Home | Search | chromium - Builders
Login

Builder Mac10.11 Tests Build 28018 Apple OSX

Results:

Failure browser_tests on (none) GPU on Mac on Mac-10.11

Trigger Info:

Projectchromium
Revision6d93874c2172b2c280b99e15fad1269c658a25fa
Got Revision6d93874c2172b2c280b99e15fad1269c658a25fa

Execution:

Steps and Logfiles:

Show:
  1. ( 0 ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. Kyle Horimoto (khorimotoohnoyoudont@google.com)
  2. Pedro Amaral (amaralpohnoyoudont@chromium.org)
  3. Caitlin Sadowski (supertriohnoyoudont@chromium.org)
  4. Ryan Sturm (ryansturmohnoyoudont@chromium.org)
  5. Dirk Pranke (dprankeohnoyoudont@chromium.org)
  6. skia-chromium-autoroll (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  7. Danyao Wang (danyaoohnoyoudont@chromium.org)
  8. Koji Ishii (kojiiohnoyoudont@chromium.org)
  9. David Dorwin (ddorwinohnoyoudont@chromium.org)
  10. catapult-chromium-autoroll (catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  11. Gang Wu (gangwuohnoyoudont@chromium.org)
  12. Yiming Zhou (uwyimingohnoyoudont@google.com)
  13. Taylor Bergquist (tbergquistohnoyoudont@chromium.org)
  14. James Cook (jamescookohnoyoudont@chromium.org)
  15. Marcin Wiacek (marcinohnoyoudont@mwiacek.com)
  16. Christopher Thompson (cthompohnoyoudont@chromium.org)
  17. Jeremy Elson (jelsonohnoyoudont@chromium.org)
  18. Dirk Pranke (dprankeohnoyoudont@chromium.org)
  19. siyua (siyuaohnoyoudont@chromium.org)
  20. Jonathan Ross (jonrossohnoyoudont@chromium.org)
  21. Qingsi Wang (qingsiohnoyoudont@google.com)
  22. Lily Houghton (lilyhoughtonohnoyoudont@chromium.org)
  23. dpapad (dpapadohnoyoudont@chromium.org)
  24. Jiawei Li (lijiaweiohnoyoudont@chromium.org)
  25. Danyao Wang (danyaoohnoyoudont@chromium.org)
  26. Scott Violet (skyohnoyoudont@chromium.org)
  27. Ryan Sleevi (rsleeviohnoyoudont@chromium.org)
  28. Brian Salomon (bsalomonohnoyoudont@google.com)
  29. Joshua Pawlicki (wafflesohnoyoudont@chromium.org)
  30. Danyao Wang (danyaoohnoyoudont@chromium.org)
  31. Saman Sami (samansohnoyoudont@chromium.org)
  32. liberato@chromium.org (liberatoohnoyoudont@chromium.org)
  33. Mikel Astiz (mastizohnoyoudont@chromium.org)
  34. danakj (danakjohnoyoudont@chromium.org)
  35. Xiaocheng Hu (xiaochenghohnoyoudont@chromium.org)
  36. Dominic Mazzoni (dmazzoniohnoyoudont@chromium.org)
  37. Chromite Chromium Autoroll (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  38. Mounir Lamouri (mlamouriohnoyoudont@chromium.org)
  39. James Cook (jamescookohnoyoudont@chromium.org)
  40. Mohamed Heikal (mheikalohnoyoudont@google.com)

Timing:

Create Thursday, 12-Jul-18 00:42:53 UTC
Start Thursday, 12-Jul-18 00:43:45 UTC
End Thursday, 12-Jul-18 01:56:18 UTC
Pending 51 secs
Execution 1 hrs 12 mins

All Changes:

  1. [CrOS MultiDevice] Tweak an EasyUnlock string description.

    Changed by Kyle Horimoto - khorimotoohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 23:09:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6d93874c2172b2c280b99e15fad1269c658a25fa

    Comments

    [CrOS MultiDevice] Tweak an EasyUnlock string description.
    
    This fix was suggested by our UX writer jonann@ in b/111006044.
    
    Bug: 824568
    Change-Id: If888000ed030b0dd90436729c77cb861a59305f9
    Reviewed-on: https://chromium-review.googlesource.com/1133710
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574396}

    Changed files

    • chrome/app/settings_strings.grdp
  2. Call generic isShowingAppMenuUpdateBadge

    Changed by Pedro Amaral - amaralpohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:08:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ffcab75a3f1d5700c92c854ca48465fa08420cbc

    Comments

    Call generic isShowingAppMenuUpdateBadge
    
    ChromeActivity should call ToolbarManager's isShowingAppMenuUpdateBadge
    so that bottom toolbar has a chance to handle it.
    
    Change-Id: I3ffdd69896ef4e3180328c33d5a5a69d21c5fdc4
    Reviewed-on: https://chromium-review.googlesource.com/1132601
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Pedro Amaral <amaralp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574395}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
  3. Fix broken link in Histograms documentation.

    Changed by Caitlin Sadowski - supertriohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:03:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38d84f451bba258746bb4ac1ee10a3cfa441997a

    Comments

    Fix broken link in Histograms documentation.
    
    Change-Id: Ie1fb9b26d0c4b5e4d767033cf50143e3b4612a3f
    Reviewed-on: https://chromium-review.googlesource.com/1134422
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Commit-Queue: Caitlin Sadowski <supertri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574394}

    Changed files

    • tools/metrics/histograms/README.md
  4. Moving Offline Previews triggering to be pre-computed

    Changed by Ryan Sturm - ryansturmohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:02:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3154b813745fb84c61dabf48dc7e75cf5d1973f9

    Comments

    Moving Offline Previews triggering to be pre-computed
    
    As part of moving previews to an earlier decision point, this CL moves
    the triggering of offline previews to be consistent with other preview
    types.
    
    Follow-up Cls will move this decision point earlier on the UI thread so
    the new offline page implementation will also be able to use it. The
    temporary dependency on PreviewsUserData will also not be needed once
    the offline tab helper is accessible (the impl is on the UI thread).
    
    Bug: 842233
    Change-Id: If2969a109434270659dcf723b39a7627bb8c8ecd
    Reviewed-on: https://chromium-review.googlesource.com/1128332
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Jian Li <jianli@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574393}

    Changed files

    • chrome/browser/offline_pages/offline_page_request_handler_unittest.cc
    • chrome/browser/offline_pages/offline_page_request_interceptor.cc
    • chrome/browser/offline_pages/offline_page_request_interceptor.h
    • chrome/browser/offline_pages/offline_page_request_job.cc
    • chrome/browser/offline_pages/offline_page_request_job.h
    • chrome/browser/previews/previews_infobar_tab_helper.cc
    • chrome/browser/previews/previews_infobar_tab_helper_unittest.cc
    • chrome/browser/profiles/profile_impl_io_data.cc
    • components/previews/content/previews_content_util.cc
    • components/previews/content/previews_content_util_unittest.cc
    • components/previews/core/previews_user_data.h
    • content/public/common/previews_state.h
    • third_party/blink/public/platform/web_url_request.h
  5. Revert "Reland "Fix OOPIF hit testing in layout tests.""

    Changed by Dirk Pranke - dprankeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:57:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 08abdaa4ff32eca88a28ab84f7da1075819c311b

    Comments

    Revert "Reland "Fix OOPIF hit testing in layout tests.""
    
    This reverts commit 3dcee047ec982d521d9ad5301e00ac1bba134f01.
    
    Reason for revert: Suspect this is causing more flaky failures, see e.g.: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/10567 and build 10568
    
    Original change's description:
    > Reland "Fix OOPIF hit testing in layout tests."
    > 
    > This is a reland of 5e93ea1955845b344d6e137195b0f27638162b06
    > 
    > Original change's description:
    > > Fix OOPIF hit testing in layout tests.
    > >
    > > If we haven't received an activated surface yet ensure that we fallback
    > > to querying the renderer for the target of input events.
    > >
    > > BUG=601584
    > >
    > > Change-Id: Id5dfcdb6bf54b98bebbd2a3b715d77202f402781
    > > Reviewed-on: https://chromium-review.googlesource.com/1131219
    > > Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    > > Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#573789}
    > 
    > TBR=kenrb@chromium.org
    > 
    > Bug: 601584
    > Change-Id: I8a2d207db79cc237e1d5e22e5e9bfffb218486c4
    > Reviewed-on: https://chromium-review.googlesource.com/1133718
    > Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    > Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574304}
    
    TBR=kenrb@chromium.org,dtapuska@chromium.org
    
    Change-Id: I9fec8992b35943f8dd2d8ce6bafe8ac9feb49411
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 601584
    Reviewed-on: https://chromium-review.googlesource.com/1134143
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574392}

    Changed files

    • content/browser/renderer_host/render_widget_host_view_base.cc
  6. Roll src/third_party/skia 4ec72f7cc745..80247e594d1f (33 commits)

    Changed by skia-chromium-autoroll - skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 22:56:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 896be1d3c7326aed2e680ed495a82e5997e5de13

    Comments

    Roll src/third_party/skia 4ec72f7cc745..80247e594d1f (33 commits)
    
    https://skia.googlesource.com/skia.git/+log/4ec72f7cc745..80247e594d1f
    
    
    git log 4ec72f7cc745..80247e594d1f --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 caryclark@skia.org Publish docs for rrect, picture, blendmode
    2018-07-11 bungeman@google.com Make CR and trailing whitespace errors.
    2018-07-11 bsalomon@google.com Reland "Make GPU cache invalidation SkMessageBus messages go to one GrContext."
    2018-07-11 bungeman@google.com Remove interal use of SkRefCnt_SafeAssign.
    2018-07-11 mtklein@chromium.org collapse parametric_{r,g,b} into parametric, remove _a and gamma_dst
    2018-07-11 herb@google.com Revert "Use new SkGlyphIDSet - v2"
    2018-07-11 bsalomon@google.com Add gltestpersistentcache config that tests GrContextOption's cache.
    2018-07-11 herb@google.com Revert "Use simple buffers instead of vectors"
    2018-07-11 bsalomon@google.com Revert "Make GPU cache invalidation SkMessageBus messages go to one GrContext."
    2018-07-11 bsalomon@google.com Make GPU cache invalidation SkMessageBus messages go to one GrContext.
    2018-07-11 herb@google.com Use simple buffers instead of vectors
    2018-07-11 halcanary@google.com Whitespace Fixup
    2018-07-11 mtklein@chromium.org also rm Perf-Debian9-GCC-GCE-CPU-AVX2-x86_64-Release-All
    2018-07-11 brianosman@google.com Only generate valid premul test data in SRGBReadWritePixels test
    2018-07-11 jvanverth@google.com Add more tests for PolyUtils
    2018-07-11 mtklein@chromium.org might as well use SkRasterPipeline::gamma too
    2018-07-11 ethannicholas@google.com fix for persistent shader cache
    2018-07-11 egdaniel@google.com Reland "Reland "Move Vulkan DebugCallback code into tools.""
    2018-07-11 timliang@google.com implemented uploading intial texture data for metal gpu backend
    2018-07-11 mtklein@chromium.org rm Perf-Win2016-MSVC-GCE-CPU-AVX2-x86_64-Release-All
    2018-07-11 robertphillips@google.com Revert "SkDEBUGF: use __VA_ARGS__"
    2018-07-11 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 a6a7842fdbf5..5c8113d3c20f (1 commits)
    2018-07-11 timliang@google.com refactored where texture descriptors are made for metal gpu backend
    2018-07-11 herb@google.com Use new SkGlyphIDSet - v2
    2018-07-11 mtklein@chromium.org use from/to_srgb
    2018-07-11 halcanary@google.com SkDEBUGF: use __VA_ARGS__
    2018-07-11 kjlubick@google.com Adventures with Skia, WASM and a JS API for Pathkit
    2018-07-11 caryclark@skia.org propogate simple angles in pathops
    2018-07-11 mtklein@google.com Reland "transform paint color to dst colorspace"
    2018-07-11 brianosman@google.com Remove clamping of kPlus with F16 configs
    2018-07-11 brianosman@google.com Remove old lazy image decoding heuristic logic
    2018-07-11 egdaniel@google.com Reland "Reland "Make GrVkBackendContext no longer derive from SkRefCnt.""
    2018-07-11 brianosman@google.com Remove unused GrPixelConfig functions
    
    
    Created with:
      gclient setdep -r src/third_party/skia@80247e594d1f
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: Ief888bfc0922b84d752987ea5ec56c4369912b14
    Reviewed-on: https://chromium-review.googlesource.com/1133871
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574391}

    Changed files

    • DEPS
  7. [Nav Experiment] Parameterize crw_web_controller_unittest.mm.

    Changed by Danyao Wang - danyaoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:53:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d6a9497984526d151d178bfe8ec9dd1b1c84597c

    Comments

    [Nav Experiment] Parameterize crw_web_controller_unittest.mm.
    
    This is so that both LegacyNavigationManagerImpl and
    WKBasedNavigationManagerImpl can be tested on trybots.
    
    Also fixed broken test setup for
    ScriptExecutionTest.UserScriptOnAppSpecificPage and
    CRWWebControllerTest.AbortNativeUrlNavigation.
    
    Bug: 862718
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ic343aafa9d1db545086fbeb001c5c9dd6253eb52
    Reviewed-on: https://chromium-review.googlesource.com/1134406
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574390}

    Changed files

    • ios/web/web_state/ui/crw_web_controller_unittest.mm
  8. [LayoutNG] Rename ShapingLineBreaker::kStartShouldBeSafe to kDontReshapeStart

    Changed by Koji Ishii - kojiiohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:50:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 65d0489cb43a7d17f1668f9178506e7a446b9a3d

    Comments

    [LayoutNG] Rename ShapingLineBreaker::kStartShouldBeSafe to kDontReshapeStart
    
    The naming turned out to be confusing.
    
    Bug: 636993
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I16fb06f080caac6ef9356edb187fe8032ef8f9ef
    Reviewed-on: https://chromium-review.googlesource.com/1133098
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574389}

    Changed files

    • third_party/blink/renderer/core/layout/ng/inline/ng_line_breaker.cc
    • third_party/blink/renderer/platform/fonts/shaping/shaping_line_breaker.cc
    • third_party/blink/renderer/platform/fonts/shaping/shaping_line_breaker.h
  9. Update XR (VR & AR) OWNERS files

    Changed by David Dorwin - ddorwinohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:49:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bcd11ade1174730bcc35ee5f8d71960c5a6a4794

    Comments

    Update XR (VR & AR) OWNERS files
    
    Switch COMPONENT to new structure, update and alphabetize owners, and
    add missing fields.
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:closure_compilation;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I5141932b33a41d3aeaad1cc053623f12422e277e
    Reviewed-on: https://chromium-review.googlesource.com/1121097
    Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
    Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
    Reviewed-by: Brandon Jones <bajones@chromium.org>
    Reviewed-by: Ian Vollick <vollick@chromium.org>
    Reviewed-by: Bill Orr <billorr@chromium.org>
    Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Commit-Queue: David Dorwin <ddorwin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574388}

    Changed files

    • chrome/android/java/res_vr/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr_shell/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VR_JAVA_OWNERS
    • chrome/browser/android/vr/OWNERS
    • chrome/browser/android/vr/arcore_device/OWNERS
    • chrome/browser/resources/vr/OWNERS
    • chrome/browser/vr/OWNERS
    • chrome/browser/vr/service/OWNERS
    • chrome/browser/vr/vector_icons/OWNERS
    • chrome/test/data/vr/OWNERS
    • chrome/test/vr/OWNERS
    • device/vr/OWNERS
    • device/vr/oculus/OWNERS
    • device/vr/openvr/OWNERS
    • device/vr/public/mojom/OWNERS
    • third_party/WebKit/LayoutTests/external/wpt/webvr/OWNERS
    • third_party/WebKit/LayoutTests/external/wpt/webxr/OWNERS
    • third_party/arcore-android-sdk/OWNERS
    • third_party/blink/renderer/modules/vr/OWNERS
    • third_party/blink/renderer/modules/xr/OWNERS
    • third_party/gvr-android-keyboard/OWNERS
    • third_party/gvr-android-keyboard/com/google/vr/keyboard/OWNERS
    • third_party/gvr-android-sdk/OWNERS
    • third_party/libovr/OWNERS
    • third_party/openvr/OWNERS
    • tools/perf/contrib/vr_benchmarks/OWNERS
  10. Roll src/third_party/catapult 5c0d851abe6e..1af68170e543 (2 commits)

    Changed by catapult-chromium-autoroll - catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 22:44:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 720dadbc215c229ce100bc408edb3aee03b0697e

    Comments

    Roll src/third_party/catapult 5c0d851abe6e..1af68170e543 (2 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/5c0d851abe6e..1af68170e543
    
    
    git log 5c0d851abe6e..1af68170e543 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 simonhatch@chromium.org Dashboard - Use oauth scopes for /add_histograms
    2018-07-11 simonhatch@chromium.org Dashboard - Add some timing around /add_histograms
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@1af68170e543
    
    The AutoRoll server is located here: https://catapult-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:862730,chromium:862666
    TBR=sullivan@chromium.org
    
    Change-Id: If4b4e810ef8ae28ad68c15848c6aebe5ccc3fb56
    Reviewed-on: https://chromium-review.googlesource.com/1133869
    Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574387}

    Changed files

    • DEPS
  11. [Feed] Feed Storage Initialization

    Changed by Gang Wu - gangwuohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:44:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 74b454af56f3e14b18880854866b9b0d0b1f2a13

    Comments

    [Feed] Feed Storage Initialization
    
    Implement feed storage initialization in C++.
    
    Bug:828938
    
    Change-Id: I33a5a9e2e7dd20c36ec945feab6ea9932e9d94a2
    Reviewed-on: https://chromium-review.googlesource.com/1121834
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Commit-Queue: Gang Wu <gangwu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574386}

    Changed files

    • chrome/browser/android/feed/feed_host_service_factory.cc
    • components/feed/core/feed_host_service.cc
    • components/feed/core/feed_host_service.h
    • components/feed/core/feed_storage_database.cc
    • components/feed/core/feed_storage_database.h
  12. Introducing improvements for the Action Recorder Extension.

    Changed by Yiming Zhou - uwyimingohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 22:41:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 856e676d5e063bce97d01d06311b517f6b9e108c

    Comments

    Introducing improvements for the Action Recorder Extension.
    
    1. Improved the xpath generator. The generator will produce even more concise xpaths. This improvement helps to make test recipes readable to humans.
    2. Changed the way the extension queries for an iframe's context. Prior to this change, the extension would construct a path from the iframe to the top level frame by making a query at each ancestor frame node. However, InProcessBrowserTest does not need a path to go from the top level frame to a descendant iframe. Therefore, in this change the extension only makes one query at the parent frame node.
    3. Moved the frame context query action to the front of the start recording workflow. This move cuts one message roundtrip from the extension's background script to the extension's content script.
    4. Made the extension jot down a target element's visibility state when recording an action. Prior to this change, the extension assumes that every target element is visible, enabled and on the top of the page. However, the extension's complex action recording logic sometimes catches actions on invisible or partially obscured elements.
    5. Added refined logic to the extension to distinguish between a user typing action and a Chrome autofill action. Prior to this change the extension simply assumes that Chrome always autofills every autofill-able field. If a user types inside an autofillable field, the extension will mistakenly record an autofill action. With this change the extension uses keyboard events to detect when a user types inside a field, eliminating the false positive.
    6. Began implementing new features to capture Chrome Password Manager actions.
    
    Bug: 855284
    Change-Id: Ic7ff3af95cdc9f308c3ad061a3506fced150b4f8
    Reviewed-on: https://chromium-review.googlesource.com/1132540
    Commit-Queue: Yiming Zhou <uwyiming@google.com>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574385}

    Changed files

    • components/test/data/autofill/automated_integration/action_recorder_extension/background/background.js
    • components/test/data/autofill/automated_integration/action_recorder_extension/constants.js
    • components/test/data/autofill/automated_integration/action_recorder_extension/content/action_handler.js
  13. Bandaid detached tabs at 150% scale

    Changed by Taylor Bergquist - tbergquistohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:40:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c18d19908d8817f4057df5e50afc966d92a25701

    Comments

    Bandaid detached tabs at 150% scale
    
    At some dpi scales (150% for example), the tabs are drawn detached from
    the toolbar, with a stark one-pixel gap between the tabs and the
    toolbar.
    
    This CL draws one extra dip's worth of tab below the bottom of the tab,
    which is occluded by the toolbar at integral scales and fills the gap
    on non-integral scales.
    
    
    Bug: 848106
    Change-Id: Ib465e8886c49613916bf3f3faff5fc43f36dfb18
    Reviewed-on: https://chromium-review.googlesource.com/1121386
    Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574384}

    Changed files

    • chrome/browser/ui/layout_constants.cc
    • chrome/browser/ui/layout_constants.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_unittest.cc
    • chrome/browser/ui/views/frame/browser_view_layout.cc
    • chrome/browser/ui/views/frame/browser_view_unittest.cc
    • chrome/browser/ui/views/tabs/new_tab_button.cc
    • chrome/browser/ui/views/tabs/tab.cc
  14. Fix crash in shortcut viewer with ChromeVox enabled

    Changed by James Cook - jamescookohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:38:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f74145f76fd3c4d8c1b4d024f34cf24189350d2

    Comments

    Fix crash in shortcut viewer with ChromeVox enabled
    
    Views can trigger accessibility events during Widget construction
    before the AXRemoteHost starts monitoring the widget. This happens
    with the material design focus ring on text fields.
    
    Bug: 862759
    Test: added to views_mus_unittests
    Change-Id: Ib7de6aa1d09b17fb65ad350abd362ad26b0454ae
    Reviewed-on: https://chromium-review.googlesource.com/1134353
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574383}

    Changed files

    • ui/views/mus/ax_remote_host.cc
    • ui/views/mus/ax_remote_host_unittest.cc
  15. @IntDef cleanup in browser/java/appmenu

    Changed by Marcin Wiacek - marcinohnoyoudont@mwiacek.com
    Changed at Wednesday, 11-Jul-18 22:34:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5d0c1419ced881ae3321b7c6e3f23bbcacde473a

    Comments

    @IntDef cleanup in browser/java/appmenu
    
    @IntDef/@StringDef annotation are preferred way for declaring
    set of String/int values:
    
    1. they need less space in APK than enum, see
    https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
    2. they give more control over allowed values than "static final" values
    
    Main goal of patch is writing "static final" values, enum
    and some classes in one common @IntDef/@StringDef form:
    
    1. with @IntDef/@StringDef first, @Retention second
       and related @interface third
    2. with values inside @interface
    3. with NUM_ENTRIES declaring number of entries if necessary
    4. with comment about numbering from 0 without gaps when necessary
    5. with @Retention(RetentionPolicy.SOURCE)
    6. without "static final" in the @interface
    
    Additionally there are done some other trivial cleanups.
    
    Change-Id: Ie6b59c0f1a8ec6fe50d3177619f0768798f97508
    Reviewed-on: https://chromium-review.googlesource.com/1128092
    Commit-Queue: Marcin WiÄ…cek <marcin@mwiacek.com>
    Commit-Queue: Theresa <twellington@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574382}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java
    • chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java
  16. Add metrics tracking how long Page Info is open

    Changed by Christopher Thompson - cthompohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:29:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0c4e06c2d21cc9a69f0a2a871a873b30c12b8fee

    Comments

    Add metrics tracking how long Page Info is open
    
    Per a suggestion of martinshelton@, this adds a new set of histograms to
    track how long users have the Page Info bubble open. This will help us
    better understand users who open Page Info but take no actions in it
    (e.g., are these opens likely to be more accidental or incidental).
    
    This metric is split by the security level of the page to allow us to
    see differences between different security indicators. Two sub-histograms
    ("Action" and "NoAction") further split up the metric by whether the user
    performed an action in the Page Info bubble before closing it (including
    actions that cause the bubble to close).
    
    Bug: 859116
    Change-Id: I630a1f37ecff13bc7ee44b3e8e5a5c34337c9267
    Reviewed-on: https://chromium-review.googlesource.com/1096336
    Commit-Queue: Christopher Thompson <cthomp@chromium.org>
    Reviewed-by: Steven Holte <holte@chromium.org>
    Reviewed-by: Emily Stark <estark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574381}

    Changed files

    • chrome/browser/ui/page_info/page_info.cc
    • chrome/browser/ui/page_info/page_info.h
    • chrome/browser/ui/page_info/page_info_unittest.cc
    • tools/metrics/histograms/histograms.xml
  17. Allow optimization hints to be marked as experimental.

    Changed by Jeremy Elson - jelsonohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:28:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c8940b1c9de6fb2951013a8d2bb78770e62598b7

    Comments

    Allow optimization hints to be marked as experimental.
    
    Experimental hints are tagged (in the Optimization proto) with an
    experiment name. Experimental hints are not enabled unless an
    experiment with a matching name is enabled. Experiments are enabled by
    turning on the new base::Feature called kOptimizationHintsExperiments,
    with the name of the experiment in a parameter called experiment_name.
    
    Bug: 831817
    Change-Id: I6141c70f8f3a8f9adb2c9772b747ee2a0c59b227
    Reviewed-on: https://chromium-review.googlesource.com/1132491
    Commit-Queue: Jeremy Elson <jelson@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574380}

    Changed files

    • components/optimization_guide/proto/hints.proto
    • components/previews/content/previews_hints.cc
    • components/previews/content/previews_optimization_guide_unittest.cc
    • components/previews/core/previews_features.cc
    • components/previews/core/previews_features.h
  18. Reland "[sampling heap profiler] Support stack collection on Android"

    Changed by Dirk Pranke - dprankeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:26:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0a3c0496180f1a183b3ca8061440d3888ff0722a

    Comments

    Reland "[sampling heap profiler] Support stack collection on Android"
    
    This reverts commit db0cac4eafdcc6cbd13e19eacc3eba15c15bfa2c.
    
    Reason for revert: The revert didn't affect anything, so re-landing.
    
    Original change's description:
    > Revert "[sampling heap profiler] Support stack collection on Android"
    > 
    > This reverts commit 52601a565375e7e60fdee70568f5e85242b76441.
    > 
    > Reason for revert: Speculatively reverting to see if this is confusing crashpad on the Mac somehow. See crbug.com/862466.
    > 
    > Original change's description:
    > > [sampling heap profiler] Support stack collection on Android
    > > 
    > > BUG=803276
    > > 
    > > Change-Id: I60d7925104b8614aa68c135d52f6089a76675d22
    > > Reviewed-on: https://chromium-review.googlesource.com/1128630
    > > Reviewed-by: Siddhartha S <ssid@chromium.org>
    > > Commit-Queue: Alexei Filippov <alph@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#573880}
    > 
    > TBR=alph@chromium.org,ssid@chromium.org
    > 
    > Change-Id: Ie7b4f8b20cd5526420ef836d3a21dda27d4090bb
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 803276
    > Reviewed-on: https://chromium-review.googlesource.com/1132357
    > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    > Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574032}
    
    TBR=dpranke@chromium.org,alph@chromium.org,ssid@chromium.org
    
    Change-Id: I41392b0836e75c25ae6b0b9aa243daeef95b6ee7
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 803276
    Reviewed-on: https://chromium-review.googlesource.com/1134142
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574379}

    Changed files

    • base/sampling_heap_profiler/sampling_heap_profiler.cc
    • base/sampling_heap_profiler/sampling_heap_profiler.h
  19. Add intermediate bubble UI for local card migration flow.

    Changed by siyua - siyuaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:25:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59f08db6b91e0572161cf98df942b70c3becc285

    Comments

    Add intermediate bubble UI for local card migration flow.
    
    This is the 1st CL adding new views. There will be three following CLs
    on Autofill Client change, unit-test and metrics, and cocoa implementation.
    
    For details, please refer to design doc go/ib-paradise.
    
    This project is to offer users an option to upload chrome local credit
    cards to Google Pay server. This bubble UI is the entry point of the entire
    flow. It should be anchored to a credit card icon in the location bar and
    be shown from it.
    
    Bug: 852904
    Change-Id: Iadc4667598fc0a90a81c23658185045a5aecda8a
    Reviewed-on: https://chromium-review.googlesource.com/1128569
    Commit-Queue: Siyu An <siyua@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574378}

    Changed files

    • chrome/app/chrome_command_ids.h
    • chrome/app/generated_resources.grd
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/autofill/local_card_migration_bubble.h
    • chrome/browser/ui/autofill/local_card_migration_bubble_controller_impl.cc
    • chrome/browser/ui/autofill/local_card_migration_bubble_controller_impl.h
    • chrome/browser/ui/browser_window.h
    • chrome/browser/ui/cocoa/browser_window_cocoa.h
    • chrome/browser/ui/cocoa/browser_window_cocoa.mm
    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
    • chrome/browser/ui/location_bar/location_bar.h
    • chrome/browser/ui/view_ids.h
    • chrome/browser/ui/views/autofill/local_card_migration_bubble_views.cc
    • chrome/browser/ui/views/autofill/local_card_migration_bubble_views.h
    • chrome/browser/ui/views/autofill/local_card_migration_icon_view.cc
    • chrome/browser/ui/views/autofill/local_card_migration_icon_view.h
    • chrome/browser/ui/views/frame/browser_view.cc
    • chrome/browser/ui/views/frame/browser_view.h
    • chrome/browser/ui/views/location_bar/location_bar_view.cc
    • chrome/browser/ui/views/location_bar/location_bar_view.h
    • chrome/test/base/test_browser_window.cc
    • chrome/test/base/test_browser_window.h
    • components/autofill/core/browser/ui/local_card_migration_bubble_controller.h
    • components/autofill_strings.grdp
  20. Disable SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest on Viz

    Changed by Jonathan Ross - jonrossohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:24:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99b62af5a66207b0fe84080bdd23492471a9ba94

    Comments

    Disable SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest on Viz
    
    Apparently this test can still fail on Windows. So re-disabling it until it can be investigated further.
    
    TBR=fsamuel@chromium.org
    TEST=SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest
    
    Bug: 848825
    Change-Id: I00828a10cfd5c8c111b30f61eb5d8acbf57da2ea
    Reviewed-on: https://chromium-review.googlesource.com/1133875
    Reviewed-by: Jonathan Ross <jonross@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574377}

    Changed files

    • testing/buildbot/filters/viz.android.content_browsertests.filter
    • testing/buildbot/filters/viz.content_browsertests.filter
  21. Add the target for overrides of metrics utilities in jingle_unittests.

    Changed by Qingsi Wang - qingsiohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 22:24:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 50c4d834c41b8f1ae60ae80bc47d67a51dcb23bd

    Comments

    Add the target for overrides of metrics utilities in jingle_unittests.
    
    The target rtc_p2p from WebRTC, transitively depended on by
    jingle_unittests via the target webrtc_overrides, will soon depend on
    the implementation of RTC_HISTOGRAM_* macros in WebRTC.
    
    Bug: webrtc:9409
    Change-Id: I1f2bf0776d2f7c18c9585fb15d7251f8128ce175
    Reviewed-on: https://chromium-review.googlesource.com/1134183
    Commit-Queue: Qingsi Wang <qingsi@google.com>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574376}

    Changed files

    • jingle/BUILD.gn
  22. Remove NetworkContextTest.PreconnectLessThanZero

    Changed by Lily Houghton - lilyhoughtonohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:23:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fe8c7d594e193f0dbdf6e3b7c970e44bee9c5c5c

    Comments

    Remove NetworkContextTest.PreconnectLessThanZero
    
    This test is flaky on android bots, and given that its testing something that
    should be explicitly unsupported (passing a negative number to a uint parameter),
    I think it's worth removing for now.
    
    Bug: 862647
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I316cb2cc5979aefb7335f715bd1fd2655db097b3
    Reviewed-on: https://chromium-review.googlesource.com/1134206
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: Lily Houghton <lilyhoughton@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574375}

    Changed files

    • services/network/network_context_unittest.cc
  23. Settings WebUI: Also look for no-search CSS attribute, if noSearch is false.

    Changed by dpapad - dpapadohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:22:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6ab1508513baf70561ebe2289ca48030f3fca81a

    Comments

    Settings WebUI: Also look for no-search CSS attribute, if noSearch is false.
    
    At r573968 the logic was modified to only look for the noSearch property for
    subpage wrappers. It should also look for the CSS attribute for the case where
    no-search is not part of a binding.
    
    Bug: 862517
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Id3f5dbcd86f931cce71f2e3c8a784780f5b34be6
    Reviewed-on: https://chromium-review.googlesource.com/1133683
    Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
    Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574374}

    Changed files

    • chrome/browser/resources/settings/search_settings.js
    • chrome/test/data/webui/settings/search_settings_test.js
  24. [Chromecast] Chromecast support for tap down gestures

    Changed by Jiawei Li - lijiaweiohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:20:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 06e3ca5865cd84108599d13d143b5f230cef145f

    Comments

    [Chromecast] Chromecast support for tap down gestures
    
    - TAP_DOWN is added to CastContentWindow::GestureType
    - The gesture detection is attached to the root window and handles
      tap down events. A new JS binding API: onTapDownHandler will be hosted on
      platform
    - HandleTapGesture: finger is released after pressed within tap timeout window
      HandleTapDownGesture: finger is pressed
    
    Bug: internal b/75979846
    Test: build manually and test whether both tap and tap down handler callback works
    Change-Id: Iaefa6df9c7a5284ba27964083fc056bf36cf480a
    Reviewed-on: https://chromium-review.googlesource.com/1115418
    Reviewed-by: Luke Halliwell <halliwell@chromium.org>
    Commit-Queue: Jiawei Li <lijiawei@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574373}

    Changed files

    • chromecast/browser/cast_content_window.h
    • chromecast/browser/cast_content_window_aura.cc
    • chromecast/browser/cast_content_window_aura.h
    • chromecast/browser/cast_gesture_dispatcher.cc
    • chromecast/browser/cast_gesture_dispatcher.h
    • chromecast/graphics/cast_gesture_handler.h
    • chromecast/graphics/cast_system_gesture_event_handler.cc
  25. [Nav Experiment] Make WebStateImplTest parameterized.

    Changed by Danyao Wang - danyaoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:19:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 00ee7c4ed5ad09f68465f8e73c89639217adfacf

    Comments

    [Nav Experiment] Make WebStateImplTest parameterized.
    
    This way both legacy and WK based navigation manager implementations are
    tested on trybots.
    
    Fixed incorrect test setup in ShowAndClearInterstitialWithNoCommittedItems.
    Disabled ShowAndClearInterstitialWithCommittedItem and
    ShowAndClearInterstitialWithoutChangingSslStatus because they require
    mocking out navigation state, which is not possible now.
    
    Bug: 862718
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Id72d1c2837aba7c1ed53f4fd8623e8c286a4a0a2
    Reviewed-on: https://chromium-review.googlesource.com/1134086
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574372}

    Changed files

    • ios/web/web_state/web_state_impl_unittest.mm
  26. chromeos: fix infinite loop in cursor lookup

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:17:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1d9f316a0ba47bb4be158db0de5edc596272dabe

    Comments

    chromeos: fix infinite loop in cursor lookup
    
    And remove a NOTREACHED that we're hitting. I will supply a test for this
    separate, as well as investgating removal of NOREACHED.
    
    BUG=855767
    TEST=none
    
    Change-Id: Idf59b80388fefa06317a70055d18db995187c9a0
    Reviewed-on: https://chromium-review.googlesource.com/1134352
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574371}

    Changed files

    • services/ui/ws2/window_delegate_impl.cc
    • services/ui/ws2/window_delegate_impl.h
  27. Support disabling the remainder of the Symantec Legacy PKI

    Changed by Ryan Sleevi - rsleeviohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:16:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c671bf913c328f7788df5046dd7b81bee3e17a04

    Comments

    Support disabling the remainder of the Symantec Legacy PKI
    
    Introduce a base::Feature flag that controls how the
    remainder of the Symantec Legacy PKI - that is, certs
    issued on/after 2016-06-01 but before 2017-12-01 - are
    handled.
    
    Bug: 796230
    Change-Id: Iebe9976ace0dfcdfd02f844fdaf497cf67dde704
    Reviewed-on: https://chromium-review.googlesource.com/1134037
    Reviewed-by: David Benjamin <davidben@chromium.org>
    Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574370}

    Changed files

    • net/cert/cert_verify_proc.cc
    • net/cert/cert_verify_proc.h
    • net/cert/cert_verify_proc_unittest.cc
  28. Reland "Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest."

    Changed by Brian Salomon - bsalomonohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 22:15:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 23370775c415c21f4de1c7d97dd5645fe2b7e818

    Comments

    Reland "Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest."
    
    This is a reland of 841c0dde5461c763fdd524c2078aafaf241444aa
    
    The updated change uses window.devicePixelRatio to determine the inset.
    It also accounts for the absolute position used by the "WithDivs"
    variations of this test. One additional device pixel of offset is used
    to make this pass on mac_chromium_rel_ng. This is probably necessary
    because either window.devicePixelRatio reports 1 incorrectly or the
    edge antialiasing covers slightly more than one pixel. This wasn't
    investigated.
    
    Original change's description:
    > Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest.
    >
    > Skia currently has a driver workaround that performans antialiased
    > rectangle edge equation evalution in the fragment shader rather than
    > vertex shader on Adreno 3xx GPUs. This was done because the interpolation
    > of values computed in the vertex shader lacks enough precision to pass
    > these tests. However, doing so has a negative performance impact. Skia
    > tests run with the workaround removed show that in practice the visual
    > difference is insignificant. Moreover, cc::GLRenderer also incurs these
    > same errors as it uses the same antialiasing approach without the
    > workaround and has shipped on Adreno 3xx devices for years with no known
    > complaints about antialiasing quality/accuracy. We're better off
    > reclaiming the performance and accepting a small hit to antialiasing
    > accuracy.
    >
    > Bug: 847984
    > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    > Change-Id: If1e62e0780a752179a75ddd57ccc7b24128c68ac
    > Reviewed-on: https://chromium-review.googlesource.com/1129041
    > Reviewed-by: Kenneth Russell <kbr@chromium.org>
    > Commit-Queue: Brian Salomon <bsalomon@google.com>
    > Cr-Commit-Position: refs/heads/master@{#573695}
    
    Bug: 847984
    Change-Id: Ie5e685e8d5e0afbcf4c54ea3186ee68d238464ba
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Reviewed-on: https://chromium-review.googlesource.com/1132574
    Commit-Queue: Brian Salomon <bsalomon@google.com>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574369}

    Changed files

    • content/test/gpu/gpu_tests/screenshot_sync_integration_test.py
  29. Reland "Add method "ConfirmSaveAutofillProfile" to AutofillClient."

    Changed by Joshua Pawlicki - wafflesohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:15:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 76e9e78757733e56983b4b6c9ac5b13fdc21db8b

    Comments

    Reland "Add method "ConfirmSaveAutofillProfile" to AutofillClient."
    
    This reverts commit 560191224bcaf8390e0745a16bdf8975a1add6bf.
    
    Reason for revert: Patch still applies cleanly without prior change.
    
    Original change's description:
    > Revert "Add method "ConfirmSaveAutofillProfile" to AutofillClient."
    >
    > This reverts commit da5ab5f6853c93ea08fe428db7dd22abe62db7d7.
    >
    > Reason for revert: compile failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux/55639
    >
    > Original change's description:
    > > Add method "ConfirmSaveAutofillProfile" to AutofillClient.
    > >
    > > This method will allow clients to decide if they want to
    > > save autofill profiles. //ios/web_view may choose to not
    > > save autofill profiles under some conditions.
    > > For all other autofill_clients, save like usual.
    > >
    > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    > > Change-Id: I33764384ba931c5eb0bb4f3de3810be2f64c70bf
    > > Reviewed-on: https://chromium-review.googlesource.com/1074269
    > > Commit-Queue: John Wu <jzw@chromium.org>
    > > Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    > > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    > > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    > > Reviewed-by: Bo <boliu@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#574310}
    >
    > TBR=boliu@chromium.org,mathp@chromium.org,sebsg@chromium.org,mahmadi@chromium.org,jzw@chromium.org
    >
    > Change-Id: I570967926d1f38e675aa9980a9a5181e6270bb2d
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    > Reviewed-on: https://chromium-review.googlesource.com/1134139
    > Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    > Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574326}
    
    TBR=boliu@chromium.org,mathp@chromium.org,waffles@chromium.org,sebsg@chromium.org,mahmadi@chromium.org,jzw@chromium.org
    
    Change-Id: I6ed0526b444574a5e8419ea83a37e348dc97cd11
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Reviewed-on: https://chromium-review.googlesource.com/1134141
    Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
    Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574368}

    Changed files

    • android_webview/browser/aw_autofill_client.cc
    • android_webview/browser/aw_autofill_client.h
    • chrome/browser/ui/autofill/chrome_autofill_client.cc
    • chrome/browser/ui/autofill/chrome_autofill_client.h
    • components/autofill/core/browser/autofill_client.h
    • components/autofill/core/browser/autofill_merge_unittest.cc
    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc
    • components/autofill/core/browser/test_autofill_client.cc
    • components/autofill/core/browser/test_autofill_client.h
    • ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
    • ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
    • ios/web_view/internal/autofill/web_view_autofill_client_ios.h
    • ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
  30. [Nav Experiment] Add a wait after restore session.

    Changed by Danyao Wang - danyaoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:14:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bcae87b0c7618e2fc61f78a073cf5589fe9679bd

    Comments

    [Nav Experiment] Add a wait after restore session.
    
    This fixes WebViewRestorableStateTest when WKBasedNavigationManger is
    enabled. A better approach would be to turn this test into a
    programmatic test so both navigation managers implementations are
    tested, but web::features symbols are not exposed in ios/web_view.
    
    Bug: 862714
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I19916a973b566fac32c8995bd199784f0c846a1e
    Reviewed-on: https://chromium-review.googlesource.com/1134046
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574367}

    Changed files

    • ios/web_view/test/web_view_restorable_state_inttest.mm
  31. Check DrawQuad is given a valid pointer to SharedQuadState

    Changed by Saman Sami - samansohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:13:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision af0b9e0ea205364f81579ede827a19acecfb6ee8

    Comments

    Check DrawQuad is given a valid pointer to SharedQuadState
    
    Bug: 852294
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    Change-Id: Iea27ee973f337f833b31a8c18e002b2772f7bacb
    Reviewed-on: https://chromium-review.googlesource.com/1133579
    Reviewed-by: Fady Samuel <fsamuel@chromium.org>
    Commit-Queue: Saman Sami <samans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574366}

    Changed files

    • components/viz/common/quads/draw_quad.cc
  32. Don't make MCVD textures unrenderable.

    Changed by liberato@chromium.org - liberatoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:12:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 00c9a8cb21b0bd26037458b9ebe1d94a8b3204f1

    Comments

    Don't make MCVD textures unrenderable.
    
    Previously, we would make MCVD video frame textures unrenderable
    after the VideoFrame was destroyed and the sync token had cleared.
    This prevented the image from holding onto MediaCodec buffers
    unnecessarily, since the actual destruction of the texture might
    be delayed until the GL context was made current.
    
    However, it turns out that the sync token isn't always correct.
    If the VideoResourceUpdater is destroyed, then it immediately
    releases all VideoFrames with whatever sync token they have,
    without waiting for viz to return the resources (and a new sync
    token!).  This shows up during tests quite a bit.
    
    Ideally, it would wait.  However, that's nontrivial and likely has
    other side-effects.
    
    This CL frees the MediaCodec buffers when the sync token clears,
    but doesn't actually disconnect the CodecImage from the texture.
    So, any existing frame will remain renderable.  If the image hadn't
    been rendered yet, then it will render the most recently rendered
    one, which is still a race.  However, in practice, it works.
    
    Bug: 858826
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Ia09b00a68964e886a05acf19f3623b4c87c31115
    Reviewed-on: https://chromium-review.googlesource.com/1132115
    Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    Commit-Queue: Frank Liberato <liberato@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574365}

    Changed files

    • media/gpu/android/codec_image.cc
    • media/gpu/android/codec_image.h
    • media/gpu/android/codec_image_group.cc
    • media/gpu/android/codec_image_group_unittest.cc
    • media/gpu/android/texture_pool.cc
    • media/gpu/android/texture_pool.h
    • media/gpu/android/texture_pool_unittest.cc
    • media/gpu/android/video_frame_factory_impl.cc
    • media/gpu/android/video_frame_factory_impl.h
  33. Introduce BlockingModelTypeStore[Impl]

    Changed by Mikel Astiz - mastizohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:12:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3cfab37a6906e7d897ad16e9260cf5818323f247

    Comments

    Introduce BlockingModelTypeStore[Impl]
    
    The class is analogous to the non-blocking ModelTypeStore, which exposes
    an asynchronous API.
    
    The new class is intended to be used by datatypes that don't need to
    live in the UI thread, and are instead fine to live in a background
    thread, namely a sequenced task runner enforced by
    BlockingModelTypeStore.
    
    Users must use that sequenced task runner, because the underlying
    (shared) LevelDB database lives there, and is not thread-safe.
    
    The result of this refactoring introduces a minor behavioral change
    which is in fact an improvement: there is now one extra hop between
    threads when reading metadata, which is also the reason why some
    tests need to be updated.
    
    TBR=markusheintz@chromium.org
    
    Bug: 861632
    Change-Id: I5db552adc42c48fc36da6378c1d7f61334f1f450
    Reviewed-on: https://chromium-review.googlesource.com/1129800
    Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574364}

    Changed files

    • components/consent_auditor/consent_sync_bridge_impl_unittest.cc
    • components/sync/BUILD.gn
    • components/sync/model/blocking_model_type_store.h
    • components/sync/model/model_type_store.cc
    • components/sync/model/model_type_store.h
    • components/sync/model/model_type_store_base.cc
    • components/sync/model/model_type_store_base.h
    • components/sync/model_impl/blocking_model_type_store_impl.cc
    • components/sync/model_impl/blocking_model_type_store_impl.h
    • components/sync/model_impl/model_type_store_backend.cc
    • components/sync/model_impl/model_type_store_backend.h
    • components/sync/model_impl/model_type_store_impl.cc
    • components/sync/model_impl/model_type_store_impl.h
    • components/sync/user_events/user_event_sync_bridge_unittest.cc
  34. Fix the type of the end text selection handle

    Changed by danakj - danakjohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:11:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5469c6437a9600862ba63c6abcd30dbc87c8f02

    Comments

    Fix the type of the end text selection handle
    
    Due to copy paste mistakes, the end handle ended up being the same type
    as the start handle, but it should be the opposite type.
    
    R=chrishtr@chromium.org
    
    Bug: 862510
    Change-Id: I2e6609d1e4083ced5f92b563925ba8c8401964fa
    Reviewed-on: https://chromium-review.googlesource.com/1133681
    Reviewed-by: Jeremy Roman <jbroman@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Commit-Queue: danakj <danakj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574363}

    Changed files

    • third_party/blink/renderer/core/exported/web_view_test.cc
    • third_party/blink/renderer/core/frame/frame_test_helpers.cc
    • third_party/blink/renderer/core/frame/frame_test_helpers.h
    • third_party/blink/renderer/core/page/chrome_client_impl.cc
    • third_party/blink/renderer/core/page/chrome_client_impl_test.cc
    • third_party/blink/renderer/core/page/page_overlay_test.cc
    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/testing/stub_graphics_layer_client.h
  35. Make bidi adjustment in auto-directioned paragraphs saner

    Changed by Xiaocheng Hu - xiaochenghohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:11:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2b245c2e812b84d4e58b76dbc0fd6bb14b5d257e

    Comments

    Make bidi adjustment in auto-directioned paragraphs saner
    
    In bidi adjustment for legacy layout, there is a hack that stops any
    adjustment if current text box is in 'unicode-bidi: plaintext'. This
    is wrong if the auto-directioned paragraph still contains
    bidirectional text.
    
    Ideally, we should remove this hack, and check paragraph direction.
    However, we don't have a reliable way to do this in legacy layout.
    So this patch makes the hack slightly saner that, bidi adjustment
    shouldn't stop as long as we are at a bidi boundary, even if we are
    in 'unicode-bidi: plaintext'.
    
    Bug: 861559
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Ie7e1f704b976adf28a5d143e8265a499af0d62e4
    Reviewed-on: https://chromium-review.googlesource.com/1132472
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574362}

    Changed files

    • third_party/blink/renderer/core/editing/inline_box_traversal.cc
    • third_party/blink/renderer/core/editing/selection_modifier_character_test.cc
  36. Simple rename in BrowserAccessibilityCocoa.

    Changed by Dominic Mazzoni - dmazzoniohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:09:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 72bfd2dc3d3fa59a925d66978ae2acffffd4dfc6

    Comments

    Simple rename in BrowserAccessibilityCocoa.
    
    The BrowserAccessibilityCocoa (Objective-C Object for macOS) often
    needs to ask its corresponding BrowserAccessibility (cross-platform
    C++ object). Rather than calling it browserAccessibility or
    browserAccessibility_, let's call it "owner".
    
    I'm open to other names, but this is pretty limited to this one
    file so anyone hacking on this file should figure it out
    pretty quickly.
    
    Bug: none
    Change-Id: I36a5503ff53196b0c1e17bd405307d5471f9bd06
    Reviewed-on: https://chromium-review.googlesource.com/1132142
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574361}

    Changed files

    • content/browser/accessibility/browser_accessibility_cocoa.h
    • content/browser/accessibility/browser_accessibility_cocoa.mm
    • content/browser/accessibility/browser_accessibility_mac_unittest.mm
    • content/browser/accessibility/browser_accessibility_manager_mac.mm
  37. Roll src/third_party/chromite 0664f1210277..a3bc29bcacf3 (6 commits)

    Changed by Chromite Chromium Autoroll - chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 22:05:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f83ad3fa1e9af7b2a8d4a51863fc2abb0e121de

    Comments

    Roll src/third_party/chromite 0664f1210277..a3bc29bcacf3 (6 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/0664f1210277..a3bc29bcacf3
    
    
    git log 0664f1210277..a3bc29bcacf3 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 vapier@chromium.org validation_pool: process private/draft CLs before filtering
    2018-07-11 dgarrett@google.com cbuildbot_launch: Pass --workspace to cbuildbot.
    2018-07-11 xixuan@chromium.org Skylab-launch: Remove hard-coded build for SkylabHWTestStage.
    2018-07-11 xixuan@chromium.org HWTestSkylab: Add luci tag for skylab suite jobs.
    2018-07-11 dgarrett@google.com chromeos_config: Move master-chromium-pfq to chromeos waterfall.
    2018-07-11 dgarrett@chromium.org Revert "chrome_committer: Remove committer email argument."
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@a3bc29bcacf3
    
    The AutoRoll server is located here: https://chromite-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: Ie16ad6bc99dfb42886e1eaad6e06bafe2cd7726d
    Reviewed-on: https://chromium-review.googlesource.com/1133864
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574360}

    Changed files

    • DEPS
  38. MediaButtonReceiver: log key code from event received in intent.

    Changed by Mounir Lamouri - mlamouriohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:05:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2c5680ed55a6960e03ec7aaaa13d52adab56d754

    Comments

    MediaButtonReceiver: log key code from event received in intent.
    
    Forgot to upload the change as part of https://chromium-review.googlesource.com/c/chromium/src/+/1133741
    
    Bug: None
    Change-Id: Icb1f99c0d45928840740abef161c513d661d01af
    Reviewed-on: https://chromium-review.googlesource.com/1134179
    Reviewed-by: Min Qin <qinmin@chromium.org>
    Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574359}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaButtonReceiver.java
  39. mash: Fix crash when opening network menu in system tray

    Changed by James Cook - jamescookohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:03:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 62eee33ef5ebff05c7d26f7ee545199d27e01adb

    Comments

    mash: Fix crash when opening network menu in system tray
    
    Change a check for MASH_DEPRECATED to IsAshInBrowserProcess, since the
    relevant ash-to-chrome delegate hasn't been ported to mash yet.
    
    Bug: none
    Test: chrome --enable-features=Mash and open network menu
    Change-Id: Ic5013ec84590814d964159acea66f8cab26ba5cd
    Reviewed-on: https://chromium-review.googlesource.com/1134085
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574358}

    Changed files

    • ash/system/network/network_list.cc
  40. [UMA] Fix bug were omnibox focus is ignored before native is loaded

    Changed by Mohamed Heikal - mheikalohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 22:02:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 79bb954dd2e807d3fac32e2b4fa14046770ef00a

    Comments

    [UMA] Fix bug were omnibox focus is ignored before native is loaded
    
    Urlbar/omnibox focus events that are used for UMAs
    ("MobileStartup.ToolbarFirstFocusStartupState.<activity name>" and
    "MobileStartup.ToolbarFirstFocusTime2.<activity name>"), that happen
    before native is loaded, are ignored. This was due to the improper
    placement of the call to OmniboxStartupMetrics#onUrlBarFocused.
    
    Bug: 862752
    Change-Id: I7354be526b1c116ef9b541a4d5993058163d22a1
    Reviewed-on: https://chromium-review.googlesource.com/1134184
    Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
    Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574357}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java