Home | Search | chromium - Builders
Login

Builder Mac10.11 Tests Build 28016 Apple OSX

Results:

Failure browser_tests on (none) GPU on Mac on Mac-10.11 Failure viz_content_browsertests on Mac-10.11

Trigger Info:

Projectchromium
Revision88b4645c0f83e2cb7c76457bc1dd400d5ed24165
Got Revision88b4645c0f83e2cb7c76457bc1dd400d5ed24165

Execution:

Steps and Logfiles:

Show:
  1. ( 0 ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. perfetto-chromium-autoroll (perfetto-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  2. Chris Harrelson (chrishtrohnoyoudont@chromium.org)
  3. Marcin Wiacek (marcinohnoyoudont@mwiacek.com)
  4. Mathieu Perreault (mathpohnoyoudont@chromium.org)
  5. Chong Jiang (chongjiangohnoyoudont@chromium.org)
  6. Joshua Pawlicki (wafflesohnoyoudont@chromium.org)
  7. Joshua Pawlicki (wafflesohnoyoudont@chromium.org)
  8. Joshua Pawlicki (wafflesohnoyoudont@chromium.org)
  9. Chris Harrelson (chrishtrohnoyoudont@chromium.org)
  10. angle-chromium-autoroll (angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  11. Joshua Pawlicki (wafflesohnoyoudont@chromium.org)
  12. Mounir Lamouri (mlamouriohnoyoudont@chromium.org)
  13. Chris Harrelson (chrishtrohnoyoudont@chromium.org)
  14. Esmael El-Moslimany (aeeohnoyoudont@chromium.org)
  15. Joshua Pawlicki (wafflesohnoyoudont@chromium.org)
  16. Esmael El-Moslimany (aeeohnoyoudont@chromium.org)
  17. Sahel Sharify (sahelohnoyoudont@chromium.org)
  18. Dominic Mazzoni (dmazzoniohnoyoudont@chromium.org)
  19. Helen Li (xunjieliohnoyoudont@chromium.org)
  20. yiyix (yiyixohnoyoudont@chromium.org)
  21. Sebastien Marchand (sebmarchandohnoyoudont@chromium.org)
  22. Dirk Pranke (dprankeohnoyoudont@chromium.org)
  23. John Z Wu (jzwohnoyoudont@chromium.org)
  24. Sujie Zhu (sujiezhuohnoyoudont@google.com)
  25. Andrew Grieve (agrieveohnoyoudont@chromium.org)
  26. Yaron Friedman (yfriedmanohnoyoudont@chromium.org)
  27. Marc Treib (treibohnoyoudont@chromium.org)
  28. pdfium-chromium-autoroll (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  29. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  30. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  31. Jonathan Ross (jonrossohnoyoudont@chromium.org)
  32. Tiger Oakes (tigeroohnoyoudont@google.com)
  33. Mitsuru Oshima (oshimaohnoyoudont@chromium.org)
  34. bsheedy (bsheedyohnoyoudont@chromium.org)
  35. Scott Violet (skyohnoyoudont@chromium.org)
  36. Paul Miller (paulmillerohnoyoudont@google.com)
  37. Matt Menke (mmenkeohnoyoudont@chromium.org)
  38. Yue Li (updowndotaohnoyoudont@chromium.org)
  39. Samuel Huang (huangsohnoyoudont@chromium.org)
  40. Ran Ji (ranjohnoyoudont@chromium.org)
  41. Mounir Lamouri (mlamouriohnoyoudont@chromium.org)
  42. Moe Ahmadi (mahmadiohnoyoudont@chromium.org)
  43. Yiming Zhou (uwyimingohnoyoudont@google.com)
  44. Marc Treib (treibohnoyoudont@chromium.org)
  45. Francois Doray (fdorayohnoyoudont@chromium.org)
  46. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  47. Chris Mumford (cmumfordohnoyoudont@chromium.org)
  48. Emily Hanley (eyaichohnoyoudont@google.com)
  49. Stephen McGruer (smcgruerohnoyoudont@chromium.org)
  50. Bo Liu (boliuohnoyoudont@chromium.org)
  51. Ned Nguyen (nednguyenohnoyoudont@google.com)

Timing:

Create Wednesday, 11-Jul-18 21:59:30 UTC
Start Wednesday, 11-Jul-18 21:59:47 UTC
End Wednesday, 11-Jul-18 23:22:51 UTC
Pending 17 secs
Execution 1 hrs 23 mins

All Changes:

  1. Roll src/third_party/perfetto 256c9c48ab20..f37ffaf9b1a1 (1 commits)

    Changed by perfetto-chromium-autoroll - perfetto-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 21:03:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 88b4645c0f83e2cb7c76457bc1dd400d5ed24165

    Comments

    Roll src/third_party/perfetto 256c9c48ab20..f37ffaf9b1a1 (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/256c9c48ab20..f37ffaf9b1a1
    
    
    git log 256c9c48ab20..f37ffaf9b1a1 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 lalitm@google.com trace_processor: update sched slice table to use new query serializer
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@f37ffaf9b1a1
    
    The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:80416541
    TBR=perfetto-bugs@google.com
    
    Change-Id: I42f8e4e668e662c199a44f054864a272bad5153a
    Reviewed-on: https://chromium-review.googlesource.com/1133859
    Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574332}

    Changed files

    • DEPS
  2. Set root as the "common_transform_ancestor" if there is no compositing container for squashing.

    Changed by Chris Harrelson - chrishtrohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:03:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d1b4460d9ccaf07f8010c980126bec388652e648

    Comments

    Set root as the "common_transform_ancestor" if there is no compositing container for squashing.
    
    Bug: 854381
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I34aa3bf133d71c2809b13c7efe45f1d5307b99cd
    Reviewed-on: https://chromium-review.googlesource.com/1132466
    Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
    Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574331}

    Changed files

    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
  3. Optimization in java/preferences + trivial cleanup in java/compositor

    Changed by Marcin Wiacek - marcinohnoyoudont@mwiacek.com
    Changed at Wednesday, 11-Jul-18 20:59:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 672e508eaf7ee440129bf98f54842b8cab4c9a84

    Comments

    Optimization in java/preferences + trivial cleanup in java/compositor
    
    Moving separate methods in one in the PrefServiceBridge +
    using *.PERMISSIONS in SiteSettingsCategory +
    
    some mechanical trivial cleanup in compositor files.
    
    Note: preferences work is another part after https://chromium-review.googlesource.com/c/chromium/src/+/1097408
    
    Change-Id: I6fab5994368ebc258863c65811559f5151056fe0
    Reviewed-on: https://chromium-review.googlesource.com/1109817
    Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574330}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelBase.java
    • chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelTextViewInflater.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/NotificationsPreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsCategory.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/Website.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/preferences/NotificationsPreferencesTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java
  4. [Payments] Add feature to only send address countries in GetUploadDetails

    Changed by Mathieu Perreault - mathpohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:58:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 829a85709e1eb1a2b736aa38040cfad59c409742

    Comments

    [Payments] Add feature to only send address countries in GetUploadDetails
    
    Feature is disabled by default.
    
    Also renames some functions in the TestPaymentsClient.
    
    Bug: 862465
    Change-Id: Idf44bfbca180266f43914a165603ad6be4c88794
    Reviewed-on: https://chromium-review.googlesource.com/1132404
    Commit-Queue: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Cr-Commit-Position: refs/heads/master@{#574329}

    Changed files

    • components/autofill/core/browser/credit_card_save_manager.cc
    • components/autofill/core/browser/credit_card_save_manager.h
    • components/autofill/core/browser/credit_card_save_manager_unittest.cc
    • components/autofill/core/browser/payments/test_payments_client.cc
    • components/autofill/core/browser/payments/test_payments_client.h
    • components/autofill/core/common/autofill_features.cc
    • components/autofill/core/common/autofill_features.h
  5. ozone: evdev: Replace VLOG with DVLOG

    Changed by Chong Jiang - chongjiangohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:58:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 69457fa19c040700fd28ae3b9a942373f5c35427

    Comments

    ozone: evdev: Replace VLOG with DVLOG
    
    BUG=chromium:489441
    
    VLOG() has a high overhead due to pattern matching. Calling it here
    accounts for ~0.9% of all cycles spent in Chrome on ChromeOS devices.
    
    Change-Id: I5c6c94fdc2edcd96bf26d9450c591fcc16c521a9
    Reviewed-on: https://chromium-review.googlesource.com/1132432
    Reviewed-by: Michael Spang <spang@chromium.org>
    Commit-Queue: Chong Jiang <chongjiang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574328}

    Changed files

    • ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc
  6. Revert "Reland "Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type.""

    Changed by Joshua Pawlicki - wafflesohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:57:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 58332a8d64507e81052c08a588c7fa1649c86620

    Comments

    Revert "Reland "Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type.""
    
    This reverts commit 69ff8256385b83c6eae31f1446e94323dc504287.
    
    Reason for revert: Dependent change now reverted, reverting this one as well.
    
    Original change's description:
    > Reland "Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type."
    > 
    > This reverts commit eda64b390b4dd364363c6cf1b17c9a08f8a645f3.
    > 
    > Reason for revert: There is already a dependent change.
    > 
    > Original change's description:
    > > Revert "Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type."
    > > 
    > > This reverts commit 8b5c0e25f1d7abd563c81d5b2530257150d3fc74.
    > > 
    > > Reason for revert: breaks compile on Cast Linux
    > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux/55639
    > > 
    > > Original change's description:
    > > > Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type.
    > > > 
    > > > For the workflow of the local card migration, we need to know the type of the imported credit card to decide whether to prompt the migration to the user. The type of the imported credit card from the submitted form can be LOCAL_CARD, SERVER_CARD, NEW_CARD and NO_CARD. Currently we have the offering_upload_of_local_credit_card_ variable to denote the imported card is a local card. For the code simpilicity and reuse, we change the bool variable to an enum to represent the type of the imported credit card.
    > > > 
    > > > Since the ImportCreditCard is not always called in the ImportFormData, so we reset the imported_credit_card_record_type in ImportFormData so that every time we try to import from form, the imported_credit_card_record_type is reset. Also, to test the reset, we use ImportFormData instead of directly using ImportCreditCard in the unittest.
    > > > 
    > > > In this CL, we add unittest for imported_credit_card_record_type to check correctness of the imported card type.
    > > > 
    > > > The following CL will be solve the triggering logic with the imported_credit_card_record_type.
    > > > 
    > > > Bug: 852904
    > > > Change-Id: I09fd790ae324943cb0ad0072be4fef3f56729ca0
    > > > Reviewed-on: https://chromium-review.googlesource.com/1130467
    > > > Reviewed-by: Jared Saul <jsaul@google.com>
    > > > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    > > > Commit-Queue: Sujie Zhu <sujiezhu@google.com>
    > > > Cr-Commit-Position: refs/heads/master@{#574309}
    > > 
    > > TBR=sebsg@chromium.org,jsaul@google.com,jiahuiguo@chromium.org,siyua@google.com,sujiezhu@google.com
    > > 
    > > Change-Id: I9f5d6752dfc50f4b830d6286b9188d66df36ee6a
    > > No-Presubmit: true
    > > No-Tree-Checks: true
    > > No-Try: true
    > > Bug: 852904
    > > Reviewed-on: https://chromium-review.googlesource.com/1134118
    > > Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    > > Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#574318}
    > 
    > TBR=waffles@chromium.org,sebsg@chromium.org,jsaul@google.com,jiahuiguo@chromium.org,siyua@google.com,sujiezhu@google.com
    > 
    > Change-Id: I030a7f4e25a44ff2d6932628c0b54241fce8085c
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 852904
    > Reviewed-on: https://chromium-review.googlesource.com/1134138
    > Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    > Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574325}
    
    TBR=waffles@chromium.org,sebsg@chromium.org,jsaul@google.com,jiahuiguo@chromium.org,siyua@google.com,sujiezhu@google.com
    
    Change-Id: I63e14d46d868547eb6859f485581bfb2d8a2091b
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 852904
    Reviewed-on: https://chromium-review.googlesource.com/1134119
    Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574327}

    Changed files

    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc
  7. Revert "Add method "ConfirmSaveAutofillProfile" to AutofillClient."

    Changed by Joshua Pawlicki - wafflesohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:54:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 560191224bcaf8390e0745a16bdf8975a1add6bf

    Comments

    Revert "Add method "ConfirmSaveAutofillProfile" to AutofillClient."
    
    This reverts commit da5ab5f6853c93ea08fe428db7dd22abe62db7d7.
    
    Reason for revert: compile failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux/55639
    
    Original change's description:
    > Add method "ConfirmSaveAutofillProfile" to AutofillClient.
    > 
    > This method will allow clients to decide if they want to
    > save autofill profiles. //ios/web_view may choose to not
    > save autofill profiles under some conditions.
    > For all other autofill_clients, save like usual.
    > 
    > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    > Change-Id: I33764384ba931c5eb0bb4f3de3810be2f64c70bf
    > Reviewed-on: https://chromium-review.googlesource.com/1074269
    > Commit-Queue: John Wu <jzw@chromium.org>
    > Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    > Reviewed-by: Bo <boliu@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574310}
    
    TBR=boliu@chromium.org,mathp@chromium.org,sebsg@chromium.org,mahmadi@chromium.org,jzw@chromium.org
    
    Change-Id: I570967926d1f38e675aa9980a9a5181e6270bb2d
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Reviewed-on: https://chromium-review.googlesource.com/1134139
    Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574326}

    Changed files

    • android_webview/browser/aw_autofill_client.cc
    • android_webview/browser/aw_autofill_client.h
    • chrome/browser/ui/autofill/chrome_autofill_client.cc
    • chrome/browser/ui/autofill/chrome_autofill_client.h
    • components/autofill/core/browser/autofill_client.h
    • components/autofill/core/browser/autofill_merge_unittest.cc
    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc
    • components/autofill/core/browser/test_autofill_client.cc
    • components/autofill/core/browser/test_autofill_client.h
    • ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
    • ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
    • ios/web_view/internal/autofill/web_view_autofill_client_ios.h
    • ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
  8. Reland "Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type."

    Changed by Joshua Pawlicki - wafflesohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:52:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 69ff8256385b83c6eae31f1446e94323dc504287

    Comments

    Reland "Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type."
    
    This reverts commit eda64b390b4dd364363c6cf1b17c9a08f8a645f3.
    
    Reason for revert: There is already a dependent change.
    
    Original change's description:
    > Revert "Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type."
    > 
    > This reverts commit 8b5c0e25f1d7abd563c81d5b2530257150d3fc74.
    > 
    > Reason for revert: breaks compile on Cast Linux
    > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux/55639
    > 
    > Original change's description:
    > > Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type.
    > > 
    > > For the workflow of the local card migration, we need to know the type of the imported credit card to decide whether to prompt the migration to the user. The type of the imported credit card from the submitted form can be LOCAL_CARD, SERVER_CARD, NEW_CARD and NO_CARD. Currently we have the offering_upload_of_local_credit_card_ variable to denote the imported card is a local card. For the code simpilicity and reuse, we change the bool variable to an enum to represent the type of the imported credit card.
    > > 
    > > Since the ImportCreditCard is not always called in the ImportFormData, so we reset the imported_credit_card_record_type in ImportFormData so that every time we try to import from form, the imported_credit_card_record_type is reset. Also, to test the reset, we use ImportFormData instead of directly using ImportCreditCard in the unittest.
    > > 
    > > In this CL, we add unittest for imported_credit_card_record_type to check correctness of the imported card type.
    > > 
    > > The following CL will be solve the triggering logic with the imported_credit_card_record_type.
    > > 
    > > Bug: 852904
    > > Change-Id: I09fd790ae324943cb0ad0072be4fef3f56729ca0
    > > Reviewed-on: https://chromium-review.googlesource.com/1130467
    > > Reviewed-by: Jared Saul <jsaul@google.com>
    > > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    > > Commit-Queue: Sujie Zhu <sujiezhu@google.com>
    > > Cr-Commit-Position: refs/heads/master@{#574309}
    > 
    > TBR=sebsg@chromium.org,jsaul@google.com,jiahuiguo@chromium.org,siyua@google.com,sujiezhu@google.com
    > 
    > Change-Id: I9f5d6752dfc50f4b830d6286b9188d66df36ee6a
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 852904
    > Reviewed-on: https://chromium-review.googlesource.com/1134118
    > Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    > Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574318}
    
    TBR=waffles@chromium.org,sebsg@chromium.org,jsaul@google.com,jiahuiguo@chromium.org,siyua@google.com,sujiezhu@google.com
    
    Change-Id: I030a7f4e25a44ff2d6932628c0b54241fce8085c
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 852904
    Reviewed-on: https://chromium-review.googlesource.com/1134138
    Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574325}

    Changed files

    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc
  9. Adjust overlay scrollbar reparenting trigger logic

    Changed by Chris Harrelson - chrishtrohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:48:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 496307f84f8edf8fd2c11cf3e36854ed77c4632a

    Comments

    Adjust overlay scrollbar reparenting trigger logic
    
    - Determine non-stacked-with-in-flow-stacked descendants scrollers, and use that
    information to decide when to reparent overlay scrollbars. Delete old logic.
    - Implement this new
    bit in the descendant-dependent PaintLayer tree walk. Move the has-self-painting-
    layer-descendant bit to that tree walk also.
    
    
    Overlay scrollbars for an overflow scrolling element need to paint after all
    content that scrolls under it. If the element is stacked, this is easy because
    we can iterate over all PaintLayers that scroll with it (including the element)
    and reparent the overlay scrollbars after that in the GraphicsLayer list of
    the parent stacking context.
    
    If the element is not stacked, however, this is trickier, as we should only reparent
    if there is a stacked scrolling PaintLayer under the element, because the element
    is not painted in the containing stacking context, but instead by its direct ancestor,
    which may not be a stacking context.
    scrollbars/overlay-scrollbars-within-overflow-scroll.html is a good
    example of this, where the inner scroller is not stacked and has no stacked descendant.
    
    Detecting non-stacked with stacking, scrolled descendants allow us to simplify the logic
    for determining reparenting triggers, to avoid complicated/potentially slow logic in
    CompositingInputsUpdater.
    
    To make room for the new bit, merge the HasSelfPaintingLayerDescendant bit into the
    descendant-dependent tree walk. This bit was computed in its own tree walk with
    its own dirty bit, which was unnecessarily complicated and slow.
    
    
    Bug: 857035
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Idcf8fdf0ab20ca25edc9e5ff33c203efee392dbd
    Reviewed-on: https://chromium-review.googlesource.com/1128333
    Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
    Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574324}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/compositing/overflow/scrollbar-layer-placement-negative-z-index-child-positioned-expected.png
    • third_party/WebKit/LayoutTests/compositing/overflow/scrollbar-layer-placement-negative-z-index-child-positioned-expected.txt
    • third_party/WebKit/LayoutTests/compositing/overflow/scrollbar-layer-placement-negative-z-index-child-positioned.html
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
    • third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater.cc
    • third_party/blink/renderer/core/paint/compositing/graphics_layer_tree_builder.cc
    • third_party/blink/renderer/core/paint/paint_layer.cc
    • third_party/blink/renderer/core/paint/paint_layer.h
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
    • third_party/blink/renderer/core/paint/paint_layer_test.cc
  10. Roll src/third_party/angle 5c8113d3c20f..89ef177f9475 (3 commits)

    Changed by angle-chromium-autoroll - angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 20:48:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5e3b22a638ef80bbd479bbf91259e8bd02b732ed

    Comments

    Roll src/third_party/angle 5c8113d3c20f..89ef177f9475 (3 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/5c8113d3c20f..89ef177f9475
    
    
    git log 5c8113d3c20f..89ef177f9475 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 geofflang@chromium.org EGL: Fix binding EGL_NO_SURFACE without surfaceless support.
    2018-07-11 jmadill@chromium.org Vulkan: Remove vk::ErrorOrResult.
    2018-07-11 jmadill@chromium.org Vulkan: Implement sampler structs as function args.
    
    
    Created with:
      gclient setdep -r src/third_party/angle@89ef177f9475
    
    The AutoRoll server is located here: https://angle-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jmadill@chromium.org
    
    Change-Id: I6502f767d05dac13d2c0c5d1ea69df7d973e9b43
    Reviewed-on: https://chromium-review.googlesource.com/1133858
    Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574323}

    Changed files

    • DEPS
  11. Re-mark csp test as flaky (was speculatively unmarked).

    Changed by Joshua Pawlicki - wafflesohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:47:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a18e8a4a19f2f5dd2d52b8d715da8fa61a3b9654

    Comments

    Re-mark csp test as flaky (was speculatively unmarked).
    
    Bug: 818324
    Change-Id: Ie3b8afb30a9a84c124cbe22978e1dd491dbe84e4
    TBR: dpranke@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/1134052
    Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574322}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  12. MediaButtonReceiver: update logging and behavior when receiving invalid intent.

    Changed by Mounir Lamouri - mlamouriohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:47:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f892f7f11ab2136b78a2f041ca48da8e60fec3c2

    Comments

    MediaButtonReceiver: update logging and behavior when receiving invalid intent.
    
    Bug: None
    Change-Id: I7d714f5a10f9cdce90ce251f3e415e75897a07e7
    Reviewed-on: https://chromium-review.googlesource.com/1133741
    Reviewed-by: Min Qin <qinmin@chromium.org>
    Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574321}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaButtonReceiver.java
  13. Optimize infinite ClipRect cases a bit more.

    Changed by Chris Harrelson - chrishtrohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:46:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a335c9fe7f2ded9e83b64e85d45e623b2cf6b729

    Comments

    Optimize infinite ClipRect cases a bit more.
    
    This reduced time in deep-layers.html (rom https://chromium-review.googlesource.com/c/chromium/src/+/1101824)
    by about 5%.
    
    Bug:831762
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I338274cd96335300054ca347cd5bc53aff700de6
    Reviewed-on: https://chromium-review.googlesource.com/1132490
    Reviewed-by: vmpstr <vmpstr@chromium.org>
    Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574320}

    Changed files

    • third_party/blink/renderer/core/paint/clip_rect.cc
    • third_party/blink/renderer/core/paint/clip_rect.h
    • third_party/blink/renderer/core/paint/clip_rect_test.cc
    • third_party/blink/renderer/core/paint/paint_layer_clipper.cc
  14. Downloads WebUI: allow toolbar to resize along with decreased window widths

    Changed by Esmael El-Moslimany - aeeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:46:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a76b5ec55bca210fa0601a64e9724bf1dd528961

    Comments

    Downloads WebUI: allow toolbar to resize along with decreased window widths
    
    Bug: 841708
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Iae485cc912bed7bcbb3ebd6e435c5f3d0208a550
    Reviewed-on: https://chromium-review.googlesource.com/1124982
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574319}

    Changed files

    • chrome/browser/resources/md_downloads/manager.html
  15. Revert "Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type."

    Changed by Joshua Pawlicki - wafflesohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:45:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eda64b390b4dd364363c6cf1b17c9a08f8a645f3

    Comments

    Revert "Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type."
    
    This reverts commit 8b5c0e25f1d7abd563c81d5b2530257150d3fc74.
    
    Reason for revert: breaks compile on Cast Linux
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux/55639
    
    Original change's description:
    > Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type.
    > 
    > For the workflow of the local card migration, we need to know the type of the imported credit card to decide whether to prompt the migration to the user. The type of the imported credit card from the submitted form can be LOCAL_CARD, SERVER_CARD, NEW_CARD and NO_CARD. Currently we have the offering_upload_of_local_credit_card_ variable to denote the imported card is a local card. For the code simpilicity and reuse, we change the bool variable to an enum to represent the type of the imported credit card.
    > 
    > Since the ImportCreditCard is not always called in the ImportFormData, so we reset the imported_credit_card_record_type in ImportFormData so that every time we try to import from form, the imported_credit_card_record_type is reset. Also, to test the reset, we use ImportFormData instead of directly using ImportCreditCard in the unittest.
    > 
    > In this CL, we add unittest for imported_credit_card_record_type to check correctness of the imported card type.
    > 
    > The following CL will be solve the triggering logic with the imported_credit_card_record_type.
    > 
    > Bug: 852904
    > Change-Id: I09fd790ae324943cb0ad0072be4fef3f56729ca0
    > Reviewed-on: https://chromium-review.googlesource.com/1130467
    > Reviewed-by: Jared Saul <jsaul@google.com>
    > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    > Commit-Queue: Sujie Zhu <sujiezhu@google.com>
    > Cr-Commit-Position: refs/heads/master@{#574309}
    
    TBR=sebsg@chromium.org,jsaul@google.com,jiahuiguo@chromium.org,siyua@google.com,sujiezhu@google.com
    
    Change-Id: I9f5d6752dfc50f4b830d6286b9188d66df36ee6a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 852904
    Reviewed-on: https://chromium-review.googlesource.com/1134118
    Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574318}

    Changed files

    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc
  16. User Manager WebUI: update bg color

    Changed by Esmael El-Moslimany - aeeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:41:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision be221fc5f10b2250a6bf6064cc51297b71f35656

    Comments

    User Manager WebUI: update bg color
    
    Bug: 862273
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I3137dfd35e896196b2c6ee364cdbf4540823e9e6
    Reviewed-on: https://chromium-review.googlesource.com/1132492
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574317}

    Changed files

    • chrome/browser/resources/md_user_manager/shared_styles.html
    • chrome/browser/resources/md_user_manager/user_manager.html
  17. Clean up wheel scroll latching and async wheel events flags.

    Changed by Sahel Sharify - sahelohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:40:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e6d81f47c871e49bb60ab45804dcb11e7c801667

    Comments

    Clean up wheel scroll latching and async wheel events flags.
    
    This cl removes the wheel scroll latching and async wheel event flags
    which have been enabled by default since M65.
    
    Bug: 859171
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I9597a055774fe3d38f15444e41c0236ed564a3a9
    Reviewed-on: https://chromium-review.googlesource.com/1121057
    Commit-Queue: Sahel Sharify <sahel@chromium.org>
    Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
    Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
    Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    Reviewed-by: danakj <danakj@chromium.org>
    Reviewed-by: Kevin McNee <mcnee@chromium.org>
    Reviewed-by: Timothy Dresser <tdresser@chromium.org>
    Reviewed-by: David Bokan <bokan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574316}

    Changed files

    • cc/input/input_handler.h
    • cc/trees/layer_tree_host_impl.cc
    • cc/trees/layer_tree_host_impl.h
    • cc/trees/layer_tree_host_impl_unittest.cc
    • cc/trees/layer_tree_host_unittest_scroll.cc
    • chrome/browser/about_flags.cc
    • chrome/browser/apps/guest_view/web_view_browsertest.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • content/browser/devtools/protocol/input_handler.cc
    • content/browser/frame_host/cross_process_frame_connector.cc
    • content/browser/pointer_lock_browsertest.cc
    • content/browser/renderer_host/input/fling_controller.cc
    • content/browser/renderer_host/input/fling_controller.h
    • content/browser/renderer_host/input/fling_controller_unittest.cc
    • content/browser/renderer_host/input/input_router_impl.cc
    • content/browser/renderer_host/input/input_router_impl.h
    • content/browser/renderer_host/input/input_router_impl_unittest.cc
    • content/browser/renderer_host/input/mouse_wheel_event_queue.cc
    • content/browser/renderer_host/input/mouse_wheel_event_queue.h
    • content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc
    • content/browser/renderer_host/input/mouse_wheel_phase_handler.cc
    • content/browser/renderer_host/input/wheel_scroll_latching_browsertest.cc
    • content/browser/renderer_host/overscroll_controller.cc
    • content/browser/renderer_host/overscroll_controller.h
    • content/browser/renderer_host/render_widget_host_impl.cc
    • content/browser/renderer_host/render_widget_host_input_event_router.cc
    • content/browser/renderer_host/render_widget_host_input_event_router.h
    • content/browser/renderer_host/render_widget_host_unittest.cc
    • content/browser/renderer_host/render_widget_host_view_android.cc
    • content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
    • content/browser/renderer_host/render_widget_host_view_base.cc
    • content/browser/renderer_host/render_widget_host_view_base.h
    • content/browser/renderer_host/render_widget_host_view_child_frame.cc
    • content/browser/renderer_host/render_widget_host_view_child_frame.h
    • content/browser/renderer_host/render_widget_host_view_child_frame_unittest.cc
    • content/browser/renderer_host/render_widget_host_view_event_handler.cc
    • content/browser/renderer_host/render_widget_host_view_mac.mm
    • content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
    • content/browser/site_per_process_browsertest.cc
    • content/browser/site_per_process_hit_test_browsertest.cc
    • content/browser/site_per_process_mac_browsertest.mm
    • content/child/runtime_features.cc
    • content/public/common/content_features.cc
    • content/public/common/content_features.h
    • content/renderer/input/widget_input_handler_manager.cc
    • testing/buildbot/filters/fuchsia.content_unittests.filter
    • testing/buildbot/filters/mash.browser_tests.filter
    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
    • third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/VirtualTestSuites
    • third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/animated-scroll/README.txt
    • third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/non-animated-scroll/README.txt
    • third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/events/wheel/README.txt
    • third_party/blink/public/platform/web_gesture_event.h
    • third_party/blink/public/platform/web_runtime_features.h
    • third_party/blink/renderer/core/input/mouse_wheel_event_manager.cc
    • third_party/blink/renderer/platform/exported/web_runtime_features.cc
    • ui/compositor/overscroll/scroll_input_handler.cc
    • ui/events/blink/input_handler_proxy.cc
    • ui/events/blink/input_handler_proxy.h
    • ui/events/blink/input_handler_proxy_client.h
    • ui/events/blink/input_handler_proxy_unittest.cc
    • ui/events/blink/web_input_event_traits.cc
    • ui/events/blink/web_input_event_traits.h
  18. Create concrete base class for AXPlatformNodeDelegate

    Changed by Dominic Mazzoni - dmazzoniohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:40:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0088cd120e9b1edfc64f7c2732f64341db6a692d

    Comments

    Create concrete base class for AXPlatformNodeDelegate
    
    The reason to make a pure-virtual class is to ensure that if someone
    adds a new function it must be overridden by all subclasses.
    
    Here are the subclasses of AXPlatformNodeDelegate, and how much they
    implement / override:
    
    * BrowserAccessibility: all
    * NativeViewAccessibilityBase: most
    * TestAXNodeWrapper: most
    * AXSystemCaretWin: a little bit
    * AuraLinuxApplication: a little bit
    
    Every time we added a new interface, it didn't seem to make sense to
    keep implementing them in AXSystemCaretWin and AuraLinuxApplication if
    they weren't needed.
    
    This change adds AXPlatformNodeDelegateBase with default
    implementations of everything. Then most subclasses can
    override exactly what they need and no more.
    
    Bug: none
    Change-Id: I7ad78e9403c92b576881969e035d14174222bb3d
    Reviewed-on: https://chromium-review.googlesource.com/1132093
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: David Tseng <dtseng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574315}

    Changed files

    • content/browser/accessibility/browser_accessibility.h
    • ui/accessibility/BUILD.gn
    • ui/accessibility/platform/ax_platform_node_delegate.h
    • ui/accessibility/platform/ax_platform_node_delegate_base.cc
    • ui/accessibility/platform/ax_platform_node_delegate_base.h
    • ui/accessibility/platform/ax_system_caret_win.cc
    • ui/accessibility/platform/ax_system_caret_win.h
    • ui/accessibility/platform/test_ax_node_wrapper.cc
    • ui/accessibility/platform/test_ax_node_wrapper.h
    • ui/views/accessibility/native_view_accessibility_auralinux.cc
    • ui/views/accessibility/native_view_accessibility_base.cc
    • ui/views/accessibility/native_view_accessibility_base.h
  19. Make NetworkConnectionTracker survive network service crashes and restarts

    Changed by Helen Li - xunjieliohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:39:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cec0800c372ef670f59999fb3f028013d36b866c

    Comments

    Make NetworkConnectionTracker survive network service crashes and restarts
    
    This CL is to mirror tbansal@'s CL
    (https://chromium-review.googlesource.com/1058528) to make
    NetworkConnectionTracker survice network service's crashes and restarts.
    
    Bug: 821009
    Change-Id: Iec33797c0fd0ce12a8e5fdab9fda0a710eb9a528
    Reviewed-on: https://chromium-review.googlesource.com/1120738
    Commit-Queue: Helen Li <xunjieli@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574314}

    Changed files

    • chrome/browser/browser_process_impl.cc
    • chrome/browser/net/network_connection_tracker_browsertest.cc
    • chrome/browser/net/network_quality_tracker_browsertest.cc
    • content/public/browser/network_connection_tracker.cc
    • content/public/browser/network_connection_tracker.h
    • content/public/browser/network_connection_tracker_unittest.cc
  20. Remove metrics in Browser.NonCriticalPath

    Changed by yiyix - yiyixohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:38:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b1e8ede6cc6f5ab8878695e6e0d45a4743b9018d

    Comments

    Remove metrics in Browser.NonCriticalPath
    
    All frames are in the critical path in Browser. i.e., smooth
    does not take priority. So no data is reported in metrics
    BeginMainFrameIntervalNotCritical2 and
    BeginMainFrameQueueDurationNotCritical2.
    
    BUG=856860
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Ibd58bb31ebfdc21f0aae6f5feabbc22ed8fbbcf1
    Reviewed-on: https://chromium-review.googlesource.com/1133427
    Reviewed-by: Fady Samuel <fsamuel@chromium.org>
    Reviewed-by: Mark Pearson <mpearson@chromium.org>
    Commit-Queue: Yi Xu <yiyix@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574313}

    Changed files

    • cc/scheduler/compositor_timing_history.cc
    • tools/metrics/histograms/histograms.xml
  21. Use the Intervention Policy DB to assist discarding/freezing decisions

    Changed by Sebastien Marchand - sebmarchandohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:38:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0d26e79ae48f4aabcc86ebba3df8ea85776f7754

    Comments

    Use the Intervention Policy DB to assist discarding/freezing decisions
    
    Other bug fix in this CL: Don't use the Local DB heuristics when an
    extension try to discard a tab.
    
    Bug: 773383
    Change-Id: I1dd378a097d462793f25c382c9f96aa9381775d7
    Reviewed-on: https://chromium-review.googlesource.com/1129620
    Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Reviewed-by: Chris Hamilton <chrisha@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574312}

    Changed files

    • chrome/browser/browser_process_impl.cc
    • chrome/browser/resource_coordinator/intervention_policy_database.cc
    • chrome/browser/resource_coordinator/intervention_policy_database.h
    • chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
    • chrome/browser/resource_coordinator/tab_lifecycle_unit.h
    • chrome/browser/resource_coordinator/tab_lifecycle_unit_source.cc
    • chrome/browser/resource_coordinator/tab_lifecycle_unit_source.h
    • chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc
    • chrome/test/base/testing_browser_process.cc
  22. Revert "macOS: Display [ctr + tab] and [ctr + shift + tab] as hotkeys for tab switching."

    Changed by Dirk Pranke - dprankeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:35:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df8ff0849861817c9fe9bad0453ddb29785d77fa

    Comments

    Revert "macOS: Display [ctr + tab] and [ctr + shift + tab] as hotkeys for tab switching."
    
    This reverts commit c93c3dca594c13251590042f228f8a1029eca985.
    
    Reason for revert: Suspect this caused a crash on 10.13 (dbg): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/3973
    
    Original change's description:
    > macOS: Display [ctr + tab] and [ctr + shift + tab] as hotkeys for tab switching.
    > 
    > This matches other macOS application like Safari, Terminal, etc. All existing
    > hotkeys will still work.
    > 
    > This CL uses the same hotkey for "previous tab" that Safari and Terminal use,
    > which is [ctr + shift + "Horizontal Tab"]. This also causes tests to pass.
    > However, pressing that key combination actually generates [ctr + shift + "End of
    > Medium"], which renderers in the Main Menu as a backwards tab. This CL updates
    > NSMenuItem(ChromeAdditions) to check for this special case.
    > 
    > This CL removes two incorrect DCHECKs from render_widget_host_view_cocoa.mm. I
    > regularly hit both of them when running Chromium on a local build. They both
    > rely on the false assumption that keyEquivalents in the main menu must have the
    > command modifier.
    > 
    > Bug: 851714
    > Change-Id: I90c643870f9bc7dd87369496eec9ab62a1685e07
    > Reviewed-on: https://chromium-review.googlesource.com/1106659
    > Commit-Queue: Erik Chen <erikchen@chromium.org>
    > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    > Reviewed-by: Nico Weber <thakis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574211}
    
    TBR=thakis@chromium.org,asvitkine@chromium.org,erikchen@chromium.org
    
    Change-Id: I4ce9b2e4dac1f0f2fae815528a1523326ac1d134
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 851714
    Reviewed-on: https://chromium-review.googlesource.com/1134098
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574311}

    Changed files

    • chrome/app/nibs/MainMenu.xib
    • chrome/browser/global_keyboard_shortcuts_mac.mm
    • chrome/browser/ui/cocoa/accelerators_cocoa.mm
    • chrome/browser/ui/cocoa/nsmenuitem_additions.mm
    • chrome/browser/ui/cocoa/nsmenuitem_additions_unittest.mm
    • content/browser/renderer_host/render_widget_host_view_cocoa.mm
    • ui/events/test/cocoa_test_event_utils.mm
  23. Add method "ConfirmSaveAutofillProfile" to AutofillClient.

    Changed by John Z Wu - jzwohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:35:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision da5ab5f6853c93ea08fe428db7dd22abe62db7d7

    Comments

    Add method "ConfirmSaveAutofillProfile" to AutofillClient.
    
    This method will allow clients to decide if they want to
    save autofill profiles. //ios/web_view may choose to not
    save autofill profiles under some conditions.
    For all other autofill_clients, save like usual.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I33764384ba931c5eb0bb4f3de3810be2f64c70bf
    Reviewed-on: https://chromium-review.googlesource.com/1074269
    Commit-Queue: John Wu <jzw@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    Reviewed-by: Bo <boliu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574310}

    Changed files

    • android_webview/browser/aw_autofill_client.cc
    • android_webview/browser/aw_autofill_client.h
    • chrome/browser/ui/autofill/chrome_autofill_client.cc
    • chrome/browser/ui/autofill/chrome_autofill_client.h
    • components/autofill/core/browser/autofill_client.h
    • components/autofill/core/browser/autofill_merge_unittest.cc
    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc
    • components/autofill/core/browser/test_autofill_client.cc
    • components/autofill/core/browser/test_autofill_client.h
    • ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
    • ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
    • ios/web_view/internal/autofill/web_view_autofill_client_ios.h
    • ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
  24. Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type.

    Changed by Sujie Zhu - sujiezhuohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 20:34:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8b5c0e25f1d7abd563c81d5b2530257150d3fc74

    Comments

    Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type.
    
    For the workflow of the local card migration, we need to know the type of the imported credit card to decide whether to prompt the migration to the user. The type of the imported credit card from the submitted form can be LOCAL_CARD, SERVER_CARD, NEW_CARD and NO_CARD. Currently we have the offering_upload_of_local_credit_card_ variable to denote the imported card is a local card. For the code simpilicity and reuse, we change the bool variable to an enum to represent the type of the imported credit card.
    
    Since the ImportCreditCard is not always called in the ImportFormData, so we reset the imported_credit_card_record_type in ImportFormData so that every time we try to import from form, the imported_credit_card_record_type is reset. Also, to test the reset, we use ImportFormData instead of directly using ImportCreditCard in the unittest.
    
    In this CL, we add unittest for imported_credit_card_record_type to check correctness of the imported card type.
    
    The following CL will be solve the triggering logic with the imported_credit_card_record_type.
    
    Bug: 852904
    Change-Id: I09fd790ae324943cb0ad0072be4fef3f56729ca0
    Reviewed-on: https://chromium-review.googlesource.com/1130467
    Reviewed-by: Jared Saul <jsaul@google.com>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Sujie Zhu <sujiezhu@google.com>
    Cr-Commit-Position: refs/heads/master@{#574309}

    Changed files

    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc
  25. Android: Remove legacy --stamp arguments from build scripts

    Changed by Andrew Grieve - agrieveohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:26:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 655ea51f430bf9d583dd4d654fa23501ba58558f

    Comments

    Android: Remove legacy --stamp arguments from build scripts
    
    These were used by GYP, and have not been used for some time.
    
    Change-Id: I89c63e1b75d4f32297015fede805247d0cd82d15
    Reviewed-on: https://chromium-review.googlesource.com/1133305
    Reviewed-by: agrieve <agrieve@chromium.org>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Commit-Queue: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574308}

    Changed files

    • build/android/gyp/gcc_preprocess.py
    • build/android/gyp/generate_v14_compatible_resources.py
    • build/android/gyp/java_cpp_enum_tests.py
    • build/android/gyp/java_google_api_keys_tests.py
    • build/android/gyp/lint.py
    • build/android/gyp/proguard.py
    • build/android/gyp/util/build_utils.py
    • build/android/gyp/write_ordered_libraries.py
  26. Clean up of unused WebApk metrics.

    Changed by Yaron Friedman - yfriedmanohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:19:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4df7c6c40ebef72484655dc54db5c40e9f8c2bc2

    Comments

    Clean up of unused WebApk metrics.
    
    I was doing a pass through our metrics and I don't think these are
    actively used or providing value.
    
    TBR=holte
    
    Change-Id: I0ddb0a0fd89237109bf71b41f12611d812a0cc5e
    Reviewed-on: https://chromium-review.googlesource.com/1129374
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
    Reviewed-by: Ran Ji <ranj@chromium.org>
    Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574307}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java
    • tools/metrics/histograms/histograms.xml
  27. Remove unnecessary thread-affinity in /components/browser_sync

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:19:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8c479395ead17e469f8e1406f420a3d058461dc0

    Comments

    Remove unnecessary thread-affinity in /components/browser_sync
    
    This switches a bunch of places in /components/browser_sync from
    ThreadTaskRunnerHandle/SingleThreadTaskRunner to
    SequencedTaskRunnerHandle/SequencedTaskRunner. A few references to
    SingleThreadTaskRunner remain, where it makes sense (e.g. UIModelWorker)
    or where lower layers require it (e.g. WebDataServiceBase).
    
    While we're here, this also changes some Callbacks in
    SigninConfirmationHelper to OnceCallbacks.
    
    Bug: 846238
    Change-Id: I951d95ec442b6b6df4ba3be08674a9eefd4da02c
    Reviewed-on: https://chromium-review.googlesource.com/1131189
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574306}

    Changed files

    • components/browser_sync/abstract_profile_sync_service_test.cc
    • components/browser_sync/profile_sync_test_util.cc
    • components/browser_sync/profile_sync_test_util.h
    • components/browser_sync/signin_confirmation_helper.cc
    • components/browser_sync/signin_confirmation_helper.h
  28. Roll src/third_party/pdfium e7e454da8e38..b165ffb64e59 (2 commits)

    Changed by pdfium-chromium-autoroll - pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 20:18:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9717e66b37a4336e55a1e420bb998ec4f4e07553

    Comments

    Roll src/third_party/pdfium e7e454da8e38..b165ffb64e59 (2 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/e7e454da8e38..b165ffb64e59
    
    
    git log e7e454da8e38..b165ffb64e59 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 thestig@chromium.org Use JSGetObject() in more places.
    2018-07-11 art-snake@yandex-team.ru Fix crash and memory leak.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@b165ffb64e59
    
    The AutoRoll server is located here: https://pdfium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:860210
    TBR=dsinclair@chromium.org
    
    Change-Id: I22163f80735fd7ab47b3879c5ebccd91b216a9e0
    Reviewed-on: https://chromium-review.googlesource.com/1133860
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574305}

    Changed files

    • DEPS
  29. Reland "Fix OOPIF hit testing in layout tests."

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:17:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3dcee047ec982d521d9ad5301e00ac1bba134f01

    Comments

    Reland "Fix OOPIF hit testing in layout tests."
    
    This is a reland of 5e93ea1955845b344d6e137195b0f27638162b06
    
    Original change's description:
    > Fix OOPIF hit testing in layout tests.
    >
    > If we haven't received an activated surface yet ensure that we fallback
    > to querying the renderer for the target of input events.
    >
    > BUG=601584
    >
    > Change-Id: Id5dfcdb6bf54b98bebbd2a3b715d77202f402781
    > Reviewed-on: https://chromium-review.googlesource.com/1131219
    > Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    > Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#573789}
    
    TBR=kenrb@chromium.org
    
    Bug: 601584
    Change-Id: I8a2d207db79cc237e1d5e22e5e9bfffb218486c4
    Reviewed-on: https://chromium-review.googlesource.com/1133718
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574304}

    Changed files

    • content/browser/renderer_host/render_widget_host_view_base.cc
  30. Import wpt@23057064c87f42aba0615705b11570ace9cb4324

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:17:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4ed5725c80c240b42d7b9ec82a32d1ed7a1fdc7d

    Comments

    Import wpt@23057064c87f42aba0615705b11570ace9cb4324
    
    Using wpt-import in Chromium 8fc67b341c8d30821f9df226a769d97e86523f02.
    With Chromium commits locally applied on WPT:
    a9045946af "Add a fail-fast for longtask layouttests"
    
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21177
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    TBR=foolip
    
    No-Export: true
    Change-Id: I67a2d31dafffcfcbd0d9d5ed1576c0853d6c5644
    Reviewed-on: https://chromium-review.googlesource.com/1133762
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574303}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/media-elements/audio_loop_base.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/media-elements/video_loop_base.html
    • third_party/WebKit/LayoutTests/external/wpt/media/2x2-green.mp4
    • third_party/WebKit/LayoutTests/external/wpt/media/2x2-green.ogv
    • third_party/WebKit/LayoutTests/external/wpt/media/sound_0.mp3
    • third_party/WebKit/LayoutTests/external/wpt/media/sound_0.oga
  31. Updating Viz Content BrowserTests Filter

    Changed by Jonathan Ross - jonrossohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:15:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a57a12587f7ace3b15480262c181ced968346ea4

    Comments

    Updating Viz Content BrowserTests Filter
    
    A few tests have been fixed. This updates the filter accordingly to re-enable them.
    
    TEST=SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest
    SitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF
    Bug: 848825, 848348
    
    Change-Id: If05696e57dfee18cc6ae06c21f7d968982c31219
    Reviewed-on: https://chromium-review.googlesource.com/1133863
    Reviewed-by: Jonathan Ross <jonross@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574302}

    Changed files

    • testing/buildbot/filters/viz.android.content_browsertests.filter
    • testing/buildbot/filters/viz.content_browsertests.filter
  32. Supersize: Adds counter for number of symbols of each type

    Changed by Tiger Oakes - tigeroohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 20:13:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3459a089449cdc6728667a5e4d60bf30ac96ffc4

    Comments

    Supersize: Adds counter for number of symbols of each type
    
    The infocard now displays the amount of each type of symbol present in
    a container. This is a 3rd column alongside the existing total byte
    size and percentage columns.
    
    Bug: 847599
    Change-Id: Iab247f1891ee036262956dd585e81864ee8ce12c
    Reviewed-on: https://chromium-review.googlesource.com/1133759
    Commit-Queue: Tiger Oakes <tigero@google.com>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574301}

    Changed files

    • tools/binary_size/libsupersize/template_tree_view/index.html
    • tools/binary_size/libsupersize/template_tree_view/infocard-ui.js
    • tools/binary_size/libsupersize/template_tree_view/shared.js
    • tools/binary_size/libsupersize/template_tree_view/state.js
    • tools/binary_size/libsupersize/template_tree_view/tree-ui.js
    • tools/binary_size/libsupersize/template_tree_view/tree-worker.js
  33. Fix uint8 -> uint8_t

    Changed by Mitsuru Oshima - oshimaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:11:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 15449df72eb980ce894ee03ac9d8041b204a9df3

    Comments

    Fix uint8 -> uint8_t
    
    It was causing the following compilation error:
    ../../media/gpu/jpeg_encode_accelerator_unittest.cc:415:29: error: unknown type name 'uint8'; did you mean 'uint'?
              static_cast<const uint8*>(hw_out_shm_->memory()), hw_encoded_size,
                                ^~~~~
                                uint
    
    TBR=kcwu@chromium.org
    BUG=None
    TEST=compiles on simple chrome workflow.
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: If8869b2fe9d1a62e858637fc4b6e412990ad40a9
    Reviewed-on: https://chromium-review.googlesource.com/1133774
    Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574300}

    Changed files

    • media/gpu/jpeg_encode_accelerator_unittest.cc
  34. Fix flaky NPE in VR Dialog tests

    Changed by bsheedy - bsheedyohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:09:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6fd7a607f0e9ba82642d92b7a92ecd261da81608

    Comments

    Fix flaky NPE in VR Dialog tests
    
    Fixes a race condition in the code to wait for VR native UI quiescence
    that caused the provided callback to be nulled out prematurely if
    multiple interactions were run in quick succession.
    
    Change-Id: I6d56f8fe6840bd45efc603026b731b0574ad1306
    Reviewed-on: https://chromium-review.googlesource.com/1134038
    Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
    Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574299}

    Changed files

    • chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/NativeUiUtils.java
  35. chromeos: disable LoginWebDialogTest.CannotMinimize

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:08:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bd2556851e3cf048df2cbebfbfa2a2633e89e786

    Comments

    chromeos: disable LoginWebDialogTest.CannotMinimize
    
    for mash_browser_tests as it's flaky.
    
    BUG=855767
    TEST=none
    TBR=msw@chromium.org
    
    Change-Id: Ib0952cdb6aed73556784e9002d2a364d2120fbf7
    Reviewed-on: https://chromium-review.googlesource.com/1134051
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574298}

    Changed files

    • testing/buildbot/filters/mash.browser_tests.filter
  36. Variations: Rename 'win' to 'windows' in testing config

    Changed by Paul Miller - paulmillerohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 20:07:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ad77b789e40639b5d0d70875d7cc0aa4a506473d

    Comments

    Variations: Rename 'win' to 'windows' in testing config
    
    This is to match server-side tools. Since GN uses "win", there must
    still be some boundary where "win" is converted to "windows"; move the
    conversion from fieldtrial_to_struct.py to field_trial_config/BUILD.gn.
    
    Also add "android_webview" to the field trial config presubmit.
    
    BUG=707911
    
    Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
    Change-Id: I73c2d2fa98410e32ae77d053098d704ee40378ac
    Reviewed-on: https://chromium-review.googlesource.com/1130348
    Commit-Queue: Paul Miller <paulmiller@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574297}

    Changed files

    • components/variations/field_trial_config/BUILD.gn
    • testing/variations/PRESUBMIT.py
    • testing/variations/README.md
    • testing/variations/fieldtrial_testing_config.json
    • tools/chrome_proxy/webdriver/variations_combinations.py
    • tools/perf/core/perf_benchmark.py
    • tools/variations/fieldtrial_to_struct.py
    • tools/variations/fieldtrial_to_struct_unittest.py
    • tools/variations/fieldtrial_util.py
    • tools/variations/fieldtrial_util_unittest.py
    • tools/variations/unittest_data/test_config.json
  37. Delete the media cache(s) when using a single combined HTTP cache.

    Changed by Matt Menke - mmenkeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:05:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e226149af1b3f003b5d3f59e19ee17bef7419c42

    Comments

    Delete the media cache(s) when using a single combined HTTP cache.
    
    This is so that I can try increasing the media cache size in experiments
    without increasing Chrome's profile size (Except possibly for profiles
    that have never been used to play video).
    
    Bug: 789657
    Change-Id: I45e8f8c6e346a1fa7d05b0bea3e8b001d7dc41e1
    Reviewed-on: https://chromium-review.googlesource.com/1130162
    Reviewed-by: Maks Orlovich <morlovich@chromium.org>
    Commit-Queue: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574296}

    Changed files

    • chrome/browser/profiles/profile_browsertest.cc
    • chrome/browser/profiles/profile_impl_io_data.cc
  38. Handle hotword enable/disable in assistant service

    Changed by Yue Li - updowndotaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:02:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d6a3ec92579dd20374fbbc96ed991f3ba57b09bc

    Comments

    Handle hotword enable/disable in assistant service
    
    - Restart the Assistant when hotword enable state changes
    - Add mojom methods for hotword_enabled pref.
    
    Bug: b/110219351
    Test: Manual test
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: If45adaab50f412d08b43fdc7b6883acecc2441d8
    Reviewed-on: https://chromium-review.googlesource.com/1117849
    Commit-Queue: Yue Li <updowndota@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574295}

    Changed files

    • ash/public/interfaces/voice_interaction_controller.mojom
    • ash/shelf/app_list_button.h
    • ash/system/palette/tools/metalayer_mode.h
    • ash/voice_interaction/voice_interaction_controller.cc
    • ash/voice_interaction/voice_interaction_controller.h
    • ash/voice_interaction/voice_interaction_controller_unittest.cc
    • chrome/browser/chromeos/arc/voice_interaction/fake_voice_interaction_controller.cc
    • chrome/browser/chromeos/arc/voice_interaction/fake_voice_interaction_controller.h
    • chrome/browser/chromeos/arc/voice_interaction/voice_interaction_controller_client.cc
    • chrome/browser/chromeos/arc/voice_interaction/voice_interaction_controller_client.h
    • chrome/browser/chromeos/arc/voice_interaction/voice_interaction_controller_client_unittest.cc
    • chrome/browser/resources/settings/google_assistant_page/google_assistant_browser_proxy.js
    • chrome/browser/resources/settings/google_assistant_page/google_assistant_page.html
    • chrome/browser/resources/settings/google_assistant_page/google_assistant_page.js
    • chrome/browser/ui/webui/settings/chromeos/google_assistant_handler.cc
    • chrome/browser/ui/webui/settings/chromeos/google_assistant_handler.h
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/service.cc
    • chromeos/services/assistant/service.h
    • chromeos/services/assistant/utils.cc
    • chromeos/services/assistant/utils.h
  39. [Zucchini] DEX parsing: Implement stricter size checks for MapItem.

    Changed by Samuel Huang - huangsohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:02:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f63bf220bcb93560358fbe593ebccc4d64f4baa

    Comments

    [Zucchini] DEX parsing: Implement stricter size checks for MapItem.
    
    This CL fixes a bug discovered by the Fuzzer, where DEX parsing
    triggers CHECK() failure due to an attempt to read a 4-byte value that
    straddles EOF.
    
    Tracing (Zucchini-read) using the Fuzzer-provided DEX show that the
    faulty read attempt is for ClassDefItem::static_values_off, which is
    a field in a fixed-length item.
    
    Our fix is to validate MapItem entries for fixed-length items. Details:
    - Add GetItemBaseSize() to return an item size bound. For fixed-length
      items, this is exactly the item size. Moreover, no 4-byte alignment
      is needed, since the item sizes are already multiples of 4 bytes.
    - In DisassemblerDex::ParseHeader(), verify each MapItem fits in the
      image. For fixed-length items, this check enables safe read for
      items whose index are within bound (and avoid similar bugs). For
      variable-length items, this serves as a sanity check to quickly
      reject obviously bad inputs. Subsequent parsing will perform a more
      refined check. For unhandled items, sizes are assumed to be 1.
    - Not checked: Whether MapItems ranges overlap. May do this in the
      future (more refactoring will be needed).
    
    Bug: 862566
    Change-Id: If8efce122979fa1a36d1d445556d414eb499d273
    Reviewed-on: https://chromium-review.googlesource.com/1133713
    Reviewed-by: Samuel Huang <huangs@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Samuel Huang <huangs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574294}

    Changed files

    • components/zucchini/disassembler_dex.cc
  40. Revert "Move kApplicationLocale pref to ui/base"

    Changed by Ran Ji - ranjohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:00:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5908cff94737bde5356c8305a348f66cae6788c2

    Comments

    Revert "Move kApplicationLocale pref to ui/base"
    
    This reverts commit 6ad1cbd1bd26744de3a8d9be9e6fb824ac5c12b3.
    
    Reason for revert: <INSERT REASONING HERE>
    
    Original change's description:
    > Move kApplicationLocale pref to ui/base
    > 
    > We need to use the pref in components, so move the pref to ui/base so it
    > can be accessed.
    > 
    > TBR=jam@chromium.org
    > 
    > Bug: 729596
    > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    > Change-Id: Iffc7c5c2f459340c14a74787defeab00c6c5589c
    > Reviewed-on: https://chromium-review.googlesource.com/1125143
    > Commit-Queue: Ran Ji <ranj@chromium.org>
    > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#573536}
    
    TBR=sky@chromium.org,jam@chromium.org,asvitkine@chromium.org,ranj@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 729596
    Change-Id: I950b8aa43701741de843172f24dd4a1b9887a5de
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Reviewed-on: https://chromium-review.googlesource.com/1133618
    Reviewed-by: Ran Ji <ranj@chromium.org>
    Commit-Queue: Ran Ji <ranj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574293}

    Changed files

    • chrome/browser/browser_process_impl.cc
    • chrome/browser/chrome_browser_main.cc
    • chrome/browser/chromeos/accessibility/accessibility_manager.cc
    • chrome/browser/chromeos/accessibility/dictation_chromeos.cc
    • chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc
    • chrome/browser/chromeos/hats/hats_dialog.cc
    • chrome/browser/chromeos/locale_change_guard.cc
    • chrome/browser/chromeos/login/oobe_localization_browsertest.cc
    • chrome/browser/chromeos/login/screens/welcome_screen.cc
    • chrome/browser/chromeos/login/session/user_session_manager.cc
    • chrome/browser/chromeos/login/ui/login_display_host_webui.cc
    • chrome/browser/extensions/api/settings_private/prefs_util.cc
    • chrome/browser/lifetime/application_lifetime.cc
    • chrome/browser/policy/configuration_policy_handler_list_factory.cc
    • chrome/browser/policy/policy_browsertest.cc
    • chrome/browser/prefs/chrome_command_line_pref_store.cc
    • chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc
    • chrome/browser/profiles/profile.cc
    • chrome/browser/profiles/profile_impl.cc
    • chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc
    • chrome/browser/search/one_google_bar/one_google_bar_loader_impl_unittest.cc
    • chrome/browser/ui/app_list/arc/arc_app_utils.cc
    • chrome/browser/ui/search/local_ntp_test_utils.cc
    • chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc
    • chrome/browser/ui/webui/settings/languages_handler.cc
    • chrome/common/pref_names.cc
    • chrome/common/pref_names.h
    • chrome/service/service_process.cc
    • ios/chrome/browser/prefs/browser_prefs.mm
    • ui/base/BUILD.gn
    • ui/base/pref_names.cc
    • ui/base/pref_names.h
  41. Autoplay: allow autoplay for kiosk applications.

    Changed by Mounir Lamouri - mlamouriohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:54:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e20a770c6072f9563c9c12f001876c7ae59469a

    Comments

    Autoplay: allow autoplay for kiosk applications.
    
    The different with other Chrome Apps is that <webview> should also be
    allowed to autoplay if they are inside a Kiosk application.
    
    Bug: 856659
    Change-Id: If51ca43549d3829eeb9fe25309770467c1fc14c2
    Reviewed-on: https://chromium-review.googlesource.com/1115096
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574292}

    Changed files

    • chrome/browser/extensions/chrome_extension_web_contents_observer.cc
    • chrome/test/base/ash_test_environment_chrome.cc
    • chrome/test/base/ash_test_environment_chrome.h
  42. [AF][IOS] Takes secondary toolbar into account in CC save infobar (Part 2)

    Changed by Moe Ahmadi - mahmadiohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:53:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df5e2cc33a579c47e6242a808195437092b2f344

    Comments

    [AF][IOS] Takes secondary toolbar into account in CC save infobar (Part 2)
    
    This CL moves the logic to set the infobar's bottom margin from
    |-layoutSubviews| to |-sizeThatFits:|. The former method doesn't
    always get called after the secondary toolbar disappears in
    landscape mode. The latter does get called more reliably in both
    portrait and landscape modes.
    Also provides comments on why |-setFrame:| is overridden.
    
    Bug: 849433
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I3ce410378d60535178a0c0c9d0f12f11948772ba
    Reviewed-on: https://chromium-review.googlesource.com/1112303
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574291}

    Changed files

    • ios/chrome/browser/ui/autofill/save_card_infobar_view.mm
  43. Removing the client name parameter from autofill server queries.

    Changed by Yiming Zhou - uwyimingohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 19:49:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4f799497909efb1abf363546de886bfa71c0025a

    Comments

    Removing the client name parameter from autofill server queries.
    
    When attempting to autofill a form, Chrome queries the autofill server
    for form field predictions. Inside the autofill server query request url is a 'client' parameter. In official Chrome builds, the code sets the parameter value to 'Google+Chrome'. In unofficial Chrome builds, the code sets the parameter value to 'Chromium'.
    
    This discrepany in value between the 'client' parameter causes problems
    for Autofill Captured Sites Interactive UI Tests (Captured Sites Tests). As its name indicates, the Captured Sites Tests uses the InProcessBrowserTest framework to test Chrome Autofill on captured sites. A test author creates a test by capturing a site using Web Page Replay Go (WPR). When running the test, WPR stands up a local server to replay the captured traffic, matching replay requests to captured requests. A test author typically uses an official Chrome build to capture sites, so the capture files would contain autofill server requests with one client parameter value. On the other hand InProcessBrowserTests are unofficial Chrome builds, so test would always query the autofill server with a different parameter value. The WPR cannot match the replay request to the captured request, and return 404. The test would fail.
    
    This autofill server actually does not consume the client parameter. So this fix addresses the above problem by removing the client name parameter from autofill server queries.
    
    Bug: 849778
    Change-Id: Iff9a0d7d4c8052b7f91e940e1a7a2536ec6ac996
    Reviewed-on: https://chromium-review.googlesource.com/1119359
    Reviewed-by: Roger McFarlane <rogerm@chromium.org>
    Commit-Queue: Yiming Zhou <uwyiming@google.com>
    Cr-Commit-Position: refs/heads/master@{#574290}

    Changed files

    • components/autofill/core/browser/autofill_download_manager.cc
  44. Remove unnecessary thread-affinity in /components/sync*

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:44:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 95851f140e1532050909cdef0f5ea4cd128b20fb

    Comments

    Remove unnecessary thread-affinity in /components/sync*
    
    This CL replaces many instances of ThreadTaskRunnerHandle by
    SequencedTaskRunnerHandle, and SingleThreadTaskRunner by
    SequencedTaskRunner, in /components/sync/, /components/sync_bookmarks/,
    and /components/sync_sessions/.
    
    There are still several ThreadCheckers around which should become
    SequenceCheckers. That will follow in another CL soon.
    
    Bug: 846238
    Change-Id: I180185e0e4d380f69246ccf52b6dd9a1b4cfbee8
    Reviewed-on: https://chromium-review.googlesource.com/1131474
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574289}

    Changed files

    • components/sync/driver/backend_migrator.cc
    • components/sync/driver/data_type_controller.h
    • components/sync/driver/data_type_manager_impl.cc
    • components/sync/driver/fake_data_type_controller.cc
    • components/sync/driver/frontend_data_type_controller_unittest.cc
    • components/sync/driver/glue/sync_backend_host_core.cc
    • components/sync/driver/glue/sync_backend_host_impl_unittest.cc
    • components/sync/driver/model_type_controller_unittest.cc
    • components/sync/driver/shared_change_processor.cc
    • components/sync/driver/shared_change_processor.h
    • components/sync/driver/sync_service_crypto.cc
    • components/sync/driver/sync_stopped_reporter.cc
    • components/sync/engine/fake_sync_manager.cc
    • components/sync/engine_impl/model_type_connector_proxy.cc
    • components/sync/engine_impl/model_type_registry.cc
    • components/sync/engine_impl/sync_encryption_handler_impl.cc
    • components/sync/engine_impl/sync_encryption_handler_impl.h
    • components/sync/engine_impl/sync_manager_impl.cc
    • components/sync/engine_impl/sync_scheduler_impl.cc
    • components/sync/engine_impl/sync_scheduler_impl_unittest.cc
    • components/sync/model_impl/client_tag_based_model_type_processor.cc
    • components/sync/model_impl/client_tag_based_model_type_processor_unittest.cc
    • components/sync/model_impl/model_type_store_impl.cc
    • components/sync_bookmarks/bookmark_data_type_controller_unittest.cc
    • components/sync_bookmarks/bookmark_model_type_processor.cc
    • components/sync_sessions/session_data_type_controller.cc
    • components/sync_sessions/session_sync_bridge.cc
    • components/sync_sessions/sessions_sync_manager.cc
  45. RC: Make UsageClock work on ChromeOS.

    Changed by Francois Doray - fdorayohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:40:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8ff0122069f9f0ce5c456c9d8eb3ba74142cc7f7

    Comments

    RC: Make UsageClock work on ChromeOS.
    
    Now that DesktopSessionDurationTracker is built on ChromeOS, UsageClock
    can work the same way on all platforms.
    
    Bug: 775644
    Change-Id: Ic90984b2f36a1ffbf19047fae0bb953d56653eee
    Reviewed-on: https://chromium-review.googlesource.com/1133419
    Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
    Commit-Queue: François Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574288}

    Changed files

    • chrome/browser/resource_coordinator/usage_clock.cc
    • chrome/browser/resource_coordinator/usage_clock.h
    • chrome/browser/resource_coordinator/usage_clock_unittest.cc
  46. Update V8 to version 6.9.351.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 19:34:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ca4ce3f01347ddb612162ee031443b5dbc29b277

    Comments

    Update V8 to version 6.9.351.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/c3ce505d..8dc93fc4
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: I9cda5847bd8104c45b418f6c47c784b7352b881c
    Reviewed-on: https://chromium-review.googlesource.com/1133437
    Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574287}

    Changed files

    • DEPS
  47. Disable portion of navigation preload test failing with network service.

    Changed by Chris Mumford - cmumfordohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:33:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ca700a51e4bea95516073239ceb682c0586ba96c

    Comments

    Disable portion of navigation preload test failing with network service.
    
    A recent change (crrev.com/c/1079787) is causing
    a portion of http/tests/serviceworker/navigation_preload/use-counter.html
    to fail when the network service is disabled. Temporarily disabling.
    
    TBR=loonybear@chromium.org,jam@chromium.org
    
    Bug: 862643
    Change-Id: I32848d107bfd7aabdf7de71fc177aebcce386d2a
    Reviewed-on: https://chromium-review.googlesource.com/1133685
    Commit-Queue: Chris Mumford <cmumford@chromium.org>
    Reviewed-by: Chris Mumford <cmumford@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574286}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  48. Cleaning up perf data generator now that we are on OBBS

    Changed by Emily Hanley - eyaichohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 19:32:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e7dca0885bc6876f53d5285c3ca16c1e48bed7ec

    Comments

    Cleaning up perf data generator now that we are on OBBS
    
    Bug: 757933
    Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
    Change-Id: I3268b95bd05eaa9ea86547ccfd8dd7e5d4711c90
    Reviewed-on: https://chromium-review.googlesource.com/1133691
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Commit-Queue: Emily Hanley <eyaich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574285}

    Changed files

    • tools/perf/core/perf_data_generator.py
    • tools/perf/core/perf_data_generator_unittest.py
  49. Remove DCHECK for ScrollTree containment in ScrollTimeline::CurrentTime

    Changed by Stephen McGruer - smcgruerohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:30:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59ec1d863c20d9f5d543901bab5d35c4882f1b0a

    Comments

    Remove DCHECK for ScrollTree containment in ScrollTimeline::CurrentTime
    
    The original assertion that if a ScrollTimeline had a non-null scroller
    id (either pending or active) then said id would be in the ScrollTree
    was actually false. There are cases where the ScrollTimeline can have a
    scroller id, but the scrolling element would not be in the ScrollTree -
    for example a composited overflow: visible element would meet this
    criteria.
    
    As such, this CL converts the DCHECK into an early-exit for this case.
    
    Bug: 853231
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I0ca14a8e8f516357ee9814388514ba2f72fdfd47
    Reviewed-on: https://chromium-review.googlesource.com/1133317
    Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
    Reviewed-by: Majid Valipour <majidvp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574284}

    Changed files

    • cc/animation/scroll_timeline.cc
    • third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-scroll-timeline-non-scrollable-expected.html
    • third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-scroll-timeline-non-scrollable.html
  50. Delete left over tmp file in android build

    Changed by Bo Liu - boliuohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:26:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9b959230e65301ed32da20cd29ae825cd56b68b1

    Comments

    Delete left over tmp file in android build
    
    Change-Id: I672ae27130ac3f851c7a23904b1d2ce42e37eec9
    Reviewed-on: https://chromium-review.googlesource.com/1133425
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Bo <boliu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574283}

    Changed files

    • build/android/gyp/apkbuilder.py
  51. Add --jobs and -j commandline flags for run_webkit_tests.py script

    Changed by Ned Nguyen - nednguyenohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 19:25:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 416e3e9fd93d2796e07eed5c36c2cac6a662dac7

    Comments

    Add --jobs and -j commandline flags for run_webkit_tests.py script
    
    Bug: 862474
    Change-Id: Ic383add3475ba78abc2a0a9eee0ce0a21e1938e1
    Reviewed-on: https://chromium-review.googlesource.com/1132405
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Ned Nguyen <nednguyen@google.com>
    Cr-Commit-Position: refs/heads/master@{#574282}

    Changed files

    • third_party/blink/tools/blinkpy/web_tests/bisect_test_ordering.py
    • third_party/blink/tools/blinkpy/web_tests/run_webkit_tests.py
    • third_party/blink/tools/blinkpy/web_tests/run_webkit_tests_unittest.py
    • third_party/blink/tools/debug_web_tests