Home | Search | chromium - Builders
Login

Builder Mac10.10 Tests Build 35299 Apple OSX

Results:

Failure webkit_layout_tests on (none) GPU on Mac on Mac-10.10.5

Trigger Info:

Projectchromium
Revision755d6f957abd6af5b8bbbf045ac622b92fea60a5
Got Revision755d6f957abd6af5b8bbbf045ac622b92fea60a5

Execution:

Steps and Logfiles:

Show:
  1. ( 448 ms ) setup_build
    running recipe: "chromium"
  2. ( 335 ms ) report builders
     
    running tester 'Mac10.10 Tests' on master 'chromium.mac'
  3. ( 3 mins 49 secs ) bot_update
    [68GB/232GB used (29%)]
  4. ( 1 secs ) swarming.py --version
    0.13
  5. ( 206 ms ) ensure_installed
  6. ( 14 secs ) gclient runhooks
  7. ( 813 ms ) read test spec (chromium.mac.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.mac.json
  8. ( 488 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  9. ( 519 ms ) build directory
  10. ( 587 ms ) find isolated tests
  11. ( 1 secs ) accessibility_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 10s
  12. ( 4 secs ) angle_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 55s
  13. ( 1 secs ) app_shell_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Pending time: 10s
    Shard duration: 14s
  14. ( 3 secs ) base_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 28s
  15. ( 1 secs ) blink_common_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 9s
  16. ( 1 secs ) blink_fuzzer_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 10s
  17. ( 1 secs ) blink_heap_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 14s
  18. ( 2 secs ) blink_platform_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 19s
  19. ( 2 secs ) boringssl_crypto_tests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 11s
  20. ( 1 secs ) boringssl_ssl_tests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 8s
  21. ( 1 secs ) cacheinvalidation_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 7s
  22. ( 2 secs ) capture_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 10s
  23. ( 2 secs ) cast_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 15s
  24. ( 3 secs ) cc_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 43s
  25. ( 2 secs ) chrome_app_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Pending time: 10s
    Shard duration: 15s
  26. ( 1 secs ) chromedriver_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Pending time: 11s
    Shard duration: 9s
  27. ( 1 secs ) components_browsertests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Pending time: 12s
    Shard duration: 28s
  28. ( 8 secs ) components_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Pending time: 16s
    Shard duration: 0:01:50.854182
  29. ( 16 mins 31 secs ) content_browsertests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Pending time: 16s
    Shard duration: 0:20:01.793120
  30. ( 1 secs ) perfetto_content_browsertests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Pending time: 15s
    Shard duration: 21s
  31. ( 4 secs ) content_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Pending time: 17s
    Shard duration: 49s
  32. ( 1 secs ) crashpad_tests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 10s
  33. ( 1 secs ) cronet_tests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 10s
  34. ( 1 secs ) cronet_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 9s
  35. ( 1 secs ) crypto_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 7s
  36. ( 2 secs ) device_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 13s
  37. ( 1 secs ) display_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 8s
  38. ( 2 secs ) events_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 10s
  39. ( 1 secs ) extensions_browsertests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 0:01:13.986673
  40. ( 3 secs ) extensions_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 21s
  41. ( 1 secs ) filesystem_service_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 8s
  42. ( 2 secs ) gcm_unit_tests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 10s
  43. ( 3 secs ) gfx_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 19s
  44. ( 1 secs ) gin_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 9s
  45. ( 1 secs ) google_apis_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 9s
  46. ( 3 secs ) gpu_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 14s
  47. ( 1 secs ) headless_browsertests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 28s
  48. ( 1 secs ) headless_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 11s
  49. ( 2 secs ) webui_polymer2_interactive_ui_tests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 0:01:18.548989
  50. ( 1 secs ) ipc_tests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 15s
  51. ( 1 secs ) jingle_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 9s
  52. ( 2 secs ) latency_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 8s
  53. ( 1 secs ) leveldb_service_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 0:01:19.829362
  54. ( 1 secs ) libjingle_xmpp_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 17s
  55. ( 2 secs ) mac_installer_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 11s
  56. ( 2 secs ) media_blink_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 12s
  57. ( 1 secs ) media_service_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 10s
  58. ( 4 secs ) media_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 24s
  59. ( 1 secs ) message_center_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 12s
  60. ( 1 secs ) midi_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 11s
  61. ( 2 secs ) mojo_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 11s
  62. ( 1 secs ) nacl_loader_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 11s
  63. ( 2 secs ) native_theme_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 8s
  64. ( 14 secs ) net_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 0:03:14.873567
  65. ( 2 secs ) pdf_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 9s
  66. ( 1 secs ) ppapi_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 9s
  67. ( 1 secs ) printing_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 7s
  68. ( 2 secs ) remoting_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 16s
  69. ( 1 secs ) sandbox_mac_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 8s
  70. ( 1 secs ) service_manager_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 14s
  71. ( 2 secs ) services_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 22s
  72. ( 1 secs ) shell_dialogs_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 10s
  73. ( 2 secs ) skia_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 9s
  74. ( 1 secs ) snapshot_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 9s
  75. ( 1 secs ) sql_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 8s
  76. ( 1 secs ) storage_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 11s
  77. ( 2 secs ) sync_integration_tests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 0:06:44.095190
  78. ( 1 secs ) traffic_annotation_auditor_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 9s
  79. ( 1 secs ) ui_base_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 10s
  80. ( 1 secs ) ui_touch_selection_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 9s
  81. ( 6 secs ) unit_tests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 0:02:00.350089
  82. ( 1 secs ) url_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 8s
  83. ( 2 secs ) views_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 40s
  84. ( 2 secs ) viz_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 51s
  85. ( 6 secs ) webkit_unit_tests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 0:01:03.503928
  86. ( 2 secs ) wtf_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 7s
  87. ( 2 secs ) interactive_ui_tests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Max shard duration: 0:05:53.642006 (shard #0)
    Min shard duration: 0:04:26.281407 (shard #1)
  88. ( 2 secs ) webui_polymer2_browser_tests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Max pending time: 10s (shard #3)
    Max shard duration: 0:03:58.569833 (shard #2)
    Min shard duration: 0:03:30.002921 (shard #0)
  89. ( 2 secs ) chromedriver_py_tests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Pending time: 12s
    Shard duration: 0:03:01.626729
    Total tests: 142
    * Passed: 142 (142 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  90. ( 2 secs ) chromedriver_replay_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 8s
    Total tests: 33
    * Passed: 33 (33 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  91. ( 1 secs ) components_perftests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Pending time: 13s
    Shard duration: 0:01:28.878056
    Total tests: n/a
     
  92. ( 1 secs ) content_shell_crash_test on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Pending time: 13s
    Shard duration: 33s
    Total tests: n/a
     
  93. ( 1 secs ) metrics_python_tests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 10s
    Total tests: 74
    * Passed: 74 (74 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  94. ( 2 secs ) telemetry_gpu_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Pending time: 11s
    Shard duration: 0:01:02.862585
    Total tests: 35
    * Passed: 35 (35 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  95. ( 4 secs ) telemetry_perf_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Max pending time: 0:03:33.982883 (shard #11)
    Max shard duration: 0:08:36.248156 (shard #6)
    Min shard duration: 0:04:26.958067 (shard #0)
    Total tests: 285
    * Passed: 252 (252 expected, 0 unexpected)
    * Skipped: 33 (33 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  96. ( 3 secs ) telemetry_unittests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Max pending time: 0:04:19.712328 (shard #3)
    Max shard duration: 0:08:47.598031 (shard #0)
    Min shard duration: 0:03:20.072779 (shard #2)
    Total tests: 1153
    * Passed: 1062 (1062 expected, 0 unexpected)
    * Skipped: 91 (91 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  97. ( 3 secs ) views_perftests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 9s
    Total tests: n/a
     
  98. ( 4 mins 8 secs ) webkit_layout_tests on (none) GPU on Mac on Mac-10.10.5
    Run on OS: 'Mac-10.10.5'
    Max pending time: 0:05:59.945488 (shard #11)
    Max shard duration: 0:08:35.416931 (shard #0)
    Min shard duration: 0:06:33.565788 (shard #2)
    Total tests: 87453
    * Passed: 74118 (74026 expected, 92 unexpected)
    * Skipped: 10695 (10695 expected, 0 unexpected)
    * Failed: 2556 (2555 expected, >>>1 unexpected<<<)
    * Flaky: 84 (84 expected, 0 unexpected)
     
    Unexpected Failures:
    * virtual/layout_ng/fast/block/float/nopaint-after-layer-destruction.html
     
  99. ( 2 secs ) webkit_python_tests on (none) GPU on Mac on Mac-10.10
    Run on OS: 'Mac-10.10'
    Shard duration: 16s
    Total tests: 1551
    * Passed: 1551 (1551 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  100. ( 285 ms ) Tests statistics
     
    Stats
    Total shards: 119
    Total runtime: 4:00:19.339660
     
  101. ( 3 ms ) Failure reason

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm76-m9" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539335225812976, "id": "8932883742217305136", "project": "chromium", "tags": ["builder:Mac10.10 Tests", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/755d6f957abd6af5b8bbbf045ac622b92fea60a5", "gitiles_ref:refs/heads/master", "parent_buildername:Mac Builder", "parent_buildnumber:90632", "scheduler_invocation_id:9098313804390131280", "scheduler_job_id:chromium/Mac10.10 Tests", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Mac10.10 Tests" setup_build
buildnumber 35299 setup_build
mastername "chromium.mac" setup_build
parent_buildername "Mac Builder" setup_build
parent_got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" setup_build
parent_got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" setup_build
parent_got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" setup_build
parent_got_revision "755d6f957abd6af5b8bbbf045ac622b92fea60a5" setup_build
parent_got_revision_cp "refs/heads/master@{#599145}" setup_build
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" setup_build
parent_got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" setup_build
parent_got_v8_revision_cp "refs/heads/7.1.302@{#1}" setup_build
parent_got_webrtc_revision "a54daf162facb9fe30bcc3e05bd21c1597076157" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25135}" setup_build
parent_mastername "chromium.mac" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "755d6f957abd6af5b8bbbf045ac622b92fea60a5" setup_build
swarm_hashes {"accessibility_unittests": "b8297560268b78e9f048b85c1d39f1df81040957", "angle_unittests": "c32c73f7e3d97ad497164e56b030583e6e904c16", "app_shell_unittests": "c004d9e84bd056d1503166d7ef247c7aec5cb0f9", "base_unittests": "f0e8d38a7e4befa75fa5a323c37101ff167a3a7b", "blink_common_unittests": "f071caa4929a7b11604387c93c180858c6d5fdd9", "blink_fuzzer_unittests": "d6e7f544253f0ead0df344b33c18782bc77bb646", "blink_heap_unittests": "9e267c3ec23257ae820250f744dcf6a5af5e840a", "blink_platform_unittests": "4db63ba163cec5c616584bd499e37280aec2a2c5", "boringssl_crypto_tests": "2b764b4207c8eae34301b67fbcf8d9a83fe03e53", "boringssl_ssl_tests": "82a1ef9e9c0e18151210377c601ca3dc00e344a2", "browser_tests": "87511b5ec4882728b7f0e467aad66370f3514dcc", "cacheinvalidation_unittests": "977e0ae716656deecd7f6606e0169b7ec51f17bb", "capture_unittests": "870d7343b2cb7d53f390fc343aa869ff47c63adb", "cast_unittests": "2d898c7eeb62411a7835fcb879ec9849f394e146", "cc_unittests": "d13fa37bd7788b3215a22b2397246eba080809a6", "chrome_app_unittests": "69926032438fa941fdfdf874e9bfeb462cd8c136", "chromedriver_py_tests": "4da4d06f15b98b65cea73a21570d96aa812db211", "chromedriver_replay_unittests": "950c040334ad8a7d3fc3ab9bf98bea1f48abdaec", "chromedriver_unittests": "3b641407ad34eaf941f7b83e01bb2b45cf55dace", "components_browsertests": "0e3c5a8bbfc245f77367b512aa275efd600e6b22", "components_perftests": "b4afb9d0719f62a6503afc60a5c200f9a15ed5cd", "components_unittests": "aac61b90b052f31a8b3f50c2612c8f51362bf5d2", "content_browsertests": "7b5b9bdc1eeb0a7423fa26bc2bcacf5bdfb5311a", "content_shell_crash_test": "6825aa075846cebd87a6aa27fd7f44f4234a7ae1", "content_unittests": "a0264157d178826edf1a6dc99607ee0a641d9697", "crashpad_tests": "27572b66b58333e2446bfbdf879f6562f67348a6", "cronet_tests": "911e27b58d973821e1a0df8f4d78a558ec542c5f", "cronet_unittests": "6ad712f7217e3617807980436a78d3a0be86db46", "crypto_unittests": "be2b03d8c0d36cca99b534015e7c19bf45509679", "device_unittests": "e6f58cc192de7477c56ae307527ac69a7af526e3", "display_unittests": "c88ef4cb54b4eedb0dd2c53657d1e3b36493a43e", "events_unittests": "fa8949f79893d7cd294ca2091e3f49a90381607d", "extensions_browsertests": "3974e300970dcbe0c08c826f57d032591757a428", "extensions_unittests": "ff89273d6bb1c940bf09c03532ebf5cfd2a451e9", "filesystem_service_unittests": "29bde0b547afdebb59dc3c1d07ceeabdf149fc71", "gcm_unit_tests": "3ebfd918d853ef804f6a90e124d14406ab958e77", "gfx_unittests": "3f6eb31122011c46b6c8b63efb21797c029aa26d", "gin_unittests": "8844f0ae82fae64588a489b84520a677ea168db8", "google_apis_unittests": "5c2497956c11241f3212fbdfc27138e511d6290f", "gpu_unittests": "bc1bf02a93ac560b3d33d00cd01c7656ae917d76", "headless_browsertests": "aee38b5139ccec2bcf270598228e1e34c89b349b", "headless_unittests": "ea906e55f0a616d68a06c00f0c61b09796e21d8d", "interactive_ui_tests": "33a0d7fdd6bb405dbcd1fd9bf0a0117acfbf5680", "ipc_tests": "77b93f932c19729e4f1350ccb2d090a1baf36981", "jingle_unittests": "3ffd2e9d676f19b5ac077ebba52ec37a686f0279", "latency_unittests": "bf7c2e039e4966ff6d59b9df26f644b4cb661649", "leveldb_service_unittests": "b37f7b355eeeec374cd0ff002249464d4802d8d0", "libjingle_xmpp_unittests": "d8d6f35275807aa93ed42c6ea8a38918ae308792", "mac_installer_unittests": "b443b217e52a9811856e9f02887afec90519aef8", "media_blink_unittests": "a45f8eee6f35725373815f6aba4c3d0c9feadaa4", "media_service_unittests": "251c4e4606396c02765b314cfb91c40e6d5ac0f8", "media_unittests": "75b52b0404009a886dceebce3b5e77174b6ae4bf", "message_center_unittests": "c1dbd7f5207e7d1e6757be48dee3f58453ad8aef", "metrics_python_tests": "a7ea6892f85a3f6a50a4cca2c0b6bc4fb51b579d", "midi_unittests": "5e08022d85cb6bfe34e04a049219cb36d1d5de27", "mojo_unittests": "d0fc72bc28ada8b750fe04ec2817eeb5211d370c", "nacl_loader_unittests": "08459cf5e6cf13c5a5ee92b876f7016f87f34c18", "native_theme_unittests": "7930fefe672e30c379eec53bd7705aef3162968c", "net_unittests": "9d5d3a0ad827cc1af4035303bedc4f22db920f3c", "pdf_unittests": "475066028461bd223e3ed457b591517b8d0a066f", "ppapi_unittests": "7c86fe207a5719995ce8ba84bad0baf8b5e16608", "printing_unittests": "095f5325fe1c563b25571e7c235ebdae4996d2a6", "remoting_unittests": "1218a9cf9149a025a4e8df5829a032ffb51b87af", "sandbox_mac_unittests": "31f0aabf957f7269bf9d14b0fd7a49d9f119bfde", "service_manager_unittests": "210fca4cc04960bf7d5ce7e1585da1dc0284c33f", "services_unittests": "2f7e952dd66172c6c1475a807081859f6ec87df3", "shell_dialogs_unittests": "91ba7e11188aa2dc1485afa76e8cbe2cf0361df9", "skia_unittests": "add07ba3b9806e03c63e762b0bb726fa23172645", "snapshot_unittests": "af07df1dada934a2fe930192516583f01ede698a", "sql_unittests": "2634e4f4b8b13c09373372590c63271523f34e18", "storage_unittests": "6811128ed910c7505209acba48f34f2dc9fd3078", "sync_integration_tests": "4c486d66c0771c7f03a79d3c718a0b3740640bfc", "telemetry_gpu_unittests": "bcccabdbc64cbe564a5a4052d85d37c3d2ae7ebd", "telemetry_perf_unittests": "73e92c88906b02df587a1d33c741f7fd222d8255", "telemetry_unittests": "56765531148ea505153822b8a7b156b94b9a2a61", "traffic_annotation_auditor_unittests": "c32a84bfbc78c6f206bef59642538d6ac2321da0", "ui_base_unittests": "b9d0b2c050a249e58bafea215bc7932e6937b948", "ui_touch_selection_unittests": "cb6fe0eeaea2be55932322047166b3e94cf0d733", "unit_tests": "beebf89bedabf3ab9ec638d0d823074adf99bb0a", "url_unittests": "766e6300044abc12cd5efb29a3b4d0a438020afb", "views_perftests": "696d8c8274a4fe46a7eaa801e4213b3c0c772617", "views_unittests": "401d8ae309199f8a3e97eb3d580766f499ddda3f", "viz_unittests": "05d745dd1f64bde2e4b54872907b45a46171197a", "webkit_layout_tests_exparchive": "4ceb16ee2cb79435ff20dafdd243344aab52cedc", "webkit_python_tests": "79d04ef92dffaa604ec80e513816995983971080", "webkit_unit_tests": "fc5bff3343d6567bf1fdd62b78e312c8da52d872", "wtf_unittests": "ac575f437d529142293741c3a7c23087f4478409"} setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "755d6f957abd6af5b8bbbf045ac622b92fea60a5" bot_update
got_revision_cp "refs/heads/master@{#599145}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "a54daf162facb9fe30bcc3e05bd21c1597076157" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25135}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  2. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  3. Florent Castelli (orphisohnoyoudont@chromium.org)
  4. Fergal Daly (fergalohnoyoudont@chromium.org)
  5. Alexander Alekseev (alemateohnoyoudont@chromium.org)
  6. A Olsen (olsenohnoyoudont@chromium.org)
  7. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  8. Roman Sorokin (rsorokinohnoyoudont@chromium.org)
  9. Alexander Alekseev (alemateohnoyoudont@chromium.org)
  10. Luciano Pacheco (lucmultohnoyoudont@chromium.org)
  11. Alexandre Courbot (acourbotohnoyoudont@chromium.org)
  12. Jochen Eisinger (jochenohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 09:07:05 UTC
Start Friday, 12-Oct-18 09:07:52 UTC
End Friday, 12-Oct-18 09:46:25 UTC
Pending 46 secs
Execution 38 mins 32 secs

All Changes:

  1. [iOS] Support Accessibility ContentSize on NTP header

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:35:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 755d6f957abd6af5b8bbbf045ac622b92fea60a5

    Comments

    [iOS] Support Accessibility ContentSize on NTP header
    
    This CL changes the header of the "Articles for you" section of the NTP
    to have a better support for the "accessibility" categories of preferred
    content size chosen by the user.
    
    Bug: 893524
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I56ed6f89e7767697083c3e8e5d5a796db3066aee
    Reviewed-on: https://chromium-review.googlesource.com/c/1273522
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599145}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_articles_header_item.mm
    • ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
  2. [iOS] Use Dynamic Type in the empty NTP cell

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:35:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c245af46fb47db066cbdc99a5f578e2b94b2ca2f

    Comments

    [iOS] Use Dynamic Type in the empty NTP cell
    
    This CL adds Dynamic Type to the cell displayed when the NTP's articles
    section is empty.
    
    Bug: 893527
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: If36d6ece1eaac888f606f7730de379aec11ba6be
    Reviewed-on: https://chromium-review.googlesource.com/c/1273536
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599144}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_text_item.mm
  3. Revert "Move InstallAttributes to chromeos/settings"

    Changed by Florent Castelli - orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:33:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f32368f166f8a2d51078a6c6c2f6ffc8c3f2f7a9

    Comments

    Revert "Move InstallAttributes to chromeos/settings"
    
    This reverts commit aa6c62dce936e966e2db445045dd04414553642b.
    
    Reason for revert: Breaks build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-daisy-rel/33402
    
    Original change's description:
    > Move InstallAttributes to chromeos/settings
    > 
    > Necessary for moving CrosSettings to chromeos/settings, so it
    > can eventually be used by Mustash.
    > 
    > The following changes were necessary:
    > 1. Move install_attributes{.h, .cc} and unit_test.cc
    > 2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn
    > (destination)
    > 3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h,
    > which is included by install_attributes.h
    > 
    > 4. Unfortunately, that same dependency lead to a circular dependency.
    > I was able to avoid that by separating out a "common_constants" rule in
    > components/policy/core/common, so that chromeos/settings only depends on
    > that, and not on all of components/policy. So I had to change
    > components/policy/core/common/BUILD.gn
    > and I removed an unnecessary include from
    > components/policy/core/common/cloud/cloud_policy_constants.cc
    > 
    > 5. Update #include directives for install_attributes to point to new
    > location. This is the other 22 files, all with diffs of +1 -1.
    > 
    > Bug: 446937
    > Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288
    > Reviewed-on: https://chromium-review.googlesource.com/c/1264757
    > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    > Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    > Commit-Queue: A Olsen <olsen@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599140}
    
    TBR=stevenjb@chromium.org,emaxx@chromium.org,olsen@chromium.org
    
    Change-Id: I50c58b55830961d97834d86a76088dc50eff672d
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 446937
    Reviewed-on: https://chromium-review.googlesource.com/c/1278748
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599143}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/app_mode/kiosk_app_manager.h
    • chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/dbus/dbus_helper.cc
    • chrome/browser/chromeos/login/demo_mode/demo_session.cc
    • chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
    • chrome/browser/chromeos/policy/blocking_login_browsertest.cc
    • chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
    • chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
    • chrome/browser/chromeos/policy/enrollment_status_chromeos.h
    • chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
    • chrome/browser/chromeos/settings/device_settings_provider.cc
    • chrome/browser/chromeos/settings/install_attributes.cc
    • chrome/browser/chromeos/settings/install_attributes.h
    • chrome/browser/chromeos/settings/install_attributes_unittest.cc
    • chrome/browser/chromeos/settings/stub_install_attributes.h
    • chrome/browser/chromeos/system/device_disabling_manager.cc
    • chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
    • chrome/browser/ui/webui/policy_ui_handler.cc
    • chromeos/DEPS
    • chromeos/settings/BUILD.gn
    • components/policy/core/common/BUILD.gn
    • components/policy/core/common/cloud/cloud_policy_constants.cc
  4. [css, dom] Support partmap="foo: bar" syntax.

    Changed by Fergal Daly - fergalohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:26:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4cb84b573a62d8db8d168de16560b4ff78df5bda

    Comments

    [css, dom] Support partmap="foo: bar" syntax.
    
    This is the new syntax agreed for partmap.
    
    Bug: 805271
    Change-Id: I5e8e34551167b4a56706980dae8054e4b7a6fba2
    Reviewed-on: https://chromium-review.googlesource.com/c/1278566
    Commit-Queue: Fergal Daly <fergal@chromium.org>
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599142}

    Changed files

    • third_party/WebKit/LayoutTests/css-shadow-parts/double-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-change-part-name-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-change-partmap-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-complex-selector-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/precedence-part-vs-part.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/simple-forward.html
    • third_party/blink/renderer/core/dom/element_test.cc
    • third_party/blink/renderer/core/dom/names_map.cc
    • third_party/blink/renderer/core/dom/names_map_test.cc
    • third_party/blink/renderer/core/html/parser/html_parser_idioms.h
  5. Chrome OS Powerwash screen: update icon and illustration.

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:22:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision afc97ac06f5d3677c1016d1530c1e196844e2432

    Comments

    Chrome OS Powerwash screen: update icon and illustration.
    
    
    Bug: 894280
    Change-Id: I0d478790d35323008a0622404ebde6983fea06ae
    Reviewed-on: https://chromium-review.googlesource.com/c/1278211
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599141}

    Changed files

    • chrome/browser/resources/chromeos/login/images/1x/reset_illustration_1x.svg
    • chrome/browser/resources/chromeos/login/images/2x/reset_illustration_2x.svg
    • chrome/browser/resources/chromeos/login/images/reset_illustration_1x.png
    • chrome/browser/resources/chromeos/login/images/reset_illustration_2x.png
    • chrome/browser/resources/chromeos/login/oobe_reset.css
    • chrome/browser/resources/chromeos/login/oobe_reset.html
  6. Move InstallAttributes to chromeos/settings

    Changed by A Olsen - olsenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:19:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aa6c62dce936e966e2db445045dd04414553642b

    Comments

    Move InstallAttributes to chromeos/settings
    
    Necessary for moving CrosSettings to chromeos/settings, so it
    can eventually be used by Mustash.
    
    The following changes were necessary:
    1. Move install_attributes{.h, .cc} and unit_test.cc
    2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn
    (destination)
    3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h,
    which is included by install_attributes.h
    
    4. Unfortunately, that same dependency lead to a circular dependency.
    I was able to avoid that by separating out a "common_constants" rule in
    components/policy/core/common, so that chromeos/settings only depends on
    that, and not on all of components/policy. So I had to change
    components/policy/core/common/BUILD.gn
    and I removed an unnecessary include from
    components/policy/core/common/cloud/cloud_policy_constants.cc
    
    5. Update #include directives for install_attributes to point to new
    location. This is the other 22 files, all with diffs of +1 -1.
    
    Bug: 446937
    Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288
    Reviewed-on: https://chromium-review.googlesource.com/c/1264757
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Commit-Queue: A Olsen <olsen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599140}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/app_mode/kiosk_app_manager.h
    • chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/dbus/dbus_helper.cc
    • chrome/browser/chromeos/login/demo_mode/demo_session.cc
    • chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
    • chrome/browser/chromeos/policy/blocking_login_browsertest.cc
    • chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
    • chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
    • chrome/browser/chromeos/policy/enrollment_status_chromeos.h
    • chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
    • chrome/browser/chromeos/settings/device_settings_provider.cc
    • chrome/browser/chromeos/settings/stub_install_attributes.h
    • chrome/browser/chromeos/system/device_disabling_manager.cc
    • chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
    • chrome/browser/ui/webui/policy_ui_handler.cc
    • chromeos/DEPS
    • chromeos/settings/BUILD.gn
    • chromeos/settings/install_attributes.cc
    • chromeos/settings/install_attributes.h
    • chromeos/settings/install_attributes_unittest.cc
    • components/policy/core/common/BUILD.gn
    • components/policy/core/common/cloud/cloud_policy_constants.cc
  7. Import wpt@6446b4dc89324df48019ef6fa4999595d1f80abf

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:18:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 112288aae86b2fcd3dde5b2a67872e292e54a8b0

    Comments

    Import wpt@6446b4dc89324df48019ef6fa4999595d1f80abf
    
    Using wpt-import in Chromium fb7986d88b0b8f174020916003d6939d2d928b83.
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25972
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    hongchan@chromium.org, rtoy@chromium.org:
      external/wpt/webaudio
    
    NOAUTOREVERT=true
    TBR=robertma
    
    No-Export: true
    Change-Id: I9f8c2a91eb58657997bd243420a319e96a3ebc02
    Reviewed-on: https://chromium-review.googlesource.com/c/1278059
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599139}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-reuse.html
  8. Override stub path before PreEarlyInitDBus

    Changed by Roman Sorokin - rsorokinohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:10:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b80ea1c80ef7c8ec439c14def8120498fc35eda8

    Comments

    Override stub path before PreEarlyInitDBus
    
    Otherwise install attributes are not loaded on the linux Chrome OS
    build.
    
    TEST=manual
    
    Bug: 848615, 729596
    Change-Id: I445b2b337b707822459c076058610f49f02767ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1264643
    Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Xi Han <hanxi@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599138}

    Changed files

    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/metrics/chrome_feature_list_creator.cc
  9. Chrome OS: Integrate Discover PIN setup into First run UI.

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:08:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 761a7e81af6dfcf0e5e1c29721d9a9c73a3dd19a

    Comments

    Chrome OS: Integrate Discover PIN setup into First run UI.
    
    Bug: 852553
    Change-Id: I215392305eee1555441d5dd66f0bb2908d0f5525
    Reviewed-on: https://chromium-review.googlesource.com/c/1250136
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599137}

    Changed files

    • chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc
    • chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.h
    • chrome/browser/chromeos/login/oobe_interactive_ui_test.cc
    • chrome/browser/chromeos/login/session/user_session_manager.cc
    • chrome/browser/chromeos/login/wizard_controller.cc
    • chrome/browser/chromeos/login/wizard_controller.h
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.h
    • chrome/browser/ui/webui/chromeos/login/discover/discover_ui.cc
  10. Fix naming issue when renaming files inside My files

    Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:02:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 40a6cb9be79a8d05395498a705e59d50cbb77f57

    Comments

    Fix naming issue when renaming files inside My files
    
    Change DirectoryModel to "unwrap" VolumeEntry when it's selected via
    file list. This fixes the issue where after selecting a VolumeEntry any
    operation in the private API would fail because it wouldn't be able to
    send a VolumeEntry to private API, because it requires a real Entry.
    
    This fixes the user issue of trying to rename and always getting "Use
    shorter name" error, even with a short name.
    
    Update FakeEntry to be an implementation of FilesAppDirEntry, since all
    users were using as directory, also update some functions to typing to
    use FilesAppDirEntry instead of FakeEntry which is more correct.
    
    Test: browser_tests --gtest_filter="*/myFilesFolderRename"
    Bug: 889636
    Change-Id: Ieb75ffbb811a91e4742fb7a49a3badfd129376ad
    Reviewed-on: https://chromium-review.googlesource.com/c/1276067
    Reviewed-by: Joel Hockey <joelhockey@chromium.org>
    Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599136}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • ui/file_manager/file_manager/background/js/volume_info_impl.js
    • ui/file_manager/file_manager/common/js/files_app_entry_types.js
    • ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.js
    • ui/file_manager/file_manager/foreground/js/directory_model.js
    • ui/file_manager/file_manager/foreground/js/file_manager.js
    • ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
    • ui/file_manager/file_manager/foreground/js/file_watcher.js
    • ui/file_manager/integration_tests/file_manager/my_files.js
  11. media/gpu/v4l2: workaround VIDIOC_G_FMT bug in libtegrav4l2.so.

    Changed by Alexandre Courbot - acourbotohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:54:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 029544dab67d79059b7610a92890091520ef7603

    Comments

    media/gpu/v4l2: workaround VIDIOC_G_FMT bug in libtegrav4l2.so.
    
    libtegrav4l2.so's implementation of V4L2_G_FMT has a bug which will make
    it return 0 planes for single-plane multiplanar formats. We obviously
    cannot have a multiplanar format with 0 planes, so add a workaround at
    the fake-ioctl level. Implement it as a case-switch for future-proofing
    against other workarounds we will likely have to add.
    
    Also add a few recommendations in v4l2_device.cc against the temptation
    to spare some memory by using an appropriately-sized array of
    v4l2_planes: it turns out libv4l2 also likes to write above the number
    of passed planes, and using anything shorter than VIDEO_MAX_PLANES will
    result in memory corruption DCHECKS being raised.
    
    BUG=893661
    TEST=Checked that VDA unittest was passing on both hana and nyan_big.
    
    Change-Id: I7ea638f19f5bf0bdfaa0a47885577eb9dec4c225
    Reviewed-on: https://chromium-review.googlesource.com/c/1275727
    Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
    Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
    Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599135}

    Changed files

    • media/gpu/v4l2/tegra_v4l2_device.cc
    • media/gpu/v4l2/v4l2_device.cc
  12. Add browser tests for when we show the cookie exception

    Changed by Jochen Eisinger - jochenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:53:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df554d02051d43d493d30cdf39fb1ee7566355bf

    Comments

    Add browser tests for when we show the cookie exception
    
    Depending on the sync / sign-in state.
    
    BUG=890925
    R=tangltom@chromium.org, msarda@chromium.org
    
    Change-Id: I784f13a4981250f851df770d111a13969a6892a6
    Reviewed-on: https://chromium-review.googlesource.com/c/1273521
    Commit-Queue: Jochen Eisinger <jochen@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599134}

    Changed files

    • chrome/browser/browsing_data/counters/browsing_data_counter_utils_browsertest.cc
    • chrome/test/BUILD.gn