Home | Search | chromium - Builders
Login

Builder Mac Release (Intel) Build 103196 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revision346d1aac0d7c49126b8a9943434ee88af85481af
Got Revision346d1aac0d7c49126b8a9943434ee88af85481af

Execution:

Steps and Logfiles:

Show:
  1. ( 488 ms ) setup_build
    running recipe: "chromium"
  2. ( 359 ms ) report builders
     
    running tester 'Mac Release (Intel)' on master 'chromium.gpu'
  3. ( 10 mins 2 secs ) bot_update
    [70GB/232GB used (30%)]
  4. ( 2 secs ) swarming.py --version
    0.13
  5. ( 546 ms ) ensure_installed
  6. ( 23 secs ) gclient runhooks
  7. ( 578 ms ) read test spec (chromium.gpu.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.json
  8. ( 577 ms ) lookup builder GN args
     
    dcheck_always_on = true
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  9. ( 2 secs ) build directory
  10. ( 612 ms ) find isolated tests
  11. ( 1 secs ) wait for tasks
  12. ( 4 secs ) angle_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 52s
  13. ( 2 secs ) gl_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 8s
  14. ( 2 secs ) gl_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 14s
  15. ( 1 secs ) wait for tasks (2)
  16. ( 2 secs ) hardware_accelerated_feature_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 26s
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  17. ( 2 secs ) depth_capture_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 27s
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  18. ( 2 secs ) info_collection_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 25s
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  19. ( 2 secs ) tab_capture_end2end_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 36s
  20. ( 8 secs ) wait for tasks (3)
  21. ( 2 secs ) gpu_process_launch_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 57s
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  22. ( 992 ms ) wait for tasks (4)
  23. ( 2 secs ) screenshot_sync_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 54s
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  24. ( 1 secs ) wait for tasks (5)
  25. ( 2 secs ) maps_pixel_test on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:00.854068
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  26. ( 59 secs ) wait for tasks (6)
  27. ( 2 secs ) context_lost_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:49.170060
    Total tests: 10
    * Passed: 10 (10 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  28. ( 1 mins 5 secs ) wait for tasks (7)
  29. ( 2 secs ) trace_test on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:02:34.974590
    Total tests: 36
    * Passed: 18 (18 expected, 0 unexpected)
    * Skipped: 18 (18 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 2 mins 2 secs ) wait for tasks (8)
  31. ( 2 secs ) pixel_test on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:03:37.499476
    Total tests: 57
    * Passed: 54 (54 expected, 0 unexpected)
    * Skipped: 3 (3 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  32. ( 1 mins 56 secs ) webgl_conformance_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Max shard duration: 0:07:12.391062 (shard #1)
    Min shard duration: 0:02:27.045889 (shard #0)
    Total tests: 932
    * Passed: 925 (925 expected, 0 unexpected)
    * Skipped: 7 (7 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  33. ( 360 ms ) Tests statistics
     
    Stats
    Total shards: 15
    Total runtime: 0:19:34.991983
     

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm118-m9" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541786105685766, "id": "8930313808403444768", "project": "chromium", "tags": ["builder:Mac Release (Intel)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/346d1aac0d7c49126b8a9943434ee88af85481af", "gitiles_ref:refs/heads/master", "parent_buildername:GPU Mac Builder", "parent_buildnumber:138310", "scheduler_invocation_id:9095743870634017648", "scheduler_job_id:chromium/Mac Release (Intel)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Mac Release (Intel)" setup_build
buildnumber 103196 setup_build
mastername "chromium.gpu" setup_build
parent_buildername "GPU Mac Builder" setup_build
parent_got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" setup_build
parent_got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" setup_build
parent_got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" setup_build
parent_got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" setup_build
parent_got_revision "346d1aac0d7c49126b8a9943434ee88af85481af" setup_build
parent_got_revision_cp "refs/heads/master@{#606891}" setup_build
parent_got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" setup_build
parent_got_v8_revision "f6ed3c5d7eb73112326476d681f0f79d40fc1e0e" setup_build
parent_got_v8_revision_cp "refs/heads/7.2.287@{#1}" setup_build
parent_got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25544}" setup_build
parent_mastername "chromium.gpu" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "346d1aac0d7c49126b8a9943434ee88af85481af" setup_build
swarm_hashes {"angle_unittests": "6777bd76910c8e02ffa6b26e6bf298ad125aa530", "browser_tests": "9002d90b92ee0bf1be28abc7c0e0b20d8e11f78a", "gl_tests": "90ba47c4116da95cda5d1095bf1fed0b4c6c57ce", "gl_unittests": "cd3bc39057fad99d458f3f4ba18879b0d9354d22", "telemetry_gpu_integration_test": "8c9a6cba09c10ab305dc83029defce8f70e2fa76"} setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "346d1aac0d7c49126b8a9943434ee88af85481af" bot_update
got_revision_cp "refs/heads/master@{#606891}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "f6ed3c5d7eb73112326476d681f0f79d40fc1e0e" bot_update
got_v8_revision_cp "refs/heads/7.2.287@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. Bin Wu (wubohnoyoudont@chromium.org)
  2. Javier Ernesto Flores Robles (javierroblesohnoyoudont@chromium.org)
  3. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  4. Fady Samuel (fsamuelohnoyoudont@chromium.org)
  5. Joe DeBlasio (jdeblasioohnoyoudont@chromium.org)
  6. Sky Malice (skymohnoyoudont@google.com)
  7. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  8. Hayato Ito (hayatoohnoyoudont@chromium.org)
  9. Mathias Carlen (mcarlenohnoyoudont@chromium.org)
  10. Lan Wei (lanweiohnoyoudont@chromium.org)
  11. Becky Zhou (huayinzohnoyoudont@chromium.org)
  12. Hirokazu Honda (hirohohnoyoudont@chromium.org)

Timing:

Create Friday, 09-Nov-18 17:55:05 UTC
Start Friday, 09-Nov-18 17:55:09 UTC
End Friday, 09-Nov-18 18:14:43 UTC
Pending 3 secs
Execution 19 mins 33 secs

All Changes:

  1. Reland "Export the quic batch writer code to Chromium. Note it's not used anywhere in Chrome, we are just exporting the code so people outside of Google can take a look."

    Changed by Bin Wu - wubohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:45:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 346d1aac0d7c49126b8a9943434ee88af85481af

    Comments

    Reland "Export the quic batch writer code to Chromium. Note it's not used anywhere in Chrome, we are just exporting the code so people outside of Google can take a look."
    
    This reverts commit 683a348730bbea7ccea7158eacc04b928b3d5256.
    
    
    In addition to the auto-revert, I also changed two bzero calls to memset calls. I don't know why, but net_unittest under msan fails with a use-of-uninitialized-value: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930601665674446576/+/steps/net_unittests/0/stdout
    
    The msan error goes away after I changed the following bzero(s) into memset(s):
    
    diff --git a/net/third_party/quic/platform/impl/quic_linux_socket_utils.h b/net/third_party/quic/platform/impl/quic_linux_socket_utils.h
    index 94f055f35564..198e266dfdf2 100644
    --- a/net/third_party/quic/platform/impl/quic_linux_socket_utils.h
    +++ b/net/third_party/quic/platform/impl/quic_linux_socket_utils.h
    @@ -102,7 +102,7 @@ class QuicMMsgHdr {
         }
    
         storage_.reset(new char[StorageSize()]);
    -    bzero(&storage_[0], StorageSize());
    +    memset(&storage_[0], 0, StorageSize());
    
         int i = -1;
         for (auto it = first; it != last; ++it) {
    diff --git a/net/third_party/quic/platform/impl/quic_socket_utils.cc b/net/third_party/quic/platform/impl/quic_socket_utils.cc
    index c25f4697dbef..1f252e50f953 100644
    --- a/net/third_party/quic/platform/impl/quic_socket_utils.cc
    +++ b/net/third_party/quic/platform/impl/quic_socket_utils.cc
    @@ -78,7 +78,7 @@ void* QuicMsgHdr::GetNextCmsgDataInternal(int cmsg_level,
    
       if (cmsg_ == nullptr) {
         DCHECK_EQ(nullptr, hdr_.msg_control);
    -    bzero(cbuf_, cbuf_size_);
    +    memset(cbuf_, 0, cbuf_size_);
         hdr_.msg_control = cbuf_;
         cmsg_ = CMSG_FIRSTHDR(&hdr_);
       } else {
    
    
    R=rch@chromium.org
    
    Change-Id: Ibe60068cb87c0f974088b8c1601cc516ee333106
    Reviewed-on: https://chromium-review.googlesource.com/c/1329348
    Commit-Queue: Bin Wu <wub@chromium.org>
    Reviewed-by: Ryan Hamilton <rch@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606891}

    Changed files

    • net/BUILD.gn
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_base.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_base.h
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_buffer.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_buffer.h
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_buffer_test.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_batch_writer_test.h
    • net/third_party/quic/platform/impl/batch_writer/quic_gso_batch_writer.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_gso_batch_writer.h
    • net/third_party/quic/platform/impl/batch_writer/quic_gso_batch_writer_test.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_sendmmsg_batch_writer.cc
    • net/third_party/quic/platform/impl/batch_writer/quic_sendmmsg_batch_writer.h
    • net/third_party/quic/platform/impl/batch_writer/quic_sendmmsg_batch_writer_test.cc
    • net/third_party/quic/platform/impl/quic_linux_socket_utils.cc
    • net/third_party/quic/platform/impl/quic_linux_socket_utils.h
    • net/third_party/quic/platform/impl/quic_linux_socket_utils_test.cc
    • net/third_party/quic/platform/impl/quic_socket_utils.cc
    • net/third_party/quic/platform/impl/quic_socket_utils.h
  2. [iOS][MF] Adds password related histograms

    Changed by Javier Ernesto Flores Robles - javierroblesohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:41:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f350cfe2c23c02c23f852840ee9d5e08d9c61e96

    Comments

    [iOS][MF] Adds password related histograms
    
    Bug: 878388
    Change-Id: Ia0a6622596753d87888e480401e38f7ef61ae539
    Reviewed-on: https://chromium-review.googlesource.com/c/1326013
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606890}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/password_view_controller.mm
    • tools/metrics/histograms/histograms.xml
  3. Roll src-internal 827de2c806ba..5fa11106b909 (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 17:40:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7e4f2a9f17b74405f73aca4ecee7dcd639477de6

    Comments

    Roll src-internal 827de2c806ba..5fa11106b909 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/827de2c806ba..5fa11106b909
    
    
    Created with:
      gclient setdep -r src-internal@5fa11106b909
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ie1b9b04d41e2a6dfe8e4fa45f0d25892052660e1
    Reviewed-on: https://chromium-review.googlesource.com/c/1329503
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606889}

    Changed files

    • DEPS
  4. viz: Plumb LocalSurfaceIdAllocation to more places [part 5]

    Changed by Fady Samuel - fsamuelohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:36:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7e806513b1b91da6e96a56bfd3ca5f464c4666b9

    Comments

    viz: Plumb LocalSurfaceIdAllocation to more places [part 5]
    
    viz::LocalSurfaceIdAllocation bundles a viz::LocalSurfaceId and an
    allocation time for that viz::LocalSurfaceId. The purpose of this allocation
    time is to determine how long it takes for a surface to get embedded once
    an ID has been allocated for it.
    
    There was some concern raised about drift between LocalSurfaceIds and allocation
    times and so a previous CL bundled the two together in a class. This CL plumbs
    LocalSurfaceIdAllocation to more places to ensure the two quantities remain
    in sync with one another.
    
    This CL plumbs removes various accessors on ChildLocalSurfaceIdAllocator and
    ParentLocalSurfaceIdAllocator that return an allocation time or LocalSurfaceId
    independent of the other. This is to encourage future plumbing of
    LocalSurfaceIdAllocation instead.
    
    Bug: 655231
    Change-Id: I3118cc06e0afa04914a0e2e7457ffdfd5ad5778d
    Reviewed-on: https://chromium-review.googlesource.com/c/1327573
    Reviewed-by: Jonathan Ross <jonross@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Commit-Queue: Fady Samuel <fsamuel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606888}

    Changed files

    • cc/test/layer_tree_test.cc
    • cc/test/layer_tree_test.h
    • cc/trees/layer_tree_host_impl.cc
    • cc/trees/layer_tree_host_impl.h
    • cc/trees/layer_tree_host_unittest.cc
    • components/viz/common/surfaces/child_local_surface_id_allocator.h
    • components/viz/common/surfaces/child_local_surface_id_allocator_unittest.cc
    • components/viz/common/surfaces/parent_local_surface_id_allocator.h
    • components/viz/common/surfaces/parent_local_surface_id_allocator_unittest.cc
    • content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
    • third_party/blink/renderer/platform/graphics/surface_layer_bridge.cc
    • third_party/blink/renderer/platform/graphics/video_frame_submitter.cc
    • third_party/blink/renderer/platform/graphics/video_frame_submitter_test.cc
  5. Record Android revokes in Permissions.Action.Notification.

    Changed by Joe DeBlasio - jdeblasioohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:35:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f8c0f174bb015976222531ead359ade19b488833

    Comments

    Record Android revokes in Permissions.Action.Notification.
    
    This CL modifies fixes a bug in which metrics were not being recorded on
    Android when notification permissions were revoked. It adds a missing
    ScopedRevocationReporter for Chrome-visible changes, and adds detection
    code for when notification permissions are revoked in Android O+
    system channel settings.
    
    Bug: 782126
    Change-Id: I609e909936d09e6dd948f0601bbf73ecdb6b8b75
    Reviewed-on: https://chromium-review.googlesource.com/c/1324394
    Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
    Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    Reviewed-by: Christopher Thompson <cthomp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606887}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferenceBridge.java
    • chrome/browser/android/preferences/website_preference_bridge.cc
    • chrome/browser/permissions/permission_uma_util.h
    • tools/metrics/ukm/ukm.xml
  6. [Feed] Check loadUrlParams for null, fallback to opening online.

    Changed by Sky Malice - skymohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 17:33:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 60b47f98f87e0f3689826e4342fab09b7a35ed5e

    Comments

    [Feed] Check loadUrlParams for null, fallback to opening online.
    
    Bug: 901179
    Change-Id: Ieb3a421a7930ddc0014f7ef57b6a8f6d89dc3615
    Reviewed-on: https://chromium-review.googlesource.com/c/1315358
    Commit-Queue: Sky Malice <skym@chromium.org>
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606886}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedLoggingBridge.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/action/FeedActionHandler.java
    • chrome/android/junit/src/org/chromium/chrome/browser/feed/action/FeedActionHandlerTest.java
    • chrome/browser/android/feed/feed_logging_bridge.cc
    • chrome/browser/android/feed/feed_logging_bridge.h
  7. Roll src/third_party/perfetto cf90797ef05a..5fc6c2c52e7b (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 17:32:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0475284ad58e36e9950059000bb7ec3556bb31bb

    Comments

    Roll src/third_party/perfetto cf90797ef05a..5fc6c2c52e7b (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/cf90797ef05a..5fc6c2c52e7b
    
    
    git log cf90797ef05a..5fc6c2c52e7b --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 lalitm@google.com Merge "trace_processor: allow integers to be compared against doubles"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@5fc6c2c52e7b
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: Ifd53d09565e264f09c1deffb23f8adfce3a34958
    Reviewed-on: https://chromium-review.googlesource.com/c/1329505
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606885}

    Changed files

    • DEPS
  8. Fix a bug in https://crrev.com/c/1272937, where event.target can be still null

    Changed by Hayato Ito - hayatoohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:31:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2ed9605b4c99774d8865dbd190e13c9fe5c2d03a

    Comments

    Fix a bug in https://crrev.com/c/1272937, where event.target can be still null
    
    Fix a bug in the previous CL, https://crrev.com/c/1272937, where event.target
    can be null when GetElement() returns nullptr.
    
    Bug: 892970, 893449, 902287
    Change-Id: I7a08227d39117c2dc90fe720f0d6ffd62d9b2ea6
    Reviewed-on: https://chromium-review.googlesource.com/c/1322177
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606884}

    Changed files

    • third_party/blink/renderer/modules/accessibility/ax_object.cc
  9. [Autofill Assistant] Handle payment request dismiss.

    Changed by Mathias Carlen - mcarlenohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:30:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f3fe32fc147390a01e54fbd7c54e62ca3a3b8ad4

    Comments

    [Autofill Assistant] Handle payment request dismiss.
    
    Before this patch the payment request UI did not properly handle cancel
    and back button.
    
    This patch notifies the Autofill Assistant controller to shut down
    gracefully with a 'give up' message whenever the payment request UI has
    been canceled.
    
    Bug: 806868
    Change-Id: Ie3d83bf48a2004f0a6a72763c4b509b3db023ff9
    Reviewed-on: https://chromium-review.googlesource.com/c/1326499
    Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606883}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantPaymentRequest.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/PaymentRequestUI.java
    • components/autofill_assistant_strings.grdp
  10. Add action_sequence in testdriver

    Changed by Lan Wei - lanweiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:28:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 687313c56366619151285b4d87847b61e6547cbc

    Comments

    Add action_sequence in testdriver
    
    After we expose test_driver.Actions API to web users, we add their
    implementation in our testdriver file, and fix the wpt tests of
    Actions API.
    
    Bug: 893480
    Change-Id: Ib02c0223208eeb2cc30c2ca35b98d5fc938baa2c
    Reviewed-on: https://chromium-review.googlesource.com/c/1289119
    Commit-Queue: Lan Wei <lanwei@chromium.org>
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606882}

    Changed files

    • content/common/input/actions_parser.cc
    • content/common/input/actions_parser.h
    • content/common/input/actions_parser_unittest.cc
    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/elementPosition.html
    • third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/eventOrder.html
    • third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_pointermove.html
    • third_party/WebKit/LayoutTests/external/wpt/resources/testdriver-actions.js
    • third_party/WebKit/LayoutTests/external/wpt/resources/testdriver.js
    • third_party/WebKit/LayoutTests/external/wpt_automation/pointerevents/pointerevent_pointermove-manual-automation.js
    • third_party/WebKit/LayoutTests/resources/testdriver-vendor.js
    • third_party/WebKit/LayoutTests/resources/testdriver.js
  11. [Feed] Fix Feed NTP not clickable when hardware keyboard is connected

    Changed by Becky Zhou - huayinzohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:25:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision acb2df40a36d52ef4649dc82d779b8b024112358

    Comments

    [Feed] Fix Feed NTP not clickable when hardware keyboard is connected
    
    Bug: 891877
    Change-Id: I8c0cae6ad80f290580975983cb2d2f4f6286509b
    Reviewed-on: https://chromium-review.googlesource.com/c/1325082
    Commit-Queue: Becky Zhou <huayinz@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606881}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java
  12. Reland "media/gpu/VEA unittest: Test DMABuf-backed input buffers"

    Changed by Hirokazu Honda - hirohohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:21:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 341861b66e4ad99689c9842cdb723cf7429d3157

    Comments

    Reland "media/gpu/VEA unittest: Test DMABuf-backed input buffers"
    
    This adds the command line option, --natvie_input, that VEA unittest passes
    DMABuf-backed video frame to VEA.
    DMABufs are obtained by gbm though NativePixmap. To create NativePixmap on
    Chrome OS, it needs to set up Ozone environment properly. Therefore, this change
    also makes VEA unittest dependent on Ozone.
    
    BUG=chromium:895230
    TEST=VEA unittest on eve w/wo --native_input
    TBR=posciak@chromium.org
    
    Change-Id: I2998f0695813e5e1b77ae2136140eebc385636bf
    Reviewed-on: https://chromium-review.googlesource.com/c/1329121
    Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
    Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606880}

    Changed files

    • media/gpu/BUILD.gn
    • media/gpu/test/generic_dmabuf_video_frame_mapper.cc
    • media/gpu/test/rendering_helper.cc
    • media/gpu/test/texture_ref.cc
    • media/gpu/test/texture_ref.h
    • media/gpu/test/video_encode_accelerator_unittest_helpers.cc
    • media/gpu/test/video_encode_accelerator_unittest_helpers.h
    • media/gpu/test/video_frame_mapper_factory.cc
    • media/gpu/test/video_frame_mapper_factory.h
    • media/gpu/test/video_frame_validator.cc
    • media/gpu/test/video_frame_validator.h
    • media/gpu/video_decode_accelerator_unittest.cc
    • media/gpu/video_encode_accelerator_unittest.cc