Home | Search | chromium - Builders
Login

Builder Mac FYI Retina Release (NVIDIA) Build 3844 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revision5395d94feaf7a04c1a7fd9832d3750c636d6dea1
Got Revision5395d94feaf7a04c1a7fd9832d3750c636d6dea1

Execution:

Steps and Logfiles:

Show:
  1. ( 341 ms ) setup_build
    running recipe: "chromium"
  2. ( 220 ms ) report builders
     
    running tester 'Mac FYI Retina Release (NVIDIA)' on master 'chromium.gpu.fyi'
  3. ( 1 mins 21 secs ) bot_update
    [94GB/464GB used (20%)]
  4. ( 2 secs ) swarming.py --version
    0.13
  5. ( 406 ms ) ensure_installed
  6. ( 16 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
  8. ( 403 ms ) lookup builder GN args
     
    build_angle_gles1_conform_tests = true
    dcheck_always_on = true
    ffmpeg_branding = "Chrome"
    internal_gles2_conform_tests = true
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  9. ( 1 secs ) build directory
  10. ( 383 ms ) find isolated tests
  11. ( 2 secs ) angle_end2end_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Max shard duration: 0:01:42.617420 (shard #3)
    Min shard duration: 31s (shard #1)
  12. ( 3 secs ) angle_unittests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:03:25.473629
  13. ( 2 mins 18 secs ) tab_capture_end2end_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:02:13.685973
  14. ( 1 mins 46 secs ) gl_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:01:39.667718
  15. ( 36 secs ) gl_unittests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 32s
  16. ( 5 mins 17 secs ) gles2_conform_test on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:05:15.506499
  17. ( 1 mins 5 secs ) gpu_unittests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:01:00.084652
  18. ( 1 mins 4 secs ) services_unittests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:01:01.788924
  19. ( 1 secs ) swiftshader_unittests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 23s
  20. ( 5 mins 39 secs ) context_lost_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:05:31.589246
    Total tests: 10
    * Passed: 10 (10 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  21. ( 1 mins 54 secs ) depth_capture_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:01:51.678172
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  22. ( 3 mins 30 secs ) gpu_process_launch_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:03:26.199563
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  23. ( 1 mins 20 secs ) hardware_accelerated_feature_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:01:16.493674
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  24. ( 1 mins 16 secs ) info_collection_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:01:15.081994
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  25. ( 2 mins 29 secs ) maps_pixel_test on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:02:22.976066
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  26. ( 5 mins 56 secs ) pixel_test on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:05:49.346851
    Total tests: 57
    * Passed: 54 (54 expected, 0 unexpected)
    * Skipped: 3 (3 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  27. ( 3 mins 5 secs ) screenshot_sync_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:02:59.879463
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  28. ( 5 mins 30 secs ) trace_test on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:05:20.933014
    Total tests: 36
    * Passed: 18 (18 expected, 0 unexpected)
    * Skipped: 18 (18 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 32 mins 39 secs ) webgl2_conformance_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Max pending time: 34s (shard #19)
    Max shard duration: 0:32:04.693810 (shard #6)
    Min shard duration: 0:08:33.034087 (shard #1)
    Total tests: 2796
    * Passed: 2731 (2731 expected, 0 unexpected)
    * Skipped: 65 (65 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 29 mins 37 secs ) webgl_conformance_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Max pending time: 0:01:22.850904 (shard #1)
    Max shard duration: 0:28:12.491529 (shard #1)
    Min shard duration: 0:10:07.683081 (shard #0)
    Total tests: 932
    * Passed: 925 (925 expected, 0 unexpected)
    * Skipped: 7 (7 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  31. ( 301 ms ) Tests statistics
     
    Stats
    Total shards: 43
    Total runtime: 9:55:28.412567
     

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "build84-m9" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541777565812550, "id": "8930322763109493024", "project": "chromium", "tags": ["builder:Mac FYI Retina Release (NVIDIA)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/5395d94feaf7a04c1a7fd9832d3750c636d6dea1", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Mac Builder", "parent_buildnumber:27355", "scheduler_invocation_id:9095752825182792704", "scheduler_job_id:chromium/Mac FYI Retina Release (NVIDIA)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Mac FYI Retina Release (NVIDIA)" setup_build
buildnumber 3844 setup_build
mastername "chromium.gpu.fyi" setup_build
parent_buildername "GPU FYI Mac Builder" setup_build
parent_got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" setup_build
parent_got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" setup_build
parent_got_dawn_revision "284f33439871e1ae2556d3ada34b5d1b75a4fb20" setup_build
parent_got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" setup_build
parent_got_revision "5395d94feaf7a04c1a7fd9832d3750c636d6dea1" setup_build
parent_got_revision_cp "refs/heads/master@{#606844}" setup_build
parent_got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" setup_build
parent_got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" setup_build
parent_got_v8_revision_cp "refs/heads/7.2.286@{#1}" setup_build
parent_got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25544}" setup_build
parent_mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "5395d94feaf7a04c1a7fd9832d3750c636d6dea1" setup_build
swarm_hashes {"angle_end2end_tests": "fdac938759f6d2a1c8a19af8dea0ae553e096d2a", "angle_unittests": "b2be6e8b061241ca84a2688b463370ac41c1e47a", "browser_tests": "abda48ea49ba52a3e51e4f838ed2ec76801bef3c", "gl_tests": "b09576de0d21a6c495afbcc39e55f5c871b8d237", "gl_unittests": "a241f9ef503248e552520c7061063d9c47088144", "gles2_conform_test": "29bd8ab4f93b811c260973f4381917e3aeecf5fa", "gpu_unittests": "336cff3bccbd30112e66824d3aacad8cfb9f4a49", "services_unittests": "65a42671f5ed0a75d88f38a2f6b206582c829324", "swiftshader_unittests": "798caf633b7a656df19c59f6cf426d5e9e7f8814", "telemetry_gpu_integration_test": "32f757c60b1f6f8d4bc9be244b84c163d6d2350a"} setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "5395d94feaf7a04c1a7fd9832d3750c636d6dea1" bot_update
got_revision_cp "refs/heads/master@{#606844}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" bot_update
got_v8_revision_cp "refs/heads/7.2.286@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  2. Lukasz Suder (lsuderohnoyoudont@google.com)
  3. Greg Thompson (grtohnoyoudont@chromium.org)
  4. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  5. Corentin Wallez (cwallezohnoyoudont@chromium.org)
  6. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  7. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  8. Ioana Pandele (ioanapohnoyoudont@chromium.org)
  9. Sam Maier (smaierohnoyoudont@chromium.org)
  10. Hiroshige Hayashizaki (hiroshigeohnoyoudont@chromium.org)
  11. Rohit Rao (rohitraoohnoyoudont@chromium.org)
  12. Sigurdur Asgeirsson (siggiohnoyoudont@chromium.org)
  13. Mike Reed (reedohnoyoudont@google.com)
  14. Marc Treib (treibohnoyoudont@chromium.org)
  15. Marc Treib (treibohnoyoudont@chromium.org)
  16. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  17. Leonard Grey (lgreyohnoyoudont@chromium.org)
  18. Peter Kotwicz (pkotwiczohnoyoudont@chromium.org)
  19. Stephane Zermatten (szermattohnoyoudont@chromium.org)
  20. Mark Cogan (marqohnoyoudont@google.com)
  21. gogerald (gogeraldohnoyoudont@google.com)
  22. Clemens Arbesser (arbesserohnoyoudont@google.com)
  23. Corentin Wallez (cwallezohnoyoudont@chromium.org)
  24. Xianzhu Wang (wangxianzhuohnoyoudont@chromium.org)
  25. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  26. Yuki Shiino (yukishiinoohnoyoudont@chromium.org)
  27. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  28. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  29. Mohamed Amir Yosef (mamirohnoyoudont@chromium.org)
  30. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  31. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)

Timing:

Create Friday, 09-Nov-18 15:32:45 UTC
Start Friday, 09-Nov-18 15:32:48 UTC
End Friday, 09-Nov-18 17:22:43 UTC
Pending 2 secs
Execution 1 hrs 49 mins

All Changes:

  1. Retire NotificationInlineReplies runtime enabled flag.

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:15:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5395d94feaf7a04c1a7fd9832d3750c636d6dea1

    Comments

    Retire NotificationInlineReplies runtime enabled flag.
    
    NotificationInlineReplies shipped in M70.
    
    BUG=834580
    
    Change-Id: Ibed1612aae4c21a239e9328d7134cd75169c713a
    Reviewed-on: https://chromium-review.googlesource.com/c/1323615
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606844}

    Changed files

    • third_party/blink/renderer/modules/notifications/notification_action.idl
    • third_party/blink/renderer/modules/notifications/notification_event.idl
    • third_party/blink/renderer/modules/notifications/notification_event_init.idl
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  2. [Autofill Assistant] Fixes Payement Request details bug.

    Changed by Lukasz Suder - lsuderohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:13:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision be08662134b0c40ff6913cf531e2fefed5c2d4d9

    Comments

    [Autofill Assistant] Fixes Payement Request details bug.
    
    Before all details where asked each time.
    
    Bug: 806868
    Change-Id: Ie3a278e2882d4829cfe2c54ac641d10abf5af2e6
    Reviewed-on: https://chromium-review.googlesource.com/c/1329167
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Commit-Queue: Lukasz Suder <lsuder@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606843}

    Changed files

    • components/autofill_assistant/browser/actions/get_payment_information_action.cc
  3. Fix the icons for the app menu and the upgrade item in it when an update is available.

    Changed by Greg Thompson - grtohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:12:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a5a766d75a0eb8006212cb5cee94d704650c787b

    Comments

    Fix the icons for the app menu and the upgrade item in it when an update is available.
    
    A regression was introduced in r581520 that caused the wrong icon and/or
    the wrong coloring to be used in some circumstances. This CL fixes this
    in two parts:
    
    - AppMenuIconController may decide that the "annoyance level" from a
      pending update is too low to bother the user. One bug introduced in
      r581520 was that the controller still notified delegates that the
      UPGRADE_NOTIFICATION icon type should be used in this case. Now, the
      VERY_LOW annoyance level is ignore entirely for beta and stable
      channels.
    
    - AppMenuModel no longer bases its decision to include the upgrade menu
      item directly on the UpgradeDetector. Rather, it now queries the
      AppMenuIconController. This ensures that the same logic is used for
      both the badging of the app menu and for the presence of the upgrade
      item in the menu.
    
    BUG=898958
    
    Change-Id: I4b761844365968a24bc69030d711122fcaf16e28
    Reviewed-on: https://chromium-review.googlesource.com/c/1312475
    Commit-Queue: Greg Thompson <grt@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606842}

    Changed files

    • chrome/browser/ui/toolbar/app_menu_icon_controller.cc
    • chrome/browser/ui/toolbar/app_menu_icon_controller.h
    • chrome/browser/ui/toolbar/app_menu_icon_controller_unittest.cc
    • chrome/browser/ui/toolbar/app_menu_model.cc
    • chrome/browser/ui/toolbar/app_menu_model.h
    • chrome/browser/ui/toolbar/app_menu_model_unittest.cc
    • chrome/browser/ui/views/toolbar/browser_app_menu_button.cc
    • chrome/browser/ui/views/toolbar/browser_app_menu_button.h
    • chrome/browser/ui/views/toolbar/toolbar_view.cc
    • chrome/browser/ui/views/toolbar/toolbar_view.h
    • chrome/test/BUILD.gn
  4. Import wpt@47f0061f15dd2973dab11d87c03f0c8264d32e02

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 15:09:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c42eb303c89bfba751ae499abfb7252e2ceb7532

    Comments

    Import wpt@47f0061f15dd2973dab11d87c03f0c8264d32e02
    
    Using wpt-import in Chromium 43d0eed3db77a5e6167b5ebbf6ecb3710790272a.
    With Chromium commits locally applied on WPT:
    270d4abddc "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content."
    
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    NOAUTOREVERT=true
    TBR=foolip
    
    No-Export: true
    Change-Id: I4bcac484d08efe8d6e6412d40b1c7d73ffe512d5
    Reviewed-on: https://chromium-review.googlesource.com/c/1329061
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606841}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/selection-api.idl
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/webrtc.idl
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/idlharness.https.window-expected.txt
    • third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
  5. testing/buildbot: add fake bots to run Dawn's GPU tests.

    Changed by Corentin Wallez - cwallezohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:05:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9f2b5efa43dfe2ff69fab31ba83c352ecf8e62ab

    Comments

    testing/buildbot: add fake bots to run Dawn's GPU tests.
    
    BUG=chromium:901830
    
    Change-Id: I5c5b0b08fadddc34f6a2d176ae39ebfae7e7f706
    Reviewed-on: https://chromium-review.googlesource.com/c/1326157
    Commit-Queue: Corentin Wallez <cwallez@chromium.org>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606840}

    Changed files

    • testing/buildbot/chromium.gpu.fyi.json
    • testing/buildbot/generate_buildbot_json.py
    • testing/buildbot/gn_isolate_map.pyl
    • testing/buildbot/test_suites.pyl
    • testing/buildbot/waterfalls.pyl
  6. Roll src/third_party/perfetto 606ed681f4ea..fd986312652f (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 15:03:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01d002523922e64775a90ae4fbcb831f3aebf024

    Comments

    Roll src/third_party/perfetto 606ed681f4ea..fd986312652f (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/606ed681f4ea..fd986312652f
    
    
    git log 606ed681f4ea..fd986312652f --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 hjd@google.com Merge "perfetto-ui: Fix UI with counter only traces"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@fd986312652f
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I602c7205239349ff0faf4467740388c6cb05725f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329044
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606839}

    Changed files

    • DEPS
  7. Roll src-internal c458532c0628..6166365225d6 (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 14:56:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 02a2080524dcf1a59efd81b88b8a6526fc6224ee

    Comments

    Roll src-internal c458532c0628..6166365225d6 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c458532c0628..6166365225d6
    
    
    Created with:
      gclient setdep -r src-internal@6166365225d6
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I57783466072640b229610c2550d50f9c46d0c4e9
    Reviewed-on: https://chromium-review.googlesource.com/c/1329043
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606838}

    Changed files

    • DEPS
  8. Add a provider for the Passwords UI in Settings

    Changed by Ioana Pandele - ioanapohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:51:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision feda313fc19c2032e21eed604a1a0e58d42587ee

    Comments

    Add a provider for the Passwords UI in Settings
    
    This CL introduces ManagePasswordsUIProvider, a class which aims to allow
    for alternative UI surfaces to be shown if available.
    
    Bug: 903249
    Change-Id: I8c03f2f539772044bd5ba0fa944fd5e441d43c76
    Reviewed-on: https://chromium-review.googlesource.com/c/1326488
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Ioana Pandele <ioanap@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606837}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java
    • chrome/android/java/src/org/chromium/chrome/browser/password_manager/ManagePasswordsUIProvider.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
    • chrome/android/java_sources.gni
  9. Apk for test proguard flags ignoring classes which don't exist

    Changed by Sam Maier - smaierohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:50:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b4fffd63b4281c67f7e142087c476ce903a5a08a

    Comments

    Apk for test proguard flags ignoring classes which don't exist
    
    Bug: 872904
    Change-Id: Ib178be906c8d74ecabd7cfafeba8e7cf3a3398ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1327331
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Reviewed-by: Sam Maier <smaier@chromium.org>
    Commit-Queue: Sam Maier <smaier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606836}

    Changed files

    • chrome/android/java/apk_for_test.flags
  10. Enable multiple WorkerFetchContext per one global scope

    Changed by Hiroshige Hayashizaki - hiroshigeohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:46:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7ede5922f5c054c81b5ea049651775ab0503582c

    Comments

    Enable multiple WorkerFetchContext per one global scope
    
    Currently WorkerFetchContext has the ownership of
    some objects originated from WebWorkerFetchContext.
    To create multiple WorkerFetchContexts
    for one WorkerOrWorkletGlobalScope/WebWorkerFetchContext,
    this CL moves these ownership outside WorkerFetchContext.
    Namely,
    - url_loader_factory_ and script_loader_factory_
      from WorkerFetchContext to WebWorketFetchContext subclasses, and
    - subresource_filter_ from WorkerFetchContext to
      WorkerOrWorkletGlobalScope.
      Still |WorkerFetchContext::subresource_filter_| is kept, but
      it is created in WorkerOrWorkletGlobalScope and passed to
      WorkerFetchContext.
    
    This CL doesn't change the observable behavior.
    This CL creates WebURLLoaderFactory a little more eagerly, i.e.
    when WorkerFetchContext is created,
    while previously it was created when
    WorkerFetchContext::CreateURLLoader() is called for the first time.
    
    Bug: 880027, 903579
    Change-Id: I84a8bafee25b7f293201a271d198260e2dfb8e68
    Reviewed-on: https://chromium-review.googlesource.com/c/1193385
    Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606835}

    Changed files

    • content/renderer/loader/web_worker_fetch_context_impl.cc
    • content/renderer/loader/web_worker_fetch_context_impl.h
    • content/renderer/service_worker/service_worker_fetch_context_impl.cc
    • content/renderer/service_worker/service_worker_fetch_context_impl.h
    • third_party/blink/public/platform/web_worker_fetch_context.h
    • third_party/blink/renderer/core/loader/worker_fetch_context.cc
    • third_party/blink/renderer/core/loader/worker_fetch_context.h
    • third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
    • third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h
  11. [ios] Deletes unused code that was migrated from ios/clean.

    Changed by Rohit Rao - rohitraoohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:41:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6e3ace0051b91c7144046c60acd04c7d658c9b09

    Comments

    [ios] Deletes unused code that was migrated from ios/clean.
    
    BUG=None
    
    Change-Id: I3a14f465f152e9b1b514802723093e9702edc001
    Reviewed-on: https://chromium-review.googlesource.com/c/1326487
    Reviewed-by: edchin <edchin@chromium.org>
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: edchin <edchin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606834}

    Changed files

    • ios/chrome/browser/browser_state/BUILD.gn
    • ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm
    • ios/chrome/browser/ui/coordinators/BUILD.gn
    • ios/chrome/browser/ui/coordinators/browser_coordinator+internal.h
    • ios/chrome/browser/ui/coordinators/browser_coordinator.h
    • ios/chrome/browser/ui/coordinators/browser_coordinator.mm
    • ios/chrome/browser/ui/coordinators/browser_coordinator_test.h
    • ios/chrome/browser/ui/coordinators/browser_coordinator_test.mm
    • ios/chrome/browser/ui/coordinators/browser_coordinator_test_util.h
    • ios/chrome/browser/ui/coordinators/browser_coordinator_test_util.mm
    • ios/chrome/browser/ui/coordinators/browser_coordinator_unittest.mm
    • ios/chrome/browser/ui/coordinators/test_browser_coordinator.h
    • ios/chrome/browser/ui/coordinators/test_browser_coordinator.mm
    • ios/chrome/browser/ui/main_content/BUILD.gn
    • ios/chrome/browser/ui/main_content/main_content_coordinator.h
    • ios/chrome/browser/ui/main_content/main_content_coordinator.mm
    • ios/chrome/browser/ui/main_content/main_content_coordinator_unittest.mm
    • ios/chrome/browser/ui/overlays/BUILD.gn
    • ios/chrome/browser/ui/overlays/OWNERS
    • ios/chrome/browser/ui/overlays/browser_overlay_queue.h
    • ios/chrome/browser/ui/overlays/browser_overlay_queue.mm
    • ios/chrome/browser/ui/overlays/overlay_coordinator+internal.h
    • ios/chrome/browser/ui/overlays/overlay_coordinator.h
    • ios/chrome/browser/ui/overlays/overlay_coordinator.mm
    • ios/chrome/browser/ui/overlays/overlay_queue.h
    • ios/chrome/browser/ui/overlays/overlay_queue.mm
    • ios/chrome/browser/ui/overlays/overlay_queue_manager.h
    • ios/chrome/browser/ui/overlays/overlay_queue_manager.mm
    • ios/chrome/browser/ui/overlays/overlay_queue_manager_observer.h
    • ios/chrome/browser/ui/overlays/overlay_queue_manager_unittest.mm
    • ios/chrome/browser/ui/overlays/overlay_queue_observer.h
    • ios/chrome/browser/ui/overlays/overlay_queue_unittest.mm
    • ios/chrome/browser/ui/overlays/overlay_scheduler.h
    • ios/chrome/browser/ui/overlays/overlay_scheduler.mm
    • ios/chrome/browser/ui/overlays/overlay_scheduler_observer.h
    • ios/chrome/browser/ui/overlays/overlay_scheduler_unittest.mm
    • ios/chrome/browser/ui/overlays/overlay_service.h
    • ios/chrome/browser/ui/overlays/overlay_service_factory.h
    • ios/chrome/browser/ui/overlays/overlay_service_factory.mm
    • ios/chrome/browser/ui/overlays/overlay_service_impl.h
    • ios/chrome/browser/ui/overlays/overlay_service_impl.mm
    • ios/chrome/browser/ui/overlays/overlay_service_observer.h
    • ios/chrome/browser/ui/overlays/overlay_service_observer_bridge.h
    • ios/chrome/browser/ui/overlays/overlay_service_observer_bridge.mm
    • ios/chrome/browser/ui/overlays/test/BUILD.gn
    • ios/chrome/browser/ui/overlays/test/overlay_coordinator_test.h
    • ios/chrome/browser/ui/overlays/test/overlay_coordinator_test.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_coordinator.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_coordinator.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_parent_coordinator.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_parent_coordinator.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue_manager_observer.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue_manager_observer.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue_observer.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue_observer.mm
    • ios/chrome/browser/ui/overlays/web_state_overlay_queue.h
    • ios/chrome/browser/ui/overlays/web_state_overlay_queue.mm
    • ios/chrome/test/BUILD.gn
  12. RC: Compress all chrome://discards resources.

    Changed by Sigurdur Asgeirsson - siggiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:35:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e826ee9592541ae9d53fd23c51761adf9df17cfc

    Comments

    RC: Compress all chrome://discards resources.
    
    I don't know whether to trust these numbers, but this is what I see
    for my local Windows release 32 bit build.
    
    Uncompressed:
    3,034,139 browser_resources.pak
    233,038,336 mini_installer.exe
    
    Compressed:
    2,869,382 browser_resources.pak
    232,873,472 mini_installer.exe
    
    Bug: 891310
    Change-Id: I3db92ad65afc97b80a9acfbd2fabf486739d7822
    Reviewed-on: https://chromium-review.googlesource.com/c/1327406
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606833}

    Changed files

    • chrome/browser/browser_resources.grd
    • chrome/browser/ui/webui/discards/discards_ui.cc
  13. use SkFontHinting

    Changed by Mike Reed - reedohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 14:32:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a6d7fa9a9e6b3fe2c1c33cb52460998b0a991cf

    Comments

    use SkFontHinting
    
    Bug: skia:2664
    Change-Id: I22633705f2f21f95a223a193a1437d2311e5e205
    Reviewed-on: https://chromium-review.googlesource.com/c/1318416
    Commit-Queue: Mike Reed <reed@google.com>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Reviewed-by: Bill Budge <bbudge@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606832}

    Changed files

    • cc/paint/oop_pixeltest.cc
    • cc/paint/paint_flags.cc
    • cc/paint/paint_flags.h
    • chrome/renderer/pepper/pepper_flash_renderer_host.cc
    • content/renderer/render_view_fuchsia.cc
    • content/renderer/render_view_linux.cc
    • skia/config/SkUserConfig.h
    • third_party/blink/public/platform/web_font_render_style.h
    • third_party/blink/renderer/platform/fonts/font_metrics.cc
    • third_party/blink/renderer/platform/fonts/mac/font_platform_data_mac.mm
    • third_party/blink/renderer/platform/fonts/web_font_render_style.cc
    • third_party/blink/renderer/platform/graphics/logging_canvas.cc
  14. PersonalDataManager: Rename AccountStorageForServer(Cards->Data)

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:31:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 41c87263ae4560b264e15ec45be4832be2e79e86

    Comments

    PersonalDataManager: Rename AccountStorageForServer(Cards->Data)
    
    The account storage is now used for both server cards and server
    addresses.
    
    Bug: 864519
    Change-Id: Ia5fb5ebc4bd4e334b162378923ccd04562d4cac9
    Reviewed-on: https://chromium-review.googlesource.com/c/1329241
    Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606831}

    Changed files

    • chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
    • components/autofill/core/browser/personal_data_manager.cc
    • components/autofill/core/browser/personal_data_manager.h
  15. PersonalDataManager: Store server (aka Wallet) addresses in the Server DB

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:24:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 274ab9c5685ffb50c277a68979c46b4abf9c9455

    Comments

    PersonalDataManager: Store server (aka Wallet) addresses in the Server DB
    
    Currently, this makes no functional difference: In full Sync mode, the
    local DB and the server DB are the same thing anyway, and in
    lightweight/Butter mode, we don't store server addresses at all.
    However,
    1) this change will unlock actually supporting Wallet addresses in
       Butter mode, and
    2) it's just less confusing if "server" things are actually stored in
       the "server" DB.
    
    Bug: 864519
    Change-Id: I4f5479faff87cfa4f7def6b98f6b2235294393b8
    Reviewed-on: https://chromium-review.googlesource.com/c/1326492
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606830}

    Changed files

    • components/autofill/core/browser/personal_data_manager.cc
    • components/autofill/core/browser/personal_data_manager_unittest.cc
  16. Ribbon: Apply values via CustomProperty.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:23:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 634f8db566f7e5401be35e6d6d98f8858a41e0d0

    Comments

    Ribbon: Apply values via CustomProperty.
    
    Instead of applying custom properties via the static Variable instance,
    use the new CustomProperty class (which knows about its name and
    registration) to apply values. This brings the custom property code path
    closer to the standard property code path.
    
    To assist CSSPropertyRef in producing a CSSProperty&, this CL adds the
    class CSSPropertyName. The idea is that CSSPropertyName can be used instead
    of CSSPropertyID/AtomicString where both standard and custom properties are
    expected. My intent is to store a CSSPropertyName in
    CSSPropertyValueMetadata (instead of the CSSProperty*), but this is a big
    change, as everything that creates property/value pairs must carry the
    CSSPropertyName. So, for now PropertyReference.Name() is faking it by
    digging the name out of the associated CSSValue.
    
    Note that CSSPropertyName::ToAtomicString intentionally does not return
    a const AtomicString&. This is because 1) I want to try and reduce the
    size of CSSPropertyName to one pointer, which means it will contain a
    StringImpl* rather than an AtomicString, and 2) I want CSSPropertyName to
    be something that can be passed to other threads if needed, which again
    means StringImpl* (or String, at least) rather than AtomicString.
    
    In general, this CL is a step on the path to achieve these things:
    
     1. Removing the useless and dangerous static Variable instance.
     2. Not having to piggy-back the custom property name in a CSSValue.
     3. Not having to smuggle initial/inherit/unset via the
        CSSCustomPropertyDeclaration (vs. applying CSSIdentifierValues
        holding these values, like civilized individuals).
    
    R=flackr@chromium.org, futhark@chromium.org
    
    Change-Id: I1a062138fc86c5a398542ac147bf9d71feed7b3c
    Reviewed-on: https://chromium-review.googlesource.com/c/1323113
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606829}

    Changed files

    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/animation/css_default_interpolation_type.cc
    • third_party/blink/renderer/core/animation/css_var_cycle_interpolation_type.cc
    • third_party/blink/renderer/core/animation/property_handle.h
    • third_party/blink/renderer/core/animation/property_handle_test.cc
    • third_party/blink/renderer/core/css/BUILD.gn
    • third_party/blink/renderer/core/css/css_property_name.cc
    • third_party/blink/renderer/core/css/css_property_name.h
    • third_party/blink/renderer/core/css/css_property_name_test.cc
    • third_party/blink/renderer/core/css/css_property_value_set.cc
    • third_party/blink/renderer/core/css/css_property_value_set.h
    • third_party/blink/renderer/core/css/properties/css_property_ref.cc
    • third_party/blink/renderer/core/css/properties/css_property_ref.h
    • third_party/blink/renderer/core/css/properties/css_property_ref_test.cc
    • third_party/blink/renderer/core/css/properties/longhands/custom_property.cc
    • third_party/blink/renderer/core/css/properties/longhands/custom_property.h
    • third_party/blink/renderer/core/css/properties/longhands/variable.cc
    • third_party/blink/renderer/core/css/properties/longhands/variable.h
    • third_party/blink/renderer/core/css/resolver/css_variable_resolver_test.cc
    • third_party/blink/renderer/core/css/resolver/style_builder.cc
    • third_party/blink/renderer/core/css/resolver/style_builder.h
    • third_party/blink/renderer/core/css/resolver/style_resolver.cc
  17. Revert "Mac: Disallow dragging tab into blocked tabstrip"

    Changed by Leonard Grey - lgreyohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:18:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 899b84ea267b8ce6ce522d2cf3b34453be3ac164

    Comments

    Revert "Mac: Disallow dragging tab into blocked tabstrip"
    
    This reverts commit 002dfaef6957632740a412c3d69af0913536e1dd.
    
    Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=903706#c1
    
    Original change's description:
    > Mac: Disallow dragging tab into blocked tabstrip
    > 
    > This is a really longwinded way for me to fix some NOTIMPLEMENTED spam,
    > though I'm pretty sure the thing that happens right now when you open
    > a certificate prompt and drag a tab into the parent window is bad.
    > 
    > This introduces a new method because we're not sure if it matches the
    > Aura semantics, and this is better than the nothing we were doing previously.
    > 
    > Bug: 825834
    > Change-Id: I316ca4fbaa7a27dacb09bce0866203b79567016d
    > Reviewed-on: https://chromium-review.googlesource.com/c/1315956
    > Commit-Queue: Leonard Grey <lgrey@chromium.org>
    > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606619}
    
    TBR=ellyjones@chromium.org,lgrey@chromium.org
    
    Change-Id: If2a6470657f160a0e7fa2fd9978078ab46ae048a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 825834
    Reviewed-on: https://chromium-review.googlesource.com/c/1329341
    Reviewed-by: Leonard Grey <lgrey@chromium.org>
    Commit-Queue: Leonard Grey <lgrey@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606828}

    Changed files

    • chrome/browser/ui/views/tabs/tab_drag_controller.cc
    • chrome/browser/ui/views/tabs/tab_drag_controller.h
  18. Fix h2o_junit_manifest_target_name on the bots

    Changed by Peter Kotwicz - pkotwiczohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:16:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a996f2946740acd659f5ed757b2ae364c0168c0

    Comments

    Fix h2o_junit_manifest_target_name on the bots
    
    This CL:
    - Makes the generated AndroidManifest.xml a data dependency of
    h2o_junit_manifest_target_name
    - Reenables LaunchTest.*
    
    BUG=902325
    
    Change-Id: I47e3c5c2226c78c696716712a4307127493c5903
    Reviewed-on: https://chromium-review.googlesource.com/c/1324875
    Reviewed-by: Xi Han <hanxi@chromium.org>
    Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606827}

    Changed files

    • chrome/android/webapk/shell_apk/BUILD.gn
    • chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/h2o/LaunchTest.java
  19. [Autofill Assistant] Allow clicking on links.

    Changed by Stephane Zermatten - szermattohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:16:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 74c9dc10cd643cc6eec6928ae7a8c8d364b85738

    Comments

    [Autofill Assistant] Allow clicking on links.
    
    Before this patch, navigation triggered by clicking on a link or through
    javascript (renderer-initiated navigation) was considered an end state
    for Autofill assistant.
    
    With this patch, such actions are only considered an end state if the
    page that's navigated to has no scripts. This is necessary, as such
    navigation is part of the expected flow of some scripts.
    
    Going back a page or refreshing through the UI (non renderer-initiated
    navigation) are still considered an end state with this patch.
    
    Bug: 806868
    Change-Id: I5a38a82e7edf8b34a5830130b957dfad387e1b0d
    Reviewed-on: https://chromium-review.googlesource.com/c/1329242
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606826}

    Changed files

    • components/autofill_assistant/browser/controller.cc
  20. [iOS] Decouple completion handler from new tab creation in BVC.

    Changed by Mark Cogan - marqohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 14:15:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3c86aa454442704cbfc07d7bf5aaf6a7e301b70c

    Comments

    [iOS] Decouple completion handler from new tab creation in BVC.
    
    This CL decouples the addition of a tab completion block from the other
    tab opening code in the BVC. This will allow the tab opening logic
    (which is just tab model manipulation) to be moved out of the BVC.
    
    Bug: 903338
    Change-Id: Ibc7ba411c2cbec58dd11ac7cb65e2b9284eb811c
    Reviewed-on: https://chromium-review.googlesource.com/c/1323558
    Commit-Queue: Mark Cogan <marq@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606825}

    Changed files

    • ios/chrome/app/application_delegate/url_opener_unittest.mm
    • ios/chrome/app/main_controller.mm
    • ios/chrome/browser/ui/browser_view_controller.h
    • ios/chrome/browser/ui/browser_view_controller.mm
  21. [Autofill Assistant] Fix tap operation and add browser tests

    Changed by gogerald - gogeraldohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 14:02:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5c30a7925aa902990811797ff7dcd2cf89994947

    Comments

    [Autofill Assistant] Fix tap operation and add browser tests
    
    Bug: 806868
    Change-Id: I9730373e60f28b65fb515f9de42da0f6505db594
    Reviewed-on: https://chromium-review.googlesource.com/c/1324239
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Commit-Queue: Ganggui Tang <gogerald@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606824}

    Changed files

    • components/autofill_assistant/browser/web_controller.cc
    • components/autofill_assistant/browser/web_controller.h
    • components/autofill_assistant/browser/web_controller_browsertest.cc
    • components/test/data/autofill_assistant/autofill_assistant_target_website.html
    • components/test/data/autofill_assistant/autofill_assistant_target_website_iframe_one.html
  22. [Autofill Assistant] Extended the amount of information available through feedback forms.

    Changed by Clemens Arbesser - arbesserohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 13:57:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e0eb90453d54daf47f522b220ba83dda94bba669

    Comments

    [Autofill Assistant] Extended the amount of information available through feedback forms.
    
    The stock android feedback form has an optional string field `feedbackContext', which can be used to provide extended information. Depending on when the user taps the feedback button, not all of the information may be available.
    
    Bug: 806868
    Change-Id: I5dfaaf813c48198f573f2e1fbd0d6468439d3a6c
    Reviewed-on: https://chromium-review.googlesource.com/c/1317911
    Commit-Queue: Clemens Arbesser <arbesser@google.com>
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606823}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/FeedbackContext.java
    • chrome/android/java_sources.gni
    • chrome/browser/android/autofill_assistant/ui_controller_android.cc
    • chrome/browser/android/autofill_assistant/ui_controller_android.h
    • components/autofill_assistant/browser/controller.cc
    • components/autofill_assistant/browser/controller.h
    • components/autofill_assistant/browser/mock_ui_controller.h
    • components/autofill_assistant/browser/script_tracker.cc
    • components/autofill_assistant/browser/script_tracker.h
    • components/autofill_assistant/browser/ui_controller.h
    • components/autofill_assistant/browser/ui_delegate.h
  23. Revert "Add resource load priority Service Worker tests"

    Changed by Corentin Wallez - cwallezohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:57:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c01e9b4c3145dbde2c4d472ab75dd00937663981

    Comments

    Revert "Add resource load priority Service Worker tests"
    
    This reverts commit 0f0d0b74734bf82737b893d03ed334ef360f9b0b.
    
    Reason for revert: super flaky on win7_chromium_rel_ng
    
    BUG=chromium:872776
    
    Original change's description:
    > Add resource load priority Service Worker tests
    > 
    > This CL adds resource load priority tests ensuring that the priority of
    > requests that pass through a Service Worker is preserved.
    > 
    > R=​kinuko@chromium.org, kouhei@chromium.org, yhirano@chromium.org
    > 
    > Bug: 872776
    > Change-Id: I74f334359b3255fcac5c13fbdb9f1e601af0f8f0
    > Reviewed-on: https://chromium-review.googlesource.com/c/1316104
    > Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
    > Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    > Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606689}
    
    TBR=falken@chromium.org,kinuko@chromium.org,yhirano@chromium.org,kouhei@chromium.org,domfarolino@gmail.com
    
    Change-Id: I6d997795ffc64f1005ed3821799300cd3401eea9
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 872776
    Reviewed-on: https://chromium-review.googlesource.com/c/1329245
    Reviewed-by: Corentin Wallez <cwallez@chromium.org>
    Commit-Queue: Corentin Wallez <cwallez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606822}

    Changed files

    • third_party/WebKit/LayoutTests/http/tests/priorities/resource-load-priorities-service-worker.https-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/priorities/resource-load-priorities-service-worker.https.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/common.js
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/async-script.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/defer-script.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/fetch.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/module-script.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/off-screen-image.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/parser-blocking-script.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/prefetch.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/render-blocking-stylesheet.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/xhr.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/service-worker-get-priority.js
  24. [SPv2] Fix background invalidation on scroll

    Changed by Xianzhu Wang - wangxianzhuohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:55:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 089805f4087998a3c196305ad8f13cc488bb7655

    Comments

    [SPv2] Fix background invalidation on scroll
    
    The previous early return shortcut required invalidation of fixed-attachment
    background etc.
    
    Now in PaintLayerScrollableArea::InvalidatePaintForScrollOffsetChange():
    - always invalidate for fixed-attachment background
    - correct invalidation of local-attachment background for SPv2
    - remove the SetNeedsRepaint() logic for change of existence of
      ScrollTranslation because now PaintPropertyTreeBuilder will do that
      whenever a paint property node is created or removed
    
    Bug: 529963
    Change-Id: I5c9636cb318412cf8398f305a43bc0c55b9a3fc0
    Reviewed-on: https://chromium-review.googlesource.com/c/1308988
    Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606821}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/full-viewport-repaint-for-background-attachment-fixed-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/scroll/overflow-scroll-local-background-text-color-change-expected.txt
    • third_party/WebKit/LayoutTests/paint/invalidation/scroll/repaint-during-scroll-with-zoom-expected.txt
    • third_party/blink/renderer/core/paint/box_paint_invalidator.cc
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area_test.cc
    • third_party/blink/renderer/core/style/fill_layer.cc
    • third_party/blink/renderer/core/style/fill_layer.h
  25. Revert "Fix page slip issue after dragging"

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:55:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a47b88e164851a0821bd9d6107b63deedb09656a

    Comments

    Revert "Fix page slip issue after dragging"
    
    This reverts commit 05e6d6110b8ee4c29a04943ac021bf59c1d62c72.
    
    Reason for revert: Breaks AppsGridViewDragTest.MouseDragMaxItemsInFolder/6 and a bunch of other tests. 
    
    ==23676==ERROR: AddressSanitizer: container-overflow on address 0x608000011e50 at pc 0x5580f7784dcd bp 0x7ffd9affb130 sp 0x7ffd9affb128
    READ of size 8 at 0x608000011e50 thread T0
        #0 0x5580f7784dcc in ViewAtBase ui/views/view_model.h:71:28
    
    See https://sheriff-o-matic.appspot.com/chromium/examine/chromium.memory.Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1).app_list_unittests.
    
    Original change's description:
    > Fix page slip issue after dragging
    > 
    > Changes:
    > Update the selected page to be the target page of dragged item at the
    > end of dragging.
    > 
    > Bug: 893832
    > Change-Id: I91dcf8e03f62eab1597e3899bdbcafdad1fec2df
    > Reviewed-on: https://chromium-review.googlesource.com/c/1324851
    > Commit-Queue: Weidong Guo <weidongg@chromium.org>
    > Reviewed-by: Alex Newcomer <newcomer@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606585}
    
    TBR=newcomer@chromium.org,weidongg@chromium.org
    
    Change-Id: I4177d2e3ac6226b415b627148db211614d0b7ec4
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 893832
    Reviewed-on: https://chromium-review.googlesource.com/c/1329170
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606820}

    Changed files

    • ash/app_list/views/apps_grid_view.cc
  26. v8binding: Use explicitly-typed callback functions in custom elements

    Changed by Yuki Shiino - yukishiinoohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:46:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2f2d97b775634dcb3f099162f926af93924d29ab

    Comments

    v8binding: Use explicitly-typed callback functions in custom elements
    
    We're planning to not use cross origin ScriptStates everywhere,
    especially in IDL callback function and callback interface.
    Given that, we'd like to minimize use of ScriptState of callbacks,
    which will be nullptr in case of cross origin, so that the call sites
    of callbacks do not need to handle a SecurityError.
    
    This patch is a preparation of https://crrev.com/c/1314023 and
    removes the use of the ScriptState from custom elements.
    
    Bug: 886588, 892755
    Change-Id: I52068920b659efe119496ec092448cdc107e0631
    Reviewed-on: https://chromium-review.googlesource.com/c/1325585
    Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606819}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/BUILD.gn
    • third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.cc
    • third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.h
    • third_party/blink/renderer/bindings/core/v8/script_custom_element_definition_builder.cc
    • third_party/blink/renderer/bindings/core/v8/script_custom_element_definition_builder.h
    • third_party/blink/renderer/bindings/scripts/v8_callback_function.py
    • third_party/blink/renderer/bindings/scripts/v8_callback_interface.py
    • third_party/blink/renderer/bindings/scripts/v8_types.py
    • third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_optional_any_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_variadic_any_args.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_long_callback_function.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_string_sequence_callback_function_long_sequence_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_object.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_treat_non_object_as_null_boolean_function.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_treat_non_object_as_null_void_function.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_dictionary_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_enum_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_interface_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_test_interface_sequence_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_typedef.h
    • third_party/blink/renderer/bindings/tests/results/modules/v8_void_callback_function_modules.h
    • third_party/blink/renderer/core/html/custom/custom_element_registry.idl
  27. DisabletestModalNativeAppBannerCanBeTriggeredMultipleTimesCustomTab.

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:41:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 496cd36004b1f6d845e66930bbbd939de4e4f5bb

    Comments

    DisabletestModalNativeAppBannerCanBeTriggeredMultipleTimesCustomTab.
    
    It is flaky. See for instance
    https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-kitkat-arm-rel/121816.
    
    Bug: 903658, 903657
    Change-Id: Ic682ac60329923a35745d135d101d0eb8b61b08b
    Tbr: mdjones@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/c/1329161
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606818}

    Changed files

    • chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
  28. Update V8 to version 7.2.286.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 13:41:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d3d9d78bc2653ea749eb1719fffdd70f53cedfc6

    Comments

    Update V8 to version 7.2.286.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/6130e69e..31b2546b
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: I2a2852bb93f2c67cb5e6a1f0ed39315bab81006f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329062
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606817}

    Changed files

    • DEPS
  29. [Sync::USS] Fix for counting unsyncable bookmarks when loading model

    Changed by Mohamed Amir Yosef - mamirohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:34:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b6a54aa7e9e0d98986cdbaa84a41d1441e17ad1c

    Comments

    [Sync::USS] Fix for counting unsyncable bookmarks when loading model
    
    On every start up, the bookmarks sync metadata are compared to the
    local model to check the integrity of the persisted data.
    If the model and the metadata don't match, sync infrastructure assumes
    the metadata are corrupted and start syncing from a clean state.
    
    Before this CL:
    Unsyncable bookmarks where considered at comparison. This resulted in the
    models to always never match, and issue an initial update at every
    start up.
    
    After this CL:
    Only syncable bookmarks are considering when comparing the model
    and the metadata.
    
    This issue could be observed using the UMA metric
    Sync.ModelTypeEntityChange3.BOOKMARK
    which should how frequently the client asks for initial updates.
    Before this patch, the client was unnecessarily asking for initial
    updates at every start up, and hence resulted in huge increase in
    the bucket in REMOTE_INITIAL_UPDATE of
    Sync.ModelTypeEntityChange3.BOOKMARK
    
    Bug: 516866
    Change-Id: I61c453359c4265af09a91253f2e13139034b2a53
    Reviewed-on: https://chromium-review.googlesource.com/c/1329001
    Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606816}

    Changed files

    • components/sync_bookmarks/synced_bookmark_tracker.cc
    • components/sync_bookmarks/synced_bookmark_tracker_unittest.cc
  30. Roll src/third_party/perfetto 486203eeaffd..606ed681f4ea (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 13:33:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6318418e6bff257eaf360aa0661f49f993a8f3c1

    Comments

    Roll src/third_party/perfetto 486203eeaffd..606ed681f4ea (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/486203eeaffd..606ed681f4ea
    
    
    git log 486203eeaffd..606ed681f4ea --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 treehugger-gerrit@google.com Merge "Add comment on ftrace pid"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@606ed681f4ea
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: If0bd022a39477de441941826e42f178807d978bc
    Reviewed-on: https://chromium-review.googlesource.com/c/1329042
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606815}

    Changed files

    • DEPS
  31. Roll src-internal 73158cecda02..c458532c0628 (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 13:29:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7bde1aec4c859fd39a039a59a98da4c8b51f6f4f

    Comments

    Roll src-internal 73158cecda02..c458532c0628 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/73158cecda02..c458532c0628
    
    
    Created with:
      gclient setdep -r src-internal@c458532c0628
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I8311db5f4432ad7184b609969b5a2ecd787fbe9f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329041
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606814}

    Changed files

    • DEPS