Home | Search | chromium - Builders
Login

Builder Mac FYI Retina Release (NVIDIA) Build 2301 Apple OSX

Results:

Failure context_lost_tests on NVIDIA GPU on Mac Retina on Mac-10.12.6 Failure webgl2_conformance_tests on NVIDIA GPU on Mac Retina on Mac-10.12.6

Trigger Info:

Projectchromium
Revisionf261109a91970ace70f10388bf8a39acb9977d4b
Got Revisionf261109a91970ace70f10388bf8a39acb9977d4b

Execution:

Steps and Logfiles:

Show:
  1. ( 318 ms ) setup_build
    running recipe: "chromium"
  2. ( 364 ms ) remove .cipd
  3. ( 1 mins 11 secs ) bot_update
    [77GB/464GB used (16%)]
  4. ( 0 ) ensure_goma
  5. ( 705 ms ) swarming.py --version
    0.13
  6. ( 191 ms ) ensure_installed
  7. ( 13 secs ) gclient runhooks
  8. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
  9. ( 1 secs ) build directory
  10. ( 45 secs ) extract build
  11. ( 348 ms ) find isolated tests
  12. ( 0 ) test_pre_run
  13. ( 1 mins 30 secs ) angle_end2end_tests on NVIDIA GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:22.749850
  14. ( 1 mins 8 secs ) angle_unittests on NVIDIA GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:01.079610
  15. ( 48 secs ) tab_capture_end2end_tests on NVIDIA GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 45s
  16. ( 43 secs ) gl_tests on NVIDIA GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 39s
  17. ( 12 secs ) gl_unittests on NVIDIA GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 8s
  18. ( 2 mins 35 secs ) gles2_conform_test on NVIDIA GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:02:28.954780
  19. ( 19 secs ) gpu_unittests on NVIDIA GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 16s
  20. ( 20 secs ) services_unittests on NVIDIA GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 14s
  21. ( 1 secs ) swiftshader_unittests on NVIDIA GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 22s
  22. ( 1 mins 47 secs ) context_lost_tests on NVIDIA GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:43.763640
    Total tests: 8
    * Passed: 7 (7 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 1 (0 expected, >>>1 unexpected<<<)
    * Flaky: 0 (0 expected, 0 unexpected)
     
    Unexpected Failures:
    * gpu_tests.context_lost_integration_test.ContextLostIntegrationTest.ContextLost_WebGLContextLostFromGPUProcessExit
     
  23. ( 27 secs ) depth_capture_tests on NVIDIA GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 25s
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  24. ( 50 secs ) gpu_process_launch_tests on NVIDIA GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 47s
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  25. ( 25 secs ) hardware_accelerated_feature_tests on NVIDIA GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 22s
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  26. ( 22 secs ) info_collection_tests on NVIDIA GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 20s
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  27. ( 57 secs ) maps_pixel_test on NVIDIA GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 50s
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  28. ( 10 mins 13 secs ) pixel_test on NVIDIA GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:10:08.165150
    Total tests: 55
    * Passed: 52 (52 expected, 0 unexpected)
    * Skipped: 3 (3 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 2 mins 38 secs ) screenshot_sync_tests on NVIDIA GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:02:34.108780
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 3 mins 34 secs ) trace_test on NVIDIA GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:03:25.397740
    Total tests: 34
    * Passed: 17 (17 expected, 0 unexpected)
    * Skipped: 17 (17 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  31. ( 1 hrs 2 mins ) webgl2_conformance_tests on NVIDIA GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Max pending time: 43s (shard #19)
    Max shard duration: 1:01:18.615400 (shard #18)
    Min shard duration: 0:08:17.413800 (shard #14)
    Total tests: 2625
    * Passed: 2561 (2561 expected, 0 unexpected)
    * Skipped: 64 (64 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  32. ( 8 mins 6 secs ) webgl_conformance_tests on NVIDIA GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Max pending time: 12s (shard #1)
    Max shard duration: 0:07:50.238990 (shard #1)
    Min shard duration: 0:03:13.742960 (shard #0)
    Total tests: 922
    * Passed: 915 (915 expected, 0 unexpected)
    * Skipped: 7 (7 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  33. ( 183 ms ) Tests statistics
     
    Stats
    Total shards: 40
    Total runtime: 9:08:36.700340
     
  34. ( 1 ms ) Failure reason

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "build84-m9" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531407053803490, "id": "8941197033109795808", "project": "chromium", "tags": ["builder:Mac FYI Retina Release (NVIDIA)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/f261109a91970ace70f10388bf8a39acb9977d4b", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Mac Builder", "parent_buildnumber:13940", "scheduler_invocation_id:9106627095394678672", "scheduler_job_id:chromium/Mac FYI Retina Release (NVIDIA)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Mac FYI Retina Release (NVIDIA)" setup_build
buildnumber 2301 setup_build
mastername "chromium.gpu.fyi" setup_build
parent_buildername "GPU FYI Mac Builder" setup_build
parent_got_angle_revision "9ff9c7732a8731cac249127ee68f1f5f02d8eb63" setup_build
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" setup_build
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" setup_build
parent_got_revision "f261109a91970ace70f10388bf8a39acb9977d4b" setup_build
parent_got_revision_cp "refs/heads/master@{#574557}" setup_build
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" setup_build
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" setup_build
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" setup_build
parent_got_webrtc_revision "58c79f66dd3afef0ec2d77053e44f26b998b84b1" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#23950}" setup_build
parent_mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "f261109a91970ace70f10388bf8a39acb9977d4b" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "f261109a91970ace70f10388bf8a39acb9977d4b" bot_update
got_revision_cp "refs/heads/master@{#574557}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "58c79f66dd3afef0ec2d77053e44f26b998b84b1" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23950}" bot_update
swarm_hashes {"angle_end2end_tests": "c4cf095807cc2650cc2dff51dc04759e08fb1dd9", "angle_unittests": "241fa8f045ab1465beb91de83612fe694a9d48ad", "browser_tests": "2f505a1c7a1d3a7ef237a0fde479ef4419bcc6c8", "gl_tests": "03b5438d2bc68d34d912d8eefc16cbded03642f3", "gl_unittests": "ba9218caa53b815b99237e5521f32c5b73532156", "gles2_conform_test": "80a53e186959bf5045ab9809bb6d39f412a4fed3", "gpu_unittests": "9735dc98ce1d10ee9c145ccedc0d8e6694fefebf", "services_unittests": "4ab8ed2747c0047a8a631e3391f9b4ed86c74ffe", "swiftshader_unittests": "433a33afad32c4025574cbb76973443812cf42ae", "telemetry_gpu_integration_test": "ac070f1dabf8a36d3f3287495688c1e50d598b0a"} find isolated tests

Blamelist:

  1. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
  2. pdfium-chromium-autoroll (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  3. Tiger Oakes (tigeroohnoyoudont@google.com)
  4. skia-chromium-autoroll (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  5. clamy (clamyohnoyoudont@chromium.org)
  6. Jan Wilken Doerrie (jdoerrieohnoyoudont@chromium.org)
  7. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  8. Colin Blundell (blundellohnoyoudont@chromium.org)
  9. stkhapugin@chromium.org (stkhapuginohnoyoudont@chromium.org)
  10. Thomas Tangl (tangltomohnoyoudont@chromium.org)
  11. Nico Weber (thakisohnoyoudont@chromium.org)
  12. Stephen McGruer (smcgruerohnoyoudont@chromium.org)
  13. Aaron Leventhal (aleventhalohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 14:50:53 UTC
Start Thursday, 12-Jul-18 14:50:55 UTC
End Thursday, 12-Jul-18 16:34:49 UTC
Pending 1 secs
Execution 1 hrs 43 mins

All Changes:

  1. [Unity][Android] Increase char limit for 'Sync and Google services'

    Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 14:33:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f261109a91970ace70f10388bf8a39acb9977d4b

    Comments

    [Unity][Android] Increase char limit for 'Sync and Google services'
    
    This CL increases the char limit for 'Sync and Google services'
    translations to 40 characters. It also enables text wrapping for
    preference title that uses this string.
    
    Bug: 814728
    Change-Id: If1b2c3bb9d83a01a2fa13ddd38d39323dc94e689
    Reviewed-on: https://chromium-review.googlesource.com/1131126
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574557}

    Changed files

    • chrome/android/java/res/xml/main_preferences.xml
    • chrome/android/java/strings/android_chrome_strings.grd
  2. Roll src/third_party/pdfium 5ff09fb5ee90..6aa2190f70a8 (1 commits)

    Changed by pdfium-chromium-autoroll - pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 14:29:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df1df391ec8f9534d21219ea753c260c4357588b

    Comments

    Roll src/third_party/pdfium 5ff09fb5ee90..6aa2190f70a8 (1 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/5ff09fb5ee90..6aa2190f70a8
    
    
    git log 5ff09fb5ee90..6aa2190f70a8 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 thestig@chromium.org Use JSGetObject() in even more places.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@6aa2190f70a8
    
    The AutoRoll server is located here: https://pdfium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:862059
    TBR=dsinclair@chromium.org
    
    Change-Id: I1f8681742658f04204fb7df938c0667e814d84c6
    Reviewed-on: https://chromium-review.googlesource.com/1134951
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574556}

    Changed files

    • DEPS
  3. Adds favicon for supersize UI

    Changed by Tiger Oakes - tigeroohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 14:25:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e6d9ffa49bc8e4b239cf5ebe1e7b886764280f5a

    Comments

    Adds favicon for supersize UI
    
    Creates a simple icon by taking the pie chart icon and giving it colors
    from the Chromium logo.
    (https://material.io/tools/icons/?search=pie_chart&icon=pie_chart)
    
    Icon:
    https://notwoods.github.io/chrome-supersize-reports/icon.png
    
    Bug: 847599
    Change-Id: Ib711bf0c717b9339914ec4ba2d9f369b33fb84d7
    Reviewed-on: https://chromium-review.googlesource.com/1134195
    Reviewed-by: agrieve <agrieve@chromium.org>
    Reviewed-by: Peter Wen <wnwen@chromium.org>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Commit-Queue: Tiger Oakes <tigero@google.com>
    Cr-Commit-Position: refs/heads/master@{#574555}

    Changed files

    • tools/binary_size/libsupersize/html_report.py
    • tools/binary_size/libsupersize/template_tree_view/favicon.ico
    • tools/binary_size/libsupersize/template_tree_view/index.html
  4. Roll src/third_party/skia 4d6a844365e7..56a426a516d0 (2 commits)

    Changed by skia-chromium-autoroll - skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 14:11:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 84a2e1ca7620207a3183a275d73d247035d4c078

    Comments

    Roll src/third_party/skia 4d6a844365e7..56a426a516d0 (2 commits)
    
    https://skia.googlesource.com/skia.git/+log/4d6a844365e7..56a426a516d0
    
    
    git log 4d6a844365e7..56a426a516d0 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 5598148b7613..c9c259cccb2e (1 commits)
    2018-07-12 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    
    
    Created with:
      gclient setdep -r src/third_party/skia@56a426a516d0
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: Iae08a82a8704081e534320f9183df4acbccb30d5
    Reviewed-on: https://chromium-review.googlesource.com/1134950
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574554}

    Changed files

    • DEPS
  5. Store multiple NavigationRequests in RenderFrameHost

    Changed by clamy - clamyohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:52:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d3bfdb09875f6b6cdadd5075d7c1f7305b5118ec

    Comments

    Store multiple NavigationRequests in RenderFrameHost
    
    This CL makes it so that RenderFrameHost can store several
    NavigationRequests waiting to commit instead of just one. This avoids
    deleting a NavigationRequest that would later commit (which can happen
    in quick navigations with a renderer process that is slow to process the
    commit).
    
    The regression test was originally written by arthursonzogni@chromium.org in
    https://chromium-review.googlesource.com/c/chromium/src/+/671351.
    
    The background for this change can be found in the following design doc:
    https://docs.google.com/document/d/1mXjxYJptb_bZ_EqGMF-c4LTSnhjt6Gn_WVvSrsinpq8/edit#.
    
    Bug: 738177
    Change-Id: Idd666e41bd2094c90fa576c77cdc26fb7b54cd7f
    Reviewed-on: https://chromium-review.googlesource.com/1082440
    Commit-Queue: Camille Lamy <clamy@chromium.org>
    Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574553}

    Changed files

    • content/browser/browser_side_navigation_browsertest.cc
    • content/browser/frame_host/navigation_controller_impl_browsertest.cc
    • content/browser/frame_host/navigation_controller_impl_unittest.cc
    • content/browser/frame_host/navigation_request.cc
    • content/browser/frame_host/navigator_impl_unittest.cc
    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl.h
    • content/browser/frame_host/render_frame_host_impl_browsertest.cc
    • content/browser/frame_host/render_frame_host_manager.cc
    • content/browser/frame_host/render_frame_host_manager_unittest.cc
    • content/browser/renderer_host/render_widget_host_view_browsertest.cc
    • content/browser/security_exploit_browsertest.cc
    • content/browser/site_per_process_browsertest.cc
    • content/browser/web_contents/web_contents_impl_unittest.cc
    • content/browser/webauth/webauth_browsertest.cc
    • content/public/test/browser_test_utils.cc
    • content/public/test/navigation_simulator.cc
    • content/public/test/test_renderer_host.cc
    • content/test/data/infinite_load_1.html
    • content/test/data/infinite_load_2.html
    • content/test/did_commit_provisional_load_interceptor.cc
    • content/test/did_commit_provisional_load_interceptor.h
    • content/test/test_render_frame_host.cc
    • content/test/test_render_frame_host.h
    • content/test/test_web_contents.cc
  6. [bluetooth] Move Map of Characteristics in Gatt Service

    Changed by Jan Wilken Doerrie - jdoerrieohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:43:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision efd642e61e6933f8e78a607f02b2478652547e92

    Comments

    [bluetooth] Move Map of Characteristics in Gatt Service
    
    This change cleans up BluetoothRemoteGattService and its implementations
    by moving the map of characteristics into the base class. This allows
    for less code duplication and a simplified interface. Furthermore, a
    AddCharacterisitic helper method is introduced.
    
    Bug: 821766
    Change-Id: Ib370c599f1c8519d497a379c976c89c48d7ecb56
    Reviewed-on: https://chromium-review.googlesource.com/1131178
    Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574552}

    Changed files

    • content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
    • device/bluetooth/bluetooth_remote_gatt_characteristic.h
    • device/bluetooth/bluetooth_remote_gatt_service.cc
    • device/bluetooth/bluetooth_remote_gatt_service.h
    • device/bluetooth/bluetooth_remote_gatt_service_android.cc
    • device/bluetooth/bluetooth_remote_gatt_service_android.h
    • device/bluetooth/bluetooth_remote_gatt_service_mac.h
    • device/bluetooth/bluetooth_remote_gatt_service_mac.mm
    • device/bluetooth/bluetooth_remote_gatt_service_win.cc
    • device/bluetooth/bluetooth_remote_gatt_service_win.h
    • device/bluetooth/bluetooth_remote_gatt_service_winrt.cc
    • device/bluetooth/bluetooth_remote_gatt_service_winrt.h
    • device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc
    • device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.h
    • device/bluetooth/cast/bluetooth_remote_gatt_service_cast.cc
    • device/bluetooth/cast/bluetooth_remote_gatt_service_cast.h
    • device/bluetooth/device_unittest.cc
    • device/bluetooth/test/fake_remote_gatt_service.cc
    • device/bluetooth/test/fake_remote_gatt_service.h
    • device/bluetooth/test/mock_bluetooth_gatt_service.cc
    • device/bluetooth/test/mock_bluetooth_gatt_service.h
    • device/fido/fido_ble_connection_unittest.cc
  7. [iOS] Create FindInPage UI for UI Refresh

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:41:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 81f3e175814bb20d103aa178a71272c2cd422193

    Comments

    [iOS] Create FindInPage UI for UI Refresh
    
    This CL creates the FindInPage UI to be used with UI Refresh.
    
    Bug: 805504
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ib6f5adcfde4560a589fed323a717b02c4566621d
    Reviewed-on: https://chromium-review.googlesource.com/1133160
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574551}

    Changed files

    • ios/chrome/browser/ui/find_bar/BUILD.gn
    • ios/chrome/browser/ui/find_bar/find_bar_controller_ios.mm
    • ios/chrome/browser/ui/find_bar/find_bar_ui_element.h
    • ios/chrome/browser/ui/find_bar/find_bar_view.h
    • ios/chrome/browser/ui/find_bar/find_bar_view.mm
  8. MutablePO2TS: Fire token available when adding invalid token at startup

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:40:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d373e8d468f12b8ca7bbf6b979961e3a3f29cc73

    Comments

    MutablePO2TS: Fire token available when adding invalid token at startup
    
    ProfileOAuth2TokenService maintains the invariant that if the user is
    signed in at startup, the primary account is always present in
    PO2TS::GetAccounts().
    
    To maintain this invariant, MutableProfileOAuth2TokenServiceDelegate
    performs the following action when the load of tokens from the on-disk
    database is complete: if the user is signed in, it checks whether there
    is a token present for the primary account and if not, inserts an
    invalid token for that account. (The token can be absent due to e.g. a
    failure to decrypt the database on disk for whatever reason).
    
    However, MutablePO2TSDelegate does *not* fire the
    OnRefreshTokenAvailable() callback in that case. This breaks the
    implicit expectation of clients that when ProfileOAuth2TokenService adds
    an account, it will always fire OnRefreshTokenAvailable(). It is also
    inconsistent with the behavior if the primary account happens to have
    an invalid token on disk that is successfully decrypted: in that case,
    MutablePO2TSDelegate will fire the observer callback, but of course,
    from clients' POV there is no difference whatsoever between these two
    cases.
    
    In particular, the failure of this invariant can cause IdentityManager
    to crash if a user in this situation later signs out, as the token
    being revoked violates IdentityManager's expectation that it had
    previously been made aware of that token via a notification that it
    was available.
    
    This CL remedies the problem by firing OnRefreshTokenAvailable() in
    this case. It also extends the relevant MutablePO2TSDelegate unittest
    to fail without this change and succeed with this change.
    
    Bug: 860011
    Change-Id: I66cebda29ec56d79f209f6b2c93dff67797c57b4
    Reviewed-on: https://chromium-review.googlesource.com/1126861
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574550}

    Changed files

    • chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc
    • chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.h
    • chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
  9. [iOS] Hide clear button when the textfield is empty.

    Changed by stkhapugin@chromium.org - stkhapuginohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:35:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a0056ea7bc75754d4ac5388b0ee9108cc604945d

    Comments

    [iOS] Hide clear button when the textfield is empty.
    
    Makes UI Refresh omnibox hide the clear button when the textfield
    is empty.
    
    Bug: 854622
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I7905efa0c5ead8c7c2884c27474ec992b970355c
    Reviewed-on: https://chromium-review.googlesource.com/1122627
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574549}

    Changed files

    • ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm
  10. [Dice] Add drop down button to signin button in user menu

    Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:27:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7dcd444b288c6dc6237db97575abc35e4e4d81ce

    Comments

    [Dice] Add drop down button to signin button in user menu
    
    The "Sync to another account" button in the user menu
    is removed and instead a drop down button is added to
    the right of the sign-in button.
    
    Bug: 824546
    Change-Id: I8b1b892962b17229dfdc057169a7f18132ffb58b
    Reviewed-on: https://chromium-review.googlesource.com/1133978
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574548}

    Changed files

    • chrome/browser/ui/views/profiles/profile_chooser_view.cc
  11. Run filesystem_service_unittests, leveldb_service_unittests on all desktop bots.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:25:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eb527397d46f689b27ba693793620d1a2fb98493

    Comments

    Run filesystem_service_unittests, leveldb_service_unittests on all desktop bots.
    
    Bug: 843511
    Change-Id: I082a2c9e4d5e573f07bef1e0176f32db6344f2f0
    Reviewed-on: https://chromium-review.googlesource.com/1132400
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574547}

    Changed files

    • testing/buildbot/chromium.chromiumos.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.mac.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.win.json
    • testing/buildbot/test_suites.pyl
  12. Remove webkit-appearance.tentative.html WPT test

    Changed by Stephen McGruer - smcgruerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:22:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision af6945a93a039f0717fbc6037dd66a1db081fa65

    Comments

    Remove webkit-appearance.tentative.html WPT test
    
    This test is not a good indicator of -webkit-appearance support; it only
    checks whether computed-value == applied-value for -webkit-appearance
    values specified on a vanilla <div>. In reality most values of
    -webkit-appearance are not of interest to other UAs (see
    https://github.com/whatwg/compat/issues/6), and the behavior is
    different on different elements (e.g. <input>).
    
    Since this has caused issues across different platforms on Chrome (see
    bug), remove it.
    
    Bug: 810162
    Change-Id: I9d469cb624569f453978f3c56cc180eb07435b5b
    Reviewed-on: https://chromium-review.googlesource.com/1134387
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574546}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/compat/webkit-appearance.tentative.html
    • third_party/WebKit/LayoutTests/platform/mac/external/wpt/compat/webkit-appearance.tentative-expected.txt
  13. Avoid incomplete live region text change announcements

    Changed by Aaron Leventhal - aleventhalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:04:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a32928f26183dce010284f0abcee28508e44a6f8

    Comments

    Avoid incomplete live region text change announcements
    
    When a live region change occurs we sometimes fire text change events
    for only part of the text. For example, if "car" changes to "cat", we
    fire an event that makes it look like only the "t" changed.
    
    This changes the heuristic so that when a live region occurs that is
    not in an editor, it will prefer to indicate that entire text nodes
    have changed.
    
    Bug: 778478
    Change-Id: If87f1ac8c9c0b237bd422e8b7217d8d0347a13ab
    Reviewed-on: https://chromium-review.googlesource.com/1134201
    Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574545}

    Changed files

    • content/test/data/accessibility/event/description-change-indirect-expected-win.txt
    • content/test/data/accessibility/event/name-change-indirect-expected-win.txt
    • content/test/data/accessibility/event/text-changed-expected-win.txt
    • ui/accessibility/platform/ax_platform_node_win.cc
    • ui/accessibility/platform/ax_platform_node_win.h