Home | Search | chromium - Builders
Login

Builder Mac FYI Retina Release (AMD) Build 5515 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revision78a0a24222fde0f77a45d4f78b1f4502496c434e
Got Revision78a0a24222fde0f77a45d4f78b1f4502496c434e

Execution:

Steps and Logfiles:

Show:
  1. ( 305 ms ) setup_build
    running recipe: "chromium"
  2. ( 363 ms ) remove .cipd
  3. ( 1 mins 11 secs ) bot_update
    [77GB/232GB used (33%)]
  4. ( 0 ) ensure_goma
  5. ( 714 ms ) swarming.py --version
    0.13
  6. ( 178 ms ) ensure_installed
  7. ( 13 secs ) gclient runhooks
  8. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
  9. ( 1 secs ) build directory
  10. ( 44 secs ) extract build
  11. ( 348 ms ) find isolated tests
  12. ( 0 ) test_pre_run
  13. ( 2 secs ) angle_end2end_tests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 25s
  14. ( 3 secs ) angle_unittests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 56s
  15. ( 47 secs ) tab_capture_end2end_tests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 43s
  16. ( 49 secs ) gl_tests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 47s
  17. ( 9 secs ) gl_unittests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 7s
  18. ( 4 mins 38 secs ) gles2_conform_test on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:04:32.847810
  19. ( 19 secs ) gpu_unittests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 15s
  20. ( 18 secs ) services_unittests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 14s
  21. ( 1 secs ) swiftshader_unittests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 7s
  22. ( 1 mins 17 secs ) context_lost_tests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:14.408060
    Total tests: 8
    * Passed: 8 (8 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  23. ( 32 secs ) depth_capture_tests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 28s
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  24. ( 48 secs ) gpu_process_launch_tests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 46s
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  25. ( 27 secs ) hardware_accelerated_feature_tests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 25s
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  26. ( 25 secs ) info_collection_tests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 24s
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  27. ( 48 secs ) maps_pixel_test on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 46s
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  28. ( 3 mins 36 secs ) pixel_test on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:03:31.977050
    Total tests: 55
    * Passed: 52 (52 expected, 0 unexpected)
    * Skipped: 3 (3 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 1 mins 2 secs ) screenshot_sync_tests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:01.447040
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 1 mins 28 secs ) trace_test on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:25.096730
    Total tests: 34
    * Passed: 17 (17 expected, 0 unexpected)
    * Skipped: 17 (17 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  31. ( 9 mins 32 secs ) webgl2_conformance_tests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Max shard duration: 0:09:22.178330 (shard #12)
    Min shard duration: 0:06:52.003710 (shard #8)
    Total tests: 2761
    * Passed: 2697 (2697 expected, 0 unexpected)
    * Skipped: 64 (64 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  32. ( 6 mins 49 secs ) webgl_conformance_tests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Max shard duration: 0:06:41.822160 (shard #1)
    Min shard duration: 0:02:57.222670 (shard #0)
    Total tests: 922
    * Passed: 915 (915 expected, 0 unexpected)
    * Skipped: 7 (7 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  33. ( 267 ms ) Tests statistics
     
    Stats
    Total shards: 40
    Total runtime: 2:56:43.520378
     
  34. ( 1 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "build86-m9" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531399989560260, "id": "8941204440504938144", "project": "chromium", "tags": ["builder:Mac FYI Retina Release (AMD)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/78a0a24222fde0f77a45d4f78b1f4502496c434e", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Mac Builder", "parent_buildnumber:13928", "scheduler_invocation_id:9106634502639536016", "scheduler_job_id:chromium/Mac FYI Retina Release (AMD)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Mac FYI Retina Release (AMD)" setup_build
buildnumber 5515 setup_build
mastername "chromium.gpu.fyi" setup_build
parent_buildername "GPU FYI Mac Builder" setup_build
parent_got_angle_revision "c9c259cccb2ece20c516b45f2c3782e31860a528" setup_build
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" setup_build
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" setup_build
parent_got_revision "78a0a24222fde0f77a45d4f78b1f4502496c434e" setup_build
parent_got_revision_cp "refs/heads/master@{#574537}" setup_build
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" setup_build
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" setup_build
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" setup_build
parent_got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#23944}" setup_build
parent_mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "78a0a24222fde0f77a45d4f78b1f4502496c434e" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "78a0a24222fde0f77a45d4f78b1f4502496c434e" bot_update
got_revision_cp "refs/heads/master@{#574537}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23944}" bot_update
swarm_hashes {"angle_end2end_tests": "87e5182bcfc7e49cd89ecbae64c26b226340d342", "angle_unittests": "352ffef9e98a6b3a670258a69370295ec45fdd3e", "browser_tests": "4881e3e89109fbb850f34281630960bb2b7e04db", "gl_tests": "2b07f9ae44c3b892fd6a3f4fdebdcbf00f65546d", "gl_unittests": "d7acc432db82cf60fa169facef2031872f10ae49", "gles2_conform_test": "affaa1dc7253e39235234e1d24fd70e3958a752e", "gpu_unittests": "b100417ff386e688be5e950e84f4d1c4a759f0c2", "services_unittests": "4f7e80d48976ab51e148a8ea2a1965a61d44fe3a", "swiftshader_unittests": "433a33afad32c4025574cbb76973443812cf42ae", "telemetry_gpu_integration_test": "f53c4bd43eaa7a9b06ff65797cecc1616c8359b4"} find isolated tests

Blamelist:

  1. Chromite Chromium Autoroll (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  2. Kent Tamura (tkentohnoyoudont@chromium.org)
  3. Ivan Sandrk (isandrkohnoyoudont@google.com)
  4. Mike West (mkwstohnoyoudont@chromium.org)
  5. Arthur Hemery (ahemeryohnoyoudont@chromium.org)
  6. skia-chromium-autoroll (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  7. yoshiki iguchi (yoshikiohnoyoudont@chromium.org)
  8. Shik Chen (shikohnoyoudont@chromium.org)
  9. Benoit Lize (lizebohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 12:53:09 UTC
Start Thursday, 12-Jul-18 12:53:10 UTC
End Thursday, 12-Jul-18 13:31:47 UTC
Pending 1 secs
Execution 38 mins 36 secs

All Changes:

  1. Roll src/third_party/chromite c228d491eb86..3973c26575e2 (1 commits)

    Changed by Chromite Chromium Autoroll - chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 12:32:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 78a0a24222fde0f77a45d4f78b1f4502496c434e

    Comments

    Roll src/third_party/chromite c228d491eb86..3973c26575e2 (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/c228d491eb86..3973c26575e2
    
    
    git log c228d491eb86..3973c26575e2 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 dhanyaganesh@chromium.org CreateTarball: Add debug code with lsof
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@3973c26575e2
    
    The AutoRoll server is located here: https://chromite-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: Iabf74616719c8b90e6b34c6576772eeb313a7183
    Reviewed-on: https://chromium-review.googlesource.com/1134906
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574537}

    Changed files

    • DEPS
  2. Oilpan: Do not include wtf/functional.h

    Changed by Kent Tamura - tkentohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:30:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb

    Comments

    Oilpan: Do not include wtf/functional.h
    
    No one in platform/heap/ needs wtf/functional.h, though persistent.h
    needs base/bind.h for IsWeakReceiver<> and BindUnwrapTraits<>.
    
    This CL reduces the pre-processed size of handle.h by 31KB.
    
    Bug: 242216
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I6097a6f22dbe7a762f4b0a23560c731a07daf5ce
    Reviewed-on: https://chromium-review.googlesource.com/1134809
    Reviewed-by: Keishi Hattori <keishi@chromium.org>
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574536}

    Changed files

    • third_party/blink/renderer/core/fetch/form_data_bytes_consumer.cc
    • third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_descriptor.cc
    • third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_service.cc
    • third_party/blink/renderer/modules/budget/budget_service.cc
    • third_party/blink/renderer/modules/device_orientation/device_sensor_event_pump.h
    • third_party/blink/renderer/modules/filesystem/directory_reader.cc
    • third_party/blink/renderer/modules/filesystem/file_system_callbacks.cc
    • third_party/blink/renderer/modules/gamepad/gamepad_haptic_actuator.cc
    • third_party/blink/renderer/modules/indexeddb/idb_request_queue_item.cc
    • third_party/blink/renderer/modules/indexeddb/idb_request_queue_item.h
    • third_party/blink/renderer/modules/locks/lock.cc
    • third_party/blink/renderer/modules/mediastream/media_devices_test.cc
    • third_party/blink/renderer/modules/payments/payment_manager.cc
    • third_party/blink/renderer/modules/service_worker/respond_with_observer.cc
    • third_party/blink/renderer/modules/webusb/usb_device.cc
    • third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image_test.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource.cc
    • third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc
    • third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.cc
    • third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context_test.cc
    • third_party/blink/renderer/platform/graphics/gpu/xr_webgl_drawing_buffer.cc
    • third_party/blink/renderer/platform/graphics/skia_texture_holder.h
    • third_party/blink/renderer/platform/heap/persistent.h
    • third_party/blink/renderer/platform/heap/thread_state.h
    • third_party/blink/renderer/platform/testing/empty_web_media_player.h
    • third_party/blink/renderer/platform/testing/unit_test_helpers.cc
  3. Add UMA for locked-fullscreen state

    Changed by Ivan Sandrk - isandrkohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 12:29:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2fe933a784678f6aa62203b7d57a638051c15f2a

    Comments

    Add UMA for locked-fullscreen state
    
    Locked-fullscreen state will be used for giving student quizzes on managed
    Chrome OS devices in schools. Add a UMA to track feature adoption.
    
    Change-Id: I59f809e2aecd67a4e9f10ee21a28658796c03b15
    Reviewed-on: https://chromium-review.googlesource.com/1126241
    Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Commit-Queue: Ivan Ĺ andrk <isandrk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574535}

    Changed files

    • chrome/browser/extensions/api/tabs/tabs_api.cc
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
  4. Mark "virtual/gpu/fast/canvas/canvas-blending-image-over-pattern.html" as flaky

    Changed by Mike West - mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:23:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 84356c12447981846eda650f06085913fa831126

    Comments

    Mark "virtual/gpu/fast/canvas/canvas-blending-image-over-pattern.html" as flaky
    
    TBR=kpaulhamus@chromium.org
    
    Bug: 862907
    Change-Id: If6ce15cb1633ae74177e385774a1cef7010e67c0
    Reviewed-on: https://chromium-review.googlesource.com/1134989
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574534}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  5. Navigation: Refactoring WebContents unittests to use NavigationSimulator

    Changed by Arthur Hemery - ahemeryohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:20:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c65bc1abc46c630c53a3e21bb0670dc602e8d37d

    Comments

    Navigation: Refactoring WebContents unittests to use NavigationSimulator
    
    Removed the usage of TestWebContents->DidNavigate variants in
    web_contents_impl_unittest.cc. Some usage remains, linked to
    overlapping navigations and other specific usages.
    
    Bug: 728571
    Change-Id: Ie2d6b73cb5deea077f720114fdd45ab4ee714c0a
    Reviewed-on: https://chromium-review.googlesource.com/1076240
    Reviewed-by: Camille Lamy <clamy@chromium.org>
    Commit-Queue: Arthur Hemery <ahemery@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574533}

    Changed files

    • content/browser/web_contents/web_contents_impl_unittest.cc
  6. Roll src/third_party/skia fcc10da18eb5..4d6a844365e7 (9 commits)

    Changed by skia-chromium-autoroll - skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 12:19:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a66959734236ca95f9372334bfa18bbc7a5a1b52

    Comments

    Roll src/third_party/skia fcc10da18eb5..4d6a844365e7 (9 commits)
    
    https://skia.googlesource.com/skia.git/+log/fcc10da18eb5..4d6a844365e7
    
    
    git log fcc10da18eb5..4d6a844365e7 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files
    2018-07-12 herb@google.com Use new SkGlyphIDSet - v3
    2018-07-12 bungeman@google.com Remove SkDrawFilter.
    2018-07-12 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 5c8113d3c20f..5598148b7613 (8 commits)
    2018-07-12 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2018-07-12 robertphillips@google.com Revert "build debug on linux for gdb"
    2018-07-12 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2018-07-12 caryclark@google.com build debug on linux for gdb
    2018-07-12 benjaminwagner@google.com Update Win10 in Skolo.
    
    
    Created with:
      gclient setdep -r src/third_party/skia@4d6a844365e7
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: Ifd4c74ca893ddae66e41fe10ff663287be1cf325
    Reviewed-on: https://chromium-review.googlesource.com/1134148
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574532}

    Changed files

    • DEPS
  7. Activate widget correctly when the inline reply opens on ARC notification

    Changed by yoshiki iguchi - yoshikiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:13:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab9d0ad4ed6a95ee7675fabb4d16cf63d286dba2

    Comments

    Activate widget correctly when the inline reply opens on ARC notification
    
    When a non-ARC normal window (eg. Chrome browser window) was active, the
    inline textbox didn't work for the second time and later. This CL solves
    this issue.
    
    This was because the widget was not activated correctly (IsActive() was
    true but CanActivate() was false) in that case. This CL removes the
    IsActive() guard to make the widget active correctly whenever the inline
    reply opens.
    
    Bug: b/111100376
    Bug: 858938
    Test: manual (inline reply can be used multiple times)
    
    Change-Id: I65d7604be5d24ff1e6c56336a76a5951d6066b39
    Reviewed-on: https://chromium-review.googlesource.com/1133039
    Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
    Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574531}

    Changed files

    • ash/system/message_center/arc/arc_notification_content_view.cc
  8. media: sync the camera metadata definitions

    Changed by Shik Chen - shikohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:13:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38884d4717c2517cb832722d0fa4871a89d19799

    Comments

    media: sync the camera metadata definitions
    
    We need some new metadata tags for external camera, so regenerate and
    sync all of them in arc-camera, chromium, and ARC++.
    
    Some "arc" are replaced by "cros" manually.
    
    BUG=b:77833131
    TEST=Verify CCA works on Nautilus.
    
    Change-Id: I308e258d9b72acdd825591041a67ce7352dce6a8
    Reviewed-on: https://chromium-review.googlesource.com/1117970
    Reviewed-by: Ricky Liang <jcliang@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Shik Chen <shik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574530}

    Changed files

    • media/capture/video/chromeos/mojo/camera_metadata_tags.mojom
  9. blink/wtf: Really move MovableStrings when DCHECK_IS_ON.

    Changed by Benoit Lize - lizebohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:09:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d1fef2b1ad38fe1ef8c3914fb5dadc39bae80b9b

    Comments

    blink/wtf: Really move MovableStrings when DCHECK_IS_ON.
    
    When a MovableString is parked, actually park the content, and poison
    the previous allocation. This is intended to find cached raw pointer
    accesses, which are not allowed beyond the UI thread task per the
    contract of the class.
    Enabled only when DCHECK_IS_ON to prevent potential crashes.
    
    Changes with and without DCHECK()s:
    - Cache some String properties in MovableStringImpl
    - Add a parked_strings_ to MovableStringTable for accounting, and
      update tests accordingly.
    
    Changes with DCHECK()s:
    - Add a parked_string_ member to MovableStringImpl
    - Copy the string to the parked version in Park(), and poison the
      previous allocation.
    - Restore the string in Unpark().
    
    Bug: 837659
    Change-Id: Ib7631d5e12471826c9e71a424e30d26cf8f1f042
    Reviewed-on: https://chromium-review.googlesource.com/1133169
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Benoit L <lizeb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574529}

    Changed files

    • third_party/blink/renderer/platform/wtf/text/movable_string.cc
    • third_party/blink/renderer/platform/wtf/text/movable_string.h
    • third_party/blink/renderer/platform/wtf/text/movable_string_test.cc