Home | Search | chromium - Builders
Login

Builder Mac FYI Retina Debug (NVIDIA) Build 4691 Apple OSX

Results:

Internal Failure

Trigger Info:

Projectchromium
Revision8112997ce464e3fa4ae5ca8e166c7adc1de03e35

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    coordinator: no such stream
    • - no logs -

Build Properties:

NameValueSource

Blamelist:

  1. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  2. Shu Chen (shuchenohnoyoudont@google.com)
  3. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  4. Hiroki Nakagawa (nhirokiohnoyoudont@chromium.org)
  5. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  6. maxmorin (maxmorinohnoyoudont@chromium.org)
  7. Charles Zhao (charleszhaoohnoyoudont@chromium.org)
  8. Alan Cutter (alancutterohnoyoudont@chromium.org)
  9. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  10. Kinuko Yasuda (kinukoohnoyoudont@chromium.org)
  11. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  12. Li Lin (llinohnoyoudont@chromium.org)
  13. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
  14. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)

Timing:

Create Friday, 07-Dec-18 07:19:01 UTC
Start Friday, 07-Dec-18 07:19:06 UTC
End Friday, 07-Dec-18 07:26:26 UTC
Pending 4 secs
Execution 7 mins 20 secs

All Changes:

  1. Roll src/third_party/skia 309f1deddf8e..f3babcd0afb3 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 06:49:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8112997ce464e3fa4ae5ca8e166c7adc1de03e35

    Comments

    Roll src/third_party/skia 309f1deddf8e..f3babcd0afb3 (2 commits)

https://skia.googlesource.com/skia.git/+log/309f1deddf8e..f3babcd0afb3


git log 309f1deddf8e..f3babcd0afb3 --date=short --no-merges --format='%ad %ae %s'
2018-12-07 sergeyu@chromium.org Reland "Add SkFontMgr implementation for Fuchsia"
2018-12-07 reed@google.com Revert "Add SkFontMgr implementation for Fuchsia"


Created with:
  gclient setdep -r src/third_party/skia@f3babcd0afb3

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@chromium.org

Change-Id: Ieefefb070c45ba63a5efa3872a75e1d4140b5e41
Reviewed-on: https://chromium-review.googlesource.com/c/1367116
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614629}

    Changed files

    • DEPS

  2. Updates the order of key mappings to match the same as layout rendering in VK.

    Changed by Shu Chen - shuchenohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 06:48:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 65054bfdd84984501e8054b2f96edacc1bab93a9

    Comments

    Updates the order of key mappings to match the same as layout rendering in VK.

The modifier importance priority is: Altgr > Shift > Capslock.
So if user presses a key with Shift + Altgr + Capslock and the key mapping is not defined for the input method.
It will fallback to other key mappings in this order:
 - Shift + Altgr
 - Altgr + Capslock
 - Shift + Capslock
 - Altgr
 - Shift
 - Capslock
 - Normal

Bug: 910049
Change-Id: I3a274ba02671977a075ee27441acf429cf4569cb
Reviewed-on: https://chromium-review.googlesource.com/c/1356735
Reviewed-by: Leo Zhang <googleo@chromium.org>
Commit-Queue: Leo Zhang <googleo@chromium.org>
Commit-Queue: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614628}

    Changed files

    • chromeos/services/ime/public/cpp/rulebased/def/fa.cc
    • chromeos/services/ime/public/cpp/rulebased/def/lo.cc
    • chromeos/services/ime/public/cpp/rulebased/def/ta_inscript.cc
    • chromeos/services/ime/public/cpp/rulebased/def/ta_phone.cc
    • chromeos/services/ime/public/cpp/rulebased/def/th.cc

  3. Import wpt@2d0f68b3c512b4ba268b09fac224830f866a5720

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 06:36:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b38c320095ae37996d50a735f7d2690c9e0eed10

    Comments

    Import wpt@2d0f68b3c512b4ba268b09fac224830f866a5720

Using wpt-import in Chromium c71812f1007dae45bce45b451c384bf9c0dbd356.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
hbos@chromium.org, hta@chromium.org:
  external/wpt/webrtc

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I379fefc2dcbcf7082675a8eced0893890f23b0ef
Reviewed-on: https://chromium-review.googlesource.com/c/1367132
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614627}

    Changed files

    • third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
    • third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-track-stats.https-expected.txt
    • third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-track-stats.https.html
    • third_party/blink/web_tests/external/wpt/webrtc/legacy/RTCPeerConnection-addStream.https.html
    • third_party/blink/web_tests/external/wpt/webrtc/no-media-call.html

  4. Worklet: Use <meta name="timeout"> instead of SlowTests annotations for slow WPTs

    Changed by Hiroki Nakagawa - nhirokiohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:31:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 593b9acb3dea58c30c4a4cd8d251938f66a47c1e

    Comments

    Worklet: Use <meta name="timeout"> instead of SlowTests annotations for slow WPTs

<meta name="timeout"> is prefereable for WPTs:
https://web-platform-tests.org/writing-tests/testharness-api.html#harness-timeout

Bug: 912240
Change-Id: I3c4a9acb1fb070c34d10f59ff9d3fd3d2bd11afb
Reviewed-on: https://chromium-review.googlesource.com/c/1366469
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614626}

    Changed files

    • third_party/blink/web_tests/SlowTests
    • third_party/blink/web_tests/external/wpt/worklets/animation-worklet-csp.https.html
    • third_party/blink/web_tests/external/wpt/worklets/audio-worklet-csp.https.html

  5. Roll src/third_party/catapult 5d7bcad36ff4..62ba44ace70c (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 06:29:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a61e410e3beb88a04880f973dbde7c0099dbdff6

    Comments

    Roll src/third_party/catapult 5d7bcad36ff4..62ba44ace70c (1 commits)

https://chromium.googlesource.com/catapult.git/+log/5d7bcad36ff4..62ba44ace70c


git log 5d7bcad36ff4..62ba44ace70c --date=short --no-merges --format='%ad %ae %s'
2018-12-06 rmhasan@google.com Adds another verification to the Test expectation parser


Created with:
  gclient setdep -r src/third_party/catapult@62ba44ace70c

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:905426
TBR=sullivan@chromium.org

Change-Id: Ibda0e80cd77c7ecd1434701f064e2f99db1b8307
Reviewed-on: https://chromium-review.googlesource.com/c/1367099
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614625}

    Changed files

    • DEPS

  6. Activate audio thread hang monitoring when OOP

    Changed by maxmorin - maxmorinohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:26:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c67047dd2ff166e62aa72f9d461e3a00baf5e573

    Comments

    Activate audio thread hang monitoring when OOP

Also includes cleaning up the hang monitor:
 * Actually a class!
 * Actually possible to stop the hang monitor!
 * Tests!
 * When OOP, uploads dumps (without crashing). A kill switch is added for this.
 * Switch the UMA enum to kCase, make it a class enum, and use the simpler UMA
   histogram.
 * Switch from "tail posting" the periodic task to using RepeatingTimer.
 * Runs on the task scheduler rather than on the browser IO thread.
 * Some suspend/resume code was simplified.

The hang monitor is now owned by the AudioThread implementation.

Extra functionality (such a nuking the audio process in case of a hang)
is coming later.

Bug: 866442, 905681
Change-Id: Icfe83cc3e7626b164648a8b502d13cf2cfc25518
Reviewed-on: https://chromium-review.googlesource.com/c/1340264
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614624}

    Changed files

    • content/browser/renderer_host/media/audio_output_authorization_handler_unittest.cc
    • content/browser/renderer_host/render_process_host_impl.cc
    • media/audio/BUILD.gn
    • media/audio/audio_features.cc
    • media/audio/audio_features.h
    • media/audio/audio_manager.cc
    • media/audio/audio_manager.h
    • media/audio/audio_thread.h
    • media/audio/audio_thread_hang_monitor.cc
    • media/audio/audio_thread_hang_monitor.h
    • media/audio/audio_thread_hang_monitor_unittest.cc
    • media/audio/audio_thread_impl.cc
    • media/audio/audio_thread_impl.h
    • media/audio/test_audio_thread.cc
    • media/audio/test_audio_thread.h
    • services/audio/owning_audio_manager_accessor.cc

  7. TabRanker: Fix Query time logging.

    Changed by Charles Zhao - charleszhaoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:26:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6378752b810e6122744cefac544c8d84278dcc71

    Comments

    TabRanker: Fix Query time logging.


TabRanker query time logging was landed in this cl:
https://chromium-review.googlesource.com/c/chromium/src/+/1350445

TabManager::GetSortedLifecycleUnitsFromTabRanker() was created to bypass calls to
TabManager::GetSortedLifecycleUnits()

But this was wrong on two aspects:

(1) TabManagerDelegate::LowMemoryKillImpl is still calling GetSortedLifecycleUnits(),
    so ChromeOS discards are all skipped.

(2) TabManagerDelegate::Candidate is calling
    lifecycle_unit_->GetSortKey() for inferring sorting,
    Which means TabRanker model won't work for ChromeOS discards.


The fix:
(1) Change TabManager, TabLifecycleUnit back to their previous code,
    which were sorting LifecycleUnits by TabRanker when it's enabled.

(2) Add TabActivityWatcher::LogOldestNTabFeatures() and call this function in
    TabManager::DiscardTab for query time logging.

Bug: 911474

Change-Id: I103e8237cd96ea87667536b7b44b27fe8772abb4
Reviewed-on: https://chromium-review.googlesource.com/c/1360471
Reviewed-by: Christopher Morin <cmtm@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Charles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614623}

    Changed files

    • chrome/browser/resource_coordinator/tab_activity_watcher.cc
    • chrome/browser/resource_coordinator/tab_activity_watcher.h
    • chrome/browser/resource_coordinator/tab_activity_watcher_browsertest.cc
    • chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
    • chrome/browser/resource_coordinator/tab_manager.cc
    • chrome/browser/resource_coordinator/tab_manager.h

  8. Revert "Timer notification UI improvement:"

    Changed by Alan Cutter - alancutterohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:18:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 28d424ea311f180535b9a5aceb6facfc61c9b59e

    Comments

    Revert "Timer notification UI improvement:"

This reverts commit d710a7b3ef59302c00c2e3fe1b00c788310801c6.

Reason for revert: Broke compile:
https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59395
../../chromeos/services/assistant/assistant_manager_service_impl.cc:33:10: fatal error: 'libassistant/shared/internal_api/alarm_timer_types.h' file not found
#include "libassistant/shared/internal_api/alarm_timer_types.h"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Original change's description:
> Timer notification UI improvement:
> 
> * Add timer deeplinks for:
>   - Stop timer
>   - Add time to timer
> * Add "add 1 min to timer" button to timer notification.
> 
> Using a feature flag to guard the usage of the deeplink as
> AlarmTimerManager is not fully available yet.
> 
> Bug: b:119116816
> Change-Id: Ib9b28abecece1bb4fc60b88f367900f6f08f2efe
> Reviewed-on: https://chromium-review.googlesource.com/c/1340786
> Commit-Queue: Li Lin <llin@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Reviewed-by: Tao Wu <wutao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#614618}

TBR=xiyuan@chromium.org,dcheng@chromium.org,xiaohuic@chromium.org,dmblack@google.com,wutao@chromium.org,llin@chromium.org

Change-Id: I8ece5ad7361e379880921e2abc55085d1de6cd88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:119116816
Reviewed-on: https://chromium-review.googlesource.com/c/1367081
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614622}

    Changed files

    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/assistant/util/deep_link_util.cc
    • ash/assistant/util/deep_link_util.h
    • ash/assistant/util/deep_link_util_unittest.cc
    • chromeos/chromeos_strings.grd
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h

  9. Report PreviewsEligibilityReason as offline when device is offline

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:11:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01c4f97005f6f162b3df6953b8f2a4efce338ec1

    Comments

    Report PreviewsEligibilityReason as offline when device is offline

Currently, if the device is offline, PreviewsEligibilityReason
records the reason for not showing previews as network quality
unavailable.

This CL changes it to record the reason as device offline.
Network quality unavailable reason is now used for only the cases where
NQE (network quality estimator) reports ECT as Unknown.

Bug: 912725
Change-Id: I0af0977770e2123f6ccd0317f8ebbfaed1aac9b2
Reviewed-on: https://chromium-review.googlesource.com/c/1366835
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614621}

    Changed files

    • components/previews/content/previews_decider_impl.cc
    • components/previews/content/previews_decider_impl_unittest.cc
    • components/previews/core/previews_black_list.h
    • components/previews/core/previews_logger.cc
    • tools/metrics/histograms/enums.xml

  10. Remove RenderFrameHostImpl::subresource_loader_factories_bundle_ which is unused

    Changed by Kinuko Yasuda - kinukoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:09:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b1eb8373104f00c0ca44780a28d621dd6cf2f603

    Comments

    Remove RenderFrameHostImpl::subresource_loader_factories_bundle_ which is unused

This field was added before to keep the copy of the bundle around in
RFHI but not really used any more.

Bug: N/A
Change-Id: Ib007ee7dc941b980bab3ad92a1de016ad14d155c
Reviewed-on: https://chromium-review.googlesource.com/c/1365052
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614620}

    Changed files

    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl.h

  11. Roll src-internal 10e8db47197f..3e90e0805dd5 (6 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 05:50:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e595fa693a4ef17b348340dbb64cf039c765e9c7

    Comments

    Roll src-internal 10e8db47197f..3e90e0805dd5 (6 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/10e8db47197f..3e90e0805dd5


Created with:
  gclient setdep -r src-internal@3e90e0805dd5

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ia59b4d7347cb4c123f7e30d889f30af08e8b39f8
Reviewed-on: https://chromium-review.googlesource.com/c/1367115
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614619}

    Changed files

    • DEPS

  12. Timer notification UI improvement:

    Changed by Li Lin - llinohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 05:41:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d710a7b3ef59302c00c2e3fe1b00c788310801c6

    Comments

    Timer notification UI improvement:

* Add timer deeplinks for:
  - Stop timer
  - Add time to timer
* Add "add 1 min to timer" button to timer notification.

Using a feature flag to guard the usage of the deeplink as
AlarmTimerManager is not fully available yet.

Bug: b:119116816
Change-Id: Ib9b28abecece1bb4fc60b88f367900f6f08f2efe
Reviewed-on: https://chromium-review.googlesource.com/c/1340786
Commit-Queue: Li Lin <llin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614618}

    Changed files

    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/assistant/util/deep_link_util.cc
    • ash/assistant/util/deep_link_util.h
    • ash/assistant/util/deep_link_util_unittest.cc
    • chromeos/chromeos_strings.grd
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h

  13. Crostini: migrate persisted paths from Downloads to MyFiles

    Changed by Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 05:38:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aa7bc76e086df2f9428a2d583546f84f81c59d16

    Comments

    Crostini: migrate persisted paths from Downloads to MyFiles

When MyFiles is enabled, check persisted paths in prefs
and convert paths as needed.

Bug: 911946
Change-Id: I3931d196f89f31fa2ae95f7e02f9241b25d23524
Reviewed-on: https://chromium-review.googlesource.com/c/1366458
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614617}

    Changed files

    • chrome/browser/chromeos/crostini/crostini_share_path.cc
    • chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
    • chrome/browser/chromeos/file_manager/path_util.cc
    • chrome/browser/chromeos/file_manager/path_util.h
    • chrome/browser/chromeos/file_manager/path_util_unittest.cc

  14. Update V8 to version 7.3.56.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 05:30:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a61841709892ab7b5fc112c935f62851a2d3831e

    Comments

    Update V8 to version 7.3.56.

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2192eb7f..fd3bdfda

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I21cf598a516538376f34825912d8dd575a2ce058
Reviewed-on: https://chromium-review.googlesource.com/c/1367111
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614616}

    Changed files

    • DEPS