Home | Search | chromium - Builders
Login

Builder Mac FYI Release (Intel) Build 7289 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revisionb85f543af1e343404dde1a2c51067b2ed5ac08cb
Got Revisionb85f543af1e343404dde1a2c51067b2ed5ac08cb

Execution:

Steps and Logfiles:

Show:
  1. ( 328 ms ) setup_build
    running recipe: "chromium"
  2. ( 220 ms ) report builders
     
    running tester 'Mac FYI Release (Intel)' on master 'chromium.gpu.fyi'
  3. ( 1 mins 17 secs ) bot_update
    [79GB/232GB used (34%)]
  4. ( 0 ) ensure_goma
  5. ( 721 ms ) swarming.py --version
    0.13
  6. ( 158 ms ) ensure_installed
  7. ( 13 secs ) gclient runhooks
  8. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
  9. ( 369 ms ) lookup builder GN args
     
    build_angle_gles1_conform_tests = true
    dcheck_always_on = true
    ffmpeg_branding = "Chrome"
    internal_gles2_conform_tests = true
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  10. ( 408 ms ) build directory
  11. ( 381 ms ) find isolated tests
  12. ( 0 ) test_pre_run
  13. ( 3 secs ) angle_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 53s
  14. ( 36 secs ) tab_capture_end2end_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 34s
  15. ( 1 secs ) gl_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:44.207040
  16. ( 1 secs ) gl_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:34.255124
  17. ( 2 secs ) gles2_conform_test on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 58s
  18. ( 2 secs ) gpu_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 19s
  19. ( 15 secs ) services_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 12s
  20. ( 1 secs ) swiftshader_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 6s
  21. ( 2 secs ) angle_end2end_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Max shard duration: 14s (shard #1)
    Min shard duration: 13s (shard #2)
  22. ( 2 mins 28 secs ) context_lost_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:02:21.871023
    Total tests: 10
    * Passed: 10 (10 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  23. ( 28 secs ) depth_capture_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 25s
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  24. ( 53 secs ) gpu_process_launch_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 50s
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  25. ( 21 secs ) hardware_accelerated_feature_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 20s
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  26. ( 25 secs ) info_collection_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 23s
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  27. ( 54 secs ) maps_pixel_test on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 52s
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  28. ( 3 mins 28 secs ) pixel_test on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:03:19.440283
    Total tests: 57
    * Passed: 54 (54 expected, 0 unexpected)
    * Skipped: 3 (3 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 53 secs ) screenshot_sync_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 50s
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 1 mins ) trace_test on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 57s
    Total tests: 36
    * Passed: 18 (18 expected, 0 unexpected)
    * Skipped: 18 (18 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  31. ( 23 mins 31 secs ) webgl2_conformance_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Max shard duration: 0:23:22.433941 (shard #7)
    Min shard duration: 0:07:06.836972 (shard #10)
    Total tests: 2781
    * Passed: 2716 (2716 expected, 0 unexpected)
    * Skipped: 65 (65 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  32. ( 6 mins 28 secs ) webgl_conformance_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Max shard duration: 0:06:12.819041 (shard #1)
    Min shard duration: 0:02:26.607261 (shard #0)
    Total tests: 926
    * Passed: 919 (919 expected, 0 unexpected)
    * Skipped: 7 (7 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  33. ( 269 ms ) Tests statistics
     
    Stats
    Total shards: 43
    Total runtime: 3:04:30.767552
     
  34. ( 3 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "build81-m9" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539351405669049, "id": "8932866776407482096", "project": "chromium", "tags": ["builder:Mac FYI Release (Intel)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/b85f543af1e343404dde1a2c51067b2ed5ac08cb", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Mac Builder", "parent_buildnumber:23981", "scheduler_invocation_id:9098296838608022816", "scheduler_job_id:chromium/Mac FYI Release (Intel)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Mac FYI Release (Intel)" setup_build
buildnumber 7289 setup_build
mastername "chromium.gpu.fyi" setup_build
parent_buildername "GPU FYI Mac Builder" setup_build
parent_got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" setup_build
parent_got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" setup_build
parent_got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" setup_build
parent_got_revision "b85f543af1e343404dde1a2c51067b2ed5ac08cb" setup_build
parent_got_revision_cp "refs/heads/master@{#599191}" setup_build
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" setup_build
parent_got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" setup_build
parent_got_v8_revision_cp "refs/heads/7.1.302@{#1}" setup_build
parent_got_webrtc_revision "55d1af14751ad10e0cae741240f013ea67039f45" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25138}" setup_build
parent_mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "b85f543af1e343404dde1a2c51067b2ed5ac08cb" setup_build
swarm_hashes {"angle_end2end_tests": "379553b02756189637d37b439177a6493f142e5a", "angle_unittests": "3af1f03ce0f689a6914fbfe10a0d0f7900ff2353", "browser_tests": "abc1ef5dd1fe8085e9befbd44159f1bc5bc80350", "gl_tests": "99ff66f2dc9963ae929897b65b3c626035e1bf88", "gl_unittests": "27b7e3cf53323642d98ad131638a2e8ce0e0449b", "gles2_conform_test": "84074cd2dddae6dd82d64da00c040b7eecdf74d4", "gpu_unittests": "df5eee88c64d4f2a6269bcfbdf38bda0f3d9ced7", "services_unittests": "693f484c45e4b746fa5aec322e2bc21502db396d", "swiftshader_unittests": "887bfd2c07de007e59ffcd2eab31a08bee292560", "telemetry_gpu_integration_test": "8a6c227f641368058eba922bd9113c2089bf396f"} setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "b85f543af1e343404dde1a2c51067b2ed5ac08cb" bot_update
got_revision_cp "refs/heads/master@{#599191}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "55d1af14751ad10e0cae741240f013ea67039f45" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25138}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. Shu Chen (shuchenohnoyoudont@google.com)
  2. Findit (findit-for-meohnoyoudont@appspot.gserviceaccount.com)
  3. Colin Blundell (blundellohnoyoudont@chromium.org)
  4. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  5. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  6. Morten Stenshorne (mstenshoohnoyoudont@chromium.org)
  7. Christian Dullweber (dullweberohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 13:36:45 UTC
Start Friday, 12-Oct-18 13:36:48 UTC
End Friday, 12-Oct-18 14:22:23 UTC
Pending 2 secs
Execution 45 mins 35 secs

All Changes:

  1. Avoid using gypi_to_gn.py.

    Changed by Shu Chen - shuchenohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 13:25:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b85f543af1e343404dde1a2c51067b2ed5ac08cb

    Comments

    Avoid using gypi_to_gn.py.
    
    Change-Id: I9bac8317577feaadfa00ec88661175b7338ced4a
    Reviewed-on: https://chromium-review.googlesource.com/c/1267596
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Shu Chen <shuchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599191}

    Changed files

    • third_party/google_input_tools/README.chromium
    • third_party/google_input_tools/builder.py
    • third_party/google_input_tools/closure.gni
    • third_party/google_input_tools/inputview.gni
    • third_party/google_input_tools/inputview.gypi
    • third_party/google_input_tools/update.py
    • ui/keyboard/BUILD.gn
  2. Revert "Files app: Select My files when there are no volumes"

    Changed by Findit - findit-for-meohnoyoudont@appspot.gserviceaccount.com
    Changed at Friday, 12-Oct-18 13:17:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 402571f89e1aff1627ccf491110764c74029e3de

    Comments

    Revert "Files app: Select My files when there are no volumes"
    
    This reverts commit 5cd8c123e452c0b76fbbcaf53e82d86ca7d54930.
    
    Reason for revert:
    
    Findit (https://goo.gl/kROfz5) identified CL at revision 599026 as the
    culprit for flakes in the build cycles as shown on:
    https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNWNkOGMxMjNlNDUyYzBiNzZmYmJjYWY1M2U4MmQ4NmNhN2Q1NDkzMAw
    
    Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/9016
    
    Sample Failed Step: viz_browser_tests
    
    Sample Flaky Test: FileDisplay/FilesAppBrowserTest.Test/fileDisplayWithoutVolumesThenMountDrive_DriveFs
    
    Original change's description:
    > Files app: Select My files when there are no volumes
    > 
    > Make Files app select "My files" when there are no available volumes,
    > this to allow Files app to behave properly when volumes subsequently
    > become available.
    > 
    > Change DirectoryModel.onVolumeInfoListUpdated_ method to check for
    > non-null |displayRoot| before trying to change to |displayRoot|. This
    > fixes the error "Cannot read property 'getParent' of null" when Drive
    > volume becomes available before Downloads volume, which is the default
    > volume/root.
    > 
    > Change FakeDriveFs to unbind the two mojo bindings if they're bound, so
    > DriveFsTestVolume can re-mount itself.
    > 
    > Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*"
    > Bug: 893161, 884967
    > Change-Id: Ic813b25261530495c11c9f641a92f6e07f883702
    > Reviewed-on: https://chromium-review.googlesource.com/c/1272418
    > Reviewed-by: Noel Gordon <noel@chromium.org>
    > Reviewed-by: Sam McNally <sammc@chromium.org>
    > Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599026}
    
    Change-Id: I883485c8fc1bdcc22dba93cc4b03b7c157dcb5f2
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 893161, 884967, 889703
    Reviewed-on: https://chromium-review.googlesource.com/c/1278063
    Cr-Commit-Position: refs/heads/master@{#599190}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
    • chromeos/components/drivefs/fake_drivefs.cc
    • ui/file_manager/file_manager/foreground/js/directory_model.js
    • ui/file_manager/file_manager/foreground/js/file_manager.js
    • ui/file_manager/integration_tests/file_manager/file_display.js
  3. Start using IdentityTestEnvironment in ProfileSyncServiceBundle

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:10:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 863a437d0fdbbba19ad5446420b72d2f91748a72

    Comments

    Start using IdentityTestEnvironment in ProfileSyncServiceBundle
    
    ProfileSyncServiceBundle owns and exposes signin-related objects for
    use by sync tests. These signin-related objects include ones that are
    deprecated by IdentityManager and no longer used directly in the
    production code being tested; however, up until now it has not been
    feasible to convert this test utility to using IdentityTestEnvironment,
    as doing so would have required converting the widespread usage of this
    utility in one go.
    
    We recently introduced an IdentityTestEnvironment usage mode wherein
    it can be supplied with IdentityManager's dependencies from the
    external client, precisely to enable incremental conversion in use cases
    like this. This CL exploits this usage mode to introduce
    IdentityTestEnvironment in ProfileSyncServiceBundle.h and provide an
    example of its usage to eliminate a direct usage of the deprecated
    classes. Once the conversion is complete, ProfileSyncServiceBundle can
    then be changed to *only* hold an IdentityTestEnvironment object.
    
    Bug: 886600, 886599
    Change-Id: I205c3567fc0a9bcd6f7b613c00a247c302d71be5
    Reviewed-on: https://chromium-review.googlesource.com/c/1273065
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599189}

    Changed files

    • components/browser_sync/BUILD.gn
    • components/browser_sync/profile_sync_service_autofill_unittest.cc
    • components/browser_sync/profile_sync_test_util.cc
    • components/browser_sync/profile_sync_test_util.h
  4. Import wpt@e8a20c396e2ed7b7b8b2cacd3128f959e710a243

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:59:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c12ec9eedc27e721f93de806016cfcf26225fde9

    Comments

    Import wpt@e8a20c396e2ed7b7b8b2cacd3128f959e710a243
    
    Using wpt-import in Chromium 68550e484d7eecf6bd1d39fca300644ab2c21f5d.
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25974
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    NOAUTOREVERT=true
    TBR=lukebjerring
    
    No-Export: true
    Change-Id: I132a332cdc953a69e5c54c550a9bb4e5d08c9bb5
    Reviewed-on: https://chromium-review.googlesource.com/c/1277603
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599188}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/webrtc.idl
  5. Roll src-internal f37e9866851d..2cecd6e79600 (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 12:56:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2f64dae1358dab03fb6fb5e12fc444dad20d38f4

    Comments

    Roll src-internal f37e9866851d..2cecd6e79600 (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f37e9866851d..2cecd6e79600
    
    
    Created with:
      gclient setdep -r src-internal@2cecd6e79600
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Iac9c77c5c0927e0ca3862bf5171f5972e5c40ca7
    Reviewed-on: https://chromium-review.googlesource.com/c/1278711
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599187}

    Changed files

    • DEPS
  6. [LayoutNG] Mark nopaint-after-layer-destruction.html as passing again.

    Changed by Morten Stenshorne - mstenshoohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:45:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 17f212ee41ac78c428f851f24fa76ffee0ec8c3d

    Comments

    [LayoutNG] Mark nopaint-after-layer-destruction.html as passing again.
    
    Needed some rebaselining on Mac.
    
    Attempted to mark it as passing here:
    https://chromium-review.googlesource.com/c/1277649
    
    Then a sheriff marked it as failing again:
    https://chromium-review.googlesource.com/c/chromium/src/+/1278785
    
    TBR=kojii@chromium.org,orphis@chromium.org
    
    Change-Id: I4b282cba19e6c94f032c127f70672cf4cfe133ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1278805
    Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599186}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/platform/mac/fast/block/float/nopaint-after-layer-destruction-expected.txt
    • third_party/WebKit/LayoutTests/platform/mac/virtual/layout_ng/fast/block/float/nopaint-after-layer-destruction-expected.png
  7. Log UserDeletedCookieOrCacheFromDialog from Android

    Changed by Christian Dullweber - dullweberohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:43:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aeec7095a6a5129132a4fe7e5f5f0abeb2cf8ff3

    Comments

    Log UserDeletedCookieOrCacheFromDialog from Android
    
    We currently log the UserDeletedCookieOrCacheFromDialog histogram from
    Desktop. On Android we only know about total cookie/cache deletion
    and not those started from CBD.
    This CL adds logging of the UserDeletedCookieOrCacheFromDialog histogram
    to the CBD dialog on Android.
    
    Change-Id: I51c1ff6d3c5dc6f531f5bfccc59f522718b1abef
    Reviewed-on: https://chromium-review.googlesource.com/c/1276605
    Commit-Queue: Christian Dullweber <dullweber@chromium.org>
    Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599185}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesBasic.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java
    • content/public/android/BUILD.gn
    • content/public/browser/browsing_data_remover.h