Home | Search | chromium - Builders
Login

Builder Mac FYI GPU ASAN Release Build 2888 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revisionb87d9e9516460c683b698bb569d85ed8a9fd7348
Got Revisionb87d9e9516460c683b698bb569d85ed8a9fd7348

Execution:

Steps and Logfiles:

Show:
  1. ( 338 ms ) setup_build
    running recipe: "chromium"
  2. ( 209 ms ) report builders
     
    running builder/tester 'Mac FYI GPU ASAN Release' on master 'chromium.gpu.fyi'
  3. ( 1 mins 36 secs ) bot_update
    [125GB/232GB used (53%)]
  4. ( 724 ms ) swarming.py --version
    0.14
  5. ( 168 ms ) ensure_installed
  6. ( 15 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
  8. ( 384 ms ) lookup GN args
     
    build_angle_gles1_conform_tests = true
    dcheck_always_on = true
    enable_nacl = false
    ffmpeg_branding = "Chrome"
    internal_gles2_conform_tests = true
    is_asan = true
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  9. ( 21 secs ) generate_build_files
  10. ( 520 ms ) clang_revision
  11. ( 56 mins 13 secs ) compile
  12. ( 35 secs ) isolate tests
  13. ( 340 ms ) find isolated tests
  14. ( 1 secs ) wait for tasks
  15. ( 1 secs ) gl_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 9s
  16. ( 2 secs ) gl_unittests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 11s
  17. ( 1 secs ) dawn_end2end_tests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Max shard duration: 9s (shard #3)
    Min shard duration: 8s (shard #0)
  18. ( 1 secs ) hardware_accelerated_feature_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 36s
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  19. ( 1 secs ) swiftshader_unittests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 9s
  20. ( 1 secs ) gl_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 25s
  21. ( 1 secs ) tab_capture_end2end_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 52s
  22. ( 2 secs ) angle_end2end_tests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Max shard duration: 17s (shard #1)
    Min shard duration: 16s (shard #0)
  23. ( 1 secs ) services_unittests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 23s
  24. ( 1 secs ) depth_capture_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 36s
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  25. ( 1 secs ) gl_tests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 57s
  26. ( 1 secs ) tab_capture_end2end_tests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 54s
  27. ( 1 secs ) depth_capture_tests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 42s
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  28. ( 2 secs ) swiftshader_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 9s
  29. ( 13 secs ) angle_end2end_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Max shard duration: 20s (shard #3)
    Min shard duration: 19s (shard #0)
  30. ( 6 secs ) dawn_end2end_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Max shard duration: 9s (shard #3)
    Min shard duration: 6s (shard #1)
  31. ( 2 secs ) services_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 17s
  32. ( 842 ms ) wait for tasks (2)
  33. ( 1 secs ) maps_pixel_test on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 56s
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  34. ( 1 secs ) maps_pixel_test on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:01:04.489902
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  35. ( 3 secs ) gpu_unittests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 52s
  36. ( 1 secs ) hardware_accelerated_feature_tests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 40s
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  37. ( 3 secs ) gpu_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:11.856259
  38. ( 2 secs ) gpu_process_launch_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:21.646996
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  39. ( 2 secs ) gles2_conform_test on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:48.646537
  40. ( 4 secs ) screenshot_sync_tests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:01:24.946277
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  41. ( 1 secs ) wait for tasks (3)
  42. ( 1 secs ) gpu_process_launch_tests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:02:00.375346
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  43. ( 4 secs ) angle_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:02:46.824100
  44. ( 3 secs ) angle_unittests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:02:54.516620
  45. ( 1 secs ) context_lost_tests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:02:24.123671
    Total tests: 10
    * Passed: 10 (10 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  46. ( 2 secs ) context_lost_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:02:11.780449
    Total tests: 10
    * Passed: 10 (10 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  47. ( 1 mins 6 secs ) wait for tasks (4)
  48. ( 11 secs ) trace_test on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:03:41.047219
    Total tests: 48
    * Passed: 24 (24 expected, 0 unexpected)
    * Skipped: 24 (24 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  49. ( 2 secs ) trace_test on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:03:59.530285
    Total tests: 48
    * Passed: 24 (24 expected, 0 unexpected)
    * Skipped: 24 (24 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  50. ( 1 mins 5 secs ) wait for tasks (5)
  51. ( 2 secs ) pixel_test on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:05:19.810975
    Total tests: 64
    * Passed: 61 (61 expected, 0 unexpected)
    * Skipped: 3 (3 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  52. ( 1 secs ) gles2_conform_test on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:05:12.809560
  53. ( 2 mins 1 secs ) wait for tasks (6)
  54. ( 2 secs ) screenshot_sync_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:06:07.516580
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  55. ( 2 secs ) pixel_test on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:06:56.169240
    Total tests: 64
    * Passed: 61 (61 expected, 0 unexpected)
    * Skipped: 3 (3 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  56. ( 6 mins 4 secs ) wait for tasks (7)
  57. ( 2 secs ) webgl_conformance_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Max shard duration: 0:12:30.372544 (shard #1)
    Min shard duration: 0:05:48.415999 (shard #0)
    Total tests: 936
    * Passed: 930 (930 expected, 0 unexpected)
    * Skipped: 6 (6 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  58. ( 3 secs ) webgl_conformance_tests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Max shard duration: 0:12:38.640464 (shard #1)
    Min shard duration: 0:04:18.280989 (shard #0)
    Total tests: 936
    * Passed: 930 (930 expected, 0 unexpected)
    * Skipped: 6 (6 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  59. ( 14 mins 3 secs ) wait for tasks (8)
  60. ( 4 secs ) webgl2_conformance_tests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Max shard duration: 0:26:45.688715 (shard #19)
    Min shard duration: 0:13:41.008963 (shard #7)
    Total tests: 2800
    * Passed: 2735 (2735 expected, 0 unexpected)
    * Skipped: 65 (65 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  61. ( 4 mins 31 secs ) webgl2_conformance_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Max shard duration: 0:32:11.911754 (shard #12)
    Min shard duration: 0:12:56.112191 (shard #7)
    Total tests: 2800
    * Passed: 2735 (2735 expected, 0 unexpected)
    * Skipped: 65 (65 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  62. ( 396 ms ) Tests statistics
     
    Stats
    Total shards: 92
    Total runtime: 11:21:51.428248
     
  63. ( 1 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "build91-m9" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544159527421676, "id": "8927825095333220304", "project": "chromium", "tags": ["builder:Mac FYI GPU ASAN Release", "buildset:commit/git/b87d9e9516460c683b698bb569d85ed8a9fd7348", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/b87d9e9516460c683b698bb569d85ed8a9fd7348", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9093255157406418000", "scheduler_job_id:chromium/Mac FYI GPU ASAN Release", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Mac FYI GPU ASAN Release" setup_build
buildnumber 2888 setup_build
mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "b87d9e9516460c683b698bb569d85ed8a9fd7348" setup_build
got_angle_revision "7c985f5c4f1ae2caa3629bbee08c0e27853d196d" bot_update
got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" bot_update
got_dawn_revision "0f50114b3c6849238eedf95236137d614fed4be2" bot_update
got_nacl_revision "8e13fe5e85640b063aefcb88a3ccb52abf6e28e8" bot_update
got_revision "b87d9e9516460c683b698bb569d85ed8a9fd7348" bot_update
got_revision_cp "refs/heads/master@{#614614}" bot_update
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" bot_update
got_v8_revision "2192eb7f7ea45e3a7ee625cf3156f1469abed8b8" bot_update
got_v8_revision_cp "refs/heads/7.3.55@{#1}" bot_update
got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25919}" bot_update
got_clang_revision "346388-5" clang_revision
swarm_hashes_refs/heads/master(at){#614614}_without_patch {"angle_end2end_tests": "5bd9319358750a6ac288b9bf9375cbc347c1bff7", "angle_unittests": "3425282bfa3b4ebcc74526ca5401e4a8fb2d5e53", "browser_tests": "a965b370c739b6ef6bdea4671f54dedc3cfbb943", "dawn_end2end_tests": "ee6ed4c29a0202c0bfdab3401b9920ce8455dff0", "gl_tests": "60e2821180519c55978c29ec8ccf95a645ba4be2", "gl_unittests": "69d1884e2ae8068c25125e58aa1a011c4c05957e", "gles2_conform_test": "610ceb0c09be0373b775743d42c7afa4589bdea1", "gpu_unittests": "0c8e343f1038bdb9fe69ac12f8d394b359dcfa27", "services_unittests": "231af678bbddd889310523934efc724d4a45fb22", "swiftshader_unittests": "6cbb65d8cee3713220b20deb5b26fa57d521b12f", "telemetry_gpu_integration_test": "fb5ec70ab620f133724b30ac5a465d836e9ee278"} isolate tests
swarm_hashes {"angle_end2end_tests": "5bd9319358750a6ac288b9bf9375cbc347c1bff7", "angle_unittests": "3425282bfa3b4ebcc74526ca5401e4a8fb2d5e53", "browser_tests": "a965b370c739b6ef6bdea4671f54dedc3cfbb943", "dawn_end2end_tests": "ee6ed4c29a0202c0bfdab3401b9920ce8455dff0", "gl_tests": "60e2821180519c55978c29ec8ccf95a645ba4be2", "gl_unittests": "69d1884e2ae8068c25125e58aa1a011c4c05957e", "gles2_conform_test": "610ceb0c09be0373b775743d42c7afa4589bdea1", "gpu_unittests": "0c8e343f1038bdb9fe69ac12f8d394b359dcfa27", "services_unittests": "231af678bbddd889310523934efc724d4a45fb22", "swiftshader_unittests": "6cbb65d8cee3713220b20deb5b26fa57d521b12f", "telemetry_gpu_integration_test": "fb5ec70ab620f133724b30ac5a465d836e9ee278"} find isolated tests

Blamelist:

  1. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  2. Adam Rice (riceaohnoyoudont@chromium.org)
  3. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  4. Madeleine Barowsky (mbarowskyohnoyoudont@chromium.org)
  5. Aleks Totic (atoticohnoyoudont@chromium.org)
  6. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
  7. Justin DeWitt (dewittjohnoyoudont@chromium.org)
  8. Eugene But (eugenebutohnoyoudont@google.com)
  9. rbpotter (rbpotterohnoyoudont@chromium.org)
  10. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  11. Scott Chen (scottchenohnoyoudont@chromium.org)
  12. Darren Shen (shendohnoyoudont@chromium.org)
  13. Devlin Cronin (rdevlin.croninohnoyoudont@chromium.org)
  14. Reilly Grant (reillygohnoyoudont@google.com)
  15. Clark DuVall (cduvallohnoyoudont@chromium.org)
  16. Alexander Alekseev (alemateohnoyoudont@chromium.org)
  17. Kyle Horimoto (khorimotoohnoyoudont@chromium.org)
  18. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  19. Victor Vasiliev (vasilvvohnoyoudont@chromium.org)
  20. Leon Han (leon.hanohnoyoudont@intel.com)
  21. Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
  22. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  23. Eric Willigers (ericwilligersohnoyoudont@chromium.org)
  24. John Budorick (jbudorickohnoyoudont@chromium.org)
  25. liberato@chromium.org (liberatoohnoyoudont@chromium.org)
  26. Ryan Hansberry (hansberryohnoyoudont@chromium.org)
  27. Mohsen Izadi (mohsenohnoyoudont@chromium.org)
  28. Matthew Mourgos (mmourgosohnoyoudont@chromium.org)
  29. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  30. Hiroki Nakagawa (nhirokiohnoyoudont@chromium.org)
  31. Luciano Pacheco (lucmultohnoyoudont@chromium.org)
  32. Nigel Tao (nigeltaoohnoyoudont@chromium.org)
  33. Kent Tamura (tkentohnoyoudont@chromium.org)
  34. Dan Beam (dbeamohnoyoudont@chromium.org)

Timing:

Create Friday, 07-Dec-18 05:12:07 UTC
Start Friday, 07-Dec-18 05:12:18 UTC
End Friday, 07-Dec-18 06:46:13 UTC
Pending 10 secs
Execution 1 hrs 33 mins

All Changes:

  1. Roll src/native_client 17af1e818981..8e13fe5e8564 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 05:10:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b87d9e9516460c683b698bb569d85ed8a9fd7348

    Comments

    Roll src/native_client 17af1e818981..8e13fe5e8564 (1 commits)
    
    https://chromium.googlesource.com/native_client/src/native_client.git/+log/17af1e818981..8e13fe5e8564
    
    
    git log 17af1e818981..8e13fe5e8564 --date=short --no-merges --format='%ad %ae %s'
    2018-12-07 jchinlee@chromium.org Surface lxml for use via vpython.
    
    
    Created with:
      gclient setdep -r src/native_client@8e13fe5e8564
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:912379
    TBR=mseaborn@chromium.org
    
    Change-Id: I53ddc48b5935ca8ea3f5bd8a44d39a43341edb2a
    Reviewed-on: https://chromium-review.googlesource.com/c/1366881
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614614}

    Changed files

    • DEPS
  2. Remove EncodingStreams runtime flag

    Changed by Adam Rice - riceaohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 05:10:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2fbb267e716151d87e9bb0a394935f6944515700

    Comments

    Remove EncodingStreams runtime flag
    
    TextEncoderStream and TextDecoderStream have shipped. The flag is no
    longer needed. Remove it.
    
    BUG=898158
    
    Change-Id: Ie08d787509f075715b084c7d5e55ad7b2a0e2fb4
    Reviewed-on: https://chromium-review.googlesource.com/c/1364934
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Adam Rice <ricea@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614613}

    Changed files

    • third_party/blink/renderer/modules/encoding/text_decoder_stream.idl
    • third_party/blink/renderer/modules/encoding/text_encoder_stream.idl
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  3. Roll src/third_party/angle 132d15c217e0..c3e3731cd3b2 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 05:06:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2c653611523cbca009b53d250a568e95aacf9c29

    Comments

    Roll src/third_party/angle 132d15c217e0..c3e3731cd3b2 (2 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/132d15c217e0..c3e3731cd3b2
    
    
    git log 132d15c217e0..c3e3731cd3b2 --date=short --no-merges --format='%ad %ae %s'
    2018-12-07 jmadill@chromium.org Give every validation error a constant.
    2018-12-06 syoussefi@chromium.org Vulkan: Add dynamic vertex buffers to graph
    
    
    Created with:
      gclient setdep -r src/third_party/angle@c3e3731cd3b2
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=ynovikov@chromium.org
    
    Change-Id: Iaed9b0cae0e3386ca9836bc3caaf112c87dd8d17
    Reviewed-on: https://chromium-review.googlesource.com/c/1367169
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614612}

    Changed files

    • DEPS
  4. Define libwebp max allocation limit in GN fuzzer targets

    Changed by Madeleine Barowsky - mbarowskyohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:49:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d639093c7a8572cdcbec81cc6b28dfb860ce815

    Comments

    Define libwebp max allocation limit in GN fuzzer targets
    
    This upper bound of 800MiB is previously enforced in the oss-fuzz
    targets [1], so we are adding it here too for consistency.
    
    [1]: github.com/google/oss-fuzz/blob/master/projects/libwebp/build.sh#L19
    
    Bug: 901042
    Change-Id: I5d1f3a970340c0c60c39e52ab2f959e0253ff63c
    Reviewed-on: https://chromium-review.googlesource.com/c/1365655
    Reviewed-by: Max Moroz <mmoroz@chromium.org>
    Reviewed-by: James Zern <jzern@google.com>
    Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614611}

    Changed files

    • third_party/libwebp/BUILD.gn
  5. [LayoutNG] DCHECK that inline container is containing block

    Changed by Aleks Totic - atoticohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:49:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 249af433d7f20d80d1d9cc225333ead0ef67d47f

    Comments

    [LayoutNG] DCHECK that inline container is containing block
    
    Bug: 740993
    Change-Id: Ie8abce134861f5a5a7cf694225da7073c48ae773
    Reviewed-on: https://chromium-review.googlesource.com/c/1321167
    Commit-Queue: Aleks Totic <atotic@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614610}

    Changed files

    • third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.cc
  6. [DevTools] Do not report worker console messages twice

    Changed by Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:46:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e41224229e7a61deb59a2a5d7bf5175cc56bf14c

    Comments

    [DevTools] Do not report worker console messages twice
    
    When the worker is still alive while DevTools is being opened,
    there is a race between console messages coming from page and
    worker target creation.
    
    Bug: 908863
    Change-Id: I9495d4becada0e4f2bd208c0922b2a2a3ea98af9
    Reviewed-on: https://chromium-review.googlesource.com/c/1359039
    Reviewed-by: Joel Einbinder <einbinder@chromium.org>
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614609}

    Changed files

    • third_party/blink/renderer/devtools/front_end/browser_sdk/LogManager.js
    • third_party/blink/renderer/devtools/front_end/sdk/ConsoleModel.js
  7. [EoS] Enable re-scrolling on back button.

    Changed by Justin DeWitt - dewittjohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:45:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2a94ae3b82c0e840d2eff0a21edb3cc591700f3c

    Comments

    [EoS] Enable re-scrolling on back button.
    
    This utilizes LinearLayoutManager#onSaveInstanceState to provide a
    parcelable.  This is stashed on the NavigationEntry (which is OK since it
    is not persisted in any way.)
    
    Change-Id: I903ef6440d1ef8e3d65d2e3764c2da35201b8b18
    Reviewed-on: https://chromium-review.googlesource.com/c/1362198
    Commit-Queue: Justin DeWitt <dewittj@chromium.org>
    Reviewed-by: Cathy Li <chili@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614608}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java
    • chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridge.java
    • chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPageTest.java
    • chrome/test/data/android/render_tests/ExploreSitesPageTest.initial_layout.Nexus_5-19.png
    • chrome/test/data/android/render_tests/ExploreSitesPageTest.recycler_layout.Nexus_5-19.png
    • chrome/test/data/android/render_tests/ExploreSitesPageTest.recycler_layout_back.Nexus_5-19.png
  8. Create OWNERS file for ios/web_view/internal/passwords.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 04:45:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8cdaa50cfb8075f774149c3b525b37301fc9f62a

    Comments

    Create OWNERS file for ios/web_view/internal/passwords.
    
    jzw@ wrote large portion of this code and ichikawa@ reviewed most of the
    changes. This CL effectively removes eugenebut@, michaeldo@ or rohitrao@
    from ios/web_view/internal/passwords OWNERS, because these engineers are
    not very familiar with the code.
    
    Bug: None
    Change-Id: I9343624316a7fee7376e13f6b942439d22baa8c2
    Reviewed-on: https://chromium-review.googlesource.com/c/1366258
    Reviewed-by: John Wu <jzw@chromium.org>
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614607}

    Changed files

    • ios/web_view/internal/passwords/OWNERS
  9. MD History: Make history item use FocusRowBehavior

    Changed by rbpotter - rbpotterohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:44:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9d890486deef4f4822344fa734cafcc2be778805

    Comments

    MD History: Make history item use FocusRowBehavior
    
    history-item shared a large amount of logic with the settings
    FocusRowBehavior. This CL moves FocusRowBehavior to cr/ui (with
    FocusRow), and makes history item implement it instead of using custom
    logic.
    
    Bug: None
    Change-Id: Id326142bf25a231ef9cbc338c7fe2a3f9551d3f6
    Reviewed-on: https://chromium-review.googlesource.com/c/1345414
    Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614606}

    Changed files

    • chrome/browser/resources/md_history/BUILD.gn
    • chrome/browser/resources/md_history/history_item.html
    • chrome/browser/resources/md_history/history_item.js
    • chrome/browser/resources/settings/BUILD.gn
    • chrome/browser/resources/settings/autofill_page/BUILD.gn
    • chrome/browser/resources/settings/autofill_page/password_list_item.html
    • chrome/browser/resources/settings/autofill_page/password_list_item.js
    • chrome/browser/resources/settings/focus_row_behavior.html
    • chrome/browser/resources/settings/focus_row_behavior.js
    • chrome/browser/resources/settings/on_startup_page/BUILD.gn
    • chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
    • chrome/browser/resources/settings/on_startup_page/startup_url_entry.js
    • chrome/browser/resources/settings/search_engines_page/BUILD.gn
    • chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
    • chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js
    • chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
    • chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
    • chrome/browser/resources/settings/settings_resources.grd
    • chrome/browser/resources/settings/site_settings/BUILD.gn
    • chrome/browser/resources/settings/site_settings/site_data_entry.html
    • chrome/browser/resources/settings/site_settings/site_data_entry.js
    • chrome/browser/resources/settings/site_settings/site_list_entry.html
    • chrome/browser/resources/settings/site_settings/site_list_entry.js
    • chrome/test/data/webui/BUILD.gn
    • chrome/test/data/webui/cr_focus_row_behavior_interactive_test.js
    • chrome/test/data/webui/cr_focus_row_behavior_test.js
    • chrome/test/data/webui/settings/cr_settings_interactive_ui_tests.js
    • ui/webui/resources/html/cr/ui/focus_row_behavior.html
    • ui/webui/resources/js/cr/ui/BUILD.gn
    • ui/webui/resources/js/cr/ui/focus_grid.js
    • ui/webui/resources/js/cr/ui/focus_row.js
    • ui/webui/resources/js/cr/ui/focus_row_behavior.js
    • ui/webui/resources/webui_resources.grd
  10. Roll src/third_party/perfetto f4a214430436..f1a2558c421d (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 04:44:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab2a18af11b07f338b2b59d493c767d8f1dbdefa

    Comments

    Roll src/third_party/perfetto f4a214430436..f1a2558c421d (2 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/f4a214430436..f1a2558c421d
    
    
    git log f4a214430436..f1a2558c421d --date=short --no-merges --format='%ad %ae %s'
    2018-12-07 primiano@google.com Cache new git deps in Travis
    2018-12-07 primiano@google.com Merge "TraceProcessor: add parsing of oom_score_adj"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@f1a2558c421d
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I31a16930ff43c4e094d9992352b94c71633957d9
    Reviewed-on: https://chromium-review.googlesource.com/c/1367097
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614605}

    Changed files

    • DEPS
  11. Nux Onboarding: fix race-condition crashes

    Changed by Scott Chen - scottchenohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:43:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a6223083496b5fed8d8bb69c38b20d7819ca3be9

    Comments

    Nux Onboarding: fix race-condition crashes
    
    There are a couple race-conditions happening in the code that
    in combination causes 'undefined' to be passed to the C++ handler,
    which crashes on a CHECK in BookmarkHandler:
    - in some places toggleBookmarkBar() depends on isBookmarkBarShown()
       result, without taking into account that isBookmarkBarShown is async.
    - multiple toggleBookmarkBar() async calls fire consecutively, overriding
       each other's effects.
    
    The above two issues are fixed together by locally cached bookmark visibility
    state that can be updated and retrieved synchronously (inside of the wrapper
    BookmarkBarManager). There doesn't seem to be a way for toggling bookmark
    visibility to fail in the backend. Even if that's possible, the best we can
    do is to keep using the local cache value until the visibility state becomes
    eventually consistent, so simply updating this local cache should suffice.
    
    After the above fix, another timing issue is exposed:
    - the navigation behavior's onRouteChange is always called in the order
    that elements are created. This is problematic since sometimes module's
    clean-up code run after another module's init code and causing conflicting
    effects.
    
    The above issue is fixed in this CL by adding additional enter and exit
    hooks to each route, and navigation behavior will trigger them in the
    expected order.
    
    Bug: 908544
    Change-Id: If462d2ec955ece0d8b17fc342fc7d1ce0225e72c
    Reviewed-on: https://chromium-review.googlesource.com/c/1357523
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Reviewed-by: Hector Carmona <hcarmona@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614604}

    Changed files

    • chrome/browser/resources/welcome/onboarding_welcome/BUILD.gn
    • chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.js
    • chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.js
    • chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.js
    • chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.js
    • chrome/browser/resources/welcome/onboarding_welcome/navigation_behavior.js
    • chrome/browser/resources/welcome/onboarding_welcome/shared/bookmark_proxy.js
    • chrome/browser/resources/welcome/onboarding_welcome/welcome_app.html
    • chrome/browser/resources/welcome/onboarding_welcome/welcome_app.js
    • chrome/test/data/webui/welcome/email_chooser_test.js
    • chrome/test/data/webui/welcome/navigation_behavior_test.js
    • chrome/test/data/webui/welcome/onboarding_welcome_browsertest.js
  12. [VK] Fix keyboard shortcut documentation.

    Changed by Darren Shen - shendohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:43:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 54c3aef61f7f6568ff4c4f1526107d9894003c94

    Comments

    [VK] Fix keyboard shortcut documentation.
    
    This patch fixes the ambiguous description in the keyboard shortcut
    viewer for Ctrl-Space and Ctrl-Shift-Space. Namely, Ctrl-Space
    toggles between the current input method and the last used, whereas
    Ctrl-Shift-Space cycles through all of them. The naming is confusing
    because "previous" here means "last used" and not the opposite of
    "next". The two shortcuts are -not- inverses of each other. We rename
    the implementation as well for clarity.
    
    TBR=shuchen@chromium.org
    
    Bug: 909863
    Change-Id: I7ca8d70d5d571ce3065814cb789e79a1488b875d
    Reviewed-on: https://chromium-review.googlesource.com/c/1358195
    Commit-Queue: Darren Shen <shend@chromium.org>
    Reviewed-by: Oliver Chang <ochang@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614603}

    Changed files

    • ash/accelerators/accelerator_controller.cc
    • ash/accelerators/accelerator_controller_unittest.cc
    • ash/accelerators/accelerator_table.cc
    • ash/accelerators/accelerator_table_unittest.cc
    • ash/components/shortcut_viewer/keyboard_shortcut_viewer_metadata.cc
    • ash/components/shortcut_viewer_strings.grdp
    • ash/ime/ime_controller.cc
    • ash/ime/ime_controller.h
    • ash/ime/ime_controller_unittest.cc
    • ash/ime/test_ime_controller_client.cc
    • ash/ime/test_ime_controller_client.h
    • ash/public/cpp/accelerators.cc
    • ash/public/cpp/accelerators.h
    • ash/public/interfaces/ime_controller.mojom
    • chrome/browser/chromeos/input_method/input_method_manager_impl.cc
    • chrome/browser/chromeos/input_method/input_method_manager_impl.h
    • chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc
    • chrome/browser/ui/ash/ime_controller_client.cc
    • chrome/browser/ui/ash/ime_controller_client.h
    • chrome/browser/ui/ash/ime_controller_client_unittest.cc
    • chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_metadata_unittest.cc
    • ui/base/ime/chromeos/input_method_manager.h
    • ui/base/ime/chromeos/mock_input_method_manager.cc
    • ui/base/ime/chromeos/mock_input_method_manager.h
  13. [Platform Apps] Include uncompiled app sources in API registration]

    Changed by Devlin Cronin - rdevlin.croninohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:42:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b0836cf405ec25c63308dbddb72c046f651286e1

    Comments

    [Platform Apps] Include uncompiled app sources in API registration]
    
    Include un-compiled API sources in the list of APIs to register for
    Chrome API functions.
    
    Bug: 902116
    
    Change-Id: Ie10134207e4a0d8c4ecb1eb6a0b8d3b2e9d4b61d
    Reviewed-on: https://chromium-review.googlesource.com/c/1367114
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614602}

    Changed files

    • chrome/browser/apps/platform_apps/api/BUILD.gn
  14. Clean up sequence checking in //services/device/hid

    Changed by Reilly Grant - reillygohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 04:42:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bbc72ccaf4f7bbe5f0e34529ea83ba5e4502324e

    Comments

    Clean up sequence checking in //services/device/hid
    
    This change replaces the remaining thread checkers in this code with
    sequence checkers. In the Linux backend specifically an unnecessary
    thread hop during connection open has been removed.
    
    Change-Id: I7fa4da7d02702a9249d3e45b93f271a691301d56
    Reviewed-on: https://chromium-review.googlesource.com/c/1351418
    Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
    Commit-Queue: Reilly Grant <reillyg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614601}

    Changed files

    • services/device/hid/hid_connection.cc
    • services/device/hid/hid_connection.h
    • services/device/hid/hid_connection_linux.cc
    • services/device/hid/hid_connection_linux.h
    • services/device/hid/hid_service.cc
    • services/device/hid/hid_service.h
    • services/device/hid/hid_service_linux.cc
    • services/device/hid/hid_service_linux.h
    • services/device/hid/hid_service_mac.cc
    • services/device/hid/hid_service_win.cc
  15. Fix crash when accessing invalid cookie settings

    Changed by Clark DuVall - cduvallohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:41:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e0fa376aa1cbba121926489eafab6b4a95fb14d4

    Comments

    Fix crash when accessing invalid cookie settings
    
    This crash happens when ResourceContext is destroyed, but
    RenderFrameMessageFilter is still alive, and tries to use the old
    ResourceContext pointer. This change explicitly nulls out
    ResourceContext and checks before using it.
    
    Bug: 911714
    Change-Id: I7c71297d8b70607ce245db06f3ea35765476857f
    Reviewed-on: https://chromium-review.googlesource.com/c/1366356
    Commit-Queue: Clark DuVall <cduvall@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614600}

    Changed files

    • content/browser/frame_host/render_frame_message_filter.cc
    • content/browser/frame_host/render_frame_message_filter.h
    • content/browser/frame_host/render_frame_message_filter_browsertest.cc
    • content/browser/renderer_host/render_process_host_impl.cc
  16. OobeInteractiveUITest: move local code to anonymous namespace.

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:41:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2dc4db19196b7edca464d0536cb4d0e244ce66ee

    Comments

    OobeInteractiveUITest: move local code to anonymous namespace.
    
    This Cl moves test-local code to anonymous namespace to prevent link erros.
    
    Bug: 891277
    Change-Id: I47c5f41b2c9d77300b389d06bcabf38c981548a2
    Reviewed-on: https://chromium-review.googlesource.com/c/1367110
    Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614599}

    Changed files

    • chrome/browser/chromeos/login/oobe_interactive_ui_test.cc
  17. [CrOS MultiDevice] Convert to multidevice::SoftwareFeature/BeaconSeed.

    Changed by Kyle Horimoto - khorimotoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:39:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c984f40f3f825924c8ded4f29daf16148281269f

    Comments

    [CrOS MultiDevice] Convert to multidevice::SoftwareFeature/BeaconSeed.
    
    Before this CL, RemoteDevice and related classes directly used CryptAuth
    proto enums/messages for SoftwareFeature and BeaconSeed fields. This was
    problematic because:
      (1) RemoteDevice has been moved to a common/shared location and is now
          meant to be independent of any one service. Thus, it no longer
          makes sense for it to contain fields that are implementation
          details of the DeviceSync service.
      (2) The CryptAuth SoftwareFeature enum included an UNKNOWN_FEATURE
          enum value, but this value was only meant to be used as a sentinel
          value while communicating with the CryptAuth server. Since we
          previously referenced the cryptauth::SoftwareFeature enum
          directly, it was possible for RemoteDevice objects to have a state
          for UNKNOWN_FEATURE, which does not make sense in this context.
      (3) The CryptAuth SoftwareFeature enum referred to feature names using
          outdated and/or incorrect names.
      (4) CryptAuth protos do not define an operator<<() function, so it was
          possible to log a cryptauth::SoftwareFeature as a number instead
          of as a user-readable description. This led to issues such as
          https://crbug.com/906836.
    
    A follow-up CL will move the RemoteDevice Mojo definition from
    device_sync.mojom (i.e., the DeviceSync-specific Mojo file) to a new
    multidevice.mojom file meant to be referenced by other Mojo definitions.
    
    Change-Id: Iccf4997cb5a1c6f4c34e7962c7c993f74f8aa8f0
    Bug: 912743
    Reviewed-on: https://chromium-review.googlesource.com/c/1362214
    Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614598}

    Changed files

    • chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
    • chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
    • chrome/browser/chromeos/tether/tether_service_unittest.cc
    • chromeos/components/multidevice/BUILD.gn
    • chromeos/components/multidevice/beacon_seed.cc
    • chromeos/components/multidevice/beacon_seed.h
    • chromeos/components/multidevice/remote_device.cc
    • chromeos/components/multidevice/remote_device.h
    • chromeos/components/multidevice/remote_device_ref.cc
    • chromeos/components/multidevice/remote_device_ref.h
    • chromeos/components/multidevice/remote_device_ref_unittest.cc
    • chromeos/components/multidevice/remote_device_test_util.cc
    • chromeos/components/multidevice/remote_device_test_util.h
    • chromeos/components/multidevice/software_feature.cc
    • chromeos/components/multidevice/software_feature.h
    • chromeos/components/multidevice/software_feature_state.h
    • chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.cc
    • chromeos/components/tether/tether_host_fetcher_impl.cc
    • chromeos/components/tether/tether_host_fetcher_impl_unittest.cc
    • chromeos/services/device_sync/device_sync_impl.cc
    • chromeos/services/device_sync/device_sync_impl.h
    • chromeos/services/device_sync/device_sync_service_unittest.cc
    • chromeos/services/device_sync/fake_device_sync.cc
    • chromeos/services/device_sync/fake_device_sync.h
    • chromeos/services/device_sync/public/cpp/device_sync_client.h
    • chromeos/services/device_sync/public/cpp/device_sync_client_impl.cc
    • chromeos/services/device_sync/public/cpp/device_sync_client_impl.h
    • chromeos/services/device_sync/public/cpp/device_sync_client_impl_unittest.cc
    • chromeos/services/device_sync/public/cpp/fake_device_sync_client.cc
    • chromeos/services/device_sync/public/cpp/fake_device_sync_client.h
    • chromeos/services/device_sync/public/mojom/device_sync.mojom
    • chromeos/services/device_sync/public/mojom/device_sync.typemap
    • chromeos/services/device_sync/public/mojom/device_sync_mojom_traits.cc
    • chromeos/services/device_sync/public/mojom/device_sync_mojom_traits.h
    • chromeos/services/device_sync/public/mojom/device_sync_mojom_traits_unittest.cc
    • chromeos/services/multidevice_setup/device_reenroller.cc
    • chromeos/services/multidevice_setup/device_reenroller_unittest.cc
    • chromeos/services/multidevice_setup/eligible_host_devices_provider_impl.cc
    • chromeos/services/multidevice_setup/eligible_host_devices_provider_impl_unittest.cc
    • chromeos/services/multidevice_setup/feature_state_manager_impl.cc
    • chromeos/services/multidevice_setup/feature_state_manager_impl_unittest.cc
    • chromeos/services/multidevice_setup/grandfathered_easy_unlock_host_disabler.cc
    • chromeos/services/multidevice_setup/grandfathered_easy_unlock_host_disabler_unittest.cc
    • chromeos/services/multidevice_setup/host_backend_delegate_impl.cc
    • chromeos/services/multidevice_setup/host_backend_delegate_impl_unittest.cc
    • chromeos/services/multidevice_setup/host_verifier_impl.cc
    • chromeos/services/multidevice_setup/host_verifier_impl_unittest.cc
    • chromeos/services/secure_channel/ble_service_data_helper_impl.cc
    • chromeos/services/secure_channel/ble_service_data_helper_impl_unittest.cc
    • components/cryptauth/background_eid_generator.cc
    • components/cryptauth/background_eid_generator_unittest.cc
    • components/cryptauth/ble/ble_advertisement_generator.cc
    • components/cryptauth/ble/ble_advertisement_generator_unittest.cc
    • components/cryptauth/fake_software_feature_manager.cc
    • components/cryptauth/fake_software_feature_manager.h
    • components/cryptauth/remote_device_loader.cc
    • components/cryptauth/remote_device_loader_unittest.cc
    • components/cryptauth/software_feature_manager.h
    • components/cryptauth/software_feature_manager_impl.cc
    • components/cryptauth/software_feature_manager_impl.h
    • components/cryptauth/software_feature_manager_impl_unittest.cc
  18. Roll src/third_party/pdfium f1038808a9c8..994719731644 (6 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 04:39:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9dbfb69b67406cdee217e9970fafea98e8c70c40

    Comments

    Roll src/third_party/pdfium f1038808a9c8..994719731644 (6 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/f1038808a9c8..994719731644
    
    
    git log f1038808a9c8..994719731644 --date=short --no-merges --format='%ad %ae %s'
    2018-12-07 tsepez@chromium.org Move element/parent relationship data to .inc file
    2018-12-06 tsepez@chromium.org Use symbols to represent parents in script hierarchy
    2018-12-06 tsepez@chromium.org XFA: generate element tables via C preprocessor
    2018-12-06 tsepez@chromium.org XFA: generate value tables with C preprocessor.
    2018-12-06 tsepez@chromium.org XFA: generate attribute tables via C Preprocessor.
    2018-12-06 thestig@chromium.org Limit pdf_codec_fax_fuzzer input size.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@994719731644
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:910505
    TBR=dsinclair@chromium.org
    
    Change-Id: I666c94ba76957f9159579f9c9932e9769bbc8915
    Reviewed-on: https://chromium-review.googlesource.com/c/1367102
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614597}

    Changed files

    • DEPS
  19. Move HTTP/2 fuzzers outside of shared codebase.

    Changed by Victor Vasiliev - vasilvvohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:38:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 747e0c3c3d0570ca782f66da2c541f32be6f40bd

    Comments

    Move HTTP/2 fuzzers outside of shared codebase.
    
    They were never present in google3, so they shouldn't be in
    net/third_party/http2.
    
    R=rch@chromium.org
    
    Change-Id: If6a7e2ff4d21ddf0cdf7f929ca45766c0610c2e9
    Reviewed-on: https://chromium-review.googlesource.com/c/1366919
    Reviewed-by: Ryan Hamilton <rch@chromium.org>
    Commit-Queue: Ryan Hamilton <rch@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614596}

    Changed files

    • net/BUILD.gn
    • net/spdy/fuzzing/hpack_decoder_fuzzer.cc
    • net/spdy/fuzzing/http2_frame_decoder_fuzzer.cc
  20. [ServiceWorker] A cleanup in service_worker_context_client.cc.

    Changed by Leon Han - leon.hanohnoyoudont@intel.com
    Changed at Friday, 07-Dec-18 04:38:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a115b526e20b66a78426ab092bc43600f9a27a4

    Comments

    [ServiceWorker] A cleanup in service_worker_context_client.cc.
    
    The ToWebServiceWorkerRequest() is used only for dispatching fetch event
    to service workers, and is not supposed to be used for other purposes
    even in the future.
    
    BUG=911930
    
    Change-Id: Ie57f1b65c927ad3aed675b744135ed48f37df9b8
    Reviewed-on: https://chromium-review.googlesource.com/c/1365074
    Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Leon Han <leon.han@intel.com>
    Cr-Commit-Position: refs/heads/master@{#614595}

    Changed files

    • content/renderer/service_worker/service_worker_context_client.cc
  21. Fix length calculation in imagesizes when <meta> viewport is present

    Changed by Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:37:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d7692e1f3e7a07d088557a8c765d9218775daaf7

    Comments

    Fix length calculation in imagesizes when <meta> viewport is present
    
    This fixes a bug where "vw" length calculation of imagesizes attribute
    coming from Link rel=preload header did not reflect the content
    width from <meta name=viewport>.
    
    MediaValuesDynamic::ComputeLength() did not use overridden viewport
    dimensions.
    
    Bug: 813452
    Change-Id: Icbc8f124e552b681bfffa80f407543078f851ed3
    Reviewed-on: https://chromium-review.googlesource.com/c/1365051
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614594}

    Changed files

    • third_party/blink/renderer/core/css/media_values_dynamic.cc
    • third_party/blink/web_tests/http/tests/preload/meta-viewport-link-headers-imagesrcset.html
    • third_party/blink/web_tests/http/tests/preload/resources/media-link-headers-imagesrcset.php
  22. Roll src/third_party/skia 055539a9c2d9..309f1deddf8e (8 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 04:37:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6ac0bbde1c1bbf2aa38f2c61ab77208b04556d4a

    Comments

    Roll src/third_party/skia 055539a9c2d9..309f1deddf8e (8 commits)
    
    https://skia.googlesource.com/skia.git/+log/055539a9c2d9..309f1deddf8e
    
    
    git log 055539a9c2d9..309f1deddf8e --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 sergeyu@chromium.org Add SkFontMgr implementation for Fuchsia
    2018-12-06 reed@google.com Revert "remove SkPaint breakText, use SkFont instead (or don't call it)"
    2018-12-06 reed@google.com Move all glyphsToUnichars to a single impl (rely on typeface)
    2018-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d300548fcc28..ec06305b8216 (3 commits)
    2018-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader c0f92f2308d1..f8374cf0e75c (3 commits)
    2018-12-06 reed@google.com Abandon onDrawText and its variants, turn everything into textblobs
    2018-12-06 bsalomon@google.com Revert "Revert "Use unnormalized coords all the way through with GL_TEXTURE_RECTANGLE textures.""
    2018-12-06 jvanverth@google.com Add use of RG textures in wacky_yuv_formats
    
    
    Created with:
      gclient setdep -r src/third_party/skia@309f1deddf8e
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jcgregorio@chromium.org
    
    Change-Id: If73538629fb7a90866aae2eb1f8b561287088552
    Reviewed-on: https://chromium-review.googlesource.com/c/1366789
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614593}

    Changed files

    • DEPS
  23. [CSS Animations] !important fails to override

    Changed by Eric Willigers - ericwilligersohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:36:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 155df253bc1fbbff79ae6e72b6b9eba95adb972d

    Comments

    [CSS Animations] !important fails to override
    
    Blink currently fails the css-cascade/important-prop.html WPT
    
    BUG=552085
    
    Change-Id: Ida8839e7aa81b7dd6fd05a32248406e7fa6126c5
    Reviewed-on: https://chromium-review.googlesource.com/c/1366459
    Reviewed-by: Robert Flack <flackr@chromium.org>
    Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614592}

    Changed files

    • third_party/blink/web_tests/TestExpectations
  24. Pass --disable-breakpad to the layout tests on android.

    Changed by John Budorick - jbudorickohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:36:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b18336198ea30e225e2a2352c1338779c1cde940

    Comments

    Pass --disable-breakpad to the layout tests on android.
    
    crrev.com/c/1357941 switched Android from breakpad to crashpad.
    Also adds standalone configuration for android_blink_rel.
    
    Bug: 912120
    Change-Id: I7330d4dc707036a8a01f9d8ddbe918259dddb378
    Reviewed-on: https://chromium-review.googlesource.com/c/1367106
    Reviewed-by: Stephen Martinis <martiniss@chromium.org>
    Commit-Queue: John Budorick <jbudorick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614591}

    Changed files

    • infra/config/global/luci-milo.cfg
    • testing/buildbot/chromium.android.json
    • testing/buildbot/generate_buildbot_json.py
    • testing/buildbot/test_suite_exceptions.pyl
    • testing/buildbot/test_suites.pyl
    • testing/buildbot/tryserver.chromium.android.json
    • testing/buildbot/waterfalls.pyl
  25. Average unknown feature value predictions in RandomTree.

    Changed by liberato@chromium.org - liberatoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:35:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 02aa8a1cafd38518bb3eaa1562d64041e76ccb88

    Comments

    Average unknown feature value predictions in RandomTree.
    
    Previously, RandomTree would return an empty distribution if it
    encountered an unknown feature value while traversing the tree.
    
    However, if we used one-hot encoding for nominal values, then it
    would take the "zero" branch of the split instead.  The tree
    structure would dictate which non-one-hot value that corresponds to.
    
    To do something similar, RandomTree now traverses all branches from
    the split, and sums the distributions if the new LearningTask flag
    rt_unknown_value_handling is set to kUseAllSplits.
    
    Alternatively, if it's set to kEmptyDistribution, then it keeps the
    old behavior.
    
    Change-Id: Iccff895a2463a892babc353862a940e9dcd75d4a
    Reviewed-on: https://chromium-review.googlesource.com/c/1365976
    Commit-Queue: Frank Liberato <liberato@chromium.org>
    Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614590}

    Changed files

    • media/learning/common/learning_task.h
    • media/learning/impl/learning_task_controller_impl.cc
    • media/learning/impl/random_tree_trainer.cc
    • media/learning/impl/random_tree_trainer.h
    • media/learning/impl/random_tree_trainer_unittest.cc
  26. Smart Lock: Only add observer to ProximityMonitor once.

    Changed by Ryan Hansberry - hansberryohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:35:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2418c9546e5e7d0f2fabbb135c467e0df700f14e

    Comments

    Smart Lock: Only add observer to ProximityMonitor once.
    
    ProximityMonitor::AddObserver was previously being called
    multiple times. Its mirror RemoveObserver call was also
    never called; this CL adds that call. Finally, the
    proximity_monitor_ object was being created multiple times
    for no reason; now it is created once.
    
    Bug: 910769
    Change-Id: If1ab0216d364831cad2bf0d39516af31aa34cbd4
    Reviewed-on: https://chromium-review.googlesource.com/c/1367084
    Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
    Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614589}

    Changed files

    • chromeos/components/proximity_auth/unlock_manager_impl.cc
  27. Pass GpuPreferences to Viz process in Mash

    Changed by Mohsen Izadi - mohsenohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:34:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6a6476b7e75b45046297564825d5464f61c759cc

    Comments

    Pass GpuPreferences to Viz process in Mash
    
    This CL passes GpuPreferences as command line arguments to the Viz
    process when it is launched.
    
    BUG=906171
    
    Change-Id: Iaa4be301dc20f2c2055de4736e70288d21b32554
    Reviewed-on: https://chromium-review.googlesource.com/c/1343525
    Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614588}

    Changed files

    • chrome/browser/DEPS
    • chrome/browser/chrome_content_browser_client.cc
    • content/browser/gpu/gpu_data_manager_impl.cc
    • content/browser/gpu/gpu_data_manager_impl.h
    • content/public/browser/gpu_data_manager.h
  28. Shows the label "Unnamed" in the app list as the default name for a folder in place of "Unnamed Folder"

    Changed by Matthew Mourgos - mmourgosohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:34:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b4236f76fdc3abf7c036659fe8d1299f93bf0ca7

    Comments

    Shows the label "Unnamed" in the app list as the default name for a folder in place of "Unnamed Folder"
    
    Bug: 755547
    Change-Id: Ieb549f14a278f409aec7632da284d39de564a1c5
    Reviewed-on: https://chromium-review.googlesource.com/c/1363978
    Reviewed-by: Weidong Guo <weidongg@chromium.org>
    Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614587}

    Changed files

    • ui/strings/ui_strings.grd
  29. Roll src-internal fb4f6083a23a..10e8db47197f (11 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 04:33:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 873bec09ca14a9a1aeae4682a417ebd4518e1b9e

    Comments

    Roll src-internal fb4f6083a23a..10e8db47197f (11 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fb4f6083a23a..10e8db47197f
    
    
    Created with:
      gclient setdep -r src-internal@10e8db47197f
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I44a5dde14e3683af5d7d39bd5ae32f0f6bd148be
    Reviewed-on: https://chromium-review.googlesource.com/c/1367098
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614586}

    Changed files

    • DEPS
  30. Worklet: Mark CSP web tests for audio and animation worklets with slow

    Changed by Hiroki Nakagawa - nhirokiohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:33:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 93bc539ac1ed13143e53bbe14dab93c6b0430782

    Comments

    Worklet: Mark CSP web tests for audio and animation worklets with slow
    
    Bug: 912240
    Change-Id: I823d1b825c4f31138953eb83c65a374540dc0a85
    Tbr: nhiroki@chromium.org
    Notry: true
    Reviewed-on: https://chromium-review.googlesource.com/c/1366463
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614585}

    Changed files

    • third_party/blink/web_tests/SlowTests
  31. Deflake DirectoryTreeContextMenu tests

    Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:32:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3272f73f06312a50d6601bda8dbf737cbbae3874

    Comments

    Deflake DirectoryTreeContextMenu tests
    
    Change flake tests to use expandTreeItemInDirectoryTree and fix it to
    wait for the tree-item being expanded to have "has-children" attribute,
    so the click to expand actually works.
    
    Change expandTreeItemInDirectoryTree to use |waitAndClickElement| and
    to do so, move it from RemoteCallGallery to the RemoteCall base class.
    Change its callbacks from anonymous function to arrow function.
    
    Enable dirRenameWithoutChangingCurrent to run with MyFilesVolume flag
    enabled.
    
    Bug: 911609
    Change-Id: I10387aef5f213ac2c39f253bf041a5003a2cde17
    Reviewed-on: https://chromium-review.googlesource.com/c/1364932
    Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
    Reviewed-by: Sam McNally <sammc@chromium.org>
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614584}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • ui/file_manager/integration_tests/file_manager/directory_tree_context_menu.js
    • ui/file_manager/integration_tests/remote_call.js
  32. First draft of an App Service search provider

    Changed by Nigel Tao - nigeltaoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:32:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f4cd59a01351d213e782174c933a6da6160723c2

    Comments

    First draft of an App Service search provider
    
    Lots of TODOs, but there's enough implemented so that running "chrome
    --enable-features=AppService" will populate the app list search box with
    apps' names and icons, and clicking on the icon will launch the app.
    
    BUG=826982
    
    Change-Id: I564bbd9142061e95a91c1a0b63a70980c970d56d
    Reviewed-on: https://chromium-review.googlesource.com/c/1362597
    Commit-Queue: Nigel Tao <nigeltao@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614583}

    Changed files

    • chrome/browser/apps/app_service/built_in_chromeos_apps.cc
    • chrome/browser/apps/app_service/extension_apps.cc
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/app_list/app_service_app_item.cc
    • chrome/browser/ui/app_list/search/app_search_provider.cc
    • chrome/browser/ui/app_list/search/app_service_app_result.cc
    • chrome/browser/ui/app_list/search/app_service_app_result.h
    • chrome/services/app_service/public/cpp/app_registry_cache.cc
    • chrome/services/app_service/public/cpp/app_registry_cache.h
    • chrome/services/app_service/public/cpp/app_update.cc
    • chrome/services/app_service/public/cpp/app_update.h
    • chrome/services/app_service/public/cpp/app_update_unittest.cc
    • chrome/services/app_service/public/mojom/types.mojom
  33. Renaming remaining files of which names contain "layouttest" in content/

    Changed by Kent Tamura - tkentohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:31:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2eab5b13ff0998313a8373c1f95eac04b9e6151f

    Comments

    Renaming remaining files of which names contain "layouttest" in content/
    
    - layouttest_support.* => web_test_support.*
    - layout_test_dependencies.* => web_test_dependencies.*
    - layout_test_runtime_flags.* => web_test_runtime_flags.*
    
    Also, this CL renames symbols related to these files.
    
    TBR=caitkp@chromium.org
    
    Bug: 843412
    Change-Id: Ief1431a8d74e75cf1907737d958964184ea973c8
    Reviewed-on: https://chromium-review.googlesource.com/c/1362594
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614582}

    Changed files

    • components/BUILD.gn
    • content/public/test/web_test_support.h
    • content/renderer/BUILD.gn
    • content/renderer/media/media_factory.cc
    • content/renderer/render_thread_impl.cc
    • content/renderer/render_thread_impl.h
    • content/renderer/render_view_impl.cc
    • content/renderer/renderer_webapplicationcachehost_impl.cc
    • content/renderer/resizing_mode_selector.cc
    • content/renderer/web_test_dependencies.cc
    • content/renderer/web_test_dependencies.h
    • content/shell/BUILD.gn
    • content/shell/app/shell_main_delegate.cc
    • content/shell/browser/web_test/blink_test_controller.cc
    • content/shell/browser/web_test/fake_bluetooth_chooser.cc
    • content/shell/browser/web_test/web_test_bluetooth_fake_adapter_setter_impl.cc
    • content/shell/browser/web_test/web_test_message_filter.cc
    • content/shell/renderer/web_test/blink_test_runner.cc
    • content/shell/renderer/web_test/web_test_content_renderer_client.cc
    • content/shell/renderer/web_test/web_test_render_thread_observer.cc
    • content/shell/test_runner/BUILD.gn
    • content/shell/test_runner/layout_dump.cc
    • content/shell/test_runner/layout_dump.h
    • content/shell/test_runner/mock_content_settings_client.cc
    • content/shell/test_runner/mock_content_settings_client.h
    • content/shell/test_runner/pixel_dump.cc
    • content/shell/test_runner/test_runner.cc
    • content/shell/test_runner/test_runner.h
    • content/shell/test_runner/web_test_runtime_flags.cc
    • content/shell/test_runner/web_test_runtime_flags.h
    • content/test/BUILD.gn
    • content/test/DEPS
    • content/test/web_test_support.cc
  34. Downloads: detect failed file icons and show default thumbnail

    Changed by Dan Beam - dbeamohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:31:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ec126531ceaebdd0b9ee340ec4d750507290fd7

    Comments

    Downloads: detect failed file icons and show default thumbnail
    
    On the downloads page, we consult the system for a themed image for the
    type of file downloads. Ex: zip files -> archive icon.
    
    When a system doesn't know why type of icon to show for a specific file
    type, it can either return a default or nothing. Right now, Linux
    returns nothing, so we show nothing.  chrome://fileicon tries to warn
    us by giving a network error (which has been ignored until now).
    
    So, when a chrome://fileicon fails to load, show a default filetype
    icon in respond.
    
    Before & after screenshots: https://imgur.com/a/txRbfIG
    
    R=dpapad@chromium.org
    BUG=855259
    
    Change-Id: I370fd8ea119b194ad8e1ba7e0dfad32c6cea1bbe
    Reviewed-on: https://chromium-review.googlesource.com/c/1132560
    Commit-Queue: Dan Beam <dbeam@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614581}

    Changed files

    • chrome/browser/browser_resources.grd
    • chrome/browser/resources/md_downloads/BUILD.gn
    • chrome/browser/resources/md_downloads/icon_loader.html
    • chrome/browser/resources/md_downloads/icon_loader.js
    • chrome/browser/resources/md_downloads/item.html
    • chrome/browser/resources/md_downloads/item.js
    • chrome/browser/resources/print_preview/data/destination.js
    • chrome/browser/resources/print_preview/icons.html
    • chrome/browser/resources/print_preview/new/app.html
    • chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc
    • chrome/test/data/webui/icon_test.html
    • chrome/test/data/webui/md_downloads/downloads_browsertest.js
    • chrome/test/data/webui/md_downloads/item_tests.js
    • chrome/test/data/webui/md_downloads/test_support.js
    • ui/webui/resources/cr_elements/icons.html
    • ui/webui/resources/js/icon.js