Home | Search | chromium - Builders
Login

Builder Mac FYI GPU ASAN Release Build 2124 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revision3e151e38b3dabf71057cd3f303490937fbc24bad
Got Revision3e151e38b3dabf71057cd3f303490937fbc24bad

Execution:

Steps and Logfiles:

Show:
  1. ( 329 ms ) setup_build
    running recipe: "chromium"
  2. ( 245 ms ) report builders
     
    running builder/tester 'Mac FYI GPU ASAN Release' on master 'chromium.gpu.fyi'
  3. ( 1 mins 38 secs ) bot_update
    [120GB/232GB used (51%)]
  4. ( 0 ) ensure_goma
  5. ( 719 ms ) swarming.py --version
    0.13
  6. ( 200 ms ) ensure_installed
  7. ( 15 secs ) gclient runhooks
  8. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
  9. ( 413 ms ) lookup GN args
     
    build_angle_gles1_conform_tests = true
    dcheck_always_on = true
    enable_nacl = false
    ffmpeg_branding = "Chrome"
    internal_gles2_conform_tests = true
    is_asan = true
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  10. ( 18 secs ) generate_build_files
  11. ( 602 ms ) clang_revision
  12. ( 22 mins 3 secs ) compile
  13. ( 34 secs ) isolate tests
  14. ( 395 ms ) find isolated tests
  15. ( 0 ) test_pre_run
  16. ( 3 mins 18 secs ) angle_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:03:09.436782
  17. ( 3 mins 13 secs ) angle_unittests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:03:06.575456
  18. ( 53 secs ) tab_capture_end2end_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 51s
  19. ( 1 mins 8 secs ) tab_capture_end2end_tests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:01:04.997085
  20. ( 28 secs ) gl_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 25s
  21. ( 1 mins 16 secs ) gl_tests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:01:12.193169
  22. ( 10 secs ) gl_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 8s
  23. ( 12 secs ) gl_unittests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 10s
  24. ( 2 mins 1 secs ) gles2_conform_test on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:57.529137
  25. ( 5 mins 17 secs ) gles2_conform_test on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:05:11.997576
  26. ( 1 mins 7 secs ) gpu_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:03.436193
  27. ( 1 mins 1 secs ) gpu_unittests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 53s
  28. ( 18 secs ) services_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 16s
  29. ( 24 secs ) services_unittests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 22s
  30. ( 1 secs ) swiftshader_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 9s
  31. ( 1 secs ) swiftshader_unittests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 9s
  32. ( 2 mins 22 secs ) angle_end2end_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Max shard duration: 0:02:12.733442 (shard #2)
    Min shard duration: 17s (shard #0)
  33. ( 19 secs ) angle_end2end_tests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Max shard duration: 17s (shard #1)
    Min shard duration: 16s (shard #2)
  34. ( 2 mins 4 secs ) context_lost_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:58.049781
    Total tests: 10
    * Passed: 10 (10 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  35. ( 2 mins 44 secs ) context_lost_tests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:02:38.175922
    Total tests: 10
    * Passed: 10 (10 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  36. ( 33 secs ) depth_capture_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 32s
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  37. ( 45 secs ) depth_capture_tests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 42s
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  38. ( 1 mins 31 secs ) gpu_process_launch_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:27.422446
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  39. ( 1 mins 43 secs ) gpu_process_launch_tests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:01:37.290112
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  40. ( 32 secs ) hardware_accelerated_feature_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 30s
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  41. ( 41 secs ) hardware_accelerated_feature_tests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 39s
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  42. ( 1 mins ) maps_pixel_test on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 56s
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  43. ( 1 mins 9 secs ) maps_pixel_test on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:01:06.076134
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  44. ( 5 mins 23 secs ) pixel_test on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:05:17.799424
    Total tests: 57
    * Passed: 54 (54 expected, 0 unexpected)
    * Skipped: 3 (3 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  45. ( 5 mins 47 secs ) pixel_test on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:05:42.451545
    Total tests: 57
    * Passed: 54 (54 expected, 0 unexpected)
    * Skipped: 3 (3 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  46. ( 1 mins 8 secs ) screenshot_sync_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:06.863647
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  47. ( 1 mins 26 secs ) screenshot_sync_tests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:01:22.185897
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  48. ( 1 mins 35 secs ) trace_test on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:32.777491
    Total tests: 36
    * Passed: 18 (18 expected, 0 unexpected)
    * Skipped: 18 (18 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  49. ( 1 mins 58 secs ) trace_test on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:01:53.424731
    Total tests: 36
    * Passed: 18 (18 expected, 0 unexpected)
    * Skipped: 18 (18 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  50. ( 37 mins 11 secs ) webgl2_conformance_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Max shard duration: 0:37:07.507487 (shard #13)
    Min shard duration: 0:13:01.137913 (shard #14)
    Total tests: 2781
    * Passed: 2716 (2716 expected, 0 unexpected)
    * Skipped: 65 (65 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  51. ( 16 mins 43 secs ) webgl2_conformance_tests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Max shard duration: 0:16:29.400616 (shard #17)
    Min shard duration: 0:13:03.372361 (shard #13)
    Total tests: 2781
    * Passed: 2716 (2716 expected, 0 unexpected)
    * Skipped: 65 (65 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  52. ( 11 mins 51 secs ) webgl_conformance_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Max shard duration: 0:11:47.800965 (shard #1)
    Min shard duration: 0:04:19.606631 (shard #0)
    Total tests: 926
    * Passed: 919 (919 expected, 0 unexpected)
    * Skipped: 7 (7 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  53. ( 12 mins 47 secs ) webgl_conformance_tests on ATI GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Max shard duration: 0:12:37.405314 (shard #1)
    Min shard duration: 0:03:57.732206 (shard #0)
    Total tests: 926
    * Passed: 919 (919 expected, 0 unexpected)
    * Skipped: 7 (7 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  54. ( 383 ms ) Tests statistics
     
    Stats
    Total shards: 84
    Total runtime: 11:12:58.926932
     
  55. ( 1 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "build91-m9" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539322927693861, "id": "8932896637730003120", "project": "chromium", "tags": ["builder:Mac FYI GPU ASAN Release", "buildset:commit/git/3e151e38b3dabf71057cd3f303490937fbc24bad", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/3e151e38b3dabf71057cd3f303490937fbc24bad", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9098326699909209680", "scheduler_job_id:chromium/Mac FYI GPU ASAN Release", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Mac FYI GPU ASAN Release" setup_build
buildnumber 2124 setup_build
mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "3e151e38b3dabf71057cd3f303490937fbc24bad" setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "3e151e38b3dabf71057cd3f303490937fbc24bad" bot_update
got_revision_cp "refs/heads/master@{#599104}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "8f4bc41c42318534a564e75e48b01f065f2cbc57" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25133}" bot_update
got_clang_revision "344066-1" clang_revision
swarm_hashes_refs/heads/master(at){#599104}_without_patch {"angle_end2end_tests": "981393907e240cf617e75ac1f1ebe2cf3e7c243a", "angle_unittests": "cb81ec5242b41a40ec9b90ac68a211ad948f9224", "browser_tests": "59ff13f9bc24daaf4176c9c90a6f7c0dac806412", "gl_tests": "b4b0d3265bb3c245757f09a4edaaf0fd77510d52", "gl_unittests": "a42c65965927ce06d4f0fc9b3e128ef25e5dbb44", "gles2_conform_test": "e643873377e4203a1123e0907ff29d6ba70dc411", "gpu_unittests": "95bb06879df529a463762b5e9932b81e7943da45", "services_unittests": "83e9945678660331565794c011473ed23103711b", "swiftshader_unittests": "e514ef4743e5578db13e73c7e0988c38595f038b", "telemetry_gpu_integration_test": "ddc02eee7fefe8b5ed469c0162b19b0d39776307"} isolate tests
swarm_hashes {"angle_end2end_tests": "981393907e240cf617e75ac1f1ebe2cf3e7c243a", "angle_unittests": "cb81ec5242b41a40ec9b90ac68a211ad948f9224", "browser_tests": "59ff13f9bc24daaf4176c9c90a6f7c0dac806412", "gl_tests": "b4b0d3265bb3c245757f09a4edaaf0fd77510d52", "gl_unittests": "a42c65965927ce06d4f0fc9b3e128ef25e5dbb44", "gles2_conform_test": "e643873377e4203a1123e0907ff29d6ba70dc411", "gpu_unittests": "95bb06879df529a463762b5e9932b81e7943da45", "services_unittests": "83e9945678660331565794c011473ed23103711b", "swiftshader_unittests": "e514ef4743e5578db13e73c7e0988c38595f038b", "telemetry_gpu_integration_test": "ddc02eee7fefe8b5ed469c0162b19b0d39776307"} find isolated tests

Blamelist:

  1. Yuki Yamada (yukiyohnoyoudont@google.com)
  2. Kouhei Ueno (kouheiohnoyoudont@chromium.org)
  3. Justin Cohen (justincohenohnoyoudont@google.com)
  4. John Z Wu (jzwohnoyoudont@chromium.org)
  5. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  6. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  7. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
  8. Keiichi Watanabe (keiichiwohnoyoudont@chromium.org)
  9. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  10. Koji Ishii (kojiiohnoyoudont@chromium.org)
  11. Findit (findit-for-meohnoyoudont@appspot.gserviceaccount.com)
  12. Leon Han (leon.hanohnoyoudont@intel.com)
  13. Fergal Daly (fergalohnoyoudont@chromium.org)
  14. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  15. Tommy Steimel (steimelohnoyoudont@chromium.org)
  16. Gang Wu (gangwuohnoyoudont@chromium.org)
  17. Aga Wronska (agawronskaohnoyoudont@chromium.org)
  18. Ian Clelland (iclellandohnoyoudont@chromium.org)
  19. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  20. Roger Tawa (rogertaohnoyoudont@chromium.org)
  21. Ryan Hansberry (hansberryohnoyoudont@chromium.org)
  22. Dominick Ng (dominicknohnoyoudont@chromium.org)
  23. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  24. chrome-release-bot (chrome-release-botohnoyoudont@chromium.org)
  25. Kyle Horimoto (khorimotoohnoyoudont@google.com)
  26. Sadrul Habib Chowdhury (sadrulohnoyoudont@chromium.org)
  27. Azeem Arshad (azeemarshadohnoyoudont@chromium.org)
  28. Albert J. Wong (ajwongohnoyoudont@chromium.org)
  29. Becky Zhou (huayinzohnoyoudont@chromium.org)
  30. wutao (wutaoohnoyoudont@chromium.org)
  31. David Black (dmblackohnoyoudont@google.com)
  32. David Black (dmblackohnoyoudont@google.com)
  33. Pavel Feldman (pfeldmanohnoyoudont@chromium.org)
  34. Zhizhou Yang (zhizhouyohnoyoudont@google.com)
  35. Scott Chen (scottchenohnoyoudont@chromium.org)
  36. Patti (patricialorohnoyoudont@chromium.org)
  37. Kent Tamura (tkentohnoyoudont@chromium.org)
  38. Henrique Nakashima (hnakashimaohnoyoudont@chromium.org)
  39. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  40. John Rummell (jrummellohnoyoudont@chromium.org)
  41. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  42. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  43. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)

Timing:

Create Friday, 12-Oct-18 05:42:07 UTC
Start Friday, 12-Oct-18 05:42:11 UTC
End Friday, 12-Oct-18 08:23:08 UTC
Pending 3 secs
Execution 2 hrs 40 mins

All Changes:

  1. Add a comment for backup_incumbent_scope in JSEventHandler::SetCompiledHandler()

    Changed by Yuki Yamada - yukiyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 05:38:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e151e38b3dabf71057cd3f303490937fbc24bad

    Comments

    Add a comment for backup_incumbent_scope in JSEventHandler::SetCompiledHandler()
    
    This adds a comment for the previous change:
    https://chromium-review.googlesource.com/c/chromium/src/+/1276406
    
    Bug: 893951
    Change-Id: Ib7a14eedb9922a03c0f6121205c55a9924a5fd7c
    Reviewed-on: https://chromium-review.googlesource.com/c/1278070
    Commit-Queue: Yuki Yamada <yukiy@google.com>
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599104}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/js_event_handler.cc
  2. Implement SignedExchange.Prefetch UMAs

    Changed by Kouhei Ueno - kouheiohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 05:30:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 97df84454db873390762a20012a30407d6bd1ed5

    Comments

    Implement SignedExchange.Prefetch UMAs
    
    Bug: 890180
    Change-Id: I5de8d5b1bdb154455a59e5106ebcefd4973d5bcd
    Reviewed-on: https://chromium-review.googlesource.com/c/1275746
    Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599103}

    Changed files

    • content/browser/loader/prefetch_url_loader_service.cc
    • content/browser/web_package/signed_exchange_loader.cc
    • content/browser/web_package/signed_exchange_prefetch_metric_recorder.cc
    • content/browser/web_package/signed_exchange_prefetch_metric_recorder.h
    • content/browser/web_package/signed_exchange_prefetch_metric_recorder_unittest.cc
    • content/browser/web_package/signed_exchange_request_handler_browsertest.cc
    • content/test/BUILD.gn
    • tools/metrics/histograms/histograms.xml
  3. [ios] Move FYI xcode-clang bot back to Xcode 10.

    Changed by Justin Cohen - justincohenohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 05:20:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1af4ddc196ec7424ff808b37f3ec67aa36577a0c

    Comments

    [ios] Move FYI xcode-clang bot back to Xcode 10.
    
    This bot was erronously moved from Xcode 10 beta 4 all the way to Xcode 10.1
    beta.  Now that Xcode 10 GM is in goma, roll to Xcode 10.
    
    Note: This rolls to 10a254a, which is slightly different than the package
    goma installed, but it has the same compiler (clang-1000.11.45.2) so it should
    work the same.  If not, we'll have to investigate why and upload a new package
    to CIPD.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I46e90d60eb562f69d1848df3ff48db3d82cf1cc1
    Reviewed-on: https://chromium-review.googlesource.com/c/1278331
    Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
    Commit-Queue: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599102}

    Changed files

    • ios/build/bots/chromium.fyi/ios12-sdk-xcode-clang.json
  4. Some fixes for sync:

    Changed by John Z Wu - jzwohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 05:16:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 877046da44d232fb9de9bcbaee249c83ff8b0d1e

    Comments

    Some fixes for sync:
    
    1. Disable feature SyncUserConsentSeparateType for now.
    2. Use ReloadCredentials since LoadCredentials DCHECKs and fix up the tests.
    
    Bug: 867548
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I3a9af1b353b3138b411ee9fdab6cc67c447ee109
    Reviewed-on: https://chromium-review.googlesource.com/c/1278471
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: John Wu <jzw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599101}

    Changed files

    • ios/web_view/BUILD.gn
    • ios/web_view/internal/sync/cwv_sync_controller.mm
    • ios/web_view/internal/sync/cwv_sync_controller_unittest.mm
    • ios/web_view/internal/web_view_web_main_parts.mm
  5. Roll src/third_party/angle c4533eae082f..671809e62e80 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 05:16:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 155a1c23d2f8953f50fcff84366cfaea19f0691e

    Comments

    Roll src/third_party/angle c4533eae082f..671809e62e80 (2 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/c4533eae082f..671809e62e80
    
    
    git log c4533eae082f..671809e62e80 --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 jiajia.qin@intel.com ES31: Add vector and matrix support in SSBO for D3D
    2018-10-12 jiajia.qin@intel.com ES31: Collect shader storage blocks info for d3d.
    
    
    Created with:
      gclient setdep -r src/third_party/angle@671809e62e80
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=fjhenigman@chromium.org
    
    Change-Id: Ie918b1391ee226eb39be833dc7768cec9bdbee65
    Reviewed-on: https://chromium-review.googlesource.com/c/1278299
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599100}

    Changed files

    • DEPS
  6. Roll src/third_party/chromite 9a72c51a329f..89e4bf93b1a1 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 05:06:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 86871d7222d501610f9de98a22fd8a41b495d0c3

    Comments

    Roll src/third_party/chromite 9a72c51a329f..89e4bf93b1a1 (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/9a72c51a329f..89e4bf93b1a1
    
    
    git log 9a72c51a329f..89e4bf93b1a1 --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 derat@chromium.org chromeos_config: Run Tast on {amd64-generic,betty}-paladin.
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@89e4bf93b1a1
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I29f302fb260fcd75ce3d9d3b538f0eed2c2a1f21
    Reviewed-on: https://chromium-review.googlesource.com/c/1278493
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599099}

    Changed files

    • DEPS
  7. CrOS FilesApp: refactor only: split out crostini UI tests

    Changed by Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 04:53:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2500163be8a63b6dd75c9427640f8763d6d46b33

    Comments

    CrOS FilesApp: refactor only: split out crostini UI tests
    
    Split crostini UI tests from crostini.js into test files:
     * crostini_mount.js
     * crostini_share.js
     * crostini_tasks.js
    The existing tests are getting a bit too large and pushing
    the bot testing time limits.
    
    Bug: 878324
    Change-Id: I882a38e3f644916e3c904709f3bfc540034b1383
    Reviewed-on: https://chromium-review.googlesource.com/c/1278429
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599098}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_uitest.cc
    • ui/file_manager/file_manager/test/BUILD.gn
    • ui/file_manager/file_manager/test/crostini.js
    • ui/file_manager/file_manager/test/crostini_mount.js
    • ui/file_manager/file_manager/test/crostini_share.js
    • ui/file_manager/file_manager/test/crostini_tasks.js
  8. [Video Capture, Test] Make tests requiring real webcam fail if it's not found

    Changed by Keiichi Watanabe - keiichiwohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 04:50:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dfeab488cdc95233b19b9edeedef3d0b7581b17e

    Comments

    [Video Capture, Test] Make tests requiring real webcam fail if it's not found
    
    Use prefix "UsingRealWebcam_" for names of tests that require real webcam and
    add checking whether webcam is found or not.
    Accordingly, exclude such test cases from test suites for devices that have no
    camera.
    
    Bug: 893494
    Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebox (guado)
          and it failed.
    Test: Ran capture_unittests excluding UsingRealWebcam_ tests on Chromebox (guado)
          and it passed.
    Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebook (kevin)
          and it passed.
    
    Change-Id: I5c91380b7674aeace6a7d1764f7fad31f02f8af7
    Reviewed-on: https://chromium-review.googlesource.com/c/1276407
    Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org>
    Reviewed-by: Christian Fremerey <chfremer@chromium.org>
    Reviewed-by: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599097}

    Changed files

    • media/capture/video/video_capture_device_unittest.cc
    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.chromiumos.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.linux.json
    • testing/buildbot/chromium.mac.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.win.json
    • testing/buildbot/test_suites.pyl
  9. Roll src-internal 616feb1a7c2c..09c355ef00f4 (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 04:45:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5fc416b1492c1141613708a7234048954198b839

    Comments

    Roll src-internal 616feb1a7c2c..09c355ef00f4 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/616feb1a7c2c..09c355ef00f4
    
    
    Created with:
      gclient setdep -r src-internal@09c355ef00f4
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I31399eb2e92dae352d53dc7fcde8bf49c0966418
    Reviewed-on: https://chromium-review.googlesource.com/c/1278531
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599096}

    Changed files

    • DEPS
  10. [auto] Update FlagExpectations for LayoutNG

    Changed by Koji Ishii - kojiiohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 04:22:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dfdec8007a6f8a83d060f176a335b42537cb8ba9

    Comments

    [auto] Update FlagExpectations for LayoutNG
    
    Following bot results are included.
    10421 10431 10436 10446 10458 10478 10484 10489 10494 10496
    10498 10499 10503 10509 10514 10516 10519 10523 10525 10530
    10541 10549 10550 10552
    
    1 lines were removed and 3 lines were deflaked by consecutive
    results since 10503.
    
    TBR=eae@chromium.org, mstensho@chromium.org
    NOTRY=true
    
    Bug: 591099
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I937b189ec5c0061d7c1607828b6ac5fc0bfe71b4
    Reviewed-on: https://chromium-review.googlesource.com/c/1270498
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599095}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
  11. Revert "Fling bubbles from OOPIF properly."

    Changed by Findit - findit-for-meohnoyoudont@appspot.gserviceaccount.com
    Changed at Friday, 12-Oct-18 04:21:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bb03212f2a4bd93f4f87da036a5f9eaeb2256466

    Comments

    Revert "Fling bubbles from OOPIF properly."
    
    This reverts commit a12ef847a57f4aa0282ca47b555c04da18b00f9e.
    
    Reason for revert:
    
    Findit (https://goo.gl/kROfz5) identified CL at revision 599001 as the
    culprit for flakes in the build cycles as shown on:
    https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYTEyZWY4NDdhNTdmNGFhMDI4MmNhNDdiNTU1YzA0ZGExOGIwMGY5ZQw
    
    Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29516
    
    Sample Failed Step: content_browsertests
    
    Sample Flaky Test: BrowserSideFlingBrowserTest.TouchscreenFlingBubblesFromOOPIF
    
    Original change's description:
    > Fling bubbles from OOPIF properly.
    > 
    > While we are bubbling a scroll sequence GFS is sent to the fling controllers
    > of both the oopif and the bubbling target. The fling controller of the oopif
    > calls progressFling and generates a GSU with inertial phase, the GSU gets acked
    > immediately before getting sent to the renderer since we are in bubbling mode.
    > Then the oopif's fling controller receives the unconsumed GSU ack and generates
    > a GSE to complete the scrolling sequence on the oopif. The bubbling target's
    > fling controller receives and processes the GFS and generates GSUs which are
    > sent to the target's renderer.
    > 
    > If the GSE generated by the oopif's fling controller gets bubbled before
    > the GFS, the bubbling target gets reset and the target does not receive the
    > GFS. This cl fixes the issue by making sure that the events generated by the
    > oopif's fling controller are not bubbled to the target. Also in case of
    > GFS bubbling, the GFC should also get sent to the bubbling target to make
    > sure that the fling controller in charge of flinging receives the GFC.
    > 
    > 
    > Bug: 884728, 249063
    > Test: BrowserSideFlingBrowserTest.[Touchpad|Touchscreen]FlingBubblesFromOOPIF
    > Change-Id: I064944f125bebcb746f329af4cfb117f3be94ff0
    > Reviewed-on: https://chromium-review.googlesource.com/c/1274193
    > Reviewed-by: Kevin McNee <mcnee@chromium.org>
    > Reviewed-by: Charlie Reis <creis@chromium.org>
    > Commit-Queue: Charlie Reis <creis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599001}
    
    Change-Id: Ie8178e456d50cdd43fdeb86939180d20b96bcc36
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 884728, 249063, 894703
    Reviewed-on: https://chromium-review.googlesource.com/c/1278536
    Cr-Commit-Position: refs/heads/master@{#599094}

    Changed files

    • content/browser/frame_host/cross_process_frame_connector.cc
    • content/browser/renderer_host/input/fling_browsertest.cc
    • content/browser/renderer_host/render_widget_host_input_event_router.cc
    • content/browser/renderer_host/render_widget_host_input_event_router.h
    • content/browser/renderer_host/render_widget_host_view_child_frame.cc
  12. [OnionSoup] Reduce usages of blink::WebServiceWorkerRegistration

    Changed by Leon Han - leon.hanohnoyoudont@intel.com
    Changed at Friday, 12-Oct-18 04:17:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a6856b267639d14077ac2aac923503f586f3c955

    Comments

    [OnionSoup] Reduce usages of blink::WebServiceWorkerRegistration
    
    Currently some modules (push_messaging, background_fetch etc.) are
    calling blink::SWRegistration::WebRegistration() to get a pointer to
    blink::WebSWRegistration to continue their work there.
    However, they use that blink::WebSWRegistration just to retrieve the
    service worker registration id, i.e. what they really want is not
    blink::WebSWRegistration, but just the registration id.
    
    So, this CL removes blink::SWRegistration::WebRegistration() and
    provides a new function blink::SWRegistration::RegistrationId() for
    those users instead.
    
    This CL is in preparation for https://crrev.com/c/1275300 which plans to
    merge content::WebSWRegistrationImpl into blink::SWRegistration and
    remove the public interface blink::WebSWRegistration completely.
    
    BUG=789857,879019
    
    Change-Id: Iafb245ec6f978dfaa294f58ee800d80c5ba60fac
    Reviewed-on: https://chromium-review.googlesource.com/c/1275298
    Commit-Queue: Leon Han <leon.han@intel.com>
    Reviewed-by: Victor Costan <pwnall@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Reviewed-by: Ian Clelland <iclelland@chromium.org>
    Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599093}

    Changed files

    • content/renderer/push_messaging/push_messaging_client.cc
    • content/renderer/push_messaging/push_messaging_client.h
    • content/renderer/push_messaging/push_provider.cc
    • content/renderer/push_messaging/push_provider.h
    • third_party/blink/public/platform/modules/push_messaging/web_push_client.h
    • third_party/blink/public/platform/modules/push_messaging/web_push_provider.h
    • third_party/blink/renderer/modules/background_fetch/background_fetch_bridge.cc
    • third_party/blink/renderer/modules/background_sync/sync_manager.cc
    • third_party/blink/renderer/modules/cookie_store/cookie_store.cc
    • third_party/blink/renderer/modules/notifications/notification_manager.cc
    • third_party/blink/renderer/modules/notifications/notification_manager.h
    • third_party/blink/renderer/modules/notifications/service_worker_registration_notifications.cc
    • third_party/blink/renderer/modules/push_messaging/push_manager.cc
    • third_party/blink/renderer/modules/push_messaging/push_subscription.cc
    • third_party/blink/renderer/modules/service_worker/navigation_preload_manager.cc
    • third_party/blink/renderer/modules/service_worker/service_worker_registration.cc
    • third_party/blink/renderer/modules/service_worker/service_worker_registration.h
  13. [css, dom] Improve docs on partmap parser.

    Changed by Fergal Daly - fergalohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 04:09:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cb88d559e0a370eae92cb3812eee20197ec0cd6f

    Comments

    [css, dom] Improve docs on partmap parser.
    
    Make the state transitions more clear and document which transitions
    consume a character.
    
    Bug: 805271
    
    Change-Id: I363cb6c9d459b560d0ec1b4cb6649cce981deffc
    Reviewed-on: https://chromium-review.googlesource.com/c/1275747
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Commit-Queue: Fergal Daly <fergal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599092}

    Changed files

    • third_party/blink/renderer/core/dom/names_map.cc
  14. Roll src/third_party/webrtc 1cd39fa9ea0c..8f4bc41c4231 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 03:48:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5de92169da01a3247e6397fc71f44c83447a8a12

    Comments

    Roll src/third_party/webrtc 1cd39fa9ea0c..8f4bc41c4231 (1 commits)
    
    https://webrtc.googlesource.com/src.git/+log/1cd39fa9ea0c..8f4bc41c4231
    
    
    git log 1cd39fa9ea0c..8f4bc41c4231 --date=short --no-merges --format='%ad %ae %s'
    2018-10-11 oprypin@webrtc.org Revert "Move CryptoOptions to api/crypto from rtc_base/sslstreamadapter.h"
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@8f4bc41c4231
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I926d7ea870bf3c7c76c519c12806778129e89659
    Reviewed-on: https://chromium-review.googlesource.com/c/1277843
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599091}

    Changed files

    • DEPS
  15. [Picture in Picture] Add resize handle for CrOS.

    Changed by Tommy Steimel - steimelohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 03:46:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ccd3669d8798ee2013539723323bfd8d982b36a6

    Comments

    [Picture in Picture] Add resize handle for CrOS.
    
    This change adds a UI affordance that the window is resizable and
    draggable on ChromeOS. This adds a ResizeHandleButton made specifically
    as the affordance.
    
    This icon is on the edge of the window that points to the center of
    the workspace screen. For example, if the window is on the bottom right
    quadrant, the icon will be on the top left. In the case where the window
    is on the bottom left quadrant, the icon replaces the close button. The
    close button is then shifted to the top left corner.
    
    Bug: 890113
    Change-Id: Iea6b543e4ee5751d8478dc76daa024f5e85292d2
    Reviewed-on: https://chromium-review.googlesource.com/c/1275526
    Commit-Queue: Tommy Steimel <steimel@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599090}

    Changed files

    • chrome/app/generated_resources.grd
    • chrome/app/vector_icons/BUILD.gn
    • chrome/app/vector_icons/resize_handle.icon
    • chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/views/overlay/close_image_button.cc
    • chrome/browser/ui/views/overlay/close_image_button.h
    • chrome/browser/ui/views/overlay/overlay_window_views.cc
    • chrome/browser/ui/views/overlay/overlay_window_views.h
    • chrome/browser/ui/views/overlay/resize_handle_button.cc
    • chrome/browser/ui/views/overlay/resize_handle_button.h
  16. [Feed] Wire the logging report with the logging bridge

    Changed by Gang Wu - gangwuohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 03:40:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab5a1ef3e0e0069c84adc62075ae09afbd612c78

    Comments

    [Feed] Wire the logging report with the logging bridge
    
    Wired most of the UMA logging, there are two methods in the bridge not
    connected since it is new UMA, will do in next CL.
    
    Bug: 831641
    Change-Id: I154261aa3266d1f6d0af07ccb7510b3879f2744e
    Reviewed-on: https://chromium-review.googlesource.com/c/1275130
    Commit-Queue: Gang Wu <gangwu@chromium.org>
    Reviewed-by: Sky Malice <skym@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599089}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedLoggingBridge.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedProcessScopeFactory.java
    • chrome/browser/android/feed/feed_logging_bridge.cc
    • chrome/browser/android/feed/feed_logging_bridge.h
    • components/feed/core/feed_logging_metrics.cc
    • components/feed/core/feed_logging_metrics.h
    • components/feed/core/feed_logging_metrics_unittest.cc
  17. Demo mode: Add debug logs to demo mode setup.

    Changed by Aga Wronska - agawronskaohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 03:38:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 17f321cb0b8198ca3c72ac8dbf9a6acbd3588df0

    Comments

    Demo mode: Add debug logs to demo mode setup.
    
    Logging demo setup steps will help to determine at what point problems
    occured for example in case of infinite loading.
    
    Change-Id: I04725e4c9d0de12553f6f14fb3d8ee7d106e9699
    Reviewed-on: https://chromium-review.googlesource.com/c/1277957
    Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
    Commit-Queue: Aga Wronska <agawronska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599088}

    Changed files

    • chrome/browser/chromeos/login/demo_mode/demo_setup_controller.cc
  18. Enable FP reporting for sensor policy violations.

    Changed by Ian Clelland - iclellandohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 03:36:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a4699db12f4e711719ba1d225ff7c82d62a2a6c

    Comments

    Enable FP reporting for sensor policy violations.
    
    This queues a report through the Reporting API whenever the Generic Sensor API
    is used in a frame in which the specific sensor is not allowed according to
    feature policy.
    
    Bug: 867471
    Change-Id: I9c50f4a331b2b2230890ee0c357047704af8425a
    Reviewed-on: https://chromium-review.googlesource.com/c/1263041
    Reviewed-by: Reilly Grant <reillyg@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Ian Clelland <iclelland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599087}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/generic-sensor-reporting.https.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/reporting/generic-sensor-reporting.https.html.headers
    • third_party/blink/renderer/core/frame/device_single_window_event_controller.cc
    • third_party/blink/renderer/modules/sensor/sensor.cc
  19. Roll src/third_party/chromite d23bbdb87b57..9a72c51a329f (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 03:34:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b2cf2dab488e2544ca9bb60b18778ac736257c13

    Comments

    Roll src/third_party/chromite d23bbdb87b57..9a72c51a329f (2 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/d23bbdb87b57..9a72c51a329f
    
    
    git log d23bbdb87b57..9a72c51a329f --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 vapier@chromium.org paygen: download_cache_unittest: convert to lib.gs & delete gslib.Cat
    2018-10-12 vapier@chromium.org paygen: gslib: drop unused Stat
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@9a72c51a329f
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I5c3d6623dd88c54fd144213025257ecc157d0565
    Reviewed-on: https://chromium-review.googlesource.com/c/1278489
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599086}

    Changed files

    • DEPS
  20. Fix compile confirm no-op in win builders.

    Changed by Roger Tawa - rogertaohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 03:34:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 50cfd443f039957406f1eec2324d058bb9726e60

    Comments

    Fix compile confirm no-op in win builders.
    
    Bug: 893874
    Change-Id: Id07fb2e9d67403cb77d571df41b4b2aef11bb46d
    Reviewed-on: https://chromium-review.googlesource.com/c/1278475
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599085}

    Changed files

    • chrome/credential_provider/gaiacp/BUILD.gn
  21. [CrOS MultiDevice] Display a modal webview of links in MultiDevice OOBE screen.

    Changed by Ryan Hansberry - hansberryohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 03:21:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cfebc9e310c9fd4494d0944b3133745224aa01f9

    Comments

    [CrOS MultiDevice] Display a modal webview of links in MultiDevice OOBE screen.
    
    Links can't be opened like they usually would be in OOBE, because there's no
    browser to open them in. This CL creates a webview modal which is displayed
    when the user clicks on one of the two "Learn More" links in the MultiDevice
    OOBE screen, and loads it with the appropriate URL.
    
    Screenshot: https://screenshot.googleplex.com/JL9nfShorRA.png
    
    Bug: 893349
    Change-Id: I1ac06ea26857adcdf1f3113756e95e15b2f8a127
    Reviewed-on: https://chromium-review.googlesource.com/c/1275296
    Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599084}

    Changed files

    • chrome/browser/resources/chromeos/login/multidevice_setup_first_run.html
    • chrome/browser/resources/chromeos/login/multidevice_setup_first_run.js
    • chrome/browser/resources/chromeos/login/screen_multidevice_setup.html
    • ui/webui/resources/cr_components/chromeos/multidevice_setup/BUILD.gn
    • ui/webui/resources/cr_components/chromeos/multidevice_setup/start_setup_page.html
    • ui/webui/resources/cr_components/chromeos/multidevice_setup/start_setup_page.js
  22. Add the CrOS intent helper as a browser supporting WebAPKs.

    Changed by Dominick Ng - dominicknohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 03:21:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4729eda6b9057a0a052573a7cb9c9af46f907eae

    Comments

    Add the CrOS intent helper as a browser supporting WebAPKs.
    
    This will allow WebAPKs to be bounced to the desktop browser on Chrome
    OS devices.
    
    BUG=893927
    
    Change-Id: Ic70b58d2ab2b23960cc894dd3420174b523908e6
    Reviewed-on: https://chromium-review.googlesource.com/c/1272756
    Reviewed-by: Xi Han <hanxi@chromium.org>
    Commit-Queue: Dominick Ng <dominickn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599083}

    Changed files

    • chrome/android/webapk/shell_apk/current_version/current_version.gni
    • chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/HostBrowserUtils.java
  23. Roll src/third_party/angle f2ed299569c0..c4533eae082f (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 03:12:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d47784f23ea51b0b1def44a767780f383be6b090

    Comments

    Roll src/third_party/angle f2ed299569c0..c4533eae082f (1 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/f2ed299569c0..c4533eae082f
    
    
    git log f2ed299569c0..c4533eae082f --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 yizhou.jiang@intel.com Enable ANGLE_texture_multisample in glsl in es 3.0
    
    
    Created with:
      gclient setdep -r src/third_party/angle@c4533eae082f
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=fjhenigman@chromium.org
    
    Change-Id: Ie5a6b652c2c723a90215ae863749da0c24965d4d
    Reviewed-on: https://chromium-review.googlesource.com/c/1278528
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599082}

    Changed files

    • DEPS
  24. Updating trunk VERSION from 3578.0 to 3579.0 and incrementing major version to 72

    Changed by chrome-release-bot - chrome-release-botohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 03:08:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 16e778a19743677a294dd155583e11f265f0d065

    Comments

    Updating trunk VERSION from 3578.0 to 3579.0 and incrementing major version to 72
    
    # This is an automated release commit.
    # Do not revert without consulting chrome-pmo@google.com.
    NOAUTOREVERT=true
    TBR=benmason@chromium.org
    
    Change-Id: I81c44eb87bd68655b6cbc34a68cde6f851a839f0
    Reviewed-on: https://chromium-review.googlesource.com/c/1278328
    Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599081}

    Changed files

    • chrome/MAJOR_BRANCH_DATE
    • chrome/VERSION
  25. [CrOS MultiDevice] Add Shutdown() handling in MultiDevice KeyedServices.

    Changed by Kyle Horimoto - khorimotoohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 03:06:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f49ce435169672969142e5da5303def870e7fd98

    Comments

    [CrOS MultiDevice] Add Shutdown() handling in MultiDevice KeyedServices.
    
    This ensures that connections to our Mojo services are disconnected,
    which will result in the Shutdown() code added in this CL will run:
    https://chromium-review.googlesource.com/c/chromium/src/+/1274886
    
    Bug: 884066
    Change-Id: Ifb4fad53fc9d1a693ae83099dc43ee9908303ea7
    TBR: jhawkins@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/c/1277588
    Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
    Reviewed-by: Jeremy Klein <jlklein@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599080}

    Changed files

    • chrome/browser/chromeos/android_sms/android_sms_service.cc
    • chrome/browser/chromeos/device_sync/device_sync_client_factory.cc
    • chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
    • chrome/browser/chromeos/multidevice_setup/multidevice_setup_client_factory.cc
    • chromeos/services/device_sync/BUILD.gn
    • chromeos/services/device_sync/device_sync_base.cc
    • chromeos/services/device_sync/device_sync_base.h
    • chromeos/services/device_sync/device_sync_impl.cc
    • chromeos/services/device_sync/fake_device_sync.cc
  26. android: Dump for delayed presentation timestamp.

    Changed by Sadrul Habib Chowdhury - sadrulohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:55:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31c0c1c2517f38fb1e0ed336c4e70d261b97e69d

    Comments

    android: Dump for delayed presentation timestamp.
    
    It looks like on android, presentation timestamps can sometimes be very
    large. DumpWithoutCrashing() in such cases to collect some data to
    understand why/when/where this is happening.
    
    BUG=894440
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    Change-Id: I22817f68014c3f57f7180accc593506eee86f291
    Reviewed-on: https://chromium-review.googlesource.com/c/1276549
    Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
    Reviewed-by: kylechar <kylechar@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599079}

    Changed files

    • base/timer/elapsed_timer.h
    • components/viz/service/display/display.cc
    • components/viz/service/display/display.h
  27. Add Android Messages usage info in notifications settings.

    Changed by Azeem Arshad - azeemarshadohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:51:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b9d0776816b987172184af69d6de4a09def7dca6

    Comments

    Add Android Messages usage info in notifications settings.
    
    This CL adds a special note under messages for android entry
    in notification permissions to indicate usage in ChromeOS multidevice
    features. This note will be displayed whenever the messages
    sync feature is enabled. Please refer screenshot:
    https://screenshot.googleplex.com/VnGZ1qApzHk.png
    
    Bug: 845706
    Change-Id: Ibcbe706cf9c579d980e4440825b8bc70b64466df
    Reviewed-on: https://chromium-review.googlesource.com/c/1260503
    Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
    Reviewed-by: Jeremy Klein <jlklein@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599078}

    Changed files

    • chrome/app/settings_strings.grdp
    • chrome/browser/resources/settings/multidevice_page/multidevice_browser_proxy.js
    • chrome/browser/resources/settings/settings_resources.grd
    • chrome/browser/resources/settings/site_settings/BUILD.gn
    • chrome/browser/resources/settings/site_settings/site_list.html
    • chrome/browser/resources/settings/site_settings/site_list.js
    • chrome/browser/resources/settings/site_settings/site_list_entry.js
    • chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/webui/settings/chromeos/multidevice_handler.cc
    • chrome/browser/ui/webui/settings/chromeos/multidevice_handler.h
    • chrome/browser/ui/webui/settings/chromeos/multidevice_handler_unittest.cc
    • chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
    • chrome/test/data/webui/settings/cr_settings_browsertest.js
    • chrome/test/data/webui/settings/multidevice_page_tests.js
    • chrome/test/data/webui/settings/multidevice_subpage_tests.js
    • chrome/test/data/webui/settings/site_list_entry_tests.js
    • chrome/test/data/webui/settings/site_list_tests.js
    • chrome/test/data/webui/settings/test_multidevice_browser_proxy.js
    • chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js
  28. Use unique_ptr<> for BrowserPluginGuest creation APIs

    Changed by Albert J. Wong - ajwongohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:50:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c55cc64d0a527b307b12e547fc5b5c1f1a93c70b

    Comments

    Use unique_ptr<> for BrowserPluginGuest creation APIs
    
    Bug: 419087
    Change-Id: Ic870c7059fef752560d0299064a0cef4a1733f3a
    Reviewed-on: https://chromium-review.googlesource.com/c/1277594
    Commit-Queue: Albert J. Wong <ajwong@chromium.org>
    Reviewed-by: Nasko Oskov <nasko@chromium.org>
    Reviewed-by: danakj <danakj@chromium.org>
    Reviewed-by: James MacLean <wjmaclean@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599077}

    Changed files

    • content/browser/browser_plugin/browser_plugin_guest.cc
    • content/browser/browser_plugin/browser_plugin_guest.h
    • content/browser/web_contents/web_contents_impl.cc
    • content/browser/web_contents/web_contents_impl.h
  29. Update VR JS dialog goldens

    Changed by Becky Zhou - huayinzohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:37:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c72c4a77a976bc67bbcb4a5bc2340ac48b47f5ae

    Comments

    Update VR JS dialog goldens
    
    Bug: 894660
    Change-Id: Ib8b7d6484bd050daf4d295c1c9367bd132cb9e80
    Reviewed-on: https://chromium-review.googlesource.com/c/1278269
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Becky Zhou <huayinz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599076}

    Changed files

    • components/test/data/js_dialogs/render_tests/VrBrowserJavaScriptModalDialogTest.js_modal_view_vr_alert.Pixel_XL-25.png
    • components/test/data/js_dialogs/render_tests/VrBrowserJavaScriptModalDialogTest.js_modal_view_vr_alert.Pixel_XL-26.png
    • components/test/data/js_dialogs/render_tests/VrBrowserJavaScriptModalDialogTest.js_modal_view_vr_confirm.Pixel_XL-25.png
    • components/test/data/js_dialogs/render_tests/VrBrowserJavaScriptModalDialogTest.js_modal_view_vr_confirm.Pixel_XL-26.png
    • components/test/data/js_dialogs/render_tests/VrBrowserJavaScriptModalDialogTest.js_modal_view_vr_prompt.Pixel_XL-25.png
    • components/test/data/js_dialogs/render_tests/VrBrowserJavaScriptModalDialogTest.js_modal_view_vr_prompt.Pixel_XL-26.png
  30. assistant: Check status before starting service

    Changed by wutao - wutaoohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:33:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2a789a6e4d2c639cfe39db5b7b19edd6a0837ad6

    Comments

    assistant: Check status before starting service
    
    This cl checks the |allowed_status| before starting assistant service.
    
    Bug: b/117371953
    Test: manual.
    Change-Id: I0b638db9d92abd5f54c5f7f41d5f66c25a719f77
    Reviewed-on: https://chromium-review.googlesource.com/c/1278345
    Commit-Queue: Tao Wu <wutao@chromium.org>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599075}

    Changed files

    • chrome/browser/ui/ash/assistant/assistant_client.cc
  31. Modify Assistant DialogPlate icons and shift greeting label.

    Changed by David Black - dmblackohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 02:32:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ddbc8a4da719464b3ebdbdae529019bc64964738

    Comments

    Modify Assistant DialogPlate icons and shift greeting label.
    
    Per request from UI/UX folks, enlarging DialogPlate icons sizes to
    24dip and adjusting left inset for voice input modality layout container.
    
    Note that the vector icon files themselves were also updated per request
    in the bug to ensure consistency of internal padding.
    
    Also per request, the greeting label is shifted up by 4dip.
    
    See bug for discussion/screenshots.
    
    Bug: b:112313532
    Change-Id: I5b72c6867452470abbc8bd562c83ba37492279ea
    Reviewed-on: https://chromium-review.googlesource.com/c/1276947
    Commit-Queue: David Black <dmblack@google.com>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599074}

    Changed files

    • ash/assistant/ui/dialog_plate/action_view.cc
    • ash/assistant/ui/dialog_plate/dialog_plate.cc
    • ash/assistant/ui/main_stage/assistant_main_stage.cc
    • ash/resources/vector_icons/BUILD.gn
    • ash/resources/vector_icons/keyboard.icon
    • ash/resources/vector_icons/mic.icon
    • ash/resources/vector_icons/settings.icon
  32. Move response processing out of UiElementContainerView.

    Changed by David Black - dmblackohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 02:27:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 74869ac201a1859b4acc0bc0e0b14304f99843fb

    Comments

    Move response processing out of UiElementContainerView.
    
    This CL moves processing logic out of UiElementContainerView and into
    AssistantResponseProcessor which is owned by
    AssistantInteractionController.
    
    The controller will now initiate processing of the Assistant response
    before it is finalized. This cleans up the view logic considerably as
    well as provides better synchronization of animations since processing
    will have already occurred prior to the stage initiating a change.
    
    Bug: b:117344968, b:116751668
    Change-Id: I3ac1300978a3448fd7e244b6a7312ec9bf3c39bd
    Reviewed-on: https://chromium-review.googlesource.com/c/1265820
    Commit-Queue: David Black <dmblack@google.com>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599073}

    Changed files

    • ash/BUILD.gn
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/assistant/assistant_response_processor.cc
    • ash/assistant/assistant_response_processor.h
    • ash/assistant/model/assistant_interaction_model.cc
    • ash/assistant/model/assistant_interaction_model.h
    • ash/assistant/model/assistant_interaction_model_observer.h
    • ash/assistant/model/assistant_response.cc
    • ash/assistant/model/assistant_response.h
    • ash/assistant/model/assistant_response_observer.h
    • ash/assistant/model/assistant_ui_element.cc
    • ash/assistant/model/assistant_ui_element.h
    • ash/assistant/ui/assistant_mini_view.cc
    • ash/assistant/ui/assistant_mini_view.h
    • ash/assistant/ui/assistant_ui_constants.h
    • ash/assistant/ui/main_stage/assistant_header_view.cc
    • ash/assistant/ui/main_stage/assistant_header_view.h
    • ash/assistant/ui/main_stage/assistant_main_stage.cc
    • ash/assistant/ui/main_stage/assistant_main_stage.h
    • ash/assistant/ui/main_stage/suggestion_container_view.cc
    • ash/assistant/ui/main_stage/suggestion_container_view.h
    • ash/assistant/ui/main_stage/ui_element_container_view.cc
    • ash/assistant/ui/main_stage/ui_element_container_view.h
  33. DevTools: use invoke_ notation for the DOM.getNodeForLocation

    Changed by Pavel Feldman - pfeldmanohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:26:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a5b00caf3bd7d17a327de3ddef647259af155ee

    Comments

    DevTools: use invoke_ notation for the DOM.getNodeForLocation
    
    Bug: 893705
    Change-Id: I6df37f886de9c080fa20c972df7457b0a726ce3e
    Reviewed-on: https://chromium-review.googlesource.com/c/1278206
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599072}

    Changed files

    • third_party/blink/renderer/devtools/front_end/sdk/DOMModel.js
  34. nacl_helper: Removing ldflags which intended to fix crash in ThinLTO

    Changed by Zhizhou Yang - zhizhouyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 02:15:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38a512ee8468d9a18ccdbe57f02344d93e1e4729

    Comments

    nacl_helper: Removing ldflags which intended to fix crash in ThinLTO
    
    This patch will remove a linker flag for ThinLTO. The flag was first
    introduced to work around a nacl crash bug. After the compiler upgrade,
    there is no need to keep this work around.
    
    I tested the nacl_helper code size changes on several different boards:
    on samus: 30MB -> 11MB
    on elm: 19MB -> 7MB
    on veyton-minnie: 19MB -> 7MB
    
    Tested correctness by trying to reproduce https://crbug.com/799642 and
    no error shows up.
    
    BUG=chromium:799642
    TEST=USE="afdo_use" emerge-samus chromeos-chrome
    
    Change-Id: I6fff65700e6d5a5d0e02ad810def5317ea912263
    Reviewed-on: https://chromium-review.googlesource.com/c/1277596
    Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
    Commit-Queue: Zhizhou Yang <zhizhouy@google.com>
    Cr-Commit-Position: refs/heads/master@{#599071}

    Changed files

    • components/nacl/loader/BUILD.gn
  35. Reland "NUX Onboarding: clean up build process."

    Changed by Scott Chen - scottchenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:15:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f68c9b2548a5f1a2462146e1efc36165571c055c

    Comments

    Reland "NUX Onboarding: clean up build process."
    
    The original CL 1252906 was reverted due to breaking unit tests for
    branded window builds.
    
    This CL fixes that by removing obsolete unit tests. It was testing the
    mechanism that conditionally directs users to the chrome://welcome/email
    and chrome://welcome/apps experiment URLs, which will no longer be used.
    
    Bug: 874153
    Change-Id: I3b92b53e191606a6f5889cf17b15a570ce566994
    Reviewed-on: https://chromium-review.googlesource.com/c/1275294
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599070}

    Changed files

    • BUILD.gn
    • chrome/browser/profiles/profile_manager.cc
    • chrome/browser/resources/BUILD.gn
    • chrome/browser/resources/welcome/onboarding_welcome/BUILD.gn
    • chrome/browser/resources/welcome/onboarding_welcome/email/BUILD.gn
    • chrome/browser/resources/welcome/onboarding_welcome/google_apps/BUILD.gn
    • chrome/browser/resources/welcome/onboarding_welcome/set_as_default/BUILD.gn
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/startup/startup_browser_creator.cc
    • chrome/browser/ui/startup/startup_tab_provider.cc
    • chrome/browser/ui/startup/startup_tab_provider.h
    • chrome/browser/ui/startup/startup_tab_provider_unittest.cc
    • chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc
    • chrome/browser/ui/webui/welcome/nux_helper.cc
    • chrome/browser/ui/webui/welcome/nux_helper.h
    • chrome/browser/ui/webui/welcome/welcome_ui.cc
    • chrome/browser/ui/webui/welcome/welcome_ui.h
    • chrome/common/pref_names.cc
    • chrome/common/pref_names.h
  36. Revert "splitscreen: Adjust bubble dialog bounds if splitscreen is active."

    Changed by Patti - patricialorohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:14:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e41458e037d2d6eea8297dfee4006848bb6f123a

    Comments

    Revert "splitscreen: Adjust bubble dialog bounds if splitscreen is active."
    
    This reverts commit c3acb7ba6a2b6565656736f3050bfc593baf4781.
    
    Reason for revert: This change may be causing ash_unittests to fail on multiple builders - see crbug.com/894683
    
    Original change's description:
    > splitscreen: Adjust bubble dialog bounds if splitscreen is active.
    > 
    > When a dialog is added to a window that's currently showig in
    > splitscreen, we should adjust the dialog bounds to show the dialog
    > aligned within its own side of the split, rather than across the divider
    > bar.
    > 
    > Note the divider is still placed on top of the snapped windows and its
    > transient children if they are placed in default container.
    > 
    > Bug: 878268
    > Change-Id: Ibdd71f1d42aac419ef73ae9f7a2f78af6bf36880
    > Reviewed-on: https://chromium-review.googlesource.com/c/1274197
    > Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
    > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#598827}
    
    TBR=xiyuan@chromium.org,xdai@chromium.org
    
    Change-Id: I74d78ce0184d2028811872ac633da33ede16f296
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 878268, 894683
    Reviewed-on: https://chromium-review.googlesource.com/c/1277907
    Reviewed-by: Patti <patricialor@chromium.org>
    Commit-Queue: Patti <patricialor@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599069}

    Changed files

    • ash/wm/splitview/split_view_controller_unittest.cc
    • ash/wm/splitview/split_view_divider.cc
    • ash/wm/splitview/split_view_divider.h
  37. Make PRESUBMIT.py and tests in LayoutTests/ workable in web_tests/.

    Changed by Kent Tamura - tkentohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:07:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59dc2a72979d66089c58d1c0da8f835ec2894692

    Comments

    Make PRESUBMIT.py and tests in LayoutTests/ workable in web_tests/.
    
    This CL makes LayoutTests/PRESUBMIT.py and some tests in LayoutTests/
    workable in blink/web_tests/ too.
    Moving LayoutTests directory gets easier by this CL.
    
    * PRESUBMIT.py
     - Use PresubmitLocalPath() instead of 'LayoutTests'
     - Remove unnecessary check for existence of 'LayoutTests' in
      AffectedFiles(), which returns files under the PRESUBMIT directory.
      _FindNewViolationsOfRule() also handles only files under the
      PRESUBMIT directory.
    
    * Tests
     - Update code searching for 'LayoutTests' so that it searches for
       'web_tests' too.
     - Drop 'LayoutTests' from test expectations if we can
     - Introduce relativeTestPath()
    
    Change-Id: I741ab3cb29d8e6c2a35e3b7669f92744f76c2839
    Bug: 843412
    Reviewed-on: https://chromium-review.googlesource.com/c/1276047
    Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599068}

    Changed files

    • third_party/WebKit/LayoutTests/PRESUBMIT.py
    • third_party/WebKit/LayoutTests/cssom/cssfloat-cssom.html
    • third_party/WebKit/LayoutTests/editing/assert_selection.js
    • third_party/WebKit/LayoutTests/editing/pasteboard/drag-files-to-editable-element.html
    • third_party/WebKit/LayoutTests/fast/dom/Window/dom-access-from-closure-iframe-expected.txt
    • third_party/WebKit/LayoutTests/fast/dom/Window/dom-access-from-closure-window-expected.txt
    • third_party/WebKit/LayoutTests/fast/dom/Window/dom-access-from-closure-window-with-gc-expected.txt
    • third_party/WebKit/LayoutTests/fast/dom/Window/resources/dom-access-from-closure-iframe-child.html
    • third_party/WebKit/LayoutTests/fast/dom/Window/resources/dom-access-from-closure-window-child.html
    • third_party/WebKit/LayoutTests/fast/dom/documenturi-not-affected-by-base-tag-expected.txt
    • third_party/WebKit/LayoutTests/fast/dom/documenturi-not-affected-by-base-tag.html
    • third_party/WebKit/LayoutTests/fast/frames/frame-src-attribute-expected.txt
    • third_party/WebKit/LayoutTests/fast/frames/frame-src-attribute.html
    • third_party/WebKit/LayoutTests/fast/js/script-tests/exception-line-number.js
    • third_party/WebKit/LayoutTests/fast/workers/constructor-proto.html
    • third_party/WebKit/LayoutTests/fast/workers/resources/worker-location.js
    • third_party/WebKit/LayoutTests/fast/workers/resources/worker-navigator.js
    • third_party/WebKit/LayoutTests/fast/workers/resources/worker-replace-self.js
    • third_party/WebKit/LayoutTests/http/tests/devtools/file-system-project.js
    • third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/network-uisourcecode-provider.js
    • third_party/WebKit/LayoutTests/inspector-protocol/dom-snapshot/dom-snapshot-getSnapshot-expected.txt
    • third_party/WebKit/LayoutTests/inspector-protocol/dom-snapshot/dom-snapshot-getSnapshot.js
    • third_party/WebKit/LayoutTests/resources/common.js
  38. Stop after type mismatch of args of a message received by PDF Plugin.

    Changed by Henrique Nakashima - hnakashimaohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:06:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ba3e80058ac8ed66fefa0ec3c68adba8edcac6e2

    Comments

    Stop after type mismatch of args of a message received by PDF Plugin.
    
    Previously, after HandleMessage matched the message type, if the
    argument types were wrong it would keep trying to match with the
    other message types.
    
    Change-Id: Ia270ddc0ac4614b3ef998bcd30d3686f987dd809
    Reviewed-on: https://chromium-review.googlesource.com/c/1277445
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599067}

    Changed files

    • pdf/out_of_process_instance.cc
  39. Import wpt@639d29d0f4f7932109ce83039d3d057f4cac75b0

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 02:04:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a19a0bb310f57c27fe5dbfe5bdca3244ac430091

    Comments

    Import wpt@639d29d0f4f7932109ce83039d3d057f4cac75b0
    
    Using wpt-import in Chromium 08d41ac558fd84035f4fea691370edf2fe7373d9.
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25970
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
      external/wpt/fetch
    
    NOAUTOREVERT=true
    TBR=foolip
    
    No-Export: true
    Change-Id: Ic18cb6ace02a8e07c8b1c4fcca71bd9ce8704ebd
    Reviewed-on: https://chromium-review.googlesource.com/c/1278142
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599066}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/fetch/api/abort/serviceworker-intercepted.https.html
    • third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/destination/resources/fetch-destination-worker-no-load-event.js
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/postmessage-to-client.https.html
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/about-blank-replacement-ping-frame.py
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/enable-client-message-queue.html
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/message-vs-microtask.html
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/nested-iframe-parent.html
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/stalling-service-worker.js
  40. Don't try RemoveTemporarySession test if license server not available.

    Changed by John Rummell - jrummellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 01:57:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 44229dd3259f368779bfc384620e127c0c0abba9

    Comments

    Don't try RemoveTemporarySession test if license server not available.
    
    BUG=894422
    TEST=test passes on Windows
    
    Change-Id: I3907fecda3642f542db153e68ce12cb33c074402
    Reviewed-on: https://chromium-review.googlesource.com/c/1278467
    Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
    Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599065}

    Changed files

    • chrome/browser/media/encrypted_media_browsertest.cc
  41. Roll src-internal 55ac0aa2f68f..616feb1a7c2c (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 01:57:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 040907c0408cd98d7ee1d368002c258b8356c41a

    Comments

    Roll src-internal 55ac0aa2f68f..616feb1a7c2c (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/55ac0aa2f68f..616feb1a7c2c
    
    
    Created with:
      gclient setdep -r src-internal@616feb1a7c2c
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ia68c999e8e301f47fc1e0dadeb8cd369a1377495
    Reviewed-on: https://chromium-review.googlesource.com/c/1277840
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599064}

    Changed files

    • DEPS
  42. Roll src/third_party/pdfium c7f66edd2244..94f3ca931552 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 01:54:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1949eebad19138b6a0e701255b6c3a9ad2e9868b

    Comments

    Roll src/third_party/pdfium c7f66edd2244..94f3ca931552 (2 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/c7f66edd2244..94f3ca931552
    
    
    git log c7f66edd2244..94f3ca931552 --date=short --no-merges --format='%ad %ae %s'
    2018-10-11 thestig@chromium.org Fix some nits in CJS_Document helpers.
    2018-10-11 thestig@chromium.org Use pdfium::Vector2D in CCodec_FaxEncoder ctor.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@94f3ca931552
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I062fef526b85eec3b0d299893951ad74a10d4b2c
    Reviewed-on: https://chromium-review.googlesource.com/c/1278485
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599063}

    Changed files

    • DEPS
  43. Roll src/third_party/chromite 7078e2599b7b..d23bbdb87b57 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 01:47:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4aaee5b116fefa626ebf5dcb400e609cafcfebed

    Comments

    Roll src/third_party/chromite 7078e2599b7b..d23bbdb87b57 (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/7078e2599b7b..d23bbdb87b57
    
    
    git log 7078e2599b7b..d23bbdb87b57 --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 gmx@chromium.org kip: enable new tcmalloc
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@d23bbdb87b57
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I7c19b61739142e56b9c1053adbbf8b5884e2738c
    Reviewed-on: https://chromium-review.googlesource.com/c/1277836
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599062}

    Changed files

    • DEPS