Home | Search | chromium - Builders
Login

Builder Mac FYI GPU ASAN Release Build 1605 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revisione064bc93ae45308ecc1b6fa886808ad20bd2225f
Got Revisione064bc93ae45308ecc1b6fa886808ad20bd2225f

Execution:

Steps and Logfiles:

Show:
  1. ( 0 ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. Peter Kasting (pkastingohnoyoudont@chromium.org)
  2. Yafei Duan (romaxohnoyoudont@chromium.org)
  3. skia-chromium-autoroll (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  4. Joe Mason (joenotcharlesohnoyoudont@chromium.org)
  5. Chris Palmer (palmerohnoyoudont@chromium.org)
  6. Kai Ninomiya (kaininoohnoyoudont@chromium.org)
  7. siyua (siyuaohnoyoudont@chromium.org)
  8. Antoine Labour (pimanohnoyoudont@chromium.org)
  9. Scott Violet (skyohnoyoudont@chromium.org)
  10. Jun Mukai (mukaiohnoyoudont@chromium.org)
  11. Matthew Cary (mattcaryohnoyoudont@chromium.org)
  12. depot-tools-chromium-autoroll (depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  13. Wenzhao Zang (wzangohnoyoudont@chromium.org)
  14. Stephen Martinis (martinissohnoyoudont@chromium.org)
  15. Lei Zhang (thestigohnoyoudont@chromium.org)
  16. John Chen (johnchenohnoyoudont@chromium.org)
  17. Adolfo Victoria (adokarohnoyoudont@google.com)
  18. angle-chromium-autoroll (angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  19. Emil A Eklund (eaeohnoyoudont@chromium.org)
  20. Tatiana Buldina (buldinaohnoyoudont@chromium.org)
  21. catapult-chromium-autoroll (catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  22. Dale Curtis (dalecurtisohnoyoudont@chromium.org)
  23. Zhenyao Mo (zmoohnoyoudont@chromium.org)
  24. Cathy Li (chiliohnoyoudont@chromium.org)
  25. Krishna Govind (govindohnoyoudont@chromium.org)
  26. Sebastien Marchand (sebmarchandohnoyoudont@chromium.org)
  27. Manu Cornet (manucornetohnoyoudont@chromium.org)
  28. Kenneth Russell (kbrohnoyoudont@chromium.org)
  29. Matthew Jones (mdjonesohnoyoudont@chromium.org)
  30. Stephen Martinis (martinissohnoyoudont@chromium.org)
  31. Pete Williamson (petewilohnoyoudont@chromium.org)
  32. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
  33. Lei Zhang (thestigohnoyoudont@chromium.org)
  34. kristipark (kristiparkohnoyoudont@chromium.org)
  35. Justin DeWitt (dewittjohnoyoudont@chromium.org)
  36. Wei-Yin Chen (陳威尹) (wychenohnoyoudont@chromium.org)
  37. Chris Lu (thegreenfrogohnoyoudont@chromium.org)
  38. pdfium-chromium-autoroll (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  39. Takuto Ikuta (tikutaohnoyoudont@chromium.org)
  40. Mason Freed (masonfreedohnoyoudont@google.com)
  41. Xi Cheng (chengxohnoyoudont@chromium.org)
  42. Christopher Cameron (ccameronohnoyoudont@chromium.org)
  43. Donn Denman (donndohnoyoudont@chromium.org)
  44. Eric Roman (eromanohnoyoudont@chromium.org)
  45. Erik Chen (erikchenohnoyoudont@chromium.org)
  46. Sarah Hu (xiaoyinhohnoyoudont@chromium.org)
  47. Gabriel Charette (gabohnoyoudont@chromium.org)
  48. Travis Skare (skareohnoyoudont@chromium.org)
  49. Derek Cheng (imchengohnoyoudont@chromium.org)
  50. Scott Violet (skyohnoyoudont@chromium.org)
  51. Martin Kreichgauer (martinkrohnoyoudont@google.com)
  52. Peter Wen (wnwenohnoyoudont@chromium.org)
  53. Adrienne Walker (enneohnoyoudont@chromium.org)
  54. Peter Kasting (pkastingohnoyoudont@chromium.org)
  55. Yuwei Huang (yuweihohnoyoudont@chromium.org)
  56. Peter Kasting (pkastingohnoyoudont@chromium.org)
  57. Avi Drissman (aviohnoyoudont@chromium.org)
  58. Weidong Guo (weidonggohnoyoudont@chromium.org)

Timing:

Create Saturday, 11-Aug-18 01:49:03 UTC
Start Saturday, 11-Aug-18 01:49:06 UTC
End Saturday, 11-Aug-18 05:14:13 UTC
Pending 2 secs
Execution 3 hrs 25 mins

All Changes:

  1. Disable flaky tests.

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:46:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e064bc93ae45308ecc1b6fa886808ad20bd2225f

    Comments

    Disable flaky tests.
    
    Bug: 622387, 871692
    Change-Id: Ie03b640422b120d903ca56bf9f0650a1ffc23065
    TBR: mgiuca
    Reviewed-on: https://chromium-review.googlesource.com/1171852
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582419}

    Changed files

    • chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
    • chrome/test/data/webui/extensions/cr_extensions_browsertest.js
    • chrome/test/data/webui/settings/cr_settings_browsertest.js
  2. [Offline Pages] Implement live page sharing.

    Changed by Yafei Duan - romaxohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:45:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 514ffca0bacb2fce140defae3a4ae3dcab37bfa0

    Comments

    [Offline Pages] Implement live page sharing.
    
    Implement live page sharing:
    - Adding a new temporary client namespace for the usage of live page
      sharing, which has a limit of one page per url and expiration period
      as one hour.
    - Adding saveAndSharePage in OfflinePageUtils, implementing the workflow
      of save page, get page and share page.
    
    Bug: 870895
    Change-Id: Iab5f074dfa955ba30f8b125a70cedb87e8610246
    Reviewed-on: https://chromium-review.googlesource.com/1162827
    Reviewed-by: Peter Williamson <petewil@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Yafei Duan <romax@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582418}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/offlinepages/GetPagesByNamespaceForLivePageSharingCallback.java
    • chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
    • chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
    • chrome/android/java/src/org/chromium/chrome/browser/offlinepages/SavePageAndShareCallback.java
    • chrome/android/java/src/org/chromium/chrome/browser/share/ShareMenuActionHandler.java
    • chrome/android/java_sources.gni
    • components/offline_pages/core/client_namespace_constants.cc
    • components/offline_pages/core/client_namespace_constants.h
    • components/offline_pages/core/client_policy_controller.cc
    • components/offline_pages/core/client_policy_controller_unittest.cc
    • components/offline_pages/core/model/offline_page_model_utils.cc
    • tools/metrics/histograms/enums.xml
  3. Roll src/third_party/skia 4eac21fee047..f3ca1c6abb07 (18 commits)

    Changed by skia-chromium-autoroll - skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Saturday, 11-Aug-18 01:40:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 51acd92215e6b735f2c0f80119f7ca51c031f797

    Comments

    Roll src/third_party/skia 4eac21fee047..f3ca1c6abb07 (18 commits)
    
    https://skia.googlesource.com/skia.git/+log/4eac21fee047..f3ca1c6abb07
    
    
    git log 4eac21fee047..f3ca1c6abb07 --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 brucewang@google.com Implement FreeType COLR/CPAL support.
    2018-08-10 timliang@google.com fixed the size in bytes of vec3s to match Metal standard in Metal gpu backend
    2018-08-10 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2018-08-10 timliang@google.com only set color index if using dual source blending in Metal gpu backend
    2018-08-10 kjlubick@google.com [PathKit] Add various path effects
    2018-08-10 mtklein@google.com clean up SK_LEGACY_CONVERT_PIXELS_IMPL
    2018-08-10 caryclark@skia.org fix text blob example errors
    2018-08-10 caryclark@skia.org fix bookmaker check for enum size
    2018-08-10 liyuqian@google.com Reland "Update ShouldUseAAA with our better complexity estimation"
    2018-08-10 timliang@google.com enabled gms and most unit tests for Metal gpu backend
    2018-08-10 mtklein@google.com switch ubsan to blacklist
    2018-08-10 bungeman@google.com Change generateAdvance to never chain.
    2018-08-10 caryclark@skia.org refresh generated includes
    2018-08-10 fmalita@chromium.org [sksg] Simplify ScopedRenderContext
    2018-08-10 caryclark@skia.org new batch of docs
    2018-08-10 timliang@google.com implemented GrMtlGpuCommandBuffer for draws in Metal gpu backend
    2018-08-10 mtklein@google.com add bounds sanitizer to ASAN/UBSAN bots
    2018-08-10 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader dd662d210afc..c47cd435bf6f (1 commits)
    
    
    Created with:
      gclient setdep -r src/third_party/skia@f3ca1c6abb07
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=djsollen@chromium.org
    
    Change-Id: I5274deea227ad59efbb4157cf2401fcc016ae264
    Reviewed-on: https://chromium-review.googlesource.com/1171445
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582417}

    Changed files

    • DEPS
  4. Mojo: Add ArrayTraits for std::unordered_set

    Changed by Joe Mason - joenotcharlesohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:31:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 576c7e134e5ce40b4ef09482600d9bd51f52d152

    Comments

    Mojo: Add ArrayTraits for std::unordered_set
    
    This is required to typemap chrome_cleaner::PUPData.
    
    R=rockot
    
    Bug: 830892
    Change-Id: I42e29dbd928c1bd9064ba9a75a37493461209b7e
    Reviewed-on: https://chromium-review.googlesource.com/1171736
    Commit-Queue: Joe Mason <joenotcharles@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582416}

    Changed files

    • mojo/public/cpp/bindings/array_traits_stl.h
  5. Change the history state throttle interval from 60 to 120 Hz.

    Changed by Chris Palmer - palmerohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:26:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e4127dd506c501cd3f51d91dc22a3dfa8f5f1ca

    Comments

    Change the history state throttle interval from 60 to 120 Hz.
    
    This is a bit more lenient and may enable some callers, including a flaky test,
    to get (more of) what they need. The test's root problem seems to be data races
    (see issue 847326), however.
    
    Bug: 870861
    Change-Id: I249e9f06fa9a9a9f3b74e53cf2ef3f34b0c2371c
    Reviewed-on: https://chromium-review.googlesource.com/1171825
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Chris Palmer <palmer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582415}

    Changed files

    • third_party/blink/renderer/core/frame/history.cc
  6. Normalize rendering_desktop.json, rendering_mobile.json

    Changed by Kai Ninomiya - kaininoohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:26:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 074cecb79d9d30ec9f2bf6b5b10edb6cd77a8b4f

    Comments

    Normalize rendering_desktop.json, rendering_mobile.json
    
    This is needed because re-recording archives (using record_wpr)
    causes these files to get re-alphabetized automatically.
    This commit lets us re-record an archive without producing an
    unreadable diff.
    
    Doing this also removes the duplicate key
    "androidpolice_mobile_sync_scroll_2018" from rendering_mobile.json.
    
    Tangentially, also delete the unused archive
    rendering_mobile_007.wprgo.sha1.
    
    Bug: 872551, 867368
    Change-Id: Ib15c9c0a8600e7fa510a146ad896aa92e4f9de45
    Reviewed-on: https://chromium-review.googlesource.com/1171677
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Commit-Queue: Kai Ninomiya <kainino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582414}

    Changed files

    • tools/perf/page_sets/data/rendering_desktop.json
    • tools/perf/page_sets/data/rendering_mobile.json
    • tools/perf/page_sets/data/rendering_mobile_007.wprgo.sha1
  7. Add Main Prompts for Card Migration Flow

    Changed by siyua - siyuaohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:24:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6fec3aebc5358345210d473c0ec36fef86ba5937

    Comments

    Add Main Prompts for Card Migration Flow
    
    This is the 1st CL adding view skeleton.
    
    For project details please refer to go/ib-paradise.
    
    Bug: 852904
    Change-Id: Icc10a2598bb15659a6478fc2dbf2734094111494
    Reviewed-on: https://chromium-review.googlesource.com/1149514
    Commit-Queue: Siyu An <siyua@chromium.org>
    Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    Reviewed-by: Cait Phillips <caitkp@chromium.org>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Cr-Commit-Position: refs/heads/master@{#582413}

    Changed files

    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/autofill/local_card_migration_dialog.h
    • chrome/browser/ui/autofill/local_card_migration_dialog_controller_impl.cc
    • chrome/browser/ui/autofill/local_card_migration_dialog_controller_impl.h
    • chrome/browser/ui/autofill/local_card_migration_dialog_factory.h
    • chrome/browser/ui/autofill/local_card_migration_dialog_state.h
    • chrome/browser/ui/views/autofill/local_card_migration_dialog_view.cc
    • chrome/browser/ui/views/autofill/local_card_migration_dialog_view.h
    • chrome/browser/ui/views/harmony/chrome_layout_provider.cc
    • chrome/browser/ui/views/harmony/chrome_layout_provider.h
    • components/autofill/core/browser/BUILD.gn
    • components/autofill/core/browser/ui/local_card_migration_dialog_controller.h
    • components/autofill_strings.grdp
    • components/resources/autofill_scaled_resources.grdp
    • components/resources/default_100_percent/autofill/migration_header.png
    • components/resources/default_200_percent/autofill/migration_header.png
    • components/resources/default_300_percent/autofill/migration_header.png
  8. Send SharedImage IPC with multi-flush

    Changed by Antoine Labour - pimanohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:14:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 14ff32c26823fa7aff03d2d74790d04acdfb59ab

    Comments

    Send SharedImage IPC with multi-flush
    
    This generalizes the FlushParams to contain sync tokens + IPC::Message instead
    of ad-hoc fields transformed into Messages on the receiving side. This allows
    any Message (that doesn't have handles) to be included into the list, and
    simplifies the service-side handling.
    Existing AsyncFlush and DestroyTransferBuffer messages are now serialized
    client-side, and CreateSharedImage/DestroySharedImage are converted to this
    mechanism, to avoid extra IPCs per tile.
    
    Bug: 870116
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Ib11298c03e249f49aec8e710a3db4195aea33e81
    Reviewed-on: https://chromium-review.googlesource.com/1168731
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
    Commit-Queue: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582412}

    Changed files

    • gpu/command_buffer/common/command_buffer.h
    • gpu/ipc/client/command_buffer_proxy_impl.cc
    • gpu/ipc/client/command_buffer_proxy_impl_unittest.cc
    • gpu/ipc/client/gpu_channel_host.cc
    • gpu/ipc/client/gpu_channel_host.h
    • gpu/ipc/client/shared_image_interface_proxy.cc
    • gpu/ipc/common/BUILD.gn
    • gpu/ipc/common/flush_params.cc
    • gpu/ipc/common/flush_params.h
    • gpu/ipc/common/gpu_messages.h
    • gpu/ipc/common/gpu_param_traits_macros.h
    • gpu/ipc/service/gpu_channel.cc
    • gpu/ipc/service/shared_image_stub.cc
    • gpu/ipc/service/shared_image_stub.h
  9. chromeos: add SingleProcessMash mode

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:14:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b092ae622b9ab3856d64d3eca543e4ecb243be77

    Comments

    chromeos: add SingleProcessMash mode
    
    This makes Ash create an Env if passed SingleProcessMash. In addition this
    makes all window creation go through a factory that ensures the right env is
    supplied.
    
    See https://docs.google.com/document/d/11ha_KioDdXe4iZS2AML1foKnCJlNKm7Q1hFr6VW8dV4/edit
    for more details.
    
    This also adds the feature to ui/base.
    
    BUG=847992
    TEST=covered by tests
    
    Change-Id: Ica3c433627222f0e076dddaf19b1ab09168cebeb
    Reviewed-on: https://chromium-review.googlesource.com/1168282
    Commit-Queue: Scott Violet <sky@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582411}

    Changed files

    • ash/BUILD.gn
    • ash/README.md
    • ash/app_launch_unittest.cc
    • ash/ash_service_unittest.cc
    • ash/components/fast_ink/fast_ink_view.cc
    • ash/display/cursor_window_controller.cc
    • ash/display/display_manager_unittest.cc
    • ash/display/display_util.cc
    • ash/display/mirror_window_controller.cc
    • ash/display/mouse_cursor_event_filter_unittest.cc
    • ash/display/root_window_transformers_unittest.cc
    • ash/display/screen_ash.cc
    • ash/display/screen_position_controller_unittest.cc
    • ash/display/unified_mouse_warp_controller_unittest.cc
    • ash/display/window_tree_host_manager_unittest.cc
    • ash/drag_drop/drag_drop_tracker.cc
    • ash/events/event_rewriter_controller.cc
    • ash/extended_desktop_unittest.cc
    • ash/frame/detached_title_area_renderer.cc
    • ash/frame/header_view.cc
    • ash/host/DEPS
    • ash/host/ash_window_tree_host.cc
    • ash/host/ash_window_tree_host_platform.cc
    • ash/keyboard/arc/arc_input_method_surface_manager_unittest.cc
    • ash/keyboard/test_keyboard_ui.cc
    • ash/magnifier/docked_magnifier_controller.cc
    • ash/magnifier/magnification_controller_unittest.cc
    • ash/metrics/desktop_task_switch_metric_recorder_unittest.cc
    • ash/public/cpp/frame_border_hit_test.cc
    • ash/root_window_controller.cc
    • ash/root_window_controller_unittest.cc
    • ash/shelf/shelf_layout_manager_unittest.cc
    • ash/shelf/shelf_window_watcher_unittest.cc
    • ash/shell.cc
    • ash/shell.h
    • ash/shell_unittest.cc
    • ash/system/message_center/arc/arc_notification_content_view_unittest.cc
    • ash/system/message_center/arc/arc_notification_view_unittest.cc
    • ash/system/message_center/arc/mock_arc_notification_surface.cc
    • ash/system/message_center/arc/mock_arc_notification_surface.h
    • ash/system/night_light/night_light_controller.cc
    • ash/system/overview/overview_button_tray_unittest.cc
    • ash/system/tray/tray_background_view.cc
    • ash/test/ash_test_base.cc
    • ash/test/ash_test_helper.cc
    • ash/test/ash_test_suite.cc
    • ash/test/ui_controls_factory_ash.cc
    • ash/utility/screenshot_controller_unittest.cc
    • ash/wayland/wayland_server_controller.cc
    • ash/wayland/wayland_server_controller.h
    • ash/window_factory.cc
    • ash/window_factory.h
    • ash/window_user_data_unittest.cc
    • ash/wm/ash_focus_rules_unittest.cc
    • ash/wm/cursor_manager_chromeos.cc
    • ash/wm/drag_window_controller.cc
    • ash/wm/drag_window_resizer_unittest.cc
    • ash/wm/immersive_fullscreen_controller_unittest.cc
    • ash/wm/native_cursor_manager_ash_classic.cc
    • ash/wm/non_client_frame_controller.cc
    • ash/wm/overview/window_selector_unittest.cc
    • ash/wm/stacking_controller_unittest.cc
    • ash/wm/system_gesture_event_filter_unittest.cc
    • ash/wm/system_modal_container_layout_manager_unittest.cc
    • ash/wm/top_level_window_factory.cc
    • ash/wm/toplevel_window_event_handler.cc
    • ash/wm/toplevel_window_event_handler_unittest.cc
    • ash/wm/video_detector.cc
    • ash/wm/window_dimmer.cc
    • ash/wm/window_dimmer_unittest.cc
    • ash/wm/workspace/workspace_event_handler_unittest.cc
    • ash/wm/workspace/workspace_layout_manager_unittest.cc
    • ash/wm/workspace/workspace_window_resizer_unittest.cc
    • ash/wm/workspace_controller_unittest.cc
    • ash/ws/window_service_owner.cc
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc
    • chrome/browser/ui/ash/ksv/DEPS
    • chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_util.cc
    • components/exo/test/exo_test_base.cc
    • components/exo/wayland/clients/test/wayland_client_test.cc
    • ui/aura/env.cc
    • ui/aura/env.h
    • ui/aura/test/test_windows.cc
    • ui/aura/test/test_windows.h
    • ui/aura/window.cc
    • ui/aura/window.h
    • ui/aura/window_tree_host_platform.cc
    • ui/base/ui_base_features.cc
    • ui/base/ui_base_features.h
  10. refine window finder for mash

    Changed by Jun Mukai - mukaiohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:09:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c0f9aa861fdb9bc534829d3f764e2100cfff71c

    Comments

    refine window finder for mash
    
    Previously window_finder_chromeos (for mash) looks through the
    list of the toplevel browser windows, but it is too simple and
    doesn't work well on several cases.
    
    This CL moves the window finding code to ash, and let WindowTree
    notify the list of windows at the cursor to the client upon
    window moving.
    
    BUG=867074
    TEST=ash_unittests
    
    Change-Id: Ib44ad1a927a31c50cc108eee92ddba4d9bd918ee
    Reviewed-on: https://chromium-review.googlesource.com/1159346
    Commit-Queue: Jun Mukai <mukai@chromium.org>
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582410}

    Changed files

    • ash/BUILD.gn
    • ash/wm/window_finder.cc
    • ash/wm/window_finder.h
    • ash/wm/window_finder_unittest.cc
    • ash/ws/window_service_delegate_impl.cc
    • ash/ws/window_service_delegate_impl.h
    • ash/ws/window_service_delegate_impl_unittest.cc
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/views/tabs/DEPS
    • chrome/browser/ui/views/tabs/tab_drag_controller.cc
    • chrome/browser/ui/views/tabs/window_finder.cc
    • chrome/browser/ui/views/tabs/window_finder.h
    • chrome/browser/ui/views/tabs/window_finder_chromeos.cc
    • content/renderer/mus/renderer_window_tree_client.cc
    • content/renderer/mus/renderer_window_tree_client.h
    • services/ui/public/interfaces/window_tree.mojom
    • services/ui/ws2/BUILD.gn
    • services/ui/ws2/test_change_tracker.cc
    • services/ui/ws2/test_change_tracker.h
    • services/ui/ws2/test_window_tree_client.cc
    • services/ui/ws2/test_window_tree_client.h
    • services/ui/ws2/topmost_window_observer.cc
    • services/ui/ws2/topmost_window_observer.h
    • services/ui/ws2/window_service_delegate.cc
    • services/ui/ws2/window_service_delegate.h
    • services/ui/ws2/window_tree.cc
    • services/ui/ws2/window_tree.h
    • ui/aura/BUILD.gn
    • ui/aura/mus/topmost_window_tracker.cc
    • ui/aura/mus/topmost_window_tracker.h
    • ui/aura/mus/window_tree_client.cc
    • ui/aura/mus/window_tree_client.h
    • ui/aura/test/mus/test_window_tree.cc
    • ui/aura/test/mus/test_window_tree.h
  11. Orderfile: renable misordered symbol threshold in check_orderfile.py.

    Changed by Matthew Cary - mattcaryohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:09:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bdba7075443440ec9b67631bc351866397558f0e

    Comments

    Orderfile: renable misordered symbol threshold in check_orderfile.py.
    
    Bug: 873380
    Change-Id: Iaa194b57f57985a6bc851a2b826555a6d087a57c
    Reviewed-on: https://chromium-review.googlesource.com/1171234
    Commit-Queue: Matthew Cary <mattcary@chromium.org>
    Reviewed-by: Benoit L <lizeb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582409}

    Changed files

    • tools/cygprofile/check_orderfile.py
    • tools/cygprofile/check_orderfile_unittest.py
  12. Roll src/third_party/depot_tools 284b5e0c60ac..6a4e31b4882f (1 commits)

    Changed by depot-tools-chromium-autoroll - depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Saturday, 11-Aug-18 01:08:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3bb07ab082388ed8e0590614162bc1cc9f756bdb

    Comments

    Roll src/third_party/depot_tools 284b5e0c60ac..6a4e31b4882f (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/284b5e0c60ac..6a4e31b4882f
    
    
    git log 284b5e0c60ac..6a4e31b4882f --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 ehmaldonado@chromium.org gclient_scm: Add option to specify the branch the patch is based on.
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@6a4e31b4882f
    
    The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:870279
    TBR=agable@chromium.org
    
    Change-Id: I4563fb1540b017267659c6d67ca8dcbf6f3feb8f
    Reviewed-on: https://chromium-review.googlesource.com/1171443
    Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582408}

    Changed files

    • DEPS
  13. cros: Fix empty preview wallpaper description issue

    Changed by Wenzhao Zang - wzangohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:02:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a59fa8e81cbc0a8d5b5cbb61172d86a4ff4e10a

    Comments

    cros: Fix empty preview wallpaper description issue
    
    Bug: 873340
    Change-Id: Ia5979ba5305b154a27689157db573f8bc6803801
    Reviewed-on: https://chromium-review.googlesource.com/1171790
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582407}

    Changed files

    • chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js
  14. Revert "Add debug chromium bots"

    Changed by Stephen Martinis - martinissohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:59:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f3cf71cc8609b20283f2e3eeb3a378a3c51d544

    Comments

    Revert "Add debug chromium bots"
    
    This reverts commit 2db4180229db1c343018f96400d97944534b7a77.
    
    Reason for revert: Bots are purple, will reland and make sure they're green later.
    
    Original change's description:
    > Add debug chromium bots
    > 
    > These are mirrors of the existing release bots
    > 
    > Bug: 867725
    > Change-Id: I6f59d04a82103572e801273e294534e822d3e03d
    > Reviewed-on: https://chromium-review.googlesource.com/1159172
    > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
    > Reviewed-by: Nodir Turakulov <nodir@chromium.org>
    > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    > Reviewed-by: Kenneth Russell <kbr@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#582390}
    
    TBR=iannucci@chromium.org,vadimsh@chromium.org,dpranke@chromium.org,kbr@chromium.org,nodir@chromium.org,martiniss@chromium.org,jbudorick@chromium.org
    
    Change-Id: I28a27093f09db79c83239070325254df6a1a0dca
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 867725
    Reviewed-on: https://chromium-review.googlesource.com/1171430
    Reviewed-by: Stephen Martinis <martiniss@chromium.org>
    Commit-Queue: Stephen Martinis <martiniss@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582406}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
    • infra/config/global/luci-milo.cfg
    • infra/config/global/luci-scheduler.cfg
    • testing/buildbot/chromium.json
    • testing/buildbot/test_suite_exceptions.pyl
    • testing/buildbot/waterfalls.pyl
    • tools/mb/mb_config.pyl
  15. Clean up PdfCompositorImpl.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:55:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b2f31335a925a33e3fec9a7d7e765698f4cc3de3

    Comments

    Clean up PdfCompositorImpl.
    
    - Make some methods const.
    - Update some comments.
    - Remove an unimplemented method declaration.
    - Remove an unused method parameter.
    
    Change-Id: I678d740f4915b4d55d5be5fdc6482b7bac18778b
    Reviewed-on: https://chromium-review.googlesource.com/1170401
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Reviewed-by: Wei Li <weili@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582405}

    Changed files

    • components/services/pdf_compositor/pdf_compositor_impl.cc
    • components/services/pdf_compositor/pdf_compositor_impl.h
  16. [ChromeDriver] Fix version string in release branch

    Changed by John Chen - johnchenohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:52:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dbe92472c755ab9519221b35a96c1458a61293cf

    Comments

    [ChromeDriver] Fix version string in release branch
    
    The previous change (r581945) to update version string used by
    ChromeDriver in release branches didn't work, because the top-most
    commit doesn't have the necessary branch info. This CL adds the same
    commit filter used to generate the version string shown by Chrome.
    
    Bug: chromedriver:2080
    Change-Id: I4d7b57a139968d3e5e0f1ebad26d6ed648ab5d72
    Reviewed-on: https://chromium-review.googlesource.com/1171843
    Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    Commit-Queue: John Chen <johnchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582404}

    Changed files

    • chrome/test/chromedriver/embed_version_in_cpp.py
  17. Add vector of intervals range checking to Time Restrictions policy

    Changed by Adolfo Victoria - adokarohnoyoudont@google.com
    Changed at Saturday, 11-Aug-18 00:42:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b3392d988ae23dc52d9b386af47dc6a53a2d22c8

    Comments

    Add vector of intervals range checking to Time Restrictions policy
    
    * Add function GetEndOfCurrent interval to obtain the last end of the
    interval which contains the current time.
    * Add function MaterializeIntervalsToLocalTimezone, which materializes
    the given intervals to the current local timezone.
    * Add function TimeIsInsideCrosSettingsIntervals, which checks if the
    current time is inside the intervals set in cros settings. It then
    returns the localized string of the end of the interval that contains
    the current time.
    
    BUG=chromium:852860
    TEST=added unittests
    
    Change-Id: Ife32e31c8a929827fd14ab9f108c49eacb9c32c3
    Reviewed-on: https://chromium-review.googlesource.com/1132676
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582403}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/policy/device_auto_update_time_restrictions_utils.cc
    • chrome/browser/chromeos/policy/device_auto_update_time_restrictions_utils.h
    • chrome/browser/chromeos/policy/device_auto_update_time_restrictions_utils_unittest.cc
    • chrome/browser/chromeos/policy/weekly_time/time_utils.cc
    • chrome/browser/chromeos/policy/weekly_time/time_utils.h
    • chrome/browser/chromeos/policy/weekly_time/time_utils_unittest.cc
    • chrome/browser/chromeos/policy/weekly_time/weekly_time.h
    • chrome/browser/chromeos/policy/weekly_time/weekly_time_interval.h
  18. Roll src/third_party/angle 077cd858b2d4..ea926a362b77 (3 commits)

    Changed by angle-chromium-autoroll - angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Saturday, 11-Aug-18 00:41:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e4c26fa3e9b08e7dda082537ecfdc254c8d8db35

    Comments

    Roll src/third_party/angle 077cd858b2d4..ea926a362b77 (3 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/077cd858b2d4..ea926a362b77
    
    
    git log 077cd858b2d4..ea926a362b77 --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 jmadill@chromium.org Add angle_perftests README file.
    2018-08-10 jmadill@chromium.org D3D: Use angle::Result error pattern.
    2018-08-10 jmadill@chromium.org Fix AMD detection in angle_end2end_tests.
    
    
    Created with:
      gclient setdep -r src/third_party/angle@ea926a362b77
    
    The AutoRoll server is located here: https://angle-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=ynovikov@chromium.org
    
    Change-Id: I66ef52bae109017756c16854706a5a4b95d73c23
    Reviewed-on: https://chromium-review.googlesource.com/1171403
    Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582402}

    Changed files

    • DEPS
  19. Roll HarfBuzz to 1.8.7

    Changed by Emil A Eklund - eaeohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:35:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 03427d53dc8e88fbde543f6115708a98c2b9b1f0

    Comments

    Roll HarfBuzz to 1.8.7
    
    https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/2b76767bf572364d3d647cdd139f2044a7ad06b2..b6fdcf4f8bd09e065c767939125861c9dc8ff18f
    
    Tbr: drott@chromium.org
    Change-Id: Ie65cb46846224bd90ffa86517a946c44f321f2c7
    Reviewed-on: https://chromium-review.googlesource.com/1170170
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582401}

    Changed files

    • DEPS
    • third_party/harfbuzz-ng/README.chromium
  20. [ChromeDriver] Fix testWindowMinimize and remove old code

    Changed by Tatiana Buldina - buldinaohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:34:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0bd3fb604e6b8598a546503e09f4979d4590ccb8

    Comments

    [ChromeDriver] Fix testWindowMinimize and remove old code
    
    Fix a test failure in Python test case testWindowMinimize, and
    clean up code related to not supported version.
    
    Change-Id: I076cdc90cdaca322bc64530c6bb9eabe6ae9069a
    Reviewed-on: https://chromium-review.googlesource.com/1171805
    Reviewed-by: John Chen <johnchen@chromium.org>
    Commit-Queue: Tatiana Buldina <buldina@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582400}

    Changed files

    • chrome/test/chromedriver/test/run_py_tests.py
  21. Roll src/third_party/catapult 5a4110982f31..21cd5a309631 (1 commits)

    Changed by catapult-chromium-autoroll - catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Saturday, 11-Aug-18 00:34:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 24be12346d5a4ec8ebcc2c0615add14d150496e7

    Comments

    Roll src/third_party/catapult 5a4110982f31..21cd5a309631 (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/5a4110982f31..21cd5a309631
    
    
    git log 5a4110982f31..21cd5a309631 --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 dtu@chromium.org [pinpoint] Ignore comparison_magnitude == 'None' for reruns.
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@21cd5a309631
    
    The AutoRoll server is located here: https://catapult-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:873331
    TBR=sullivan@chromium.org
    
    Change-Id: Ie322f1501b9f5411006fd4d603edf90941097a93
    Reviewed-on: https://chromium-review.googlesource.com/1171404
    Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582399}

    Changed files

    • DEPS
  22. Speculative fix for GSA crashes with MediaCodec callback API.

    Changed by Dale Curtis - dalecurtisohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:32:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7feecd556d5bb5fe3bd419703709c5ce38942123

    Comments

    Speculative fix for GSA crashes with MediaCodec callback API.
    
    Prevents any calls into the native bridge once release() has been
    called on MediaCodecBridge. I've also reordered some member
    variables of the bridge to match their lifetime.
    
    BUG=873094
    TEST=none
    
    Change-Id: Iccf648275bac2d466ce62c5e4e792f9a088b09a0
    Reviewed-on: https://chromium-review.googlesource.com/1171836
    Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
    Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582398}

    Changed files

    • media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
    • media/base/android/media_codec_bridge_impl.cc
    • media/base/android/media_codec_bridge_impl.h
  23. Reduce telemetry based isolate size

    Changed by Zhenyao Mo - zmoohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:19:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1715e3f972fe31826c3aaa4eaef20d0aeb7794c6

    Comments

    Reduce telemetry based isolate size
    
    Excluding some large size data in third_party/catapult/ that are not needed
    in running the telemetry tests.
    
    R=kbr@chromium.org,nednguyen@chromium.org
    
    Change-Id: I10a1968b5a9b02415f5d7f66b33a247d64791578
    Bug: 872521
    Reviewed-on: https://chromium-review.googlesource.com/1166261
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Commit-Queue: Zhenyao Mo <zmo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582397}

    Changed files

    • chrome/test/BUILD.gn
    • tools/perf/chrome_telemetry_build/BUILD.gn
  24. [Offline pages]: Fix css class so we apply download image correctly

    Changed by Cathy Li - chiliohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:07:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d37e211bd2d980098fadcec0151bb533af6cc360

    Comments

    [Offline pages]: Fix css class so we apply download image correctly
    
    Bug: 873124
    Change-Id: I5f5f5af481e9f8e31a1dab141b9b4dac93acc121
    Reviewed-on: https://chromium-review.googlesource.com/1171742
    Reviewed-by: Peter Williamson <petewil@chromium.org>
    Commit-Queue: Cathy Li <chili@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582396}

    Changed files

    • components/neterror/resources/neterror.css
  25. Updating XTBs based on .GRDs from branch master

    Changed by Krishna Govind - govindohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:05:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision af94e466a77ac86e5f795780749c07bb886ebf60

    Comments

    Updating XTBs based on .GRDs from branch master
    
    R=amineer@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I5429bacaf530263c0fe78c4403624d6773d12866
    Reviewed-on: https://chromium-review.googlesource.com/1171858
    Reviewed-by: Krishna Govind <govind@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582395}

    Changed files

    • ash/components/strings/ash_components_strings_mr.xtb
    • ash/strings/ash_strings_ar.xtb
    • ash/strings/ash_strings_bn.xtb
    • ash/strings/ash_strings_es-419.xtb
    • ash/strings/ash_strings_fa.xtb
    • ash/strings/ash_strings_fi.xtb
    • ash/strings/ash_strings_fil.xtb
    • ash/strings/ash_strings_gu.xtb
    • ash/strings/ash_strings_hu.xtb
    • ash/strings/ash_strings_ja.xtb
    • ash/strings/ash_strings_kn.xtb
    • ash/strings/ash_strings_ko.xtb
    • ash/strings/ash_strings_lt.xtb
    • ash/strings/ash_strings_ml.xtb
    • ash/strings/ash_strings_mr.xtb
    • ash/strings/ash_strings_ru.xtb
    • ash/strings/ash_strings_ta.xtb
    • ash/strings/ash_strings_th.xtb
    • ash/strings/ash_strings_tr.xtb
    • ash/strings/ash_strings_vi.xtb
    • ash/strings/ash_strings_zh-CN.xtb
    • ash/strings/ash_strings_zh-TW.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_es-419.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fil.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hu.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ja.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ko.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_lt.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ru.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_th.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_tr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_vi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_zh-CN.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_zh-TW.xtb
    • chrome/app/resources/chromium_strings_ar.xtb
    • chrome/app/resources/generated_resources_am.xtb
    • chrome/app/resources/generated_resources_ar.xtb
    • chrome/app/resources/generated_resources_bg.xtb
    • chrome/app/resources/generated_resources_bn.xtb
    • chrome/app/resources/generated_resources_ca.xtb
    • chrome/app/resources/generated_resources_cs.xtb
    • chrome/app/resources/generated_resources_da.xtb
    • chrome/app/resources/generated_resources_de.xtb
    • chrome/app/resources/generated_resources_el.xtb
    • chrome/app/resources/generated_resources_en-GB.xtb
    • chrome/app/resources/generated_resources_es-419.xtb
    • chrome/app/resources/generated_resources_es.xtb
    • chrome/app/resources/generated_resources_et.xtb
    • chrome/app/resources/generated_resources_fa.xtb
    • chrome/app/resources/generated_resources_fi.xtb
    • chrome/app/resources/generated_resources_fil.xtb
    • chrome/app/resources/generated_resources_fr.xtb
    • chrome/app/resources/generated_resources_gu.xtb
    • chrome/app/resources/generated_resources_hi.xtb
    • chrome/app/resources/generated_resources_hr.xtb
    • chrome/app/resources/generated_resources_hu.xtb
    • chrome/app/resources/generated_resources_id.xtb
    • chrome/app/resources/generated_resources_it.xtb
    • chrome/app/resources/generated_resources_iw.xtb
    • chrome/app/resources/generated_resources_ja.xtb
    • chrome/app/resources/generated_resources_kn.xtb
    • chrome/app/resources/generated_resources_ko.xtb
    • chrome/app/resources/generated_resources_lt.xtb
    • chrome/app/resources/generated_resources_lv.xtb
    • chrome/app/resources/generated_resources_ml.xtb
    • chrome/app/resources/generated_resources_mr.xtb
    • chrome/app/resources/generated_resources_ms.xtb
    • chrome/app/resources/generated_resources_nl.xtb
    • chrome/app/resources/generated_resources_no.xtb
    • chrome/app/resources/generated_resources_pl.xtb
    • chrome/app/resources/generated_resources_pt-BR.xtb
    • chrome/app/resources/generated_resources_pt-PT.xtb
    • chrome/app/resources/generated_resources_ro.xtb
    • chrome/app/resources/generated_resources_ru.xtb
    • chrome/app/resources/generated_resources_sk.xtb
    • chrome/app/resources/generated_resources_sl.xtb
    • chrome/app/resources/generated_resources_sr.xtb
    • chrome/app/resources/generated_resources_sv.xtb
    • chrome/app/resources/generated_resources_sw.xtb
    • chrome/app/resources/generated_resources_ta.xtb
    • chrome/app/resources/generated_resources_te.xtb
    • chrome/app/resources/generated_resources_th.xtb
    • chrome/app/resources/generated_resources_tr.xtb
    • chrome/app/resources/generated_resources_uk.xtb
    • chrome/app/resources/generated_resources_vi.xtb
    • chrome/app/resources/generated_resources_zh-CN.xtb
    • chrome/app/resources/generated_resources_zh-TW.xtb
    • chrome/app/resources/google_chrome_strings_ar.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_es-419.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fil.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_gu.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hu.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ja.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_kn.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ko.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_lt.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ml.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_mr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ru.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ta.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_th.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_tr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_vi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-CN.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-TW.xtb
    • chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_bn.xtb
    • chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_fa.xtb
    • components/policy/resources/policy_templates_am.xtb
    • components/policy/resources/policy_templates_ar.xtb
    • components/policy/resources/policy_templates_bg.xtb
    • components/policy/resources/policy_templates_bn.xtb
    • components/policy/resources/policy_templates_ca.xtb
    • components/policy/resources/policy_templates_cs.xtb
    • components/policy/resources/policy_templates_da.xtb
    • components/policy/resources/policy_templates_de.xtb
    • components/policy/resources/policy_templates_el.xtb
    • components/policy/resources/policy_templates_en-GB.xtb
    • components/policy/resources/policy_templates_es-419.xtb
    • components/policy/resources/policy_templates_es.xtb
    • components/policy/resources/policy_templates_et.xtb
    • components/policy/resources/policy_templates_fa.xtb
    • components/policy/resources/policy_templates_fi.xtb
    • components/policy/resources/policy_templates_fil.xtb
    • components/policy/resources/policy_templates_fr.xtb
    • components/policy/resources/policy_templates_gu.xtb
    • components/policy/resources/policy_templates_hi.xtb
    • components/policy/resources/policy_templates_hr.xtb
    • components/policy/resources/policy_templates_hu.xtb
    • components/policy/resources/policy_templates_id.xtb
    • components/policy/resources/policy_templates_it.xtb
    • components/policy/resources/policy_templates_iw.xtb
    • components/policy/resources/policy_templates_ja.xtb
    • components/policy/resources/policy_templates_kn.xtb
    • components/policy/resources/policy_templates_ko.xtb
    • components/policy/resources/policy_templates_lt.xtb
    • components/policy/resources/policy_templates_lv.xtb
    • components/policy/resources/policy_templates_ml.xtb
    • components/policy/resources/policy_templates_mr.xtb
    • components/policy/resources/policy_templates_ms.xtb
    • components/policy/resources/policy_templates_nl.xtb
    • components/policy/resources/policy_templates_no.xtb
    • components/policy/resources/policy_templates_pl.xtb
    • components/policy/resources/policy_templates_pt-BR.xtb
    • components/policy/resources/policy_templates_pt-PT.xtb
    • components/policy/resources/policy_templates_ro.xtb
    • components/policy/resources/policy_templates_ru.xtb
    • components/policy/resources/policy_templates_sk.xtb
    • components/policy/resources/policy_templates_sl.xtb
    • components/policy/resources/policy_templates_sr.xtb
    • components/policy/resources/policy_templates_sv.xtb
    • components/policy/resources/policy_templates_sw.xtb
    • components/policy/resources/policy_templates_ta.xtb
    • components/policy/resources/policy_templates_te.xtb
    • components/policy/resources/policy_templates_th.xtb
    • components/policy/resources/policy_templates_tr.xtb
    • components/policy/resources/policy_templates_uk.xtb
    • components/policy/resources/policy_templates_vi.xtb
    • components/policy/resources/policy_templates_zh-CN.xtb
    • components/policy/resources/policy_templates_zh-TW.xtb
    • components/strings/components_strings_am.xtb
    • components/strings/components_strings_ar.xtb
    • components/strings/components_strings_bg.xtb
    • components/strings/components_strings_bn.xtb
    • components/strings/components_strings_ca.xtb
    • components/strings/components_strings_cs.xtb
    • components/strings/components_strings_da.xtb
    • components/strings/components_strings_de.xtb
    • components/strings/components_strings_el.xtb
    • components/strings/components_strings_en-GB.xtb
    • components/strings/components_strings_es-419.xtb
    • components/strings/components_strings_es.xtb
    • components/strings/components_strings_et.xtb
    • components/strings/components_strings_fa.xtb
    • components/strings/components_strings_fi.xtb
    • components/strings/components_strings_fil.xtb
    • components/strings/components_strings_fr.xtb
    • components/strings/components_strings_gu.xtb
    • components/strings/components_strings_hi.xtb
    • components/strings/components_strings_hr.xtb
    • components/strings/components_strings_hu.xtb
    • components/strings/components_strings_id.xtb
    • components/strings/components_strings_it.xtb
    • components/strings/components_strings_iw.xtb
    • components/strings/components_strings_ja.xtb
    • components/strings/components_strings_kn.xtb
    • components/strings/components_strings_ko.xtb
    • components/strings/components_strings_lt.xtb
    • components/strings/components_strings_lv.xtb
    • components/strings/components_strings_ml.xtb
    • components/strings/components_strings_mr.xtb
    • components/strings/components_strings_ms.xtb
    • components/strings/components_strings_nl.xtb
    • components/strings/components_strings_no.xtb
    • components/strings/components_strings_pl.xtb
    • components/strings/components_strings_pt-BR.xtb
    • components/strings/components_strings_pt-PT.xtb
    • components/strings/components_strings_ro.xtb
    • components/strings/components_strings_ru.xtb
    • components/strings/components_strings_sk.xtb
    • components/strings/components_strings_sl.xtb
    • components/strings/components_strings_sr.xtb
    • components/strings/components_strings_sv.xtb
    • components/strings/components_strings_sw.xtb
    • components/strings/components_strings_ta.xtb
    • components/strings/components_strings_te.xtb
    • components/strings/components_strings_th.xtb
    • components/strings/components_strings_tr.xtb
    • components/strings/components_strings_uk.xtb
    • components/strings/components_strings_vi.xtb
    • components/strings/components_strings_zh-CN.xtb
    • components/strings/components_strings_zh-TW.xtb
    • content/app/strings/translations/content_strings_es.xtb
    • content/app/strings/translations/content_strings_fi.xtb
    • content/app/strings/translations/content_strings_mr.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_es-419.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_fi.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_fil.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_gu.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_hu.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ja.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_kn.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ko.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_lt.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ml.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_mr.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_pl.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ru.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ta.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_th.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_tr.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_vi.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_zh-CN.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_zh-TW.xtb
    • ios/chrome/app/strings/resources/ios_google_chrome_strings_pl.xtb
    • ios/chrome/app/strings/resources/ios_strings_am.xtb
    • ios/chrome/app/strings/resources/ios_strings_ar.xtb
    • ios/chrome/app/strings/resources/ios_strings_bg.xtb
    • ios/chrome/app/strings/resources/ios_strings_bn.xtb
    • ios/chrome/app/strings/resources/ios_strings_ca.xtb
    • ios/chrome/app/strings/resources/ios_strings_cs.xtb
    • ios/chrome/app/strings/resources/ios_strings_da.xtb
    • ios/chrome/app/strings/resources/ios_strings_de.xtb
    • ios/chrome/app/strings/resources/ios_strings_el.xtb
    • ios/chrome/app/strings/resources/ios_strings_en-GB.xtb
    • ios/chrome/app/strings/resources/ios_strings_es-419.xtb
    • ios/chrome/app/strings/resources/ios_strings_es.xtb
    • ios/chrome/app/strings/resources/ios_strings_et.xtb
    • ios/chrome/app/strings/resources/ios_strings_fa.xtb
    • ios/chrome/app/strings/resources/ios_strings_fi.xtb
    • ios/chrome/app/strings/resources/ios_strings_fil.xtb
    • ios/chrome/app/strings/resources/ios_strings_fr.xtb
    • ios/chrome/app/strings/resources/ios_strings_gu.xtb
    • ios/chrome/app/strings/resources/ios_strings_hi.xtb
    • ios/chrome/app/strings/resources/ios_strings_hr.xtb
    • ios/chrome/app/strings/resources/ios_strings_hu.xtb
    • ios/chrome/app/strings/resources/ios_strings_id.xtb
    • ios/chrome/app/strings/resources/ios_strings_it.xtb
    • ios/chrome/app/strings/resources/ios_strings_iw.xtb
    • ios/chrome/app/strings/resources/ios_strings_ja.xtb
    • ios/chrome/app/strings/resources/ios_strings_kn.xtb
    • ios/chrome/app/strings/resources/ios_strings_ko.xtb
    • ios/chrome/app/strings/resources/ios_strings_lt.xtb
    • ios/chrome/app/strings/resources/ios_strings_lv.xtb
    • ios/chrome/app/strings/resources/ios_strings_ml.xtb
    • ios/chrome/app/strings/resources/ios_strings_mr.xtb
    • ios/chrome/app/strings/resources/ios_strings_ms.xtb
    • ios/chrome/app/strings/resources/ios_strings_nl.xtb
    • ios/chrome/app/strings/resources/ios_strings_no.xtb
    • ios/chrome/app/strings/resources/ios_strings_pl.xtb
    • ios/chrome/app/strings/resources/ios_strings_pt-BR.xtb
    • ios/chrome/app/strings/resources/ios_strings_pt-PT.xtb
    • ios/chrome/app/strings/resources/ios_strings_ro.xtb
    • ios/chrome/app/strings/resources/ios_strings_ru.xtb
    • ios/chrome/app/strings/resources/ios_strings_sk.xtb
    • ios/chrome/app/strings/resources/ios_strings_sl.xtb
    • ios/chrome/app/strings/resources/ios_strings_sr.xtb
    • ios/chrome/app/strings/resources/ios_strings_sv.xtb
    • ios/chrome/app/strings/resources/ios_strings_sw.xtb
    • ios/chrome/app/strings/resources/ios_strings_ta.xtb
    • ios/chrome/app/strings/resources/ios_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_strings_th.xtb
    • ios/chrome/app/strings/resources/ios_strings_tr.xtb
    • ios/chrome/app/strings/resources/ios_strings_uk.xtb
    • ios/chrome/app/strings/resources/ios_strings_vi.xtb
    • ios/chrome/app/strings/resources/ios_strings_zh-CN.xtb
    • ios/chrome/app/strings/resources/ios_strings_zh-TW.xtb
  26. Add the PageAlmostIdleAndLocalDB experiment to fieldtrial_testing_config.json

    Changed by Sebastien Marchand - sebmarchandohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:04:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fad3162e6ad14ef32cacf0e2e05e474d91041d87

    Comments

    Add the PageAlmostIdleAndLocalDB experiment to fieldtrial_testing_config.json
    
    This moves the PageAlmostIdle and SiteCharacteristicsDatabase features to their
    own experiment so they can easily be shipped to Beta only.
    
    Change-Id: I56c65e4ffb8b389b502a8c03d661ca2c26a66abe
    Reviewed-on: https://chromium-review.googlesource.com/1168107
    Reviewed-by: Chris Hamilton <chrisha@chromium.org>
    Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
    Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582394}

    Changed files

    • testing/variations/fieldtrial_testing_config.json
  27. Add a new type of shelf status/indicator for "active" status

    Changed by Manu Cornet - manucornetohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:04:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b12dd997dd70b06c806c89e16cbf1302eacbd972

    Comments

    Add a new type of shelf status/indicator for "active" status
    
    This will allow us to differentiate between "running" and "active".
    The logic to set this properly depending on status will come in a
    separate CL.
    
    Note that no shelf item is ever marked as STATUS_ACTIVE yet, so
    this CL has no effect on behavior.
    
    Bug: 805612
    Change-Id: I50f985d66659bd35e2b59ab19a898ae5a3634179
    Reviewed-on: https://chromium-review.googlesource.com/1170394
    Commit-Queue: Manu Cornet <manucornet@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582393}

    Changed files

    • ash/public/cpp/shelf_struct_mojom_traits.h
    • ash/public/cpp/shelf_types.h
    • ash/public/interfaces/shelf.mojom
    • ash/shelf/shelf_button.cc
    • ash/shelf/shelf_button.h
    • ash/shelf/shelf_view.cc
  28. Run WebGL 2.0 tests on passthrough cmd decoder on Linux/Intel.

    Changed by Kenneth Russell - kbrohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:01:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c7862cb6e7b0be134f2373e3dae5af8d0f6dc64

    Comments

    Run WebGL 2.0 tests on passthrough cmd decoder on Linux/Intel.
    
    It looks like an oversight that they weren't run on this configuration
    previously.
    
    Tbr: geofflang@chromium.org
    Bug: 872302
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I77e4e175a449cea70254dcc3bab8ea3686fc74d9
    Reviewed-on: https://chromium-review.googlesource.com/1168464
    Reviewed-by: Geoff Lang <geofflang@chromium.org>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582392}

    Changed files

    • testing/buildbot/chromium.gpu.fyi.json
    • testing/buildbot/waterfalls.pyl
  29. Fix new tab animation from tab switcher in Duet

    Changed by Matthew Jones - mdjonesohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:00:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9226b58bb77c84fd444da9d423199356bea96673

    Comments

    Fix new tab animation from tab switcher in Duet
    
    This patch changes the container that the new tab animation runs in
    when Duet is enabled. The container changes position from running on
    top of the toolbars to running beneath them (since the bottom toolbar
    is a persistent fixture). This would negatively impact the top toolbar
    if there were still icons there (since the top toolbar has an
    appearance animation to compensate for the tab appearing on top of
    it). However, since there are no icons, it is not an issue.
    
    Bug: 852012
    Change-Id: I19422b70844f3fd45e7d9318a3c9c9768b407991
    Reviewed-on: https://chromium-review.googlesource.com/1171819
    Commit-Queue: Matthew Jones <mdjones@chromium.org>
    Reviewed-by: Pedro Amaral <amaralp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582391}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayoutBase.java
  30. Add debug chromium bots

    Changed by Stephen Martinis - martinissohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:58:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2db4180229db1c343018f96400d97944534b7a77

    Comments

    Add debug chromium bots
    
    These are mirrors of the existing release bots
    
    Bug: 867725
    Change-Id: I6f59d04a82103572e801273e294534e822d3e03d
    Reviewed-on: https://chromium-review.googlesource.com/1159172
    Commit-Queue: Stephen Martinis <martiniss@chromium.org>
    Reviewed-by: Nodir Turakulov <nodir@chromium.org>
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582390}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
    • infra/config/global/luci-milo.cfg
    • infra/config/global/luci-scheduler.cfg
    • testing/buildbot/chromium.json
    • testing/buildbot/test_suite_exceptions.pyl
    • testing/buildbot/waterfalls.pyl
    • tools/mb/mb_config.pyl
  31. Fix crash that can occur when sharing temporary offline pages

    Changed by Pete Williamson - petewilohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:52:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9603793bf71d4fcce938bb0481dee2448cb5dc27

    Comments

    Fix crash that can occur when sharing temporary offline pages
    
    Sometimes when sharing temporary offline pages, we fail to create the
    content URI.  If we do, fall back to sharing by URL with the URL of the page.
    
    Bug: 871697
    Change-Id: Ie2e895fd708fdf4e5e992ebc2317ee49fd5bcee3
    Reviewed-on: https://chromium-review.googlesource.com/1168587
    Reviewed-by: Yafei Duan <romax@chromium.org>
    Commit-Queue: Peter Williamson <petewil@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582389}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
  32. [Unity][Android] Update margins in sign-in and consent bump screens

    Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:41:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fff9a68b5bd9965a4690f5d21104529adad34afc

    Comments

    [Unity][Android] Update margins in sign-in and consent bump screens
    
    This CL updates the layout of the streamlined sign-in screen and the
    consent bump screen to accommodate last changes to mocks.
    
    Bug: 814728
    Change-Id: If8f2cdaf39ba175ca60584f9015a4b2ccaf23217
    Reviewed-on: https://chromium-review.googlesource.com/1171226
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582388}

    Changed files

    • chrome/android/java/res/layout/consent_bump_more_options_view.xml
    • chrome/android/java/res/layout/signin_view.xml
    • chrome/android/java/res/values/dimens.xml
  33. Remove is_ready variables in PdfCompositorImplTest.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:41:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f2ae2bec992432aafcbcb760f7efe56aaa423f90

    Comments

    Remove is_ready variables in PdfCompositorImplTest.
    
    Change-Id: I3c0930f22e7ff3ff72611bfb70415b3e122f398e
    Reviewed-on: https://chromium-review.googlesource.com/1171378
    Reviewed-by: Wei Li <weili@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582387}

    Changed files

    • components/services/pdf_compositor/pdf_compositor_impl_unittest.cc
  34. [NTP] Fix arrow navigation order of the restore default options

    Changed by kristipark - kristiparkohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:37:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f7c77a5b154fdb9105958e026f285742b8cef125

    Comments

    [NTP] Fix arrow navigation order of the restore default options
    
    The "Restore default shortcuts" and "Restore default background" options
    are swapped when navigating with arrow keys.
    
    Bug: 872978
    Change-Id: I6078a6fb0a004a81e321a39f08e1f024bf53e9e1
    Reviewed-on: https://chromium-review.googlesource.com/1170195
    Commit-Queue: Kristi Park <kristipark@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582386}

    Changed files

    • chrome/browser/resources/local_ntp/custom_backgrounds.js
  35. [Explore Sites] Create a keyed service.

    Changed by Justin DeWitt - dewittjohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:32:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 40f76ee9d98b9b20c8fd7997786fa11e4352cee8

    Comments

    [Explore Sites] Create a keyed service.
    
    This will host the ExploreSites datastore as well as the downloader.
    
    BUG=867488
    
    Change-Id: Ifff84b6c8316033929ccbd52c32c2f175af117c8
    Reviewed-on: https://chromium-review.googlesource.com/1169588
    Reviewed-by: Cathy Li <chili@chromium.org>
    Commit-Queue: Justin DeWitt <dewittj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582385}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/android/explore_sites/explore_sites_service.h
    • chrome/browser/android/explore_sites/explore_sites_service_factory.cc
    • chrome/browser/android/explore_sites/explore_sites_service_factory.h
    • chrome/browser/android/explore_sites/explore_sites_service_impl.cc
    • chrome/browser/android/explore_sites/explore_sites_service_impl.h
  36. Fix misspelling "existance"

    Changed by Wei-Yin Chen (陳威尹) - wychenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:31:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fec2acecd6a5c82ae15b48fca7d1aa14de1650f4

    Comments

    Fix misspelling "existance"
    
    third_party/ is excluded, except for third_party/WebKit and
    third_party/blink.
    
    This is uncovered by:
    https://chromium-swarm.appspot.com/task?id=3f2afb7b4290f910
    
    Bug: None
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ie17ea50e7f6aba3538acb488df92b4926b52f4c4
    Reviewed-on: https://chromium-review.googlesource.com/1170441
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582384}

    Changed files

    • .gn
    • cc/layers/texture_layer_impl.h
    • cc/trees/layer_tree_settings.h
    • components/metrics/persistent_system_profile.h
    • ios/chrome/browser/ui/browser_view_controller.mm
    • third_party/WebKit/LayoutTests/external/wpt/user-timing/measure.html
    • third_party/WebKit/LayoutTests/external/wpt/user-timing/measure_navigation_timing.html
    • third_party/WebKit/LayoutTests/http/tests/devtools/extensions/multiple-extensions-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/devtools/extensions/multiple-extensions.js
    • third_party/WebKit/LayoutTests/jquery/resources/test/unit/traversing.js
    • third_party/blink/renderer/modules/webdatabase/sqlite/sqlite_file_system_posix.cc
    • third_party/blink/renderer/modules/webdatabase/sqlite/sqlite_file_system_win.cc
    • third_party/blink/renderer/modules/xr/xr_device.cc
    • tools/chrome_proxy/webdriver/protocol_fuzz.py
  37. [ios] Add accessibility identifier for "show history" cell in Recent Tabs

    Changed by Chris Lu - thegreenfrogohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:30:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2bef755ef86d5e4e225a5f70a58858a9078e095f

    Comments

    [ios] Add accessibility identifier for "show history" cell in Recent Tabs
    
    Change-Id: Ib6bcee51114a9fcb05aacd9079d52b65356e18d2
    Reviewed-on: https://chromium-review.googlesource.com/1171680
    Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
    Reviewed-by: Sergio Collazos <sczs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582383}

    Changed files

    • ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_constants.h
    • ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_constants.mm
    • ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm
    • ios/chrome/browser/ui/table_view/cells/table_view_accessory_item.h
    • ios/chrome/browser/ui/table_view/cells/table_view_accessory_item.mm
  38. Roll src/third_party/pdfium e1a7e8589a8c..f36a4644b828 (7 commits)

    Changed by pdfium-chromium-autoroll - pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Friday, 10-Aug-18 23:29:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision afe7c7414699ca66dbf49b162ab2c49083889a4d

    Comments

    Roll src/third_party/pdfium e1a7e8589a8c..f36a4644b828 (7 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/e1a7e8589a8c..f36a4644b828
    
    
    git log e1a7e8589a8c..f36a4644b828 --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 rharrison@chromium.org Remove direct calls to time
    2018-08-10 rharrison@chromium.org Add proxy for syscall time
    2018-08-10 tsepez@chromium.org Remove |typedef struct| in favor of just |struct|.
    2018-08-10 tsepez@chromium.org Consolidate const_casts<> in FXFT_Get_Name_Index()
    2018-08-10 thestig@chromium.org Make CFX_ImageTransformer::CalcData's bitmap non-const.
    2018-08-10 thestig@chromium.org Fix a JBIG2 decoding regression.
    2018-08-10 thestig@chromium.org Remove deprecated flags from fpdf_progressive.h.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@f36a4644b828
    
    The AutoRoll server is located here: https://pdfium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:871848
    TBR=dsinclair@chromium.org
    
    Change-Id: I22721ff61265f49fddd6ffc647ef37cc2f70bc0c
    Reviewed-on: https://chromium-review.googlesource.com/1171442
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582382}

    Changed files

    • DEPS
  39. Increase shards for android buildbot

    Changed by Takuto Ikuta - tikutaohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:26:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 091a32d416d74d48bcaec9693c0ae2589bc2b986

    Comments

    Increase shards for android buildbot
    
    I increased shards for some tests took time on
    https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel/59189
    
    Bug: 868114
    Change-Id: I9ae5c80e0fe641f8946e0d00d8a322721d2de079
    Reviewed-on: https://chromium-review.googlesource.com/1170922
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582381}

    Changed files

    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/test_suites.pyl
  40. Replaced calls to LayoutObject.Style() with LayoutObject.StyleRef().

    Changed by Mason Freed - masonfreedohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 23:14:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 95e719856c142dd807b287f535e3a597c3112e5e

    Comments

    Replaced calls to LayoutObject.Style() with LayoutObject.StyleRef().
    
    Especially within paint, most calls to LayoutObject.Style() are assuming a non-null pointer and
    dereferencing it. To better document the fact that these calls (properly, in most cases)
    assume the layout object contains style, they should be replaced with calls to the StyleRef()
    function, which dereferences the pointer.
    
    Bug: 872508
    Change-Id: Id6a04871c12a2c09d1029ca5aa04ae49099f7fd0
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Reviewed-on: https://chromium-review.googlesource.com/1171144
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Commit-Queue: Mason Freed <masonfreed@google.com>
    Cr-Commit-Position: refs/heads/master@{#582380}

    Changed files

    • third_party/blink/renderer/core/paint/block_painter.cc
    • third_party/blink/renderer/core/paint/box_painter.cc
    • third_party/blink/renderer/core/paint/collapsed_border_painter.cc
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
    • third_party/blink/renderer/core/paint/compositing/compositing_layer_assigner.cc
    • third_party/blink/renderer/core/paint/compositing/compositing_reason_finder.cc
    • third_party/blink/renderer/core/paint/compositing/compositing_requirements_updater.cc
    • third_party/blink/renderer/core/paint/css_mask_painter.cc
    • third_party/blink/renderer/core/paint/details_marker_painter.cc
    • third_party/blink/renderer/core/paint/fieldset_painter.cc
    • third_party/blink/renderer/core/paint/file_upload_control_painter.cc
    • third_party/blink/renderer/core/paint/inline_flow_box_painter.cc
    • third_party/blink/renderer/core/paint/inline_text_box_painter.cc
    • third_party/blink/renderer/core/paint/link_highlight_impl.cc
    • third_party/blink/renderer/core/paint/list_marker_painter.cc
    • third_party/blink/renderer/core/paint/multi_column_set_painter.cc
    • third_party/blink/renderer/core/paint/paint_layer.cc
    • third_party/blink/renderer/core/paint/paint_layer.h
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • third_party/blink/renderer/core/paint/replaced_painter.cc
    • third_party/blink/renderer/core/paint/root_inline_box_painter.cc
    • third_party/blink/renderer/core/paint/scrollable_area_painter.cc
    • third_party/blink/renderer/core/paint/svg_image_painter.cc
    • third_party/blink/renderer/core/paint/svg_inline_text_box_painter.cc
    • third_party/blink/renderer/core/paint/svg_model_object_painter.cc
    • third_party/blink/renderer/core/paint/svg_shape_painter.cc
    • third_party/blink/renderer/core/paint/table_cell_painter.cc
    • third_party/blink/renderer/core/paint/table_painter.cc
    • third_party/blink/renderer/core/paint/view_painter.cc
  41. Retire SampleOrderingSpec::PRESERVE_ORDER as it's not used

    Changed by Xi Cheng - chengxohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:13:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fea7ed541cd675d0ac5d17b2f8fcd6ac82edcffc

    Comments

    Retire SampleOrderingSpec::PRESERVE_ORDER as it's not used
    
    Since SampleOrderingSpec::MAY_SHUFFLE is the only one used in production
    code, there is no need to specify the SampleOrderingSpec parameter hence
    SampleOrderingSpec enum is also retired.
    
    Bug: 851163
    Change-Id: Ie9bf7c39d036db55b1533c4fe3b3f3293a2a8dbf
    Reviewed-on: https://chromium-review.googlesource.com/1171584
    Commit-Queue: Xi Cheng <chengx@chromium.org>
    Reviewed-by: Mike Wittman <wittman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582379}

    Changed files

    • chrome/common/thread_profiler.cc
    • components/metrics/call_stack_profile_builder.cc
    • components/metrics/call_stack_profile_builder_unittest.cc
    • components/metrics/call_stack_profile_params.h
    • components/metrics/call_stack_profile_proto_encoder.cc
    • components/metrics/call_stack_profile_proto_encoder.h
    • components/metrics/call_stack_profile_proto_encoder_unittest.cc
  42. CATransactionGPUCoordinator: Re-enable and make lifetime explicit

    Changed by Christopher Cameron - ccameronohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:10:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 62892558b716d1560264e42929e2be01ead07e71

    Comments

    CATransactionGPUCoordinator: Re-enable and make lifetime explicit
    
    Disalbing the CATransactionGPUCoordinator caused memory corruption bugs
    to go away.
    
    Fix two potential bugs:
    
    1.  Don't post tasks (and potentially change the reference count) inside
        CATransactionGPUCoordinator's constructor. Do this in a separate
        explicit Init function.
    
    1a. Move this initialization to the end of GpuProcessHost:Init (instead
        of being at the beginning of the constructor).
    
    2.  Make CATransactionCoordinator explicitly retain PostCommitObserver
        (which includes CATransactionGPUCoordinator). This fixes a bug
        whereby at shutdown, destroying not-yet-executed posted tasks caused
        the CATransactionGPUCoordinator to be destroyed while the
        CATransactionCoordinator still had a raw pointer to it.
    
    Bug: 871430
    Change-Id: Ie144071cce9ce48e0187cdaf1fcf32df7b62ed75
    Reviewed-on: https://chromium-review.googlesource.com/1171657
    Commit-Queue: ccameron <ccameron@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582378}

    Changed files

    • content/browser/gpu/ca_transaction_gpu_coordinator.cc
    • content/browser/gpu/ca_transaction_gpu_coordinator.h
    • content/browser/gpu/gpu_process_host.cc
    • ui/accelerated_widget_mac/ca_transaction_observer.h
    • ui/accelerated_widget_mac/ca_transaction_observer.mm
  43. [TTS] Remove unused DEPS file.

    Changed by Donn Denman - donndohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:57:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b54b3b3f4c92fac9a597039d7026120e4769a5d4

    Comments

    [TTS] Remove unused DEPS file.
    
    Change-Id: I100542f77eb1ebebf28db6c716733467be61c209
    Reviewed-on: https://chromium-review.googlesource.com/1168503
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Donn Denman <donnd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582377}

    Changed files

    • components/contextual_search/browser/DEPS
  44. Fix a typo in documentation.

    Changed by Eric Roman - eromanohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:56:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8c3c53b6d5652202ab79edad721a4a04fb0ccb79

    Comments

    Fix a typo in documentation.
    
    Change-Id: Ibbde1b31fdeade51caf0cb70fefbe915bd7a9af6
    Reviewed-on: https://chromium-review.googlesource.com/1169693
    Commit-Queue: Eric Roman <eroman@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582376}

    Changed files

    • mojo/public/cpp/bindings/callback_helpers.h
  45. Increase DevTools SystemInfoGPU timeout for Windows.

    Changed by Erik Chen - erikchenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:55:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1c9cf51bc70b424ce8d9849d24c115a7f6930772

    Comments

    Increase DevTools SystemInfoGPU timeout for Windows.
    
    Before this CL, DevTools would crash the browser if it did not get a response in
    5 seconds. This timeout is too low for Windows. On Catapult perf tests on
    Windows, it takes ~3 seconds for the GPU process to respond on average, and
    sometimes it takes more than 5 seconds.
    
    Bug: 873112
    Change-Id: I67ee82a1a75df0ba9e1b483a58c66c56a8bf2213
    Reviewed-on: https://chromium-review.googlesource.com/1170584
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582375}

    Changed files

    • content/browser/devtools/protocol/system_info_handler.cc
  46. cros: Add common fingerprint images in ui/chromeos/resources.

    Changed by Sarah Hu - xiaoyinhohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:49:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ccd841a0bbf56f3ddc4ebfbf2430404da75a86f

    Comments

    cros: Add common fingerprint images in ui/chromeos/resources.
    
    This will be used by both oobe and settings.
    
    Bug: 873229
    Change-Id: I1bb3ff8e9666e967ff5445d68085801d009894d5
    Reviewed-on: https://chromium-review.googlesource.com/1171243
    Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
    Reviewed-by: Dan Erat <derat@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582374}

    Changed files

    • ui/chromeos/resources/default_100_percent/fingerprint/fingerprint.png
    • ui/chromeos/resources/default_100_percent/fingerprint/fingerprint_scanner.png
    • ui/chromeos/resources/default_100_percent/fingerprint/tick.png
    • ui/chromeos/resources/default_200_percent/fingerprint/fingerprint.png
    • ui/chromeos/resources/default_200_percent/fingerprint/fingerprint_scanner.png
    • ui/chromeos/resources/default_200_percent/fingerprint/tick.png
    • ui/chromeos/resources/ui_chromeos_resources.grd
  47. [TaskScheduler] Cleanup all remaining base/task_scheduler references for realz

    Changed by Gabriel Charette - gabohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:48:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6bf388aef924443453385373971d022f03652981

    Comments

    [TaskScheduler] Cleanup all remaining base/task_scheduler references for realz
    
    https://cs.chromium.org/search/?q=%22base/task_scheduler%22&sq=package:chromium&type=cs
    will be empty after this CL
    
    TBR=fdoray@chromium.org
    
    Change-Id: I636ff813e461379acfb2822f58034cdd756e7d49
    Reviewed-on: https://chromium-review.googlesource.com/1171108
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Reviewed-by: Robert Liao <robliao@chromium.org>
    Reviewed-by: François Doray <fdoray@chromium.org>
    Commit-Queue: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582373}

    Changed files

    • WATCHLISTS
    • base/task/task_scheduler/task_scheduler.h
  48. [omnibox/drive] Updates for /v1beta -> /v1 api migration.

    Changed by Travis Skare - skareohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:48:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4cf7e0b53900f489bcfb7bd7db7b356cfb31d2e5

    Comments

    [omnibox/drive] Updates for /v1beta -> /v1 api migration.
    
    -Use originalURL if provided to dedupe against history.
    -Fix "typo" for corpus restrict request param (I missed it was renamed).
    -Sanitize title, provide default match data.
    
    Bug: 873290
    Change-Id: Idc2d0dd92a6afedc7086c283fe85bb4257a800d3
    Reviewed-on: https://chromium-review.googlesource.com/1171550
    Reviewed-by: Tommy Li <tommycli@chromium.org>
    Commit-Queue: Travis Skare <skare@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582372}

    Changed files

    • components/omnibox/browser/document_provider.cc
    • components/omnibox/browser/document_suggestions_service.cc
  49. [Cast discovery] Reset device lister on ForceDiscovery / user gesture.

    Changed by Derek Cheng - imchengohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:47:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 485629bea392f67ff70fcbed5007f2f91b171737

    Comments

    [Cast discovery] Reset device lister on ForceDiscovery / user gesture.
    
    We've seen cases where Cast discovery code fails to pick up services
    from the ServiceDiscoveryDeviceLister, whereas chrome://inspect
    (CastDeviceProvider) is able to do so. Since Cast discovery's
    ServiceDiscoveryDeviceLister is only created once and is long-lived,
    this suggests it has gone into a bad state after a prolonged period.
    Compared to the CastDeviceProvider's ServiceDiscoveryDeviceLister,
    which gets created/destroyed when the inspect page is loaded/unloaded.
    
    To mitigate this issue, this patch uses the ForceDiscovery() signal to
    recreate a new ServiceDiscoveryDeviceLister in DnsSdDeviceLister
    and kick off the discovery using the new object, and to clear the set
    of services in the cache. This puts DnsSdDeviceLister in a clean state
    which will the current set of services to get through to the Cast
    discovery code.
    
    Bug: 850770
    Change-Id: I3183e9d80f1a4a047b607fe5f844cdfc892f1463
    Reviewed-on: https://chromium-review.googlesource.com/1166022
    Commit-Queue: Derek Cheng <imcheng@chromium.org>
    Reviewed-by: mark a. foltz <mfoltz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582371}

    Changed files

    • chrome/browser/extensions/api/mdns/mdns_api.cc
    • chrome/browser/extensions/api/mdns/mdns_apitest.cc
    • chrome/browser/media/router/discovery/mdns/cast_media_sink_service.cc
    • chrome/browser/media/router/discovery/mdns/cast_media_sink_service_unittest.cc
    • chrome/browser/media/router/discovery/mdns/dns_sd_device_lister.cc
    • chrome/browser/media/router/discovery/mdns/dns_sd_device_lister.h
    • chrome/browser/media/router/discovery/mdns/dns_sd_registry.cc
    • chrome/browser/media/router/discovery/mdns/dns_sd_registry.h
    • chrome/browser/media/router/discovery/mdns/dns_sd_registry_unittest.cc
    • chrome/browser/media/router/test/mock_dns_sd_registry.h
  50. assistant: fix unitialized read

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:46:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 492cb6c0acd8a7714cd8d298d8d8bd83e65edc5d

    Comments

    assistant: fix unitialized read
    
    VisibilityChanged() tests the is_visible_ member before it's been set to any
    value.
    
    BUG=none
    TEST=none
    TBR=xiaohuic@chromium.org
    
    Change-Id: Ic2e95e1f5e615f1621431ab0bd2b8126bcfb87d2
    Reviewed-on: https://chromium-review.googlesource.com/1171553
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582370}

    Changed files

    • ash/assistant/ui/main_stage/assistant_progress_indicator.h
  51. fido/mac: look up credential IDs before proceeding with GetAssertion requests

    Changed by Martin Kreichgauer - martinkrohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 22:46:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a4ac527a4777da75ba6c44ed4a7e1837ed92693d

    Comments

    fido/mac: look up credential IDs before proceeding with GetAssertion requests
    
    This changes the GetAssertion operation for the Touch ID authenticator
    to locate credential IDs in the keychain at the beginning of the
    request. If no matching credential exists, the user is not prompted for
    a fingerprint. A method to locate a credential by ID is extracted from
    the existing code and moved into the Keychain class.
    
    This is done in anticipation of adding the WebAuthn UI. With the new UI,
    GetAssertion requests will only be sent to the Touch ID authenticator,
    if we know a matching credential ID to exist in the keychain.
    
    Bug: 871370
    
    Change-Id: Ie5e4916df2a68bc0e9d7552322d6b993069ce95b
    Reviewed-on: https://chromium-review.googlesource.com/1163927
    Commit-Queue: Martin Kreichgauer <martinkr@google.com>
    Reviewed-by: Balazs Engedy <engedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582369}

    Changed files

    • device/fido/mac/get_assertion_operation.h
    • device/fido/mac/get_assertion_operation.mm
    • device/fido/mac/keychain.h
    • device/fido/mac/keychain.mm
    • device/fido/mac/operation_base.h
  52. Android: Update Android Studio canary version

    Changed by Peter Wen - wnwenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:45:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31634c4f1eae7d2fbac13a7542a0c939417d62f4

    Comments

    Android: Update Android Studio canary version
    
    Bug: 620034
    Change-Id: I33a4437e3fe54f9b7d7ce234a823d4bb05c2046b
    Reviewed-on: https://chromium-review.googlesource.com/1169425
    Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
    Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582368}

    Changed files

    • build/android/gradle/root.jinja
  53. cc: Increase layer tree test timeout for CFI

    Changed by Adrienne Walker - enneohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:44:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d3df98f1195e5772ddbb2e369527e7fa3a920ce9

    Comments

    cc: Increase layer tree test timeout for CFI
    
    Also, generally increase the timeout for layer tree tests.  Most things
    don't need this, however the GL versions of pixel tests end up spending
    quite a bit of time to compile shaders.  When run in parallel, this
    only exacerbates the problem and tests can time out.  Be more generous
    so that folks stop turning off these tests.
    
    Bug: 872733
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I7c08212d454bf0d9ae6ea445fcb46b48b73aea88
    Reviewed-on: https://chromium-review.googlesource.com/1171377
    Reviewed-by: weiliangc <weiliangc@chromium.org>
    Commit-Queue: enne <enne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582367}

    Changed files

    • cc/test/layer_tree_test.cc
  54. Disable failing test (FLAKY_ has no meaning)

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:43:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b6a32c22de15bea00ed58fa55fdeafdb91767f6

    Comments

    Disable failing test (FLAKY_ has no meaning)
    
    Bug: 871812
    Change-Id: I0e4ee3e6539a6e4fa6c48495782a75a74a71dbc3
    TBR: mgiuca
    Reviewed-on: https://chromium-review.googlesource.com/1171681
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582366}

    Changed files

    • third_party/blink/renderer/core/css/font_face_cache_test.cc
  55. [CRD iOS] Using the new audio playback logic

    Changed by Yuwei Huang - yuweihohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:43:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b1e640c47e6cb75a8385ebba2e2aa31aeba732bf

    Comments

    [CRD iOS] Using the new audio playback logic
    
    This CL finishes up the rest of the work of refactoring the audio
    playback logic on iOS.
    
    Bug: 868088
    Change-Id: Iac4c240a8f98a1212bf65c056546f2f3ad14dd2d
    Reviewed-on: https://chromium-review.googlesource.com/1166339
    Commit-Queue: Yuwei Huang <yuweih@chromium.org>
    Reviewed-by: Joe Downing <joedow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582365}

    Changed files

    • remoting/client/audio/BUILD.gn
    • remoting/client/audio/audio_playback_stream.cc
    • remoting/client/audio/audio_playback_stream.h
    • remoting/ios/session/remoting_client.mm
  56. Diable a flaky test on CrOS for the same reason as others on this bug.

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:42:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f8ac232aec054638f6bfd13c783ef7d7d32e48d6

    Comments

    Diable a flaky test on CrOS for the same reason as others on this bug.
    
    Bug: 870732
    Change-Id: I0c7c7a78d7acb2e96f0d0308a758a01059628aa7
    TBR: mgiuca
    Reviewed-on: https://chromium-review.googlesource.com/1171738
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582364}

    Changed files

    • chrome/browser/password_manager/password_manager_browsertest.cc
  57. Never show shortcuts in contextual menus on the Mac.

    Changed by Avi Drissman - aviohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:42:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3c50480db92fe1220814910400ace4683a4d438a

    Comments

    Never show shortcuts in contextual menus on the Mac.
    
    This is platform convention.
    
    BUG=869564
    TEST=as in bug
    
    Change-Id: I3a4dbec12c5047219f255694eb4251405422e8fe
    Reviewed-on: https://chromium-review.googlesource.com/1164307
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582363}

    Changed files

    • ui/base/cocoa/menu_controller.mm
  58. Fix suggestion chip too long issue

    Changed by Weidong Guo - weidonggohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:41:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e448af80c5ba070e15aa387564fc8708fab6edf8

    Comments

    Fix suggestion chip too long issue
    
    Changes:
    Make the suggestion chip text length no longer than 192dip.
    
    Bug: 872948
    Change-Id: I54bc24cfc5b0ecf50d05e8312413e72ca14276e9
    Reviewed-on: https://chromium-review.googlesource.com/1171676
    Commit-Queue: Weidong Guo <weidongg@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582362}

    Changed files

    • ash/app_list/views/suggestion_chip_view.cc