Home | Search | chromium - Builders
Login

Builder Mac FYI GPU ASAN Release Build 1362 Apple OSX

Results:

Internal Failure

Trigger Info:

Projectchromium
Revisiondfb08c4ccef342639df17f6a423643df1784b767

Execution:

Steps and Logfiles:

Show:
  1. ( 300 ms ) setup_build
    running recipe: "chromium"
  2. ( 358 ms ) remove .cipd
  3. ( 1 mins 25 secs ) bot_update
    [126GB/232GB used (54%)]
  4. ( 0 ) ensure_goma
  5. ( 710 ms ) swarming.py --version
    0.13
  6. ( 180 ms ) ensure_installed
  7. ( 14 secs ) gclient runhooks
  8. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
  9. ( 18 secs ) generate_build_files
  10. ( 531 ms ) clang_revision
  11. ( 52 mins 57 secs ) compile
  12. ( 1 mins 11 secs ) isolate tests
  13. ( 399 ms ) find isolated tests
  14. ( 0 ) test_pre_run
  15. ( 50 secs ) angle_end2end_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 46s
  16. ( 2 mins 43 secs ) angle_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:02:37.954430
  17. ( 59 mins 57 secs ) angle_unittests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Pending time: 0:57:15.441920
    Shard duration: 0:02:32.208610
  18. ( 49 secs ) tab_capture_end2end_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 45s
  19. ( 1 mins 9 secs ) tab_capture_end2end_tests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Pending time: 34s
    Shard duration: 32s
  20. ( 1 mins ) gl_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 58s
  21. ( 1 mins 55 secs ) gl_tests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Pending time: 0:01:02.641010
    Shard duration: 47s
  22. ( 10 secs ) gl_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 8s
  23. ( 5 mins 27 secs ) gl_unittests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Pending time: 0:05:11.291190
    Shard duration: 7s
  24. ( 2 mins 9 secs ) gles2_conform_test on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:02:05.129320
  25. ( 9 mins 42 secs ) gles2_conform_test on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Pending time: 0:04:37.265660
    Shard duration: 0:04:57.309030
  26. ( 1 mins 5 secs ) gpu_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:00.499070
  27. ( 4 mins ) gpu_unittests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Pending time: 0:03:07.807220
    Shard duration: 44s
  28. ( 15 secs ) services_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 12s
  29. ( 5 mins 13 secs ) services_unittests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Pending time: 0:04:48.274640
    Shard duration: 13s
  30. ( 9 secs ) swiftshader_unittests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 7s
  31. ( 1 mins 35 secs ) swiftshader_unittests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Pending time: 0:01:23.181170
    Shard duration: 7s
  32. ( 1 mins 20 secs ) context_lost_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:17.789340
    Total tests: 8
    * Passed: 8 (8 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  33. ( 6 mins 54 secs ) context_lost_tests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Pending time: 0:05:28.706710
    Shard duration: 0:01:24.488670
    Total tests: 8
    * Passed: 8 (8 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  34. ( 34 secs ) depth_capture_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 32s
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  35. ( 7 mins 10 secs ) depth_capture_tests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Pending time: 0:06:37.703660
    Shard duration: 26s
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  36. ( 1 mins 20 secs ) gpu_process_launch_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:18.707840
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  37. ( 1 mins 10 secs ) gpu_process_launch_tests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 0:01:04.968360
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  38. ( 36 secs ) hardware_accelerated_feature_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Shard duration: 32s
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  39. ( 40 secs ) hardware_accelerated_feature_tests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Pending time: 14s
    Shard duration: 25s
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "build91-m9" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531383119794760, "id": "8941222129737006848", "project": "chromium", "tags": ["builder:Mac FYI GPU ASAN Release", "buildset:commit/git/dfb08c4ccef342639df17f6a423643df1784b767", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/dfb08c4ccef342639df17f6a423643df1784b767", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9106652192001616368", "scheduler_job_id:chromium/Mac FYI GPU ASAN Release", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Mac FYI GPU ASAN Release" setup_build
buildnumber 1362 setup_build
mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "dfb08c4ccef342639df17f6a423643df1784b767" setup_build
got_angle_revision "c9c259cccb2ece20c516b45f2c3782e31860a528" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "dfb08c4ccef342639df17f6a423643df1784b767" bot_update
got_revision_cp "refs/heads/master@{#574502}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23944}" bot_update
got_clang_revision "336424-1" clang_revision
swarm_hashes_refs/heads/master(at){#574502}_without_patch {"angle_end2end_tests": "a3ead56b4b91a434f8e433bd23ccf058ad41ac95", "angle_unittests": "d3b165e25a5327cf16a6842c43fd90d8a66e1364", "browser_tests": "4a1d1319861cad27d22612631ef5a35888704fe0", "gl_tests": "333bc800d9dc5b3c75fbde15a95e1197a947d11c", "gl_unittests": "271a5151a09e21d94ea4351a13d297682c05d3bd", "gles2_conform_test": "d78ef7c79e815a298c6d25b9703306c4a3b9b892", "gpu_unittests": "b2fed61d27fd97f3f910971d4b544750e46c682e", "services_unittests": "390b19363aca9912c472241a5de5fb559c43ec46", "swiftshader_unittests": "ecc17917607485fdb1b3a3c59134c3c66624be94", "telemetry_gpu_integration_test": "2d8083eecc9b2ce129809f077b5cbdb31d0efa9f"} isolate tests
swarm_hashes {"angle_end2end_tests": "a3ead56b4b91a434f8e433bd23ccf058ad41ac95", "angle_unittests": "d3b165e25a5327cf16a6842c43fd90d8a66e1364", "browser_tests": "4a1d1319861cad27d22612631ef5a35888704fe0", "gl_tests": "333bc800d9dc5b3c75fbde15a95e1197a947d11c", "gl_unittests": "271a5151a09e21d94ea4351a13d297682c05d3bd", "gles2_conform_test": "d78ef7c79e815a298c6d25b9703306c4a3b9b892", "gpu_unittests": "b2fed61d27fd97f3f910971d4b544750e46c682e", "services_unittests": "390b19363aca9912c472241a5de5fb559c43ec46", "swiftshader_unittests": "ecc17917607485fdb1b3a3c59134c3c66624be94", "telemetry_gpu_integration_test": "2d8083eecc9b2ce129809f077b5cbdb31d0efa9f"} find isolated tests

Blamelist:

  1. Anita Woodruff (awdfohnoyoudont@chromium.org)
  2. Hitoshi Yoshida (periaohnoyoudont@chromium.org)
  3. Luciano Pacheco (lucmultohnoyoudont@chromium.org)
  4. Alan Cutter (alancutterohnoyoudont@chromium.org)
  5. Marc Treib (treibohnoyoudont@chromium.org)
  6. Dominic Mazzoni (dmazzoniohnoyoudont@chromium.org)
  7. Hirokazu Honda (hirohohnoyoudont@chromium.org)
  8. cathiechen (cathiechenohnoyoudont@tencent.com)
  9. Stefan Zager (szagerohnoyoudont@chromium.org)
  10. Jun Mukai (mukaiohnoyoudont@chromium.org)
  11. rbpotter (rbpotterohnoyoudont@chromium.org)
  12. Lei Zhang (thestigohnoyoudont@chromium.org)
  13. John Abd-El-Malek (jamohnoyoudont@chromium.org)
  14. Jinsuk Kim (jinsukkimohnoyoudont@chromium.org)
  15. Koji Ishii (kojiiohnoyoudont@chromium.org)
  16. Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
  17. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  18. Matt Falkenhagen (falkenohnoyoudont@chromium.org)
  19. webrtc-chromium-autoroll (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  20. Nicholas Verne (nverneohnoyoudont@chromium.org)
  21. Matt Falkenhagen (falkenohnoyoudont@chromium.org)
  22. Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
  23. Yuri Wiitala (miuohnoyoudont@chromium.org)
  24. Derek Cheng (imchengohnoyoudont@chromium.org)
  25. Fabio Tirelo (ftireloohnoyoudont@chromium.org)
  26. Brian Salomon (bsalomonohnoyoudont@google.com)
  27. Chromite Chromium Autoroll (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  28. chrome-release-bot (chrome-release-botohnoyoudont@chromium.org)
  29. Devlin Cronin (rdevlin.croninohnoyoudont@chromium.org)
  30. Victor Costan (pwnallohnoyoudont@chromium.org)
  31. Esmael El-Moslimany (aeeohnoyoudont@chromium.org)
  32. Kenichi Ishibashi (bashiohnoyoudont@chromium.org)
  33. webrtc-chromium-autoroll (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  34. Halton Huo (halton.huoohnoyoudont@gmail.com)
  35. Maks Orlovich (morlovichohnoyoudont@chromium.org)
  36. tzik (tzikohnoyoudont@chromium.org)
  37. depot-tools-chromium-autoroll (depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  38. Yuichiro Hanada (yhanadaohnoyoudont@chromium.org)
  39. Esmael El-Moslimany (aeeohnoyoudont@chromium.org)
  40. Scott Violet (skyohnoyoudont@chromium.org)
  41. sawtelle (sawtelleohnoyoudont@google.com)
  42. Tetsui Ohkubo (tetsuiohnoyoudont@chromium.org)
  43. Kenneth Russell (kbrohnoyoudont@chromium.org)
  44. Michael Giuffrida (michaelpgohnoyoudont@chromium.org)
  45. Karan Bhatia (karandeepbohnoyoudont@chromium.org)
  46. Daniel Park (danielparkohnoyoudont@chromium.org)
  47. Xiangjun Zhang (xjzohnoyoudont@chromium.org)
  48. angle-chromium-autoroll (angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  49. Scott Haseley (shaseleyohnoyoudont@google.com)
  50. Xiaocheng Hu (xiaochenghohnoyoudont@chromium.org)
  51. Darren Shen (shendohnoyoudont@chromium.org)
  52. Ben Pastene (bpasteneohnoyoudont@chromium.org)
  53. Scott Wu (scottwuohnoyoudont@chromium.org)
  54. Ken Rockot (rockotohnoyoudont@chromium.org)
  55. Alexey Baskakov (loysoohnoyoudont@chromium.org)
  56. Michael Giuffrida (michaelpgohnoyoudont@chromium.org)
  57. pdfium-chromium-autoroll (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  58. Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
  59. Darren Shen (shendohnoyoudont@chromium.org)
  60. Wez (wezohnoyoudont@chromium.org)
  61. Ramya Nagarajan (ramyanohnoyoudont@chromium.org)
  62. catapult-chromium-autoroll (catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  63. Scott Violet (skyohnoyoudont@chromium.org)
  64. Ken Rockot (rockotohnoyoudont@chromium.org)
  65. Jinsuk Kim (jinsukkimohnoyoudont@chromium.org)
  66. Min Qin (qinminohnoyoudont@chromium.org)
  67. Bailey Forrest (bcfohnoyoudont@chromium.org)
  68. Morten Stenshorne (mstenshoohnoyoudont@chromium.org)
  69. kylechar (kylecharohnoyoudont@chromium.org)
  70. James Cook (jamescookohnoyoudont@chromium.org)
  71. Peter Kasting (pkastingohnoyoudont@chromium.org)
  72. Nico Weber (thakisohnoyoudont@chromium.org)
  73. Scott Chen (scottchenohnoyoudont@chromium.org)
  74. Daniel Park (danielparkohnoyoudont@chromium.org)
  75. depot-tools-chromium-autoroll (depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  76. Scott Violet (skyohnoyoudont@chromium.org)
  77. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  78. Tien-Ren Chen (trchenohnoyoudont@chromium.org)
  79. skia-chromium-autoroll (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  80. proberge (probergeohnoyoudont@chromium.org)
  81. John Rummell (jrummellohnoyoudont@chromium.org)
  82. rajendrant (rajendrantohnoyoudont@chromium.org)
  83. Devlin Cronin (rdevlin.croninohnoyoudont@chromium.org)
  84. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  85. Ken Rockot (rockotohnoyoudont@chromium.org)
  86. Kyle Horimoto (khorimotoohnoyoudont@google.com)
  87. Avi Drissman (aviohnoyoudont@chromium.org)
  88. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  89. Dirk Pranke (dprankeohnoyoudont@chromium.org)
  90. Darren Shen (shendohnoyoudont@chromium.org)
  91. Sonny Sasaka (sonnysasakaohnoyoudont@chromium.org)
  92. Yuki Awano (yawanoohnoyoudont@chromium.org)
  93. Aaron Leventhal (aleventhalohnoyoudont@chromium.org)
  94. Fady Samuel (fsamuelohnoyoudont@chromium.org)
  95. Mike Wasserman (mswohnoyoudont@chromium.org)
  96. Dominik Röttsches (drottohnoyoudont@chromium.org)
  97. kristipark (kristiparkohnoyoudont@chromium.org)
  98. James Cook (jamescookohnoyoudont@chromium.org)
  99. nacl-chromium-autoroll (nacl-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  100. Hongchan Choi (hongchanohnoyoudont@chromium.org)
  101. <blame list capped at 100 commits> ()

Timing:

Create Thursday, 12-Jul-18 08:11:59 UTC
Start Thursday, 12-Jul-18 08:12:30 UTC
End Thursday, 12-Jul-18 12:13:07 UTC
Pending 30 secs
Execution 4 hrs

All Changes:

  1. [Android PageInfo] Refactor PageInfoController to enable testing

    Changed by Anita Woodruff - awdfohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:05:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dfb08c4ccef342639df17f6a423643df1784b767

    Comments

    [Android PageInfo] Refactor PageInfoController to enable testing
    
    - Extracted PermissionParamsListBuilder from PageInfoController
    to handle all the permission-related logic when displaying
    permissions in page info. This new class requires fewer
    hard-to-unit-test dependencies so its logic can now be tested.
    
    Bug: 691898
    Change-Id: Iddbea30642a0dc31dae26110381e2dad9feb2af4
    Reviewed-on: https://chromium-review.googlesource.com/1103564
    Commit-Queue: Anita Woodruff <awdf@chromium.org>
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574502}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoController.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/PermissionParamsListBuilder.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/SystemSettingsActivityRequiredListener.java
    • chrome/android/java_sources.gni
    • chrome/android/junit/src/org/chromium/chrome/browser/page_info/PermissionParamsListBuilderUnitTest.java
  2. oilpan: Make ImageLoader::Task::script_state_ WeakPersistent

    Changed by Hitoshi Yoshida - periaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:41:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f59c5558bcae3a45e08edc99450f00242e5e7ce0

    Comments

    oilpan: Make ImageLoader::Task::script_state_ WeakPersistent
    
    ImageLoader::Task class does not actually own the script state,
    so its reference can be weak.
    This CL makes the reference weak.
    
    Bug: 773605
    Change-Id: Ib5761227e6582a8519a9d10ffaa00226559ee3d6
    Reviewed-on: https://chromium-review.googlesource.com/1134629
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574501}

    Changed files

    • third_party/blink/renderer/core/loader/image_loader.cc
  3. Change test to use full-path-for-testing attribute selector

    Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:12:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a8460b3e49c7b9ee03dcf56af71a0d76c0f60e4

    Comments

    Change test to use full-path-for-testing attribute selector
    
    This makes this test compatible with directory tree having My Files or
    not, and makes the test more readable too.
    
    This is a preparation to enable new navigation (with My Files) by
    default.
    
    Bug: 857335
    No-presubmit: true
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ia35bc2cc7c91e0492f0158990bfc397a6b57da21
    Reviewed-on: https://chromium-review.googlesource.com/1133610
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574500}

    Changed files

    • ui/file_manager/integration_tests/file_manager/context_menu.js
    • ui/file_manager/integration_tests/file_manager/create_new_folder.js
    • ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
  4. Add find bar icon to hosted app windows

    Changed by Alan Cutter - alancutterohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:03:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e35f205a1441afebe9987e606c7c876d5bfc4594

    Comments

    Add find bar icon to hosted app windows
    
    This CL moves the find icon from LocationBarView into PageActionIconContainerView
    enabling the icon to appear in hosted app window title bars.
    
    This change also fixes the find icon getting nudged by
    crrev.com/108c0687254683b3beeaa32b6e0a86f2046a867e.
    
    Before 108c0687254683b3beeaa32b6e0a86f2046a867e:
    https://bugs.chromium.org/p/chromium/issues/attachment?aid=346964&signed_aid=IuPvufZswamla90tWW5FCg==&inline=1
    Before CL:
    https://bugs.chromium.org/p/chromium/issues/attachment?aid=346965&signed_aid=Aiy5ATHUK4cWS64MyuRMdQ==&inline=1
    After CL:
    https://bugs.chromium.org/p/chromium/issues/attachment?aid=346968&signed_aid=DR3vtzLR7tlPH3cEwibshQ==&inline=1
    
    Bug: 788051, 814531
    Change-Id: I5fa60cce484bd2553131582fc39e6737da34e967
    Reviewed-on: https://chromium-review.googlesource.com/1054908
    Commit-Queue: Alan Cutter <alancutter@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574499}

    Changed files

    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
    • chrome/browser/ui/find_bar/find_bar_controller.cc
    • chrome/browser/ui/location_bar/location_bar.h
    • chrome/browser/ui/page_action/page_action_icon_container.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
    • chrome/browser/ui/views/frame/browser_view_layout.cc
    • chrome/browser/ui/views/frame/hosted_app_button_container.cc
    • chrome/browser/ui/views/frame/hosted_app_button_container.h
    • chrome/browser/ui/views/frame/toolbar_button_provider.h
    • chrome/browser/ui/views/location_bar/find_bar_icon.cc
    • chrome/browser/ui/views/location_bar/find_bar_icon.h
    • chrome/browser/ui/views/location_bar/location_bar_view.cc
    • chrome/browser/ui/views/location_bar/location_bar_view.h
    • chrome/browser/ui/views/page_action/page_action_icon_container_view.cc
    • chrome/browser/ui/views/page_action/page_action_icon_container_view.h
    • chrome/browser/ui/views/toolbar/toolbar_view.cc
    • chrome/browser/ui/views/toolbar/toolbar_view.h
    • chrome/test/base/test_browser_window.h
  5. Replace ThreadChecker by SequenceChecker in /components/sync*

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 06:54:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fc8a763a002339d6a7821e3c69d45ad8642dafc1

    Comments

    Replace ThreadChecker by SequenceChecker in /components/sync*
    
    https://crrev.com/c/1131474 removed the unnecessary thread-affinity,
    this one adjusts the checks accordingly.
    
    Bug: 846238
    Change-Id: If4e1145712fe99f4d8236d93e4f645e69c3e7655
    Reviewed-on: https://chromium-review.googlesource.com/1131738
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574498}

    Changed files

    • components/sync/driver/glue/sync_backend_host_core.cc
    • components/sync/driver/glue/sync_backend_host_core.h
    • components/sync/driver/glue/sync_backend_host_impl.cc
    • components/sync/driver/glue/sync_backend_host_impl.h
    • components/sync/driver/sync_service_crypto.cc
    • components/sync/driver/sync_service_crypto.h
    • components/sync/engine/sync_backend_registrar.cc
    • components/sync/engine/sync_backend_registrar.h
    • components/sync/engine_impl/debug_info_event_listener.cc
    • components/sync/engine_impl/debug_info_event_listener.h
    • components/sync/engine_impl/model_type_worker.cc
    • components/sync/engine_impl/model_type_worker.h
    • components/sync/engine_impl/net/server_connection_manager.cc
    • components/sync/engine_impl/net/server_connection_manager.h
    • components/sync/engine_impl/sync_manager_impl.cc
    • components/sync/engine_impl/sync_manager_impl.h
    • components/sync/engine_impl/sync_manager_impl_unittest.cc
    • components/sync/test/engine/fake_model_worker.cc
    • components/sync/test/engine/fake_model_worker.h
    • components/sync_bookmarks/bookmark_change_processor.cc
    • components/sync_bookmarks/bookmark_change_processor.h
  6. Track changes to nodes that are in the AX tree but aren't laid out.

    Changed by Dominic Mazzoni - dmazzoniohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 06:41:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d535bf95b998d1061629905139485c937272fc3b

    Comments

    Track changes to nodes that are in the AX tree but aren't laid out.
    
    Previously we only had hooks to update the children of a node in the
    AX tree when LayoutObjects were inserted or removed. That left out some
    corner cases when Nodes are inserted or removed that are part of the
    AX tree but not laid out, like nodes in the accessible / fallback content
    for a canvas.
    
    Bug: 862311
    Change-Id: I9482a9e0dc9ba45368b2fc87ea3449bdd4ef1c50
    Reviewed-on: https://chromium-review.googlesource.com/1132119
    Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574497}

    Changed files

    • third_party/WebKit/LayoutTests/accessibility/children-changed-in-canvas.html
    • third_party/blink/renderer/core/dom/element.cc
    • third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
    • third_party/blink/renderer/modules/accessibility/ax_layout_object.h
    • third_party/blink/renderer/modules/accessibility/ax_node_object.cc
    • third_party/blink/renderer/modules/accessibility/ax_node_object.h
  7. media/gpu/test/RenderingHelper: Unify interface to process video frame

    Changed by Hirokazu Honda - hirohohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 06:09:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c9e1a62b97488da8c36e7c12d0fe9769a60b4238

    Comments

    media/gpu/test/RenderingHelper: Unify interface to process video frame
    
    VDA test client calls RenderingHelper::RenderThumbnail() if a thumbnail is made
    from a video frame. Otherwise, it calls RenderingHelper::QueueVideoFrame().
    RenderingHelper itself knows which function to be called, and thus these
    functions should be unified into a single interface.
    
    BUG=chromium:834170
    TEST=VDA unittest at veyron_minnie and eve
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I106d4ce1c05b003d6333a6865a8d96e276031598
    Reviewed-on: https://chromium-review.googlesource.com/1122656
    Reviewed-by: Pawel Osciak <posciak@chromium.org>
    Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574496}

    Changed files

    • media/gpu/test/rendering_helper.cc
    • media/gpu/test/rendering_helper.h
    • media/gpu/video_decode_accelerator_unittest.cc
  8. [LayoutNG]Make the first marker of nested list occupying a whole line

    Changed by cathiechen - cathiechenohnoyoudont@tencent.com
    Changed at Thursday, 12-Jul-18 05:58:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 347323ce0f71964c59a50c507f14484baff8a386

    Comments

    [LayoutNG]Make the first marker of nested list occupying a whole line
    
    In legacy Layout, there's line-break between marker and the nesting
    <ul>/<ol>. In order to keep consistency with it, add NeedsOccupyWholeLine()
    in LayoutNGListMarker to indicate that marker would occupy a line.
    During Layout(), this kind of marker won't be added to container_builder_,
    and layout directly. And its margin will be handled after layout.
    
    Bug: 725277
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Ie9f6dbca0945c8e031ec7bb44594db2e96773462
    Reviewed-on: https://chromium-review.googlesource.com/1132819
    Commit-Queue: cathie chen <cathiechen@tencent.com>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574495}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/doctypes/001-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/doctypes/003-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/doctypes/004-expected.txt
    • third_party/blink/renderer/core/layout/ng/list/layout_ng_list_marker.cc
    • third_party/blink/renderer/core/layout/ng/list/layout_ng_list_marker.h
    • third_party/blink/renderer/core/layout/ng/list/ng_unpositioned_list_marker.h
    • third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
    • third_party/blink/renderer/core/paint/ng/ng_box_fragment_painter.cc
  9. Move scroll-related platform test code into core/testing/

    Changed by Stefan Zager - szagerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:49:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ecb9b545a199897e05ca621e40fd5e93289f82bd

    Comments

    Move scroll-related platform test code into core/testing/
    
    Also delete unused fake_scrollable_area.h.
    
    BUG=823365
    R=skobes@chromium.org,pdr@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I5620b9c31d53d523108c0c7a3a247264e588fc90
    Reviewed-on: https://chromium-review.googlesource.com/1132380
    Reviewed-by: Steve Kobes <skobes@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Commit-Queue: Stefan Zager <szager@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574494}

    Changed files

    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/editing/rendered_position_test.cc
    • third_party/blink/renderer/core/frame/frame_test_helpers.h
    • third_party/blink/renderer/core/paint/compositing/compositing_layer_property_updater_test.cc
    • third_party/blink/renderer/core/testing/core_unit_test_helper.h
    • third_party/blink/renderer/core/testing/use_mock_scrollbar_settings.h
    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
    • third_party/blink/renderer/platform/graphics/test/fake_scrollable_area.h
  10. check |focused_surface_| on SetCursorType

    Changed by Jun Mukai - mukaiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:47:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5939dab948bcde131510fa955f2802e93159238

    Comments

    check |focused_surface_| on SetCursorType
    
    SetCursorType hasn't checked the focused surface, thus it could
    change the cursor shapes even though the mouse pointer isn't
    related to the apps under exo.
    
    BUG=b/111360026
    TEST=the new test case in exo_unittests
    
    Change-Id: Ibacb0b8689720caa00ec206848cc6efb74854946
    Reviewed-on: https://chromium-review.googlesource.com/1134185
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Commit-Queue: Jun Mukai <mukai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574493}

    Changed files

    • components/exo/pointer.cc
    • components/exo/pointer_unittest.cc
  11. Print Preview: Add new Cloud Printer Handler flag

    Changed by rbpotter - rbpotterohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:34:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9990eb4884bf57e3f907c5a475d182ff4db6d760

    Comments

    Print Preview: Add new Cloud Printer Handler flag
    
    Use a new cloud printer handler flag to control using the C++ cloud
    printer handler instead of the JS cloud print interface in Print
    Preview. Print Preview will be temporarily whitelisted to send network
    requests with the network service flag enabled, so these changes should
    be de-coupled from the network service flag.
    
    Bug: 829414
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I9a7b53fe69bfe5aad4ab7cc5688dfb88e6074014
    Reviewed-on: https://chromium-review.googlesource.com/1134397
    Reviewed-by: Lei Zhang <thestig@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574492}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • chrome/browser/resources/print_preview/data/destination_store.js
    • chrome/browser/ui/webui/print_preview/print_preview_handler.cc
    • chrome/browser/ui/webui/print_preview/print_preview_ui.cc
    • chrome/common/chrome_features.cc
    • chrome/common/chrome_features.h
    • tools/metrics/histograms/enums.xml
  12. Remove debugging code in base::MessagePumpWin.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:29:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 95f61506c064bf502b2f2f81293866e40843ab2b

    Comments

    Remove debugging code in base::MessagePumpWin.
    
    BUG=596190
    
    Change-Id: Ie9b6ee2cc1db8399247be767cabba1b39df50544
    Reviewed-on: https://chromium-review.googlesource.com/1128274
    Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574491}

    Changed files

    • base/message_loop/message_pump_win.cc
    • base/message_loop/message_pump_win.h
  13. Add workaround for WebUIs that make network requests when running with the network service.

    Changed by John Abd-El-Malek - jamohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:28:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 04bfa853ac261c316e0ef799e7c10ae05dece8c1

    Comments

    Add workaround for WebUIs that make network requests when running with the network service.
    
    Currently with the network service, renderers that have WebUI bindings are not allowed to make requests over the internet. This is to improve security in case the response hijacks the renderer. However there are a couple of WebUIs that are doing this now, so temporarily allow them.
    
    Bug: 848987, 829412
    Change-Id: I34c1b66e63fd1b7c2960cc867709c065329cf489
    Reviewed-on: https://chromium-review.googlesource.com/1134412
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574490}

    Changed files

    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/chrome_content_browser_client.h
    • chrome/browser/extensions/chrome_extensions_browser_client.cc
    • chrome/browser/extensions/chrome_extensions_browser_client.h
    • chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
    • chrome/browser/ui/webui/chrome_web_ui_controller_factory.h
    • content/browser/frame_host/render_frame_host_impl.cc
    • content/public/browser/content_browser_client.cc
    • content/public/browser/content_browser_client.h
    • extensions/browser/api/web_request/web_request_permissions.cc
    • extensions/browser/extensions_browser_client.cc
    • extensions/browser/extensions_browser_client.h
  14. Stop content sniffing after successful encoding detection

    Changed by Jinsuk Kim - jinsukkimohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:40:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision efbdada3f735a2631e9dfeed5c5e3f880245ccd3

    Comments

    Stop content sniffing after successful encoding detection
    
    Content sniffing should stop once the detector makes a valid
    guess. http://crrev.com/2697213002 introduced a side effect
    that has the detector continue to sniff the content, therefore
    opens the possibility of returning an encoding different from
    the first guess. It leads to a document decoded with multiple
    encoding schemes, one of which may not be correct.
    
    This CL addresses it by defining a new flag |detection_completed_|
    to tell the TextResourceDecoder to stop sniffing, even if
    detector returns false for unlabelled UTF-8 documents. Also added
    a test verifying the behavior.
    
    Bug: 710861
    Change-Id: Ic07de3ae08fbb742aa3c24f1e18055348d6acbd8
    Reviewed-on: https://chromium-review.googlesource.com/1132904
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574489}

    Changed files

    • third_party/blink/renderer/core/html/parser/text_resource_decoder.cc
    • third_party/blink/renderer/core/html/parser/text_resource_decoder.h
    • third_party/blink/renderer/core/html/parser/text_resource_decoder_test.cc
    • third_party/blink/renderer/platform/text/text_encoding_detector.cc
    • third_party/blink/renderer/platform/wtf/text/text_encoding.cc
    • third_party/blink/renderer/platform/wtf/text/text_encoding.h
  15. [LayoutNG] Minor cleanup for NGInlineItem::Script()

    Changed by Koji Ishii - kojiiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:27:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 078bf960f5874ead134ad8f8c2e3f265969044cb

    Comments

    [LayoutNG] Minor cleanup for NGInlineItem::Script()
    
    Bug: 636993
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Ie8d9ac37eca29db6a39f9a4612a3c0151ef06006
    Reviewed-on: https://chromium-review.googlesource.com/1132254
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574488}

    Changed files

    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_item.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_item.h
  16. Fix crash in ResourceFetcher::CachedResource()

    Changed by Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:26:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae18f0f47b8272cc5b911cc22cb799a648405f45

    Comments

    Fix crash in ResourceFetcher::CachedResource()
    
    This fixes a bug where ResourceFetcher::CachedResource() crashes when
    given a null KURL.
    
    Bug: 859314
    Change-Id: Iae07ded3124b690854aa7ba2a532f21be2a99972
    Reviewed-on: https://chromium-review.googlesource.com/1132914
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574487}

    Changed files

    • third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
    • third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
  17. Disable flaky resource loading hints browser test on windows.

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:25:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 91567a36db92e68bb36a513b68c119707b4c2cec

    Comments

    Disable flaky resource loading hints browser test on windows.
    
    Change-Id: Iea8b186c1673fb14982c98ce24141003d267df21
    TBR: ryansturm@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/1134595
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574486}

    Changed files

    • chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc
  18. Gardening: Revise bug # for broken-chunked-encoding.https.html.

    Changed by Matt Falkenhagen - falkenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:20:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 349d297d20d841791815fd8b86b87f02e755bd22

    Comments

    Gardening: Revise bug # for broken-chunked-encoding.https.html.
    
    NOTRY=true
    
    Bug: 830472,862886
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: Ia6b50e1730d1f5dcb4f84b5c18d47003565fd838
    TBR: bashi
    Reviewed-on: https://chromium-review.googlesource.com/1134627
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574485}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
    • third_party/WebKit/LayoutTests/TestExpectations
  19. Roll src/third_party/webrtc d78323faba86..5795489e83ad (1 commits)

    Changed by webrtc-chromium-autoroll - webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 04:20:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1fc8a107a045fc9722cc619cd867e1197564f338

    Comments

    Roll src/third_party/webrtc d78323faba86..5795489e83ad (1 commits)
    
    https://webrtc.googlesource.com/src.git/+log/d78323faba86..5795489e83ad
    
    
    git log d78323faba86..5795489e83ad --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 buildbot@webrtc.org Roll chromium_revision 2e3b05bf93..720dadbc21 (574261:574387)
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@5795489e83ad
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
    
    BUG=chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I921992cf5317868ff92ddfd27ecdba4c9cd8c78f
    Reviewed-on: https://chromium-review.googlesource.com/1134146
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574484}

    Changed files

    • DEPS
  20. Linux install dialog now has the word (Beta)

    Changed by Nicholas Verne - nverneohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:19:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f5adc1de421e13cb871f50ed27d194a6ed1d5fb4

    Comments

    Linux install dialog now has the word (Beta)
    
    Bug: 848118
    Change-Id: Ib19c766d00084771d58f648076901eb6c4e25533
    Reviewed-on: https://chromium-review.googlesource.com/1133605
    Reviewed-by: Renée Wright <rjwright@chromium.org>
    Commit-Queue: Nicholas Verne <nverne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574483}

    Changed files

    • chrome/app/chromeos_strings.grdp
  21. Ensure NavigationURLLoader does not exist in OnStartChecksComplete.

    Changed by Matt Falkenhagen - falkenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:05:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision db52f93a94ed44198ade982c1640aa6aec35346c

    Comments

    Ensure NavigationURLLoader does not exist in OnStartChecksComplete.
    
    navigation_handle_->InitServiceWorkerHandle and navigation_handle_->InitAppCacheHandle
    reset the objects that NavigationURLLoaderImpl holds raw pointers to.
    So we must ensure |loader_| does not exist before doing that.
    
    Follow-up to r574110 <https://chromium-review.googlesource.com/1132715>.
    
    Bug: 857005
    Change-Id: If150832a8f6a104dbd662f2cc0e2c119e7a523bf
    Reviewed-on: https://chromium-review.googlesource.com/1133611
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574482}

    Changed files

    • content/browser/frame_host/navigation_request.cc
  22. Update signed exchange test directory reference

    Changed by Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:42:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7e72dce733afafe0340e25390b5f4c228702e9de

    Comments

    Update signed exchange test directory reference
    
    The directory was renamed in crrev.com/c/1132835.
    
    Bug: 856530
    Change-Id: I34890b24f256048d49bc59f5ba34ec048ce48d1c
    Reviewed-on: https://chromium-review.googlesource.com/1133609
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574481}

    Changed files

    • third_party/blink/tools/blinkpy/third_party/wpt/README.chromium
  23. Add viz::VideoCaptureOverlay to support mouse cursor rendering VIZ-side.

    Changed by Yuri Wiitala - miuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:36:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7bed8483e07637b8b24e7492d97bbc0499b6c16

    Comments

    Add viz::VideoCaptureOverlay to support mouse cursor rendering VIZ-side.
    
    VideoCaptureOverlay provides the post-GPU-readback rendering of small
    SkBitmaps onto the VideoFrames captured by viz::FrameSinkVideoCapturer.
    This will be used to move mouse cursor rendering out of the browser
    process, and into VIZ, as was intended in the original design. More
    details in crbug/810133.
    
    A soon-upcoming series of changes will provide mojo IDL definition as
    well as integration of VideoCaptureOverlay with FrameSinkVideoCapturer.
    
    Bug: 810133
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    Change-Id: I16897dbd361af153d10a1223339d9fb5f7e5f05a
    Reviewed-on: https://chromium-review.googlesource.com/1132318
    Commit-Queue: Yuri Wiitala <miu@chromium.org>
    Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574480}

    Changed files

    • components/viz/service/BUILD.gn
    • components/viz/service/frame_sinks/video_capture/video_capture_overlay.cc
    • components/viz/service/frame_sinks/video_capture/video_capture_overlay.h
    • components/viz/service/frame_sinks/video_capture/video_capture_overlay_unittest.cc
    • components/viz/test/data/video_capture/overlay_clips_ll.png
    • components/viz/test/data/video_capture/overlay_clips_lr.png
    • components/viz/test/data/video_capture/overlay_clips_ul.png
    • components/viz/test/data/video_capture/overlay_clips_ur.png
    • components/viz/test/data/video_capture/overlay_full_cover.png
    • components/viz/test/data/video_capture/overlay_full_cover_scaled.png
    • components/viz/test/data/video_capture/overlay_moves_0_0.png
    • components/viz/test/data/video_capture/overlay_moves_1_0.png
    • components/viz/test/data/video_capture/overlay_moves_2_0.png
    • components/viz/test/data/video_capture/overlay_moves_2_1.png
    • components/viz/test/data/video_capture/overlay_moves_2_2.png
    • components/viz/test/data/video_capture/overlay_moves_lr.png
  24. [MediaRouter] Reconnect the extension MRP Mojo pipe on connection error.

    Changed by Derek Cheng - imchengohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:34:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision da7bd5a1bbf177bb5822564193a7ea1795e0159b

    Comments

    [MediaRouter] Reconnect the extension MRP Mojo pipe on connection error.
    
    MR extension can fail/crash for many reasons. This in turn may cause
    ExtensionMediaRouteProviderProxy to violate its Mojo message pipe
    contract by dropping pending callbacks.
    
    Rather than wrapping each callback and tracking them in EMRPP, this
    patch deals with this by having MediaRouterDesktop detect when the EMRPP
    pipe encounters an error and attempt to recreate the pipe, subject to a
    max number of attempts.
    
    Bug: 861778
    Change-Id: Ie70e2cae3ea6650b65f658aba4ec527d4e2eb0d0
    Reviewed-on: https://chromium-review.googlesource.com/1129208
    Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
    Commit-Queue: Derek Cheng <imcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574479}

    Changed files

    • chrome/browser/media/router/mojo/media_router_desktop.cc
    • chrome/browser/media/router/mojo/media_router_desktop.h
    • chrome/browser/media/router/mojo/media_router_desktop_unittest.cc
    • chrome/browser/media/router/providers/extension/extension_media_route_provider_proxy.cc
    • chrome/browser/media/router/providers/extension/extension_media_route_provider_proxy.h
    • chrome/browser/media/router/providers/extension/extension_media_route_provider_proxy_unittest.cc
  25. [Save card dialog] Update Google Pay logo and title padding

    Changed by Fabio Tirelo - ftireloohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:30:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fb48e72d0b5d141e297e1e0a04d47cca079b0e1a

    Comments

    [Save card dialog] Update Google Pay logo and title padding
    
    According to the new spec, title for the server card should be:
      [GPay icon]<8px>|<8px>[Title]
    as opposed to the current:
      [GPay icon]<16px>|<16px>[Title]
    
    Mocks: https://drive.google.com/open?id=1A717QrLWOYSj3_A75tyMZomLUhy0xdV0
    Testing:
     - Local card: ./out/Debug/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=SaveCardBubbleControllerImplTest.InvokeUi_Local --test-launcher-interactive
     - Upstream card: ./out/Debug/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=SaveCardBubbleControllerImplTest.InvokeUi_Server --test-launcher-interactive
    
    The way it was done before was to consider that the separator
    was part of the GPay icon. However, that doesn't work properly
    for RTL languages, and the approach was harder to expand for
    different paddings.
    
    In order to achieve that, this CL:
     - Replaces the gpay logo icon with a new version without the
       separator (logo provided by our UX designer, by inspection
       it's easy to see that there was no change to the icon);
     - Creates a custom title container view that includes the icon,
       the | separator, and the "Save card?" title.
    
    Please notice that I didn't want to add complexity to the base
    classes to handle separators. However, if we think it might be
    useful for other dialogs, I'd like to generalize in a follow-up
    CL, to make sure we have proper testing.
    
    Also added comments to the different sections of the GPay logo
    .icon file, to make it easier to inspect any future updates.
    
    Bug: 859893
    Change-Id: I6c551b113e476f21f3e74198b37f6df080226e78
    Reviewed-on: https://chromium-review.googlesource.com/1127471
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574478}

    Changed files

    • chrome/app/vector_icons/BUILD.gn
    • chrome/app/vector_icons/google_pay_logo.icon
    • chrome/browser/ui/views/autofill/save_card_bubble_views.cc
    • chrome/browser/ui/views/autofill/save_card_bubble_views.h
  26. Revert "Reland "Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest.""

    Changed by Brian Salomon - bsalomonohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 03:18:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cbaa2f11a4e9f5ef04eeb8cf0dc2acfdbaa79f56

    Comments

    Revert "Reland "Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest.""
    
    This reverts commit 23370775c415c21f4de1c7d97dd5645fe2b7e818.
    
    Reason for revert: still fails on Nexus 9
    
    Original change's description:
    > Reland "Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest."
    > 
    > This is a reland of 841c0dde5461c763fdd524c2078aafaf241444aa
    > 
    > The updated change uses window.devicePixelRatio to determine the inset.
    > It also accounts for the absolute position used by the "WithDivs"
    > variations of this test. One additional device pixel of offset is used
    > to make this pass on mac_chromium_rel_ng. This is probably necessary
    > because either window.devicePixelRatio reports 1 incorrectly or the
    > edge antialiasing covers slightly more than one pixel. This wasn't
    > investigated.
    > 
    > Original change's description:
    > > Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest.
    > >
    > > Skia currently has a driver workaround that performans antialiased
    > > rectangle edge equation evalution in the fragment shader rather than
    > > vertex shader on Adreno 3xx GPUs. This was done because the interpolation
    > > of values computed in the vertex shader lacks enough precision to pass
    > > these tests. However, doing so has a negative performance impact. Skia
    > > tests run with the workaround removed show that in practice the visual
    > > difference is insignificant. Moreover, cc::GLRenderer also incurs these
    > > same errors as it uses the same antialiasing approach without the
    > > workaround and has shipped on Adreno 3xx devices for years with no known
    > > complaints about antialiasing quality/accuracy. We're better off
    > > reclaiming the performance and accepting a small hit to antialiasing
    > > accuracy.
    > >
    > > Bug: 847984
    > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    > > Change-Id: If1e62e0780a752179a75ddd57ccc7b24128c68ac
    > > Reviewed-on: https://chromium-review.googlesource.com/1129041
    > > Reviewed-by: Kenneth Russell <kbr@chromium.org>
    > > Commit-Queue: Brian Salomon <bsalomon@google.com>
    > > Cr-Commit-Position: refs/heads/master@{#573695}
    > 
    > Bug: 847984
    > Change-Id: Ie5e685e8d5e0afbcf4c54ea3186ee68d238464ba
    > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    > Reviewed-on: https://chromium-review.googlesource.com/1132574
    > Commit-Queue: Brian Salomon <bsalomon@google.com>
    > Reviewed-by: Kenneth Russell <kbr@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574369}
    
    TBR=bsalomon@google.com,zmo@chromium.org,kbr@chromium.org
    
    Change-Id: Idf353b940d79a85adba768e22593057d00310e47
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 847984
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Reviewed-on: https://chromium-review.googlesource.com/1134120
    Reviewed-by: Brian Salomon <bsalomon@google.com>
    Commit-Queue: Brian Salomon <bsalomon@google.com>
    Cr-Commit-Position: refs/heads/master@{#574477}

    Changed files

    • content/test/gpu/gpu_tests/screenshot_sync_integration_test.py
  27. Roll src/third_party/chromite a3bc29bcacf3..c228d491eb86 (3 commits)

    Changed by Chromite Chromium Autoroll - chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 03:16:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f0b7cacfc5ff01fe6d83463c81048b244322db8c

    Comments

    Roll src/third_party/chromite a3bc29bcacf3..c228d491eb86 (3 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/a3bc29bcacf3..c228d491eb86
    
    
    git log a3bc29bcacf3..c228d491eb86 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 bpastene@chromium.org cros_chrome_sdk: Change default location of cros cache dir.
    2018-07-12 vapier@chromium.org config_lib: delay loading of site_config in many modules
    2018-07-12 tbrindus@chromium.org paygen: Fix exception instantiation in error path
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@c228d491eb86
    
    The AutoRoll server is located here: https://chromite-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I88e283d9cb6593f6c1be6a0dfb2a9853e8e09f7f
    Reviewed-on: https://chromium-review.googlesource.com/1134103
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574476}

    Changed files

    • DEPS
  28. Updating trunk VERSION from 3489.0 to 3490.0

    Changed by chrome-release-bot - chrome-release-botohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:08:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 21d5fa75c5045ffda38bb5368435754a3a42d8e8

    Comments

    Updating trunk VERSION from 3489.0 to 3490.0
    
    # This is an automated release commit.
    # Do not revert without consulting chrome-pmo@google.com.
    NOAUTOREVERT=true
    TBR=amineer@chromium.org
    
    Change-Id: I6fc6232d8ba9ed933cc765caf4098281916f453d
    Reviewed-on: https://chromium-review.googlesource.com/1134528
    Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574475}

    Changed files

    • chrome/VERSION
  29. [Extensions Cleanup] Remove unnecessary call to sync service

    Changed by Devlin Cronin - rdevlin.croninohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:08:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 34a47acf551fda25534bde4146c5f94409bd8b5b

    Comments

    [Extensions Cleanup] Remove unnecessary call to sync service
    
    The runtime host permissions preferences used to be synced, but aren't
    currently. Remove the call to the sync service, since it's unnecessary.
    
    If/when we add back syncing support, we can re-add this call.
    
    Bug: 839681
    Change-Id: Iba45e431ad09f8ff92861c69ae8447c125af707a
    Reviewed-on: https://chromium-review.googlesource.com/1134433
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574474}

    Changed files

    • chrome/browser/extensions/scripting_permissions_modifier.cc
  30. Blink: Add test for LifecycleNotifier::ForEachObserver.

    Changed by Victor Costan - pwnallohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:02:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d12a94d841e7040cb516cb29c535cb899bdb58f0

    Comments

    Blink: Add test for LifecycleNotifier::ForEachObserver.
    
    Change-Id: I105750df8a76a5cabface400ba0dcfe60a77b810
    Reviewed-on: https://chromium-review.googlesource.com/1132848
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Victor Costan <pwnall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574473}

    Changed files

    • third_party/blink/renderer/platform/lifecycle_context_test.cc
  31. Settings: remove use of /deep/ selector in settings-ui

    Changed by Esmael El-Moslimany - aeeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:57:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 953e0851bee83c191092a0e7abeb883aab2fe1fc

    Comments

    Settings: remove use of /deep/ selector in settings-ui
    
    Bug: 860069
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I15349a654bd8309688cb5f0f58a4df115d3e180d
    Reviewed-on: https://chromium-review.googlesource.com/1133707
    Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574472}

    Changed files

    • chrome/browser/resources/settings/settings_ui/settings_ui.js
  32. Skip a ChromeResourceDispatcherHostDelegateBrowserTest when S13nSW is enabled

    Changed by Kenichi Ishibashi - bashiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:54:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f1fbed9c375f8c5301ea55a28320e56c0a4653ac

    Comments

    Skip a ChromeResourceDispatcherHostDelegateBrowserTest when S13nSW is enabled
    
    ChromeResourceDispatcherHostDelegateBrowserTest.NavigationDataProcessed
    tries to get NavigationData from NavigationHandle but we dont set
    NavigationData when S13nSW is enabled. Skip it when S13nSW is enabled.
    
    Bug: 861657
    Change-Id: I7af24fa1981d66c76cf5f83920b29b49d3988f33
    Reviewed-on: https://chromium-review.googlesource.com/1131041
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574471}

    Changed files

    • chrome/browser/loader/chrome_resource_dispatcher_host_delegate_browsertest.cc
  33. Roll src/third_party/webrtc ef43aafcf595..d78323faba86 (47 commits)

    Changed by webrtc-chromium-autoroll - webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 02:51:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2b0529974fae81606d19de5722d21320de4678e8

    Comments

    Roll src/third_party/webrtc ef43aafcf595..d78323faba86 (47 commits)
    
    https://webrtc.googlesource.com/src.git/+log/ef43aafcf595..d78323faba86
    
    
    git log ef43aafcf595..d78323faba86 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 steveanton@webrtc.org Remove AddTrack override with MediaStreams
    2018-07-11 buildbot@webrtc.org Roll chromium_revision c797a4c559..2e3b05bf93 (574101:574261)
    2018-07-11 danilchap@webrtc.org Reland "Remove rtc::Optional alias and api:optional target"
    2018-07-11 tkchin@webrtc.org Clear interrupted flag on CallKit audio activation.
    2018-07-11 yujo@chromium.org Remove not-updating-stats log message.
    2018-07-11 qingsi@google.com Revert "Reland "Replace the usage of MetricsObserverInterface by RTC_HISTOGRAM_*.""
    2018-07-11 fbarchard@google.com Include libyuv/planar_functions.h for CopyPlane
    2018-07-11 stefan@webrtc.org Moved PayloadRouter to call/.
    2018-07-11 sprang@webrtc.org Fix incorrect screenshare bitrate configs in test cases
    2018-07-11 magjed@webrtc.org Android: Remove use of EGLContexts in PeerConnectionFactory
    2018-07-11 magjed@webrtc.org VCMPacket: Set VCMNaluCompleteness for generic codecs
    2018-07-11 mbonadei@webrtc.org Removing unneeded warning suppression flags from audio_device.
    2018-07-11 yura.yaroshevich@gmail.com Fixed crash when PCF is destroyed before RTCRtpReceiver in ObjC
    2018-07-11 srte@webrtc.org Removes unnecessary destructor checks in tests.
    2018-07-11 hbos@webrtc.org RtpReceiverInterface::stream_ids() added.
    2018-07-11 mbonadei@webrtc.org Remove -Wno-reorder from examples/BUILD.gn.
    2018-07-11 andersc@webrtc.org Fix null check in CricketToWebRtcVideoDecoderFactory
    2018-07-11 mbonadei@webrtc.org Add missing dependency on //third_party/abseil-cpp/absl/memory.
    2018-07-11 buildbot@webrtc.org Roll chromium_revision 916138ba7e..c797a4c559 (573665:574101)
    2018-07-11 mbonadei@webrtc.org Removing -Wno-sentinel from examples/BUILD.gn.
    2018-07-11 mbonadei@webrtc.org Add missing dependencies on //third_party/abseil-cpp/absl/memory.
    2018-07-11 asapersson@webrtc.org Add unit tests for simulcast layer configurations.
    2018-07-11 ilnik@webrtc.org Revert "Remove rtc::Optional alias and api:optional target"
    2018-07-11 qingsi@webrtc.org Revert "Add Profile 2 configuration to VP9 Encoder and Decoder"
    2018-07-11 qingsi@google.com Reland "Replace the usage of MetricsObserverInterface by RTC_HISTOGRAM_*."
    2018-07-11 emircan@webrtc.org Add Profile 2 to default supported profiles
    2018-07-10 emircan@webrtc.org Add Profile 2 configuration to VP9 Encoder and Decoder
    2018-07-10 qingsi@google.com Revert "Replace the usage of MetricsObserverInterface by RTC_HISTOGRAM_*."
    2018-07-10 ouj@fb.com Add unittest for default severity level of RTCCallbackLogger
    2018-07-10 qingsi@google.com Replace the usage of MetricsObserverInterface by RTC_HISTOGRAM_*.
    2018-07-10 danilchap@webrtc.org Remove rtc::Optional alias and api:optional target
    2018-07-10 magjed@webrtc.org Android: Fix QueryVideoEncoder() for H264 High Profile
    2018-07-10 philipel@webrtc.org Actually input packets into the PacketBuffer.
    2018-07-10 alessiob@webrtc.org Reland "IWYU: Add <cmath> for fabsf() and powf(), switch to C++ versions"
    2018-07-10 magjed@webrtc.org Android: Honor disabling legacy video HW codec acceleration
    2018-07-10 saza@webrtc.org Fix fuzzer-found flow-over in AGC1
    2018-07-10 mbonadei@webrtc.org Removing -Wno-microsoft-extra-qualification.
    2018-07-10 mbonadei@webrtc.org Removing rtc_unittests warning suppression flags.
    2018-07-10 mbonadei@webrtc.org Remove -Wno-sign-compare, -Wno-unused-variable and -Wno-format.
    2018-07-10 philipel@webrtc.org Change RTPVideoTypeHeader to absl::variant and move RTPVideoHeader into its own h/cc file.
    2018-07-10 srte@webrtc.org Moves VideoAnalyzer class to a separate file.
    2018-07-10 srte@webrtc.org Removes unnecessary destructor checks in tests.
    2018-07-10 buildbot@webrtc.org Roll chromium_revision ef3275516a..916138ba7e (573561:573665)
    2018-07-10 ouj@fb.com Regenerate mock peer connection to add missing mock methods.
    2018-07-10 sakal@webrtc.org Update examples to use the new VideoCapturer interface.
    2018-07-10 ouj@fb.com Make the default severity level of RTCCallbackLogger match the comment on its header.
    2018-07-10 andersc@webrtc.org Migrate legacy Android video codec factories.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@d78323faba86
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
    
    BUG=chromium:None,chromium:None,chromium:None,chromium:861721,chromium:None,chromium:None,chromium:None,chromium:none,chromium:819294,chromium:860638,chromium:none,chromium:None,chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I76bc9222cb5ac91beb290da2d1740e35a029679c
    Reviewed-on: https://chromium-review.googlesource.com/1134448
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574470}

    Changed files

    • DEPS
  34. Fix debain package issue for ARM64.

    Changed by Halton Huo - halton.huoohnoyoudont@gmail.com
    Changed at Thursday, 12-Jul-18 02:49:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c621f6274616b050108d3cbb3b9d24bfa2c56233

    Comments

    Fix debain package issue for ARM64.
    
    Bug: 862500
    Change-Id: Ib456bdb3773cf9f50d7de85275804700c807f18e
    Reviewed-on: https://chromium-review.googlesource.com/1134578
    Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574469}

    Changed files

    • chrome/installer/linux/debian/build.sh
    • chrome/installer/linux/debian/calculate_package_deps.py
  35. Port GCM's RegistrationRequest to SimpleURLLoader

    Changed by Maks Orlovich - morlovichohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:45:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c70c93c4855cbbdd5c9f05fe2f383599be7a0eb5

    Comments

    Port GCM's RegistrationRequest to SimpleURLLoader
    
    URLFetcher will stop working with advent of Network Service, and
    SimpleURLLoader is the replacement API for most clients.
    
    (Other request types will follow; they were not done for now to keep CL size down, since there is a
     lot of wiring of pointers through and test infra stuff).
    
    Bug: 844987
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I1dc5efda6d239509d060f154cedf57ecf73edff2
    Reviewed-on: https://chromium-review.googlesource.com/1110705
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Reviewed-by: Reilly Grant <reillyg@chromium.org>
    Commit-Queue: Maks Orlovich <morlovich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574468}

    Changed files

    • chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
    • chrome/browser/gcm/gcm_profile_service_unittest.cc
    • chrome/browser/net/system_network_context_manager.cc
    • components/gcm_driver/fake_gcm_client.cc
    • components/gcm_driver/fake_gcm_client.h
    • components/gcm_driver/gcm_client.h
    • components/gcm_driver/gcm_client_impl.cc
    • components/gcm_driver/gcm_client_impl.h
    • components/gcm_driver/gcm_client_impl_unittest.cc
    • components/gcm_driver/gcm_driver_desktop.cc
    • components/gcm_driver/gcm_driver_desktop.h
    • components/gcm_driver/gcm_driver_desktop_unittest.cc
    • google_apis/gcm/BUILD.gn
    • google_apis/gcm/engine/gcm_request_test_base.cc
    • google_apis/gcm/engine/gcm_request_test_base.h
    • google_apis/gcm/engine/registration_request.cc
    • google_apis/gcm/engine/registration_request.h
    • google_apis/gcm/engine/registration_request_unittest.cc
    • google_apis/gcm/test/DEPS
    • google_apis/gcm/test/run_all_unittests.cc
  36. Add base::OneShotTimer::FireNow() as a replacement of user_task()

    Changed by tzik - tzikohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:25:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f550a61d86c912dabe13cc71ea1e81762b951ae4

    Comments

    Add base::OneShotTimer::FireNow() as a replacement of user_task()
    
    This CL adds base::OneShotTimer::FireNow(), and replaces all user_task()
    call on base::OneShotTimer with FireNow(), as a preparation of
    OnceCallback support of OneShotTimer.
    
    After OneShotTimer starts supporting OnceCallback, user_task() needs to
    change the type of its return value to `const OnceClosure&`, which is
    unusable to run the callback. Assuming all users of user_task() of
    OneShotTimer run the resulting callback immediately and stop the timer,
    FireNow should work as the replacement.
    
    Bug: 850247
    Change-Id: I52617fecfaf75aee19d681838af0e8a6b6f736a1
    Reviewed-on: https://chromium-review.googlesource.com/1128684
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Dan Erat <derat@chromium.org>
    Reviewed-by: Egor Pasko <pasko@chromium.org>
    Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574467}

    Changed files

    • ash/lock_screen_action/lock_screen_note_display_state_handler_unittest.cc
    • ash/policy/policy_recommendation_restorer_unittest.cc
    • ash/system/night_light/night_light_controller.h
    • ash/system/night_light/night_light_controller_unittest.cc
    • ash/system/power/power_button_controller_test_api.cc
    • ash/system/power/power_button_screenshot_controller_test_api.cc
    • ash/wm/immersive_fullscreen_controller_unittest.cc
    • base/timer/timer.cc
    • base/timer/timer.h
    • chrome/browser/chromeos/arc/voice_interaction/highlighter_controller_client.cc
    • chrome/browser/chromeos/login/screens/update_screen_browsertest.cc
    • components/arc/power/arc_power_bridge.cc
    • components/sync/driver/data_type_manager_impl_unittest.cc
    • components/sync/driver/model_association_manager_unittest.cc
    • components/variations/variations_request_scheduler_mobile_unittest.cc
    • content/browser/indexed_db/indexed_db_backing_store.cc
    • content/browser/indexed_db/indexed_db_factory_unittest.cc
    • content/browser/renderer_host/input/mouse_wheel_phase_handler.cc
    • media/remoting/renderer_controller_unittest.cc
    • net/disk_cache/simple/simple_index_unittest.cc
    • ui/display/manager/display_configurator.cc
  37. Roll src/third_party/depot_tools d64781e17af7..32e3d1e37cd6 (1 commits)

    Changed by depot-tools-chromium-autoroll - depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 02:20:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 00714da94e9a0e147844f4d5625b433cb57cddd6

    Comments

    Roll src/third_party/depot_tools d64781e17af7..32e3d1e37cd6 (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d64781e17af7..32e3d1e37cd6
    
    
    git log d64781e17af7..32e3d1e37cd6 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 ehmaldonado@chromium.org Add a library for monitoring.
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@32e3d1e37cd6
    
    The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=agable@chromium.org
    
    Change-Id: Ie6794e65ad8cfec457900a56f6808509b810267c
    Reviewed-on: https://chromium-review.googlesource.com/1134450
    Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574466}

    Changed files

    • DEPS
  38. Expose Arc input method feature to chrome://flags.

    Changed by Yuichiro Hanada - yhanadaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:18:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0b63f06694d4bea2639fc3921d69fe2972cd699d

    Comments

    Expose Arc input method feature to chrome://flags.
    
    Bug: 845079
    Change-Id: I9f674c68d3cc442c042dde834a5f3123f15170cf
    Reviewed-on: https://chromium-review.googlesource.com/1131048
    Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
    Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574465}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • tools/metrics/histograms/enums.xml
  39. Settings: fix find in page shortcut handling

    Changed by Esmael El-Moslimany - aeeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:14:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 123398402602d1d9259cc9e3b71f50eae20c2415

    Comments

    Settings: fix find in page shortcut handling
    
    Bug: 862701
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I10c6f5888d53e0faf055adf9a45216bd83a71767
    Reviewed-on: https://chromium-review.googlesource.com/1133969
    Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574464}

    Changed files

    • chrome/browser/resources/settings/settings.html
    • chrome/browser/resources/settings/settings_ui/settings_ui.html
  40. chromeos: adds more comments about child modal/transients

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:12:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 20a46d01a72532d0375df58d797487cad764eede

    Comments

    chromeos: adds more comments about child modal/transients
    
    And a DCHECK that we're not attempting to use a DesktopNativeWidgetAura for
    CHILD_MODAL windows.
    
    BUG=none
    TEST=none
    
    Change-Id: I9138c7d5fb83078e6ee5cfe04d8fbf8a12e1cc85
    Reviewed-on: https://chromium-review.googlesource.com/1134048
    Commit-Queue: Scott Violet <sky@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574463}

    Changed files

    • ui/views/mus/desktop_window_tree_host_mus.cc
  41. [Picture in Picture] Create PictureInPictureControlEvent

    Changed by sawtelle - sawtelleohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 02:08:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 281b1ee604a3095d93c5bed1eb05e84f57db6966

    Comments

    [Picture in Picture] Create PictureInPictureControlEvent
    
    This change creates a subclass of Event called
    PictureInPictureControlEvent that can be called when
    a custom control is clicked on the Picture in Picture Window
     - the reason for this event specifically is that it also
    contains a String 'id', which is useful for a developer
    to see which control was clicked.
    
    Manual testing was done by initiating the call in
    overlay_window_views.cc by calling controller_->ControlClick() and
    confirming that the Event was triggered. An example can be seen at:
    https://stevensawtelle.github.io/pictureinpicture
        /picture_in_picture_example.html
    
    Note: There is still no built in way of assigning the string based on
    the id of the control that was clicked - that will come in a future CL.
    This CL is just to create the custom event.
    
    Bug: 854271
    Change-Id: Idf8c290c7f7745af8f492d3b3169ba4cadb2386a
    Reviewed-on: https://chromium-review.googlesource.com/1106615
    Commit-Queue: Steven Sawtelle <sawtelle@google.com>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: apacible <apacible@chromium.org>
    Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
    Cr-Commit-Position: refs/heads/master@{#574462}

    Changed files

    • third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/core_idl_files.gni
    • third_party/blink/renderer/core/events/BUILD.gn
    • third_party/blink/renderer/core/events/picture_in_picture_control_event.cc
    • third_party/blink/renderer/core/events/picture_in_picture_control_event.h
    • third_party/blink/renderer/core/events/picture_in_picture_control_event.idl
    • third_party/blink/renderer/core/events/picture_in_picture_control_event_init.idl
    • third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
  42. Unified: Get default focus on detailed view.

    Changed by Tetsui Ohkubo - tetsuiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:06:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 704db340a765dc9972c0018b74fbb2908cb04d0c

    Comments

    Unified: Get default focus on detailed view.
    
    In UnifiedSystemTray, detailed view did not get focus when it is
    transitioned by keyboard.
    
    TEST=manual
    BUG=862504
    
    Change-Id: I9f39359d3fa72be4bff5d42e5a9f98144b1a1bad
    Reviewed-on: https://chromium-review.googlesource.com/1132899
    Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
    Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574461}

    Changed files

    • ash/system/tray/tray_detailed_view.cc
    • ash/system/tray/tray_detailed_view.h
    • ash/system/unified/unified_system_tray_controller.cc
    • ash/system/unified/unified_system_tray_view.cc
  43. Remove fetch_telemetry_dependencies DEPS hook.

    Changed by Kenneth Russell - kbrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:04:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bec21faa451d3fc5c62018430ec212d46db17707

    Comments

    Remove fetch_telemetry_dependencies DEPS hook.
    
    The recipes are using the new checkout_telemetry_binary_dependencies
    hook instead and the bots no longer set this gyp variable.
    
    Bug: 862640
    Change-Id: I53c136898a21f18d246b431c5b2a6b08bfb6a0d5
    Reviewed-on: https://chromium-review.googlesource.com/1134189
    Reviewed-by: Stephen Martinis <martiniss@chromium.org>
    Commit-Queue: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574460}

    Changed files

    • DEPS
  44. Add chromeosInfoPrivate stylusStatus API (part 1)

    Changed by Michael Giuffrida - michaelpgohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:02:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6279eb8c5898875d456fc753c8e28ca8cea08e80

    Comments

    Add chromeosInfoPrivate stylusStatus API (part 1)
    
    Adds the "stylusStatus" property to chromeosInfoPrivate.get(). Will be:
    - "unsupported" if the device doesn't support stylus input.
    - "supported" if the device supports it.
    
    Part 2 will add:
    - "seen" if supported and stylus has been used at least once or the
      device comes with an internal stylus.
    
    Test: try && manually using supported and unsupported devices
    Bug: 632814
    Change-Id: I343908bcada0d149410875b885416bdc17f907da
    Reviewed-on: https://chromium-review.googlesource.com/1123320
    Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
    Reviewed-by: Toni Barzic <tbarzic@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574459}

    Changed files

    • chrome/browser/chromeos/extensions/info_private_api.cc
    • chrome/browser/chromeos/extensions/info_private_apitest.cc
    • chrome/common/extensions/api/chromeos_info_private.json
    • chrome/test/data/extensions/api_test/chromeos_info_private/extended/background.js
  45. Declarative Net Request: Handle flatbuffer indexed ruleset corruption.

    Changed by Karan Bhatia - karandeepbohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:59:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3b7bb4be8c040188b1ad9e36ee9262dd6fcdf8f8

    Comments

    Declarative Net Request: Handle flatbuffer indexed ruleset corruption.
    
    The JSON rulesets provided by an extension for the Declarative Net Request API
    are indexed to a flatbuffer (indexed) format during extension installation. This
    indexed ruleset is excluded from content verification and it is possible that it
    may get corrupted, making the extension ruleset useless.
    
    This CL handles ruleset corruption by re-indexing the JSON ruleset if the
    indexed ruleset fails to load.
    
    BUG=852058
    
    Change-Id: Ief43cd8f2bc030ad634a92e1fcf7656d03abd4c0
    Reviewed-on: https://chromium-review.googlesource.com/1107479
    Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
    Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574458}

    Changed files

    • chrome/browser/extensions/api/declarative_net_request/declarative_net_request_browsertest.cc
    • extensions/browser/api/declarative_net_request/rules_monitor_service.cc
    • extensions/browser/api/declarative_net_request/ruleset_manager.cc
    • extensions/browser/api/declarative_net_request/ruleset_manager.h
    • extensions/browser/api/declarative_net_request/utils.cc
    • extensions/browser/api/declarative_net_request/utils.h
    • extensions/browser/sandboxed_unpacker.cc
    • tools/metrics/histograms/histograms.xml
  46. [Modern] Modernizes settings action bar

    Changed by Daniel Park - danielparkohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:51:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d8b1c7455e423788c982bc899cd32cd635a2d2c

    Comments

    [Modern] Modernizes settings action bar
    
    > Changes action bar color to white
    > Adds shadow on scroll
    > Per Hannah's request, this change also affects ManageStorage
        - White action bar carries over to ManageStorage
    
    Bug: 834600
    Change-Id: Ib09e63bafbf03237ac07ff323743f689a73205fe
    Reviewed-on: https://chromium-review.googlesource.com/1098375
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
    Commit-Queue: Daniel Park <danielpark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574457}

    Changed files

    • chrome/android/java/res/drawable-hdpi/ic_help_white_24dp.png
    • chrome/android/java/res/drawable-mdpi/ic_help_white_24dp.png
    • chrome/android/java/res/drawable-xhdpi/ic_help_white_24dp.png
    • chrome/android/java/res/drawable-xxhdpi/ic_help_white_24dp.png
    • chrome/android/java/res/drawable-xxxhdpi/ic_help_white_24dp.png
    • chrome/android/java/res/layout/add_languages_main.xml
    • chrome/android/java/res/layout/autofill_editor_base.xml
    • chrome/android/java/res/layout/bookmark_add_edit_folder_activity.xml
    • chrome/android/java/res/layout/bookmark_edit.xml
    • chrome/android/java/res/layout/bookmark_folder_select_activity.xml
    • chrome/android/java/res/layout/clear_browsing_data_tabs.xml
    • chrome/android/java/res/layout/homepage_editor.xml
    • chrome/android/java/res/layout/password_entry_editor_interactive.xml
    • chrome/android/java/res/layout/password_entry_exception.xml
    • chrome/android/java/res/layout/payment_request_editor.xml
    • chrome/android/java/res/layout/preferences_action_bar_shadow.xml
    • chrome/android/java/res/menu/prefeditor_editor_menu.xml
    • chrome/android/java/res/values-v17/styles.xml
    • chrome/android/java/res/values-v21/styles.xml
    • chrome/android/java/res/values/colors.xml
    • chrome/android/java/res/values/dimens.xml
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/HomepageEditor.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferenceUtils.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/AddLanguageFragment.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java
    • chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorDialog.java
    • ui/android/java/res/values-v17/styles.xml
    • ui/android/java/res/values/colors.xml
  47. Mirroring Service: Supports switching between mirroring and remoting.

    Changed by Xiangjun Zhang - xjzohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:50:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1eb8fa9af662dd108d6033c5d8813db78b8489ee

    Comments

    Mirroring Service: Supports switching between mirroring and remoting.
    
    Add the implementation to support the switching between mirroring and
    remoting. Also changed to only monitor the WiFi status when receiver
    indicates that it supports the get status message.
    
    Bug: 734672
    Change-Id: I72eefbcadc6f790c2573a81976cd9d0e2dbe3ae7
    Reviewed-on: https://chromium-review.googlesource.com/1104966
    Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
    Reviewed-by: Yuri Wiitala <miu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574456}

    Changed files

    • components/mirroring/service/BUILD.gn
    • components/mirroring/service/interface.h
    • components/mirroring/service/message_dispatcher.cc
    • components/mirroring/service/message_dispatcher.h
    • components/mirroring/service/message_dispatcher_unittest.cc
    • components/mirroring/service/session.cc
    • components/mirroring/service/session.h
    • components/mirroring/service/session_monitor.cc
    • components/mirroring/service/session_monitor.h
    • components/mirroring/service/session_monitor_unittest.cc
    • components/mirroring/service/session_unittest.cc
  48. Roll src/third_party/angle 89ef177f9475..5598148b7613 (5 commits)

    Changed by angle-chromium-autoroll - angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 01:48:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a77159361b8dbc319ff208be3a0a38970c79d2c5

    Comments

    Roll src/third_party/angle 89ef177f9475..5598148b7613 (5 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/89ef177f9475..5598148b7613
    
    
    git log 89ef177f9475..5598148b7613 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 jmadill@chromium.org Vulkan: Don't use gl::ErrorOrResult.
    2018-07-11 jmadill@chromium.org Vulkan: Clean up Error usage.
    2018-07-11 jmadill@chromium.org Vulkan: Move Feature init before device creation.
    2018-07-11 jmadill@chromium.org Generalize Context scratch buffer errors.
    2018-07-11 jmadill@chromium.org Refactor internal format pixel math methods.
    
    
    Created with:
      gclient setdep -r src/third_party/angle@5598148b7613
    
    The AutoRoll server is located here: https://angle-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jmadill@chromium.org
    
    Change-Id: Ib007468f11fc8153eca19ee8925a7558fea89d47
    Reviewed-on: https://chromium-review.googlesource.com/1133872
    Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574455}

    Changed files

    • DEPS
  49. [scheduler] Refactor QueueCreationParams, separating out QueueTraits

    Changed by Scott Haseley - shaseleyohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 01:47:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 520720d455489da4f863ee202944c7dc0171ceaf

    Comments

    [scheduler] Refactor QueueCreationParams, separating out QueueTraits
    
    QueueTraits is the (deferrable, throttleable, pausable, freezable)
    4-tuple. We will be associating each non-loading TaskType with a
    QueueTraits to map it to a unique task queue.
    
    This CL also forward declares FrameSchedulerImpl in
    main_thread_task_queue.h and cleans up the necessary frame_scheduler_impl.h
    includes in files that were relying on the indirect include.
    
    Bug: 859963
    Change-Id: I84f883379d718d85e5baf806f199181d7e7bf753
    Reviewed-on: https://chromium-review.googlesource.com/1125033
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Commit-Queue: Scott Haseley <shaseley@google.com>
    Cr-Commit-Position: refs/heads/master@{#574454}

    Changed files

    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.h
    • third_party/blink/renderer/platform/scheduler/main_thread/queueing_time_estimator.cc
    • third_party/blink/renderer/platform/scheduler/test/fake_frame_scheduler.h
  50. [LayoutNG] Fix handling of generated boxes in ComputeNGCaretPosition

    Changed by Xiaocheng Hu - xiaochenghohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:45:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5bce39b0838948fbed6bcea5f4e88d4890d7edd2

    Comments

    [LayoutNG] Fix handling of generated boxes in ComputeNGCaretPosition
    
    Since there is no caret position allowed at the sides of a generated or
    pseudo inline box, ComputeNGCaretPosition should skip such box
    fragments.
    
    Existing code only checks GetNode() of the box fragment, which misses
    the case where GetNode() returns a pseudo node, and is fixed in this
    patch.
    
    Bug: 861669
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I4e46f25ea07b66fa9b4821a8944db3f854c839ae
    Reviewed-on: https://chromium-review.googlesource.com/1134396
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574453}

    Changed files

    • third_party/blink/renderer/core/layout/ng/inline/ng_caret_position.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_caret_position_test.cc
  51. [VK] Tidy up KeyboardController::PopulateKeyboardContent.

    Changed by Darren Shen - shendohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:42:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0cb32b12d33d62e3e56c9b8c9922aa9d5ca2b68f

    Comments

    [VK] Tidy up KeyboardController::PopulateKeyboardContent.
    
    Just moved some code around. Looks more consistent IMO when every switch
    case early returns.
    
    Bug: 845780
    Change-Id: If828b05cb088395d1e44d83ec038b57e8bffe9bd
    Reviewed-on: https://chromium-review.googlesource.com/1132908
    Reviewed-by: Blake O'Hare <blakeo@chromium.org>
    Commit-Queue: Darren Shen <shend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574452}

    Changed files

    • ui/keyboard/keyboard_controller.cc
  52. Luci configs for Oreo Phone Tester on chromium.android

    Changed by Ben Pastene - bpasteneohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:40:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c73e96e974871abb7258d040f9bbbdc85c9807e9

    Comments

    Luci configs for Oreo Phone Tester on chromium.android
    
    And move its testing spec to chromium.android
    
    Bug: 862645
    Change-Id: I2a45d509faeba8b75ef8d7ed1b1d8e95e347dddd
    Reviewed-on: https://chromium-review.googlesource.com/1134420
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Commit-Queue: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574451}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
    • infra/config/global/luci-milo.cfg
    • infra/config/global/luci-scheduler.cfg
    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/test_suite_exceptions.pyl
    • testing/buildbot/waterfalls.pyl
  53. Add icon getter for CWVAutofillSuggestion.

    Changed by Scott Wu - scottwuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:38:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision de45c8fcb6f97db5346bc6a52dc4edba0b7d1f3e

    Comments

    Add icon getter for CWVAutofillSuggestion.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ic1c360a24dfdb35581a13cf0532173d66c9f953c
    Reviewed-on: https://chromium-review.googlesource.com/1131050
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Reviewed-by: John Wu <jzw@chromium.org>
    Commit-Queue: Scott Wu <scottwu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574450}

    Changed files

    • ios/web_view/internal/autofill/cwv_autofill_suggestion.mm
    • ios/web_view/public/cwv_autofill_suggestion.h
  54. Reland "Use BigBuffer for legacy IPC messages"

    Changed by Ken Rockot - rockotohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:37:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c5bd80e5a7b379c0539ef33c5722fb1ee974cda

    Comments

    Reland "Use BigBuffer for legacy IPC messages"
    
    This is a reland of 3e126191c1a7a022260c1072b1b9288f09bb2dce,
    unchanged.
    
    https://chromium-review.googlesource.com/c/chromium/src/+/1134079
    fixes the root cause of the failure which caused this to be
    reverted. This CL can land once that one does.
    
    Original change's description:
    > Use BigBuffer for legacy IPC messages
    >
    > This replaces use of ReadOnlyBuffer with a new mojom Message type
    > specific to //ipc. This type maps to another new C++ MessageView type
    > which in turn wraps a BigBufferView.
    >
    > This allows us to transparently fall back onto shared memory for large
    > IPC messages without increasing the number of copies during send or
    > receive in any (small- or large-message) cases.
    >
    > In order to avoid introducing more mojo-base targets, this also removes
    > the remaining [Native] structs from mojo_base mojom (LOGFONT and
    > FileInfo) and replaces them with real mojom structures + StructTraits,
    > thus allowing //ipc to depend on mojo/public/*/base in its entirety.
    >
    > Also fixes random missing public_deps entries for a
    > chrome/services/file_util typemap, because it decided to start breaking
    > all of my local builds. :3
    >
    > Bug: 784069
    > Change-Id: I359b964ffc1fe44ffd6aa704405ea63156f4fbc9
    > Reviewed-on: https://chromium-review.googlesource.com/1131685
    > Commit-Queue: Ken Rockot <rockot@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#573956}
    
    TBR=dcheng@chromium.org
    
    Bug: 784069
    Change-Id: I1224367e9db026cb06b0099ee5dfdada89804f23
    Reviewed-on: https://chromium-review.googlesource.com/1134100
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574449}

    Changed files

    • chrome/services/file_util/public/mojom/safe_archive_analyzer.typemap
    • ipc/BUILD.gn
    • ipc/OWNERS
    • ipc/ipc.mojom
    • ipc/ipc_message_pipe_reader.cc
    • ipc/ipc_message_pipe_reader.h
    • ipc/ipc_message_utils.cc
    • ipc/ipc_message_utils.h
    • ipc/ipc_mojo_bootstrap_unittest.cc
    • ipc/message.typemap
    • ipc/message_mojom_traits.cc
    • ipc/message_mojom_traits.h
    • ipc/message_view.cc
    • ipc/message_view.h
    • ipc/typemaps.gni
    • mojo/public/cpp/base/BUILD.gn
    • mojo/public/cpp/base/file_info.typemap
    • mojo/public/cpp/base/file_info_mojom_traits.cc
    • mojo/public/cpp/base/file_info_mojom_traits.h
    • mojo/public/cpp/base/logfont_win.typemap
    • mojo/public/cpp/base/logfont_win_mojom_traits.cc
    • mojo/public/cpp/base/logfont_win_mojom_traits.h
    • mojo/public/cpp/base/time.typemap
    • mojo/public/cpp/base/time_mojom_traits.h
    • mojo/public/mojom/base/file_info.mojom
    • mojo/public/mojom/base/logfont_win.mojom
    • mojo/public/tools/bindings/chromium_bindings_configuration.gni
  55. WebApp: Extract web_applications source sets in GN.

    Changed by Alexey Baskakov - loysoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:36:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d538ba3e10d2498292aa429cef90d8b6c18473cd

    Comments

    WebApp: Extract web_applications source sets in GN.
    
    This CL reflects the existing dependencies and dependency
    cycles we have.
    
    Also, we want to establish the following folders in web_applications/:
    1) components/
    Any independent components which are shared between extensions/
    and web_applications/
    
    2) extensions/
    A code which is thematically part of chrome/browser/extensions/
    E.g. an upcoming BookmarkAppInstaller will be used by extensions.
    
    3) bookmark_apps/
    Any extension-based high-level helpers which are used by chrome/browser/
    
    Note that web_applications/policy content will be moved to
    web_applications/bookmark_apps/policy/
    
    Bug: 860581
    Change-Id: Ib89f0e327759cfab050caceae5818c8e72f40f08
    Reviewed-on: https://chromium-review.googlesource.com/1128665
    Commit-Queue: Alexey Baskakov <loyso@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574448}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/extensions/BUILD.gn
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/web_applications/BUILD.gn
    • chrome/browser/web_applications/bookmark_apps/BUILD.gn
    • chrome/browser/web_applications/components/BUILD.gn
    • chrome/browser/web_applications/extensions/BUILD.gn
    • chrome/browser/web_applications/policy/BUILD.gn
    • chrome/test/BUILD.gn
  56. Add isDemoSession to chrome.app.runtime LaunchData

    Changed by Michael Giuffrida - michaelpgohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:33:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 456e84e95d9f7060c117953d251e121bc052b158

    Comments

    Add isDemoSession to chrome.app.runtime LaunchData
    
    Adds the |isDemoSession| boolean property to launch data for the
    chrome.app.runtime.onLaunched event.
    
    Built-in platform apps on Chrome OS will check this to enable special
    Chrome OS Demo Mode behavior.
    
    This CL adds the property as |false|; a follow-up CL will correctly set
    it to |true| when the device is actually in Demo Mode.
    
    Bug: 835024
    Change-Id: Ie77f50f1551c3dfb00fff27e7779775ceca1f44d
    Reviewed-on: https://chromium-review.googlesource.com/1121113
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Sergey Volk <servolk@chromium.org>
    Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574447}

    Changed files

    • chrome/browser/extensions/chrome_extensions_browser_client.cc
    • chrome/browser/extensions/chrome_extensions_browser_client.h
    • chrome/test/data/extensions/platform_apps/launch_file/test.js
    • chrome/test/data/extensions/platform_apps/launch_whitelisted_ext_with_file/test.js
    • chromecast/browser/extensions/cast_extensions_browser_client.cc
    • chromecast/browser/extensions/cast_extensions_browser_client.h
    • extensions/browser/api/app_runtime/app_runtime_api.cc
    • extensions/browser/extensions_browser_client.h
    • extensions/browser/test_extensions_browser_client.cc
    • extensions/browser/test_extensions_browser_client.h
    • extensions/common/api/app_runtime.idl
    • extensions/renderer/resources/app_runtime_custom_bindings.js
    • extensions/shell/browser/shell_extensions_browser_client.cc
    • extensions/shell/browser/shell_extensions_browser_client.h
  57. Roll src/third_party/pdfium b165ffb64e59..d8882193737a (8 commits)

    Changed by pdfium-chromium-autoroll - pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 01:32:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 593b787d55ee623265f615215231a0fe6bc860b1

    Comments

    Roll src/third_party/pdfium b165ffb64e59..d8882193737a (8 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/b165ffb64e59..d8882193737a
    
    
    git log b165ffb64e59..d8882193737a --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 hnakashima@chromium.org Inline GetMarkParamPairAtIndex into FPDFPageObjMark_GetParamKey.
    2018-07-11 thestig@chromium.org Roll third_party/yasm/source/patched-yasm/ b98114e18..720b70524 (1 commit)
    2018-07-11 hnakashima@chromium.org Rename content mark parameter value getters.
    2018-07-11 hnakashima@chromium.org Remove clunky mark property value getters by index.
    2018-07-11 hnakashima@chromium.org Write marked content operators when generating a stream.
    2018-07-11 hnakashima@chromium.org Store property name for marked content with an indirect dict.
    2018-07-11 hnakashima@chromium.org Cleanup CPDF_ContentMark.
    2018-07-11 hnakashima@chromium.org Split CPDF_ContentMark::AddMark() into three versions.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@d8882193737a
    
    The AutoRoll server is located here: https://pdfium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I7acff8886402b7c92a599963707f72dacaa02ffa
    Reviewed-on: https://chromium-review.googlesource.com/1133877
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574446}

    Changed files

    • DEPS
  58. [Fuchsia] Add Context, Frame stubs; implement service glue.

    Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:27:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e26716b5bc2bfab8f7ae74d7418e0ac14749223f

    Comments

    [Fuchsia] Add Context, Frame stubs; implement service glue.
    
    * Add ContextImpl service.
    * Add FrameImpl service.
    * Add support for exiting after final disconnect to ContextProvider.
    * Add Context process startup logic to main.cc.
    * Rename webrunner_main.cc to web_context_service_main.cc.
    
    Bug: 852145
    Change-Id: I87228259472cc0ef1044ea3e00f94de9a0f61990
    Reviewed-on: https://chromium-review.googlesource.com/1114321
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574445}

    Changed files

    • webrunner/BUILD.gn
    • webrunner/service/common.h
    • webrunner/service/context_impl.cc
    • webrunner/service/context_impl.h
    • webrunner/service/context_provider_impl.cc
    • webrunner/service/context_provider_impl.h
    • webrunner/service/context_provider_impl_unittest.cc
    • webrunner/service/frame_impl.cc
    • webrunner/service/frame_impl.h
  59. [VK] Swap top/left in parsing SetDraggableArea arguments.

    Changed by Darren Shen - shendohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:22:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5f10ba6b2e7f231a2ec6fb549f1b470da3f17a2

    Comments

    [VK] Swap top/left in parsing SetDraggableArea arguments.
    
    'x' was mistakenly matched with 'top' and 'y' with 'left'. Should be
    the other way around. The old UI worked because x and y were the same
    (0, 0), but that's no longer true with the new UI.
    
    TBR=blakeo@chromium.org
    
    Bug: 859405, 856475
    Test: Manual
    Change-Id: I3ac31c4386abb7f86d850fea25ffb543419cf287
    Reviewed-on: https://chromium-review.googlesource.com/1133601
    Reviewed-by: Darren Shen <shend@chromium.org>
    Commit-Queue: Darren Shen <shend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574444}

    Changed files

    • chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
  60. Migrate //ipc test off of QuitCurrent*Deprecated().

    Changed by Wez - wezohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:21:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fdb9848c74490ec3cfe0faddb95e3a26d08f51de

    Comments

    Migrate //ipc test off of QuitCurrent*Deprecated().
    
    Bug: 844016
    Change-Id: If763ff6c6dc73de39e48710c3ecb7e1014a97d0f
    Reviewed-on: https://chromium-review.googlesource.com/1132473
    Commit-Queue: Wez <wez@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574443}

    Changed files

    • ipc/ipc_channel_mojo_unittest.cc
  61. [NTP] Adds service integration to request photos.

    Changed by Ramya Nagarajan - ramyanohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:20:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a29136f7c12d930aa75521113d85fca0378bb564

    Comments

    [NTP] Adds service integration to request photos.
    
    Adds a service request and callback to get Google Photos from an album.
    An access token for the signed-in user with requisite scope is
    obtained and used in the request.
    
    Bug: 839152
    Change-Id: I3b012b8cdba247d94052c774dd0b1ae1be070d14
    Reviewed-on: https://chromium-review.googlesource.com/1114231
    Reviewed-by: Christian Dullweber <dullweber@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574442}

    Changed files

    • chrome/browser/search/background/ntp_background.proto
    • chrome/browser/search/background/ntp_background_data.cc
    • chrome/browser/search/background/ntp_background_data.h
    • chrome/browser/search/background/ntp_background_service.cc
    • chrome/browser/search/background/ntp_background_service.h
    • chrome/browser/search/background/ntp_background_service_factory.cc
    • chrome/browser/search/background/ntp_background_service_observer.h
    • chrome/browser/search/background/ntp_background_service_unittest.cc
    • chrome/browser/search/local_ntp_source.cc
    • chrome/browser/search/local_ntp_source.h
    • tools/metrics/histograms/histograms.xml
    • tools/traffic_annotation/summary/annotations.xml
  62. Roll src/third_party/catapult 1af68170e543..39de3d225856 (1 commits)

    Changed by catapult-chromium-autoroll - catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 01:14:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5d4bb6ed80fc74f40da5499723417d45ab616119

    Comments

    Roll src/third_party/catapult 1af68170e543..39de3d225856 (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/1af68170e543..39de3d225856
    
    
    git log 1af68170e543..39de3d225856 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 simonhatch@chromium.org Dashboard - Remove unnecessary histogram lookups.
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@39de3d225856
    
    The AutoRoll server is located here: https://catapult-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:862666
    TBR=sullivan@chromium.org
    
    Change-Id: I748004dfd1269077f1c4648897b9d698baadb301
    Reviewed-on: https://chromium-review.googlesource.com/1133876
    Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574441}

    Changed files

    • DEPS
  63. chromeos: fixs bugs where top-levels were never deleted

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:13:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f2534b278418c9e9e6b1c701a182b36a5723d436

    Comments

    chromeos: fixs bugs where top-levels were never deleted
    
    Requests from a client to delete a top-level where not actually
    deleting the aura::Window.
    
    This also makes printing the window hierarchy include the remote id of the
    window, which is useful for debugging.
    
    BUG=none
    TEST=covered by tests
    
    Change-Id: Icd3eae0839558d6db277bfeaf5fd3b7dd2fde377
    Reviewed-on: https://chromium-review.googlesource.com/1134510
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574440}

    Changed files

    • ash/accelerators/debug_commands.cc
    • ash/shell.h
    • services/ui/ws2/server_window.cc
    • services/ui/ws2/server_window.h
    • services/ui/ws2/window_service.cc
    • services/ui/ws2/window_service.h
    • services/ui/ws2/window_tree.cc
    • services/ui/ws2/window_tree.h
    • services/ui/ws2/window_tree_test_helper.cc
    • services/ui/ws2/window_tree_test_helper.h
    • services/ui/ws2/window_tree_unittest.cc
  64. Mojo: Clean up MojoArmTrap API

    Changed by Ken Rockot - rockotohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:11:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7831a95dc47fbf2e72acba0de69703380076e333

    Comments

    Mojo: Clean up MojoArmTrap API
    
    Modifies MojoArmTrap() to place its outputs in a single buffer of
    MojoTrapEvent structures, rather than inlining all the event fields as
    output parameters. This means that traps which fail to arm can
    provide the caller with information in the same form that an actual
    event handler would receive it.
    
    Also finally cleans up trap unittests, taking advantage of capturing
    lambdas, removing the hacked in adaptations to old watcher APIs,
    
    TBR=kinuko@chromium.org
    
    Bug: 819046
    Change-Id: Ib2917df06611cbbe8406a65bcdcac71011f52e88
    Reviewed-on: https://chromium-review.googlesource.com/1133962
    Commit-Queue: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Reilly Grant <reillyg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574439}

    Changed files

    • mojo/core/core.cc
    • mojo/core/core.h
    • mojo/core/dispatcher.cc
    • mojo/core/dispatcher.h
    • mojo/core/entrypoints.cc
    • mojo/core/trap_unittest.cc
    • mojo/core/watcher_dispatcher.cc
    • mojo/core/watcher_dispatcher.h
    • mojo/public/c/system/README.md
    • mojo/public/c/system/thunks.cc
    • mojo/public/c/system/thunks.h
    • mojo/public/c/system/trap.h
    • mojo/public/cpp/system/simple_watcher.cc
    • mojo/public/cpp/system/wait.cc
    • mojo/public/cpp/system/wait_set.cc
    • third_party/blink/renderer/core/mojo/mojo_watcher.cc
  65. Update translation expectation.pyl

    Changed by Jinsuk Kim - jinsukkimohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:09:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8ea39bbbfcec8caf10486ad0b8e67a8c99bb0975

    Comments

    Update translation expectation.pyl
    
    https://crrev.com/c/1118926 had a typo in the script.
    This CL fixes it.
    
    TBR=brucedawson@chromium.org
    
    Bug: 862827
    Change-Id: I2238ca092e7f77a24ac52e379a9a9089df549c4d
    Reviewed-on: https://chromium-review.googlesource.com/1133602
    Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
    Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
    Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574438}

    Changed files

    • tools/gritsettings/translation_expectations.pyl
  66. Don't reset TabDownloadState on history back/forward

    Changed by Min Qin - qinminohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:57:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01a6365651e0b1e9896b251411a18a4ab5a4306d

    Comments

    Don't reset TabDownloadState on history back/forward
    
    Currently performing forward/backward on a tab will reset the TabDownloadState.
    Which allows javascript code to do trigger multiple downloads.
    This CL disables that behavior by not resetting the TabDownloadState on
    forward/back.
    It is still possible to reset the TabDownloadState through user gesture
    or using browser initiated download.
    
    BUG=848535
    
    Change-Id: I7f9bf6e8fb759b4dcddf5ac0c214e8c6c9f48863
    Reviewed-on: https://chromium-review.googlesource.com/1108959
    Commit-Queue: Min Qin <qinmin@chromium.org>
    Reviewed-by: Xing Liu <xingliu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574437}

    Changed files

    • chrome/browser/download/download_request_limiter.cc
    • chrome/browser/download/download_request_limiter.h
    • chrome/browser/download/download_request_limiter_unittest.cc
  67. [chromecast] BLE: Silently ignore unrecognized disconnenect events

    Changed by Bailey Forrest - bcfohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:55:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a3aa0471bc5652b265991619cde6b1486018b6b6

    Comments

    [chromecast] BLE: Silently ignore unrecognized disconnenect events
    
    - There may be other processes in the system which are
      connecting/disconnecting BLE devices.
    - We may receive extra disconnect events
    
    Bug: b/110965632
    Test: Does not log if called with unrecognized device.
    Change-Id: I3059435ea5df6919e12a87852c27e716a0f106b5
    Reviewed-on: https://chromium-review.googlesource.com/1119657
    Reviewed-by: Luke Halliwell <halliwell@chromium.org>
    Commit-Queue: Bailey Forrest <bcf@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574436}

    Changed files

    • chromecast/device/bluetooth/le/gatt_client_manager_impl.cc
  68. [LayoutNG] Force legacy for SVG foreignObject

    Changed by Morten Stenshorne - mstenshoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:50:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c1a46035e2a6626e5948f97687055c8102ac38bc

    Comments

    [LayoutNG] Force legacy for SVG foreignObject
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I12c7d4dd4af0392c2dd2d75c884dc36bff3624ab
    Reviewed-on: https://chromium-review.googlesource.com/1133164
    Reviewed-by: Fredrik Söderquist <fs@opera.com>
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574435}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/svg/extensibility/foreignObject/foreign-object-margin-collapsing.html
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/svg/custom/dominant-baseline-hanging-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/svg/custom/foreign-object-skew-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/svg/foreignObject/svg-document-in-html-document-expected.png
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/svg/foreignObject/svg-document-in-html-document-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/svg/zoom/page/zoom-foreignObject-expected.txt
    • third_party/blink/renderer/core/svg/svg_foreign_object_element.h
  69. Revert "Updating Viz Content BrowserTests Filter"

    Changed by kylechar - kylecharohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:50:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e1aa80280d36b8411d252286601369145224f684

    Comments

    Revert "Updating Viz Content BrowserTests Filter"
    
    This reverts commit a57a12587f7ace3b15480262c181ced968346ea4.
    
    Reason for revert: SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest is failing.
    
    Original change's description:
    > Updating Viz Content BrowserTests Filter
    > 
    > A few tests have been fixed. This updates the filter accordingly to re-enable them.
    > 
    > TEST=SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest
    > SitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF
    > Bug: 848825, 848348
    > 
    > Change-Id: If05696e57dfee18cc6ae06c21f7d968982c31219
    > Reviewed-on: https://chromium-review.googlesource.com/1133863
    > Reviewed-by: Jonathan Ross <jonross@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574302}
    
    TBR=jonross@chromium.org,kylechar@chromium.org
    
    Change-Id: Ic6de880ae04a3535c00bfab1cf39e61a335fe43e
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 848825, 848348
    Reviewed-on: https://chromium-review.googlesource.com/1134144
    Reviewed-by: kylechar <kylechar@chromium.org>
    Commit-Queue: kylechar <kylechar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574434}

    Changed files

    • testing/buildbot/filters/viz.android.content_browsertests.filter
    • testing/buildbot/filters/viz.content_browsertests.filter
  70. Clean up MASH_DEPRECATED in shelf auto-hide code

    Changed by James Cook - jamescookohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:45:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3bccf529dd2431e9fba3265b4cc678704182d272

    Comments

    Clean up MASH_DEPRECATED in shelf auto-hide code
    
    I verified that autohide works properly under mash with mouse gestures,
    touch gestures, and bezel gestures.
    
    Bug: 636647, 631216
    Test: ash_unittests, manual on device
    Change-Id: I368a72a96dbac9791eb67ede9adc739e1d9079fb
    Reviewed-on: https://chromium-review.googlesource.com/1134405
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574433}

    Changed files

    • ash/shelf/shelf.cc
    • ash/shelf/shelf.h
  71. Update Mac frame positioning code to be more coherent.

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:45:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dc5161c7ebd754433b509f7633c27661fe579233

    Comments

    Update Mac frame positioning code to be more coherent.
    
    This makes a couple of minor changes:
    * Consistently position the tabstrip with a 4 DIP gap to any following buttons,
      which in turn have a GetAvatarIconPadding()-size gap after them.  In turn this
      hardcoded 4 value will change to a function call in my next patch, so I'm not
      worried about having a great constant name/comment for it.
    * Make the conditions for how we reserve space be in the same order as for how
      we actually position the buttons.
    * Slight naming and similar changes to try and be more consistent.
    
    Bug: none
    Change-Id: I6116c74ac866886c1910ce824934fcf3c75e5fb0
    Reviewed-on: https://chromium-review.googlesource.com/1132604
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574432}

    Changed files

    • chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
  72. Make blink's {CORE,PLATFORM,MODULES}_TEMPLATE_CLASS_EXPORT macros no-ops.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:36:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59aea43550238d1866c865e032633e101e7f1fa4

    Comments

    Make blink's {CORE,PLATFORM,MODULES}_TEMPLATE_CLASS_EXPORT macros no-ops.
    
    On Windows, the macro already had no effect.
    
    Export on template classes doesn't make a lot of sense: The template itself
    doesn't exist, only its instantiations do. The export is inherited by the
    instantiations, so if the template had an instantiation in
    core/platform/modules then that instantiation would be visible outside the
    respective .so, but without an explicit instantation declaration, clients
    outside those sos still get their own instantation and that doesn't really do
    anything.
    
    (The bindings generator also uses this macro on explicit template
    specializations which _are_ instantiations, so the macro does have
    a useful effect there -- but it looks like the effect there isn't needed
    since everything builds fine with this patch applied.)
    
    While here, also remove a warning suppression pragma for a warning that's
    been disabled globally since #492411.
    
    Bug: 859989
    Change-Id: Ib22993d06f3ad62c79e2b53b010614ae6577d227
    Reviewed-on: https://chromium-review.googlesource.com/1133329
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574431}

    Changed files

    • third_party/blink/renderer/core/core_export.h
    • third_party/blink/renderer/modules/modules_export.h
    • third_party/blink/renderer/platform/platform_export.h
  73. Reland "Extensions: remove dependency on iron-icons"

    Changed by Scott Chen - scottchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:33:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9235ca8bfe3062c2397a3cb5ef107396adc6a01a

    Comments

    Reland "Extensions: remove dependency on iron-icons"
    
    Some files were depending on iron-icons/iron-icons.html to pull in
    iron-icon/iron-icon.html. Needed to add direct dependency to
    iron-icon.html, once iron-iconS.html was no longer imported.
    
    Bug: 855205
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Icd95f6b178a40d7169611721deef38b04e291257
    Reviewed-on: https://chromium-review.googlesource.com/1133588
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574430}

    Changed files

    • chrome/browser/resources/md_extensions/detail_view.html
    • chrome/browser/resources/md_extensions/drop_overlay.html
    • chrome/browser/resources/md_extensions/error_page.html
    • chrome/browser/resources/md_extensions/icons.html
    • chrome/browser/resources/md_extensions/item.html
    • chrome/browser/resources/md_extensions/item.js
    • chrome/browser/resources/settings/about_page/about_page.html
    • chrome/browser/resources/settings/about_page/about_page.js
    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
    • chrome/browser/resources/settings/icons.html
    • chrome/browser/resources/settings/languages_page/languages_page.html
    • chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.html
    • chrome/test/data/webui/extensions/extension_error_page_test.js
    • chrome/test/data/webui/extensions/extension_item_test.js
    • chrome/test/data/webui/settings/about_page_tests.js
    • ui/webui/resources/cr_elements/icons.html
  74. [Modern] Updates help icon to match new specs

    Changed by Daniel Park - danielparkohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:30:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cdcc3926f1af7e14fce9dd7337a0127dde9a10ef

    Comments

    [Modern] Updates help icon to match new specs
    
    > Creates xml file of new help icon
    > Removes pngs of the old help_and_feedback icon
    
    Bug: 834600
    Change-Id: Ieadda6e2771c8a57d1995d047aa418381618aef6
    Reviewed-on: https://chromium-review.googlesource.com/1044490
    Commit-Queue: Daniel Park <danielpark@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574429}

    Changed files

    • chrome/android/java/res/drawable-hdpi/ic_help_and_feedback.png
    • chrome/android/java/res/drawable-mdpi/ic_help_and_feedback.png
    • chrome/android/java/res/drawable-xhdpi/ic_help_and_feedback.png
    • chrome/android/java/res/drawable-xxhdpi/ic_help_and_feedback.png
    • chrome/android/java/res/drawable-xxxhdpi/ic_help_and_feedback.png
    • chrome/android/java/res/drawable/ic_help_and_feedback.xml
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ChosenObjectPreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/TranslatePreferences.java
  75. Roll src/third_party/depot_tools c3975e55e146..d64781e17af7 (1 commits)

    Changed by depot-tools-chromium-autoroll - depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 00:29:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3789a4a02293b9ded7d922cfc47462e25d7bc20d

    Comments

    Roll src/third_party/depot_tools c3975e55e146..d64781e17af7 (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c3975e55e146..d64781e17af7
    
    
    git log c3975e55e146..d64781e17af7 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 ehmaldonado@chromium.org gclient_scm: Fetch refs/changes/* when syncing.
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@d64781e17af7
    
    The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:858894
    TBR=agable@chromium.org
    
    Change-Id: If022f0d17cbb6ad978d73fb45f85215dfca5033e
    Reviewed-on: https://chromium-review.googlesource.com/1134447
    Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574428}

    Changed files

    • DEPS
  76. chromeos: test case for fixing infinite loop in cursor lookup

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:26:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f340807ff46e1662b09c0cf4f73e788a0cbf946b

    Comments

    chromeos: test case for fixing infinite loop in cursor lookup
    
    BUG=862715
    TEST=none
    
    Change-Id: Ic5ac2f60ad310a0b9bb88e0f9430bbdbcc17397c
    Reviewed-on: https://chromium-review.googlesource.com/1134467
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574427}

    Changed files

    • services/ui/ws2/BUILD.gn
    • services/ui/ws2/window_delegate_impl_unittest.cc
  77. Update V8 to version 6.9.352.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 00:25:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 754dce44f60812b309710cc9bbf51da2eaf4e1e2

    Comments

    Update V8 to version 6.9.352.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/8dc93fc4..8b17db68
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: Ic70862dc831eeb3ae86a02d13d9929c0a05dca45
    Reviewed-on: https://chromium-review.googlesource.com/1134196
    Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574426}

    Changed files

    • DEPS
  78. [Blink] Invalidate clip path cache if mask layer is mutated

    Changed by Tien-Ren Chen - trchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:20:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3c0ef7a52f1d5507732239edfebd81d090d1e027

    Comments

    [Blink] Invalidate clip path cache if mask layer is mutated
    
    This is a speculative fix for https://crbug.com/856818 .
    
    It is speculated that the clip path of an element become valid without
    invalidating its cache, resulting in the associated clip nodes not
    being created, and the newly created mask layer having bad layer state.
    
    BUG=856818
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Iab7acc4eb8007d03b259e6dab4f036e2b11bd900
    Reviewed-on: https://chromium-review.googlesource.com/1130596
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574425}

    Changed files

    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
  79. Roll src/third_party/skia 80247e594d1f..fcc10da18eb5 (1 commits)

    Changed by skia-chromium-autoroll - skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 00:14:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 06af0aaf8329e8b4f861dd4ed9d89eebf4adfdb2

    Comments

    Roll src/third_party/skia 80247e594d1f..fcc10da18eb5 (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/80247e594d1f..fcc10da18eb5
    
    
    git log 80247e594d1f..fcc10da18eb5 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 mtklein@chromium.org fix color management in sprite blitter
    
    
    Created with:
      gclient setdep -r src/third_party/skia@fcc10da18eb5
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: I5c8bd079d92f8d8598f032067eb6d0c26f20ca2c
    Reviewed-on: https://chromium-review.googlesource.com/1134446
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574424}

    Changed files

    • DEPS
  80. Chrome Settings: minor fix to settings_toggle_button padding

    Changed by proberge - probergeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:11:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b307437f07306488f4a72f45bec3e1217f0a99b

    Comments

    Chrome Settings: minor fix to settings_toggle_button padding
    
    When using a settings-toggle-button with a sub-label whose contents can
    fit into one or two lines depending on screen resolution, there was no
    way to get consistent vertical padding.
    
    This change explicitly sets padding inside of the settings_toggle_button's
    outerRow element in order to guarantee padding for the item.
    
    This has the negative side-effect of causing the
    settings-toggle-button to expand vertically if the window is resized such that
    the sub-label text overflows to a new line.
    
    Bug: 803683
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Iff644e6efb4aa293f4ae41e9035a961578d576f0
    Reviewed-on: https://chromium-review.googlesource.com/1133300
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: proberge <proberge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574423}

    Changed files

    • chrome/browser/resources/settings/controls/settings_toggle_button.html
    • chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
  81. Improve FrameBuffer allocation time

    Changed by John Rummell - jrummellohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:09:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 803005b59bef10b2d804a5827d626dcc9d10d906

    Comments

    Improve FrameBuffer allocation time
    
    When allocating a large buffer (via the fuzzer tests), calling resize() on
    std::vector<uint8_t> took a long time. This changes the code to use a
    std::unique_ptr<uint8_t[]> so that allocating a large buffer is much cheaper.
    
    BUG=817341
    TEST=fuzzer test now runs in 535ms instead of timing out after 25 seconds
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: If3a57a325dfab4f15d43a71b935e18c2ce759715
    Reviewed-on: https://chromium-review.googlesource.com/1133586
    Commit-Queue: John Rummell <jrummell@chromium.org>
    Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574422}

    Changed files

    • media/filters/frame_buffer_pool.cc
  82. Report data use from renderer to browser page load metrics

    Changed by rajendrant - rajendrantohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:04:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision db2671aa51b5f771f494b2911620711dbdddd115

    Comments

    Report data use from renderer to browser page load metrics
    
    Report the continuous data use to page load metrics in browser process
    via the existing renderer -> browser PageLoadMetrics mojo.
    
    Bug: 836029
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I1c7b47eb41e13f9b72d087e3ca2c0a7096c11b29
    Reviewed-on: https://chromium-review.googlesource.com/1042877
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Charlie Harrison <csharrison@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Commit-Queue: rajendrant <rajendrant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574421}

    Changed files

    • chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
    • chrome/browser/page_load_metrics/metrics_web_contents_observer.h
    • chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
    • chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.cc
    • chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
    • chrome/browser/page_load_metrics/page_load_metrics_observer.h
    • chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc
    • chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h
    • chrome/browser/page_load_metrics/page_load_tracker.cc
    • chrome/browser/page_load_metrics/page_load_tracker.h
    • chrome/common/page_load_metrics/page_load_metrics.mojom
    • chrome/renderer/BUILD.gn
    • chrome/renderer/page_load_metrics/fake_page_timing_sender.cc
    • chrome/renderer/page_load_metrics/fake_page_timing_sender.h
    • chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
    • chrome/renderer/page_load_metrics/metrics_render_frame_observer.h
    • chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc
    • chrome/renderer/page_load_metrics/page_resource_data_use.cc
    • chrome/renderer/page_load_metrics/page_resource_data_use.h
    • chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc
    • chrome/renderer/page_load_metrics/page_timing_metrics_sender.h
    • chrome/renderer/page_load_metrics/page_timing_metrics_sender_unittest.cc
    • chrome/renderer/page_load_metrics/page_timing_sender.h
    • components/data_reduction_proxy/DEPS
    • components/data_reduction_proxy/core/common/BUILD.gn
    • components/data_reduction_proxy/core/common/data_reduction_proxy_headers.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h
  83. [Extensions Click-to-Script] Remove granted hosts when changing access

    Changed by Devlin Cronin - rdevlin.croninohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:03:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 23cd214fba4ed7ccfad450e53f6683dd428e58cc

    Comments

    [Extensions Click-to-Script] Remove granted hosts when changing access
    
    When transitioning from "on specific sites" to "on click", Chromium
    should remove specific granted sites from the extension. Do so, and
    add unittests for the same.
    
    Bug: 844128
    
    Change-Id: Icfa6c1f6449e94e30560a10cf43163f2fcedd996
    Reviewed-on: https://chromium-review.googlesource.com/1133775
    Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574420}

    Changed files

    • chrome/browser/extensions/api/developer_private/developer_private_api.cc
    • chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc
  84. Reland of: Add mojom call to send resource loading hints from browser to renderer.

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:02:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dc97029f96fedad41b8600011d6c155810e50fe6

    Comments

    Reland of: Add mojom call to send resource loading hints from browser to renderer.
    
    The mojom call is send only when resource loading hints feature is
    enabled and the connection is slow.
    
    This is a reland of the CL that got reverted due to flaky
    browsertest. This reland is quite similar to the reverted CL,
    except for some changes in the browsertest.
    
    PS#1 is the original CL that got reverted.
    
    The fix is to retry fetching of histograms from the renderers.
    Note that previews_browsertest are currently enabled only on Android.
    So, it's possible that the same flakiness bug is affecting the
    browser tests on Linux in this CL.
    
    Bug: 854666
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I753e488bef7318e43530a5594a94b24bd09295bb
    TBR: rkaplow@chromium.org, dcheng@chromium.org, pkasting@chromium.org, kinuko@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/1131918
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574419}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/chrome_content_renderer_manifest_overlay.json
    • chrome/browser/previews/previews_browsertest.cc
    • chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc
    • chrome/browser/previews/resource_loading_hints/resource_loading_hints_web_contents_observer.cc
    • chrome/browser/previews/resource_loading_hints/resource_loading_hints_web_contents_observer.h
    • chrome/browser/ui/tab_helpers.cc
    • chrome/test/BUILD.gn
    • chrome/test/data/previews/resource_loading_hints.html
    • chrome/test/data/previews/resource_loading_hints_with_no_transform_header.html
    • chrome/test/data/previews/resource_loading_hints_with_no_transform_header.html.mock-http-headers
    • components/optimization_guide/proto/hints.proto
    • components/optimization_guide/test_component_creator.cc
    • components/optimization_guide/test_component_creator.h
    • components/previews/content/previews_content_util.cc
    • components/previews/content/previews_decider_impl.cc
    • testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
    • third_party/blink/public/mojom/BUILD.gn
    • third_party/blink/public/mojom/loader/previews_resource_loading_hints.mojom
    • third_party/blink/renderer/controller/blink_initializer.cc
    • third_party/blink/renderer/core/frame/local_frame.cc
    • third_party/blink/renderer/core/frame/local_frame.h
    • third_party/blink/renderer/core/loader/BUILD.gn
    • third_party/blink/renderer/core/loader/base_fetch_context.cc
    • third_party/blink/renderer/core/loader/previews_resource_loading_hints_receiver_impl.cc
    • third_party/blink/renderer/core/loader/previews_resource_loading_hints_receiver_impl.h
    • tools/metrics/histograms/histograms.xml
  85. Mojo: Fix Mac Mach port brokering race

    Changed by Ken Rockot - rockotohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:01:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1e5b3af2899e6c4888da7ad662ca1d2928e01ce8

    Comments

    Mojo: Fix Mac Mach port brokering race
    
    https://crrev.com/0e45f8023 somehow lost this logic before
    landing, probably during extensive debugging churn. :{
    
    Without this, it's possible for Mach port transfer to fail
    when sending to a new process. Seems to have gone undetected
    in production so far, but https://crrev.com/3e126191 managed
    to trip over it consistently in ipc_tests.
    
    Bug: 753541
    Change-Id: I835dc5f26326718af678acd6199c285d709b9040
    Reviewed-on: https://chromium-review.googlesource.com/1134079
    Reviewed-by: Reilly Grant <reillyg@chromium.org>
    Commit-Queue: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574418}

    Changed files

    • mojo/core/channel_posix.cc
  86. [CrOS MultiDevice] Delete HostVerifierOperation.

    Changed by Kyle Horimoto - khorimotoohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 23:58:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dbe23b8a92e64607bd4ceb6a7a8ec9ec4f677a19

    Comments

    [CrOS MultiDevice] Delete HostVerifierOperation.
    
    After today's discussions, Bluetooth verification is no longer a step of
    the MultiDevice setup flow.
    
    Bug: 824568
    Change-Id: I155ec838c74f427cde820fbbbedcdf3a2a43b85b
    Reviewed-on: https://chromium-review.googlesource.com/1134474
    Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
    Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574417}

    Changed files

    • chromeos/services/multidevice_setup/BUILD.gn
    • chromeos/services/multidevice_setup/fake_host_verifier_operation.cc
    • chromeos/services/multidevice_setup/fake_host_verifier_operation.h
    • chromeos/services/multidevice_setup/host_verifier_operation.cc
    • chromeos/services/multidevice_setup/host_verifier_operation.h
    • chromeos/services/multidevice_setup/host_verifier_operation_impl.cc
    • chromeos/services/multidevice_setup/host_verifier_operation_impl.h
    • chromeos/services/multidevice_setup/host_verifier_operation_impl_unittest.cc
  87. Fix the mouse pointer for the omnibox.

    Changed by Avi Drissman - aviohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:54:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31de41a5cd7078ec8bc0b8bbb2dc82543a59f217

    Comments

    Fix the mouse pointer for the omnibox.
    
    While the results pane is showing, forward cursor requests to the
    underlying omnibox.
    
    Note that this won't actually show any changes until 851834 is fixed.
    
    BUG=836829,851834
    
    Change-Id: I9928fe8f690cc27f1844dbe1c0b3dae08082706d
    Reviewed-on: https://chromium-review.googlesource.com/1130167
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Reviewed-by: Sidney San Martín <sdy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574416}

    Changed files

    • chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.cc
  88. Update watchlist for breve-team

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:53:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c48822897f1344928af004051305c19b4269d470

    Comments

    Update watchlist for breve-team
    
    Change-Id: Ic12456b72ab2730e5ab1dc79ea44386deb90873d
    Reviewed-on: https://chromium-review.googlesource.com/1134349
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574415}

    Changed files

    • WATCHLISTS
  89. Revert "Update Chrome callsites that use MainThreadFrameObserver"

    Changed by Dirk Pranke - dprankeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:53:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5bc3c11ce575df33970f5b0f89160f38878ae9ce

    Comments

    Revert "Update Chrome callsites that use MainThreadFrameObserver"
    
    This reverts commit cb82e2e48313e755713f169fa151199fec459a02.
    
    Reason for revert: Test is failing on multiple builders, e.g.: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ASan%20Tests%20%28sandboxed%29/48812
    
    Original change's description:
    > Update Chrome callsites that use MainThreadFrameObserver
    > 
    > MainThreadFrameObserver does not guarantee that a compositor frame was actually
    > submitted. It however does synchronize the Renderer's main thread, which allows
    > for syncing Javascript execution in tests.
    > 
    > This updates two tests in chrome/browser to use RenderFrameSubmissionObserver
    > for synchronizing on compositor frame submission. As well as InputEventAckWaiter
    > for synchronizing on input event processing.
    > 
    > TEST=WebViewTest.InterstitialPageFocusedWidget,
    > WebViewBrowserPluginSpecificInteractiveTest.EnsureFocusSynced
    > 
    > Bug: 862683
    > Change-Id: Iae40b92dedf656898b9e77c6529ef118d89e0a6e
    > Reviewed-on: https://chromium-review.googlesource.com/1133960
    > Reviewed-by: Fady Samuel <fsamuel@chromium.org>
    > Commit-Queue: Jonathan Ross <jonross@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574335}
    
    TBR=jonross@chromium.org,fsamuel@chromium.org
    
    Change-Id: Ica0e795ebad4dd81248a8e89b6f02c53e972a203
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 862683
    Reviewed-on: https://chromium-review.googlesource.com/1133779
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574414}

    Changed files

    • chrome/browser/apps/guest_view/web_view_browsertest.cc
    • chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
  90. [VK] Remove OnWindowHierarchyChanged event handler.

    Changed by Darren Shen - shendohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:52:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c597e35ea365cc192bfad7ef1effc618e427004

    Comments

    [VK] Remove OnWindowHierarchyChanged event handler.
    
    In https://crrev.com/14200002, we handled OnWindowHierarchyChanged in
    KeyboardController, which calls OnTextInputStateChanged. Originally,
    the author of the CL wanted to call OnTextInputStateChanged when the
    keyboard is enabled (so that if there's a focused textfield, we would
    show the keyboard [*]). However, OnTextInputChanged requires that the
    keyboard window is attached to a parent, which does not happen until
    later in the code. Hence, the author moved the OnTextInputStateChanged
    call to OnWindowHierarchyChanged, where we know for sure that the
    keyboard window has been attached.
    
    However, with recent changes to KeyboardController, we explicitly
    attach in ActivateKeyboardInContainer, so we can just move the code
    there without issues.
    
    [*] This behaviour is no longer true. OnTextInputChanged can't show
    the keyboard anymore under those circumstances. It may be possible
    to remove the OnTextInputChanged call completely.
    
    Bug: 845780
    Change-Id: I8fb028f3b03435e43c902b40e8ffe48844be1ea3
    Reviewed-on: https://chromium-review.googlesource.com/1132259
    Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
    Commit-Queue: Darren Shen <shend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574413}

    Changed files

    • ui/keyboard/keyboard_controller.cc
    • ui/keyboard/keyboard_controller.h
  91. device/bluetooth: Add a flag to show all unfiltered devices.

    Changed by Sonny Sasaka - sonnysasakaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:47:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7fecfeda3c0d0e1d1e8c79b141a858cd669335fa

    Comments

    device/bluetooth: Add a flag to show all unfiltered devices.
    
    Newblue development needs to see all the discovered devices unfiltered,
    so this flag is useful for Newblue development and can be removed once
    Newblue is stable.
    
    Bug: 840517
    Change-Id: I65c95c567ebfb8dbb6d831bfb1e1219b153346c0
    Reviewed-on: https://chromium-review.googlesource.com/1130655
    Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
    Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574412}

    Changed files

    • ash/BUILD.gn
    • ash/DEPS
    • ash/system/bluetooth/tray_bluetooth_helper_unittest.cc
    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • device/base/features.cc
    • device/base/features.h
    • device/bluetooth/chromeos/bluetooth_utils.cc
    • device/bluetooth/dbus/bluez_dbus_manager.cc
    • tools/metrics/histograms/enums.xml
  92. Use three way flag for ChromeVox arc support

    Changed by Yuki Awano - yawanoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:45:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b51d325c2a6fdc8f7be04d394645da611dd8ccad

    Comments

    Use three way flag for ChromeVox arc support
    
    - Use three way flag for ChromeVox arc support. This allows developers
      to easily switch between TalkBack on arc and ChromeVox arc support.
    - This CL also changes default to disabled (TalkBack on arc).
    
    Bug: 855310
    Test: None
    Change-Id: I301657798247da20eaf9ad734987b8d40790af1d
    Reviewed-on: https://chromium-review.googlesource.com/1130963
    Commit-Queue: Yuki Awano <yawano@chromium.org>
    Reviewed-by: David Tseng <dtseng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574411}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.h
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • chromeos/chromeos_features.cc
    • chromeos/chromeos_features.h
    • chromeos/chromeos_switches.cc
    • chromeos/chromeos_switches.h
    • tools/metrics/histograms/enums.xml
  93. No removed or inserted text events on static text nodes

    Changed by Aaron Leventhal - aleventhalohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:45:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0d103e4761986c5f14e7b904ddf0b143fb1b6799

    Comments

    No removed or inserted text events on static text nodes
    
    Fire only 1 set of text removed/inserted events,
    only on the parent hypertext (not on the static text).
    This helps avoid redundant live region change announcements.
    
    Bug: 778478
    Change-Id: Ic68aab54d46c98576169ecb2146cd6414413e6ac
    Reviewed-on: https://chromium-review.googlesource.com/1134199
    Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574410}

    Changed files

    • content/test/data/accessibility/event/live-region-change-expected-win.txt
    • content/test/data/accessibility/event/text-changed-expected-win.txt
    • ui/accessibility/platform/ax_platform_node_win.cc
  94. Surface Synchronization: Make Submission Flow Trace Less Noisy

    Changed by Fady Samuel - fsamuelohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:38:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 852c66f84007b6c5ee4eb6150ec2534d5797b5b4

    Comments

    Surface Synchronization: Make Submission Flow Trace Less Noisy
    
    Only log an event if the LocalSurfaceId has changed instead of on
    every submit and receipt of CompositorFrames.
    
    Bug: 672962
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I4814ec0aaa9c204864d5c5df0c4a359d4ef3bb28
    Reviewed-on: https://chromium-review.googlesource.com/1134027
    Commit-Queue: Fady Samuel <fsamuel@chromium.org>
    Reviewed-by: Saman Sami <samans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574409}

    Changed files

    • cc/mojo_embedder/async_layer_tree_frame_sink.cc
    • cc/trees/layer_tree_host.cc
    • components/viz/common/surfaces/parent_local_surface_id_allocator.cc
    • components/viz/service/frame_sinks/compositor_frame_sink_support.cc
    • components/viz/service/surfaces/surface.cc
  95. Remove extra spaces in WindowTree logs

    Changed by Mike Wasserman - mswohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:37:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59774f864d141afa5605ddba9ad153899c4dc295

    Comments

    Remove extra spaces in WindowTree logs
    
    Makes the debug logging output more consistent
    
    Bug: None
    Test: None
    Change-Id: Ib6ca05df6e06c7bbb31ffca7c027707af7d67966
    Reviewed-on: https://chromium-review.googlesource.com/1134428
    Commit-Queue: Scott Violet <sky@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574408}

    Changed files

    • services/ui/ws2/window_tree.cc
  96. Roll HarfBuzz to 1.8.3

    Changed by Dominik Röttsches - drottohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:37:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d5684ce09c352eb8ca64390c1fdb5f3de5e6bf60

    Comments

    Roll HarfBuzz to 1.8.3
    
    https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/058708a665cdd9e796581dbcf60a5778d3f5e240..2b76767bf572364d3d647cdd139f2044a7ad06b2
    
    And disable HB_VECTOR_SIZE define now that HarfBuzz has temporarily
    completed disabled compiler-assisted vectorisation.
    
    Bug: 860250, 862607
    Change-Id: If00101a279b23f5807a85973718183b33647195d
    Reviewed-on: https://chromium-review.googlesource.com/1133384
    Reviewed-by: Ben Wagner <bungeman@chromium.org>
    Commit-Queue: Dominik Röttsches <drott@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574407}

    Changed files

    • DEPS
    • third_party/harfbuzz-ng/BUILD.gn
    • third_party/harfbuzz-ng/README.chromium
  97. [NTP] Remove transition duration for MV tile hover states

    Changed by kristipark - kristiparkohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:36:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c37fbfabcaaeabb50bbbf52dfa75c6fa7491e298

    Comments

    [NTP] Remove transition duration for MV tile hover states
    
    Bug: 851656
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I4fc218b0dba1b0dd569088a1665792b933c86ada
    Reviewed-on: https://chromium-review.googlesource.com/1133686
    Commit-Queue: Kristi Park <kristipark@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574406}

    Changed files

    • chrome/browser/resources/local_ntp/most_visited_single.css
  98. Clean up MASH_DEPRECATED in FlagWarningTray and test

    Changed by James Cook - jamescookohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:36:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0795efc4ba54976c1ea978ec4c1fafe49e3ed77a

    Comments

    Clean up MASH_DEPRECATED in FlagWarningTray and test
    
    We don't run ash_unittests with --enable-features=Mash anymore, so
    manually turn on the flag to test the feature.
    
    Bug: 840391
    Test: ash_unittests
    Change-Id: Idb61128d9a65cbc6e93095683247c3e8cd714a9d
    Reviewed-on: https://chromium-review.googlesource.com/1134418
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574405}

    Changed files

    • ash/system/flag_warning/flag_warning_tray.cc
    • ash/system/flag_warning/flag_warning_tray_unittest.cc
  99. Roll src/native_client 0ba35b21089a..e6ce828ef60c (1 commits)

    Changed by nacl-chromium-autoroll - nacl-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 23:32:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 382c1d7689514b2bb3449f2ca14209ad5e75c472

    Comments

    Roll src/native_client 0ba35b21089a..e6ce828ef60c (1 commits)
    
    https://chromium.googlesource.com/native_client/src/native_client.git/+log/0ba35b21089a..e6ce828ef60c
    
    
    git log 0ba35b21089a..e6ce828ef60c --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 thomasanderson@chromium.org Revert "Trigger a buildbot cycle on client.nacl.toolchain"
    
    
    Created with:
      gclient setdep -r src/native_client@e6ce828ef60c
    
    The AutoRoll server is located here: https://nacl-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:None
    TBR=mseaborn@chromium.org
    
    Change-Id: I96d892a8a5520b5394bf8929daf655f2ab9f95e9
    Reviewed-on: https://chromium-review.googlesource.com/1133873
    Reviewed-by: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574404}

    Changed files

    • DEPS
  100. Reorg DefaultAudioDestinationNode

    Changed by Hongchan Choi - hongchanohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:30:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a4247ad3b2fda13e8f4d57b68b639bea7d78df02

    Comments

    Reorg DefaultAudioDestinationNode
    
    No renaming or functional change. Just moving and grouping things
    around. Plus, some clarification/simplification of comments.
    
    Bug: 854229
    Change-Id: I1a4fd3cdaf7fd41fd6c30fc199f281b46b061dc2
    Reviewed-on: https://chromium-review.googlesource.com/1133715
    Commit-Queue: Hongchan Choi <hongchan@chromium.org>
    Reviewed-by: Raymond Toy <rtoy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574403}

    Changed files

    • third_party/blink/renderer/modules/webaudio/default_audio_destination_node.cc
    • third_party/blink/renderer/modules/webaudio/default_audio_destination_node.h
  101. <blame list capped at 100 commits>

    Changed by <blame list capped at 100 commits> -
    Changed at N/A
    Repository
    Branch
    Revision

    Comments

    <blame list capped at 100 commits>