Home | Search | chromium - Builders
Login

Builder Mac FYI Experimental Retina Release (NVIDIA) Build 2933 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revisione324812251510778815829c1b07043b6d53f8414
Got Revisione324812251510778815829c1b07043b6d53f8414

Execution:

Steps and Logfiles:

Show:
  1. ( 344 ms ) setup_build
    running recipe: "chromium"
  2. ( 217 ms ) report builders
     
    running tester 'Mac FYI Experimental Retina Release (NVIDIA)' on master 'chromium.gpu.fyi'
  3. ( 1 mins 30 secs ) bot_update
    [77GB/232GB used (33%)]
  4. ( 746 ms ) swarming.py --version
    0.14
  5. ( 171 ms ) ensure_installed
  6. ( 14 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
  8. ( 367 ms ) lookup builder GN args
     
    build_angle_gles1_conform_tests = true
    dcheck_always_on = true
    ffmpeg_branding = "Chrome"
    internal_gles2_conform_tests = true
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  9. ( 366 ms ) build directory
  10. ( 379 ms ) find isolated tests
  11. ( 2 secs ) angle_end2end_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Max shard duration: 0:01:40.242614 (shard #1)
    Min shard duration: 0:01:34.577010 (shard #0)
  12. ( 3 mins 31 secs ) angle_unittests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:03:24.264350
  13. ( 2 mins 17 secs ) tab_capture_end2end_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:02:11.014949
  14. ( 1 secs ) dawn_end2end_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Max shard duration: 25s (shard #2)
    Min shard duration: 22s (shard #1)
  15. ( 1 mins 43 secs ) gl_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:01:38.422998
  16. ( 32 secs ) gl_unittests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 28s
  17. ( 5 mins 18 secs ) gles2_conform_test on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:05:12.582244
  18. ( 1 mins 2 secs ) gpu_unittests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 56s
  19. ( 1 mins 3 secs ) services_unittests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 58s
  20. ( 4 mins 23 secs ) context_lost_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:04:19.168893
    Total tests: 10
    * Passed: 10 (10 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  21. ( 1 mins 22 secs ) depth_capture_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:01:17.009755
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  22. ( 3 mins 33 secs ) gpu_process_launch_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Pending time: 31s
    Shard duration: 0:02:55.801604
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  23. ( 2 mins 5 secs ) hardware_accelerated_feature_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Pending time: 47s
    Shard duration: 0:01:12.221587
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  24. ( 1 mins 14 secs ) info_collection_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:01:11.467469
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  25. ( 1 mins 52 secs ) maps_pixel_test on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:01:48.880610
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  26. ( 13 mins 19 secs ) pixel_test on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:13:10.769072
    Total tests: 64
    * Passed: 61 (61 expected, 0 unexpected)
    * Skipped: 3 (3 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  27. ( 2 mins 29 secs ) screenshot_sync_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:02:25.005226
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  28. ( 5 mins 1 secs ) trace_test on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Shard duration: 0:04:50.081497
    Total tests: 48
    * Passed: 24 (24 expected, 0 unexpected)
    * Skipped: 24 (24 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 38 mins 4 secs ) webgl2_conformance_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Max pending time: 0:03:19.066834 (shard #19)
    Max shard duration: 0:34:43.744010 (shard #18)
    Min shard duration: 0:08:51.838958 (shard #8)
    Total tests: 2800
    * Passed: 2735 (2735 expected, 0 unexpected)
    * Skipped: 65 (65 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 28 mins 38 secs ) webgl_conformance_tests on NVIDIA GPU on Mac Retina on Mac-10.13.6
    Run on OS: 'Mac-10.13.6'
    Max shard duration: 0:28:18.701142 (shard #1)
    Min shard duration: 0:10:08.810642 (shard #0)
    Total tests: 936
    * Passed: 930 (930 expected, 0 unexpected)
    * Skipped: 6 (6 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  31. ( 276 ms ) Tests statistics
     
    Stats
    Total shards: 46
    Total runtime: 10:25:54.241716
     

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "build90-m9" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544156483796418, "id": "8927828286805502512", "project": "chromium", "tags": ["builder:Mac FYI Experimental Retina Release (NVIDIA)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/e324812251510778815829c1b07043b6d53f8414", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Mac Builder", "parent_buildnumber:30404", "scheduler_invocation_id:9093258349024947648", "scheduler_job_id:chromium/Mac FYI Experimental Retina Release (NVIDIA)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Mac FYI Experimental Retina Release (NVIDIA)" setup_build
buildnumber 2933 setup_build
mastername "chromium.gpu.fyi" setup_build
parent_buildername "GPU FYI Mac Builder" setup_build
parent_got_angle_revision "c3e3731cd3b2a3044f1bdec906c8557cc3edae77" setup_build
parent_got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" setup_build
parent_got_dawn_revision "0f50114b3c6849238eedf95236137d614fed4be2" setup_build
parent_got_nacl_revision "17af1e818981ebf2c492a678d4d31c9e1ee37fc7" setup_build
parent_got_revision "e324812251510778815829c1b07043b6d53f8414" setup_build
parent_got_revision_cp "refs/heads/master@{#614580}" setup_build
parent_got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" setup_build
parent_got_v8_revision "2192eb7f7ea45e3a7ee625cf3156f1469abed8b8" setup_build
parent_got_v8_revision_cp "refs/heads/7.3.55@{#1}" setup_build
parent_got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25919}" setup_build
parent_mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "e324812251510778815829c1b07043b6d53f8414" setup_build
swarm_hashes {"angle_end2end_tests": "420b61560fed9d7830b2dc58099a5027c01eaaeb", "angle_unittests": "de009fcdce62e6d638c7fe29dfa5126c65994015", "browser_tests": "e22e542d9edc65c2839c73e7812ae5307400962a", "dawn_end2end_tests": "61d8723698e6515c4fa52f7b27b69b09f0e130e9", "gl_tests": "b00f1bda847fc71aa6af6d27c54f910781e78925", "gl_unittests": "b1fec14b7ffce6260f6180ed27fabcd557b04595", "gles2_conform_test": "dd5e040401e6aa50cf928e77cf40525fa080803e", "gpu_unittests": "8afb63f52463bc11f36b04db61c8f4b384393c87", "services_unittests": "da9d6a3969c314cbceff60101b3ed13c2e9da0b9", "swiftshader_unittests": "fd52f7816096b6ce66276d0c07ad21023b2e9007", "telemetry_gpu_integration_test": "535b95bef75b2b851b5ae98a85a4ff11b34ab35a"} setup_build
got_angle_revision "132d15c217e0363626a5d789861b75122f718b5d" bot_update
got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" bot_update
got_dawn_revision "0f50114b3c6849238eedf95236137d614fed4be2" bot_update
got_nacl_revision "17af1e818981ebf2c492a678d4d31c9e1ee37fc7" bot_update
got_revision "e324812251510778815829c1b07043b6d53f8414" bot_update
got_revision_cp "refs/heads/master@{#614580}" bot_update
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" bot_update
got_v8_revision "2192eb7f7ea45e3a7ee625cf3156f1469abed8b8" bot_update
got_v8_revision_cp "refs/heads/7.3.55@{#1}" bot_update
got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25919}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. chrome-release-bot (chrome-release-botohnoyoudont@chromium.org)
  2. Takashi Sakamoto (tasakohnoyoudont@google.com)
  3. Takashi Sakamoto (tasakohnoyoudont@google.com)
  4. Dan Beam (dbeamohnoyoudont@chromium.org)

Timing:

Create Friday, 07-Dec-18 04:21:23 UTC
Start Friday, 07-Dec-18 04:21:27 UTC
End Friday, 07-Dec-18 06:23:00 UTC
Pending 3 secs
Execution 2 hrs 1 mins

All Changes:

  1. Updating trunk VERSION from 3633.0 to 3634.0

    Changed by chrome-release-bot - chrome-release-botohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:11:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e324812251510778815829c1b07043b6d53f8414

    Comments

    Updating trunk VERSION from 3633.0 to 3634.0
    
    # This is an automated release commit.
    # Do not revert without consulting chrome-pmo@google.com.
    NOAUTOREVERT=true
    TBR=mmoss@chromium.org
    
    Change-Id: I042e2caf928b9a12422f14eccec3e8f33ead12d9
    Reviewed-on: https://chromium-review.googlesource.com/c/1366874
    Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614580}

    Changed files

    • chrome/VERSION
  2. Revert "cros: Move most event/widget handling logic out of LoginBubble"

    Changed by Takashi Sakamoto - tasakohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 03:49:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bb9ca465cac1a3ec4d0670844865b40efb003c11

    Comments

    Revert "cros: Move most event/widget handling logic out of LoginBubble"
    
    This reverts commit a61287973e8f4522ed673ac1a77de0dc56eb1bc8.
    
    Reason for revert: Suspect Failure single_process_mash_ash_unittests Failure ash_unittests:
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/16943
    https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927839167159249024/+/steps/single_process_mash_ash_unittests/0/logs/LoginExpandedPublicAccountViewTest.ChangeMenuSelection/0
    ---
    [ RUN      ] LoginExpandedPublicAccountViewTest.ChangeMenuSelection
    Received signal 11 SEGV_MAPERR ffffe03f000008fe
    #0 0x5631a3caedbf base::debug::StackTrace::StackTrace()
    #1 0x5631a3cae941 base::debug::(anonymous namespace)::StackDumpSignalHandler()
    #2 0x7faa9920f330 <unknown>
    #3 0x5631a3aafbbf ash::LoginBubble::~LoginBubble()
    #4 0x5631a3ab806c ash::RightPaneView::~RightPaneView()
    #5 0x5631a3ab810e ash::RightPaneView::~RightPaneView()
    #6 0x5631a40385d4 views::View::~View()
    #7 0x5631a3ab6df9 ash::LoginExpandedPublicAccountView::~LoginExpandedPublicAccountView()
    #8 0x5631a40385d4 views::View::~View()
    #9 0x5631a300afce ash::(anonymous namespace)::DragTestView::~DragTestView()
    #10 0x5631a4039b42 views::View::DoRemoveChildView()
    #11 0x5631a403a175 views::View::RemoveAllChildViews()
    #12 0x5631a4043b81 views::internal::RootView::~RootView()
    #13 0x5631a400ef0e views::MenuHostRootView::~MenuHostRootView()
    #14 0x5631a404615f views::Widget::~Widget()
    #15 0x5631a34d645e exo::(anonymous namespace)::ShellSurfaceWidget::~ShellSurfaceWidget()
    #16 0x5631a30c36f0 ash::LoginTestBase::TearDown()
    
    Original change's description:
    > cros: Move most event/widget handling logic out of LoginBubble
    > 
    > Changes made:
    > - Move the (keyboard/click/tap) event handling logic into a
    >   LoginBubbleHandler class.
    > - Move the widget handling into LoginBaseBubbleView itself
    > 
    > Bug: 912658
    > Change-Id: Ia1a9bf4b8d847ef74ef1716e73dfe1b16b8d19b2
    > Reviewed-on: https://chromium-review.googlesource.com/c/1366516
    > Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
    > Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614544}
    
    TBR=jdufault@chromium.org,qnnguyen@chromium.org
    
    Change-Id: Ia9b9059f24f6aa6a8551c5c6bc5c76caafe592df
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 912658
    Reviewed-on: https://chromium-review.googlesource.com/c/1367070
    Reviewed-by: Takashi Sakamoto <tasak@google.com>
    Commit-Queue: Takashi Sakamoto <tasak@google.com>
    Cr-Commit-Position: refs/heads/master@{#614579}

    Changed files

    • ash/login/ui/login_base_bubble_view.cc
    • ash/login/ui/login_base_bubble_view.h
    • ash/login/ui/login_bubble.cc
    • ash/login/ui/login_bubble.h
  3. Revert "Updating XTBs based on .GRDs from branch master"

    Changed by Takashi Sakamoto - tasakohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 03:43:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df02e792b693ed5007b5c8c4866203219bedfd20

    Comments

    Revert "Updating XTBs based on .GRDs from branch master"
    
    This reverts commit c7424053a784c4d07dcd4617d68a1f2ac7f9657b.
    
    Reason for revert: suspect Android compile failure:
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel
    https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927834375124899248/+/steps/compile/0/stdout
    ---
    ../resource_zips/chrome/android/chrome_strings_grd.resources.zip/values-fr/android_chrome_strings.xml:364 Inconsistent number of arguments in formatting string `data_reduction_benefits_description`; found both 0 and 1: StringFormatCount [warning]
    <string name="data_reduction_benefits_description">"En mode simplifié, Chrome charge les pages plus rapidement et consomme jusqu\'à 60 % de données en moins."</string>
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../resource_zips/chrome/android/chrome_strings_grd.resources.zip/values-fr/android_chrome_strings.xml:389 Inconsistent number of arguments in formatting string `data_reduction_promo_summary`; found both 0 and 1: StringFormatCount [warning]
    <string name="data_reduction_promo_summary">"En mode simplifié, Chrome charge les pages plus rapidement et consomme jusqu\'à 60 % de données en moins. La technologie cloud de Google optimise les pages que vous consultez."</string>
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    Original change's description:
    > Updating XTBs based on .GRDs from branch master
    > 
    > R=​abdulsyed@chromium.org
    > 
    > Change-Id: Ibc94ee5be9db75306313d34881e4026a681eec1d
    > Reviewed-on: https://chromium-review.googlesource.com/c/1366870
    > Reviewed-by: Krishna Govind <govind@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614569}
    
    TBR=govind@chromium.org,abdulsyed@chromium.org
    
    Change-Id: I4dfd803c9c148e5d6e3335d11e06fd61728fe548
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/1366465
    Reviewed-by: Takashi Sakamoto <tasak@google.com>
    Commit-Queue: Takashi Sakamoto <tasak@google.com>
    Cr-Commit-Position: refs/heads/master@{#614578}

    Changed files

    • ash/components/strings/ash_components_strings_te.xtb
    • ash/strings/ash_strings_am.xtb
    • ash/strings/ash_strings_ar.xtb
    • ash/strings/ash_strings_bn.xtb
    • ash/strings/ash_strings_ca.xtb
    • ash/strings/ash_strings_cs.xtb
    • ash/strings/ash_strings_de.xtb
    • ash/strings/ash_strings_el.xtb
    • ash/strings/ash_strings_en-GB.xtb
    • ash/strings/ash_strings_fa.xtb
    • ash/strings/ash_strings_fi.xtb
    • ash/strings/ash_strings_fr.xtb
    • ash/strings/ash_strings_gu.xtb
    • ash/strings/ash_strings_hr.xtb
    • ash/strings/ash_strings_hu.xtb
    • ash/strings/ash_strings_id.xtb
    • ash/strings/ash_strings_it.xtb
    • ash/strings/ash_strings_kn.xtb
    • ash/strings/ash_strings_lt.xtb
    • ash/strings/ash_strings_lv.xtb
    • ash/strings/ash_strings_ml.xtb
    • ash/strings/ash_strings_nl.xtb
    • ash/strings/ash_strings_pl.xtb
    • ash/strings/ash_strings_pt-BR.xtb
    • ash/strings/ash_strings_pt-PT.xtb
    • ash/strings/ash_strings_ru.xtb
    • ash/strings/ash_strings_sk.xtb
    • ash/strings/ash_strings_sl.xtb
    • ash/strings/ash_strings_sr.xtb
    • ash/strings/ash_strings_sv.xtb
    • ash/strings/ash_strings_sw.xtb
    • ash/strings/ash_strings_te.xtb
    • ash/strings/ash_strings_th.xtb
    • ash/strings/ash_strings_tr.xtb
    • ash/strings/ash_strings_uk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_am.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ar.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_bg.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_bn.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ca.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_cs.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_da.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_de.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_el.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_en-GB.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_es-419.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_es.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fa.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fil.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_gu.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hu.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_id.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_it.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_iw.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ja.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_kn.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_lt.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_lv.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ml.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_nl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pt-BR.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pt-PT.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ru.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sv.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sw.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ta.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_te.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_th.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_tr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_uk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_zh-CN.xtb
    • chrome/app/resources/chromium_strings_te.xtb
    • chrome/app/resources/generated_resources_am.xtb
    • chrome/app/resources/generated_resources_ar.xtb
    • chrome/app/resources/generated_resources_bg.xtb
    • chrome/app/resources/generated_resources_bn.xtb
    • chrome/app/resources/generated_resources_ca.xtb
    • chrome/app/resources/generated_resources_cs.xtb
    • chrome/app/resources/generated_resources_da.xtb
    • chrome/app/resources/generated_resources_de.xtb
    • chrome/app/resources/generated_resources_el.xtb
    • chrome/app/resources/generated_resources_en-GB.xtb
    • chrome/app/resources/generated_resources_es-419.xtb
    • chrome/app/resources/generated_resources_es.xtb
    • chrome/app/resources/generated_resources_et.xtb
    • chrome/app/resources/generated_resources_fa.xtb
    • chrome/app/resources/generated_resources_fi.xtb
    • chrome/app/resources/generated_resources_fil.xtb
    • chrome/app/resources/generated_resources_fr.xtb
    • chrome/app/resources/generated_resources_gu.xtb
    • chrome/app/resources/generated_resources_hi.xtb
    • chrome/app/resources/generated_resources_hr.xtb
    • chrome/app/resources/generated_resources_hu.xtb
    • chrome/app/resources/generated_resources_id.xtb
    • chrome/app/resources/generated_resources_it.xtb
    • chrome/app/resources/generated_resources_iw.xtb
    • chrome/app/resources/generated_resources_ja.xtb
    • chrome/app/resources/generated_resources_kn.xtb
    • chrome/app/resources/generated_resources_ko.xtb
    • chrome/app/resources/generated_resources_lt.xtb
    • chrome/app/resources/generated_resources_lv.xtb
    • chrome/app/resources/generated_resources_ml.xtb
    • chrome/app/resources/generated_resources_mr.xtb
    • chrome/app/resources/generated_resources_ms.xtb
    • chrome/app/resources/generated_resources_nl.xtb
    • chrome/app/resources/generated_resources_no.xtb
    • chrome/app/resources/generated_resources_pl.xtb
    • chrome/app/resources/generated_resources_pt-BR.xtb
    • chrome/app/resources/generated_resources_pt-PT.xtb
    • chrome/app/resources/generated_resources_ro.xtb
    • chrome/app/resources/generated_resources_ru.xtb
    • chrome/app/resources/generated_resources_sk.xtb
    • chrome/app/resources/generated_resources_sl.xtb
    • chrome/app/resources/generated_resources_sr.xtb
    • chrome/app/resources/generated_resources_sv.xtb
    • chrome/app/resources/generated_resources_sw.xtb
    • chrome/app/resources/generated_resources_ta.xtb
    • chrome/app/resources/generated_resources_te.xtb
    • chrome/app/resources/generated_resources_th.xtb
    • chrome/app/resources/generated_resources_tr.xtb
    • chrome/app/resources/generated_resources_uk.xtb
    • chrome/app/resources/generated_resources_vi.xtb
    • chrome/app/resources/generated_resources_zh-CN.xtb
    • chrome/app/resources/generated_resources_zh-TW.xtb
    • chrome/app/resources/google_chrome_strings_te.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_am.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ar.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_bg.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ca.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_cs.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_da.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_de.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_el.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_en-GB.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_es-419.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_es.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_et.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fa.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fil.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hu.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_id.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_it.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ja.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ko.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_lt.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_lv.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ms.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_nl.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_no.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pl.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pt-BR.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pt-PT.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ro.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ru.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sk.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sv.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sw.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ta.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_th.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_tr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_uk.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_vi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-CN.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-TW.xtb
    • components/policy/resources/policy_templates_am.xtb
    • components/policy/resources/policy_templates_ar.xtb
    • components/policy/resources/policy_templates_bn.xtb
    • components/policy/resources/policy_templates_ca.xtb
    • components/policy/resources/policy_templates_cs.xtb
    • components/policy/resources/policy_templates_de.xtb
    • components/policy/resources/policy_templates_el.xtb
    • components/policy/resources/policy_templates_en-GB.xtb
    • components/policy/resources/policy_templates_es-419.xtb
    • components/policy/resources/policy_templates_fa.xtb
    • components/policy/resources/policy_templates_fi.xtb
    • components/policy/resources/policy_templates_fr.xtb
    • components/policy/resources/policy_templates_hr.xtb
    • components/policy/resources/policy_templates_id.xtb
    • components/policy/resources/policy_templates_it.xtb
    • components/policy/resources/policy_templates_kn.xtb
    • components/policy/resources/policy_templates_ml.xtb
    • components/policy/resources/policy_templates_nl.xtb
    • components/policy/resources/policy_templates_pl.xtb
    • components/policy/resources/policy_templates_pt-BR.xtb
    • components/policy/resources/policy_templates_pt-PT.xtb
    • components/policy/resources/policy_templates_ru.xtb
    • components/policy/resources/policy_templates_sk.xtb
    • components/policy/resources/policy_templates_sr.xtb
    • components/policy/resources/policy_templates_sv.xtb
    • components/policy/resources/policy_templates_sw.xtb
    • components/policy/resources/policy_templates_ta.xtb
    • components/policy/resources/policy_templates_te.xtb
    • components/policy/resources/policy_templates_th.xtb
    • components/policy/resources/policy_templates_tr.xtb
    • components/policy/resources/policy_templates_uk.xtb
    • components/policy/resources/policy_templates_vi.xtb
    • components/strings/components_strings_am.xtb
    • components/strings/components_strings_ar.xtb
    • components/strings/components_strings_bg.xtb
    • components/strings/components_strings_bn.xtb
    • components/strings/components_strings_ca.xtb
    • components/strings/components_strings_cs.xtb
    • components/strings/components_strings_da.xtb
    • components/strings/components_strings_de.xtb
    • components/strings/components_strings_el.xtb
    • components/strings/components_strings_en-GB.xtb
    • components/strings/components_strings_es-419.xtb
    • components/strings/components_strings_es.xtb
    • components/strings/components_strings_et.xtb
    • components/strings/components_strings_fa.xtb
    • components/strings/components_strings_fi.xtb
    • components/strings/components_strings_fil.xtb
    • components/strings/components_strings_fr.xtb
    • components/strings/components_strings_gu.xtb
    • components/strings/components_strings_hi.xtb
    • components/strings/components_strings_hr.xtb
    • components/strings/components_strings_hu.xtb
    • components/strings/components_strings_id.xtb
    • components/strings/components_strings_it.xtb
    • components/strings/components_strings_iw.xtb
    • components/strings/components_strings_ja.xtb
    • components/strings/components_strings_kn.xtb
    • components/strings/components_strings_ko.xtb
    • components/strings/components_strings_lt.xtb
    • components/strings/components_strings_lv.xtb
    • components/strings/components_strings_ml.xtb
    • components/strings/components_strings_mr.xtb
    • components/strings/components_strings_ms.xtb
    • components/strings/components_strings_nl.xtb
    • components/strings/components_strings_no.xtb
    • components/strings/components_strings_pl.xtb
    • components/strings/components_strings_pt-BR.xtb
    • components/strings/components_strings_pt-PT.xtb
    • components/strings/components_strings_ro.xtb
    • components/strings/components_strings_ru.xtb
    • components/strings/components_strings_sk.xtb
    • components/strings/components_strings_sl.xtb
    • components/strings/components_strings_sr.xtb
    • components/strings/components_strings_sv.xtb
    • components/strings/components_strings_sw.xtb
    • components/strings/components_strings_ta.xtb
    • components/strings/components_strings_te.xtb
    • components/strings/components_strings_th.xtb
    • components/strings/components_strings_tr.xtb
    • components/strings/components_strings_uk.xtb
    • components/strings/components_strings_vi.xtb
    • components/strings/components_strings_zh-CN.xtb
    • components/strings/components_strings_zh-TW.xtb
    • content/app/strings/translations/content_strings_te.xtb
    • extensions/strings/extensions_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_google_chrome_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_strings_am.xtb
    • ios/chrome/app/strings/resources/ios_strings_ar.xtb
    • ios/chrome/app/strings/resources/ios_strings_bn.xtb
    • ios/chrome/app/strings/resources/ios_strings_ca.xtb
    • ios/chrome/app/strings/resources/ios_strings_cs.xtb
    • ios/chrome/app/strings/resources/ios_strings_de.xtb
    • ios/chrome/app/strings/resources/ios_strings_el.xtb
    • ios/chrome/app/strings/resources/ios_strings_en-GB.xtb
    • ios/chrome/app/strings/resources/ios_strings_fa.xtb
    • ios/chrome/app/strings/resources/ios_strings_fi.xtb
    • ios/chrome/app/strings/resources/ios_strings_fil.xtb
    • ios/chrome/app/strings/resources/ios_strings_fr.xtb
    • ios/chrome/app/strings/resources/ios_strings_gu.xtb
    • ios/chrome/app/strings/resources/ios_strings_hr.xtb
    • ios/chrome/app/strings/resources/ios_strings_hu.xtb
    • ios/chrome/app/strings/resources/ios_strings_id.xtb
    • ios/chrome/app/strings/resources/ios_strings_it.xtb
    • ios/chrome/app/strings/resources/ios_strings_ja.xtb
    • ios/chrome/app/strings/resources/ios_strings_kn.xtb
    • ios/chrome/app/strings/resources/ios_strings_lt.xtb
    • ios/chrome/app/strings/resources/ios_strings_lv.xtb
    • ios/chrome/app/strings/resources/ios_strings_ml.xtb
    • ios/chrome/app/strings/resources/ios_strings_nl.xtb
    • ios/chrome/app/strings/resources/ios_strings_pl.xtb
    • ios/chrome/app/strings/resources/ios_strings_pt-BR.xtb
    • ios/chrome/app/strings/resources/ios_strings_pt-PT.xtb
    • ios/chrome/app/strings/resources/ios_strings_ru.xtb
    • ios/chrome/app/strings/resources/ios_strings_sk.xtb
    • ios/chrome/app/strings/resources/ios_strings_sl.xtb
    • ios/chrome/app/strings/resources/ios_strings_sr.xtb
    • ios/chrome/app/strings/resources/ios_strings_sv.xtb
    • ios/chrome/app/strings/resources/ios_strings_sw.xtb
    • ios/chrome/app/strings/resources/ios_strings_ta.xtb
    • ios/chrome/app/strings/resources/ios_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_strings_th.xtb
    • ios/chrome/app/strings/resources/ios_strings_tr.xtb
    • ios/chrome/app/strings/resources/ios_strings_uk.xtb
    • remoting/resources/remoting_strings_am.xtb
    • remoting/resources/remoting_strings_ar.xtb
    • remoting/resources/remoting_strings_bn.xtb
    • remoting/resources/remoting_strings_es.xtb
    • remoting/resources/remoting_strings_gu.xtb
    • remoting/resources/remoting_strings_hu.xtb
    • remoting/resources/remoting_strings_id.xtb
    • remoting/resources/remoting_strings_kn.xtb
    • remoting/resources/remoting_strings_lt.xtb
    • remoting/resources/remoting_strings_lv.xtb
    • remoting/resources/remoting_strings_ml.xtb
    • remoting/resources/remoting_strings_ru.xtb
    • remoting/resources/remoting_strings_sl.xtb
    • remoting/resources/remoting_strings_sr.xtb
    • remoting/resources/remoting_strings_te.xtb
    • remoting/resources/remoting_strings_th.xtb
    • remoting/resources/remoting_strings_tr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_am.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ar.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_bg.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_bn.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ca.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_cs.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_da.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_de.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_el.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_en-GB.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_es-419.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_es.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_et.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fa.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fi.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fil.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_gu.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_hi.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_hr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_hu.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_id.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_it.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_iw.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ja.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_kn.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ko.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_lt.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_lv.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ml.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_mr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ms.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_nl.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_no.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_pl.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_pt-BR.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_pt-PT.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ru.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sk.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sl.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sv.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sw.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ta.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_th.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_tr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_uk.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_vi.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_zh-CN.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_zh-TW.xtb
    • ui/chromeos/translations/ui_chromeos_strings_te.xtb
  4. Revert "Enable warmer welcome during Assistant launch."

    Changed by Dan Beam - dbeamohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 02:41:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c71812f1007dae45bce45b451c384bf9c0dbd356

    Comments

    Revert "Enable warmer welcome during Assistant launch."
    
    This reverts commit 29dca9fe6ae866266c976809adc33c09a2ca1088.
    
    Reason for revert:
      ../../chromeos/services/assistant/assistant_manager_service_impl.cc:27:10: fatal error: 'chromeos/services/assistant/assistant_warmer_welcome_log.pb.h' file not found
      #include "chromeos/services/assistant/assistant_warmer_welcome_log.pb.h"
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      1 error generated.
    
    https://logs.chromium.org/logs/chromium/bb/chromium.chrome/Google_Chrome_ChromeOS/59389/+/recipes/steps/compile/0/stdout
    
    Original change's description:
    > Enable warmer welcome during Assistant launch.
    > 
    > 1. It is guarded by a finch flag AssistantWarmerWelcome.
    > 2. WW only shows 3 times.
    > 
    > Bug: b:112495005
    > Test: Manual
    > 
    > Change-Id: I80cbcfd4104c17172939d36b986be65077bf0bb3
    > Reviewed-on: https://chromium-review.googlesource.com/c/1355174
    > Reviewed-by: Will Harris <wfh@chromium.org>
    > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > Commit-Queue: Yilei Li <yileili@google.com>
    > Cr-Commit-Position: refs/heads/master@{#614553}
    
    TBR=xiyuan@chromium.org,xiaohuic@chromium.org,wfh@chromium.org,dmblack@google.com,wutao@chromium.org,yileili@google.com
    
    Change-Id: Ib5749ef1c003be49d4923c364d8499b43a2abcf5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: b:112495005
    Reviewed-on: https://chromium-review.googlesource.com/c/1366873
    Reviewed-by: Dan Beam <dbeam@chromium.org>
    Commit-Queue: Dan Beam <dbeam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614577}

    Changed files

    • ash/BUILD.gn
    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_controller.h
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/public/cpp/ash_pref_names.cc
    • ash/public/cpp/ash_pref_names.h
    • ash/shell.cc
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h