Builder Mac FYI Experimental Retina Release (AMD)
Build 9127
Results:
Success
Trigger Info:
Project | chromium |
Revision | d1bd9b733d802ea1658f49b897fa75057254cd1f |
Got Revision | d1bd9b733d802ea1658f49b897fa75057254cd1f |
Execution:
- Source: Task 42939057c12c3810
- Bot: build89-m9
- Recipe: chromium
Steps and Logfiles:
Show:-
( 214 ms ) report buildersrunning tester 'Mac FYI Experimental Retina Release (AMD)' on master 'chromium.gpu.fyi'
-
- - no logs -
-
( 1 secs ) read test spec (chromium.gpu.fyi.json)path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
-
( 398 ms ) lookup builder GN argsbuild_angle_gles1_conform_tests = truedcheck_always_on = trueffmpeg_branding = "Chrome"internal_gles2_conform_tests = trueis_component_build = falseis_debug = falseproprietary_codecs = truestrip_absolute_paths_from_debug_symbols = truesymbol_level = 1use_goma = truegoma_dir = "/b/s/w/ir/cache/goma/client"
-
- - no logs -
-
( 2 secs ) [trigger] angle_end2end_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'
-
- - no logs -
-
( 2 secs ) angle_end2end_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'Max shard duration: 15s (shard #1)Min shard duration: 14s (shard #3)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] angle_unittests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'
-
( 1 mins 3 secs ) angle_unittests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'Shard duration: 58s
-
- - no logs -
-
( 859 ms ) test_pre_run.[trigger] tab_capture_end2end_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'
-
( 38 secs ) tab_capture_end2end_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'Shard duration: 36s
-
- - no logs -
-
( 2 secs ) test_pre_run.[trigger] dawn_end2end_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'
-
( 1 secs ) dawn_end2end_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'Max shard duration: 8s (shard #3)Min shard duration: 7s (shard #1)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] gl_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'
-
( 1 secs ) gl_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'Shard duration: 51s
-
- - no logs -
-
( 843 ms ) test_pre_run.[trigger] gl_unittests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'
-
( 1 secs ) gl_unittests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'Shard duration: 8s
-
- - no logs -
-
( 980 ms ) test_pre_run.[trigger] gles2_conform_test on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'
-
( 1 secs ) gles2_conform_test on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'Shard duration: 0:04:34.873471
-
- - no logs -
-
( 831 ms ) test_pre_run.[trigger] gpu_unittests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'
-
( 2 secs ) gpu_unittests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'Shard duration: 16s
-
- - no logs -
-
( 907 ms ) test_pre_run.[trigger] services_unittests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'
-
( 18 secs ) services_unittests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'Shard duration: 16s
-
- - no logs -
-
( 805 ms ) test_pre_run.[trigger] context_lost_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'
-
( 1 mins 58 secs ) context_lost_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'Shard duration: 0:01:57.307353Total tests: 10* Passed: 10 (10 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 912 ms ) test_pre_run.[trigger] depth_capture_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'
-
( 30 secs ) depth_capture_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'Shard duration: 29sTotal tests: 3* Passed: 3 (3 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 924 ms ) test_pre_run.[trigger] gpu_process_launch_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'
-
( 49 secs ) gpu_process_launch_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'Shard duration: 47sTotal tests: 15* Passed: 15 (15 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 947 ms ) test_pre_run.[trigger] hardware_accelerated_feature_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'
-
( 30 secs ) hardware_accelerated_feature_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'Shard duration: 27sTotal tests: 2* Passed: 2 (2 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 899 ms ) test_pre_run.[trigger] info_collection_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'
-
( 28 secs ) info_collection_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'Shard duration: 26sTotal tests: 1* Passed: 1 (1 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 873 ms ) test_pre_run.[trigger] maps_pixel_test on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'
-
( 1 mins 7 secs ) maps_pixel_test on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'Shard duration: 0:01:04.519057Total tests: 1* Passed: 1 (1 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 937 ms ) test_pre_run.[trigger] pixel_test on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'
-
( 5 mins 35 secs ) pixel_test on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'Shard duration: 0:05:28.166867Total tests: 58* Passed: 58 (58 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] screenshot_sync_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'
-
( 1 mins 14 secs ) screenshot_sync_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'Shard duration: 0:01:11.485340Total tests: 4* Passed: 4 (4 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 2 secs ) test_pre_run.[trigger] trace_test on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'
-
( 2 mins 56 secs ) trace_test on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'Shard duration: 0:02:50.782185Total tests: 48* Passed: 24 (24 expected, 0 unexpected)* Skipped: 24 (24 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
- - no logs -
-
( 8 secs ) test_pre_run.[trigger] webgl2_conformance_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'
-
( 9 mins 49 secs ) webgl2_conformance_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'Max shard duration: 0:09:38.000956 (shard #18)Min shard duration: 0:06:40.010656 (shard #1)Total tests: 2803* Passed: 2738 (2738 expected, 0 unexpected)* Skipped: 65 (65 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
- stdout
- json.output
- swarming.summary
- Merge script log
- outdir_json
- step_metadata
- shard #0 isolated out
- shard #0 (463.5 sec)
- shard #1 isolated out
- shard #1 (378.5 sec)
- shard #2 isolated out
- shard #2 (466.6 sec)
- shard #3 isolated out
- shard #3 (465.3 sec)
- shard #4 isolated out
- shard #4 (538.0 sec)
- shard #5 isolated out
- shard #5 (502.4 sec)
- shard #6 isolated out
- shard #6 (544.0 sec)
- shard #7 isolated out
- shard #7 (405.9 sec)
- shard #8 isolated out
- shard #8 (479.1 sec)
- shard #9 isolated out
- shard #9 (434.8 sec)
- shard #10 isolated out
- shard #10 (484.8 sec)
- shard #11 isolated out
- shard #11 (472.5 sec)
- shard #12 isolated out
- shard #12 (475.3 sec)
- shard #13 isolated out
- shard #13 (488.9 sec)
- shard #14 isolated out
- shard #14 (427.2 sec)
- shard #15 isolated out
- shard #15 (480.2 sec)
- shard #16 isolated out
- shard #16 (469.1 sec)
- shard #17 isolated out
- shard #17 (421.5 sec)
- shard #18 isolated out
- shard #18 (556.0 sec)
- shard #19 isolated out
- shard #19 (511.1 sec)
-
- - no logs -
-
( 1 secs ) test_pre_run.[trigger] webgl_conformance_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'
-
( 7 mins 46 secs ) webgl_conformance_tests on ATI GPU on Mac Retina on Mac-10.13.6Run on OS: 'Mac-10.13.6'Max shard duration: 0:07:41.963621 (shard #1)Min shard duration: 0:02:34.895046 (shard #0)Total tests: 938* Passed: 932 (932 expected, 0 unexpected)* Skipped: 6 (6 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "build89-m9" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548247549667519, "id": "8923538493318500784", "project": "chromium", "tags": ["builder:Mac FYI Experimental Retina Release (AMD)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/d1bd9b733d802ea1658f49b897fa75057254cd1f", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Mac Builder", "parent_buildnumber:35094", "scheduler_invocation_id:9088968555525732128", "scheduler_job_id:chromium/Mac FYI Experimental Retina Release (AMD)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "Mac FYI Experimental Retina Release (AMD)" | setup_build |
buildnumber | 9127 | setup_build |
mastername | "chromium.gpu.fyi" | setup_build |
parent_buildername | "GPU FYI Mac Builder" | setup_build |
parent_got_angle_revision | "5313c8a89964f536bff2c7f7943499f9c52e5664" | setup_build |
parent_got_buildtools_revision | "2f02e1f363b1af2715536f38e239853f04ec1497" | setup_build |
parent_got_dawn_revision | "c0f31e73e481f32d308cb6232e75e6d860d97063" | setup_build |
parent_got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | setup_build |
parent_got_revision | "d1bd9b733d802ea1658f49b897fa75057254cd1f" | setup_build |
parent_got_revision_cp | "refs/heads/master@{#625171}" | setup_build |
parent_got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | setup_build |
parent_got_v8_revision | "f6929d6c3888a08d5cf55534c7bf4a57ddc59f4a" | setup_build |
parent_got_v8_revision_cp | "refs/heads/7.3.488@{#1}" | setup_build |
parent_got_webrtc_revision | "71b5a7df7794bbc4103296fcd8bd740acebdc901" | setup_build |
parent_got_webrtc_revision_cp | "refs/heads/master@{#26351}" | setup_build |
parent_mastername | "chromium.gpu.fyi" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
revision | "d1bd9b733d802ea1658f49b897fa75057254cd1f" | setup_build |
swarm_hashes | {"angle_end2end_tests": "2bb8a36a35455f39fedf1077e2d0b951bed7f7f0", "angle_unittests": "d865577fbc5aa91c90173087391f4d6e028a5325", "browser_tests": "7eeb9750c1a7524cbe89e5dfceb113efcf0a6789", "dawn_end2end_tests": "f27d9fd7cce6c37918a2899f92d01e3695bd30e5", "gl_tests": "33a4d2ac88a467aa4b9eb94407f31cd4e6bb6014", "gl_unittests": "3f20254c0cf614e202bd814035359f674cc9e13f", "gles2_conform_test": "14ef203295ab7bd74f54e1a2aeb7d8df3a66670f", "gpu_unittests": "b9d4c128620a02386b5528850c17f20f5b418c82", "services_unittests": "cb3197a0c485812e0e268bd54edd964abb74b85a", "swiftshader_unittests": "265cdd6a7691ed2ddd7ea4ab69f548b73ec0267b", "telemetry_gpu_integration_test": "16610646093152db4e46da07d52255fcae7b627e"} | setup_build |
got_angle_revision | "5313c8a89964f536bff2c7f7943499f9c52e5664" | bot_update |
got_buildtools_revision | "2f02e1f363b1af2715536f38e239853f04ec1497" | bot_update |
got_dawn_revision | "c0f31e73e481f32d308cb6232e75e6d860d97063" | bot_update |
got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
got_revision | "d1bd9b733d802ea1658f49b897fa75057254cd1f" | bot_update |
got_revision_cp | "refs/heads/master@{#625171}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "f6929d6c3888a08d5cf55534c7bf4a57ddc59f4a" | bot_update |
got_v8_revision_cp | "refs/heads/7.3.488@{#1}" | bot_update |
got_webrtc_revision | "71b5a7df7794bbc4103296fcd8bd740acebdc901" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26351}" | bot_update |
swarm_hashes | {} | find isolated tests |
Blamelist:
- Jordan Demeulenaere (jdemeulenaereohnoyoudont@google.com)
- Andreas Haas (ahaasohnoyoudont@chromium.org)
- Henrik Boström (hbosohnoyoudont@chromium.org)
- Takashi Toyoshima (toyoshimohnoyoudont@chromium.org)
- Antonio Gomes (tonikitooohnoyoudont@igalia.com)
Timing:
Create | Wednesday, 23-Jan-19 12:45:49 UTC |
Start | Wednesday, 23-Jan-19 12:45:52 UTC |
End | Wednesday, 23-Jan-19 13:24:38 UTC |
Pending | 2 secs |
Execution | 38 mins 46 secs |
All Changes:
-
[Autofill Assistant] Add carousel chips in model.
Changed by Jordan Demeulenaere - jdemeulenaereohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 12:23:54 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d1bd9b733d802ea1658f49b897fa75057254cd1f Comments
[Autofill Assistant] Add carousel chips in model. Change-Id: I9b12db58728f9e18b54dc270d300005219ea2d77 Reviewed-on: https://chromium-review.googlesource.com/c/1426780 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#625171}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AssistantCoordinator.java
- chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AssistantModel.java
- chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
- chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/carousel/AssistantCarouselCoordinator.java
- chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/carousel/AssistantCarouselDelegate.java
- chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/carousel/AssistantCarouselModel.java
- chrome/android/java_sources.gni
- chrome/android/javatests/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiTest.java
- chrome/browser/BUILD.gn
- chrome/browser/android/autofill_assistant/assistant_carousel_delegate.cc
- chrome/browser/android/autofill_assistant/assistant_carousel_delegate.h
- chrome/browser/android/autofill_assistant/ui_controller_android.cc
- chrome/browser/android/autofill_assistant/ui_controller_android.h
-
Add myself as an owner for v8_wasm_response_extensions
Changed by Andreas Haas - ahaasohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 12:16:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9880403da18621ad47a8f167ce29e7fbc05a6076 Comments
Add myself as an owner for v8_wasm_response_extensions Though I am not much of a blink bindings expert, I am the main author of v8_wasm_response_extensions.*. R=haraken@chromium.org, mlippautz@chromium.org Change-Id: I9558e14879d3a22a28b34e8f5e389910853fe087 Reviewed-on: https://chromium-review.googlesource.com/c/1429121 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#625170}
Changed files
- third_party/blink/renderer/bindings/core/v8/OWNERS
-
Surface offerToReceive-transceivers created/modified in createOffer().
Changed by Henrik Boström - hbosohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 12:11:57 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8377018ef1088b24644d42620506adeeda3afa76 Comments
Surface offerToReceive-transceivers created/modified in createOffer(). In Unified Plan, offerToReceive[Audio/Video] are legacy configuration extensions that may create transceivers or change the direction of existing transceivers. https://w3c.github.io/webrtc-pc/#legacy-configuration-extensions This was previously supported by the webrtc layer, but until this CL the state changes were not surfaced properly, and offerToReceive-transceivers would not become visible in JavaScript until surfaced as a side-effect of some other operation that surfaces transceivers such as setLocalDescription() or setRemoteDescription(). With this CL we pass 14 more WPTs. Bug: 911090 Change-Id: I5d9a5c15c6ac4e0dc328e589ba129925a65e404e Reviewed-on: https://chromium-review.googlesource.com/c/1427541 Reviewed-by: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#625169}
Changed files
- content/renderer/media/webrtc/rtc_peer_connection_handler.cc
- content/renderer/media/webrtc/rtc_peer_connection_handler.h
- third_party/blink/public/platform/web_rtc_peer_connection_handler.h
- third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc
- third_party/blink/renderer/modules/peerconnection/rtc_peer_connection_test.cc
- third_party/blink/renderer/platform/testing/testing_platform_support_with_web_rtc.cc
- third_party/blink/renderer/platform/testing/testing_platform_support_with_web_rtc.h
- third_party/blink/web_tests/external/wpt/webrtc/legacy/RTCPeerConnection-createOffer-offerToReceive-expected.txt
- third_party/blink/web_tests/external/wpt/webrtc/legacy/RTCRtpTransceiver-with-OfferToReceive-options.https-expected.txt
-
Web MIDI: Upgrade sysex authority on demand
Changed by Takashi Toyoshima - toyoshimohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 12:04:53 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4503514cd1208585444dc447d1fc11f3917eb6e8 Comments
Web MIDI: Upgrade sysex authority on demand Currently, MidiHost caches sysex authority on the session start, that means when the first client connects. But the second or later clients share the same session, and may have different authority. This patch changes to update the cached authority when permission checks fail. Bug: 912501 Change-Id: I6fc4ebe456c7a62c4f9bc96f8332a1e78d522cb0 Reviewed-on: https://chromium-review.googlesource.com/c/1390891 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#625168}
Changed files
- content/browser/media/midi_host.cc
- content/browser/media/midi_host.h
- third_party/blink/web_tests/webmidi/requestmidiaccess-upgrade.html
-
[s13n] Replace inheritance of PO2TS::Observer by IdentityManager::Observer in AboutSigninInternals
Changed by Antonio Gomes - tonikitooohnoyoudont@igalia.com Changed at Wednesday, 23-Jan-19 12:04:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision fcbff223eed340638a951287e1cbe7304cf1d4f0 Comments
[s13n] Replace inheritance of PO2TS::Observer by IdentityManager::Observer in AboutSigninInternals CL is an incremental step to get away from PO2TS from AboutSigninInternals. BUG=809539 Change-Id: Id8e8baea53c76eedee1bb3ac83f2ccb347909210 Reviewed-on: https://chromium-review.googlesource.com/c/1426760 Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#625167}
Changed files
- components/signin/core/browser/about_signin_internals.cc
- components/signin/core/browser/about_signin_internals.h