Home | Search | chromium - Builders

Builder Mac FYI Debug (Intel) Build 8081 Apple OSX



Trigger Info:

Got Revisionc43eba9311573672d0773beed07f117d08eed09f


Steps and Logfiles:

  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:



  1. Ben Kelly (wanderviewohnoyoudont@chromium.org)
  2. Shu Chen (shuchenohnoyoudont@google.com)
  3. Findit (findit-for-meohnoyoudont@appspot.gserviceaccount.com)
  4. Colin Blundell (blundellohnoyoudont@chromium.org)


Create Friday, 12-Oct-18 13:44:39 UTC
Start Friday, 12-Oct-18 13:45:09 UTC
End Friday, 12-Oct-18 14:25:08 UTC
Pending 30 secs
Execution 39 mins 59 secs

All Changes:

  1. Make DataPipeBytesConsumer support ReadableStream loading better.

    Changed by Ben Kelly - wanderviewohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:36:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Revision c43eba9311573672d0773beed07f117d08eed09f


    Make DataPipeBytesConsumer support ReadableStream loading better.
    This CL fixes some edge condition interactions when being loaded as
    a ReadableStream.  In particular, it:
    1. Properly distinguishes between the end of the DataPipe and a closed
       DataPipe with bytes left to be read.  A ReadableStream that is not
       actively draining the pipe could get closed too early.
    2. Responses must support explicit completion in order to handle error
       conditions properly.  This CL makes DataPipeBytesConsumer wait
       for an explicit signal before closing.
    3. Service worker navigation preload is updated to provide the explicit
       completion signals.
    Bug: 894815
    Change-Id: I8cff3de94aa2dcbc8deb4a9601a95c13b8ab94d9
    Reviewed-on: https://chromium-review.googlesource.com/c/1272715
    Commit-Queue: Ben Kelly <wanderview@chromium.org>
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599192}

    Changed files

    • content/browser/service_worker/service_worker_browsertest.cc
    • third_party/blink/renderer/core/fetch/bytes_consumer.h
    • third_party/blink/renderer/core/fetch/data_pipe_bytes_consumer.cc
    • third_party/blink/renderer/core/fetch/data_pipe_bytes_consumer.h
    • third_party/blink/renderer/core/fetch/data_pipe_bytes_consumer_test.cc
    • third_party/blink/renderer/core/fetch/fetch_data_loader.cc
    • third_party/blink/renderer/core/fetch/fetch_data_loader.h
    • third_party/blink/renderer/modules/service_worker/fetch_event.cc
    • third_party/blink/renderer/modules/service_worker/fetch_event.h
    • third_party/blink/renderer/modules/service_worker/fetch_respond_with_observer.cc
  2. Avoid using gypi_to_gn.py.

    Changed by Shu Chen - shuchenohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 13:25:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Revision b85f543af1e343404dde1a2c51067b2ed5ac08cb


    Avoid using gypi_to_gn.py.
    Change-Id: I9bac8317577feaadfa00ec88661175b7338ced4a
    Reviewed-on: https://chromium-review.googlesource.com/c/1267596
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Shu Chen <shuchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599191}

    Changed files

    • third_party/google_input_tools/README.chromium
    • third_party/google_input_tools/builder.py
    • third_party/google_input_tools/closure.gni
    • third_party/google_input_tools/inputview.gni
    • third_party/google_input_tools/inputview.gypi
    • third_party/google_input_tools/update.py
    • ui/keyboard/BUILD.gn
  3. Revert "Files app: Select My files when there are no volumes"

    Changed by Findit - findit-for-meohnoyoudont@appspot.gserviceaccount.com
    Changed at Friday, 12-Oct-18 13:17:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Revision 402571f89e1aff1627ccf491110764c74029e3de


    Revert "Files app: Select My files when there are no volumes"
    This reverts commit 5cd8c123e452c0b76fbbcaf53e82d86ca7d54930.
    Reason for revert:
    Findit (https://goo.gl/kROfz5) identified CL at revision 599026 as the
    culprit for flakes in the build cycles as shown on:
    Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/9016
    Sample Failed Step: viz_browser_tests
    Sample Flaky Test: FileDisplay/FilesAppBrowserTest.Test/fileDisplayWithoutVolumesThenMountDrive_DriveFs
    Original change's description:
    > Files app: Select My files when there are no volumes
    > Make Files app select "My files" when there are no available volumes,
    > this to allow Files app to behave properly when volumes subsequently
    > become available.
    > Change DirectoryModel.onVolumeInfoListUpdated_ method to check for
    > non-null |displayRoot| before trying to change to |displayRoot|. This
    > fixes the error "Cannot read property 'getParent' of null" when Drive
    > volume becomes available before Downloads volume, which is the default
    > volume/root.
    > Change FakeDriveFs to unbind the two mojo bindings if they're bound, so
    > DriveFsTestVolume can re-mount itself.
    > Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*"
    > Bug: 893161, 884967
    > Change-Id: Ic813b25261530495c11c9f641a92f6e07f883702
    > Reviewed-on: https://chromium-review.googlesource.com/c/1272418
    > Reviewed-by: Noel Gordon <noel@chromium.org>
    > Reviewed-by: Sam McNally <sammc@chromium.org>
    > Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599026}
    Change-Id: I883485c8fc1bdcc22dba93cc4b03b7c157dcb5f2
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 893161, 884967, 889703
    Reviewed-on: https://chromium-review.googlesource.com/c/1278063
    Cr-Commit-Position: refs/heads/master@{#599190}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
    • chromeos/components/drivefs/fake_drivefs.cc
    • ui/file_manager/file_manager/foreground/js/directory_model.js
    • ui/file_manager/file_manager/foreground/js/file_manager.js
    • ui/file_manager/integration_tests/file_manager/file_display.js
  4. Start using IdentityTestEnvironment in ProfileSyncServiceBundle

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:10:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Revision 863a437d0fdbbba19ad5446420b72d2f91748a72


    Start using IdentityTestEnvironment in ProfileSyncServiceBundle
    ProfileSyncServiceBundle owns and exposes signin-related objects for
    use by sync tests. These signin-related objects include ones that are
    deprecated by IdentityManager and no longer used directly in the
    production code being tested; however, up until now it has not been
    feasible to convert this test utility to using IdentityTestEnvironment,
    as doing so would have required converting the widespread usage of this
    utility in one go.
    We recently introduced an IdentityTestEnvironment usage mode wherein
    it can be supplied with IdentityManager's dependencies from the
    external client, precisely to enable incremental conversion in use cases
    like this. This CL exploits this usage mode to introduce
    IdentityTestEnvironment in ProfileSyncServiceBundle.h and provide an
    example of its usage to eliminate a direct usage of the deprecated
    classes. Once the conversion is complete, ProfileSyncServiceBundle can
    then be changed to *only* hold an IdentityTestEnvironment object.
    Bug: 886600, 886599
    Change-Id: I205c3567fc0a9bcd6f7b613c00a247c302d71be5
    Reviewed-on: https://chromium-review.googlesource.com/c/1273065
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599189}

    Changed files

    • components/browser_sync/BUILD.gn
    • components/browser_sync/profile_sync_service_autofill_unittest.cc
    • components/browser_sync/profile_sync_test_util.cc
    • components/browser_sync/profile_sync_test_util.h