Home | Search | chromium - Builders
Login

Builder Mac FYI 10.14 Release (AMD) Build 431 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revisionb757a24517f26cd0d149546b1a8cc3d1011907cf
Got Revisionb757a24517f26cd0d149546b1a8cc3d1011907cf

Execution:

Steps and Logfiles:

Show:
  1. ( 335 ms ) setup_build
    running recipe: "chromium"
  2. ( 210 ms ) report builders
     
    running tester 'Mac FYI 10.14 Release (AMD)' on master 'chromium.gpu.fyi'
  3. ( 6 mins 48 secs ) bot_update
    [68GB/232GB used (29%)]
  4. ( 687 ms ) swarming.py --version
    0.13
  5. ( 161 ms ) ensure_installed
  6. ( 13 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
  8. ( 368 ms ) lookup builder GN args
     
    build_angle_gles1_conform_tests = true
    dcheck_always_on = true
    ffmpeg_branding = "Chrome"
    internal_gles2_conform_tests = true
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  9. ( 411 ms ) build directory
  10. ( 402 ms ) find isolated tests
  11. ( 1 mins 49 secs ) angle_end2end_tests on ATI GPU on Mac on Mac-10.14
    Run on OS: 'Mac-10.14'
    Max pending time: 0:01:31.620820 (shard #3)
    Max shard duration: 14s (shard #0)
    Min shard duration: 12s (shard #2)
  12. ( 1 mins 7 secs ) angle_unittests on ATI GPU on Mac on Mac-10.14
    Run on OS: 'Mac-10.14'
    Shard duration: 0:01:00.302662
  13. ( 47 secs ) tab_capture_end2end_tests on ATI GPU on Mac on Mac-10.14
    Run on OS: 'Mac-10.14'
    Shard duration: 38s
  14. ( 56 secs ) gl_tests on ATI GPU on Mac on Mac-10.14
    Run on OS: 'Mac-10.14'
    Shard duration: 49s
  15. ( 11 secs ) gl_unittests on ATI GPU on Mac on Mac-10.14
    Run on OS: 'Mac-10.14'
    Shard duration: 9s
  16. ( 4 mins 17 secs ) gles2_conform_test on ATI GPU on Mac on Mac-10.14
    Run on OS: 'Mac-10.14'
    Shard duration: 0:04:09.391141
  17. ( 26 secs ) gpu_unittests on ATI GPU on Mac on Mac-10.14
    Run on OS: 'Mac-10.14'
    Shard duration: 18s
  18. ( 21 secs ) services_unittests on ATI GPU on Mac on Mac-10.14
    Run on OS: 'Mac-10.14'
    Shard duration: 17s
  19. ( 12 secs ) swiftshader_unittests on ATI GPU on Mac on Mac-10.14
    Run on OS: 'Mac-10.14'
    Shard duration: 8s
  20. ( 2 mins 8 secs ) context_lost_tests on ATI GPU on Mac on Mac-10.14
    Run on OS: 'Mac-10.14'
    Shard duration: 0:02:03.921123
    Total tests: 10
    * Passed: 10 (10 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  21. ( 28 secs ) depth_capture_tests on ATI GPU on Mac on Mac-10.14
    Run on OS: 'Mac-10.14'
    Shard duration: 26s
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  22. ( 1 mins 2 secs ) gpu_process_launch_tests on ATI GPU on Mac on Mac-10.14
    Run on OS: 'Mac-10.14'
    Shard duration: 56s
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  23. ( 29 secs ) hardware_accelerated_feature_tests on ATI GPU on Mac on Mac-10.14
    Run on OS: 'Mac-10.14'
    Shard duration: 24s
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  24. ( 25 secs ) info_collection_tests on ATI GPU on Mac on Mac-10.14
    Run on OS: 'Mac-10.14'
    Shard duration: 22s
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  25. ( 1 mins 8 secs ) maps_pixel_test on ATI GPU on Mac on Mac-10.14
    Run on OS: 'Mac-10.14'
    Shard duration: 0:01:04.619549
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  26. ( 5 mins 48 secs ) pixel_test on ATI GPU on Mac on Mac-10.14
    Run on OS: 'Mac-10.14'
    Shard duration: 0:05:39.242838
    Total tests: 60
    * Passed: 57 (57 expected, 0 unexpected)
    * Skipped: 3 (3 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  27. ( 1 mins 8 secs ) screenshot_sync_tests on ATI GPU on Mac on Mac-10.14
    Run on OS: 'Mac-10.14'
    Shard duration: 0:01:04.926835
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  28. ( 2 mins 33 secs ) trace_test on ATI GPU on Mac on Mac-10.14
    Run on OS: 'Mac-10.14'
    Shard duration: 0:02:24.315707
    Total tests: 40
    * Passed: 20 (20 expected, 0 unexpected)
    * Skipped: 20 (20 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 3 hrs 6 mins ) webgl2_conformance_tests on ATI GPU on Mac on Mac-10.14
    Run on OS: 'Mac-10.14'
    Max pending time: 2:55:15.289288 (shard #19)
    Max shard duration: 0:10:41.807340 (shard #19)
    Min shard duration: 0:07:59.359673 (shard #14)
    Total tests: 2796
    * Passed: 2731 (2731 expected, 0 unexpected)
    * Skipped: 65 (65 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 11 mins 27 secs ) webgl_conformance_tests on ATI GPU on Mac on Mac-10.14
    Run on OS: 'Mac-10.14'
    Max pending time: 0:03:04.240095 (shard #1)
    Max shard duration: 0:08:18.818721 (shard #1)
    Min shard duration: 0:02:59.242585 (shard #0)
    Total tests: 932
    * Passed: 926 (926 expected, 0 unexpected)
    * Skipped: 6 (6 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  31. ( 268 ms ) Tests statistics
     
    Stats
    Total shards: 43
    Total runtime: 3:27:22.935455
     

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "build287-m9" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1542149401574606, "id": "8929932865053289008", "project": "chromium", "tags": ["builder:Mac FYI 10.14 Release (AMD)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/b757a24517f26cd0d149546b1a8cc3d1011907cf", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Mac Builder", "parent_buildnumber:27726", "scheduler_invocation_id:9095362927233565312", "scheduler_job_id:chromium/Mac FYI 10.14 Release (AMD)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Mac FYI 10.14 Release (AMD)" setup_build
buildnumber 431 setup_build
mastername "chromium.gpu.fyi" setup_build
parent_buildername "GPU FYI Mac Builder" setup_build
parent_got_angle_revision "f9143725470b92c9a1836ed677bca236a190aebb" setup_build
parent_got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" setup_build
parent_got_dawn_revision "b5bced2fcef3a5e2309f97892e6d9ddeda9ddfcc" setup_build
parent_got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" setup_build
parent_got_revision "b757a24517f26cd0d149546b1a8cc3d1011907cf" setup_build
parent_got_revision_cp "refs/heads/master@{#607774}" setup_build
parent_got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" setup_build
parent_got_v8_revision "9d32daac0fdc6d17139393cc1a7bc7d8a14dfba3" setup_build
parent_got_v8_revision_cp "refs/heads/7.2.317@{#1}" setup_build
parent_got_webrtc_revision "c7e3af1ad928814c8c64e715a86b3db0e85a055c" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25623}" setup_build
parent_mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "b757a24517f26cd0d149546b1a8cc3d1011907cf" setup_build
swarm_hashes {"angle_end2end_tests": "99c31626e7cfda9dc1faf6173b33c5f5b9c0b4f9", "angle_unittests": "f9458e3e5603107261a8470d59f05493f55611fe", "browser_tests": "587681469c842a2b6b9010e31cc37da9280f52c0", "gl_tests": "0a61202ee8274a4492e0bcb910f54a06f2c130bb", "gl_unittests": "de66f1c783325efe14fdc837d0dd5ceac0a5006f", "gles2_conform_test": "128ec81843cdb2ceb53a2ee9984b7953527c5f36", "gpu_unittests": "5a4be88349f0c77fe1995da7bd1ab7ae73782358", "services_unittests": "f3793dab571581366e3150b1a42948d05f37990f", "swiftshader_unittests": "554a19f4419b918fd1e1a1659c6d8be27e04e1a7", "telemetry_gpu_integration_test": "66d37550bdb86fbb7e299872f93d5c5cb338e2ad"} setup_build
got_angle_revision "f9143725470b92c9a1836ed677bca236a190aebb" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "597e1587b4bfc7bf89895c7c879ae58b649da3c5" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "b757a24517f26cd0d149546b1a8cc3d1011907cf" bot_update
got_revision_cp "refs/heads/master@{#607774}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "9d32daac0fdc6d17139393cc1a7bc7d8a14dfba3" bot_update
got_v8_revision_cp "refs/heads/7.2.317@{#1}" bot_update
got_webrtc_revision "c7e3af1ad928814c8c64e715a86b3db0e85a055c" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25623}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. Wez (wezohnoyoudont@chromium.org)
  2. Miguel Casas (mcasasohnoyoudont@chromium.org)
  3. Pavel Yatsuk (pavelyohnoyoudont@google.com)
  4. Quan Nguyen (qnnguyenohnoyoudont@chromium.org)
  5. Dominic Mazzoni (dmazzoniohnoyoudont@chromium.org)
  6. Sreerenj Balachandran (sreerenj.balachandranohnoyoudont@intel.com)
  7. Sammie Quon (sammiequonohnoyoudont@google.com)
  8. Alex Newcomer (newcomerohnoyoudont@chromium.org)
  9. Ben Pastene (bpasteneohnoyoudont@chromium.org)
  10. Jay Harris (harrisjayohnoyoudont@chromium.org)
  11. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  12. Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
  13. Giovanni Ortuño Urquidi (ortunoohnoyoudont@chromium.org)
  14. kylechar (kylecharohnoyoudont@chromium.org)
  15. Vikas Soni (vikassoniohnoyoudont@chromium.org)
  16. Ted Choc (tedchocohnoyoudont@chromium.org)
  17. Thomas Tangl (tangltomohnoyoudont@chromium.org)
  18. Thomas Tangl (tangltomohnoyoudont@chromium.org)
  19. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  20. Evan Stade (estadeohnoyoudont@chromium.org)
  21. Sean Gilhuly (sgilhulyohnoyoudont@chromium.org)
  22. Chase Phillips (cmpohnoyoudont@chromium.org)
  23. Cathy Li (chiliohnoyoudont@chromium.org)
  24. Becca Hughes (beccahughesohnoyoudont@chromium.org)
  25. Ken Rockot (rockotohnoyoudont@google.com)
  26. Ryan Daum (rdaumohnoyoudont@chromium.org)
  27. Ben Pastene (bpasteneohnoyoudont@chromium.org)
  28. oysteine (oysteineohnoyoudont@chromium.org)
  29. siyua (siyuaohnoyoudont@chromium.org)
  30. Justin Cohen (justincohenohnoyoudont@google.com)
  31. Ian Clelland (iclellandohnoyoudont@chromium.org)
  32. Regan Hsu (hsureganohnoyoudont@chromium.org)
  33. Hector Carmona (hcarmonaohnoyoudont@chromium.org)
  34. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  35. Jeremy Manson (jeremymansonohnoyoudont@google.com)
  36. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  37. Shawn Gallea (sagalleaohnoyoudont@google.com)
  38. Scott Violet (skyohnoyoudont@chromium.org)
  39. Dianna Hu (diannahuohnoyoudont@chromium.org)
  40. Jun Choi (hongjunchoiohnoyoudont@chromium.org)
  41. bsheedy (bsheedyohnoyoudont@chromium.org)
  42. Charlie Reis (creisohnoyoudont@chromium.org)
  43. Henrique Grandinetti (hgrandinettiohnoyoudont@chromium.org)
  44. Ryan Meier (rameierohnoyoudont@chromium.org)
  45. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  46. Kyle Milka (kmilkaohnoyoudont@chromium.org)
  47. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  48. Tomas Popela (tomas.popelaohnoyoudont@gmail.com)
  49. Sahel Sharify (sahelohnoyoudont@chromium.org)
  50. Charlie Harrison (csharrisonohnoyoudont@chromium.org)
  51. Tommy Martino (tmartinoohnoyoudont@chromium.org)
  52. Andrey Lushnikov (lushnikovohnoyoudont@chromium.org)
  53. Owen Min (zminohnoyoudont@chromium.org)
  54. Vasilii Sukhanov (vasiliiohnoyoudont@chromium.org)
  55. Jesse McKenna (jessemckennaohnoyoudont@google.com)
  56. Mike Wittman (wittmanohnoyoudont@chromium.org)
  57. Sergio Villar Senin (svillarohnoyoudont@igalia.com)
  58. Danyao Wang (danyaoohnoyoudont@chromium.org)
  59. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  60. Victor Vasiliev (vasilvvohnoyoudont@chromium.org)
  61. gogerald (gogeraldohnoyoudont@google.com)
  62. Peter Kasting (pkastingohnoyoudont@chromium.org)
  63. Steven Valdez (svaldezohnoyoudont@chromium.org)
  64. James Hawkins (jhawkinsohnoyoudont@chromium.org)
  65. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  66. manuk (manukhohnoyoudont@chromium.org)
  67. Steve Anton (steveantonohnoyoudont@chromium.org)
  68. Anne Lim (annelimohnoyoudont@google.com)
  69. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  70. Justin Cohen (justincohenohnoyoudont@google.com)
  71. Ted Choc (tedchocohnoyoudont@chromium.org)
  72. danakj (danakjohnoyoudont@chromium.org)
  73. Antoine Labour (pimanohnoyoudont@chromium.org)
  74. Mario Sanchez Prada (marioohnoyoudont@igalia.com)
  75. Hao Zhang (hozhngohnoyoudont@google.com)
  76. Elly Fong-Jones (ellyjonesohnoyoudont@chromium.org)
  77. Yi Su (mrsuyiohnoyoudont@chromium.org)
  78. Brian Osman (brianosmanohnoyoudont@google.com)
  79. jdoerrie (jdoerrieohnoyoudont@chromium.org)
  80. Erik Chen (erikchenohnoyoudont@chromium.org)
  81. Alexei Filippov (alphohnoyoudont@chromium.org)
  82. Chris Mumford (cmumfordohnoyoudont@chromium.org)
  83. Nikunj Bhagat (nikunjbohnoyoudont@chromium.org)
  84. Charlie Harrison (csharrisonohnoyoudont@chromium.org)
  85. Steven Bennetts (stevenjbohnoyoudont@chromium.org)
  86. Ahmed Fakhry (afakhryohnoyoudont@chromium.org)
  87. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  88. Lei Zhang (thestigohnoyoudont@chromium.org)
  89. Dominic Mazzoni (dmazzoniohnoyoudont@chromium.org)
  90. Elly Fong-Jones (ellyjonesohnoyoudont@chromium.org)
  91. Krishna Govind (govindohnoyoudont@chromium.org)
  92. Chris Harrelson (chrishtrohnoyoudont@chromium.org)
  93. Liquan(Max) Gu (maxlgohnoyoudont@chromium.org)
  94. Kurt Horimoto (kkhorimotoohnoyoudont@chromium.org)
  95. kyle Ju (kylejuohnoyoudont@chromium.org)
  96. Mario Sanchez Prada (marioohnoyoudont@igalia.com)
  97. Jonathan Metzman (metzmanohnoyoudont@chromium.org)
  98. Sunny Sachanandani (sunnypsohnoyoudont@chromium.org)
  99. Ned Nguyen (nednguyenohnoyoudont@google.com)
  100. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  101. <blame list capped at 100 commits> ()

Timing:

Create Tuesday, 13-Nov-18 22:50:01 UTC
Start Tuesday, 13-Nov-18 22:50:29 UTC
End Wednesday, 14-Nov-18 02:43:20 UTC
Pending 27 secs
Execution 3 hrs 52 mins

All Changes:

  1. Migrate to zx_socket_shutdown() API to close the socket for writing.

    Changed by Wez - wezohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 22:35:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b757a24517f26cd0d149546b1a8cc3d1011907cf

    Comments

    Migrate to zx_socket_shutdown() API to close the socket for writing.
    
    Zircon previously used an option to zx_socket_write() to close the
    socket for reading, or writing. Migrate to the new zx_socket_shutdown()
    API.
    
    Change-Id: Ia4067c4611713031048271800dd620a9c1b15e72
    Reviewed-on: https://chromium-review.googlesource.com/c/1334329
    Reviewed-by: Wez <wez@chromium.org>
    Reviewed-by: Adam Barth <abarth@chromium.org>
    Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
    Commit-Queue: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607774}

    Changed files

    • webrunner/net_http/url_loader_impl.cc
  2. CanvasResourceProvider: add unit tests

    Changed by Miguel Casas - mcasasohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 22:35:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 02c1b9bce60dd463b5d34af1ca54018d62b28d79

    Comments

    CanvasResourceProvider: add unit tests
    
    This CL adds CanvasResourceProvider unit tests.
    
    Also removes unused method InvalidateSurface().
    
    Bug: 902585
    Change-Id: I6602624ea4826d8cd307e4d973430e6c451aebd0
    Reviewed-on: https://chromium-review.googlesource.com/c/1334148
    Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Commit-Queue: Miguel Casas <mcasas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607773}

    Changed files

    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource_provider.h
    • third_party/blink/renderer/platform/graphics/canvas_resource_provider_test.cc
    • third_party/blink/renderer/platform/graphics/test/fake_web_graphics_context_3d_provider.h
  3. [Feed] Import feed@107851225e86b1ab6a222ce8ca7ac3729652273a

    Changed by Pavel Yatsuk - pavelyohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 22:34:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1d051c76eb60046dfc7f2f6a7b7424a390ca75bb

    Comments

    [Feed] Import feed@107851225e86b1ab6a222ce8ca7ac3729652273a
    
    Specifics:
          +753,080 bytes normalized apk size
                +5 zip entries file count
           +66,544 bytes main lib size
          +467,128 bytes main dex size
    InstallSize:
          +288,634 bytes APK size
          +835,174 bytes Estimated installed size (Android Go)
        +2,175,831 bytes Estimated installed size
    InstallBreakdown (+2,175,416 bytes):
            +2,682 bytes unwind_cfi (dev and canary only) size
            +1,934 bytes Non-compiled Android resources size
           +66,544 bytes Native code size
              +351 bytes Package metadata size
        +2,089,637 bytes Java code size
           +14,268 bytes Compiled Android resources size
    Dex:
            +2,396 entries fields
            +3,285 entries methods
              +773 entries types
            +1,679 entries strings
    
    R=pnoland@chromium.org
    
    Binary-Size: Adding errors.proto, which is finally compatible with Chromium.
    Change-Id: I1cf123baf074706ae08e64612f51c36b6380afb6
    Reviewed-on: https://chromium-review.googlesource.com/c/1333128
    Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
    Reviewed-by: Patrick Noland <pnoland@chromium.org>
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607772}

    Changed files

    • DEPS
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java
    • third_party/feed/README.chromium
    • third_party/feed/java_sources.gni
    • third_party/feed/proto_sources.gni
  4. cros: Ensure login bubbles are clickable when overlapping with shelf and virtual keyboard

    Changed by Quan Nguyen - qnnguyenohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 22:33:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 29fa932b58e2ef571a93c04291300e58a1ab1ec2

    Comments

    cros: Ensure login bubbles are clickable when overlapping with shelf and virtual keyboard
    
    Bug: 884668
    Change-Id: I16dd2c5b0156bf1490b57acd4185c1d80d193a67
    Reviewed-on: https://chromium-review.googlesource.com/c/1330206
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607771}

    Changed files

    • ash/login/ui/login_base_bubble_view.cc
    • ash/login/ui/login_base_bubble_view.h
    • ash/login/ui/login_bubble.cc
  5. Fix potential UAF if table role changes.

    Changed by Dominic Mazzoni - dmazzoniohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 22:30:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ad21cca2c4c2403df81307f5a0540c8bbff17b42

    Comments

    Fix potential UAF if table role changes.
    
    Bug: 903500
    Change-Id: I4e55e0323fe642f8af0a79152a52bccc1cb6ac82
    Reviewed-on: https://chromium-review.googlesource.com/c/1334195
    Reviewed-by: Max Moroz <mmoroz@chromium.org>
    Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607770}

    Changed files

    • ui/accessibility/ax_table_info_unittest.cc
    • ui/accessibility/ax_tree.cc
  6. media: Add H264 profile extraction support

    Changed by Sreerenj Balachandran - sreerenj.balachandranohnoyoudont@intel.com
    Changed at Tuesday, 13-Nov-18 22:29:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ffa5c05c6e68b8abfbe4f23f63292ae35d7772b6

    Comments

    media: Add H264 profile extraction support
    
    Without the ffmpeg decoder configured, libavformat is unable to get the
    codec profile and chromium ffmpeg wrapper code choose some defaults.
    This will mess up the decode scenarios where non-ffmpeg decoders like vaapi
    are in use. Fortunately, we can still get hold of the ffmpeg's
    AVStream extradata param which should contain the
    H264 AVCDecoderConfigurationRecord (ISO/IEC 14496-15).
    So we use internal parser for extracting profile information
    from this AVCDecoderConfigurationRecord.
    
    BUG=784610
    TEST=media_unittests:FFmpegCommonTest.VerifyH264Profile
    
    Change-Id: Id67c7026eefb5bb73e6c5fbbab7a362cb4553ab1
    Reviewed-on: https://chromium-review.googlesource.com/c/1292605
    Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
    Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607769}

    Changed files

    • media/ffmpeg/BUILD.gn
    • media/ffmpeg/ffmpeg_common.cc
    • media/ffmpeg/ffmpeg_common_unittest.cc
    • media/formats/BUILD.gn
  7. cros: Show correct PIN setup error message after highlight and delete.

    Changed by Sammie Quon - sammiequonohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 22:29:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a0ef725be055cbf7d9e47b33211d66bbec884297

    Comments

    cros: Show correct PIN setup error message after highlight and delete.
    
    Also fix issue where users could not backspace by using keyboard tab
    and space.
    
    Test: manual
    Bug: 881756, 862924
    Change-Id: I0523784ad05d2a02219e95e90cd02b2d275da94f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329748
    Commit-Queue: Sammie Quon <sammiequon@chromium.org>
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607768}

    Changed files

    • ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.html
    • ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.js
    • ui/webui/resources/cr_components/chromeos/quick_unlock/setup_pin_keyboard.js
  8. cros: Make touchable menu labels up to spec

    Changed by Alex Newcomer - newcomerohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 22:25:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3a8ae8e40b0157f5a3071f346586c3a7d8c7ee60

    Comments

    cros: Make touchable menu labels up to spec
    
    Increase the label size to 14px.
    
    Bug: 888610
    Change-Id: If7063fafcd8247601e3c7af0bf8b179f76f9df0c
    Reviewed-on: https://chromium-review.googlesource.com/c/1329672
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Reviewed-by: Alex Newcomer <newcomer@chromium.org>
    Commit-Queue: Alex Newcomer <newcomer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607767}

    Changed files

    • chrome/browser/ui/views/chrome_typography_provider.cc
  9. Don't use goma for WinLibfuzzer clang ToT bot.

    Changed by Ben Pastene - bpasteneohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 22:18:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 133f5790775a57f71f1f889000c3e00b06497e6b

    Comments

    Don't use goma for WinLibfuzzer clang ToT bot.
    
    Looks like no other tot bot uses goma, and the bot's currently failing
    since the goma client isn't available.
    
    Bug: 903078
    Change-Id: I14e9a3772f3df464d5e6549fd785b20bc10d0509
    Reviewed-on: https://chromium-review.googlesource.com/c/1334272
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607766}

    Changed files

    • tools/mb/mb_config.pyl
  10. Update separator opacity on visibility change

    Changed by Jay Harris - harrisjayohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 22:13:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e574e27caf09a7af60ffa25fd7af460ebc545736

    Comments

    Update separator opacity on visibility change
    
    Bug: 904318
    Change-Id: I3c0367bc925a5f3b78f3a0457c25ef3b7c807b38
    Reviewed-on: https://chromium-review.googlesource.com/c/1333007
    Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
    Commit-Queue: Jay Harris <harrisjay@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607765}

    Changed files

    • chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
  11. Update V8 to version 7.2.317.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 22:13:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9e889429385fd4a562aca336741d6af7e1b1fda9

    Comments

    Update V8 to version 7.2.317.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/c1a5d275..9d32daac
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: I8e6d7a4ca76ecd267e9288458dfd5ac8a852ead4
    Reviewed-on: https://chromium-review.googlesource.com/c/1334205
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607764}

    Changed files

    • DEPS
  12. Revert "Add Finch param to control TLS 1.3 Downgrade enforcement on known/unknown roots."

    Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 22:11:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 84b6bcf9665cdfe0c1ecf85479a8a287f6226838

    Comments

    Revert "Add Finch param to control TLS 1.3 Downgrade enforcement on known/unknown roots."
    
    This reverts commit 75ffb181057275eaf6335d1787f0413e3a3c1c2b.
    
    Reason for revert: static initializer in about_flags.cc, see https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/37607
    
    Original change's description:
    > Add Finch param to control TLS 1.3 Downgrade enforcement on known/unknown roots.
    > 
    > Change-Id: I88932442b714820944b4608e106eaf47536bf00d
    > Reviewed-on: https://chromium-review.googlesource.com/c/1329344
    > Commit-Queue: Steven Valdez <svaldez@chromium.org>
    > Reviewed-by: David Benjamin <davidben@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#607712}
    
    TBR=davidben@chromium.org,svaldez@chromium.org
    
    Change-Id: I638f9065d117b2885fa947c343234981eacfb991
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/1334412
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607763}

    Changed files

    • chrome/browser/about_flags.cc
    • net/socket/ssl_client_socket_impl.cc
    • net/socket/ssl_client_socket_unittest.cc
  13. bluetooth: Add tests for powering off and removing the adapter while scanning

    Changed by Giovanni Ortuño Urquidi - ortunoohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 22:08:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c58e8f35a946d77cd81a0adf707d811603155d27

    Comments

    bluetooth: Add tests for powering off and removing the adapter while scanning
    
    Also remove some unnecessary functions.
    
    BUG=897996
    
    Change-Id: I413001df24f29c5ccd4e3ed906727fd8152f0906
    Reviewed-on: https://chromium-review.googlesource.com/c/1331287
    Reviewed-by: Ovidio Henriquez <odejesush@chromium.org>
    Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607762}

    Changed files

    • services/device/bluetooth/bluetooth_system_unittest.cc
  14. Improve InProcessGpuMemoryBufferManager thread safety.

    Changed by kylechar - kylecharohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 22:03:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6d6affc78f6841064921ca6d01930afae49908f1

    Comments

    Improve InProcessGpuMemoryBufferManager thread safety.
    
    Don't pass GpuChannelManager to InProcessGpuMemoryBufferManager. Most of
    GpuChannelManager should only be accessed from the GPU thread so there
    is the potential for unsafe operations. Both SyncPointManager and
    GpuMemoryBufferFactory are thread safe so they should be fine.
    
    Also ensure that GpuMemoryBuffer destruction callbacks dereference their
    WeakPtr on the correct thread. GpuMemoryBuffers can be created and used
    on any thread, even though InProcessGpuMemoryBufferManager isn't used
    on multiple threads currently.
    
    Bug: 902163
    Change-Id: I8118def4fabd0307f0a58d403b9f9c08bc72fc6b
    Reviewed-on: https://chromium-review.googlesource.com/c/1330030
    Commit-Queue: kylechar <kylechar@chromium.org>
    Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607761}

    Changed files

    • cc/test/pixel_test.cc
    • components/viz/service/display_embedder/in_process_gpu_memory_buffer_manager.cc
    • components/viz/service/display_embedder/in_process_gpu_memory_buffer_manager.h
    • components/viz/service/main/viz_compositor_thread_runner.cc
    • components/viz/service/main/viz_compositor_thread_runner.h
    • gpu/ipc/service/gpu_memory_buffer_factory.h
  15. Skia representation of SharedImageBackingAHardwareBuffer.

    Changed by Vikas Soni - vikassoniohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 22:02:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9b215c6d2ef282cea18432179e9e982814454df1

    Comments

    Skia representation of SharedImageBackingAHardwareBuffer.
    
    Add a GL backed skia representation of
    SharedImageBackingAHardwareBuffer. Update unit test.
    
    Bug: 891060
    Change-Id: Ib3b458615be13e7a536a12097e8452052b78a14f
    Reviewed-on: https://chromium-review.googlesource.com/c/1330205
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Commit-Queue: vikas soni <vikassoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607760}

    Changed files

    • gpu/command_buffer/service/shared_image_backing_factory_ahardwarebuffer.cc
    • gpu/command_buffer/service/shared_image_backing_factory_ahardwarebuffer.h
    • gpu/command_buffer/service/shared_image_backing_factory_ahardwarebuffer_unittest.cc
    • gpu/command_buffer/service/shared_image_factory.cc
    • gpu/command_buffer/service/texture_manager.h
  16. Restrict NTP fakebox ripple to P+.

    Changed by Ted Choc - tedchocohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 22:02:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 420fad0271a260be32496deb8e119e479dca5022

    Comments

    Restrict NTP fakebox ripple to P+.
    
    Pre-P there is a problem with the ripple now growing
    with the omnibox as it expands from the fakebox to the
    omnibox at the top.
    
    Limit to P+ while we investigate other solutions to
    enable this on older versions.
    
    Original CL to compare what was enabled:
    https://chromium-review.googlesource.com/c/chromium/src/+/1054851/
    
    BUG=878135
    
    Change-Id: I2a45b398e7b67cf3a1b95aeea807485bcadc9968
    Reviewed-on: https://chromium-review.googlesource.com/c/1334278
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Ted Choc <tedchoc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607759}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
  17. [unified-consent] Add bottom space to passphrase settings

    Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 22:00:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cab897cb81ae473bee349425a3b596465afa6073

    Comments

    [unified-consent] Add bottom space to passphrase settings
    
    Bug: 872673
    Change-Id: I7c304ab27f8fe2d4539be3ff99b962aefb392f89
    Reviewed-on: https://chromium-review.googlesource.com/c/1333756
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607758}

    Changed files

    • chrome/browser/resources/settings/people_page/sync_page.html
  18. [unified-consent] Fix button spacing in confirmation dialog

    Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 21:59:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c428c300ca819a2db1884be76a0fd5cefc4d035c

    Comments

    [unified-consent] Fix button spacing in confirmation dialog
    
    Bug: 872642
    Change-Id: I1b067bb722650752c00c43d0b77308214ae50fd1
    Reviewed-on: https://chromium-review.googlesource.com/c/1333655
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607757}

    Changed files

    • chrome/browser/resources/signin/dice_sync_confirmation/sync_confirmation_app.html
  19. Roll src/third_party/perfetto b73027ad4816..02761361bf6a (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 21:57:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 07ae0751dfc13e16e9b5d2e6dac7f069feedf85b

    Comments

    Roll src/third_party/perfetto b73027ad4816..02761361bf6a (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/b73027ad4816..02761361bf6a
    
    
    git log b73027ad4816..02761361bf6a --date=short --no-merges --format='%ad %ae %s'
    2018-11-13 treehugger-gerrit@google.com Merge "profiling: Check open of /proc/self/{maps,mem}."
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@02761361bf6a
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: Ibc279e1a2815f86433d69b6dd75b56cdc82c88f2
    Reviewed-on: https://chromium-review.googlesource.com/c/1333862
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607756}

    Changed files

    • DEPS
  20. Re-enable DevToolsUpdatesBrowserWindow browser test.

    Changed by Evan Stade - estadeohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 21:56:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 612f89137b9da881d5870ed35401bfb6c517c734

    Comments

    Re-enable DevToolsUpdatesBrowserWindow browser test.
    
    Passes 50x locally in both classic Ash and single process Mash.
    
    Bug: 693000
    Change-Id: Ibc950f812b6195258609ca5ea1838331bf82aae3
    Reviewed-on: https://chromium-review.googlesource.com/c/1334328
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: Evan Stade <estade@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607755}

    Changed files

    • chrome/browser/ui/views/frame/browser_view_browsertest.cc
  21. Connect the Viz DevTools server

    Changed by Sean Gilhuly - sgilhulyohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 21:56:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision da1ee4ba0aa8da0f0e6447699c230c4b3c829520

    Comments

    Connect the Viz DevTools server
    
    Create a server socket on the browser process and pass it to the viz
    process, where the Viz DevTools server is created.
    
    The server is enabled with the flag --enable-viz-devtools=<port>. If no
    port is specified, the default 9229 is used.
    
    Once running, you can connect to the server with the following url:
    chrome-devtools://devtools/bundled/inspector.html?ws=localhost:9229/0
    
    The viz devtools server should be connected on Android and when it runs
    in-process, but these haven't been tested yet.
    
    Bug: 816802
    Change-Id: Ica6b98253b49e0658a680a71fa3fe7ad083610a9
    Reviewed-on: https://chromium-review.googlesource.com/c/1309135
    Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
    Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
    Reviewed-by: kylechar <kylechar@chromium.org>
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607754}

    Changed files

    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/chrome_content_browser_client.h
    • components/viz/host/BUILD.gn
    • components/viz/host/gpu_host_impl.cc
    • components/viz/host/gpu_host_impl.h
    • components/viz/service/main/viz_compositor_thread_runner.cc
    • components/viz/service/main/viz_compositor_thread_runner.h
    • components/viz/service/main/viz_main_impl.cc
    • components/viz/service/main/viz_main_impl.h
    • content/browser/BUILD.gn
    • content/browser/gpu/DEPS
    • content/browser/gpu/gpu_process_host.cc
    • content/browser/gpu/gpu_process_host.h
    • content/browser/gpu/viz_devtools_connector.cc
    • content/browser/gpu/viz_devtools_connector.h
    • content/public/browser/content_browser_client.cc
    • content/public/browser/content_browser_client.h
    • services/viz/privileged/interfaces/BUILD.gn
    • services/viz/privileged/interfaces/viz_main.mojom
  22. IndexedDB: Move content/renderer/indexed_db/ to Blink, take 2

    Changed by Chase Phillips - cmpohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 21:50:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 86293fcec9aa3fc6934d9b51ebcf3faa53da94bd

    Comments

    IndexedDB: Move content/renderer/indexed_db/ to Blink, take 2
    
    The original CL was reverted due to an IndexedDB
    stability issue reported in https://crbug.com/899446.
    
    The stability issue was fixed as part of
    commit 48bcb8e3f5b21bba8806dfa083aa0e1fa395f061.  A test
    to verify the issue doesn't regress was landed as part of
    commit 884a9b662680278cc4c75e792fd038f155e3cce2.
    
    This change was originally a revert of the following commits:
    - commit 236db7092f734f4323be60a94f553a9b0102da1b
    - commit 63debc6587a8e13227953c8a25f3ae7c547711c1
    - commit e14fc0eec15c68760ac5211e6fc15a08d5ce4635
    
    Bug: 717812
    Change-Id: I2e1d7a12fa30ccb8cdd5d792f8e7c72b40dc30c8
    Reviewed-on: https://chromium-review.googlesource.com/c/1316830
    Commit-Queue: Chase Phillips <cmp@chromium.org>
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Robert Sesek <rsesek@chromium.org>
    Reviewed-by: Daniel Murphy <dmurph@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607753}

    Changed files

    • content/renderer/BUILD.gn
    • content/renderer/indexed_db/OWNERS
    • content/renderer/indexed_db/indexed_db_callbacks_impl.cc
    • content/renderer/indexed_db/indexed_db_callbacks_impl.h
    • content/renderer/indexed_db/indexed_db_database_callbacks_impl.h
    • content/renderer/indexed_db/indexed_db_dispatcher.cc
    • content/renderer/indexed_db/indexed_db_dispatcher.h
    • content/renderer/indexed_db/indexed_db_key_builders.h
    • content/renderer/indexed_db/webidbcursor_impl.h
    • content/renderer/indexed_db/webidbdatabase_impl.cc
    • content/renderer/indexed_db/webidbdatabase_impl_unittest.cc
    • content/renderer/render_thread_impl.cc
    • content/renderer/render_thread_impl.h
    • content/renderer/renderer_blink_platform_impl.cc
    • content/renderer/renderer_blink_platform_impl.h
    • content/test/BUILD.gn
    • content/test/data/indexeddb/cursor_prefetch.js
    • content/test/test_blink_web_unit_test_support.cc
    • content/test/test_blink_web_unit_test_support.h
    • third_party/blink/common/BUILD.gn
    • third_party/blink/common/indexeddb/indexed_db_default_mojom_traits.cc
    • third_party/blink/common/indexeddb/indexeddb_key.cc
    • third_party/blink/public/BUILD.gn
    • third_party/blink/public/common/BUILD.gn
    • third_party/blink/public/common/indexeddb/indexed_db_default.typemap
    • third_party/blink/public/common/indexeddb/indexed_db_default_mojom_traits.h
    • third_party/blink/public/common/indexeddb/indexeddb.typemap
    • third_party/blink/public/platform/modules/indexeddb/indexed_db_key_builder.h
    • third_party/blink/public/platform/modules/indexeddb/web_idb_database_callbacks.h
    • third_party/blink/public/platform/modules/indexeddb/web_idb_key.h
    • third_party/blink/public/platform/platform.h
    • third_party/blink/public/public_typemaps.gni
    • third_party/blink/renderer/modules/BUILD.gn
    • third_party/blink/renderer/modules/exported/BUILD.gn
    • third_party/blink/renderer/modules/exported/indexed_db_key_builder.cc
    • third_party/blink/renderer/modules/exported/web_idb_key.cc
    • third_party/blink/renderer/modules/indexeddb/BUILD.gn
    • third_party/blink/renderer/modules/indexeddb/OWNERS
    • third_party/blink/renderer/modules/indexeddb/idb_cursor.cc
    • third_party/blink/renderer/modules/indexeddb/idb_cursor.h
    • third_party/blink/renderer/modules/indexeddb/idb_cursor_with_value.h
    • third_party/blink/renderer/modules/indexeddb/idb_database.cc
    • third_party/blink/renderer/modules/indexeddb/idb_database.h
    • third_party/blink/renderer/modules/indexeddb/idb_factory.cc
    • third_party/blink/renderer/modules/indexeddb/idb_factory.h
    • third_party/blink/renderer/modules/indexeddb/idb_index.h
    • third_party/blink/renderer/modules/indexeddb/idb_key.cc
    • third_party/blink/renderer/modules/indexeddb/idb_key.h
    • third_party/blink/renderer/modules/indexeddb/idb_object_store.cc
    • third_party/blink/renderer/modules/indexeddb/idb_object_store.h
    • third_party/blink/renderer/modules/indexeddb/idb_open_db_request.h
    • third_party/blink/renderer/modules/indexeddb/idb_request.h
    • third_party/blink/renderer/modules/indexeddb/idb_request_queue_item.cc
    • third_party/blink/renderer/modules/indexeddb/idb_transaction.h
    • third_party/blink/renderer/modules/indexeddb/indexed_db_blink.typemap
    • third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.cc
    • third_party/blink/renderer/modules/indexeddb/indexed_db_blink_mojom_traits.h
    • third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.cc
    • third_party/blink/renderer/modules/indexeddb/indexed_db_callbacks_impl.h
    • third_party/blink/renderer/modules/indexeddb/indexed_db_database_callbacks_impl.cc
    • third_party/blink/renderer/modules/indexeddb/indexed_db_database_callbacks_impl.h
    • third_party/blink/renderer/modules/indexeddb/indexed_db_dispatcher.cc
    • third_party/blink/renderer/modules/indexeddb/indexed_db_dispatcher.h
    • third_party/blink/renderer/modules/indexeddb/inspector_indexed_db_agent.cc
    • third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.cc
    • third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.h
    • third_party/blink/renderer/modules/indexeddb/mock_web_idb_database.h
    • third_party/blink/renderer/modules/indexeddb/mock_web_idb_factory.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_callbacks_impl.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_cursor.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl_unittest.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_database.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_database_impl.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_database_impl_unittest.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_factory.h
    • third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.cc
    • third_party/blink/renderer/modules/indexeddb/web_idb_factory_impl.h
    • third_party/blink/renderer/platform/mojo/blink_typemaps.gni
    • third_party/blink/renderer/platform/testing/testing_platform_support.cc
    • third_party/blink/renderer/platform/testing/testing_platform_support.h
  23. Fix NPE during NewTabPageLayout destruction.

    Changed by Cathy Li - chiliohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 21:48:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3070fce938f26368aa80073705a2c929de4b84c8

    Comments

    Fix NPE during NewTabPageLayout destruction.
    
    Null pointer crash is caused by CompositorViewHolder nulled out before onDestroy gets called in some cases.
    
    Bug: 904245
    Change-Id: I4a8c3347a2bf7f0af2f704bc2e33cadc4534adc7
    Reviewed-on: https://chromium-review.googlesource.com/c/1334273
    Commit-Queue: Cathy Li <chili@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607752}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java
  24. [Media Engagement] Remove histogram

    Changed by Becca Hughes - beccahughesohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 21:47:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a78d20743acc9e2777aa375d4dee2d8e970317bc

    Comments

    [Media Engagement] Remove histogram
    
    Remove the ScoreAtStartup histogram as it was causing
    jank and we were not using it.
    
    BUG=900679
    
    Change-Id: I004743c48425c9bb3fbbed67004c7616ef290cf9
    Reviewed-on: https://chromium-review.googlesource.com/c/1330211
    Commit-Queue: Becca Hughes <beccahughes@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: Brian White <bcwhite@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607751}

    Changed files

    • chrome/browser/media/media_engagement_service.cc
    • chrome/browser/media/media_engagement_service.h
    • chrome/browser/media/media_engagement_service_unittest.cc
    • tools/metrics/histograms/histograms.xml
  25. [service-manager] Clean up Connector API

    Changed by Ken Rockot - rockotohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 21:47:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a86fa542fff877da2589b284d800b3924d30710f

    Comments

    [service-manager] Clean up Connector API
    
    Updates the Connector mojom and C++ APIs with clarifying naming and
    type usage.
    
    Connector has accumulated lots of cruft over the years and its API
    conveys a number of muddled concepts which have lead to general
    confusion, misuse, and abuse.
    
    This attempts to sort all that out. Namely:
    
      - All use of Identity in the Connector API has been migrated to
        ServiceFilter where appropriate.
      - StartService (first version) has been renamed to WarmService to
        convey the correct intent. Bugs filed and TODOs dropped in places
        where this is being used in an undesirable fashion.
      - StartService (second version) has been renamed to
        RegisterServiceInstance to convey more accurately what it does.
        It also requires a complete Identity to be provided by the trusted
        caller.
      - QueryService takes only a service name instead of an Identity, since
        it only needs to take a service name. It also makes no service
        connection so it no longer returns a ConnectResult.
      - FilterInterfaces is marked as deprecated on the mojom interface,
        because we want to obliterate it.
      - Test-only methods have been properly suffixed and made public,
        eliminating the need for the weird TestApi wrapper thing. A
        follow-up CL will delete TestApi and migrate its users.
      - Connector methods which have async replies have optional callbacks
        now instead of the Connector weirdly having a single catch-all
        (and dubiously named) "StartServiceCallback" to handle all replies.
    
    Bug: 902590
    Change-Id: I5a986a5c114da914fd624dac7e6fd021cf139958
    Reviewed-on: https://chromium-review.googlesource.com/c/1329845
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Commit-Queue: Ken Rockot <rockot@google.com>
    Cr-Commit-Position: refs/heads/master@{#607750}

    Changed files

    • android_webview/renderer/aw_content_renderer_client.cc
    • ash/accelerators/debug_commands.cc
    • ash/app_launch_unittest.cc
    • ash/ash_service_unittest.cc
    • ash/assistant/assistant_controller.cc
    • ash/keyboard/ash_keyboard_controller_unittest.cc
    • ash/multi_device_setup/multi_device_notification_presenter.cc
    • ash/multi_device_setup/multi_device_notification_presenter_unittest.cc
    • ash/shell.cc
    • ash/shell/content/client/shell_browser_main_parts.cc
    • ash/system/flag_warning/flag_warning_tray.cc
    • chrome/browser/chrome_browser_main.cc
    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/chrome_service.cc
    • chrome/browser/chrome_site_per_process_browsertest.cc
    • chrome/browser/extensions/system_display/display_info_provider_chromeos_unittest.cc
    • chrome/browser/spellchecker/test/spellcheck_content_browser_client.cc
    • chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc
    • content/browser/browser_child_process_host_impl.cc
    • content/browser/browser_context.cc
    • content/browser/browser_main_loop.cc
    • content/browser/renderer_host/media/media_devices_manager.cc
    • content/browser/renderer_host/render_process_host_impl.cc
    • content/browser/service_manager/service_manager_context.cc
    • content/common/service_manager/child_connection.cc
    • content/public/browser/render_process_host.h
    • content/renderer/render_thread_impl_browsertest.cc
    • ios/web/browser_state.mm
    • ios/web/service_manager_context.mm
    • mash/session/session.cc
    • services/preferences/pref_service_factory_unittest.cc
    • services/resource_coordinator/resource_coordinator_service_unittest.cc
    • services/service_manager/background/tests/background_service_manager_unittest.cc
    • services/service_manager/connect_params.cc
    • services/service_manager/connect_params.h
    • services/service_manager/connect_util.cc
    • services/service_manager/public/cpp/connector.cc
    • services/service_manager/public/cpp/connector.h
    • services/service_manager/public/cpp/service_filter.cc
    • services/service_manager/public/cpp/service_filter.h
    • services/service_manager/public/cpp/test/test_connector_factory.cc
    • services/service_manager/public/mojom/connector.mojom
    • services/service_manager/service_manager.cc
    • services/service_manager/tests/connect/connect_test_app.cc
    • services/service_manager/tests/connect/connect_test_package.cc
    • services/service_manager/tests/connect/connect_unittest.cc
    • services/service_manager/tests/lifecycle/lifecycle_unittest.cc
    • services/service_manager/tests/service_manager/service_manager_unittest.cc
    • services/service_manager/tests/util.cc
    • services/service_manager/tests/util.h
    • services/tracing/tracing_service_unittest.cc
    • services/ws/ime/ime_driver_bridge.cc
    • services/ws/ime/ime_driver_bridge.h
    • services/ws/ime/ime_unittest.cc
  26. [chromecast] Draw a ring around screen in magnifier

    Changed by Ryan Daum - rdaumohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 21:45:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ac963a3f21d2647534c024e124e06f0ecfb9189

    Comments

    [chromecast] Draw a ring around screen in magnifier
    
    Draws an orange ring around the screen while magnification is enabled,
    as on Android.
    
    Bug: internal b/112634030
    Test: manual
    Change-Id: Iac134759c7f6e931c7c4a4407d827fc7a75fedca
    Reviewed-on: https://chromium-review.googlesource.com/c/1334197
    Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
    Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
    Commit-Queue: Ryan Daum <rdaum@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607749}

    Changed files

    • chromecast/graphics/accessibility/fullscreen_magnification_controller.cc
    • chromecast/graphics/accessibility/fullscreen_magnification_controller.h
  27. Create duplicate src-side configs for all chromium.lkgr bots.

    Changed by Ben Pastene - bpasteneohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 21:44:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7d61bb26afe6b8e0749af5de3d28513eca6c9c19

    Comments

    Create duplicate src-side configs for all chromium.lkgr bots.
    
    This is in preparation for their move from chromium.lkgr to chromium.fuzz
    
    Bug: 903591
    Change-Id: Ic01978e91339d71a5e69880274fd91c299cb98b6
    Reviewed-on: https://chromium-review.googlesource.com/c/1332770
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Commit-Queue: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607748}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
    • infra/config/global/luci-milo.cfg
    • testing/buildbot/chromium.fuzz.json
    • testing/buildbot/waterfalls.pyl
    • tools/mb/mb_config.pyl
  28. Revert "Reland "Perfetto: Optimization to avoid string table lookup for _END events""

    Changed by oysteine - oysteineohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 21:44:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a6bcdc64c6eec541ccc82f67a166f6854b6180cf

    Comments

    Revert "Reland "Perfetto: Optimization to avoid string table lookup for _END events""
    
    This reverts commit c972056412f05ea6253d8c678cd0c789f9396244.
    
    Reverting this; looks like the increased bytes used due to stringtable indices being hashes rather than sequential numbering is causing the trace chunks to fill up quicker and negates the optimization.
    
    BUG=903762
    Original change's description:
    > Reland "Perfetto: Optimization to avoid string table lookup for _END events"
    > 
    > This reverts commit 7acd0b524621d76fbaefdf397fdb37662bd8bf66.
    > 
    > Reason for revert: Re-landing with crashfix
    > 
    > Original change's description:
    > > Revert "Perfetto: Optimization to avoid string table lookup for _END events"
    > > 
    > > This reverts commit a7afe430785635f9608a2c0889295d698547a87b.
    > > 
    > > Reason for revert: I suspect this may have caused crashes on https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/linux-perf-fyi#
    > > 
    > > Original change's description:
    > > > Perfetto: Optimization to avoid string table lookup for _END events
    > > > 
    > > > If we're emitting an _END trace event, we know that the string
    > > > table entries for the name and the categories have already been
    > > > emitted and so we don't need to check the string table in this
    > > > case.
    > > > 
    > > > R=​primiano@chromium.org,skyostil@chromium.org
    > > > 
    > > > Change-Id: I9107bffb0b48f7b71d0a42961a78a3861ffcb76f
    > > > Reviewed-on: https://chromium-review.googlesource.com/c/1258043
    > > > Commit-Queue: oysteine <oysteine@chromium.org>
    > > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#600183}
    > > 
    > > TBR=primiano@chromium.org,oysteine@chromium.org,skyostil@chromium.org
    > > 
    > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > > 
    > > Change-Id: Ia460750fcaf338c4bf24ee7317d58b7aeede9520
    > > Reviewed-on: https://chromium-review.googlesource.com/c/1293612
    > > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
    > > Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#601586}
    > 
    > TBR=cbiesinger@chromium.org,primiano@chromium.org,oysteine@chromium.org,skyostil@chromium.org
    > 
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    > 
    > Change-Id: I8f3b5c21494d66fe9e6c25363627ec156f5abf12
    > Reviewed-on: https://chromium-review.googlesource.com/c/1325077
    > Commit-Queue: oysteine <oysteine@chromium.org>
    > Reviewed-by: oysteine <oysteine@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606308}
    
    TBR=cbiesinger@chromium.org,primiano@chromium.org,oysteine@chromium.org,skyostil@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Change-Id: I4719cde108d34cee7223615861c1f7cfac31bcd0
    Reviewed-on: https://chromium-review.googlesource.com/c/1334199
    Reviewed-by: oysteine <oysteine@chromium.org>
    Commit-Queue: oysteine <oysteine@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607747}

    Changed files

    • services/tracing/perfetto/json_trace_exporter.cc
    • services/tracing/public/cpp/perfetto/trace_event_data_source.cc
  29. [AF Paradise] Reset migration acceptance bit after a migration

    Changed by siyua - siyuaohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 21:42:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b834898709772ff1af9b3d4ed79791fb683e2245

    Comments

    [AF Paradise] Reset migration acceptance bit after a migration
    
    If one migration request is finished and the user submits another
    migration request in the same tab, the card would be automatically saved.
    
    Reason: The member variable user_accepted_main_migration_dialog_ is not
    correctly reset to false after a request is sent. So when next time the
    risk data is loaded, a request would be direcly sent to server.
    
    This is a bug for M71 code. Need to merge asap.
    
    Bug: 897998
    Change-Id: Ia77cdddc6d80550e0e23ff327f07a5c7279ba15f
    Reviewed-on: https://chromium-review.googlesource.com/c/1333122
    Commit-Queue: Siyu An <siyua@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607746}

    Changed files

    • components/autofill/core/browser/local_card_migration_manager.cc
  30. [ios] Fix BubblePresenter logic for new NTP.

    Changed by Justin Cohen - justincohenohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 21:39:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fcacbb1a0d94034fd088845706c1a302953728f6

    Comments

    [ios] Fix BubblePresenter logic for new NTP.
    
    For native controllers, we don't update the contentInset, so it
    doesn't make sense to compare the native contentOffset to the
    CRWScrollViewProxy.contentInset.
    
    Change-Id: I4fda19725cecbd70af2a054bd3c2132d5b0a25fd
    Reviewed-on: https://chromium-review.googlesource.com/c/1333870
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607745}

    Changed files

    • ios/chrome/browser/ui/browser_view_controller.mm
  31. Remove deprecated feature policy methods on Frame.

    Changed by Ian Clelland - iclellandohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 21:38:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 84a7f05e96d1c67b6ecf0d2e7605c3ec00e832f7

    Comments

    Remove deprecated feature policy methods on Frame.
    
    Bug: 888668
    Change-Id: Iec4e28d6f62d8b146b3e5311197e58e4df4b5dc2
    Reviewed-on: https://chromium-review.googlesource.com/c/1331630
    Reviewed-by: Steve Kobes <skobes@chromium.org>
    Commit-Queue: Ian Clelland <iclelland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607744}

    Changed files

    • third_party/blink/renderer/core/frame/frame.cc
    • third_party/blink/renderer/core/frame/frame.h
    • third_party/blink/renderer/core/frame/local_frame.cc
    • third_party/blink/renderer/core/frame/local_frame.h
  32. [CrOS MultiDevice] Create metrics for Verify and Forget Host

    Changed by Regan Hsu - hsureganohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 21:35:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c6c9e18b12e34f827dbedf14fc885f86123229f6

    Comments

    [CrOS MultiDevice] Create metrics for Verify and Forget Host
    confirmation buttons.
    
    MultiDevice.VerifyButtonClicked
    MultiDevice.ForgetHostConfirmed
    
    Gauge if users are getting stuck in bad states or do not like our
    feature by logging when the Verify button or Forget Host confirmation
    buttons are pressed. Simply logging the count of these events isn't
    useful because there is no baseline; therefore, each of these should
    use the following buckets:
    
    0) Button clicked.
    1) Completed Setup.
    
    Bug: 903458
    Change-Id: I1ad8e6a16a920b4dffdbcc70300bff354ef6f359
    Reviewed-on: https://chromium-review.googlesource.com/c/1330294
    Reviewed-by: Steven Holte <holte@chromium.org>
    Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
    Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
    Commit-Queue: Regan Hsu <hsuregan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607743}

    Changed files

    • chromeos/services/multidevice_setup/multidevice_setup_impl.cc
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
  33. Navi: Medium font weight for selected option in email and apps.

    Changed by Hector Carmona - hcarmonaohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 21:30:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1e711c42cb6af258aa72b76a9660148cc78ed819

    Comments

    Navi: Medium font weight for selected option in email and apps.
    
    Screenshots in bug.
    
    Bug: 901210
    Change-Id: I7a8cc24801ac66fd2d9e01a4bae03824811dd19d
    Reviewed-on: https://chromium-review.googlesource.com/c/1332715
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Commit-Queue: Hector Carmona <hcarmona@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607742}

    Changed files

    • chrome/browser/resources/welcome/onboarding_welcome/shared/chooser_shared_css.html
  34. Roll src/third_party/catapult c14a383e61b4..6d64a5e5e40b (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 21:25:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f613b78ef25828747990f10ffc871812db717f3

    Comments

    Roll src/third_party/catapult c14a383e61b4..6d64a5e5e40b (2 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/c14a383e61b4..6d64a5e5e40b
    
    
    git log c14a383e61b4..6d64a5e5e40b --date=short --no-merges --format='%ad %ae %s'
    2018-11-13 benjhayden@chromium.org Add alerts-table to v2spa.
    2018-11-13 perezju@chromium.org Reland "[Telemetry] Increase timeout on CollectChromeTracingData"
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@6d64a5e5e40b
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:900920,chromium:902064
    TBR=sullivan@chromium.org
    
    Change-Id: Ib20da9ac3441be3a3952d0812f9e9d918865e234
    Reviewed-on: https://chromium-review.googlesource.com/c/1334248
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607741}

    Changed files

    • DEPS
  35. [Fuchsia] Migrate Chromium to new epitaph-friendly error handlers.

    Changed by Jeremy Manson - jeremymansonohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 21:12:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 18f6ea3c24b6ffb07dac08ee2928ff0f63e054e8

    Comments

    [Fuchsia] Migrate Chromium to new epitaph-friendly error handlers.
    
    R=kmarshall@chromium.org, sky@chromium.org, wez@google.com
    
    Bug: FIDL-319
    Change-Id: I536f7cbaa670b439be621bcda8439a9d4597ee41
    Reviewed-on: https://chromium-review.googlesource.com/c/1324918
    Commit-Queue: Jeremy Manson <jeremymanson@google.com>
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607740}

    Changed files

    • base/fuchsia/filtered_service_directory_unittest.cc
    • base/fuchsia/service_directory_test_base.cc
    • base/fuchsia/service_directory_test_base.h
    • base/fuchsia/service_directory_unittest.cc
    • chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia.cc
    • chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia.h
    • media/audio/fuchsia/audio_output_stream_fuchsia.cc
    • media/audio/fuchsia/audio_output_stream_fuchsia.h
    • media/filters/fuchsia/fuchsia_video_decoder.cc
    • net/base/network_change_notifier_fuchsia.cc
    • ui/base/ime/fuchsia/input_method_keyboard_controller_fuchsia.cc
    • ui/ozone/platform/scenic/scenic_window.cc
    • ui/ozone/platform/scenic/scenic_window.h
    • ui/ozone/platform/scenic/scenic_window_manager.cc
    • webrunner/app/common/web_component.cc
    • webrunner/app/common/web_content_runner.cc
    • webrunner/browser/frame_impl.cc
    • webrunner/browser/frame_impl_browsertest.cc
    • webrunner/browser/webrunner_browser_main_parts.cc
    • webrunner/net_http/http_service_unittest.cc
    • webrunner/net_http/url_loader_impl.cc
    • webrunner/service/context_provider_impl_unittest.cc
  36. Roll src-internal b822560337a6..ab3176972380 (5 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 21:08:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 357bef2fb0bcdca16a55900ad0f34bf3c6e41df1

    Comments

    Roll src-internal b822560337a6..ab3176972380 (5 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b822560337a6..ab3176972380
    
    
    Created with:
      gclient setdep -r src-internal@ab3176972380
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ic8e2c07c732e0a891cb703d9849671e24772eccd
    Reviewed-on: https://chromium-review.googlesource.com/c/1333866
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607739}

    Changed files

    • DEPS
  37. EXO: Refactored text input interface into its own file

    Changed by Shawn Gallea - sagalleaohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 21:05:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aad8b28a8aade3673fc088a466d5af7b99c1bd33

    Comments

    EXO: Refactored text input interface into its own file
    
    Moved text_input_manager_v1 interface into another file,
    to be followed by refactoring of more protocols.
    
    Refactor wayland_text_input_delegate.* from server.cc
    with no new code.
    
    Modify server_util to add more utilities
    
    Bug: 896710
    Test: Compiled on ChromeOS.
    Change-Id: I2739c538a16640fdaebed1cd7493d300dd42a5a9
    Reviewed-on: https://chromium-review.googlesource.com/c/1306406
    Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
    Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
    Commit-Queue: Shawn Gallea <sagallea@google.com>
    Cr-Commit-Position: refs/heads/master@{#607738}

    Changed files

    • components/exo/wayland/BUILD.gn
    • components/exo/wayland/server.cc
    • components/exo/wayland/server_util.cc
    • components/exo/wayland/server_util.h
    • components/exo/wayland/zwp_text_input_manager.cc
    • components/exo/wayland/zwp_text_input_manager.h
  38. chromeos: copies file to ash

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 21:03:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f347ba6a419120c7cb2e3d29848a0ea1f7a284a8

    Comments

    chromeos: copies file to ash
    
    This is a copy of c/b/ui/ash/multi_user_window_manager_chromeos* to ash.
    I'm doing this as a precursor to a refactoring so you can better see what
    changes. I've only changed things necessary to avoid presubmit checks. This
    file is purposely not compiled now as it needs to be cleaned up first.
    
    BUG=756085
    TEST=nothing new is compiled, so no tests.
    
    Change-Id: I946d9e3b582142761e6519bf754733649d1a7612
    Reviewed-on: https://chromium-review.googlesource.com/c/1330078
    Commit-Queue: Scott Violet <sky@chromium.org>
    Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607737}

    Changed files

    • ash/multi_user/OWNERS
    • ash/multi_user/multi_user_window_manager.cc
    • ash/multi_user/multi_user_window_manager.h
  39. Update integer types for Http2Random.

    Changed by Dianna Hu - diannahuohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 21:03:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 616c4b9d67dfeed9723e70cc036866ea01ceb895

    Comments

    Update integer types for Http2Random.
    
    This CL updates Http2Random to use unsigned integers consistently, in
    hopes of being platform-agnostic (see, e.g.,
    https://crrev.com/c/1310613).
    
    This CL lands server changes 221087569 by bnc and 221279592 by diannahu.
    
    Change-Id: Ifb1ea404887ab46569572a27b0c61c7e1bf1a26f
    Reviewed-on: https://chromium-review.googlesource.com/c/1334009
    Reviewed-by: Bence Béky <bnc@chromium.org>
    Commit-Queue: Dianna Hu <diannahu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607736}

    Changed files

    • net/third_party/http2/test_tools/http2_random.h
  40. Make WebAuthN HoverListView scrollable

    Changed by Jun Choi - hongjunchoiohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 21:02:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2471aebe1473ee3a3cd8ec924c2b1cb6dff2d9d1

    Comments

    Make WebAuthN HoverListView scrollable
    
    HoverListView is a model-agnostic view that holds multiple
    clickable item views. In WebAuthn, this view is used to display a list
    of BLE authenticators. This CL makes the view scrollable to handle
    an arbitrary number of BLE authenticators in the UI.
    
    Bug: 877344
    Change-Id: I86f68bc3939ff661c982ae0e6bec1eed2d9a3a3a
    Reviewed-on: https://chromium-review.googlesource.com/c/1322832
    Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
    Reviewed-by: Balazs Engedy <engedy@chromium.org>
    Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607735}

    Changed files

    • chrome/browser/ui/views/webauthn/hover_list_view.cc
    • chrome/browser/ui/views/webauthn/hover_list_view.h
    • chrome/browser/ui/webauthn/ble_device_hover_list_model.cc
    • chrome/browser/ui/webauthn/ble_device_hover_list_model.h
    • chrome/browser/ui/webauthn/hover_list_model.h
    • chrome/browser/ui/webauthn/transport_hover_list_model.cc
    • chrome/browser/ui/webauthn/transport_hover_list_model.h
  41. Automated VR refresh test

    Changed by bsheedy - bsheedyohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 21:01:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 737f4fdfcfeafae5922643151af4d818acd884fe

    Comments

    Automated VR refresh test
    
    Automates the manual test for ensuring that the refresh button in the
    VR browser's overflow menu functions as expected.
    
    Bug: 887510
    Change-Id: I9e97f5b5c313229e8845ef7fc0f1e2730434bf29
    Reviewed-on: https://chromium-review.googlesource.com/c/1333111
    Reviewed-by: Bill Orr <billorr@chromium.org>
    Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607734}

    Changed files

    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrBrowserControllerInputTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrBrowserNavigationTest.java
  42. Add kenrb as per-file owner in content/browser/frame_host.

    Changed by Charlie Reis - creisohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 20:59:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 43ee9538b6224d3897d1b7681ad4df35b1816741

    Comments

    Add kenrb as per-file owner in content/browser/frame_host.
    
    Change-Id: I968c0faf6ff19d6225015967d82440b1f80c4f0c
    Reviewed-on: https://chromium-review.googlesource.com/c/1333865
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    Commit-Queue: Charlie Reis <creis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607733}

    Changed files

    • content/browser/frame_host/OWNERS
  43. Treat clock updates to never add a negative usage window.

    Changed by Henrique Grandinetti - hgrandinettiohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 20:57:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6eeb7d038d2afb6661dbea710a616dba51785825

    Comments

    Treat clock updates to never add a negative usage window.
    
    Bug: 899980
    Change-Id: I196999915290fe07322d934423430a0782c7ba55
    Reviewed-on: https://chromium-review.googlesource.com/c/1330224
    Reviewed-by: Sergey Poromov <poromov@chromium.org>
    Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607732}

    Changed files

    • chrome/browser/chromeos/policy/device_status_collector.cc
    • chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
  44. Re-enable BookmarkBrowsertest.Persist

    Changed by Ryan Meier - rameierohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 20:56:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b524b3f6c7c52a112e1de5c21b2600a76f484182

    Comments

    Re-enable BookmarkBrowsertest.Persist
    
    (Previously disabled due to apparent flakiness, but I've been unable to reproduce that behavior).
    
    Change-Id: I16433fa2ca8496cf2200f7a6948866b6b7e3efdf
    Reviewed-on: https://chromium-review.googlesource.com/c/1332208
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Ryan Meier <rameier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607731}

    Changed files

    • chrome/browser/ui/bookmarks/bookmark_browsertest.cc
  45. Roll src/third_party/skia f47abb48757f..9d958b54af30 (6 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 20:49:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0c3acc38d3f72c04cce3f8e8376075d99829c7c3

    Comments

    Roll src/third_party/skia f47abb48757f..9d958b54af30 (6 commits)
    
    https://skia.googlesource.com/skia.git/+log/f47abb48757f..9d958b54af30
    
    
    git log f47abb48757f..9d958b54af30 --date=short --no-merges --format='%ad %ae %s'
    2018-11-13 brianosman@google.com Update several more oval ops to use WriteVertexData
    2018-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cd47a379f960..2778029563f2 (2 commits)
    2018-11-13 mtklein@google.com remove opaque/alpha distinction in SSSE3 code
    2018-11-13 herb@google.com Move strike cache backpointer to glyph cache
    2018-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1147fc2a5dac..6ed398b46847 (1 commits)
    2018-11-13 mtklein@google.com drop sub_y == 0 optimization
    
    
    Created with:
      gclient setdep -r src/third_party/skia@9d958b54af30
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    TBR=rmistry@chromium.org
    
    Change-Id: I2099d5fd7b5b651e9ef133c3784f282aeb8da16e
    Reviewed-on: https://chromium-review.googlesource.com/c/1333864
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607730}

    Changed files

    • DEPS
  46. [NTP] send message to iframed doodle when expansion is complete

    Changed by Kyle Milka - kmilkaohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 20:44:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision da91071dffa07f9f66e46e148907084a5f0569f6

    Comments

    [NTP] send message to iframed doodle when expansion is complete
    
    When the iframe finishes resizing send a postMessage to the doodle
    iframe letting it know the expansion has finished.
    
    b/118340003
    
    Change-Id: Ic974ca58f51882d932e8de10c5706990f8f462cd
    Reviewed-on: https://chromium-review.googlesource.com/c/1323620
    Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
    Commit-Queue: Kyle Milka <kmilka@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607729}

    Changed files

    • chrome/browser/resources/local_ntp/local_ntp.js
  47. Import wpt@4cf6f845d427b856b1d7557aeaf02c199e6e1d81

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 20:44:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 149e294e569919d9af657a3b065e5ec09cd6bc85

    Comments

    Import wpt@4cf6f845d427b856b1d7557aeaf02c199e6e1d81
    
    Using wpt-import in Chromium 95852cba4a77c5a9bb5c1ffae5bc9e7e785fe0de.
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    NOAUTOREVERT=true
    TBR=kyleju
    
    No-Export: true
    Change-Id: I19cfd09cecfc2391f580e03ef1211f72e38d5e28
    Reviewed-on: https://chromium-review.googlesource.com/c/1334189
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607728}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/cors/access-control-expose-headers-parsing.window-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/cors/access-control-expose-headers-parsing.window.js
    • third_party/WebKit/LayoutTests/external/wpt/cors/resources/access-control-expose-headers-parsing-2.asis
    • third_party/WebKit/LayoutTests/external/wpt/cors/resources/access-control-expose-headers-parsing.asis
    • third_party/WebKit/LayoutTests/external/wpt/cors/resources/access-control-expose-headers.json
    • third_party/WebKit/LayoutTests/external/wpt/cors/resources/expose-headers.py
  48. Fix a typo in DCHECK_IS_CONFIGURABLE define

    Changed by Tomas Popela - tomas.popelaohnoyoudont@gmail.com
    Changed at Tuesday, 13-Nov-18 20:42:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision afffa97c98b0757c495e2c5a7e57761e8dd8a544

    Comments

    Fix a typo in DCHECK_IS_CONFIGURABLE define
    
    DHECK should be DCHECK.
    
    Change-Id: I3368631dee61b472d8bd58d38a4d3df3dd3900b1
    Reviewed-on: https://chromium-review.googlesource.com/c/1332931
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Tomáš Popela <tomas.popela@gmail.com>
    Cr-Commit-Position: refs/heads/master@{#607727}

    Changed files

    • base/feature_list.cc
    • base/feature_list.h
    • base/logging.cc
    • base/logging.h
    • base/logging_unittest.cc
    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • chrome/common/channel_info_win.cc
    • content/renderer/render_process_impl.cc
  49. Do not bubble GFS events from oopif.

    Changed by Sahel Sharify - sahelohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 20:41:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dc59b447f027f67515929b508afe948b5ad3ef41

    Comments

    Do not bubble GFS events from oopif.
    
    With browser side fling instead of queuing a GFS in gesture event queue
    the fling controller processes the event immediately. It means that it is
    possible to process the GFS before arrival of the GSB's ack. This behavior
    does not cause any issues since after processing the GFS event the fling
    controller starts to generate GSU events at every begin frame. Since the
    generated GSU events are queued in gesture event queue they will wait for
    the ack of the GSB before getting processed.
    
    The only issue with the logic above is when we are bubbling GFS:
    It is possible that the fling controller processes the GFS before the
    ack of the GSB is arrived. In this case we won't bubble the GFS since
    we only bubble the rest of the scroll events in a sequence only when
    the GSB of the sequence is bubbled.
    
    This cl changes the scroll bubbling logic to avoid GFS bubbling. With
    this change the GFS won't get bubbled and the fling controller of the
    oopif will generate GSU events which will get bubbled. When the bubbling
    target did not consume a generated GSU event it will tell the oopif's fling
    controller (via RWH_input_event_router) to stop flinging.
    
    The first three tests are not new. They just show that the flinging on
    the oopif still causes the parent to scroll when we are bubbling scroll.
    The last test shows that the child's fling controller stops flinging when
    the parent's renderer does not consumed the generated GSUs that are bubbled.
    
    I also changed the following tests to be browser tests since instead of the
    fling controller cancelling the fling when generated GSUs are not consumed
    the RWHV_* calls stop fling. This change is necessary since the RWHV_* knows
    when the scroll is getting bubbled but the fling controller does not:
    -Early[Touchpad|Touchscreen]FlingCancelationOnInertialGSUAckNotConsumed
    
    BrowserSideFlingBrowserTest.TouchscreenInertialGSUsBubblesFromOOPIF,
    BrowserSideFlingBrowserTest.InertialGSEGetsBubbledFromOOPIF,
    BrowserSideFlingBrowserTest.InertialGSUBubblingStopsWhenParentCannotScroll
    
    Bug: 900357
    Test: BrowserSideFlingBrowserTest.TouchpadInertialGSUsBubblesFromOOPIF,
    Change-Id: I784aa03b561d0482a95341544133761e40a1917f
    Reviewed-on: https://chromium-review.googlesource.com/c/1308598
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    Reviewed-by: Fady Samuel <fsamuel@chromium.org>
    Reviewed-by: Kevin McNee <mcnee@chromium.org>
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Commit-Queue: Sahel Sharify <sahel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607726}

    Changed files

    • content/browser/frame_host/cross_process_frame_connector.cc
    • content/browser/frame_host/render_widget_host_view_guest.cc
    • content/browser/renderer_host/input/fling_browsertest.cc
    • content/browser/renderer_host/input/fling_controller.cc
    • content/browser/renderer_host/input/fling_controller.h
    • content/browser/renderer_host/input/fling_controller_unittest.cc
    • content/browser/renderer_host/input/gesture_event_queue.cc
    • content/browser/renderer_host/render_widget_host_input_event_router.cc
    • content/browser/renderer_host/render_widget_host_input_event_router.h
    • content/browser/renderer_host/render_widget_host_view_android.cc
    • content/browser/renderer_host/render_widget_host_view_aura.cc
    • content/browser/renderer_host/render_widget_host_view_base.cc
    • content/browser/renderer_host/render_widget_host_view_base.h
    • content/browser/renderer_host/render_widget_host_view_child_frame.cc
    • content/browser/renderer_host/render_widget_host_view_child_frame.h
    • content/browser/renderer_host/render_widget_host_view_mac.mm
  50. Add some additional metadata to Popup.Closed UKM

    Changed by Charlie Harrison - csharrisonohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 20:40:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c8b7a36c15a410644979d1470baea96d5a9c42e

    Comments

    Add some additional metadata to Popup.Closed UKM
    
    This CL extends the amount of useful information a popup tracker
    has, and reports it to UKM on close.
    
    This data will additionally be useful if we add spammy popup detection
    + enforcement at run time.
    
    Bug: 825875
    Change-Id: I1366b795c500cbf58730887cf4e71c3f32b945a8
    Reviewed-on: https://chromium-review.googlesource.com/c/1313508
    Reviewed-by: Steven Holte <holte@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: Charlie Harrison <csharrison@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607725}

    Changed files

    • chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc
    • chrome/browser/ui/blocked_content/popup_tracker.cc
    • chrome/browser/ui/blocked_content/popup_tracker.h
    • chrome/browser/ui/blocked_content/popup_tracker_browsertest.cc
    • chrome/browser/ui/browser.cc
    • tools/metrics/ukm/ukm.xml
  51. [AF Android] Fix height of multiline rows

    Changed by Tommy Martino - tmartinoohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 20:31:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9196ef69e8a4d6ed2f26caf2c9ba0d8f01f07abe

    Comments

    [AF Android] Fix height of multiline rows
    
    Multiline entries are used mostly for warnings and other edge cases
    where descriptive text is needed. By their nature the height is
    variable, so we need to set padding and use a content-wrapping height.
    This was done in the old implementation but errantly not carried over to
    the refactor.
    
    Bug: 903554
    Change-Id: I6e9873c757fb9087af3066bb55017badccd15149
    Reviewed-on: https://chromium-review.googlesource.com/c/1327579
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Tommy Martino <tmartino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607724}

    Changed files

    • components/autofill/android/java/res/layout/autofill_dropdown_item_refresh.xml
  52. Use DLOG to report lost shared UI context

    Changed by Andrey Lushnikov - lushnikovohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 20:24:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6e67f5d0194f8e7f8565f68a0d05200b9e78a8a2

    Comments

    Use DLOG to report lost shared UI context
    
    The GpuProcessTransportFactory::OnLostMainThreadSharedContext gets
    called in a valid codepathes inside compositor - this message
    should not be reported to regular users.
    
    This causes a lot of confusion to Chrome Puppeteer clients who
    attribute their issues to the first error they see in terminal:
    https://github.com/GoogleChrome/puppeteer/issues/1925
    
    Change-Id: Ib6c6862e6fb6a71fae388675d6dc709cf99503c8
    Reviewed-on: https://chromium-review.googlesource.com/c/1333832
    Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
    Reviewed-by: danakj <danakj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607723}

    Changed files

    • content/browser/compositor/gpu_process_transport_factory.cc
  53. Hide all cloud reporting policies

    Changed by Owen Min - zminohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 20:19:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 516aa8b9a4f04b08917f3e8807b17b694e15075e

    Comments

    Hide all cloud reporting policies
    
    These policies are encouraged to be set via cloud policy. Hide them from
    policy template and documentation.
    
    Change-Id: Ifb7c258daa4da6aeeccefbb61d11a0b68498507e
    Reviewed-on: https://chromium-review.googlesource.com/c/1332255
    Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
    Commit-Queue: Owen Min <zmin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607722}

    Changed files

    • components/policy/resources/policy_templates.json
  54. Fix NULL pointer dereferncing in AutoSigninFirstRunDialogView.

    Changed by Vasilii Sukhanov - vasiliiohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 20:17:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a57caedba785d464d0b324ab8ff086162fea1b1f

    Comments

    Fix NULL pointer dereferncing in AutoSigninFirstRunDialogView.
    
    This is exactly the same crash and fix as in https://chromium-review.googlesource.com/c/chromium/src/+/951002/
    
    The fix is for 3 different crashes.
    - AutoSigninFirstRunDialogView::ControllerGone can trigger some accessibility events. The framework needs the title of the dialog. As a result the controller is dereferenced.
    - AutoSigninFirstRunDialogView::Accept and AutoSigninFirstRunDialogView::Cancel. On Mac those events may be triggered when the dialog already disappeared. Therefore, a NULL-check is required before pinging the controller.
    
    Bug: 904154
    Change-Id: I58904340599227a5b06eb00a3d46f180bc2864a6
    Reviewed-on: https://chromium-review.googlesource.com/c/1333659
    Reviewed-by: Vaclav Brozek <vabr@chromium.org>
    Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607721}

    Changed files

    • chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc
  55. TaskScheduler: Add methods RemoveSequence() and UpdateSortKey() to PriorityQueue

    Changed by Jesse McKenna - jessemckennaohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 20:14:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 746e4da6fc0f9eaefbc93949982737d6c561b800

    Comments

    TaskScheduler: Add methods RemoveSequence() and UpdateSortKey() to PriorityQueue
    
    Bug: 889029
    Change-Id: I4fb7cf0011d067c24f26914009681563baf51d11
    Reviewed-on: https://chromium-review.googlesource.com/c/1331949
    Commit-Queue: Jesse McKenna <jessemckenna@google.com>
    Reviewed-by: François Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607720}

    Changed files

    • base/task/task_scheduler/priority_queue.cc
    • base/task/task_scheduler/priority_queue.h
    • base/task/task_scheduler/priority_queue_unittest.cc
    • base/task/task_scheduler/sequence.cc
    • base/task/task_scheduler/sequence.h
  56. Revert "Partial revert of "Use preferred language in extension i18n""

    Changed by Mike Wittman - wittmanohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 20:12:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df2c70fcdb46d29057b48084c2571f9373ba4eff

    Comments

    Revert "Partial revert of "Use preferred language in extension i18n""
    
    This reverts commit ce0ec6fc14e4b07ae2d17fddd3c329cc38c8e004.
    
    Reason for revert: While the perf regression may have been caused by the original CL, it was transient. 
    
    Original change's description:
    > Partial revert of "Use preferred language in extension i18n"
    > 
    > This is a logical revert of "Use preferred language in extension i18n"
    > (commit 693d01a674be72cb5ee4bf1f0c622189e7e05b37). Because of some
    > intervening changes causing more complicated merges, it's simpler to
    > just undo the side effects of the original change, leaving the changed
    > boilerplate intact.
    > 
    > Reason for revert: Testing perf regression in crbug.com/898191
    > 
    > If this exonerates the original CL, we will revert this change.
    > Otherwise, we will clean up the boilerplate added for the original CL.
    > 
    > Original change's description:
    > > Use preferred language in extension i18n
    > >
    > > When localizing an extension, prioritize the user's preferred language
    > > over the application locale.
    > >
    > > Normally, these are the same. In some cases, they differ. For example,
    > > the user may choose to display Chrome in "en-CA" (the intl.app_locale
    > > pref), but because we don't have translations for that, the actual
    > > UI locale is "en-GB".
    > >
    > > This CL makes extensions try to use the user's preferred locale for i18n
    > > ("en_CA"), falling back to the UI locale ("en_GB") if no locale
    > > directory is found for the preferred locale.
    > >
    > > This change also updates the "current_locale" manifest key to reflect
    > > the user's preferred locale, or the UI locale if intl.app_locale is
    > > unset.
    > >
    > > Note: Like the application locale, the preferred locale is only set at
    > > startup (and in certain situations in CrOS). If the user changes their
    > > intl.app_locale pref, they have to restart Chrome before extensions are
    > > re-localized, just like before.
    > >
    > > Bug: 874225
    > > Change-Id: I1aabe3c3680b77d6522193e764aec15a3d618d2d
    > > Reviewed-on: https://chromium-review.googlesource.com/c/1244666
    > > Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
    > > Reviewed-by: Scott Violet <sky@chromium.org>
    > > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#600619}
    > 
    > Bug: 898191
    > Change-Id: Iaddceb16d61ffc5572a25ed31276443ea5b5baa4
    > Reviewed-on: https://chromium-review.googlesource.com/c/1308765
    > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
    > Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#604819}
    
    TBR=lazyboy@chromium.org,michaelpg@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 898191
    Change-Id: Iead107f46039f01b5d5b97b36d1b8fb242f0aee3
    Reviewed-on: https://chromium-review.googlesource.com/c/1334194
    Reviewed-by: Mike Wittman <wittman@chromium.org>
    Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
    Commit-Queue: Mike Wittman <wittman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607719}

    Changed files

    • extensions/common/extension_l10n_util.cc
    • extensions/common/extension_l10n_util_unittest.cc
  57. Convert authentication_service_unittest.mm to IdentityManager

    Changed by Sergio Villar Senin - svillarohnoyoudont@igalia.com
    Changed at Tuesday, 13-Nov-18 20:10:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c026001db6b24eac1ea4c90b35c6f7d6ff6e99c

    Comments

    Convert authentication_service_unittest.mm to IdentityManager
    
    Partially migrates authentication_service_unitttest.mm to
    IdentityManager. In particular it does no longer observ
    OAuth2TokenService::Observer but IdentityManager::Observer. Apart from
    that a IdentityTestEnvironment was created to wrap all the testing
    factories used by the test. The IdentityManager returned by that
    object is then used to completely replace the calls to the
    SigninManager object.
    
    Bug: 890821
    Change-Id: I0a04a4e8e605546a96606ecb9a3a2338e9060257
    Reviewed-on: https://chromium-review.googlesource.com/c/1323552
    Commit-Queue: Sergio Villar <svillar@igalia.com>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607718}

    Changed files

    • ios/chrome/browser/signin/BUILD.gn
    • ios/chrome/browser/signin/authentication_service_unittest.mm
  58. [Nav Experiment] Temporarily disable tests failing with slim nav.

    Changed by Danyao Wang - danyaoohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 20:10:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 992abbe4bf077ef40c889d1277b9ce24cd61a74e

    Comments

    [Nav Experiment] Temporarily disable tests failing with slim nav.
    
    This allows the slim nav bots to be added to the main waterfall.
    
    Bug: 807428
    Change-Id: Ia5caca43734158f88c2292222a2cbcd70049bb75
    Reviewed-on: https://chromium-review.googlesource.com/c/1334191
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607717}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/password_view_controller_egtest.mm
    • ios/chrome/browser/ui/reading_list/reading_list_egtest.mm
    • ios/chrome/browser/web/visible_url_egtest.mm
  59. Roll src/third_party/catapult 78869faa9193..c14a383e61b4 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 20:07:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 147873d1ebb54309fd019b84d42d29da746b16d6

    Comments

    Roll src/third_party/catapult 78869faa9193..c14a383e61b4 (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/78869faa9193..c14a383e61b4
    
    
    git log 78869faa9193..c14a383e61b4 --date=short --no-merges --format='%ad %ae %s'
    2018-11-13 pasko@chromium.org androidStartupMetric: skip FCP events when startup is missing
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@c14a383e61b4
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:900878
    TBR=sullivan@chromium.org
    
    Change-Id: I521c24016a609b53682ae7ccc8b8e26e54f40f24
    Reviewed-on: https://chromium-review.googlesource.com/c/1333863
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607716}

    Changed files

    • DEPS
  60. Clean up various inconsistencies with internal version of HTTP/2

    Changed by Victor Vasiliev - vasilvvohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 20:03:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0c1c62f3b6b6ef1822216a42ebf775a1b9d7508d

    Comments

    Clean up various inconsistencies with internal version of HTTP/2
    
    R=bnc@chromium.org
    
    Change-Id: I37dddebc128654dc417ec7fbbcebe5679b3d9294
    Reviewed-on: https://chromium-review.googlesource.com/c/1333139
    Reviewed-by: Bence Béky <bnc@chromium.org>
    Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607715}

    Changed files

    • net/third_party/http2/decoder/decode_buffer.h
    • net/third_party/http2/decoder/decode_buffer_test.cc
    • net/third_party/http2/decoder/decode_http2_structures.cc
    • net/third_party/http2/decoder/frame_decoder_state.h
    • net/third_party/http2/decoder/http2_frame_decoder.h
    • net/third_party/http2/decoder/http2_frame_decoder_listener.h
    • net/third_party/http2/decoder/http2_frame_decoder_listener_test_util.h
    • net/third_party/http2/decoder/http2_frame_decoder_test.cc
    • net/third_party/http2/decoder/http2_structure_decoder.h
    • net/third_party/http2/decoder/http2_structure_decoder_test.cc
    • net/third_party/http2/hpack/decoder/hpack_block_decoder.cc
    • net/third_party/http2/hpack/decoder/hpack_block_decoder_test.cc
    • net/third_party/http2/hpack/decoder/hpack_decoder_string_buffer_test.cc
    • net/third_party/http2/hpack/decoder/hpack_decoder_tables.h
    • net/third_party/http2/hpack/decoder/hpack_entry_decoder.cc
    • net/third_party/http2/hpack/decoder/hpack_entry_decoder_test.cc
    • net/third_party/http2/hpack/decoder/hpack_entry_type_decoder.cc
    • net/third_party/http2/hpack/decoder/hpack_entry_type_decoder.h
    • net/third_party/http2/hpack/decoder/hpack_entry_type_decoder_test.cc
    • net/third_party/http2/hpack/decoder/hpack_string_decoder.h
    • net/third_party/http2/hpack/huffman/hpack_huffman_decoder.h
    • net/third_party/http2/hpack/huffman/hpack_huffman_encoder.h
    • net/third_party/http2/hpack/tools/hpack_block_builder.cc
    • net/third_party/http2/hpack/tools/hpack_block_builder.h
    • net/third_party/http2/hpack/tools/hpack_example.cc
    • net/third_party/http2/http2_structures_test_util.cc
    • net/third_party/http2/test_tools/frame_parts.h
    • net/third_party/http2/test_tools/frame_parts_collector_listener.h
    • net/third_party/http2/tools/http2_frame_builder.h
    • net/third_party/http2/tools/random_decoder_test.cc
    • net/third_party/http2/tools/random_decoder_test.h
  61. [Autofill Assistant] Double check element's position before click or tap

    Changed by gogerald - gogeraldohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 19:58:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision da77121fa044f290bc0e8bf68261504b59a373f7

    Comments

    [Autofill Assistant] Double check element's position before click or tap
    
    Bug: 806868
    Change-Id: If15e7d8c188179b29347645fde3f4fe7b0cbf7d5
    Reviewed-on: https://chromium-review.googlesource.com/c/1331140
    Commit-Queue: Ganggui Tang <gogerald@chromium.org>
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607714}

    Changed files

    • components/autofill_assistant/browser/web_controller.cc
    • components/autofill_assistant/browser/web_controller.h
    • components/test/data/autofill_assistant/autofill_assistant_target_website.html
  62. Re-enable disabled tests in chrome/browser/ui/omnibox/.

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:56:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 660ca3f59534cde9e55e0e694dae6f028e262277

    Comments

    Re-enable disabled tests in chrome/browser/ui/omnibox/.
    
    These passed 50 times in a row on Windows.
    
    This converts from watching NOTIFICATION_NAV_ENTRY_COMMIT to using a navigation
    observer in hopes of fixing observed flakiness in EnterToSearch.
    
    Bug: 69433, 133341, 133344, 133347, 133355, 133360, 146953, 408634, 431575, 751031, 751543, 823532, 841195
    Change-Id: Ia8ce63c8a9aca1ea415fb99756b08409cbc8369c
    Reviewed-on: https://chromium-review.googlesource.com/c/1332257
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607713}

    Changed files

    • chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
  63. Add Finch param to control TLS 1.3 Downgrade enforcement on known/unknown roots.

    Changed by Steven Valdez - svaldezohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:52:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 75ffb181057275eaf6335d1787f0413e3a3c1c2b

    Comments

    Add Finch param to control TLS 1.3 Downgrade enforcement on known/unknown roots.
    
    Change-Id: I88932442b714820944b4608e106eaf47536bf00d
    Reviewed-on: https://chromium-review.googlesource.com/c/1329344
    Commit-Queue: Steven Valdez <svaldez@chromium.org>
    Reviewed-by: David Benjamin <davidben@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607712}

    Changed files

    • chrome/browser/about_flags.cc
    • net/socket/ssl_client_socket_impl.cc
    • net/socket/ssl_client_socket_unittest.cc
  64. Instant Tethering: Remove kMultiDeviceApi flagging from HostScanSchedulerImpl.

    Changed by James Hawkins - jhawkinsohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:51:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 62387c3f82ad9bc3b70bb5a7c7e813398a34f4bc

    Comments

    Instant Tethering: Remove kMultiDeviceApi flagging from HostScanSchedulerImpl.
    
    R=hansberry@chromium.org
    
    Bug: 903991
    Test: none
    Change-Id: I85c5d0efcdf3c954d7756d2ca2952c06c56dd509
    Reviewed-on: https://chromium-review.googlesource.com/c/1333899
    Commit-Queue: James Hawkins <jhawkins@chromium.org>
    Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607711}

    Changed files

    • chromeos/components/tether/host_scan_scheduler_impl.cc
    • chromeos/components/tether/host_scan_scheduler_impl.h
    • chromeos/components/tether/host_scan_scheduler_impl_unittest.cc
  65. Roll src/third_party/webrtc 44ca9a392ac6..c7e3af1ad928 (4 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 19:50:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 18cb3222f894072512ff5a56aa1ba7b5443a5e0f

    Comments

    Roll src/third_party/webrtc 44ca9a392ac6..c7e3af1ad928 (4 commits)
    
    https://webrtc.googlesource.com/src.git/+log/44ca9a392ac6..c7e3af1ad928
    
    
    git log 44ca9a392ac6..c7e3af1ad928 --date=short --no-merges --format='%ad %ae %s'
    2018-11-13 terelius@webrtc.org Remove rtc_event_log2stats.
    2018-11-13 jonasolsson@webrtc.org Introduce DLOG to video and voiceengine.
    2018-11-13 tomas.popela@gmail.com Reland "Add support for screen sharing with PipeWire on Wayland"
    2018-11-13 alessiob@webrtc.org AGC2: adding level estimation option (RMS or peak-based).
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@c7e3af1ad928
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:682122
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: Id5a0ea4e3980c70d91601c64b8f68a43b7469927
    Reviewed-on: https://chromium-review.googlesource.com/c/1333860
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607710}

    Changed files

    • DEPS
  66. [Omnibox] Avoid removing the `www.` prefix during deduping when doing so would leave no host component.

    Changed by manuk - manukhohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:50:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7c10eab1d69f3cdbc406917f0de0209ba36b0d63

    Comments

    [Omnibox] Avoid removing the `www.` prefix during deduping when doing so would leave no host component.
    
    When sorting and deduping matches, match GURLs are stripped (`AutocompleteMatch::GURLToStrippedGURL`). Certain omnibox inputs, such as `http://www.` without inline autocomplete, produce matches with host compoments `www.`. Stripping `www.` in these cases would result in an empty url host component and, therefore, invalid `GURL`. Invoking `GURL::spec` on such invalid URLs would then cause a DCHECK to evaluate false and crash the browser. The crash only affects debug builds as the DCHECK is inactive for non-debug builds.
    
    Bug: 898554
    Change-Id: I73461c65ba53891d6f3b52bc767c754b02c1ce3e
    Reviewed-on: https://chromium-review.googlesource.com/c/1331631
    Commit-Queue: manuk hovanesian <manukh@chromium.org>
    Reviewed-by: Tommy Li <tommycli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607709}

    Changed files

    • components/omnibox/browser/autocomplete_match.cc
    • components/omnibox/browser/autocomplete_match_unittest.cc
  67. Implement RTCQuicStream.write()

    Changed by Steve Anton - steveantonohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:45:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 61720441ceae8e19ba59d32e651b7c9354ac45f0

    Comments

    Implement RTCQuicStream.write()
    
    Bug: 874296
    Change-Id: I1786acb3b64fa0450e76fe27300c178081d1e191
    Reviewed-on: https://chromium-review.googlesource.com/c/1285528
    Commit-Queue: Steve Anton <steveanton@chromium.org>
    Reviewed-by: Henrik Boström <hbos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607708}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCQuicStream-helper.js
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCQuicStream.https.html
    • third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
    • third_party/blink/renderer/modules/peerconnection/adapters/test/mock_p2p_quic_stream.h
    • third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.cc
    • third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.h
    • third_party/blink/renderer/modules/peerconnection/rtc_quic_stream.idl
    • third_party/blink/renderer/modules/peerconnection/rtc_quic_stream_test.cc
  68. [Autofill] Rename existing strike_database files

    Changed by Anne Lim - annelimohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 19:45:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b5b99113feb4249e941fb738d7ba19fa8557c62b

    Comments

    [Autofill] Rename existing strike_database files
    
    Renamed strike_database.h/cc to legacy_strike_database.h/cc and
    strike_database_unittest.cc to legacy_strike_database_unittest.cc.
    This is so that the files for the  new version of StrikeDatabase
    can take the old name.
    
    Bug: 884817
    Change-Id: Id4d1496b792d93f7e38afdab1ddad0419ec27f10
    Reviewed-on: https://chromium-review.googlesource.com/c/1330724
    Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
    Reviewed-by: Martin Šrámek <msramek@chromium.org>
    Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Reviewed-by: Richard Coles <torne@chromium.org>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Commit-Queue: Anne Lim <annelim@google.com>
    Cr-Commit-Position: refs/heads/master@{#607707}

    Changed files

    • android_webview/browser/aw_autofill_client.cc
    • android_webview/browser/aw_autofill_client.h
    • chrome/browser/BUILD.gn
    • chrome/browser/autofill/legacy_strike_database_factory.cc
    • chrome/browser/autofill/legacy_strike_database_factory.h
    • chrome/browser/autofill/strike_database_factory.h
    • chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
    • chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
    • chrome/browser/ui/autofill/chrome_autofill_client.cc
    • chrome/browser/ui/autofill/chrome_autofill_client.h
    • chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
    • chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
    • components/autofill/core/browser/BUILD.gn
    • components/autofill/core/browser/autofill_client.h
    • components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
    • components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h
    • components/autofill/core/browser/credit_card_save_manager.cc
    • components/autofill/core/browser/credit_card_save_manager_unittest.cc
    • components/autofill/core/browser/legacy_strike_database.cc
    • components/autofill/core/browser/legacy_strike_database.h
    • components/autofill/core/browser/legacy_strike_database_unittest.cc
    • components/autofill/core/browser/strike_database.cc
    • components/autofill/core/browser/test_autofill_client.cc
    • components/autofill/core/browser/test_autofill_client.h
    • components/autofill/core/browser/test_legacy_strike_database.cc
    • components/autofill/core/browser/test_legacy_strike_database.h
    • components/autofill/core/common/autofill_constants.h
    • ios/chrome/browser/autofill/BUILD.gn
    • ios/chrome/browser/autofill/legacy_strike_database_factory.cc
    • ios/chrome/browser/autofill/legacy_strike_database_factory.h
    • ios/chrome/browser/autofill/strike_database_factory.cc
    • ios/chrome/browser/autofill/strike_database_factory.h
    • ios/chrome/browser/browsing_data/browsing_data_remover_impl.mm
    • ios/chrome/browser/ios_chrome_flag_descriptions.h
    • ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
    • ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
    • ios/web_view/BUILD.gn
    • ios/web_view/internal/autofill/cwv_autofill_controller.mm
    • ios/web_view/internal/autofill/web_view_autofill_client_ios.h
    • ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
    • ios/web_view/internal/autofill/web_view_legacy_strike_database_factory.cc
    • ios/web_view/internal/autofill/web_view_legacy_strike_database_factory.h
    • ios/web_view/internal/autofill/web_view_strike_database_factory.cc
    • ios/web_view/internal/autofill/web_view_strike_database_factory.h
  69. Roll src-internal 52c961afab61..b822560337a6 (4 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 19:41:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0f7418d00aab1551c6006c04a32e9acc297009fc

    Comments

    Roll src-internal 52c961afab61..b822560337a6 (4 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/52c961afab61..b822560337a6
    
    
    Created with:
      gclient setdep -r src-internal@b822560337a6
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ie7f2520d9b91994c276613c5223ffd94cc4cb9e6
    Reviewed-on: https://chromium-review.googlesource.com/c/1333859
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607706}

    Changed files

    • DEPS
  70. [ios] Immediately hide the NTP when navigating away from it.

    Changed by Justin Cohen - justincohenohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 19:38:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df0da86d32926740f165125341a3123ee5cfe299

    Comments

    [ios] Immediately hide the NTP when navigating away from it.
    
    Remove the NTP and show the web view more quickly.  WKWebView appears
    to run more slowly in certain circumstances when it is obscured by
    another view.
    
    Change-Id: I769d9e5602a0b19a0032d5bca2fc6c6d85f3d365
    Reviewed-on: https://chromium-review.googlesource.com/c/1333873
    Commit-Queue: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607705}

    Changed files

    • ios/chrome/browser/ntp/new_tab_page_tab_helper.mm
    • ios/chrome/browser/ntp/new_tab_page_tab_helper_unittest.mm
    • ios/chrome/browser/ui/browser_view_controller.mm
  71. Clean up key event dispatching for Omnibox suggestions.

    Changed by Ted Choc - tedchocohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:36:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ce65f3986e902f15c8c2ea6f02b5f45519cb18d2

    Comments

    Clean up key event dispatching for Omnibox suggestions.
    
    This moves the bulk of the key handling into the view
    classes themselves and not the coordinator.
    
    BUG=898522
    
    Change-Id: Ie2b517eca6d7ae9e27bc12a020880bc668897b56
    Reviewed-on: https://chromium-review.googlesource.com/c/1331689
    Reviewed-by: Pedro Amaral <amaralp@chromium.org>
    Commit-Queue: Ted Choc <tedchoc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607704}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteMediator.java
    • chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionsList.java
    • chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionListViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionView.java
  72. Replace WebPoint with gfx::Point in WebView/Widget APIs.

    Changed by danakj - danakjohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:34:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ef1735abc4c6683647b878ccfe2f7bbe5aeb50c6

    Comments

    Replace WebPoint with gfx::Point in WebView/Widget APIs.
    
    R=chrishtr@chromium.org, piman@chromium.org, sky@chromium.org
    
    Change-Id: I851b632e4b09f1fd9f87229c69c7f6aff30b0ead
    Bug: 738465
    Reviewed-on: https://chromium-review.googlesource.com/c/1330332
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Reviewed-by: danakj <danakj@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Commit-Queue: danakj <danakj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607703}

    Changed files

    • components/plugins/renderer/webview_plugin.cc
    • components/plugins/renderer/webview_plugin.h
    • content/renderer/render_widget.cc
    • content/renderer/render_widget.h
    • content/renderer/render_widget_fullscreen_pepper.cc
    • content/renderer/render_widget_unittest.cc
    • content/shell/test_runner/web_view_test_proxy.cc
    • content/shell/test_runner/web_view_test_proxy.h
    • content/shell/test_runner/web_widget_test_client.cc
    • content/shell/test_runner/web_widget_test_client.h
    • content/shell/test_runner/web_widget_test_proxy.cc
    • content/shell/test_runner/web_widget_test_proxy.h
    • third_party/blink/public/web/web_view.h
    • third_party/blink/public/web/web_widget.h
    • third_party/blink/public/web/web_widget_client.h
    • third_party/blink/renderer/core/editing/web_substring_util.mm
    • third_party/blink/renderer/core/exported/web_frame_test.cc
    • third_party/blink/renderer/core/exported/web_page_popup_impl.h
    • third_party/blink/renderer/core/exported/web_view_impl.cc
    • third_party/blink/renderer/core/exported/web_view_impl.h
    • third_party/blink/renderer/core/exported/web_view_test.cc
    • third_party/blink/renderer/core/frame/web_frame_widget_base.cc
    • third_party/blink/renderer/core/frame/web_frame_widget_base.h
    • third_party/blink/renderer/core/frame/web_frame_widget_impl.cc
    • third_party/blink/renderer/core/frame/web_frame_widget_impl.h
    • third_party/blink/renderer/core/frame/web_view_frame_widget.cc
    • third_party/blink/renderer/core/frame/web_view_frame_widget.h
    • third_party/blink/renderer/core/layout/scrollbars_test.cc
    • third_party/blink/renderer/core/loader/empty_clients.h
    • third_party/blink/renderer/core/page/chrome_client.h
    • third_party/blink/renderer/core/page/chrome_client_impl.cc
    • third_party/blink/renderer/core/page/chrome_client_impl.h
    • third_party/blink/renderer/core/page/drag_controller.cc
    • third_party/blink/renderer/core/page/drag_controller_test.cc
    • third_party/blink/renderer/core/page/scrolling/root_scroller_test.cc
    • third_party/blink/renderer/core/scheduler/frame_throttling_test.cc
    • third_party/blink/renderer/platform/geometry/int_point.h
  73. Correctly handle GPU process launch failure

    Changed by Antoine Labour - pimanohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:32:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ee9dfa9f040d05d82a29464202b4c226351a892f

    Comments

    Correctly handle GPU process launch failure
    
    GpuProcessHost::ReportProcessCrash incorrectly early-outs in case of process
    launch failure, and fails to trigger fallback, causing a retry loop.
    Instead, correctly track if DidFailInitialize happened (which caused a fallback)
    and only early-out in that case.
    
    Bug: 876921
    Change-Id: I561de5d73ce8afddf920fa3ff141524bd5797733
    Reviewed-on: https://chromium-review.googlesource.com/c/1333129
    Reviewed-by: Victor Miura <vmiura@chromium.org>
    Commit-Queue: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607702}

    Changed files

    • components/viz/host/gpu_host_impl.cc
    • components/viz/host/gpu_host_impl.h
    • content/browser/gpu/gpu_process_host.cc
    • content/browser/gpu/gpu_process_host.h
  74. [ios] Migrate bookmark_promo_controller.mm to use IdentityManagerObserverBridge

    Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com
    Changed at Tuesday, 13-Nov-18 19:29:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision add4a3fc779e84faf4d4e8757a009db8c3338026

    Comments

    [ios] Migrate bookmark_promo_controller.mm to use IdentityManagerObserverBridge
    
    Remove the custom C++ class IdentityManagerObserver and rely on the
    new API from //services/identity/public/objc instead.
    
    Bug: 903262
    Change-Id: I32c3d46bbd6c1cd45c092c859ef303d9cd6b240f
    Reviewed-on: https://chromium-review.googlesource.com/c/1326151
    Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Sergio Collazos <sczs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607701}

    Changed files

    • ios/chrome/browser/ui/bookmarks/BUILD.gn
    • ios/chrome/browser/ui/bookmarks/bookmark_promo_controller.mm
  75. [Autofill] Browser tests for missing expiration date flow.

    Changed by Hao Zhang - hozhngohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 19:21:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8203409e85fcc446337e142bdb58b9635cd391b5

    Comments

    [Autofill] Browser tests for missing expiration date flow.
    
    Bug: 899057
    Change-Id: I9a79e9a280ec0a937b44afd319f0dc3e516aef0f
    Reviewed-on: https://chromium-review.googlesource.com/c/1321471
    Commit-Queue: Hao Zhang <hozhng@google.com>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607700}

    Changed files

    • chrome/browser/ui/autofill/save_card_bubble_controller_impl_browsertest.cc
    • chrome/browser/ui/views/autofill/dialog_view_ids.h
    • chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
    • chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
    • chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h
    • chrome/browser/ui/views/autofill/save_card_offer_bubble_views.cc
    • components/test/data/autofill/credit_card_upload_form_address_and_cc.html
  76. views: close menus when accelerators are pressed on Mac

    Changed by Elly Fong-Jones - ellyjonesohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:19:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b3bf64e2aa498d39ee246c7183dd7c1f17f5f3f6

    Comments

    views: close menus when accelerators are pressed on Mac
    
    This change:
    
    1) Has MenuController consider command to be an accelerator key, along with
       control and alt, for the purpose of not searching for mnemonics;
    2) Adds a Mac override of ViewsDelegate::ProcessAcceleratorWhileMenuShowing
       which tells the menu to close for an accelerator
    
    Bug: 885138
    Change-Id: Iee9d9abb3b1bb3c2d346d7aaf7e532866b4ad26a
    Reviewed-on: https://chromium-review.googlesource.com/c/1334147
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607699}

    Changed files

    • chrome/browser/ui/views/chrome_views_delegate.h
    • chrome/browser/ui/views/chrome_views_delegate_mac.cc
    • ui/views/controls/menu/menu_controller.cc
  77. Add UMA "Search.iOS.SelectDefaultSearchEngine" to Search Engine Settings.

    Changed by Yi Su - mrsuyiohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:18:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b903c3070dcb045d64722ef8d738d171e66bf241

    Comments

    Add UMA "Search.iOS.SelectDefaultSearchEngine" to Search Engine Settings.
    
    The new feature Custom Search Engine is ready on Chrome iOS right now.
    This CL adds a new metric to record when users change their default
    search engines on iOS. This metric will help us understand how iOS users
    use this new feature, and types of their selected default search engine.
    
    Bug: 433824
    Change-Id: I4796dee43f177b20a4c69e832b82d9e429060f26
    Reviewed-on: https://chromium-review.googlesource.com/c/1331468
    Reviewed-by: Mark Pearson <mpearson@chromium.org>
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Commit-Queue: Mark Pearson <mpearson@chromium.org>
    Commit-Queue: Yi Su <mrsuyi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607698}

    Changed files

    • ios/chrome/browser/ui/settings/search_engine_settings_collection_view_controller.mm
    • ios/chrome/browser/ui/settings/search_engine_settings_collection_view_controller_unittest.mm
    • tools/metrics/histograms/histograms.xml
  78. Move SK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS to SkUserConfig temporarily

    Changed by Brian Osman - brianosmanohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 19:17:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bb37dd0982e0b728c0ea416f04e970eed516a306

    Comments

    Move SK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS to SkUserConfig temporarily
    
    Going to remove this, but I need to rebaseline some layout tests, so
    I have to temporarily move it from Skia's skia_for_chromium_defines
    to this location.
    
    Change-Id: I071e5d8536fb5ac8baa78e3eac3974ee4d9445d4
    Reviewed-on: https://chromium-review.googlesource.com/c/1334091
    Reviewed-by: Brian Salomon <bsalomon@google.com>
    Commit-Queue: Brian Osman <brianosman@google.com>
    Cr-Commit-Position: refs/heads/master@{#607697}

    Changed files

    • skia/config/SkUserConfig.h
  79. [Passwords] Rename Google Password Manager Feature Flag

    Changed by jdoerrie - jdoerrieohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:16:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aeab6180ef0fcec7f25c5ac10d1c2a29e25e6448

    Comments

    [Passwords] Rename Google Password Manager Feature Flag
    
    This change renames the already existing feature flag from
    kManagePasswordsAlternativeUIAndroid to kGooglePasswordManager to better
    reflect that the flag is platform agnostic.
    
    Bug: 904821
    Change-Id: I5c7f0e529de53230578b0a25115b6d3428bbf940
    Reviewed-on: https://chromium-review.googlesource.com/c/1333651
    Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
    Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607696}

    Changed files

    • chrome/browser/android/chrome_feature_list.cc
    • components/password_manager/core/common/password_manager_features.cc
    • components/password_manager/core/common/password_manager_features.h
  80. Temporarily allow toolchain/OS mismatch to fallback on local toolchain.

    Changed by Erik Chen - erikchenohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:16:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision caca9998a7d4121ff8b6edec49c2def4d5dfb9e4

    Comments

    Temporarily allow toolchain/OS mismatch to fallback on local toolchain.
    
    Historically, we've disallowed toolchain/OS version mismatches to fallback on
    local toolchain. This prevents bots from silently succeeding [but building with
    the wrong toolchain].
    
    Since the hermetic toolchain currently does not run on the
    latest OS version, this check is also affecting all developers, which we'd like
    to avoid. This CL temporarily disables the check.
    
    Bug: 904400
    Change-Id: I4a3edc1218b50017a1dba96b54088986f48a6862
    Reviewed-on: https://chromium-review.googlesource.com/c/1333877
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607695}

    Changed files

    • build_overrides/build.gni
  81. DevTools: Draw page metrics markers with a solid color.

    Changed by Alexei Filippov - alphohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:14:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 176ebabb28c440f03ffb855f73182ce5bb534526

    Comments

    DevTools: Draw page metrics markers with a solid color.
    
    BUG=901165
    
    Change-Id: Icbdb38619e2ee76d9fa17621718a7613cf72554c
    Reviewed-on: https://chromium-review.googlesource.com/c/1330716
    Commit-Queue: Alexei Filippov <alph@chromium.org>
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607694}

    Changed files

    • third_party/blink/renderer/devtools/front_end/perf_ui/FlameChart.js
  82. Clear ChunkedDataPipeUploadDataStream buffer length.

    Changed by Chris Mumford - cmumfordohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:13:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 68d0b06aa168f4b60654a2e53235c5c06ad26c39

    Comments

    Clear ChunkedDataPipeUploadDataStream buffer length.
    
    When clearing ChunkedDataPipeUploadDataStream::buf_ also set
    ChunkedDataPipeUploadDataStream::buf_len_ to zero as it signifies
    the length of buf_ which is now gone.
    
    Bug: None
    Change-Id: I470b46fcb5cd0615e1841780e3c9744763c85265
    Reviewed-on: https://chromium-review.googlesource.com/c/1333657
    Reviewed-by: Ken Rockot <rockot@google.com>
    Commit-Queue: Chris Mumford <cmumford@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607693}

    Changed files

    • services/network/chunked_data_pipe_upload_data_stream.cc
  83. Add user actions for autofill settings.

    Changed by Nikunj Bhagat - nikunjbohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:11:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab0f182e6f2d1657935652352c550515e82c59e3

    Comments

    Add user actions for autofill settings.
    
    Bug: 904459
    Change-Id: I3ab7093cb1d7eab93e5db8bc1ca6b7fa7d6ebcef
    Reviewed-on: https://chromium-review.googlesource.com/c/1331629
    Commit-Queue: Nik Bhagat <nikunjb@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607692}

    Changed files

    • chrome/browser/extensions/api/autofill_private/autofill_private_api.cc
    • tools/metrics/actions/actions.xml
  84. Use unique_ptrs for ContentSettingBubbleModels

    Changed by Charlie Harrison - csharrisonohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:09:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0c5f58ab466d9abaabebdc7edf7a4a063020e7c4

    Comments

    Use unique_ptrs for ContentSettingBubbleModels
    
    Currently, these are created with bare `new`, until they are threaded
    into the ContentSettingBubbleContents, where they are wrapped into a
    unique_ptr.
    
    This CL removes the bare new creation, so ownership passing is explicit.
    
    Bug: None
    Change-Id: Ieaecab0ecaa49ae0d732acb27615b6b2e328e167
    Reviewed-on: https://chromium-review.googlesource.com/c/1333871
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: Charlie Harrison <csharrison@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607691}

    Changed files

    • chrome/browser/ui/content_settings/content_setting_bubble_model.cc
    • chrome/browser/ui/content_settings/content_setting_bubble_model.h
    • chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc
    • chrome/browser/ui/content_settings/content_setting_image_model.cc
    • chrome/browser/ui/content_settings/content_setting_image_model.h
    • chrome/browser/ui/content_settings/content_setting_image_model_browsertest.cc
    • chrome/browser/ui/views/content_setting_bubble_contents.cc
    • chrome/browser/ui/views/content_setting_bubble_contents.h
  85. Add ash.mojom.KeyboardController.SetContainerType

    Changed by Steven Bennetts - stevenjbohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:09:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 801c71c5733824192ee92c840828ebc1ea761166

    Comments

    Add ash.mojom.KeyboardController.SetContainerType
    
    This also introduces keyboard.mojom.ContainerType, replacing
    keyboard::ContainerType.
    
    BUG=876138
    
    Change-Id: Ib09d9bfa6037b60381054dad8b68288dc73b832b
    Reviewed-on: https://chromium-review.googlesource.com/c/1330328
    Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Reviewed-by: Shu Chen <shuchen@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607690}

    Changed files

    • ash/keyboard/ash_keyboard_controller.cc
    • ash/keyboard/ash_keyboard_controller.h
    • ash/keyboard/ash_keyboard_controller_unittest.cc
    • ash/keyboard/virtual_keyboard_unittest.cc
    • ash/public/interfaces/keyboard_controller.mojom
    • ash/shelf/shelf_widget_unittest.cc
    • ash/system/status_area_widget_unittest.cc
    • ash/system/virtual_keyboard/virtual_keyboard_tray_unittest.cc
    • ash/wm/lock_layout_manager_unittest.cc
    • ash/wm/pip/pip_positioner.cc
    • ash/wm/pip/pip_positioner_unittest.cc
    • ash/wm/pip/pip_window_resizer_unittest.cc
    • ash/wm/workspace/workspace_layout_manager_unittest.cc
    • chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
    • chrome/browser/ui/ash/chrome_keyboard_controller_client.cc
    • chrome/browser/ui/ash/chrome_keyboard_controller_client.h
    • chrome/browser/ui/ash/chrome_keyboard_controller_client_test_helper.cc
    • chrome/browser/ui/ash/chrome_keyboard_ui.cc
    • chrome/browser/ui/ash/keyboard_controller_browsertest.cc
    • ui/keyboard/BUILD.gn
    • ui/keyboard/container_behavior.h
    • ui/keyboard/container_floating_behavior.cc
    • ui/keyboard/container_floating_behavior.h
    • ui/keyboard/container_full_width_behavior.cc
    • ui/keyboard/container_full_width_behavior.h
    • ui/keyboard/container_fullscreen_behavior.cc
    • ui/keyboard/container_fullscreen_behavior.h
    • ui/keyboard/container_type.h
    • ui/keyboard/keyboard_controller.cc
    • ui/keyboard/keyboard_controller.h
    • ui/keyboard/keyboard_controller_unittest.cc
    • ui/keyboard/public/keyboard_controller_types.mojom
    • ui/keyboard/queued_container_type.cc
    • ui/keyboard/queued_container_type.h
    • ui/keyboard/queued_display_change.h
  86. Revert "ui_devtools: Encapsulate views server init; use Shell Env for Chrome OS."

    Changed by Ahmed Fakhry - afakhryohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:08:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f6c1bcdfb273f5b8bc0e0975f96bf6720991c95b

    Comments

    Revert "ui_devtools: Encapsulate views server init; use Shell Env for Chrome OS."
    
    This reverts commit 605cb27893cfb5205670f546ae24b9dc94bb7c29.
    
    Reason for revert: causes a crash immediately on initialization on ChromeOS Linux build:
    
    [85464:85464:1113/105356.761188:FATAL:shell.cc(281)] Check failed: instance_. 
    #0 0x7f6445c3668f base::debug::StackTrace::StackTrace()
    #1 0x7f6445b6624b logging::LogMessage::~LogMessage()
    #2 0x7f643f32b5c2 ash::Shell::Get()
    #3 0x561d123191ba ChromeBrowserMainExtraPartsAsh::PreProfileInit()
    #4 0x561d10f06f2a ChromeBrowserMainParts::PreProfileInit()
    #5 0x561d10f07c8e ChromeBrowserMainPartsLinux::PreProfileInit()
    #6 0x561d1089bc26 chromeos::ChromeBrowserMainPartsChromeos::PreProfileInit()
    #7 0x561d10f05fee ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
    #8 0x561d10f05925 ChromeBrowserMainParts::PreMainMessageLoopRun()
    #9 0x561d1089b755 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
    #10 0x7f64434b766a content::BrowserMainLoop::PreMainMessageLoopRun()
    #11 0x7f64439b1055 content::StartupTaskRunner::RunAllTasksNow()
    #12 0x7f64434b6191 content::BrowserMainLoop::CreateStartupTasks()
    #13 0x7f64434b9d30 content::BrowserMainRunnerImpl::Initialize()
    #14 0x7f64434b3d62 content::BrowserMain()
    #15 0x7f6443fed756 content::ContentMainRunnerImpl::Run()
    #16 0x7f6434c3ff46 service_manager::Main()
    #17 0x7f6443feba44 content::ContentMain()
    #18 0x561d10094e63 ChromeMain
    #19 0x7f64352042b1 __libc_start_main
    #20 0x561d10094cda _start
    
    Original change's description:
    > ui_devtools: Encapsulate views server init; use Shell Env for Chrome OS.
    > 
    > Use the ash::Shell aura::Env in single-process mash ui_devtools.
    > Keep a TODO for initializing ui_devtools in Ash for multi-process Mash.
    > Encapsulate server init, and the switch and port definitions.
    > 
    > Bug: 896977
    > Test: ui_devtools works well on Chrome OS single-process Mash.
    > Change-Id: I3cc285d5f8ee465d45795a3521e7e4eafa354414
    > Reviewed-on: https://chromium-review.googlesource.com/c/1324373
    > Commit-Queue: Michael Wasserman <msw@chromium.org>
    > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#607408}
    
    TBR=sadrul@chromium.org,msw@chromium.org
    
    Change-Id: Iae50c4a7d67de9602596b0522da3fec0f472e092
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 896977
    Reviewed-on: https://chromium-review.googlesource.com/c/1334001
    Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
    Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607689}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/about_flags.cc
    • chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc
    • chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.h
    • chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
    • chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h
    • chrome/common/chrome_switches.cc
    • chrome/common/chrome_switches.h
    • components/ui_devtools/BUILD.gn
    • components/ui_devtools/devtools_server.cc
    • components/ui_devtools/devtools_server.h
    • components/ui_devtools/switches.cc
    • components/ui_devtools/switches.h
    • components/ui_devtools/views/BUILD.gn
    • components/ui_devtools/views/devtools_server_util.cc
    • components/ui_devtools/views/devtools_server_util.h
    • components/ui_devtools/views/dom_agent_aura.cc
    • components/ui_devtools/views/dom_agent_aura.h
    • components/ui_devtools/views/overlay_agent_aura.cc
    • components/ui_devtools/views/overlay_agent_aura.h
    • components/ui_devtools/views/overlay_agent_unittest.cc
    • components/ui_devtools/views/ui_devtools_unittest.cc
  87. Roll src/third_party/angle 0864a7ac638c..f9143725470b (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 19:07:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c86c56362f4ac4c331f174c4646bee366e46f5cc

    Comments

    Roll src/third_party/angle 0864a7ac638c..f9143725470b (2 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/0864a7ac638c..f9143725470b
    
    
    git log 0864a7ac638c..f9143725470b --date=short --no-merges --format='%ad %ae %s'
    2018-11-13 geofflang@chromium.org Only use CompositorNativeWindow11 when the window is non-null.
    2018-11-13 ynovikov@chromium.org Vulkan: refactor WrappedObject descendants
    
    
    Created with:
      gclient setdep -r src/third_party/angle@f9143725470b
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=cwallez@chromium.org
    
    Change-Id: I9237b7e197941a754f000be7c84c71381815c4a1
    Reviewed-on: https://chromium-review.googlesource.com/c/1333861
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607688}

    Changed files

    • DEPS
  88. Remove TearDown() test methods that just call TearDown().

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:04:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision da86e5b7d0710f2c5c36f6db00d4a0e2218a30d4

    Comments

    Remove TearDown() test methods that just call TearDown().
    
    In chrome/ and chromeos/. These TearDown() overrides are pointless.
    
    Change-Id: I0e9c6d2a346bc40ecf45e30a8bac0914a987e3a4
    Reviewed-on: https://chromium-review.googlesource.com/c/1330913
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607687}

    Changed files

    • chrome/browser/chromeos/ownership/owner_settings_service_chromeos_unittest.cc
    • chrome/browser/chromeos/settings/device_settings_provider_unittest.cc
    • chrome/browser/extensions/api/downloads/downloads_api_unittest.cc
    • chrome/browser/extensions/api/language_settings_private/language_settings_private_api_unittest.cc
    • chrome/browser/navigation_predictor/navigation_predictor_unittest.cc
    • chrome/browser/translate/chrome_translate_client_unittest.cc
    • chrome/browser/ui/views/translate/translate_language_browsertest.cc
    • chrome/browser/ui/webui/settings/chromeos/internet_handler_unittest.cc
    • chrome/browser/webshare/share_service_impl_unittest.cc
    • chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc
    • chrome/renderer/translate/translate_script_browsertest.cc
    • chromeos/dbus/shill_device_client_unittest.cc
    • chromeos/dbus/shill_ipconfig_client_unittest.cc
    • chromeos/dbus/shill_manager_client_unittest.cc
    • chromeos/dbus/shill_profile_client_unittest.cc
    • chromeos/dbus/shill_service_client_unittest.cc
    • chromeos/dbus/shill_third_party_vpn_driver_client_unittest.cc
    • chromeos/services/assistant/service_unittest.cc
  89. Add fuzzer for AXTableInfo code

    Changed by Dominic Mazzoni - dmazzoniohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:01:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fcb2a9f147a39c592bbaff04b5a8bc16d958ddb4

    Comments

    Add fuzzer for AXTableInfo code
    
    Change-Id: I77e9b4332bd9f67e04e65e2afca895314b278498
    Reviewed-on: https://chromium-review.googlesource.com/c/1314140
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Jonathan Metzman <metzman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607686}

    Changed files

    • ui/accessibility/BUILD.gn
    • ui/accessibility/ax_table_fuzzer.cc
    • ui/accessibility/fuzz_corpus/ax_table_fuzzer_seed.bin
  90. ui: fix ViewTreeValidatorTest on 10.14

    Changed by Elly Fong-Jones - ellyjonesohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:01:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f63790e2a15d7f6c94ed12871826116c05dec790

    Comments

    ui: fix ViewTreeValidatorTest on 10.14
    
    This test uses NSButton as its dummy class for some test cases, but there is
    now a 10.14-specific behavior in ViewTreeValidator to ignore children of
    buttons because of the linked bug, which causes this test to fail on 10.14.
    
    Bug: 892176
    Change-Id: I35bac3065ed1b2ded9466e63b6c27cd804b7180c
    Reviewed-on: https://chromium-review.googlesource.com/c/1333140
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607685}

    Changed files

    • ui/base/test/view_tree_validator_unittest.mm
  91. Updating XTBs based on .GRDs from branch master

    Changed by Krishna Govind - govindohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:01:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f795150bf9ed357c777ab4c5c67c42508a044958

    Comments

    Updating XTBs based on .GRDs from branch master
    
    R=benmason@chromium.org
    
    Change-Id: I605b7ff0aee6ec52254af8871efc7308f79d647a
    Reviewed-on: https://chromium-review.googlesource.com/c/1334098
    Reviewed-by: Krishna Govind <govind@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607684}

    Changed files

    • ash/strings/ash_strings_ca.xtb
    • ash/strings/ash_strings_es-419.xtb
    • ash/strings/ash_strings_ja.xtb
    • ash/strings/ash_strings_kn.xtb
    • ash/strings/ash_strings_ko.xtb
    • ash/strings/ash_strings_lv.xtb
    • ash/strings/ash_strings_ml.xtb
    • ash/strings/ash_strings_mr.xtb
    • ash/strings/ash_strings_ro.xtb
    • ash/strings/ash_strings_sv.xtb
    • ash/strings/ash_strings_th.xtb
    • ash/strings/ash_strings_tr.xtb
    • ash/strings/ash_strings_vi.xtb
    • ash/strings/ash_strings_zh-CN.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_am.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ar.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_bg.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_bn.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ca.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_cs.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_da.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_de.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_el.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_en-GB.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_es-419.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_es.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_et.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fa.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fil.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_gu.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hu.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_id.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_it.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_iw.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ja.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_kn.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ko.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_lt.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_lv.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ml.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_mr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ms.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_nl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_no.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pt-BR.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pt-PT.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ro.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ru.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sv.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sw.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ta.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_te.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_th.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_tr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_uk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_vi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_zh-CN.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_zh-TW.xtb
    • chrome/app/resources/generated_resources_am.xtb
    • chrome/app/resources/generated_resources_ar.xtb
    • chrome/app/resources/generated_resources_bg.xtb
    • chrome/app/resources/generated_resources_bn.xtb
    • chrome/app/resources/generated_resources_ca.xtb
    • chrome/app/resources/generated_resources_cs.xtb
    • chrome/app/resources/generated_resources_da.xtb
    • chrome/app/resources/generated_resources_de.xtb
    • chrome/app/resources/generated_resources_el.xtb
    • chrome/app/resources/generated_resources_en-GB.xtb
    • chrome/app/resources/generated_resources_es-419.xtb
    • chrome/app/resources/generated_resources_es.xtb
    • chrome/app/resources/generated_resources_et.xtb
    • chrome/app/resources/generated_resources_fa.xtb
    • chrome/app/resources/generated_resources_fi.xtb
    • chrome/app/resources/generated_resources_fil.xtb
    • chrome/app/resources/generated_resources_fr.xtb
    • chrome/app/resources/generated_resources_gu.xtb
    • chrome/app/resources/generated_resources_hi.xtb
    • chrome/app/resources/generated_resources_hr.xtb
    • chrome/app/resources/generated_resources_hu.xtb
    • chrome/app/resources/generated_resources_id.xtb
    • chrome/app/resources/generated_resources_it.xtb
    • chrome/app/resources/generated_resources_iw.xtb
    • chrome/app/resources/generated_resources_ja.xtb
    • chrome/app/resources/generated_resources_kn.xtb
    • chrome/app/resources/generated_resources_ko.xtb
    • chrome/app/resources/generated_resources_lt.xtb
    • chrome/app/resources/generated_resources_lv.xtb
    • chrome/app/resources/generated_resources_ml.xtb
    • chrome/app/resources/generated_resources_mr.xtb
    • chrome/app/resources/generated_resources_ms.xtb
    • chrome/app/resources/generated_resources_nl.xtb
    • chrome/app/resources/generated_resources_no.xtb
    • chrome/app/resources/generated_resources_pl.xtb
    • chrome/app/resources/generated_resources_pt-BR.xtb
    • chrome/app/resources/generated_resources_pt-PT.xtb
    • chrome/app/resources/generated_resources_ro.xtb
    • chrome/app/resources/generated_resources_ru.xtb
    • chrome/app/resources/generated_resources_sk.xtb
    • chrome/app/resources/generated_resources_sl.xtb
    • chrome/app/resources/generated_resources_sr.xtb
    • chrome/app/resources/generated_resources_sv.xtb
    • chrome/app/resources/generated_resources_sw.xtb
    • chrome/app/resources/generated_resources_ta.xtb
    • chrome/app/resources/generated_resources_te.xtb
    • chrome/app/resources/generated_resources_th.xtb
    • chrome/app/resources/generated_resources_tr.xtb
    • chrome/app/resources/generated_resources_uk.xtb
    • chrome/app/resources/generated_resources_vi.xtb
    • chrome/app/resources/generated_resources_zh-CN.xtb
    • chrome/app/resources/generated_resources_zh-TW.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ca.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_es-419.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ja.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_kn.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ko.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_lv.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ml.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_mr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ro.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sv.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_th.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_tr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_vi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-CN.xtb
    • chrome/credential_provider/gaiacp/strings/gaia_resources_da.xtb
    • components/policy/resources/policy_templates_ca.xtb
    • components/policy/resources/policy_templates_da.xtb
    • components/policy/resources/policy_templates_es-419.xtb
    • components/policy/resources/policy_templates_es.xtb
    • components/policy/resources/policy_templates_ja.xtb
    • components/policy/resources/policy_templates_kn.xtb
    • components/policy/resources/policy_templates_ko.xtb
    • components/policy/resources/policy_templates_lv.xtb
    • components/policy/resources/policy_templates_ml.xtb
    • components/policy/resources/policy_templates_mr.xtb
    • components/policy/resources/policy_templates_ro.xtb
    • components/policy/resources/policy_templates_sv.xtb
    • components/policy/resources/policy_templates_th.xtb
    • components/policy/resources/policy_templates_tr.xtb
    • components/policy/resources/policy_templates_vi.xtb
    • components/policy/resources/policy_templates_zh-CN.xtb
    • components/strings/components_strings_am.xtb
    • components/strings/components_strings_ar.xtb
    • components/strings/components_strings_bg.xtb
    • components/strings/components_strings_bn.xtb
    • components/strings/components_strings_ca.xtb
    • components/strings/components_strings_cs.xtb
    • components/strings/components_strings_da.xtb
    • components/strings/components_strings_de.xtb
    • components/strings/components_strings_el.xtb
    • components/strings/components_strings_en-GB.xtb
    • components/strings/components_strings_es-419.xtb
    • components/strings/components_strings_es.xtb
    • components/strings/components_strings_et.xtb
    • components/strings/components_strings_fa.xtb
    • components/strings/components_strings_fi.xtb
    • components/strings/components_strings_fil.xtb
    • components/strings/components_strings_fr.xtb
    • components/strings/components_strings_gu.xtb
    • components/strings/components_strings_hi.xtb
    • components/strings/components_strings_hr.xtb
    • components/strings/components_strings_hu.xtb
    • components/strings/components_strings_id.xtb
    • components/strings/components_strings_it.xtb
    • components/strings/components_strings_iw.xtb
    • components/strings/components_strings_ja.xtb
    • components/strings/components_strings_kn.xtb
    • components/strings/components_strings_ko.xtb
    • components/strings/components_strings_lt.xtb
    • components/strings/components_strings_lv.xtb
    • components/strings/components_strings_ml.xtb
    • components/strings/components_strings_mr.xtb
    • components/strings/components_strings_ms.xtb
    • components/strings/components_strings_nl.xtb
    • components/strings/components_strings_no.xtb
    • components/strings/components_strings_pl.xtb
    • components/strings/components_strings_pt-BR.xtb
    • components/strings/components_strings_pt-PT.xtb
    • components/strings/components_strings_ro.xtb
    • components/strings/components_strings_ru.xtb
    • components/strings/components_strings_sk.xtb
    • components/strings/components_strings_sl.xtb
    • components/strings/components_strings_sr.xtb
    • components/strings/components_strings_sv.xtb
    • components/strings/components_strings_sw.xtb
    • components/strings/components_strings_ta.xtb
    • components/strings/components_strings_te.xtb
    • components/strings/components_strings_th.xtb
    • components/strings/components_strings_tr.xtb
    • components/strings/components_strings_uk.xtb
    • components/strings/components_strings_vi.xtb
    • components/strings/components_strings_zh-CN.xtb
    • components/strings/components_strings_zh-TW.xtb
    • remoting/resources/remoting_strings_ca.xtb
    • remoting/resources/remoting_strings_es-419.xtb
    • remoting/resources/remoting_strings_ja.xtb
    • remoting/resources/remoting_strings_kn.xtb
    • remoting/resources/remoting_strings_ko.xtb
    • remoting/resources/remoting_strings_lv.xtb
    • remoting/resources/remoting_strings_ml.xtb
    • remoting/resources/remoting_strings_mr.xtb
    • remoting/resources/remoting_strings_ro.xtb
    • remoting/resources/remoting_strings_sv.xtb
    • remoting/resources/remoting_strings_th.xtb
    • remoting/resources/remoting_strings_tr.xtb
    • remoting/resources/remoting_strings_vi.xtb
    • remoting/resources/remoting_strings_zh-CN.xtb
  92. [PE] Fix contents opaque for composited layers in the presence of a foreground layer

    Changed by Chris Harrelson - chrishtrohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 19:00:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bda6e124f6ffff2a67c32d2e65903a2c25334430

    Comments

    [PE] Fix contents opaque for composited layers in the presence of a foreground layer
    
    The foreground layer paints normal-flow and positive z-index non-composited
    children in the presence of a composited negative-z-index-child. In these cases,
    we should not consider the normal-flow or positive z-index non-composited children
    as contributing to opaqueness of the main graphics layer, since they paint
    elsewhere.
    
    Bug: 892137
    
    Change-Id: I7bd6a4eab615881e4ec3931049f292b046202430
    Reviewed-on: https://chromium-review.googlesource.com/c/1332699
    Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
    Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607683}

    Changed files

    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc
    • third_party/blink/renderer/core/paint/compositing/compositing_reason_finder.cc
    • third_party/blink/renderer/core/paint/paint_layer.cc
    • third_party/blink/renderer/core/paint/paint_layer.h
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • third_party/blink/renderer/core/paint/paint_layer_test.cc
    • third_party/blink/renderer/core/testing/core_unit_test_helper.h
  93. [FCP++] Refactor Image Paint Detector

    Changed by Liquan(Max) Gu - maxlgohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 18:58:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 952b1a871fd7b3b4a629e253bb6eb21b681c60ba

    Comments

    [FCP++] Refactor Image Paint Detector
    
    This CL refactors the codes of Image Paint Detecor. This will make it easier to
    support background image for the metric.
    
    Specifically, this CL will do the following things:
    1. Move GetImageUrl() into an anonymous function.
    2. Simplify the logic of IsJustLoaded(). Take out the IsLoad() part from it and move
    it into an anonymous function.
    
    Background image support will be done by extending these two functions.
    
    Bug: 869924
    Change-Id: Idfe4794612e1d5daa71afb03f8191700ce3d65bb
    Reviewed-on: https://chromium-review.googlesource.com/c/1333990
    Reviewed-by: Steve Kobes <skobes@chromium.org>
    Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607682}

    Changed files

    • third_party/blink/renderer/core/paint/image_paint_timing_detector.cc
    • third_party/blink/renderer/core/paint/image_paint_timing_detector.h
  94. [iOS] Fix |-expandedTopToolbarHeight|.

    Changed by Kurt Horimoto - kkhorimotoohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 18:57:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d6a1800461757b65a56c1ad613f11f57506452ff

    Comments

    [iOS] Fix |-expandedTopToolbarHeight|.
    
    CGRectGetMaxY() changes as the toolbars are translated, causing issues
    when it is called from |-updateForFullscreenProgress:|.  This CL updates
    the implementation to be based on the heights, rather than the frames.
    
    Bug: 903229
    Change-Id: Ice018324f426104467f80c21544435c612b3455f
    Reviewed-on: https://chromium-review.googlesource.com/c/1328143
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607681}

    Changed files

    • ios/chrome/browser/ui/browser_view_controller.mm
  95. Move manual tests from TextExpectation file to WontFix file.

    Changed by kyle Ju - kylejuohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 18:55:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 317fdb1438147f1fe9c77412b0e89d424166523a

    Comments

    Move manual tests from TextExpectation file to WontFix file.
    
    Bug: 738489
    Change-Id: I0251f741bee780b3cbb88b13a29b67238b8c0cf5
    Reviewed-on: https://chromium-review.googlesource.com/c/1269759
    Commit-Queue: Kyle Ju <kyleju@chromium.org>
    Reviewed-by: Robert Ma <robertma@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607680}

    Changed files

    • third_party/blink/tools/blinkpy/w3c/wpt_expectations_updater.py
    • third_party/blink/tools/blinkpy/w3c/wpt_expectations_updater_unittest.py
  96. Convert chrome/browser/ui/webui/app_launcher_login_handler.cc to Identity service

    Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com
    Changed at Tuesday, 13-Nov-18 18:54:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 10d0e63da2c7135c1e80ff8e62bffecfc046eddd

    Comments

    Convert chrome/browser/ui/webui/app_launcher_login_handler.cc to Identity service
    
    Migrate uses of SigninManagerBase's GetAuthenticatedAccountInfo()
    and IsSigninAllowed() to the Identity Manager.
    
    Bug: 903894
    Change-Id: Idcddc8adffbdb4093df7170551403ae20a14afe7
    Reviewed-on: https://chromium-review.googlesource.com/c/1329979
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#607679}

    Changed files

    • chrome/browser/ui/webui/app_launcher_login_handler.cc
  97. Allow fuzzer tests to specify libs

    Changed by Jonathan Metzman - metzmanohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 18:54:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ce46de13a7df955e9acf21c436aa374543679e07

    Comments

    Allow fuzzer tests to specify libs
    
    Bug: 904877
    Change-Id: I76942f10b864f9fab39792ec8d734c1e9cec8468
    Reviewed-on: https://chromium-review.googlesource.com/c/1333900
    Commit-Queue: Max Moroz <mmoroz@chromium.org>
    Reviewed-by: Max Moroz <mmoroz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607678}

    Changed files

    • testing/libfuzzer/fuzzer_test.gni
  98. Fix SwapChainCreationResult UMA histogram

    Changed by Sunny Sachanandani - sunnypsohnoyoudont@chromium.org
    Changed at Tuesday, 13-Nov-18 18:53:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fa87389f0fce875a378654bc7b33e3ca36a03f3e

    Comments

    Fix SwapChainCreationResult UMA histogram
    
    GPU.DirectComposition.SwapChainCreationResult is emitted for each
    overlay format, but it was missing an affected-histogram entry in the
    histogram_suffixes list.
    
    Bug: 869677
    Change-Id: I20cd9987ba2ebf42230c3e026e5d33c600cc6713
    Reviewed-on: https://chromium-review.googlesource.com/c/1333133
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607677}

    Changed files

    • tools/metrics/histograms/histograms.xml
  99. Remove needs_http parameter in check_sys_deps method

    Changed by Ned Nguyen - nednguyenohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 18:51:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c91ef9689e59c6c83aa408367a68599556b9086f

    Comments

    Remove needs_http parameter in check_sys_deps method
    
    This also remove check_sys_deps from base.Port's subclasses that are
    the same as the base class method.
    
    Note: this CL removes an unused parameter and is a refactor with no intended behavior change.
    
    This clean up is a follow-up of https://chromium-review.googlesource.com/c/chromium/src/+/1229240/
    
    BUG: chromium:773617,chromium:884776
    Change-Id: I82edf733a696c4e0e6de20a8bac954e244d51365
    Reviewed-on: https://chromium-review.googlesource.com/c/1333893
    Commit-Queue: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Robert Ma <robertma@chromium.org>
    Reviewed-by: Erik Chen <erikchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607676}

    Changed files

    • third_party/blink/tools/blinkpy/web_tests/controllers/manager.py
    • third_party/blink/tools/blinkpy/web_tests/port/android.py
    • third_party/blink/tools/blinkpy/web_tests/port/base.py
    • third_party/blink/tools/blinkpy/web_tests/port/browser_test.py
    • third_party/blink/tools/blinkpy/web_tests/port/fuchsia.py
    • third_party/blink/tools/blinkpy/web_tests/port/mock_drt.py
    • third_party/blink/tools/blinkpy/web_tests/port/test.py
  100. Roll src/third_party/skia 60b6bc3c2950..f47abb48757f (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Tuesday, 13-Nov-18 18:50:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 51354d4206a9930be5070ee9b56f6ca5f61d03ad

    Comments

    Roll src/third_party/skia 60b6bc3c2950..f47abb48757f (2 commits)
    
    https://skia.googlesource.com/skia.git/+log/60b6bc3c2950..f47abb48757f
    
    
    git log 60b6bc3c2950..f47abb48757f --date=short --no-merges --format='%ad %ae %s'
    2018-11-13 mtklein@google.com remove unused DXDY SSSE3 bitmap opts
    2018-11-13 brianosman@google.com Remove obsolete SK_IGNORE_ defines
    
    
    Created with:
      gclient setdep -r src/third_party/skia@f47abb48757f
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    TBR=rmistry@chromium.org
    
    Change-Id: I4b9c084dbf4533cba3ea73f2a041c29d16b4b676
    Reviewed-on: https://chromium-review.googlesource.com/c/1333854
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607675}

    Changed files

    • DEPS
  101. <blame list capped at 100 commits>

    Changed by <blame list capped at 100 commits> -
    Changed at N/A
    Repository
    Branch
    Revision

    Comments

    <blame list capped at 100 commits>