Builder Mac Debug (Intel) Build 80298

Results:

Success

Trigger Info:

Project	chromium
Revision	dcf8a49d5e3d2440dfc3f8e3126fa266fd25a33b
Got Revision	dcf8a49d5e3d2440dfc3f8e3126fa266fd25a33b

Execution:

• Source: Task 3ea830d92d6b5110
• Bot: vm75-m9
• Recipe: chromium

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 462 ms ) setup_build

   running recipe: "chromium"
   • stdout
   • run_recipe
2. ( 580 ms ) remove .cipd
   • stdout
3. ( 1 mins 44 secs ) bot_update

   [67GB/232GB used (28%)]
   • stdout
   • json.output
4. ( 231 ms ) ensure_goma
   • - no logs -
   1. ( 231 ms ) ensure_installed
      • stdout
      • json.output
5. ( 1 secs ) swarming.py --version

   0.13
   • stdout
6. ( 253 ms ) ensure_installed
   • stdout
   • json.output
7. ( 19 secs ) gclient runhooks
   • stdout
8. ( 3 secs ) get compile targets for scripts
   • stdout
   • json.output
9. ( 599 ms ) read test spec (chromium.gpu.json)

   path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.json
   • stdout
   • json.output
10. ( 1 secs ) build directory
    • stdout
11. ( 32 secs ) extract build
    • stdout
12. ( 539 ms ) find isolated tests
    • stdout
    • json.output
13. ( 16 secs ) test_pre_run
    • - no logs -
    1. ( 1 secs ) [trigger] angle_unittests on Intel GPU on Mac on Mac-10.12.6

       Run on OS: 'Mac-10.12.6'
       • stdout
       • json.output
       • shard #0
    2. ( 1 secs ) [trigger] gl_tests on Intel GPU on Mac on Mac-10.12.6

       Run on OS: 'Mac-10.12.6'
       • stdout
       • json.output
       • shard #0
    3. ( 1 secs ) [trigger] gl_unittests on Intel GPU on Mac on Mac-10.12.6

       Run on OS: 'Mac-10.12.6'
       • stdout
       • json.output
       • shard #0
    4. ( 1 secs ) [trigger] context_lost_tests on Intel GPU on Mac on Mac-10.12.6

       Run on OS: 'Mac-10.12.6'
       • stdout
       • json.output
       • shard #0
    5. ( 1 secs ) [trigger] depth_capture_tests on Intel GPU on Mac on Mac-10.12.6

       Run on OS: 'Mac-10.12.6'
       • stdout
       • json.output
       • shard #0
    6. ( 1 secs ) [trigger] gpu_process_launch_tests on Intel GPU on Mac on Mac-10.12.6

       Run on OS: 'Mac-10.12.6'
       • stdout
       • json.output
       • shard #0
    7. ( 1 secs ) [trigger] hardware_accelerated_feature_tests on Intel GPU on Mac on Mac-10.12.6

       Run on OS: 'Mac-10.12.6'
       • stdout
       • json.output
       • shard #0
    8. ( 1 secs ) [trigger] info_collection_tests on Intel GPU on Mac on Mac-10.12.6

       Run on OS: 'Mac-10.12.6'
       • stdout
       • json.output
       • shard #0
    9. ( 1 secs ) [trigger] maps_pixel_test on Intel GPU on Mac on Mac-10.12.6

       Run on OS: 'Mac-10.12.6'
       • stdout
       • json.output
       • shard #0
    10. ( 1 secs ) [trigger] pixel_test on Intel GPU on Mac on Mac-10.12.6

        Run on OS: 'Mac-10.12.6'
        • stdout
        • json.output
        • shard #0
    11. ( 1 secs ) [trigger] screenshot_sync_tests on Intel GPU on Mac on Mac-10.12.6

        Run on OS: 'Mac-10.12.6'
        • stdout
        • json.output
        • shard #0
    12. ( 1 secs ) [trigger] trace_test on Intel GPU on Mac on Mac-10.12.6

        Run on OS: 'Mac-10.12.6'
        • stdout
        • json.output
        • shard #0
    13. ( 1 secs ) [trigger] webgl_conformance_tests on Intel GPU on Mac on Mac-10.12.6

        Run on OS: 'Mac-10.12.6'
        • stdout
        • json.output
        • shard #0
        • shard #1
14. ( 4 secs ) angle_unittests on Intel GPU on Mac on Mac-10.12.6

    Run on OS: 'Mac-10.12.6'

    Shard duration: 0:01:23.828710
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (75.3 sec)
15. ( 9 secs ) Upload to test-results [angle_unittests on Intel GPU on Mac on Mac-10.12.6]
    • stdout
16. ( 2 secs ) gl_tests on Intel GPU on Mac on Mac-10.12.6

    Run on OS: 'Mac-10.12.6'

    Shard duration: 18s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (9.0 sec)
17. ( 2 secs ) Upload to test-results [gl_tests on Intel GPU on Mac on Mac-10.12.6]
    • stdout
18. ( 2 secs ) gl_unittests on Intel GPU on Mac on Mac-10.12.6

    Run on OS: 'Mac-10.12.6'

    Shard duration: 7s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (1.0 sec)
19. ( 5 secs ) Upload to test-results [gl_unittests on Intel GPU on Mac on Mac-10.12.6]
    • stdout
20. ( 41 secs ) context_lost_tests on Intel GPU on Mac on Mac-10.12.6

    Run on OS: 'Mac-10.12.6'

    Shard duration: 0:01:17.653640

    Total tests: 8

    * Passed: 8 (8 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (53.8 sec)
21. ( 1 secs ) Upload to test-results [context_lost_tests on Intel GPU on Mac]
    • stdout
22. ( 2 secs ) depth_capture_tests on Intel GPU on Mac on Mac-10.12.6

    Run on OS: 'Mac-10.12.6'

    Shard duration: 58s

    Total tests: 3

    * Passed: 3 (3 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (13.1 sec)
23. ( 2 secs ) Upload to test-results [depth_capture_tests on Intel GPU on Mac]
    • stdout
24. ( 2 secs ) gpu_process_launch_tests on Intel GPU on Mac on Mac-10.12.6

    Run on OS: 'Mac-10.12.6'

    Shard duration: 0:01:21.170650

    Total tests: 15

    * Passed: 15 (15 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (53.8 sec)
25. ( 1 secs ) Upload to test-results [gpu_process_launch_tests on Intel GPU on Mac]
    • stdout
26. ( 4 mins 41 secs ) hardware_accelerated_feature_tests on Intel GPU on Mac on Mac-10.12.6

    Run on OS: 'Mac-10.12.6'

    Shard duration: 0:06:02.071340

    Total tests: 2

    * Passed: 2 (2 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (36.4 sec)
27. ( 2 secs ) Upload to test-results [hardware_accelerated_feature_tests on Intel GPU on Mac]
    • stdout
28. ( 2 secs ) info_collection_tests on Intel GPU on Mac on Mac-10.12.6

    Run on OS: 'Mac-10.12.6'

    Shard duration: 0:02:34.342400

    Total tests: 1

    * Passed: 1 (1 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (8.0 sec)
29. ( 1 secs ) Upload to test-results [info_collection_tests on Intel GPU on Mac]
    • stdout
30. ( 2 secs ) maps_pixel_test on Intel GPU on Mac on Mac-10.12.6

    Run on OS: 'Mac-10.12.6'

    Shard duration: 52s

    Total tests: 1

    * Passed: 1 (1 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (26.4 sec)
31. ( 1 secs ) Upload to test-results [maps_pixel_test on Intel GPU on Mac]
    • stdout
32. ( 2 secs ) pixel_test on Intel GPU on Mac on Mac-10.12.6

    Run on OS: 'Mac-10.12.6'

    Shard duration: 0:03:29.486100

    Total tests: 55

    * Passed: 52 (52 expected, 0 unexpected)

    * Skipped: 3 (3 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (182.1 sec)
33. ( 1 secs ) Upload to test-results [pixel_test on Intel GPU on Mac]
    • stdout
34. ( 1 secs ) screenshot_sync_tests on Intel GPU on Mac on Mac-10.12.6

    Run on OS: 'Mac-10.12.6'

    Shard duration: 0:01:00.004540

    Total tests: 4

    * Passed: 4 (4 expected, 0 unexpected)

    * Skipped: 0 (0 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (33.8 sec)
35. ( 1 secs ) Upload to test-results [screenshot_sync_tests on Intel GPU on Mac]
    • stdout
36. ( 2 secs ) trace_test on Intel GPU on Mac on Mac-10.12.6

    Run on OS: 'Mac-10.12.6'

    Shard duration: 0:02:51.529660

    Total tests: 34

    * Passed: 17 (17 expected, 0 unexpected)

    * Skipped: 17 (17 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (61.2 sec)
37. ( 1 secs ) Upload to test-results [trace_test on Intel GPU on Mac]
    • stdout
38. ( 7 mins 18 secs ) webgl_conformance_tests on Intel GPU on Mac on Mac-10.12.6

    Run on OS: 'Mac-10.12.6'

    Max shard duration: 0:13:31.526910 (shard #1)

    Min shard duration: 0:05:35.644790 (shard #0)

    Total tests: 922

    * Passed: 915 (915 expected, 0 unexpected)

    * Skipped: 7 (7 expected, 0 unexpected)

    * Failed: 0 (0 expected, 0 unexpected)

    * Flaky: 0 (0 expected, 0 unexpected)

     
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • outdir_json
    • step_metadata
    • shard #0 isolated out
    • shard #0 (311.3 sec)
    • shard #1 isolated out
    • shard #1 (694.0 sec)
39. ( 2 secs ) Upload to test-results [webgl_conformance_tests on Intel GPU on Mac]
    • stdout
40. ( 336 ms ) Tests statistics

     

    Stats

    Total shards: 14

    Total runtime: 0:25:59.175455

     
    • stdout
    • detailed stats
41. ( 0 ) recipe result
    • result

Build Properties:

Name	Value	Source
$recipe_engine/path	{"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"vm75-m9"	setup_build
buildbucket	{"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531413745578800, "id": "8941190016275201984", "project": "chromium", "tags": ["builder:Mac Debug (Intel)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/dcf8a49d5e3d2440dfc3f8e3126fa266fd25a33b", "gitiles_ref:refs/heads/master", "parent_buildername:GPU Mac Builder (dbg)", "parent_buildnumber:138024", "scheduler_invocation_id:9106620078364752304", "scheduler_job_id:chromium/Mac Debug (Intel)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"Mac Debug (Intel)"	setup_build
buildnumber	80298	setup_build
mastername	"chromium.gpu"	setup_build
parent_buildername	"GPU Mac Builder (dbg)"	setup_build
parent_got_angle_revision	"5598148b761380773c4e650b5b67f47553b0f090"	setup_build
parent_got_buildtools_revision	"0dd5c6f980d22be96b728155249df2da355989d9"	setup_build
parent_got_nacl_revision	"e6ce828ef60c4c1438867b535efbbb5d9a177c0e"	setup_build
parent_got_revision	"dcf8a49d5e3d2440dfc3f8e3126fa266fd25a33b"	setup_build
parent_got_revision_cp	"refs/heads/master@{#574592}"	setup_build
parent_got_swarming_client_revision	"9a518d097dca20b7b00ce3bdfc5d418ccc79893a"	setup_build
parent_got_v8_revision	"8b17db68f75a95d69debfa85b70aea3ec0766aaf"	setup_build
parent_got_v8_revision_cp	"refs/heads/6.9.352@{#1}"	setup_build
parent_got_webrtc_revision	"58c79f66dd3afef0ec2d77053e44f26b998b84b1"	setup_build
parent_got_webrtc_revision_cp	"refs/heads/master@{#23950}"	setup_build
parent_mastername	"chromium.gpu"	setup_build
path_config	"generic"	setup_build
recipe	"chromium"	setup_build
revision	"dcf8a49d5e3d2440dfc3f8e3126fa266fd25a33b"	setup_build
got_angle_revision	"5598148b761380773c4e650b5b67f47553b0f090"	bot_update
got_buildtools_revision	"0dd5c6f980d22be96b728155249df2da355989d9"	bot_update
got_nacl_revision	"e6ce828ef60c4c1438867b535efbbb5d9a177c0e"	bot_update
got_revision	"dcf8a49d5e3d2440dfc3f8e3126fa266fd25a33b"	bot_update
got_revision_cp	"refs/heads/master@{#574592}"	bot_update
got_swarming_client_revision	"9a518d097dca20b7b00ce3bdfc5d418ccc79893a"	bot_update
got_v8_revision	"8b17db68f75a95d69debfa85b70aea3ec0766aaf"	bot_update
got_v8_revision_cp	"refs/heads/6.9.352@{#1}"	bot_update
got_webrtc_revision	"58c79f66dd3afef0ec2d77053e44f26b998b84b1"	bot_update
got_webrtc_revision_cp	"refs/heads/master@{#23950}"	bot_update
swarm_hashes	{"angle_unittests": "a90b1d7d9beceeff8f7bed096b89a0a531b0fddd", "gl_tests": "26ecc85eb9ecd76436b18324f11c270d55d8d99a", "gl_unittests": "7900714a0e646c3889ac0030960e5224a77c51ec", "telemetry_gpu_integration_test": "45446770a005d2594a51a1ef6571092937f13e78"}	find isolated tests

Blamelist:

1. Mike Reed (reedohnoyoudont@google.com)
2. Peter E Conn (peconnohnoyoudont@chromium.org)
3. Peter Kasting (pkastingohnoyoudont@chromium.org)
4. Takuto Ikuta (tikutaohnoyoudont@chromium.org)
5. Jay Civelli (jcivelliohnoyoudont@google.com)
6. Stefan Zager (szagerohnoyoudont@chromium.org)

Timing:

Create	Thursday, 12-Jul-18 16:42:25 UTC
Start	Thursday, 12-Jul-18 16:42:27 UTC
End	Thursday, 12-Jul-18 17:00:25 UTC
Pending	1 secs
Execution	17 mins 58 secs

All Changes:

1. suppress until skia roll

   Changed by	Mike Reed - reedohnoyoudont@google.com
   Changed at	Thursday, 12-Jul-18 16:30:15 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	dcf8a49d5e3d2440dfc3f8e3126fa266fd25a33b

   Comments

   suppress until skia roll
   
   Bug: 863042
   Change-Id: I97a48047d0b6546055c255538fc31ddcc0a07078
   Reviewed-on: https://chromium-review.googlesource.com/1135288
   Commit-Queue: Mike Reed <reed@chromium.org>
   Commit-Queue: Florin Malita <fmalita@chromium.org>
   Reviewed-by: Florin Malita <fmalita@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#574592}

   Changed files

   • third_party/WebKit/LayoutTests/TestExpectations

2. 🤝 Add flag to force showing TWA disclosure.

   Changed by	Peter E Conn - peconnohnoyoudont@chromium.org
   Changed at	Thursday, 12-Jul-18 16:28:53 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	967fc76c423a5e86fc2e04b4655aa463d2ae7c12

   Comments

   🤝 Add flag to force showing TWA disclosure.
   
   Add a flag to force showing the disclosure for developer convenience.
   Also trigger even when there isn't an active tab yet.
   
   Bug: 813100
   Change-Id: I3ccd820d58f82040723a8f8a72097262ba374b82
   Reviewed-on: https://chromium-review.googlesource.com/1116922
   Reviewed-by: Benoit L <lizeb@chromium.org>
   Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
   Commit-Queue: Peter Conn <peconn@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#574591}

   Changed files

   • chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
   • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java
   • chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

3. Once TabStrip doesn't need it, there's no reason to expose GetTopOffset().

   Changed by	Peter Kasting - pkastingohnoyoudont@chromium.org
   Changed at	Thursday, 12-Jul-18 16:28:33 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	1b2b9af8ace2bbc3384147241601d4293f0c2259

   Comments

   Once TabStrip doesn't need it, there's no reason to expose GetTopOffset().
   
   Bug: none
   Change-Id: Ia78dd54f4364e7010ddf3ce16b01e5f5f3c764e4
   Reviewed-on: https://chromium-review.googlesource.com/1134499
   Commit-Queue: Peter Kasting <pkasting@chromium.org>
   Reviewed-by: Allen Bauer <kylixrd@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#574590}

   Changed files

   • chrome/browser/ui/views/tabs/new_tab_button.cc
   • chrome/browser/ui/views/tabs/new_tab_button.h

4. Keep timestamp in aar.py when file is not changed

   Changed by	Takuto Ikuta - tikutaohnoyoudont@chromium.org
   Changed at	Thursday, 12-Jul-18 16:22:48 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	2d186e03f89aa3fa40dc7266cbc33a0310ac3dd8

   Comments

   Keep timestamp in aar.py when file is not changed
   
   This is a reland of
   https://chromium-review.googlesource.com/c/chromium/src/+/1127565
   I didn't understand filecmp.dircmp.
   
   Changed to use md5_check.CallAndRecordIfStale instead.
   Also let ExtractAll create directory even when it is empty.
   
   Bug: 810298, 860251
   Change-Id: I0d1e2e385ff1a12981473ef422099f638ca174cf
   Reviewed-on: https://chromium-review.googlesource.com/1132818
   Reviewed-by: agrieve <agrieve@chromium.org>
   Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#574589}

   Changed files

   • build/android/gyp/aar.py
   • build/android/gyp/util/build_utils.py

5. Simplify FakeGaiaCookieManagerService

   Changed by	Jay Civelli - jcivelliohnoyoudont@google.com
   Changed at	Thursday, 12-Jul-18 16:18:37 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8

   Comments

   Simplify FakeGaiaCookieManagerService
   
   Simplifying the FakeGaiaCookieManagerService API by not requiring to
   call Init() with a FakeURLFetcherFactory. The FakeURLFetcherFactory is
   instead a member of the FakeGaiaCookieManagerService.
   
   This API simplification is in preparation for switching GaiaAuthFetcher
   to use the SimpleURLLoader (network service).
   
   Bug: 840396
   Change-Id: I917e4236a53bf251c3a8e82c868d5e4d99655aca
   Reviewed-on: https://chromium-review.googlesource.com/1114226
   Reviewed-by: Avi Drissman <avi@chromium.org>
   Reviewed-by: Scott Violet <sky@chromium.org>
   Reviewed-by: Justin Cohen <justincohen@chromium.org>
   Reviewed-by: David Roger <droger@chromium.org>
   Commit-Queue: Jay Civelli <jcivelli@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#574588}

   Changed files

   • chrome/browser/extensions/api/identity/identity_apitest.cc
   • chrome/browser/search/one_google_bar/one_google_bar_service_unittest.cc
   • chrome/browser/signin/dice_response_handler_unittest.cc
   • chrome/browser/signin/fake_gaia_cookie_manager_service_builder.cc
   • chrome/browser/signin/fake_gaia_cookie_manager_service_builder.h
   • chrome/browser/signin/signin_ui_util_unittest.cc
   • chrome/browser/supervised_user/child_accounts/child_account_service_unittest.cc
   • chrome/browser/ui/views/frame/test_with_browser_view.cc
   • chrome/browser/ui/views/frame/test_with_browser_view.h
   • components/search_provider_logos/logo_service_impl_unittest.cc
   • components/signin/core/browser/account_investigator_unittest.cc
   • components/signin/core/browser/account_reconcilor_unittest.cc
   • components/signin/core/browser/fake_gaia_cookie_manager_service.cc
   • components/signin/core/browser/fake_gaia_cookie_manager_service.h
   • components/signin/core/browser/signin_manager_unittest.cc

6. Get rid of GraphicsLayer::scrollable_area_

   Changed by	Stefan Zager - szagerohnoyoudont@chromium.org
   Changed at	Thursday, 12-Jul-18 16:18:15 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	442f13b7e97747ab09612a101159b1eb26072382

   Comments

   Get rid of GraphicsLayer::scrollable_area_
   
   The only place where it was actually used was in
   GraphicsLayer::SetScrollbarsHiddenIfOverlay, so just forward that
   call to the GraphicsLayerClient.
   
   BUG=823365
   R=pdr@chromium.org,skobes@chromium.org
   
   Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
   Change-Id: I3cdd24ceb1ab51563dbc3b6d9ce50ce9edc77bf8
   Reviewed-on: https://chromium-review.googlesource.com/1132536
   Commit-Queue: Stefan Zager <szager@chromium.org>
   Reviewed-by: Steve Kobes <skobes@chromium.org>
   Reviewed-by: Philip Rogers <pdr@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#574587}

   Changed files

   • third_party/blink/renderer/core/frame/visual_viewport.cc
   • third_party/blink/renderer/core/frame/visual_viewport.h
   • third_party/blink/renderer/core/layout/scrollbars_test.cc
   • third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
   • third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
   • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
   • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.h
   • third_party/blink/renderer/core/paint/compositing/graphics_layer_tree_as_text.cc
   • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
   • third_party/blink/renderer/platform/graphics/graphics_layer.cc
   • third_party/blink/renderer/platform/graphics/graphics_layer.h
   • third_party/blink/renderer/platform/graphics/graphics_layer_client.h