Home | Search | chromium - Builders
Login

Builder Mac Builder Build 88899 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revision8a7df13b2932f8f83559de4c263c972e08f9301b
Got Revision8a7df13b2932f8f83559de4c263c972e08f9301b

Execution:

Steps and Logfiles:

Show:
  1. ( 450 ms ) setup_build
    running recipe: "chromium"
  2. ( 586 ms ) remove .cipd
  3. ( 4 mins 44 secs ) bot_update
    [69GB/232GB used (29%)]
  4. ( 0 ) ensure_goma
  5. ( 1 secs ) swarming.py --version
    0.13
  6. ( 235 ms ) ensure_installed
  7. ( 9 mins 10 secs ) gclient runhooks
  8. ( 729 ms ) read test spec (chromium.mac.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.mac.json
  9. ( 21 secs ) generate_build_files
  10. ( 823 ms ) clang_revision
  11. ( 53 mins 27 secs ) compile
  12. ( 14 secs ) compile confirm no-op
  13. ( 1 mins 55 secs ) isolate tests
  14. ( 5 mins 14 secs ) package build
  15. ( 618 ms ) trigger

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm74-m9" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531426319649940, "id": "8941176831406242064", "project": "chromium", "tags": ["builder:Mac Builder", "buildset:commit/git/8a7df13b2932f8f83559de4c263c972e08f9301b", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/8a7df13b2932f8f83559de4c263c972e08f9301b", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9106606893593849072", "scheduler_job_id:chromium/Mac Builder", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Mac Builder" setup_build
buildnumber 88899 setup_build
mastername "chromium.mac" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "8a7df13b2932f8f83559de4c263c972e08f9301b" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "8a7df13b2932f8f83559de4c263c972e08f9301b" bot_update
got_revision_cp "refs/heads/master@{#574694}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "798ee75d23651e7631775a113742bd09cc02e212" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23952}" bot_update
got_clang_revision "336424-1" clang_revision
swarm_hashes_refs/heads/master(at){#574694}_without_patch {"accessibility_unittests": "e6763ee79da4e2538daee392088583c6f2377be2", "angle_unittests": "2a789980cc7a2b644f479cf710e906d55a296a3c", "app_shell_unittests": "e655c00a74a8c367328886fbf6186bc8eda729e4", "base_unittests": "d6cf9db882d0897026ccbc4a78286ab14e187b4a", "battor_agent_unittests": "546f8df0f11501f9167838f84d562b557ebee738", "blink_common_unittests": "1e01f96e417d9ae68168c4c39efc5e6a74369b16", "blink_fuzzer_unittests": "949a01784100d6a7c9fce2eff71025f687f1c079", "blink_heap_unittests": "c4a835f531367f4bc915149ef88e814af9540302", "blink_platform_unittests": "b1a2e39deb05d208702f324dedb75619820be978", "boringssl_crypto_tests": "865db52478dac5008f482cc91141b4097611dd1c", "boringssl_ssl_tests": "94b405783d70cbcdb17fcf49f241da7d3437ccb1", "browser_tests": "0d2ecccd85a5e987ba8aac5dcab0efb3ecffc18d", "cacheinvalidation_unittests": "91bd693af0a56954df1fa9651f54665472e98cf2", "capture_unittests": "be992f86067310a8e6f07229117ae864d183eaf2", "cast_unittests": "7c522b30d96d78c112d35bc16fb79283b04ec8be", "cc_unittests": "37ae5d243b3df0c6b62e101ce9cc7d4f40ada046", "chrome_app_unittests": "05888d44793c0d37c220e25a4dd71b0ef71b52cf", "chromedriver_py_tests": "33c149a567f81744ca7031d5dd25e9346929abd3", "chromedriver_unittests": "4818e5d171600effed82f2c5b620c27efb64e9c2", "components_browsertests": "070a0d3f1949d3d9b0617d420ace5fd2df3d19b1", "components_perftests": "ab18457813d020fdf1b1b8e579d9b76bdad4d8dd", "components_unittests": "a75cfe018c5e71a268c1681f93e8043d39b70839", "content_browsertests": "0581802563ff3dbf3941bfd9e14532147976a2eb", "content_shell_crash_test": "f9b739875f413637c493d0cef4ecc19de2c70857", "content_unittests": "df060cbde40844bbffe26174db146852998f200e", "crashpad_tests": "e274e4ccd118ead45ec69e03d065f1acb757adeb", "cronet_tests": "2bf318a1f29d563bcce7e86e5cfa151fdc3df6d1", "cronet_unittests": "286cec85b52e7df96652b27756bda55ceb808fe0", "crypto_unittests": "dbc22c71f0bf7c62458f9b4ae211ce4a44e65ff7", "device_unittests": "dd4542d91f15324d442b62d2a945f34fdb0b49fb", "display_unittests": "74864b1b2c14ec66234535cffecd81dc908f40c8", "events_unittests": "dd6821c5726f42c79dc05bbe8cc8571b91da3be9", "extensions_browsertests": "6328ec607b166a29708313d813fe83377e1013f9", "extensions_unittests": "3c5ee8f09a5e9ce54f19604cf1a87571e4f90c9e", "filesystem_service_unittests": "3b7a28b28bef70cf6926c1e6aa5386ec9d69e69e", "gcm_unit_tests": "78b640e951a7e9131620af71227ed11333a50d0a", "gfx_unittests": "c2b918932940a647996610bf6f5050e4d36ef27e", "gin_unittests": "3ff85089556333bb81657c491145ed8968bdee72", "google_apis_unittests": "a3037afd6cc7e522e2c7d038730f7682183d43dc", "gpu_unittests": "f869beb5e5ece02549e4ac0dad02e85c87bb00b0", "headless_browsertests": "37d056501571e56b6d573148d8bd71f3f483911d", "headless_unittests": "a396ced836c1b10fe11b9d71cf05b2c781d1c54f", "interactive_ui_tests": "1ba10fad4c760782ebbb0cf4567a593b03762f19", "ipc_tests": "1344238b30927b892cb1c9916808a3bd32364e9f", "jingle_unittests": "40ce2038cc837c7130a0f931aac2ffc9e95ed757", "latency_unittests": "b7a220e2c619a0cc811bb22b77ce2acc1d39551c", "leveldb_service_unittests": "34f2708fd1c53f5c510ee55569f59a22286ba74a", "libjingle_xmpp_unittests": "59d6fb8fd983bb3b6320551f5217e89cd6ef70e0", "mac_installer_unittests": "7d546a2749d127fc6fa818961648d7e0e3900978", "media_blink_unittests": "a48943e128e665931a8da7eb787f05fa4c78c57b", "media_service_unittests": "ea32137acb20a595d4c1d2fdd3a4866f1c36f5a4", "media_unittests": "d999fe83e2b4f99cfa674313ffbea954286995df", "message_center_unittests": "cccf94e1b78ee71310422d1eff3bea2c00103b0b", "metrics_python_tests": "4538fd72c5e9b0e79872b5009cd46ec71c22845a", "midi_unittests": "3da5f464ea0c9cb60f5500febc7154b8492676f1", "mojo_unittests": "53c6e9a4b246b6829d3b260ee1797a88c620c0b1", "nacl_loader_unittests": "7438a7bcb45aeac2894e28ade2366ae5e16d5d7d", "native_theme_unittests": "af43b0b308cd6ce69aadc6d49affb57ad2bdc4a6", "net_unittests": "c1a52f1824aba8ef7590035485428cc18aadf9b7", "pdf_unittests": "b63063fafc3d9c41c318ab1173eef3a26784ee8a", "ppapi_unittests": "2432bad0c276d138cab3044a4911dfa800aac656", "printing_unittests": "b727e51238f48196ed481d29f146007b26f90da0", "remoting_unittests": "83e398ecd16746537af7a40a4d6a0b94d473cc27", "sandbox_mac_unittests": "be9c8c7e3422ac7938394d46358fd526887dc260", "service_manager_unittests": "3ffb0da6e25358b6439bfab168194215221ee5ad", "services_unittests": "e2b36b47dfffc5061f467fa66f8c913ecde0cae2", "shell_dialogs_unittests": "55f736d59880819a0998f92cc94175c45d3bcb4d", "skia_unittests": "76cc454ee3273174a66424c79775296d14751838", "snapshot_unittests": "5f60f882e91bfd62d8172b0fd4c7afe6f90834f6", "sql_unittests": "11ebd91bbe9b102fba0653f09d4177037b5d02d9", "storage_unittests": "04da55b4e4259c27c6374374493132f792b8bdd1", "sync_integration_tests": "4900728c3c43f872cf9143bc637b2e67f268e035", "telemetry_gpu_unittests": "27ec4663b5821c637c424497d30c0a5b0778194f", "telemetry_perf_unittests": "d95e45ec50fc82e5b70d24cf71df7dac39b8cbfc", "telemetry_unittests": "63703964eee715c3b45d9c44e9c92fdb4e54e379", "ui_base_unittests": "0aff208b3543d525f7a44865c19745278e84563d", "ui_touch_selection_unittests": "9f55612f59d3f42466dbf647ce6c5d1392e964b7", "unit_tests": "b5203ad3e38a5e673d5fbef15fe92bfa45c1bf44", "url_unittests": "674a822e9f9c0acfc67684469add80416253efd3", "views_perftests": "f6e9d9c21e85b1475b1c43e214c306573e976d3e", "views_unittests": "2c319bef56ae1a2fd5e0b754b9c2195db1e50bf9", "viz_unittests": "31855af406e2a6732cca501a7a7a8aaecdd10656", "webkit_layout_tests_exparchive": "c399b2c57f4042c1b906bed56a1a3f95874a07db", "webkit_python_tests": "76f6e8208a07babdcba7148482eb52965f9dc71a", "webkit_unit_tests": "8f6fce0870a7966e660b2b29032b0c8fad16b3cf", "wtf_unittests": "cc09913b1c378282c34791db0efa0cd57c170ed1"} isolate tests
build_archive_url "gs://chromium-mac-archive/chromium.mac/Mac Builder/full-build-mac_8a7df13b2932f8f83559de4c263c972e08f9301b.zip" package build

Blamelist:

  1. Greg Kraynov (kraynovohnoyoudont@chromium.org)
  2. spqchan (spqchanohnoyoudont@chromium.org)
  3. Ben Pastene (bpasteneohnoyoudont@chromium.org)
  4. Andrey Lushnikov (lushnikovohnoyoudont@chromium.org)
  5. Thomas Guilbert (tguilbertohnoyoudont@chromium.org)
  6. Nektarios Paisios (nektarohnoyoudont@chromium.org)
  7. Amirhossein Simjour (asimjourohnoyoudont@chromium.org)
  8. Ryan Daum (rdaumohnoyoudont@chromium.org)
  9. Danyao Wang (danyaoohnoyoudont@chromium.org)
  10. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  11. Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
  12. erikchen (erikchenohnoyoudont@chromium.org)
  13. Esmael El-Moslimany (aeeohnoyoudont@chromium.org)
  14. Wez (wezohnoyoudont@chromium.org)
  15. Aldo Culquicondor (acondorohnoyoudont@chromium.org)
  16. Kim Paulhamus (kpaulhamusohnoyoudont@chromium.org)
  17. fuchsia-sdk-chromium-autoroll (fuchsia-sdk-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  18. Ian Clelland (iclellandohnoyoudont@chromium.org)
  19. Fabio Tirelo (ftireloohnoyoudont@chromium.org)
  20. Kenneth Russell (kbrohnoyoudont@chromium.org)
  21. perfetto-chromium-autoroll (perfetto-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  22. Daniel Murphy (dmurphohnoyoudont@chromium.org)
  23. Chromite Chromium Autoroll (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  24. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
  25. Lei Zhang (thestigohnoyoudont@chromium.org)
  26. Lu Chen (cheluohnoyoudont@chromium.org)
  27. Scott Chen (scottchenohnoyoudont@chromium.org)
  28. Kenneth Russell (kbrohnoyoudont@chromium.org)
  29. Kyle Milka (kmilkaohnoyoudont@chromium.org)
  30. skia-chromium-autoroll (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  31. Erik Luo (luoeohnoyoudont@chromium.org)
  32. Nate Fischer (ntfschrohnoyoudont@chromium.org)
  33. Michael Thiessen (mthiesseohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 20:11:59 UTC
Start Thursday, 12-Jul-18 20:12:01 UTC
End Thursday, 12-Jul-18 21:32:45 UTC
Pending 1 secs
Execution 1 hrs 20 mins

All Changes:

  1. Remove components/viz/test dependency from blink platform.

    Changed by Greg Kraynov - kraynovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:07:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8a7df13b2932f8f83559de4c263c972e08f9301b

    Comments

    Remove components/viz/test dependency from blink platform.
    
    cc::OrderedSimpleTestTaskRunner isn't used there anymore.
    
    Bug: 841735
    Change-Id: I88a5bfa2ebaf01a08943396ce20f63c483a19b3a
    Reviewed-on: https://chromium-review.googlesource.com/1133177
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Commit-Queue: Greg Kraynov <kraynov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574694}

    Changed files

    • third_party/blink/renderer/platform/scheduler/BUILD.gn
    • third_party/blink/renderer/platform/scheduler/child/DEPS
    • third_party/blink/renderer/platform/scheduler/common/DEPS
    • third_party/blink/renderer/platform/scheduler/main_thread/DEPS
    • third_party/blink/renderer/platform/scheduler/renderer/DEPS
    • third_party/blink/renderer/platform/scheduler/worker/DEPS
    • third_party/blink/renderer/platform/testing/DEPS
  2. [Mac] Refactor BrowserWindowTouchBarMac

    Changed by spqchan - spqchanohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:05:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e95b7292bae44c8e6fb9af5801f102ae28587d6c

    Comments

    [Mac] Refactor BrowserWindowTouchBarMac
    
    Separate BrowserWindowTouchBarMac into two classes:
    BrowserWindowDefaultTouchBar and
    BrowserWindowTouchBarController.
    
    BrowserWindowTouchBarController determines what
    touch bar should be used for browser window.
    BrowserWindowDefaultTouchBar creates a default
    touch bar for the browser.
    
    These changes are split from a bigger change to
    hook up touch bar support for web textfield in
    MacViews:
    
    https://chromium-review.googlesource.com/c/chromium/src/+/1132597
    
    Bug: 856391
    Change-Id: I9be31c65bd0acc2ec4d39b5e2f6b06fc30e36bf7
    Reviewed-on: https://chromium-review.googlesource.com/1133705
    Commit-Queue: Sarah Chan <spqchan@chromium.org>
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574693}

    Changed files

    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/browser_window_touch_bar_mac.h
    • chrome/browser/ui/cocoa/browser_window_controller.h
    • chrome/browser/ui/cocoa/browser_window_controller.mm
    • chrome/browser/ui/cocoa/framed_browser_window.mm
    • chrome/browser/ui/cocoa/touchbar/browser_window_default_touch_bar.h
    • chrome/browser/ui/cocoa/touchbar/browser_window_default_touch_bar.mm
    • chrome/browser/ui/cocoa/touchbar/browser_window_default_touch_bar_unittest.mm
    • chrome/browser/ui/cocoa/touchbar/browser_window_touch_bar_controller.h
    • chrome/browser/ui/cocoa/touchbar/browser_window_touch_bar_controller.mm
    • chrome/browser/ui/cocoa/touchbar/browser_window_touch_bar_controller_browsertest.mm
    • chrome/browser/ui/views/frame/browser_frame_mac.mm
    • chrome/test/BUILD.gn
  3. milo: Add link to chromiumos tryserver to chromium's console.

    Changed by Ben Pastene - bpasteneohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:03:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6678ca5e07d42a16c0e63b123543672ab94c3c29

    Comments

    milo: Add link to chromiumos tryserver to chromium's console.
    
    And alphabetize the list.
    
    R=hinoka
    
    Change-Id: I28d7c354c153f848fae7098e57b67445345cb850
    Reviewed-on: https://chromium-review.googlesource.com/1135691
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    Commit-Queue: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574692}

    Changed files

    • infra/config/global/luci-milo.cfg
  4. Make content::PermissionManager a delegate of PermissionController

    Changed by Andrey Lushnikov - lushnikovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:02:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ebff0440cc1ada42a20446c0f6d9ddf0619f64df

    Comments

    Make content::PermissionManager a delegate of PermissionController
    
    One-pager describing this refactoring: https://goo.gl/24gkCb
    
    Today, `content/` layer provides `permission_manager.h` interface that
    is supposed to be implemented by embedders and simultaneously used
    as API in `content/` layer. This leaves us with no place in content/ layer
    where we can put DevTools instrumentation.
    
    This patch separates content API from embedder interface. With this
    patch, `content/` layer provides 2 interfaces:
    - content::PermissionController - content-level API to manage permissions
    - content::PermissionManager - interface to be implemented by
    embedders. This is a delegate for content::PermissionController.
    
    This design enables DevTools to handle and override content permissions through
    DevTools protocol. The functionality will be encapsulated in
    PermissionController class.
    
    There's exactly one PermissionController for each BrowserContext.
    If embedder doesn't implement PermissionManager, then
    PermissionController rejects all permission requests.
    
    In a follow-up:
    - rename `content::PermissionManager` into `content::PermissionControllerDelegate`.
    - rename `BrowserContext::GetPermissionManager()` into `BrowserContext::GetPermissionControllerDelegate()`.
    - rename `TestBrowserContext::SetPermissionManager()` into `TestBrowserContext::SetPermissionControllerDelegate()`.
    
    R=dgozman
    TBR=sdefresne, tobiasjs, slan, thakis
    BUG=631464
    
    Change-Id: I5f6f1ea5b28e284c462a5055d9b072f12f30ce19
    Reviewed-on: https://chromium-review.googlesource.com/1111340
    Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574691}

    Changed files

    • android_webview/browser/aw_permission_manager.cc
    • chrome/browser/net/reporting_permissions_checker.cc
    • chrome/browser/notifications/platform_notification_service_impl.cc
    • chrome/browser/permissions/permission_manager.cc
    • chromecast/browser/cast_permission_manager.cc
    • components/domain_reliability/service.cc
    • components/domain_reliability/service_unittest.cc
    • components/payments/content/installable_payment_app_crawler.cc
    • content/browser/BUILD.gn
    • content/browser/background_sync/background_sync_manager.cc
    • content/browser/browser_context.cc
    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/generic_sensor/sensor_provider_proxy_impl.cc
    • content/browser/generic_sensor/sensor_provider_proxy_impl.h
    • content/browser/geolocation/geolocation_service_impl.cc
    • content/browser/geolocation/geolocation_service_impl.h
    • content/browser/geolocation/geolocation_service_impl_unittest.cc
    • content/browser/notifications/blink_notification_service_impl.cc
    • content/browser/payments/payment_app_provider_impl.cc
    • content/browser/permissions/permission_controller_impl.cc
    • content/browser/permissions/permission_controller_impl.h
    • content/browser/permissions/permission_service_context.cc
    • content/browser/permissions/permission_service_impl.cc
    • content/browser/push_messaging/push_messaging_manager.cc
    • content/public/browser/BUILD.gn
    • content/public/browser/browser_context.h
    • content/public/browser/permission_controller.h
    • content/public/browser/permission_manager.h
    • content/public/test/mock_permission_manager.cc
    • content/shell/browser/layout_test/layout_test_permission_manager.cc
    • content/shell/browser/shell_permission_manager.cc
    • headless/lib/browser/headless_permission_manager.cc
  5. Move content::MediaController to media/base

    Changed by Thomas Guilbert - tguilbertohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:02:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2784a2c6630a8de538a7b2bf6d993823d321a489

    Comments

    Move content::MediaController to media/base
    
    The MediaController interface and the upcoming MediaStatusObserver do
    not have to live in content/public/browser. The media/base folder and
    the media namespace is a more generic place for them to live, even if
    most of the code that will use them lives in content.
    
    Bug: 820277
    Change-Id: I2f91cd88c6f5238723aae8aeff1c323c02f738d4
    Reviewed-on: https://chromium-review.googlesource.com/1134090
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574690}

    Changed files

    • chrome/browser/media/android/remote/media_controller_bridge.h
    • chrome/browser/media/android/router/media_router_android.cc
    • chrome/browser/media/android/router/media_router_android.h
    • chrome/browser/media/android/router/media_router_android_bridge.cc
    • chrome/browser/media/android/router/media_router_android_bridge.h
    • chrome/browser/media/router/media_router.h
    • chrome/browser/media/router/media_router_base.cc
    • chrome/browser/media/router/media_router_base.h
    • chrome/browser/media/router/presentation/presentation_service_delegate_impl.cc
    • chrome/browser/media/router/presentation/presentation_service_delegate_impl.h
    • content/browser/media/flinging_renderer.cc
    • content/browser/media/flinging_renderer.h
    • content/browser/media/flinging_renderer_unittest.cc
    • content/browser/presentation/presentation_service_impl_unittest.cc
    • content/public/browser/BUILD.gn
    • content/public/browser/presentation_service_delegate.h
    • media/base/BUILD.gn
    • media/base/media_controller.h
  6. Improved performance of AXPosition::operator less than

    Changed by Nektarios Paisios - nektarohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:01:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision adeaf13d9c8651fcf83c9e5a6a7d1173f1eb27e1

    Comments

    Improved performance of AXPosition::operator less than
    
    Only move up or down the tree using text equivalent positions (by calling CreateParentPosition and AsLeafTextPosition) when we absolutely need to.
    R=dmazzoni@chromium.org
    
    Tested: VoiceOver on Mac by navigating in Gmail and checking how many times you hear "Busy"
    Change-Id: Id9469e52ef87b8b8a0c6c5fac5325abec415382d
    Bug: 861567
    Reviewed-on: https://chromium-review.googlesource.com/1133334
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Nektarios Paisios <nektar@chromium.org>
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574689}

    Changed files

    • ui/accessibility/ax_node_position_unittest.cc
    • ui/accessibility/ax_position.h
  7. VR: fix autofill popup size

    Changed by Amirhossein Simjour - asimjourohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:01:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9d07f06bb5c43657ce38efc57039e36287eac2a6

    Comments

    VR: fix autofill popup size
    
    Break SetAlertDialogSize into to methods. One to set the relative
    size to the main content, another one to set the absolute size.
    Also added comment to hosted_platform_ui to clarify the size of
    the rectangle in the model.
    
    Bug: 863071
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Ie102fcb00865d66052e4bb3c7817831fdcfe5dfa
    Reviewed-on: https://chromium-review.googlesource.com/1132140
    Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
    Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574688}

    Changed files

    • chrome/browser/android/vr/vr_shell_gl.cc
    • chrome/browser/vr/model/hosted_platform_ui.h
    • chrome/browser/vr/ui.cc
    • chrome/browser/vr/ui.h
  8. [chromecast] Support for top-down drag gesture.

    Changed by Ryan Daum - rdaumohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:00:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7281e2b2ea7ce739c6106b6005a2d58a9eedb86a

    Comments

    [chromecast] Support for top-down drag gesture.
    
    Bug: internal b/111304882
    Test: unit test and manual
    Change-Id: Iab32b58098a02eb054faeb94625e312d274cdae1
    Reviewed-on: https://chromium-review.googlesource.com/1135692
    Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
    Commit-Queue: Alex Sakhartchouk <alexst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574687}

    Changed files

    • chromecast/browser/cast_content_window.h
    • chromecast/browser/cast_gesture_dispatcher.cc
    • chromecast/browser/cast_gesture_dispatcher.h
    • chromecast/browser/cast_gesture_dispatcher_test.cc
  9. [Nav Experiment] Parameterize HistoryStateOperationsTest.

    Changed by Danyao Wang - danyaoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:57:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 32bdecc1fac228cf335811bea0f31e2a29153f29

    Comments

    [Nav Experiment] Parameterize HistoryStateOperationsTest.
    
    So both LegacyNavigationManager and WKBasedNavigationManager can be
    tested on trybots.
    
    Fixed test expectation for StateReplacementBackForward to match the
    behavior of WebKit (and Safari on other platforms).
    
    Bug: 862724
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ic01dcabf2e6ef6903d8f8ee348798951007660cc
    Reviewed-on: https://chromium-review.googlesource.com/1134472
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574686}

    Changed files

    • ios/web/navigation/history_state_operations_inttest.mm
  10. Network quality servicification of RTT and downlink estimates

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:56:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 88c8cc52351f93d11e0bfac3b75ded5b420b131b

    Comments

    Network quality servicification of RTT and downlink estimates
    
    Send the RTT and downlink estimates over the mojo channel
    to the browser process. The RTT and downlink estimates are
    sent over an existing mojo message which carrier the current
    effective connection type estimate.
    
    The mojo message is sent only if there is a significant change
    in the values of either the RTT or the downlink estimate.
    
    In the next CL, I will move the network quality consumers
    in the browser process over to NetworkQualityTracker.
    
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I01bbc7af2e7e3cf41f69e7ac19f8edd9ec59de90
    Bug: 819244
    Reviewed-on: https://chromium-review.googlesource.com/1130233
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Helen Li <xunjieli@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574685}

    Changed files

    • chrome/browser/net/network_quality_tracker_browsertest.cc
    • services/network/network_quality_estimator_manager.cc
    • services/network/network_quality_estimator_manager.h
    • services/network/network_quality_estimator_manager_unittest.cc
    • services/network/public/cpp/network_quality_tracker.cc
    • services/network/public/cpp/network_quality_tracker.h
    • services/network/public/cpp/network_quality_tracker_unittest.cc
    • services/network/public/mojom/network_quality_estimator_manager.mojom
  11. [Fuchsia] Remove package detection in base::PathProviderFuchsia()

    Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:48:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4f9d9e774d5d41a5d8073b156348eee4bde25753

    Comments

    [Fuchsia] Remove package detection in base::PathProviderFuchsia()
    
    Previously PathProvider was trying to detect if it's packaged or not.
    That logic is no longer needed because we can assume that all binaries
    produced in chromium are packaged.
    
    Change-Id: I963afac5342d44b8d8188c07ffb927d6b4fac271
    Reviewed-on: https://chromium-review.googlesource.com/1134586
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574684}

    Changed files

    • base/base_paths_fuchsia.cc
  12. Add high water mark in background profiling triggers for memlog.

    Changed by erikchen - erikchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:47:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3483cb3aa6a9343b22e8ec39e81cb2fc864970a3

    Comments

    Add high water mark in background profiling triggers for memlog.
    
    Previously, a memlog report would be uploaded if a fixed threshold was exceeded.
    After that point, the timer frequency would be reduced to prevent too many
    reports from being uploaded.
    
    In this CL, we use a fixed, higher frequency timer to check memory usage. We
    upload an initial report if the fixed thresholds are exceeded, and then upload
    more reports each time the high water mark is exceeded by a significant amount.
    This allows us to catch higher-velocity memory leaks, that might otherwise cause
    the process to be killed before a report would be uploaded with the previous
    mechanism.
    
    Change-Id: I706314810d962c51e4126157363f44ce64868721
    Reviewed-on: https://chromium-review.googlesource.com/1132099
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Reviewed-by: Siddhartha S <ssid@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574683}

    Changed files

    • chrome/browser/profiling_host/background_profiling_triggers.cc
    • chrome/browser/profiling_host/background_profiling_triggers.h
    • chrome/browser/profiling_host/background_profiling_triggers_unittest.cc
  13. WebUI: update text to use primary/secondary colors for style refresh

    Changed by Esmael El-Moslimany - aeeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:47:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0ceaa55ab4070c9fc1bce4a599d62362576b1322

    Comments

    WebUI: update text to use primary/secondary colors for style refresh
    
    Bug: 849857
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ia64cd1565af8f50a4af8b5c08f82d9a13df00acf
    Reviewed-on: https://chromium-review.googlesource.com/1133959
    Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574682}

    Changed files

    • chrome/browser/resources/md_downloads/item.html
    • chrome/browser/resources/md_extensions/detail_view.html
    • chrome/browser/resources/md_extensions/error_page.html
    • chrome/browser/resources/md_extensions/manager.html
    • chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
    • chrome/browser/resources/settings/device_page/storage.html
    • chrome/browser/resources/settings/internet_page/network_summary_item.html
    • chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
    • chrome/browser/resources/settings/people_page/setup_pin_dialog.html
    • chrome/browser/resources/settings/settings_page/settings_subpage_search.html
    • chrome/browser/resources/settings/settings_shared_css.html
    • chrome/browser/resources/settings/site_settings/zoom_levels.html
    • ui/webui/resources/cr_elements/chromeos/network/cr_network_list_item.html
    • ui/webui/resources/cr_elements/paper_tabs_style_css.html
  14. Fix race-condition in SchedulerSingleThreadTaskRunnerManager::Start().

    Changed by Wez - wezohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:42:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 291f0a739f2c952d402f76d3750b9a2340269c18

    Comments

    Fix race-condition in SchedulerSingleThreadTaskRunnerManager::Start().
    
    SchedulerSingleThreadTaskRunnerManager allows SingleThreadTaskRunners to
    be created and tasks posted to them before the worker threads are
    actually started. The call to Start() the required workers was calling
    both Start() and WakeUp() on each of them, the latter being unnecessary
    since if a worker needs to process work then it must already have been
    woken, when the work was PostTask()d into it.
    
    Besides removing an unnecessary wake-up, this resolves a subtle race-
    condition between wake-up and a potential worker clean-up (see bug).
    
    Bug: 862582
    Change-Id: I9c4246cec4b1bda6d728e5e1656bb2c5ca7c0f0a
    Reviewed-on: https://chromium-review.googlesource.com/1133279
    Commit-Queue: Wez <wez@chromium.org>
    Reviewed-by: Robert Liao <robliao@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574681}

    Changed files

    • base/task_scheduler/scheduler_single_thread_task_runner_manager.cc
  15. VR: Update textures only if dirty

    Changed by Aldo Culquicondor - acondorohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:38:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7b520e5b526c4e1ed0a2344a79e42eb6fcf5c298

    Comments

    VR: Update textures only if dirty
    
    This prevents from performing unnecessary context switches.
    
    Bug: 861799
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I5da0e41dda9edb0243c9bbc9c944bdc2cdfaaf39
    Reviewed-on: https://chromium-review.googlesource.com/1133298
    Reviewed-by: Christopher Grant <cjgrant@chromium.org>
    Reviewed-by: Ian Vollick <vollick@chromium.org>
    Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574680}

    Changed files

    • chrome/browser/android/vr/vr_shell_gl.cc
    • chrome/browser/vr/elements/textured_element.cc
    • chrome/browser/vr/elements/textured_element.h
    • chrome/browser/vr/elements/ui_element.cc
    • chrome/browser/vr/elements/ui_element.h
    • chrome/browser/vr/test/ui_test.cc
    • chrome/browser/vr/ui.cc
    • chrome/browser/vr/ui.h
    • chrome/browser/vr/ui_scene.cc
    • chrome/browser/vr/ui_scene.h
  16. Disable flaky SitePerProcessHitTestBrowserTest

    Changed by Kim Paulhamus - kpaulhamusohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:35:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e031a4fd51a2eefc216a0f80f4bb139e1812b6c

    Comments

    Disable flaky SitePerProcessHitTestBrowserTest
    
    [OverlapSurfaceHitTestTest]
    
    TBR=sunxd@chromium.org
    
    Bug: 833380
    Change-Id: I7991db84dd9201e59089f08a536bcab00b23d379
    Reviewed-on: https://chromium-review.googlesource.com/1135648
    Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
    Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574679}

    Changed files

    • content/browser/site_per_process_hit_test_browsertest.cc
  17. Roll Fuchsia SDK from cf3c39f9e29d to 64ef9c9bec71

    Changed by fuchsia-sdk-chromium-autoroll - fuchsia-sdk-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:34:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0708b273b84747404d79725f8be67c90f3047079

    Comments

    Roll Fuchsia SDK from cf3c39f9e29d to 64ef9c9bec71
    
    
    The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
    TBR=cr-fuchsia+bot@chromium.org
    
    Change-Id: I44aa919993e7873807987396622c8fcb0bf2a17f
    Reviewed-on: https://chromium-review.googlesource.com/1135632
    Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574678}

    Changed files

    • build/fuchsia/sdk.sha1
  18. Clean up feature policy flags.

    Changed by Ian Clelland - iclellandohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:32:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 77533434f64cde2813381a26cce2247a62070a21

    Comments

    Clean up feature policy flags.
    
    This fixes the default feature list, ensuring that features only appear
    in it if they are actually enabled with the correct runtime feature
    flags. Even if they are shipped as 'stable', they can still be disabled,
    and should not be parsed in that case, or appear in the output of
    document.policy.allowedFeatures().
    
    Bug: 862601
    Change-Id: I207a17818ed6696e9d029b86adcf42e4b58b6516
    Reviewed-on: https://chromium-review.googlesource.com/1133307
    Reviewed-by: Jeremy Roman <jbroman@chromium.org>
    Commit-Queue: Ian Clelland <iclelland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574677}

    Changed files

    • third_party/blink/renderer/platform/feature_policy/feature_policy.cc
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  19. Reland: [af] Adjust dropdown so it doesn't look so close to the input element

    Changed by Fabio Tirelo - ftireloohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:22:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 03daf4e42f99ef9329ec05fc186c1936ffa718a9

    Comments

    Reland: [af] Adjust dropdown so it doesn't look so close to the input element
    
    This relands commit f1c12e6, which was reverted by commit c71c2c1.
    
    The reason for the revert was a crash introduced by c53515c, and
    reverting that commit was very hard due to merge conflicts.
    
    Bug: 847980
    Change-Id: Ib1b6931d3ac697e78c27a6cbcc7e082f0da4b6ef
    Reviewed-on: https://chromium-review.googlesource.com/1135446
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574676}

    Changed files

    • chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
  20. Complete upgrade of Retina Macs to 10.13.5.

    Changed by Kenneth Russell - kbrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:21:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 43d34bd136540d0ff14ed70bfc2a69019338595d

    Comments

    Complete upgrade of Retina Macs to 10.13.5.
    
    Turn off the multi-dimension trigger script.
    
    Fix the configuration of "Optional Mac Retina Release (AMD)"; a
    mistake was made in the earlier CL beginning the upgrade, and the jobs
    didn't auto-migrate from 10.12.6 to 10.13.5.
    
    Bug: 856799
    Tbr: ynovikov@chromium.org
    Change-Id: Ifcceed16154c47ffaa5b682149780bc53f4a101b
    Reviewed-on: https://chromium-review.googlesource.com/1135651
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574675}

    Changed files

    • testing/buildbot/chromium.gpu.fyi.json
    • testing/buildbot/chromium.gpu.json
    • testing/buildbot/waterfalls.pyl
  21. Roll src/third_party/perfetto f37ffaf9b1a1..2af75f76f0e6 (2 commits)

    Changed by perfetto-chromium-autoroll - perfetto-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:21:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7b6920828c5fa9f72dce1b84c9ae95711ae037e5

    Comments

    Roll src/third_party/perfetto f37ffaf9b1a1..2af75f76f0e6 (2 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/f37ffaf9b1a1..2af75f76f0e6
    
    
    git log f37ffaf9b1a1..2af75f76f0e6 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 michaschwab@google.com Merge "Improve Context Architecture, add "isOnCanvas" method"
    2018-07-12 michaschwab@google.com Improve Context Architecture, add "isOnCanvas" method
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@2af75f76f0e6
    
    The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I4222bc49a1619c3cc2972a496dd5e7e961d03363
    Reviewed-on: https://chromium-review.googlesource.com/1135213
    Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574674}

    Changed files

    • DEPS
  22. [SessionStorage] Always delete Session Storage database on Android

    Changed by Daniel Murphy - dmurphohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:18:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 154ac5551c1e0ff8c877b4cd0e26ad6ea30d4860

    Comments

    [SessionStorage] Always delete Session Storage database on Android
    
    Android doesn't have session restore code run, and this code is what
    cleaned up old session storage namespaces from previous browser runs.
    
    So on Android, the session storage context will delete the database
    on startup.
    
    R=mek@chromium.org
    
    Bug: 860030
    Change-Id: Ia7c349811e4970d05a071a0de9ad50117d771855
    Reviewed-on: https://chromium-review.googlesource.com/1125260
    Commit-Queue: Daniel Murphy <dmurph@chromium.org>
    Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574673}

    Changed files

    • content/browser/dom_storage/dom_storage_context_wrapper.cc
    • content/browser/dom_storage/session_storage_context_mojo.cc
    • content/browser/dom_storage/session_storage_context_mojo.h
    • content/browser/dom_storage/session_storage_context_mojo_unittest.cc
  23. Roll src/third_party/chromite 3973c26575e2..ca73efa2232f (1 commits)

    Changed by Chromite Chromium Autoroll - chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:18:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0113967ab2dcdc45364c7cfa35fd095856d7ede5

    Comments

    Roll src/third_party/chromite 3973c26575e2..ca73efa2232f (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/3973c26575e2..ca73efa2232f
    
    
    git log 3973c26575e2..ca73efa2232f --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 stevenjb@chromium.org deploy_chrome: Always prompt to remove rootfs verification
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@ca73efa2232f
    
    The AutoRoll server is located here: https://chromite-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I910679c20d35bb32e7f9e089bdde8a437a37961c
    Reviewed-on: https://chromium-review.googlesource.com/1135208
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574672}

    Changed files

    • DEPS
  24. [Unity][Android] Update string for payments sync datatype

    Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:17:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab5e146619a4ce43dd36939245a2b6a9a254ef90

    Comments

    [Unity][Android] Update string for payments sync datatype
    
    This CL changes the string used for payments in
    'Sync and Google services' preferences screen.
    
    Bug: 814728
    Change-Id: Ib1932ef94ad6f6b90efa5a59e0ef0500775b9496
    Reviewed-on: https://chromium-review.googlesource.com/1135321
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574671}

    Changed files

    • chrome/android/java/res/xml/sync_customization_preferences.xml
    • chrome/android/java/strings/android_chrome_strings.grd
  25. Move PDFiumEngine doc/form/loading members into PDFiumDocument.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:16:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 94754366872ddaafeb4ec141f971ee47d3350c59

    Comments

    Move PDFiumEngine doc/form/loading members into PDFiumDocument.
    
    Change-Id: I11c1ecff9305a75f66c3de5443fde4d0423163d2
    Reviewed-on: https://chromium-review.googlesource.com/1112498
    Reviewed-by: dsinclair <dsinclair@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574670}

    Changed files

    • pdf/BUILD.gn
    • pdf/pdfium/pdfium_document.cc
    • pdf/pdfium/pdfium_document.h
    • pdf/pdfium/pdfium_engine.cc
    • pdf/pdfium/pdfium_engine.h
  26. Add bad IPC message check at the browser.

    Changed by Lu Chen - cheluohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:15:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f9ecec290e797566bdbbe41459d68a4045e29b5e

    Comments

    Add bad IPC message check at the browser.
    
    Add bad IPC message check to UpdateAnchorElementMetrics. The browser
    will kill the renderer process when it receives a bad message.
    
    Bug: 850624
    Change-Id: I750b6d54e556ddc659cb693844922234b9e845ce
    Reviewed-on: https://chromium-review.googlesource.com/1128259
    Commit-Queue: Lu Chen <chelu@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574669}

    Changed files

    • chrome/browser/navigation_predictor/navigation_predictor.cc
    • chrome/browser/navigation_predictor/navigation_predictor.h
    • chrome/browser/navigation_predictor/navigation_predictor_unittest.cc
    • tools/metrics/histograms/histograms.xml
  27. Settings: fix sync-account-controls banner overflowing border-radius.

    Changed by Scott Chen - scottchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:15:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 66d0e64aa958612d6b9cf38b9b8409925487458b

    Comments

    Settings: fix sync-account-controls banner overflowing border-radius.
    
    Bug: 860265
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ie85c25b7b777463569f4d3b4f01f8a8e524c84f5
    Reviewed-on: https://chromium-review.googlesource.com/1133977
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574668}

    Changed files

    • chrome/browser/resources/settings/people_page/people_page.html
    • chrome/browser/resources/settings/people_page/sync_account_control.html
  28. Update GPU pixel wrangling graphs for macOS 10.13.5 upgrade.

    Changed by Kenneth Russell - kbrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:14:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 32b92d2bc9ae9c12e01f7879de715843ac849ae8

    Comments

    Update GPU pixel wrangling graphs for macOS 10.13.5 upgrade.
    
    Tbr: ynovikov@chromium.org
    Bug: 856799
    Change-Id: I6d7265037477715df7ca7e31290ef88f7ad4f668
    Reviewed-on: https://chromium-review.googlesource.com/1135657
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574667}

    Changed files

    • docs/gpu/pixel_wrangling.md
  29. [NTP] Add Google Photos option for custom backgrounds

    Changed by Kyle Milka - kmilkaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:13:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d87ed83235c1f5505f58b0d51923dfe11db9faae

    Comments

    [NTP] Add Google Photos option for custom backgrounds
    
    Allow users to select one of their photos from Google Photos and set it
    as the NTP background image. Currently only supports users who are
    already signed in to their Google account.
    
    Bug: 848012
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Idef07f3cd107199a8e308fc883c96b9a8da37b1e
    Reviewed-on: https://chromium-review.googlesource.com/1130100
    Commit-Queue: Kyle Milka <kmilka@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574666}

    Changed files

    • chrome/browser/resources/local_ntp/custom_backgrounds.css
    • chrome/browser/resources/local_ntp/custom_backgrounds.js
    • chrome/browser/resources/local_ntp/local_ntp.html
    • chrome/browser/search/background/ntp_background_data.cc
    • chrome/browser/search/background/ntp_background_data.h
    • chrome/browser/search/background/ntp_background_service.cc
    • chrome/browser/search/local_ntp_source.cc
    • chrome/test/data/local_ntp/local_ntp_browsertest.html
  30. Roll src/third_party/skia 56a426a516d0..5551a94b9e0f (15 commits)

    Changed by skia-chromium-autoroll - skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:12:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 521effcf577f74a61bd5d6a35074ed2e3d20abd0

    Comments

    Roll src/third_party/skia 56a426a516d0..5551a94b9e0f (15 commits)
    
    https://skia.googlesource.com/skia.git/+log/56a426a516d0..5551a94b9e0f
    
    
    git log 56a426a516d0..5551a94b9e0f --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 mtklein@chromium.org update color management for color shaders
    2018-07-12 brianosman@google.com Update SRGBReadWritePixelsTest again, to only test opaque colors
    2018-07-12 fmalita@chromium.org PathKit/WASM tweaks
    2018-07-12 mtklein@chromium.org update mode color filter color management
    2018-07-12 mtklein@chromium.org remove unused parts of SkModeColorFilter
    2018-07-12 ziadb@google.com Java-only version of SkAR: drawing on android Canvas
    2018-07-12 brianosman@google.com Remove SK_LEGACY_GPU_PIXEL_OPS tests
    2018-07-12 egdaniel@google.com Generate GrVkInterface when we make the GrVkGpu.
    2018-07-12 reed@google.com remove unneeded scale from procs
    2018-07-12 brianosman@google.com In RGBA444TextureTest, use valid premul colors
    2018-07-12 borenet@google.com Roll Chromium manually to last successful CommandBuffer run
    2018-07-12 mtklein@chromium.org fix color management of CPU drawVertices()
    2018-07-12 caryclark@skia.org remove more references to draw filter
    2018-07-12 bsalomon@google.com remove debug gl interface, grcontextfactory context type, and config.
    2018-07-12 benjaminwagner@google.com Upgrade Skolo Mac bots to 10.13.6.
    
    
    Created with:
      gclient setdep -r src/third_party/skia@5551a94b9e0f
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: I31983fe5eb6e60f68f6b46ed52741dd82999eb78
    Reviewed-on: https://chromium-review.googlesource.com/1135209
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574665}

    Changed files

    • DEPS
  31. DevTools: clicking clear on input should focus

    Changed by Erik Luo - luoeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:11:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cdc1f3d342363df455d02fde8bc04d44f5331e5e

    Comments

    DevTools: clicking clear on input should focus
    
    The act of clicking the 'x' clear button blurs focus. This CL ensures
    the input focuses afterwards.
    
    Bug: 831059
    Change-Id: I848296c0981873cd878f5aaaead9654809811349
    Reviewed-on: https://chromium-review.googlesource.com/1134577
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Commit-Queue: Erik Luo <luoe@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574664}

    Changed files

    • third_party/blink/renderer/devtools/front_end/ui/Toolbar.js
  32. AW: trace events for WindowAndroid verification issues

    Changed by Nate Fischer - ntfschrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:10:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f50fc4d425345286e65488344fd85981bef36c94

    Comments

    AW: trace events for WindowAndroid verification issues
    
    No change to logic.
    
    This adds trace events inside AwContents to track WindowAndroid-related
    class verification errors. Specifically, this should illustrate the
    following verification errors:
    
     * WindowAndroid verification errors should cause activityFromContext to
       take longer than necessary.
     * ActivityWindowAndroid fails verification (because its superclass
       WindowAndroid fails verification), causing its constructor to take
       longer than necessary.
    
    R=torne@chromium.org
    
    Bug: 855796
    Test: tools/perf/run_benchmark system_health.webview_startup --browser android-webview-google
    Change-Id: I6633496fd672300216dfa6425910d19a7ae9e3da
    Reviewed-on: https://chromium-review.googlesource.com/1132479
    Reviewed-by: Richard Coles <torne@chromium.org>
    Commit-Queue: Nate Fischer <ntfschr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574663}

    Changed files

    • android_webview/java/src/org/chromium/android_webview/AwContents.java
  33. Fix VR watchlist

    Changed by Michael Thiessen - mthiesseohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:10:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a7bec5b1769172d3b2722182969d5c1ed618bc42

    Comments

    Fix VR watchlist
    
    Broken in https://chromium-review.googlesource.com/c/chromium/src/+/1134091/9/WATCHLISTS.
    
    Change-Id: Id84c46bb2f52d397975e1c3797a182b2becf9c07
    Reviewed-on: https://chromium-review.googlesource.com/1135115
    Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
    Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574662}

    Changed files

    • WATCHLISTS