Builder Mac Builder (dbg)
Build 154771
Results:
Success
Trigger Info:
| Project | chromium |
| Revision | 89c17cb893bce1d65be7df37fa9b996a144c7204 |
| Got Revision | 89c17cb893bce1d65be7df37fa9b996a144c7204 |
Execution:
- Source: Task 42956694290bff10
- Bot: vm35-m9
- Recipe: chromium
Steps and Logfiles:
Show:-
- - no logs -
-
( 1 secs ) read test spec (chromium.mac.json)path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.mac.json
-
( 725 ms ) lookup GN argsffmpeg_branding = "Chrome"is_component_build = trueis_debug = trueproprietary_codecs = truestrip_absolute_paths_from_debug_symbols = truesymbol_level = 1use_goma = truegoma_dir = "/b/s/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
Build Properties:
| Name | Value | Source |
|---|---|---|
| $recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
| $recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
| bot_id | "vm35-m9" | setup_build |
| branch | "refs/heads/master" | setup_build |
| buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548278368431156, "id": "8923506177501851984", "project": "chromium", "tags": ["builder:Mac Builder (dbg)", "buildset:commit/git/89c17cb893bce1d65be7df37fa9b996a144c7204", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/89c17cb893bce1d65be7df37fa9b996a144c7204", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9088936239675267456", "scheduler_job_id:chromium/Mac Builder (dbg)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
| buildername | "Mac Builder (dbg)" | setup_build |
| buildnumber | 154771 | setup_build |
| mastername | "chromium.mac" | setup_build |
| path_config | "generic" | setup_build |
| recipe | "chromium" | setup_build |
| repository | "https://chromium.googlesource.com/chromium/src.git" | setup_build |
| revision | "89c17cb893bce1d65be7df37fa9b996a144c7204" | setup_build |
| got_angle_revision | "47ca1b2fa3990e51a2ced20f7a7d3589a5477ad1" | bot_update |
| got_buildtools_revision | "2f02e1f363b1af2715536f38e239853f04ec1497" | bot_update |
| got_dawn_revision | "c0f31e73e481f32d308cb6232e75e6d860d97063" | bot_update |
| got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
| got_revision | "89c17cb893bce1d65be7df37fa9b996a144c7204" | bot_update |
| got_revision_cp | "refs/heads/master@{#625354}" | bot_update |
| got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
| got_v8_revision | "9df9418edf64d6a080ba569ef43cd5ca0171a820" | bot_update |
| got_v8_revision_cp | "refs/heads/7.3.492@{#2}" | bot_update |
| got_webrtc_revision | "b0397d69a93a909fc0b29ffdb9236bab1e1b2db7" | bot_update |
| got_webrtc_revision_cp | "refs/heads/master@{#26368}" | bot_update |
| got_clang_revision | "351477-1" | clang_revision |
| isolate_server | "https://isolateserver.appspot.com" | isolate tests |
| swarm_hashes_refs/heads/master(at){#625354}_without_patch | {"accessibility_unittests": "6dc60aa3a1993552ed6219adbb1fecec0e68923a", "angle_unittests": "fdbd79fcf8b155b7c38767ad7ce329f46c520c96", "app_shell_unittests": "c71450b72f22fa9d5a7d996af88e88a62709475e", "base_unittests": "4513ed4865f203d920e439e0ca4b51577147b3e9", "blink_common_unittests": "b3f6af71f5788bec337405b7f63a79e33db109a0", "blink_fuzzer_unittests": "13cdd8a4e4f7f6653aec5b8573ec76fc352c4475", "blink_heap_unittests": "81ef1a4b60a1201e217e6a05e0af0fc09ff8d6d9", "blink_platform_unittests": "8c50ba92baafed40bad74364d438b6f2d3be154e", "boringssl_crypto_tests": "22558577ad9ab1df59892ee4edc24371ea522189", "boringssl_ssl_tests": "0cb7eef2e3ebf63f3ad9b992839147c8404051b3", "browser_tests": "9d21667db9e25d752e852389cd234c14acd397bb", "cacheinvalidation_unittests": "f4b357d728fdf8409e53a2117580fa91ecd236f3", "capture_unittests": "68977edadbd17b22ebb14a4259a914a1d187b383", "cast_unittests": "c13b7ae708187c6cc2c05662da7bfe3d1dbe1a4c", "cc_unittests": "9daf9dd05bba8b43a4db60a7d8720bf7e4e4f13a", "chrome_app_unittests": "e86c54fc04ea9a27e1b3716e3bb7c3ddc4d9df96", "chromedriver_unittests": "ce9d2a36bfdeb5caa11b406da0c43657954c0b40", "components_browsertests": "ef3b2d5cd2505cbbe3171f9e0f03790563ff7e2f", "components_unittests": "4f2f17db8b182c05d8959ca5122a2273ea8fbc79", "content_browsertests": "6e63735ecf04dba6d6103f878f5a08aeda3cf15a", "content_shell_crash_test": "1bc3683b870745795a70e56e199ecac80bc6acc9", "content_unittests": "dca9cae19ba48a1e379ed40ebd28f24533420c97", "crashpad_tests": "2983d9bf122d3b902dcd7ece71ef10ce9b4ce661", "cronet_tests": "6daeb540531e0038a404e93efe6f2a1bdbf6378c", "cronet_unittests": "1cb870dd106f53c0cbfd7509ae12af06aefd589a", "crypto_unittests": "0a824022064d5902786cd52bb96c4e41b36a8b2a", "device_unittests": "1fc9e14eaaf517f7fe9862e3e5da3c7193f6a173", "display_unittests": "772bbe33bcbc2eed12618c1639d31bf48550e06c", "events_unittests": "b3bf6e0b2b7ea8433c8308cdb265ac83fd096913", "extensions_browsertests": "7df953f6f58e4df23ecdec335d0b5b6df1da6b3f", "extensions_unittests": "993b438acf39f66e9c2afefd077d65839ced233b", "filesystem_service_unittests": "2516f5628ffb6ea527e89d2cca8a41c8af9cf3d6", "gcm_unit_tests": "d81f8d39415584a0acf4617cb22a0d4d8c1007e4", "gfx_unittests": "f0c497efbb22c161c6fa7f0c1ccc692a3a0848f9", "gin_unittests": "0f17416036de6ccc49192f29ae7975adedc318dd", "google_apis_unittests": "50ff16493d65927e5f56a3abb37498f352cb8174", "gpu_unittests": "ecff2ffee7f48a7d499a3d6b84d074fd63323064", "headless_browsertests": "f40254d339d3110cd088a732011920c7c5c0bd4d", "headless_unittests": "3e6ddf7b018e894c78c692e7160a25b26531520b", "interactive_ui_tests": "1b809887988b7abc307ba61eaf0a5441d367bb6a", "ipc_tests": "c841d75ee35bcd83683e143d7990a21b74788a58", "jingle_unittests": "b8796f030afe4cd981440ad621220b8513b3d1f6", "latency_unittests": "c36d3f2ddf99d8519960c2fe616ad0412d0c7417", "leveldb_service_unittests": "4aa009b4763225302dfab9c143ad62c79468001d", "libjingle_xmpp_unittests": "ee3bff84eb2f047e7e064d7371dc03a5708f2e40", "media_blink_unittests": "b1112736aa7f97e35d30a945a2f52a899f1b6670", "media_service_unittests": "ca07f206d708deccdd7625d19b9a63048f6f21f6", "media_unittests": "e8db6244b35baf73a9eb7a58a6165ddb2d154095", "message_center_unittests": "4a904e075ce6a6aa2a4e2e8cafbcc1569fd1039f", "metrics_python_tests": "4e7c5f23da86323e8cad496feebfa234145a46ab", "midi_unittests": "11ce76f50dfc3c1dcdc965ea9ce6ed464f2d1eb6", "mojo_unittests": "75dcda45654270199430d9390457ea1b5af6aa98", "nacl_loader_unittests": "a1956aeae534301ab00265b82f909896b9122d8f", "native_theme_unittests": "7d3a89761a4a8b72c2c99841d3b4aa2b990ee094", "net_unittests": "28a4fd963f7e29675b3a65a0a244fb5169e4e418", "pdf_unittests": "c7183a1d8f4133ffd4ee2736a24c7dbff345a87a", "performance_test_suite": "199a0e1b741e6d5b9b1571e9c3207b7fc9fe05ea", "ppapi_unittests": "e966028eae64ac5bd9a864e0f926c05e2af71863", "printing_unittests": "afe002d127536e05836b1a84b8a90c1b4bc3d37c", "remoting_unittests": "1e6b1f0b1f2cacf93c660d830dd9faf362a1fef0", "sandbox_mac_unittests": "d9fb63342b45256140d59c17846f574ee785be62", "service_manager_unittests": "f7af92c3b053879cd4625c51e1df9532cb8aa099", "services_unittests": "f47c7f33bfac9132871e6068ca32303bc4ee4464", "shell_dialogs_unittests": "271d44159985f2d81bcdbe2c79d02978470a2cc1", "skia_unittests": "2bae57a59b4aa0a63a3af27f5c2ff3cd977bd474", "snapshot_unittests": "208369aa5b2ad2df60022a8b7b4e0b1970cf1542", "sql_unittests": "ea66364289e202d82b9426ba7787a73fb87f9e4c", "storage_unittests": "5aa346617952f5dd79e6e5d1d379b07f041daec4", "sync_integration_tests": "584d2c5d25e396d7b900dc96bacb466aaab2d7d7", "telemetry_gpu_unittests": "525f9dbfed50ac1a8d4690266175cfb6d94e40a7", "telemetry_unittests": "9e81476b81d1d9d3a84643d54a0681afed47e10b", "ui_base_unittests": "8f61e708ecf46f29dcdb04c6186f089b78d57e94", "ui_touch_selection_unittests": "411d4be617dd6e6abc2ccd709b78414f257e8a26", "unit_tests": "5872a3441a4fc6654005042863b8c12113d29be5", "url_unittests": "625be815584a6213af3a33abcdf8d1117721befd", "views_perftests": "b94a6a015a93596ea71bdbb8c280fb6349ebbcb6", "views_unittests": "e76348923ea137effc81a8b96b21dda2b61cf922", "viz_unittests": "bc67a7d0b7cd6d843241feac708b3e8596f11071", "webkit_layout_tests_exparchive": "13fe2f3fdb6886916e1da08196bc7d213fa9a5ce", "webkit_python_tests": "5a37aec44b7ea3c2ad8171c25e5b5476fa46ecbc", "webkit_unit_tests": "f739ad1ef9552a079f72b16eda083232a102b05f", "wtf_unittests": "f967612697797f53628adb6d400d3fb36b289b86"} | isolate tests |
Blamelist:
- Paul Meyer (paulmeyerohnoyoudont@chromium.org)
- Brian White (bcwhiteohnoyoudont@chromium.org)
- Jered Gray (jegrayohnoyoudont@google.com)
- Xiaohui Chen (xiaohuicohnoyoudont@google.com)
- Caleb Raitto (caraittoohnoyoudont@chromium.org)
- Luke Sorenson (lasorenohnoyoudont@chromium.org)
- Khushal (khushalsagarohnoyoudont@chromium.org)
- chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
- Jimmy Gong (jimmyxgongohnoyoudont@google.com)
- Jonathan Backer (backerohnoyoudont@chromium.org)
- Joshua Bell (jsbellohnoyoudont@chromium.org)
- Jacob Dufault (jdufaultohnoyoudont@google.com)
- Robert Ogden (robertogdenohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Jamie Madill (jmadillohnoyoudont@chromium.org)
- Parastoo Geranmayeh (parastoogohnoyoudont@google.com)
- Mounir Lamouri (mlamouriohnoyoudont@chromium.org)
- Eric Orth (ericorthohnoyoudont@chromium.org)
- Becca Hughes (beccahughesohnoyoudont@chromium.org)
- Xianda Sun (sunxdohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Peter Beverloo (peterohnoyoudont@chromium.org)
- Wez (wezohnoyoudont@chromium.org)
- Robert Liao (robliaoohnoyoudont@chromium.org)
- Dan Beam (dbeamohnoyoudont@chromium.org)
- Robert Sesek (rsesekohnoyoudont@chromium.org)
- Weiliang Chen (weiliangcohnoyoudont@chromium.org)
- Nicolas Pena (npmohnoyoudont@chromium.org)
- Christopher Cameron (ccameronohnoyoudont@chromium.org)
- Gary Kacmarcik (garykacohnoyoudont@chromium.org)
- Scott Violet (skyohnoyoudont@chromium.org)
- Xiao Yang (yanxiaoohnoyoudont@google.com)
- Anastasia Helfinstein (anastasiohnoyoudont@google.com)
- Peter Beverloo (peterohnoyoudont@chromium.org)
- Luke Halliwell (halliwellohnoyoudont@chromium.org)
- Pavol Marko (pmarkoohnoyoudont@chromium.org)
Timing:
| Create | Wednesday, 23-Jan-19 21:19:28 UTC |
| Start | Wednesday, 23-Jan-19 21:19:31 UTC |
| End | Wednesday, 23-Jan-19 22:14:25 UTC |
| Pending | 2 secs |
| Execution | 54 mins 53 secs |
All Changes:
-
Remove commented out code in feature_policy_test.cc.
Changed by Paul Meyer - paulmeyerohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:17:27 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 89c17cb893bce1d65be7df37fa9b996a144c7204 Comments
Remove commented out code in feature_policy_test.cc. TBR: iclelland@chromium.org Change-Id: I70b78d5d9191ad554363ce26c76ba62469900de6 Reviewed-on: https://chromium-review.googlesource.com/c/1431013 Reviewed-by: Paul Meyer <paulmeyer@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#625354}
Changed files
- third_party/blink/renderer/core/feature_policy/feature_policy_test.cc
-
Support 'never' as expiry date.
Changed by Brian White - bcwhiteohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:17:09 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8ad971db6d8a8a92b59718fd5b1974017ab141f2 Comments
Support 'never' as expiry date. Bug: 923083 Change-Id: I25136857b84832ac896e76f32c182af8eb190e15 Reviewed-on: https://chromium-review.googlesource.com/c/1418517 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#625353}
Changed files
- tools/metrics/histograms/extract_histograms.py
- tools/metrics/histograms/generate_expired_histograms_array.py
-
Reland "Fix flakiness in previews browsertests"
Changed by Jered Gray - jegrayohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 21:16:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 88574aa1a3aed9924caec756938a6a307e4a006a Comments
Reland "Fix flakiness in previews browsertests" This reverts commit de34f0bdf289e3b788f7a09be8ae97c45d1e9832. Reason for revert: Fixed additional flakiness Original change's description: > Revert "Fix flakiness in previews browsertests" > > This reverts commit ddd4f721f82a2b4065d214eee99e9fe28199ee15. > > Reason for revert: Looks like some tests become flaky (or even flakier?) > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10417 > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10418 > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10419 > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/31176 > > Original change's description: > > Fix flakiness in previews browsertests > > > > The previous logic relied upon the hints requested by the store upon a > > navigation to a url being loaded prior to the commit. This was not > > guaranteed to happen when cores were not available on a machine for > > background threads. > > > > The HintCache has been modified so that it now runs the hint loaded > > callback even in the case where no hints are available for the host. > > > > Additionally, a histogram has been added that tracks the loading of > > hints from the hint cache store has in PreviewsOptimizationGuide. The > > tests now run a priming navigation that waits for the hints to be > > loaded. This ensures that the hints are guaranteed to be available > > during the tests. > > > > Bug: 923161 > > Change-Id: I8b09dfc9391164f0a6d424ec0a8ea871334c4c8c > > Reviewed-on: https://chromium-review.googlesource.com/c/1423617 > > Commit-Queue: Jered Gray <jegray@chromium.org> > > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > > Reviewed-by: Doug Arnett <dougarnett@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#625056} Change-Id: I675f7a0b3eb79d468100af8775310bb64531b069 Reviewed-on: https://chromium-review.googlesource.com/c/1431019 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Doug Arnett <dougarnett@chromium.org> Commit-Queue: Jered Gray <jegray@chromium.org> Cr-Commit-Position: refs/heads/master@{#625352}
Changed files
- chrome/browser/previews/previews_browsertest.cc
- chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc
- components/previews/content/hint_cache.cc
- components/previews/content/hint_cache.h
- components/previews/content/previews_optimization_guide.cc
- components/previews/core/previews_constants.cc
- components/previews/core/previews_constants.h
-
assistant: turn on voice match
Changed by Xiaohui Chen - xiaohuicohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 21:15:48 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6447cd5b54e34c1c05c272f64004612d02d4f51b Comments
assistant: turn on voice match Bug: 120666177 Test: locally build and see voice model retraining works. Change-Id: Ieaff9f11cb1e879a65064001d5455b6f2d325f22 Reviewed-on: https://chromium-review.googlesource.com/c/1423659 Reviewed-by: Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#625351}
Changed files
- chromeos/services/assistant/public/features.cc
-
[Cronet] Add const and thread annotations to native UrlRequest.
Changed by Caleb Raitto - caraittoohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:09:55 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8d83ac63b851d0606440602fdb75535d5c145904 Comments
[Cronet] Add const and thread annotations to native UrlRequest. Change-Id: Ia56988f41bf11d74be67f0e7876b22c48a6c34d0 Reviewed-on: https://chromium-review.googlesource.com/c/1423619 Reviewed-by: Paul Jensen <pauljensen@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#625350}
Changed files
- components/cronet/native/url_request.cc
- components/cronet/native/url_request.h
-
Update rtanalytics-* component min env versions for M73.
Changed by Luke Sorenson - lasorenohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:09:31 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f8f18c62d1b04a6035838c93317754bcc86e344f Comments
Update rtanalytics-* component min env versions for M73. Bug: 924649 Change-Id: I5cf3bc128b5aeafa4dbb2c2ae3df690086a19c26 Reviewed-on: https://chromium-review.googlesource.com/c/1431672 Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#625349}
Changed files
- chrome/browser/component_updater/cros_component_installer_chromeos.cc
-
content: Disable SurfaceControl if AImageReader is disabled.
Changed by Khushal - khushalsagarohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 21:04:49 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision adcfe85f993f331aa98d1a1442441069f01cb8ba Comments
content: Disable SurfaceControl if AImageReader is disabled. SurfaceControl requires AImageReader to support video overlays. Disable it if AImageReader is disabled. R=piman@chromium.org Bug: 889328 Change-Id: I624f88b3759ce79eff296f75d82ac5a71616837d Reviewed-on: https://chromium-review.googlesource.com/c/1431232 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#625348}
Changed files
- content/public/browser/gpu_utils.cc
-
Roll src-internal d1737fb0576a..6aa6bc44417e (3 commits)
Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com Changed at Wednesday, 23-Jan-19 20:58:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 04b82ad690897e83605382572d0d8abe49683bae Comments
Roll src-internal d1737fb0576a..6aa6bc44417e (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d1737fb0576a..6aa6bc44417e Created with: gclient setdep -r src-internal@6aa6bc44417e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:885350 TBR=mmoss@chromium.org Change-Id: If97db92ce6bd622089d2c08a0ac845d9f7fa5515 Reviewed-on: https://chromium-review.googlesource.com/c/1431253 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625347}
Changed files
- DEPS
-
Add premount mode for NetworkFileSharesPreconfiguredShares
Changed by Jimmy Gong - jimmyxgongohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 20:57:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d7da0526a68bfba9e9d02be8f4922458185f7acb Comments
Add premount mode for NetworkFileSharesPreconfiguredShares - The "premount" mode lets preconfigured shares to be preemtively mounted upon start up of SMB file sharing. Bug: chromium=878502 Test: compiles + PolicyPrefTest unittest Change-Id: I3d53b33bb4687217b537b45d1562c4e4ed1b31b6 Reviewed-on: https://chromium-review.googlesource.com/c/1407655 Reviewed-by: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#625346}
Changed files
- chrome/test/data/policy/policy_test_cases.json
- components/policy/resources/policy_templates.json
-
Use GrShaderCache with SkiaRenderer
Changed by Jonathan Backer - backerohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:52:17 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 41d805f72249d2a5fbcf13de8dbdc1bb73745117 Comments
Use GrShaderCache with SkiaRenderer We should use GrShaderCache with SkiaRenderer, even if not using OOP-R. Change-Id: I096cbde69328efb1608232d3685a871c762d13ac Reviewed-on: https://chromium-review.googlesource.com/c/1431020 Auto-Submit: Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#625345}
Changed files
- gpu/ipc/service/gpu_channel_manager.cc
-
Browsing Data: Add README.md to explain what "canned" data is
Changed by Joshua Bell - jsbellohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:49:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5e5f22d67f34885bddda9249e22f220eca99af29 Comments
Browsing Data: Add README.md to explain what "canned" data is I can never remember what role the CannedBrowsingDataXYZHelper classes serve when someone asks, so documenting it for posterity. TBR=dullweber@chromium.org,mxcai@chromium.org NOTRY=true Change-Id: Id5853e0baccc2dd1b3649a6398cb3e86e1c1f5a1 Reviewed-on: https://chromium-review.googlesource.com/c/1431234 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#625344}
Changed files
- chrome/browser/browsing_data/README.md
-
cros: Eliminate CallJSWithPrefix
Changed by Jacob Dufault - jdufaultohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 20:47:30 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 06f705e55e1b9cd5a65bdadc4f47c922618b1d3a Comments
cros: Eliminate CallJSWithPrefix Bug: 908498 Change-Id: I5c3e0376e94f18808041db0371411ae6ec168eb2 Reviewed-on: https://chromium-review.googlesource.com/c/1352355 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#625343}
Changed files
- chrome/browser/ui/webui/chromeos/login/base_webui_handler.cc
- chrome/browser/ui/webui/chromeos/login/base_webui_handler.h
- chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc
-
Add Lite mode strings for Data Saver rebranding
Changed by Robert Ogden - robertogdenohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:46:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9efff00b89781d9a722262c995f5cf6a928a5d0b Comments
Add Lite mode strings for Data Saver rebranding Data Saver is being rebranded to Lite mode. However, we'd like to programatically roll this out via Finch in M73. We expect that this will require some merges. I'm landing this CL now so that the strings that will be used can be translated and will be available at branch. This CL is based off of https://chromium-review.googlesource.com/c/1354346 In a few places where only the description of the string was changed in that CL, the change was omitted here so that we don't need a whole other string. When Lite mode is launched, I'll come back and clean those up. All new strings are suffixed with _lite_mode, based on their Data Saver counterparts. Bug: 909915 Binary-Size: Increase is due to translations and so cannot be avoided. Change-Id: Ie3511d952c301290de8c404f4677d610767f9355 Reviewed-on: https://chromium-review.googlesource.com/c/1429499 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#625342}
Changed files
- build/android/lint/suppressions.xml
- chrome/android/java/strings/android_chrome_strings.grd
- chrome/app/chromeos_strings.grdp
- chrome/app/generated_resources.grd
-
Roll src/third_party/SPIRV-Tools/src 3d7102424810..b1be6763f6f3 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 23-Jan-19 20:45:53 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 452cd96d9ba30053bcc3e6279e6f69792dde2084 Comments
Roll src/third_party/SPIRV-Tools/src 3d7102424810..b1be6763f6f3 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3d7102424810..b1be6763f6f3 git log 3d7102424810..b1be6763f6f3 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 zoddicus@users.noreply.github.com Add helper for 'is Vulkan or WebGPU' (#2324) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@b1be6763f6f3 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic9ddcadfcb345088ea44a8dea26264635dc3788d Reviewed-on: https://chromium-review.googlesource.com/c/1431255 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625341}
Changed files
- DEPS
-
Add ANGLE build overrides.
Changed by Jamie Madill - jmadillohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:44:32 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 27e844933cdcd563923c0eda3b3a8df3b1866bbe Comments
Add ANGLE build overrides. This will allow ANGLE to use Chromium repos for third_party deps. Bug: angleproject:3088 Change-Id: I0d8d4c53df780d59fdc97813fb468d0960b18def Reviewed-on: https://chromium-review.googlesource.com/c/1424397 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#625340}
Changed files
- build_overrides/angle.gni
-
[AF] Reload from database to sort profiles
Changed by Parastoo Geranmayeh - parastoogohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 20:43:27 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d8175e6fa720ce1b442e1d88f78493941aa42fdd Comments
[AF] Reload from database to sort profiles Profiles are sorted in the DB and not in the Personal Data Manager, therefore, we need to reload them when the changes are done. => Call Refresh() each times there is no more change in the waiting in the scheduling queue. Bug: 920529 Change-Id: I7bc4337b881bac67185ed9ec279857fa6b207da4 Reviewed-on: https://chromium-review.googlesource.com/c/1406178 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#625339}
Changed files
- chrome/browser/sync/test/integration/autofill_helper.cc
- chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
- chrome/browser/ui/views/payments/payment_request_browsertest_base.h
- chrome/browser/ui/views/payments/payment_request_use_stats_browsertest.cc
- components/autofill/core/browser/autofill_profile.cc
- components/autofill/core/browser/autofill_profile.h
- components/autofill/core/browser/form_data_importer_unittest.cc
- components/autofill/core/browser/personal_data_manager.cc
- components/autofill/core/browser/personal_data_manager.h
- components/autofill/core/browser/personal_data_manager_unittest.cc
-
Remove self from one watchlist.
Changed by Mounir Lamouri - mlamouriohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:40:48 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 578ca4009263ce0ff859751e73fac85091db06fe Comments
Remove self from one watchlist. Bug: none Change-Id: I52f415f00624a3d160be1212d9317dffac113869 TBR: mlamouri@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1431535 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#625338}
Changed files
- WATCHLISTS
-
Service API for HostResolver MDNS listener
Changed by Eric Orth - ericorthohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:40:20 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 73db5a5ea91aa0fa2724ec27e8cfcb8bf5e24e43 Comments
Service API for HostResolver MDNS listener Bug: 922161 Change-Id: I33ba427d5449a0e93d36bdd9078d8a9b59b90422 Reviewed-on: https://chromium-review.googlesource.com/c/1413057 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#625337}
Changed files
- services/network/BUILD.gn
- services/network/host_resolver.cc
- services/network/host_resolver.h
- services/network/host_resolver_mdns_listener.cc
- services/network/host_resolver_mdns_listener.h
- services/network/host_resolver_unittest.cc
- services/network/public/cpp/host_resolver.typemap
- services/network/public/cpp/host_resolver_mojom_traits.cc
- services/network/public/cpp/host_resolver_mojom_traits.h
- services/network/public/mojom/host_resolver.mojom
-
Enable hardware key handling on CrOS
Changed by Becca Hughes - beccahughesohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:36:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 35f60266b2b744148f80bba2b7773646aa6d93b4 Comments
Enable hardware key handling on CrOS Enable hardware key handling on CrOS for launch in M73. Also fixes a type for kInternalMediaSession flag. BUG=891401 Change-Id: Ic79a2cb889b5f633ef971f62d67aaaf52b54d715 Reviewed-on: https://chromium-review.googlesource.com/c/1423131 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#625336}
Changed files
- media/base/media_switches.cc
-
Make Layer::ShouldHitTest respect SetHideLayerAndSubtree
Changed by Xianda Sun - sunxdohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:29:48 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 052ae71abd82e18f19f79138c7b5f9e7e5fc9625 Comments
Make Layer::ShouldHitTest respect SetHideLayerAndSubtree Ui::Layers call SetHideLayerAndSubtree when they become visible or hidden. But a cc::Layer with hide_layer_and_subtree = true still draws its content and is considered hit-testable, though not displayed on the screen. This patch makes cc hit testing respect hide_layer_and_subtree and do not hit test a layer if it's drawn but not displayed on screen. Bug: 901882 Change-Id: I18c9511c18628067dbcb471cd8dfe43a1e3c6426 Reviewed-on: https://chromium-review.googlesource.com/c/1413393 Reviewed-by: weiliangc <weiliangc@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#625335}
Changed files
- cc/layers/layer_impl.cc
- cc/layers/layer_impl.h
- cc/layers/layer_unittest.cc
- cc/trees/layer_tree_host_impl.cc
- cc/trees/layer_tree_impl.cc
- cc/trees/property_tree.cc
- cc/trees/property_tree.h
-
Roll src/third_party/perfetto db9cda8acc38..a824c339c217 (3 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 23-Jan-19 20:27:22 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision bf764290063665ea0a0e92913826e05fda44fc79 Comments
Roll src/third_party/perfetto db9cda8acc38..a824c339c217 (3 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/db9cda8acc38..a824c339c217 git log db9cda8acc38..a824c339c217 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 lalitm@google.com trace_processor: add mm_event ingestion in trace processor 2019-01-23 lalitm@google.com trace_processor: don't parse sched_switch into raw or ingest args 2019-01-23 fmayer@google.com Merge "Do not require root for heap profiling script." Created with: gclient setdep -r src/third_party/perfetto@a824c339c217 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:118897434,chromium:123252504 TBR=perfetto-bugs@google.com Change-Id: I9b853ce07a6e7ba2165e7ed8eaaec46ac7838fd1 Reviewed-on: https://chromium-review.googlesource.com/c/1431092 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625334}
Changed files
- DEPS
-
Require a user gesture for the Contact API
Changed by Peter Beverloo - peterohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:23:35 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5d7baf4f6b08380783faae0f39dc7a44ab8290e7 Comments
Require a user gesture for the Contact API Also provide a series of new tests to cover the implementation, particularly this requirement. Bug: 860467 Change-Id: I274e433fadba5228ac5dc0853b5a30354904d43e Reviewed-on: https://chromium-review.googlesource.com/c/1430014 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#625333}
Changed files
- third_party/blink/renderer/modules/contacts_picker/contacts_manager.cc
- third_party/blink/web_tests/http/tests/contacts/idl-NavigatorContacts.html
- third_party/blink/web_tests/http/tests/contacts/select-function.html
-
[Fuchsia] Remove some unnecessary defined(OS_FUCHSIA) conditionals.
Changed by Wez - wezohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:23:06 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6957c9a71253ecd18cf4791714bc34fcae592367 Comments
[Fuchsia] Remove some unnecessary defined(OS_FUCHSIA) conditionals. Bug: 854721 Change-Id: I0bbad92f6698db479518f268d0ae797a0a3d2d81 Reviewed-on: https://chromium-review.googlesource.com/c/1424598 Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Albert J. Wong <ajwong@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#625332}
Changed files
- base/allocator/partition_allocator/partition_alloc_unittest.cc
- mojo/core/broker_host.cc
- mojo/core/broker_posix.cc
-
Wire Up Windows Dark Mode to NativeThemeWin
Changed by Robert Liao - robliaoohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:20:50 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 63e92830db63d5b7d03c245dda083cb4e7f33ea8 Comments
Wire Up Windows Dark Mode to NativeThemeWin The Dark/Light mode toggle in System Settings appears to be intended for UWP apps, so this change needs to be slightly more creative about checking this state. This change checks and monitors AppsUseLightTheme in HKCU's theme area, which is not an API guarantee. Future versions of Windows could change the way this is persisted and subsequently break this change. BUG=838670 Change-Id: Ic84341ae69e2bb9cd988f9bea027052033c66360 Reviewed-on: https://chromium-review.googlesource.com/c/1429963 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#625331}
Changed files
- ui/native_theme/native_theme_win.cc
- ui/native_theme/native_theme_win.h
-
WebUI Dark Mode: update paper-tabs selection and label colors
Changed by Dan Beam - dbeamohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:18:20 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 08832e65279677ca77b8e187bd7faf938dd22954 Comments
WebUI Dark Mode: update paper-tabs selection and label colors R=dpapad@chromium.org BUG=883049 Change-Id: Ia9977c7eada06142181b2f4bc331c269ba88aeef Reviewed-on: https://chromium-review.googlesource.com/c/1429664 Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#625330}
Changed files
- ui/webui/resources/cr_elements/paper_tabs_style_css.html
-
Reland "Mac: Record via metrics the number of open FDs and the soft FD limit."
Changed by Robert Sesek - rsesekohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:16:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3aff3364f597ac6b4b32aae9b140b09153da649b Comments
Reland "Mac: Record via metrics the number of open FDs and the soft FD limit." This is a reland of a72c20e443285e06e064e67ec754d4f60d4e6d22 Fixes ProcessMetricsTest.GetChildOpenFdCount to not close guarded FDs on macOS 10.10 and 10.11. Original change's description: > Mac: Record via metrics the number of open FDs and the soft FD limit. > > The histograms already exist on Linux, CrOS, and Android, so this simply > wires up the values for macOS. > > In addition, this enables the FD count column in the Task Manager, since > the data are now readily available. > > Bug: 714614 > Change-Id: I05f8063e8d89d3c6cdc68062bf4e591d3af9559c > Reviewed-on: https://chromium-review.googlesource.com/c/1423339 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624881} Tbr: thakis@chromium.org Bug: 714614 Change-Id: Icc79aa88826e9079845f06ed6c3f52139713b404 Reviewed-on: https://chromium-review.googlesource.com/c/1430719 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#625329}
Changed files
- base/process/process_metrics.h
- base/process/process_metrics_mac.cc
- base/process/process_metrics_unittest.cc
- chrome/browser/memory_details_mac.cc
- chrome/browser/task_manager/sampling/task_group.cc
- chrome/browser/task_manager/sampling/task_group.h
- chrome/browser/task_manager/sampling/task_group_sampler.cc
- chrome/browser/task_manager/sampling/task_group_sampler.h
- chrome/browser/task_manager/sampling/task_manager_impl.cc
- chrome/browser/task_manager/task_manager_observer.h
- chrome/browser/ui/task_manager/task_manager_columns.cc
- chrome/browser/ui/task_manager/task_manager_table_model.cc
-
viz: Extract Root Color Filter from Filter DAT to Improve Performance
Changed by Weiliang Chen - weiliangcohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:15:35 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 43b349f6f508142e8cbd1bfff8f83df07a5946a9 Comments
viz: Extract Root Color Filter from Filter DAT to Improve Performance From the DAG of SkImageFilter, extract the root filter out if it is a color filter, and apply that using SkPaint. Bug: 919885, 823182 Change-Id: Ia248d4390eeeba8a6e6581b2eaa800f7262800a9 Reviewed-on: https://chromium-review.googlesource.com/c/1427572 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#625328}
Changed files
- components/viz/service/display/skia_renderer.cc
-
[ElementTiming] Only notify paint for loaded resources
Changed by Nicolas Pena - npmohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:14:22 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8685c94989998067c92fede617b2f3de42190075 Comments
[ElementTiming] Only notify paint for loaded resources This CL adds a check to ensure that an image is loaded before reporting via the Element Timing API. We want to report the first paint but only after the image is loaded. This matters for images that are progressively rendered. Bug: 879270 Change-Id: Ia0bcc68c1050967560103170be28c40238e839d9 Reviewed-on: https://chromium-review.googlesource.com/c/1415716 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#625327}
Changed files
- third_party/blink/renderer/core/paint/image_painter.cc
- third_party/blink/web_tests/http/tests/performance-timing/element-timing/progressively-loaded-image.html
- third_party/blink/web_tests/http/tests/resources/progressive-image.php
-
Mac PWAs: Fix drag-drop and visibility
Changed by Christopher Cameron - ccameronohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:12:32 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e30928eebe5ee07def107e776927097ab2bb304e Comments
Mac PWAs: Fix drag-drop and visibility Allow the app shim's WebContentsViewCocoa to call back to the browser's WebContentsViewMac via mojo. This fixes window visibility/occlusion and dragging onto web contents (though not dragging from web contents yet). Bug: 898608, 919235 Change-Id: I6b28682b330a234ebe5afb0a6f1d8af821e0c172 Reviewed-on: https://chromium-review.googlesource.com/c/1429760 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#625326}
Changed files
- content/browser/web_contents/web_contents_ns_view_bridge.mm
- content/browser/web_contents/web_contents_view_cocoa.h
- content/browser/web_contents/web_contents_view_cocoa.mm
- content/browser/web_contents/web_contents_view_mac.mm
-
[Chromoting] Fix mouse when single display selected in multi-mon
Changed by Gary Kacmarcik - garykacohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:11:54 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ebe85a812e6971fcc40d081a06ab42f030624963 Comments
[Chromoting] Fix mouse when single display selected in multi-mon Previous code would always translate the mouse coords relative to the upper-left corner of the entire display, instead of relative to the currently selected display. This cl changes the mouse input scaler to be a DesktopRect instead of a DesktopSize because we need to keep track of the origin for proper mouse event scaling. Change-Id: I397c51280187c7a8e023e8a41940b6f37b39eb7f Reviewed-on: https://chromium-review.googlesource.com/c/1429339 Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#625325}
Changed files
- remoting/client/chromoting_client.cc
- remoting/client/plugin/chromoting_instance.cc
- remoting/host/client_session.cc
- remoting/host/client_session.h
- remoting/host/client_session_unittest.cc
- remoting/host/desktop_display_info.cc
- remoting/host/desktop_display_info.h
- remoting/proto/control.proto
- remoting/protocol/mouse_input_filter.cc
- remoting/protocol/mouse_input_filter.h
- remoting/protocol/mouse_input_filter_unittest.cc
-
Call function when LayerTreeHostImpl generates a LocalSurfaceId
Changed by Scott Violet - skyohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:11:20 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7a340f4091c6d1ec256938d3ca9d2d9f6395aacf Comments
Call function when LayerTreeHostImpl generates a LocalSurfaceId This way client code that needs to know when the LocalSurfaceId changes can take action. BUG=922201 TEST=none Change-Id: I5b19a611f673e766757e51301c0e475e5ed5393c Reviewed-on: https://chromium-review.googlesource.com/c/1429623 Reviewed-by: Saman Sami <samans@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#625324}
Changed files
- cc/test/fake_layer_tree_host_impl_client.h
- cc/test/layer_tree_test.cc
- cc/test/stub_layer_tree_host_client.h
- cc/trees/layer_tree_host.cc
- cc/trees/layer_tree_host.h
- cc/trees/layer_tree_host_client.h
- cc/trees/layer_tree_host_impl.cc
- cc/trees/layer_tree_host_impl.h
- cc/trees/layer_tree_host_impl_unittest.cc
- cc/trees/proxy_impl.cc
- cc/trees/proxy_impl.h
- cc/trees/proxy_main.cc
- cc/trees/proxy_main.h
- cc/trees/single_thread_proxy.cc
- cc/trees/single_thread_proxy.h
- content/browser/renderer_host/compositor_impl_android.h
- content/renderer/compositor/layer_tree_view.h
- ui/compositor/compositor.cc
- ui/compositor/compositor.h
- ui/compositor/compositor_observer.h
-
Update Assistant checkbox string on Assistant feedback UI
Changed by Xiao Yang - yanxiaoohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 20:05:40 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 48d8a282b6ff0e545e638fb19098213200ea55f7 Comments
Update Assistant checkbox string on Assistant feedback UI 1. Update the string from "Include Assistant debug information" to "Info to debug Assistant" Bug: b/121269286 Change-Id: I7f3a7f66be0eba7541437a83ed00699527c6ec7f Reviewed-on: https://chromium-review.googlesource.com/c/1427602 Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Xiao Yang <yanxiao@google.com> Cr-Commit-Position: refs/heads/master@{#625323}
Changed files
- chrome/app/generated_resources.grd
- chrome/app/generated_resources_grd/IDS_FEEDBACK_INCLUDE_ASSISTANT_INFORMATION_CHKBOX.png.sha1
-
Update JS code for Switch Access Menu Panel to use ES2016.
Changed by Anastasia Helfinstein - anastasiohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 20:05:19 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 50609a53b17fbd2879bfe3947602d131689b604b Comments
Update JS code for Switch Access Menu Panel to use ES2016. This is a pure refactor, with no change to code behavior. Bug: None Change-Id: Ib864a858b2de4aca6619ad8b002d59d075f94fa1 Reviewed-on: https://chromium-review.googlesource.com/c/1428602 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#625322}
Changed files
- chrome/browser/resources/chromeos/switch_access/menu_panel.js
- chrome/browser/resources/chromeos/switch_access/message_handler.js
-
Align the Contact API with the proposal
Changed by Peter Beverloo - peterohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:04:33 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b19e8afc4339d44d450726cc34c8db710badf5c7 Comments
Align the Contact API with the proposal This implements the following two changes in Blink: https://github.com/beverloo/contact-api/commit/ade45e5 https://github.com/beverloo/contact-api/commit/914261f TBR=haraken@ (moving a file in modules_idl_files.gni) Bug: 860467 Change-Id: I81dde8fdbd06728164a65ea570e7606f97bd9d77 Reviewed-on: https://chromium-review.googlesource.com/c/1430104 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#625321}
Changed files
- third_party/blink/renderer/modules/contacts_picker/BUILD.gn
- third_party/blink/renderer/modules/contacts_picker/contact_info.cc
- third_party/blink/renderer/modules/contacts_picker/contact_info.h
- third_party/blink/renderer/modules/contacts_picker/contact_info.idl
- third_party/blink/renderer/modules/contacts_picker/contacts_manager.cc
- third_party/blink/renderer/modules/contacts_picker/contacts_manager.idl
- third_party/blink/renderer/modules/modules_idl_files.gni
- third_party/blink/web_tests/http/tests/contacts/idl-NavigatorContacts.html
- third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
-
Add seantopping to some chromecast/ owners files
Changed by Luke Halliwell - halliwellohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:04:09 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a50c1914f1668cc5fcef4a8e580eab51a28caaa4 Comments
Add seantopping to some chromecast/ owners files Bug: none Change-Id: I33a08288c678b9a3d6d40eecbf5144b049f97cdf Reviewed-on: https://chromium-review.googlesource.com/c/1428719 Reviewed-by: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#625320}
Changed files
- chromecast/browser/OWNERS
- chromecast/common/OWNERS
- chromecast/renderer/OWNERS
-
Allow better cert principal patterns for AutoSelectCertificateForUrls policy
Changed by Pavol Marko - pmarkoohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 20:03:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b211ab2d528918666b0684d405e2abc642e67766 Comments
Allow better cert principal patterns for AutoSelectCertificateForUrls policy Allow the AutoSelectCertificateForUrls policy to match CommonName (C), Locality (L), Organization (O), OrganizationUnit (OU) of the ISSUER and SUBJECT of certificate candidates. Move the certificate principal matching code used for ONC network policies from //chromeos/network code to //components/certificate_matching and reuse it for the AutoSelectCertificateForUrls policy and for the existing ONC certificate matching. Bug: 905994 Test: unit tests and browser tests Change-Id: I12ba650741bcfa1a6c35e73443421fdf8fe2e38f Reviewed-on: https://chromium-review.googlesource.com/c/1405011 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by: Cait Phillips <caitkp@chromium.org> Reviewed-by: Alexander Hendrich <hendrich@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#625319}
Changed files
- chrome/browser/BUILD.gn
- chrome/browser/chrome_content_browser_client.cc
- chromeos/network/BUILD.gn
- chromeos/network/DEPS
- chromeos/network/certificate_pattern.cc
- chromeos/network/certificate_pattern.h
- chromeos/network/client_cert_resolver.cc
- chromeos/network/client_cert_util.cc
- chromeos/network/client_cert_util.h
- chromeos/network/network_connection_handler.cc
- chromeos/network/network_connection_handler_impl.cc
- chromeos/network/onc/onc_certificate_pattern.cc
- chromeos/network/onc/onc_certificate_pattern.h
- chromeos/network/onc/onc_certificate_pattern_unittest.cc
- components/BUILD.gn
- components/certificate_matching/BUILD.gn
- components/certificate_matching/DEPS
- components/certificate_matching/OWNERS
- components/certificate_matching/certificate_principal_pattern.cc
- components/certificate_matching/certificate_principal_pattern.h
- components/certificate_matching/certificate_principal_pattern_unittest.cc
- components/policy/resources/policy_templates.json