Builder Mac Builder (dbg)
Build 154769
Results:
Success
Trigger Info:
| Project | chromium |
| Revision | 011a808c9817d7d15438d199e40756c38371ac00 |
| Got Revision | 011a808c9817d7d15438d199e40756c38371ac00 |
Execution:
- Source: Task 4294ee2297393210
- Bot: vm35-m9
- Recipe: chromium
Steps and Logfiles:
Show:-
- - no logs -
-
( 948 ms ) read test spec (chromium.mac.json)path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.mac.json
-
( 628 ms ) lookup GN argsffmpeg_branding = "Chrome"is_component_build = trueis_debug = trueproprietary_codecs = truestrip_absolute_paths_from_debug_symbols = truesymbol_level = 1use_goma = truegoma_dir = "/b/s/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
Build Properties:
| Name | Value | Source |
|---|---|---|
| $recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
| $recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
| bot_id | "vm35-m9" | setup_build |
| branch | "refs/heads/master" | setup_build |
| buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548270470320372, "id": "8923514459271854304", "project": "chromium", "tags": ["builder:Mac Builder (dbg)", "buildset:commit/git/011a808c9817d7d15438d199e40756c38371ac00", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/011a808c9817d7d15438d199e40756c38371ac00", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9088944521861419968", "scheduler_job_id:chromium/Mac Builder (dbg)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
| buildername | "Mac Builder (dbg)" | setup_build |
| buildnumber | 154769 | setup_build |
| mastername | "chromium.mac" | setup_build |
| path_config | "generic" | setup_build |
| recipe | "chromium" | setup_build |
| repository | "https://chromium.googlesource.com/chromium/src.git" | setup_build |
| revision | "011a808c9817d7d15438d199e40756c38371ac00" | setup_build |
| got_angle_revision | "47ca1b2fa3990e51a2ced20f7a7d3589a5477ad1" | bot_update |
| got_buildtools_revision | "2f02e1f363b1af2715536f38e239853f04ec1497" | bot_update |
| got_dawn_revision | "c0f31e73e481f32d308cb6232e75e6d860d97063" | bot_update |
| got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
| got_revision | "011a808c9817d7d15438d199e40756c38371ac00" | bot_update |
| got_revision_cp | "refs/heads/master@{#625291}" | bot_update |
| got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
| got_v8_revision | "9df9418edf64d6a080ba569ef43cd5ca0171a820" | bot_update |
| got_v8_revision_cp | "refs/heads/7.3.492@{#2}" | bot_update |
| got_webrtc_revision | "b0397d69a93a909fc0b29ffdb9236bab1e1b2db7" | bot_update |
| got_webrtc_revision_cp | "refs/heads/master@{#26368}" | bot_update |
| got_clang_revision | "351477-1" | clang_revision |
| isolate_server | "https://isolateserver.appspot.com" | isolate tests |
| swarm_hashes_refs/heads/master(at){#625291}_without_patch | {"accessibility_unittests": "c44534ff984b437f43a5e017680883cfd8b27dd6", "angle_unittests": "23781c1f80e302af968a112757654c091bea60a8", "app_shell_unittests": "fbf5733cb6b64441ca846f1a0f15108602b7bd4d", "base_unittests": "e2bea17415abf11cad3c7dc1cfb5a7253c0dd552", "blink_common_unittests": "f2a535cca7a84e0b88987e567ecc6f80a24c9842", "blink_fuzzer_unittests": "8558609c62acf135a407c0a77ba5d788cd6f102f", "blink_heap_unittests": "9fa00917e44c413edfacaeef0723e994a603b4ed", "blink_platform_unittests": "9253d4d9ece3557c2eb93cc7fee3a4c84236788c", "boringssl_crypto_tests": "8fb893cefb6334975aa4c621ea23a55b76801a1b", "boringssl_ssl_tests": "1285b16be9cfc7843dc1f11da18832cee54beb80", "browser_tests": "221e5705cdee2a5f080e99d8f68037551f4a40d5", "cacheinvalidation_unittests": "e05331ab95b98748c1c0bb4a5d120031d161a121", "capture_unittests": "cbf7072c7e8ec970ef7635104b2330866fa5e121", "cast_unittests": "198665a08eb17012a4cfdb68e2983573c8dc9bc4", "cc_unittests": "14c7a85587e18df5ef65b69750a364392d7545c4", "chrome_app_unittests": "74f5ddb32c4dc980dd2f1127bd347d6415c6f019", "chromedriver_unittests": "fce9a9a5a37e27483077cea8853f30a17ef5e194", "components_browsertests": "03c77ceacfb1b3324ba96edf53fc180e1b87ecc7", "components_unittests": "e4240fa61061d6f5cf836103178858221b2bd064", "content_browsertests": "58faea99359126644b6a4c118fd7e450b69739bc", "content_shell_crash_test": "68f6a67e508eab9fc94544d79cbfd02e876b2c7f", "content_unittests": "e0a24920c3b22f93c26b8b3c69c9df9cc2f3dc1f", "crashpad_tests": "00b2027f911997f8742259f4079ffcd2f2981afa", "cronet_tests": "fb74f7194ec0a3fcb12f957a105c96291c3fbe75", "cronet_unittests": "700323fb9c531b45f431ecaae6e535d22323cb5d", "crypto_unittests": "71c28a6c50cc21765a0686b4580f756ed7ab5856", "device_unittests": "6b0deb4f1c888d10571225d26645e7adc1255b50", "display_unittests": "6a659b1aed844afba24f75ed478aae9e65d08520", "events_unittests": "a99d4d0b8a4ec407f80f6a160bef5001f86b72d9", "extensions_browsertests": "c1f53a8437690d0f4554cad3c0bf17bba3ed2a7d", "extensions_unittests": "2e0c4f75ffc76bcfef763e9d52bd9c6aa7ff9700", "filesystem_service_unittests": "bb66fdc0ab6a88638a6082748aec44c7d6aa2e8e", "gcm_unit_tests": "c3cf8041462f3f1d8757203ca50b7188a645bb99", "gfx_unittests": "a51cc43777f2cdab556cd906d2050b4fbf221bf4", "gin_unittests": "77923e1cc836c28b1cf9dbfcd88ceece960b2a0c", "google_apis_unittests": "4703f5c58d68e972702caa276ce65cef97f36d50", "gpu_unittests": "bc90588a0fc4c12aa8e3f0db28939638cb17e50e", "headless_browsertests": "6c09ecd62ce8a5c25e1dbb9ee541e44b7ba4cc1d", "headless_unittests": "46313de6acacb91037290d9ce98e37de7ca68d97", "interactive_ui_tests": "0d4db3ea0cb6355517dc7d01bb9eec87e9c70ba3", "ipc_tests": "26c80ae6cb6123a2977fa9ab29ff720ba9729ebe", "jingle_unittests": "8d5aed89d127d2cd7aa7544e4dd34721d4efd112", "latency_unittests": "ce47a5019b76bd4892c3e4b91ab8e1ebf4e56d41", "leveldb_service_unittests": "45945c7b6156bd3b96dcdc5a8b43bc048f4d159f", "libjingle_xmpp_unittests": "fa72a9fb9218598088cf2832609605b3e1f957ea", "media_blink_unittests": "01ec85aa1a3b0634c03de3c0c46e75f5d76740b0", "media_service_unittests": "bdc0c08e94afe8a082becea47c1c9c1c151dc17d", "media_unittests": "fbd05d40f29736ab6657e5c5de25cbe8d7d2523d", "message_center_unittests": "26f84728895811941cd437b40ba5f76614c3585d", "metrics_python_tests": "98f876d1d415b9a1e54f7b5c828026606af3d75f", "midi_unittests": "ee4a3d3f1dd578982082d21d52adf6b861cf47e2", "mojo_unittests": "90a2db1205314aff3cf0b4307353a4bb193f11ca", "nacl_loader_unittests": "971595ebe8aa086a6c7d2ee769253610f0cbec2e", "native_theme_unittests": "6fe91d525af5d512197ca30425242f93d938d0f0", "net_unittests": "09f26c68b132e0059ff0644c773ab1780a80b328", "pdf_unittests": "6f3e4a4b6215e9a663120a2c46c7a456b614345d", "performance_test_suite": "1369af805b3ec215fd5bd39e059a5aacaff675f7", "ppapi_unittests": "6565dac304fcb94183a48fd7b729f9c6a5b65db3", "printing_unittests": "a602de1b5c5fe402d07872bae2a662fd8fba33e9", "remoting_unittests": "446f6eab67798e4d84d6aae7bccc189435293a86", "sandbox_mac_unittests": "b745088f8a5ef6ed22db517fbc8e28fc13e85368", "service_manager_unittests": "d81d3c57a036938c0ef1cb8cf42f54c070da960c", "services_unittests": "790f88f4aff1a576f6a9db0ca7287ddd532ece19", "shell_dialogs_unittests": "7e1aa96cd2a529bd63d92d63e55046641c39ed18", "skia_unittests": "104aed8fb9f6b875b8e4792e488430a26a34d411", "snapshot_unittests": "79b39aecac3cbb299b090a0ebb80299a4adb2683", "sql_unittests": "886b225995b29b616651c9284f4b1969db2cce74", "storage_unittests": "21df90de36b724f3002d374fa96cf98599ca8c07", "sync_integration_tests": "624ac13a75412777baf29ec21056dbdf83b08051", "telemetry_gpu_unittests": "525f9dbfed50ac1a8d4690266175cfb6d94e40a7", "telemetry_unittests": "8e8a3a2e1e6284e4471615f55ebba62737b27b58", "ui_base_unittests": "8fd711d93ae0f61bf5e9bf707c145898eabc7040", "ui_touch_selection_unittests": "3779ae5cbca205095e7e156f8dc361a81f7ab431", "unit_tests": "339d2573fd26966fbafcc1b436371283b7e0875d", "url_unittests": "4c2c9c5b11b01e5da7847bcd4d541c242beceaca", "views_perftests": "02f67a16c4bbf12f4ca56ab80c70630e26ec78ad", "views_unittests": "718be3e532b025f0b958b6047a82c7ceac0c6ce3", "viz_unittests": "4f1d114315ce94e08f3ea855342bd435d7ea0e2b", "webkit_layout_tests_exparchive": "f74151465a9295976cc606013dbb011ddd08154f", "webkit_python_tests": "76e97f22650df66d5fb7cbddb62a11dc8a1ea76c", "webkit_unit_tests": "b8e787add9ca4ce5cc042571faf47ca01452ea0f", "wtf_unittests": "f2a8043b86cf138c28988d2ec3cef4b25fc7154f"} | isolate tests |
Blamelist:
- Robert Ogden (robertogdenohnoyoudont@chromium.org)
- Kristi Park (kristiparkohnoyoudont@chromium.org)
- v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
- chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
- Vladimir Levin (vmpstrohnoyoudont@chromium.org)
- James Darpinian (jdarpinianohnoyoudont@chromium.org)
- Peng Huang (penghuangohnoyoudont@chromium.org)
- Esmael El-Moslimany (aeeohnoyoudont@chromium.org)
- Moe Ahmadi (mahmadiohnoyoudont@chromium.org)
- Jun Mukai (mukaiohnoyoudont@chromium.org)
- Jon Kunkee (jkunkeeohnoyoudont@microsoft.com)
- Lei Zhang (thestigohnoyoudont@chromium.org)
- Leonardo Padilha (ldaguilarohnoyoudont@chromium.org)
- Stepan Khapugin (stkhapuginohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Wei Lee (wtleeohnoyoudont@google.com)
- Manuel Rego Casasnovas (regoohnoyoudont@igalia.com)
Timing:
| Create | Wednesday, 23-Jan-19 19:07:50 UTC |
| Start | Wednesday, 23-Jan-19 19:07:58 UTC |
| End | Wednesday, 23-Jan-19 20:03:16 UTC |
| Pending | 8 secs |
| Execution | 55 mins 17 secs |
All Changes:
-
Add ReloadType to navigation params to copy in HTTPS Server Previews
Changed by Robert Ogden - robertogdenohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 19:04:54 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 011a808c9817d7d15438d199e40756c38371ac00 Comments
Add ReloadType to navigation params to copy in HTTPS Server Previews When navigations are cancelled by a preview, the cancelled reload type is lost. This CL adds ReloadType to the various parameters and layers in browser-initiated navigations so that it can be preserved. Bug: 914547 Change-Id: Ibd5c272252ec06fff8ac6300287c70a5074a6193 Reviewed-on: https://chromium-review.googlesource.com/c/1426519 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#625291}
Changed files
- chrome/browser/previews/previews_lite_page_browsertest.cc
- chrome/browser/previews/previews_lite_page_decider.cc
- chrome/browser/previews/previews_lite_page_navigation_throttle.cc
- chrome/browser/ui/browser_navigator.cc
- chrome/browser/ui/browser_navigator_params.cc
- chrome/browser/ui/browser_navigator_params.h
- content/browser/frame_host/navigation_controller_impl.cc
- content/browser/frame_host/navigation_controller_impl_unittest.cc
- content/public/browser/navigation_controller.cc
- content/public/browser/navigation_controller.h
- content/public/browser/page_navigator.cc
- content/public/browser/page_navigator.h
- content/shell/browser/shell.cc
- headless/lib/browser/headless_web_contents_impl.cc
-
[NTP] Support dark mode for fakebox
Changed by Kristi Park - kristiparkohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 19:04:23 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 53122970992c67f6867b246eb202eacefec24c7f Comments
[NTP] Support dark mode for fakebox Screenshots: https://screenshot.googleplex.com/xdxsFVdfMT3.png https://screenshot.googleplex.com/60nh9bRXjLu.png Bug: 919961 Change-Id: I620997bc3b76eff3c0126c69af122b0875b4f56a Reviewed-on: https://chromium-review.googlesource.com/c/1428539 Reviewed-by: Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#625290}
Changed files
- chrome/browser/resources/local_ntp/local_ntp.css
-
Update V8 to version 7.3.492.1 (cherry-pick).
Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com Changed at Wednesday, 23-Jan-19 19:03:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0f7100cdcf867aa89cc376514ea6710a143cef86 Comments
Update V8 to version 7.3.492.1 (cherry-pick). Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/21b1ee52..9df9418e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifb370322e6d064014657d697106bfd3331c7119b Reviewed-on: https://chromium-review.googlesource.com/c/1430661 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625289}
Changed files
- DEPS
-
Roll src-internal 9eb5076ed0c1..d1737fb0576a (121 commits)
Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com Changed at Wednesday, 23-Jan-19 19:02:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision fa2cdf5f63fd80d3aac1fa01842c6cfbff5a5909 Comments
Roll src-internal 9eb5076ed0c1..d1737fb0576a (121 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9eb5076ed0c1..d1737fb0576a Created with: gclient setdep -r src-internal@d1737fb0576a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891734,chromium:891313,chromium:891734 TBR=mmoss@chromium.org Change-Id: I6bab4fe920a70b802ac5e66dbd41f525da225075 Reviewed-on: https://chromium-review.googlesource.com/c/1430894 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625288}
Changed files
- DEPS
-
[DL]: Ensure that locked elements are skipped in tab order navigation
Changed by Vladimir Levin - vmpstrohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 19:01:43 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b96fd3179adab9ffb44faab88c3a05c54039b165 Comments
[DL]: Ensure that locked elements are skipped in tab order navigation This patch ensures that the elements in a locked subtree with searchable: false are not focusable by either mouse or keyboard. In effect this prevents tab order navigation to elements in locked subtrees. R=chrishtr@chromium.org Bug: 882663 Change-Id: I0fbde6ba811be21021e450b38b584aa24ad7e52a Reviewed-on: https://chromium-review.googlesource.com/c/1417715 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#625287}
Changed files
- third_party/blink/renderer/core/display_lock/display_lock_context_test.cc
- third_party/blink/renderer/core/dom/element.cc
- third_party/blink/renderer/core/dom/element.h
-
Roll WebGL f22b9ad..db52df1
Changed by James Darpinian - jdarpinianohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 19:01:15 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision efb15ad2830709ef6d4103378c9be63d5f655907 Comments
Roll WebGL f22b9ad..db52df1 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/f22b9ad..db52df1 TBR: kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win-angle-rel Change-Id: Ia39997032b4ac59d5da49051396e1b8e931101b1 Reviewed-on: https://chromium-review.googlesource.com/c/1427576 Reviewed-by: James Darpinian <jdarpinian@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#625286}
Changed files
- DEPS
- content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
- content/test/gpu/gpu_tests/webgl_conformance_revision.txt
-
Rename aster_decoder_context_state.{cc,h} to shared_context_state.{cc,h}
Changed by Peng Huang - penghuangohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 18:56:26 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8294a5a7f826f3079f26a41ee21340953cc9ec12 Comments
Rename aster_decoder_context_state.{cc,h} to shared_context_state.{cc,h} Bug: 919865 Change-Id: Ia24d527ef1ac7af7c58fda5bf232c429d0ebc453 Reviewed-on: https://chromium-review.googlesource.com/c/1427610 Reviewed-by: Jonathan Backer <backer@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#625285}Changed files
- components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.h
- components/viz/service/gl/gpu_service_impl.cc
- gpu/command_buffer/service/BUILD.gn
- gpu/command_buffer/service/gr_cache_controller.cc
- gpu/command_buffer/service/gr_cache_controller_unittest.cc
- gpu/command_buffer/service/raster_decoder.cc
- gpu/command_buffer/service/raster_decoder_unittest.cc
- gpu/command_buffer/service/raster_decoder_unittest_base.cc
- gpu/command_buffer/service/shared_context_state.cc
- gpu/command_buffer/service/shared_context_state.h
- gpu/command_buffer/service/shared_image_backing_factory_ahardwarebuffer.cc
- gpu/command_buffer/service/shared_image_backing_factory_ahardwarebuffer_unittest.cc
- gpu/command_buffer/service/shared_image_backing_factory_gl_texture_unittest.cc
- gpu/command_buffer/service/shared_image_factory.cc
- gpu/command_buffer/service/wrapped_sk_image.cc
- gpu/command_buffer/tests/fuzzer_main.cc
- gpu/ipc/in_process_command_buffer.cc
- gpu/ipc/service/gpu_channel_manager.h
-
Downloads WebUI: skip updating entries when there are no new entries
Changed by Esmael El-Moslimany - aeeohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 18:52:02 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 34ef4e670c94353ff3ffc6bdba1d245c1713a72a Comments
Downloads WebUI: skip updating entries when there are no new entries Bug: 923274 Change-Id: I98b7a42fd02ec0a950074265f4bf0c992ecc9b08 Reviewed-on: https://chromium-review.googlesource.com/c/1427739 Auto-Submit: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Dan Beam (slow until 1/29) <dbeam@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#625284}
Changed files
- chrome/browser/resources/md_downloads/manager.js
-
Revert "Enable connectivity checker for fuchsia"
Changed by Moe Ahmadi - mahmadiohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 18:48:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5bc177455c5cdf9c9550e39d243d5a2185d846d5 Comments
Revert "Enable connectivity checker for fuchsia" This reverts commit 9df0aa65ec025ddc73b669acf79122b5b3a9825d. Reason for revert: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-x64-cast/11742 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-arm64-cast/11675 Original change's description: > Enable connectivity checker for fuchsia > > We are using the default connectivity checker, and adding the switch > |--require-wlan| to allow developers to force connections to only WLAN > network interfaces. > > Fuchsia devices typically have an ethernet cable connected for > development, which causes the connectivity checker to always return connected. > For some tests and development, we need to force the usage of WLAN > interfaces, thus this switch was needed. > > Run cast with --require-wlan, observe disconnected > > Bug: 777973 > Test: net_unittests && Run cast with no flags, observe connected && > Change-Id: I359c57a83ce42eb81e5795c0c2c7b711b907471e > Reviewed-on: https://chromium-review.googlesource.com/c/1419903 > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Aidan Wolter <awolter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625258} TBR=wez@chromium.org,pauljensen@chromium.org,halliwell@chromium.org,awolter@chromium.org Change-Id: I5ea25b3824c74669aa4180706da8d9ada7d244a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 777973 Reviewed-on: https://chromium-review.googlesource.com/c/1431015 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#625283}
Changed files
- chromecast/base/chromecast_switches.cc
- chromecast/base/chromecast_switches.h
- chromecast/browser/cast_browser_main_parts.cc
- chromecast/net/BUILD.gn
- chromecast/net/network_change_notifier_factory_fuchsia.cc
- chromecast/net/network_change_notifier_factory_fuchsia.h
- net/BUILD.gn
- net/base/network_change_notifier.cc
- net/base/network_change_notifier_fuchsia.cc
- net/base/network_change_notifier_fuchsia.h
- net/base/network_change_notifier_fuchsia_unittest.cc
- net/base/network_interfaces_fuchsia.cc
- net/base/network_interfaces_fuchsia.h
-
Support of aspect ratio, max/min sizes for Mash
Changed by Jun Mukai - mukaiohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 18:48:18 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3a0c4c90e5d8456d7c7c975294d8f764deb4d2bd Comments
Support of aspect ratio, max/min sizes for Mash Right now maximum/minimum sizes are computed from views, it's hard to detect when it exactly changes. Because of that, individual client sets those properties for now to configure those metrics propertly. Bug: 921272 Test: manually Change-Id: I062da6e771f7f1c02d3ab07bebd98ceff410b3c8 Reviewed-on: https://chromium-review.googlesource.com/c/1422704 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#625282}
Changed files
- ash/wm/non_client_frame_controller.cc
- chrome/browser/ui/views/overlay/overlay_window_views.cc
- services/ws/public/cpp/property_type_converters.cc
- services/ws/public/cpp/property_type_converters.h
- services/ws/public/mojom/window_manager.mojom
- ui/aura/client/aura_constants.cc
- ui/aura/client/aura_constants.h
- ui/aura/mus/property_converter.cc
- ui/aura/mus/property_converter.h
- ui/views/mus/desktop_window_tree_host_mus.cc
- ui/views/mus/desktop_window_tree_host_mus.h
- ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc
- ui/views/widget/desktop_aura/desktop_window_tree_host_platform.h
-
Roll src/third_party/ffmpeg/ 42bb040dd..4b75b8bab (2 commits)
Changed by Jon Kunkee - jkunkeeohnoyoudont@microsoft.com Changed at Wednesday, 23-Jan-19 18:47:20 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 682c04d8553abbf37a5b7c34ba66776f7c751b00 Comments
Roll src/third_party/ffmpeg/ 42bb040dd..4b75b8bab (2 commits) https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/42bb040dde0a..4b75b8bab993 $ git log 42bb040dd..4b75b8bab --date=short --no-merges --format='%ad %ae %s' 2019-01-10 chcunningham Add ARM64 Windows support to the Chromium FFMPEG repo 2019-01-10 liberato Handle autorename files automatically. Bug: 893460 Change-Id: Iccb2d42f701e5a45e04d1cd47b15f4fb4e00682c Reviewed-on: https://chromium-review.googlesource.com/c/1429385 Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#625281}
Changed files
- DEPS
-
Remove Android-specific printing IPCs.
Changed by Lei Zhang - thestigohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 18:46:31 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 03f4a53bc296dd3a65f95c7161b7305587ac392d Comments
Remove Android-specific printing IPCs. Instead, print more like as other platforms. On the renderer side, remove most Android-specific code, so it behaves like Linux. As a result, the printed document data is transferred via PrintHostMsg_DidPrintDocument, instead of the Android-specific IPC messages. To handle this in WebView, add AwPrintManager::OnDidPrintDocument() to receive the printed data, and write it out to its file descriptor. To handle this in Chromium, reuse the existing printing architecture and add the missing Android-specific bits. Hold the file descriptor used for printing in PrintingContextAndroid, and implement PrintingContextAndroid::PrintDocument() to write to the file descriptor. BUG=922657 Change-Id: I1c0123cade448de5a3ace00d671ecae61a04ffd3 Reviewed-on: https://chromium-review.googlesource.com/c/1420297 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#625280}
Changed files
- android_webview/BUILD.gn
- android_webview/browser/aw_content_browser_client.cc
- android_webview/browser/aw_print_manager.cc
- android_webview/browser/aw_print_manager.h
- android_webview/browser/aw_printing_message_filter.cc
- android_webview/browser/aw_printing_message_filter.h
- chrome/browser/printing/print_view_manager_base.cc
- chrome/browser/printing/print_view_manager_basic.cc
- chrome/browser/printing/print_view_manager_basic.h
- chrome/browser/printing/printing_message_filter.cc
- chrome/browser/printing/printing_message_filter.h
- components/printing/common/print_messages.h
- components/printing/renderer/print_render_frame_helper.cc
- components/printing/renderer/print_render_frame_helper_linux.cc
- printing/BUILD.gn
- printing/printed_document.cc
- printing/printed_document_android.cc
- printing/printing_context_android.cc
- printing/printing_context_android.h
-
Request status report after a suspend mode has been completed.
Changed by Leonardo Padilha - ldaguilarohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 18:43:48 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b9650e0492c23bab18d5eb218cb402add39bfa53 Comments
Request status report after a suspend mode has been completed. Add return from suspend mode as trigger to status report. Bug: 919132 Change-Id: I9a3533de21bc8d83761889d26e81066c14e03428 Reviewed-on: https://chromium-review.googlesource.com/c/1427839 Reviewed-by: Aga Wronska <agawronska@chromium.org> Commit-Queue: Leonardo Padilha <ldaguilar@chromium.org> Cr-Commit-Position: refs/heads/master@{#625279}
Changed files
- chrome/browser/chromeos/child_accounts/event_based_status_reporting_service.cc
- chrome/browser/chromeos/child_accounts/event_based_status_reporting_service.h
- chrome/browser/chromeos/child_accounts/event_based_status_reporting_service_unittest.cc
-
Revert "Add a DCHECK in omnibox_view_ios."
Changed by Stepan Khapugin - stkhapuginohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 18:43:33 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 095f090c96f6131c77d4533353ea6b37e0fd36f7 Comments
Revert "Add a DCHECK in omnibox_view_ios." This reverts commit 2cd80cbbd1ec496fbc335e2d17cfc816ba56b55b. Reason for revert: DCHECK fires on real users' devices. Unclear why. Original change's description: > Add a DCHECK in omnibox_view_ios. > > I suspect that processing_user_event is always true. > If this is the case, the textfield delegate can be simplified. In > order to verify this, add a DCHECK and see if it fires on the bots. > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: Ic45526950bf1f4b05a4c11a9cde551d0eef6dc0e > Reviewed-on: https://chromium-review.googlesource.com/1120816 > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573710} TBR=rohitrao@chromium.org,justincohen@chromium.org,stkhapugin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I2729f16524f3523098c09543705f007fb5e14515 Reviewed-on: https://chromium-review.googlesource.com/c/1430088 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#625278}
Changed files
- ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm
-
Roll src/third_party/webrtc 71b5a7df7794..b0397d69a93a (17 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 23-Jan-19 18:36:17 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a57093d4da83031945fa7a79023bbab039443297 Comments
Roll src/third_party/webrtc 71b5a7df7794..b0397d69a93a (17 commits) https://webrtc.googlesource.com/src.git/+log/71b5a7df7794..b0397d69a93a git log 71b5a7df7794..b0397d69a93a --date=short --no-merges --format='%ad %ae %s' 2019-01-23 hofbauer@webrtc.org Always send abs-send-time when negotiated and do not filter it out. 2019-01-23 yvesg@webrtc.org [CodeHealth] Fix use after std::move instances. 2019-01-23 oprypin@webrtc.org Correctly specify Mac version as 10.13 for iOS simulator tests 2019-01-23 jonasolsson@webrtc.org Don't pretend we've received an end-of-candidates indication. 2019-01-23 kwiberg@webrtc.org Rename new build targets to follow the recent large file rename 2019-01-23 srte@webrtc.org Enables feature to account for unacknowledged data. 2019-01-23 srte@webrtc.org Reland "Reland "Adds richer packet and ice processing to ParsedRtcEventLog."" 2019-01-22 mbonadei@webrtc.org Fix typo in rtc_base/thread_checker.h. 2019-01-22 eladalon@webrtc.org Make SetFirstSubFrameInFrame and SetLastSubFrameInFrame protected 2019-01-22 eladalon@webrtc.org PSFB without REMB magic word is not an error 2019-01-22 ilnik@webrtc.org Always use real VideoStreamsFactory in full stack tests 2019-01-22 ilnik@webrtc.org Report rendered pixels statistic in full stack tests 2019-01-22 ilnik@webrtc.org Reduce webrtc_perf_tests duration on buildbots 2019-01-22 nisse@webrtc.org Refactor FileRotatingStream to use FileWrapper rather than FileStream 2019-01-22 nisse@webrtc.org Include video_bitrate_allocator.h, now that's in api/ 2019-01-22 sprang@webrtc.org Parsing of pacing factor and alr probing in RateControlSettings 2019-01-22 mbonadei@webrtc.org Remove NetworkManager::{set_ipv6_enabled,ipv6_enabled}. Created with: gclient setdep -r src/third_party/webrtc@b0397d69a93a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:922588,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib82b38129a76de737f00c2d0edd23c83d9e9b551 Reviewed-on: https://chromium-review.googlesource.com/c/1430219 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625277}
Changed files
- DEPS
-
Add OWNERS for camera folder
Changed by Wei Lee - wtleeohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 18:35:17 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3bd065339abbf053466d4360f6b0c5084cd15ade Comments
Add OWNERS for camera folder This CL adds OWNERS file into camera folder to clarify the ownership which it should belongs to the same owners of Chrome Camera App. Bug: 918091 Test: None Change-Id: I447ce86bea6eb420ec98c9b6a387cb69a7368a4d Reviewed-on: https://chromium-review.googlesource.com/c/1429301 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#625276}
Changed files
- chrome/browser/resources/chromeos/camera/OWNERS
-
[css-contain] Fix crash on SetText optimization
Changed by Manuel Rego Casasnovas - regoohnoyoudont@igalia.com Changed at Wednesday, 23-Jan-19 18:35:10 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 445b9c40be9c69b3c51aefc61916470a3cb3f68e Comments
[css-contain] Fix crash on SetText optimization This optimization was introduced in r578233 but it's causing a crash when you use "text-overflow: ellipsis". We need to check if we need or not an ellipsis in the new text, and compute the position of the ellipsis if it's required. For that reason we cannot apply the optimization and we need to do a proper layout. The patch adds a new condition in LayoutText::CanOptimizeSetText() to avoid applying the optimization in that case. BUG=805785 TEST=fast/css/containment/change-text-node-data-ellipsis-crash.html Change-Id: I18c2ff04af9df64930510a6bda1071322cf07664 Reviewed-on: https://chromium-review.googlesource.com/c/1430082 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#625275}
Changed files
- third_party/blink/renderer/core/layout/layout_text.cc
- third_party/blink/web_tests/fast/css/containment/change-text-node-data-ellipsis-crash-expected.txt
- third_party/blink/web_tests/fast/css/containment/change-text-node-data-ellipsis-crash.html
