Builder Mac Builder (dbg)
Build 154729
Results:
Success
Trigger Info:
| Project | chromium |
| Revision | 0b29656a35f0ee4b059cf06b40af734920917735 |
| Got Revision | 0b29656a35f0ee4b059cf06b40af734920917735 |
Execution:
- Source: Task 429168190fbf0f10
- Bot: vm35-m9
- Recipe: chromium
Steps and Logfiles:
Show:-
- - no logs -
-
( 940 ms ) read test spec (chromium.mac.json)path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.mac.json
-
( 620 ms ) lookup GN argsffmpeg_branding = "Chrome"is_component_build = trueis_debug = trueproprietary_codecs = truestrip_absolute_paths_from_debug_symbols = truesymbol_level = 1use_goma = truegoma_dir = "/b/s/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
Build Properties:
| Name | Value | Source |
|---|---|---|
| $recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
| $recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
| bot_id | "vm35-m9" | setup_build |
| branch | "refs/heads/master" | setup_build |
| buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548211359588715, "id": "8923576441366527824", "project": "chromium", "tags": ["builder:Mac Builder (dbg)", "buildset:commit/git/0b29656a35f0ee4b059cf06b40af734920917735", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/0b29656a35f0ee4b059cf06b40af734920917735", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089006503556246448", "scheduler_job_id:chromium/Mac Builder (dbg)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
| buildername | "Mac Builder (dbg)" | setup_build |
| buildnumber | 154729 | setup_build |
| mastername | "chromium.mac" | setup_build |
| path_config | "generic" | setup_build |
| recipe | "chromium" | setup_build |
| repository | "https://chromium.googlesource.com/chromium/src.git" | setup_build |
| revision | "0b29656a35f0ee4b059cf06b40af734920917735" | setup_build |
| got_angle_revision | "0c2c923ec621af0b5fff937a1528660350e6506e" | bot_update |
| got_buildtools_revision | "2f02e1f363b1af2715536f38e239853f04ec1497" | bot_update |
| got_dawn_revision | "c0f31e73e481f32d308cb6232e75e6d860d97063" | bot_update |
| got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
| got_revision | "0b29656a35f0ee4b059cf06b40af734920917735" | bot_update |
| got_revision_cp | "refs/heads/master@{#625046}" | bot_update |
| got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
| got_v8_revision | "0550ef03cf24c364d888fa381ae88400d3ff42f2" | bot_update |
| got_v8_revision_cp | "refs/heads/7.3.484@{#1}" | bot_update |
| got_webrtc_revision | "71b5a7df7794bbc4103296fcd8bd740acebdc901" | bot_update |
| got_webrtc_revision_cp | "refs/heads/master@{#26351}" | bot_update |
| got_clang_revision | "351477-1" | clang_revision |
| isolate_server | "https://isolateserver.appspot.com" | isolate tests |
| swarm_hashes_refs/heads/master(at){#625046}_without_patch | {"accessibility_unittests": "b97b9626db15391ba332a23595f163ec0613ccb5", "angle_unittests": "2e86175b412f7b7cd7aeab9867cafe0362930ad3", "app_shell_unittests": "26fa849e0ebbf3278e891945a01c0cec0b0c3778", "base_unittests": "14ed53b3a199f3958099669cb9aa92db3dc97b1c", "blink_common_unittests": "27e095327eb40be8e358be12494227e1b936699c", "blink_fuzzer_unittests": "a8bdb9badbd5abb8303040c5bb1f9e1b8154d698", "blink_heap_unittests": "10e7770e20dc8f78e8340222750b7f099afac2ed", "blink_platform_unittests": "94573f7f055d71ce4820e3c70972b8587c469a29", "boringssl_crypto_tests": "f1440898bc81a91ed7fe17152b50101530b70ecb", "boringssl_ssl_tests": "e69704735722268070386ce50e853fbb62ce3488", "browser_tests": "85c54ed9761a2955d1ee1072d83ecfe30dad2eb8", "cacheinvalidation_unittests": "ae1168a80dd45c0399ae140da6559bc7436d2baa", "capture_unittests": "b4508e47a5dfa2964bd144d2003d91424e524fdb", "cast_unittests": "bc33faddb968c05baa755b109286ec7b25252fd2", "cc_unittests": "0b204a6d237a2fc077f7a86f1a59716cf18b7948", "chrome_app_unittests": "bb7c3eb2eec714e05d2e72054969d897d2a8f194", "chromedriver_unittests": "59fab23cb65f1117d21b32ac8951df3a5be1e76d", "components_browsertests": "9abe4c69ce994bd7804fe3883ab1d45f6379792a", "components_unittests": "e86a8b401bab781c85563424d1a3fab113e7d06e", "content_browsertests": "cddaff760bd1f49303dfdaa59ff2c3909ea6bc61", "content_shell_crash_test": "0071807d7eb6cd45c36f18690dbedfc23b9c11b3", "content_unittests": "c091b83e4e9c236e88355a24b663807be3733d80", "crashpad_tests": "f48c522a20636d9fd32d420c02cbdf2d236e913f", "cronet_tests": "aaabac6a53a83690cbdd5fbdc46c75d17eb7ee00", "cronet_unittests": "b65128c170a8f3d388d6fd3474662f0f014f5b84", "crypto_unittests": "06fda1bb9fe22118e87cfac96e8995d6af6d4b88", "device_unittests": "6121c3460d06ba2d8e76e77945a14b3e6eb8e6ca", "display_unittests": "0cfc7dedb398eafbe7d00b8e91b502182125e2fe", "events_unittests": "5debbc3b8414d27e13b51bf98cb9da3abe76fac2", "extensions_browsertests": "fe51a84ba9d2647f0baf48a3705f89d300fbfa63", "extensions_unittests": "a012fe31cc6abcd8253cecb43dfe63efe53227a2", "filesystem_service_unittests": "e26d2b5895243d711ad897bc24ce9c59bd6c618e", "gcm_unit_tests": "8c8fa3625eb25e7b1256b43696a107cf2b04e63e", "gfx_unittests": "c72770a310dbd2e50dc3c45ed094aba9bf716dd1", "gin_unittests": "b4b34c5aefa7d01e90f2304187def4a2101e22ed", "google_apis_unittests": "9afb62b3d9da1ddbea375e4cfa37ef94dd1d5757", "gpu_unittests": "20144a815f120787df858c3ceacc325d4eba3928", "headless_browsertests": "98c03e949337ad40c4fecdf73838cec20e7bc6ca", "headless_unittests": "84d3f9e9cc3aa9e7bef82dd4dbbbd9bd99fc5fd1", "interactive_ui_tests": "076f3ee86cd3d79a469255f334d5b4342acb86db", "ipc_tests": "3cd924d8cf4e0eb7366e4463b2c880e63e6c8eb4", "jingle_unittests": "2fcc2c5b6b655b662fe0faf8cef777ff9b9e30f6", "latency_unittests": "a393c4a73e101c23c7d72588c26d94f7f8c6d3fd", "leveldb_service_unittests": "acde7d2b00149d22930924cd8d69045fe5c62421", "libjingle_xmpp_unittests": "577af94416499f7b162052ac5695801e390225a7", "media_blink_unittests": "5e25322d6a696012e4892f48af5120d7a284582d", "media_service_unittests": "fa75884a3c69d830bd1958f930f763165ead3d46", "media_unittests": "21682f157bd5605df1c9474c39aa41d34415e25c", "message_center_unittests": "6a75a743e047a80dcaff5a36786967b24343ffa7", "metrics_python_tests": "98f876d1d415b9a1e54f7b5c828026606af3d75f", "midi_unittests": "bbd8a13f0978bb5ec44242e24d800c78840256e6", "mojo_unittests": "d1ad57b3a45bf35de81263b73d78b73d00aeaea9", "nacl_loader_unittests": "1d5369d2b7ab2d6a59ad9fe5352ead797f4e7556", "native_theme_unittests": "ac414314be981db5a37baf2afab520dfc284a291", "net_unittests": "1aed19ebe79f8105438bbb87eaab747c3a771961", "pdf_unittests": "c496411175e2ef4e4dbf154df03cb74b18b0ff46", "performance_test_suite": "844ac1c5183eaa67d4da36bb2ed52df1391bda7f", "ppapi_unittests": "a072c24cacf7a541b1a9c2df3b89ee96eab1e429", "printing_unittests": "5ca2c193eb3684bf1397bf73ac2840d980b6d074", "remoting_unittests": "fc5fb0188aae36f0359a32ded18e95d4878abe4c", "sandbox_mac_unittests": "34af246a42c7b55ba131bb00c28cc4f4e3aa0c74", "service_manager_unittests": "57501b43b48a83ac93b5fea6ccde5142f2ebc80b", "services_unittests": "afbeae0f3a931c899ab0483408b7e764650e633f", "shell_dialogs_unittests": "395f12f83e9e250c7d070ebc15382c9fac8bd7e4", "skia_unittests": "5f09ecbcdd5b74b34ee808ecb7a6b4aa7dcbc8c4", "snapshot_unittests": "e554d189f482391c135d8b4783a18359196fdbdf", "sql_unittests": "07e251e9e2c9b6af152e54d89245c7cb7de5e249", "storage_unittests": "904d17d2265f973ab8de37d7350da82f00efca23", "sync_integration_tests": "e05bf3e2304bd3f7243febe3539fad2d9c8f74d2", "telemetry_gpu_unittests": "9b5c14def67b32714ce0e5c186aa9066ee4a0be7", "telemetry_unittests": "62d06c8d2bc3fc283e2cb5a77f1ca14a1e98dc97", "ui_base_unittests": "2deadb9fa654b905672ed5a35d9ddb166731af83", "ui_touch_selection_unittests": "59072ff52009ae713bc2432d0ea15a343df8b4db", "unit_tests": "a1a0c86a5e18942966c018073c5f0c2431166ba1", "url_unittests": "9b0f111a638da01e66ee3d409037d266a4c3ea57", "views_perftests": "c9087bc1536b55685daedc502ff3ce0b5b17a725", "views_unittests": "937d218fee68c764235fb1730a59dbdca5befec9", "viz_unittests": "7444e4c9fcd762a77434b5eb67e0ac701ef79153", "webkit_layout_tests_exparchive": "fe2bb4a455f3b8c774f1c5fcaf0f7ad52298be19", "webkit_python_tests": "45de6257be202d6266c4bee77f5a24a268cf35c8", "webkit_unit_tests": "a9ba6ade7d747142383ebe4f3f0349fb6402e99a", "wtf_unittests": "832ddc2c50ba3fc79bc2335aefe3598494161856"} | isolate tests |
Blamelist:
- Joey Scarr (jscaohnoyoudont@google.com)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Justin Cohen (justincohenohnoyoudont@chromium.org)
- v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
- John Chen (johnchenohnoyoudont@chromium.org)
- Dan Beam (dbeamohnoyoudont@chromium.org)
- Hiroshige Hayashizaki (hiroshigeohnoyoudont@chromium.org)
- sangwoo.ko (sangwoo.koohnoyoudont@navercorp.com)
- Dan Beam (dbeamohnoyoudont@chromium.org)
- Azeem Arshad (azeemarshadohnoyoudont@chromium.org)
- Alan Cutter (alancutterohnoyoudont@chromium.org)
- rbpotter (rbpotterohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Julie Jeongeun Kim (jkimohnoyoudont@igalia.com)
- Tatiana Buldina (buldinaohnoyoudont@chromium.org)
- Robert Ogden (robertogdenohnoyoudont@chromium.org)
Timing:
| Create | Wednesday, 23-Jan-19 02:42:39 UTC |
| Start | Wednesday, 23-Jan-19 02:42:42 UTC |
| End | Wednesday, 23-Jan-19 03:27:34 UTC |
| Pending | 2 secs |
| Execution | 44 mins 51 secs |
All Changes:
-
Add mb_config entry for Code Search Fuchsia bot.
Changed by Joey Scarr - jscaohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 02:32:20 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0b29656a35f0ee4b059cf06b40af734920917735 Comments
Add mb_config entry for Code Search Fuchsia bot. Bug: 903068 Change-Id: I50c39777d8cad7fda18b940f3cc2601e7728ee84 Reviewed-on: https://chromium-review.googlesource.com/c/1428619 Commit-Queue: Joey Scarr <jsca@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Joey Scarr <jsca@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#625046}
Changed files
- tools/mb/mb_config.pyl
-
Roll src/third_party/skia 6ac8d361167d..325778b8884b (5 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 23-Jan-19 02:29:51 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision cc31b5f9fd73379bcf4f7a9dae025b66955e59bf Comments
Roll src/third_party/skia 6ac8d361167d..325778b8884b (5 commits) https://skia.googlesource.com/skia.git/+log/6ac8d361167d..325778b8884b git log 6ac8d361167d..325778b8884b --date=short --no-merges --format='%ad %ae %s' 2019-01-22 benjaminwagner@google.com Update android-skqp Docker image to accept licenses 2019-01-22 csmartdalton@google.com Move Op chain bounds calculations into tryConcat 2019-01-22 reed@google.com Move more utils into SkFontPriv, IWYU 2019-01-22 fmalita@chromium.org [skshaper] Relax create_hb_font assert 2019-01-22 brianosman@google.com Update ImGui to 1.67 Created with: gclient setdep -r src/third_party/skia@325778b8884b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: If40e25fea5d64d53c30ac510f611f32b3d57345e Reviewed-on: https://chromium-review.googlesource.com/c/1428361 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625045}
Changed files
- DEPS
-
Revert "Reland "[ios] Call LoadIfNecessary even when displaying the NTP.""
Changed by Justin Cohen - justincohenohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 02:27:20 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9656ebbd0446e1d9a648b7e8e5a5dcaf6132cd1d Comments
Revert "Reland "[ios] Call LoadIfNecessary even when displaying the NTP."" This reverts commit f7a1e3d83c5e10e5f61fdce4cd3715b6768ecf47. Reason for revert: Still causing failures. Original change's description: > Reland "[ios] Call LoadIfNecessary even when displaying the NTP." > > This reverts commit 2a974e5ae5d7df2535b2923999f48a075d5394a8. > > Reason for revert: Speculative re-land of this CL, as it seems > unlikely that this CL caused infobar to fail. > TBR=gab@chromium.org,justincohen@chromium.org,eugenebut@chromium.org,danyao@chromium.org Change-Id: I61c4fe19fe23aa553a2689380a6e07b776a858ca No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1429259 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#625044}
Changed files
- ios/chrome/browser/ui/browser_view_controller.mm
-
Update V8 to version 7.3.484.
Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com Changed at Wednesday, 23-Jan-19 02:24:47 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision de023c7906485f5cb2713a333a628f4534b76a4c Comments
Update V8 to version 7.3.484. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/72736ac1..0550ef03 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I16461db3e0cd9996b4f0a6b6f2f9a9c62da54cec Reviewed-on: https://chromium-review.googlesource.com/c/1427796 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625043}
Changed files
- DEPS
-
[go/perfbot-sheriff] Disable failing browse:media:pinterest:2018
Changed by John Chen - johnchenohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 02:24:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5c187ee1462f4d14cc20ecb576f0e440d87fbf0d Comments
[go/perfbot-sheriff] Disable failing browse:media:pinterest:2018 Disabling system_health.memory_desktop/browse:media:pinterest:2018 on chromium.perf/linux-perf, which has been consistently failing since Jan 20. TBR=perezju@chromium.org Bug: 924330 Change-Id: Ib1246c78256633be8b05c8974d14f846ea99d2a2 Reviewed-on: https://chromium-review.googlesource.com/c/1428080 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#625042}
Changed files
- tools/perf/expectations.config
-
WebUI Dark Mode: style <select class="md-select"> for all pages
Changed by Dan Beam - dbeamohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 02:22:25 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5db16d6cdcfddd547b9c396630df79c1a7e3cfba Comments
WebUI Dark Mode: style <select class="md-select"> for all pages Screenshots: https://imgur.com/a/zioTkR5 Spec: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit?ts=5c363f50#slide=id.g3b4ff0456d_0_9 R=dpapad@chromium.org BUG=883049 Change-Id: I1e38c095af75ffbf574046891e5ad0427b4b4855 Reviewed-on: https://chromium-review.googlesource.com/c/1427456 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#625041}
Changed files
- ui/webui/resources/html/md_select_css.html
-
[Layered API] Compress Layered API scripts
Changed by Hiroshige Hayashizaki - hiroshigeohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 02:20:49 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2c1b59c67f332a7a0d9e0e0f0da037121d443c33 Comments
[Layered API] Compress Layered API scripts Bug: 920264 Change-Id: Ib05c139cdf609136c779bb81d0933077a61cf8c4 Reviewed-on: https://chromium-review.googlesource.com/c/1036603 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#625040}
Changed files
- third_party/blink/renderer/core/script/generate_lapi_grdp.py
- third_party/blink/renderer/core/script/layered_api.cc
- third_party/blink/renderer/core/script/resources/layered_api/resources.grdp
-
Enable rich animation when it's unit test
Changed by sangwoo.ko - sangwoo.koohnoyoudont@navercorp.com Changed at Wednesday, 23-Jan-19 02:18:50 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4043777d26b7c69e98e241f7059f3125a790f65a Comments
Enable rich animation when it's unit test We should always enable rich animation. Otherwise, unit tests could be flaky. Bug: 923849 Change-Id: I87371df838ffa2f2f8c0a9baf5b439450c81e994 Reviewed-on: https://chromium-review.googlesource.com/c/1426239 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#625039}
Changed files
- chrome/browser/ui/views/tabs/tab_strip_unittest.cc
-
Closure compiler: Cleanup compile2.py and rename.
Changed by Dan Beam - dbeamohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 02:18:37 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0135f0c169cacdb2b74899a452126da972a95d80 Comments
Closure compiler: Cleanup compile2.py and rename. There used to be a compile.py, so we added a compile2.py while migrating to a newer format of GYP (which is now long gone). No real reason this file is still "compile2" other than history. Let's fix that. The "Checker" class does more than checking, so I've renamed it "Compiler". And because folks invoke "check()" essentially just to run the compiler.jar in some cases, I've renamed that "run()". file: compile2.py -> compiler.py class: Checker -> Compiler main: check() -> run() R=dpapad@chromium.org BUG=none Change-Id: Ib73a8cca4e14e5aa9cf6ff9db0b97263c1b16208 Reviewed-on: https://chromium-review.googlesource.com/c/1423742 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#625038}
Changed files
- chrome/browser/resources/media_router/extension/BUILD.gn
- third_party/closure_compiler/compiler.py
- third_party/closure_compiler/compiler_test.py
- third_party/closure_compiler/js_binary.py
- third_party/closure_compiler/js_minify.py
-
[CrOS Messages] Add flag for web push in ChromeOS - Messages itegration
Changed by Azeem Arshad - azeemarshadohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 02:16:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 373e1ea774d3f8d82f57e3ce53dbfcd519e9f421 Comments
[CrOS Messages] Add flag for web push in ChromeOS - Messages itegration This flag controls FCM web push based background notifications for Android Messages integration on ChromeOS. See go/awm-cros-fcm. Bug: 920831 Change-Id: I89fc2642e60697d265fbcf0c50ea4afd6ba0de8b Reviewed-on: https://chromium-review.googlesource.com/c/1419223 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Jeremy Klein <jlklein@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#625037}
Changed files
- chrome/browser/about_flags.cc
- chrome/browser/flag-metadata.json
- chrome/browser/flag_descriptions.cc
- chrome/browser/flag_descriptions.h
- chromeos/constants/chromeos_features.cc
- chromeos/constants/chromeos_features.h
- tools/metrics/histograms/enums.xml
-
Fix crash when opening app menu during extension uninstallation
Changed by Alan Cutter - alancutterohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 02:15:47 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 69ac13800ab9c49c7424f0146b1c38056b63ab22 Comments
Fix crash when opening app menu during extension uninstallation This CL adds a missing null check for HostedAppBrowserController::GetExtension() when constructing the hosted app menu. Bug: 923309 Change-Id: I102a1cf5a845ebb65d2e6eed54e862b45d0c92ce Reviewed-on: https://chromium-review.googlesource.com/c/1426243 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#625036}
Changed files
- chrome/browser/ui/extensions/hosted_app_browser_controller.cc
- chrome/browser/ui/extensions/hosted_app_browser_controller.h
- chrome/browser/ui/extensions/hosted_app_menu_model.cc
-
Print Preview: Move enterprise badging to header
Changed by rbpotter - rbpotterohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 02:12:58 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4ad5eae470a95d07465380b0cb5fd8977d83127f Comments
Print Preview: Move enterprise badging to header Move enterprise badging from the individual settings sections to the print header. Bug: 923187 Change-Id: Ie88d0a9fdce9e76b65eef2352d98b030def91a2e Reviewed-on: https://chromium-review.googlesource.com/c/1419267 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#625035}
Changed files
- chrome/app/printing_strings.grdp
- chrome/browser/resources/print_preview/new/color_settings.html
- chrome/browser/resources/print_preview/new/header.html
- chrome/browser/resources/print_preview/new/header.js
- chrome/browser/resources/print_preview/new/other_options_settings.html
- chrome/browser/resources/print_preview/new/settings_section.html
- chrome/browser/resources/print_preview/new/settings_section.js
- chrome/browser/ui/webui/print_preview/print_preview_ui.cc
- chrome/test/data/webui/print_preview/base_settings_section_test.js
- chrome/test/data/webui/print_preview/header_test.js
- chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js
- chrome/test/data/webui/print_preview/print_header_interactive_test.js
- chrome/test/data/webui/print_preview/settings_section_test.js
-
Roll src/third_party/SPIRV-Tools/src 3a3ad2ec5017..4a405eda53be (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 23-Jan-19 02:12:36 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5eb41d7cefbb78f6e7b48aab96c35a7e49af3abb Comments
Roll src/third_party/SPIRV-Tools/src 3a3ad2ec5017..4a405eda53be (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3a3ad2ec5017..4a405eda53be git log 3a3ad2ec5017..4a405eda53be --date=short --no-merges --format='%ad %ae %s' 2019-01-22 dneto@google.com Fix layout checks for nested struct in relaxed layout; and descriptor arrays (#2312) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@4a405eda53be The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2d08cc14026c395ab8fc66bfd6b5fa9885482e61 Reviewed-on: https://chromium-review.googlesource.com/c/1427942 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625034}
Changed files
- DEPS
-
[s13n] Move CWVSyncController away from AccountTrackerService
Changed by Julie Jeongeun Kim - jkimohnoyoudont@igalia.com Changed at Wednesday, 23-Jan-19 02:07:17 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9bebf552e00bd397904d672e1ed21c4256521449 Comments
[s13n] Move CWVSyncController away from AccountTrackerService This CL removes AccountTrackerService from CWVSyncController and uses IdentityManager instead of it. Bug: 922801 Change-Id: Id9f588bbd534ccbaf79030423ddd0ceb98f95321 Reviewed-on: https://chromium-review.googlesource.com/c/1426200 Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#625033}
Changed files
- ios/web_view/internal/cwv_web_view_configuration.mm
- ios/web_view/internal/sync/cwv_sync_controller.mm
- ios/web_view/internal/sync/cwv_sync_controller_internal.h
- ios/web_view/internal/sync/cwv_sync_controller_unittest.mm
-
[ChromeDriver] Keep connection open unless explicit request to close it
Changed by Tatiana Buldina - buldinaohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 02:03:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 67b3c8fdf446ce9260b917895ad1d3bfc787d81b Comments
[ChromeDriver] Keep connection open unless explicit request to close it Bug: chromedriver:1529 Change-Id: Iaec7478021e88750f4a36e1bbe439a93ae9de6be Reviewed-on: https://chromium-review.googlesource.com/c/1427981 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#625032}
Changed files
- chrome/test/chromedriver/server/chromedriver_server.cc
-
Revert "Rebrand Data Saver to Lite mode"
Changed by Robert Ogden - robertogdenohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 02:00:03 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 252a21ac5df697215e19dad4d22d74954f65c559 Comments
Revert "Rebrand Data Saver to Lite mode" This reverts commit 6f01ecff8157c0ee41b669876dc6536f2765ce40. Reason for revert: String changes should be behind a Finch flag Original change's description: > Rebrand Data Saver to Lite mode > > Change-Id: I777e068f0391dfd0e45c26fde83c423d3374cb20 > Bug: 909915 > Reviewed-on: https://chromium-review.googlesource.com/c/1354346 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Commit-Queue: Megan Jablonski <megjablon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613368} TBR=twellington@chromium.org,tbansal@chromium.org,megjablon@chromium.org,srahim@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 909915 Change-Id: Ibc26a00f54b7a63e31fefe6dff037c124616d835 Reviewed-on: https://chromium-review.googlesource.com/c/1427920 Reviewed-by: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#625031}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionPromoInfoBar.java
- chrome/android/java/strings/android_chrome_strings.grd
- chrome/app/chromeos_strings.grdp
- chrome/app/generated_resources.grd