Builder Mac Builder (dbg)
Build 154725
Results:
Success
Trigger Info:
| Project | chromium |
| Revision | 12eff4b61cea3d1545e3894ded9ee2c5a392d595 |
| Got Revision | 12eff4b61cea3d1545e3894ded9ee2c5a392d595 |
Execution:
- Source: Task 4290c54aa3aacb10
- Bot: vm35-m9
- Recipe: chromium
Steps and Logfiles:
Show:-
- - no logs -
-
( 934 ms ) read test spec (chromium.mac.json)path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.mac.json
-
( 632 ms ) lookup GN argsffmpeg_branding = "Chrome"is_component_build = trueis_debug = trueproprietary_codecs = truestrip_absolute_paths_from_debug_symbols = truesymbol_level = 1use_goma = truegoma_dir = "/b/s/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
Build Properties:
| Name | Value | Source |
|---|---|---|
| $recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
| $recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
| bot_id | "vm35-m9" | setup_build |
| branch | "refs/heads/master" | setup_build |
| buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548200689505068, "id": "8923587629759913504", "project": "chromium", "tags": ["builder:Mac Builder (dbg)", "buildset:commit/git/12eff4b61cea3d1545e3894ded9ee2c5a392d595", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/12eff4b61cea3d1545e3894ded9ee2c5a392d595", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089017691886996544", "scheduler_job_id:chromium/Mac Builder (dbg)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
| buildername | "Mac Builder (dbg)" | setup_build |
| buildnumber | 154725 | setup_build |
| mastername | "chromium.mac" | setup_build |
| path_config | "generic" | setup_build |
| recipe | "chromium" | setup_build |
| repository | "https://chromium.googlesource.com/chromium/src.git" | setup_build |
| revision | "12eff4b61cea3d1545e3894ded9ee2c5a392d595" | setup_build |
| got_angle_revision | "05459e06fde5047ae8f5f90fe091c3255e6bc88e" | bot_update |
| got_buildtools_revision | "2f02e1f363b1af2715536f38e239853f04ec1497" | bot_update |
| got_dawn_revision | "c0f31e73e481f32d308cb6232e75e6d860d97063" | bot_update |
| got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
| got_revision | "12eff4b61cea3d1545e3894ded9ee2c5a392d595" | bot_update |
| got_revision_cp | "refs/heads/master@{#624987}" | bot_update |
| got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
| got_v8_revision | "72736ac1af838d42f4765d213dee19496f8c563d" | bot_update |
| got_v8_revision_cp | "refs/heads/7.3.482@{#1}" | bot_update |
| got_webrtc_revision | "71b5a7df7794bbc4103296fcd8bd740acebdc901" | bot_update |
| got_webrtc_revision_cp | "refs/heads/master@{#26351}" | bot_update |
| got_clang_revision | "351477-1" | clang_revision |
| isolate_server | "https://isolateserver.appspot.com" | isolate tests |
| swarm_hashes_refs/heads/master(at){#624987}_without_patch | {"accessibility_unittests": "115a7c3a9845806b9000b76bb212416f6fd4213e", "angle_unittests": "0d2a8b82d0b7ff112c526e58cd65eb1bd59a8fe4", "app_shell_unittests": "6a6a238f76e78de281dee7dfed285789559d0fd2", "base_unittests": "a8a2d38d533c997dbc793ccf4d190fd6004dac38", "blink_common_unittests": "4ea1cff2540e4fb526f7ac44848e5f20a5699900", "blink_fuzzer_unittests": "b2a5f4b28714b64985676125ae671de0ff2b31d7", "blink_heap_unittests": "86427096502aed2213089f4fe8b599fb89f9a674", "blink_platform_unittests": "6ca8aec8be9f7f5c293d16f80b9613f93768c306", "boringssl_crypto_tests": "8c07eba86bd4c43166911af97957bc8e712cd754", "boringssl_ssl_tests": "dc508a265197d084504165cc61761c6c99d9cc4e", "browser_tests": "b23ec7ea79060e9d436e38c976f98567825c77d3", "cacheinvalidation_unittests": "9284badb8ef587ba15fd7967df130f976961ccd6", "capture_unittests": "96200cc5cf8e03a98afd365594ca950889e9e260", "cast_unittests": "806b4d92ab057bbf3cb8b79d8565581de91525c0", "cc_unittests": "fa770c29aa066fc0acdb400bf02d5fe6891f19c3", "chrome_app_unittests": "df6809e85d6a5d2cacaa63f24ea327fdd83795e7", "chromedriver_unittests": "95802463df87f96cc4bb38764f68d1b4f6bcb803", "components_browsertests": "efb764b2baf7d70ace506539591bc637885e17c4", "components_unittests": "fcc12757b5d71990adf2055c9a05c6ef1a4067e9", "content_browsertests": "f07cba0d6e4ec6756027fa961c0588d2148d0ab7", "content_shell_crash_test": "622661d5f3a45f6dd9964d4fbcfed3e3ecd6376b", "content_unittests": "176836f64e4c838310c7641e4d83b17a7254d55c", "crashpad_tests": "a61309378bc4bbff4f5d77c65a3af78286d2407a", "cronet_tests": "5369fbdd3de4e357b326fb6f6f8f8299b619fe8d", "cronet_unittests": "ad6089828b30ab45ac018c6a3283b383de80cdd7", "crypto_unittests": "c0946f784f7089451a95b86f179dea99dd05f6ca", "device_unittests": "fca8098d4947886d69bcc962b665b6310aab702d", "display_unittests": "45c41bf5b11f557153708ad9f6de07bb9dfe59dc", "events_unittests": "11e043905caefc8e452aee88d1deb219d25a40ae", "extensions_browsertests": "9a8e0c5727d20f2a1f2a55709e2c2c3fede95049", "extensions_unittests": "4df3676ab49e18750453290dd87f1923b41ecc7f", "filesystem_service_unittests": "833b2df072b218377ef2c37f10a7aae783b414ea", "gcm_unit_tests": "ee85551dfbf51b5962c04f977de27e71ef4f349b", "gfx_unittests": "91c1dedc27a8cfa0e2dc3614f756ca967620d850", "gin_unittests": "66d77a70d933366b0268cd1a1d1aa4a48061cf79", "google_apis_unittests": "021a6d88f6b6d08edbcaec49b95c4e96df6cdd79", "gpu_unittests": "0ccdabe9a61506ea88fedde34d7b7c72a3b212ff", "headless_browsertests": "80702c56748fe4e4443ce139137026bddd18e644", "headless_unittests": "6f5c3fc0b5c6f434f13679e636152adafcf4e59f", "interactive_ui_tests": "fea67d5dd9cd54fcde9cec55b5e20691a283cae8", "ipc_tests": "901c341f1430660d74f4c8cf0ca1a1edd24948de", "jingle_unittests": "274d81d15f9a0755e6fc674a2415ee665a8faf85", "latency_unittests": "1584e19a0046493ee609672c1ce14eebe1e71fd0", "leveldb_service_unittests": "bd7d0585b9bc622056b3b3c867196be9b5449c1f", "libjingle_xmpp_unittests": "558e21ef28e0f4c1b59a9cdf422609a9f88cbd7d", "media_blink_unittests": "43da9819ac58c76b34f228d7af0bcc12989bd879", "media_service_unittests": "0cd3e6d9226139cafda392748edb6a623766d1ef", "media_unittests": "e14fa295ca1862fbeeea3204b23dcb7d62e528c0", "message_center_unittests": "86d2d6bb60ff1780d96e34b9078b2b36a661132f", "metrics_python_tests": "98f876d1d415b9a1e54f7b5c828026606af3d75f", "midi_unittests": "473d4c2ab23e5a98c1d5b82c775c4921d08b21d9", "mojo_unittests": "f7018625bb3e8acc63f06e2214c4d26afebd6a58", "nacl_loader_unittests": "186e14ff980fd7484d8230eaaef662f034ce9b80", "native_theme_unittests": "e939b4f39b191bc88d50666e7906559ffb5ecb04", "net_unittests": "8813bb333ecfdb0e2c099cf55a0e1491ddcfa684", "pdf_unittests": "6b0910bf2ca5f501954fef03ec369a9da171df00", "performance_test_suite": "c675a2348ad2faf4a196cf84e0e9024c6c2053b6", "ppapi_unittests": "738799f61122fb51f17d88ca83ea28f79bbd41af", "printing_unittests": "1f939bc3f4d77f63f1c657e4a7cef8c236f2a41a", "remoting_unittests": "42ce950282f5c008efad0ff736d704f424d8af21", "sandbox_mac_unittests": "ce2e65127adac1f6f3120e58accb1b4c26f5e61d", "service_manager_unittests": "9b8a61562826e394f185f4d09e6d19457d0aee76", "services_unittests": "c3ac549b9a2069595e7c9408e94b6be4f6b583ab", "shell_dialogs_unittests": "3b1e6fa705e6d21e322ae6e02fa05e2064744b03", "skia_unittests": "b826247dc69dfb42bd2812d46f11c7d6d3d98522", "snapshot_unittests": "2c79db604db06ae62fbcc4b15fd2043ef85d5e8b", "sql_unittests": "dc3cb464a68bc5f45355440dde37417785e28353", "storage_unittests": "5a3f43ee13a5f82effb773ab32859edee748b374", "sync_integration_tests": "5d87400ecce3801c0bb25d7b03c9ed93a798a699", "telemetry_gpu_unittests": "13007a5a9465792dcfa4c69bccd1ecd5c92f046a", "telemetry_unittests": "86344f914b32e0b30caf7b5151061c3ea920c50d", "ui_base_unittests": "deb4c4523128d8e5c831d510e3d735a336667c11", "ui_touch_selection_unittests": "d714d26fb14177dcf6a2844576332e7d7ba54af4", "unit_tests": "6c20afdd3cfab4b8ed3579995b77d6ee3e413b4d", "url_unittests": "7567e5944efb03f0c0fef2fa97ffc33a65267a6c", "views_perftests": "331443ab79d78fa099697abc7aab62d8785be6da", "views_unittests": "070d4fb46b428ff766dd0c6b48b729e8476010c6", "viz_unittests": "88f80e18b01a6781e188d514daf074c1dae4e26c", "webkit_layout_tests_exparchive": "5f4288486ee4a2fdf85aaf73a924fd19d1a9e860", "webkit_python_tests": "ad48d827c31cee71a7dd660e109f1fd5c6328a37", "webkit_unit_tests": "fd87fec246400eeb8d2600a64f464bbb9f9cca72", "wtf_unittests": "ed9937cba4ac619d3a2fbe8f5e7f936877c7381e"} | isolate tests |
Blamelist:
- Melissa Zhang (melzhangohnoyoudont@google.com)
- Dale Curtis (dalecurtisohnoyoudont@chromium.org)
- Yuchen Liu (yucliuohnoyoudont@chromium.org)
- Quinten Yearsley (qyearsleyohnoyoudont@chromium.org)
- Vlad Tsyrklevich (vtsyrklevichohnoyoudont@chromium.org)
- Annie Sullivan (sullivanohnoyoudont@chromium.org)
- Steve Anton (steveantonohnoyoudont@chromium.org)
- Hector Carmona (hcarmonaohnoyoudont@chromium.org)
Timing:
| Create | Tuesday, 22-Jan-19 23:44:49 UTC |
| Start | Tuesday, 22-Jan-19 23:44:51 UTC |
| End | Wednesday, 23-Jan-19 00:00:58 UTC |
| Pending | 1 secs |
| Execution | 16 mins 7 secs |
All Changes:
-
Implement App Permission Grant and Revoke for ARC apps.
Changed by Melissa Zhang - melzhangohnoyoudont@google.com Changed at Tuesday, 22-Jan-19 23:42:08 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 12eff4b61cea3d1545e3894ded9ee2c5a392d595 Comments
Implement App Permission Grant and Revoke for ARC apps. This CL adds the arc bridge support and required mojo connections such that Chrome OS can access and call the grant and revoke Android app permission functions that are implemented on ARC. BUG=916380 Change-Id: I1c2d788fb2da3988244b235e7d8850368010117c Reviewed-on: https://chromium-review.googlesource.com/c/1415061 Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Reviewed-by: David Jacobo <djacobo@chromium.org> Commit-Queue: Melissa Zhang <melzhang@google.com> Auto-Submit: Melissa Zhang <melzhang@google.com> Cr-Commit-Position: refs/heads/master@{#624987}
Changed files
- chrome/browser/chromeos/arc/arc_service_launcher.cc
- components/arc/BUILD.gn
- components/arc/app_permissions/arc_app_permissions_bridge.cc
- components/arc/app_permissions/arc_app_permissions_bridge.h
- components/arc/arc_bridge_host_impl.cc
- components/arc/arc_bridge_host_impl.h
- components/arc/arc_bridge_service.h
- components/arc/common/BUILD.gn
- components/arc/common/app_permissions.mojom
- components/arc/common/arc_bridge.mojom
- components/arc/test/fake_arc_bridge_host.cc
- components/arc/test/fake_arc_bridge_host.h
-
Fix broken ContextGL loss for Video SurfaceLayer.
Changed by Dale Curtis - dalecurtisohnoyoudont@chromium.org Changed at Tuesday, 22-Jan-19 23:33:26 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7050ea6a38d4123e12e35e18d7e0412177485624 Comments
Fix broken ContextGL loss for Video SurfaceLayer. Turns out less is more. Presuambly since we're actually getting a real SurfaceID these days, we don't need to call ClearSurfaceID on the layer when context is lost. The remote side seems to restore and resurrect the existing SurfaceID in a way that allows the existing one to continue to work properly once a new frame sink is fetched. This also removes an unnecessary reset of |is_surface_visible_| upon context loss, which does not help anything. You still get green frames if GpuMemoryBuffer's are enabled, but otherwise all frames are displayed again when the new context is retrieved. This all works since UpdateSubmissionState() will either submit a frame or rendering is in action and one will come in soon. TODO: We really need an automated test for ContextLoss to ensure it still works. Will start on that in a separate CL. BUG=746182 TEST=kill gpu process, video resumes. Change-Id: Ic0e480b9788baf4145971be6fe247e431f698c65 Reviewed-on: https://chromium-review.googlesource.com/c/1423463 Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#624986}
Changed files
- content/renderer/media/stream/webmediaplayer_ms.cc
- content/renderer/media/stream/webmediaplayer_ms.h
- content/renderer/media/stream/webmediaplayer_ms_compositor.cc
- content/renderer/media/stream/webmediaplayer_ms_compositor.h
- content/renderer/media/stream/webmediaplayer_ms_unittest.cc
- media/blink/video_frame_compositor.cc
- media/blink/video_frame_compositor.h
- media/blink/video_frame_compositor_unittest.cc
- media/blink/webmediaplayer_impl.cc
- media/blink/webmediaplayer_impl.h
- media/blink/webmediaplayer_impl_unittest.cc
- third_party/blink/public/platform/web_surface_layer_bridge.h
- third_party/blink/public/platform/web_video_frame_submitter.h
- third_party/blink/renderer/platform/graphics/surface_layer_bridge.cc
- third_party/blink/renderer/platform/graphics/surface_layer_bridge.h
- third_party/blink/renderer/platform/graphics/video_frame_submitter.cc
- third_party/blink/renderer/platform/graphics/video_frame_submitter.h
- third_party/blink/renderer/platform/graphics/video_frame_submitter_test.cc
-
[Chromecast] Do not call OnInitialized if video only pipeline
Changed by Yuchen Liu - yucliuohnoyoudont@chromium.org Changed at Tuesday, 22-Jan-19 23:33:13 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a0f73a26ae8cce4b6e1970f6283bea308ac4b170 Comments
[Chromecast] Do not call OnInitialized if video only pipeline Do not call DestructableAudioDecoder::OnInitialized if the pipeline only contains video. Bug: internal b/123249180 Test: Fling video only stream and no crash Change-Id: I8971169719e7fafe4d3f54be07fa6d0b784f04cf Reviewed-on: https://chromium-review.googlesource.com/c/1427923 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#624985}
Changed files
- chromecast/media/cma/backend/media_pipeline_backend_wrapper.cc
-
[tricium cpplint] Disable build/header_guard and runtime/explicit in src
Changed by Quinten Yearsley - qyearsleyohnoyoudont@chromium.org Changed at Tuesday, 22-Jan-19 23:26:35 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 90acfd264e65dc445527a1ad405871fd027f4754 Comments
[tricium cpplint] Disable build/header_guard and runtime/explicit in src The build/header_guard isn't working for the cpplint analyzer right now, which is creating a lot of noise. Disabling runtime/explicit for now because of discussion in https://chromium-review.googlesource.com/c/chromium/src/+/1415258. TBR=maruel TBR_REASON=this is a small config change that should be committed quickly because it fixes an issue that is creating noise for many people. Bug: 924326 Change-Id: Ie904b445cf0babc9f2a61ae5f62734f0b5402d0d Reviewed-on: https://chromium-review.googlesource.com/c/1427932 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#624984}
Changed files
- infra/config/global/tricium-prod.cfg
-
GWP-ASan: Allocate SlotMetadata array dynamically
Changed by Vlad Tsyrklevich - vtsyrklevichohnoyoudont@chromium.org Changed at Tuesday, 22-Jan-19 23:25:14 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d67de4bf7864713373d14216d34e86e4f9695b28 Comments
GWP-ASan: Allocate SlotMetadata array dynamically Dynamically allocating SlotMetadata reduces the amount of memory consumed in the current default configuration by ~6 kilobytes, or about 13% of the GWP-ASan memory overhead. Furthermore, it sets up the following change that eliminates the use of base::debug::StackTrace and places the addresses directly in the SlotMetadata. Bug: 896019, 921237, 923050 Change-Id: Ib60533821011a7aaeccc8278bc0ed7d747474a06 Reviewed-on: https://chromium-review.googlesource.com/c/1427440 Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#624983}
Changed files
- components/gwp_asan/client/guarded_page_allocator.cc
- components/gwp_asan/client/guarded_page_allocator.h
- components/gwp_asan/common/allocator_state.cc
- components/gwp_asan/common/allocator_state.h
- components/gwp_asan/common/allocator_state_unittest.cc
- components/gwp_asan/crash_handler/crash_analyzer.cc
- components/gwp_asan/crash_handler/crash_analyzer.h
- tools/metrics/histograms/enums.xml
-
Add a UserInitiated boolean to PageLoad UKM
Changed by Annie Sullivan - sullivanohnoyoudont@chromium.org Changed at Tuesday, 22-Jan-19 23:23:51 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 496d10a4755317cfeac6349bf88d6270416c37e3 Comments
Add a UserInitiated boolean to PageLoad UKM This counts a load as user-initiated if it's started in the browser, or it's started in the renderer and we can tie it back to the original input event. There are some notable missing cases in the renderer, like back/forward and reload. Bug: 921710 Change-Id: Ibc034fbfa077a73148c9cc93032e8dc4a57dae5f Reviewed-on: https://chromium-review.googlesource.com/c/1423110 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#624982}
Changed files
- chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
- chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
- tools/metrics/ukm/ukm.xml
-
Update include path for renamed WebRTC header file
Changed by Steve Anton - steveantonohnoyoudont@chromium.org Changed at Tuesday, 22-Jan-19 23:18:03 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b56de9d58e6283e33cb14c94baac30963cb41879 Comments
Update include path for renamed WebRTC header file Bug: webrtc:10159 Change-Id: I63b48eb97ad3c22ed34a088979b9355f4c2845cd Reviewed-on: https://chromium-review.googlesource.com/c/1427782 Auto-Submit: Steve Anton <steveanton@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#624981}
Changed files
- third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_crypto_config_factory_impl.h
-
Navi: Enable new onboarding workflow by default on Mac OS.
Changed by Hector Carmona - hcarmonaohnoyoudont@chromium.org Changed at Tuesday, 22-Jan-19 23:11:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7226ec25f1535e89e83bba9c2d6e63a7b4dfbce7 Comments
Navi: Enable new onboarding workflow by default on Mac OS. Bug: 924274 Change-Id: I782ef19e63fb7f42ce909f874e9932d8d7f3cbd6 Reviewed-on: https://chromium-review.googlesource.com/c/1420017 Reviewed-by: Dan Beam <dbeam@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#624980}
Changed files
- chrome/browser/ui/webui/welcome/nux_helper.cc