Builder Mac Builder (dbg)
Build 154712
Results:
Success
Trigger Info:
| Project | chromium |
| Revision | 534ec06a02f60082011726cba1150a5dd7a0ab34 |
| Got Revision | 534ec06a02f60082011726cba1150a5dd7a0ab34 |
Execution:
- Source: Task 428f654d8bcbf110
- Bot: vm35-m9
- Recipe: chromium
Steps and Logfiles:
Show:-
- - no logs -
-
( 933 ms ) read test spec (chromium.mac.json)path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.mac.json
-
( 623 ms ) lookup GN argsffmpeg_branding = "Chrome"is_component_build = trueis_debug = trueproprietary_codecs = truestrip_absolute_paths_from_debug_symbols = truesymbol_level = 1use_goma = truegoma_dir = "/b/s/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
Build Properties:
| Name | Value | Source |
|---|---|---|
| $recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
| $recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
| bot_id | "vm35-m9" | setup_build |
| branch | "refs/heads/master" | setup_build |
| buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548177621527213, "id": "8923611818287748064", "project": "chromium", "tags": ["builder:Mac Builder (dbg)", "buildset:commit/git/534ec06a02f60082011726cba1150a5dd7a0ab34", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/534ec06a02f60082011726cba1150a5dd7a0ab34", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089041880440292080", "scheduler_job_id:chromium/Mac Builder (dbg)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
| buildername | "Mac Builder (dbg)" | setup_build |
| buildnumber | 154712 | setup_build |
| mastername | "chromium.mac" | setup_build |
| path_config | "generic" | setup_build |
| recipe | "chromium" | setup_build |
| repository | "https://chromium.googlesource.com/chromium/src.git" | setup_build |
| revision | "534ec06a02f60082011726cba1150a5dd7a0ab34" | setup_build |
| got_angle_revision | "c81e7bfeb5580726f995776ed04fc4517d6d9c27" | bot_update |
| got_buildtools_revision | "2f02e1f363b1af2715536f38e239853f04ec1497" | bot_update |
| got_dawn_revision | "c0f31e73e481f32d308cb6232e75e6d860d97063" | bot_update |
| got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
| got_revision | "534ec06a02f60082011726cba1150a5dd7a0ab34" | bot_update |
| got_revision_cp | "refs/heads/master@{#624808}" | bot_update |
| got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
| got_v8_revision | "4144ab42ee423306521d60ae5210eecd9ee1e077" | bot_update |
| got_v8_revision_cp | "refs/heads/7.3.474@{#1}" | bot_update |
| got_webrtc_revision | "71b5a7df7794bbc4103296fcd8bd740acebdc901" | bot_update |
| got_webrtc_revision_cp | "refs/heads/master@{#26351}" | bot_update |
| got_clang_revision | "351477-1" | clang_revision |
| isolate_server | "https://isolateserver.appspot.com" | isolate tests |
| swarm_hashes_refs/heads/master(at){#624808}_without_patch | {"accessibility_unittests": "00a1f8d71eac677556502aed7b7e5fc620db5867", "angle_unittests": "1ea3b7d2d20332389a812e8d4fc326023114a30c", "app_shell_unittests": "d4f30fd9e694f980c342a65666d44308ab17d7b5", "base_unittests": "efa56d8ef3d3e9554cd3addc3424fcbe6b6ad5f8", "blink_common_unittests": "6c6ae77b16005a17d083e2928504217cb593ac43", "blink_fuzzer_unittests": "ffb4cba5978a4a791eabbf61d920b12970c04585", "blink_heap_unittests": "79222bf88ff882650632d99233abf2046264dfa5", "blink_platform_unittests": "930eba4a6a7f87683a67684485beced258ec439e", "boringssl_crypto_tests": "0ae50b4d1fbfd1ed893bf3c5faa713a89abbd52d", "boringssl_ssl_tests": "29d345d2fd7f014a2fbc78c020f50e42f4eafed6", "browser_tests": "60e7fe387e8a17d8a57e40598943ca665f2aa478", "cacheinvalidation_unittests": "61c04fea328a9efb097a750fb29cbab5ee165932", "capture_unittests": "6deaf29843fcaeea8cb1f18d8bcb22ec9a7d65b8", "cast_unittests": "9eb6b05bea9f2195af26b7028fdaf463a036efd3", "cc_unittests": "5e3a0b163abe1686eaf42969b028210c5039ffa4", "chrome_app_unittests": "66f5fd5d05e8df840d5226e081c160fc4a96416d", "chromedriver_unittests": "cddc302f2351099d27e6f5e9876b10153f8e7497", "components_browsertests": "cedebc0c4a2f0bff626989e1e94099e15fbcc440", "components_unittests": "22fe0a84d93908e9c3b17292c12fce2b73962011", "content_browsertests": "3df39e0d296f375bb37bc5e08ca5e52820c19d15", "content_shell_crash_test": "bdb40accaaa9d896fd182198ecefded12d43fe22", "content_unittests": "286e200f9ad51a539b24aada7bc6d2300fd808db", "crashpad_tests": "5e77a6c8697cc7092739a66046205b5f98bf3129", "cronet_tests": "ed571aabb460328187c11cea369512565a1b1962", "cronet_unittests": "b6aab1ddb73ff698c90967aead1af308992e7e0f", "crypto_unittests": "074bb1b95d969e04b8af5f81c38fac7d0365404b", "device_unittests": "f410f24d6af46499e49abcd546c8c74ba8d1b770", "display_unittests": "38beb724eac61311822de63a30528e17cda3537e", "events_unittests": "0e3b6cb732f18b9130036d8fd79769ba82a07cb3", "extensions_browsertests": "a4f8bde0b767888cb7f8247e6456ae44d5864fd7", "extensions_unittests": "a831c1dd54980569c81cba6befe7a347a22ab474", "filesystem_service_unittests": "cc021acb2ca3b33ddd4242f9695a1fc6b37a5c51", "gcm_unit_tests": "e4b8e616c07431b5c1e64479cff2a2b5e02eb08f", "gfx_unittests": "aa98ab4541cf40fde201e2a5b25bd8114e40a4ce", "gin_unittests": "565f34b485599eed5a818ac2178f6bb8b9efead2", "google_apis_unittests": "ec2e8ebf59d0cfd75a2abe6fd244fd279c2b9d14", "gpu_unittests": "ed7a7663b8ce9aa4aee9419ef9a650e9e67daefd", "headless_browsertests": "503b5b30cbda6d212b38a8484d78201237bfdd2e", "headless_unittests": "d9ddbd9eb3a7c2535b56f66cba2c44ddbc018f2e", "interactive_ui_tests": "2f76b1dd07365961b995b4f7bc07808aa8f72ecb", "ipc_tests": "dca1e3780359da2378f5495dcea3ffab503dba3e", "jingle_unittests": "5139657ed834a023949d40795ed211d2e585a574", "latency_unittests": "a755c72fe2cc0556f9a37c5808bc2c297a00bb34", "leveldb_service_unittests": "ba8083f6d8b3c218ff80e248ac659ba24476fbed", "libjingle_xmpp_unittests": "dac6047afcd9193302d8feea6874105994ed8bd7", "media_blink_unittests": "5dba5751e5b9d1d133b86a4f69597d59ba16d54f", "media_service_unittests": "3d9f09d2bb5d84af9242151b272cae7e254da1b3", "media_unittests": "150a3bf9ae9768292cd20c0063ddfe67ba8351ba", "message_center_unittests": "7d9aa2e4fdddb75c6776cb9b6fcfa5e302dfb466", "metrics_python_tests": "98f876d1d415b9a1e54f7b5c828026606af3d75f", "midi_unittests": "eb63be132096a71d636089d0c204b3f246802b3e", "mojo_unittests": "346045c2a92fc778a63916343ddfe946ec24c3e1", "nacl_loader_unittests": "7843cb5a9461935474ac5088560d76467cbc9697", "native_theme_unittests": "e8faa26215cd76d19ab08d9a820b061c10e10eaf", "net_unittests": "1e10a11498ba1089c2aa5ff48bbe97cf29de4d80", "pdf_unittests": "31743523288df798eefa9008bc9c1db04f39c18f", "performance_test_suite": "2e4e58a03660f8819656f978febc74f2ff48e907", "ppapi_unittests": "c2ba3e7248272e33c1e4e252fc7dad33fb6e48f8", "printing_unittests": "d531da8cfef8a0316129c5334708e85be0b109d7", "remoting_unittests": "c98dec7cc004378c093bb50abb10dd390d519dcd", "sandbox_mac_unittests": "ccc28419641a5a38eeadac1f13a96c0e871a930e", "service_manager_unittests": "bf96f7b572e24bdba1ac130e186ed87ae60eb78e", "services_unittests": "9f83bd7677369d2e5f8909134cf25b5a488565a8", "shell_dialogs_unittests": "174c1b9b58eed074eeaeb00a4d4741a2e9d6f32d", "skia_unittests": "06bcd28e2c18b25df361f239faf7dd6ca4aa5902", "snapshot_unittests": "b8749e4bed7a583fe5ebde463cf3ff58f0b25630", "sql_unittests": "97d06207615c62184409fe82651a39f9df715721", "storage_unittests": "b58cc7f894369fe48f33b515bce29a51779939f8", "sync_integration_tests": "a5e53f9968001f7d710d992dabee5bc36fccd0df", "telemetry_gpu_unittests": "12c6d1dece83c66ccfd320a1bc75f663be8311f7", "telemetry_unittests": "baa7224d33d67c30122a8ad55533c51e5fcaf8f2", "ui_base_unittests": "51cd4ab33ab6ec9fa7c3ea33114e05d38d5997f7", "ui_touch_selection_unittests": "4690ed82f6a115ddc909758b1cd77d567f44901b", "unit_tests": "fc0220a75f3cb444cfbad2e94652ecabc490751b", "url_unittests": "0f1e9458d9f845107475fa049ec620ad75933322", "views_perftests": "109176a1dd5316bdf239ee4369a6d1842f881b45", "views_unittests": "77915e777fbb2da32081aa8e06aafad0e184b7ee", "viz_unittests": "14a8deef71207e0d9c43553a339d130506b3a76f", "webkit_layout_tests_exparchive": "8e26d26c4419272a69267cbdf8f9080080bcf372", "webkit_python_tests": "dcb58e3f78ac7140f4b9a2a49a19f5cd1ffe9c7c", "webkit_unit_tests": "3db61ae1f5e04ba6d8bfcf461aaaa018d9def29b", "wtf_unittests": "5b13b5808f3bf74b101dcbea0deec4e1c9250f77"} | isolate tests |
Blamelist:
- Prabir Pradhan (prabirmspohnoyoudont@google.com)
- Gauthier Ambard (gambardohnoyoudont@chromium.org)
- Christian Fremerey (chfremerohnoyoudont@chromium.org)
- Clemens Arbesser (arbesserohnoyoudont@google.com)
- Xiyuan Xia (xiyuanohnoyoudont@chromium.org)
- Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
Timing:
| Create | Tuesday, 22-Jan-19 17:20:21 UTC |
| Start | Tuesday, 22-Jan-19 17:20:23 UTC |
| End | Tuesday, 22-Jan-19 17:35:36 UTC |
| Pending | 1 secs |
| Execution | 15 mins 12 secs |
All Changes:
-
Assume key handled if expired
Changed by Prabir Pradhan - prabirmspohnoyoudont@google.com Changed at Tuesday, 22-Jan-19 17:18:58 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 534ec06a02f60082011726cba1150a5dd7a0ab34 Comments
Assume key handled if expired Previously, all key events would be acknowledged with a handled or unhandled notification. If chrome did not recieve such a notification for a key by the expiration time, chrome would process the accelerator as if the key was unhandled. Since android is no longer sending handled notifications and is only sending dropped or unhandled notifications, we change the logic to assume that all keys are handled unless we recieve a notification saying otherwise. Therefore when the key event expires, we do not process the accelerator. Since accelerators are no longer processed for exprired keys, there are no publicly detectable changes that take place for expired keys, and so the corresponding unit tests are removed. Bug: b/119312287 Change-Id: I5f1740755f84f62fc559ba924a9d36e1e81822b2 Reviewed-on: https://chromium-review.googlesource.com/c/1396152 Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#624808}
Changed files
- components/exo/keyboard.cc
- components/exo/keyboard_unittest.cc
- third_party/wayland-protocols/unstable/keyboard/keyboard-extension-unstable-v1.xml
-
[iOS] Convert the last NTP test to EG
Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org Changed at Tuesday, 22-Jan-19 17:16:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d65fc736ecc01152176a96099a9258334f3a9ddb Comments
[iOS] Convert the last NTP test to EG This CL converts the last Franky tests to EarlGrey. This follows https://chromium-review.googlesource.com/c/1392089. Bug: 904865 Change-Id: I6542ad757ea4792c8357a22d5c9cf7e3bb0232d0 Reviewed-on: https://chromium-review.googlesource.com/c/1424844 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#624807}
Changed files
- ios/chrome/browser/ui/content_suggestions/BUILD.gn
- ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h
- ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
- ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm
-
[Video Capture, Android] Enable more integration test cases using the video capture service
Changed by Christian Fremerey - chfremerohnoyoudont@chromium.org Changed at Tuesday, 22-Jan-19 17:14:54 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 28ea6e81ad0b1d0223ca8b2d8773a349da168562 Comments
[Video Capture, Android] Enable more integration test cases using the video capture service Certain integration test cases had been disabled for Android, because Android did not yet have a working configuration of the video capture service. Since a working configuration is now already available, these test cases can and should be enabled. Test: out/android_release/bin/run_content_browsertests --gtest_filter=*ReceiveFramesFromFakeCaptureDevice* Bug: 792621 Change-Id: I139cd3b9089559285a63a94341dbe79d88cfabc7 Reviewed-on: https://chromium-review.googlesource.com/c/1423319 Reviewed-by: Weiyong Yao <braveyao@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#624806}
Changed files
- content/browser/renderer_host/media/video_capture_browsertest.cc
-
[Autofill Assistant] The payment request now has radio buttons to agree to or review the 3rd party terms&conditions.
Changed by Clemens Arbesser - arbesserohnoyoudont@google.com Changed at Tuesday, 22-Jan-19 17:13:54 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d9e46ea106944b69c602d102025c8c22c85512a2 Comments
[Autofill Assistant] The payment request now has radio buttons to agree to or review the 3rd party terms&conditions. Initially, both radio buttons are unchecked. The 'continue' button is only enabled if a choice has been made. Previously, the choice was implicitly 'review'. old: https://screenshot.googleplex.com/BJXrr4U3C7Z.png new, initial: https://screenshot.googleplex.com/dwVsriFyp1L.png new, select 'agree': https://screenshot.googleplex.com/WRLOqYmfkDj.png new, select 'review': https://screenshot.googleplex.com/mekEFS29C4K.png Bug: 806868 Change-Id: I5e04c6089337546752c87130274ed570124cabc5 Reviewed-on: https://chromium-review.googlesource.com/c/1411997 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by: Mathias Carlen <mcarlen@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#624805}
Changed files
- chrome/android/java/res_autofill_assistant/drawable/autofill_assistant_lightblue_rect_bg.xml
- chrome/android/java/res_autofill_assistant/layout/autofill_assistant_payment_request.xml
- chrome/android/java/res_autofill_assistant/values-v17/colors.xml
- chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/payment/AutofillAssistantPaymentRequest.java
- chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/payment/PaymentRequestUI.java
- chrome/android/java/strings/android_chrome_strings.grd
-
Fix the missing IME candidate window
Changed by Xiyuan Xia - xiyuanohnoyoudont@chromium.org Changed at Tuesday, 22-Jan-19 17:13:51 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 2515f154344593adc5bd81f9dce036d5845dbe58 Comments
Fix the missing IME candidate window https://crrev.com/c/1396794 moves IME candidate to VK container managed by KeyboardLayoutManager. KeyboardLayoutManager was expecting only the VK contents window and blocks bounds change for all other windows. As a result, IME candidate window bounds change is ignored. This CL fixes the issue by making the layout manager to allow other windows to change bounds. Bug: 921689 Change-Id: I351543fc3129425e01773798f4abc08cf9d5e684 Reviewed-on: https://chromium-review.googlesource.com/c/1423298 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#624804}
Changed files
- ui/keyboard/keyboard_layout_manager.cc
-
Copy-on-write when combining RuleFeatureSet.
Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org Changed at Tuesday, 22-Jan-19 17:12:25 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision fc186cc264765c1574bc5cd526865236aa24a9cf Comments
Copy-on-write when combining RuleFeatureSet. Currently, when adding local RuleFeatureSets to the global RuleFeatureSet, we effectively create copies of the incoming InvalidationSets, even for keys where we don't have a value. It is commonly very little overlap between (local) RuleFeatureSets, which means most of the InvalidationSets we end up with in the global RuleFeatureSet are not the result of combining two (or more) local InvalidationSets, but rather just a copy of the one-and-only InvalidationSet for that key. In this CL, we delay the copying of the first InvalidationSet until we actually need to combine it with another InvalidationSet (or otherwise modify it). This saves about 350kB of memory on facebook.com, which is about 44% of the memory used by InvalidationSet instances (and their HashSet backings). Change-Id: Idc34c109c0f2a5643c01b472357309cf9a252daa Reviewed-on: https://chromium-review.googlesource.com/c/1424877 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#624803}
Changed files
- third_party/blink/renderer/core/css/rule_feature_set.cc
- third_party/blink/renderer/core/css/rule_feature_set.h
- third_party/blink/renderer/core/css/rule_feature_set_test.cc
