Builder Mac Builder (dbg)
Build 154661
Results:
Success
Trigger Info:
Project | chromium |
Revision | b4f6394dcd59d8697e154c2e2c74eb85284f2e4b |
Got Revision | b4f6394dcd59d8697e154c2e2c74eb85284f2e4b |
Execution:
- Source: Task 428b72b67fc4e910
- Bot: vm35-m9
- Recipe: chromium
Steps and Logfiles:
Show:-
- - no logs -
-
( 940 ms ) read test spec (chromium.mac.json)path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.mac.json
-
( 627 ms ) lookup GN argsffmpeg_branding = "Chrome"is_component_build = trueis_debug = trueproprietary_codecs = truestrip_absolute_paths_from_debug_symbols = truesymbol_level = 1use_goma = truegoma_dir = "/b/s/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "vm35-m9" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548111391865048, "id": "8923681265122006608", "project": "chromium", "tags": ["builder:Mac Builder (dbg)", "buildset:commit/git/b4f6394dcd59d8697e154c2e2c74eb85284f2e4b", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/b4f6394dcd59d8697e154c2e2c74eb85284f2e4b", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089111327343577552", "scheduler_job_id:chromium/Mac Builder (dbg)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "Mac Builder (dbg)" | setup_build |
buildnumber | 154661 | setup_build |
mastername | "chromium.mac" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
repository | "https://chromium.googlesource.com/chromium/src.git" | setup_build |
revision | "b4f6394dcd59d8697e154c2e2c74eb85284f2e4b" | setup_build |
got_angle_revision | "c81e7bfeb5580726f995776ed04fc4517d6d9c27" | bot_update |
got_buildtools_revision | "2f02e1f363b1af2715536f38e239853f04ec1497" | bot_update |
got_dawn_revision | "c0f31e73e481f32d308cb6232e75e6d860d97063" | bot_update |
got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
got_revision | "b4f6394dcd59d8697e154c2e2c74eb85284f2e4b" | bot_update |
got_revision_cp | "refs/heads/master@{#624687}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "2ac265ceefda517d15eddbfff7f77a2959908123" | bot_update |
got_v8_revision_cp | "refs/heads/7.3.468@{#1}" | bot_update |
got_webrtc_revision | "74ba99062c48b278675cfe52643719202296fddc" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26298}" | bot_update |
got_clang_revision | "351477-1" | clang_revision |
isolate_server | "https://isolateserver.appspot.com" | isolate tests |
swarm_hashes_refs/heads/master(at){#624687}_without_patch | {"accessibility_unittests": "f91eaeb68af0613740c11d0a936f9f2ea08ea7ba", "angle_unittests": "ffc391f6866643559803c1142f06c4d73e3a86d0", "app_shell_unittests": "530f23e4f3b9c77ba860ced0c92d6de51565f21d", "base_unittests": "aefb6a789a304cd0fc22a8a16c6babf88b317384", "blink_common_unittests": "ba305c310e7c123eb179b6e5a680a23a45300057", "blink_fuzzer_unittests": "fc59979458ad63c98ca026004b3a8b0f7eab788d", "blink_heap_unittests": "13ec72d95d616c5d57afcceaac20f88335ee677c", "blink_platform_unittests": "bde3ffcda32ab2e4cf29e964c7b29554878adbed", "boringssl_crypto_tests": "2bdd9e04b3e520274ba788fbf1a12895327c8592", "boringssl_ssl_tests": "c540359d32a99520db31f09f27e46c10cd37f093", "browser_tests": "c22e05f631bafafee486cde2e16bde19471ad099", "cacheinvalidation_unittests": "416b1d549926f518e2e58030939c91d35b656e5a", "capture_unittests": "dab5738c7fd274498ae27197652a8617ef77e619", "cast_unittests": "853b76957c55353a96e29dc5b463e49fb1e2752f", "cc_unittests": "07dd1346df2b53a8f4ef62bf51a1519f4c8528f1", "chrome_app_unittests": "8c31826b9a1c242121b96eba493fd2fc544af16b", "chromedriver_unittests": "768289a4e87b4b1bfd79e19bb20cd056f2ec8fe6", "components_browsertests": "8ca41086847234d5288ae957a0b84bf02a63b888", "components_unittests": "2ab3370905f2cc3536d6758ce4491b06894a39f2", "content_browsertests": "14bb3344ac91b5ac9bf6d0ad6c0eb69923a2c0e2", "content_shell_crash_test": "116bfc0bdfc651d60ba8e02d26d49eb63d1ac8e1", "content_unittests": "13bec6f5c181ee555307f53a99a52ec3fa1a8885", "crashpad_tests": "7e3e40a18c49cad92567370988f7d31430990337", "cronet_tests": "6418e058d653f9d63ee0098e9a15e76447cb6ef5", "cronet_unittests": "f0ee6bc0105ea9212cb98093d68f897609e1f4f1", "crypto_unittests": "566138f9cab76d41c1ed17dd23490f7e41581b42", "device_unittests": "22f702541aed419eb4dae73378e21f1332757b06", "display_unittests": "04f91e944f82bb56f90dc8640d6dce7117379283", "events_unittests": "acdfe7e443681dbce51ac2620d97ee78f96cbd6b", "extensions_browsertests": "4fb650293ae9aa699792152d4e2eafd0aabe2214", "extensions_unittests": "a93e679c95fb3bc904485c20be07d07056eb5101", "filesystem_service_unittests": "6d06c01e6062b1ea6c4a2401b9cb2b2596927a89", "gcm_unit_tests": "427df5ade7fcb99aa8cb83ddf2ef82183ca82c36", "gfx_unittests": "36b6d13cdcf5efee6d5a3efd91b8d0e7029477a7", "gin_unittests": "eb3bf68086eb0529dfece19ed3e4bb75c37fb896", "google_apis_unittests": "8a8b27171805be53d01e289778e9a571840c78a7", "gpu_unittests": "1a0bdf3cc094a357a6c47c0a5fe0d66d2c62dd2f", "headless_browsertests": "329d5080b747692f5f3b661b1e316b51970b04ae", "headless_unittests": "fc1a09662322cd45bbc3e99ccf5e89a5d5a02301", "interactive_ui_tests": "d9b3f1bd3c2b305e166cc3d9724c98c37b4c76b2", "ipc_tests": "17ce196f99e65704006a204ecbadc44faa388c54", "jingle_unittests": "4c4f590403426db0be0ddef2a008ce530539fede", "latency_unittests": "25a111247e59a9654741df864aed40d356f49311", "leveldb_service_unittests": "8b44afffd77cf32f0fd793e17c8b0c7560f1b496", "libjingle_xmpp_unittests": "709744918385266b834386527b810f977597ac9c", "media_blink_unittests": "bf4db20786621f353670ca883b73597193e7dd7b", "media_service_unittests": "6d9c3261e05ec67883a142b5fed7bd028052dacc", "media_unittests": "76d04417c0658996894e4a8d5029a00ea4ee74c2", "message_center_unittests": "6b9cafbeb415f8dd84c89d43d252d0ef4ed66a1f", "metrics_python_tests": "98f876d1d415b9a1e54f7b5c828026606af3d75f", "midi_unittests": "1662f4bccc3695e87c325a49baa92842576d22fc", "mojo_unittests": "fe1acc575076f69dcfb33a8be9db56d1795e3072", "nacl_loader_unittests": "fb700bfd2f0753f71de401923875cd35c6fad4af", "native_theme_unittests": "11a2f9b8bbed8e916802bd4579f85482619a6a5d", "net_unittests": "556fe666e4f51851796cccb027cc5916ebf70244", "pdf_unittests": "f83d4f071b88bed3bd873013d4e8bb6b4fcda214", "performance_test_suite": "b407fc6004c788f5255ee25acbc7e68fa2c7b484", "ppapi_unittests": "511a293f9da56bd6c347a6e2c1958985cc4abdd9", "printing_unittests": "0852f7da860a3ce0c363320f8a7489e8aadce011", "remoting_unittests": "bc60f5f452a38e30f5abae538b618d8e1e0d9e8e", "sandbox_mac_unittests": "3c0f254a85fe68fe699f2a53bafe26ed875ab714", "service_manager_unittests": "88f6b193b95ebd60f0c1f5bb066417f7fd7ff276", "services_unittests": "b1f2ee359d44ed7cb6eb7c1a4ab087d163e65773", "shell_dialogs_unittests": "06c2fcacce70375f747bf2533693dd6cd7063a4f", "skia_unittests": "bc8fb766d7e4122cf59f5b205afac8cc3f152136", "snapshot_unittests": "47b5b6eb0374514e6cd3130e2fbd696869587de8", "sql_unittests": "d43e3789dcf18db368e4ca7280158a6678d8a634", "storage_unittests": "90c78023f99bac4dc065373ea4577b20b60bd4db", "sync_integration_tests": "cd04fef7708b44f40d283dffd0c7a4d67a0d596b", "telemetry_gpu_unittests": "fff3b889ba09546f5896aaf005485510caa751cd", "telemetry_unittests": "7e2b60afcb1be6c559b1f646ce306e03a43da707", "ui_base_unittests": "2c0bf196fa33d952cbe6214a2b616f3413f6e23c", "ui_touch_selection_unittests": "dc7c8fc1fbee834bc96747db972e59478a2f6348", "unit_tests": "6a825d8aeda0b28e754a08e1ec39ca3cc7516dee", "url_unittests": "dcbef11df0a2d956baabfbba4ba9dbdca32a5842", "views_perftests": "b66903f4282bbf96ad423d61a3fefdee82c3948a", "views_unittests": "20cb0d25b0be0fd704dca1c6661ade183bde93e1", "viz_unittests": "392f096a2f0339f8a622b041ba6e0628557ed4f2", "webkit_layout_tests_exparchive": "f5b4b0fa7ae8ba655c2a5c254b3952a544066133", "webkit_python_tests": "6358e3958164c69a9b84f9db445da148d780d217", "webkit_unit_tests": "ca60a6ccae309a5918c0bc07bd2bef9164d10c18", "wtf_unittests": "110ae4277e7ce7fa0eabc7fdc9e41c72ea956538"} | isolate tests |
Blamelist:
- Mike Wasserman (mswohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Lukasz Anforowicz (lukaszaohnoyoudont@chromium.org)
Timing:
Create | Monday, 21-Jan-19 22:56:31 UTC |
Start | Monday, 21-Jan-19 22:56:33 UTC |
End | Monday, 21-Jan-19 23:13:56 UTC |
Pending | 1 secs |
Execution | 17 mins 22 secs |
All Changes:
-
mash: content: changes RenderWidgetHostInputEventRouter hit test querying
Changed by Mike Wasserman - mswohnoyoudont@chromium.org Changed at Monday, 21-Jan-19 22:38:35 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b4f6394dcd59d8697e154c2e2c74eb85284f2e4b Comments
mash: content: changes RenderWidgetHostInputEventRouter hit test querying Rebase of sky@'s < http://crrev.com/c/1239454 >. Also, make FindTargetForLocationStartingFromImpl virtual for testing. Original description: ===================================================================== Specifically this converts from starting the hit testing from the root to hit testing from the frame-sink of the RenderWidgetHost. As the event is already received by the RenderWidgetHost hit testing can start from there, rather than the root. This matters in the mash case because of hot hit testing works. ===================================================================== TODO: After this change, we may be able to revert http://crrev.com/c/1249152 (sky@ suggested this should be possible, but it breaks SPM iframe targeting afaict) Bug: 879791, 920931 Test: SingleProcessMash web content (w/iframe) hit testing works with a11y magnifier. Change-Id: Ie6c53ecfdba9444c62a9b3e3a7f573f0ec27ce6b Reviewed-on: https://chromium-review.googlesource.com/c/1411650 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Ria Jiang <riajiang@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#624687}
Changed files
- components/viz/host/hit_test/hit_test_query.cc
- components/viz/host/hit_test/hit_test_query.h
- components/viz/host/hit_test/hit_test_query_unittest.cc
- content/browser/renderer_host/render_widget_host_input_event_router.cc
- content/browser/renderer_host/render_widget_host_input_event_router_unittest.cc
-
Roll src/third_party/skia 02738a86e5fd..792038755ad4 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Monday, 21-Jan-19 22:35:33 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision de718d93a2e5ad380e423cfbd0afa6b4255736eb Comments
Roll src/third_party/skia 02738a86e5fd..792038755ad4 (1 commits) https://skia.googlesource.com/skia.git/+log/02738a86e5fd..792038755ad4 git log 02738a86e5fd..792038755ad4 --date=short --no-merges --format='%ad %ae %s' 2019-01-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 9d6cc12318d2..9eca44242f7b (155 commits) Created with: gclient setdep -r src/third_party/skia@792038755ad4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: Ib3a1e492e11e5fb1b191b5267973d61609eeb1a1 Reviewed-on: https://chromium-review.googlesource.com/c/1426038 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624686}
Changed files
- DEPS
-
CanAccessDataFromOrigin(..., initiator) in AppCacheSubresourceURLFactory
Changed by Lukasz Anforowicz - lukaszaohnoyoudont@chromium.org Changed at Monday, 21-Jan-19 22:29:50 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1b43ef7815413edac4400dadfe3701d7818cfd12 Comments
CanAccessDataFromOrigin(..., initiator) in AppCacheSubresourceURLFactory This reverts commit 912f47b4715551b4db57f8ed8bed05a83144c2f7 and tries another approach for protecting network::ResourceRequest::request_initiator against compromised renderers. In the new approach: 1. AppCacheHost stores the renderer process id it is associated with. 2. AppCacheSubresourceURLFactory uses the process id to verify request_initiator via ChildProcessSecurityPolicyImpl::CanAccessDataFromOrigin. 3. The process id needs to be provided to AppCacheHost in 3 scenarios (not counting unit tests): 3.1. SharedWorkerServiceImpl::CreateWorker already has a process id 3.2. AppCacheBackendImpl::RegisterHost also already has a process id 3.3. NavigationHandleImpl::InitAppCacheHandle runs when navigation starts and doesn't have a process yet. In this scenario ChildProcessHost::kInvalidUniqueID is passed to AppCacheHost's constructor and the real process id is provided later, once NavigationHandleImpl::ReadyToCommitNavigation knows the target process for the navigation. - This delay is okay, because AppCacheHost::process_id() is only consulted from AppCache*Subresource*URLFactory which is only used for subresources and not for navigations. - The delay involves a thread hop - this is also okay, because the task that will set the process id is posted to the IO thread *before* a Commit IPC is sent down to the renderer (and therefore subresource requests from the renderer will come *after* that task). Bug: 910287 Change-Id: Icb59e7247231373490c6fc79ae0c39a5af1c1a87 Reviewed-on: https://chromium-review.googlesource.com/c/1419015 Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ćukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#624685}
Changed files
- content/browser/appcache/appcache_backend_impl.cc
- content/browser/appcache/appcache_group_unittest.cc
- content/browser/appcache/appcache_host.cc
- content/browser/appcache/appcache_host.h
- content/browser/appcache/appcache_host_unittest.cc
- content/browser/appcache/appcache_navigation_handle.cc
- content/browser/appcache/appcache_navigation_handle.h
- content/browser/appcache/appcache_navigation_handle_core.cc
- content/browser/appcache/appcache_navigation_handle_core.h
- content/browser/appcache/appcache_subresource_url_factory.cc
- content/browser/appcache/appcache_unittest.cc
- content/browser/appcache/appcache_update_job_unittest.cc
- content/browser/frame_host/navigation_handle_impl.cc
- content/browser/loader/cross_site_document_blocking_browsertest.cc
- content/browser/worker_host/shared_worker_service_impl.cc