Builder Mac Builder (dbg)
Build 154658
Results:
Success
Trigger Info:
Project | chromium |
Revision | 6b47cef80ff0f4a5eda85a276b8f61efb65a230d |
Got Revision | 6b47cef80ff0f4a5eda85a276b8f61efb65a230d |
Execution:
- Source: Task 428b0f26deb7e310
- Bot: vm35-m9
- Recipe: chromium
Steps and Logfiles:
Show:-
- - no logs -
-
( 975 ms ) read test spec (chromium.mac.json)path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.mac.json
-
( 631 ms ) lookup GN argsffmpeg_branding = "Chrome"is_component_build = trueis_debug = trueproprietary_codecs = truestrip_absolute_paths_from_debug_symbols = truesymbol_level = 1use_goma = truegoma_dir = "/b/s/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "vm35-m9" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548104867155777, "id": "8923688106775906208", "project": "chromium", "tags": ["builder:Mac Builder (dbg)", "buildset:commit/git/6b47cef80ff0f4a5eda85a276b8f61efb65a230d", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/6b47cef80ff0f4a5eda85a276b8f61efb65a230d", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089118168867958880", "scheduler_job_id:chromium/Mac Builder (dbg)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "Mac Builder (dbg)" | setup_build |
buildnumber | 154658 | setup_build |
mastername | "chromium.mac" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
repository | "https://chromium.googlesource.com/chromium/src.git" | setup_build |
revision | "6b47cef80ff0f4a5eda85a276b8f61efb65a230d" | setup_build |
got_angle_revision | "bf433727853d2330412766bfeb0611c1c0c1e55a" | bot_update |
got_buildtools_revision | "2f02e1f363b1af2715536f38e239853f04ec1497" | bot_update |
got_dawn_revision | "c0f31e73e481f32d308cb6232e75e6d860d97063" | bot_update |
got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
got_revision | "6b47cef80ff0f4a5eda85a276b8f61efb65a230d" | bot_update |
got_revision_cp | "refs/heads/master@{#624672}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "504b12e5c45dddb048ad638d6f1611af9704e716" | bot_update |
got_v8_revision_cp | "refs/heads/7.3.465@{#1}" | bot_update |
got_webrtc_revision | "74ba99062c48b278675cfe52643719202296fddc" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26298}" | bot_update |
got_clang_revision | "351477-1" | clang_revision |
isolate_server | "https://isolateserver.appspot.com" | isolate tests |
swarm_hashes_refs/heads/master(at){#624672}_without_patch | {"accessibility_unittests": "aed3f2e4c00aa3b8c601c2c2e1de51aad389c0e2", "angle_unittests": "e82087648e91b014c72503dc2521aed01933e4e8", "app_shell_unittests": "dffb17cf429b21d49308c64d6adea3f8b6e43dea", "base_unittests": "d5f70571a7b92ce1ef26ff173b54332091e2da4a", "blink_common_unittests": "e67aecabe1b3b702da80041703ff65e4c8d3501f", "blink_fuzzer_unittests": "247c25a292bdd74d8f4684ddc09ac4c8c984bebb", "blink_heap_unittests": "0244bafafd01f24fdd145ab2ff176ddace86043b", "blink_platform_unittests": "67fe67c7c886504cca21d873434ffb4f223c3849", "boringssl_crypto_tests": "a1f244e2a3c6174ad000884991f1bf425db8680e", "boringssl_ssl_tests": "734e76a3a3b8d947e687252fa097541e995f2ec8", "browser_tests": "0cf2fd814924628f026efbf462111ef338af96a2", "cacheinvalidation_unittests": "80b75d731632a840651f818e5509587df22a4f7b", "capture_unittests": "dd5b1de0e88e5523a9298a9c05f8dee3656c786b", "cast_unittests": "039addaedf3e70684802e328f6c848b51ab28701", "cc_unittests": "8aa9daf28b9cc2fb6aaad7c98246f8557e5f5fc3", "chrome_app_unittests": "4cd310afb7483123615b85e8d288729778455b33", "chromedriver_unittests": "908239ce24182021e4c3f048d31b78dfdb575cfa", "components_browsertests": "b68b0f48d7acf47ba93bc6838e03560c109c6532", "components_unittests": "03238a0c780005895967d008fe504aa6c8051b87", "content_browsertests": "b2f255d3871be941a88f69f339a9e6e788fe2835", "content_shell_crash_test": "a5944f7385e8d5a1880df3582568f58e25fc325a", "content_unittests": "3ff89087b1f228278380811764b17e05140cf819", "crashpad_tests": "3c4bdff5b359ceba5037c063a8ae08b04d535dd0", "cronet_tests": "9d4e6b85306671e3ed8c8fd86be1d997cad1e321", "cronet_unittests": "f959fc9e88df287601e04969fc171cce78f9f632", "crypto_unittests": "bd221dfbca8e7d70cacda4334194c372acc0e37c", "device_unittests": "7bab72e56a82018f7d0f3b5fede75a9945a380f2", "display_unittests": "7071e2df10d6004b6174b69e2333eebe82e3ac34", "events_unittests": "82c7619abeed40306ddb58408627aeaa897bb7fa", "extensions_browsertests": "75fa2418d4281c2e810ec112ad1a975130a7e766", "extensions_unittests": "20cae0756d95c00f100f7f15ba8f25054b81ad6f", "filesystem_service_unittests": "217a5de03e3b11f5a6569192e6ccfe4e9f6bb303", "gcm_unit_tests": "6f056eab5495d247167ac032deea44e63c474f30", "gfx_unittests": "895f0f0db3d0306564cd48a8d14ff86d36938f72", "gin_unittests": "800f1a008fbe662e9473e111c51e1e5f49ee3100", "google_apis_unittests": "958629051918f0eb8b6c3d4d5d08ccd962323b51", "gpu_unittests": "9bc529178c096cb1b5f084490da95f89d477d6db", "headless_browsertests": "ed416f4dac15d88abb20049ee4eb9cd6afbdbd5a", "headless_unittests": "007c3a6424f18e1990ec8f6679185d17af4371c9", "interactive_ui_tests": "44ad01853320f62ea845c22e4cc571baca4c0ae8", "ipc_tests": "5a38c0f10ef916c821b75f2fdf8508b0e3fc655f", "jingle_unittests": "3225cd760edd7ed130d7ee569b8fbccf63742071", "latency_unittests": "80318cd5d4994e24e77f5a22dcb5d7ba4e3c74ff", "leveldb_service_unittests": "182ccf0cd10669dec5fde7168709608f533f8557", "libjingle_xmpp_unittests": "9d4f493ab9adbb5bb8a752c0bdacb43cf2948a4c", "media_blink_unittests": "ec7d0923611d626b0ea01a2b9d513c02cf4cdb33", "media_service_unittests": "376eeb16c18e74b59f2a66777d7a225d27eab835", "media_unittests": "a5914112dc156ca84190ab85966750f34a6434bc", "message_center_unittests": "7eef8040b5a70b91b4a10648b74a94737e98e421", "metrics_python_tests": "98f876d1d415b9a1e54f7b5c828026606af3d75f", "midi_unittests": "00dd5e4c95d69eae091f16f2fd919a9bcb6bcd6c", "mojo_unittests": "3e2ee1af1ff79c81243a8397ebe61204e30b2b71", "nacl_loader_unittests": "f5da8d9fea100b19a36f125a334e6c662dd1be53", "native_theme_unittests": "7748c42f6f13e68d9b9d9a3b179c24625c6fbeee", "net_unittests": "7b24d723472ab7ad5ea4d3a4529bf54516bb52b6", "pdf_unittests": "d28794e0056293fb919d56b39a1dd964cddd8a5e", "performance_test_suite": "15830cb88722130339a6b693e7a7ae07859fc15e", "ppapi_unittests": "d47c014b12c2de98c5297c18319ead530f8225ac", "printing_unittests": "e1f463b323878b7e2a25dd18758bcf3a2969cda5", "remoting_unittests": "a7b5b7cbd913010b2c51a7b27233406143f87f89", "sandbox_mac_unittests": "8cb6a03afa430f487f5e63061a4b3745297c4754", "service_manager_unittests": "16de41161f19c6d4e17b394a20067b13040aa254", "services_unittests": "83a0ab43567a3674059d9999ce1f2484220b9deb", "shell_dialogs_unittests": "b8752821a50b198bb74b1a1bcb1b16a607d89b68", "skia_unittests": "f4424bad543e3b88b147c1f329a508c658aec3ac", "snapshot_unittests": "462b0972f5999f99c2471ca5fcc2ab912572b7a5", "sql_unittests": "cee2bdd486769010ae7193d6965a0d0e5cccbcb2", "storage_unittests": "4912c4655fc483f17476edb52847c1fb23da831c", "sync_integration_tests": "73cbb72269b70b7098502178291c6d2fe5e77a00", "telemetry_gpu_unittests": "fff3b889ba09546f5896aaf005485510caa751cd", "telemetry_unittests": "f2a05d1f2177ad4b086d873e40aba334de5e69b6", "ui_base_unittests": "83a995f2ba2112da95c5b618df8ec4f06ccb4af6", "ui_touch_selection_unittests": "a508098e033f1f7c7529c86c423210669a316b6a", "unit_tests": "87c8e6b4112843d654b60a8e129cc2688465f41c", "url_unittests": "bd5036502e35ba5cb573806ea32bf127dfcb4c11", "views_perftests": "1f2ddfadb70b19cf11ecb74e3ba71cd769d2c54d", "views_unittests": "fd1c994dddfb4e4e956de13befa30d265055c9f8", "viz_unittests": "6dd385b17244a9ec6d0d0bbbe308ba68717f03f9", "webkit_layout_tests_exparchive": "02936227747828a040ddd2cec4937c6017723dc3", "webkit_python_tests": "d12c868d7c0f3a915e1ba7c14ccbe7f3d24ae07b", "webkit_unit_tests": "b455ac52afff84d35364caf3470a584f238b6355", "wtf_unittests": "2d256287bedb400e73073d2f76490ea1bdcab8d6"} | isolate tests |
Blamelist:
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Gabriel Charette (gabohnoyoudont@chromium.org)
- Anthony Vallee-Dubois (anthonyvdohnoyoudont@chromium.org)
- Andrew Grieve (agrieveohnoyoudont@chromium.org)
- Tibor Goldschwendt (tiborgohnoyoudont@chromium.org)
- Vladimir Levin (vmpstrohnoyoudont@chromium.org)
- Christopher Grant (cjgrantohnoyoudont@chromium.org)
- Sam Maier (smaierohnoyoudont@chromium.org)
- v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
- Xiaocheng Hu (xiaochenghohnoyoudont@chromium.org)
- Yi Gu (yiguohnoyoudont@chromium.org)
- Parastoo Geranmayeh (parastoogohnoyoudont@google.com)
- Daniel Nicoara (dnicoaraohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Eric Willigers (ericwilligersohnoyoudont@chromium.org)
- Ehsan Karamad (ekaramadohnoyoudont@chromium.org)
- Moe Ahmadi (mahmadiohnoyoudont@chromium.org)
- Polina Bondarenko (pbondohnoyoudont@google.com)
- Tien Mai (tienmaiohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Gabriel Charette (gabohnoyoudont@chromium.org)
- Philip Rogers (pdrohnoyoudont@chromium.org)
- Ian Kilpatrick (ikilpatrickohnoyoudont@chromium.org)
- Nicolas Ouellet-payeur (nicolasoohnoyoudont@chromium.org)
Timing:
Create | Monday, 21-Jan-19 21:07:47 UTC |
Start | Monday, 21-Jan-19 21:07:50 UTC |
End | Monday, 21-Jan-19 21:59:27 UTC |
Pending | 2 secs |
Execution | 51 mins 37 secs |
All Changes:
-
Roll src/third_party/perfetto 3267538833a2..37699ed05b43 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Monday, 21-Jan-19 21:07:02 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6b47cef80ff0f4a5eda85a276b8f61efb65a230d Comments
Roll src/third_party/perfetto 3267538833a2..37699ed05b43 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/3267538833a2..37699ed05b43 git log 3267538833a2..37699ed05b43 --date=short --no-merges --format='%ad %ae %s' 2019-01-21 fmayer@google.com Merge "Add heapprofd protos to perfetto_trace.proto." Created with: gclient setdep -r src/third_party/perfetto@37699ed05b43 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I82d4006ab44a42b2780cca88eefdafbef6dfb8b0 Reviewed-on: https://chromium-review.googlesource.com/c/1425677 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624672}
Changed files
- DEPS
-
Reland "Adds a separator between custom tab bar and title, based on UX feedback."
Changed by Gabriel Charette - gabohnoyoudont@chromium.org Changed at Monday, 21-Jan-19 21:06:50 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 02f2825ab10a2d6bae105d2a6c94c28f055193e9 Comments
Reland "Adds a separator between custom tab bar and title, based on UX feedback." This reverts commit de610823c81c9740c5e5174dc748389caeb37f35. Reason for reland : didn't fix it. Original change's description: > Revert "Adds a separator between custom tab bar and title, based on UX feedback." > > This reverts commit f207ec9653d036442e5738a4740b04506d7fe346. > > Reason for revert: suspected for https://bugs.chromium.org/p/chromium/issues/detail?id=923894#c14 > > Original change's description: > > Adds a separator between custom tab bar and title, based on UX feedback. > > > > Previously, a similar separator was drawn. However, this separator > > was always shown (when the theme color was white-ish), and the desired > > behavior is to *only* render the separator when the custom tab bar > > is visible AND the custom tab bar is white-ish. > > > > This CL will cause a 15% black separator to be drawn at the top of the > > custom tab bar, blended with the apps theme color, so it looks like > > the separator is drawn onto the title bar. > > > > Bug: 918788 > > Change-Id: Iba020fe4f059558fe355d18236d5226d35f3a2aa > > Reviewed-on: https://chromium-review.googlesource.com/c/1414535 > > Commit-Queue: Jay Harris <harrisjay@chromium.org> > > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#624514} > > TBR=bsep@chromium.org,harrisjay@chromium.org > > Change-Id: I16e4607f127301e3c579277f92b2549b51a92266 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 918788, 923894 > Reviewed-on: https://chromium-review.googlesource.com/c/1425999 > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624638} TBR=gab@chromium.org,bsep@chromium.org,harrisjay@chromium.org Change-Id: I107e52387e2fd3a5072c484e39c883cfabe7349c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 918788, 923894 Reviewed-on: https://chromium-review.googlesource.com/c/1425968 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#624671}
Changed files
- chrome/browser/ui/views/location_bar/custom_tab_bar_view.cc
- chrome/browser/ui/views/location_bar/custom_tab_bar_view.h
-
Only trigger HrefTranslate if the originator is the DSE
Changed by Anthony Vallee-Dubois - anthonyvdohnoyoudont@chromium.org Changed at Monday, 21-Jan-19 21:05:55 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision de1b8f8fd94987a2f7b1a0c0e8a7294117eb021b Comments
Only trigger HrefTranslate if the originator is the DSE To prevent any website from triggering Chrome auto-translate, the hrefTranslate attribute on <a> tags will only work automatically when the originator of the request is the user's default search engine. A follow up patch will make it so that hrefTranslate from other originators show the Translate UI. Context for this change can be found in crbug.com/909088. Bug: 900586 Change-Id: I41b66382e6f56b7b67eab3ffcca7a93c755cdce7 Reviewed-on: https://chromium-review.googlesource.com/c/1413403 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#624670}
Changed files
- chrome/browser/translate/chrome_translate_client.cc
- chrome/browser/translate/translate_manager_browsertest.cc
- components/translate/content/browser/BUILD.gn
- components/translate/content/browser/DEPS
- components/translate/content/browser/content_translate_driver.cc
- components/translate/content/browser/content_translate_driver.h
-
Android: Do not include ELF padding in normalized_apk_size metric
Changed by Andrew Grieve - agrieveohnoyoudont@chromium.org Changed at Monday, 21-Jan-19 21:05:47 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 616b8605e696f3268055256d3c1838398e87a052 Comments
Android: Do not include ELF padding in normalized_apk_size metric This should make android-binary-size more clear about the size impact of commits. Previously all small native code changes would have a normalized size delta of 0 or 4kb. Bug: 921160 Change-Id: Ifa98681fc9f92d9e238140782153513927ae2f97 Reviewed-on: https://chromium-review.googlesource.com/c/1423663 Commit-Queue: agrieve <agrieve@chromium.org> Auto-Submit: agrieve <agrieve@chromium.org> Reviewed-by: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#624669}
Changed files
- build/android/resource_sizes.py
- docs/speed/binary_size/metrics.md
- tools/binary_size/BUILD.gn
-
Reland "[vr] Deferred install module at startup on Daydream-ready devices"
Changed by Tibor Goldschwendt - tiborgohnoyoudont@chromium.org Changed at Monday, 21-Jan-19 21:04:47 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8d6272c6c6212608b368f4509b7151917dcd77cc Comments
Reland "[vr] Deferred install module at startup on Daydream-ready devices" This is a reland of 4ca801964f8b02b19554be114d95d62dcdd1e319 Original change's description: > [vr] Deferred install module at startup on Daydream-ready devices > > + Consolidate VR initialization after module install. > > + Add ability to have instrumentation tests that expect the module not > be installed. > > + Add instrumentation test for startup install request. > > TBR=mthiesse@chromium.org > > Bug: 914499 > Change-Id: I4819734e5826d1b3919779046b1ab864f29241b0 > Reviewed-on: https://chromium-review.googlesource.com/c/1412532 > Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624597} TBR=agrieve@chromium.org,mthiesse@chromium.org,bsheedy@chromium.org Bug: 914499 Change-Id: If8b7108f2cd56327c68a4a717a775db124348c7b Reviewed-on: https://chromium-review.googlesource.com/c/1425358 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#624668}
Changed files
- chrome/android/BUILD.gn
- chrome/android/chrome_public_apk_tmpl.gni
- chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegate.java
- chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateFallback.java
- chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateImpl.java
- chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java
- chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellDelegate.java
- chrome/android/javatests/DEPS
- chrome/android/javatests/src/org/chromium/chrome/browser/vr/TestVrShellDelegate.java
- chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrDaydreamReadyModuleInstallTest.java
- chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/ChromeTabbedActivityVrTestRule.java
- chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/CustomTabActivityVrTestRule.java
- chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/VrModuleNotInstalled.java
- chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/WebappActivityVrTestRule.java
- chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTestRuleUtils.java
- components/module_installer/android/BUILD.gn
- components/module_installer/android/java/src-impl/org/chromium/components/module_installer/FakeModuleInstallerBackend.java
- components/module_installer/android/java/src-impl/org/chromium/components/module_installer/ModuleInstaller.java
- components/module_installer/android/java/src-impl/org/chromium/components/module_installer/ModuleInstallerBackend.java
- components/module_installer/android/java/src-impl/org/chromium/components/module_installer/PlayCoreModuleInstallerBackend.java
- components/module_installer/android/java/src-stub/org/chromium/components/module_installer/ModuleInstaller.java
- components/module_installer/android/java/src-test/org/chromium/components/module_installer/ModuleInstaller.java
-
Ensure to do SafeUnalias while layerizing a group.
Changed by Vladimir Levin - vmpstrohnoyoudont@chromium.org Changed at Monday, 21-Jan-19 21:04:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e24232b80612cbb268a7b9da20b5d498a12f2391 Comments
Ensure to do SafeUnalias while layerizing a group. This patch is a speculative fix for the referenced bug. R=pdr@chromium.org Bug: 923729 Change-Id: If635382198a89d8f58bffda19d059baa9d87881a Reviewed-on: https://chromium-review.googlesource.com/c/1426017 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#624667}
Changed files
- third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc
-
Android: Fix secondary ABI GN inconsistencies
Changed by Christopher Grant - cjgrantohnoyoudont@chromium.org Changed at Monday, 21-Jan-19 21:03:35 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1e511063dfee87d89b9b8eb4028deb81abc407a6 Comments
Android: Fix secondary ABI GN inconsistencies Some GN configs use "current_toolchain == default_toolchain" to avoid work on the host toolchain. A problem with this is that not all non-default toolchains are the host toolchain. In the 64-bit ARM Android case, there's the default toolchain (arm64), and the secondary ABI toolchain (arm32). A check like the one listed above yields incorrect behavior in this case. Instead, it needs to be "is current toolchain the default toolchain (ie. arm64), or, if on Android, is the current toolchain the secondary ABI toolchain". This could be more simply stated as "are you one of the toolchains used for the destination". Hence this change introduces a variable, is_a_destination_toolchain, which tries to convey that we're on a non-host toolchain. BUG=899570 Change-Id: I534abeb91e116f30be8a1625f02af64b4acfc206 Reviewed-on: https://chromium-review.googlesource.com/c/1412298 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#624666}
Changed files
- build/config/compiler/BUILD.gn
- build/config/compiler/compiler.gni
-
Allowing proguard.py to succeed if no dex is generated
Changed by Sam Maier - smaierohnoyoudont@chromium.org Changed at Monday, 21-Jan-19 21:03:32 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4dbbe3ca6db9e72afa789de86af1745a732e7dd1 Comments
Allowing proguard.py to succeed if no dex is generated Bug: 923878 Change-Id: I663ac76ac1a440555b55e8c3c9cb868950646e74 Reviewed-on: https://chromium-review.googlesource.com/c/1425962 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#624665}
Changed files
- build/android/gyp/proguard.py
-
Reland "Update V8 to version 7.3.465."
Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com Changed at Monday, 21-Jan-19 21:02:31 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a5625ea0e252dc185c5c1b82b38b459aafe73f97 Comments
Reland "Update V8 to version 7.3.465." This is a reland of 1c052c978e972780aed2373d104081e28cd29211 TBR=danakj Original change's description: > Update V8 to version 7.3.465. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/5f328d27..504b12e5 > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: I8464686a484f696225391887c9ac133b005629fe > Reviewed-on: https://chromium-review.googlesource.com/c/1425480 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#624633} Change-Id: I6f4a3f172978288bae83a1a365b945769e910e96 Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1426080 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#624664}
Changed files
- DEPS
-
Convert editing/selection/selection-3748164-fix.html with selection_test()
Changed by Xiaocheng Hu - xiaochenghohnoyoudont@chromium.org Changed at Monday, 21-Jan-19 21:02:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9373669213b5b05a28ebf31358763997b3a1b75d Comments
Convert editing/selection/selection-3748164-fix.html with selection_test() This patch converts the web test with selection_test() to promote the usage of W3C test harness. It also avoid a minor 1px image diff with bidi caret affinity in crrev.com/c/1419249. Bug: 894651 Change-Id: I3cca3b080315334ca316c9a24f7313d69236c061 Reviewed-on: https://chromium-review.googlesource.com/c/1422960 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#624663}
Changed files
- third_party/blink/web_tests/editing/selection/selection-3748164-fix.html
- third_party/blink/web_tests/platform/linux/editing/selection/selection-3748164-fix-expected.png
- third_party/blink/web_tests/platform/mac/editing/selection/selection-3748164-fix-expected.png
- third_party/blink/web_tests/platform/mac/editing/selection/selection-3748164-fix-expected.txt
- third_party/blink/web_tests/platform/win/editing/selection/selection-3748164-fix-expected.png
- third_party/blink/web_tests/platform/win/editing/selection/selection-3748164-fix-expected.txt
-
[Code Health] Fix a potential integer overflow issue
Changed by Yi Gu - yiguohnoyoudont@chromium.org Changed at Monday, 21-Jan-19 21:01:25 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision aac4cd1c2037eb0d2285e15e5c9ab7bc1d2bd0b5 Comments
[Code Health] Fix a potential integer overflow issue crrev.com/c/1411032 only fixed the cluster fuzz reported issue but missed the other one. Change-Id: I9fbdb3484e2dc6c3958f6e54497db1eaafb53f72 Reviewed-on: https://chromium-review.googlesource.com/c/1425559 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#624662}
Changed files
- cc/animation/keyframe_model.cc
-
[AF] Client validation feature
Changed by Parastoo Geranmayeh - parastoogohnoyoudont@google.com Changed at Monday, 21-Jan-19 21:01:09 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0f5ebbc6ec44d9184f904702828bd6a8f3b73673 Comments
[AF] Client validation feature Client validation should run behind a feature. Bug: 904413 Change-Id: I6991762016dbb9dbda4829e9090630146108e470 Reviewed-on: https://chromium-review.googlesource.com/c/1401663 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#624661}
Changed files
- chrome/browser/about_flags.cc
- chrome/browser/flag-metadata.json
- chrome/browser/flag_descriptions.cc
- chrome/browser/flag_descriptions.h
- components/autofill/core/browser/personal_data_manager.cc
- components/autofill/core/browser/personal_data_manager_unittest.cc
- components/autofill/core/common/autofill_features.cc
- components/autofill/core/common/autofill_features.h
- tools/metrics/histograms/enums.xml
-
EXO: Refactor wl_compositor interface
Changed by Daniel Nicoara - dnicoaraohnoyoudont@chromium.org Changed at Monday, 21-Jan-19 21:00:19 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3ec2e2df357a91fb6376a38b07ac10a1e59d4495 Comments
EXO: Refactor wl_compositor interface Move the wl_compositor interface into its own files. This change only moves code around, no functional changes. Bug: 896710 Test: Build and run exo_unittests Change-Id: I7973a1c72b7b33c9f0b3c22dabf48cd0afe75177 Reviewed-on: https://chromium-review.googlesource.com/c/1425482 Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#624660}
Changed files
- components/exo/wayland/BUILD.gn
- components/exo/wayland/server.cc
- components/exo/wayland/wl_compositor.cc
- components/exo/wayland/wl_compositor.h
-
Roll src/third_party/catapult 21987aac84ec..39e1df9e9df0 (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Monday, 21-Jan-19 21:00:05 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6f2d3a68603ca9a0c9fd8398917dbb6665078205 Comments
Roll src/third_party/catapult 21987aac84ec..39e1df9e9df0 (1 commits) https://chromium.googlesource.com/catapult.git/+log/21987aac84ec..39e1df9e9df0 git log 21987aac84ec..39e1df9e9df0 --date=short --no-merges --format='%ad %ae %s' 2019-01-21 benjhayden@chromium.org Add chart-base for v2spa Created with: gclient setdep -r src/third_party/catapult@39e1df9e9df0 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ib98d1fa93fbaea1301a9a8b6e0d75b9c2d3dc621 Reviewed-on: https://chromium-review.googlesource.com/c/1425818 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624659}
Changed files
- DEPS
-
WebShare: canShare() method in Level 2
Changed by Eric Willigers - ericwilligersohnoyoudont@chromium.org Changed at Monday, 21-Jan-19 20:59:02 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d14f5b09b829b309f9b706dab38fc3d1cc9f0871 Comments
WebShare: canShare() method in Level 2 canShare(data) returns false iff share(data) would reject with TypeError https://wicg.github.io/web-share/level-2/#canshare-method Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/AiKgWvv3cq0/xAsjfSfMDQAJ Bug: 903010 Change-Id: I15e8a92a9d71b08da4e9e6d4bf2692c97dce5c0f Reviewed-on: https://chromium-review.googlesource.com/c/1351340 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#624658}
Changed files
- third_party/blink/public/platform/web_feature.mojom
- third_party/blink/renderer/modules/webshare/navigator_share.cc
- third_party/blink/renderer/modules/webshare/navigator_share.h
- third_party/blink/renderer/modules/webshare/navigator_share.idl
- third_party/blink/renderer/modules/webshare/share_data.idl
- third_party/blink/renderer/platform/runtime_enabled_features.json5
- third_party/blink/web_tests/external/wpt/web-share/canShare-files.https.html
- third_party/blink/web_tests/external/wpt/web-share/canShare-insecure.http.html
- third_party/blink/web_tests/external/wpt/web-share/canShare.https.html
- third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
- tools/metrics/histograms/enums.xml
-
[ FeaturePolicy ] - Report for "legacy-image-formats"
Changed by Ehsan Karamad - ekaramadohnoyoudont@chromium.org Changed at Monday, 21-Jan-19 20:58:50 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3488b4555d7bbe8777426b38fabaeecd248ae470 Comments
[ FeaturePolicy ] - Report for "legacy-image-formats" This CL adds support for generating reports for violations of the "legacy-image-formats" feature policy. This also automatically starts counting the potential violations of this feature in web pages (Blink.UseCounter.FeaturePolicy.PotentialViolation). Bug: 915788 Change-Id: If72ec438b6038730907ac086bddd0c680cc60d97 Reviewed-on: https://chromium-review.googlesource.com/c/1409698 Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#624657}
Changed files
- third_party/blink/renderer/core/layout/layout_image.cc
- third_party/blink/web_tests/external/wpt/feature-policy/reporting/image.bmp
- third_party/blink/web_tests/external/wpt/feature-policy/reporting/legacy-image-formats-reporting.html
- third_party/blink/web_tests/external/wpt/feature-policy/reporting/legacy-image-formats-reporting.html.headers
- third_party/blink/web_tests/http/tests/images/feature-policy-image-policies-with-border-radius-expected.txt
- third_party/blink/web_tests/http/tests/images/feature-policy-legacy-formats-expected.txt
-
[iOS][Translate] ObjC TranslateInfobarDelegateObserver
Changed by Moe Ahmadi - mahmadiohnoyoudont@chromium.org Changed at Monday, 21-Jan-19 20:57:50 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision bbe1350d8c635f3ec4f1845c0b43e23e8bf082ed Comments
[iOS][Translate] ObjC TranslateInfobarDelegateObserver TranslateInfobarDelegateObserverBridge for use in ObjC Bug: 910994 Change-Id: I5e001c05b95fe9afb95e8e1718ad0a13a0addc05 Reviewed-on: https://chromium-review.googlesource.com/c/1422117 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#624656}
Changed files
- components/translate/core/browser/translate_infobar_delegate.h
- ios/chrome/browser/translate/BUILD.gn
- ios/chrome/browser/translate/translate_infobar_delegate_observer_bridge.h
- ios/chrome/browser/translate/translate_infobar_delegate_observer_bridge.mm
- ios/chrome/browser/translate/translate_infobar_delegate_observer_bridge_unittest.mm
-
diagnostics: Add PerformWebRequest method to mojom
Changed by Polina Bondarenko - pbondohnoyoudont@google.com Changed at Monday, 21-Jan-19 20:57:10 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision fb2709d14ec7935c0ee32f287c8b052708b64a95 Comments
diagnostics: Add PerformWebRequest method to mojom Add implementation of PerformWebRequest method in DiagnosticsdBridge that performs the web requests initiated by diagnosticsd daemon. Add unit tests for new DiagnosticsdWebRequestService. BUG=chromium:903745 TEST=unit_tests Change-Id: I528f7c850067146ff3b7b473179a69e83f2d3253 Reviewed-on: https://chromium-review.googlesource.com/c/1386868 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Mattias Nissler <mnissler@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#624655}
Changed files
- chrome/browser/chromeos/BUILD.gn
- chrome/browser/chromeos/chrome_browser_main_chromeos.cc
- chrome/browser/chromeos/diagnosticsd/diagnosticsd_bridge.cc
- chrome/browser/chromeos/diagnosticsd/diagnosticsd_bridge.h
- chrome/browser/chromeos/diagnosticsd/diagnosticsd_bridge_unittest.cc
- chrome/browser/chromeos/diagnosticsd/diagnosticsd_web_request_service.cc
- chrome/browser/chromeos/diagnosticsd/diagnosticsd_web_request_service.h
- chrome/browser/chromeos/diagnosticsd/diagnosticsd_web_request_service_unittest.cc
- chrome/browser/chromeos/diagnosticsd/mojo_utils.cc
- chrome/browser/chromeos/diagnosticsd/mojo_utils.h
- chrome/services/diagnosticsd/public/mojom/BUILD.gn
- chrome/services/diagnosticsd/public/mojom/diagnosticsd.mojom
-
Switch inline signin for GCPW to use new gaia endpoint.
Changed by Tien Mai - tienmaiohnoyoudont@chromium.org Changed at Monday, 21-Jan-19 20:56:09 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 80c294d497e7050df7cfd868774d71b9e2b45359 Comments
Switch inline signin for GCPW to use new gaia endpoint. Also allows any endpoint to be used as sign in page. Bug: 923329 Change-Id: Ieb2d2d92235889c52a17e4917ce224c3543e5710 Reviewed-on: https://chromium-review.googlesource.com/c/1385016 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#624654}
Changed files
- chrome/browser/ui/startup/credential_provider_signin_dialog_win.cc
- chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
- chrome/credential_provider/common/gcp_strings.cc
- chrome/credential_provider/common/gcp_strings.h
- chrome/credential_provider/gaiacp/gaia_credential_base.cc
- google_apis/gaia/gaia_urls.cc
- google_apis/gaia/gaia_urls.h
-
Roll src/third_party/skia 463c0737a8ca..02738a86e5fd (5 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Monday, 21-Jan-19 20:56:06 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 22a2dfeca21e449554a62cba91202f463b2448ad Comments
Roll src/third_party/skia 463c0737a8ca..02738a86e5fd (5 commits) https://skia.googlesource.com/skia.git/+log/463c0737a8ca..02738a86e5fd git log 463c0737a8ca..02738a86e5fd --date=short --no-merges --format='%ad %ae %s' 2019-01-21 halcanary@google.com Revert "hide hinting and flag enums with PAINT_FLAGS" 2019-01-21 brianosman@google.com SkColorSpace API cleanup 2019-01-21 fmalita@chromium.org [skshaper] Export "primitive" sources in public.bzl 2019-01-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 7403dd2cd376..bf433727853d (1 commits) 2019-01-21 reed@google.com hide hinting and flag enums with PAINT_FLAGS Created with: gclient setdep -r src/third_party/skia@02738a86e5fd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: Ieadcfd25c2d660a191a97503dd8a84e437d6da04 Reviewed-on: https://chromium-review.googlesource.com/c/1426037 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624653}
Changed files
- DEPS
-
Unflake TestBrowserThreadBundleTest death tests
Changed by Gabriel Charette - gabohnoyoudont@chromium.org Changed at Monday, 21-Jan-19 20:55:06 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a9b3d2f4c1d07c3e45df0937010417d6d246f566 Comments
Unflake TestBrowserThreadBundleTest death tests R=avi@chromium.org Bug: 923923 Change-Id: Ie6c2aa8b1084144e4477194315b86916ed0a95bf Reviewed-on: https://chromium-review.googlesource.com/c/1426018 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#624652}
Changed files
- content/public/test/test_browser_thread_bundle_unittest.cc
-
Show blink property trees with --vmodule=*paint*=1
Changed by Philip Rogers - pdrohnoyoudont@chromium.org Changed at Monday, 21-Jan-19 20:55:02 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c2ef13aa3c777a38a4b2d51db2d7f39587e83e2f Comments
Show blink property trees with --vmodule=*paint*=1 PrePaintTreeWalk::WalkTree had a condition to only print blink property trees when needs_tree_builder_context_update was false, but we should print property trees whenever they change. This patch inverts the conditional. With this patch, we print property trees when running: content_shell --enable-blink-features=BlinkGenPropertyTrees --vmodule=*paint*=1 https://pr.gg Change-Id: I578286a2e795ba7671524337b9ba6bd96c4f4e8a Reviewed-on: https://chromium-review.googlesource.com/c/1426057 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#624651}
Changed files
- third_party/blink/renderer/core/paint/pre_paint_tree_walk.cc
-
[LayoutNG] Remove positioned float vector & related methods.
Changed by Ian Kilpatrick - ikilpatrickohnoyoudont@chromium.org Changed at Monday, 21-Jan-19 20:53:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ba0bf7f55eed8d5d51788e925c750466e74a0cf3 Comments
[LayoutNG] Remove positioned float vector & related methods. Now that the line breaker doesn't deal with positioned floats in a vector, we can remove the NGUnpositionedFloatVector type and related classes. There should be no behaviour change. Bug: 635619 Change-Id: I0e2d2dc3ce8258b9363d66ab540c262a51f2d9f9 Reviewed-on: https://chromium-review.googlesource.com/c/1424418 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#624650}
Changed files
- third_party/blink/renderer/core/layout/BUILD.gn
- third_party/blink/renderer/core/layout/ng/inline/ng_inline_layout_algorithm.h
- third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
- third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.h
- third_party/blink/renderer/core/layout/ng/ng_floats_utils.cc
- third_party/blink/renderer/core/layout/ng/ng_floats_utils.h
- third_party/blink/renderer/core/layout/ng/ng_layout_result.h
- third_party/blink/renderer/core/layout/ng/ng_unpositioned_float.h
- third_party/blink/renderer/core/layout/ng/ng_unpositioned_float_vector.h
-
Add 'Managed UI' on chrome://settings
Changed by Nicolas Ouellet-payeur - nicolasoohnoyoudont@chromium.org Changed at Monday, 21-Jan-19 20:53:47 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 04fb00a20bc9758ec846853c5751ab18221869ce Comments
Add 'Managed UI' on chrome://settings Adds a message for managed users at the top of the chrome://settings page. Enterprise users will now see a message that says "Your browser is managed by your organization", with a link they can click to view a help center article. The new UI is hidden behind a flag so that most users don't see this WIP feature just yet. Bug: 893628 Change-Id: I878497a5f39cb2a86015af5331198bfffbcf53a3 Reviewed-on: https://chromium-review.googlesource.com/c/1401509 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#624649}
Changed files
- chrome/browser/resources/settings/i18n_setup.html
- chrome/browser/resources/settings/settings_main/settings_main.html
- chrome/browser/resources/settings/settings_main/settings_main.js
- chrome/browser/ui/webui/settings/md_settings_ui.cc
- chrome/test/data/webui/settings/settings_main_test.js