Builder Mac Builder (dbg) Build 154643

Results:

Success

Trigger Info:

Project	chromium
Revision	49c021d047ee19447403569a88ccdadf2df2023d
Got Revision	49c021d047ee19447403569a88ccdadf2df2023d

Execution:

• Source: Task 4289b946e959de10
• Bot: vm35-m9
• Recipe: chromium

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 540 ms ) setup_build

   running recipe: "chromium"
   • stdout
   • run_recipe
2. ( 331 ms ) report builders

    

   running builder 'Mac Builder (dbg)' on master 'chromium.mac'
   • stdout
   • bots.json
3. ( 1 mins 37 secs ) bot_update

   [86GB/232GB used (37%)]
   • stdout
   • json.output
4. ( 426 ms ) ensure_goma
   • - no logs -
   1. ( 426 ms ) ensure_installed
      • stdout
      • json.output
5. ( 987 ms ) swarming.py --version

   0.14
   • stdout
6. ( 215 ms ) ensure_installed
   • stdout
   • json.output
7. ( 20 secs ) gclient runhooks
   • stdout
8. ( 4 secs ) get compile targets for scripts
   • stdout
   • json.output
9. ( 935 ms ) read test spec (chromium.mac.json)

   path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.mac.json
   • stdout
   • json.output
10. ( 579 ms ) clean isolated files
    • stdout
11. ( 627 ms ) lookup GN args

     

    ffmpeg_branding = "Chrome"

    is_component_build = true

    is_debug = true

    proprietary_codecs = true

    strip_absolute_paths_from_debug_symbols = true

    symbol_level = 1

    use_goma = true

    goma_dir = "/b/s/w/ir/cache/goma/client"
    • stdout
12. ( 14 secs ) generate_build_files
    • stdout
    • swarming-targets-file.txt
13. ( 815 ms ) clang_revision
    • stdout
    • json.output
14. ( 21 secs ) preprocess_for_goma
    • - no logs -
    1. ( 599 ms ) goma cache directory
       • stdout
    2. ( 18 secs ) start_goma
       • stdout
       • cloudtail
    3. ( 1 secs ) start cloudtail
       • stdout
15. ( 3 mins 33 secs ) compile
    • stdout
16. ( 11 secs ) compile confirm no-op
    • stdout
17. ( 17 secs ) postprocess_for_goma
    • - no logs -
    1. ( 1 secs ) goma_jsonstatus
       • stdout
       • json.output
    2. ( 815 ms ) goma_stat
       • stdout
    3. ( 866 ms ) stop_goma
       • stdout
    4. ( 13 secs ) upload_log
       • stdout
       • json.output
       • compiler_proxy_log
       • ninja_log
    5. ( 1 secs ) stop cloudtail
       • stdout
18. ( 46 secs ) isolate webkit_layout_tests_exparchive
    • stdout
    • json.output
19. ( 4 mins 11 secs ) isolate tests
    • stdout
    • json.output
20. ( 639 ms ) trigger
    • stdout
21. ( 0 ) recipe result
    • result

Build Properties:

Name	Value	Source
$recipe_engine/path	{"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"vm35-m9"	setup_build
branch	"refs/heads/master"	setup_build
buildbucket	{"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548082461537467, "id": "8923711600769329008", "project": "chromium", "tags": ["builder:Mac Builder (dbg)", "buildset:commit/git/49c021d047ee19447403569a88ccdadf2df2023d", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/49c021d047ee19447403569a88ccdadf2df2023d", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089141662921974896", "scheduler_job_id:chromium/Mac Builder (dbg)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"Mac Builder (dbg)"	setup_build
buildnumber	154643	setup_build
mastername	"chromium.mac"	setup_build
path_config	"generic"	setup_build
recipe	"chromium"	setup_build
repository	"https://chromium.googlesource.com/chromium/src.git"	setup_build
revision	"49c021d047ee19447403569a88ccdadf2df2023d"	setup_build
got_angle_revision	"7403dd2cd3764fe96660fe09892e764e9ae1dbca"	bot_update
got_buildtools_revision	"2f02e1f363b1af2715536f38e239853f04ec1497"	bot_update
got_dawn_revision	"c0f31e73e481f32d308cb6232e75e6d860d97063"	bot_update
got_nacl_revision	"ff15c51d20785fa51c0ef03ccb480b87299acbeb"	bot_update
got_revision	"49c021d047ee19447403569a88ccdadf2df2023d"	bot_update
got_revision_cp	"refs/heads/master@{#624581}"	bot_update
got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	bot_update
got_v8_revision	"2513630682fff92fd7fda96870d6679b958a793d"	bot_update
got_v8_revision_cp	"refs/heads/7.3.456@{#1}"	bot_update
got_webrtc_revision	"74ba99062c48b278675cfe52643719202296fddc"	bot_update
got_webrtc_revision_cp	"refs/heads/master@{#26298}"	bot_update
got_clang_revision	"351477-1"	clang_revision
isolate_server	"https://isolateserver.appspot.com"	isolate tests
swarm_hashes_refs/heads/master(at){#624581}_without_patch	{"accessibility_unittests": "ab964accc04968e731ac19b5b23f907c36e23484", "angle_unittests": "08f4fe8ddfe3220259bcf24070ac615ce5a7d605", "app_shell_unittests": "8b89b3cf720dbf2778c80fb3aa70a7b33731dece", "base_unittests": "d38f23146b9d6cb5ed644d88c14ba498bf935320", "blink_common_unittests": "b0502b36642923cd8af7a3c7090f71c722ba6592", "blink_fuzzer_unittests": "2e51cb9f15b77c287172282e134ecf294eb49314", "blink_heap_unittests": "85af00e50deede4d620e358869b0173b79aece09", "blink_platform_unittests": "637d8dee5e871b901036b46ec6ba165c716c258e", "boringssl_crypto_tests": "7c960acbcb13b60d5a86dad87533d90856537e02", "boringssl_ssl_tests": "815848a2876044abfbbb88ca729709636fb95bc8", "browser_tests": "758e1d3f35f1d5d17b9bb8254660633df3b18e88", "cacheinvalidation_unittests": "b061e550d1a5f1f380fb67372e95af868286fb40", "capture_unittests": "4bf40ced62fa1903a7ce19bdf8a94cbe2813dbef", "cast_unittests": "184e54f49b29aab0a5627ddc11bd15de06869dc4", "cc_unittests": "615dfd9b0275e4efc712134ecdaa084d24780b27", "chrome_app_unittests": "08e7afd08b3919b8f0dc28e4a3a1be24f2947fe8", "chromedriver_unittests": "8dd7ad312d74597dfcfe2a68a94f9c0402627ff1", "components_browsertests": "345dded6e9d5f5ecdeaeae2055d9511500fe9add", "components_unittests": "946249042724ee668e929c627971997f421de8f9", "content_browsertests": "4db2bde29744d53cf4d27c6f0ab7f680812c439a", "content_shell_crash_test": "cf66fff23e84a98b1e1710f38c3598487b4f6b5d", "content_unittests": "2f6cda84a90b727a300e3fd14a73cda147e41316", "crashpad_tests": "4694e2981d783e8e0c007534e513bd99783f75c4", "cronet_tests": "1e84ae9c94659b0e39dd5475472f1e3524ad5d3c", "cronet_unittests": "b0fd61154a9cd862bad873b9d7f16ce43b39dcb0", "crypto_unittests": "1dc394671822723e8f9b4592db13e738890a80d9", "device_unittests": "bc5c15d6a1d826b142c056a299ec6dec6d7ed8b3", "display_unittests": "e7fc7362ebfe0de551bb322b4681ac764024f0c3", "events_unittests": "dcffa056cc56f32f6a7b0d5ef18564ae0954c87b", "extensions_browsertests": "c3275f85004ddd72c2776962403d098c0d055a66", "extensions_unittests": "851bea2f428d9e1b982384c899828d6ccfd005f6", "filesystem_service_unittests": "ce76f2888e18cf09e4496e353794c9aa5906d6d0", "gcm_unit_tests": "76d5f0378bffc0991d350d821b6740eb3e9a5c27", "gfx_unittests": "892c0b7a65eb88d450de6f936d1f9806d72d5ce3", "gin_unittests": "0a32123232849ad11278d7ed35b998f4efbe20c5", "google_apis_unittests": "5409e163121dcb170cb8079a0ffdcc4800d3fee0", "gpu_unittests": "02c3b98a3a2f95b79bf9d57c28d3e31cb7aa19ed", "headless_browsertests": "dec885348bba685bba6699e00b48557039da164c", "headless_unittests": "4d35690b0b1af41d86d156e3e9bc1f6355430618", "interactive_ui_tests": "4b64b4079d89629f4e1b0fe3da07b416144f0bc8", "ipc_tests": "da9e3a20461bacf49c70a6f0af0c7b97a86232b7", "jingle_unittests": "f3fdc06a2c60ff3f029061868b288fd4abdd43ae", "latency_unittests": "8f28f2871e9d5ae8860a5d6e88bdb5c67c13b748", "leveldb_service_unittests": "777eb9ead75fb9052457ddf675897ecb1001da25", "libjingle_xmpp_unittests": "8c9dba743ccd8b5761ec49236313224d290920ea", "media_blink_unittests": "48e699c8a7c445ea9ec7d00e57d42c3ba7ca2479", "media_service_unittests": "7381bc2f061f09e27cc4e629883eede139e4618f", "media_unittests": "d6ac0660b3abbc17d05f2a5c2151634d7bb55fb7", "message_center_unittests": "b3a5106f0f8a5e00abbca319dae8ac9397815e29", "metrics_python_tests": "98f876d1d415b9a1e54f7b5c828026606af3d75f", "midi_unittests": "0eed04bc679b026ce32fd3897b320f0d0d7b2892", "mojo_unittests": "813eeb8994a7154db7082d6a3322db8ad8e0dc65", "nacl_loader_unittests": "8c6040d4af7f1385721a71a06920fe8b91fe81c8", "native_theme_unittests": "18e4b088d797dd1a188ac3148158643072729423", "net_unittests": "e8a21aa07a402a457eebfaecbe0690f1aace87eb", "pdf_unittests": "9975cd2551d4c3c839688040f461388071c69363", "performance_test_suite": "81389843a5d63565de96ecf211c4e68494505d1b", "ppapi_unittests": "5a75da1175321d726bc77bfaa09938afd82b8085", "printing_unittests": "b60493592f82ddb3969ffc63831ea4b9d011356f", "remoting_unittests": "75a311648401495c4544534041938450cbe8a70b", "sandbox_mac_unittests": "dd97eca7261e6263328a7f00e07338e2f1e599f3", "service_manager_unittests": "9901eeb2ca4d6a12c2f8266954d71626010b507c", "services_unittests": "d33a7eed4c9c6113bc420585c89b5298ccafb301", "shell_dialogs_unittests": "440be2c601fb62b08728dcaafb5dd24f9e5ab65b", "skia_unittests": "32bca58c89facad4a012884f30fdfd2a31819864", "snapshot_unittests": "73f7a6c658b0e99a1384eaf5aaa9b637e0f81899", "sql_unittests": "0d73a2ecf262ea804e268b2c4ffa02c0235c6962", "storage_unittests": "9bcd9686a5a7ab37bf8b7edfad606b534a5fee57", "sync_integration_tests": "98a113c2897c45888f42a901812d45c655c55668", "telemetry_gpu_unittests": "e97d71e4867ef90bb373c412c5d51f544a47b0e6", "telemetry_unittests": "6da1a9f3b6622102d815a2cb87754d2af8c344d4", "ui_base_unittests": "0ada42bb39f109a9566ed373117383d8b73f907d", "ui_touch_selection_unittests": "bc6d1b4a45a1a64b1c517fabfd2c7908b33d2a2d", "unit_tests": "355794265e6bf8d9bcf647733dd27563d998b85b", "url_unittests": "4e02565ef215998124e62e35cb336d27056c0109", "views_perftests": "262a07612b30a327d64184c15f034e047d7bc3c7", "views_unittests": "3d75d11501debcd3d869c275a6d4dbd846c0c31f", "viz_unittests": "a671eebdc092ff228b128878bc7490847c7a57ea", "webkit_layout_tests_exparchive": "8c7f0303dd292122cf52a6cf5948bb582d8f7731", "webkit_python_tests": "36ffa740a03c8b6b1e379b86a50160c33804ca1e", "webkit_unit_tests": "f15add49189aca939de5f40b8ee003a8e16eb75f", "wtf_unittests": "8c822ce2ba72d41130daf055f671463881c136f3"}	isolate tests

Blamelist:

1. Koji Ishii (kojiiohnoyoudont@chromium.org)

Timing:

Create	Monday, 21-Jan-19 14:54:21 UTC
Start	Monday, 21-Jan-19 14:54:23 UTC
End	Monday, 21-Jan-19 15:07:27 UTC
Pending	2 secs
Execution	13 mins 3 secs

All Changes:

1. [LayoutNG] Improve performance of min-content for break-word

   Changed by	Koji Ishii - kojiiohnoyoudont@chromium.org
   Changed at	Monday, 21-Jan-19 14:36:55 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	49c021d047ee19447403569a88ccdadf2df2023d

   Comments

   [LayoutNG] Improve performance of min-content for break-word
   
   |NGLineBreaker::HandleOverflow()| had an old code that is no
   longer needed. It has no effects on results, but removing it
   improves `line-layout-fit-content-break-word.html` by 30%. It
   was probably needed at some point but then became redundant.
   
   This patch removes the condition. There should be no behavior
   changes.
   
   blink_perf.layout_ng:
   https://pinpoint-dot-chromeperf.appspot.com/job/179e3a0a540000
   
   loading.desktop_layout_ng looks noise:
   https://pinpoint-dot-chromeperf.appspot.com/job/14818d71540000
   Probably fit-content+break-word isn't used much in top sites.
   
   Bug: 919123
   Change-Id: I7e296b083144de6b2813a39d36701f039d7d5053
   Reviewed-on: https://chromium-review.googlesource.com/c/1424105
   Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
   Commit-Queue: Koji Ishii <kojii@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624581}

   Changed files

   • third_party/blink/renderer/core/layout/ng/inline/ng_line_breaker.cc