Home | Search | chromium - Builders
Login

Builder Mac ASan 64 Tests (1) Build 46161 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revision77b7b35987d9420138ebc3fcb7d24d786bf5549c
Got Revision77b7b35987d9420138ebc3fcb7d24d786bf5549c

Execution:

Steps and Logfiles:

Show:
  1. ( 568 ms ) setup_build
    running recipe: "chromium"
  2. ( 400 ms ) report builders
     
    running tester 'Mac ASan 64 Tests (1)' on master 'chromium.memory'
  3. ( 1 mins 12 secs ) bot_update
    [69GB/232GB used (29%)]
  4. ( 3 secs ) swarming.py --version
    0.13
  5. ( 605 ms ) ensure_installed
  6. ( 27 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.memory.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.memory.json
  8. ( 603 ms ) lookup builder GN args
     
    dcheck_always_on = true
    enable_nacl = false
    is_asan = true
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  9. ( 2 secs ) build directory
  10. ( 1 secs ) find isolated tests
  11. ( 1 secs ) wait for tasks
  12. ( 2 secs ) accessibility_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 35s
  13. ( 3 secs ) blink_platform_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:35.811261
  14. ( 2 secs ) shell_dialogs_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 26s
  15. ( 2 secs ) jingle_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 20s
  16. ( 2 secs ) midi_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 15s
  17. ( 2 secs ) crypto_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 14s
  18. ( 2 secs ) printing_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 19s
  19. ( 2 secs ) chrome_app_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:18.266841
  20. ( 2 secs ) blink_common_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 31s
  21. ( 2 secs ) wtf_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 18s
  22. ( 2 secs ) cronet_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 21s
  23. ( 1 secs ) ui_touch_selection_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 16s
  24. ( 2 secs ) sandbox_mac_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 15s
  25. ( 1 secs ) url_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 14s
  26. ( 2 secs ) native_theme_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 14s
  27. ( 2 secs ) capture_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 29s
  28. ( 2 secs ) display_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 18s
  29. ( 2 secs ) sql_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 15s
  30. ( 2 secs ) blink_heap_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:11.771940
  31. ( 2 secs ) service_manager_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 26s
  32. ( 2 secs ) app_shell_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 58s
  33. ( 2 secs ) message_center_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 27s
  34. ( 39 secs ) net_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:11:05.052597
  35. ( 2 secs ) pdf_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 38s
  36. ( 4 secs ) gfx_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:14.037287
  37. ( 2 secs ) cast_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 33s
  38. ( 2 secs ) latency_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 24s
  39. ( 3 secs ) webui_polymer2_browser_tests
    Run on OS: 'Mac-10.13'
    Max shard duration: 0:01:35.206033 (shard #0)
    Min shard duration: 0:01:20.644369 (shard #3)
  40. ( 1 secs ) media_service_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 42s
  41. ( 2 secs ) events_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 24s
  42. ( 2 secs ) gin_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 17s
  43. ( 2 secs ) ipc_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 27s
  44. ( 4 secs ) base_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:46.986126
  45. ( 2 secs ) google_apis_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 23s
  46. ( 2 secs ) chromedriver_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 24s
  47. ( 2 secs ) boringssl_ssl_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 16s
  48. ( 2 secs ) headless_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 39s
  49. ( 2 secs ) device_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 44s
  50. ( 2 secs ) ppapi_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 22s
  51. ( 2 secs ) cacheinvalidation_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  52. ( 5 secs ) angle_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:04:32.007882
  53. ( 2 secs ) gcm_unit_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 24s
  54. ( 2 secs ) filesystem_service_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 16s
  55. ( 2 secs ) blink_fuzzer_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 50s
  56. ( 2 secs ) leveldb_service_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 17s
  57. ( 2 secs ) crashpad_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:06.106565
  58. ( 2 secs ) cronet_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 22s
  59. ( 2 secs ) perfetto_content_browsertests
    Run on OS: 'Mac-10.13'
    Shard duration: 51s
  60. ( 2 secs ) libjingle_xmpp_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 25s
  61. ( 5 secs ) gpu_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:07.989985
  62. ( 2 secs ) boringssl_crypto_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 24s
  63. ( 2 secs ) ui_base_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 25s
  64. ( 1 secs ) wait for tasks (2)
  65. ( 12 secs ) components_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:06:17.768524
  66. ( 2 secs ) webui_polymer2_interactive_ui_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:51.797066
  67. ( 9 secs ) webkit_unit_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:04:48.306207
  68. ( 3 secs ) components_browsertests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:59.222432
  69. ( 2 secs ) media_blink_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:10.188535
  70. ( 3 secs ) extensions_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:39.630540
  71. ( 4 secs ) cc_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:02:18.738605
  72. ( 3 secs ) viz_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:02:22.102315
  73. ( 4 secs ) services_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:59.089609
  74. ( 2 secs ) extensions_browsertests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:04:15.709085
  75. ( 2 secs ) headless_browsertests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:42.999066
  76. ( 2 secs ) mojo_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 54s
  77. ( 2 secs ) remoting_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 55s
  78. ( 2 secs ) views_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 53s
  79. ( 4 secs ) media_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:35.934887
  80. ( 2 secs ) skia_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 27s
  81. ( 3 secs ) storage_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 55s
  82. ( 2 secs ) snapshot_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 28s
  83. ( 6 secs ) content_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:03:42.362752
  84. ( 1 secs ) wait for tasks (3)
  85. ( 9 secs ) unit_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:06:09.090532
  86. ( 8 mins 12 secs ) wait for tasks (4)
  87. ( 2 secs ) interactive_ui_tests
    Run on OS: 'Mac-10.13'
    Max shard duration: 0:17:28.305034 (shard #2)
    Min shard duration: 0:11:58.217336 (shard #1)
  88. ( 6 mins 2 secs ) wait for tasks (5)
  89. ( 6 secs ) content_browsertests
    Run on OS: 'Mac-10.13'
    Max shard duration: 0:24:10.874243 (shard #0)
    Min shard duration: 0:23:11.468413 (shard #1)
  90. ( 3 secs ) sync_integration_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:23:03.488384
  91. ( 1 secs ) Tests statistics
     
    Stats
    Total shards: 81
    Total runtime: 2:42:18.765403
     
  92. ( 2 ms ) recipe result

Build Properties:

NameValueSource
$build/goma {"jobs": 500} setup_build
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm258-m9" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541785499673673, "id": "8930314443853439376", "project": "chromium", "tags": ["builder:Mac ASan 64 Tests (1)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/77b7b35987d9420138ebc3fcb7d24d786bf5549c", "gitiles_ref:refs/heads/master", "parent_buildername:Mac ASan 64 Builder", "parent_buildnumber:70740", "scheduler_invocation_id:9095744505949582768", "scheduler_job_id:chromium/Mac ASan 64 Tests (1)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Mac ASan 64 Tests (1)" setup_build
buildnumber 46161 setup_build
mastername "chromium.memory" setup_build
parent_buildername "Mac ASan 64 Builder" setup_build
parent_got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" setup_build
parent_got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" setup_build
parent_got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" setup_build
parent_got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" setup_build
parent_got_revision "77b7b35987d9420138ebc3fcb7d24d786bf5549c" setup_build
parent_got_revision_cp "refs/heads/master@{#606866}" setup_build
parent_got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" setup_build
parent_got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" setup_build
parent_got_v8_revision_cp "refs/heads/7.2.286@{#1}" setup_build
parent_got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25544}" setup_build
parent_mastername "chromium.memory" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "77b7b35987d9420138ebc3fcb7d24d786bf5549c" setup_build
swarm_hashes {"accessibility_unittests": "e62b89e7e2ceddb1c00665b4944e8e7df52a33ff", "angle_unittests": "abe64000a1f2501129e126fe27234014f2e280a8", "app_shell_unittests": "28ed4b8ccc90c70fabf21834c42720aa4340c575", "base_unittests": "ff96d2e27fee4a257624adf1f7bc864469c92c46", "blink_common_unittests": "2f22d6e0ba45735434b6169a28ec1dbf6e8180e2", "blink_fuzzer_unittests": "035424b66729b423877c345af20d30d5e782b1f7", "blink_heap_unittests": "6d856445474a4673f9c9ba1912d029135e54e4e0", "blink_platform_unittests": "d6e92cfc9c627b8ca12a2de78f32e006de7bd744", "boringssl_crypto_tests": "31c1663513d6e724f32e517693c8861516df9493", "boringssl_ssl_tests": "b8b52d86aedc7fb14dc8b416ec912f34d2403b0d", "browser_tests": "b74a92526de31b0f0615dd80184c877bf81ebcd6", "cacheinvalidation_unittests": "fb59a79bacbbda74548897e2abf558474aad9b91", "capture_unittests": "7d421ec4cb843cce7eda6296ba1e0c7a577b6929", "cast_unittests": "7518e4691af7e8a7fd8adbef4a617b88341cfb80", "cc_unittests": "02215bd4ec7b719b75197b078da65bc750432fb2", "chrome_app_unittests": "eb8fb90d464840c2661c8aebe7fa9d2d32dcf4fc", "chromedriver_unittests": "5e23d3c7eda87cd22630e5c7d64b7920e8e71a25", "components_browsertests": "900415dabe75b1df9141f39ea5fd4214be5c814c", "components_unittests": "5447df8b35d13263104e1399af5bb30e810bcb53", "content_browsertests": "9cd29ab50a215230bbec55b92d0262a5fd80ad3a", "content_unittests": "d188394113ee4d35c3162fedfc4046d102efb6b3", "crashpad_tests": "95f12ce065d4cc6574e58f035884fd2dde64f450", "cronet_tests": "c0b57d75da6622e4e130a23f29d81cb6539d9e68", "cronet_unittests": "a97b0462a49ec2e97a782c9643738c5fcf45d46b", "crypto_unittests": "17ac069db197279b6a9275fc56bb43077d8f4f10", "device_unittests": "a8da940a864f14607711ffc82f3c2fbb2e36d482", "display_unittests": "c7ae21a579994573308c79b97178edeb39f5aabc", "events_unittests": "a82531b6c641cb63fa4bfbc050e67c8b4e1e6667", "extensions_browsertests": "378e5dc3f4fe5730cc9ed15b30fcbf0b7a28721d", "extensions_unittests": "bdd6f1335f257dd76d3f4a5386fdbcc62fa651cb", "filesystem_service_unittests": "3084f6627c9e6b3c874e03a614291caf626ee89a", "gcm_unit_tests": "3ae514aba70b534529cdaa1d249ba5909c6f06e7", "gfx_unittests": "ff182eaffe707c936a1244251604630324431419", "gin_unittests": "ea8cf7a698d37a82aca93322bc630737376b1e0d", "google_apis_unittests": "663d520fa2e208a3457eba93f8b29102362c29dc", "gpu_unittests": "d9f0a1dc6ec5d3f63ddc448e61010a82dddfa032", "headless_browsertests": "3b2469974772e82472dd9cbeed066d0f5b9471c2", "headless_unittests": "1edf8791b1650dad51b05724e1c715c1434701fe", "interactive_ui_tests": "a8bb7c7da694eff5b82bcdbad988ea79f9290b6c", "ipc_tests": "fbf668fd10cd39a15209cca903ddc116f28b65c4", "jingle_unittests": "fe43c990e78d3c7512e968aa15ee9ae39bc8fede", "latency_unittests": "6dead623e4b5fe7014a3dadd79663db23183e7ed", "leveldb_service_unittests": "b7875fa0ef06c2b1af25924756a64dc45d41031d", "libjingle_xmpp_unittests": "f102409dabe19d57f1abe6162aab2b1391dabaa2", "media_blink_unittests": "81d278f46ea833624a4ee955458ff2ad6b622768", "media_service_unittests": "f0978887b6bb3bffd5d4cf5d3eee9d801c3da689", "media_unittests": "af83a00f659a857245a1030daea7126651f8a8ab", "message_center_unittests": "15bd6a0612dea5f293a301a86a21daedcc61a9ed", "midi_unittests": "e1c151fa04293482901fae7f4256c1a6b1ec78e9", "mojo_unittests": "bedd6a9b797331ce1654c6ec1aaf52c46b50c6ef", "native_theme_unittests": "94aa3d0aabeb7657d399673f8558e8c6ca6c84a5", "net_unittests": "421abb95d1f755f62b19cf3d3babd5c2ca01dd87", "pdf_unittests": "55ca5ca0a5d96656d4f7751e267ad988b1e0841f", "ppapi_unittests": "ecb2e402b94265a383f85c30769da26b1fdf6f2e", "printing_unittests": "d2e7d395e360dc6983a88f1639f885d09ae49506", "remoting_unittests": "6213b17592326502c3b102b45a8b07db0d93adc4", "sandbox_mac_unittests": "ca6acc08d572a68e448f9417e95c21bccd121e59", "service_manager_unittests": "f835c7f5555af0b7bee2506f95d128ba0e3347ff", "services_unittests": "5269abec2985c511d8ab41d77ae9a4ec70756d47", "shell_dialogs_unittests": "797f8d790c4f345391394b982395800bab5876da", "skia_unittests": "e15e615014c8e33691bb78ff0a1fe0ca401c7593", "snapshot_unittests": "c2968c93357f9bc16a1aa14186e3b6a2ec73d946", "sql_unittests": "177021d6c27c7b758b65cafae81adff49b15164b", "storage_unittests": "c341278b724824cd04eda8c71fdacf4c9a65552e", "sync_integration_tests": "734dd2a0f82f17a108291825a0e1fa53db3e9bbc", "ui_base_unittests": "f439051f9bdf726bbc2c83e94b35b194c1b1a3ee", "ui_touch_selection_unittests": "21cb483615ac3e490cecc75c0cf7cfc33f580d9c", "unit_tests": "1e1f39e3430940f8358637bee2cc58023d0f3844", "url_unittests": "61e34049e3371eb5afbe60678acc4626828631e6", "views_unittests": "8c12fa740188501a67878ce8fb3bd599d8fdb231", "viz_unittests": "3b40c00853f30f34963b19de00c02ed357d769b1", "webkit_unit_tests": "7b13218af3b383388e5c03e7fae2245243a07fa9", "wtf_unittests": "5702c2ad7639c87387d5a22d1d94109c768f6b49"} setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "77b7b35987d9420138ebc3fcb7d24d786bf5549c" bot_update
got_revision_cp "refs/heads/master@{#606866}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" bot_update
got_v8_revision_cp "refs/heads/7.2.286@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. David 'Digit' Turner (digitohnoyoudont@google.com)
  2. James Hawkins (jhawkinsohnoyoudont@chromium.org)
  3. Antonio Gomes (tonikitooohnoyoudont@igalia.com)

Timing:

Create Friday, 09-Nov-18 17:44:59 UTC
Start Friday, 09-Nov-18 17:45:04 UTC
End Friday, 09-Nov-18 18:14:29 UTC
Pending 5 secs
Execution 29 mins 25 secs

All Changes:

  1. Android: Fix resource extraction from splits for Hebrew and others.

    Changed by David 'Digit' Turner - digitohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 16:32:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 77b7b35987d9420138ebc3fcb7d24d786bf5549c

    Comments

    Android: Fix resource extraction from splits for Hebrew and others.
    
    This CL fixes a bug in the logic used to locate locale .pak files
    inside bundle splits. The reason for the bug is that bundletool
    wants to use deprecated language names (i.e. 'iw' instead of 'he')
    to store asset files.
    
    As an example, for Hebrew, Chrome was looking at:
    
      assets/locales#lang_he/he.pak
    
    While the file was really stored under:
    
      assets/locales#lang_iw/he.pak
    
    The CL fixes the issue for Hebrew, Yiddish and Indonesian and
    Filipino.
    
    BUG=902915
    R=benmason@chromium.org, tiborg@chromium.org, yfriedman@chromium.org, twellington@chromium.org
    
    Change-Id: I420158c30ba33c6203495af9453877722271e104
    Reviewed-on: https://chromium-review.googlesource.com/c/1327203
    Commit-Queue: David Turner <digit@chromium.org>
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606866}

    Changed files

    • ui/android/java/src/org/chromium/ui/base/LocalizationUtils.java
    • ui/android/java/src/org/chromium/ui/resources/ResourceExtractor.java
    • ui/android/junit/src/org/chromium/ui/base/LocalizationUtilsTest.java
  2. Proximity Auth: Remove kMultiDeviceApi flagging from ProxAuthWebuiHandler.

    Changed by James Hawkins - jhawkinsohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:30:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d7bfd5bb2031d217d0e0f87240b4ce16705abb3d

    Comments

    Proximity Auth: Remove kMultiDeviceApi flagging from ProxAuthWebuiHandler.
    
    R=hansberry@chromium.org
    
    Bug: 899324
    Test: none
    Change-Id: Iac6aacb1b40608d261d6c13b12fd37bfd6b0df8f
    Reviewed-on: https://chromium-review.googlesource.com/c/1325393
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
    Commit-Queue: James Hawkins <jhawkins@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606865}

    Changed files

    • chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
    • chromeos/components/proximity_auth/webui/proximity_auth_ui.cc
    • chromeos/components/proximity_auth/webui/proximity_auth_ui.h
    • chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.cc
    • chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.h
  3. Use network::ResourceRequestInfo::proxy_server instead of was_fetched_via_proxy

    Changed by Antonio Gomes - tonikitooohnoyoudont@igalia.com
    Changed at Friday, 09-Nov-18 16:24:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f513b7c0c1803fe4688b8eee2dab06f48dabf081

    Comments

    Use network::ResourceRequestInfo::proxy_server instead of was_fetched_via_proxy
    
    ... and remove the later.
    
    This is a follow up of mmenke's request in [1].
    
    [1] https://crrev.com/c/1251642/3/services/network/url_loader.cc#70
    
    TBR=nparker@chromium (components/safe_browsing/browser/threat_details_cache.cc)
    TBR=jam@chromium.org (content/browser/loader/resource_loader.cc)
    
    BUG=773295
    
    Change-Id: I932315bec7d1790dbc8726eeb1decce6e76172b1
    Reviewed-on: https://chromium-review.googlesource.com/c/1320769
    Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606864}

    Changed files

    • components/policy/core/common/cloud/device_management_service.cc
    • components/safe_browsing/browser/threat_details_cache.cc
    • content/browser/loader/resource_loader.cc
    • services/network/public/cpp/resource_response.cc
    • services/network/public/cpp/resource_response_info.cc
    • services/network/public/cpp/resource_response_info.h
    • services/network/url_loader.cc