Home | Search | chromium - Builders
Login

Builder Mac ASan 64 Tests (1) Build 45028 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revision531c057ed48682ab7b275a932b872bcef1a932d9
Got Revision531c057ed48682ab7b275a932b872bcef1a932d9

Execution:

Steps and Logfiles:

Show:
  1. ( 497 ms ) setup_build
    running recipe: "chromium"
  2. ( 334 ms ) report builders
     
    running tester 'Mac ASan 64 Tests (1)' on master 'chromium.memory'
  3. ( 1 mins 40 secs ) bot_update
    [52GB/232GB used (22%)]
  4. ( 1 secs ) swarming.py --version
    0.13
  5. ( 246 ms ) ensure_installed
  6. ( 22 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.memory.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.memory.json
  8. ( 662 ms ) lookup builder GN args
     
    dcheck_always_on = true
    enable_nacl = false
    is_asan = true
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  9. ( 819 ms ) build directory
  10. ( 617 ms ) find isolated tests
  11. ( 2 secs ) accessibility_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 22s
  12. ( 5 secs ) angle_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:04:13.718876
  13. ( 2 secs ) app_shell_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 43s
  14. ( 4 secs ) base_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:21.891265
  15. ( 1 secs ) blink_common_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 20s
  16. ( 2 secs ) blink_fuzzer_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 23s
  17. ( 2 secs ) blink_heap_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 50s
  18. ( 4 secs ) blink_platform_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:15.647686
  19. ( 2 secs ) boringssl_crypto_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 20s
  20. ( 2 secs ) boringssl_ssl_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  21. ( 2 secs ) cacheinvalidation_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 11s
  22. ( 2 secs ) capture_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 20s
  23. ( 2 secs ) cast_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 20s
  24. ( 4 secs ) cc_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:02:11.258491
  25. ( 2 secs ) chrome_app_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 49s
  26. ( 2 secs ) chromedriver_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 20s
  27. ( 2 secs ) components_browsertests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:02:10.128143
  28. ( 4 mins 34 secs ) components_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:07:30.489219
  29. ( 2 secs ) perfetto_content_browsertests
    Run on OS: 'Mac-10.13'
    Shard duration: 43s
  30. ( 5 secs ) content_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:03:04.397648
  31. ( 2 secs ) crashpad_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:02.373299
  32. ( 2 secs ) cronet_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 20s
  33. ( 2 secs ) cronet_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 14s
  34. ( 2 secs ) crypto_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 11s
  35. ( 2 secs ) device_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 27s
  36. ( 2 secs ) display_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 14s
  37. ( 2 secs ) events_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 21s
  38. ( 2 secs ) extensions_browsertests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:03:22.235196
  39. ( 3 secs ) extensions_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:08.225001
  40. ( 2 secs ) filesystem_service_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  41. ( 2 secs ) gcm_unit_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 22s
  42. ( 4 secs ) gfx_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 59s
  43. ( 2 secs ) gin_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 15s
  44. ( 2 secs ) google_apis_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 19s
  45. ( 4 secs ) gpu_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:03.531777
  46. ( 2 secs ) headless_browsertests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:39.917249
  47. ( 2 secs ) headless_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 36s
  48. ( 2 secs ) webui_polymer2_interactive_ui_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 57s
  49. ( 2 secs ) ipc_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 23s
  50. ( 2 secs ) jingle_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 18s
  51. ( 2 secs ) latency_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  52. ( 1 secs ) leveldb_service_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  53. ( 2 secs ) libjingle_xmpp_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 22s
  54. ( 2 secs ) mac_installer_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 20s
  55. ( 3 secs ) media_blink_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 39s
  56. ( 2 secs ) media_service_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 19s
  57. ( 4 secs ) media_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:19.313481
  58. ( 2 secs ) message_center_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 18s
  59. ( 2 secs ) midi_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 11s
  60. ( 3 secs ) mojo_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 36s
  61. ( 2 secs ) native_theme_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 11s
  62. ( 30 secs ) net_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:12:07.104871
  63. ( 2 secs ) pdf_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 17s
  64. ( 2 secs ) ppapi_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 17s
  65. ( 2 secs ) printing_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  66. ( 3 secs ) remoting_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 40s
  67. ( 2 secs ) sandbox_mac_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 11s
  68. ( 2 secs ) service_manager_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 20s
  69. ( 3 secs ) services_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:29.688495
  70. ( 1 secs ) shell_dialogs_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 16s
  71. ( 2 secs ) skia_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 17s
  72. ( 2 secs ) snapshot_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 15s
  73. ( 2 secs ) sql_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 12s
  74. ( 2 secs ) storage_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 28s
  75. ( 8 mins 57 secs ) sync_integration_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:20:26.234615
  76. ( 2 secs ) traffic_annotation_auditor_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 15s
  77. ( 2 secs ) ui_base_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 24s
  78. ( 2 secs ) ui_touch_selection_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 15s
  79. ( 9 secs ) unit_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:07:01.990955
  80. ( 2 secs ) url_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  81. ( 2 secs ) views_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 43s
  82. ( 3 secs ) viz_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:59.096925
  83. ( 10 secs ) webkit_unit_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:04:10.750540
  84. ( 2 secs ) wtf_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 16s
  85. ( 6 secs ) content_browsertests
    Run on OS: 'Mac-10.13'
    Max shard duration: 0:20:20.927957 (shard #0)
    Min shard duration: 0:18:24.070094 (shard #1)
  86. ( 3 secs ) interactive_ui_tests
    Run on OS: 'Mac-10.13'
    Max shard duration: 0:15:08.971291 (shard #0)
    Min shard duration: 0:10:34.503571 (shard #1)
  87. ( 2 secs ) webui_polymer2_browser_tests
    Run on OS: 'Mac-10.13'
    Max shard duration: 0:01:48.584694 (shard #0)
    Min shard duration: 0:01:01.511596 (shard #1)
  88. ( 1 secs ) Tests statistics
     
    Stats
    Total shards: 83
    Total runtime: 2:29:50.184594
     
  89. ( 2 ms ) recipe result

Build Properties:

NameValueSource
$build/goma {"jobs": 500} setup_build
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm258-m9" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539354073518375, "id": "8932863978964644576", "project": "chromium", "tags": ["builder:Mac ASan 64 Tests (1)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/531c057ed48682ab7b275a932b872bcef1a932d9", "gitiles_ref:refs/heads/master", "parent_buildername:Mac ASan 64 Builder", "parent_buildnumber:68679", "scheduler_invocation_id:9098294041098702272", "scheduler_job_id:chromium/Mac ASan 64 Tests (1)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Mac ASan 64 Tests (1)" setup_build
buildnumber 45028 setup_build
mastername "chromium.memory" setup_build
parent_buildername "Mac ASan 64 Builder" setup_build
parent_got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" setup_build
parent_got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" setup_build
parent_got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" setup_build
parent_got_revision "531c057ed48682ab7b275a932b872bcef1a932d9" setup_build
parent_got_revision_cp "refs/heads/master@{#599198}" setup_build
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" setup_build
parent_got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" setup_build
parent_got_v8_revision_cp "refs/heads/7.1.302@{#1}" setup_build
parent_got_webrtc_revision "55d1af14751ad10e0cae741240f013ea67039f45" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25138}" setup_build
parent_mastername "chromium.memory" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "531c057ed48682ab7b275a932b872bcef1a932d9" setup_build
swarm_hashes {"accessibility_unittests": "f83094274938058375dbbd9d9c4b82849d5551e1", "angle_unittests": "bb460c861e1cd0c913ae347eae40e311735b476e", "app_shell_unittests": "7db4929aa50b5002ba78fdd5e786bc0414d5e9c3", "base_unittests": "bbc6d4360058efe0d9ca834b3472804787da92a5", "blink_common_unittests": "ac6e352fbd4f6d2d1a642322b471c8d2be9877e6", "blink_fuzzer_unittests": "b8c776f8ca25b8a95cf0b9938acca88db989ec59", "blink_heap_unittests": "9553c5abf56a42a0fff6b3d61eabd9acf4cbddc4", "blink_platform_unittests": "fcdc849a10f3de235575b622d7e3dbe489a7308e", "boringssl_crypto_tests": "bf4f9fa1f86962a3ffe72e168d4630176e339782", "boringssl_ssl_tests": "3acde4e26401193ac9a485d0651f10151068c1e6", "browser_tests": "517864270452380599281b1a97e15d2eaa80674e", "cacheinvalidation_unittests": "23bd19253a291a383f406767b62741019e70e537", "capture_unittests": "53f7ad4b746808d2bdd27ea082fbbc2bb818255e", "cast_unittests": "5eeae89ac82b48dbb3bfc712265530b78cee466a", "cc_unittests": "178b67146a5a965dd4229510e97fe73e3ab51fa5", "chrome_app_unittests": "9df7189686a3e1f6c3f39a4e6cc469a513bb3e1a", "chromedriver_unittests": "c960f465b35503506f15b28ff482a9bcb58d7fda", "components_browsertests": "1f79f840d18e19a55749c1f7a9b0db207ee787b7", "components_unittests": "83e89c41b69421dd2ec84a470bf560a7161675e8", "content_browsertests": "b43d1799e9c023509f2bfb565f229c0f3532de8e", "content_unittests": "b40a33a9067d12352d6235afd9cdd995bed18d25", "crashpad_tests": "69e3bb0b0aa9b30cafb753af4c3468b2e4d09e3a", "cronet_tests": "f5e85983d7d126473471683b76541eb030f187b2", "cronet_unittests": "d1777b970292a75a3e93166de4466b6e1ae5ce8f", "crypto_unittests": "9bf86ebe5db54dc58fad315f36a80c1969dc4713", "device_unittests": "87f9fce5cd1fe4935269aa4dbfbb68bd3393a04d", "display_unittests": "dbe2ddcd831a806557b77f7577f53ccee048a95a", "events_unittests": "665ced9d46d71838655869d184558b98ae792128", "extensions_browsertests": "0780ca0f4436d3b0b08103916c27dcc0376d7b5f", "extensions_unittests": "0c4268d6ef0e0dbef707ecec5c6817e9b57fa22f", "filesystem_service_unittests": "8ca1afc0e0cc2b368b278d51d67c99b4a7dd06f3", "gcm_unit_tests": "795a5cf818fac2397116dbd8b7f24d6d6bef7439", "gfx_unittests": "08bc44b01058ca2e3c080284d7168fd28894a049", "gin_unittests": "1a244ffcb6122284366825f78578d9430896b305", "google_apis_unittests": "c46d43f230677b07e1e05f348c5ff25e32ec3ff8", "gpu_unittests": "0415f49c1a97f40fd258fba31e7f24b814256ccb", "headless_browsertests": "18591782d5335ec74d9faf30850de8e6bb9f00b0", "headless_unittests": "1852e7d473d30e7ea9e9db7299f2a1ab1a661e55", "interactive_ui_tests": "4360734488df60f622ed1fe9c5a3876343961ddd", "ipc_tests": "8129dea99a044be4a17f0ed68fefe4ce55cf9e0e", "jingle_unittests": "531f80cbef3e601651bf319b046e56e2897d3be0", "latency_unittests": "aaf2daf4a2085760f1c18aa0a49ae907d097c60c", "leveldb_service_unittests": "846d026a533cade92d77d5b07cb6d9debab35e78", "libjingle_xmpp_unittests": "583611eb94c54b7828d06802ef145501d83ba5ea", "mac_installer_unittests": "c0ea08d27736a232d592b7aea4bc9318556b2ac8", "media_blink_unittests": "646ef2b1863ab05fcd0f7cce602d3dea1bb4e588", "media_service_unittests": "ac5dbd40ebdcba186d414f3f648aeb04d56d6330", "media_unittests": "59725a2b73baef0280b7b1289f7413244dd0d0f4", "message_center_unittests": "6a43a0817ab3fede2a24d38e581340f2d8915984", "midi_unittests": "40e97cf5ae1250140097295c5265b5a237bf78df", "mojo_unittests": "37aed9207f3cf6b88895c370b7ea57320abbeee6", "native_theme_unittests": "a640305a7311d2f3e854582c253c8200736bb939", "net_unittests": "2ca38a055d23eba02183092e564b666d0fcfed68", "pdf_unittests": "e65d47e940c07cbe661f7ff8d6c5bf48decfcc30", "ppapi_unittests": "f3ed190aeb5d3e1ff8cbf5d6c74d416a58bd6c0f", "printing_unittests": "2ff0e63c47c801ba3372c2ee1f4955015dcab27d", "remoting_unittests": "647eaf2204e369f19042677e30c0dba4bac4d81c", "sandbox_mac_unittests": "230f7a7456033cd7b1241bd5e7f0ea966b41acb5", "service_manager_unittests": "90c679c43d71377cded4b52c1f348920a72c26a3", "services_unittests": "c03eea6bcb46bf9943f360f17eb70695855805b6", "shell_dialogs_unittests": "0cec5b08e72113f8adbc6c8b48ff55779f1a0101", "skia_unittests": "30d46192d0dd7c4e6fe80d1bfa0318fd750fc9fd", "snapshot_unittests": "88f13b916fa26526468094c0728bef214c5aef02", "sql_unittests": "971b48fbe393020cc721160d764b040019a4d95f", "storage_unittests": "f1386ae5b45ac16e81909bc79bd125952f75fc04", "sync_integration_tests": "43f494a477f454b1d25dfa6f1b5da5ec73f432a9", "traffic_annotation_auditor_unittests": "3c7adb1708bf262e809bd0ca973999086747812d", "ui_base_unittests": "fbb51e492e9141577a07d788b13efc6ae22edc97", "ui_touch_selection_unittests": "dca2e6b20c9361b16d43cb98b6ddac5d2bfb59f3", "unit_tests": "3c217ee32d90a48225c87457aa10007e23858340", "url_unittests": "461046504576015f04cf5bf1e61ee5d356a5e9c2", "views_unittests": "b320159f8cd5868a2548357ebe1968bb1e5901db", "viz_unittests": "506d30223d6470916a95a92d64baaa91708b9147", "webkit_unit_tests": "4ad6c2424c97333d32e2ba6140ab4dfaa4fd2c31", "wtf_unittests": "d0b98cba78251653e1e860904186ab0e4acab80d"} setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "531c057ed48682ab7b275a932b872bcef1a932d9" bot_update
got_revision_cp "refs/heads/master@{#599198}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "55d1af14751ad10e0cae741240f013ea67039f45" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25138}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. Sam Maier (smaierohnoyoudont@chromium.org)
  2. Robert Ma (robertmaohnoyoudont@chromium.org)
  3. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
  4. Marc Treib (treibohnoyoudont@chromium.org)
  5. Stephane Zermatten (szermattohnoyoudont@chromium.org)
  6. Peng Huang (penghuangohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 14:21:13 UTC
Start Friday, 12-Oct-18 14:21:17 UTC
End Friday, 12-Oct-18 14:49:27 UTC
Pending 4 secs
Execution 28 mins 9 secs

All Changes:

  1. Android: Adding min_api for r8 dexing.

    Changed by Sam Maier - smaierohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 14:04:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 531c057ed48682ab7b275a932b872bcef1a932d9

    Comments

    Android: Adding min_api for r8 dexing.
    
    Bug: 872904
    Change-Id: I44e020b7d7d121650f4c292b71b4d2dbc45fa9f3
    Reviewed-on: https://chromium-review.googlesource.com/c/1277765
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Sam Maier <smaier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599198}

    Changed files

    • build/android/gyp/proguard.py
    • build/config/android/internal_rules.gni
  2. [WPT import] Add a flag to upload but not submit CL

    Changed by Robert Ma - robertmaohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:49:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 167121ea09987452572723a78b2d8987b770b751

    Comments

    [WPT import] Add a flag to upload but not submit CL
    
    We used to have only one flag, --auto-update, which controls both
    uploading and landing the import CL. This makes testing new setup of the
    bot (i.e. LUCI in this case) hard.
    
    This change adds one more flag, --auto-upload, to exercise more steps
    (namely uploading and rebaselining), which will be used on the
    experimental LUCI builder.
    
    Bug: 790503
    Change-Id: I4ce07fc9ddf15a34c9cb25ba4723d250cad26977
    Reviewed-on: https://chromium-review.googlesource.com/c/1277587
    Commit-Queue: Robert Ma <robertma@chromium.org>
    Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599197}

    Changed files

    • third_party/blink/tools/blinkpy/w3c/test_importer.py
  3. Restore FrameLoadRequest::HrefTranslate

    Changed by Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:42:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 703e2b8a5b805ecd4fba4bffb76095125330cec4

    Comments

    Restore FrameLoadRequest::HrefTranslate
    
    This was accidentaly removed as part of FrameLoadRequest cleanup.
    
    Bug: none
    Change-Id: I58bf324729d397a2f0340831fd116ab749f7a213
    Reviewed-on: https://chromium-review.googlesource.com/c/1278290
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599196}

    Changed files

    • third_party/blink/renderer/core/html/html_anchor_element.cc
    • third_party/blink/renderer/core/loader/frame_load_request.h
  4. ProfileSyncService cleanup: Remove platform_sync_allowed_provider_

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:42:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f0d63432c51741e6dc0bf48f0b84e4afb63f887f

    Comments

    ProfileSyncService cleanup: Remove platform_sync_allowed_provider_
    
    ProfileSyncService::platform_sync_allowed_provider_ was a callback that
    returned whether Android's "Master Sync" toggle is enabled, and so Sync
    shouldn't start up. However, PSS didn't know when the value changed, so
    the callback was kinda useless, and PSS could easily get into an
    inconsistent state (where there is a disable reason, but Sync is still
    running). Things were working out in practice only because the Android
    UI code also called RequestStart/Stop as necessary.
    So, since PSS needs change notifications anyway, let's make that
    explicit: This CL replaces the callback by a bool, which can be set
    explicitly.
    
    Bug: 867901
    Change-Id: I5b7e9f4657d1f565d9643984eb52ec1df26b5c90
    Reviewed-on: https://chromium-review.googlesource.com/c/1269870
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599195}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java
    • chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java
    • chrome/browser/sync/profile_sync_service_android.cc
    • chrome/browser/sync/profile_sync_service_android.h
    • components/browser_sync/profile_sync_service.cc
    • components/browser_sync/profile_sync_service.h
  5. [Autofill Assistant] Add Mathias and I as owners

    Changed by Stephane Zermatten - szermattohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:39:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b71114eba7ab4e982eaf03186b12503c8ca49c4

    Comments

    [Autofill Assistant] Add Mathias and I as owners
    
    Change-Id: I71ed01f39d1c81c62828d8e4900091e7941e7ab1
    Reviewed-on: https://chromium-review.googlesource.com/c/1278399
    Reviewed-by: Ganggui Tang <gogerald@chromium.org>
    Commit-Queue: Ganggui Tang <gogerald@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599194}

    Changed files

    • components/autofill_assistant/OWNERS
  6. Hook up skia makeYUVAPromiseTexture API

    Changed by Peng Huang - penghuangohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:39:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 33ca177f048a1d593c5486b46f09ac9ea91071a9

    Comments

    Hook up skia makeYUVAPromiseTexture API
    
    Know issues:
     * Skia only draws Y plane.
     * makeYUVAPromiseTexture() will release context, even if it failed.
     * Skia doesn't accept GL_RGBA8 format for a yuva plane
    
    Bug: 824382
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    Change-Id: Ic8da2b3de574ef2a0d527c79f34d383a676a3bc0
    Reviewed-on: https://chromium-review.googlesource.com/c/1262421
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Commit-Queue: Peng Huang <penghuang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599193}

    Changed files

    • components/viz/service/display/skia_output_surface.h
    • components/viz/service/display/skia_renderer.cc
    • components/viz/service/display_embedder/skia_output_surface_impl.cc
    • components/viz/service/display_embedder/skia_output_surface_impl.h
    • components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
    • components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.h