Home | Search | chromium - Builders
Login

Builder Mac ASan 64 Tests (1) Build 45017 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revision30958ae060dbfee80d985b84caa9e3c5f4d9c4cc
Got Revision30958ae060dbfee80d985b84caa9e3c5f4d9c4cc

Execution:

Steps and Logfiles:

Show:
  1. ( 491 ms ) setup_build
    running recipe: "chromium"
  2. ( 326 ms ) report builders
     
    running tester 'Mac ASan 64 Tests (1)' on master 'chromium.memory'
  3. ( 1 mins 29 secs ) bot_update
    [52GB/232GB used (22%)]
  4. ( 992 ms ) swarming.py --version
    0.13
  5. ( 220 ms ) ensure_installed
  6. ( 20 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.memory.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.memory.json
  8. ( 575 ms ) lookup builder GN args
     
    dcheck_always_on = true
    enable_nacl = false
    is_asan = true
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  9. ( 591 ms ) build directory
  10. ( 590 ms ) find isolated tests
  11. ( 2 secs ) accessibility_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 24s
  12. ( 5 secs ) angle_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:04:41.095741
  13. ( 2 secs ) app_shell_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:10.902208
  14. ( 4 secs ) base_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:28.631464
  15. ( 2 secs ) blink_common_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 19s
  16. ( 2 secs ) blink_fuzzer_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 46s
  17. ( 2 secs ) blink_heap_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 36s
  18. ( 3 secs ) blink_platform_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:28.790481
  19. ( 2 secs ) boringssl_crypto_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 25s
  20. ( 2 secs ) boringssl_ssl_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 14s
  21. ( 2 secs ) cacheinvalidation_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 10s
  22. ( 2 secs ) capture_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 20s
  23. ( 2 secs ) cast_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 19s
  24. ( 4 secs ) cc_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:02:59.335902
  25. ( 4 secs ) chrome_app_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:03.806749
  26. ( 2 secs ) chromedriver_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 23s
  27. ( 2 secs ) components_browsertests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:33.273163
  28. ( 4 mins 3 secs ) components_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:07:08.869137
  29. ( 2 secs ) perfetto_content_browsertests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:04.609090
  30. ( 9 mins 53 secs ) content_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:17:16.603292
  31. ( 2 secs ) crashpad_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:03.509068
  32. ( 2 secs ) cronet_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 17s
  33. ( 2 secs ) cronet_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 15s
  34. ( 1 secs ) crypto_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 11s
  35. ( 2 secs ) device_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 34s
  36. ( 2 secs ) display_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 24s
  37. ( 2 secs ) events_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 21s
  38. ( 2 secs ) extensions_browsertests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:04:02.142820
  39. ( 2 secs ) extensions_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:18.491967
  40. ( 2 secs ) filesystem_service_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 15s
  41. ( 2 secs ) gcm_unit_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 22s
  42. ( 4 secs ) gfx_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:00.094666
  43. ( 2 secs ) gin_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 22s
  44. ( 2 secs ) google_apis_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 19s
  45. ( 5 secs ) gpu_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:00.541154
  46. ( 2 secs ) headless_browsertests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:55.097520
  47. ( 2 secs ) headless_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 31s
  48. ( 2 secs ) webui_polymer2_interactive_ui_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:01.895399
  49. ( 2 secs ) ipc_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 24s
  50. ( 2 secs ) jingle_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 16s
  51. ( 2 secs ) latency_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 12s
  52. ( 2 secs ) leveldb_service_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 14s
  53. ( 2 secs ) libjingle_xmpp_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 23s
  54. ( 2 secs ) mac_installer_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  55. ( 2 secs ) media_blink_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 55s
  56. ( 2 secs ) media_service_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 22s
  57. ( 4 secs ) media_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:21.617165
  58. ( 2 secs ) message_center_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 15s
  59. ( 2 secs ) midi_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 11s
  60. ( 3 secs ) mojo_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 37s
  61. ( 2 secs ) native_theme_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 11s
  62. ( 29 secs ) net_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:09:32.076499
  63. ( 2 secs ) pdf_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 17s
  64. ( 2 secs ) ppapi_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 24s
  65. ( 2 secs ) printing_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  66. ( 4 secs ) remoting_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 47s
  67. ( 2 secs ) sandbox_mac_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 12s
  68. ( 2 secs ) service_manager_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 23s
  69. ( 4 secs ) services_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:12.125383
  70. ( 2 secs ) shell_dialogs_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 28s
  71. ( 2 secs ) skia_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 15s
  72. ( 1 secs ) snapshot_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 15s
  73. ( 2 secs ) sql_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 12s
  74. ( 2 secs ) storage_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 25s
  75. ( 3 mins 48 secs ) sync_integration_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:24:51.013915
  76. ( 2 secs ) traffic_annotation_auditor_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 15s
  77. ( 2 secs ) ui_base_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 23s
  78. ( 2 secs ) ui_touch_selection_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 14s
  79. ( 9 secs ) unit_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:05:33.889693
  80. ( 2 secs ) url_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 11s
  81. ( 2 secs ) views_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 37s
  82. ( 3 secs ) viz_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:02:07.390542
  83. ( 9 secs ) webkit_unit_tests
    Run on OS: 'Mac-10.13'
    Shard duration: 0:04:33.399998
  84. ( 2 secs ) wtf_unittests
    Run on OS: 'Mac-10.13'
    Shard duration: 17s
  85. ( 6 secs ) content_browsertests
    Run on OS: 'Mac-10.13'
    Max shard duration: 0:18:48.999398 (shard #0)
    Min shard duration: 0:18:32.085311 (shard #1)
  86. ( 2 secs ) interactive_ui_tests
    Run on OS: 'Mac-10.13'
    Max shard duration: 0:14:15.868207 (shard #0)
    Min shard duration: 0:11:38.701812 (shard #1)
  87. ( 2 secs ) webui_polymer2_browser_tests
    Run on OS: 'Mac-10.13'
    Max shard duration: 0:01:51.909474 (shard #1)
    Min shard duration: 0:01:18.714066 (shard #2)
  88. ( 1 secs ) Tests statistics
     
    Stats
    Total shards: 83
    Total runtime: 2:42:41.888542
     
  89. ( 1 ms ) recipe result

Build Properties:

NameValueSource
$build/goma {"jobs": 500} setup_build
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm258-m9" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539335682734912, "id": "8932883263099593536", "project": "chromium", "tags": ["builder:Mac ASan 64 Tests (1)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/30958ae060dbfee80d985b84caa9e3c5f4d9c4cc", "gitiles_ref:refs/heads/master", "parent_buildername:Mac ASan 64 Builder", "parent_buildnumber:68648", "scheduler_invocation_id:9098313325586051472", "scheduler_job_id:chromium/Mac ASan 64 Tests (1)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Mac ASan 64 Tests (1)" setup_build
buildnumber 45017 setup_build
mastername "chromium.memory" setup_build
parent_buildername "Mac ASan 64 Builder" setup_build
parent_got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" setup_build
parent_got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" setup_build
parent_got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" setup_build
parent_got_revision "30958ae060dbfee80d985b84caa9e3c5f4d9c4cc" setup_build
parent_got_revision_cp "refs/heads/master@{#599146}" setup_build
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" setup_build
parent_got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" setup_build
parent_got_v8_revision_cp "refs/heads/7.1.302@{#1}" setup_build
parent_got_webrtc_revision "a54daf162facb9fe30bcc3e05bd21c1597076157" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25135}" setup_build
parent_mastername "chromium.memory" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "30958ae060dbfee80d985b84caa9e3c5f4d9c4cc" setup_build
swarm_hashes {"accessibility_unittests": "17ce9b74b92e2ded7e447d620d6c1d2eca5708fd", "angle_unittests": "988be3c9cb678a64bf82b5ac78d59a301b88f5ee", "app_shell_unittests": "ee3f009a471791b9681eada60e95a0870fe9ae21", "base_unittests": "fe71ef864ff368dd49dd85e069a620c89594b347", "blink_common_unittests": "1557d8b121dd1fdb97d69dbee7ec31744f8a6b9e", "blink_fuzzer_unittests": "6b720861879f3b8cb868237c0a096c7593b179dc", "blink_heap_unittests": "e01c965ea16beb2e596db6abd2f4873d4016ee9e", "blink_platform_unittests": "57245be4b1694e2e91d2245a44210a9aac5746b8", "boringssl_crypto_tests": "9e4915a6f8220b739925a355e44212aece223047", "boringssl_ssl_tests": "6ed53aea3b02013b54bd1441e5dd22ee0d29d6aa", "browser_tests": "9805522032c1a6a9f03d3229c1837d3615503b7f", "cacheinvalidation_unittests": "032ae256b35846739ced82ad6629eb47eedf2775", "capture_unittests": "e5a0062036ae9218e23adf709d32f3783b027a33", "cast_unittests": "97390d633647238920adbd6d3b032dd281fd13eb", "cc_unittests": "7bfcf137b18bda807bd4379e5f04e8f80dcc2b16", "chrome_app_unittests": "f97581d8d59393ac1bde957cc117b07096203184", "chromedriver_unittests": "6a4fa6d38c600d870b0b2d0a09f8b0747f508dc4", "components_browsertests": "6080e26942e5a04310f6b312d7b24c238fa51fc9", "components_unittests": "c30fcf0d64382ec11acac3181533f7af877015e5", "content_browsertests": "e4d3815b3db63eced4fe3d939e072430cb2eb3f9", "content_unittests": "05f1bc8d1607289aa26f13ecf3c597ec5040365d", "crashpad_tests": "4427b0afecefd06ef934a54f1efd9aa7043f24f8", "cronet_tests": "20a36691066db48ffa0295b6fdbda8d9b05f1143", "cronet_unittests": "cb8c8d66f926240565a6718f3dd936a4d39fab38", "crypto_unittests": "cc2eb5591f8b2177ea90e1cca5063b0000fa5575", "device_unittests": "1ac85a3163b258f1ba185dc79586f5500b79cf3d", "display_unittests": "4accddd12c500b19934d24f8a7d59e01f3c774c5", "events_unittests": "2ef150677bb80c7d91dcb5a48040d77fffea709c", "extensions_browsertests": "b4b584c5efdf8c82a467d07b153b86316ec2dd4f", "extensions_unittests": "6f25202d7ca89b0166a2dd005c6dd5d4dc5b8572", "filesystem_service_unittests": "ed343bb6df61d140651fa7095f89baf5d3ba427a", "gcm_unit_tests": "c03a080ab380ae7774516244269d9f17b85ffa1c", "gfx_unittests": "5310679708d83fbbda253beb0bc227fd3631781f", "gin_unittests": "ef8506b1db7fade7e587266dc6b9b49b089a1e4e", "google_apis_unittests": "ce493609c6c8f660554dc209264285fe17f59aeb", "gpu_unittests": "d8da55c266d16fbedd5031ee7e07f7a9fb271ba4", "headless_browsertests": "bab2828176014905d02cb55f0ec52302173ede0e", "headless_unittests": "3252bc6d9e5103f4e595edd516b91cd1c1d6f07c", "interactive_ui_tests": "41411a32269d32ff9a73e345e70fd069bb92ee30", "ipc_tests": "b0c3db98f4f031a452f695bfb3414658a0f493cb", "jingle_unittests": "01ee84028ee4df6090d58ac79be0017c0e2f201f", "latency_unittests": "3f780c357093dcf50c7e4b67664e823e94d44354", "leveldb_service_unittests": "73a61b75709fdedfa12e80af686213f4822a3bc6", "libjingle_xmpp_unittests": "b70f480051ab9ccf7a1a9a193bbb8ce61dcbbd36", "mac_installer_unittests": "059c374dae8cab28f463675fcd46781294c6485a", "media_blink_unittests": "045ad13d70ea393e3e427f0d047053ce380766a6", "media_service_unittests": "294765966b2af7bc406b350942e807a5581dbeb0", "media_unittests": "82ab1e0ff81d8e2a2c037048b71c4bcd0af99e99", "message_center_unittests": "6cc7fd853e308f521fd6fe4c298137212603908f", "midi_unittests": "823763fba3bbf8359c5a8579deac985b673b131f", "mojo_unittests": "b205d6b4b4c4cbf1b34d3c4aa15a906e473be191", "native_theme_unittests": "dcfe1c70d29d0c6cc2301e29d427a570611ac222", "net_unittests": "49a2a9ddbf45de77e5ee159ae2c5a69cdd710b32", "pdf_unittests": "1d2067ab9ee2a0118809cb652ab0c953677b777e", "ppapi_unittests": "9ef416caea6eca448e1bd8905cd70e21a5126201", "printing_unittests": "a5baa5045e40e856fcc7d3ee61dff95294163956", "remoting_unittests": "bfe1ce8726312ca0ea729d1893ccd41b407d3ff7", "sandbox_mac_unittests": "669fa7d7c4bc8bfa7efe1ab3a1af9fdb0d3afa62", "service_manager_unittests": "c796e6ecbcb2bfc3226812795a8b73ca6df7bfc0", "services_unittests": "6156e1055fde8db89f3aab6c7b7dd3ff1ea9c402", "shell_dialogs_unittests": "78fe274734d0ba5b552d442b7057f3f984c80e43", "skia_unittests": "f821fe2215d73baf287379890545d7617149b705", "snapshot_unittests": "39d9c9f17063109343890b69503a24be94e92a7d", "sql_unittests": "97eb71756a2ac04d57cec676a7c5da58c90576b5", "storage_unittests": "3222e34b889f7e642bb79f99aa7c7879de987268", "sync_integration_tests": "d78104745528c0a8e70355787c18543bd1cbb381", "traffic_annotation_auditor_unittests": "35395a4f09807ffeb9d343b287221ee69e373b98", "ui_base_unittests": "09cbd96cfd31421a2b4c0da064209fee8a049e47", "ui_touch_selection_unittests": "937f32d36b0e9eb3086710f6d5ab29d20888961a", "unit_tests": "45b82793dbd0fa21a736476fcd758c851c6ae8ea", "url_unittests": "535f96a4ae3347f8feefc079b575a315e876435f", "views_unittests": "2c09df4dd4acc3719507ce517f6bd073a0449301", "viz_unittests": "60c10daecfacf4b06d3a50659563ce9a1e0f9fd1", "webkit_unit_tests": "5c8e5f1c10ddc170212facacaf22e0216a7d8cab", "wtf_unittests": "de26e70df084f816cd4ad3d4c6abce7ab2602e33"} setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "30958ae060dbfee80d985b84caa9e3c5f4d9c4cc" bot_update
got_revision_cp "refs/heads/master@{#599146}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "a54daf162facb9fe30bcc3e05bd21c1597076157" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25135}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. Alexander Alekseev (alemateohnoyoudont@chromium.org)
  2. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  3. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  4. Florent Castelli (orphisohnoyoudont@chromium.org)
  5. Fergal Daly (fergalohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 09:14:42 UTC
Start Friday, 12-Oct-18 09:14:45 UTC
End Friday, 12-Oct-18 09:46:20 UTC
Pending 3 secs
Execution 31 mins 34 secs

All Changes:

  1. Chrome OS: move DiscoverManager ownership to ChromeBrowserMainPartsChromeos.

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:49:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 30958ae060dbfee80d985b84caa9e3c5f4d9c4cc

    Comments

    Chrome OS: move DiscoverManager ownership to ChromeBrowserMainPartsChromeos.
    
    TBR=sky@chromium.org
    
    Bug: 828999
    Change-Id: I46514f21581ab6d30e1c4b38719b66e43b075f42
    Reviewed-on: https://chromium-review.googlesource.com/c/1278129
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599146}

    Changed files

    • chrome/browser/browser_process_platform_part_chromeos.cc
    • chrome/browser/browser_process_platform_part_chromeos.h
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.h
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
  2. [iOS] Support Accessibility ContentSize on NTP header

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:35:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 755d6f957abd6af5b8bbbf045ac622b92fea60a5

    Comments

    [iOS] Support Accessibility ContentSize on NTP header
    
    This CL changes the header of the "Articles for you" section of the NTP
    to have a better support for the "accessibility" categories of preferred
    content size chosen by the user.
    
    Bug: 893524
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I56ed6f89e7767697083c3e8e5d5a796db3066aee
    Reviewed-on: https://chromium-review.googlesource.com/c/1273522
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599145}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_articles_header_item.mm
    • ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
  3. [iOS] Use Dynamic Type in the empty NTP cell

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:35:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c245af46fb47db066cbdc99a5f578e2b94b2ca2f

    Comments

    [iOS] Use Dynamic Type in the empty NTP cell
    
    This CL adds Dynamic Type to the cell displayed when the NTP's articles
    section is empty.
    
    Bug: 893527
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: If36d6ece1eaac888f606f7730de379aec11ba6be
    Reviewed-on: https://chromium-review.googlesource.com/c/1273536
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599144}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_text_item.mm
  4. Revert "Move InstallAttributes to chromeos/settings"

    Changed by Florent Castelli - orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:33:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f32368f166f8a2d51078a6c6c2f6ffc8c3f2f7a9

    Comments

    Revert "Move InstallAttributes to chromeos/settings"
    
    This reverts commit aa6c62dce936e966e2db445045dd04414553642b.
    
    Reason for revert: Breaks build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-daisy-rel/33402
    
    Original change's description:
    > Move InstallAttributes to chromeos/settings
    > 
    > Necessary for moving CrosSettings to chromeos/settings, so it
    > can eventually be used by Mustash.
    > 
    > The following changes were necessary:
    > 1. Move install_attributes{.h, .cc} and unit_test.cc
    > 2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn
    > (destination)
    > 3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h,
    > which is included by install_attributes.h
    > 
    > 4. Unfortunately, that same dependency lead to a circular dependency.
    > I was able to avoid that by separating out a "common_constants" rule in
    > components/policy/core/common, so that chromeos/settings only depends on
    > that, and not on all of components/policy. So I had to change
    > components/policy/core/common/BUILD.gn
    > and I removed an unnecessary include from
    > components/policy/core/common/cloud/cloud_policy_constants.cc
    > 
    > 5. Update #include directives for install_attributes to point to new
    > location. This is the other 22 files, all with diffs of +1 -1.
    > 
    > Bug: 446937
    > Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288
    > Reviewed-on: https://chromium-review.googlesource.com/c/1264757
    > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    > Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    > Commit-Queue: A Olsen <olsen@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599140}
    
    TBR=stevenjb@chromium.org,emaxx@chromium.org,olsen@chromium.org
    
    Change-Id: I50c58b55830961d97834d86a76088dc50eff672d
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 446937
    Reviewed-on: https://chromium-review.googlesource.com/c/1278748
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599143}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/app_mode/kiosk_app_manager.h
    • chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/dbus/dbus_helper.cc
    • chrome/browser/chromeos/login/demo_mode/demo_session.cc
    • chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
    • chrome/browser/chromeos/policy/blocking_login_browsertest.cc
    • chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
    • chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
    • chrome/browser/chromeos/policy/enrollment_status_chromeos.h
    • chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
    • chrome/browser/chromeos/settings/device_settings_provider.cc
    • chrome/browser/chromeos/settings/install_attributes.cc
    • chrome/browser/chromeos/settings/install_attributes.h
    • chrome/browser/chromeos/settings/install_attributes_unittest.cc
    • chrome/browser/chromeos/settings/stub_install_attributes.h
    • chrome/browser/chromeos/system/device_disabling_manager.cc
    • chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
    • chrome/browser/ui/webui/policy_ui_handler.cc
    • chromeos/DEPS
    • chromeos/settings/BUILD.gn
    • components/policy/core/common/BUILD.gn
    • components/policy/core/common/cloud/cloud_policy_constants.cc
  5. [css, dom] Support partmap="foo: bar" syntax.

    Changed by Fergal Daly - fergalohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:26:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4cb84b573a62d8db8d168de16560b4ff78df5bda

    Comments

    [css, dom] Support partmap="foo: bar" syntax.
    
    This is the new syntax agreed for partmap.
    
    Bug: 805271
    Change-Id: I5e8e34551167b4a56706980dae8054e4b7a6fba2
    Reviewed-on: https://chromium-review.googlesource.com/c/1278566
    Commit-Queue: Fergal Daly <fergal@chromium.org>
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599142}

    Changed files

    • third_party/WebKit/LayoutTests/css-shadow-parts/double-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-change-part-name-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-change-partmap-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-complex-selector-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/precedence-part-vs-part.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/simple-forward.html
    • third_party/blink/renderer/core/dom/element_test.cc
    • third_party/blink/renderer/core/dom/names_map.cc
    • third_party/blink/renderer/core/dom/names_map_test.cc
    • third_party/blink/renderer/core/html/parser/html_parser_idioms.h