Home | Search | chromium - Builders
Login

Builder Mac ASAN Release Media Build 17621 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revisionc43eba9311573672d0773beed07f117d08eed09f
Got Revisionc43eba9311573672d0773beed07f117d08eed09f

Execution:

Steps and Logfiles:

Show:
  1. ( 380 ms ) setup_build
    running recipe: "chromium"
  2. ( 265 ms ) report builders
     
    running builder 'Mac ASAN Release Media' on master 'chromium.lkgr'
  3. ( 1 mins 27 secs ) bot_update
    [113GB/232GB used (48%)]
  4. ( 802 ms ) swarming.py --version
    0.13
  5. ( 8 secs ) clobber
  6. ( 180 ms ) ensure_installed
  7. ( 15 secs ) gclient runhooks
  8. ( 450 ms ) lookup GN args
     
    enable_ipc_fuzzer = true
    enable_nacl = false
    ffmpeg_branding = "Chrome"
    is_asan = true
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    sanitizer_coverage_flags = "trace-pc-guard"
    strip_absolute_paths_from_debug_symbols = true
    use_goma = true
    v8_enable_verify_heap = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  9. ( 21 secs ) generate_build_files
  10. ( 667 ms ) clang_revision
  11. ( 48 mins 45 secs ) compile
  12. ( 440 ms ) create staging_dir
  13. ( 462 ms ) Copy sancov
  14. ( 1 secs ) filter build_dir
  15. ( 4 mins 14 secs ) zipping
  16. ( 1 mins 22 secs ) gsutil upload

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "build153-m9" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539351425822229, "id": "8932866755275006240", "project": "chromium", "tags": ["builder:Mac ASAN Release Media", "buildset:commit/git/c43eba9311573672d0773beed07f117d08eed09f", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/c43eba9311573672d0773beed07f117d08eed09f", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9098296817448379728", "scheduler_job_id:chromium/Mac ASAN Release Media", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Mac ASAN Release Media" setup_build
buildnumber 17621 setup_build
mastername "chromium.lkgr" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "c43eba9311573672d0773beed07f117d08eed09f" setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "c43eba9311573672d0773beed07f117d08eed09f" bot_update
got_revision_cp "refs/heads/master@{#599192}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "55d1af14751ad10e0cae741240f013ea67039f45" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25138}" bot_update
got_clang_revision "344066-1" clang_revision

Blamelist:

  1. Ben Kelly (wanderviewohnoyoudont@chromium.org)
  2. Shu Chen (shuchenohnoyoudont@google.com)
  3. Findit (findit-for-meohnoyoudont@appspot.gserviceaccount.com)

Timing:

Create Friday, 12-Oct-18 13:37:05 UTC
Start Friday, 12-Oct-18 13:37:10 UTC
End Friday, 12-Oct-18 14:35:19 UTC
Pending 4 secs
Execution 58 mins 9 secs

All Changes:

  1. Make DataPipeBytesConsumer support ReadableStream loading better.

    Changed by Ben Kelly - wanderviewohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:36:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c43eba9311573672d0773beed07f117d08eed09f

    Comments

    Make DataPipeBytesConsumer support ReadableStream loading better.
    
    This CL fixes some edge condition interactions when being loaded as
    a ReadableStream.  In particular, it:
    
    1. Properly distinguishes between the end of the DataPipe and a closed
       DataPipe with bytes left to be read.  A ReadableStream that is not
       actively draining the pipe could get closed too early.
    2. Responses must support explicit completion in order to handle error
       conditions properly.  This CL makes DataPipeBytesConsumer wait
       for an explicit signal before closing.
    3. Service worker navigation preload is updated to provide the explicit
       completion signals.
    
    Bug: 894815
    Change-Id: I8cff3de94aa2dcbc8deb4a9601a95c13b8ab94d9
    Reviewed-on: https://chromium-review.googlesource.com/c/1272715
    Commit-Queue: Ben Kelly <wanderview@chromium.org>
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599192}

    Changed files

    • content/browser/service_worker/service_worker_browsertest.cc
    • third_party/blink/renderer/core/fetch/bytes_consumer.h
    • third_party/blink/renderer/core/fetch/data_pipe_bytes_consumer.cc
    • third_party/blink/renderer/core/fetch/data_pipe_bytes_consumer.h
    • third_party/blink/renderer/core/fetch/data_pipe_bytes_consumer_test.cc
    • third_party/blink/renderer/core/fetch/fetch_data_loader.cc
    • third_party/blink/renderer/core/fetch/fetch_data_loader.h
    • third_party/blink/renderer/modules/service_worker/fetch_event.cc
    • third_party/blink/renderer/modules/service_worker/fetch_event.h
    • third_party/blink/renderer/modules/service_worker/fetch_respond_with_observer.cc
  2. Avoid using gypi_to_gn.py.

    Changed by Shu Chen - shuchenohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 13:25:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b85f543af1e343404dde1a2c51067b2ed5ac08cb

    Comments

    Avoid using gypi_to_gn.py.
    
    Change-Id: I9bac8317577feaadfa00ec88661175b7338ced4a
    Reviewed-on: https://chromium-review.googlesource.com/c/1267596
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Shu Chen <shuchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599191}

    Changed files

    • third_party/google_input_tools/README.chromium
    • third_party/google_input_tools/builder.py
    • third_party/google_input_tools/closure.gni
    • third_party/google_input_tools/inputview.gni
    • third_party/google_input_tools/inputview.gypi
    • third_party/google_input_tools/update.py
    • ui/keyboard/BUILD.gn
  3. Revert "Files app: Select My files when there are no volumes"

    Changed by Findit - findit-for-meohnoyoudont@appspot.gserviceaccount.com
    Changed at Friday, 12-Oct-18 13:17:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 402571f89e1aff1627ccf491110764c74029e3de

    Comments

    Revert "Files app: Select My files when there are no volumes"
    
    This reverts commit 5cd8c123e452c0b76fbbcaf53e82d86ca7d54930.
    
    Reason for revert:
    
    Findit (https://goo.gl/kROfz5) identified CL at revision 599026 as the
    culprit for flakes in the build cycles as shown on:
    https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNWNkOGMxMjNlNDUyYzBiNzZmYmJjYWY1M2U4MmQ4NmNhN2Q1NDkzMAw
    
    Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/9016
    
    Sample Failed Step: viz_browser_tests
    
    Sample Flaky Test: FileDisplay/FilesAppBrowserTest.Test/fileDisplayWithoutVolumesThenMountDrive_DriveFs
    
    Original change's description:
    > Files app: Select My files when there are no volumes
    > 
    > Make Files app select "My files" when there are no available volumes,
    > this to allow Files app to behave properly when volumes subsequently
    > become available.
    > 
    > Change DirectoryModel.onVolumeInfoListUpdated_ method to check for
    > non-null |displayRoot| before trying to change to |displayRoot|. This
    > fixes the error "Cannot read property 'getParent' of null" when Drive
    > volume becomes available before Downloads volume, which is the default
    > volume/root.
    > 
    > Change FakeDriveFs to unbind the two mojo bindings if they're bound, so
    > DriveFsTestVolume can re-mount itself.
    > 
    > Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*"
    > Bug: 893161, 884967
    > Change-Id: Ic813b25261530495c11c9f641a92f6e07f883702
    > Reviewed-on: https://chromium-review.googlesource.com/c/1272418
    > Reviewed-by: Noel Gordon <noel@chromium.org>
    > Reviewed-by: Sam McNally <sammc@chromium.org>
    > Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599026}
    
    Change-Id: I883485c8fc1bdcc22dba93cc4b03b7c157dcb5f2
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 893161, 884967, 889703
    Reviewed-on: https://chromium-review.googlesource.com/c/1278063
    Cr-Commit-Position: refs/heads/master@{#599190}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
    • chromeos/components/drivefs/fake_drivefs.cc
    • ui/file_manager/file_manager/foreground/js/directory_model.js
    • ui/file_manager/file_manager/foreground/js/file_manager.js
    • ui/file_manager/integration_tests/file_manager/file_display.js