Home | Search | chromium - Builders
Login

Builder Mac ASAN Release Media Build 13764 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revisionb56c4e40b65ee14134dd2e61834f260ca9c1715e
Got Revisionb56c4e40b65ee14134dd2e61834f260ca9c1715e

Execution:

Steps and Logfiles:

Show:
  1. ( 305 ms ) setup_build
    running recipe: "chromium"
  2. ( 374 ms ) remove .cipd
  3. ( 1 mins 12 secs ) bot_update
    [86GB/232GB used (37%)]
  4. ( 0 ) ensure_goma
  5. ( 719 ms ) swarming.py --version
    0.13
  6. ( 7 secs ) clobber
  7. ( 176 ms ) ensure_installed
  8. ( 13 secs ) gclient runhooks
  9. ( 17 secs ) generate_build_files
  10. ( 640 ms ) clang_revision
  11. ( 42 mins 54 secs ) compile
  12. ( 390 ms ) create staging_dir
  13. ( 411 ms ) Copy sancov
  14. ( 898 ms ) filter build_dir
  15. ( 2 mins 24 secs ) zipping
  16. ( 50 secs ) gsutil upload

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "build152-m9" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531399283519340, "id": "8941205180843380592", "project": "chromium", "tags": ["builder:Mac ASAN Release Media", "buildset:commit/git/b56c4e40b65ee14134dd2e61834f260ca9c1715e", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/b56c4e40b65ee14134dd2e61834f260ca9c1715e", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9106635242887743152", "scheduler_job_id:chromium/Mac ASAN Release Media", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Mac ASAN Release Media" setup_build
buildnumber 13764 setup_build
mastername "chromium.lkgr" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "b56c4e40b65ee14134dd2e61834f260ca9c1715e" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "b56c4e40b65ee14134dd2e61834f260ca9c1715e" bot_update
got_revision_cp "refs/heads/master@{#574538}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23944}" bot_update
got_clang_revision "336424-1" clang_revision

Blamelist:

  1. Elly Fong-Jones (ellyjonesohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 12:41:23 UTC
Start Thursday, 12-Jul-18 12:41:25 UTC
End Thursday, 12-Jul-18 13:30:48 UTC
Pending 1 secs
Execution 49 mins 22 secs

All Changes:

  1. macviews: switch back to Cocoa menus for Views context menus

    Changed by Elly Fong-Jones - ellyjonesohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:36:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b56c4e40b65ee14134dd2e61834f260ca9c1715e

    Comments

    macviews: switch back to Cocoa menus for Views context menus
    
    This change:
    1) Reverts erikchen@'s 79c8511fb8801f7fc23c4cbe81311b6065daef15, which removed
       the Cocoa menu runner code;
    2) Wires the Cocoa menu runner code back up in MenuRunnerImplInterface::Create;
    3) Fixes a latent bug in Textfield that could cause it to delete its context
       menu while handling a context menu activation - this is fine with Views menus
       but forbidden with Cocoa menus.
    
    Bug: 860673
    Change-Id: If110f09379c4661a4f61a8b0257cf5214503e6a9
    Reviewed-on: https://chromium-review.googlesource.com/1131564
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574538}

    Changed files

    • ui/views/BUILD.gn
    • ui/views/controls/menu/menu_runner_cocoa_unittest.mm
    • ui/views/controls/menu/menu_runner_impl.cc
    • ui/views/controls/menu/menu_runner_impl_cocoa.h
    • ui/views/controls/menu/menu_runner_impl_cocoa.mm
    • ui/views/controls/textfield/textfield.cc
    • ui/views/controls/textfield/textfield_unittest.cc