Home | Search | chromium - Builders
Login

Builder Mac ASAN Debug Build 16052 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revision9773a84184a277ad674bbe729aa26677f1f3c800
Got Revision9773a84184a277ad674bbe729aa26677f1f3c800

Execution:

Steps and Logfiles:

Show:
  1. ( 341 ms ) setup_build
    running recipe: "chromium"
  2. ( 216 ms ) report builders
     
    running builder 'Mac ASAN Debug' on master 'chromium.lkgr'
  3. ( 1 mins 24 secs ) bot_update
    [137GB/232GB used (59%)]
  4. ( 1 secs ) swarming.py --version
    0.13
  5. ( 7 secs ) clobber
  6. ( 432 ms ) ensure_installed
  7. ( 14 secs ) gclient runhooks
  8. ( 391 ms ) lookup GN args
     
    enable_ipc_fuzzer = true
    enable_nacl = false
    is_asan = true
    is_component_build = false
    is_debug = true
    sanitizer_coverage_flags = "trace-pc-guard"
    strip_absolute_paths_from_debug_symbols = true
    use_goma = true
    v8_enable_verify_heap = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  9. ( 21 secs ) generate_build_files
  10. ( 637 ms ) clang_revision
  11. ( 1 hrs 40 mins ) compile
  12. ( 454 ms ) create staging_dir
  13. ( 463 ms ) Copy sancov
  14. ( 956 ms ) filter build_dir
  15. ( 9 mins 7 secs ) zipping
  16. ( 2 mins 49 secs ) gsutil upload

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "build156-m9" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541779030331596, "id": "8930321227450309712", "project": "chromium", "tags": ["builder:Mac ASAN Debug", "buildset:commit/git/9773a84184a277ad674bbe729aa26677f1f3c800", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/9773a84184a277ad674bbe729aa26677f1f3c800", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095751289666360864", "scheduler_job_id:chromium/Mac ASAN Debug", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Mac ASAN Debug" setup_build
buildnumber 16052 setup_build
mastername "chromium.lkgr" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "9773a84184a277ad674bbe729aa26677f1f3c800" setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "9773a84184a277ad674bbe729aa26677f1f3c800" bot_update
got_revision_cp "refs/heads/master@{#606854}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" bot_update
got_v8_revision_cp "refs/heads/7.2.286@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
got_clang_revision "346388-1" clang_revision

Blamelist:

  1. Eugene But (eugenebutohnoyoudont@google.com)
  2. Pavel Shmakov (pshmakovohnoyoudont@google.com)

Timing:

Create Friday, 09-Nov-18 15:57:10 UTC
Start Friday, 09-Nov-18 15:57:35 UTC
End Friday, 09-Nov-18 17:53:30 UTC
Pending 25 secs
Execution 1 hrs 55 mins

All Changes:

  1. Update SadTabTabHelper to work with SadTabCoordinator.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:56:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9773a84184a277ad674bbe729aa26677f1f3c800

    Comments

    Update SadTabTabHelper to work with SadTabCoordinator.
    
    SadTabTabHelper now calls sadTabTabHelperDidHide: and
    sadTabTabHelper:didShowForRepeatedFailure:
    
    Bug: 901563
    Change-Id: If2b75702c951c247d44368b681ce360bbb6464d5
    Reviewed-on: https://chromium-review.googlesource.com/c/1327167
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606854}

    Changed files

    • ios/chrome/browser/web/sad_tab_tab_helper.h
    • ios/chrome/browser/web/sad_tab_tab_helper.mm
    • ios/chrome/browser/web/sad_tab_tab_helper_unittest.mm
  2. Refactor Trusted Web Activity UI code to MVC

    Changed by Pavel Shmakov - pshmakovohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:56:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3a5daa30c703af7c6e90dd5088cdbd5fdcfdc7d0

    Comments

    Refactor Trusted Web Activity UI code to MVC
    
    The code is restructured according to the high-level MVC picture, but
    low-level details such as view binding mechanism are not used, as
    it seems to be an overkill at this point. We can easily install those
    mechanisms in future should the model become more complicated.
    
    Verification is extracted to TrustedWebActivityVerifier in the
    controller layer. Several controllers observe verification and update
    the model. Several independent Views are observing the changes in the
    model and updating themselves accordingly.
    
    Change-Id: I8882da2d648fcea21b85fd4a1c0568dd00e47113
    Reviewed-on: https://chromium-review.googlesource.com/c/1323069
    Reviewed-by: Peter Conn <peconn@chromium.org>
    Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606853}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/ClientAppDataRegister.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityOpenTimeRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityUi.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/TrustedWebActivityCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/TrustedWebActivityModel.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/ClientAppDataRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/PersistentNotificationController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityDisclosureController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityOpenTimeRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityToolbarController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityVerifier.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/PersistentNotificationView.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/TrustedWebActivityDisclosureView.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/TrustedWebActivityToolbarView.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/dependency_injection/CustomTabActivityComponent.java
    • chrome/android/java_sources.gni
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosureTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/ClientAppDataRecorderTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityDisclosureControllerTest.java