Home | Search | chromium - Builders
Login

Builder Mac ASAN Debug Build 13718 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revision206d44a2086dc771c898b5d3f9da0bcd95f6c0a7
Got Revision206d44a2086dc771c898b5d3f9da0bcd95f6c0a7

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. Yuwei Huang (yuweihohnoyoudont@chromium.org)

Timing:

Create Saturday, 11-Aug-18 04:59:50 UTC
Start Saturday, 11-Aug-18 05:00:14 UTC
End Saturday, 11-Aug-18 06:35:49 UTC
Pending 23 secs
Execution 1 hrs 35 mins

All Changes:

  1. [CRD iOS] Make ChromotingSession own the AudioStub

    Changed by Yuwei Huang - yuweihohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 04:59:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 206d44a2086dc771c898b5d3f9da0bcd95f6c0a7

    Comments

    [CRD iOS] Make ChromotingSession own the AudioStub
    
    Previously AudioStub is owned by the the (Remoting|Jni)Client class and
    being passed to ChromotingSession as a WeakPtr. The AudioStub is not
    used after it is passed to ChromotingSession and it is a burden for the
    *Client class to manage its lifetime.
    
    This CL fixes this by making ChromotingSession own the AudioStub.
    
    Bug: 868088
    Change-Id: I067f321b3aab7110df7bb85a8b8c519ea889865e
    Reviewed-on: https://chromium-review.googlesource.com/1171840
    Reviewed-by: Joe Downing <joedow@chromium.org>
    Commit-Queue: Yuwei Huang <yuweih@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582428}

    Changed files

    • remoting/client/audio/audio_playback_stream.cc
    • remoting/client/audio/audio_playback_stream.h
    • remoting/client/chromoting_session.cc
    • remoting/client/chromoting_session.h
    • remoting/client/jni/jni_client.cc
    • remoting/client/jni/jni_client.h
    • remoting/ios/session/remoting_client.mm