Home | Search | chromium - Builders

Builder MSAN Release (chained origins) Build 51994 Canonical Ubuntu



Trigger Info:

Got Revision863a437d0fdbbba19ad5446420b72d2f91748a72


Steps and Logfiles:

  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:



  1. Colin Blundell (blundellohnoyoudont@chromium.org)


Create Friday, 12-Oct-18 13:16:05 UTC
Start Friday, 12-Oct-18 13:16:06 UTC
End Friday, 12-Oct-18 14:24:06 UTC
Pending 1 secs
Execution 1 hrs 8 mins

All Changes:

  1. Start using IdentityTestEnvironment in ProfileSyncServiceBundle

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:10:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Revision 863a437d0fdbbba19ad5446420b72d2f91748a72


    Start using IdentityTestEnvironment in ProfileSyncServiceBundle
    ProfileSyncServiceBundle owns and exposes signin-related objects for
    use by sync tests. These signin-related objects include ones that are
    deprecated by IdentityManager and no longer used directly in the
    production code being tested; however, up until now it has not been
    feasible to convert this test utility to using IdentityTestEnvironment,
    as doing so would have required converting the widespread usage of this
    utility in one go.
    We recently introduced an IdentityTestEnvironment usage mode wherein
    it can be supplied with IdentityManager's dependencies from the
    external client, precisely to enable incremental conversion in use cases
    like this. This CL exploits this usage mode to introduce
    IdentityTestEnvironment in ProfileSyncServiceBundle.h and provide an
    example of its usage to eliminate a direct usage of the deprecated
    classes. Once the conversion is complete, ProfileSyncServiceBundle can
    then be changed to *only* hold an IdentityTestEnvironment object.
    Bug: 886600, 886599
    Change-Id: I205c3567fc0a9bcd6f7b613c00a247c302d71be5
    Reviewed-on: https://chromium-review.googlesource.com/c/1273065
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599189}

    Changed files

    • components/browser_sync/BUILD.gn
    • components/browser_sync/profile_sync_service_autofill_unittest.cc
    • components/browser_sync/profile_sync_test_util.cc
    • components/browser_sync/profile_sync_test_util.h