Home | Search | chromium - Builders

Builder MSAN Release (chained origins) Build 39319 Canonical Ubuntu



Trigger Info:

Got Revisiondcf09c7b1347f35a690e11fc7f592b678d5532db


Steps and Logfiles:

  1. ( 294 ms ) setup_build
    running recipe: "chromium"
  2. ( 462 ms ) remove .cipd
  3. ( 44 secs ) bot_update
    [58GB/295GB used (19%)]
  4. ( 0 ) ensure_goma
  5. ( 599 ms ) swarming.py --version
  6. ( 4 secs ) clobber
  7. ( 10 secs ) gclient runhooks
  8. ( 615 ms ) clang_revision
  9. ( 4 mins 24 secs ) compile
  10. ( 449 ms ) create staging_dir
  11. ( 461 ms ) Copy sancov
  12. ( 676 ms ) filter build_dir
  13. ( 2 mins 30 secs ) zipping
  14. ( 20 secs ) gsutil upload

Build Properties:

$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm1959-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531429689591010, "id": "8941173297765815296", "project": "chromium", "tags": ["builder:MSAN Release (chained origins)", "buildset:commit/git/dcf09c7b1347f35a690e11fc7f592b678d5532db", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/dcf09c7b1347f35a690e11fc7f592b678d5532db", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9106603359969585296", "scheduler_job_id:chromium/MSAN Release (chained origins)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "MSAN Release (chained origins)" setup_build
buildnumber 39319 setup_build
mastername "chromium.lkgr" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "dcf09c7b1347f35a690e11fc7f592b678d5532db" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "dcf09c7b1347f35a690e11fc7f592b678d5532db" bot_update
got_revision_cp "refs/heads/master@{#574717}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "895617fa9bc36c240b37d47402cdb341ecadf994" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23955}" bot_update
got_clang_revision "336424-1" clang_revision


  1. liberato@chromium.org (liberatoohnoyoudont@chromium.org)


Create Thursday, 12-Jul-18 21:08:09 UTC
Start Thursday, 12-Jul-18 21:08:15 UTC
End Thursday, 12-Jul-18 21:17:40 UTC
Pending 5 secs
Execution 9 mins 25 secs

All Changes:

  1. Handle MCVD cleanup properly if texture has been destroyed.

    Changed by liberato@chromium.org - liberatoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 21:05:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Revision dcf09c7b1347f35a690e11fc7f592b678d5532db


    Handle MCVD cleanup properly if texture has been destroyed.
    If AbstractTexture drops its reference to the underlying texture,
    then that texture might have been freed.  This happens when the
    gl stub is lost.
    Previously, MCVD assumed that the CodecImage attached to the texture
    was valid.  However, if the AbstractTexture has dropped its ref
    to the texture, and there are no other refs, then this assumption
    isn't right.
    This CL checks if the AbstractTexture still has a TextureBase before
    referencing the CodecImage.
    An alternate approach of holding a scoped_refptr to the CodecImage
    in the callback would also work, but might keep the CodecImage
    around longer than it should when the stub is destroyed.  This can
    hold the MediaCodec open longer if the CodecImage has an unrendered
    codec buffer.
    Bug: 863012
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: If83a9eb0c27d6eb8e995424bdf71f7f7bc93590d
    Reviewed-on: https://chromium-review.googlesource.com/1135697
    Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    Commit-Queue: Frank Liberato <liberato@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574717}

    Changed files

    • media/gpu/android/texture_pool.cc
    • media/gpu/android/video_frame_factory_impl.cc