Builder Lollipop Tablet Tester Build 2099

Results:

Failure angle_unittests on Android device Nexus 7 [2013] Failure base_unittests on Android device Nexus 7 [2013] Failure blink_heap_unittests on Android device Nexus 7 [2013] Failure blink_platform_unittests on Android device Nexus 7 [2013] Failure boringssl_crypto_tests on Android device Nexus 7 [2013] Failure cc_unittests on Android device Nexus 7 [2013] Failure chrome_sync_shell_test_apk on Android device Nexus 7 [2013] Failure components_browsertests on Android device Nexus 7 [2013] Failure perfetto_content_browsertests on Android device Nexus 7 [2013] Failure gfx_unittests on Android device Nexus 7 [2013] Failure gpu_unittests on Android device Nexus 7 [2013] Failure media_unittests on Android device Nexus 7 [2013] Failure mojo_test_apk on Android device Nexus 7 [2013] Failure services_unittests on Android device Nexus 7 [2013] Failure webkit_unit_tests on Android device Nexus 7 [2013] Failure content_shell_test_apk on Android device Nexus 7 [2013] Failure content_unittests on Android device Nexus 7 [2013] Failure net_unittests on Android device Nexus 7 [2013] Failure components_unittests on Android device Nexus 7 [2013] Failure webview_instrumentation_test_apk on Android device Nexus 7 [2013] Failure content_browsertests on Android device Nexus 7 [2013] Failure unit_tests on Android device Nexus 7 [2013] Failure chrome_public_test_apk on Android device Nexus 7 [2013]

Trigger Info:

Project	chromium
Revision	40a6cb9be79a8d05395498a705e59d50cbb77f57
Got Revision	40a6cb9be79a8d05395498a705e59d50cbb77f57

Execution:

• Source: Task 408062515ea6d910
• Bot: swarm99-c4

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog

   Log stream has no annotation entries
   • - no logs -

Build Properties:

Name	Value	Source

Blamelist:

1. Luciano Pacheco (lucmultohnoyoudont@chromium.org)
2. Alexandre Courbot (acourbotohnoyoudont@chromium.org)
3. Jochen Eisinger (jochenohnoyoudont@chromium.org)
4. Yuta Kitamura (yutakohnoyoudont@chromium.org)
5. Eliot Courtney (edcourtneyohnoyoudont@google.com)
6. Gauthier Ambard (gambardohnoyoudont@chromium.org)
7. Alexander Alekseev (alemateohnoyoudont@chromium.org)
8. Amos Lim (eui-sang.limohnoyoudont@samsung.com)
9. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
10. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
11. momohatt (momohatt10ohnoyoudont@gmail.com)
12. Noel Gordon (noelohnoyoudont@chromium.org)
13. John Z Wu (jzwohnoyoudont@chromium.org)
14. Henrik Grunell (grunellohnoyoudont@chromium.org)
15. Jochen Eisinger (jochenohnoyoudont@chromium.org)
16. yiyix (yiyixohnoyoudont@chromium.org)
17. Maksim Sisov (msisovohnoyoudont@igalia.com)
18. Christopher Cameron (ccameronohnoyoudont@chromium.org)
19. Trent Apted (taptedohnoyoudont@chromium.org)
20. Sam McNally (sammcohnoyoudont@chromium.org)
21. Alexandre Courbot (acourbotohnoyoudont@chromium.org)
22. Trent Apted (taptedohnoyoudont@chromium.org)
23. Yuki Yamada (yukiyohnoyoudont@google.com)
24. rajendrant (rajendrantohnoyoudont@chromium.org)
25. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
26. Patti (patricialorohnoyoudont@chromium.org)
27. Yuki Yamada (yukiyohnoyoudont@google.com)
28. Jinsuk Kim (jinsukkimohnoyoudont@chromium.org)
29. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
30. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
31. Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
32. Mohamed Amir Yosef (mamirohnoyoudont@chromium.org)
33. Yuki Yamada (yukiyohnoyoudont@google.com)
34. Kouhei Ueno (kouheiohnoyoudont@chromium.org)
35. Justin Cohen (justincohenohnoyoudont@google.com)
36. John Z Wu (jzwohnoyoudont@chromium.org)
37. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
38. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
39. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
40. Keiichi Watanabe (keiichiwohnoyoudont@chromium.org)

Timing:

Create	Friday, 12-Oct-18 09:17:11 UTC
Start	Friday, 12-Oct-18 09:17:36 UTC
End	Friday, 12-Oct-18 11:54:19 UTC
Pending	24 secs
Execution	2 hrs 36 mins

All Changes:

1. Fix naming issue when renaming files inside My files

   Changed by	Luciano Pacheco - lucmultohnoyoudont@chromium.org
   Changed at	Friday, 12-Oct-18 08:02:18 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	40a6cb9be79a8d05395498a705e59d50cbb77f57

   Comments

   Fix naming issue when renaming files inside My files
   
   Change DirectoryModel to "unwrap" VolumeEntry when it's selected via
   file list. This fixes the issue where after selecting a VolumeEntry any
   operation in the private API would fail because it wouldn't be able to
   send a VolumeEntry to private API, because it requires a real Entry.
   
   This fixes the user issue of trying to rename and always getting "Use
   shorter name" error, even with a short name.
   
   Update FakeEntry to be an implementation of FilesAppDirEntry, since all
   users were using as directory, also update some functions to typing to
   use FilesAppDirEntry instead of FakeEntry which is more correct.
   
   Test: browser_tests --gtest_filter="*/myFilesFolderRename"
   Bug: 889636
   Change-Id: Ieb75ffbb811a91e4742fb7a49a3badfd129376ad
   Reviewed-on: https://chromium-review.googlesource.com/c/1276067
   Reviewed-by: Joel Hockey <joelhockey@chromium.org>
   Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#599136}

   Changed files

   • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
   • ui/file_manager/file_manager/background/js/volume_info_impl.js
   • ui/file_manager/file_manager/common/js/files_app_entry_types.js
   • ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.js
   • ui/file_manager/file_manager/foreground/js/directory_model.js
   • ui/file_manager/file_manager/foreground/js/file_manager.js
   • ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
   • ui/file_manager/file_manager/foreground/js/file_watcher.js
   • ui/file_manager/integration_tests/file_manager/my_files.js

2. media/gpu/v4l2: workaround VIDIOC_G_FMT bug in libtegrav4l2.so.

   Changed by	Alexandre Courbot - acourbotohnoyoudont@chromium.org
   Changed at	Friday, 12-Oct-18 07:54:06 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	029544dab67d79059b7610a92890091520ef7603

   Comments

   media/gpu/v4l2: workaround VIDIOC_G_FMT bug in libtegrav4l2.so.
   
   libtegrav4l2.so's implementation of V4L2_G_FMT has a bug which will make
   it return 0 planes for single-plane multiplanar formats. We obviously
   cannot have a multiplanar format with 0 planes, so add a workaround at
   the fake-ioctl level. Implement it as a case-switch for future-proofing
   against other workarounds we will likely have to add.
   
   Also add a few recommendations in v4l2_device.cc against the temptation
   to spare some memory by using an appropriately-sized array of
   v4l2_planes: it turns out libv4l2 also likes to write above the number
   of passed planes, and using anything shorter than VIDEO_MAX_PLANES will
   result in memory corruption DCHECKS being raised.
   
   BUG=893661
   TEST=Checked that VDA unittest was passing on both hana and nyan_big.
   
   Change-Id: I7ea638f19f5bf0bdfaa0a47885577eb9dec4c225
   Reviewed-on: https://chromium-review.googlesource.com/c/1275727
   Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
   Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
   Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#599135}

   Changed files

   • media/gpu/v4l2/tegra_v4l2_device.cc
   • media/gpu/v4l2/v4l2_device.cc

3. Add browser tests for when we show the cookie exception

   Changed by	Jochen Eisinger - jochenohnoyoudont@chromium.org
   Changed at	Friday, 12-Oct-18 07:53:09 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	df554d02051d43d493d30cdf39fb1ee7566355bf

   Comments

   Add browser tests for when we show the cookie exception
   
   Depending on the sync / sign-in state.
   
   BUG=890925
   R=tangltom@chromium.org, msarda@chromium.org
   
   Change-Id: I784f13a4981250f851df770d111a13969a6892a6
   Reviewed-on: https://chromium-review.googlesource.com/c/1273521
   Commit-Queue: Jochen Eisinger <jochen@chromium.org>
   Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#599134}

   Changed files

   • chrome/browser/browsing_data/counters/browsing_data_counter_utils_browsertest.cc
   • chrome/test/BUILD.gn

4. Move thread-related functionalities in Platform to Thread.

   Changed by	Yuta Kitamura - yutakohnoyoudont@chromium.org
   Changed at	Friday, 12-Oct-18 07:47:14 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	9deeac4682dc2c2a45fdf483c376c75011a09241

   Comments

   Move thread-related functionalities in Platform to Thread.
   
   This CL moves the most of implementation for Thread in Platform to
   Thread, so the Platform would contain less implementation (ideally,
   Platform should be a pure interface to embedders).
   
   Previously the global state of threads was stored in Platform, and
   this CL moves it to Thread. Now the thread-local storage for Blink
   threads and the main and compositor thread objects are stored as
   the global variable in thread.cc. This way, the threads state is
   completely separated from Platform. Old threading functions in
   Platform are deprecated now, and they will be migrated to Thread ones
   later.
   
   Due to those changes, some test utilities need to be updated. As the
   state of threads is not stored in Platform, the tests that need to
   override their main thread have to do that by themselves. To
   facilitate this, two new utility classes, ScopedMainThreadOverrider
   and ScopedSchedulerOverrider, are introduced, and TestingPlatform-
   SupportWithCustomScheduler is removed in favor of the new utilities.
   
   Bug: 826203
   Change-Id: Ieb702dc85b7ffd75991055038f1165c2bfd7d058
   Reviewed-on: https://chromium-review.googlesource.com/c/1273115
   Commit-Queue: Yuta Kitamura <yutak@chromium.org>
   Reviewed-by: Kentaro Hara <haraken@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#599133}

   Changed files

   • content/renderer/render_thread_impl.cc
   • third_party/blink/public/platform/platform.h
   • third_party/blink/renderer/core/dom/idle_deadline_test.cc
   • third_party/blink/renderer/core/dom/scripted_idle_task_controller_test.cc
   • third_party/blink/renderer/platform/BUILD.gn
   • third_party/blink/renderer/platform/exported/platform.cc
   • third_party/blink/renderer/platform/scheduler/common/thread.cc
   • third_party/blink/renderer/platform/scheduler/public/thread.h
   • third_party/blink/renderer/platform/testing/scoped_main_thread_overrider.cc
   • third_party/blink/renderer/platform/testing/scoped_main_thread_overrider.h
   • third_party/blink/renderer/platform/testing/scoped_scheduler_overrider.cc
   • third_party/blink/renderer/platform/testing/scoped_scheduler_overrider.h
   • third_party/blink/renderer/platform/testing/testing_platform_support.cc
   • third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.cc
   • third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.h
   • third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.cc
   • third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.h

5. Let ClientControlledState apply animation during bounds change.

   Changed by	Eliot Courtney - edcourtneyohnoyoudont@google.com
   Changed at	Friday, 12-Oct-18 07:45:24 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	68084907a40caccccb72dd14c0ad3139b97747f7

   Comments

   Let ClientControlledState apply animation during bounds change.
   
   This CL introduces a new BoundsChangeAnimationType for
   ClientControlledState which will animate the window bounds for a
   specified duration.
   
   Bug: b/115291749
   Bug: 841886
   Test: Tested with local PIP prototype - applies animation.
   Change-Id: I8eda8b2131b8d3f679ade5cfbe64d7378efd6881
   Reviewed-on: https://chromium-review.googlesource.com/c/1218385
   Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
   Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#599132}

   Changed files

   • ash/wm/client_controlled_state.cc
   • ash/wm/client_controlled_state.h
   • ash/wm/client_controlled_state_unittest.cc
   • ash/wm/default_state.cc
   • ash/wm/window_state.cc
   • ash/wm/window_state.h
   • ash/wm/wm_event.cc
   • ash/wm/wm_event.h
   • components/exo/client_controlled_shell_surface.cc
   • components/exo/client_controlled_shell_surface_unittest.cc

6. [iOS] Remove ReadingList empty view

   Changed by	Gauthier Ambard - gambardohnoyoudont@chromium.org
   Changed at	Friday, 12-Oct-18 07:44:34 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	a53cbb1cdf96e0695e4d24cd408b52cc826d5088

   Comments

   [iOS] Remove ReadingList empty view
   
   This view was used in the old ReadingList implementation.
   
   Bug: none
   Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
   Change-Id: Id4fa1df5a00f0dd572a2d4951764f422231e3874
   Reviewed-on: https://chromium-review.googlesource.com/c/1276966
   Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
   Commit-Queue: Gauthier Ambard <gambard@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#599131}

   Changed files

   • ios/chrome/browser/ui/reading_list/BUILD.gn
   • ios/chrome/browser/ui/reading_list/empty_reading_list_background_view.h
   • ios/chrome/browser/ui/reading_list/empty_reading_list_background_view.mm
   • ios/chrome/browser/ui/reading_list/reading_list_egtest.mm

7. Chrome OS: Integrate PIN setup into Discover UI

   Changed by	Alexander Alekseev - alemateohnoyoudont@chromium.org
   Changed at	Friday, 12-Oct-18 07:43:54 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	f479db8f992be027ddc9b715919df65ad4e40bb6

   Comments

   Chrome OS: Integrate PIN setup into Discover UI
   
   Bug: 852553
   Change-Id: I460a420b1dd0024eaebb114aac2368a7bb3f28ae
   Reviewed-on: https://chromium-review.googlesource.com/c/1249496
   Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
   Reviewed-by: Jacob Dufault <jdufault@chromium.org>
   Commit-Queue: Alexander Alekseev <alemate@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#599130}

   Changed files

   • chrome/app/chromeos_strings.grdp
   • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP.png.sha1
   • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_DONE.png.sha1
   • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_PASSWORD_SUBTITLE.png.sha1
   • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_PASSWORD_TITLE.png.sha1
   • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_SUBTITLE3.png.sha1
   • chrome/browser/chromeos/login/session/user_session_manager.cc
   • chrome/browser/resources/chromeos/login/discover/discover_app.html
   • chrome/browser/resources/chromeos/login/discover/discover_app.js
   • chrome/browser/resources/chromeos/login/discover/discover_components.html
   • chrome/browser/resources/chromeos/login/discover/discover_components.js
   • chrome/browser/resources/chromeos/login/discover/discover_module_behavior.js
   • chrome/browser/resources/chromeos/login/discover/discover_ui.html
   • chrome/browser/resources/chromeos/login/discover/discover_ui.js
   • chrome/browser/resources/chromeos/login/discover/discover_welcome.css
   • chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.css
   • chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.html
   • chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.js
   • chrome/browser/resources/chromeos/login/discover/modules/images/pin_illustration_1x.svg
   • chrome/browser/resources/chromeos/login/discover/modules/images/pin_illustration_2x.svg
   • chrome/browser/resources/chromeos/login/screen_discover.html
   • chrome/browser/ui/BUILD.gn
   • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
   • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.h
   • chrome/browser/ui/webui/chromeos/login/discover/discover_module.h
   • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_launch_help_app.cc
   • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_launch_help_app.h
   • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_pin_setup.cc
   • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_pin_setup.h
   • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_redeem_offers.cc
   • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_redeem_offers.h
   • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_sync_files.cc
   • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_sync_files.h
   • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_welcome.cc
   • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_welcome.h
   • chrome/common/extensions/api/_api_features.json

8. Change cpp.tmpl files to cc.tmpl

   Changed by	Amos Lim - eui-sang.limohnoyoudont@samsung.com
   Changed at	Friday, 12-Oct-18 07:35:05 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	07c46624768cb8f779f4c872aa5951d3cb7d7920

   Comments

   Change cpp.tmpl files to cc.tmpl
   
   Formats of C++ template files are mixed up with cpp.tmpl and cc.tmpl.
   Unify C++ template files to cc.tmpl
   
   Bug: 894684
   Change-Id: I4f7413f29809bcd3262a20c7f40a23e63ba45d3a
   Reviewed-on: https://chromium-review.googlesource.com/c/1278567
   Reviewed-by: Kent Tamura <tkent@chromium.org>
   Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
   Cr-Commit-Position: refs/heads/master@{#599129}

   Changed files

   • third_party/blink/renderer/bindings/scripts/code_generator_v8.py
   • third_party/blink/renderer/bindings/scripts/generate_v8_context_snapshot_external_references.py
   • third_party/blink/renderer/bindings/templates/attributes.cc.tmpl
   • third_party/blink/renderer/bindings/templates/callback_function.cc.tmpl
   • third_party/blink/renderer/bindings/templates/callback_interface.cc.tmpl
   • third_party/blink/renderer/bindings/templates/callback_invoke.cc.tmpl
   • third_party/blink/renderer/bindings/templates/constants.cc.tmpl
   • third_party/blink/renderer/bindings/templates/dictionary_impl.cc.tmpl
   • third_party/blink/renderer/bindings/templates/dictionary_impl.h.tmpl
   • third_party/blink/renderer/bindings/templates/dictionary_impl_common.cc.tmpl
   • third_party/blink/renderer/bindings/templates/dictionary_v8.cc.tmpl
   • third_party/blink/renderer/bindings/templates/external_reference_table.cc.tmpl
   • third_party/blink/renderer/bindings/templates/interface.cc.tmpl
   • third_party/blink/renderer/bindings/templates/interface_base.cc.tmpl
   • third_party/blink/renderer/bindings/templates/methods.cc.tmpl
   • third_party/blink/renderer/bindings/templates/partial_interface.cc.tmpl
   • third_party/blink/renderer/bindings/templates/templates.gni
   • third_party/blink/renderer/bindings/templates/union_container.cc.tmpl
   • third_party/blink/renderer/bindings/templates/utilities.cc.tmpl
   • third_party/blink/renderer/bindings/tests/results/core/array_buffer_or_array_buffer_view_or_dictionary.cc
   • third_party/blink/renderer/bindings/tests/results/core/boolean_or_element_sequence.cc
   • third_party/blink/renderer/bindings/tests/results/core/boolean_or_string_or_unrestricted_double.cc
   • third_party/blink/renderer/bindings/tests/results/core/boolean_or_test_callback_interface.cc
   • third_party/blink/renderer/bindings/tests/results/core/byte_string_or_node_list.cc
   • third_party/blink/renderer/bindings/tests/results/core/byte_string_sequence_sequence_or_byte_string_byte_string_record.cc
   • third_party/blink/renderer/bindings/tests/results/core/double_or_double_or_null_sequence.cc
   • third_party/blink/renderer/bindings/tests/results/core/double_or_double_sequence.cc
   • third_party/blink/renderer/bindings/tests/results/core/double_or_long_or_boolean_sequence.cc
   • third_party/blink/renderer/bindings/tests/results/core/double_or_string.cc
   • third_party/blink/renderer/bindings/tests/results/core/double_or_string_or_double_or_string_sequence.cc
   • third_party/blink/renderer/bindings/tests/results/core/element_sequence_or_byte_string_double_or_string_record.cc
   • third_party/blink/renderer/bindings/tests/results/core/float_or_boolean.cc
   • third_party/blink/renderer/bindings/tests/results/core/long_or_boolean.cc
   • third_party/blink/renderer/bindings/tests/results/core/long_or_test_dictionary.cc
   • third_party/blink/renderer/bindings/tests/results/core/long_sequence_or_event.cc
   • third_party/blink/renderer/bindings/tests/results/core/nested_union_type.cc
   • third_party/blink/renderer/bindings/tests/results/core/node_or_node_list.cc
   • third_party/blink/renderer/bindings/tests/results/core/string_or_array_buffer_or_array_buffer_view.cc
   • third_party/blink/renderer/bindings/tests/results/core/string_or_double.cc
   • third_party/blink/renderer/bindings/tests/results/core/string_or_string_sequence.cc
   • third_party/blink/renderer/bindings/tests/results/core/test_dictionary.cc
   • third_party/blink/renderer/bindings/tests/results/core/test_dictionary_derived.cc
   • third_party/blink/renderer/bindings/tests/results/core/test_enum_or_double.cc
   • third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_or_null_sequence.cc
   • third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_sequence.cc
   • third_party/blink/renderer/bindings/tests/results/core/test_interface_2_or_uint8_array.cc
   • third_party/blink/renderer/bindings/tests/results/core/test_interface_event_init.cc
   • third_party/blink/renderer/bindings/tests/results/core/test_interface_or_long.cc
   • third_party/blink/renderer/bindings/tests/results/core/test_interface_or_test_interface_empty.cc
   • third_party/blink/renderer/bindings/tests/results/core/test_permissive_dictionary.cc
   • third_party/blink/renderer/bindings/tests/results/core/unrestricted_double_or_string.cc
   • third_party/blink/renderer/bindings/tests/results/core/unsigned_long_long_or_boolean_or_test_callback_interface.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_optional_any_arg.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_variadic_any_args.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_array_buffer.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_array_buffer_view.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_data_view.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_long_callback_function.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_string_sequence_callback_function_long_sequence_arg.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_svg_test_interface.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_attributes.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_functions.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_interface.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_constants.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary_derived.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_global.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_primary_global.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_2.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_3.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_check_security.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_conditional_secure_context.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_2.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_3.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_4.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_custom_constructor.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_document.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_empty.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init_constructor.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_target.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor_2.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_node.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_origin_trial_enabled.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_secure_context.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_legacy_callback_interface.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_node.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_object.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_permissive_dictionary.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_special_operations.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_special_operations_not_enumerable.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_typedefs.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_test_variadic_constructor_arguments.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_treat_non_object_as_null_boolean_function.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_treat_non_object_as_null_void_function.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_uint8_clamped_array.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_dictionary_arg.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_enum_arg.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_interface_arg.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_test_interface_sequence_arg.cc
   • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_typedef.cc
   • third_party/blink/renderer/bindings/tests/results/core/xml_http_request_or_string.cc
   • third_party/blink/renderer/bindings/tests/results/modules/boolean_or_string.cc
   • third_party/blink/renderer/bindings/tests/results/modules/v8_test_inherited_legacy_unenumerable_named_properties.cc
   • third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_2_partial.cc
   • third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_5.cc
   • third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_partial.cc
   • third_party/blink/renderer/bindings/tests/results/modules/v8_test_not_enumerable_named_getter.cc
   • third_party/blink/renderer/bindings/tests/results/modules/v8_test_sub_object.cc
   • third_party/blink/renderer/bindings/tests/results/modules/v8_void_callback_function_modules.cc
   • third_party/blink/renderer/core/css/css_primitive_value.h

9. CrOS FilesApp: Add Manage Linux sharing top menu link to settings page

   Changed by	Joel Hockey - joelhockeyohnoyoudont@chromium.org
   Changed at	Friday, 12-Oct-18 07:33:06 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	836e5cd90af24fa6af71e4e633d1c0fb41ca0765

   Comments

   CrOS FilesApp: Add Manage Linux sharing top menu link to settings page
   
   Shown when crostini and flag crostini-files are enabled.
   Links to chrome://settings/crostini/crostiniShared.
   Record UMA for clicks.
   
   Bug: 878324
   Change-Id: Ie09cd5c07edbe6dc0d0bcc22fee78b14981b2020
   Reviewed-on: https://chromium-review.googlesource.com/c/1277130
   Commit-Queue: Joel Hockey <joelhockey@chromium.org>
   Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#599128}

   Changed files

   • chrome/app/file_manager_strings.grdp
   • chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_MANAGE_LINUX_SHARING_BUTTON_LABEL.png.sha1
   • chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
   • tools/metrics/histograms/enums.xml
   • ui/file_manager/file_manager/foreground/js/file_manager.js
   • ui/file_manager/file_manager/foreground/js/file_manager_commands.js
   • ui/file_manager/file_manager/main.html
   • ui/file_manager/file_manager/test/crostini_share.js

10. Roll src-internal aebffd21b13f..7781cb9daa22 (1 commits)

    Changed by	chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at	Friday, 12-Oct-18 07:17:46 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	d6d014a7e5ef0d330fef991ab82343f02e71b6f8

    Comments

    Roll src-internal aebffd21b13f..7781cb9daa22 (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aebffd21b13f..7781cb9daa22
    
    
    Created with:
      gclient setdep -r src-internal@7781cb9daa22
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ib8911116b9b81a6503414f98f9988cd10a39144e
    Reviewed-on: https://chromium-review.googlesource.com/c/1278303
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599127}

    Changed files

    • DEPS

11. [ServiceWorker] Add WPT tests to check request header for update

    Changed by	momohatt - momohatt10ohnoyoudont@gmail.com
    Changed at	Friday, 12-Oct-18 07:05:38 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	4512662655ea5694ebba6c13055e99c9a0b2d096

    Comments

    [ServiceWorker] Add WPT tests to check request header for update
    
    Spec requires that during the update of service workers, request headers
    for fetching main scripts should include "Service-Worker" field, while
    that for fetching importScripts() resources should not.
    This patch adds WPT tests to validate this behavior.
    
    Change-Id: I24949fd0b375f6b811a73ce24aae87a4ea7c234f
    Reviewed-on: https://chromium-review.googlesource.com/c/1267297
    Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
    Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599126}

    Changed files

    • AUTHORS
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/service-worker-header.py
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/service-worker-header.https.html

12. Add Quick View audio load test

    Changed by	Noel Gordon - noelohnoyoudont@chromium.org
    Changed at	Friday, 12-Oct-18 07:04:47 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	ae2fcf0ef323eb487edced1ab876a090b3f9ce1e

    Comments

    Add Quick View audio load test
    
    Now we have the QuickView <webview> infra to detect the 'loaded' state
    of the <webview> content, add a <file-safe-media> audio test, and also
    check the <webview> renders its content on a transparent black body.
    
    This test exposed an issue in Blink node code. When the modal <dialog>
    is calling showModal(), its flat tree distribution can be out-of-date,
    causing a DCHECK crash when testing if the Quick View <dialog> element
    contains sibling <iframe id="command-dispatcher"> [1].
    
    Fix that: FlatTreeTraversal::ContainsIncludingPseudoElement() requires
    that its node arguments have up-to-date flat tree distribution. Ensure
    the <dialog>'s flat tree distribution is up-of-date _before_ trying to
    propagate the "inert" bit into sub-frames.
    
    Add crash test: html/dialog/showmodal-shadow-sibling-frame-crash.html
    
    [1] Known crash reports already exist: issue 789094 issue 804047.
    
    test: browser_tests --gtest_filter="QuickView*openQuickViewAudio"
    Bug: 891150, 789094, 804047
    Change-Id: I714585272fc775c157f6d0bd97143af27bf2b961
    Reviewed-on: https://chromium-review.googlesource.com/c/1264138
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599125}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • third_party/WebKit/LayoutTests/html/dialog/showmodal-shadow-sibling-frame-crash-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/showmodal-shadow-sibling-frame-crash.html
    • third_party/blink/renderer/core/html/html_dialog_element.cc
    • ui/file_manager/integration_tests/file_manager/quick_view.js

13. Clarify |stopSyncAndClearIdentity| with additional comment.

    Changed by	John Z Wu - jzwohnoyoudont@chromium.org
    Changed at	Friday, 12-Oct-18 07:03:47 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	3255a4ba5a80b407cc61864a85c469842894f469

    Comments

    Clarify |stopSyncAndClearIdentity| with additional comment.
    
    Namely, it is OK to call it multiple times.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I7348628de6e39ca50461c25db7343cd46b5f069a
    Reviewed-on: https://chromium-review.googlesource.com/c/1278061
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599124}

    Changed files

    • ios/web_view/public/cwv_sync_controller.h

14. Revert "[Video Capture, Test] Make tests requiring real webcam fail if it's not found"

    Changed by	Henrik Grunell - grunellohnoyoudont@chromium.org
    Changed at	Friday, 12-Oct-18 06:57:19 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	7bb43df173039894cf46c8b3476913f0f20ae6d1

    Comments

    Revert "[Video Capture, Test] Make tests requiring real webcam fail if it's not found"
    
    This reverts commit dfeab488cdc95233b19b9edeedef3d0b7581b17e.
    
    Reason for revert: Tests fail on Chromium WebRTC bots. Example: https://ci.chromium.org/buildbot/chromium.webrtc/Mac%20Tester/84091
    
    Original change's description:
    > [Video Capture, Test] Make tests requiring real webcam fail if it's not found
    > 
    > Use prefix "UsingRealWebcam_" for names of tests that require real webcam and
    > add checking whether webcam is found or not.
    > Accordingly, exclude such test cases from test suites for devices that have no
    > camera.
    > 
    > Bug: 893494
    > Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebox (guado)
    >       and it failed.
    > Test: Ran capture_unittests excluding UsingRealWebcam_ tests on Chromebox (guado)
    >       and it passed.
    > Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebook (kevin)
    >       and it passed.
    > 
    > Change-Id: I5c91380b7674aeace6a7d1764f7fad31f02f8af7
    > Reviewed-on: https://chromium-review.googlesource.com/c/1276407
    > Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org>
    > Reviewed-by: Christian Fremerey <chfremer@chromium.org>
    > Reviewed-by: Ben Pastene <bpastene@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599097}
    
    TBR=bpastene@chromium.org,chfremer@chromium.org,keiichiw@chromium.org
    
    Change-Id: I282dc00ffad2ff6614e7dfab1a9404da85cf032a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 893494
    Reviewed-on: https://chromium-review.googlesource.com/c/1278272
    Reviewed-by: Henrik Grunell <grunell@chromium.org>
    Commit-Queue: Henrik Grunell <grunell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599123}

    Changed files

    • media/capture/video/video_capture_device_unittest.cc
    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.chromiumos.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.linux.json
    • testing/buildbot/chromium.mac.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.win.json
    • testing/buildbot/test_suites.pyl

15. Remove the round-robin list for third-party additions

    Changed by	Jochen Eisinger - jochenohnoyoudont@chromium.org
    Changed at	Friday, 12-Oct-18 06:51:55 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	13767a51fd778bba049621a733ac7fbe6221922b

    Comments

    Remove the round-robin list for third-party additions
    
    Instead, require an email to opensource-licensing@ again until we
    figured out the new process.
    
    R=jam@chromium.org
    
    Change-Id: I352bd17e42cc1500994ba39368d25a0d91271f9c
    Reviewed-on: https://chromium-review.googlesource.com/c/1275846
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Commit-Queue: Jochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599122}

    Changed files

    • docs/adding_to_third_party.md
    • third_party/OWNERS

16. GPU_Tests: Remove expectations after rebaseline

    Changed by	yiyix - yiyixohnoyoudont@chromium.org
    Changed at	Friday, 12-Oct-18 06:49:33 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	6c30443b0e8a01efd448efc72829fb96584f0db0

    Comments

    GPU_Tests: Remove expectations after rebaseline
    
    Bug: 879379
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I43e957955103e5b2d6e4ae80b296655f1b2aa5b1
    Reviewed-on: https://chromium-review.googlesource.com/c/1277953
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Commit-Queue: Yi Xu <yiyix@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599121}

    Changed files

    • content/test/gpu/gpu_tests/pixel_expectations.py

17. [ozone/wayland] Fix kiosk mode.

    Changed by	Maksim Sisov - msisovohnoyoudont@igalia.com
    Changed at	Friday, 12-Oct-18 06:36:54 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	f154daab631433d3d9706af7f3512aa6b196e52f

    Comments

    [ozone/wayland] Fix kiosk mode.
    
    This CL fixes a fullscreen state changes before the surface is
    activated.
    
    That is, Wayland may ignore fullscreen changes before the surface
    is activated. Thus, store a pending state, and once the surface
    is activated, trigger the change.
    
    Change-Id: I8c0b995eb9f282f6be16e82d094d9dd93821a60a
    Bug: 843018
    Reviewed-on: https://chromium-review.googlesource.com/c/1275885
    Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
    Commit-Queue: Maksim Sisov <msisov@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#599120}

    Changed files

    • ui/ozone/platform/wayland/wayland_window.cc
    • ui/ozone/platform/wayland/wayland_window.h
    • ui/ozone/platform/wayland/wayland_window_unittest.cc

18. RemoteMacViews: Make fullscreen mode not crash

    Changed by	Christopher Cameron - ccameronohnoyoudont@chromium.org
    Changed at	Friday, 12-Oct-18 06:34:55 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	800a927eb503828f5cf6f489739e1a6efc444429

    Comments

    RemoteMacViews: Make fullscreen mode not crash
    
    Fix a few places where we would dereference a BridgedNativeWidgetImpl
    which is null when out-of-process. This doesn't guarantee correct
    behavior, but avoids a crash.
    
    Make WebContentsNSViewBridge::Show resize the web contents view and
    also all of its children.
    
    Bug: 859152
    Change-Id: I948de1e4f79db4a51c5b86e7960356133eff4342
    Reviewed-on: https://chromium-review.googlesource.com/c/1278533
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: ccameron <ccameron@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599119}

    Changed files

    • chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_views.mm
    • content/browser/web_contents/web_contents_ns_view_bridge.mm

19. Migrate base::AtomicFlag to std::atomic

    Changed by	Trent Apted - taptedohnoyoudont@chromium.org
    Changed at	Friday, 12-Oct-18 06:34:45 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	d64bfc8e330fea105de74137e6e176763dc546a4

    Comments

    Migrate base::AtomicFlag to std::atomic
    
    atomicops.h uses `volatile` which inhibits some compiler optimisations
    without contributing to threading correctness.
    
    Define AtomicFlag::IsSet() in the header, rather than out-of-line.
    Without this, WeakPtr overheads in ObserverListPerfTest_*.CheckedObserver
    in base_perftests are up to 70% greater.
    
    Bug: 891536
    Change-Id: Ibc733042bf0027738b49c70ccbbcefc4cde3289d
    Reviewed-on: https://chromium-review.googlesource.com/c/1278425
    Commit-Queue: Trent Apted <tapted@chromium.org>
    Reviewed-by: Albert J. Wong <ajwong@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599118}

    Changed files

    • base/synchronization/atomic_flag.cc
    • base/synchronization/atomic_flag.h

20. Make DriveFS opt-out in FilesApp tests.

    Changed by	Sam McNally - sammcohnoyoudont@chromium.org
    Changed at	Friday, 12-Oct-18 06:33:41 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	e9c79d562d8d3b789cca95b6909aa600a1dd39d2

    Comments

    Make DriveFS opt-out in FilesApp tests.
    
    Bug: 891197
    Change-Id: Id3101a43cfe97e652d71f720b5f312b933af1113
    Reviewed-on: https://chromium-review.googlesource.com/c/1277133
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Commit-Queue: Sam McNally <sammc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599117}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

21. media/gpu/v4l2: use actual number of planes in ioctls

    Changed by	Alexandre Courbot - acourbotohnoyoudont@chromium.org
    Changed at	Friday, 12-Oct-18 06:30:03 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	cec52397f2ea0fb8ac322378d229f1a454edf972

    Comments

    media/gpu/v4l2: use actual number of planes in ioctls
    
    The Tegra V4L2 library has a bug in its handling of VIDIOC_QUERYBUF that
    makes it fail if the number of planes of the passed v4l2_buffer does not
    exactly match the number of planes of the currently set format. This CL
    implements a workaround by first running a VIDIOC_G_FMT ioctl in
    AllocateBuffers(), and then passing the returned number of planes to the
    buffer constructor so the correct value can be passed to
    VIDIOC_QUERYBUF.
    
    And since we have this value, we also use it in VIDIOC_DQBUF.
    
    BUG=893661
    TEST=Checked that VDA unittest was passing on hana (Tegra devices have
    another bug that is fixed in the next CL).
    
    Change-Id: I830334de1cf322302fd476ac5535313ebc65900d
    Reviewed-on: https://chromium-review.googlesource.com/c/1275726
    Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
    Reviewed-by: Pawel Osciak <posciak@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599116}

    Changed files

    • media/gpu/v4l2/v4l2_device.cc
    • media/gpu/v4l2/v4l2_device.h

22. Files App: Move reportPromise,waitUntil to //ui/file_manager/base/js/test_error_reporting.js

    Changed by	Trent Apted - taptedohnoyoudont@chromium.org
    Changed at	Friday, 12-Oct-18 06:29:22 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4

    Comments

    Files App: Move reportPromise,waitUntil to //ui/file_manager/base/js/test_error_reporting.js
    
    These functions are currently in file_manager/file_manager/common/js/unittest_util.js
    which has a lot of files-app specific stuff that media apps shouldn't
    depend on.
    
     - Move MockAPIEvent to the only unittest (in gallery) that uses it.
     - Delete the redundant copy of waitUntil in list_thumbnail_loader_unittest.js
     - Updates the remaining handcrafted foo_unittest.html files in the files app
       * combination sed-script and manual edit.
    
    Bug: 879035
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I7d54cec253384b46d1cdb7c51f8ff0eb9596ebf1
    Reviewed-on: https://chromium-review.googlesource.com/c/1275545
    Commit-Queue: Trent Apted <tapted@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599115}

    Changed files

    • ui/file_manager/base/js/BUILD.gn
    • ui/file_manager/base/js/test_error_reporting.js
    • ui/file_manager/file_manager/background/js/device_handler_unittest.html
    • ui/file_manager/file_manager/background/js/duplicate_finder_unittest.html
    • ui/file_manager/file_manager/background/js/file_operation_manager_unittest.html
    • ui/file_manager/file_manager/background/js/import_history_unittest.html
    • ui/file_manager/file_manager/background/js/media_import_handler_unittest.html
    • ui/file_manager/file_manager/background/js/media_scanner_unittest.html
    • ui/file_manager/file_manager/background/js/task_queue_unittest.html
    • ui/file_manager/file_manager/background/js/volume_manager_unittest.html
    • ui/file_manager/file_manager/common/js/BUILD.gn
    • ui/file_manager/file_manager/common/js/metrics_unittest.html
    • ui/file_manager/file_manager/common/js/unittest_util.js
    • ui/file_manager/file_manager/foreground/elements/files_tooltip_unittest.html
    • ui/file_manager/file_manager/foreground/js/BUILD.gn
    • ui/file_manager/file_manager/foreground/js/actions_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/file_tasks_unittest.html
    • ui/file_manager/file_manager/foreground/js/import_controller_unittest.html
    • ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.html
    • ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.js
    • ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_provider_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/metadata_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/multi_metadata_provider_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/thumbnail_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/providers_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/spinner_controller_unittest.html
    • ui/file_manager/file_manager/foreground/js/task_controller_unittest.html
    • ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.html
    • ui/file_manager/file_manager/foreground/js/ui/file_tap_handler_unittest.html
    • ui/file_manager/gallery/js/BUILD.gn
    • ui/file_manager/gallery/js/entry_list_watcher_unittest.js
    • ui/file_manager/gallery/js/image_editor/BUILD.gn
    • ui/file_manager/image_loader/BUILD.gn

23. Rename scopes and context in JSBasedEventListener::handleEvent()

    Changed by	Yuki Yamada - yukiyohnoyoudont@google.com
    Changed at	Friday, 12-Oct-18 06:29:00 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	7d87839234fceb435e01ca49cf72096ef6691599

    Comments

    Rename scopes and context in JSBasedEventListener::handleEvent()
    
    This CL renames some ambiguous name of scope and context in
    JSBasedEventListener::handleEvent().
    
    Split from another one:
    https://chromium-review.googlesource.com/c/chromium/src/+/1270300
    
    Bug: 872138
    Change-Id: I8e772ecdc283fd1585566cf56a52170b777f4608
    Reviewed-on: https://chromium-review.googlesource.com/c/1277135
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Commit-Queue: Yuki Yamada <yukiy@google.com>
    Cr-Commit-Position: refs/heads/master@{#599114}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/js_based_event_listener.cc

24. Remove service name and refactor data use update to metrics service

    Changed by	rajendrant - rajendrantohnoyoudont@chromium.org
    Changed at	Friday, 12-Oct-18 06:24:24 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	dce70a031f697342a52b900211aa0ba7eceab082

    Comments

    Remove service name and refactor data use update to metrics service
    
    This CL does a bunch of steps to make the servicification easy to do.
    1. Removes the usage of ServiceName in data_use_measurement
    2. Refactors the data use update to metrics service to not take service
    name and instead send if the data use is from metrics component.
    3. To remove the UpdateUsagePrefCallback from DataUseMeasurement(),
    ChromeDataUseMeasurement is introduced that does the posting to UI thread
    (from io_thread.cc). This helps in servicification since there won't be
    thread hop. This also helps when CDUA classes are removed, and
    ChromeDataUseMeasurement can be there without dependency.
    
    Bug: 808498
    Change-Id: I7a4421c9798447c1ca4d39698f69b227cc773d48
    Reviewed-on: https://chromium-review.googlesource.com/c/1272256
    Commit-Queue: rajendrant <rajendrant@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Reviewed-by: Roger Tawa <rogerta@chromium.org>
    Reviewed-by: Steven Holte <holte@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599113}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
    • chrome/browser/data_use_measurement/chrome_data_use_ascriber.h
    • chrome/browser/data_use_measurement/chrome_data_use_measurement.cc
    • chrome/browser/data_use_measurement/chrome_data_use_measurement.h
    • chrome/browser/io_thread.cc
    • chrome/browser/io_thread.h
    • chrome/browser/net/system_network_context_manager.cc
    • chrome/browser/net/system_network_context_manager.h
    • chrome/browser/profiles/profile_impl_io_data.cc
    • components/data_use_measurement/core/BUILD.gn
    • components/data_use_measurement/core/DEPS
    • components/data_use_measurement/core/data_use_ascriber.cc
    • components/data_use_measurement/core/data_use_ascriber.h
    • components/data_use_measurement/core/data_use_measurement.cc
    • components/data_use_measurement/core/data_use_measurement.h
    • components/data_use_measurement/core/data_use_measurement_unittest.cc
    • components/data_use_measurement/core/data_use_network_delegate.cc
    • components/data_use_measurement/core/data_use_network_delegate.h
    • components/data_use_measurement/core/data_use_network_delegate_unittest.cc
    • components/data_use_measurement/core/data_use_user_data.cc
    • components/data_use_measurement/core/data_use_user_data.h
    • components/domain_reliability/uploader.cc
    • components/domain_reliability/uploader.h
    • components/metrics/data_use_tracker.cc
    • components/metrics/data_use_tracker.h
    • components/metrics/data_use_tracker_unittest.cc
    • components/metrics/metrics_service.cc
    • components/metrics/metrics_service.h
    • components/metrics/reporting_service.cc
    • components/metrics/reporting_service.h
    • google_apis/gaia/gaia_auth_util.cc
    • google_apis/gaia/gaia_auth_util.h
    • google_apis/gaia/gaia_oauth_client.cc
    • google_apis/gaia/oauth2_api_call_flow.cc
    • tools/metrics/histograms/histograms.xml

25. Roll src/third_party/chromite 89e4bf93b1a1..e2727ef6f5dc (3 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Friday, 12-Oct-18 06:12:59 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	028fceebebe0743ddd7bb16dc8b753ae0f41a3f2

    Comments

    Roll src/third_party/chromite 89e4bf93b1a1..e2727ef6f5dc (3 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/89e4bf93b1a1..e2727ef6f5dc
    
    
    git log 89e4bf93b1a1..e2727ef6f5dc --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 dgarrett@google.com builder_status_lib: Fix logging lint error.
    2018-10-12 vapier@chromium.org paygen: paygen_payload_lib: convert to gs.LS
    2018-10-12 vapier@chromium.org paygen: urilib_unittest: convert mox to mock
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@e2727ef6f5dc
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I2f3527661843ab9aafccf5f4f58b19fdde879453
    Reviewed-on: https://chromium-review.googlesource.com/c/1278301
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599112}

    Changed files

    • DEPS

26. Revert "[Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering."

    Changed by	Patti - patricialorohnoyoudont@chromium.org
    Changed at	Friday, 12-Oct-18 06:10:28 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	8c2893ee9102687d16f2f65fa96651d8bd1fdab7

    Comments

    Revert "[Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering."
    
    This reverts commit 86da6573944f302cf9df04d59a7e35bba895d059.
    
    Reason for revert: This patch may be causing failures in browser_tests, on chromium.win/Win7 Tests (dbg)(1)
      https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29
    
    Findit found culprit 598844 with 75% confidence, so reverting this to try and fix.
    
    Original change's description:
    > [Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering.
    > 
    > * The service shouldn't unregister from the topics, when handler
    > the Handler is unregistering from topic (as stated in the documentation
    > for for UnregisterHandler).
    > * Sync shouldn't unregister on browser shutdown
    > 
    > Bug: 801985, 876274
    > Change-Id: I857da7b0fbfa0a0f2e1ad05708cc24cdc9386a76
    > Reviewed-on: https://chromium-review.googlesource.com/c/1196522
    > Commit-Queue: Tatiana Gornak <melandory@chromium.org>
    > Reviewed-by: Gabriel Charette <gab@chromium.org>
    > Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#598844}
    
    TBR=gab@chromium.org,pavely@chromium.org,melandory@chromium.org
    
    Change-Id: I70fa87c3476925814408665644acb23c3c1f1614
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 801985, 876274, 894715
    Reviewed-on: https://chromium-review.googlesource.com/c/1278273
    Reviewed-by: Patti <patricialor@chromium.org>
    Commit-Queue: Patti <patricialor@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599111}

    Changed files

    • chrome/browser/prefs/browser_prefs.cc
    • components/invalidation/impl/BUILD.gn
    • components/invalidation/impl/fcm_fake_invalidator.cc
    • components/invalidation/impl/fcm_invalidation_listener.cc
    • components/invalidation/impl/fcm_invalidation_listener.h
    • components/invalidation/impl/fcm_invalidation_service.cc
    • components/invalidation/impl/fcm_invalidation_service.h
    • components/invalidation/impl/fcm_invalidation_service_unittest.cc
    • components/invalidation/impl/invalidator_registrar.cc
    • components/invalidation/impl/invalidator_registrar.h
    • components/invalidation/impl/invalidator_registrar_with_memory.cc
    • components/invalidation/impl/invalidator_registrar_with_memory.h
    • components/sync/driver/glue/sync_backend_host_impl.cc

27. Create v8::HandleScope in JSBasedEventListener::GetSourceLocation()

    Changed by	Yuki Yamada - yukiyohnoyoudont@google.com
    Changed at	Friday, 12-Oct-18 06:08:15 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	f93617e5eb9f06935b07002223f33d164f517909

    Comments

    Create v8::HandleScope in JSBasedEventListener::GetSourceLocation()
    
    This is the bug fixing for previous CL:
    https://chromium-review.googlesource.com/c/chromium/src/+/1253317
    
    v8::HandleScope was not named.
    
    Bug: 894069
    Change-Id: Ib9111275bad434b1968a4bd674a0b8932b8c1533
    Reviewed-on: https://chromium-review.googlesource.com/c/1278548
    Commit-Queue: Yuki Yamada <yukiy@google.com>
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599110}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/js_based_event_listener.cc

28. Android: Ensure single TabWebContentsObserver per Tab

    Changed by	Jinsuk Kim - jinsukkimohnoyoudont@chromium.org
    Changed at	Friday, 12-Oct-18 06:07:05 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	e0a45684f1cc9e125daed78cb74c7939415ebadc

    Comments

    Android: Ensure single TabWebContentsObserver per Tab
    
    TabWebContentsObserver is TabWebContentsUserData which is created
    for the first active WebContents for a given Tab, and finally
    destroyed together with the Tab. There was a bug creating
    multiple instances of the observer for every new active WebContents.
    This left an instance for old WebContents undestroyed, and caused
    a reported bug for already nulled out WebContents references
    while handling an event that should not have been triggered.
    
    This CL makes sure there will be a single TabWebContentsObserver
    for Tab.
    
    Bug: 894353
    Change-Id: Ie2cbe5c79b4d1e9f68d1be045c4d7e88d91c5312
    Reviewed-on: https://chromium-review.googlesource.com/c/1278426
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599109}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

29. Roll src/third_party/webrtc 8f4bc41c4231..a54daf162fac (2 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Friday, 12-Oct-18 06:05:56 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	9d4f9a68490476ebc67a19242ed76606d57aa853

    Comments

    Roll src/third_party/webrtc 8f4bc41c4231..a54daf162fac (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/8f4bc41c4231..a54daf162fac
    
    
    git log 8f4bc41c4231..a54daf162fac --date=short --no-merges --format='%ad %ae %s'
    2018-10-11 benwright@webrtc.org Reland "Move CryptoOptions to api/crypto from rtc_base/sslstreamadapter.h"
    2018-10-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9d052f4b6f..37b6d53f02 (598839:598967)
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@a54daf162fac
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I3d22153c1dd390398aa7dda8a0f8a00d032fc627
    Reviewed-on: https://chromium-review.googlesource.com/c/1278298
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599108}

    Changed files

    • DEPS

30. Roll src-internal 09c355ef00f4..aebffd21b13f (1 commits)

    Changed by	chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at	Friday, 12-Oct-18 05:52:40 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	b8143822153ed2373d843fd588593070ed59894c

    Comments

    Roll src-internal 09c355ef00f4..aebffd21b13f (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09c355ef00f4..aebffd21b13f
    
    
    Created with:
      gclient setdep -r src-internal@aebffd21b13f
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I816f02425f0557bf4030f14078bb453721cca6fe
    Reviewed-on: https://chromium-review.googlesource.com/c/1278300
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599107}

    Changed files

    • DEPS

31. Signed Exchange: Populate completion time for inner response

    Changed by	Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org
    Changed at	Friday, 12-Oct-18 05:49:49 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	cb0dee4694e580a614f5d380e0c60526cdfd2b90

    Comments

    Signed Exchange: Populate completion time for inner response
    
    This fixes a bug where Resource Timing for prefetched Signed Exchange
    had negative duration value.
    
    Bug: 803774
    Change-Id: I77006c803c12a6f645f2d5145a4e37e9321757f8
    Reviewed-on: https://chromium-review.googlesource.com/c/1278546
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
    Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599106}

    Changed files

    • content/browser/web_package/signed_exchange_loader.cc
    • third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-prefetch-resource-timing.html

32. [Sync::USS] Handle corrupted bookmarks metadata

    Changed by	Mohamed Amir Yosef - mamirohnoyoudont@chromium.org
    Changed at	Friday, 12-Oct-18 05:42:17 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	fb7986d88b0b8f174020916003d6939d2d928b83

    Comments

    [Sync::USS] Handle corrupted bookmarks metadata
    
    At startup, the persisted sync metadata (if available) are loaded
    and tracked.
    
    This CL adds some integrity checks and makes sure that corrupted
    metadata are ignored, and that Sync starts clean in such case.
    
    
    Bug: 516866
    Change-Id: Idf42cce2306f18a94941d40caa1816f737732156
    Reviewed-on: https://chromium-review.googlesource.com/c/1274106
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599105}

    Changed files

    • components/sync_bookmarks/BUILD.gn
    • components/sync_bookmarks/DEPS
    • components/sync_bookmarks/bookmark_model_type_processor.cc
    • components/sync_bookmarks/bookmark_model_type_processor.h
    • components/sync_bookmarks/bookmark_model_type_processor_unittest.cc
    • components/sync_bookmarks/synced_bookmark_tracker.cc
    • components/sync_bookmarks/synced_bookmark_tracker.h
    • components/sync_bookmarks/synced_bookmark_tracker_unittest.cc

33. Add a comment for backup_incumbent_scope in JSEventHandler::SetCompiledHandler()

    Changed by	Yuki Yamada - yukiyohnoyoudont@google.com
    Changed at	Friday, 12-Oct-18 05:38:24 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	3e151e38b3dabf71057cd3f303490937fbc24bad

    Comments

    Add a comment for backup_incumbent_scope in JSEventHandler::SetCompiledHandler()
    
    This adds a comment for the previous change:
    https://chromium-review.googlesource.com/c/chromium/src/+/1276406
    
    Bug: 893951
    Change-Id: Ib7a14eedb9922a03c0f6121205c55a9924a5fd7c
    Reviewed-on: https://chromium-review.googlesource.com/c/1278070
    Commit-Queue: Yuki Yamada <yukiy@google.com>
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599104}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/js_event_handler.cc

34. Implement SignedExchange.Prefetch UMAs

    Changed by	Kouhei Ueno - kouheiohnoyoudont@chromium.org
    Changed at	Friday, 12-Oct-18 05:30:49 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	97df84454db873390762a20012a30407d6bd1ed5

    Comments

    Implement SignedExchange.Prefetch UMAs
    
    Bug: 890180
    Change-Id: I5de8d5b1bdb154455a59e5106ebcefd4973d5bcd
    Reviewed-on: https://chromium-review.googlesource.com/c/1275746
    Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599103}

    Changed files

    • content/browser/loader/prefetch_url_loader_service.cc
    • content/browser/web_package/signed_exchange_loader.cc
    • content/browser/web_package/signed_exchange_prefetch_metric_recorder.cc
    • content/browser/web_package/signed_exchange_prefetch_metric_recorder.h
    • content/browser/web_package/signed_exchange_prefetch_metric_recorder_unittest.cc
    • content/browser/web_package/signed_exchange_request_handler_browsertest.cc
    • content/test/BUILD.gn
    • tools/metrics/histograms/histograms.xml

35. [ios] Move FYI xcode-clang bot back to Xcode 10.

    Changed by	Justin Cohen - justincohenohnoyoudont@google.com
    Changed at	Friday, 12-Oct-18 05:20:06 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	1af4ddc196ec7424ff808b37f3ec67aa36577a0c

    Comments

    [ios] Move FYI xcode-clang bot back to Xcode 10.
    
    This bot was erronously moved from Xcode 10 beta 4 all the way to Xcode 10.1
    beta.  Now that Xcode 10 GM is in goma, roll to Xcode 10.
    
    Note: This rolls to 10a254a, which is slightly different than the package
    goma installed, but it has the same compiler (clang-1000.11.45.2) so it should
    work the same.  If not, we'll have to investigate why and upload a new package
    to CIPD.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I46e90d60eb562f69d1848df3ff48db3d82cf1cc1
    Reviewed-on: https://chromium-review.googlesource.com/c/1278331
    Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
    Commit-Queue: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599102}

    Changed files

    • ios/build/bots/chromium.fyi/ios12-sdk-xcode-clang.json

36. Some fixes for sync:

    Changed by	John Z Wu - jzwohnoyoudont@chromium.org
    Changed at	Friday, 12-Oct-18 05:16:43 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	877046da44d232fb9de9bcbaee249c83ff8b0d1e

    Comments

    Some fixes for sync:
    
    1. Disable feature SyncUserConsentSeparateType for now.
    2. Use ReloadCredentials since LoadCredentials DCHECKs and fix up the tests.
    
    Bug: 867548
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I3a9af1b353b3138b411ee9fdab6cc67c447ee109
    Reviewed-on: https://chromium-review.googlesource.com/c/1278471
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: John Wu <jzw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599101}

    Changed files

    • ios/web_view/BUILD.gn
    • ios/web_view/internal/sync/cwv_sync_controller.mm
    • ios/web_view/internal/sync/cwv_sync_controller_unittest.mm
    • ios/web_view/internal/web_view_web_main_parts.mm

37. Roll src/third_party/angle c4533eae082f..671809e62e80 (2 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Friday, 12-Oct-18 05:16:39 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	155a1c23d2f8953f50fcff84366cfaea19f0691e

    Comments

    Roll src/third_party/angle c4533eae082f..671809e62e80 (2 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/c4533eae082f..671809e62e80
    
    
    git log c4533eae082f..671809e62e80 --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 jiajia.qin@intel.com ES31: Add vector and matrix support in SSBO for D3D
    2018-10-12 jiajia.qin@intel.com ES31: Collect shader storage blocks info for d3d.
    
    
    Created with:
      gclient setdep -r src/third_party/angle@671809e62e80
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=fjhenigman@chromium.org
    
    Change-Id: Ie918b1391ee226eb39be833dc7768cec9bdbee65
    Reviewed-on: https://chromium-review.googlesource.com/c/1278299
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599100}

    Changed files

    • DEPS

38. Roll src/third_party/chromite 9a72c51a329f..89e4bf93b1a1 (1 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Friday, 12-Oct-18 05:06:14 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	86871d7222d501610f9de98a22fd8a41b495d0c3

    Comments

    Roll src/third_party/chromite 9a72c51a329f..89e4bf93b1a1 (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/9a72c51a329f..89e4bf93b1a1
    
    
    git log 9a72c51a329f..89e4bf93b1a1 --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 derat@chromium.org chromeos_config: Run Tast on {amd64-generic,betty}-paladin.
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@89e4bf93b1a1
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I29f302fb260fcd75ce3d9d3b538f0eed2c2a1f21
    Reviewed-on: https://chromium-review.googlesource.com/c/1278493
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599099}

    Changed files

    • DEPS

39. CrOS FilesApp: refactor only: split out crostini UI tests

    Changed by	Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at	Friday, 12-Oct-18 04:53:58 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	2500163be8a63b6dd75c9427640f8763d6d46b33

    Comments

    CrOS FilesApp: refactor only: split out crostini UI tests
    
    Split crostini UI tests from crostini.js into test files:
     * crostini_mount.js
     * crostini_share.js
     * crostini_tasks.js
    The existing tests are getting a bit too large and pushing
    the bot testing time limits.
    
    Bug: 878324
    Change-Id: I882a38e3f644916e3c904709f3bfc540034b1383
    Reviewed-on: https://chromium-review.googlesource.com/c/1278429
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599098}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_uitest.cc
    • ui/file_manager/file_manager/test/BUILD.gn
    • ui/file_manager/file_manager/test/crostini.js
    • ui/file_manager/file_manager/test/crostini_mount.js
    • ui/file_manager/file_manager/test/crostini_share.js
    • ui/file_manager/file_manager/test/crostini_tasks.js

40. [Video Capture, Test] Make tests requiring real webcam fail if it's not found

    Changed by	Keiichi Watanabe - keiichiwohnoyoudont@chromium.org
    Changed at	Friday, 12-Oct-18 04:50:26 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	dfeab488cdc95233b19b9edeedef3d0b7581b17e

    Comments

    [Video Capture, Test] Make tests requiring real webcam fail if it's not found
    
    Use prefix "UsingRealWebcam_" for names of tests that require real webcam and
    add checking whether webcam is found or not.
    Accordingly, exclude such test cases from test suites for devices that have no
    camera.
    
    Bug: 893494
    Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebox (guado)
          and it failed.
    Test: Ran capture_unittests excluding UsingRealWebcam_ tests on Chromebox (guado)
          and it passed.
    Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebook (kevin)
          and it passed.
    
    Change-Id: I5c91380b7674aeace6a7d1764f7fad31f02f8af7
    Reviewed-on: https://chromium-review.googlesource.com/c/1276407
    Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org>
    Reviewed-by: Christian Fremerey <chfremer@chromium.org>
    Reviewed-by: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599097}

    Changed files

    • media/capture/video/video_capture_device_unittest.cc
    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.chromiumos.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.linux.json
    • testing/buildbot/chromium.mac.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.win.json
    • testing/buildbot/test_suites.pyl