Builder Lollipop Phone Tester Build 4561
Results:
Failure chrome_public_test_apk on Android device Nexus 5 Failure network_service_chrome_public_test_apk on Android device Nexus 5 Failure chrome_public_test_vr_apk on Android device Nexus 5 Failure content_browsertests on Android device Nexus 5
Trigger Info:
Project | chromium |
Revision | 4fcb3e56c3585e1d48d54a30e03eddd743a13113 |
Got Revision | 4fcb3e56c3585e1d48d54a30e03eddd743a13113 |
Execution:
- Source: Task 426f55e833d45210
- Bot: swarm98-c4
- Recipe: chromium
Steps and Logfiles:
Show:-
- - no logs -
-
( 1 secs ) read test spec (chromium.android.json)path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
-
( 505 ms ) lookup builder GN argsffmpeg_branding = "Chrome"is_component_build = falseis_debug = trueproprietary_codecs = truestrip_absolute_paths_from_debug_symbols = truesymbol_level = 1target_os = "android"use_goma = truegoma_dir = "/b/swarming/w/ir/cache/goma/client"
-
- - no logs -
-
( 11 secs ) [trigger] network_service_chrome_public_test_apk on Android device Nexus 5Run on OS: 'Android'
-
( 5 secs ) [trigger] network_service_content_shell_test_apk on Android device Nexus 5Run on OS: 'Android'
-
( 6 secs ) [trigger] webview_instrumentation_test_apk on Android device Nexus 5Run on OS: 'Android'
-
- - no logs -
-
( 4 secs ) android_webview_unittests on Android device Nexus 5Run on OS: 'Android'Shard duration: 0:02:02.778375
-
( 2 secs ) ui_touch_selection_unittests on Android device Nexus 5Run on OS: 'Android'Shard duration: 26s
-
( 5 secs ) angle_unittests on Android device Nexus 5Run on OS: 'Android'Shard duration: 0:02:15.367803
-
( 2 secs ) libjingle_xmpp_unittests on Android device Nexus 5Run on OS: 'Android'Shard duration: 34s
-
( 2 secs ) cacheinvalidation_unittests on Android device Nexus 5Run on OS: 'Android'Shard duration: 32s
-
( 2 secs ) capture_unittests on Android device Nexus 5Run on OS: 'Android'Pending time: 23sShard duration: 56s
-
( 4 secs ) gpu_unittests on Android device Nexus 5Run on OS: 'Android'Shard duration: 0:02:10.446491
-
( 2 secs ) cast_unittests on Android device Nexus 5Run on OS: 'Android'Pending time: 26sShard duration: 43s
-
( 2 secs ) sandbox_linux_unittests on Android device Nexus 5Run on OS: 'Android'Shard duration: 24s
-
( 4 secs ) gfx_unittests on Android device Nexus 5Run on OS: 'Android'Shard duration: 0:01:43.134743
-
( 1 secs ) mojo_test_apk on Android device Nexus 5Run on OS: 'Android'Shard duration: 0:01:56.222239
-
( 2 secs ) ui_base_unittests on Android device Nexus 5Run on OS: 'Android'Shard duration: 0:01:29.676202
-
( 3 secs ) boringssl_crypto_tests on Android device Nexus 5Run on OS: 'Android'Shard duration: 0:02:10.873313
-
( 4 secs ) blink_platform_unittests on Android device Nexus 5Run on OS: 'Android'Pending time: 23sShard duration: 0:02:00.313187
-
( 2 secs ) blink_heap_unittests on Android device Nexus 5Run on OS: 'Android'Pending time: 19sShard duration: 0:02:05.219786
-
( 4 secs ) cc_unittests on Android device Nexus 5Run on OS: 'Android'Pending time: 33sShard duration: 0:03:09.784641
-
( 5 secs ) base_unittests on Android device Nexus 5Run on OS: 'Android'Pending time: 10sShard duration: 0:04:14.543063
-
( 3 secs ) chrome_public_test_apk on Android device Nexus 5Run on OS: 'Android'Max pending time: 0:05:37.444444 (shard #19)Max shard duration: 0:02:50.412179 (shard #6)Min shard duration: 0:01:55.737895 (shard #17)
- stdout
- swarming.summary
- Merge script log
- step_metadata
- result_details (logcats, flakiness links)
- shard #0 isolated out
- shard #0 (failed) (113.2 sec)
- shard #1 isolated out
- shard #1 (failed) (118.9 sec)
- shard #2 isolated out
- shard #2 (failed) (107.3 sec)
- shard #3 isolated out
- shard #3 (failed) (114.6 sec)
- shard #4 isolated out
- shard #4 (failed) (113.3 sec)
- shard #5 isolated out
- shard #5 (failed) (110.0 sec)
- shard #6 isolated out
- shard #6 (failed) (118.4 sec)
- shard #7 isolated out
- shard #7 (failed) (110.7 sec)
- shard #8 isolated out
- shard #8 (failed) (111.7 sec)
- shard #9 isolated out
- shard #9 (failed) (111.3 sec)
- shard #10 isolated out
- shard #10 (failed) (115.9 sec)
- shard #11 isolated out
- shard #11 (failed) (115.0 sec)
- shard #12 isolated out
- shard #12 (failed) (109.6 sec)
- shard #13 isolated out
- shard #13 (failed) (108.1 sec)
- shard #14 isolated out
- shard #14 (failed) (114.2 sec)
- shard #15 isolated out
- shard #15 (failed) (117.3 sec)
- shard #16 isolated out
- shard #16 (failed) (116.4 sec)
- shard #17 isolated out
- shard #17 (failed) (109.8 sec)
- shard #18 isolated out
- shard #18 (failed) (109.7 sec)
- shard #19 isolated out
- shard #19 (failed) (108.4 sec)
-
( 3 secs ) network_service_chrome_public_test_apk on Android device Nexus 5Run on OS: 'Android'Max pending time: 0:10:28.687236 (shard #19)Max shard duration: 0:02:06.382037 (shard #8)Min shard duration: 0:01:55.884430 (shard #1)
- stdout
- swarming.summary
- Merge script log
- step_metadata
- result_details (logcats, flakiness links)
- shard #0 isolated out
- shard #0 (failed) (107.6 sec)
- shard #1 isolated out
- shard #1 (failed) (107.3 sec)
- shard #2 isolated out
- shard #2 (failed) (108.9 sec)
- shard #3 isolated out
- shard #3 (failed) (109.8 sec)
- shard #4 isolated out
- shard #4 (failed) (109.8 sec)
- shard #5 isolated out
- shard #5 (failed) (109.2 sec)
- shard #6 isolated out
- shard #6 (failed) (110.3 sec)
- shard #7 isolated out
- shard #7 (failed) (107.4 sec)
- shard #8 isolated out
- shard #8 (failed) (117.2 sec)
- shard #9 isolated out
- shard #9 (failed) (117.0 sec)
- shard #10 isolated out
- shard #10 (failed) (108.4 sec)
- shard #11 isolated out
- shard #11 (failed) (102.8 sec)
- shard #12 isolated out
- shard #12 (failed) (109.8 sec)
- shard #13 isolated out
- shard #13 (failed) (110.9 sec)
- shard #14 isolated out
- shard #14 (failed) (110.8 sec)
- shard #15 isolated out
- shard #15 (failed) (107.9 sec)
- shard #16 isolated out
- shard #16 (failed) (108.7 sec)
- shard #17 isolated out
- shard #17 (failed) (108.5 sec)
- shard #18 isolated out
- shard #18 (failed) (108.2 sec)
- shard #19 isolated out
- shard #19 (failed) (112.6 sec)
-
( 2 secs ) chrome_public_test_vr_apk on Android device Nexus 5Run on OS: 'Android'Max pending time: 0:10:41.836378 (shard #1)Max shard duration: 0:02:07.795564 (shard #1)Min shard duration: 0:01:54.725888 (shard #0)
-
( 2 secs ) components_browsertests on Android device Nexus 5Run on OS: 'Android'Pending time: 0:10:57.052135Shard duration: 0:06:29.823412
-
( 19 secs ) components_unittests on Android device Nexus 5Run on OS: 'Android'Max pending time: 0:12:15.693255 (shard #3)Max shard duration: 0:07:01.903568 (shard #0)Min shard duration: 0:06:16.096593 (shard #3)
-
( 1 secs ) perfetto_content_browsertests on Android device Nexus 5Run on OS: 'Android'Pending time: 0:19:44.080240Shard duration: 0:02:43.767085
-
( 2 secs ) content_shell_test_apk on Android device Nexus 5Run on OS: 'Android'Max pending time: 0:19:55.816897 (shard #2)Max shard duration: 0:07:55.031281 (shard #2)Min shard duration: 0:07:14.935068 (shard #0)
-
( 2 secs ) device_unittests on Android device Nexus 5Run on OS: 'Android'Pending time: 0:31:20.547185Shard duration: 51s
-
( 2 secs ) network_service_content_shell_test_apk on Android device Nexus 5Run on OS: 'Android'Max pending time: 0:28:49.229965 (shard #4)Max shard duration: 0:06:07.844020 (shard #2)Min shard duration: 0:04:27.497696 (shard #3)
- stdout
- swarming.summary
- Merge script log
- step_metadata
- result_details (logcats, flakiness links)
- shard #0 isolated out
- shard #0 (274.8 sec)
- shard #1 isolated out
- shard #1 (233.9 sec)
- shard #2 isolated out
- shard #2 (358.2 sec)
- shard #3 isolated out
- shard #3 (248.9 sec)
- shard #4 isolated out
- shard #4 (310.6 sec)
-
( 10 secs ) content_browsertests on Android device Nexus 5Run on OS: 'Android'Max pending time: 0:18:30.274427 (shard #8)Max shard duration: 0:16:28.716954 (shard #1)Min shard duration: 0:13:48.347918 (shard #8)failures:WebRtcInternalsBrowserTest.ConvertedGraphsSitePerProcessBrowserTest.FrameDepthSimpleWakeLockTest.UnlockAfterTabCrashedSitePerProcessBrowserTest.TwoBlobURLsWithNullOriginDontShareProcessWebRtcDataBrowserTest.CallWithSctpDataAndMediaSitePerProcessHighDPIHitTestBrowserTest.NonFlatTransformedSurfaceHitTestTest/1SitePerProcessHitTestDataGenerationBrowserTest.RotatedClippedOOPIF/1WebRtcImageCaptureGetPhotoStateFailsBrowserTest.GrabFrame/0SitePerProcessBrowserTest.KeyboardScrollBubblingFromOOPIFSitePerProcessHitTestBrowserTest.AsynchronousHitTestChildTimeout/0WorkerTest.MultipleSharedWorkersWebRtcBrowserTest.CanSetupCallAndSendDtmfSignedExchangeAcceptHeaderBrowserTest/SignedExchangeAcceptHeaderBrowserTest.PrefetchEnabledPageRedirectFromDisabledToEnabledToDisabledTarget/0SitePerProcessHitTestBrowserTest.TouchActionAckTimeout/1SignedExchangeAcceptHeaderBrowserTest/SignedExchangeAcceptHeaderBrowserTest.PrefetchEnabledPageRedirectFromDisabledToEnabledToDisabledTarget/5SignedExchangeAcceptHeaderBrowserTest/SignedExchangeAcceptHeaderBrowserTest.PrefetchEnabledPageEnabledTarget/12SignedExchangeAcceptHeaderBrowserTest/SignedExchangeAcceptHeaderBrowserTest.ServiceWorker/11WebRtcMediaRecorderTest.RemovingTrackFromMediaStreamFiresErrorEventWebRtcMediaRecorderTest.PauseSitePerProcessBrowserTest.ScreenCoordinatesWebUINavigationBrowserTest.WebUISubframeNewWindowToWebAllowedWebUIMojoTest.EndToEndPingWebRtcBrowserTest.CanSetupVideoCallWith1To1AspectRatioTouchInputBrowserTest.MultiPointTouchPressSitePerProcessHitTestBrowserTest.CrossProcessTooltipTestAndroid/0SitePerProcessBrowserTest.CrossSiteIframeDisplayNoneWheelEventListenerBrowserTest.DocumentMouseWheelEventListenersPassiveByDefaultSitePerProcessHitTestBrowserTest.HitTestStaleDataDeletedView/2SignedExchangeRequestHandlerWithServiceWorkerBrowserTest/SignedExchangeRequestHandlerWithServiceWorkerBrowserTest.NotControlledBySameOriginDistributorsSW/0SitePerProcessBrowserTest.NavigatingSubframePreservesOpenerInParent... 266 more (296 total) ...
- stdout
- swarming.summary
- Merge script log
- WebRtcInternalsBrowserTest.ConvertedGraphs (status NOTRUN)
- SitePerProcessBrowserTest.FrameDepthSimple (status NOTRUN)
- WakeLockTest.UnlockAfterTabCrashed (status NOTRUN)
- SitePerProcessBrowserTest.TwoBlobURLsWithNullOriginDontShareProcess (status NOTRUN)
- WebRtcDataBrowserTest.CallWithSctpDataAndMedia (status NOTRUN)
- SitePerProcessHighDPIHitTestBrowserTest.NonFlatTransformedSurfaceHitTestTest/1 (status NOTRUN)
- SitePerProcessHitTestDataGenerationBrowserTest.RotatedClippedOOPIF/1 (status NOTRUN)
- WebRtcImageCaptureGetPhotoStateFailsBrowserTest.GrabFrame/0 (status NOTRUN)
- SitePerProcessBrowserTest.KeyboardScrollBubblingFromOOPIF (status NOTRUN)
- SitePerProcessHitTestBrowserTest.AsynchronousHitTestChildTimeout/0 (status NOTRUN)
- WorkerTest.MultipleSharedWorkers (status NOTRUN)
- WebRtcBrowserTest.CanSetupCallAndSendDtmf (status NOTRUN)
- SignedExchangeAcceptHeaderBrowserTest/SignedExchangeAcceptHeaderBrowserTest.PrefetchEnabledPageRedirectFromDisabledToEnabledToDisabledTarget/0 (status NOTRUN)
- SitePerProcessHitTestBrowserTest.TouchActionAckTimeout/1 (status NOTRUN)
- SignedExchangeAcceptHeaderBrowserTest/SignedExchangeAcceptHeaderBrowserTest.PrefetchEnabledPageRedirectFromDisabledToEnabledToDisabledTarget/5 (status NOTRUN)
- SignedExchangeAcceptHeaderBrowserTest/SignedExchangeAcceptHeaderBrowserTest.PrefetchEnabledPageEnabledTarget/12 (status NOTRUN)
- SignedExchangeAcceptHeaderBrowserTest/SignedExchangeAcceptHeaderBrowserTest.ServiceWorker/11 (status NOTRUN)
- WebRtcMediaRecorderTest.RemovingTrackFromMediaStreamFiresErrorEvent (status NOTRUN)
- WebRtcMediaRecorderTest.Pause (status NOTRUN)
- SitePerProcessBrowserTest.ScreenCoordinates (status NOTRUN)
- WebUINavigationBrowserTest.WebUISubframeNewWindowToWebAllowed (status NOTRUN)
- WebUIMojoTest.EndToEndPing (status NOTRUN)
- WebRtcBrowserTest.CanSetupVideoCallWith1To1AspectRatio (status NOTRUN)
- TouchInputBrowserTest.MultiPointTouchPress (status NOTRUN)
- SitePerProcessHitTestBrowserTest.CrossProcessTooltipTestAndroid/0 (status NOTRUN)
- SitePerProcessBrowserTest.CrossSiteIframeDisplayNone (status NOTRUN)
- WheelEventListenerBrowserTest.DocumentMouseWheelEventListenersPassiveByDefault (status NOTRUN)
- SitePerProcessHitTestBrowserTest.HitTestStaleDataDeletedView/2 (status NOTRUN)
- SignedExchangeRequestHandlerWithServiceWorkerBrowserTest/SignedExchangeRequestHandlerWithServiceWorkerBrowserTest.NotControlledBySameOriginDistributorsSW/0 (status NOTRUN)
- SitePerProcessBrowserTest.NavigatingSubframePreservesOpenerInParent (status NOTRUN)
- step_metadata
- result_details (logcats, flakiness links)
- shard #0 isolated out
- shard #0 timed out after 961.1 sec
- shard #1 isolated out
- shard #1 timed out after 961.1 sec
- shard #2 isolated out
- shard #2 (808.7 sec)
- shard #3 isolated out
- shard #3 (837.6 sec)
- shard #4 isolated out
- shard #4 timed out after 961.1 sec
- shard #5 isolated out
- shard #5 (907.5 sec)
- shard #6 isolated out
- shard #6 timed out after 961.1 sec
- shard #7 isolated out
- shard #7 timed out after 961.1 sec
- shard #8 isolated out
- shard #8 (812.0 sec)
-
( 2 secs ) events_unittests on Android device Nexus 5Run on OS: 'Android'Pending time: 0:33:17.637077Shard duration: 38s
-
( 2 secs ) media_service_unittests on Android device Nexus 5Run on OS: 'Android'Pending time: 0:33:35.047379Shard duration: 57s
-
( 6 secs ) content_unittests on Android device Nexus 5Run on OS: 'Android'Max pending time: 0:30:45.257517 (shard #2)Max shard duration: 0:05:04.400549 (shard #1)Min shard duration: 0:04:04.079859 (shard #2)
-
( 2 secs ) gl_tests on Android device Nexus 5Run on OS: 'Android'Pending time: 0:33:16.536492Shard duration: 45s
-
( 4 secs ) media_blink_unittests on Android device Nexus 5Run on OS: 'Android'Pending time: 0:33:36.003663Shard duration: 0:01:51.191886
-
( 2 secs ) shell_dialogs_unittests on Android device Nexus 5Run on OS: 'Android'Pending time: 0:34:52.687458Shard duration: 34s
-
( 3 secs ) services_unittests on Android device Nexus 5Run on OS: 'Android'Pending time: 0:34:37.563421Shard duration: 0:02:39.901560
-
( 2 secs ) ui_android_unittests on Android device Nexus 5Run on OS: 'Android'Pending time: 0:35:31.615776Shard duration: 33s
-
( 6 secs ) media_unittests on Android device Nexus 5Run on OS: 'Android'Pending time: 0:33:34.834752Shard duration: 0:03:53.833292
-
( 2 secs ) storage_unittests on Android device Nexus 5Run on OS: 'Android'Pending time: 0:35:10.169110Shard duration: 0:01:05.149475
-
( 2 secs ) skia_unittests on Android device Nexus 5Run on OS: 'Android'Pending time: 0:35:04.403911Shard duration: 34s
-
( 40 secs ) net_unittests on Android device Nexus 5Run on OS: 'Android'Max pending time: 0:33:33.032058 (shard #2)Max shard duration: 0:08:32.897861 (shard #1)Min shard duration: 0:07:48.324658 (shard #2)
-
( 2 secs ) vr_common_unittests on Android device Nexus 5Run on OS: 'Android'Pending time: 0:42:15.236979Shard duration: 0:01:48.248373
-
( 2 secs ) vr_pixeltests on Android device Nexus 5Run on OS: 'Android'Pending time: 0:42:20.279367Shard duration: 0:01:51.116001
-
( 2 secs ) vr_android_unittests on Android device Nexus 5Run on OS: 'Android'Pending time: 0:42:11.040057Shard duration: 0:01:31.240683
-
( 7 secs ) unit_tests on Android device Nexus 5Run on OS: 'Android'Max pending time: 0:38:26.428666 (shard #9)Max shard duration: 0:05:39.811180 (shard #3)Min shard duration: 0:04:30.244425 (shard #1)
- stdout
- swarming.summary
- Merge script log
- step_metadata
- result_details (logcats, flakiness links)
- shard #0 isolated out
- shard #0 (300.1 sec)
- shard #1 isolated out
- shard #1 (252.5 sec)
- shard #2 isolated out
- shard #2 (306.1 sec)
- shard #3 isolated out
- shard #3 (279.9 sec)
- shard #4 isolated out
- shard #4 (267.7 sec)
- shard #5 isolated out
- shard #5 (284.0 sec)
- shard #6 isolated out
- shard #6 (317.2 sec)
- shard #7 isolated out
- shard #7 (236.7 sec)
- shard #8 isolated out
- shard #8 (285.8 sec)
- shard #9 isolated out
- shard #9 (274.3 sec)
-
( 3 secs ) viz_unittests on Android device Nexus 5Run on OS: 'Android'Pending time: 0:41:47.936086Shard duration: 56s
-
( 2 secs ) mojo_unittests on Android device Nexus 5Run on OS: 'Android'Pending time: 0:33:33.511834Shard duration: 0:11:35.714348
-
( 3 secs ) webview_instrumentation_test_apk on Android device Nexus 5Run on OS: 'Android'Max pending time: 0:44:33.379732 (shard #6)Max shard duration: 0:10:45.622125 (shard #2)Min shard duration: 0:08:35.496961 (shard #6)
- stdout
- swarming.summary
- Merge script log
- step_metadata
- result_details (logcats, flakiness links)
- shard #0 isolated out
- shard #0 (500.4 sec)
- shard #1 isolated out
- shard #1 (516.8 sec)
- shard #2 isolated out
- shard #2 (616.8 sec)
- shard #3 isolated out
- shard #3 (507.9 sec)
- shard #4 isolated out
- shard #4 (605.6 sec)
- shard #5 isolated out
- shard #5 (586.7 sec)
- shard #6 isolated out
- shard #6 (500.6 sec)
-
( 10 secs ) webkit_unit_tests on Android device Nexus 5Run on OS: 'Android'Max pending time: 0:42:48.984418 (shard #1)Max shard duration: 0:10:35.166684 (shard #0)Min shard duration: 0:10:33.894201 (shard #1)
Build Properties:
Name | Value | Source |
---|---|---|
$build/goma | {"jobs": 150} | setup_build |
$recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm98-c4" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547639741922882, "id": "8924175825933094864", "project": "chromium", "tags": ["builder:Lollipop Phone Tester", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/4fcb3e56c3585e1d48d54a30e03eddd743a13113", "gitiles_ref:refs/heads/master", "parent_buildername:Android arm Builder (dbg)", "parent_buildnumber:39544", "scheduler_invocation_id:9089605887940491280", "scheduler_job_id:chromium/Lollipop Phone Tester", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "Lollipop Phone Tester" | setup_build |
buildnumber | 4561 | setup_build |
mastername | "chromium.android" | setup_build |
parent_buildername | "Android arm Builder (dbg)" | setup_build |
parent_got_angle_revision | "ab2bfa814ceefdcbe24483b3a12ba525345d486c" | setup_build |
parent_got_buildtools_revision | "40194ab03962d8183b2796fa58a39ec8a9e83a41" | setup_build |
parent_got_dawn_revision | "acd8b7d937cc4dcc81856377863f2d56af7037b5" | setup_build |
parent_got_nacl_revision | "1ea07c56ac9b57c30eb784ab2af582af0cdd4b08" | setup_build |
parent_got_revision | "4fcb3e56c3585e1d48d54a30e03eddd743a13113" | setup_build |
parent_got_revision_cp | "refs/heads/master@{#623189}" | setup_build |
parent_got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | setup_build |
parent_got_v8_revision | "871f913bad24b4ead79468f431a1ae8326d9d27b" | setup_build |
parent_got_v8_revision_cp | "refs/heads/7.3.412@{#1}" | setup_build |
parent_got_webrtc_revision | "ccc1b57e32bd99e4f220a3db0e540713f4349ad9" | setup_build |
parent_got_webrtc_revision_cp | "refs/heads/master@{#26266}" | setup_build |
parent_mastername | "chromium.android" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
revision | "4fcb3e56c3585e1d48d54a30e03eddd743a13113" | setup_build |
swarm_hashes | {"android_webview_unittests": "5c09f1c9ad3cccde6bda8aa10794485d64844677", "angle_unittests": "7a3245a8d729efc4016c51770584b6f1c0cfbc89", "base_unittests": "995b0be93676abe5d3e262d3271b9faf2e1b45c0", "blink_common_unittests": "2140fa7de87dd2f0da4eb70dd599c1455e505abb", "blink_heap_unittests": "2a22f5e286174e4b2c0946dd6a581a0c5057d0ad", "blink_platform_unittests": "10a7ac014b191f3e709390443023791a8180fdc9", "boringssl_crypto_tests": "ffee94ec0be7175ecc4aaf9c3aef7b21bb028cac", "boringssl_ssl_tests": "eff36713cd7579a57528451358a6623405f113ba", "breakpad_unittests": "4eee40c0e9e36aff513875223512d4bedfa5860e", "cacheinvalidation_unittests": "89bb9186ae93430c8ed935bdc136ad0a6eb5f2c5", "capture_unittests": "f19b1482bfb76dc98c6b75bfb623a359cd35a0ea", "cast_unittests": "88d7e31ba244a6b9a29f69e4c5073493b90df9a1", "cc_unittests": "49905f7233ff67146bf00a7f760f943e2f010e71", "chrome_public_test_apk": "8992b55e5264516a8324d5a6309fedc1d0b04ec8", "chrome_public_test_vr_apk": "a218cdd4d9b69045d3642ef4758fc2955223fc90", "components_browsertests": "d4664b2b2271b9bb942b21c09b5a585d2ce8f9d5", "components_unittests": "bb7d1070539f289cce03c7afe880890baddaaa82", "content_browsertests": "31176f0b90d1de0ca0de8ada2da9d82b4a241f2f", "content_shell_test_apk": "cb32e9071673e4bbc16482f5e2de442a078fd310", "content_unittests": "d36d33f3a0b9e3935afbfe591d18e384d1b9aee5", "crypto_unittests": "c0188364d63e45889bfc5cec454dcbc36fcbcf6a", "device_unittests": "60f12b282cf9531b04798ba2c6f6977556207bec", "display_unittests": "ef98b53d9fe6025a35f9b6cb915641c942b115be", "events_unittests": "0266e500574a7087bb95e5b30dd9732de29bf274", "gcm_unit_tests": "a32ff86262961ad7c9df93501c046869d79ae95b", "gfx_unittests": "fda46c24388d7bb6e1f9c51d75678355cac6769d", "gin_unittests": "be1960e5b4113f325a6228f473d4306bad94c7f6", "gl_tests": "ebe396ad9ea2afa4b3f3646b25587e8e8c700bb6", "gl_unittests": "84145dbe6936d8f4efa10422762d9700b8fc624d", "google_apis_unittests": "7a0faa6f3d1dee91421ef055518f9591ba3a30e6", "gpu_unittests": "b1953876cdbeed4cfb9672ede12ea77efe5716a9", "ipc_tests": "cf34eb41b989512e7607fe2092b0cc7b27640a77", "jingle_unittests": "0a0b3ec66d8e639ea7a85c03974234ba9f42f3a2", "latency_unittests": "94f18f6d2ef7a6afeb64b9d019675f9a5e1445ef", "libjingle_xmpp_unittests": "d79a8e2e57e2e28adc19d4f1321ff2095a313b64", "media_blink_unittests": "c317224313506a3e77e78fd09b566bde9731fa6d", "media_service_unittests": "efd5a280e137db9b292a87b671717b43a00d2b19", "media_unittests": "a14a392823845bd756f182a162abcb1e60b03956", "midi_unittests": "463d6d6851f0b3658c78aa8c0e82665e4f660ce5", "mojo_test_apk": "29fb842e69d7a542b22f10e2f9652cb874f8ded8", "mojo_unittests": "92d7e101c077202f2ddc5bee67b2d4e0641bba83", "net_unittests": "438c5663adeae4e3ef6ea8008bbeb5a4147a52ab", "sandbox_linux_unittests": "b3d53f2b7de6684b4c0c00951465c3dcd653b510", "services_unittests": "4f5e3026cff76abcd9d9b9ff3b6d390d48ba4f42", "shell_dialogs_unittests": "b1407844e77e37be724040b500db9ca1b673eefb", "skia_unittests": "1cf2eb264af4412270bdd2524ff2120a8aa0f365", "sql_unittests": "28e00510cb4abf52b6f3f9284d56b5739eb8c0a0", "storage_unittests": "795b42920a980000b3c18b006f4bb00149349e79", "ui_android_unittests": "400799a7c77d9c10a17d587d75c6221d1f15e010", "ui_base_unittests": "0ad0d71ec075ab718bf0cdc3d454b826e9e0221b", "ui_touch_selection_unittests": "f0710c640fc3452bc4196dd63126e1ea017bea2a", "unit_tests": "8da9f85938c5bb466b3dd8af4f565056527ad87a", "url_unittests": "e7f61b22164bd661f0153cb1367c47412bc2d718", "viz_unittests": "b2f8293466b61f1c272bb1bc4efc22502af0ef19", "vr_android_unittests": "9aba305c02fc97558156d70fd1d1114f438a29f0", "vr_common_unittests": "3897e9b4faded74cd4015868d619c110982fd220", "vr_pixeltests": "972031c7c4df65a98b37dfe7dcae3bf836ded98b", "webkit_layout_tests_exparchive": "f27d0ead3e5241d365a8c5955eb99c98f8c44ebc", "webkit_unit_tests": "a08e29262042ac5791393c663e57b3daf0aaf21d", "webview_cts_tests": "66e35839af875de62ae3d09c38e8173424418fd5", "webview_instrumentation_test_apk": "cdcdb34635d0311a93aba3c73714095010ad2f78", "wtf_unittests": "30369a10e91deefe764cfae8d0efe65a29cf43ee"} | setup_build |
got_angle_revision | "ab2bfa814ceefdcbe24483b3a12ba525345d486c" | bot_update |
got_buildtools_revision | "40194ab03962d8183b2796fa58a39ec8a9e83a41" | bot_update |
got_dawn_revision | "acd8b7d937cc4dcc81856377863f2d56af7037b5" | bot_update |
got_nacl_revision | "1ea07c56ac9b57c30eb784ab2af582af0cdd4b08" | bot_update |
got_revision | "4fcb3e56c3585e1d48d54a30e03eddd743a13113" | bot_update |
got_revision_cp | "refs/heads/master@{#623189}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "871f913bad24b4ead79468f431a1ae8326d9d27b" | bot_update |
got_v8_revision_cp | "refs/heads/7.3.412@{#1}" | bot_update |
got_webrtc_revision | "ccc1b57e32bd99e4f220a3db0e540713f4349ad9" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26266}" | bot_update |
swarm_hashes | {} | find isolated tests |
Blamelist:
- Carlos Caballero (carlscabohnoyoudont@google.com)
- Lowell Manners (lowellohnoyoudont@chromium.org)
- Sergio Villar Senin (svillarohnoyoudont@igalia.com)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- Mario Sanchez Prada (marioohnoyoudont@igalia.com)
- Jonas Olsson (jonasolssonohnoyoudont@chromium.org)
- Oleg Davydov (burundukohnoyoudont@google.com)
- Christos Froussios (cfroussiosohnoyoudont@chromium.org)
- Javier Ernesto Flores Robles (javierroblesohnoyoudont@chromium.org)
- Lowell Manners (lowellohnoyoudont@chromium.org)
- Laís Minchillo (laisminchilloohnoyoudont@chromium.org)
- Sylvain Defresne (sdefresneohnoyoudont@chromium.org)
- Michael Lippautz (mlippautzohnoyoudont@chromium.org)
- chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
- Shakti Sahu (shaktisahuohnoyoudont@chromium.org)
- Ioana Pandele (ioanapohnoyoudont@chromium.org)
- Gyuyoung Kim (gyuyoungohnoyoudont@igalia.com)
Timing:
Create | Wednesday, 16-Jan-19 11:55:41 UTC |
Start | Wednesday, 16-Jan-19 11:56:03 UTC |
End | Wednesday, 16-Jan-19 12:59:40 UTC |
Pending | 21 secs |
Execution | 1 hrs 3 mins |
All Changes:
-
[scheduling] Use ScopedTaskEnvironment instead of MessageLoop in drive_backend
Changed by Carlos Caballero - carlscabohnoyoudont@google.com Changed at Wednesday, 16-Jan-19 10:50:12 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4fcb3e56c3585e1d48d54a30e03eddd743a13113 Comments
[scheduling] Use ScopedTaskEnvironment instead of MessageLoop in drive_backend MessageLoop will go away, eventually. BUG=891670 Change-Id: Ia64f78ea238b99b0599cfec331ffaa764742399b Reviewed-on: https://chromium-review.googlesource.com/c/1377853 Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#623189}
Changed files
- chrome/browser/sync_file_system/drive_backend/callback_helper_unittest.cc
- chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc
- chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc
-
Make secondary account sync tests share a single TestURLLoaderFactory.
Changed by Lowell Manners - lowellohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 10:49:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 49be60bf098342ba3242522312d02cdd2ed1e149 Comments
Make secondary account sync tests share a single TestURLLoaderFactory. Before this change, these tests had multiple TestURLLoaderFactory instances. One, which is declared in SyncTest, plus an additional instance each time BuildFakeGaiaCookieManagerServiceWithOptions was invoked. Eventually, FakeGCMS will be eliminated entirely in these tests. This change separates out one of the logical side effects of eliminating FakeGCMS, which that there will be a single TestURLLoaderFactory instance. We are splitting out this change to be able to verify whether the switch to a single shared factory was the cause of the flake in https://chromium-review.googlesource.com/c/chromium/src/+/1396148. Our suspicion is that the flake was rather caused by the fact that in that CL, the TestURLLoaderFactory was *not* used by the main profile, whereas prior to that CL FakeGCMS instances had been installed for all Profiles. Assuming that this change sticks, we will follow it up by hiding the usage of |test_url_loader_factory_| inside a new SecondarySyncTest class, thus eliminating the passing of the raw pointer. This is part of step 1a of the plan to eliminate FakeGCMS entirely: TBR=rkaplow@chromium.org https: //docs.google.com/document/d/1t0ZtuV7h-znzdItFgBW0aKPscAwWXIBuNZnNlEGgi7g/edit Change-Id: I86837090af84e94bdd9887ac9ee5e9c96bbef8da Bug: 907782 Reviewed-on: https://chromium-review.googlesource.com/c/1411877 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#623188}
Changed files
- chrome/browser/metrics/ukm_browsertest.cc
- chrome/browser/sync/test/integration/secondary_account_helper.cc
- chrome/browser/sync/test/integration/secondary_account_helper.h
- chrome/browser/sync/test/integration/single_client_secondary_account_sync_test.cc
- chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
- chrome/browser/sync/test/integration/sync_test.h
-
Port AvatarToolbarButton away from GaiaCookieManagerService callbacks
Changed by Sergio Villar Senin - svillarohnoyoudont@igalia.com Changed at Wednesday, 16-Jan-19 10:48:56 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1fa3981d86535dfddfab2fc89ded02b5610b847f Comments
Port AvatarToolbarButton away from GaiaCookieManagerService callbacks It was observing the gaia cookie manager service to know whether the list of gaia accounts in the cookie jar has changed. That can be achieved observing IdentityManager as well. Bug: 921008 Change-Id: Icad5a14f1288346b97d4d8ccc1eb4c0a901eae3b Reviewed-on: https://chromium-review.googlesource.com/c/1408928 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#623187}
Changed files
- chrome/browser/ui/views/profiles/avatar_toolbar_button.cc
- chrome/browser/ui/views/profiles/avatar_toolbar_button.h
-
Roll src/third_party/perfetto 4a0ee4e0ef36..e2f79261ed5f (11 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Wednesday, 16-Jan-19 10:48:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9c3c23072d1b4db1b2b4c0f5eca7cc0f246063bd Comments
Roll src/third_party/perfetto 4a0ee4e0ef36..e2f79261ed5f (11 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/4a0ee4e0ef36..e2f79261ed5f git log 4a0ee4e0ef36..e2f79261ed5f --date=short --no-merges --format='%ad %ae %s' 2019-01-16 primiano@google.com Disable heap profiling e2e tests 2019-01-15 oysteine@google.com Fix integer sign mismatch error preventing Chrome autoroll 2019-01-15 rsavitski@google.com heapprofd: minimally-functioning fork mode 2019-01-15 treehugger-gerrit@google.com Merge "base: add missing PERFETTO_EXPORT to ThreadChecker" 2019-01-15 hjd@google.com Merge "perfetto-ui: Refactor high frequancy state" 2019-01-15 primiano@google.com Ftrace: fall back on set_event interface if /enable fails 2019-01-15 eseckler@google.com Merge "Add PERFETTO_EXPORT onto the ScatteredHeapBuffer and sub class SLICE" 2019-01-15 eseckler@google.com Merge "Add two additional stats (rewritten & out-of-order) related to writing chunks." 2019-01-15 eseckler@google.com Merge "gn: Make it more convenient for embedders to enable DLOG" 2019-01-15 ilkos@google.com Allow arbitrary config in tmux tool 2019-01-15 lalitm@google.com Merge "trace_processor: add userspace LMK events to the instants table" Created with: gclient setdep -r src/third_party/perfetto@e2f79261ed5f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:121352331,chromium:78791178,chromium:120185246,chromium:122609457 TBR=perfetto-bugs@google.com Change-Id: I1d8dae96d1532c2bdc1f5971d8a639fe1c0eaf08 Reviewed-on: https://chromium-review.googlesource.com/c/1414698 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#623186}
Changed files
- DEPS
-
Migrate PeopleHandler to the IdentityManager
Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com Changed at Wednesday, 16-Jan-19 10:36:33 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision cacfd35f4e09cbbd969a2c882f3db0eccc127bc0 Comments
Migrate PeopleHandler to the IdentityManager Use the APIs from IdentityManager and PrimaryAccountsMutator to migrate calls previously depending on SigninManager and ProfileOAuth2TokenService. Bug: 898810, 920236, 920237, 921445 Change-Id: I22b046bae82e2539d165d95573c27d47affa6a06 Reviewed-on: https://chromium-review.googlesource.com/c/1298994 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#623185}
Changed files
- chrome/browser/ui/webui/settings/people_handler.cc
- chrome/browser/ui/webui/settings/people_handler_unittest.cc
-
Keep the StreamBrokerDisconnectReason histograms a bit longer.
Changed by Jonas Olsson - jonasolssonohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 10:35:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision abca1d5ed36092b8877044587a89baed3b5a3941 Comments
Keep the StreamBrokerDisconnectReason histograms a bit longer. Bug: chromium:919650 chromium:919651 Change-Id: I15130a3f0e179532dc90fb7ae2ac8f142de1a641 Reviewed-on: https://chromium-review.googlesource.com/c/1412457 Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Jonas Olsson <jonasolsson@chromium.org> Cr-Commit-Position: refs/heads/master@{#623184}
Changed files
- tools/metrics/histograms/histograms.xml
-
Remove check for client registration in StatusUploader ctor
Changed by Oleg Davydov - burundukohnoyoudont@google.com Changed at Wednesday, 16-Jan-19 10:35:17 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 43132ffeb2245cfc7996e11acfeffb163ab0a380 Comments
Remove check for client registration in StatusUploader ctor StatusUploader's work makes sence only if working on managed device with resitered client, but due to some missynchonizations we may not know if it's registered client when creating StatusUploader. That's why there is an extra registered check before submitting status. See more in: https://bugs.chromium.org/p/chromium/issues/detail?id=705607 Therefore check in StatusUploader constructor is redundant and causes only problems when dchecks are enabled: https://bugs.chromium.org/p/chromium/issues/detail?id=912770 Bug: 912770 Change-Id: Ib9c4001b87834286a36cbe3ca123f1c456844ad9 Reviewed-on: https://chromium-review.googlesource.com/c/1400664 Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Oleg Davydov <burunduk@google.com> Cr-Commit-Position: refs/heads/master@{#623183}
Changed files
- chrome/browser/chromeos/policy/status_uploader.cc
-
[Password Manager] More precise errors for failure on LinuxPasswordsMigrationToEncryptionStatus
Changed by Christos Froussios - cfroussiosohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 10:32:25 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b965b53f7730d269c56675dd0fc2f39dea07a2ee Comments
[Password Manager] More precise errors for failure on LinuxPasswordsMigrationToEncryptionStatus When migrating away from the native backend, the most common cause of failure are operations on the temporary database. I've split the error code for further insight. Bug: 571003 Change-Id: I382e62ebeb9c85306526bcd6978a1aa41a5e79fc Reviewed-on: https://chromium-review.googlesource.com/c/1411609 Reviewed-by: Christos Froussios <cfroussios@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#623182}
Changed files
- chrome/browser/password_manager/password_store_x.cc
- chrome/browser/password_manager/password_store_x.h
- components/password_manager/core/browser/password_manager_metrics_util.h
- tools/metrics/histograms/enums.xml
-
[iOS][MF] Restore original keyboard for pickers
Changed by Javier Ernesto Flores Robles - javierroblesohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 10:31:58 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6897877855447b9e93eaa8a3c0e48ad5ac37ace9 Comments
[iOS][MF] Restore original keyboard for pickers When the keyboard changes to a picker restore it, so the user can select one of the options from the site. The user is still able to go back into the manual fallback menu for consultation, touching the options won't work though. Bug: 914766 Change-Id: I23b4d91bc2833705fe5cec8250e5eac27c5083d4 Reviewed-on: https://chromium-review.googlesource.com/c/1411931 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: David Jean <djean@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#623181}
Changed files
- ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
-
Add a factory method to create a FakeGCMS with a TestURLLoaderFactory.
Changed by Lowell Manners - lowellohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 10:31:18 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9b4e49741e91a48a3a3eccd25c100354de3c5f07 Comments
Add a factory method to create a FakeGCMS with a TestURLLoaderFactory. This new factory method is meant to replace BuildFakeGaiaCookieManagerServiceWithOptions in the cases where create_fake_url_loader_factory_for_cookie_requests is set to true. Callers of BuildFakeGaiaCookieManagerServiceWithOptions will be migrated to use this new factory method in a future CL. This is part of step 1a of the plan to eliminate FakeGCMS entirely: https: //docs.google.com/document/d/1t0ZtuV7h-znzdItFgBW0aKPscAwWXIBuNZnNlEGgi7g/edit Change-Id: Ia26dbe429743e30b86130106d3909a3320e4ba2d Bug: 907782 Reviewed-on: https://chromium-review.googlesource.com/c/1412456 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#623180}
Changed files
- chrome/browser/signin/fake_gaia_cookie_manager_service_builder.cc
- chrome/browser/signin/fake_gaia_cookie_manager_service_builder.h
-
[aw] Add proxy override integration tests
Changed by Laís Minchillo - laisminchilloohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 10:23:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8c5b7240984937fe41ca7fa76bab6d8c8dd1c215 Comments
[aw] Add proxy override integration tests Bug: 902215 Change-Id: Ibac9527580253aa924ed8c553bb5f01f47e368aa Reviewed-on: https://chromium-review.googlesource.com/c/1391561 Reviewed-by: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Cr-Commit-Position: refs/heads/master@{#623179}
Changed files
- android_webview/javatests/src/org/chromium/android_webview/test/AwProxyControllerTest.java
- android_webview/test/BUILD.gn
- testing/buildbot/filters/mojo.fyi.network_webview_instrumentation_test_apk.filter
-
Convert from base::{LazyInstance,Singleton} to base::NoDestructor
Changed by Sylvain Defresne - sdefresneohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 10:22:21 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8b07207aff59d8d0a19e6af45e95e3431f998ffe Comments
Convert from base::{LazyInstance,Singleton} to base::NoDestructor The class base::NoDestructor is a simpler way to define a static global value (aka a singleton) than base::{LazyInstance,Singleton} and is the recommended pattern to use. The changes were automated using a custom one-shot script, then fine tuned by hand (to remove unnecessary classes, ...). This fixes usages in src/ios/chrome/browser/ui/webui. This CL was uploaded by git cl split. Bug: none Change-Id: I0f2864e73cf4e99a07384d29dfd0c5c705a9dc85 Reviewed-on: https://chromium-review.googlesource.com/c/1411785 Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#623178}
Changed files
- ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.h
- ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.mm
-
unified-heap: Provide names for internal classes in heap snapshot
Changed by Michael Lippautz - mlippautzohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 10:09:21 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 43ae85f867e407a557e0e7671cbcc07dd2688e16 Comments
unified-heap: Provide names for internal classes in heap snapshot Provide a name for internal nodes in non-production builds. This is very useful for manual debugging builds but may confuse people without providing better DevTools integration. Bug: 843903 Change-Id: Ifd7359575beb3c916a86fc6091abfc20c76e6b64 Reviewed-on: https://chromium-review.googlesource.com/c/1412472 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#623177}
Changed files
- third_party/blink/renderer/platform/heap/name_trait_test.cc
- third_party/blink/renderer/platform/heap/name_traits.h
- third_party/blink/web_tests/inspector-protocol/heap-profiler/heap-snapshot-merged-nodes.js
- third_party/blink/web_tests/inspector-protocol/heap-profiler/heap-snapshot-with-event-listener.js
- third_party/blink/web_tests/inspector-protocol/heap-profiler/heap-snapshot-with-multiple-retainers.js
-
Roll src-internal 5631ed218f7e..f2c8fe4e24b3 (7 commits)
Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com Changed at Wednesday, 16-Jan-19 10:07:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ade728f52493877707ef97c941c06ab77d0addda Comments
Roll src-internal 5631ed218f7e..f2c8fe4e24b3 (7 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5631ed218f7e..f2c8fe4e24b3 Created with: gclient setdep -r src-internal@f2c8fe4e24b3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic38853d87d4b9222be558da9bb752c0703afa66b Reviewed-on: https://chromium-review.googlesource.com/c/1414697 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#623176}
Changed files
- DEPS
-
Download Home : Fixed padding on empty view on Articles for You section
Changed by Shakti Sahu - shaktisahuohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 10:01:42 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d60c7ccbe2128008c62c2da9e23de664c39170a3 Comments
Download Home : Fixed padding on empty view on Articles for You section This CL improves the UI (attached screenshot) as per mocks : https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZa-WKS_VfBWp/files/MCHtA7U1iMGr6yF79JTTnBdi9vOmcRvRxmM Bug: 902403 Change-Id: I7fd6b64a70531f28e5ba6fc8428198bf5c771c58 Reviewed-on: https://chromium-review.googlesource.com/c/1412822 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#623175}
Changed files
- chrome/android/java/res_download/layout/downloads_empty_view.xml
-
Remove click handler for the link in the password generation popup
Changed by Ioana Pandele - ioanapohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 09:41:36 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 893c068d35a42afd462e3caebc35ef3814af99f8 Comments
Remove click handler for the link in the password generation popup The link has already been removed, both on desktop and Android, but the click handler was not. Note: On Android, the popup is now used only to display the help text. Bug: 862269 Change-Id: Ie6fbe83c45b029fccb4fd32d228a53bdd527d5f0 Reviewed-on: https://chromium-review.googlesource.com/c/1409451 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#623174}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGenerationAdapter.java
- chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGenerationPopupBridge.java
- chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc
- chrome/browser/ui/android/autofill/password_generation_popup_view_android.h
- chrome/browser/ui/passwords/password_generation_popup_controller.h
- chrome/browser/ui/passwords/password_generation_popup_controller_impl.cc
- chrome/browser/ui/passwords/password_generation_popup_controller_impl.h
- chrome/browser/ui/views/passwords/password_generation_popup_view_views.cc
- chrome/browser/ui/views/passwords/password_generation_popup_view_views.h
-
s13n: Remove SigninManager-related includes from identity_apitest.cc
Changed by Gyuyoung Kim - gyuyoungohnoyoudont@igalia.com Changed at Wednesday, 16-Jan-19 09:35:12 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 81cd63979e7fb20cbc42824992cde618a04941d8 Comments
s13n: Remove SigninManager-related includes from identity_apitest.cc This CL cleans up the unnecessary includes related to SigninManager. Bug: 920210 Change-Id: I67b9505ad35270ca50356dade8e02fb478557000 Reviewed-on: https://chromium-review.googlesource.com/c/1414730 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#623173}
Changed files
- chrome/browser/extensions/api/identity/identity_apitest.cc