Home | Search | chromium - Builders
Login

Builder Lollipop Phone Tester Build 2927 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision7bb43df173039894cf46c8b3476913f0f20ae6d1
Got Revision7bb43df173039894cf46c8b3476913f0f20ae6d1

Execution:

Steps and Logfiles:

Show:
  1. ( 327 ms ) setup_build
    running recipe: "chromium"
  2. ( 862 ms ) report builders
     
    running tester 'Lollipop Phone Tester' on master 'chromium.android'
  3. ( 4 mins 11 secs ) bot_update
    [57GB/295GB used (19%)]
  4. ( 1 secs ) swarming.py --version
    0.13
  5. ( 39 secs ) gclient runhooks
  6. ( 1 secs ) read test spec (chromium.android.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
  7. ( 499 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = true
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_os = "android"
    use_goma = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  8. ( 15 secs ) clean local files
  9. ( 741 ms ) tree truth steps
  10. ( 507 ms ) build directory
  11. ( 1 secs ) find isolated tests
  12. ( 5 secs ) android_webview_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:03.993908
  13. ( 14 secs ) angle_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:01:50.399514
  14. ( 1 mins 6 secs ) base_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 0:02:55.872733
  15. ( 2 secs ) blink_common_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Shard duration: 31s
  16. ( 2 secs ) blink_heap_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 17s
    Shard duration: 0:02:06.096059
  17. ( 4 secs ) blink_platform_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 24s
    Shard duration: 0:02:36.300734
  18. ( 2 secs ) boringssl_crypto_tests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 30s
    Shard duration: 0:02:16.338203
  19. ( 2 secs ) boringssl_ssl_tests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 41s
    Shard duration: 30s
  20. ( 2 secs ) breakpad_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 43s
    Shard duration: 29s
  21. ( 2 secs ) cacheinvalidation_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 49s
    Shard duration: 26s
  22. ( 2 secs ) capture_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 49s
    Shard duration: 52s
  23. ( 2 secs ) cast_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 53s
    Shard duration: 36s
  24. ( 4 secs ) cc_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 53s
    Shard duration: 0:02:51.873137
  25. ( 6 mins 24 secs ) chrome_sync_shell_test_apk on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:01:58.651560
    Shard duration: 0:08:09.801829
  26. ( 3 secs ) components_browsertests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:02:03.380761
    Shard duration: 0:03:30.402299
  27. ( 2 secs ) perfetto_content_browsertests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:02:17.780474
    Shard duration: 0:01:41.208517
  28. ( 2 secs ) crypto_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:02:16.668605
    Shard duration: 32s
  29. ( 2 secs ) device_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:02:17.182593
    Shard duration: 49s
  30. ( 2 secs ) display_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:02:32.066951
    Shard duration: 33s
  31. ( 2 secs ) events_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:02:52.197002
    Shard duration: 35s
  32. ( 2 secs ) gcm_unit_tests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:02:54.053102
    Shard duration: 43s
  33. ( 5 secs ) gfx_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:03:07.108897
    Shard duration: 0:02:25.183330
  34. ( 2 secs ) gin_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:03:47.911424
    Shard duration: 31s
  35. ( 2 secs ) gl_tests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:03:49.743277
    Shard duration: 0:01:21.257549
  36. ( 2 secs ) gl_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:03:58.550656
    Shard duration: 27s
  37. ( 2 secs ) google_apis_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:04:04.553595
    Shard duration: 37s
  38. ( 5 secs ) gpu_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:04:08.668127
    Shard duration: 0:02:10.202885
  39. ( 2 secs ) ipc_tests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:04:21.751970
    Shard duration: 31s
  40. ( 2 secs ) jingle_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:04:37.371760
    Shard duration: 36s
  41. ( 2 secs ) latency_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:04:40.643109
    Shard duration: 27s
  42. ( 2 secs ) libjingle_xmpp_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:04:53.797773
    Shard duration: 35s
  43. ( 3 secs ) media_blink_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:05:15.437026
    Shard duration: 0:01:18.339712
  44. ( 2 secs ) media_service_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:05:36.170956
    Shard duration: 55s
  45. ( 6 secs ) media_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:05:44.844918
    Shard duration: 0:03:15.466558
  46. ( 2 secs ) midi_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:05:54.852413
    Shard duration: 28s
  47. ( 2 secs ) mojo_test_apk on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:06:10.182965
    Shard duration: 0:01:50.538495
  48. ( 2 secs ) mojo_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:06:16.807434
    Shard duration: 0:01:21.759809
  49. ( 2 secs ) sandbox_linux_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:06:22.547562
    Shard duration: 24s
  50. ( 4 secs ) services_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:06:22.001911
    Shard duration: 0:02:26.262360
  51. ( 2 secs ) shell_dialogs_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:06:28.880291
    Shard duration: 36s
  52. ( 2 secs ) skia_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:06:32.690284
    Shard duration: 43s
  53. ( 2 secs ) sql_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:07:14.800734
    Shard duration: 34s
  54. ( 2 secs ) storage_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:07:23.601873
    Shard duration: 0:01:01.390746
  55. ( 2 secs ) ui_android_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:07:31.022212
    Shard duration: 31s
  56. ( 2 secs ) ui_base_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:07:34.070774
    Shard duration: 47s
  57. ( 2 secs ) ui_touch_selection_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:07:51.279013
    Shard duration: 29s
  58. ( 2 secs ) url_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:07:52.365837
    Shard duration: 26s
  59. ( 2 secs ) viz_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:08:11.337474
    Shard duration: 57s
  60. ( 2 secs ) vr_common_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:08:15.229050
    Shard duration: 0:01:07.249491
  61. ( 2 secs ) vr_pixeltests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:08:34.020654
    Shard duration: 0:01:04.303512
  62. ( 2 secs ) wtf_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Pending time: 0:08:58.087103
    Shard duration: 31s
  63. ( 3 mins 44 secs ) chrome_public_test_vr_apk on Android device Nexus 5
    Run on OS: 'Android'
    Max pending time: 0:08:59.052908 (shard #1)
    Max shard duration: 0:07:49.957411 (shard #0)
    Min shard duration: 0:07:28.749281 (shard #1)
  64. ( 2 mins 8 secs ) webkit_unit_tests on Android device Nexus 5
    Run on OS: 'Android'
    Max pending time: 0:09:26.084963 (shard #1)
    Max shard duration: 0:09:38.986442 (shard #0)
    Min shard duration: 0:08:19.131340 (shard #1)
  65. ( 3 secs ) content_shell_test_apk on Android device Nexus 5
    Run on OS: 'Android'
    Max pending time: 0:10:12.961124 (shard #2)
    Max shard duration: 0:07:10.667998 (shard #1)
    Min shard duration: 0:07:04.931047 (shard #2)
  66. ( 6 secs ) content_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Max pending time: 0:10:45.909062 (shard #2)
    Max shard duration: 0:03:59.534884 (shard #0)
    Min shard duration: 0:03:41.003625 (shard #1)
  67. ( 4 mins 18 secs ) net_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Max pending time: 0:15:56.078218 (shard #2)
    Max shard duration: 0:07:29.244319 (shard #0)
    Min shard duration: 0:06:11.750058 (shard #2)
  68. ( 32 secs ) components_unittests on Android device Nexus 5
    Run on OS: 'Android'
    Max pending time: 0:18:11.143396 (shard #3)
    Max shard duration: 0:06:06.028656 (shard #3)
    Min shard duration: 0:05:12.934884 (shard #1)
  69. ( 6 mins 40 secs ) webview_instrumentation_test_apk on Android device Nexus 5
    Run on OS: 'Android'
    Max pending time: 0:23:21.192282 (shard #6)
    Max shard duration: 0:09:56.440227 (shard #4)
    Min shard duration: 0:07:37.391187 (shard #6)
  70. ( 12 mins 22 secs ) content_browsertests on Android device Nexus 5
    Run on OS: 'Android'
    Max pending time: 0:29:42.080195 (shard #8)
    Max shard duration: 0:16:13.030313 (shard #3)
    Min shard duration: 0:10:57.919511 (shard #8)
  71. ( 38 secs ) unit_tests on Android device Nexus 5
    Run on OS: 'Android'
    Max pending time: 0:39:39.740035 (shard #9)
    Max shard duration: 0:04:58.704733 (shard #0)
    Min shard duration: 0:04:08.671000 (shard #7)
  72. ( 20 mins 58 secs ) chrome_public_test_apk on Android device Nexus 5
    Run on OS: 'Android'
    Max pending time: 0:54:58.275493 (shard #19)
    Max shard duration: 0:10:58.111816 (shard #8)
    Min shard duration: 0:07:33.220389 (shard #19)
  73. ( 236 ms ) Tests statistics
     
    Stats
    Total shards: 114
    Total runtime: 9:27:20.350582
     
  74. ( 704 ms ) test_report
  75. ( 2 ms ) recipe result

Build Properties:

NameValueSource
$build/goma {"jobs": 150} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm98-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539331603697857, "id": "8932887540280193472", "project": "chromium", "tags": ["builder:Lollipop Phone Tester", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/7bb43df173039894cf46c8b3476913f0f20ae6d1", "gitiles_ref:refs/heads/master", "parent_buildername:Android arm Builder (dbg)", "parent_buildnumber:37873", "scheduler_invocation_id:9098317602462697472", "scheduler_job_id:chromium/Lollipop Phone Tester", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Lollipop Phone Tester" setup_build
buildnumber 2927 setup_build
mastername "chromium.android" setup_build
parent_buildername "Android arm Builder (dbg)" setup_build
parent_got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" setup_build
parent_got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" setup_build
parent_got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" setup_build
parent_got_revision "7bb43df173039894cf46c8b3476913f0f20ae6d1" setup_build
parent_got_revision_cp "refs/heads/master@{#599123}" setup_build
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" setup_build
parent_got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" setup_build
parent_got_v8_revision_cp "refs/heads/7.1.302@{#1}" setup_build
parent_got_webrtc_revision "a54daf162facb9fe30bcc3e05bd21c1597076157" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25135}" setup_build
parent_mastername "chromium.android" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "7bb43df173039894cf46c8b3476913f0f20ae6d1" setup_build
swarm_hashes {"android_webview_unittests": "8394e2e1bf47ae6a0805c9cb289ebde4db2e63db", "angle_unittests": "80fd5744ed069fe5901e959a73efc1888b6501a3", "base_unittests": "f916cf6182719b2280459e319af3ac25b9648ec2", "blink_common_unittests": "9351add28023438ca05c2b84b1bc5335f93ce960", "blink_heap_unittests": "c626e35022c40fdaec6fe7ed6f6bde57bffbe2b9", "blink_platform_unittests": "edc32776c045a189914bbc8912b14cf68ec0f192", "boringssl_crypto_tests": "ca9b28d6dc9c3b815c997d75fab4bdbfb7c9a8df", "boringssl_ssl_tests": "359a69b402d9605abefa787ee2e1d91242d7002d", "breakpad_unittests": "5134e43c0682165819b7fe3e9d30015d30354d23", "cacheinvalidation_unittests": "7148ff5d4795e9bc9198edd70c11ac1887810200", "capture_unittests": "837a91db8fb58396f3f24b41ed6b6c4fea516dde", "cast_unittests": "ffcc8cce9de251f7762fc91fa3cc43f652f9789c", "cc_unittests": "4f22ab82c1ae276a90719d20c48023ab67abae22", "chrome_public_test_apk": "071181bbfbde49e73e287120718ee0f9447beff4", "chrome_public_test_vr_apk": "b0e5812ede8800b76013905540ecc0a9c9203a92", "chrome_sync_shell_test_apk": "9aa7165a49e2d0a3d6e3b3bc6be4056544e740da", "components_browsertests": "baec130eb2027ab82ae55c2e4df54d351e91a51c", "components_unittests": "c43fb42227f8d880539be9928516083c20a6ac0d", "content_browsertests": "432bbe901af0946522a21c7e4cf972a9ef0a770d", "content_shell_test_apk": "5df3a94f190aeb791efef376258e430556218828", "content_unittests": "0cb5bb4ffbc412638721581fda0dc9bb9149db65", "crypto_unittests": "f9fca71955d0119590fe558bd00f12f0ece70b0f", "device_unittests": "61ad1389f4e9f0cb0a3d754f3c12c4abd0336066", "display_unittests": "6ae10685c10107b3c77c6c5491c63fc35c1cf770", "events_unittests": "31435de5571ea11dadbaf4030650d886f9f0f19b", "gcm_unit_tests": "23401f53ed054caff1145b033ad8f126011eeba1", "gfx_unittests": "73db35d6beca34400ff7dffc89c5b66e6d2d4224", "gin_unittests": "a0879eae1569349b90eaa06d8152a809a3356653", "gl_tests": "077e9eea51243143a4a95c392fe68dfe615cdf77", "gl_unittests": "84d33c3304f78c6c52afd194cd091172e9f0312e", "google_apis_unittests": "0bdb3ef31e6df94fe70426682ddd2aae6f32fce1", "gpu_unittests": "d34b70bc1e8c61671327f5745812b0dbe9d5a51f", "ipc_tests": "b02f2efdd40e28ef3e5ef0ad84cafb6ab2a7e027", "jingle_unittests": "a802442fe66065532c08a3dcf351c1163373b3b4", "latency_unittests": "d31022fe8e462fc0b872dd6e6d72afbe71808a34", "libjingle_xmpp_unittests": "d2acb0356815d1a0b268e19fc1fa250d76085797", "media_blink_unittests": "be9d5bd43a42103d3ab6c3a2d68870b82743a774", "media_service_unittests": "2b66986be498c015c1508b1de860ba9c4934ac54", "media_unittests": "0dac6fec438b2f1bfaeea992cf4be460b9113b4d", "midi_unittests": "251ab862ce0b4a858ae2185ea187e98a6dd01733", "mojo_test_apk": "05a1348a5077208cc513f9cd911cb21401b43726", "mojo_unittests": "acaefe5b1a937d18a67e414126f98f42ba1d8f27", "net_unittests": "016cf26a95779ac7439573f2046278af24c2b9ef", "sandbox_linux_unittests": "75f5d769dd4aec8f32a0a923f41e65165582aeb6", "services_unittests": "c87f64b91963e2a0b00d33da18cc4bd5a8f448fd", "shell_dialogs_unittests": "dcc2a157b0257297e121d0d3e60b20d472b4094c", "skia_unittests": "85e0e23832a30e2404901cd5e17aea6097f53f7e", "sql_unittests": "3ef426e5fb274ae9acd75a3879dd127fe8c3ba19", "storage_unittests": "13b3dd4a7f7035277b2b3789dc18f30274d1dd30", "ui_android_unittests": "4f29f6e5fb3e003f1bba4c94348ba8c25e80fcd6", "ui_base_unittests": "079bcadb00342e928d3957fa7aa0ac5fd00fb8c1", "ui_touch_selection_unittests": "92da693a94ece80fd55828f3ff9552fff447b5cf", "unit_tests": "54ecb9cd8e7a3f8ad5584b1cbaf8ca1171e15e54", "url_unittests": "e223a04013841748caaeff2ae9b08f07aa82eac1", "viz_unittests": "7379eb901bf3ab167e19b81e0b2e1c92498175e1", "vr_common_unittests": "92c56c5fe825fe6e6220e1e5a33ae12e7dbceb83", "vr_pixeltests": "506d4a5e14c3ea6d274c1c38a99f11c39e5e8de3", "webkit_layout_tests_exparchive": "38fb0e13e39e0600dc6bdfb678157a8c9698487c", "webkit_unit_tests": "3ec009a64e42832e1635ee3fddbb9a02c44622d4", "webview_cts_tests": "d4cdd05eded9c3cb6133862a616bf821ba550be1", "webview_instrumentation_test_apk": "90b68e2f370ff2f360e95771239d22a1c01be1b3", "wtf_unittests": "a4ed526e1030972f6a1a799828cc4902661af4e9"} setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "7bb43df173039894cf46c8b3476913f0f20ae6d1" bot_update
got_revision_cp "refs/heads/master@{#599123}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "a54daf162facb9fe30bcc3e05bd21c1597076157" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25135}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. Henrik Grunell (grunellohnoyoudont@chromium.org)
  2. Jochen Eisinger (jochenohnoyoudont@chromium.org)
  3. yiyix (yiyixohnoyoudont@chromium.org)
  4. Maksim Sisov (msisovohnoyoudont@igalia.com)
  5. Christopher Cameron (ccameronohnoyoudont@chromium.org)
  6. Trent Apted (taptedohnoyoudont@chromium.org)
  7. Sam McNally (sammcohnoyoudont@chromium.org)
  8. Alexandre Courbot (acourbotohnoyoudont@chromium.org)
  9. Trent Apted (taptedohnoyoudont@chromium.org)
  10. Yuki Yamada (yukiyohnoyoudont@google.com)
  11. rajendrant (rajendrantohnoyoudont@chromium.org)
  12. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  13. Patti (patricialorohnoyoudont@chromium.org)
  14. Yuki Yamada (yukiyohnoyoudont@google.com)
  15. Jinsuk Kim (jinsukkimohnoyoudont@chromium.org)
  16. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)

Timing:

Create Friday, 12-Oct-18 08:06:43 UTC
Start Friday, 12-Oct-18 08:07:09 UTC
End Friday, 12-Oct-18 09:20:01 UTC
Pending 26 secs
Execution 1 hrs 12 mins

All Changes:

  1. Revert "[Video Capture, Test] Make tests requiring real webcam fail if it's not found"

    Changed by Henrik Grunell - grunellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:57:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7bb43df173039894cf46c8b3476913f0f20ae6d1

    Comments

    Revert "[Video Capture, Test] Make tests requiring real webcam fail if it's not found"
    
    This reverts commit dfeab488cdc95233b19b9edeedef3d0b7581b17e.
    
    Reason for revert: Tests fail on Chromium WebRTC bots. Example: https://ci.chromium.org/buildbot/chromium.webrtc/Mac%20Tester/84091
    
    Original change's description:
    > [Video Capture, Test] Make tests requiring real webcam fail if it's not found
    > 
    > Use prefix "UsingRealWebcam_" for names of tests that require real webcam and
    > add checking whether webcam is found or not.
    > Accordingly, exclude such test cases from test suites for devices that have no
    > camera.
    > 
    > Bug: 893494
    > Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebox (guado)
    >       and it failed.
    > Test: Ran capture_unittests excluding UsingRealWebcam_ tests on Chromebox (guado)
    >       and it passed.
    > Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebook (kevin)
    >       and it passed.
    > 
    > Change-Id: I5c91380b7674aeace6a7d1764f7fad31f02f8af7
    > Reviewed-on: https://chromium-review.googlesource.com/c/1276407
    > Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org>
    > Reviewed-by: Christian Fremerey <chfremer@chromium.org>
    > Reviewed-by: Ben Pastene <bpastene@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599097}
    
    TBR=bpastene@chromium.org,chfremer@chromium.org,keiichiw@chromium.org
    
    Change-Id: I282dc00ffad2ff6614e7dfab1a9404da85cf032a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 893494
    Reviewed-on: https://chromium-review.googlesource.com/c/1278272
    Reviewed-by: Henrik Grunell <grunell@chromium.org>
    Commit-Queue: Henrik Grunell <grunell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599123}

    Changed files

    • media/capture/video/video_capture_device_unittest.cc
    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.chromiumos.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.linux.json
    • testing/buildbot/chromium.mac.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.win.json
    • testing/buildbot/test_suites.pyl
  2. Remove the round-robin list for third-party additions

    Changed by Jochen Eisinger - jochenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:51:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 13767a51fd778bba049621a733ac7fbe6221922b

    Comments

    Remove the round-robin list for third-party additions
    
    Instead, require an email to opensource-licensing@ again until we
    figured out the new process.
    
    R=jam@chromium.org
    
    Change-Id: I352bd17e42cc1500994ba39368d25a0d91271f9c
    Reviewed-on: https://chromium-review.googlesource.com/c/1275846
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Commit-Queue: Jochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599122}

    Changed files

    • docs/adding_to_third_party.md
    • third_party/OWNERS
  3. GPU_Tests: Remove expectations after rebaseline

    Changed by yiyix - yiyixohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:49:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c30443b0e8a01efd448efc72829fb96584f0db0

    Comments

    GPU_Tests: Remove expectations after rebaseline
    
    Bug: 879379
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I43e957955103e5b2d6e4ae80b296655f1b2aa5b1
    Reviewed-on: https://chromium-review.googlesource.com/c/1277953
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Commit-Queue: Yi Xu <yiyix@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599121}

    Changed files

    • content/test/gpu/gpu_tests/pixel_expectations.py
  4. [ozone/wayland] Fix kiosk mode.

    Changed by Maksim Sisov - msisovohnoyoudont@igalia.com
    Changed at Friday, 12-Oct-18 06:36:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f154daab631433d3d9706af7f3512aa6b196e52f

    Comments

    [ozone/wayland] Fix kiosk mode.
    
    This CL fixes a fullscreen state changes before the surface is
    activated.
    
    That is, Wayland may ignore fullscreen changes before the surface
    is activated. Thus, store a pending state, and once the surface
    is activated, trigger the change.
    
    Change-Id: I8c0b995eb9f282f6be16e82d094d9dd93821a60a
    Bug: 843018
    Reviewed-on: https://chromium-review.googlesource.com/c/1275885
    Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
    Commit-Queue: Maksim Sisov <msisov@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#599120}

    Changed files

    • ui/ozone/platform/wayland/wayland_window.cc
    • ui/ozone/platform/wayland/wayland_window.h
    • ui/ozone/platform/wayland/wayland_window_unittest.cc
  5. RemoteMacViews: Make fullscreen mode not crash

    Changed by Christopher Cameron - ccameronohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:34:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 800a927eb503828f5cf6f489739e1a6efc444429

    Comments

    RemoteMacViews: Make fullscreen mode not crash
    
    Fix a few places where we would dereference a BridgedNativeWidgetImpl
    which is null when out-of-process. This doesn't guarantee correct
    behavior, but avoids a crash.
    
    Make WebContentsNSViewBridge::Show resize the web contents view and
    also all of its children.
    
    Bug: 859152
    Change-Id: I948de1e4f79db4a51c5b86e7960356133eff4342
    Reviewed-on: https://chromium-review.googlesource.com/c/1278533
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: ccameron <ccameron@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599119}

    Changed files

    • chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_views.mm
    • content/browser/web_contents/web_contents_ns_view_bridge.mm
  6. Migrate base::AtomicFlag to std::atomic

    Changed by Trent Apted - taptedohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:34:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d64bfc8e330fea105de74137e6e176763dc546a4

    Comments

    Migrate base::AtomicFlag to std::atomic
    
    atomicops.h uses `volatile` which inhibits some compiler optimisations
    without contributing to threading correctness.
    
    Define AtomicFlag::IsSet() in the header, rather than out-of-line.
    Without this, WeakPtr overheads in ObserverListPerfTest_*.CheckedObserver
    in base_perftests are up to 70% greater.
    
    Bug: 891536
    Change-Id: Ibc733042bf0027738b49c70ccbbcefc4cde3289d
    Reviewed-on: https://chromium-review.googlesource.com/c/1278425
    Commit-Queue: Trent Apted <tapted@chromium.org>
    Reviewed-by: Albert J. Wong <ajwong@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599118}

    Changed files

    • base/synchronization/atomic_flag.cc
    • base/synchronization/atomic_flag.h
  7. Make DriveFS opt-out in FilesApp tests.

    Changed by Sam McNally - sammcohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:33:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e9c79d562d8d3b789cca95b6909aa600a1dd39d2

    Comments

    Make DriveFS opt-out in FilesApp tests.
    
    Bug: 891197
    Change-Id: Id3101a43cfe97e652d71f720b5f312b933af1113
    Reviewed-on: https://chromium-review.googlesource.com/c/1277133
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Commit-Queue: Sam McNally <sammc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599117}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
  8. media/gpu/v4l2: use actual number of planes in ioctls

    Changed by Alexandre Courbot - acourbotohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:30:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cec52397f2ea0fb8ac322378d229f1a454edf972

    Comments

    media/gpu/v4l2: use actual number of planes in ioctls
    
    The Tegra V4L2 library has a bug in its handling of VIDIOC_QUERYBUF that
    makes it fail if the number of planes of the passed v4l2_buffer does not
    exactly match the number of planes of the currently set format. This CL
    implements a workaround by first running a VIDIOC_G_FMT ioctl in
    AllocateBuffers(), and then passing the returned number of planes to the
    buffer constructor so the correct value can be passed to
    VIDIOC_QUERYBUF.
    
    And since we have this value, we also use it in VIDIOC_DQBUF.
    
    BUG=893661
    TEST=Checked that VDA unittest was passing on hana (Tegra devices have
    another bug that is fixed in the next CL).
    
    Change-Id: I830334de1cf322302fd476ac5535313ebc65900d
    Reviewed-on: https://chromium-review.googlesource.com/c/1275726
    Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
    Reviewed-by: Pawel Osciak <posciak@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599116}

    Changed files

    • media/gpu/v4l2/v4l2_device.cc
    • media/gpu/v4l2/v4l2_device.h
  9. Files App: Move reportPromise,waitUntil to //ui/file_manager/base/js/test_error_reporting.js

    Changed by Trent Apted - taptedohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:29:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4

    Comments

    Files App: Move reportPromise,waitUntil to //ui/file_manager/base/js/test_error_reporting.js
    
    These functions are currently in file_manager/file_manager/common/js/unittest_util.js
    which has a lot of files-app specific stuff that media apps shouldn't
    depend on.
    
     - Move MockAPIEvent to the only unittest (in gallery) that uses it.
     - Delete the redundant copy of waitUntil in list_thumbnail_loader_unittest.js
     - Updates the remaining handcrafted foo_unittest.html files in the files app
       * combination sed-script and manual edit.
    
    Bug: 879035
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I7d54cec253384b46d1cdb7c51f8ff0eb9596ebf1
    Reviewed-on: https://chromium-review.googlesource.com/c/1275545
    Commit-Queue: Trent Apted <tapted@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599115}

    Changed files

    • ui/file_manager/base/js/BUILD.gn
    • ui/file_manager/base/js/test_error_reporting.js
    • ui/file_manager/file_manager/background/js/device_handler_unittest.html
    • ui/file_manager/file_manager/background/js/duplicate_finder_unittest.html
    • ui/file_manager/file_manager/background/js/file_operation_manager_unittest.html
    • ui/file_manager/file_manager/background/js/import_history_unittest.html
    • ui/file_manager/file_manager/background/js/media_import_handler_unittest.html
    • ui/file_manager/file_manager/background/js/media_scanner_unittest.html
    • ui/file_manager/file_manager/background/js/task_queue_unittest.html
    • ui/file_manager/file_manager/background/js/volume_manager_unittest.html
    • ui/file_manager/file_manager/common/js/BUILD.gn
    • ui/file_manager/file_manager/common/js/metrics_unittest.html
    • ui/file_manager/file_manager/common/js/unittest_util.js
    • ui/file_manager/file_manager/foreground/elements/files_tooltip_unittest.html
    • ui/file_manager/file_manager/foreground/js/BUILD.gn
    • ui/file_manager/file_manager/foreground/js/actions_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/file_tasks_unittest.html
    • ui/file_manager/file_manager/foreground/js/import_controller_unittest.html
    • ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.html
    • ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.js
    • ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_provider_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/metadata_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/multi_metadata_provider_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/thumbnail_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/providers_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/spinner_controller_unittest.html
    • ui/file_manager/file_manager/foreground/js/task_controller_unittest.html
    • ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.html
    • ui/file_manager/file_manager/foreground/js/ui/file_tap_handler_unittest.html
    • ui/file_manager/gallery/js/BUILD.gn
    • ui/file_manager/gallery/js/entry_list_watcher_unittest.js
    • ui/file_manager/gallery/js/image_editor/BUILD.gn
    • ui/file_manager/image_loader/BUILD.gn
  10. Rename scopes and context in JSBasedEventListener::handleEvent()

    Changed by Yuki Yamada - yukiyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 06:29:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7d87839234fceb435e01ca49cf72096ef6691599

    Comments

    Rename scopes and context in JSBasedEventListener::handleEvent()
    
    This CL renames some ambiguous name of scope and context in
    JSBasedEventListener::handleEvent().
    
    Split from another one:
    https://chromium-review.googlesource.com/c/chromium/src/+/1270300
    
    Bug: 872138
    Change-Id: I8e772ecdc283fd1585566cf56a52170b777f4608
    Reviewed-on: https://chromium-review.googlesource.com/c/1277135
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Commit-Queue: Yuki Yamada <yukiy@google.com>
    Cr-Commit-Position: refs/heads/master@{#599114}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/js_based_event_listener.cc
  11. Remove service name and refactor data use update to metrics service

    Changed by rajendrant - rajendrantohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:24:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dce70a031f697342a52b900211aa0ba7eceab082

    Comments

    Remove service name and refactor data use update to metrics service
    
    This CL does a bunch of steps to make the servicification easy to do.
    1. Removes the usage of ServiceName in data_use_measurement
    2. Refactors the data use update to metrics service to not take service
    name and instead send if the data use is from metrics component.
    3. To remove the UpdateUsagePrefCallback from DataUseMeasurement(),
    ChromeDataUseMeasurement is introduced that does the posting to UI thread
    (from io_thread.cc). This helps in servicification since there won't be
    thread hop. This also helps when CDUA classes are removed, and
    ChromeDataUseMeasurement can be there without dependency.
    
    Bug: 808498
    Change-Id: I7a4421c9798447c1ca4d39698f69b227cc773d48
    Reviewed-on: https://chromium-review.googlesource.com/c/1272256
    Commit-Queue: rajendrant <rajendrant@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Reviewed-by: Roger Tawa <rogerta@chromium.org>
    Reviewed-by: Steven Holte <holte@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599113}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
    • chrome/browser/data_use_measurement/chrome_data_use_ascriber.h
    • chrome/browser/data_use_measurement/chrome_data_use_measurement.cc
    • chrome/browser/data_use_measurement/chrome_data_use_measurement.h
    • chrome/browser/io_thread.cc
    • chrome/browser/io_thread.h
    • chrome/browser/net/system_network_context_manager.cc
    • chrome/browser/net/system_network_context_manager.h
    • chrome/browser/profiles/profile_impl_io_data.cc
    • components/data_use_measurement/core/BUILD.gn
    • components/data_use_measurement/core/DEPS
    • components/data_use_measurement/core/data_use_ascriber.cc
    • components/data_use_measurement/core/data_use_ascriber.h
    • components/data_use_measurement/core/data_use_measurement.cc
    • components/data_use_measurement/core/data_use_measurement.h
    • components/data_use_measurement/core/data_use_measurement_unittest.cc
    • components/data_use_measurement/core/data_use_network_delegate.cc
    • components/data_use_measurement/core/data_use_network_delegate.h
    • components/data_use_measurement/core/data_use_network_delegate_unittest.cc
    • components/data_use_measurement/core/data_use_user_data.cc
    • components/data_use_measurement/core/data_use_user_data.h
    • components/domain_reliability/uploader.cc
    • components/domain_reliability/uploader.h
    • components/metrics/data_use_tracker.cc
    • components/metrics/data_use_tracker.h
    • components/metrics/data_use_tracker_unittest.cc
    • components/metrics/metrics_service.cc
    • components/metrics/metrics_service.h
    • components/metrics/reporting_service.cc
    • components/metrics/reporting_service.h
    • google_apis/gaia/gaia_auth_util.cc
    • google_apis/gaia/gaia_auth_util.h
    • google_apis/gaia/gaia_oauth_client.cc
    • google_apis/gaia/oauth2_api_call_flow.cc
    • tools/metrics/histograms/histograms.xml
  12. Roll src/third_party/chromite 89e4bf93b1a1..e2727ef6f5dc (3 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 06:12:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 028fceebebe0743ddd7bb16dc8b753ae0f41a3f2

    Comments

    Roll src/third_party/chromite 89e4bf93b1a1..e2727ef6f5dc (3 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/89e4bf93b1a1..e2727ef6f5dc
    
    
    git log 89e4bf93b1a1..e2727ef6f5dc --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 dgarrett@google.com builder_status_lib: Fix logging lint error.
    2018-10-12 vapier@chromium.org paygen: paygen_payload_lib: convert to gs.LS
    2018-10-12 vapier@chromium.org paygen: urilib_unittest: convert mox to mock
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@e2727ef6f5dc
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I2f3527661843ab9aafccf5f4f58b19fdde879453
    Reviewed-on: https://chromium-review.googlesource.com/c/1278301
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599112}

    Changed files

    • DEPS
  13. Revert "[Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering."

    Changed by Patti - patricialorohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:10:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8c2893ee9102687d16f2f65fa96651d8bd1fdab7

    Comments

    Revert "[Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering."
    
    This reverts commit 86da6573944f302cf9df04d59a7e35bba895d059.
    
    Reason for revert: This patch may be causing failures in browser_tests, on chromium.win/Win7 Tests (dbg)(1)
      https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29
    
    Findit found culprit 598844 with 75% confidence, so reverting this to try and fix.
    
    Original change's description:
    > [Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering.
    > 
    > * The service shouldn't unregister from the topics, when handler
    > the Handler is unregistering from topic (as stated in the documentation
    > for for UnregisterHandler).
    > * Sync shouldn't unregister on browser shutdown
    > 
    > Bug: 801985, 876274
    > Change-Id: I857da7b0fbfa0a0f2e1ad05708cc24cdc9386a76
    > Reviewed-on: https://chromium-review.googlesource.com/c/1196522
    > Commit-Queue: Tatiana Gornak <melandory@chromium.org>
    > Reviewed-by: Gabriel Charette <gab@chromium.org>
    > Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#598844}
    
    TBR=gab@chromium.org,pavely@chromium.org,melandory@chromium.org
    
    Change-Id: I70fa87c3476925814408665644acb23c3c1f1614
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 801985, 876274, 894715
    Reviewed-on: https://chromium-review.googlesource.com/c/1278273
    Reviewed-by: Patti <patricialor@chromium.org>
    Commit-Queue: Patti <patricialor@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599111}

    Changed files

    • chrome/browser/prefs/browser_prefs.cc
    • components/invalidation/impl/BUILD.gn
    • components/invalidation/impl/fcm_fake_invalidator.cc
    • components/invalidation/impl/fcm_invalidation_listener.cc
    • components/invalidation/impl/fcm_invalidation_listener.h
    • components/invalidation/impl/fcm_invalidation_service.cc
    • components/invalidation/impl/fcm_invalidation_service.h
    • components/invalidation/impl/fcm_invalidation_service_unittest.cc
    • components/invalidation/impl/invalidator_registrar.cc
    • components/invalidation/impl/invalidator_registrar.h
    • components/invalidation/impl/invalidator_registrar_with_memory.cc
    • components/invalidation/impl/invalidator_registrar_with_memory.h
    • components/sync/driver/glue/sync_backend_host_impl.cc
  14. Create v8::HandleScope in JSBasedEventListener::GetSourceLocation()

    Changed by Yuki Yamada - yukiyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 06:08:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f93617e5eb9f06935b07002223f33d164f517909

    Comments

    Create v8::HandleScope in JSBasedEventListener::GetSourceLocation()
    
    This is the bug fixing for previous CL:
    https://chromium-review.googlesource.com/c/chromium/src/+/1253317
    
    v8::HandleScope was not named.
    
    Bug: 894069
    Change-Id: Ib9111275bad434b1968a4bd674a0b8932b8c1533
    Reviewed-on: https://chromium-review.googlesource.com/c/1278548
    Commit-Queue: Yuki Yamada <yukiy@google.com>
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599110}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/js_based_event_listener.cc
  15. Android: Ensure single TabWebContentsObserver per Tab

    Changed by Jinsuk Kim - jinsukkimohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:07:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e0a45684f1cc9e125daed78cb74c7939415ebadc

    Comments

    Android: Ensure single TabWebContentsObserver per Tab
    
    TabWebContentsObserver is TabWebContentsUserData which is created
    for the first active WebContents for a given Tab, and finally
    destroyed together with the Tab. There was a bug creating
    multiple instances of the observer for every new active WebContents.
    This left an instance for old WebContents undestroyed, and caused
    a reported bug for already nulled out WebContents references
    while handling an event that should not have been triggered.
    
    This CL makes sure there will be a single TabWebContentsObserver
    for Tab.
    
    Bug: 894353
    Change-Id: Ie2cbe5c79b4d1e9f68d1be045c4d7e88d91c5312
    Reviewed-on: https://chromium-review.googlesource.com/c/1278426
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599109}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
  16. Roll src/third_party/webrtc 8f4bc41c4231..a54daf162fac (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 06:05:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9d4f9a68490476ebc67a19242ed76606d57aa853

    Comments

    Roll src/third_party/webrtc 8f4bc41c4231..a54daf162fac (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/8f4bc41c4231..a54daf162fac
    
    
    git log 8f4bc41c4231..a54daf162fac --date=short --no-merges --format='%ad %ae %s'
    2018-10-11 benwright@webrtc.org Reland "Move CryptoOptions to api/crypto from rtc_base/sslstreamadapter.h"
    2018-10-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9d052f4b6f..37b6d53f02 (598839:598967)
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@a54daf162fac
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I3d22153c1dd390398aa7dda8a0f8a00d032fc627
    Reviewed-on: https://chromium-review.googlesource.com/c/1278298
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599108}

    Changed files

    • DEPS