Home | Search | chromium - Builders
Login

Builder Lollipop Low-end Tester Build 302 Canonical Ubuntu

Results:

Failure Incorrect or missing bot configuration

Trigger Info:

Projectchromium
Revisionddc0ed5ebee5a6670fe9e1b1fa46993335b79af7

Execution:

Steps and Logfiles:

Show:
  1. ( 344 ms ) setup_build
    running recipe: "chromium"

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm104-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1526675691711270, "id": "8946158225846459104", "project": "chromium", "tags": ["builder:Lollipop Low-end Tester", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7", "gitiles_ref:refs/heads/master", "parent_buildername:Android arm Builder (dbg)", "parent_buildnumber:35102", "scheduler_invocation_id:9111588288061616224", "scheduler_job_id:chromium/Lollipop Low-end Tester", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Lollipop Low-end Tester" setup_build
buildnumber 302 setup_build
mastername "chromium.android.fyi" setup_build
parent_buildername "Android arm Builder (dbg)" setup_build
parent_got_angle_revision "8688bf46f1835dbe7fff4480350b1bc0ef02ff78" setup_build
parent_got_buildtools_revision "94288c26d2ffe3aec9848c147839afee597acefd" setup_build
parent_got_nacl_revision "93deff44b49fcbb4da0ee7961f21b6b93da194e9" setup_build
parent_got_revision "ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7" setup_build
parent_got_revision_cp "refs/heads/master@{#559932}" setup_build
parent_got_swarming_client_revision "833f5ebf894be1e3e6d13678d5de8479bf12ff28" setup_build
parent_got_v8_revision "5a28871f57ec111f18e2f59697d5108806111355" setup_build
parent_got_v8_revision_cp "refs/heads/6.8.252@{#1}" setup_build
parent_got_webrtc_revision "4103b383505575b23222f77fd04116d2f6c10273" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#23301}" setup_build
parent_mastername "chromium.android" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7" setup_build

Blamelist:

  1. liberato@chromium.org (liberatoohnoyoudont@chromium.org)
  2. nednguyen (nednguyenohnoyoudont@google.com)
  3. catapult-chromium-autoroll (catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  4. Shuotao Gao (stgaoohnoyoudont@chromium.org)
  5. Stephen McGruer (smcgruerohnoyoudont@chromium.org)
  6. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
  7. Alexandros Frantzis (alexandros.frantzisohnoyoudont@collabora.com)
  8. Sharon Yang (yangsharonohnoyoudont@google.com)
  9. Philip Jägenstedt (foolipohnoyoudont@chromium.org)
  10. Ian Vollick (vollickohnoyoudont@chromium.org)
  11. Aga Wronska (agawronskaohnoyoudont@chromium.org)
  12. Max Morin (maxmorinohnoyoudont@chromium.org)
  13. Maggie Chen (magchenohnoyoudont@chromium.org)
  14. Tommy C. Li (tommycliohnoyoudont@chromium.org)
  15. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
  16. Danyao Wang (danyaoohnoyoudont@google.com)
  17. Andrew Grieve (agrieveohnoyoudont@chromium.org)
  18. Tom Anderson (thomasandersonohnoyoudont@chromium.org)
  19. Gabriel Charette (gabohnoyoudont@chromium.org)
  20. webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  21. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
  22. John Budorick (jbudorickohnoyoudont@chromium.org)
  23. Ian Clelland (iclellandohnoyoudont@chromium.org)
  24. Nico Weber (thakisohnoyoudont@chromium.org)
  25. Marc Treib (treibohnoyoudont@chromium.org)
  26. Christopher Grant (cjgrantohnoyoudont@chromium.org)
  27. Peng Huang (penghuangohnoyoudont@chromium.org)
  28. angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com (angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  29. Sebastien Marchand (sebmarchandohnoyoudont@chromium.org)
  30. Yuke Liao (liaoyukeohnoyoudont@chromium.org)
  31. Mustaq Ahmed (mustaqohnoyoudont@google.com)
  32. Mohamed Amir Yosef (mamirohnoyoudont@chromium.org)
  33. Lindsay Pasricha (lindsaywohnoyoudont@google.com)
  34. Tom Anderson (thomasandersonohnoyoudont@chromium.org)
  35. v8-autoroll (v8-autorollohnoyoudont@chromium.org)
  36. Mathieu Perreault (mathpohnoyoudont@chromium.org)
  37. Simeon Anfinrud (sanfinohnoyoudont@chromium.org)
  38. Quinten Yearsley (qyearsleyohnoyoudont@chromium.org)
  39. Shakti Sahu (shaktisahuohnoyoudont@chromium.org)
  40. Euisang Lim (eui-sang.limohnoyoudont@samsung.com)
  41. Philip Rogers (pdrohnoyoudont@chromium.org)
  42. Christopher Grant (cjgrantohnoyoudont@chromium.org)
  43. Mattias Nissler (mnisslerohnoyoudont@chromium.org)
  44. Charlie Harrison (csharrisonohnoyoudont@chromium.org)
  45. Hiroki Nakagawa (nhirokiohnoyoudont@chromium.org)
  46. Charlie Andrews (charlieaohnoyoudont@chromium.org)
  47. Yuta Kitamura (yutakohnoyoudont@chromium.org)
  48. Aaron Leventhal (aleventhalohnoyoudont@chromium.org)
  49. Charlie Harrison (csharrisonohnoyoudont@chromium.org)
  50. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  51. Aldo Culquicondor (acondorohnoyoudont@chromium.org)
  52. webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  53. Charlie Harrison (csharrisonohnoyoudont@chromium.org)
  54. skia-chromium-autoroll (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  55. Vadym Doroshenko (dvadymohnoyoudont@chromium.org)
  56. v8-autoroll (v8-autorollohnoyoudont@chromium.org)
  57. Xiyuan Xia (xiyuanohnoyoudont@chromium.org)
  58. Vasilii Sukhanov (vasiliiohnoyoudont@chromium.org)
  59. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
  60. webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  61. Hajime Hoshi (hajimehoshiohnoyoudont@chromium.org)
  62. Philip Rogers (pdrohnoyoudont@chromium.org)
  63. stkhapugin@chromium.org (stkhapuginohnoyoudont@chromium.org)
  64. Philipp Hancke (philipp.hanckeohnoyoudont@googlemail.com)
  65. Maksim Ivanov (emaxxohnoyoudont@chromium.org)
  66. nednguyen (nednguyenohnoyoudont@google.com)
  67. v8-autoroll (v8-autorollohnoyoudont@chromium.org)
  68. Koji Ishii (kojiiohnoyoudont@chromium.org)
  69. Alexander Timin (altiminohnoyoudont@chromium.org)
  70. Robert Ma (robertmaohnoyoudont@chromium.org)
  71. Mirko Bonadei (mbonadeiohnoyoudont@chromium.org)
  72. webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  73. Max Morin (maxmorinohnoyoudont@chromium.org)
  74. Wang Qing (wangqing-hfohnoyoudont@loongson.cn)
  75. Bernhard Bauer (bauerbohnoyoudont@chromium.org)
  76. Yuta Kitamura (yutakohnoyoudont@chromium.org)
  77. Mohamed Amir Yosef (mamirohnoyoudont@chromium.org)
  78. Yuri Wiitala (miuohnoyoudont@chromium.org)
  79. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  80. Ke He (ke.heohnoyoudont@intel.com)
  81. stkhapugin@chromium.org (stkhapuginohnoyoudont@chromium.org)
  82. v8-autoroll (v8-autorollohnoyoudont@chromium.org)
  83. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
  84. Hajime Hoshi (hajimehoshiohnoyoudont@chromium.org)
  85. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  86. Guido Urdaneta (guidouohnoyoudont@chromium.org)
  87. stkhapugin@chromium.org (stkhapuginohnoyoudont@chromium.org)
  88. Lutz Justen (ljustenohnoyoudont@chromium.org)
  89. Henrik Boström (hbosohnoyoudont@chromium.org)
  90. Yoichi Osato (yoichioohnoyoudont@chromium.org)
  91. A Olsen (olsenohnoyoudont@chromium.org)
  92. Ramin Halavati (rhalavatiohnoyoudont@chromium.org)
  93. Fergal Daly (fergalohnoyoudont@chromium.org)
  94. Maksim Sisov (msisovohnoyoudont@igalia.com)
  95. Alexander Hendrich (hendrichohnoyoudont@chromium.org)
  96. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  97. Gyuyoung Kim (gyuyoung.kimohnoyoudont@lge.com)
  98. Matt Falkenhagen (falkenohnoyoudont@chromium.org)
  99. Kent Tamura (tkentohnoyoudont@chromium.org)
  100. Noel Gordon (noelohnoyoudont@chromium.org)
  101. <blame list capped at 100 commits> ()

Timing:

Create Friday, 18-May-18 20:34:51 UTC
Start Friday, 18-May-18 20:38:39 UTC
End Friday, 18-May-18 20:38:52 UTC
Pending 3 mins 47 secs
Execution 13 secs

All Changes:

  1. Pass |have_context| to OnWillDestroyStub.

    Changed by liberato@chromium.org - liberatoohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 17:12:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ddc0ed5ebee5a6670fe9e1b1fa46993335b79af7

    Comments

    Pass |have_context| to OnWillDestroyStub.
    
    Notify the observers whether or not the GL context is current during
    stub destruction.  This allows them to skip any platform GL cleanup
    if there's no context.
    
    Bug: 844500
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: If53d558be84af8cf2758de3fdf77b8f9c475a8ae
    Reviewed-on: https://chromium-review.googlesource.com/1060279
    Commit-Queue: Frank Liberato <liberato@chromium.org>
    Reviewed-by: Dan Sanders <sandersd@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559932}

    Changed files

    • gpu/ipc/service/command_buffer_stub.cc
    • gpu/ipc/service/command_buffer_stub.h
    • gpu/ipc/service/stream_texture_android.cc
    • gpu/ipc/service/stream_texture_android.h
    • media/gpu/android/command_buffer_stub_wrapper.h
    • media/gpu/android/command_buffer_stub_wrapper_impl.cc
    • media/gpu/android/command_buffer_stub_wrapper_impl.h
    • media/gpu/android/mock_command_buffer_stub_wrapper.cc
    • media/gpu/android/mock_command_buffer_stub_wrapper.h
    • media/gpu/android/texture_pool.cc
    • media/gpu/android/texture_pool.h
    • media/gpu/android/texture_pool_unittest.cc
    • media/gpu/android/video_frame_factory_impl.cc
    • media/gpu/android/video_frame_factory_impl.h
    • media/gpu/command_buffer_helper.cc
    • media/gpu/ipc/service/gpu_video_decode_accelerator.cc
    • media/gpu/ipc/service/gpu_video_decode_accelerator.h
  2. Update swarming dimension of bots on 'Win 7 Perf'

    Changed by nednguyen - nednguyenohnoyoudont@google.com
    Changed at Friday, 18-May-18 17:11:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 25b0480fff787c7b35b297db60239e91bf3e2f07

    Comments

    Update swarming dimension of bots on 'Win 7 Perf'
    
    NOTRY=true  # test through PRESUBMIT
    
    Bug: 842703
    Change-Id: I17b2476e2c3243a99c341a94e66e094b1df5ce85
    Reviewed-on: https://chromium-review.googlesource.com/1066184
    Reviewed-by: Emily Hanley <eyaich@chromium.org>
    Commit-Queue: Ned Nguyen <nednguyen@google.com>
    Cr-Commit-Position: refs/heads/master@{#559931}

    Changed files

    • testing/buildbot/chromium.perf.json
    • tools/perf/core/benchmark_sharding_map.json
    • tools/perf/core/perf_data_generator.py
  3. Roll src/third_party/catapult/ ce9b3742a..e2506237b (1 commit)

    Changed by catapult-chromium-autoroll - catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Friday, 18-May-18 17:09:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 093b42e858ad42434e45da4c195f5acb4e6899a0

    Comments

    Roll src/third_party/catapult/ ce9b3742a..e2506237b (1 commit)
    
    https://chromium.googlesource.com/catapult.git/+log/ce9b3742a10d..e2506237bc2c
    
    $ git log ce9b3742a..e2506237b --date=short --no-merges --format='%ad %ae %s'
    2018-05-18 simonhatch Dashboard - Add some more logging in /add_histograms
    
    Created with:
      roll-dep src/third_party/catapult
    
    
    The AutoRoll server is located here: https://catapult-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=sullivan@chromium.org
    
    Change-Id: Ic9c1f693f648a5abf193aafb370ce6d61a88d424
    Reviewed-on: https://chromium-review.googlesource.com/1066175
    Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#559930}

    Changed files

    • DEPS
  4. Revert "Delete HeadlessBrowserContext::Observer::OnChildContentsCreated."

    Changed by Shuotao Gao - stgaoohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 17:06:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 171ecd1ad92d18a8e1c15ba531a4eee6fb07d939

    Comments

    Revert "Delete HeadlessBrowserContext::Observer::OnChildContentsCreated."
    
    This reverts commit 888c9108f752de46db58bb32f8b425478cfcb16a.
    
    Reason for revert:
    This is the only relavant CL in the regression range of flaky test VirtualTimeObserverTest.RunAsyncTest in headless_browsertests as shown below.
    
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/69109
    
    https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyowELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJtY2hyb21pdW0ud2luL1dpbjcgVGVzdHMgKGRiZykoMSkvNjkxMDkvaGVhZGxlc3NfYnJvd3NlcnRlc3RzL1ZtbHlkSFZoYkZScGJXVlBZbk5sY25abGNsUmxjM1F1VW5WdVFYTjVibU5VWlhOMAwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM
    
    Original change's description:
    > Delete HeadlessBrowserContext::Observer::OnChildContentsCreated.
    > 
    > This isn't used.
    > 
    > Change-Id: Id61efee5ce35617c6ab65c6c19a059b36323176f
    > Reviewed-on: https://chromium-review.googlesource.com/1065076
    > Reviewed-by: Alex Clarke <alexclarke@chromium.org>
    > Commit-Queue: Johannes Henkel <johannes@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#559821}
    
    TBR=caseq@chromium.org,alexclarke@chromium.org,eseckler@chromium.org,johannes@chromium.org
    
    Change-Id: Ic63ea8788412e76018baac752d20e34d1a9d7d85
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/1066330
    Reviewed-by: Shuotao Gao <stgao@chromium.org>
    Commit-Queue: Shuotao Gao <stgao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559929}

    Changed files

    • headless/lib/browser/headless_browser_context_impl.cc
    • headless/lib/browser/headless_browser_context_impl.h
    • headless/lib/browser/headless_web_contents_impl.cc
    • headless/lib/headless_web_contents_browsertest.cc
    • headless/public/headless_browser_context.h
  5. Update unittests to use '%23' instead of '#' in data URIs

    Changed by Stephen McGruer - smcgruerohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 17:04:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1eb762aafda9c46b404b961effc7acacca8ebdd0

    Comments

    Update unittests to use '%23' instead of '#' in data URIs
    
    This is a (very) partial reland of
    https://chromium-review.googlesource.com/c/chromium/src/+/738395,
    restoring only the changes to applicable unittests. This should be safe
    since '%23' always has been a correct encoding of '#' and so should work
    with the data URI code as it is today. It will also make any future
    re-land of the core original CL easier.
    
    Some unittests from the original CL were excluded, as the changes made
    to them relied on the underlying behavior change.
    
    TBR: pfeldman@chromium.org, thakis@chromium.org, ellyjones@chromium.org
    Bug: 123004
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Change-Id: I816fd90d744a1e12e2d9a8d6d0298834b55f2e57
    Reviewed-on: https://chromium-review.googlesource.com/1062190
    Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
    Reviewed-by: David Benjamin <davidben@chromium.org>
    Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559928}

    Changed files

    • chrome/browser/resources/chromeos/chromevox/testing/common.js
    • chrome/renderer/autofill/password_generation_test_utils.cc
    • chrome/renderer/safe_browsing/threat_dom_details_browsertest.cc
    • content/browser/accessibility/accessibility_action_browsertest.cc
    • content/browser/accessibility/accessibility_win_browsertest.cc
    • content/browser/devtools/protocol/devtools_protocol_browsertest.cc
    • content/browser/renderer_host/input/composited_scrolling_browsertest.cc
    • content/browser/renderer_host/input/touch_input_browsertest.cc
    • content/browser/renderer_host/input/wheel_scroll_latching_browsertest.cc
    • content/browser/renderer_host/render_widget_host_view_browsertest.cc
    • content/public/test/render_view_test.cc
    • ios/net/protocol_handler_util_unittest.mm
  6. [Android] Add support for null spans to SpanApplier

    Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 16:55:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 408ec9e22429827b3b5628a710560baf7e4c7cf1

    Comments

    [Android] Add support for null spans to SpanApplier
    
    This CL modifies SpanApplier so it allows null Span objects in SpanInfo.
    When SpanInfo has a null Span, SpanApplier will just remove start and
    end tags of this SpanInfo from the input string.
    
    Bug: 814728
    Change-Id: Ia9c87f8f695ab79ad70bcbcc7cb7a94642c85085
    Reviewed-on: https://chromium-review.googlesource.com/1066131
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559927}

    Changed files

    • ui/android/java/src/org/chromium/ui/text/SpanApplier.java
    • ui/android/junit/src/org/chromium/ui/text/SpanApplierTest.java
  7. viz: Use overlay plane fences in GLRenderer

    Changed by Alexandros Frantzis - alexandros.frantzisohnoyoudont@collabora.com
    Changed at Friday, 18-May-18 16:53:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f51ce08314c75a60f99eea9af9b76254606616c3

    Comments

    viz: Use overlay plane fences in GLRenderer
    
    Create GpuFences for surfaces used as overlays, and pass them to the
    ScheduleOverlayPlane call in GLRenderer.
    
    The command-line flag --use-gpu-fences-for-overlay-planes, which
    controls the use of plane fences on the service side, is also consulted
    before creating the client-side fences in this patch to avoid creating
    fences when not needed.
    
    Bug: 828393
    Test: Chrome on Ozone-DRM with the --use-gpu-fences-for-overlay-planes flag
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Ibee2b4272a0db19722664947d93eb4d193900ea4
    Reviewed-on: https://chromium-review.googlesource.com/1021694
    Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559926}

    Changed files

    • android_webview/browser/parent_output_surface.cc
    • android_webview/browser/parent_output_surface.h
    • cc/output/overlay_candidate.cc
    • cc/output/overlay_candidate.h
    • cc/test/pixel_test_output_surface.cc
    • cc/test/pixel_test_output_surface.h
    • components/viz/service/display/direct_renderer.cc
    • components/viz/service/display/gl_renderer.cc
    • components/viz/service/display/gl_renderer_unittest.cc
    • components/viz/service/display/output_surface.h
    • components/viz/service/display/overlay_unittest.cc
    • components/viz/service/display_embedder/gl_output_surface.cc
    • components/viz/service/display_embedder/gl_output_surface.h
    • components/viz/service/display_embedder/skia_output_surface_impl.cc
    • components/viz/service/display_embedder/skia_output_surface_impl.h
    • components/viz/service/display_embedder/software_output_surface.cc
    • components/viz/service/display_embedder/software_output_surface.h
    • components/viz/test/fake_output_surface.cc
    • components/viz/test/fake_output_surface.h
    • content/browser/compositor/gpu_browser_compositor_output_surface.cc
    • content/browser/compositor/gpu_browser_compositor_output_surface.h
    • content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc
    • content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h
    • content/browser/compositor/offscreen_browser_compositor_output_surface.cc
    • content/browser/compositor/offscreen_browser_compositor_output_surface.h
    • content/browser/compositor/reflector_impl_unittest.cc
    • content/browser/compositor/software_browser_compositor_output_surface.cc
    • content/browser/compositor/software_browser_compositor_output_surface.h
    • content/browser/renderer_host/compositor_impl_android.cc
    • content/renderer/android/synchronous_layer_tree_frame_sink.cc
    • ui/compositor/test/in_process_context_factory.cc
  8. Add more proto fields for notification UKM collection.

    Changed by Sharon Yang - yangsharonohnoyoudont@google.com
    Changed at Friday, 18-May-18 16:49:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d817469566a20179ecaa1b563f79ad895fa6d84e

    Comments

    Add more proto fields for notification UKM collection.
    
    Added more proto fields to facilitate future collecting of UKM. We are adding
    them as proto fields so the information we want to collect can be written to the
    database and we can avoid storing the information in memory unnecessarily.
    
    This is part of a series of CLs to add UKM for notifications.
    
    Existing unit tests and related methods were updated with the new fields.
    
    Bug: 842622
    Change-Id: Ic2d04b8b9bfdc724f4fa7bc5d3c549b243357077
    Reviewed-on: https://chromium-review.googlesource.com/1059287
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Anita Woodruff <awdf@chromium.org>
    Commit-Queue: Sharon Yang <yangsharon@google.com>
    Cr-Commit-Position: refs/heads/master@{#559925}

    Changed files

    • content/browser/notifications/notification_database_data.proto
    • content/browser/notifications/notification_database_data_conversions.cc
    • content/browser/notifications/notification_database_data_unittest.cc
    • content/public/browser/notification_database_data.h
  9. Sync LayoutTests/resources/ with LayoutTests/external/wpt/resources/

    Changed by Philip Jägenstedt - foolipohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 16:48:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e832355cf4019319cb55bebd11fa6533ec5a5143

    Comments

    Sync LayoutTests/resources/ with LayoutTests/external/wpt/resources/
    
    Roll in the most recent version of:
    testharness.js, testdriver.js, idlharness.js and webidl2.js
    
    Trailing whitespace in webidl2.js is removed to pass presubmit.
    This means it is not 100% in sync with upstream.
    
    Bug: 685854
    Change-Id: Iac8177bd995eb13d545796ef91e1075692db70f0
    Reviewed-on: https://chromium-review.googlesource.com/1059152
    Reviewed-by: Robert Ma <robertma@chromium.org>
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Commit-Queue: Robert Ma <robertma@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559924}

    Changed files

    • third_party/WebKit/LayoutTests/fast/dom/custom/svg-use-shadow-tree-expected.txt
    • third_party/WebKit/LayoutTests/resources/idlharness.js
    • third_party/WebKit/LayoutTests/resources/testdriver.js
    • third_party/WebKit/LayoutTests/resources/testharness.js
    • third_party/WebKit/LayoutTests/resources/webidl2.js
    • third_party/WebKit/LayoutTests/webaudio/audio-worklet/audio-worklet-node-idl-expected.txt
    • third_party/WebKit/LayoutTests/webaudio/audio-worklet/audio-worklet-node-idl.html
  10. Hook up ARCoreDevice to real ARCore binaries

    Changed by Ian Vollick - vollickohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 16:47:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1cfbf9f53aa4eba9ed7fbbbc58e149667a463778

    Comments

    Hook up ARCoreDevice to real ARCore binaries
    
    This hooks up the stub ARCoreDevice code with
    the real ARCore libraries so that AR
    is actually functional and generates proper
    poses and camera frames.
    
    Bug: 837116,837947,841555
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
    Change-Id: I78ae38aaa577899f392e058bf0e36d5b34d7147d
    Reviewed-on: https://chromium-review.googlesource.com/1020199
    Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org>
    Reviewed-by: Tao Bai <michaelbai@chromium.org>
    Reviewed-by: Biao She <bshe@chromium.org>
    Reviewed-by: Ian Vollick <vollick@chromium.org>
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Reviewed-by: David Dorwin <ddorwin@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Bill Orr <billorr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559923}

    Changed files

    • chrome/android/chrome_public_apk_tmpl.gni
    • chrome/android/java/AndroidManifest.xml
    • chrome/android/java/src/org/chromium/chrome/browser/vr/ArCoreJavaUtils.java
    • chrome/android/java_sources.gni
    • chrome/app/android/DEPS
    • chrome/browser/android/vr/BUILD.gn
    • chrome/browser/android/vr/arcore_device/DEPS
    • chrome/browser/android/vr/arcore_device/ar_image_transport.cc
    • chrome/browser/android/vr/arcore_device/ar_image_transport.h
    • chrome/browser/android/vr/arcore_device/arcore.h
    • chrome/browser/android/vr/arcore_device/arcore_device.cc
    • chrome/browser/android/vr/arcore_device/arcore_device.h
    • chrome/browser/android/vr/arcore_device/arcore_gl.cc
    • chrome/browser/android/vr/arcore_device/arcore_gl.h
    • chrome/browser/android/vr/arcore_device/arcore_gl_thread.cc
    • chrome/browser/android/vr/arcore_device/arcore_gl_thread.h
    • chrome/browser/android/vr/arcore_device/arcore_impl.cc
    • chrome/browser/android/vr/arcore_device/arcore_impl.h
    • chrome/browser/android/vr/arcore_device/arcore_interface.h
    • chrome/browser/android/vr/arcore_device/arcore_java_utils.cc
    • chrome/browser/android/vr/arcore_device/arcore_java_utils.h
    • chrome/browser/android/vr/arcore_device/arcore_shim.cc
    • chrome/browser/android/vr/arcore_device/arcore_shim.h
    • chrome/browser/android/vr/arcore_device/fake_arcore.cc
    • chrome/browser/android/vr/arcore_device/fake_arcore.h
    • chrome/browser/android/vr/vr_shell_delegate.cc
    • chrome/browser/vr/service/vr_device_manager.cc
    • chrome/browser/vr/testapp/vr_testapp.cc
    • device/vr/BUILD.gn
    • device/vr/buildflags/BUILD.gn
    • device/vr/buildflags/buildflags.gni
    • device/vr/vr_display_impl.cc
    • third_party/arcore-android-sdk/README.chromium
    • third_party/blink/renderer/modules/xr/xr_frame_provider.cc
  11. Update shelf visibility when display configuration changes.

    Changed by Aga Wronska - agawronskaohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 16:45:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8af5e106aa826f15b44303af358312d3a7e35c96

    Comments

    Update shelf visibility when display configuration changes.
    
    Shelf is supposed to be hidden on secondary diaplay on lock and login
    screens. To reporduce the bug external display needs to be set as primary
    screen and then attached while on lock screen. In that case external
    monitor is first added as secondary and later set as primary. Shelf
    visibility was not updated for the new secondary disply after the primary
    display was changed.
    
    Similar bug was also present for login screen. To fix it removing the early
    return from ShelfLayoutManager::UpdateVisibilityState was needed. The issue
    that required early return is already fixed.
    
    Bug: 824504
    Change-Id: I2e3b8e9d6427e3496e72651ba4be1bab538fe25c
    Reviewed-on: https://chromium-review.googlesource.com/1052488
    Commit-Queue: Aga Wronska <agawronska@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559922}

    Changed files

    • ash/shelf/shelf_controller.cc
    • ash/shelf/shelf_layout_manager.cc
    • ash/shelf/shelf_layout_manager.h
    • ash/shelf/shelf_unittest.cc
  12. Clean up audio service state in the destructor.

    Changed by Max Morin - maxmorinohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 16:43:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a3eb7fef083ca5d5a5ea8dd874c162ccace18e66

    Comments

    Clean up audio service state in the destructor.
    
    Looks like we aren't sure OnServiceManagerConnectionLost() is called, so
    stop threads and such in the destructor instead.
    
    Bug: 844419
    Change-Id: Ib038f8cec2ce17816f7f63d4c2971af1fd951a47
    Reviewed-on: https://chromium-review.googlesource.com/1065677
    Reviewed-by: Olga Sharonova <olka@chromium.org>
    Commit-Queue: Olga Sharonova <olka@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559921}

    Changed files

    • services/audio/service.cc
    • services/audio/service.h
  13. Added |is_protected_video| to YUV video draw quad and DC layer overlay.

    Changed by Maggie Chen - magchenohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 16:43:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3691b153cfd5b24821a19fe153ba9854cf8e69a6

    Comments

    Added |is_protected_video| to YUV video draw quad and DC layer overlay.
    
    This CL creates a new key PROTECTED_VIDEO for the video frame metadata. In YUV DrawQuad, this info
    will be retrieved from the metadata and saved in DCLayerOverlay and then passed down to the GPU
    process through GL command buffer in GLRenderer gl_->ScheduleDCLayerCHROMIUM.
    
    This CL is part of the implementation for supporting protected video encoding in Windows. When
    is_protected_video is true, the video content should be protected by hardware until it is displayed.
    
    BUG=843814
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: If732e263dcbcbafa0c66577939e35c2738d772f6
    Reviewed-on: https://chromium-review.googlesource.com/1056262
    Reviewed-by: Zhenyao Mo <zmo@chromium.org>
    Reviewed-by: Frank Liberato <liberato@chromium.org>
    Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Maggie Chen <magchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559920}

    Changed files

    • cc/resources/video_resource_updater.cc
    • components/viz/common/quads/draw_quad_unittest.cc
    • components/viz/common/quads/yuv_video_draw_quad.cc
    • components/viz/common/quads/yuv_video_draw_quad.h
    • components/viz/service/display/dc_layer_overlay.cc
    • components/viz/service/display/dc_layer_overlay.h
    • components/viz/service/display/gl_renderer.cc
    • media/base/video_frame_metadata.h
    • services/viz/public/cpp/compositing/quads_struct_traits.cc
    • services/viz/public/cpp/compositing/quads_struct_traits.h
    • services/viz/public/cpp/compositing/struct_traits_unittest.cc
    • services/viz/public/interfaces/compositing/quads.mojom
  14. Omnibox UI: Clean up OmniboxClient API a bit.

    Changed by Tommy C. Li - tommycliohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 16:42:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 169388e6f4eec7db5886a4e33c6ecac8d3880a3b

    Comments

    Omnibox UI: Clean up OmniboxClient API a bit.
    
    Remove an unused parameter and some no-op IOS overrides.
    
    This is a CL to clean up the API in preparation for potentially
    changing the meaning of IsPopupOpen for the Material Refresh UI.
    
    Bug: 823535
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Change-Id: I10638a3bc873448f49961c705157e541257adfa4
    Reviewed-on: https://chromium-review.googlesource.com/1065022
    Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
    Commit-Queue: Tommy Li <tommycli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559919}

    Changed files

    • chrome/browser/ui/omnibox/chrome_omnibox_client.cc
    • chrome/browser/ui/omnibox/chrome_omnibox_client.h
    • components/omnibox/browser/omnibox_client.h
    • components/omnibox/browser/omnibox_edit_model.cc
    • ios/chrome/browser/ui/omnibox/chrome_omnibox_client_ios.h
    • ios/chrome/browser/ui/omnibox/chrome_omnibox_client_ios.mm
  15. WebManifest: move manifest_share_target_util to blink

    Changed by Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 16:37:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 76953b5c495871be689a97885447d26ffdfa96fb

    Comments

    WebManifest: move manifest_share_target_util to blink
    
    This is a part of moving manifest implementation to blink.
    These util functions will be used from blink and chrome, so
    their final destination is blink/public/common.
    
    Bug: 704441
    Change-Id: I6b1bb93e602bf7cccf067994d16d5aeae32f985a
    Reviewed-on: https://chromium-review.googlesource.com/1054608
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Matt Giuca <mgiuca@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559918}

    Changed files

    • chrome/browser/webshare/share_service_impl.cc
    • content/public/common/BUILD.gn
    • content/public/common/manifest_share_target_util.h
    • content/renderer/manifest/manifest_parser.cc
    • content/test/BUILD.gn
    • third_party/blink/common/BUILD.gn
    • third_party/blink/common/manifest/manifest_share_target_util.cc
    • third_party/blink/common/manifest/manifest_share_target_util_unittest.cc
    • third_party/blink/public/common/BUILD.gn
    • third_party/blink/public/common/manifest/manifest_share_target_util.h
  16. [Nav Experiment] No need to handle cancelled error.

    Changed by Danyao Wang - danyaoohnoyoudont@google.com
    Changed at Friday, 18-May-18 16:31:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7e3f29a34181f6413b5495c023c7593231672095

    Comments

    [Nav Experiment] No need to handle cancelled error.
    
    |handleCancelledError| currently reloads the last committed item if
    the current provisional navigation is cancelled. This is not needed with
    WKBasedNavigation because WKWebView will take care of restoring the last
    committed state.
    
    This explicit load is the cause of disappearing forward-history when
    user taps on "back" in rapid succession. Each tap starts a new
    navigation that is immediately cancelled by the subsequent navigation.
    At the end of the chain, when the last committed item is loaded (NTP),
    it causes forward history to be lost.
    
    Bug: 841747
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I612a403ac1a7fbe40ea00196aafa2492a3345ce0
    Reviewed-on: https://chromium-review.googlesource.com/1065052
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559917}

    Changed files

    • ios/web/web_state/ui/crw_web_controller.mm
  17. GN: Add "python_library" template for group()s that use ".pydeps"

    Changed by Andrew Grieve - agrieveohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 16:17:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a7f1ee90249c022de2b5d441bb1e1a3f8c0ecdd7

    Comments

    GN: Add "python_library" template for group()s that use ".pydeps"
    
    Also adds two new usages of it:
      //build/android:resource_sizes_py
      //tools/binary_size:binary_size_trybot_py
    
    Bug: 702625
    Change-Id: Idc8113ca5e95ec9b5f5ff0cf22c14eeab95b78f8
    Reviewed-on: https://chromium-review.googlesource.com/1058836
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Reviewed-by: Helen Li <xunjieli@chromium.org>
    Reviewed-by: Peter Wen <wnwen@chromium.org>
    Commit-Queue: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559916}

    Changed files

    • BUILD.gn
    • OWNERS
    • PRESUBMIT.py
    • build/android/BUILD.gn
    • build/android/resource_sizes.pydeps
    • build/config/python.gni
    • build/secondary/third_party/android_platform/development/scripts/BUILD.gn
    • chrome/test/chromedriver/BUILD.gn
    • net/tools/testserver/BUILD.gn
    • tools/binary_size/BUILD.gn
    • tools/binary_size/supersize.pydeps
  18. Don't pass undefined variables to not_needed

    Changed by Tom Anderson - thomasandersonohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 16:12:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c94b10c2de375975782d27769efbb8447d5c25e2

    Comments

    Don't pass undefined variables to not_needed
    
    CL [1] makes passing undefined variables to not_needed an error (it woudld
    previously crash on ToT gn).
    
    This CL avoids passing undefined variables to not_needed and instead marks all
    variables not needed using "*".
    
    [1] https://chromium-review.googlesource.com/c/chromium/src/+/1063118
    
    R=dpranke
    CC=thakis
    
    Change-Id: I96590488e01917709694480cf20d4c998a5b5172
    Reviewed-on: https://chromium-review.googlesource.com/1063170
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559915}

    Changed files

    • testing/libfuzzer/fuzzer_test.gni
  19. [MessageLoop cleanup] Remove unused MessageLoopCurrent::QuitWhenIdleClosure method

    Changed by Gabriel Charette - gabohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 16:04:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5110d6ba39549b71be178fb0e72b0577e9cfa716

    Comments

    [MessageLoop cleanup] Remove unused MessageLoopCurrent::QuitWhenIdleClosure method
    
    I realized @ https://chromium-review.googlesource.com/c/chromium/src/+/1055729/1/PRESUBMIT.py#416
    that I should really complete the migration off
    MessageLoop::QuitWhenIdleClosure and then further realized it should
    really be coalesced with similar RunLoop helpers (already covered in
    presubmit by "RunLoop::QuitCurrent*").
    This is the last CL to make that so.
    
    R=danakj@chromium.org, dpranke@chromium.org, kylechar@chromium.org
    
    Bug: 825327
    Change-Id: Id0fa7ca441b60e90b4ebadfa7fc705690a4aecba
    Reviewed-on: https://chromium-review.googlesource.com/1055891
    Commit-Queue: Gabriel Charette <gab@chromium.org>
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Reviewed-by: kylechar <kylechar@chromium.org>
    Reviewed-by: danakj <danakj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559914}

    Changed files

    • PRESUBMIT.py
    • base/message_loop/message_loop_current.cc
    • base/message_loop/message_loop_current.h
  20. Roll src/third_party/webrtc/ a6ccd25ee..4103b3835 (1 commit)

    Changed by webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com - webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Friday, 18-May-18 16:04:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e75d3fde57a240c2393fb7026a0105c71343219c

    Comments

    Roll src/third_party/webrtc/ a6ccd25ee..4103b3835 (1 commit)
    
    https://webrtc.googlesource.com/src.git/+log/a6ccd25eea6e..4103b3835055
    
    $ git log a6ccd25ee..4103b3835 --date=short --no-merges --format='%ad %ae %s'
    
    Created with:
      roll-dep src/third_party/webrtc
    
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I9d0e03e4cd2bc4cb224f94aea94b97e69f8d0622
    Reviewed-on: https://chromium-review.googlesource.com/1065805
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#559913}

    Changed files

    • DEPS
  21. Blink: remove PlatformFrameView and simplify PlatformChromeClient

    Changed by Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 16:03:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4b3682f34d6f60c39f53b84745549eb701bf25bd

    Comments

    Blink: remove PlatformFrameView and simplify PlatformChromeClient
    
    Most of this stuff is unused.
    
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
    Change-Id: Ifd45c91b507d100e6703f93ed9dbe569c44dd127
    Reviewed-on: https://chromium-review.googlesource.com/1065141
    Reviewed-by: Jeremy Roman <jbroman@chromium.org>
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559912}

    Changed files

    • third_party/blink/renderer/core/exported/web_page_popup_impl.cc
    • third_party/blink/renderer/core/frame/local_frame_view.cc
    • third_party/blink/renderer/core/frame/local_frame_view.h
    • third_party/blink/renderer/core/frame/local_frame_view_test.cc
    • third_party/blink/renderer/core/frame/visual_viewport.cc
    • third_party/blink/renderer/core/inspector/dev_tools_host.cc
    • third_party/blink/renderer/core/layout/layout_theme.h
    • third_party/blink/renderer/core/layout/layout_theme_default.cc
    • third_party/blink/renderer/core/layout/layout_theme_default.h
    • third_party/blink/renderer/core/layout/layout_theme_mac.h
    • third_party/blink/renderer/core/layout/layout_theme_mac.mm
    • third_party/blink/renderer/core/layout/text_autosizer_test.cc
    • third_party/blink/renderer/core/loader/empty_clients.h
    • third_party/blink/renderer/core/page/chrome_client.h
    • third_party/blink/renderer/core/page/chrome_client_impl.cc
    • third_party/blink/renderer/core/page/chrome_client_impl.h
    • third_party/blink/renderer/core/page/validation_message_overlay_delegate.cc
    • third_party/blink/renderer/core/paint/object_paint_invalidator.cc
    • third_party/blink/renderer/core/paint/paint_invalidator.cc
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
    • third_party/blink/renderer/core/svg/graphics/svg_image_chrome_client.cc
    • third_party/blink/renderer/core/svg/graphics/svg_image_chrome_client.h
    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/platform_chrome_client.h
    • third_party/blink/renderer/platform/platform_frame_view.h
    • third_party/blink/renderer/platform/scroll/scrollbar_test_suite.h
  22. Remove compile+test+luci configs for Linux Xenial buildbot.

    Changed by John Budorick - jbudorickohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 16:01:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2e9231cbbe7d585075ad0e54f4c7798d7849e30b

    Comments

    Remove compile+test+luci configs for Linux Xenial buildbot.
    
    Moved to luci. Also added compile config for linux-xenial-rel
    trybot.
    
    Bug: 812051
    Change-Id: I861172d85d9df1149e1a0e2a36e4e0da43b5b952
    Reviewed-on: https://chromium-review.googlesource.com/1066150
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Reviewed-by: Ben Pastene <bpastene@chromium.org>
    Commit-Queue: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559911}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
    • infra/config/global/luci-milo-dev.cfg
    • infra/config/global/luci-milo.cfg
    • infra/config/global/luci-scheduler.cfg
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/test_suite_exceptions.pyl
    • testing/buildbot/waterfalls.pyl
    • tools/mb/mb_config.pyl
  23. Remove TopNavByUserActivationInSandbox flag

    Changed by Ian Clelland - iclellandohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 15:59:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f026b32c7de27d0b4dee0098c227c44eba5530c5

    Comments

    Remove TopNavByUserActivationInSandbox flag
    
    The feature has been shipped as stable since Chrome 58. A previous commit
    removed some of the calls to test the state of this flag; this one removes the
    last call, and the feature from the JSON5 file.
    
    Change-Id: Iad96a7dc80696b665e6ae6e0c10af6427f90b5ca
    Reviewed-on: https://chromium-review.googlesource.com/1005617
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Ian Clelland <iclelland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559910}

    Changed files

    • third_party/blink/renderer/core/frame/sandbox_flags.cc
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  24. Disable MachOImageAnnotationsReader.CrashModuleInitialization under ASan.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 15:58:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f11ad6a3e4af5133c6aa410889d197cad912f738

    Comments

    Disable MachOImageAnnotationsReader.CrashModuleInitialization under ASan.
    
    Bug: 844396
    Change-Id: I830b2f7696ea3f388d77e8b53debe2635ebb7232
    Reviewed-on: https://chromium-review.googlesource.com/1065459
    Reviewed-by: Robert Sesek <rsesek@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559909}

    Changed files

    • third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc
  25. ProfileSyncService: Move access token handling into SyncAuthManager

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 15:58:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 938887e6d723ecc8ad4c6699630176c0ef258cc0

    Comments

    ProfileSyncService: Move access token handling into SyncAuthManager
    
    Followup to https://crrev.com/c/1057508
    
    Bug: 842697
    Change-Id: Iec5b08efccf62427b4e1069ea829c7fadad02deb
    Reviewed-on: https://chromium-review.googlesource.com/1064062
    Commit-Queue: Marc Treib <treib@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559908}

    Changed files

    • components/browser_sync/profile_sync_service.cc
    • components/browser_sync/profile_sync_service.h
    • components/browser_sync/sync_auth_manager.cc
    • components/browser_sync/sync_auth_manager.h
  26. VR: Set overflow menu to contain scoped standalone items

    Changed by Christopher Grant - cjgrantohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 15:53:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 921f8053e88090665b146cf7b8227150c17eb43b

    Comments

    VR: Set overflow menu to contain scoped standalone items
    
    BUG=
    
    Change-Id: I42a71dbc8cc6225d534f4b61a1d66eb3a37796b6
    Reviewed-on: https://chromium-review.googlesource.com/1064853
    Reviewed-by: Biao She <bshe@chromium.org>
    Commit-Queue: Christopher Grant <cjgrant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559907}

    Changed files

    • chrome/browser/vr/ui_scene_creator.cc
  27. Turn on presentation callback for all platforms.

    Changed by Peng Huang - penghuangohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 15:50:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 606ca80576f7bae148673c3622c4fe2b0ebb0f40

    Comments

    Turn on presentation callback for all platforms.
    
    This CL also removes the --enale-presentation-callback flag, helper
    method and UpdateVSyncParameters related methods and IPC.
    
    Bug: 776877
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I54a26e725853d3ee3a962a12985c639bf2f2cea4
    Reviewed-on: https://chromium-review.googlesource.com/1064599
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Commit-Queue: Peng Huang <penghuang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559906}

    Changed files

    • ash/metrics/time_to_first_present_recorder.cc
    • chrome/browser/ui/ash/time_to_first_present_recorder_browsertest.cc
    • components/viz/service/display_embedder/skia_output_surface_impl.cc
    • components/viz/service/display_embedder/skia_output_surface_impl.h
    • components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
    • components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.h
    • gpu/ipc/client/command_buffer_proxy_impl.cc
    • gpu/ipc/client/command_buffer_proxy_impl.h
    • gpu/ipc/in_process_command_buffer.cc
    • gpu/ipc/in_process_command_buffer.h
    • gpu/ipc/service/direct_composition_surface_win_unittest.cc
    • gpu/ipc/service/gles2_command_buffer_stub.cc
    • gpu/ipc/service/gles2_command_buffer_stub.h
    • gpu/ipc/service/gpu_vsync_provider_unittest_win.cc
    • gpu/ipc/service/image_transport_surface_delegate.h
    • gpu/ipc/service/pass_through_image_transport_surface.cc
    • gpu/ipc/service/pass_through_image_transport_surface.h
    • ui/gl/BUILD.gn
    • ui/gl/gl_switches.cc
    • ui/gl/gl_switches.h
    • ui/gl/gl_switches_util.cc
    • ui/gl/gl_switches_util.h
  28. Roll src/third_party/angle/ 4607148c6..8688bf46f (1 commit)

    Changed by angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com - angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Friday, 18-May-18 15:44:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eff610c98b7cf3359d1fbfd27f32b76a70285728

    Comments

    Roll src/third_party/angle/ 4607148c6..8688bf46f (1 commit)
    
    https://chromium.googlesource.com/angle/angle.git/+log/4607148c6be3..8688bf46f183
    
    $ git log 4607148c6..8688bf46f --date=short --no-merges --format='%ad %ae %s'
    2018-05-18 lucferron Vulkan: readPixels improvement - use DynamicBuffer
    
    Created with:
      roll-dep src/third_party/angle
    
    
    The AutoRoll server is located here: https://angle-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=ynovikov@chromium.org
    
    Change-Id: Iae7e298a9a36e3cc167a7ded5fb81880f88d6c2b
    Reviewed-on: https://chromium-review.googlesource.com/1066172
    Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#559905}

    Changed files

    • DEPS
  29. Site Characteristics DB: Move the I/O ops to a blocking TaskRunner.

    Changed by Sebastien Marchand - sebmarchandohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 15:41:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 390e0bdb5e0f68135e273ad81594c752b4d34fe5

    Comments

    Site Characteristics DB: Move the I/O ops to a blocking TaskRunner.
    
    Bug: 773382
    Change-Id: I4c89b6b6706a7bffba19122447ea6b1a31095afc
    Reviewed-on: https://chromium-review.googlesource.com/1059697
    Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
    Reviewed-by: François Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559904}

    Changed files

    • chrome/browser/resource_coordinator/leveldb_site_characteristics_database.cc
    • chrome/browser/resource_coordinator/leveldb_site_characteristics_database.h
    • chrome/browser/resource_coordinator/leveldb_site_characteristics_database_unittest.cc
    • chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc
    • chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
    • chrome/browser/resource_coordinator/local_site_characteristics_data_impl_unittest.cc
    • chrome/browser/resource_coordinator/local_site_characteristics_data_store.cc
    • chrome/browser/resource_coordinator/local_site_characteristics_data_store_unittest.cc
    • chrome/browser/resource_coordinator/local_site_characteristics_data_unittest_utils.cc
    • chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store_unittest.cc
  30. Coverage: Add an argument to allow specify coverage tools to use.

    Changed by Yuke Liao - liaoyukeohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 15:40:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 082e996347bbe484ec2d90dba33e996a1a662bc0

    Comments

    Coverage: Add an argument to allow specify coverage tools to use.
    
    This CL adds an argument to allow specify coverage tools to use, and
    one use case is for testing the code coverage script against clang
    coverage tools tot.
    
    Bug: 821840
    Change-Id: I2ecbd425ed1dcd8494e2e89963bc763505e19a11
    Reviewed-on: https://chromium-review.googlesource.com/1064602
    Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
    Reviewed-by: Max Moroz <mmoroz@chromium.org>
    Reviewed-by: Abhishek Arya <inferno@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559903}

    Changed files

    • tools/code_coverage/coverage.py
  31. ChromeClientImpl calls UserGestureIndicator methods directly.

    Changed by Mustaq Ahmed - mustaqohnoyoudont@google.com
    Changed at Friday, 18-May-18 15:34:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2ffe87bb9aa46aa792e6446a48d3a8ca28d53536

    Comments

    ChromeClientImpl calls UserGestureIndicator methods directly.
    
    Bug: 781328
    Change-Id: If1cb265cf1dfcf4ef2fffe4cd67741ed177ae1be
    Reviewed-on: https://chromium-review.googlesource.com/1062768
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559902}

    Changed files

    • third_party/blink/public/web/web_user_gesture_indicator.h
    • third_party/blink/renderer/core/exported/web_user_gesture_indicator.cc
    • third_party/blink/renderer/core/page/chrome_client_impl.cc
  32. [Sync::USS] Implement remote deletion of bookmarks

    Changed by Mohamed Amir Yosef - mamirohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 15:32:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b289511b5bcb90c423a291687cacc20d221c86b6

    Comments

    [Sync::USS] Implement remote deletion of bookmarks
    
    This CL implements the remote deletion of an existing bookmark
    coming from the server.
    
    Bug: 516866
    Change-Id: I6ec845e4154505a804eb38f1ae6ddb374937254f
    Reviewed-on: https://chromium-review.googlesource.com/1052687
    Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559901}

    Changed files

    • chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc
    • components/sync_bookmarks/bookmark_model_type_processor.cc
    • components/sync_bookmarks/bookmark_model_type_processor.h
    • components/sync_bookmarks/bookmark_model_type_processor_unittest.cc
    • components/sync_bookmarks/synced_bookmark_tracker.cc
    • components/sync_bookmarks/synced_bookmark_tracker.h
    • components/sync_bookmarks/synced_bookmark_tracker_unittest.cc
  33. Rename upstream fyi bot ios-webview to ios11-beta-simulator.

    Changed by Lindsay Pasricha - lindsaywohnoyoudont@google.com
    Changed at Friday, 18-May-18 15:32:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cf09347e46f55c5cf1e2e45aff5ef59602bf87ad

    Comments

    Rename upstream fyi bot ios-webview to ios11-beta-simulator.
    
    Adds ios11-beta-simulato.json. ios-webview.json will be
    deleted in a following CL.
    
    Bug: 830810
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Change-Id: I4ffa40c24532bd2d66ce60721f0be95fdd3aad08
    Reviewed-on: https://chromium-review.googlesource.com/1060654
    Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559900}

    Changed files

    • ios/build/bots/chromium.fyi/ios11-beta-simulator.json
  34. Fix gn CHECK()ing on not_needed() when given undefined identifiers

    Changed by Tom Anderson - thomasandersonohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 15:26:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4497a44f0d8236cb069ed89c013154c1adfc2087

    Comments

    Fix gn CHECK()ing on not_needed() when given undefined identifiers
    
    GN now gives an error message that looks like:
    
    ERROR at //BUILD.gn:76:23: Undefined identifier
      not_needed(["deps", "deps_____________"])
                          ^------------------
    
    R=dpranke
    
    Change-Id: Ic55afef672a7aefab7934875ceb22aff52b68f94
    Reviewed-on: https://chromium-review.googlesource.com/1063118
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559899}

    Changed files

    • tools/gn/functions.cc
  35. Update V8 to version 6.8.252.

    Changed by v8-autoroll - v8-autorollohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 15:19:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a14f7a5748af68f8d7bb625493d29f0d8d01bb6e

    Comments

    Update V8 to version 6.8.252.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/1caa6178..5a28871f
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org
    
    Change-Id: I735e302b8e84c44eed6ad67c59db6570e9cccad6
    Reviewed-on: https://chromium-review.googlesource.com/1065460
    Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
    Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559898}

    Changed files

    • DEPS
  36. [Histograms page] Import histograms before querying for them.

    Changed by Mathieu Perreault - mathpohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 15:17:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f8af727643a16136e731c3d0eeab8b78a3023b60

    Comments

    [Histograms page] Import histograms before querying for them.
    
    Without this function, only a partial list is returned.
    
    Bug: 844341, 844121
    Change-Id: I45fa43a68e899cce2b14b7b1f75e6edd5c48a146
    Reviewed-on: https://chromium-review.googlesource.com/1065462
    Reviewed-by: Dan Erat <derat@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559897}

    Changed files

    • content/browser/histograms_internals_ui.cc
  37. [Chromecast] Allow removing observers from Observables.

    Changed by Simeon Anfinrud - sanfinohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 15:14:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eb9f60d092af8ebfdce0a6e507bb7509460b1b2b

    Comments

    [Chromecast] Allow removing observers from Observables.
    
    To remove an observer created by a watch() call, the result of
    the watch() call should be stored, and close()d when observation
    is no longer needed.
    
    This implies that the registration of observers is itself a part
    of program state. Which means that we can represent it with
    Observables. Which means some unexpectedly powerful options open
    up for composing events.
    
    Namely, if the span of a program in which a given ScopeFactory
    is observing a state is itself a state, then we can use currying
    instead of and() to watch the intersection of multiple states.
    
        stateA.and(stateB).watch(ScopeFactories.both((a, b) -> ...))
    
    ... can be replaced by:
    
        stateA.watch(a -> stateB.watch(b -> ...))
    
    But even aside from this horrifyingly elegant tool for
    composition, this simplifies the implementation of new
    Observables while adding the ability to unregister observers.
    
    Bug: None
    Test: cast_base_junit_tests, cast_shell_junit_tests
    Change-Id: Ie92672c2ea242a09b2cbbf710f8fbb744c0e8e33
    Reviewed-on: https://chromium-review.googlesource.com/981602
    Reviewed-by: Luke Halliwell <halliwell@chromium.org>
    Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559896}

    Changed files

    • chromecast/base/java/src/org/chromium/chromecast/base/Controller.java
    • chromecast/base/java/src/org/chromium/chromecast/base/Observable.java
    • chromecast/base/java/test/org/chromium/chromecast/base/ObservableAndControllerTest.java
    • chromecast/base/java/test/org/chromium/chromecast/base/ScopeFactoriesTest.java
    • chromecast/base/reactive_java.md
    • chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWebContentsActivity.java
    • chromecast/browser/android/junit/src/org/chromium/chromecast/shell/CastWebContentsSurfaceHelperTest.java
  38. [blinkpy] Update blinkpy style checker, resolving TODO

    Changed by Quinten Yearsley - qyearsleyohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 15:12:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4423675f89b0a44d8f9286a31fc40b34512802a3

    Comments

    [blinkpy] Update blinkpy style checker, resolving TODO
    
    There are now no Python scripts without the .py extension,
    thanks to Kent's renaming during the scripts migration.
    
    Change-Id: I32c36c37221fffa9c1d11178f31a9581c211c4e5
    Reviewed-on: https://chromium-review.googlesource.com/1065079
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559895}

    Changed files

    • third_party/blink/tools/blinkpy/style/checker.py
    • third_party/blink/tools/blinkpy/style/checker_unittest.py
  39. Download Infobar : Show IPH

    Changed by Shakti Sahu - shaktisahuohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 15:06:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dd0f00b919e8fd932c2b63871463ffbc17194d1d

    Comments

    Download Infobar : Show IPH
    
    Added two IPH for the accelerated infobar
    1 - When infobar is closed, IPH would show up with message "Your download is still running"
    2 - When the infobar starts up, IPH would show up with message "Chrome now downloads files faster"
    
    Bug: 844201
    Change-Id: Id1ccde95e0175ce285c29f033b0bf23996433f7d
    Reviewed-on: https://chromium-review.googlesource.com/1054157
    Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Reviewed-by: David Trainor <dtrainor@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559894}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfoBarController.java
    • chrome/android/java/src/org/chromium/chrome/browser/infobar/IPHBubbleDelegateImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/infobar/IPHInfoBarSupport.java
    • chrome/android/java/strings/android_chrome_strings.grd
    • components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/FeatureConstants.java
    • components/feature_engagement/public/feature_constants.cc
    • components/feature_engagement/public/feature_constants.h
    • components/feature_engagement/public/feature_list.cc
    • components/feature_engagement/public/feature_list.h
    • testing/variations/fieldtrial_testing_config.json
    • tools/metrics/histograms/histograms.xml
  40. [WebUI] Change the background color for Web UI pages

    Changed by Euisang Lim - eui-sang.limohnoyoudont@samsung.com
    Changed at Friday, 18-May-18 14:57:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 311cb1b4bd88be4517d3734f117a0b74edd1bd7c

    Comments

    [WebUI] Change the background color for Web UI pages
    
    Change the background color for Web UI pages(Settings, Extensions,
    History, Bookmarks, Downloads) from #F1F1F1 to #F8F9FA(GG50)
    for MD Refresh.
    
    Change the background-color of each files of Settings, Extensions,
    and Downloads.
    
    Change --md-background-color in ui/webui for History and Bookmarks
    which use var(--md-background-color).
    
    Bug: 841839
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: Ib6eeb53f38e385f1de617e5eaba83e8325d7119a
    Reviewed-on: https://chromium-review.googlesource.com/1055029
    Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559893}

    Changed files

    • chrome/browser/resources/md_downloads/downloads.html
    • chrome/browser/resources/md_extensions/extensions.html
    • chrome/browser/resources/settings/settings.html
    • ui/webui/resources/css/md_colors.css
  41. [BlinkGenPropertyTrees] Mark tile-occlusion-boundaries.html as failing

    Changed by Philip Rogers - pdrohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 14:55:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d5c7eab4bf9e9c72815f5eebb7a10936228786ef

    Comments

    [BlinkGenPropertyTrees] Mark tile-occlusion-boundaries.html as failing
    
    This patch updates the test expectations for
    --enable-blink-gen-property-trees to mark
    compositing/culling/tile-occlusion-boundaries.html as failing
    
    TBR=trchen@chromium.org
    
    Bug: 844429
    Change-Id: I6759ae25407cfaee1f4ce510077b8c6ce1e96905
    Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees
    Reviewed-on: https://chromium-review.googlesource.com/1065806
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Commit-Queue: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559892}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
  42. VR: Move the loading progress bar into content

    Changed by Christopher Grant - cjgrantohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 14:54:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 628d7b3174d205db77c6efcdb0c63003932e9100

    Comments

    VR: Move the loading progress bar into content
    
    BUG=837331
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
    Change-Id: I3fd41598ec541a9ccd2fd72d53cc99b6cebb5718
    Reviewed-on: https://chromium-review.googlesource.com/1055906
    Reviewed-by: Ian Vollick <vollick@chromium.org>
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Commit-Queue: Christopher Grant <cjgrant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559891}

    Changed files

    • chrome/browser/vr/elements/content_element.cc
    • chrome/browser/vr/elements/content_element.h
    • chrome/browser/vr/model/color_scheme.cc
    • chrome/browser/vr/ui_scene_constants.h
    • chrome/browser/vr/ui_scene_creator.cc
    • chrome/browser/vr/ui_unittest.cc
  43. Force offline login for missing cryptohomes.

    Changed by Mattias Nissler - mnisslerohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 14:51:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 947d259b32f20e6444984d082547741148ea0738

    Comments

    Force offline login for missing cryptohomes.
    
    Add an AuthState code that indicates offline login failed due to the
    cryptohome being missing from disk. Handle this state by switching to
    online login for the user.
    
    BUG=chromium:469990
    TEST=unit tests
    
    Change-Id: I8a96c96366d3e836648fc254dd3bea80393fd405
    Reviewed-on: https://chromium-review.googlesource.com/1065871
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Commit-Queue: Mattias Nissler <mnissler@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559890}

    Changed files

    • chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
    • chrome/browser/chromeos/login/existing_user_controller.cc
    • chrome/browser/chromeos/login/existing_user_controller.h
    • chromeos/login/auth/auth_status_consumer.h
    • chromeos/login/auth/cryptohome_authenticator.cc
    • chromeos/login/auth/cryptohome_authenticator.h
  44. Add presubmit to ensure ruleset version for perf benchmarks is up to date

    Changed by Charlie Harrison - csharrisonohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 14:45:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 20917d71479d5412c846c554c6b4da37196acd88

    Comments

    Add presubmit to ensure ruleset version for perf benchmarks is up to date
    
    This will ensure that updates to the ruleset format version are
    propagated to tools/perf/core/default_local_state.json.
    
    An alternative would be to add a compile step which generates this file,
    but since it is updated so infrequently, a presubmit seems like a fine
    solution.
    
    Note: This presubmit does _not_ guard against the case when
    default_local_state.json changes but the indexed ruleset version does
    not. That should really never happen though.
    
    Bug: 823982
    Change-Id: I3c64047a66a24e8cceb61b8acd45a5bce9168e0d
    Reviewed-on: https://chromium-review.googlesource.com/1064507
    Reviewed-by: Josh Karlin <jkarlin@chromium.org>
    Commit-Queue: Charlie Harrison <csharrison@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559889}

    Changed files

    • components/subresource_filter/core/common/PRESUBMIT.py
  45. Worker: Add credentials tests for dedicated workers

    Changed by Hiroki Nakagawa - nhirokiohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 14:44:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f844404708be03a8bff069cf742cf43024a78420

    Comments

    Worker: Add credentials tests for dedicated workers
    
    This CL adds web-platform-tests for the "credentials" option of WorkerOptions:
    https://html.spec.whatwg.org/multipage/workers.html#workeroptions
    
    The current spec defines that the default value of this option is "omit", but
    there is an ongoing spec discussion to change it to "same-origin":
    https://github.com/whatwg/html/pull/3656
    
    This CL adds the tests based on the current spec, and a subsequent CL will
    update them based on the decision.
    
    Bug: 843875
    Change-Id: I50eb0c7971587b9d84865498d67abef8ed2d8fc6
    Reviewed-on: https://chromium-review.googlesource.com/1063524
    Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559888}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/workers/modules/dedicated-worker-options-credentials.html
    • third_party/WebKit/LayoutTests/external/wpt/workers/modules/dedicated-worker-options-credentials.html.headers
    • third_party/WebKit/LayoutTests/external/wpt/workers/modules/resources/credentials.py
  46. Add a new doc on how to launch a functional bisect and interpet results

    Changed by Charlie Andrews - charlieaohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 14:38:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fd35b20e4389fa63c77f823b250950122c2c84d1

    Comments

    Add a new doc on how to launch a functional bisect and interpet results
    
    R=eyaich@chromium.org
    
    Bug: 842232
    Change-Id: I97320db313f78da70ecb9ca4dc1a55ce7ffc19e5
    Reviewed-on: https://chromium-review.googlesource.com/1062833
    Commit-Queue: Charlie Andrews <charliea@chromium.org>
    Reviewed-by: Emily Hanley <eyaich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559887}

    Changed files

    • docs/speed/bot_health_sheriffing/how_to_launch_a_functional_bisect.md
    • docs/speed/bot_health_sheriffing/images/flakiness_flaky_test.png
    • docs/speed/bot_health_sheriffing/images/flakiness_flaky_test_good_bad_revisions.png
    • docs/speed/bot_health_sheriffing/images/flakiness_revision_bad.png
    • docs/speed/bot_health_sheriffing/images/flakiness_revision_good.png
    • docs/speed/bot_health_sheriffing/images/flakiness_simple.png
    • docs/speed/bot_health_sheriffing/images/perf_dashboard_graph.png
    • docs/speed/bot_health_sheriffing/images/perf_dashboard_revision.png
    • docs/speed/bot_health_sheriffing/images/perf_dashboard_start_bisect.png
    • docs/speed/bot_health_sheriffing/images/pinpoint_bug_comment.png
    • docs/speed/bot_health_sheriffing/images/pinpoint_graph.png
    • docs/speed/bot_health_sheriffing/images/pinpoint_run_info.png
    • docs/speed/bot_health_sheriffing/images/pinpoint_run_info_logs.png
  47. Move WebThreadScheduler::{Add,Remove}TaskObserver() to ThreadScheduler.

    Changed by Yuta Kitamura - yutakohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 14:33:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 06d3b4517b9c527cf598ed3c6e2fb08456629acd

    Comments

    Move WebThreadScheduler::{Add,Remove}TaskObserver() to ThreadScheduler.
    
    Those functions are not used by any Chromium (non-Blink) code, thus they
    should not be exposed via Web interfaces.
    
    This patch moves the functions to ThreadScheduler, which is the right
    home for this kind of functions. As WebThreadScheduler and
    ThreadScheduler's interfaces are implemented by the same concrete
    class, the amount of the code changes are kept minimum.
    
    Bug: 826203
    Change-Id: Ifcbad156a7e3a2788294681ca544afdcba7faabd
    Reviewed-on: https://chromium-review.googlesource.com/1065555
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Yuta Kitamura <yutak@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559886}

    Changed files

    • third_party/blink/public/platform/scheduler/test/fake_renderer_scheduler.h
    • third_party/blink/public/platform/scheduler/web_thread_scheduler.h
    • third_party/blink/renderer/core/dom/idle_deadline_test.cc
    • third_party/blink/renderer/core/dom/scripted_idle_task_controller_test.cc
    • third_party/blink/renderer/platform/scheduler/public/thread_scheduler.h
    • third_party/blink/renderer/platform/scheduler/test/fake_renderer_scheduler.cc
  48. Do not expose IA2 text attribute default values

    Changed by Aaron Leventhal - aleventhalohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 14:33:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c2877c98e39bbc16e943a4c199ada9a2e7c616c8

    Comments

    Do not expose IA2 text attribute default values
    
    According to the IA2 spec here:
    https://wiki.linuxfoundation.org/accessibility/iaccessible2/textattributes
    "If an attribute is not specified and if the table shows that there is a default value, the default value should be assumed."
    
    This makes the a11y tree less noisy, smaller and easier to debug, and is similar to how Firefox works.
    
    Bug: 844147
    Change-Id: I1c4578abc84097f0fc5e9624d9020ad20276bffc
    Reviewed-on: https://chromium-review.googlesource.com/1064850
    Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559885}

    Changed files

    • content/browser/accessibility/browser_accessibility_com_win.cc
    • content/browser/accessibility/browser_accessibility_win_unittest.cc
    • content/test/data/accessibility/aria/aria-invalid-expected-win.txt
    • content/test/data/accessibility/css/font-style-expected-win.txt
    • content/test/data/accessibility/html/b-expected-blink.txt
    • content/test/data/accessibility/html/b-expected-win.txt
    • content/test/data/accessibility/html/b.html
  49. Add jkarlin to subresource_filter OWNERS and add COMPONENT

    Changed by Charlie Harrison - csharrisonohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 14:29:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b92710d35c21e169caeb377d9b1fefdb96ecbb0a

    Comments

    Add jkarlin to subresource_filter OWNERS and add COMPONENT
    
    Bug: None
    Change-Id: Ie4a9dbb1f740156d3848957d40c1b4e74dca49ae
    Reviewed-on: https://chromium-review.googlesource.com/1064854
    Reviewed-by: Josh Karlin <jkarlin@chromium.org>
    Commit-Queue: Charlie Harrison <csharrison@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559884}

    Changed files

    • chrome/browser/subresource_filter/OWNERS
    • components/subresource_filter/OWNERS
  50. Fix label preferred width for Tools Menu

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 14:23:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fd3815c607559cb5b8472f40c6ae3b1a3678e896

    Comments

    Fix label preferred width for Tools Menu
    
    This CL fixes a bug where the height of a Tools Menu cell was too tall
    compared to what was needed. It was happening because the preferred
    width of the label wasn't reset when the cell was reused.
    So if a cell which was having a label was reused, the max width for the
    new title was smaller than what it should have been. Then the title was
    displayed on two lines instead of one, creating a visible jump in the
    collection.
    This was because the table view was using autolayout to determine the
    height of the cells. This CL fixes it by explicitly calculating the
    height of the cells.
    
    Bug: 837624
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Iee6d8f282de254aa5e8a6e663ac5068721c4b142
    Reviewed-on: https://chromium-review.googlesource.com/1064056
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559883}

    Changed files

    • ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
  51. VR: Updating transform during layout instead of input handling.

    Changed by Aldo Culquicondor - acondorohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 14:00:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 380dd88fca1dbbbfd9183f60fbc499685d65db71

    Comments

    VR: Updating transform during layout instead of input handling.
    
    It came to vollick@ realization that we were handling the transform
    inappropriately.
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
    Change-Id: I5b33dbfc52296e51fcccb4fc2508b9912f20202f
    Reviewed-on: https://chromium-review.googlesource.com/1064503
    Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
    Reviewed-by: Ian Vollick <vollick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559882}

    Changed files

    • chrome/browser/vr/elements/scrollable_element.cc
  52. Roll src/third_party/webrtc/ 460f53bb8..a6ccd25ee (4 commits)

    Changed by webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com - webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Friday, 18-May-18 14:00:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 76021332f36b5820b8efa4fe2ea19d7558a34bef

    Comments

    Roll src/third_party/webrtc/ 460f53bb8..a6ccd25ee (4 commits)
    
    https://webrtc.googlesource.com/src.git/+log/460f53bb860e..a6ccd25eea6e
    
    $ git log 460f53bb8..a6ccd25ee --date=short --no-merges --format='%ad %ae %s'
    
    Created with:
      roll-dep src/third_party/webrtc
    
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: If0b89de91ddc7be513320cc0e5f7c2ac9ec095d4
    Reviewed-on: https://chromium-review.googlesource.com/1065801
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#559881}

    Changed files

    • DEPS
  53. [subresource_filter] Move ukm recording out of page_load_metrics

    Changed by Charlie Harrison - csharrisonohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 13:39:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1bf776b86d79c44b7d5ea62dea005bff5d58152a

    Comments

    [subresource_filter] Move ukm recording out of page_load_metrics
    
    Bug: 843832
    Change-Id: Ic9364d956486268a07189b4cb8e3c5ad0f62ea55
    Reviewed-on: https://chromium-review.googlesource.com/1062825
    Reviewed-by: Steven Holte <holte@chromium.org>
    Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
    Commit-Queue: Charlie Harrison <csharrison@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559880}

    Changed files

    • chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc
    • chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h
    • chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
    • components/subresource_filter/content/browser/BUILD.gn
    • components/subresource_filter/content/browser/DEPS
    • components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc
    • components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc
  54. Roll src/third_party/skia/ 44890ef00..50edafacc (1 commit)

    Changed by skia-chromium-autoroll - skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Friday, 18-May-18 13:38:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8768006983f8fccabe692678998eccf73511ad53

    Comments

    Roll src/third_party/skia/ 44890ef00..50edafacc (1 commit)
    
    https://skia.googlesource.com/skia.git/+log/44890ef00dab..50edafacc8ea
    
    $ git log 44890ef00..50edafacc --date=short --no-merges --format='%ad %ae %s'
    2018-05-17 csmartdalton Add proxy unique key management to GrOnFlushResourceProvider
    
    Created with:
      roll-dep src/third_party/skia
    
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=herb@chromium.org
    
    Change-Id: Ied25fe8b0eb992706bee953585c59b3a80b0b2ed
    Reviewed-on: https://chromium-review.googlesource.com/1065796
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#559879}

    Changed files

    • DEPS
  55. Use unique_renderer_id in NewPasswordFormManager::DoesManage

    Changed by Vadym Doroshenko - dvadymohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 13:35:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 892380dd10dbc5c7811e93a6ad78ace9b4261515

    Comments

    Use unique_renderer_id in NewPasswordFormManager::DoesManage
    
    Bug: 831123
    Change-Id: Idb6795108e78445e983dd64f13ad571171f0510e
    Reviewed-on: https://chromium-review.googlesource.com/1064115
    Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
    Reviewed-by: Vaclav Brozek <vabr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559878}

    Changed files

    • components/autofill/core/common/form_data.cc
    • components/password_manager/core/browser/new_password_form_manager.cc
    • components/password_manager/core/browser/new_password_form_manager_unittest.cc
  56. Update V8 to version 6.8.250.

    Changed by v8-autoroll - v8-autorollohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 13:35:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99ccd902420c934bf6440c35044ea36408ceb73a

    Comments

    Update V8 to version 6.8.250.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/31ea99d8..1caa6178
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org
    
    Change-Id: I2845e3801b7f9a6a654c550c7830cdbc2e2de2b7
    Reviewed-on: https://chromium-review.googlesource.com/1065458
    Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
    Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559877}

    Changed files

    • DEPS
  57. ash: Delegate interface for ArcNotificationManager

    Changed by Xiyuan Xia - xiyuanohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 13:32:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e16a11d919e8558943b50fbf5500526d275577e

    Comments

    ash: Delegate interface for ArcNotificationManager
    
    Add an ArcNotificationManagerDelegate interface for arc notification
    code to call ash code without the need to add "nogncheck".
    
    Bug: 768439
    Change-Id: Id0d992539af90cd758a15cdba58aafb73212fb52
    Reviewed-on: https://chromium-review.googlesource.com/1065121
    Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
    Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559876}

    Changed files

    • ash/BUILD.gn
    • ash/message_center/arc_notification_manager_delegate_impl.cc
    • ash/message_center/arc_notification_manager_delegate_impl.h
    • ash/message_center/message_center_controller.cc
    • ash/message_center/message_center_controller.h
    • ash/system/message_center/arc/BUILD.gn
    • ash/system/message_center/arc/arc_notification_manager.cc
    • ash/system/message_center/arc/arc_notification_manager.h
    • ash/system/message_center/arc/arc_notification_manager_delegate.h
    • ash/system/message_center/arc/arc_notification_manager_unittest.cc
  58. Reland: Update PasswordManager when a relevant credential is removed by the user.

    Changed by Vasilii Sukhanov - vasiliiohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 13:23:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1fd384b65ca67a73e6766d754ca9b115d57d3686

    Comments

    Reland: Update PasswordManager when a relevant credential is removed by the user.
    
    Before this CL this behavior is possible:
    - a credential is autofilled.
    - user removes the credential via settings or "Manage passwords" bubble.
    - user clicks "Login" or reloads the page. In other words makes an action that we consider a successful form submission.
    - password manager updates the credential in the store by reviving it.
    
    After this CL the password manager is informed as soon as the password is removed. Thus, the copy of the credential in the memory should go away.
    
    This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1064118
    The reason for original failure was a refetch on adding a credential:
    - A password was generated and added to the store.
    - Refetch was triggered.
    - The generated password was autofilled everywhere including the original field.
    - The password manager wasn't in the generation mode anymore.
    
    Bug: 821763,841853
    Change-Id: Ia0f24ccdf8d53dd0c3c740e9672c291322a5fd63
    Reviewed-on: https://chromium-review.googlesource.com/1065971
    Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
    Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559875}

    Changed files

    • chrome/browser/password_manager/password_manager_browsertest.cc
    • chrome/browser/ui/passwords/manage_passwords_state.cc
    • chrome/browser/ui/passwords/manage_passwords_state.h
  59. Remove dependencies from geometry to transforms

    Changed by Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 13:13:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 846b0f36a36255851b967db1c6ed855cab10c4c9

    Comments

    Remove dependencies from geometry to transforms
    
    - TransformState is moved to transforms;
    - TransformAsJSONArray is moved to transformation_matrix.
    
    This makes geometry <-> transforms dependency acyclic.
    
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
    Change-Id: I967407f1a439b37f768b571033013958b80dc3c8
    Reviewed-on: https://chromium-review.googlesource.com/1062886
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559874}

    Changed files

    • third_party/blink/renderer/core/frame/local_frame_view.cc
    • third_party/blink/renderer/core/layout/layout_box_model_object.cc
    • third_party/blink/renderer/core/layout/layout_geometry_map.cc
    • third_party/blink/renderer/core/layout/layout_inline.cc
    • third_party/blink/renderer/core/layout/layout_object.cc
    • third_party/blink/renderer/core/layout/layout_object.h
    • third_party/blink/renderer/core/layout/layout_table_cell.cc
    • third_party/blink/renderer/core/layout/layout_view.cc
    • third_party/blink/renderer/core/layout/map_coordinates_test.cc
    • third_party/blink/renderer/core/layout/svg/layout_svg_block.cc
    • third_party/blink/renderer/core/layout/svg/svg_layout_support.cc
    • third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
    • third_party/blink/renderer/core/paint/paint_layer.cc
    • third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
    • third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/geometry/DEPS
    • third_party/blink/renderer/platform/geometry/geometry_as_json.cc
    • third_party/blink/renderer/platform/geometry/geometry_as_json.h
    • third_party/blink/renderer/platform/transforms/DEPS
    • third_party/blink/renderer/platform/transforms/transform_state.cc
    • third_party/blink/renderer/platform/transforms/transform_state.h
    • third_party/blink/renderer/platform/transforms/transformation_matrix.cc
    • third_party/blink/renderer/platform/transforms/transformation_matrix.h
  60. Roll src/third_party/webrtc/ 4639d46ea..460f53bb8 (2 commits)

    Changed by webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com - webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Friday, 18-May-18 12:49:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 34692b7952f3d419b91cc8794c6230bc9ed03f85

    Comments

    Roll src/third_party/webrtc/ 4639d46ea..460f53bb8 (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/4639d46eaaa7..460f53bb860e
    
    $ git log 4639d46ea..460f53bb8 --date=short --no-merges --format='%ad %ae %s'
    
    Created with:
      roll-dep src/third_party/webrtc
    BUG=chromium:None
    
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: Ia1a85a40ea898ce72530004f79589b15d7bbe8d9
    Reviewed-on: https://chromium-review.googlesource.com/1065798
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#559873}

    Changed files

    • DEPS
  61. Add TaskType::kMainThreadTaskQueueControl and use it for MainThreadScheduelrImpl::control_task_queue_

    Changed by Hajime Hoshi - hajimehoshiohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 12:43:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 47827ec56830179ce0ccf3be7b7886488555b579

    Comments

    Add TaskType::kMainThreadTaskQueueControl and use it for MainThreadScheduelrImpl::control_task_queue_
    
    This adds TaskType information to post the control task queue usages in
    DeadlineTaskRunner.
    
    For the direct usage of |control_task_queue_| in MainThreadSchedulerImpl,
    the task type is not added yet.
    
    Bug: 841172
    Change-Id: I865336e0fce3988f476aa3bb3651e837d13eddaa
    Reviewed-on: https://chromium-review.googlesource.com/1065951
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559872}

    Changed files

    • third_party/blink/public/platform/task_type.h
    • third_party/blink/renderer/platform/scheduler/child/worker_scheduler.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
    • tools/metrics/histograms/enums.xml
  62. [RLS] Remove unused code in view_painter, ax_object, graphics_layer, and print_context

    Changed by Philip Rogers - pdrohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 12:24:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 40f2b7eb1c85ff9b7c118b004f87aec41816ff99

    Comments

    [RLS] Remove unused code in view_painter, ax_object, graphics_layer, and print_context
    
    Now that Root Layer Scrolling (RLS) is enabled by default, we can remove
    these unused codepaths.
    
    Bug: 823365
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
    Change-Id: I212505daa58d1e723cc51c4c764c08822d01da33
    Reviewed-on: https://chromium-review.googlesource.com/1065119
    Reviewed-by: Steve Kobes <skobes@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559871}

    Changed files

    • third_party/blink/renderer/core/page/print_context.cc
    • third_party/blink/renderer/core/paint/view_painter.cc
    • third_party/blink/renderer/modules/accessibility/ax_object.cc
    • third_party/blink/renderer/platform/graphics/graphics_layer.cc
  63. Cleanup OmniboxContainerView.

    Changed by stkhapugin@chromium.org - stkhapuginohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 12:12:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5d098e8705167bb05e98def1d65941891d83f55a

    Comments

    Cleanup OmniboxContainerView.
    
    Removes unused code from OmniboxContainerView and updates comments.
    
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Change-Id: I107339a8fbab6ea49bf831b4a23ff4346fa69c6d
    Reviewed-on: https://chromium-review.googlesource.com/1061467
    Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559870}

    Changed files

    • ios/chrome/browser/ui/omnibox/omnibox_container_view.h
    • ios/chrome/browser/ui/omnibox/omnibox_container_view.mm
  64. webrtc-internals: fix active connection display

    Changed by Philipp Hancke - philipp.hanckeohnoyoudont@googlemail.com
    Changed at Friday, 18-May-18 12:10:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fd80db4e6b2657e3dd5980002a822489c9dad4de

    Comments

    webrtc-internals: fix active connection display
    
    unlike in getStats, googActiveConnection is a boolean value in
    webrtc-internals
    
    BUG=678292
    
    Change-Id: If0bd555ee9edb20f1a41d5cc23d594c7a46f5c9d
    Reviewed-on: https://chromium-review.googlesource.com/1065872
    Reviewed-by: Henrik Boström <hbos@chromium.org>
    Reviewed-by: Tommi <tommi@chromium.org>
    Commit-Queue: Tommi <tommi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559869}

    Changed files

    • content/browser/resources/media/stats_table.js
  65. UMA for install attributes lock over existing data

    Changed by Maksim Ivanov - emaxxohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 12:01:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0e616467f98dc3bb3214268a4141c29527576fe3

    Comments

    UMA for install attributes lock over existing data
    
    Collect stats for how often is the Chrome OS install attributes lock
    reusing the existing lock (with the same attributes as requested), as
    opposed to a fresh lock with writing the requested attributes.
    
    BUG=chromium:837609
    TEST=Unit tests: unit_tests --gtest_filter=InstallAttributesTest.Lock
    
    Change-Id: I10872202fd9357463b9040720d6008a1ef87e11f
    Reviewed-on: https://chromium-review.googlesource.com/1035264
    Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559868}

    Changed files

    • chrome/browser/chromeos/settings/install_attributes.cc
    • chrome/browser/chromeos/settings/install_attributes_unittest.cc
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
  66. Refactor process_perf_results to separate handling perf dashboard results out from

    Changed by nednguyen - nednguyenohnoyoudont@google.com
    Changed at Friday, 18-May-18 11:54:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ec1e58d7d52c0528d1db3d8beda48cb6bc3389ac

    Comments

    Refactor process_perf_results to separate handling perf dashboard results out from
    handling perf json results
    
    Bug: 842145
    Change-Id: If995ba7d4e50a9bd4284c3b05fd20d4cf05fb67e
    Reviewed-on: https://chromium-review.googlesource.com/1064317
    Reviewed-by: Emily Hanley <eyaich@chromium.org>
    Commit-Queue: Ned Nguyen <nednguyen@google.com>
    Cr-Commit-Position: refs/heads/master@{#559867}

    Changed files

    • tools/perf/process_perf_results.py
  67. Update V8 to version 6.8.249.

    Changed by v8-autoroll - v8-autorollohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 11:49:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f6c805ac460ff4bc601dd8c09c4229deb40f30f8

    Comments

    Update V8 to version 6.8.249.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/9265952a..31ea99d8
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org
    
    Change-Id: Ibb60971ef6c5cb4cfc6b8f358e0de1a61aaaf479
    Reviewed-on: https://chromium-review.googlesource.com/1065522
    Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
    Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559866}

    Changed files

    • DEPS
  68. [auto] Update FlagExpectations for LayoutNG

    Changed by Koji Ishii - kojiiohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 11:47:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8a4c87761b35292f00dccfe2c7cfe681a888ad99

    Comments

    [auto] Update FlagExpectations for LayoutNG
    
    Following bot results are included.
    5566 5571 5581 5586 5588 5592 5595 5603 5608 5613 5614 5616 5622
    
    307 lines were removed and 16 lines were deflaked by consecutive
    results since 5515.
    
    TBR=eae@chromium.org, mstensho@chromium.org
    NOTRY=true
    
    Bug: 591099
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
    Change-Id: Iae42164778b3178a4e2f9b7ec23c71cc9fa0d4f9
    Reviewed-on: https://chromium-review.googlesource.com/1062994
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559865}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
  69. [blink] Update LocalFrame::GetFrameScheduler comment

    Changed by Alexander Timin - altiminohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 11:43:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3b393426db382219f520317fc49c5705a1da9fa7

    Comments

    [blink] Update LocalFrame::GetFrameScheduler comment
    
    R=dcheng@chromium.org,hajimehoshi@chromium.org
    BUG=840934
    
    Change-Id: Id3b0e9ac257f1bc104ff035cbe42e23fdaaa8b66
    Reviewed-on: https://chromium-review.googlesource.com/1064351
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
    Commit-Queue: Alexander Timin <altimin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559864}

    Changed files

    • third_party/blink/renderer/core/frame/local_frame.h
  70. Remove some test expectations for WebCryptoAPI WPT

    Changed by Robert Ma - robertmaohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 11:30:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 911054f7d0f8472be6059cc730e1bf5f593e7010

    Comments

    Remove some test expectations for WebCryptoAPI WPT
    
    These tests are fixed (split) upstream so they no longer timeout.
    https://github.com/w3c/web-platform-tests/pull/11028
    
    Bug: 787971
    Change-Id: I4441a36cc254a1f0069d7d157c8c54d6a33781ad
    Reviewed-on: https://chromium-review.googlesource.com/1065144
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559863}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  71. Fixing rename_dynamic_annotations.sh.

    Changed by Mirko Bonadei - mbonadeiohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 11:25:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c8231dd37ae7da58d03e5cca4d525295cf201c24

    Comments

    Fixing rename_dynamic_annotations.sh.
    
    I forgot to rename some symbols in the script. This CL fixes that.
    
    There is also a change to dynamic_annotations.cc (I'll add a patch
    to apply automatically in a follow-up CL).
    
    TBR=phoglund@chromium.org
    
    Bug: None
    Change-Id: Icde64cf542c160cd7103a335f4b6768c205b2a74
    Reviewed-on: https://chromium-review.googlesource.com/1065873
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559862}

    Changed files

    • third_party/abseil-cpp/absl/base/dynamic_annotations.cc
    • third_party/abseil-cpp/absl/base/dynamic_annotations.h
    • third_party/abseil-cpp/rename_dynamic_annotations.sh
  72. Roll src/third_party/webrtc/ f8d8d6d00..4639d46ea (9 commits)

    Changed by webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com - webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Friday, 18-May-18 11:24:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 56035060edd273dc02a435269e3be77971cc3386

    Comments

    Roll src/third_party/webrtc/ f8d8d6d00..4639d46ea (9 commits)
    
    https://webrtc.googlesource.com/src.git/+log/f8d8d6d00c16..4639d46eaaa7
    
    $ git log f8d8d6d00..4639d46ea --date=short --no-merges --format='%ad %ae %s'
    
    Created with:
      roll-dep src/third_party/webrtc
    BUG=chromium:749664,chromium:None,chromium:755660,chromium:none,chromium:755660
    
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I756a4a2a935296d3c20dd926253dd1517393b4e0
    Reviewed-on: https://chromium-review.googlesource.com/1065795
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#559861}

    Changed files

    • DEPS
  73. Fix Chrome unit tests when using the audio service.

    Changed by Max Morin - maxmorinohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 11:23:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d5dcd11bcb43052b089561a443c8f677ceed692d

    Comments

    Fix Chrome unit tests when using the audio service.
    
    WebContentsImpl accesses ServiceManagerConnection when we're
    toggling muting using the audio service. This is always set
    in production, but in tests we need to make sure that it is
    initialized.
    
    Tbr: markusheintz
    Bug: 843103
    Change-Id: Ief7819edbeed6616e9e7defb5860b422f6862f9b
    Reviewed-on: https://chromium-review.googlesource.com/1062038
    Commit-Queue: Max Morin <maxmorin@chromium.org>
    Reviewed-by: Becca Hughes <beccahughes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559860}

    Changed files

    • chrome/browser/content_settings/sound_content_setting_observer_unittest.cc
    • chrome/browser/media/media_engagement_contents_observer_unittest.cc
  74. Remove noexcept from file "components/search_provider_logos/logo_common.cc".

    Changed by Wang Qing - wangqing-hfohnoyoudont@loongson.cn
    Changed at Friday, 18-May-18 11:20:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 122692ccee62223f266a988c575ae687e3f4c056

    Comments

    Remove noexcept from file "components/search_provider_logos/logo_common.cc".
    
    This fixes the build error with the following message:
    
            ../../components/search_provider_logos/logo_common.cc:17:15: error: function ‘search_provider_logos::LogoMetadata& search_provider_logos::LogoMetadata::operator=(search_provider_logos::LogoMetadata&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’
            LogoMetadata& LogoMetadata::operator=(LogoMetadata&&) noexcept = default;
                       ^
            ../../components/search_provider_logos/logo_common.cc:31:1: error: function ‘search_provider_logos::LogoCallbacks::LogoCallbacks(search_provider_logos::LogoCallbacks&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’
            LogoCallbacks::LogoCallbacks(LogoCallbacks&&) noexcept = default;
            ^
            ../../components/search_provider_logos/logo_common.cc:32:16: error: function ‘search_provider_logos::LogoCallbacks& search_provider_logos::LogoCallbacks::operator=(search_provider_logos::LogoCallbacks&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’
            LogoCallbacks& LogoCallbacks::operator=(LogoCallbacks&&) noexcept = default;
    
    BUG= 844355
    R= bauerb@chromium.org
    
    Change-Id: I084d0d22f8a2cc976f5f8b24a8c623cd38f86876
    Reviewed-on: https://chromium-review.googlesource.com/1065521
    Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
    Commit-Queue: 汪 清 <wangqing-hf@loongson.cn>
    Cr-Commit-Position: refs/heads/master@{#559859}

    Changed files

    • components/search_provider_logos/logo_common.cc
  75. Disable VrShellTransitionTest.testStartActivityTriggersDoff*

    Changed by Bernhard Bauer - bauerbohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 11:03:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 010dc63978edcd6c6cf79d9e5a5acbf01bf7378a

    Comments

    Disable VrShellTransitionTest.testStartActivityTriggersDoff*
    
    Failing on Nougat (e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Nougat%20Phone%20Tester/6317).
    
    TBR: mthiesse@chromium.org
    Bug: 831589
    Change-Id: I46bd2b5c3f9a5d5c08faf8bedc7f5e477fc3be5b
    Reviewed-on: https://chromium-review.googlesource.com/1065813
    Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
    Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559858}

    Changed files

    • chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTransitionTest.java
  76. Add (NonMain)ThreadScheduler::Current().

    Changed by Yuta Kitamura - yutakohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 10:45:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c1ee639a707d712bd40c4c704a6ddd21f6846b7a

    Comments

    Add (NonMain)ThreadScheduler::Current().
    
    The function returns the current thread's instance of ThreadScheduler.
    This is an alias of the "Platform::Current()->CurrentThread()
    ->Scheduler()" idiom which is currently widely used in Blink, and all
    such calls will be replaced with the shorter "ThreadScheduler
    ::Current()" call in the future.
    
    This patch also adds similar NonMainThreadScheduler::Current(), which
    DCHECKs the caller is on the right thread. When we add
    MainThreadScheduler in the future (this is likely to happen), it will
    also have the similar Current() function.
    
    Bug: 826203
    Change-Id: Iaba856ff37cb81a33cbdf4b558764ab5634adf84
    Reviewed-on: https://chromium-review.googlesource.com/1065538
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Yuta Kitamura <yutak@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559857}

    Changed files

    • third_party/blink/renderer/platform/scheduler/BUILD.gn
    • third_party/blink/renderer/platform/scheduler/common/thread_scheduler.cc
    • third_party/blink/renderer/platform/scheduler/public/non_main_thread_scheduler.h
    • third_party/blink/renderer/platform/scheduler/public/thread_scheduler.h
    • third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler.cc
  77. [Sync::USS] Implement remote update of bookmarks

    Changed by Mohamed Amir Yosef - mamirohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 10:37:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 91a96f15d50475e36511ecf5317107d7f0ffb927

    Comments

    [Sync::USS] Implement remote update of bookmarks
    
    This CL implements the remote update of an existing bookmark
    coming from the server.
    
    Bug: 516866
    Change-Id: I7a89fcbd9bf69472d5a381d4d928617b54bed39f
    Reviewed-on: https://chromium-review.googlesource.com/1052227
    Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559856}

    Changed files

    • chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc
    • components/sync_bookmarks/bookmark_model_type_processor.cc
    • components/sync_bookmarks/bookmark_model_type_processor.h
    • components/sync_bookmarks/bookmark_model_type_processor_unittest.cc
    • components/sync_bookmarks/synced_bookmark_tracker.cc
    • components/sync_bookmarks/synced_bookmark_tracker.h
  78. Add trace events to Audio Service loopback stream.

    Changed by Yuri Wiitala - miuohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 10:17:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9c6ea194b927f76ed9d439531b83e036ea9ab287

    Comments

    Add trace events to Audio Service loopback stream.
    
    Bug: 824019
    Change-Id: I94b9c87a355c9abe5064af0c7b73d7bf23e5a1bb
    Reviewed-on: https://chromium-review.googlesource.com/1063371
    Reviewed-by: Max Morin <maxmorin@chromium.org>
    Commit-Queue: Yuri Wiitala <miu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559855}

    Changed files

    • services/audio/loopback_stream.cc
    • services/audio/snooper_node.cc
  79. Perform color property application in CSSProperty classes.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 10:11:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aa59b11a8848c0d13cc156016c4a73ed9057c7f1

    Comments

    Perform color property application in CSSProperty classes.
    
    This applies to:
    
      background-color
      border-bottom-color
      border-left-color
      border-right-color
      border-top-color
      column-rule-color
      outline-color
      text-decoration-color
      -webkit-text-emphasis-color
      -webkit-text-fill-color
      -webkit-text-stroke-color
    
    R=futhark@chromium.org
    
          Style, _except_ background-color which is stored as a StyleColor.
          (I don't yet know why). This is the reason for using the
          custom_apply_args['initial_color'] instead of the regular
          'default_value' defined in CSSProperties.json5.
    
    Note: All of the above properties are stored as a Color+1bit on Computed-
    Bug: 751354
    Change-Id: Icef9c99b3507da88820e4a79d6864f315f8b7136
    Reviewed-on: https://chromium-review.googlesource.com/1061415
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559854}

    Changed files

    • third_party/blink/renderer/build/scripts/core/css/properties/make_css_property_subclasses.py
    • third_party/blink/renderer/build/scripts/core/css/properties/templates/css_property_subclass.cc.tmpl
    • third_party/blink/renderer/build/scripts/make_style_builder.py
    • third_party/blink/renderer/build/scripts/templates/style_builder_functions.cc.tmpl
    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/css/CSSProperties.json5
  80. Add Connector to Service Manager Java APIs

    Changed by Ke He - ke.heohnoyoudont@intel.com
    Changed at Friday, 18-May-18 10:08:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4995fb767fee0cb6896594dfe6dbd2bd6ab2b2d8

    Comments

    Add Connector to Service Manager Java APIs
    
    Add Connector and ServiceManagerConnection classes which expose the ability
    to bind interfaces from other services in the system.
    
    Also add the ConnectorTest.java as a browsertest which use the Connector and
    ServiceManagerConnection to connect the echo service.
    
    BUG=827934
    
    Change-Id: I84addef979c193ecc1bb379dbf8f1be58994aa4e
    Reviewed-on: https://chromium-review.googlesource.com/989839
    Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
    Reviewed-by: Bo <boliu@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Commit-Queue: Ke He <ke.he@intel.com>
    Cr-Commit-Position: refs/heads/master@{#559853}

    Changed files

    • content/common/service_manager/service_manager_connection_impl.cc
    • content/public/android/BUILD.gn
    • content/public/android/java/src/org/chromium/content/common/ServiceManagerConnectionImpl.java
    • content/public/android/java/src/org/chromium/content_public/common/ServiceManagerConnection.java
    • content/public/android/javatests/src/org/chromium/content/common/ServiceManagerConnectionImplTest.java
    • services/service_manager/public/java/BUILD.gn
    • services/service_manager/public/java/src/org/chromium/services/service_manager/Connector.java
  81. Move OmniboxContainerView to i/c/b/ui/omnibox.

    Changed by stkhapugin@chromium.org - stkhapuginohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 10:07:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e3cd7b382b85ac0b3d3f39e51664ad821977ae9

    Comments

    Move OmniboxContainerView to i/c/b/ui/omnibox.
    
    Moves the omnibox container view to the folder where it should be.
    
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Change-Id: Id56806892fef9d1ce5d26bc71469f72736140272
    Reviewed-on: https://chromium-review.googlesource.com/1061193
    Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559852}

    Changed files

    • ios/chrome/browser/ui/location_bar/BUILD.gn
    • ios/chrome/browser/ui/omnibox/BUILD.gn
    • ios/chrome/browser/ui/omnibox/omnibox_container_view.h
    • ios/chrome/browser/ui/omnibox/omnibox_container_view.mm
    • ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm
  82. Update V8 to version 6.8.247.

    Changed by v8-autoroll - v8-autorollohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 10:04:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 610f3d109860c44ee9e8510885779bd081faf23e

    Comments

    Update V8 to version 6.8.247.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/ef1b9aac..9265952a
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org
    
    Change-Id: Ia21bde20eca237e1400c4c55ed0a6c45bd69288b
    Reviewed-on: https://chromium-review.googlesource.com/1065517
    Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
    Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559851}

    Changed files

    • DEPS
  83. FilesApp mountCrostiniContainer add GetSshKeys, MountPath

    Changed by Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 10:00:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 849db4e602539fa048d76266c5a7823f9d8c8208

    Comments

    FilesApp mountCrostiniContainer add GetSshKeys, MountPath
    
    * Add call to CrostiniManager::GetSshKeys to obtain the keys
      required for sshfs.
    * Add call to DiskMountManager::MountPath to invoke sshfs
    * Listen for cros-disks mount event and then call to
      ExternalMountPoints::RegisterFileSystem and add the volume
      to file_manager::VolumeManager.  The mount will then show up
      in FilesApp as a disk volume.
    
    Bug: 834103
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: I6493fce7b469f675c041f1793d5dec9c0e654679
    Reviewed-on: https://chromium-review.googlesource.com/1051425
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Reviewed-by: Sam McNally <sammc@chromium.org>
    Reviewed-by: Naoki Fukino <fukino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559850}

    Changed files

    • chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
    • chrome/browser/chromeos/extensions/file_manager/private_api_misc.h
  84. Use MainThreadSchedulerImpl::DefaultTaskRunner instead of DefaultTaskQueue at WebThreadImplForRendererScheduler

    Changed by Hajime Hoshi - hajimehoshiohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 09:50:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38a1c0c283dbfaab2ef08495710313c71ef091a2

    Comments

    Use MainThreadSchedulerImpl::DefaultTaskRunner instead of DefaultTaskQueue at WebThreadImplForRendererScheduler
    
    Now DefaultTaskRunner() returns TaskQueueWithTaskType, this should be
    used for the task type annotation.
    
    Bug: 841172
    Change-Id: If55175b5083094863f13bca52ae277e164418865
    Reviewed-on: https://chromium-review.googlesource.com/1065534
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559849}

    Changed files

    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
    • third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.cc
  85. Enumerate aliases on CSSPropertyDeclaration.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 09:43:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aae947a01acaf7bce18c309244b64c8ef110a349

    Comments

    Enumerate aliases on CSSPropertyDeclaration.
    
    Currently, property aliases do not appear when enumerating
    CSSPropertyDeclaration. We generate CSSUnresolvedProperty-subclasses
    for alias properties, but these classes do not provide a
    GetJSPropertyName function, hence CSSPropertyDeclaration::
    NamedPropertyEnumerator can't currently know which property names to write.
    
    This patch lifts CSSProperty::GetJSPropertyName/IsEnabled to
    CSSUnresolvedProperty and adds generation of these functions to alias
    properties.
    
    Notes on runtime flags:
    
     * The runtime_flag setting on aliased properties already propagate to the
       alias. (See css_properties.py:expand_aliases).
     * It turns out that we currently have no aliased property with a runtime
       flag. This means IsEnabled-generation is currently unused for aliases.
       I have manually tested a fake alias against a runtime_flag'd property
       to verify that the generated code works.
    
    R=foolip@chromium.org, futhark@chromium.org
    
    Bug: 768917
    Change-Id: Ibde70b71416bdbe792d05cc21f31794f997cb968
    Reviewed-on: https://chromium-review.googlesource.com/1059615
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559848}

    Changed files

    • third_party/WebKit/LayoutTests/animations/animations-parsing-001.html
    • third_party/WebKit/LayoutTests/animations/animations-parsing-002.html
    • third_party/WebKit/LayoutTests/animations/animations-parsing-003.html
    • third_party/WebKit/LayoutTests/animations/animations-parsing-004.html
    • third_party/WebKit/LayoutTests/animations/animations-parsing-005.html
    • third_party/WebKit/LayoutTests/external/wpt/compat/css-style-declaration-alias-enumeration.html
    • third_party/WebKit/LayoutTests/transitions/transitions-parsing-001.html
    • third_party/WebKit/LayoutTests/transitions/transitions-parsing-002.html
    • third_party/WebKit/LayoutTests/transitions/transitions-parsing-003.html
    • third_party/WebKit/LayoutTests/transitions/transitions-parsing-004.html
    • third_party/WebKit/LayoutTests/transitions/transitions-parsing-005.html
    • third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
    • third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt
    • third_party/blink/renderer/build/scripts/core/css/properties/make_css_property_subclasses.py
    • third_party/blink/renderer/build/scripts/core/css/properties/templates/css_property.h.tmpl
    • third_party/blink/renderer/build/scripts/core/css/properties/templates/css_property_subclass.h.tmpl
    • third_party/blink/renderer/build/scripts/core/css/properties/templates/css_unresolved_property.h.tmpl
    • third_party/blink/renderer/core/css/css_style_declaration.cc
  86. Disable flaky WebRtcGetUserMediaBrowserTest.SrcObjectRemoveFirstOfTwoVideoTracks

    Changed by Guido Urdaneta - guidouohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 09:41:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ecd9ac62caf3e846b6aa22d4cf1843565c4c3d7a

    Comments

    Disable flaky WebRtcGetUserMediaBrowserTest.SrcObjectRemoveFirstOfTwoVideoTracks
    
    This is flaking with Leak and Memory Sanitizers.
    
    TBR=hbos@chromium.org
    
    Bug: 843844
    Change-Id: Ide654e740b76e92d63a64850def3bd1e654411f4
    Reviewed-on: https://chromium-review.googlesource.com/1065850
    Reviewed-by: Guido Urdaneta <guidou@chromium.org>
    Reviewed-by: Henrik Boström <hbos@chromium.org>
    Commit-Queue: Guido Urdaneta <guidou@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559847}

    Changed files

    • content/browser/webrtc/webrtc_getusermedia_browsertest.cc
  87. Swap location bar edit view to be OmniboxViewController's view.

    Changed by stkhapugin@chromium.org - stkhapuginohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 09:34:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9d3f32b2142a0b4e32618e4e3d73c2286f165b57

    Comments

    Swap location bar edit view to be OmniboxViewController's view.
    
    Makes OmniboxCoordinator manage a view controller. Exposes this view
    controller for embedding by LocationBarCoordinator. Updates the LBVC to
    use an injectable edit view. Updates LBCoordinator to inject the view.
    
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Change-Id: I9292548e840d3b7ac663bfa953f81b376142d60d
    Reviewed-on: https://chromium-review.googlesource.com/1061113
    Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559846}

    Changed files

    • ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm
    • ios/chrome/browser/ui/location_bar/location_bar_view_controller.h
    • ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm
    • ios/chrome/browser/ui/omnibox/omnibox_coordinator.h
    • ios/chrome/browser/ui/omnibox/omnibox_coordinator.mm
    • ios/chrome/browser/ui/omnibox/omnibox_view_controller.h
    • ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm
  88. Add ComponentActiveDirectoryPolicyService

    Changed by Lutz Justen - ljustenohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 09:33:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9006a26a7e2bd39b5eb9812b7a78b380b076d77e

    Comments

    Add ComponentActiveDirectoryPolicyService
    
    Part 2 of Active Directory extension policy support. This CL adds a
    ComponentActiveDirectoryPolicyService class that is responsible for
    fetching and parsing component policy, performing type conversions and
    validating schema. To fetch policy it uses the ComponentActiveDirectory-
    PolicyRetriever class introduced in part 1. In part 3 this class will be
    hooked up with the ActiveDirectoryPolicyManager instances.
    
    BUG=chromium:784595
    TEST=unit_tests --gtest_filter=ComponentActiveDirectoryPolicyService*
    
    Change-Id: Ib601706c6efdb2017108384687e36fbff7fae98c
    Reviewed-on: https://chromium-review.googlesource.com/1057620
    Reviewed-by: Pavol Marko <pmarko@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Commit-Queue: Lutz Justen <ljusten@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559845}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/policy/component_active_directory_policy_retriever_unittest.cc
    • chrome/browser/chromeos/policy/component_active_directory_policy_service.cc
    • chrome/browser/chromeos/policy/component_active_directory_policy_service.h
    • chrome/browser/chromeos/policy/component_active_directory_policy_service_unittest.cc
    • components/policy/core/common/registry_dict.cc
    • components/policy/core/common/registry_dict.h
  89. Added RTCConfiguration's sdpSemantics to chrome://webrtc-internals.

    Changed by Henrik Boström - hbosohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 09:30:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4b752756a77c801e06f57562f5c4960923050dc2

    Comments

    Added RTCConfiguration's sdpSemantics to chrome://webrtc-internals.
    
    This means
      sdpSemantics: "plan-b" (default behavior)
    or
      sdpSemantics: "unified-plan" (can be explicitly passed in the
                                    RTCPeerConnection configuration)
    
    TBR=hta@chromium.org
    
    Bug: 799030
    Change-Id: I355e6032be21603a9bf58046d51af70f6dd38c9f
    Reviewed-on: https://chromium-review.googlesource.com/1065771
    Reviewed-by: Henrik Boström <hbos@chromium.org>
    Commit-Queue: Henrik Boström <hbos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559844}

    Changed files

    • content/renderer/media/webrtc/peer_connection_tracker.cc
  90. [LayoutNG] Let LayoutText::LocalSelectionRect considering soft linebreak

    Changed by Yoichi Osato - yoichioohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 09:30:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2a3dba74a72ae2da66c541c96495f8993fe2e8f8

    Comments

    [LayoutNG] Let LayoutText::LocalSelectionRect considering soft linebreak
    
    This patch modifies LocalSelectionRect to consider soft linebreak rect
    by unifying rect computing code with NGTextFragmentPainter's.
    This patch settles the unified code onto NGPhysicalTextFragment.
    
    This fixes 3 selection failures:
    paint/selection/text-selection-drag-in-frame-scrolled.html
    paint/selection/text-selection-drag-in-frame.html
    paint/selection/text-selection-drag.html
    
    Bug: 837521
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
    Change-Id: Ic0c5ecf8742577f92c239f430261489d3ff6a756
    Reviewed-on: https://chromium-review.googlesource.com/1063692
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Commit-Queue: Yoichi Osato <yoichio@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559843}

    Changed files

    • third_party/blink/renderer/core/layout/layout_text.cc
    • third_party/blink/renderer/core/layout/layout_text_test.cc
    • third_party/blink/renderer/core/paint/ng/ng_paint_fragment.cc
    • third_party/blink/renderer/core/paint/ng/ng_paint_fragment.h
    • third_party/blink/renderer/core/paint/ng/ng_text_fragment_painter.cc
  91. Preserve indentation in policy_templates.json

    Changed by A Olsen - olsenohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 09:26:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 52b0e8f4b55a3230a437f8e441a269724891a0bc

    Comments

    Preserve indentation in policy_templates.json
    
    Currently all leading spaces are stripped from the policy description
    text - this leads to hard-to-read JSON examples. This change keeps
    the indentation that is useful to users, but strips the common 6-space
    indentation that is there only to make policy_templates.json itself
    more readable.
    
    See bug for screenshot of this change.
    
    Bug: 843934
    Change-Id: Ic8efe2cb48421fd035470d57c8c1a3c90f69f792
    Reviewed-on: https://chromium-review.googlesource.com/1063831
    Commit-Queue: A Olsen <olsen@chromium.org>
    Reviewed-by: Lutz Justen <ljusten@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559842}

    Changed files

    • components/policy/tools/template_writers/policy_template_generator.py
    • components/policy/tools/template_writers/policy_template_generator_unittest.py
  92. Fix clang tools running script's non-posix compile command split.

    Changed by Ramin Halavati - rhalavatiohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 09:11:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7fc661d8418106f9e13d53b1c929edb4af046204

    Comments

    Fix clang tools running script's non-posix compile command split.
    
    tools/clang/scripts/run_tool.py does not consider non-posix requirements
    when splitting the compile command on Windows. This is fixed.
    
    Change-Id: I0d0829373c4cc9cdc703a1660224a52ba129e11c
    Reviewed-on: https://chromium-review.googlesource.com/1059108
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559841}

    Changed files

    • tools/clang/scripts/run_tool.py
  93. CSS: No-op, convert Invalidate.* to void.

    Changed by Fergal Daly - fergalohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 09:11:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4cd55c1ec2bc62a458f8db5200cef5eb2cefed05

    Comments

    CSS: No-op, convert Invalidate.* to void.
    
    Currently these return bool but nothing makes use of this returned
    value.
    
    Change-Id: I3e467455fd42479ac48857ec4956305234036bd0
    Reviewed-on: https://chromium-review.googlesource.com/1061713
    Commit-Queue: Fergal Daly <fergal@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559840}

    Changed files

    • third_party/blink/renderer/core/css/invalidation/style_invalidator.cc
    • third_party/blink/renderer/core/css/invalidation/style_invalidator.h
  94. [ozone/platform/wayland] Call OnNativeWidgetDestroying on destruction.

    Changed by Maksim Sisov - msisovohnoyoudont@igalia.com
    Changed at Friday, 18-May-18 09:10:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 54fd69310e96d63efdbde3d77c8fe0b31eae46c9

    Comments

    [ozone/platform/wayland] Call OnNativeWidgetDestroying on destruction.
    
    DesktopWindowTreeHostPlatform must notify native widget delegate
    about destruction. This allows to properly release resources,
    and fixes a AccessebilityChecker in browser_tests.
    
    Bug: 578890
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I316fda5a2b2f35c865e192fc12274bc57cc2f1bf
    Reviewed-on: https://chromium-review.googlesource.com/1059208
    Commit-Queue: Maksim Sisov <msisov@igalia.com>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559839}

    Changed files

    • components/viz/service/display_embedder/software_output_device_ozone_unittest.cc
    • gpu/ipc/service/direct_composition_surface_win_unittest.cc
    • services/ui/ws/platform_display_default.cc
    • services/ui/ws/platform_display_default.h
    • services/ui/ws/platform_display_mirror.cc
    • services/ui/ws/platform_display_mirror.h
    • ui/aura/window_tree_host_platform.cc
    • ui/aura/window_tree_host_platform.h
    • ui/compositor/test/test_compositor_host_ozone.cc
    • ui/gl/gl_surface_egl_unittest.cc
    • ui/ozone/demo/demo_window.cc
    • ui/ozone/demo/demo_window.h
    • ui/ozone/platform/wayland/wayland_window.cc
    • ui/ozone/platform/wayland/wayland_window_unittest.cc
    • ui/ozone/test/mock_platform_window_delegate.h
    • ui/platform_window/platform_window_delegate.h
    • ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc
    • ui/views/widget/desktop_aura/desktop_window_tree_host_platform.h
  95. Support multiple filters for the same pattern in 'AutoSelectCertificateForUrls'

    Changed by Alexander Hendrich - hendrichohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 08:21:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bcf2616e8eb74191a038c9ad457344fa0354f420

    Comments

    Support multiple filters for the same pattern in 'AutoSelectCertificateForUrls'
    
    Update the client certificate auto-selection content settings to be a
    list of filters instead of just a single filter to support
    multiple filters for the same patterns. The filters are processed in
    the order they are specified, and the first matched certificate is
    selected.
    
    Bug: 824940
    Change-Id: I91e6193a263a8ebfe114679cd032e7997286c179
    Reviewed-on: https://chromium-review.googlesource.com/1050250
    Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
    Reviewed-by: Pavol Marko <pmarko@chromium.org>
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559838}

    Changed files

    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/chromeos/login/webview_login_browsertest.cc
    • chrome/browser/content_settings/content_settings_policy_provider_unittest.cc
    • chrome/browser/ssl/ssl_browsertest.cc
    • components/content_settings/core/browser/content_settings_policy_provider.cc
  96. Fix Open New Incognito Tab animation

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 08:20:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5d762728bab96990b6850e1edb2cab49c9cf97a0

    Comments

    Fix Open New Incognito Tab animation
    
    This CL fixes the Open New Incognito Tab animation when the
    BrowserContainerViewController is in fullscreen.
    It is also fixing the animation for the iPhone X.
    
    Bug: 688259, 836730, 819811, 843931, 844013
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Change-Id: I298811b90b42122ff2f805f7888d2d5ff750c2b8
    Reviewed-on: https://chromium-review.googlesource.com/1061528
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559837}

    Changed files

    • ios/chrome/browser/about_flags.mm
    • ios/chrome/browser/snapshots/snapshot_generator.mm
    • ios/chrome/browser/ui/browser_view_controller.mm
    • ios/chrome/browser/ui/ntp/incognito_view.mm
    • ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm
    • ios/chrome/browser/ui/side_swipe/card_side_swipe_view.mm
    • ios/chrome/browser/ui/ui_feature_flags.cc
    • ios/chrome/browser/ui/ui_feature_flags.h
    • ios/web/features.mm
    • ios/web/public/features.h
    • ios/web/web_state/ui/crw_web_controller.mm
  97. Reland "Handle a low memory situation in LayerTreeHostImpl"

    Changed by Gyuyoung Kim - gyuyoung.kimohnoyoudont@lge.com
    Changed at Friday, 18-May-18 08:12:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4b6a46c9e3a9520193ba910d11e5bf7ca08db042

    Comments

    Reland "Handle a low memory situation in LayerTreeHostImpl"
    
    This reverts commit 3c07526593635d1ac91f96d36af168b28a84f1b0.
    
    Original CL missed disabling the test case in the MEMORY_SANITIZER
    and LEAK_SANITIZER. This CL disabled the test case both on the
    MEMORY_SANITIZER and LEAK_SANITIZER as well.
    
    TBR=ericrk@chromium.org,danakj@chromium.org
    
    Bug: 839687
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I400894efd8badf4b26c81a8b4106aeb47947b4cf
    Reviewed-on: https://chromium-review.googlesource.com/1065535
    Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
    Reviewed-by: Gyuyoung Kim <gyuyoung.kim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559836}

    Changed files

    • cc/trees/layer_tree_host_impl.cc
    • cc/trees/layer_tree_host_impl.h
    • cc/trees/layer_tree_host_impl_unittest.cc
  98. service worker: Use URLLoaderFactoryBundle for loading new scripts.

    Changed by Matt Falkenhagen - falkenohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 08:11:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 83f1f8b146164249e9c710ba00c33357ccfc5905

    Comments

    service worker: Use URLLoaderFactoryBundle for loading new scripts.
    
    Before this CL, the service worker script loader factories had both
    a network loader factory and non-network loader factory, and chose
    which one to use based on the URL scheme. A URLLoaderFactoryBundle can
    be used for that instead, which simplifies code as the factories
    just need a single abstract SharedURLLoaderFactory.
    
    Change-Id: Id9664138601327c65886e81198a4dd15f71af092
    Bug: 836129
    Reviewed-on: https://chromium-review.googlesource.com/1059986
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559835}

    Changed files

    • content/browser/service_worker/embedded_worker_instance.cc
    • content/browser/service_worker/embedded_worker_instance.h
    • content/browser/service_worker/embedded_worker_instance_unittest.cc
    • content/browser/service_worker/service_worker_navigation_loader_unittest.cc
    • content/browser/service_worker/service_worker_new_script_loader.cc
    • content/browser/service_worker/service_worker_new_script_loader.h
    • content/browser/service_worker/service_worker_new_script_loader_unittest.cc
    • content/browser/service_worker/service_worker_provider_host.cc
    • content/browser/service_worker/service_worker_provider_host.h
    • content/browser/service_worker/service_worker_script_loader_factory.cc
    • content/browser/service_worker/service_worker_script_loader_factory.h
    • content/browser/service_worker/service_worker_version.cc
  99. content_shell: Do not exit by --run-layout-test flag.

    Changed by Kent Tamura - tkentohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 08:05:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b44bd6f4b3925c309b067cfa77600a38bf2f8dfa

    Comments

    content_shell: Do not exit by --run-layout-test flag.
    
    It shows a warning, and works as an alias of --run-web-tests.
    
    Bug: 843412
    Change-Id: I38c67e69a6f96509240bb1dd7f4cdfdbbc967029
    Reviewed-on: https://chromium-review.googlesource.com/1064657
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559834}

    Changed files

    • content/shell/app/shell_main_delegate.cc
  100. Rename FileManagerBrowserTest: add JS test case names

    Changed by Noel Gordon - noelohnoyoudont@chromium.org
    Changed at Friday, 18-May-18 08:02:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b294d0c43be3ae928447a28746f4ec1d23049643

    Comments

    Rename FileManagerBrowserTest: add JS test case names
    
    Change test fixture name to FilesAppBrowserTest. Also, add JS testcase
    name, plus modes, to the end of GTEST test name (which is shown on the
    Flakiness Dashboard). That's all GTEST allows, and it is strict re the
    character used to combine string names: '_' only.
    
    FilesAppBrowserTest, the new fixture name, is used to decouple all the
    re-named tests from the old fixture name, FileManagerBrowserTest, when
    searching the Flakiness Dashboard [1].
    
    Update the Mash bot filter exclusion list for the new fixture name and
    add TODO(me): remove the old Mash FileManagerBrowserTest entries.
    
    [1] Keeping FileManagerBrowserTest would cause developer confusion.
    
    Bug: 843030,836254
    No-presubmit: true
    Change-Id: I46318d34ce5132155db6d0e792e54a579b8e5c5c
    Reviewed-on: https://chromium-review.googlesource.com/1063952
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Reviewed-by: Luciano Pacheco (SYD) <lucmult@chromium.org>
    Reviewed-by: Naoki Fukino <fukino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559833}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • testing/buildbot/filters/mash.browser_tests.filter
  101. <blame list capped at 100 commits>

    Changed by <blame list capped at 100 commits> -
    Changed at N/A
    Repository
    Branch
    Revision

    Comments

    <blame list capped at 100 commits>