Builder Linux x64 Goma Canary LocalOutputCache Build 18696

Results:

Success

Trigger Info:

Project	chromium
Revision	780f6874acdc3c5d6b7a752c58b094062a344977
Got Revision	780f6874acdc3c5d6b7a752c58b094062a344977

Execution:

• Source: Task 42962939ab6a9e10
• Bot: swarm2390-c4
• Recipe: chromium

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 406 ms ) setup_build

   running recipe: "chromium"
   • stdout
   • run_recipe
2. ( 336 ms ) report builders

    

   running builder/tester 'Linux x64 Goma Canary LocalOutputCache' on master 'chromium.fyi'
   • stdout
   • bots.json
3. ( 1 mins 4 secs ) bot_update

   [79GB/295GB used (26%)]
   • stdout
   • json.output
4. ( 96 ms ) ensure_goma

   candidate goma client is selected
   • - no logs -
   1. ( 96 ms ) ensure_installed
      • stdout
      • json.output
5. ( 815 ms ) swarming.py --version

   0.14
   • stdout
6. ( 7 secs ) clobber
   • stdout
7. ( 45 secs ) gclient runhooks
   • stdout
8. ( 3 secs ) get compile targets for scripts
   • stdout
   • json.output
9. ( 1 secs ) read test spec (chromium.fyi.json)

   path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.fyi.json
   • stdout
   • json.output
10. ( 676 ms ) clean isolated files
    • stdout
11. ( 712 ms ) lookup GN args

     

    is_component_build = false

    is_debug = false

    strip_absolute_paths_from_debug_symbols = true

    use_goma = true

    goma_dir = "/b/swarming/w/ir/cache/goma/client"
    • stdout
12. ( 12 secs ) generate_build_files
    • stdout
    • swarming-targets-file.txt
13. ( 18 secs ) preprocess_for_goma
    • - no logs -
    1. ( 698 ms ) goma cache directory
       • stdout
    2. ( 15 secs ) start_goma
       • stdout
       • cloudtail
    3. ( 1 secs ) start cloudtail
       • stdout
14. ( 22 mins 8 secs ) compile
    • stdout
15. ( 13 secs ) compile confirm no-op
    • stdout
16. ( 25 secs ) postprocess_for_goma
    • - no logs -
    1. ( 1 secs ) goma_jsonstatus
       • stdout
       • json.output
    2. ( 744 ms ) goma_stat
       • stdout
    3. ( 773 ms ) stop_goma
       • stdout
    4. ( 21 secs ) upload_log
       • stdout
       • json.output
       • compiler_proxy_log
       • ninja_log
    5. ( 1 secs ) stop cloudtail
       • stdout
17. ( 21 secs ) isolate tests
    • stdout
    • json.output
18. ( 678 ms ) find isolated tests
    • stdout
    • json.output
19. ( 2 secs ) test_pre_run
    • - no logs -
    1. ( 1 secs ) [trigger] base_unittests

       Run on OS: 'Ubuntu-14.04'
       • stdout
       • json.output
       • shard #0
    2. ( 1 secs ) [trigger] content_unittests

       Run on OS: 'Ubuntu-14.04'
       • stdout
       • json.output
       • shard #0
20. ( 933 ms ) wait for tasks
    • stdout
    • json.output
21. ( 357 ms ) ensure swarming
    • - no logs -
    1. ( 357 ms ) ensure_installed
       • stdout
       • json.output
22. ( 2 secs ) base_unittests

    Run on OS: 'Ubuntu-14.04'

    Shard duration: 23s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (17.6 sec) (deduped)
23. ( 2 secs ) Upload to test-results [base_unittests]
    • stdout
24. ( 32 secs ) content_unittests

    Run on OS: 'Ubuntu-14.04'

    Shard duration: 34s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (24.1 sec)
25. ( 4 secs ) Upload to test-results [content_unittests]
    • stdout
26. ( 511 ms ) Tests statistics

     

    Stats

    Total shards: 2

    Total runtime: 41s

     
    • stdout
    • detailed stats
27. ( 0 ) recipe result
    • result

Build Properties:

Name	Value	Source
$recipe_engine/path	{"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"swarm2390-c4"	setup_build
branch	"refs/heads/master"	setup_build
buildbucket	{"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548291124614574, "id": "8923492801674779200", "project": "chromium", "tags": ["builder:Linux x64 Goma Canary LocalOutputCache", "buildset:commit/git/780f6874acdc3c5d6b7a752c58b094062a344977", "scheduler_invocation_id:9088922864344882928", "scheduler_job_id:chromium/Linux x64 Goma Canary LocalOutputCache", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"Linux x64 Goma Canary LocalOutputCache"	setup_build
buildnumber	18696	setup_build
mastername	"chromium.fyi"	setup_build
path_config	"generic"	setup_build
recipe	"chromium"	setup_build
repository	"https://chromium.googlesource.com/chromium/src.git"	setup_build
revision	"780f6874acdc3c5d6b7a752c58b094062a344977"	setup_build
got_angle_revision	"47ca1b2fa3990e51a2ced20f7a7d3589a5477ad1"	bot_update
got_buildtools_revision	"2f02e1f363b1af2715536f38e239853f04ec1497"	bot_update
got_dawn_revision	"c0f31e73e481f32d308cb6232e75e6d860d97063"	bot_update
got_nacl_revision	"ff15c51d20785fa51c0ef03ccb480b87299acbeb"	bot_update
got_revision	"780f6874acdc3c5d6b7a752c58b094062a344977"	bot_update
got_revision_cp	"refs/heads/master@{#625443}"	bot_update
got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	bot_update
got_v8_revision	"9df9418edf64d6a080ba569ef43cd5ca0171a820"	bot_update
got_v8_revision_cp	"refs/heads/7.3.492@{#2}"	bot_update
got_webrtc_revision	"b0397d69a93a909fc0b29ffdb9236bab1e1b2db7"	bot_update
got_webrtc_revision_cp	"refs/heads/master@{#26368}"	bot_update
isolate_server	"https://isolateserver.appspot.com"	isolate tests
swarm_hashes_refs/heads/master(at){#625443}_without_patch	{"base_unittests": "d807998b929c8a4eab3c214f20aaed50a2633762", "content_unittests": "aacb61053cac43ae2a93788d34d24ba6e50ea0f1"}	isolate tests
swarm_hashes	{"base_unittests": "d807998b929c8a4eab3c214f20aaed50a2633762", "content_unittests": "aacb61053cac43ae2a93788d34d24ba6e50ea0f1"}	find isolated tests

Blamelist:

1. Sylvain Defresne (sdefresneohnoyoudont@chromium.org)
2. Xianzhu Wang (wangxianzhuohnoyoudont@chromium.org)
3. Brandon Wylie (wyliebohnoyoudont@chromium.org)
4. Etienne Pierre-doray (etiennepohnoyoudont@chromium.org)
5. Quinten Yearsley (qyearsleyohnoyoudont@chromium.org)
6. Egor Pasko (paskoohnoyoudont@chromium.org)
7. Kyle Milka (kmilkaohnoyoudont@chromium.org)
8. Aran Gilman (gilmanmhohnoyoudont@google.com)
9. siyua (siyuaohnoyoudont@chromium.org)
10. Julie Jeongeun Kim (jkimohnoyoudont@igalia.com)
11. Caleb Rouleau (crouleauohnoyoudont@chromium.org)
12. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
13. Andreas Butler (andreasbutlerohnoyoudont@google.com)
14. Piotr Bialecki (bialpioohnoyoudont@chromium.org)
15. Caleb Rouleau (crouleauohnoyoudont@chromium.org)
16. Chris Mumford (cmumfordohnoyoudont@google.com)
17. Maggie Cai (mxcaiohnoyoudont@chromium.org)
18. Wenzhao Zang (wzangohnoyoudont@chromium.org)
19. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
20. Tim Volodine (timvolodineohnoyoudont@chromium.org)
21. Thomas Guilbert (tguilbertohnoyoudont@chromium.org)
22. Yun Liu (yliuyliuohnoyoudont@google.com)
23. Varun Khaneja (vakhohnoyoudont@chromium.org)
24. Tommy Steimel (steimelohnoyoudont@chromium.org)

Timing:

Create	Thursday, 24-Jan-19 00:52:04 UTC
Start	Thursday, 24-Jan-19 00:52:07 UTC
End	Thursday, 24-Jan-19 01:18:59 UTC
Pending	2 secs
Execution	26 mins 52 secs

All Changes:

1. Use SyncService instead of ProfileSyncService when possible

   Changed by	Sylvain Defresne - sdefresneohnoyoudont@chromium.org
   Changed at	Thursday, 24-Jan-19 00:50:56 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	780f6874acdc3c5d6b7a752c58b094062a344977

   Comments

   Use SyncService instead of ProfileSyncService when possible
   
   The sync service API is exposed by the syncer::SyncService interface
   and browser_sync::ProfileSyncService is an implementation of it. The
   code should prefer to use the abstract interface (for one, testing
   is easier as the surface to mock is smaller) instead of a particular
   concrete implementation.
   
   This change both factories in src/ios to return a syncer::SyncService
   and port client code that could not use syncer::SyncService to access
   the service as browser_sync::ProfileSyncService via dedicated methods.
   
   Those methods will eventually be removed once there are alternative
   way to access the corresponding API (either because it is moved to a
   separate service, or moved to the syncer::SyncService interface).
   
   Bug: 924508
   Change-Id: I49db34ea7c79ef7b6165eb6d51f03b0af0394b41
   Reviewed-on: https://chromium-review.googlesource.com/c/1429939
   Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
   Reviewed-by: Marc Treib <treib@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#625443}

   Changed files

   • ios/chrome/app/DEPS
   • ios/chrome/app/spotlight/topsites_spotlight_manager.mm
   • ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.mm
   • ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.cc
   • ios/chrome/browser/browsing_data/browsing_data_counter_wrapper.cc
   • ios/chrome/browser/history/web_history_service_factory.cc
   • ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm
   • ios/chrome/browser/metrics/ios_profile_session_durations_service_factory.mm
   • ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm
   • ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc
   • ios/chrome/browser/passwords/password_controller.mm
   • ios/chrome/browser/signin/authentication_service.h
   • ios/chrome/browser/signin/authentication_service.mm
   • ios/chrome/browser/signin/authentication_service_fake.h
   • ios/chrome/browser/signin/authentication_service_fake.mm
   • ios/chrome/browser/suggestions/suggestions_service_factory.mm
   • ios/chrome/browser/sync/glue/sync_start_util.cc
   • ios/chrome/browser/sync/ios_chrome_sync_client.mm
   • ios/chrome/browser/sync/ios_user_event_service_factory.cc
   • ios/chrome/browser/sync/profile_sync_service_factory.cc
   • ios/chrome/browser/sync/profile_sync_service_factory.h
   • ios/chrome/browser/sync/profile_sync_service_factory_unittest.cc
   • ios/chrome/browser/sync/session_sync_service_factory.mm
   • ios/chrome/browser/sync/sync_setup_service_factory.cc
   • ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
   • ios/chrome/browser/ui/bookmarks/synced_bookmarks_bridge.mm
   • ios/chrome/browser/ui/history/history_coordinator.mm
   • ios/chrome/browser/ui/recent_tabs/recent_tabs_coordinator_unittest.mm
   • ios/chrome/browser/ui/settings/accounts_table_egtest.mm
   • ios/chrome/browser/ui/settings/accounts_table_view_controller.mm
   • ios/chrome/browser/ui/settings/clear_browsing_data_manager.mm
   • ios/chrome/browser/ui/settings/google_services_settings_mediator.h
   • ios/chrome/browser/ui/settings/google_services_settings_mediator.mm
   • ios/chrome/browser/ui/settings/settings_table_view_controller.mm
   • ios/chrome/browser/ui/settings/sync_encryption_passphrase_table_view_controller.mm
   • ios/chrome/browser/ui/settings/sync_encryption_table_view_controller.mm
   • ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm
   • ios/chrome/browser/ui/settings/sync_settings_collection_view_controller_unittest.mm
   • ios/chrome/browser/ui/settings/sync_utils/sync_error_infobar_delegate.mm
   • ios/chrome/browser/ui/settings/sync_utils/sync_fake_server_egtest.mm
   • ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc
   • ios/chrome/browser/unified_consent/unified_consent_service_factory.cc
   • ios/chrome/test/app/sync_test_util.mm
   • ios/web_view/internal/autofill/cwv_autofill_controller.mm
   • ios/web_view/internal/cwv_web_view_configuration.mm
   • ios/web_view/internal/passwords/web_view_password_store_factory.mm
   • ios/web_view/internal/sync/cwv_sync_controller.mm
   • ios/web_view/internal/sync/cwv_sync_controller_internal.h
   • ios/web_view/internal/sync/cwv_sync_controller_unittest.mm
   • ios/web_view/internal/sync/web_view_profile_sync_service_factory.h
   • ios/web_view/internal/sync/web_view_profile_sync_service_factory.mm

2. Try to deflake two http/tests/devtools/layers tests

   Changed by	Xianzhu Wang - wangxianzhuohnoyoudont@chromium.org
   Changed at	Thursday, 24-Jan-19 00:50:41 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	977d954ac88bee5b9c259d9ac3b0499729e9ed48

   Comments

   Try to deflake two http/tests/devtools/layers tests
   
   - http/tests/devtools/layers/layer-compositing-reasons.js
     When it failed, the text difference was:
      +ERROR: No layer for iframe
      -Compositing reasons for iframe#iframe: iFrame
     which means that the iframe is not composited when we dump the
     compositing reasons.
     This is probably a synchronization issue, but instead of fixing
     the issue, I removed the iframe from the test because
     1. the other layers already provide enough test coverage of the
        compositing reasons feature of devtools,
     2. whether the iframe is composited is not a matter of the test,
        but compositing tests to test, and
     3. CompositeAfterPaint no longer needs to composite iframes
        containing composited contents
   
   - http/tests/devtools/layers/layer-scroll-rects-get.js
     When it failed, the touch action rects were missing.
     Let the page wait one additional frame to ensure the touch
     action rects are updated.
   
   Bug: 794180,859169
   Change-Id: I633bc0db1c9ff848d51182b5222fbaf82920250a
   Reviewed-on: https://chromium-review.googlesource.com/c/1423931
   Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
   Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#625442}

   Changed files

   • third_party/blink/web_tests/http/tests/devtools/layers/layer-compositing-reasons-expected.txt
   • third_party/blink/web_tests/http/tests/devtools/layers/layer-compositing-reasons.js
   • third_party/blink/web_tests/http/tests/devtools/layers/layer-scroll-rects-get.js
   • third_party/blink/web_tests/http/tests/devtools/layers/resources/compositing-reasons.html

3. [Feed] Enable LevelDB's default histograms for Feed and friends

   Changed by	Brandon Wylie - wyliebohnoyoudont@chromium.org
   Changed at	Thursday, 24-Jan-19 00:49:37 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	5ba80bd41aad1702d4706e72f64f98300d340ed0

   Comments

   [Feed] Enable LevelDB's default histograms for Feed and friends
   
   Bug: 915791
   Change-Id: I27bad3cd49bf5c3036a09c73f9139886e3955cdf
   Reviewed-on: https://chromium-review.googlesource.com/c/1380941
   Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
   Reviewed-by: Gang Wu <gangwu@chromium.org>
   Commit-Queue: Brandon Wylie <wylieb@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#625441}

   Changed files

   • tools/metrics/histograms/histograms.xml

4. [TaskScheduler]: Cleanup ScopedAllowWait.

   Changed by	Etienne Pierre-doray - etiennepohnoyoudont@chromium.org
   Changed at	Thursday, 24-Jan-19 00:49:19 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	f85e02ae59b813b1de0cbb58e28cd8db398627ab

   Comments

   [TaskScheduler]: Cleanup ScopedAllowWait.
   
   Delete deprecated ScopedAllowWait and remove related friendship in
   ThreadRestrictions.
   
   Bug: 766678
   Change-Id: I25c33b87150c6dbfb3325c4591d34919b975e59d
   Reviewed-on: https://chromium-review.googlesource.com/c/1417790
   Reviewed-by: Bo <boliu@chromium.org>
   Reviewed-by: Gabriel Charette <gab@chromium.org>
   Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
   Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#625440}

   Changed files

   • base/threading/thread_restrictions.cc
   • base/threading/thread_restrictions.h
   • content/public/test/nested_message_pump_android.cc

5. Disable casting warning from cpplint in chromium

   Changed by	Quinten Yearsley - qyearsleyohnoyoudont@chromium.org
   Changed at	Thursday, 24-Jan-19 00:48:18 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	98c7fe34e21b2d2bddc3b7729ff3cfcec03ac837

   Comments

   Disable casting warning from cpplint in chromium
   
   This warning is incorrect when cpplint is run on Objective-C headers.
   
   This CL also adds an explicit "verbose" config, which shouldn't
   change behavior, but explicit is better than implicit.
   
   Bug: 924509
   Change-Id: I39f35926ae799fc1c03947a2320590932757d4bc
   Reviewed-on: https://chromium-review.googlesource.com/c/1431892
   Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
   Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#625439}

   Changed files

   • infra/config/global/tricium-prod.cfg

6. Remove DCHECK from GetWindowClientInfoOnUI

   Changed by	Egor Pasko - paskoohnoyoudont@chromium.org
   Changed at	Thursday, 24-Jan-19 00:47:27 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	9dd721953ed486ad03a0ecb9fe4a0453c661c821

   Comments

   Remove DCHECK from GetWindowClientInfoOnUI
   
   As discussed in the bug, the condition under DCHECK is legitimate, and
   the existing code does no harm in this case.
   
   Bug: 923806
   Change-Id: I5c46ac94174ba91184d6a5dad46702899abef95e
   Reviewed-on: https://chromium-review.googlesource.com/c/1431613
   Commit-Queue: Matt Falkenhagen <falken@chromium.org>
   Reviewed-by: Matt Falkenhagen <falken@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#625438}

   Changed files

   • content/browser/service_worker/service_worker_client_utils.cc

7. Reland "[NTP] Cap search suggestion impressions"

   Changed by	Kyle Milka - kmilkaohnoyoudont@chromium.org
   Changed at	Thursday, 24-Jan-19 00:46:55 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	5d52425f8fe923f16feb6a9759baf0a5b20e758d

   Comments

   Reland "[NTP] Cap search suggestion impressions"
   
   This is a reland of 41e54be1d923353f72490f19a15e73eb09248a38
   
   One of the checks is converting the times from ms->s. In practice
   seconds is plenty precise but in the test 800ms ended up being 0,
   so increase it to 1000ms (similar to ImpressionCountResetsAfterTimeout
   which was not flaky).
   
   Original change's description:
   > [NTP] Cap search suggestion impressions
   >
   > The parameters for capping suggestions impressions are provided as part
   > of the update proto. Read and update the local pref on each fetch. Use
   > these prefs to determine if the impression cap has been reach or if
   > fetching is frozen due to an empty response.
   >
   > Bug: 904565
   > Change-Id: Ib5539a99f18e9da2ac1223ecc7aff65cb909bca8
   > Reviewed-on: https://chromium-review.googlesource.com/c/1395188
   > Commit-Queue: Kyle Milka <kmilka@chromium.org>
   > Reviewed-by: Kristi Park <kristipark@chromium.org>
   > Cr-Commit-Position: refs/heads/master@{#624994}
   
   Bug: 904565
   Change-Id: I424cb51d2a9c1738c0e5168f58ef52b73ed4b223
   Reviewed-on: https://chromium-review.googlesource.com/c/1431472
   Reviewed-by: Kristi Park <kristipark@chromium.org>
   Commit-Queue: Kyle Milka <kmilka@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#625437}

   Changed files

   • chrome/browser/search/local_ntp_source.cc
   • chrome/browser/search/search_suggest/search_suggest_data.cc
   • chrome/browser/search/search_suggest/search_suggest_data.h
   • chrome/browser/search/search_suggest/search_suggest_loader.h
   • chrome/browser/search/search_suggest/search_suggest_loader_impl.cc
   • chrome/browser/search/search_suggest/search_suggest_loader_impl_unittest.cc
   • chrome/browser/search/search_suggest/search_suggest_service.cc
   • chrome/browser/search/search_suggest/search_suggest_service.h
   • chrome/browser/search/search_suggest/search_suggest_service_unittest.cc
   • chrome/common/pref_names.cc
   • chrome/common/pref_names.h

8. Clean up distillable_page_utils.h and related files.

   Changed by	Aran Gilman - gilmanmhohnoyoudont@google.com
   Changed at	Thursday, 24-Jan-19 00:46:10 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	008a7ae48922ac58e8cf3a807b1c4f026172ed0f

   Comments

   Clean up distillable_page_utils.h and related files.
   
   This includes formatting the files with clang-format, adding and rewriting comments to make the code easier to understand, and adding/removing includes.
   
   Change-Id: I91395c1974f8ad68a2fd0245c2362fe6d1803ddc
   Reviewed-on: https://chromium-review.googlesource.com/c/1423091
   Commit-Queue: Aran Gilman <gilmanmh@google.com>
   Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#625436}

   Changed files

   • chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc
   • components/dom_distiller/content/browser/distillable_page_utils.cc
   • components/dom_distiller/content/browser/distillable_page_utils.h
   • components/dom_distiller/content/browser/distillable_page_utils_android.cc

9. [Autofill] Added browser tests for local card migration flow (part 1)

   Changed by	siyua - siyuaohnoyoudont@chromium.org
   Changed at	Thursday, 24-Jan-19 00:45:36 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	48246c46cc516439bd62c8a2bd0daf3cdfd20daa

   Comments

   [Autofill] Added browser tests for local card migration flow (part 1)
   
   The previous browser tests CL got reverted twice due to flaky tests,
   so I will try to break the browser tests into several CLs. Listed the
   following tests to be added in the TODO in the browser tests file.
   
   
   Bug: 897998
   Change-Id: Ib3c99de27028530e2f8bce7b616d7d5a9dae4cd3
   Reviewed-on: https://chromium-review.googlesource.com/c/1364695
   Commit-Queue: Siyu An <siyua@chromium.org>
   Reviewed-by: Evan Stade <estade@chromium.org>
   Reviewed-by: Jared Saul <jsaul@google.com>
   Cr-Commit-Position: refs/heads/master@{#625435}

   Changed files

   • chrome/browser/ui/views/autofill/dialog_view_ids.h
   • chrome/browser/ui/views/autofill/local_card_migration_browsertest.cc
   • chrome/browser/ui/views/autofill/local_card_migration_bubble_views.cc
   • chrome/browser/ui/views/autofill/local_card_migration_bubble_views.h
   • chrome/browser/ui/views/autofill/local_card_migration_dialog_view.cc
   • chrome/browser/ui/views/autofill/local_card_migration_dialog_view.h
   • chrome/test/BUILD.gn
   • components/autofill/core/browser/credit_card_save_manager.h
   • components/autofill/core/browser/form_data_importer.h
   • components/autofill/core/browser/local_card_migration_manager.cc
   • components/autofill/core/browser/local_card_migration_manager.h

10. [s13n] Move IdentityAPI away from using AccountTrackerService

    Changed by	Julie Jeongeun Kim - jkimohnoyoudont@igalia.com
    Changed at	Thursday, 24-Jan-19 00:45:05 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	6f4e2c0b1e765e3fe1953a73bcf41d3e6efb44d1

    Comments

    [s13n] Move IdentityAPI away from using AccountTrackerService
    
    This CL removes AccountTrackerService from IdentityAPI and
    uses IdentityManager instead of it.
    
    Bug: 922750, 922751
    Change-Id: Ibb4f2cd90fd9439b0889f25608d8491d110dcba0
    Reviewed-on: https://chromium-review.googlesource.com/c/1429883
    Reviewed-by: David Roger <droger@chromium.org>
    Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#625434}

    Changed files

    • chrome/browser/extensions/api/identity/identity_api.cc
    • chrome/browser/extensions/api/identity/identity_api.h

11. Make myself an owner of chromium.perf.

    Changed by	Caleb Rouleau - crouleauohnoyoudont@chromium.org
    Changed at	Thursday, 24-Jan-19 00:44:22 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	3844f8f8630eb06318575128a584004de3fc55cd

    Comments

    Make myself an owner of chromium.perf.
    
    Also remove people who have switched teams.
    
    Change-Id: I097dbec4407f157ad640a1782e75a33f6b992990
    Reviewed-on: https://chromium-review.googlesource.com/c/1428093
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#625433}

    Changed files

    • testing/buildbot/OWNERS

12. Roll src/third_party/perfetto 3eabfafdae1e..843e4c41417f (1 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Thursday, 24-Jan-19 00:44:01 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	a3043830bcd281080ff52dff3777c72c722ef669

    Comments

    Roll src/third_party/perfetto 3eabfafdae1e..843e4c41417f (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/3eabfafdae1e..843e4c41417f
    
    
    git log 3eabfafdae1e..843e4c41417f --date=short --no-merges --format='%ad %ae %s'
    2019-01-23 ilkos@google.com Strip newlines from atrace events
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@843e4c41417f
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:b/123286408
    TBR=perfetto-bugs@google.com
    
    Change-Id: Icc63d470266d5dfbae56bd38ce68227e44732bd6
    Reviewed-on: https://chromium-review.googlesource.com/c/1432532
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#625432}

    Changed files

    • DEPS

13. [IndexedDB]: Modify RecordCorruptionInfo to use ImportantFileWriter

    Changed by	Andreas Butler - andreasbutlerohnoyoudont@google.com
    Changed at	Thursday, 24-Jan-19 00:43:08 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	342698dc84f1e3f19abad8efcc2fe379a1208f3c

    Comments

    [IndexedDB]: Modify RecordCorruptionInfo to use ImportantFileWriter
    
    As per crbug640232, RecordCorruptionInfo's method of writing a
    corruption report to a file is modified from making a file and then
    writing to it to writing it atomically using ImportantFileWriter's
    WriteFileAtomically method to avoid issues involving interruption of
    the file write between file creation and actual writing of the record.
    
    Bug: 640232
    Change-Id: I69aad54da0c341528dbcf46ebf5a2b08cc3270f6
    Reviewed-on: https://chromium-review.googlesource.com/c/1419261
    Reviewed-by: Daniel Murphy <dmurph@chromium.org>
    Commit-Queue: Andreas Butler <andreasbutler@google.com>
    Cr-Commit-Position: refs/heads/master@{#625431}

    Changed files

    • content/browser/indexed_db/indexed_db_backing_store.cc

14. Fix AR samples to work on ToT

    Changed by	Piotr Bialecki - bialpioohnoyoudont@chromium.org
    Changed at	Thursday, 24-Jan-19 00:42:55 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	52e5e82f5616890e78514c778e16cbaeec61979a

    Comments

    Fix AR samples to work on ToT
    
    This CL updates the uses of WebXR API in test pages.
    Additionally, there is an update needed in webxr-version-shim.js.
    
    Change-Id: If50624de7fed88c612751f709397755344e467c1
    Reviewed-on: https://chromium-review.googlesource.com/c/1431915
    Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
    Reviewed-by: Klaus Weidner <klausw@chromium.org>
    Reviewed-by: Bill Orr <billorr@chromium.org>
    Auto-Submit: Piotr Bialecki <bialpio@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#625430}

    Changed files

    • third_party/webxr_test_pages/.gitignore
    • third_party/webxr_test_pages/README.chromium
    • third_party/webxr_test_pages/webxr-samples/js/cottontail/build/cottontail.debug.js
    • third_party/webxr_test_pages/webxr-samples/js/cottontail/build/cottontail.debug.js.map
    • third_party/webxr_test_pages/webxr-samples/js/cottontail/build/cottontail.js
    • third_party/webxr_test_pages/webxr-samples/js/cottontail/package.json
    • third_party/webxr_test_pages/webxr-samples/js/cottontail/src/scenes/scene.js
    • third_party/webxr_test_pages/webxr-samples/js/webxr-version-shim.js
    • third_party/webxr_test_pages/webxr-samples/proposals/phone-ar-hit-test.html
    • third_party/webxr_test_pages/webxr-samples/proposals/phone-ar.html

15. Migrate CQ gtest_perf_tests to run_performance_tests.py.

    Changed by	Caleb Rouleau - crouleauohnoyoudont@chromium.org
    Changed at	Thursday, 24-Jan-19 00:42:10 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	127d95428a3e9e312a5994e84fa83831b9b56cb1

    Comments

    Migrate CQ gtest_perf_tests to run_performance_tests.py.
    
    components_perftests and views_perftests run on the CQ
    and use run_performance_tests_wrapper.py. This changelist
    migrates them to use run_performance_tests.py. This migration
    unblocks deleting run_gtest_perf_test.py (and then all the
    perf tests use run_performance_tests.py as their runner,
    which then allows us to finally delete
    run_performance_tests_wrapper.py.)
    
    Note that I also needed to add a slash at the end of
    a target for components/BUILD.gn since I was getting the
    error
    "Input directory [...]src/components/subresource_filter/
    core/common/perftests/data must have a trailing slash
    "
    
    CC=​​​​​​tapted@chromium.org
    R=johnchen@chromium.org,eyaich@chromium.org
    TBR=blundell@chromium.org
    
    Bug: 924351
    Change-Id: I9f4542c22b72d45176574d379ed4eaedf6eb8e92
    Reviewed-on: https://chromium-review.googlesource.com/c/1428090
    Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
    Reviewed-by: Ben Pastene <bpastene@chromium.org>
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    Reviewed-by: John Chen <johnchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#625429}

    Changed files

    • components/BUILD.gn
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.linux.json
    • testing/buildbot/chromium.mac.json
    • testing/buildbot/chromium.win.json
    • testing/buildbot/gn_isolate_map.pyl
    • testing/buildbot/test_suites.pyl

16. Fixed UrlFetchRequestBase::WriteFileData memory bug.

    Changed by	Chris Mumford - cmumfordohnoyoudont@google.com
    Changed at	Thursday, 24-Jan-19 00:42:00 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	657d0723d916d35d4605e4912b0bb3ad13f68777

    Comments

    Fixed UrlFetchRequestBase::WriteFileData memory bug.
    
    UrlFetchRequestBase::WriteFileData was using an invalid
    base::StringPiece object. This was because the StringPiece
    passed to OnDataReceived is only guaranteed to be valid
    for the duration of the call, but was being posted to
    another task runner. This fixes this bug by creating a copy
    of the file data.
    
    Bug: 905097
    Change-Id: I335d4ddce29b21f4b7fcd6d686b1de20d3bdad47
    Reviewed-on: https://chromium-review.googlesource.com/c/1431692
    Reviewed-by: Stuart Langley <slangley@chromium.org>
    Commit-Queue: Chris Mumford <cmumford@google.com>
    Cr-Commit-Position: refs/heads/master@{#625428}

    Changed files

    • google_apis/drive/base_requests.cc
    • google_apis/drive/base_requests.h

17. Settings: Refresh All Sites data after returning from Site Details.

    Changed by	Maggie Cai - mxcaiohnoyoudont@chromium.org
    Changed at	Thursday, 24-Jan-19 00:41:42 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	ec4d95c5042a8d41472f34076eeb303273d02480

    Comments

    Settings: Refresh All Sites data after returning from Site Details.
    
    Currently the All Sites page |siteGroupMap| will not repopulate when we
    click the back button from the Site Details page. This CL populates the
    site list data whenever the All Sites route is navigated.
    
    This CL also simplifies the |siteGroupMap| updating mechanism. Since the
    site list sent from the backend will always include permissions and
    storage, we can simply in-place update the |siteGroupMap| when a new list
    is fetched.
    
    BUG=835712
    
    Change-Id: If8c6d8ae5092cfaa7b85dd49527c478243cddf86
    Reviewed-on: https://chromium-review.googlesource.com/c/1428622
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Patti <patricialor@chromium.org>
    Commit-Queue: Maggie Cai <mxcai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#625427}

    Changed files

    • chrome/browser/resources/settings/site_settings/all_sites.js
    • chrome/test/data/webui/settings/all_sites_tests.js

18. cros: Add helper function for demo mode autotests

    Changed by	Wenzhao Zang - wzangohnoyoudont@chromium.org
    Changed at	Thursday, 24-Jan-19 00:40:46 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	8224d40691fe9e6da64516759213f85bf75be6f5

    Comments

    cros: Add helper function for demo mode autotests
    
    Follow-up work includes adding "setUpOnlineDemoMode" in oobe.py.
    
    oobe.py uses md_login_shared.js instead of oobe.js as the entry point
    for autotests.
    
    Bug: 870049
    Change-Id: I97afc5e5aac16c8ff83f168af4c63b0e0439f3d2
    Reviewed-on: https://chromium-review.googlesource.com/c/1431479
    Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
    Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#625426}

    Changed files

    • chrome/browser/resources/chromeos/login/md_login_shared.js
    • chrome/browser/resources/chromeos/login/oobe.js

19. Roll src-internal 5f9f137868bd..80e56cb3f138 (2 commits)

    Changed by	chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at	Thursday, 24-Jan-19 00:40:38 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	edefa340dc1b934a1a3e12ca00f83010343e3fe0

    Comments

    Roll src-internal 5f9f137868bd..80e56cb3f138 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5f9f137868bd..80e56cb3f138
    
    
    Created with:
      gclient setdep -r src-internal@80e56cb3f138
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I6e4614f5e3d16c03edb451e97dc5d41ea74e548f
    Reviewed-on: https://chromium-review.googlesource.com/c/1432513
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#625425}

    Changed files

    • DEPS

20. [AW NS] Make sure to not call shouldInterceptRequest for special android urls

    Changed by	Tim Volodine - timvolodineohnoyoudont@chromium.org
    Changed at	Thursday, 24-Jan-19 00:39:33 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	1d773b17aac0b4398ce2066ed61129e4eef93942

    Comments

    [AW NS] Make sure to not call shouldInterceptRequest for special android urls
    
    shouldInterceptRequest callback should not be called for special
    android URLs, unless they fail to load. Special android urls are
    urls such as "file:///android_asset/", "file:///android_res/"
    or "content:" scheme urls.
    
    Fixed tests:
    -AwContentsClientShouldInterceptRequestTest.testNotCalledForExistingAsset
    -AwContentsClientShouldInterceptRequestTest.testNotCalledForExistingContentUrl
    -AwContentsClientShouldInterceptRequestTest.testNotCalledForExistingResource
    
    BUG=893566,841556
    
    Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo
    Change-Id: I1fd6275194d2ee2d09822896f53626e96789ff32
    Reviewed-on: https://chromium-review.googlesource.com/c/1424892
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
    Commit-Queue: Tim Volodine <timvolodine@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#625424}

    Changed files

    • android_webview/browser/aw_proxying_url_loader_factory.cc
    • testing/buildbot/filters/mojo.fyi.network_webview_instrumentation_test_apk.filter

21. Add OnRemotePlayStateChange to RendererClient

    Changed by	Thomas Guilbert - tguilbertohnoyoudont@chromium.org
    Changed at	Thursday, 24-Jan-19 00:39:18 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	8dfac45316d72c31e344a0dfe4bebc31476bd6a9

    Comments

    Add OnRemotePlayStateChange to RendererClient
    
    There is no way for a FlingingRenderer (which corresponds 1:1 with a
    video playing remotely on a cast device) to signal to WMPI that an
    external device has paused/resumed the video.
    
    This CL adds the necessary plumbing for FlingingRenderer to send state
    changes back to media::Pipeline, via the RendererClient interface.
    
    Two follow up CLs are planned: adding OnRemotePlayStateChange to
    Pipeline::Client, and adding the logic to keep WMPI's play/pause state
    in sync with the externally playing video.
    
    Bug: 790766
    Change-Id: I85bb77d85000d7913bc9e7f52048daf527e1c8c7
    Reviewed-on: https://chromium-review.googlesource.com/c/1412806
    Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
    Reviewed-by: Dan Sanders <sandersd@chromium.org>
    Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
    Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#625423}

    Changed files

    • content/browser/media/flinging_renderer_unittest.cc
    • content/renderer/media/android/media_player_renderer_client.cc
    • content/renderer/media/android/media_player_renderer_client.h
    • media/base/ipc/media_param_traits_macros.h
    • media/base/media_status.h
    • media/base/mock_filters.h
    • media/base/pipeline_impl.cc
    • media/base/renderer_client.h
    • media/mojo/clients/mojo_renderer.cc
    • media/mojo/clients/mojo_renderer.h
    • media/mojo/interfaces/media_types.mojom
    • media/mojo/interfaces/media_types.typemap
    • media/mojo/interfaces/renderer.mojom
    • media/mojo/services/media_service_unittest.cc
    • media/mojo/services/mojo_renderer_service.cc
    • media/mojo/services/mojo_renderer_service.h
    • media/remoting/courier_renderer_unittest.cc
    • media/remoting/receiver.cc
    • media/remoting/receiver.h
    • media/renderers/audio_renderer_impl_unittest.cc
    • media/renderers/renderer_impl.cc

22. Add separate StubbedOfflineContentProvider for Download home new UI testing

    Changed by	Yun Liu - yliuyliuohnoyoudont@google.com
    Changed at	Thursday, 24-Jan-19 00:38:13 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	34fbd2426ff3196b16360b65a294c50b33931e54

    Comments

    Add separate StubbedOfflineContentProvider for Download home new UI testing
    
    It is very similar to the one in current StubbedProvider
    
    Bug: 728297
    Change-Id: I6df1af44ac2746acdc23d5ae0f095ced5951132c
    Reviewed-on: https://chromium-review.googlesource.com/c/1419857
    Commit-Queue: Yun Liu <yliuyliu@google.com>
    Reviewed-by: David Trainor <dtrainor@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#625422}

    Changed files

    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/download/home/DownloadActivityV2Test.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/download/home/StubbedOfflineContentProvider.java

23. Populate the CSBRR proto for APK downloads and send the report.

    Changed by	Varun Khaneja - vakhohnoyoudont@chromium.org
    Changed at	Thursday, 24-Jan-19 00:38:01 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	3596d3597148c59ba4bdba2eacb37e3830f9e163

    Comments

    Populate the CSBRR proto for APK downloads and send the report.
    
    safety_net_id field is still unset.
    Added a TODO for that.
    
    R=drubery
    
    Bug: 907280
    Change-Id: Ic6b78615aeb79e7cb5e07c741d30a312e50e6640
    Reviewed-on: https://chromium-review.googlesource.com/c/1422741
    Commit-Queue: Varun Khaneja <vakh@chromium.org>
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Reviewed-by: Daniel Rubery <drubery@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#625421}

    Changed files

    • chrome/browser/safe_browsing/telemetry/android/android_telemetry_service.cc
    • chrome/browser/safe_browsing/telemetry/android/android_telemetry_service.h
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml

24. Revert "CC: Support YUV images in PaintImage and GpuImageDecodeCache"

    Changed by	Tommy Steimel - steimelohnoyoudont@chromium.org
    Changed at	Thursday, 24-Jan-19 00:28:25 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	97d4b16e5c57b45d462690321a901f28eda7995c

    Comments

    Revert "CC: Support YUV images in PaintImage and GpuImageDecodeCache"
    
    This reverts commit cb521877bf31b9b6df74d34e01da6e41b0d9b469.
    
    Reason for revert: causing compile errors on ios bots:
    
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-device/112397
    
    Original change's description:
    > CC: Support YUV images in PaintImage and GpuImageDecodeCache
    > 
    > This patch modifies PaintImage to have an interface to indicate
    > that the underlying image is YUV pixel format and adds a
    > corresponding DecodeYuv() method.
    > 
    > In GpuImageDecodeCache, this change adds "is YUV" variables/getters to
    > DecodedImageData, UploadedImageData (has_yuv_planes()), and ImageData,
    > as well as base:Optional arrays for the SkImages and GL texture IDs for
    > each Y, U, and V plane in the relevant places.
    > 
    > The YUV decoding path will initially be implemented for in-process
    > GPU rasterization and later for OOPR (Out of Process Rasterization).
    > Changes that affect WebP decoding in Blink will be hidden behind a flag called
    > kDecodeLossyWebPImagesToYUV.
    > 
    > Finally, because this decides whether to YUV decode based on
    > the result of PaintImageGenerator::QueryYUVA8, we separately modified
    > JPEGImageDecoder::CanDecodeToYUV (crrev.com/c/1400764) and
    > VideoImageGenerator::QueryYUVA8 (crrev.com/c/1418322)
    > to return false in order to avoid prematurely going down the YUV decode path.
    > 
    > See bit.ly/webp-decoding-into-yuv for the design document and
    > crrev.com/c/1338461 for a working prototype CL.
    > 
    > Bug: 900672
    > Change-Id: I14f60d83cc2da2382e3da296fab598597b7e8ec8
    > Reviewed-on: https://chromium-review.googlesource.com/c/1368687
    > Reviewed-by: Miguel Casas <mcasas@chromium.org>
    > Reviewed-by: Khushal <khushalsagar@chromium.org>
    > Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#625406}
    
    TBR=scroggo@chromium.org,ccameron@chromium.org,mcasas@chromium.org,dcastagna@chromium.org,khushalsagar@chromium.org,jvanverth@chromium.org,ericrk@chromium.org,andrescj@chromium.org,mbarowsky@chromium.org
    
    Change-Id: I5b67ca61424074b5d51c33692071a4306803c283
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 900672
    Reviewed-on: https://chromium-review.googlesource.com/c/1432878
    Reviewed-by: Tommy Steimel <steimel@chromium.org>
    Commit-Queue: Tommy Steimel <steimel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#625420}

    Changed files

    • cc/paint/paint_image.cc
    • cc/paint/paint_image.h
    • cc/tiles/gpu_image_decode_cache.cc
    • cc/tiles/gpu_image_decode_cache.h
    • third_party/blink/renderer/platform/graphics/decoding_image_generator.cc
    • third_party/blink/renderer/platform/graphics/image_frame_generator.cc