Builder Linux x64 Goma Canary (clobber) Build 20672

Overview

Results:

Success

Trigger Info:

Project	chromium
Revision	0246bba0cd7b7d6616e0aeac4a3f38464e9af232
Got Revision	0246bba0cd7b7d6616e0aeac4a3f38464e9af232

Execution:

Steps and Logfiles:

Show: Expanded Default Non-Green

( 334 ms ) setup_build
running recipe: "chromium"
- stdout
- run_recipe
( 343 ms ) report builders

running builder/tester 'Linux x64 Goma Canary (clobber)' on master 'chromium.fyi'
- stdout
- bots.json
( 57 secs ) bot_update
[70GB/295GB used (23%)]
- stdout
- json.output
( 95 ms ) ensure_goma
candidate goma client is selected
- - no logs -
1. ( 95 ms ) ensure_installed
  - stdout
  - json.output
( 819 ms ) swarming.py --version
0.14
- stdout
( 6 secs ) clobber
- stdout
( 33 secs ) gclient runhooks
- stdout
( 3 secs ) get compile targets for scripts
- stdout
- json.output
( 1 secs ) read test spec (chromium.fyi.json)
path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.fyi.json
- stdout
- json.output
( 630 ms ) clean isolated files
- stdout
( 727 ms ) lookup GN args

is_component_build = false
is_debug = false
strip_absolute_paths_from_debug_symbols = true
use_goma = true
goma_dir = "/b/swarming/w/ir/cache/goma/client"
- stdout
( 11 secs ) generate_build_files
- stdout
- swarming-targets-file.txt
( 17 secs ) preprocess_for_goma
- - no logs -
1. ( 668 ms ) goma cache directory
  - stdout
2. ( 14 secs ) start_goma
  - stdout
  - cloudtail
3. ( 1 secs ) start cloudtail
  - stdout
( 19 mins 49 secs ) compile
- stdout
( 20 secs ) compile confirm no-op
- stdout
( 19 secs ) postprocess_for_goma
- - no logs -
1. ( 855 ms ) goma_jsonstatus
  - stdout
  - json.output
2. ( 736 ms ) goma_stat
  - stdout
3. ( 779 ms ) stop_goma
  - stdout
4. ( 16 secs ) upload_log
5. ( 804 ms ) stop cloudtail
  - stdout
( 18 secs ) isolate tests
- stdout
- json.output
( 705 ms ) find isolated tests
- stdout
- json.output
( 2 secs ) test_pre_run
- - no logs -
1. ( 1 secs ) [trigger] base_unittests
  Run on OS: 'Ubuntu-14.04'
2. ( 1 secs ) [trigger] content_unittests
  Run on OS: 'Ubuntu-14.04'
( 929 ms ) wait for tasks
- stdout
- json.output
( 309 ms ) ensure swarming
- - no logs -
1. ( 309 ms ) ensure_installed
  - stdout
  - json.output
( 2 secs ) base_unittests
Run on OS: 'Ubuntu-14.04'
Shard duration: 23s
- stdout
- swarming.summary
- Merge script log
- step_metadata
- shard #0 isolated out
- shard #0 (18.0 sec) (deduped)
( 2 secs ) Upload to test-results [base_unittests]
- stdout
( 46 mins 29 secs ) content_unittests
Run on OS: 'Ubuntu-14.04'
Pending time: 0:45:51.877931
Shard duration: 28s
- stdout
- swarming.summary
- Merge script log
- step_metadata
- shard #0 isolated out
- shard #0 (20.4 sec)
( 4 secs ) Upload to test-results [content_unittests]
- stdout
( 416 ms ) Tests statistics

Stats
Total shards: 2
Total runtime: 38s
- stdout
- detailed stats
( 0 ) recipe result
- result

Build Properties:

Name	Value	Source
$recipe_engine/path	{"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"swarm2391-c4"	setup_build
branch	"refs/heads/master"	setup_build
buildbucket	{"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548285329998962, "id": "8923498877770004128", "project": "chromium", "tags": ["builder:Linux x64 Goma Canary (clobber)", "buildset:commit/git/0246bba0cd7b7d6616e0aeac4a3f38464e9af232", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/0246bba0cd7b7d6616e0aeac4a3f38464e9af232", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9088928940113004720", "scheduler_job_id:chromium/Linux x64 Goma Canary (clobber)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"Linux x64 Goma Canary (clobber)"	setup_build
buildnumber	20672	setup_build
mastername	"chromium.fyi"	setup_build
path_config	"generic"	setup_build
recipe	"chromium"	setup_build
repository	"https://chromium.googlesource.com/chromium/src.git"	setup_build
revision	"0246bba0cd7b7d6616e0aeac4a3f38464e9af232"	setup_build
got_angle_revision	"47ca1b2fa3990e51a2ced20f7a7d3589a5477ad1"	bot_update
got_buildtools_revision	"2f02e1f363b1af2715536f38e239853f04ec1497"	bot_update
got_dawn_revision	"c0f31e73e481f32d308cb6232e75e6d860d97063"	bot_update
got_nacl_revision	"ff15c51d20785fa51c0ef03ccb480b87299acbeb"	bot_update
got_revision	"0246bba0cd7b7d6616e0aeac4a3f38464e9af232"	bot_update
got_revision_cp	"refs/heads/master@{#625401}"	bot_update
got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	bot_update
got_v8_revision	"9df9418edf64d6a080ba569ef43cd5ca0171a820"	bot_update
got_v8_revision_cp	"refs/heads/7.3.492@{#2}"	bot_update
got_webrtc_revision	"b0397d69a93a909fc0b29ffdb9236bab1e1b2db7"	bot_update
got_webrtc_revision_cp	"refs/heads/master@{#26368}"	bot_update
isolate_server	"https://isolateserver.appspot.com"	isolate tests
swarm_hashes_refs/heads/master(at){#625401}_without_patch	{"base_unittests": "c1128f59b0af2fefdd0724ae17639f4d238ddda2", "content_unittests": "ea450c29d8b92f47014fc2aeaaefa128ecfaad16"}	isolate tests
swarm_hashes	{"base_unittests": "c1128f59b0af2fefdd0724ae17639f4d238ddda2", "content_unittests": "ea450c29d8b92f47014fc2aeaaefa128ecfaad16"}	find isolated tests

Blamelist:

danakj (danakjohnoyoudont@chromium.org)
Eugene But (eugenebutohnoyoudont@google.com)
Victor Costan (pwnallohnoyoudont@chromium.org)
danakj (danakjohnoyoudont@chromium.org)
Yann Dago (ydagoohnoyoudont@chromium.org)
Daniel Rubery (druberyohnoyoudont@chromium.org)
chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
Sidney San Martín (sdyohnoyoudont@chromium.org)
3su6n15k.default@developer.gserviceaccount.com (3su6n15k.defaultohnoyoudont@developer.gserviceaccount.com)

Timing:

Create	Wednesday, 23-Jan-19 23:15:29 UTC
Start	Wednesday, 23-Jan-19 23:15:31 UTC
End	Thursday, 24-Jan-19 00:25:33 UTC
Pending	1 secs
Execution	1 hrs 10 mins

All Changes:

Move page scale factor out of RenderWidget::SynchronizeVisualProperties.

Changed by	danakj - danakjohnoyoudont@chromium.org
Changed at	Wednesday, 23-Jan-19 23:12:27 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	0246bba0cd7b7d6616e0aeac4a3f38464e9af232

Comments

Move page scale factor out of RenderWidget::SynchronizeVisualProperties.

The SynchronizeVisualProperties() method is called from the IPC handler
to apply some of the IPC message. The code for page scale factor is
moved out to the IPC handler to act on it directly.

It is also called by a number of methods for tests, which apply various
properties to the RenderWidget. Page scale is not ever changed by these
test methods, so they do not depend on it being inside
SynchronizeVisualProperties().

It is also also called from the screen metrics emulator, but since the
emulator does not change the page scale factor, it also does not depend
on this code being in SynchronizeVisualProperties().

The notification of the page scale factor change to each
RenderFrameProxy is dramatically reordered with respect to the other
properties of RenderWidget changing. This is okay because the
notification is only to pass the value over IPC up to the browser and
down to the child RenderWidget, so it does not depend on the ordering.

This reduces the test-only method dependency footprint on the
VisualProperties structure. Left a TODO about changing the routing
of this page scale property to go

blink->RenderView->RenderViewHost->{All RenderWidgets}

instead of the current

blink->RenderView->RenderWidget->
  {All RenderFrameProxy->RenderWidgetHost->RenderWidgets}

Other page-level properties could benefit from this path as well
but are much trickier since they
a) do not go through RenderFrameProxy today and instead seem to
propagate through the browser code, which is good, except
b) are treated identically in child RenderWidgets as in the main
frame,

whereas the page scale factor has clear behaviour differences for
child RenderWidgets. So this could be useful for exploring and
establishing this pattern.

R=ajwong@chromium.org
TBR=avi

Change-Id: I4af9b114e729c26e8356e69ecb9569337d653cb3
Bug: 912193
Reviewed-on: https://chromium-review.googlesource.com/c/1427466
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625401}

Changed files

content/renderer/render_widget.cc
content/renderer/render_widget.h

Improve session restore performance.

Changed by	Eugene But - eugenebutohnoyoudont@google.com
Changed at	Wednesday, 23-Jan-19 23:11:53 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	ccf6be4686093ade39c87b4afc36cf95cceabca0

Comments

Improve session restore performance.

Session restoration completion code was moved from
didCommitNavigation to didStartProvisionalNavigation.
This change will allow the user to start interacting with
web contents without waiting until the first post-restore
navigation is complete.

There will be no committed URL until the first post-restore
navigation is complete, but user should be able to load new
pages and perform back forward navigations.

Bug: 877671
Change-Id: Iceeeff857aee36bf4151f247815c0705ac377e73
Reviewed-on: https://chromium-review.googlesource.com/c/1407909
Commit-Queue: Eugene But <eugenebut@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625400}

Changed files

ios/web/navigation/legacy_navigation_manager_impl.h
ios/web/navigation/legacy_navigation_manager_impl.mm
ios/web/navigation/navigation_manager_impl.h
ios/web/navigation/navigation_manager_impl.mm
ios/web/navigation/navigation_manager_impl_unittest.mm
ios/web/navigation/wk_based_navigation_manager_impl.h
ios/web/navigation/wk_based_navigation_manager_impl.mm
ios/web/public/navigation_manager.h
ios/web/web_state/ui/crw_web_controller.mm
ios/web/web_state/web_state_unittest.mm

appcache: Move AppCacheFrontend from content/common to content/browser.

Changed by	Victor Costan - pwnallohnoyoudont@chromium.org
Changed at	Wednesday, 23-Jan-19 23:10:48 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	1255f3c58bfae11962aed0aa9ead7874ae1250cb

Comments

appcache: Move AppCacheFrontend from content/common to content/browser.

AppCacheFrontend is only used in AppCache's browser-side
implementation. Having it in content/common/appcache_interfaces.h is
misleading, as it suggests that the class is shared with the renderer.

Bug: 611938
Change-Id: I68865d63ee38841d59b61866664716c0ec8c2c39
Reviewed-on: https://chromium-review.googlesource.com/c/1429247
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625399}

Changed files

content/browser/BUILD.gn
content/browser/appcache/appcache_frontend.h
content/browser/appcache/appcache_frontend_proxy.h
content/browser/appcache/appcache_group_unittest.cc
content/browser/appcache/appcache_host.cc
content/browser/appcache/appcache_host_unittest.cc
content/browser/appcache/appcache_navigation_handle_core.h
content/browser/appcache/appcache_request_handler_unittest.cc
content/browser/appcache/appcache_storage_impl_unittest.cc
content/browser/appcache/appcache_unittest.cc
content/browser/appcache/appcache_update_job.cc
content/browser/appcache/appcache_update_job_unittest.cc
content/browser/appcache/appcache_url_request_job.cc
content/browser/service_worker/service_worker_installed_script_loader.h
content/common/appcache_interfaces.h

Remove Redraw call from RenderWidgetScreenMetricsEmulator.

Changed by	danakj - danakjohnoyoudont@chromium.org
Changed at	Wednesday, 23-Jan-19 23:10:21 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	30ad91688b7a9c9976cf00ead80a294157ff1796

Comments

Remove Redraw call from RenderWidgetScreenMetricsEmulator.

This redraw used to be

  if (params.needs_resize_ack)
    delegate_->Redraw();

Which was there to cause a paint (pre compositing) or a composite (post
compositing) in order to send an ack after a resize. We no longer need
to make this redraw happen to get the appropriate ACK as
664698a679a27ce4e converted us to ACKing to SynchronizeVisualProperties
(which replaced Resize) directly, and now ACKing is tied to surface
synchronization and local surface IDs.

R=avi@chromium.org

Change-Id: Id1c0e3e5534b41767ce36fb2298af56a639fa677
Bug: 912193
Reviewed-on: https://chromium-review.googlesource.com/c/1431213
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625398}

Changed files

content/renderer/devtools/render_widget_screen_metrics_emulator.cc
content/renderer/devtools/render_widget_screen_metrics_emulator_delegate.h
content/renderer/render_widget.cc
content/renderer/render_widget.h

Added reporting info on chrome://management for desktop

Changed by	Yann Dago - ydagoohnoyoudont@chromium.org
Changed at	Wednesday, 23-Jan-19 23:04:46 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	ed5d04cf3a36f6956ef9eac17af165d092804c25

Comments

Added reporting info on chrome://management for desktop

Message added under Browsing Reporting section on Desktop
with "Chrome Reporting Extension (cloud or OnPrem)" installed
for each of the following policies:
  * report_machine_id_data (true for cloud reporting)
  * report_user_id_data (true for cloud reporting)
  * report_version_data (true for cloud reporting)
  * report_policy_data (true for cloud reporting)
  * report_extensions_data (true for cloud reporting)
  * report_safe_browsing_data (true for cloud reporting)
  * report_system_telemetry_data
  * report_user_browsing_data

Bug: 921698
Change-Id: Icccf744acb775be9723e38b61829ffb42fc2053c
Reviewed-on: https://chromium-review.googlesource.com/c/1423116
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Dan Beam (slow until 1/29) <dbeam@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625397}

Changed files

chrome/browser/resources/management/management.html
chrome/browser/resources/management/management.js
chrome/browser/ui/webui/management_ui.cc
chrome/browser/ui/webui/management_ui_handler.cc
chrome/browser/ui/webui/management_ui_handler.h
components/management_strings.grdp

Fix gn check for //chrome/browser/safe_browsing:safe_browsing

Changed by	Daniel Rubery - druberyohnoyoudont@chromium.org
Changed at	Wednesday, 23-Jan-19 23:04:35 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	b4754fc159b2454e05de85b33db55f8799731b0c

Comments

Fix gn check for //chrome/browser/safe_browsing:safe_browsing

This CL adds a number of deps to the target
//chrome/browser/safe_browsing:safe_browsing
It also adds the safe_browsing target to allow_circular_includes_from
for //chrome/browser:browser, since these are tightly coupled. The
remaining gn check errors are only due to circular dependencies with:
  //chrome/browser/ui:ui
  //chrome/browser/extensions:extensions
Both of which will be fixed in future CLs

Bug: 919683
Change-Id: Iec1c1737aceef070aca082260b587dc96250bc16
Reviewed-on: https://chromium-review.googlesource.com/c/1428480
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625396}

Changed files

chrome/browser/BUILD.gn
chrome/browser/safe_browsing/BUILD.gn

Roll src-internal 6aa6bc44417e..5f9f137868bd (2 commits)

Changed by	chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
Changed at	Wednesday, 23-Jan-19 23:02:07 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	fd81d8d0f0c3c04315030485cb8f1efe0ded9614

Comments

Roll src-internal 6aa6bc44417e..5f9f137868bd (2 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6aa6bc44417e..5f9f137868bd


Created with:
  gclient setdep -r src-internal@5f9f137868bd

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Icce4c91cf17d385e89919647ab3b5ca4332b44eb
Reviewed-on: https://chromium-review.googlesource.com/c/1431832
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625395}

Changed files

DEPS

Re-enable app shim code signature checking with fixes.

Changed by	Sidney San Martín - sdyohnoyoudont@chromium.org
Changed at	Wednesday, 23-Jan-19 23:00:24 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	2007aaf2b18b3e2a9d1b3233bc89d41b138fba14

Comments

Re-enable app shim code signature checking with fixes.

Two changes:
- Remove the IS_OFFICIAL_BUILD check (don't require official builds to
  be signed for app shims to run at all).
- Construct a custom designated requirement to verify the app shim,
  which checks its identifier and that its certificate matches the
  browser's.

For now, keep failures log-only.

This reverts commit add2f7a11d13cf857b95ccb575afcd5d66690532.

Bug: 913362, 923612
Change-Id: I1c536e2172519dbf8e5b36a2dd9b5f1b26fb8302
Reviewed-on: https://chromium-review.googlesource.com/c/1427385
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Auto-Submit: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625394}

Changed files

base/mac/foundation_util.h
base/mac/foundation_util.mm
chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc

Automated Commit: LKGM 11631.0.0 for chromeos.

Changed by	3su6n15k.default@developer.gserviceaccount.com - 3su6n15k.defaultohnoyoudont@developer.gserviceaccount.com
Changed at	Wednesday, 23-Jan-19 22:54:50 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	4793abd38544dfc631d694b6eb1a393af15a720c

Comments

Automated Commit: LKGM 11631.0.0 for chromeos.

BUG=762641
TBR=michaelpg@google.com

Change-Id: Ia4ebed15d53163eace05eaa2997a8111e9f0a6ff
Reviewed-on: https://chromium-review.googlesource.com/c/1429199
Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625393}

Changed files

chromeos/CHROMEOS_LKGM