Builder Linux x64 Goma Canary (clobber) Build 20661
Results:
Success
Trigger Info:
Project | chromium |
Revision | c9aa6b0b42cbebe6441374dec0c44f9f31956cf7 |
Got Revision | c9aa6b0b42cbebe6441374dec0c44f9f31956cf7 |
Execution:
- Source: Task 42948ea19a163510
- Bot: swarm2391-c4
- Recipe: chromium
Steps and Logfiles:
Show:-
( 346 ms ) report buildersrunning builder/tester 'Linux x64 Goma Canary (clobber)' on master 'chromium.fyi'
-
- - no logs -
-
( 1 secs ) read test spec (chromium.fyi.json)path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.fyi.json
-
( 730 ms ) lookup GN argsis_component_build = falseis_debug = falsestrip_absolute_paths_from_debug_symbols = trueuse_goma = truegoma_dir = "/b/swarming/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm2391-c4" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548264216255176, "id": "8923521017134187472", "project": "chromium", "tags": ["builder:Linux x64 Goma Canary (clobber)", "buildset:commit/git/c9aa6b0b42cbebe6441374dec0c44f9f31956cf7", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/c9aa6b0b42cbebe6441374dec0c44f9f31956cf7", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9088951079185145568", "scheduler_job_id:chromium/Linux x64 Goma Canary (clobber)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "Linux x64 Goma Canary (clobber)" | setup_build |
buildnumber | 20661 | setup_build |
mastername | "chromium.fyi" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
repository | "https://chromium.googlesource.com/chromium/src.git" | setup_build |
revision | "c9aa6b0b42cbebe6441374dec0c44f9f31956cf7" | setup_build |
got_angle_revision | "5313c8a89964f536bff2c7f7943499f9c52e5664" | bot_update |
got_buildtools_revision | "2f02e1f363b1af2715536f38e239853f04ec1497" | bot_update |
got_dawn_revision | "c0f31e73e481f32d308cb6232e75e6d860d97063" | bot_update |
got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
got_revision | "c9aa6b0b42cbebe6441374dec0c44f9f31956cf7" | bot_update |
got_revision_cp | "refs/heads/master@{#625242}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "21b1ee522c100e983d64754291774d68e7bdc31f" | bot_update |
got_v8_revision_cp | "refs/heads/7.3.492@{#1}" | bot_update |
got_webrtc_revision | "71b5a7df7794bbc4103296fcd8bd740acebdc901" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26351}" | bot_update |
isolate_server | "https://isolateserver.appspot.com" | isolate tests |
swarm_hashes_refs/heads/master(at){#625242}_without_patch | {"base_unittests": "2e5e83af6c46383aac293f202820265646b4cd90", "content_unittests": "6c787ef71f569a79559b7f1e4c01e5347554104e"} | isolate tests |
swarm_hashes | {"base_unittests": "2e5e83af6c46383aac293f202820265646b4cd90", "content_unittests": "6c787ef71f569a79559b7f1e4c01e5347554104e"} | find isolated tests |
Blamelist:
- Jordan Demeulenaere (jdemeulenaereohnoyoudont@google.com)
- Aaron Leventhal (aleventhalohnoyoudont@chromium.org)
- Victor Costan (pwnallohnoyoudont@chromium.org)
- Rayan Kanso (rayankansohnoyoudont@chromium.org)
- Josh Nohle (nohleohnoyoudont@google.com)
- Lily Chen (chlilyohnoyoudont@chromium.org)
- Kyle Milka (kmilkaohnoyoudont@chromium.org)
- Thomas Tangl (tangltomohnoyoudont@chromium.org)
- Manu Cornet (manucornetohnoyoudont@chromium.org)
- Sebastien Lalancette (seblalancetteohnoyoudont@chromium.org)
- Tarun Bansal (tbansalohnoyoudont@chromium.org)
- Clark DuVall (cduvallohnoyoudont@chromium.org)
- Daniel Bratell (bratellohnoyoudont@opera.com)
- Miguel Casas (mcasasohnoyoudont@chromium.org)
Timing:
Create | Wednesday, 23-Jan-19 17:23:36 UTC |
Start | Wednesday, 23-Jan-19 17:23:37 UTC |
End | Wednesday, 23-Jan-19 17:47:34 UTC |
Pending | 1 secs |
Execution | 23 mins 57 secs |
All Changes:
-
[Autofill Assistant] Move details into model.
Changed by Jordan Demeulenaere - jdemeulenaereohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 17:22:54 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c9aa6b0b42cbebe6441374dec0c44f9f31956cf7 Comments
[Autofill Assistant] Move details into model. Change-Id: I804c3314accef5590c02aba545f6f0ea84c654e1 Reviewed-on: https://chromium-review.googlesource.com/c/1430000 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#625242}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AssistantCoordinator.java
- chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AssistantModel.java
- chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
- chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/carousel/AssistantCarouselCoordinator.java
- chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/details/AssistantDetails.java
- chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/details/AssistantDetailsCoordinator.java
- chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/details/AssistantDetailsModel.java
- chrome/android/java_sources.gni
- chrome/android/javatests/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiTest.java
- chrome/browser/BUILD.gn
- chrome/browser/android/autofill_assistant/ui_controller_android.cc
- chrome/browser/android/autofill_assistant/ui_controller_android.h
-
Correct validation popup hiding code
Changed by Aaron Leventhal - aleventhalohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 17:22:02 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d20c5b9464a04c7eac13832b52d02e0d74971f38 Comments
Correct validation popup hiding code When the validation popup is hidden, this unexpected code path occurs: - HideValidationMessage() is called continuously, and keeps restarting the timer used to call Reset() - As a result, Reset() is never reached The fix: do not restart the timer if a hide is in progress. This fix is blocking an accessibility fix, which needs an accurate signal when the validation message is no longer visible. Bug: None Change-Id: I0d69abf006a881dd7cc147dfe49ada50217b8c4a Reviewed-on: https://chromium-review.googlesource.com/c/1417890 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#625241}
Changed files
- third_party/blink/renderer/core/page/validation_message_client_impl.cc
- third_party/blink/renderer/core/page/validation_message_overlay_delegate.h
-
appcache: Move AppCacheNamespace from content/common to content/browser.
Changed by Victor Costan - pwnallohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 17:21:40 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0750356830c58226fd66bf48439d30275bffe904 Comments
appcache: Move AppCacheNamespace from content/common to content/browser. AppCacheNamespace is only used in AppCache's browser-side implementation. Having it in content/common/appcache_interfaces.h is misleading, as it suggests that the class is shared with the renderer. Bug: 611938 Change-Id: Iffcb77f27408f133c97417663d48d244f2a672bd Reviewed-on: https://chromium-review.googlesource.com/c/1429246 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#625240}
Changed files
- content/browser/BUILD.gn
- content/browser/appcache/appcache.h
- content/browser/appcache/appcache_database.h
- content/browser/appcache/appcache_manifest_parser.h
- content/browser/appcache/appcache_namespace.cc
- content/browser/appcache/appcache_namespace.h
- content/common/appcache_interfaces.cc
- content/common/appcache_interfaces.h
-
[Background Fetch] Support registrations w/duplicate URLs.
Changed by Rayan Kanso - rayankansohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 17:20:37 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 34ba977263f45aa7d718e23f993781311d3a7049 Comments
[Background Fetch] Support registrations w/duplicate URLs. This CL uses a workaraound to enable storing duplicate URLs in the Cache Storage, until it is fully supported. The way it works is that it appends the unique_id+request_index to the URL query, and removes it again when extracted from the cache. When a request is matched, we search the cache with ignored query mode, then we recheck that the queries in fact match. This also allows to store duplicate URLs with different methods. This CL should be submitted with a second part, that performs a cache migration from the old format to the new one. Bug: 871174 Change-Id: Id801361424fbb9464016daba153155c3259b6671 Reviewed-on: https://chromium-review.googlesource.com/c/1414937 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Mugdha Lakhani <nator@google.com> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#625239}
Changed files
- content/browser/background_fetch/background_fetch_data_manager_unittest.cc
- content/browser/background_fetch/background_fetch_request_match_params.h
- content/browser/background_fetch/background_fetch_service_unittest.cc
- content/browser/background_fetch/storage/create_metadata_task.cc
- content/browser/background_fetch/storage/database_helpers.cc
- content/browser/background_fetch/storage/database_helpers.h
- content/browser/background_fetch/storage/database_helpers_unittest.cc
- content/browser/background_fetch/storage/mark_request_complete_task.cc
- content/browser/background_fetch/storage/match_requests_task.cc
- content/browser/background_fetch/storage/match_requests_task.h
- content/test/BUILD.gn
-
Add CryptAuthKeyRegistry class
Changed by Josh Nohle - nohleohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 17:15:40 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1c8b1403f4cbe485bfe4f184a567e591830332f8 Comments
Add CryptAuthKeyRegistry class The CryptAuthKeyRegistry stores key bundles that are enrolled with CryptAuth. This storage is persisted as a pref, and retrieved on construction. Bug: 899080 Change-Id: Ifad5bb2d4ce38de43420061fb375f4fe43416ed4 Reviewed-on: https://chromium-review.googlesource.com/c/1407257 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#625238}
Changed files
- chromeos/services/device_sync/BUILD.gn
- chromeos/services/device_sync/cryptauth_key_registry.cc
- chromeos/services/device_sync/cryptauth_key_registry.h
- chromeos/services/device_sync/cryptauth_key_registry_impl.cc
- chromeos/services/device_sync/cryptauth_key_registry_impl.h
- chromeos/services/device_sync/cryptauth_key_registry_impl_unittest.cc
- chromeos/services/device_sync/pref_names.cc
- chromeos/services/device_sync/pref_names.h
-
Reporting: Strip username, password, and ref fragment from report URLs
Changed by Lily Chen - chlilyohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 17:13:27 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8fed0dd750de6fd29a660066df84d7ccb1fdf82f Comments
Reporting: Strip username, password, and ref fragment from report URLs The specification (https://w3c.github.io/reporting/#queue-report) states that the username, password, and fragment of the report URL should be cleared before queueing a report. We were neglecting to do this. This CL strips those fields so as to conform to the specification. Bug: None Change-Id: I9a04592ee14b3ab953de721b53208cde0cb9be0f Reviewed-on: https://chromium-review.googlesource.com/c/1427249 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#625237}
Changed files
- net/reporting/reporting_service.cc
- net/reporting/reporting_service_unittest.cc
-
Allow ddljson response to not contain an image
Changed by Kyle Milka - kmilkaohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 17:08:19 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ed75158ba4c24f6c411982517f745d10b1e22acc Comments
Allow ddljson response to not contain an image Interactive doodles don't use the image (data_uri field) included in the ddljson response. Don't require that responses (on Desktop) contain an image. Allow logo_cache to cache a doodle that doesn't include an image. Bug: 800170 Change-Id: I2161b4b2d33ffdaaa463dd9e59ed2c2f77a9cc1a Reviewed-on: https://chromium-review.googlesource.com/c/1427564 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#625236}
Changed files
- chrome/browser/resources/local_ntp/doodles.js
- chrome/browser/search/local_ntp_source.cc
- chrome/browser/ui/search/local_ntp_doodle_browsertest.cc
- components/search_provider_logos/google_logo_api_unittest.cc
- components/search_provider_logos/logo_cache.cc
- components/search_provider_logos/logo_cache_unittest.cc
- components/search_provider_logos/logo_service_impl.cc
- components/search_provider_logos/logo_service_impl.h
- tools/metrics/histograms/enums.xml
-
[unified-consent] Update substring for UMA
Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 17:06:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a9f7f9f2c5c9f49843635b21edfc8bc7be936621 Comments
[unified-consent] Update substring for UMA TBR=jochen@chromium.org Bug: 924183 Change-Id: I149ca188f0aa18d7d8ab351460402987808fe8e1 Reviewed-on: https://chromium-review.googlesource.com/c/1430103 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#625235}
Changed files
- chrome/app/settings_strings.grdp
-
CrOS Shelf: Remove overflow shelf clip
Changed by Manu Cornet - manucornetohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 17:06:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0cee3055957800b3acd3f458c2972bcce8352db5 Comments
CrOS Shelf: Remove overflow shelf clip Remove overflow shelf clip so that inkdrop ripples can propagate outside the overflow bubble. The mask isn't really useful in the first place anyway. See before/after screenshots here: https://bugs.chromium.org/p/chromium/issues/detail?id=631240#c14 Bug: 631240 Change-Id: Iaa1d2f4e2e74bff34a708fa9e2cd7be5ed9a52fa Reviewed-on: https://chromium-review.googlesource.com/c/1429639 Auto-Submit: Manu Cornet <manucornet@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#625234}
Changed files
- ash/shelf/overflow_bubble_view.cc
-
[AF] Added browser tests for Autocomplete.
Changed by Sebastien Lalancette - seblalancetteohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 17:05:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5cf3bcd7d1ced78b01e07edc7b9e822a38e97821 Comments
[AF] Added browser tests for Autocomplete. Added the following browser tests for the Autocomplete feature: Retention Policy Flag ON: - SubmitSimpleValue_Saves - SubmitSimpleValue_OTR_DoesNotSave - SubmitSimpleValue_Disabled_DoesNotSave - RetentionPolicy_Init_SavesVersionPref - RetentionPolicy_RemovesExpiredEntry - RetentionPolicy_DoesNot_RemoveValidEntry Retention Policy Flag OFF: - SubmitSimpleValue_Saves - SubmitSimpleValue_OTR_DoesNotSave - SubmitSimpleValue_Disabled_DoesNotSave - RetentionPolicy_DoesNot_RemoveExpiredEntry Bug: 920620 Change-Id: Id422c68b06938a78e6c12a9011b520e59cc0e021 Reviewed-on: https://chromium-review.googlesource.com/c/1412503 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#625233}
Changed files
- chrome/browser/autofill/autofill_autocomplete_browsertest.cc
- chrome/test/BUILD.gn
- chrome/test/data/autofill/autocomplete_simple_form.html
- components/autofill/core/browser/BUILD.gn
- components/autofill/core/browser/autocomplete_history_manager.cc
- components/autofill/core/browser/autocomplete_history_manager.h
- components/autofill/core/browser/autofill_observer.cc
- components/autofill/core/browser/autofill_observer.h
- components/autofill/core/browser/autofill_subject.cc
- components/autofill/core/browser/autofill_subject.h
- components/autofill/core/browser/autofill_subject_unittest.cc
- components/autofill/core/browser/test_autofill_async_observer.cc
- components/autofill/core/browser/test_autofill_async_observer.h
- components/autofill/core/browser/webdata/autofill_table.cc
- components/autofill/core/browser/webdata/autofill_table_unittest.cc
- components/autofill/core/common/autofill_constants.h
-
Navigation Predictor: Merge two features into a single one
Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 16:55:58 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 422f901782f0a5f274a6065fbff3983279ef3c0b Comments
Navigation Predictor: Merge two features into a single one Currently, navigation predictor code defines two features: kRecordAnchorMetricsClicked and kRecordAnchorMetricsVisible. The original plan was to have two features to be used to independently control two different behaviors of Chrome: (i) UMA recording of metrics of the clicked anchor element (ii) UMA recording of metrics of the visible anchor element. However, we never got around to doing so, and actually used the same feature to control all the behavior. This CL merges the two features into a single one to make code cleaner and simpler to understand. There is no functional change. Change-Id: Icedd78c9af50c0f2f76350d20d5af4bb13a7ca0d Bug: 908725 Reviewed-on: https://chromium-review.googlesource.com/c/1416153 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Doug Arnett <dougarnett@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#625232}
Changed files
- chrome/browser/navigation_predictor/navigation_predictor.cc
- chrome/browser/navigation_predictor/navigation_predictor_browsertest.cc
- chrome/browser/navigation_predictor/navigation_predictor_unittest.cc
- testing/variations/fieldtrial_testing_config.json
- third_party/blink/common/features.cc
- third_party/blink/public/common/features.h
- third_party/blink/renderer/core/html/anchor_element_metrics.cc
- third_party/blink/renderer/core/html/anchor_element_metrics_sender.cc
- third_party/blink/renderer/core/html/anchor_element_metrics_sender_test.cc
- third_party/blink/renderer/core/html/anchor_element_metrics_test.cc
-
Move Android SPNEGO token generation to the browser process
Changed by Clark DuVall - cduvallohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 16:55:17 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 502f66397f33a27fc8a51f44048168dba8d9ef56 Comments
Move Android SPNEGO token generation to the browser process This creates a HttpNegotiateAuthSystem interface which the network service can implement which calls out to the browser process for token generation. A NegotiateAuthSystemFactory can be passed through to the HttpAuthHandlerFactory, which will be used in the Android network service case to override the default android AuthSystem. This has been manually tested on Android with the instructions here: https://chromium.googlesource.com/chromium/src.git/+/lkgr/tools/android/kerberos/README.md If there is a more robust way of testing, please let me know. Bug: 922127 Change-Id: Ia858c157d823cafe13bcfcbd97dd19e8a85c6c68 Reviewed-on: https://chromium-review.googlesource.com/c/1413140 Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Asanka Herath <asanka@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#625231}
Changed files
- content/browser/network_service_client.cc
- content/browser/network_service_client.h
- net/BUILD.gn
- net/android/http_auth_negotiate_android.cc
- net/android/http_auth_negotiate_android.h
- net/http/http_auth_gssapi_posix.h
- net/http/http_auth_handler_factory.cc
- net/http/http_auth_handler_factory.h
- net/http/http_auth_handler_negotiate.cc
- net/http/http_auth_handler_negotiate.h
- net/http/http_auth_handler_negotiate_unittest.cc
- net/http/http_auth_sspi_win.cc
- net/http/http_auth_sspi_win.h
- net/http/http_negotiate_auth_system.h
- services/network/network_service.cc
- services/network/public/mojom/network_service.mojom
- services/network/test/test_network_service_client.cc
- services/network/test/test_network_service_client.h
- services/network/url_loader_unittest.cc
-
Fix shadowing between gfx::ITALIC and gfx::Font::ITALIC
Changed by Daniel Bratell - bratellohnoyoudont@opera.com Changed at Wednesday, 23-Jan-19 16:49:05 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c5a96bff56f107c75ecb105558a374856c59ed16 Comments
Fix shadowing between gfx::ITALIC and gfx::Font::ITALIC With the shadowing warning enabled and a sufficiently new clang, there will be warnings about gfx::Font::ITALIC (and STRIKE and UNDERSCORE) shadowing gfx::ITALIC, coming from the enum gfx::TextStyle. To prevent that shadowing, this renames the gfx enum values TEXT_STYLE_*, including a new name, TEXT_STYLE_COUNT, for what would otherwise be TEXT_STYLE_NUM_TEXT_STYLES. This shadowing problem currently prevents content (where the shadowing warning is already enabled) from using these headers together. Fixes to other shadowing problems, including enabling the shadow warning, will come in https://chromium-review.googlesource.com/c/chromium/src/+/1421104 after this has landed. Bug: 923078,794619 Change-Id: I3018054f06a2fd2dc04cc4e0e72e5a0d641e99c5 Reviewed-on: https://chromium-review.googlesource.com/c/1424799 Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#625230}
Changed files
- chrome/browser/ui/views/omnibox/omnibox_view_views.cc
- chrome/browser/vr/elements/text.cc
- ui/gfx/canvas_skia.cc
- ui/gfx/render_text.cc
- ui/gfx/render_text.h
- ui/gfx/render_text_harfbuzz.cc
- ui/gfx/render_text_mac.mm
- ui/gfx/render_text_unittest.cc
- ui/gfx/text_constants.h
- ui/views/examples/multiline_example.cc
- ui/views/examples/textfield_example.cc
-
CanvasResourceProvider: extract ResourceType list logic to a function
Changed by Miguel Casas - mcasasohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 16:48:41 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 4c8002abdf7c865d985a45a3e8c905ff3b1af26e Comments
CanvasResourceProvider: extract ResourceType list logic to a function This CL makes enum CanvasResourceType an enum class, and extracts the ResourceType fallback list selection logic out of CanvasResourceProvider::Create() -- so I can add a DCHECK() to enforce similarity between vectors. Bug: 920626 Change-Id: Icac251b0c1e7676b4eb0b1c6876a953858920eff Reviewed-on: https://chromium-review.googlesource.com/c/1423348 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#625229}
Changed files
- third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc