Builder Linux x64 Goma Canary (clobber) Build 20630

Overview

Results:

Success

Trigger Info:

Project	chromium
Revision	d35cf3f2f21a0c16279ff81e6bc94158d477e559
Got Revision	d35cf3f2f21a0c16279ff81e6bc94158d477e559

Execution:

Steps and Logfiles:

Show: Expanded Default Non-Green

( 356 ms ) setup_build
running recipe: "chromium"
- stdout
- run_recipe
( 346 ms ) report builders

running builder/tester 'Linux x64 Goma Canary (clobber)' on master 'chromium.fyi'
- stdout
- bots.json
( 55 secs ) bot_update
[70GB/295GB used (23%)]
- stdout
- json.output
( 96 ms ) ensure_goma
candidate goma client is selected
- - no logs -
1. ( 96 ms ) ensure_installed
  - stdout
  - json.output
( 849 ms ) swarming.py --version
0.14
- stdout
( 6 secs ) clobber
- stdout
( 36 secs ) gclient runhooks
- stdout
( 3 secs ) get compile targets for scripts
- stdout
- json.output
( 1 secs ) read test spec (chromium.fyi.json)
path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.fyi.json
- stdout
- json.output
( 635 ms ) clean isolated files
- stdout
( 736 ms ) lookup GN args

is_component_build = false
is_debug = false
strip_absolute_paths_from_debug_symbols = true
use_goma = true
goma_dir = "/b/swarming/w/ir/cache/goma/client"
- stdout
( 12 secs ) generate_build_files
- stdout
- swarming-targets-file.txt
( 17 secs ) preprocess_for_goma
- - no logs -
1. ( 707 ms ) goma cache directory
  - stdout
2. ( 14 secs ) start_goma
  - stdout
  - cloudtail
3. ( 1 secs ) start cloudtail
  - stdout
( 19 mins 20 secs ) compile
- stdout
( 18 secs ) compile confirm no-op
- stdout
( 22 secs ) postprocess_for_goma
- - no logs -
1. ( 1 secs ) goma_jsonstatus
  - stdout
  - json.output
2. ( 756 ms ) goma_stat
  - stdout
3. ( 777 ms ) stop_goma
  - stdout
4. ( 18 secs ) upload_log
5. ( 1 secs ) stop cloudtail
  - stdout
( 16 secs ) isolate tests
- stdout
- json.output
( 685 ms ) find isolated tests
- stdout
- json.output
( 2 secs ) test_pre_run
- - no logs -
1. ( 1 secs ) [trigger] base_unittests
  Run on OS: 'Ubuntu-14.04'
2. ( 1 secs ) [trigger] content_unittests
  Run on OS: 'Ubuntu-14.04'
( 939 ms ) wait for tasks
- stdout
- json.output
( 199 ms ) ensure swarming
- - no logs -
1. ( 199 ms ) ensure_installed
  - stdout
  - json.output
( 2 secs ) base_unittests
Run on OS: 'Ubuntu-14.04'
Shard duration: 23s
- stdout
- swarming.summary
- Merge script log
- step_metadata
- shard #0 isolated out
- shard #0 (18.4 sec) (deduped)
( 2 secs ) Upload to test-results [base_unittests]
- stdout
( 3 secs ) content_unittests
Run on OS: 'Ubuntu-14.04'
Shard duration: 31s
- stdout
- swarming.summary
- Merge script log
- step_metadata
- shard #0 isolated out
- shard #0 (23.0 sec) (deduped)
( 3 secs ) Upload to test-results [content_unittests]
- stdout
( 453 ms ) Tests statistics

Stats
Total shards: 2
Total runtime: 41s
- stdout
- detailed stats
( 0 ) recipe result
- result

Build Properties:

Name	Value	Source
$recipe_engine/path	{"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"swarm2391-c4"	setup_build
branch	"refs/heads/master"	setup_build
buildbucket	{"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548216907574745, "id": "8923570623882153920", "project": "chromium", "tags": ["builder:Linux x64 Goma Canary (clobber)", "buildset:commit/git/d35cf3f2f21a0c16279ff81e6bc94158d477e559", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/d35cf3f2f21a0c16279ff81e6bc94158d477e559", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089000686071084864", "scheduler_job_id:chromium/Linux x64 Goma Canary (clobber)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"Linux x64 Goma Canary (clobber)"	setup_build
buildnumber	20630	setup_build
mastername	"chromium.fyi"	setup_build
path_config	"generic"	setup_build
recipe	"chromium"	setup_build
repository	"https://chromium.googlesource.com/chromium/src.git"	setup_build
revision	"d35cf3f2f21a0c16279ff81e6bc94158d477e559"	setup_build
got_angle_revision	"828acb39df5fe60953dc1eca00b8d3cd25a63ab7"	bot_update
got_buildtools_revision	"2f02e1f363b1af2715536f38e239853f04ec1497"	bot_update
got_dawn_revision	"c0f31e73e481f32d308cb6232e75e6d860d97063"	bot_update
got_nacl_revision	"ff15c51d20785fa51c0ef03ccb480b87299acbeb"	bot_update
got_revision	"d35cf3f2f21a0c16279ff81e6bc94158d477e559"	bot_update
got_revision_cp	"refs/heads/master@{#625081}"	bot_update
got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	bot_update
got_v8_revision	"0550ef03cf24c364d888fa381ae88400d3ff42f2"	bot_update
got_v8_revision_cp	"refs/heads/7.3.484@{#1}"	bot_update
got_webrtc_revision	"71b5a7df7794bbc4103296fcd8bd740acebdc901"	bot_update
got_webrtc_revision_cp	"refs/heads/master@{#26351}"	bot_update
isolate_server	"https://isolateserver.appspot.com"	isolate tests
swarm_hashes_refs/heads/master(at){#625081}_without_patch	{"base_unittests": "a68911e1481ead45361beaf74f9601a826d44860", "content_unittests": "ad4ae31358fe22913107e8c7c9ed8a4a18c120b9"}	isolate tests
swarm_hashes	{"base_unittests": "a68911e1481ead45361beaf74f9601a826d44860", "content_unittests": "ad4ae31358fe22913107e8c7c9ed8a4a18c120b9"}	find isolated tests

Blamelist:

David Black (dmblackohnoyoudont@google.com)
John Williams (jrwohnoyoudont@google.com)
CJ DiMeglio (lethalantidoteohnoyoudont@chromium.org)
Matt Reynolds (mattreynoldsohnoyoudont@google.com)
chrome-release-bot (chrome-release-botohnoyoudont@chromium.org)
Jonathan Metzman (metzmanohnoyoudont@chromium.org)
Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
Khushal (khushalsagarohnoyoudont@chromium.org)
Alexandre Courbot (acourbotohnoyoudont@chromium.org)
Kinuko Yasuda (kinukoohnoyoudont@chromium.org)

Timing:

Create	Wednesday, 23-Jan-19 04:15:07 UTC
Start	Wednesday, 23-Jan-19 04:15:09 UTC
End	Wednesday, 23-Jan-19 04:38:18 UTC
Pending	2 secs
Execution	23 mins 8 secs

All Changes:

Handle frequent PowerChanged events in Assistant service.

Changed by	David Black - dmblackohnoyoudont@google.com
Changed at	Wednesday, 23-Jan-19 04:12:26 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	d35cf3f2f21a0c16279ff81e6bc94158d477e559

Comments

Handle frequent PowerChanged events in Assistant service.

The PowerManagerClient::Observer::PowerChanged event fires periodically,
not only with updates as was previously assumed. This causes the
Assistant service to restart LibAssistant too eagerly which has a side
effect of closing Assistant UI.

Now, we'll only handle the deltas that we're intersted in.

PowerManagerClient::Observer::PowerChanged documentation:
https://cs.chromium.org/chromium/src/chromeos/dbus/power_manager_client.h?type=cs&q=powermanagerclient::observer&g=0&l=95

Bug: b:123245601
Change-Id: I620ca1d1f03fad82bae88762b84d08e1546381a1
Reviewed-on: https://chromium-review.googlesource.com/c/1428519
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#625081}

Changed files

chromeos/services/assistant/service.cc

Introduced cast_session::Result for reporting success/failure results.

Changed by	John Williams - jrwohnoyoudont@google.com
Changed at	Wednesday, 23-Jan-19 04:12:14 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	0fe0f9679fa598620deafeaf7b141458adf7abe8

Comments

Introduced cast_session::Result for reporting success/failure results.

Change-Id: I25000d6f2dbbdc84c601e83d05d8327455382e5c
Reviewed-on: https://chromium-review.googlesource.com/c/1423136
Commit-Queue: John Williams <jrw@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625080}

Changed files

chrome/browser/media/router/providers/cast/cast_activity_manager.cc
chrome/browser/media/router/providers/cast/cast_activity_manager.h
chrome/browser/media/router/providers/cast/cast_activity_manager_unittest.cc
components/cast_channel/cast_message_handler.cc
components/cast_channel/cast_message_handler.h
components/cast_channel/cast_message_handler_unittest.cc
components/cast_channel/cast_test_util.h

Adds Aria Labels for PiP.

Changed by	CJ DiMeglio - lethalantidoteohnoyoudont@chromium.org
Changed at	Wednesday, 23-Jan-19 04:11:09 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	7b44032440abb5edcb98c6af0df4f774760a59ba

Comments

Adds Aria Labels for PiP.

This CL changes the picture-in-picture button to use aria attributes instead of
explicitly creating accessibility nodes.

Bug: 836549
Change-Id: I35e8a20f570e8068f85cb2203580325c935dde55
Reviewed-on: https://chromium-review.googlesource.com/c/1391862
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625079}

Changed files

third_party/blink/renderer/modules/accessibility/ax_media_controls.cc
third_party/blink/renderer/modules/media_controls/elements/media_control_element_type.h
third_party/blink/renderer/modules/media_controls/elements/media_control_picture_in_picture_button_element.cc
third_party/blink/renderer/modules/media_controls/elements/media_control_picture_in_picture_button_element.h
third_party/blink/web_tests/media/controls/accessibility-picture-in-picture-button.html
third_party/blink/web_tests/media/media-controls.js

Rename FIDO mock for device::mojom::HidConnection

Changed by	Matt Reynolds - mattreynoldsohnoyoudont@google.com
Changed at	Wednesday, 23-Jan-19 04:10:58 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	2353fb67877b5b744b5d8c284b15a20ee5a198c7

Comments

Rename FIDO mock for device::mojom::HidConnection

The //device/fido/hid unittests defined a MockHidConnection type
that conflicts with the identically-named type in
//services/device/hid. This CL renames the FIDO mock to
MockFidoHidConnection.

BUG=None

Change-Id: Ief80f6e8fb389c64aa99f1da5eea3739395016cf
Reviewed-on: https://chromium-review.googlesource.com/c/1418899
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625078}

Changed files

device/fido/hid/fake_hid_impl_for_testing.cc
device/fido/hid/fake_hid_impl_for_testing.h
device/fido/hid/fido_hid_device_unittest.cc

Updating trunk VERSION from 3681.0 to 3682.0

Changed by	chrome-release-bot - chrome-release-botohnoyoudont@chromium.org
Changed at	Wednesday, 23-Jan-19 04:10:19 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	4e0b0992819dc5a50854be5aa2ca0fb9afdb4a13

Comments

Updating trunk VERSION from 3681.0 to 3682.0

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=cmasso@chromium.org

Change-Id: I4460ee0662cf3a5793e53f9f3df6aa82651411b2
Reviewed-on: https://chromium-review.googlesource.com/c/1429579
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625077}

Changed files

chrome/VERSION

[libFuzzer][Windows] Don't build sqlite3_lpm_corpus_gen

Changed by	Jonathan Metzman - metzmanohnoyoudont@chromium.org
Changed at	Wednesday, 23-Jan-19 04:09:55 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	aaa056f4368075cbce12ea7ee3be6222186fd42d

Comments

[libFuzzer][Windows] Don't build sqlite3_lpm_corpus_gen

Don't build sqlite3_lpm_corpus_gen on Windows. It breaks the clang ToT
bot because it uses getpid, among other things, and there isn't any
demand for running it on Windows.

Change-Id: I9bf982e4a9802f2ad5ccfde604f1648a146e6a6f
Bug: 903078
Reviewed-on: https://chromium-review.googlesource.com/c/1427904
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625076}

Changed files

third_party/sqlite/BUILD.gn

SignedExchange: Update version parameter of Accept header to b3

Changed by	Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org
Changed at	Wednesday, 23-Jan-19 04:09:43 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	d6373b2dab1cdbec67555d2533ff5819ffc6541b

Comments

SignedExchange: Update version parameter of Accept header to b3

Bug: 924020
Change-Id: Ib1d168ddb3c9009c6b4fc4dff2ced6816af1529f
Reviewed-on: https://chromium-review.googlesource.com/c/1425850
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625075}

Changed files

content/browser/loader/prefetch_browsertest.cc
content/browser/loader/prefetch_url_loader.cc
content/browser/web_package/signed_exchange_consts.h
content/browser/web_package/signed_exchange_handler.cc
content/browser/web_package/signed_exchange_request_handler_browsertest.cc
third_party/blink/web_tests/http/tests/misc/xhtml-expected.txt

cc: Avoid hardcoding size limits in paint deserialization.

Changed by	Khushal - khushalsagarohnoyoudont@chromium.org
Changed at	Wednesday, 23-Jan-19 04:08:32 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	361a36b23b69d3d3d3c0503580cfb3afa1d5de1b

Comments

cc: Avoid hardcoding size limits in paint deserialization.

Avoid using hardcoded size limits for ensuring sane memory allocations
during paint deserializations. Instead make sure we don't allocate more
than the remaining bytes to read.

R=enne@chromium.org

Bug: 924042
Change-Id: Ib4acf3a9d1887b71c7fa23a62f6ff138649f9042
Reviewed-on: https://chromium-review.googlesource.com/c/1427560
Commit-Queue: Khushal <khushalsagar@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625074}

Changed files

cc/paint/paint_op_reader.cc

media/gpu/v4l2: fix bug preventing decoding on devices using IP

Changed by	Alexandre Courbot - acourbotohnoyoudont@chromium.org
Changed at	Wednesday, 23-Jan-19 04:08:28 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	00d5413e503533bdd2f4eb977ed2be7ce32898a0

Comments

media/gpu/v4l2: fix bug preventing decoding on devices using IP

CL crrev.com/c/1424683 introduced a bug that caused output buffers to
never be made available for decoding when using an image processor. The
bug slipped in because it did not manifest when rendering was disabled.
Fix this by ensuring that buffers are released for decoding both when
rendering is disabled, and when an image processor is present.

Bug: 920908
Test: Checked that VDA unittest passed on Hana and Nyan with rendering
both enabled and disabled.
Test: Checked that H.264 playback on crosvideo.appspot.com was correct
on Hana and Nyan.

Change-Id: I54f9b06f5df671d400e606545f9c16580688abcc
Reviewed-on: https://chromium-review.googlesource.com/c/1428623
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Auto-Submit: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625073}

Changed files

media/gpu/v4l2/v4l2_video_decode_accelerator.cc

Revert "Tracing: Start the tracing service on-demand"

Changed by	Kinuko Yasuda - kinukoohnoyoudont@chromium.org
Changed at	Wednesday, 23-Jan-19 03:55:40 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	ecf22aee39d1e7134a35ceccd0fc43ff7919251a

Comments

Revert "Tracing: Start the tracing service on-demand"

This reverts commit b99afc65a575475141a42235bc8dbfa9bc277427.

Reason for revert: Suspected that it broke build

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8923573116361840720/+/steps/compile/0/stdout

Original change's description:
> Tracing: Start the tracing service on-demand
> 
> Instead of each process connecting to the tracing service
> on startup, the tracing service is now instead brought
> up on demand (when something binds the Coordinator interface)
> and will then pass pointers to the AgentRegistry and
> PerfettoService to the other services so they can register themselves.
> 
> This is a prerequisite to having the tracing service run as a
> sandboxed service (or we would always have a new background process
> running): https://chromium-review.googlesource.com/c/chromium/src/+/1412016
> 
> Requires these prior CLs for service_manager manifest support:
> * https://chromium-review.googlesource.com/c/chromium/src/+/1410124
> * https://chromium-review.googlesource.com/c/chromium/src/+/1410384
> 
> TBR=yusukes@chromium.org (for trivial CrOS change)
> 
> Bug: 914579
> Change-Id: Ia1c92fe2aa75e3411efbd119cb9443e8a78e4c8f
> Reviewed-on: https://chromium-review.googlesource.com/c/1377593
> Commit-Queue: oysteine <oysteine@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Eric Seckler <eseckler@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Reviewed-by: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#625059}

TBR=yusukes@chromium.org,rockot@google.com,chiniforooshan@chromium.org,haraken@chromium.org,oysteine@chromium.org,skyostil@chromium.org,tsepez@chromium.org,eseckler@chromium.org

Change-Id: I581b356d2ef29e49c816eca570e4e05a5c971e65
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 914579
Reviewed-on: https://chromium-review.googlesource.com/c/1428625
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625072}

Changed files

chrome/browser/chromeos/arc/tracing/arc_tracing_bridge.cc
content/browser/tracing/background_tracing_manager_impl.cc
content/browser/tracing/tracing_controller_browsertest.cc
content/browser/tracing/tracing_controller_impl.cc
content/browser/tracing/tracing_controller_impl.h
content/child/child_thread_impl.cc
content/child/child_thread_impl.h
services/service_manager/public/cpp/BUILD.gn
services/service_manager/public/cpp/DEPS
services/service_manager/public/cpp/service_binding.cc
services/tracing/BUILD.gn
services/tracing/agent_registry.cc
services/tracing/agent_registry.h
services/tracing/coordinator.cc
services/tracing/coordinator.h
services/tracing/coordinator_unittest.cc
services/tracing/manifest.cc
services/tracing/perfetto/perfetto_service.cc
services/tracing/perfetto/perfetto_service.h
services/tracing/perfetto/perfetto_tracing_coordinator.cc
services/tracing/perfetto/perfetto_tracing_coordinator.h
services/tracing/public/DEPS
services/tracing/public/cpp/BUILD.gn
services/tracing/public/cpp/base_agent.cc
services/tracing/public/cpp/base_agent.h
services/tracing/public/cpp/perfetto/producer_client.cc
services/tracing/public/cpp/perfetto/producer_client.h
services/tracing/public/cpp/trace_event_agent.cc
services/tracing/public/cpp/trace_event_agent.h
services/tracing/public/cpp/traced_process.cc
services/tracing/public/cpp/traced_process.h
services/tracing/public/mojom/tracing.mojom
services/tracing/tracing_service.cc
services/tracing/tracing_service.h
services/tracing/tracing_service_unittest.cc