Builder Linux x64 Goma Canary (clobber) Build 20595

Results:

Success

Trigger Info:

Project	chromium
Revision	5806d65535351c927454bb79ce4bc1030af0d30b
Got Revision	5806d65535351c927454bb79ce4bc1030af0d30b

Execution:

• Source: Task 428dd274e6408a10
• Bot: swarm2391-c4
• Recipe: chromium

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 351 ms ) setup_build

   running recipe: "chromium"
   • stdout
   • run_recipe
2. ( 340 ms ) report builders

    

   running builder/tester 'Linux x64 Goma Canary (clobber)' on master 'chromium.fyi'
   • stdout
   • bots.json
3. ( 54 secs ) bot_update

   [70GB/295GB used (23%)]
   • stdout
   • json.output
4. ( 174 ms ) ensure_goma

   candidate goma client is selected
   • - no logs -
   1. ( 174 ms ) ensure_installed
      • stdout
      • json.output
5. ( 811 ms ) swarming.py --version

   0.14
   • stdout
6. ( 6 secs ) clobber
   • stdout
7. ( 31 secs ) gclient runhooks
   • stdout
8. ( 3 secs ) get compile targets for scripts
   • stdout
   • json.output
9. ( 1 secs ) read test spec (chromium.fyi.json)

   path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.fyi.json
   • stdout
   • json.output
10. ( 629 ms ) clean isolated files
    • stdout
11. ( 709 ms ) lookup GN args

     

    is_component_build = false

    is_debug = false

    strip_absolute_paths_from_debug_symbols = true

    use_goma = true

    goma_dir = "/b/swarming/w/ir/cache/goma/client"
    • stdout
12. ( 11 secs ) generate_build_files
    • stdout
    • swarming-targets-file.txt
13. ( 16 secs ) preprocess_for_goma
    • - no logs -
    1. ( 692 ms ) goma cache directory
       • stdout
    2. ( 14 secs ) start_goma
       • stdout
       • cloudtail
    3. ( 1 secs ) start cloudtail
       • stdout
14. ( 18 mins 59 secs ) compile
    • stdout
15. ( 20 secs ) compile confirm no-op
    • stdout
16. ( 19 secs ) postprocess_for_goma
    • - no logs -
    1. ( 801 ms ) goma_jsonstatus
       • stdout
       • json.output
    2. ( 738 ms ) goma_stat
       • stdout
    3. ( 771 ms ) stop_goma
       • stdout
    4. ( 15 secs ) upload_log
       • stdout
       • json.output
       • compiler_proxy_log
       • ninja_log
    5. ( 1 secs ) stop cloudtail
       • stdout
17. ( 13 secs ) isolate tests
    • stdout
    • json.output
18. ( 660 ms ) find isolated tests
    • stdout
    • json.output
19. ( 2 secs ) test_pre_run
    • - no logs -
    1. ( 1 secs ) [trigger] base_unittests

       Run on OS: 'Ubuntu-14.04'
       • stdout
       • json.output
       • shard #0
    2. ( 1 secs ) [trigger] content_unittests

       Run on OS: 'Ubuntu-14.04'
       • stdout
       • json.output
       • shard #0
20. ( 958 ms ) wait for tasks
    • stdout
    • json.output
21. ( 242 ms ) ensure swarming
    • - no logs -
    1. ( 242 ms ) ensure_installed
       • stdout
       • json.output
22. ( 2 secs ) base_unittests

    Run on OS: 'Ubuntu-14.04'

    Shard duration: 23s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (17.4 sec) (deduped)
23. ( 2 secs ) Upload to test-results [base_unittests]
    • stdout
24. ( 3 secs ) content_unittests

    Run on OS: 'Ubuntu-14.04'

    Shard duration: 31s
    • stdout
    • swarming.summary
    • Merge script log
    • step_metadata
    • shard #0 isolated out
    • shard #0 (23.3 sec) (deduped)
25. ( 3 secs ) Upload to test-results [content_unittests]
    • stdout
26. ( 403 ms ) Tests statistics

     

    Stats

    Total shards: 2

    Total runtime: 40s

     
    • stdout
    • detailed stats
27. ( 0 ) recipe result
    • result

Build Properties:

Name	Value	Source
$recipe_engine/path	{"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"swarm2391-c4"	setup_build
branch	"refs/heads/master"	setup_build
buildbucket	{"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548151219780358, "id": "8923639502526007552", "project": "chromium", "tags": ["builder:Linux x64 Goma Canary (clobber)", "buildset:commit/git/5806d65535351c927454bb79ce4bc1030af0d30b", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/5806d65535351c927454bb79ce4bc1030af0d30b", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089069564863589104", "scheduler_job_id:chromium/Linux x64 Goma Canary (clobber)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"Linux x64 Goma Canary (clobber)"	setup_build
buildnumber	20595	setup_build
mastername	"chromium.fyi"	setup_build
path_config	"generic"	setup_build
recipe	"chromium"	setup_build
repository	"https://chromium.googlesource.com/chromium/src.git"	setup_build
revision	"5806d65535351c927454bb79ce4bc1030af0d30b"	setup_build
got_angle_revision	"c81e7bfeb5580726f995776ed04fc4517d6d9c27"	bot_update
got_buildtools_revision	"2f02e1f363b1af2715536f38e239853f04ec1497"	bot_update
got_dawn_revision	"c0f31e73e481f32d308cb6232e75e6d860d97063"	bot_update
got_nacl_revision	"ff15c51d20785fa51c0ef03ccb480b87299acbeb"	bot_update
got_revision	"5806d65535351c927454bb79ce4bc1030af0d30b"	bot_update
got_revision_cp	"refs/heads/master@{#624752}"	bot_update
got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	bot_update
got_v8_revision	"7b7a1521956e0f499a6b0170e3a421c109a2288e"	bot_update
got_v8_revision_cp	"refs/heads/7.3.471@{#1}"	bot_update
got_webrtc_revision	"74ba99062c48b278675cfe52643719202296fddc"	bot_update
got_webrtc_revision_cp	"refs/heads/master@{#26298}"	bot_update
isolate_server	"https://isolateserver.appspot.com"	isolate tests
swarm_hashes_refs/heads/master(at){#624752}_without_patch	{"base_unittests": "93b7efffeb780a97bd133687aa5bffb9b872831f", "content_unittests": "ccd6274be89c0558cd73f0d30e4dd4557aa12e32"}	isolate tests
swarm_hashes	{"base_unittests": "93b7efffeb780a97bd133687aa5bffb9b872831f", "content_unittests": "ccd6274be89c0558cd73f0d30e4dd4557aa12e32"}	find isolated tests

Blamelist:

1. A Olsen (olsenohnoyoudont@chromium.org)
2. Tanja Gornak (melandoryohnoyoudont@chromium.org)

Timing:

Create	Tuesday, 22-Jan-19 10:00:19 UTC
Start	Tuesday, 22-Jan-19 10:00:24 UTC
End	Tuesday, 22-Jan-19 10:23:00 UTC
Pending	4 secs
Execution	22 mins 35 secs

All Changes:

1. Wire up StatsReportingController, don't use CrosSettings::Set

   Changed by	A Olsen - olsenohnoyoudont@chromium.org
   Changed at	Tuesday, 22-Jan-19 09:58:20 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	5806d65535351c927454bb79ce4bc1030af0d30b

   Comments

   Wire up StatsReportingController, don't use CrosSettings::Set
   
   StatsReportingController is used instead of CrosSettings::Set.
   CrosSettings::Set is discouraged due to mostly-unneeded complexity,
   and the way it always gives the callers owner-like privileges -
   see the bug.
   
   This is the last use of CrosSettings::Set. After this change,
   CrosSettings::Set and DeviceSettingsProvider::Set can be removed.
   Hopefully, this will mean CrosSettings and DeviceSettingsProvider
   have less dependencies, which is why I am doing this.
   
   StatsReportingController needs to be called when ownership is
   taken. The existing code which handles this scenario is in
   DeviceSettingsProvider, so the call to OnOwnershipTaken is made
   from there. Because StatsReportingController is taking over
   some of DeviceSettingsProviders functionality, it now makes
   less sense for the existing code to be there - but this, along
   with the new call, can be moved in a later CL.
   
   Bug: 433840
   Change-Id: I5ae99235e2f746f464b61dfdc13dd0d650bde6bb
   Reviewed-on: https://chromium-review.googlesource.com/c/1402765
   Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
   Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
   Reviewed-by: Dominic Battré <battre@chromium.org>
   Reviewed-by: Jochen Eisinger <jochen@chromium.org>
   Reviewed-by: Mattias Nissler <mnissler@chromium.org>
   Reviewed-by: Lutz Justen <ljusten@chromium.org>
   Commit-Queue: A Olsen <olsen@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624752}

   Changed files

   • chrome/browser/chrome_browser_main.cc
   • chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc
   • chrome/browser/chromeos/arc/intent_helper/arc_settings_service_unittest.cc
   • chrome/browser/chromeos/arc/optin/arc_optin_preference_handler.cc
   • chrome/browser/chromeos/arc/optin/arc_optin_preference_handler.h
   • chrome/browser/chromeos/arc/optin/arc_terms_of_service_default_negotiator_unittest.cc
   • chrome/browser/chromeos/login/wizard_controller.cc
   • chrome/browser/chromeos/settings/cros_settings.h
   • chrome/browser/chromeos/settings/device_settings_provider.cc
   • chrome/browser/chromeos/settings/stats_reporting_controller.cc
   • chrome/browser/chromeos/settings/stats_reporting_controller.h
   • chrome/browser/chromeos/settings/stats_reporting_controller_unittest.cc
   • chrome/browser/metrics/chrome_metrics_services_manager_client.cc
   • chrome/browser/metrics/chrome_metrics_services_manager_client.h
   • chrome/browser/prefs/browser_prefs.cc

2. [Tango->FCM] Add unittests, which verify that failed subscription requests are retried

   Changed by	Tanja Gornak - melandoryohnoyoudont@chromium.org
   Changed at	Tuesday, 22-Jan-19 09:56:00 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	f02a2b780c207e538eadda309f79de0b36db9f70

   Comments

   [Tango->FCM] Add unittests, which verify that failed subscription requests are retried
   
   When the subscription request has failed, PerUserTopicRegistrationManager re-schedules
   it. This CL adds unittests to verify that the request is rescheduled.
   
   Bug: 801985, 878446
   Change-Id: I98e5f34c7b83902a7bb5f63089a7405e81db5e8d
   Reviewed-on: https://chromium-review.googlesource.com/c/1424841
   Commit-Queue: Tatiana Gornak <melandory@chromium.org>
   Reviewed-by: Mikel Astiz <mastiz@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624751}

   Changed files

   • components/invalidation/impl/per_user_topic_registration_manager.h
   • components/invalidation/impl/per_user_topic_registration_manager_unittest.cc