Builder Linux x64 Goma Canary (clobber) Build 20588
Results:
Success
Trigger Info:
Project | chromium |
Revision | 474733a1f1007ba9c84e27603863a27a8066d2b2 |
Got Revision | 474733a1f1007ba9c84e27603863a27a8066d2b2 |
Execution:
- Source: Task 428d3a3652d02710
- Bot: swarm2391-c4
- Recipe: chromium
Steps and Logfiles:
Show:-
( 342 ms ) report buildersrunning builder/tester 'Linux x64 Goma Canary (clobber)' on master 'chromium.fyi'
-
- - no logs -
-
( 1 secs ) read test spec (chromium.fyi.json)path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.fyi.json
-
( 707 ms ) lookup GN argsis_component_build = falseis_debug = falsestrip_absolute_paths_from_debug_symbols = trueuse_goma = truegoma_dir = "/b/swarming/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm2391-c4" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548141243273909, "id": "8923649963651729248", "project": "chromium", "tags": ["builder:Linux x64 Goma Canary (clobber)", "buildset:commit/git/474733a1f1007ba9c84e27603863a27a8066d2b2", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/474733a1f1007ba9c84e27603863a27a8066d2b2", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089080025757242704", "scheduler_job_id:chromium/Linux x64 Goma Canary (clobber)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "Linux x64 Goma Canary (clobber)" | setup_build |
buildnumber | 20588 | setup_build |
mastername | "chromium.fyi" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
repository | "https://chromium.googlesource.com/chromium/src.git" | setup_build |
revision | "474733a1f1007ba9c84e27603863a27a8066d2b2" | setup_build |
got_angle_revision | "c81e7bfeb5580726f995776ed04fc4517d6d9c27" | bot_update |
got_buildtools_revision | "2f02e1f363b1af2715536f38e239853f04ec1497" | bot_update |
got_dawn_revision | "c0f31e73e481f32d308cb6232e75e6d860d97063" | bot_update |
got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
got_revision | "474733a1f1007ba9c84e27603863a27a8066d2b2" | bot_update |
got_revision_cp | "refs/heads/master@{#624737}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "7b7a1521956e0f499a6b0170e3a421c109a2288e" | bot_update |
got_v8_revision_cp | "refs/heads/7.3.471@{#1}" | bot_update |
got_webrtc_revision | "74ba99062c48b278675cfe52643719202296fddc" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26298}" | bot_update |
isolate_server | "https://isolateserver.appspot.com" | isolate tests |
swarm_hashes_refs/heads/master(at){#624737}_without_patch | {"base_unittests": "446859197be1eac9827529ccbbc7e331267ed0e3", "content_unittests": "981b894e4a423a4e742cdf18f685508f9c51d7a1"} | isolate tests |
swarm_hashes | {"base_unittests": "446859197be1eac9827529ccbbc7e331267ed0e3", "content_unittests": "981b894e4a423a4e742cdf18f685508f9c51d7a1"} | find isolated tests |
Blamelist:
- Dominic Mazzoni (dmazzoniohnoyoudont@chromium.org)
Timing:
Create | Tuesday, 22-Jan-19 07:14:03 UTC |
Start | Tuesday, 22-Jan-19 07:14:48 UTC |
End | Tuesday, 22-Jan-19 07:37:30 UTC |
Pending | 44 secs |
Execution | 22 mins 42 secs |
All Changes:
-
Reland "Fix bottleneck in AXObject::GetWordBoundaries"
Changed by Dominic Mazzoni - dmazzoniohnoyoudont@chromium.org Changed at Tuesday, 22-Jan-19 07:13:23 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 474733a1f1007ba9c84e27603863a27a8066d2b2 Comments
Reland "Fix bottleneck in AXObject::GetWordBoundaries" This reverts commit 3064da20981be73b7acf2128dd407a5f3da78165. Reason for revert: Purpose of original revert was just to see that it was reflected on chromeperf. I can now confirm that reverting this change does result in a significant performance drop, so relanding it is worth it. Original change's description: > Revert "Fix bottleneck in AXObject::GetWordBoundaries" > > This reverts commit c9218a18e39eb3e42245ee74f159594611d1e36f. > > Reason for revert: Temporarily reverting in order to see > if the performance on chromeperf changes. > > Original change's description: > > Fix bottleneck in AXObject::GetWordBoundaries > > > > GetWordBoundaries is only used on an AXInlineTextBox, so it only needs > > to return integer start and end offsets within a single node. It was > > inefficient for it to return AXRanges, since AXRanges span multiple nodes > > and do lots of validation and normalization. > > > > This change leads to a ~3x speedup of this benchmark > > (added in http://crrev.com/c/1410175): > > third_party/blink/perf_tests/accessibility/line-breaks.html > > > > TBR=mkwst@chromium.org > > > > Bug: 921789 > > Change-Id: I826feedc7863caa5ce4baa11de0971e68b1bf114 > > Reviewed-on: https://chromium-review.googlesource.com/c/1411212 > > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#623411} > > TBR=dmazzoni@chromium.org,aboxhall@chromium.org,mkwst@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 921789 > Change-Id: Icdb625c4563691cb4771dd829f49f06cc165181c > Reviewed-on: https://chromium-review.googlesource.com/c/1426170 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624700} TBR=dmazzoni@chromium.org,aboxhall@chromium.org,mkwst@chromium.org Change-Id: I775847259836684f1212610c66f5b0f0cbf3893c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 921789 Reviewed-on: https://chromium-review.googlesource.com/c/1426520 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#624737}
Changed files
- third_party/blink/renderer/modules/accessibility/ax_inline_text_box.cc
- third_party/blink/renderer/modules/accessibility/ax_inline_text_box.h
- third_party/blink/renderer/modules/accessibility/ax_object.cc
- third_party/blink/renderer/modules/accessibility/ax_object.h
- third_party/blink/renderer/modules/exported/web_ax_object.cc