Builder Linux Tests Build 74179
Results:
Success
Trigger Info:
Project | chromium |
Revision | e324812251510778815829c1b07043b6d53f8414 |
Got Revision | e324812251510778815829c1b07043b6d53f8414 |
Execution:
- Source: Task 41a023406257e910
- Bot: swarm966-c4
- Recipe: chromium
Steps and Logfiles:
Show:-
- - no logs -
-
( 601 ms ) read test spec (chromium.linux.json)path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.linux.json
-
( 535 ms ) lookup builder GN argsffmpeg_branding = "Chrome"is_component_build = falseis_debug = falseproprietary_codecs = truestrip_absolute_paths_from_debug_symbols = trueuse_goma = truegoma_dir = "/b/swarming/w/ir/cache/goma/client"
-
- - no logs -
-
( 1 secs ) network_service_interactive_ui_testsRun on OS: 'Ubuntu-14.04'Max shard duration: 0:03:30.017752 (shard #0)Min shard duration: 0:02:20.267560 (shard #1)
-
( 1 secs ) metrics_python_testsRun on OS: 'Ubuntu-14.04'Shard duration: 5sTotal tests: 74* Passed: 74 (74 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
( 1 secs ) telemetry_gpu_unittestsRun on OS: 'Ubuntu-14.04'Shard duration: 35sTotal tests: 38* Passed: 38 (38 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
( 3 mins 7 secs ) not_site_per_process_webkit_layout_testsRun on OS: 'Ubuntu-14.04'Max shard duration: 0:08:41.914265 (shard #2)Min shard duration: 0:07:03.279902 (shard #1)Total tests: 91887* Passed: 78769 (78720 expected, 49 unexpected)* Skipped: 10464 (10464 expected, 0 unexpected)* Failed: 2564 (2564 expected, 0 unexpected)* Flaky: 90 (90 expected, 0 unexpected)
- stdout
- json.output
- swarming.summary
- Merge script log
- outdir_json
- step_metadata
- shard #0 isolated out
- shard #0 (396.7 sec)
- shard #1 isolated out
- shard #1 (378.2 sec)
- shard #2 isolated out
- shard #2 (466.6 sec)
- shard #3 isolated out
- shard #3 (400.3 sec)
- shard #4 isolated out
- shard #4 (403.1 sec)
- shard #5 isolated out
- shard #5 (428.7 sec)
- shard #6 isolated out
- shard #6 (435.9 sec)
- shard #7 isolated out
- shard #7 (420.5 sec)
- shard #8 isolated out
- shard #8 (386.1 sec)
- shard #9 isolated out
- shard #9 (405.8 sec)
-
( 4 secs ) network_service_content_browsertestsRun on OS: 'Ubuntu-14.04'Max shard duration: 0:04:31.405050 (shard #0)Min shard duration: 0:03:55.604676 (shard #1)
-
( 2 secs ) telemetry_unittestsRun on OS: 'Ubuntu-14.04'Max shard duration: 0:06:33.633465 (shard #1)Min shard duration: 0:05:50.856701 (shard #0)Total tests: 1148* Passed: 1080 (1080 expected, 0 unexpected)* Skipped: 68 (68 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
( 2 secs ) webui_polymer2_browser_testsRun on OS: 'Ubuntu-14.04'Max shard duration: 0:02:02.623342 (shard #2)Min shard duration: 0:01:55.617215 (shard #0)
-
( 2 secs ) webkit_python_testsRun on OS: 'Ubuntu-14.04'Shard duration: 11sTotal tests: 1590* Passed: 1590 (1590 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
( 1 secs ) telemetry_perf_unittestsRun on OS: 'Ubuntu-14.04'Max shard duration: 0:09:17.668904 (shard #1)Min shard duration: 0:04:11.188649 (shard #10)Total tests: 310* Passed: 235 (235 expected, 0 unexpected)* Skipped: 75 (75 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
- stdout
- json.output
- swarming.summary
- Merge script log
- outdir_json
- step_metadata
- shard #0 isolated out
- shard #0 (299.0 sec)
- shard #1 isolated out
- shard #1 (499.1 sec)
- shard #2 isolated out
- shard #2 (465.7 sec)
- shard #3 isolated out
- shard #3 (402.2 sec)
- shard #4 isolated out
- shard #4 (331.9 sec)
- shard #5 isolated out
- shard #5 (394.8 sec)
- shard #6 isolated out
- shard #6 (354.1 sec)
- shard #7 isolated out
- shard #7 (406.2 sec)
- shard #8 isolated out
- shard #8 (435.5 sec)
- shard #9 isolated out
- shard #9 (344.9 sec)
- shard #10 isolated out
- shard #10 (240.0 sec)
- shard #11 isolated out
- shard #11 (353.2 sec)
-
( 1 secs ) interactive_ui_testsRun on OS: 'Ubuntu-14.04'Max shard duration: 0:02:33.745511 (shard #0)Min shard duration: 0:02:20.741403 (shard #2)
-
( 6 secs ) network_service_browser_testsRun on OS: 'Ubuntu-14.04'Max shard duration: 0:04:48.037964 (shard #6)Min shard duration: 0:03:20.174552 (shard #4)
- stdout
- swarming.summary
- Merge script log
- step_metadata
- shard #0 isolated out
- shard #0 (234.9 sec)
- shard #1 isolated out
- shard #1 (237.1 sec)
- shard #2 isolated out
- shard #2 (248.8 sec)
- shard #3 isolated out
- shard #3 (220.6 sec)
- shard #4 isolated out
- shard #4 (189.7 sec)
- shard #5 isolated out
- shard #5 (228.4 sec)
- shard #6 isolated out
- shard #6 (272.1 sec)
- shard #7 isolated out
- shard #7 (235.8 sec)
- shard #8 isolated out
- shard #8 (266.2 sec)
- shard #9 isolated out
- shard #9 (193.5 sec)
- shard #10 isolated out
- shard #10 (234.2 sec)
- shard #11 isolated out
- shard #11 (237.6 sec)
- shard #12 isolated out
- shard #12 (265.9 sec)
- shard #13 isolated out
- shard #13 (218.3 sec)
- shard #14 isolated out
- shard #14 (233.1 sec)
-
( 8 secs ) browser_testsRun on OS: 'Ubuntu-14.04'Max shard duration: 0:06:30.761305 (shard #2)Min shard duration: 0:05:09.154385 (shard #4)
- stdout
- swarming.summary
- Merge script log
- step_metadata
- shard #0 isolated out
- shard #0 (349.2 sec)
- shard #1 isolated out
- shard #1 (344.5 sec)
- shard #2 isolated out
- shard #2 (377.7 sec)
- shard #3 isolated out
- shard #3 (337.3 sec)
- shard #4 isolated out
- shard #4 (295.1 sec)
- shard #5 isolated out
- shard #5 (304.4 sec)
- shard #6 isolated out
- shard #6 (357.6 sec)
- shard #7 isolated out
- shard #7 (342.9 sec)
- shard #8 isolated out
- shard #8 (303.7 sec)
- shard #9 isolated out
- shard #9 (315.3 sec)
-
( 1 secs ) chromedriver_replay_unittestsRun on OS: 'Ubuntu-14.04'Shard duration: 6sTotal tests: 33* Passed: 33 (33 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
( 1 secs ) chromedriver_py_testsRun on OS: 'Ubuntu-14.04'Shard duration: 0:01:40.065231Total tests: 148* Passed: 148 (148 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
( 2 mins 57 secs ) webkit_layout_testsRun on OS: 'Ubuntu-14.04'Max shard duration: 0:12:47.037511 (shard #0)Min shard duration: 0:10:47.155365 (shard #3)Total tests: 91887* Passed: 78717 (78686 expected, 31 unexpected)* Skipped: 10464 (10464 expected, 0 unexpected)* Failed: 2579 (2579 expected, 0 unexpected)* Flaky: 127 (127 expected, 0 unexpected)
- stdout
- json.output
- swarming.summary
- Merge script log
- outdir_json
- step_metadata
- shard #0 isolated out
- shard #0 (686.6 sec)
- shard #1 isolated out
- shard #1 (605.6 sec)
- shard #2 isolated out
- shard #2 (589.4 sec)
- shard #3 isolated out
- shard #3 (587.3 sec)
- shard #4 isolated out
- shard #4 (663.1 sec)
- shard #5 isolated out
- shard #5 (611.0 sec)
Build Properties:
Name | Value | Source |
---|---|---|
$build/goma | {"jobs": 500} | setup_build |
$recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm966-c4" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544163538245185, "id": "8927820889679719456", "project": "chromium", "tags": ["builder:Linux Tests", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/e324812251510778815829c1b07043b6d53f8414", "gitiles_ref:refs/heads/master", "parent_buildername:Linux Builder", "parent_buildnumber:108559", "scheduler_invocation_id:9093250951854761504", "scheduler_job_id:chromium/Linux Tests", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "Linux Tests" | setup_build |
buildnumber | 74179 | setup_build |
mastername | "chromium.linux" | setup_build |
parent_buildername | "Linux Builder" | setup_build |
parent_got_angle_revision | "132d15c217e0363626a5d789861b75122f718b5d" | setup_build |
parent_got_buildtools_revision | "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" | setup_build |
parent_got_dawn_revision | "0f50114b3c6849238eedf95236137d614fed4be2" | setup_build |
parent_got_nacl_revision | "17af1e818981ebf2c492a678d4d31c9e1ee37fc7" | setup_build |
parent_got_revision | "e324812251510778815829c1b07043b6d53f8414" | setup_build |
parent_got_revision_cp | "refs/heads/master@{#614580}" | setup_build |
parent_got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | setup_build |
parent_got_v8_revision | "2192eb7f7ea45e3a7ee625cf3156f1469abed8b8" | setup_build |
parent_got_v8_revision_cp | "refs/heads/7.3.55@{#1}" | setup_build |
parent_got_webrtc_revision | "18f0c3c038fc45be6951301a3c2726e6810565d3" | setup_build |
parent_got_webrtc_revision_cp | "refs/heads/master@{#25919}" | setup_build |
parent_mastername | "chromium.linux" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
revision | "e324812251510778815829c1b07043b6d53f8414" | setup_build |
swarm_hashes | {"accessibility_unittests": "62ad2a5c987da2d17b5398d659c23d01b5c070b1", "angle_unittests": "22f21e84845c5174f02cfa559b002b70c9d79bc6", "app_shell_unittests": "a2e9845a5915884a6b6bc1def5c47d874bec54b6", "aura_unittests": "720e4c26c6a78db948c53588187a307bf33e9559", "base_unittests": "b65db03a39f4cbd751303939f36a4b1265d4ba9c", "blink_common_unittests": "a5549abb1f51ebb732edb93dd8db64c1198a9046", "blink_fuzzer_unittests": "f115e7ee0f291b3e24eff6ab5ab35f31a15f7687", "blink_heap_unittests": "54598bb088e6576451403fe71eb56984edf4aa85", "blink_platform_unittests": "6ec228491f85e92bcb4d6933cb0657a2438336a6", "boringssl_crypto_tests": "0787dbaa034190c834b8d1549d66a8402c31bd04", "boringssl_ssl_tests": "7e818fc3afa96a412b23aa586691761d6ffd9771", "browser_tests": "000d22424d5dd00e94c64c5fd3db4d5ad84d2e6e", "cacheinvalidation_unittests": "0cea8851cc6e6ac85dc364117c927e57bf16069b", "capture_unittests": "e73e00ef609f7676b68ee75a81f1e3cf976a507c", "cast_unittests": "fd962febcdb01c88c3530bd6a97d0c64a828f0fa", "cc_unittests": "3f92db765e95eff113ec189126a88408c71f2879", "chrome_app_unittests": "5440ccd22bae48b1a923c5ead4a71e162694abf5", "chromedriver_py_tests": "d9030da17bf7a5a64fed861fd6051acb941ba465", "chromedriver_replay_unittests": "2c79475fcfea940e6a9329f898a5d864d316a076", "chromedriver_unittests": "096cccdfd00ee0bbf61c2d3be151321d63e260d5", "components_browsertests": "ecdb840b059190c8870d48e52a21492ba476022b", "components_unittests": "19d5b8b3bef7732aff225d11e38224722dd0390c", "compositor_unittests": "65a5c65a1389c01b8512548808c98e8783a0ce0b", "content_browsertests": "4651e1f63111b6433c45fe9e4a34b6ace52ef996", "content_shell_crash_test": "da8ca325d6250abdff893a2e0206eb98dad7cf96", "content_unittests": "dc33b72ab90f0e38af5812273c2b770db310d681", "cronet_tests": "a69bfef7513ed25b91975ed2be0a8172acfa9e13", "cronet_unittests": "0c9b01d86af3fa4e1034711a642ebcc400a04055", "crypto_unittests": "f334a00d299553bd456d6a8bc657ca5c1d7e62ac", "dbus_unittests": "2de72441fca306b0138457c083224899d3ce4099", "device_unittests": "56eeee8f5b901af761f4eca8261193c4e7c95490", "devtools_closure_compile": "a6b41eb5aae0c73c8ac98ca5ea0e74d4406c0ad5", "devtools_eslint": "485f56cad759fb5c56dd3a7c8ba21cc73135fba0", "display_unittests": "4b02cd62990dcd9fb7e269af97dea5882b5c1a52", "events_unittests": "37e431954122d916381ef6f94d08668078832d9e", "extensions_browsertests": "12a6013a5548f2326b444ad78c64f6687e93cf75", "extensions_unittests": "fea2f568b78a87d75265fa1989c99d1da3262fd3", "filesystem_service_unittests": "688f5e845e687d29908129588d1d67ce0d7975d1", "gcm_unit_tests": "0bd957c9ad74c7e2d548823a4262ceaec511cf2d", "gfx_unittests": "9398c644dd2dd594a5275706684da18cd3a0f65a", "gin_unittests": "1307f89e796a32056f107804ba270fbc1994ab0b", "google_apis_unittests": "54f5b0a22497bc3fd41563439546efafb4331e03", "gpu_unittests": "85a178fa5ceb4102427257871b02bbbe0dcf09d6", "headless_browsertests": "a7d65f7d598f094622e3ea64b137747c08912633", "headless_unittests": "f10a68a0c18b6fd1bb35df84f0e00c5759bd8e8a", "interactive_ui_tests": "1cf506c58297bec7e11a8afe65f0eb07abc89abe", "ipc_tests": "72819b8ce05654e9fd795b3666dd21cacd973bb9", "jingle_unittests": "46b945f99381d42ff0c89a119a0e3ca755a688d3", "latency_unittests": "4e36668fde60cf283715505c17eaebcc4aab73fb", "leveldb_service_unittests": "69e7dddee84d30169134afa64b656b924c42428f", "libjingle_xmpp_unittests": "c8a65f6ee71aaeae38b012aa353408c91ecfd2bf", "media_blink_unittests": "d60a00a73e85afca97b97bbbdd07a21bb43a7020", "media_service_unittests": "3c853f165ad509465389d5a08803426477fed6f4", "media_unittests": "dd4b01f9dec9b23f4e7c9bed5f2f3fbd63376043", "message_center_unittests": "bd4dc002bf290719decc901f36f4e07eaf3394cd", "metrics_python_tests": "2056aa288e61169d34d413308effcb672d41de12", "midi_unittests": "a1f5cb57c95d44cbfc7c5ab5155402dccd1c1b49", "mojo_core_unittests": "1552293ce05f264cbab43508e23fcae16d6f0063", "mojo_unittests": "1605f329922ca63638f70a70e23cf5cd577bdd0e", "nacl_helper_nonsfi_unittests": "8810757166dbfa2bd10adae380b70593e45059f7", "nacl_loader_unittests": "ed27e8a7e93de4be9562a85a409f5baaac7928fd", "native_theme_unittests": "04e40099af856d01fe4901f06651db42b2beb336", "net_unittests": "448b19528e37edd60adbf8228ee6361a503229c5", "pdf_unittests": "ff0e734cb8a92d28aa0f45bb03934c39c715b082", "ppapi_unittests": "c766615eec4949b6aa70b423c2274f4a4b6201cc", "printing_unittests": "61c35b70363631fa4c5dc373cbf1695c9f44be5c", "remoting_unittests": "ce42b33480ec80cf82251bb9b7fb1355c2ff5ed8", "sandbox_linux_unittests": "64755b6b3ca7ca701cb7669d569129787ad7f526", "service_manager_unittests": "9944585227427258d6de806e1a5a3f62e1355fe4", "services_unittests": "a5c956f795adf4f60f1728da21f9147c3d46adf2", "shell_dialogs_unittests": "bacbc193e6bf001ebcb71aa7b16b52204e8e80ac", "skia_unittests": "25dfcc419173baf471bca30bce623b4e80c4defe", "snapshot_unittests": "f2a59e978e5034ab9261a10dfefa55ad79ccf1bb", "sql_unittests": "c0b2cbbf0fb210b2cc394650fede1fa21027ed2a", "storage_unittests": "05950ccac5961a19f8cef708c79df1d078b9afca", "sync_integration_tests": "7b633a39a6e3b2ad2f551cb17fa048d83cd96eb6", "telemetry_gpu_unittests": "48115937fe3e9b5edf0e3ba0b64a45c6454dec0d", "telemetry_perf_unittests": "b8afe7238d65d43106879f00d8dc452f2b14cdf4", "telemetry_unittests": "f58c4762c4ba8388a6197c533ae4b777efd80d45", "traffic_annotation_auditor_unittests": "bae643fc39148a00ffbca3df85ed649c0202477d", "ui_base_unittests": "9efb8ac7c1b665bf445b240b1893ed52e428f970", "ui_touch_selection_unittests": "9e2d129ad2ff4e479fda573b137b7f701f78d45a", "unit_tests": "d5da5afda781b2d6520e0cf9144fcffde1fba5a8", "url_unittests": "acfd4ea4340102bd63df4d1d64518bd10dca11ae", "views_perftests": "dc18c26dee56feff772741ebe41df62695fbc5a1", "views_unittests": "52b61da9eb3bf7adf741a80274057f9dd10f4ee1", "viz_unittests": "6cad3e76cc14ab9da18ba1d15838316e37c1408a", "vr_common_unittests": "5edc4ea58e893dc6343748f0614a14b2a3dd2ff5", "vr_pixeltests": "4401818a1f26526e2e989db8f67fbd9e6e9cc002", "webkit_layout_tests_exparchive": "c12844176004beaa0760916938c9766d24f9be1d", "webkit_python_tests": "565a840a3431845ccebea1de80c6b282dbbe3aff", "webkit_unit_tests": "d5c9ef784d1cae3c7fedd9b44e09eeeff9831127", "wm_unittests": "947d745f6c1dc325d6a369700a12c5ccb4cdf159", "wtf_unittests": "8ed2e3433222bfd796a58691019e97dc74e22a6a"} | setup_build |
got_angle_revision | "132d15c217e0363626a5d789861b75122f718b5d" | bot_update |
got_buildtools_revision | "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" | bot_update |
got_dawn_revision | "0f50114b3c6849238eedf95236137d614fed4be2" | bot_update |
got_nacl_revision | "17af1e818981ebf2c492a678d4d31c9e1ee37fc7" | bot_update |
got_revision | "e324812251510778815829c1b07043b6d53f8414" | bot_update |
got_revision_cp | "refs/heads/master@{#614580}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "2192eb7f7ea45e3a7ee625cf3156f1469abed8b8" | bot_update |
got_v8_revision_cp | "refs/heads/7.3.55@{#1}" | bot_update |
got_webrtc_revision | "18f0c3c038fc45be6951301a3c2726e6810565d3" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#25919}" | bot_update |
swarm_hashes | {"accessibility_unittests": "62ad2a5c987da2d17b5398d659c23d01b5c070b1", "angle_unittests": "22f21e84845c5174f02cfa559b002b70c9d79bc6", "app_shell_unittests": "a2e9845a5915884a6b6bc1def5c47d874bec54b6", "aura_unittests": "720e4c26c6a78db948c53588187a307bf33e9559", "base_unittests": "b65db03a39f4cbd751303939f36a4b1265d4ba9c", "blink_common_unittests": "a5549abb1f51ebb732edb93dd8db64c1198a9046", "blink_fuzzer_unittests": "f115e7ee0f291b3e24eff6ab5ab35f31a15f7687", "blink_heap_unittests": "54598bb088e6576451403fe71eb56984edf4aa85", "blink_platform_unittests": "6ec228491f85e92bcb4d6933cb0657a2438336a6", "boringssl_crypto_tests": "0787dbaa034190c834b8d1549d66a8402c31bd04", "boringssl_ssl_tests": "7e818fc3afa96a412b23aa586691761d6ffd9771", "browser_tests": "000d22424d5dd00e94c64c5fd3db4d5ad84d2e6e", "cacheinvalidation_unittests": "0cea8851cc6e6ac85dc364117c927e57bf16069b", "capture_unittests": "e73e00ef609f7676b68ee75a81f1e3cf976a507c", "cast_unittests": "fd962febcdb01c88c3530bd6a97d0c64a828f0fa", "cc_unittests": "3f92db765e95eff113ec189126a88408c71f2879", "chrome_app_unittests": "5440ccd22bae48b1a923c5ead4a71e162694abf5", "chromedriver_py_tests": "d9030da17bf7a5a64fed861fd6051acb941ba465", "chromedriver_replay_unittests": "2c79475fcfea940e6a9329f898a5d864d316a076", "chromedriver_unittests": "096cccdfd00ee0bbf61c2d3be151321d63e260d5", "components_browsertests": "ecdb840b059190c8870d48e52a21492ba476022b", "components_unittests": "19d5b8b3bef7732aff225d11e38224722dd0390c", "compositor_unittests": "65a5c65a1389c01b8512548808c98e8783a0ce0b", "content_browsertests": "4651e1f63111b6433c45fe9e4a34b6ace52ef996", "content_shell_crash_test": "da8ca325d6250abdff893a2e0206eb98dad7cf96", "content_unittests": "dc33b72ab90f0e38af5812273c2b770db310d681", "cronet_tests": "a69bfef7513ed25b91975ed2be0a8172acfa9e13", "cronet_unittests": "0c9b01d86af3fa4e1034711a642ebcc400a04055", "crypto_unittests": "f334a00d299553bd456d6a8bc657ca5c1d7e62ac", "dbus_unittests": "2de72441fca306b0138457c083224899d3ce4099", "device_unittests": "56eeee8f5b901af761f4eca8261193c4e7c95490", "devtools_closure_compile": "a6b41eb5aae0c73c8ac98ca5ea0e74d4406c0ad5", "devtools_eslint": "485f56cad759fb5c56dd3a7c8ba21cc73135fba0", "display_unittests": "4b02cd62990dcd9fb7e269af97dea5882b5c1a52", "events_unittests": "37e431954122d916381ef6f94d08668078832d9e", "extensions_browsertests": "12a6013a5548f2326b444ad78c64f6687e93cf75", "extensions_unittests": "fea2f568b78a87d75265fa1989c99d1da3262fd3", "filesystem_service_unittests": "688f5e845e687d29908129588d1d67ce0d7975d1", "gcm_unit_tests": "0bd957c9ad74c7e2d548823a4262ceaec511cf2d", "gfx_unittests": "9398c644dd2dd594a5275706684da18cd3a0f65a", "gin_unittests": "1307f89e796a32056f107804ba270fbc1994ab0b", "google_apis_unittests": "54f5b0a22497bc3fd41563439546efafb4331e03", "gpu_unittests": "85a178fa5ceb4102427257871b02bbbe0dcf09d6", "headless_browsertests": "a7d65f7d598f094622e3ea64b137747c08912633", "headless_unittests": "f10a68a0c18b6fd1bb35df84f0e00c5759bd8e8a", "interactive_ui_tests": "1cf506c58297bec7e11a8afe65f0eb07abc89abe", "ipc_tests": "72819b8ce05654e9fd795b3666dd21cacd973bb9", "jingle_unittests": "46b945f99381d42ff0c89a119a0e3ca755a688d3", "latency_unittests": "4e36668fde60cf283715505c17eaebcc4aab73fb", "leveldb_service_unittests": "69e7dddee84d30169134afa64b656b924c42428f", "libjingle_xmpp_unittests": "c8a65f6ee71aaeae38b012aa353408c91ecfd2bf", "media_blink_unittests": "d60a00a73e85afca97b97bbbdd07a21bb43a7020", "media_service_unittests": "3c853f165ad509465389d5a08803426477fed6f4", "media_unittests": "dd4b01f9dec9b23f4e7c9bed5f2f3fbd63376043", "message_center_unittests": "bd4dc002bf290719decc901f36f4e07eaf3394cd", "metrics_python_tests": "2056aa288e61169d34d413308effcb672d41de12", "midi_unittests": "a1f5cb57c95d44cbfc7c5ab5155402dccd1c1b49", "mojo_core_unittests": "1552293ce05f264cbab43508e23fcae16d6f0063", "mojo_unittests": "1605f329922ca63638f70a70e23cf5cd577bdd0e", "nacl_helper_nonsfi_unittests": "8810757166dbfa2bd10adae380b70593e45059f7", "nacl_loader_unittests": "ed27e8a7e93de4be9562a85a409f5baaac7928fd", "native_theme_unittests": "04e40099af856d01fe4901f06651db42b2beb336", "net_unittests": "448b19528e37edd60adbf8228ee6361a503229c5", "pdf_unittests": "ff0e734cb8a92d28aa0f45bb03934c39c715b082", "ppapi_unittests": "c766615eec4949b6aa70b423c2274f4a4b6201cc", "printing_unittests": "61c35b70363631fa4c5dc373cbf1695c9f44be5c", "remoting_unittests": "ce42b33480ec80cf82251bb9b7fb1355c2ff5ed8", "sandbox_linux_unittests": "64755b6b3ca7ca701cb7669d569129787ad7f526", "service_manager_unittests": "9944585227427258d6de806e1a5a3f62e1355fe4", "services_unittests": "a5c956f795adf4f60f1728da21f9147c3d46adf2", "shell_dialogs_unittests": "bacbc193e6bf001ebcb71aa7b16b52204e8e80ac", "skia_unittests": "25dfcc419173baf471bca30bce623b4e80c4defe", "snapshot_unittests": "f2a59e978e5034ab9261a10dfefa55ad79ccf1bb", "sql_unittests": "c0b2cbbf0fb210b2cc394650fede1fa21027ed2a", "storage_unittests": "05950ccac5961a19f8cef708c79df1d078b9afca", "sync_integration_tests": "7b633a39a6e3b2ad2f551cb17fa048d83cd96eb6", "telemetry_gpu_unittests": "48115937fe3e9b5edf0e3ba0b64a45c6454dec0d", "telemetry_perf_unittests": "b8afe7238d65d43106879f00d8dc452f2b14cdf4", "telemetry_unittests": "f58c4762c4ba8388a6197c533ae4b777efd80d45", "traffic_annotation_auditor_unittests": "bae643fc39148a00ffbca3df85ed649c0202477d", "ui_base_unittests": "9efb8ac7c1b665bf445b240b1893ed52e428f970", "ui_touch_selection_unittests": "9e2d129ad2ff4e479fda573b137b7f701f78d45a", "unit_tests": "d5da5afda781b2d6520e0cf9144fcffde1fba5a8", "url_unittests": "acfd4ea4340102bd63df4d1d64518bd10dca11ae", "views_perftests": "dc18c26dee56feff772741ebe41df62695fbc5a1", "views_unittests": "52b61da9eb3bf7adf741a80274057f9dd10f4ee1", "viz_unittests": "6cad3e76cc14ab9da18ba1d15838316e37c1408a", "vr_common_unittests": "5edc4ea58e893dc6343748f0614a14b2a3dd2ff5", "vr_pixeltests": "4401818a1f26526e2e989db8f67fbd9e6e9cc002", "webkit_layout_tests_exparchive": "c12844176004beaa0760916938c9766d24f9be1d", "webkit_python_tests": "565a840a3431845ccebea1de80c6b282dbbe3aff", "webkit_unit_tests": "d5c9ef784d1cae3c7fedd9b44e09eeeff9831127", "wm_unittests": "947d745f6c1dc325d6a369700a12c5ccb4cdf159", "wtf_unittests": "8ed2e3433222bfd796a58691019e97dc74e22a6a"} | find isolated tests |
Blamelist:
- chrome-release-bot (chrome-release-botohnoyoudont@chromium.org)
- Takashi Sakamoto (tasakohnoyoudont@google.com)
- Takashi Sakamoto (tasakohnoyoudont@google.com)
- Dan Beam (dbeamohnoyoudont@chromium.org)
Timing:
Create | Friday, 07-Dec-18 06:18:58 UTC |
Start | Friday, 07-Dec-18 06:19:38 UTC |
End | Friday, 07-Dec-18 07:29:18 UTC |
Pending | 39 secs |
Execution | 1 hrs 9 mins |
All Changes:
-
Updating trunk VERSION from 3633.0 to 3634.0
Changed by chrome-release-bot - chrome-release-botohnoyoudont@chromium.org Changed at Friday, 07-Dec-18 04:11:08 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e324812251510778815829c1b07043b6d53f8414 Comments
Updating trunk VERSION from 3633.0 to 3634.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I042e2caf928b9a12422f14eccec3e8f33ead12d9 Reviewed-on: https://chromium-review.googlesource.com/c/1366874 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#614580}
Changed files
- chrome/VERSION
-
Revert "cros: Move most event/widget handling logic out of LoginBubble"
Changed by Takashi Sakamoto - tasakohnoyoudont@google.com Changed at Friday, 07-Dec-18 03:49:55 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision bb9ca465cac1a3ec4d0670844865b40efb003c11 Comments
Revert "cros: Move most event/widget handling logic out of LoginBubble" This reverts commit a61287973e8f4522ed673ac1a77de0dc56eb1bc8. Reason for revert: Suspect Failure single_process_mash_ash_unittests Failure ash_unittests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/16943 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927839167159249024/+/steps/single_process_mash_ash_unittests/0/logs/LoginExpandedPublicAccountViewTest.ChangeMenuSelection/0 --- [ RUN ] LoginExpandedPublicAccountViewTest.ChangeMenuSelection Received signal 11 SEGV_MAPERR ffffe03f000008fe #0 0x5631a3caedbf base::debug::StackTrace::StackTrace() #1 0x5631a3cae941 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7faa9920f330 <unknown> #3 0x5631a3aafbbf ash::LoginBubble::~LoginBubble() #4 0x5631a3ab806c ash::RightPaneView::~RightPaneView() #5 0x5631a3ab810e ash::RightPaneView::~RightPaneView() #6 0x5631a40385d4 views::View::~View() #7 0x5631a3ab6df9 ash::LoginExpandedPublicAccountView::~LoginExpandedPublicAccountView() #8 0x5631a40385d4 views::View::~View() #9 0x5631a300afce ash::(anonymous namespace)::DragTestView::~DragTestView() #10 0x5631a4039b42 views::View::DoRemoveChildView() #11 0x5631a403a175 views::View::RemoveAllChildViews() #12 0x5631a4043b81 views::internal::RootView::~RootView() #13 0x5631a400ef0e views::MenuHostRootView::~MenuHostRootView() #14 0x5631a404615f views::Widget::~Widget() #15 0x5631a34d645e exo::(anonymous namespace)::ShellSurfaceWidget::~ShellSurfaceWidget() #16 0x5631a30c36f0 ash::LoginTestBase::TearDown() Original change's description: > cros: Move most event/widget handling logic out of LoginBubble > > Changes made: > - Move the (keyboard/click/tap) event handling logic into a > LoginBubbleHandler class. > - Move the widget handling into LoginBaseBubbleView itself > > Bug: 912658 > Change-Id: Ia1a9bf4b8d847ef74ef1716e73dfe1b16b8d19b2 > Reviewed-on: https://chromium-review.googlesource.com/c/1366516 > Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614544} TBR=jdufault@chromium.org,qnnguyen@chromium.org Change-Id: Ia9b9059f24f6aa6a8551c5c6bc5c76caafe592df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912658 Reviewed-on: https://chromium-review.googlesource.com/c/1367070 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#614579}
Changed files
- ash/login/ui/login_base_bubble_view.cc
- ash/login/ui/login_base_bubble_view.h
- ash/login/ui/login_bubble.cc
- ash/login/ui/login_bubble.h
-
Revert "Updating XTBs based on .GRDs from branch master"
Changed by Takashi Sakamoto - tasakohnoyoudont@google.com Changed at Friday, 07-Dec-18 03:43:15 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision df02e792b693ed5007b5c8c4866203219bedfd20 Comments
Revert "Updating XTBs based on .GRDs from branch master" This reverts commit c7424053a784c4d07dcd4617d68a1f2ac7f9657b. Reason for revert: suspect Android compile failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927834375124899248/+/steps/compile/0/stdout --- ../resource_zips/chrome/android/chrome_strings_grd.resources.zip/values-fr/android_chrome_strings.xml:364 Inconsistent number of arguments in formatting string `data_reduction_benefits_description`; found both 0 and 1: StringFormatCount [warning] <string name="data_reduction_benefits_description">"En mode simplifié, Chrome charge les pages plus rapidement et consomme jusqu\'à 60 % de données en moins."</string> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../resource_zips/chrome/android/chrome_strings_grd.resources.zip/values-fr/android_chrome_strings.xml:389 Inconsistent number of arguments in formatting string `data_reduction_promo_summary`; found both 0 and 1: StringFormatCount [warning] <string name="data_reduction_promo_summary">"En mode simplifié, Chrome charge les pages plus rapidement et consomme jusqu\'à 60 % de données en moins. La technologie cloud de Google optimise les pages que vous consultez."</string> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Original change's description: > Updating XTBs based on .GRDs from branch master > > R=abdulsyed@chromium.org > > Change-Id: Ibc94ee5be9db75306313d34881e4026a681eec1d > Reviewed-on: https://chromium-review.googlesource.com/c/1366870 > Reviewed-by: Krishna Govind <govind@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614569} TBR=govind@chromium.org,abdulsyed@chromium.org Change-Id: I4dfd803c9c148e5d6e3335d11e06fd61728fe548 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1366465 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#614578}
Changed files
- ash/components/strings/ash_components_strings_te.xtb
- ash/strings/ash_strings_am.xtb
- ash/strings/ash_strings_ar.xtb
- ash/strings/ash_strings_bn.xtb
- ash/strings/ash_strings_ca.xtb
- ash/strings/ash_strings_cs.xtb
- ash/strings/ash_strings_de.xtb
- ash/strings/ash_strings_el.xtb
- ash/strings/ash_strings_en-GB.xtb
- ash/strings/ash_strings_fa.xtb
- ash/strings/ash_strings_fi.xtb
- ash/strings/ash_strings_fr.xtb
- ash/strings/ash_strings_gu.xtb
- ash/strings/ash_strings_hr.xtb
- ash/strings/ash_strings_hu.xtb
- ash/strings/ash_strings_id.xtb
- ash/strings/ash_strings_it.xtb
- ash/strings/ash_strings_kn.xtb
- ash/strings/ash_strings_lt.xtb
- ash/strings/ash_strings_lv.xtb
- ash/strings/ash_strings_ml.xtb
- ash/strings/ash_strings_nl.xtb
- ash/strings/ash_strings_pl.xtb
- ash/strings/ash_strings_pt-BR.xtb
- ash/strings/ash_strings_pt-PT.xtb
- ash/strings/ash_strings_ru.xtb
- ash/strings/ash_strings_sk.xtb
- ash/strings/ash_strings_sl.xtb
- ash/strings/ash_strings_sr.xtb
- ash/strings/ash_strings_sv.xtb
- ash/strings/ash_strings_sw.xtb
- ash/strings/ash_strings_te.xtb
- ash/strings/ash_strings_th.xtb
- ash/strings/ash_strings_tr.xtb
- ash/strings/ash_strings_uk.xtb
- chrome/android/java/strings/translations/android_chrome_strings_am.xtb
- chrome/android/java/strings/translations/android_chrome_strings_ar.xtb
- chrome/android/java/strings/translations/android_chrome_strings_bg.xtb
- chrome/android/java/strings/translations/android_chrome_strings_bn.xtb
- chrome/android/java/strings/translations/android_chrome_strings_ca.xtb
- chrome/android/java/strings/translations/android_chrome_strings_cs.xtb
- chrome/android/java/strings/translations/android_chrome_strings_da.xtb
- chrome/android/java/strings/translations/android_chrome_strings_de.xtb
- chrome/android/java/strings/translations/android_chrome_strings_el.xtb
- chrome/android/java/strings/translations/android_chrome_strings_en-GB.xtb
- chrome/android/java/strings/translations/android_chrome_strings_es-419.xtb
- chrome/android/java/strings/translations/android_chrome_strings_es.xtb
- chrome/android/java/strings/translations/android_chrome_strings_fa.xtb
- chrome/android/java/strings/translations/android_chrome_strings_fi.xtb
- chrome/android/java/strings/translations/android_chrome_strings_fil.xtb
- chrome/android/java/strings/translations/android_chrome_strings_fr.xtb
- chrome/android/java/strings/translations/android_chrome_strings_gu.xtb
- chrome/android/java/strings/translations/android_chrome_strings_hi.xtb
- chrome/android/java/strings/translations/android_chrome_strings_hr.xtb
- chrome/android/java/strings/translations/android_chrome_strings_hu.xtb
- chrome/android/java/strings/translations/android_chrome_strings_id.xtb
- chrome/android/java/strings/translations/android_chrome_strings_it.xtb
- chrome/android/java/strings/translations/android_chrome_strings_iw.xtb
- chrome/android/java/strings/translations/android_chrome_strings_ja.xtb
- chrome/android/java/strings/translations/android_chrome_strings_kn.xtb
- chrome/android/java/strings/translations/android_chrome_strings_lt.xtb
- chrome/android/java/strings/translations/android_chrome_strings_lv.xtb
- chrome/android/java/strings/translations/android_chrome_strings_ml.xtb
- chrome/android/java/strings/translations/android_chrome_strings_nl.xtb
- chrome/android/java/strings/translations/android_chrome_strings_pl.xtb
- chrome/android/java/strings/translations/android_chrome_strings_pt-BR.xtb
- chrome/android/java/strings/translations/android_chrome_strings_pt-PT.xtb
- chrome/android/java/strings/translations/android_chrome_strings_ru.xtb
- chrome/android/java/strings/translations/android_chrome_strings_sk.xtb
- chrome/android/java/strings/translations/android_chrome_strings_sl.xtb
- chrome/android/java/strings/translations/android_chrome_strings_sr.xtb
- chrome/android/java/strings/translations/android_chrome_strings_sv.xtb
- chrome/android/java/strings/translations/android_chrome_strings_sw.xtb
- chrome/android/java/strings/translations/android_chrome_strings_ta.xtb
- chrome/android/java/strings/translations/android_chrome_strings_te.xtb
- chrome/android/java/strings/translations/android_chrome_strings_th.xtb
- chrome/android/java/strings/translations/android_chrome_strings_tr.xtb
- chrome/android/java/strings/translations/android_chrome_strings_uk.xtb
- chrome/android/java/strings/translations/android_chrome_strings_zh-CN.xtb
- chrome/app/resources/chromium_strings_te.xtb
- chrome/app/resources/generated_resources_am.xtb
- chrome/app/resources/generated_resources_ar.xtb
- chrome/app/resources/generated_resources_bg.xtb
- chrome/app/resources/generated_resources_bn.xtb
- chrome/app/resources/generated_resources_ca.xtb
- chrome/app/resources/generated_resources_cs.xtb
- chrome/app/resources/generated_resources_da.xtb
- chrome/app/resources/generated_resources_de.xtb
- chrome/app/resources/generated_resources_el.xtb
- chrome/app/resources/generated_resources_en-GB.xtb
- chrome/app/resources/generated_resources_es-419.xtb
- chrome/app/resources/generated_resources_es.xtb
- chrome/app/resources/generated_resources_et.xtb
- chrome/app/resources/generated_resources_fa.xtb
- chrome/app/resources/generated_resources_fi.xtb
- chrome/app/resources/generated_resources_fil.xtb
- chrome/app/resources/generated_resources_fr.xtb
- chrome/app/resources/generated_resources_gu.xtb
- chrome/app/resources/generated_resources_hi.xtb
- chrome/app/resources/generated_resources_hr.xtb
- chrome/app/resources/generated_resources_hu.xtb
- chrome/app/resources/generated_resources_id.xtb
- chrome/app/resources/generated_resources_it.xtb
- chrome/app/resources/generated_resources_iw.xtb
- chrome/app/resources/generated_resources_ja.xtb
- chrome/app/resources/generated_resources_kn.xtb
- chrome/app/resources/generated_resources_ko.xtb
- chrome/app/resources/generated_resources_lt.xtb
- chrome/app/resources/generated_resources_lv.xtb
- chrome/app/resources/generated_resources_ml.xtb
- chrome/app/resources/generated_resources_mr.xtb
- chrome/app/resources/generated_resources_ms.xtb
- chrome/app/resources/generated_resources_nl.xtb
- chrome/app/resources/generated_resources_no.xtb
- chrome/app/resources/generated_resources_pl.xtb
- chrome/app/resources/generated_resources_pt-BR.xtb
- chrome/app/resources/generated_resources_pt-PT.xtb
- chrome/app/resources/generated_resources_ro.xtb
- chrome/app/resources/generated_resources_ru.xtb
- chrome/app/resources/generated_resources_sk.xtb
- chrome/app/resources/generated_resources_sl.xtb
- chrome/app/resources/generated_resources_sr.xtb
- chrome/app/resources/generated_resources_sv.xtb
- chrome/app/resources/generated_resources_sw.xtb
- chrome/app/resources/generated_resources_ta.xtb
- chrome/app/resources/generated_resources_te.xtb
- chrome/app/resources/generated_resources_th.xtb
- chrome/app/resources/generated_resources_tr.xtb
- chrome/app/resources/generated_resources_uk.xtb
- chrome/app/resources/generated_resources_vi.xtb
- chrome/app/resources/generated_resources_zh-CN.xtb
- chrome/app/resources/generated_resources_zh-TW.xtb
- chrome/app/resources/google_chrome_strings_te.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_am.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ar.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_bg.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ca.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_cs.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_da.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_de.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_el.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_en-GB.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_es-419.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_es.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_et.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fa.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fi.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fil.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fr.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hi.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hr.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hu.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_id.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_it.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ja.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ko.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_lt.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_lv.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ms.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_nl.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_no.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pl.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pt-BR.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pt-PT.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ro.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ru.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sk.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sr.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sv.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sw.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ta.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_th.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_tr.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_uk.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_vi.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-CN.xtb
- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-TW.xtb
- components/policy/resources/policy_templates_am.xtb
- components/policy/resources/policy_templates_ar.xtb
- components/policy/resources/policy_templates_bn.xtb
- components/policy/resources/policy_templates_ca.xtb
- components/policy/resources/policy_templates_cs.xtb
- components/policy/resources/policy_templates_de.xtb
- components/policy/resources/policy_templates_el.xtb
- components/policy/resources/policy_templates_en-GB.xtb
- components/policy/resources/policy_templates_es-419.xtb
- components/policy/resources/policy_templates_fa.xtb
- components/policy/resources/policy_templates_fi.xtb
- components/policy/resources/policy_templates_fr.xtb
- components/policy/resources/policy_templates_hr.xtb
- components/policy/resources/policy_templates_id.xtb
- components/policy/resources/policy_templates_it.xtb
- components/policy/resources/policy_templates_kn.xtb
- components/policy/resources/policy_templates_ml.xtb
- components/policy/resources/policy_templates_nl.xtb
- components/policy/resources/policy_templates_pl.xtb
- components/policy/resources/policy_templates_pt-BR.xtb
- components/policy/resources/policy_templates_pt-PT.xtb
- components/policy/resources/policy_templates_ru.xtb
- components/policy/resources/policy_templates_sk.xtb
- components/policy/resources/policy_templates_sr.xtb
- components/policy/resources/policy_templates_sv.xtb
- components/policy/resources/policy_templates_sw.xtb
- components/policy/resources/policy_templates_ta.xtb
- components/policy/resources/policy_templates_te.xtb
- components/policy/resources/policy_templates_th.xtb
- components/policy/resources/policy_templates_tr.xtb
- components/policy/resources/policy_templates_uk.xtb
- components/policy/resources/policy_templates_vi.xtb
- components/strings/components_strings_am.xtb
- components/strings/components_strings_ar.xtb
- components/strings/components_strings_bg.xtb
- components/strings/components_strings_bn.xtb
- components/strings/components_strings_ca.xtb
- components/strings/components_strings_cs.xtb
- components/strings/components_strings_da.xtb
- components/strings/components_strings_de.xtb
- components/strings/components_strings_el.xtb
- components/strings/components_strings_en-GB.xtb
- components/strings/components_strings_es-419.xtb
- components/strings/components_strings_es.xtb
- components/strings/components_strings_et.xtb
- components/strings/components_strings_fa.xtb
- components/strings/components_strings_fi.xtb
- components/strings/components_strings_fil.xtb
- components/strings/components_strings_fr.xtb
- components/strings/components_strings_gu.xtb
- components/strings/components_strings_hi.xtb
- components/strings/components_strings_hr.xtb
- components/strings/components_strings_hu.xtb
- components/strings/components_strings_id.xtb
- components/strings/components_strings_it.xtb
- components/strings/components_strings_iw.xtb
- components/strings/components_strings_ja.xtb
- components/strings/components_strings_kn.xtb
- components/strings/components_strings_ko.xtb
- components/strings/components_strings_lt.xtb
- components/strings/components_strings_lv.xtb
- components/strings/components_strings_ml.xtb
- components/strings/components_strings_mr.xtb
- components/strings/components_strings_ms.xtb
- components/strings/components_strings_nl.xtb
- components/strings/components_strings_no.xtb
- components/strings/components_strings_pl.xtb
- components/strings/components_strings_pt-BR.xtb
- components/strings/components_strings_pt-PT.xtb
- components/strings/components_strings_ro.xtb
- components/strings/components_strings_ru.xtb
- components/strings/components_strings_sk.xtb
- components/strings/components_strings_sl.xtb
- components/strings/components_strings_sr.xtb
- components/strings/components_strings_sv.xtb
- components/strings/components_strings_sw.xtb
- components/strings/components_strings_ta.xtb
- components/strings/components_strings_te.xtb
- components/strings/components_strings_th.xtb
- components/strings/components_strings_tr.xtb
- components/strings/components_strings_uk.xtb
- components/strings/components_strings_vi.xtb
- components/strings/components_strings_zh-CN.xtb
- components/strings/components_strings_zh-TW.xtb
- content/app/strings/translations/content_strings_te.xtb
- extensions/strings/extensions_strings_te.xtb
- ios/chrome/app/strings/resources/ios_chromium_strings_te.xtb
- ios/chrome/app/strings/resources/ios_google_chrome_strings_te.xtb
- ios/chrome/app/strings/resources/ios_strings_am.xtb
- ios/chrome/app/strings/resources/ios_strings_ar.xtb
- ios/chrome/app/strings/resources/ios_strings_bn.xtb
- ios/chrome/app/strings/resources/ios_strings_ca.xtb
- ios/chrome/app/strings/resources/ios_strings_cs.xtb
- ios/chrome/app/strings/resources/ios_strings_de.xtb
- ios/chrome/app/strings/resources/ios_strings_el.xtb
- ios/chrome/app/strings/resources/ios_strings_en-GB.xtb
- ios/chrome/app/strings/resources/ios_strings_fa.xtb
- ios/chrome/app/strings/resources/ios_strings_fi.xtb
- ios/chrome/app/strings/resources/ios_strings_fil.xtb
- ios/chrome/app/strings/resources/ios_strings_fr.xtb
- ios/chrome/app/strings/resources/ios_strings_gu.xtb
- ios/chrome/app/strings/resources/ios_strings_hr.xtb
- ios/chrome/app/strings/resources/ios_strings_hu.xtb
- ios/chrome/app/strings/resources/ios_strings_id.xtb
- ios/chrome/app/strings/resources/ios_strings_it.xtb
- ios/chrome/app/strings/resources/ios_strings_ja.xtb
- ios/chrome/app/strings/resources/ios_strings_kn.xtb
- ios/chrome/app/strings/resources/ios_strings_lt.xtb
- ios/chrome/app/strings/resources/ios_strings_lv.xtb
- ios/chrome/app/strings/resources/ios_strings_ml.xtb
- ios/chrome/app/strings/resources/ios_strings_nl.xtb
- ios/chrome/app/strings/resources/ios_strings_pl.xtb
- ios/chrome/app/strings/resources/ios_strings_pt-BR.xtb
- ios/chrome/app/strings/resources/ios_strings_pt-PT.xtb
- ios/chrome/app/strings/resources/ios_strings_ru.xtb
- ios/chrome/app/strings/resources/ios_strings_sk.xtb
- ios/chrome/app/strings/resources/ios_strings_sl.xtb
- ios/chrome/app/strings/resources/ios_strings_sr.xtb
- ios/chrome/app/strings/resources/ios_strings_sv.xtb
- ios/chrome/app/strings/resources/ios_strings_sw.xtb
- ios/chrome/app/strings/resources/ios_strings_ta.xtb
- ios/chrome/app/strings/resources/ios_strings_te.xtb
- ios/chrome/app/strings/resources/ios_strings_th.xtb
- ios/chrome/app/strings/resources/ios_strings_tr.xtb
- ios/chrome/app/strings/resources/ios_strings_uk.xtb
- remoting/resources/remoting_strings_am.xtb
- remoting/resources/remoting_strings_ar.xtb
- remoting/resources/remoting_strings_bn.xtb
- remoting/resources/remoting_strings_es.xtb
- remoting/resources/remoting_strings_gu.xtb
- remoting/resources/remoting_strings_hu.xtb
- remoting/resources/remoting_strings_id.xtb
- remoting/resources/remoting_strings_kn.xtb
- remoting/resources/remoting_strings_lt.xtb
- remoting/resources/remoting_strings_lv.xtb
- remoting/resources/remoting_strings_ml.xtb
- remoting/resources/remoting_strings_ru.xtb
- remoting/resources/remoting_strings_sl.xtb
- remoting/resources/remoting_strings_sr.xtb
- remoting/resources/remoting_strings_te.xtb
- remoting/resources/remoting_strings_th.xtb
- remoting/resources/remoting_strings_tr.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_am.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_ar.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_bg.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_bn.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_ca.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_cs.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_da.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_de.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_el.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_en-GB.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_es-419.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_es.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_et.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_fa.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_fi.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_fil.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_fr.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_gu.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_hi.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_hr.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_hu.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_id.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_it.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_iw.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_ja.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_kn.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_ko.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_lt.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_lv.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_ml.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_mr.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_ms.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_nl.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_no.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_pl.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_pt-BR.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_pt-PT.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_ru.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_sk.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_sl.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_sr.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_sv.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_sw.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_ta.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_th.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_tr.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_uk.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_vi.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_zh-CN.xtb
- third_party/libaddressinput/chromium/resources/address_input_strings_zh-TW.xtb
- ui/chromeos/translations/ui_chromeos_strings_te.xtb
-
Revert "Enable warmer welcome during Assistant launch."
Changed by Dan Beam - dbeamohnoyoudont@chromium.org Changed at Friday, 07-Dec-18 02:41:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c71812f1007dae45bce45b451c384bf9c0dbd356 Comments
Revert "Enable warmer welcome during Assistant launch." This reverts commit 29dca9fe6ae866266c976809adc33c09a2ca1088. Reason for revert: ../../chromeos/services/assistant/assistant_manager_service_impl.cc:27:10: fatal error: 'chromeos/services/assistant/assistant_warmer_welcome_log.pb.h' file not found #include "chromeos/services/assistant/assistant_warmer_welcome_log.pb.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. https://logs.chromium.org/logs/chromium/bb/chromium.chrome/Google_Chrome_ChromeOS/59389/+/recipes/steps/compile/0/stdout Original change's description: > Enable warmer welcome during Assistant launch. > > 1. It is guarded by a finch flag AssistantWarmerWelcome. > 2. WW only shows 3 times. > > Bug: b:112495005 > Test: Manual > > Change-Id: I80cbcfd4104c17172939d36b986be65077bf0bb3 > Reviewed-on: https://chromium-review.googlesource.com/c/1355174 > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Yilei Li <yileili@google.com> > Cr-Commit-Position: refs/heads/master@{#614553} TBR=xiyuan@chromium.org,xiaohuic@chromium.org,wfh@chromium.org,dmblack@google.com,wutao@chromium.org,yileili@google.com Change-Id: Ib5749ef1c003be49d4923c364d8499b43a2abcf5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:112495005 Reviewed-on: https://chromium-review.googlesource.com/c/1366873 Reviewed-by: Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#614577}
Changed files
- ash/BUILD.gn
- ash/assistant/assistant_controller.cc
- ash/assistant/assistant_controller.h
- ash/assistant/assistant_interaction_controller.cc
- ash/assistant/assistant_interaction_controller.h
- ash/public/cpp/ash_pref_names.cc
- ash/public/cpp/ash_pref_names.h
- ash/shell.cc
- chromeos/services/assistant/assistant_manager_service_impl.cc
- chromeos/services/assistant/assistant_manager_service_impl.h
- chromeos/services/assistant/fake_assistant_manager_service_impl.cc
- chromeos/services/assistant/fake_assistant_manager_service_impl.h
- chromeos/services/assistant/public/features.cc
- chromeos/services/assistant/public/features.h
- chromeos/services/assistant/public/mojom/assistant.mojom
- chromeos/services/assistant/test_support/mock_assistant.h