Home | Search | chromium - Builders
Login

Builder Linux Tests (dbg)(1)(32) Build 51328 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revisionadeaf13d9c8651fcf83c9e5a6a7d1173f1eb27e1
Got Revisionadeaf13d9c8651fcf83c9e5a6a7d1173f1eb27e1

Execution:

Steps and Logfiles:

Show:
  1. ( 305 ms ) setup_build
    running recipe: "chromium"
  2. ( 451 ms ) remove .cipd
  3. ( 4 mins 39 secs ) bot_update
    [67GB/295GB used (22%)]
  4. ( 0 ) ensure_goma
  5. ( 628 ms ) swarming.py --version
    0.13
  6. ( 45 secs ) gclient runhooks
  7. ( 618 ms ) read test spec (chromium.linux.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.linux.json
  8. ( 3 secs ) build directory
  9. ( 5 mins 18 secs ) extract build
  10. ( 1 secs ) find isolated tests
  11. ( 0 ) test_pre_run
  12. ( 1 secs ) test_pre_run.[trigger] accessibility_unittests
    Run on OS: 'Ubuntu-14.04'
  13. ( 1 secs ) test_pre_run.[trigger] angle_unittests
    Run on OS: 'Ubuntu-14.04'
  14. ( 1 secs ) test_pre_run.[trigger] app_shell_unittests
    Run on OS: 'Ubuntu-14.04'
  15. ( 969 ms ) test_pre_run.[trigger] aura_unittests
    Run on OS: 'Ubuntu-14.04'
  16. ( 968 ms ) test_pre_run.[trigger] base_unittests
    Run on OS: 'Ubuntu-14.04'
  17. ( 981 ms ) test_pre_run.[trigger] battor_agent_unittests
    Run on OS: 'Ubuntu-14.04'
  18. ( 1 secs ) test_pre_run.[trigger] blink_common_unittests
    Run on OS: 'Ubuntu-14.04'
  19. ( 1 secs ) test_pre_run.[trigger] blink_fuzzer_unittests
    Run on OS: 'Ubuntu-14.04'
  20. ( 1 secs ) test_pre_run.[trigger] blink_heap_unittests
    Run on OS: 'Ubuntu-14.04'
  21. ( 927 ms ) test_pre_run.[trigger] blink_platform_unittests
    Run on OS: 'Ubuntu-14.04'
  22. ( 1 secs ) test_pre_run.[trigger] boringssl_crypto_tests
    Run on OS: 'Ubuntu-14.04'
  23. ( 950 ms ) test_pre_run.[trigger] boringssl_ssl_tests
    Run on OS: 'Ubuntu-14.04'
  24. ( 7 secs ) test_pre_run.[trigger] browser_tests
    Run on OS: 'Ubuntu-14.04'
  25. ( 11 secs ) test_pre_run.[trigger] network_service_browser_tests
    Run on OS: 'Ubuntu-14.04'
  26. ( 4 secs ) test_pre_run.[trigger] viz_browser_tests
    Run on OS: 'Ubuntu-14.04'
  27. ( 1 secs ) test_pre_run.[trigger] cacheinvalidation_unittests
    Run on OS: 'Ubuntu-14.04'
  28. ( 1 secs ) test_pre_run.[trigger] capture_unittests
    Run on OS: 'Ubuntu-14.04'
  29. ( 1 secs ) test_pre_run.[trigger] cast_unittests
    Run on OS: 'Ubuntu-14.04'
  30. ( 943 ms ) test_pre_run.[trigger] cc_unittests
    Run on OS: 'Ubuntu-14.04'
  31. ( 1 secs ) test_pre_run.[trigger] chrome_app_unittests
    Run on OS: 'Ubuntu-14.04'
  32. ( 1 secs ) test_pre_run.[trigger] chromedriver_unittests
    Run on OS: 'Ubuntu-14.04'
  33. ( 977 ms ) test_pre_run.[trigger] components_unittests
    Run on OS: 'Ubuntu-14.04'
  34. ( 884 ms ) test_pre_run.[trigger] compositor_unittests
    Run on OS: 'Ubuntu-14.04'
  35. ( 1 secs ) test_pre_run.[trigger] content_browsertests
    Run on OS: 'Ubuntu-14.04'
  36. ( 2 secs ) test_pre_run.[trigger] viz_content_browsertests
    Run on OS: 'Ubuntu-14.04'
  37. ( 867 ms ) test_pre_run.[trigger] content_unittests
    Run on OS: 'Ubuntu-14.04'
  38. ( 943 ms ) test_pre_run.[trigger] viz_content_unittests
    Run on OS: 'Ubuntu-14.04'
  39. ( 911 ms ) test_pre_run.[trigger] cronet_tests
    Run on OS: 'Ubuntu-14.04'
  40. ( 869 ms ) test_pre_run.[trigger] cronet_unittests
    Run on OS: 'Ubuntu-14.04'
  41. ( 1 secs ) test_pre_run.[trigger] crypto_unittests
    Run on OS: 'Ubuntu-14.04'
  42. ( 1 secs ) test_pre_run.[trigger] dbus_unittests
    Run on OS: 'Ubuntu-14.04'
  43. ( 932 ms ) test_pre_run.[trigger] device_unittests
    Run on OS: 'Ubuntu-14.04'
  44. ( 987 ms ) test_pre_run.[trigger] display_unittests
    Run on OS: 'Ubuntu-14.04'
  45. ( 922 ms ) test_pre_run.[trigger] events_unittests
    Run on OS: 'Ubuntu-14.04'
  46. ( 2 secs ) test_pre_run.[trigger] extensions_browsertests
    Run on OS: 'Ubuntu-14.04'
  47. ( 879 ms ) test_pre_run.[trigger] extensions_unittests
    Run on OS: 'Ubuntu-14.04'
  48. ( 978 ms ) test_pre_run.[trigger] filesystem_service_unittests
    Run on OS: 'Ubuntu-14.04'
  49. ( 872 ms ) test_pre_run.[trigger] gcm_unit_tests
    Run on OS: 'Ubuntu-14.04'
  50. ( 1 secs ) test_pre_run.[trigger] gfx_unittests
    Run on OS: 'Ubuntu-14.04'
  51. ( 1 secs ) test_pre_run.[trigger] gin_unittests
    Run on OS: 'Ubuntu-14.04'
  52. ( 1 secs ) test_pre_run.[trigger] google_apis_unittests
    Run on OS: 'Ubuntu-14.04'
  53. ( 1 secs ) test_pre_run.[trigger] gpu_unittests
    Run on OS: 'Ubuntu-14.04'
  54. ( 960 ms ) test_pre_run.[trigger] headless_browsertests
    Run on OS: 'Ubuntu-14.04'
  55. ( 942 ms ) test_pre_run.[trigger] headless_unittests
    Run on OS: 'Ubuntu-14.04'
  56. ( 2 secs ) test_pre_run.[trigger] interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
  57. ( 943 ms ) test_pre_run.[trigger] ipc_tests
    Run on OS: 'Ubuntu-14.04'
  58. ( 1 secs ) test_pre_run.[trigger] jingle_unittests
    Run on OS: 'Ubuntu-14.04'
  59. ( 1 secs ) test_pre_run.[trigger] latency_unittests
    Run on OS: 'Ubuntu-14.04'
  60. ( 938 ms ) test_pre_run.[trigger] leveldb_service_unittests
    Run on OS: 'Ubuntu-14.04'
  61. ( 1 secs ) test_pre_run.[trigger] libjingle_xmpp_unittests
    Run on OS: 'Ubuntu-14.04'
  62. ( 944 ms ) test_pre_run.[trigger] media_blink_unittests
    Run on OS: 'Ubuntu-14.04'
  63. ( 956 ms ) test_pre_run.[trigger] media_service_unittests
    Run on OS: 'Ubuntu-14.04'
  64. ( 1 secs ) test_pre_run.[trigger] media_unittests
    Run on OS: 'Ubuntu-14.04'
  65. ( 1 secs ) test_pre_run.[trigger] message_center_unittests
    Run on OS: 'Ubuntu-14.04'
  66. ( 1 secs ) test_pre_run.[trigger] midi_unittests
    Run on OS: 'Ubuntu-14.04'
  67. ( 1 secs ) test_pre_run.[trigger] mojo_core_unittests
    Run on OS: 'Ubuntu-14.04'
  68. ( 1 secs ) test_pre_run.[trigger] mojo_unittests
    Run on OS: 'Ubuntu-14.04'
  69. ( 1 secs ) test_pre_run.[trigger] nacl_helper_nonsfi_unittests
    Run on OS: 'Ubuntu-14.04'
  70. ( 940 ms ) test_pre_run.[trigger] nacl_loader_unittests
    Run on OS: 'Ubuntu-14.04'
  71. ( 865 ms ) test_pre_run.[trigger] native_theme_unittests
    Run on OS: 'Ubuntu-14.04'
  72. ( 2 secs ) test_pre_run.[trigger] net_unittests
    Run on OS: 'Ubuntu-14.04'
  73. ( 1 secs ) test_pre_run.[trigger] pdf_unittests
    Run on OS: 'Ubuntu-14.04'
  74. ( 1 secs ) test_pre_run.[trigger] ppapi_unittests
    Run on OS: 'Ubuntu-14.04'
  75. ( 1 secs ) test_pre_run.[trigger] printing_unittests
    Run on OS: 'Ubuntu-14.04'
  76. ( 941 ms ) test_pre_run.[trigger] sandbox_linux_unittests
    Run on OS: 'Ubuntu-14.04'
  77. ( 1 secs ) test_pre_run.[trigger] service_manager_unittests
    Run on OS: 'Ubuntu-14.04'
  78. ( 966 ms ) test_pre_run.[trigger] services_unittests
    Run on OS: 'Ubuntu-14.04'
  79. ( 1 secs ) test_pre_run.[trigger] shell_dialogs_unittests
    Run on OS: 'Ubuntu-14.04'
  80. ( 1 secs ) test_pre_run.[trigger] skia_unittests
    Run on OS: 'Ubuntu-14.04'
  81. ( 1 secs ) test_pre_run.[trigger] snapshot_unittests
    Run on OS: 'Ubuntu-14.04'
  82. ( 1 secs ) test_pre_run.[trigger] sql_unittests
    Run on OS: 'Ubuntu-14.04'
  83. ( 1 secs ) test_pre_run.[trigger] storage_unittests
    Run on OS: 'Ubuntu-14.04'
  84. ( 995 ms ) test_pre_run.[trigger] sync_integration_tests
    Run on OS: 'Ubuntu-14.04'
  85. ( 915 ms ) test_pre_run.[trigger] ui_base_unittests
    Run on OS: 'Ubuntu-14.04'
  86. ( 860 ms ) test_pre_run.[trigger] ui_touch_selection_unittests
    Run on OS: 'Ubuntu-14.04'
  87. ( 944 ms ) test_pre_run.[trigger] unit_tests
    Run on OS: 'Ubuntu-14.04'
  88. ( 1 secs ) test_pre_run.[trigger] url_unittests
    Run on OS: 'Ubuntu-14.04'
  89. ( 932 ms ) test_pre_run.[trigger] views_unittests
    Run on OS: 'Ubuntu-14.04'
  90. ( 1 secs ) test_pre_run.[trigger] viz_unittests
    Run on OS: 'Ubuntu-14.04'
  91. ( 1 secs ) test_pre_run.[trigger] vr_common_unittests
    Run on OS: 'Ubuntu-14.04'
  92. ( 1 secs ) test_pre_run.[trigger] vr_pixeltests
    Run on OS: 'Ubuntu-14.04'
  93. ( 946 ms ) test_pre_run.[trigger] webkit_unit_tests
    Run on OS: 'Ubuntu-14.04'
  94. ( 936 ms ) test_pre_run.[trigger] wm_unittests
    Run on OS: 'Ubuntu-14.04'
  95. ( 1 secs ) test_pre_run.[trigger] wtf_unittests
    Run on OS: 'Ubuntu-14.04'
  96. ( 2 secs ) test_pre_run.[trigger] devtools_closure_compile
    Run on OS: 'Ubuntu-14.04'
  97. ( 918 ms ) test_pre_run.[trigger] devtools_eslint
    Run on OS: 'Ubuntu-14.04'
  98. ( 1 secs ) test_pre_run.[trigger] metrics_python_tests
    Run on OS: 'Ubuntu-14.04'
  99. ( 1 secs ) test_pre_run.[trigger] telemetry_gpu_unittests
    Run on OS: 'Ubuntu-14.04'
  100. ( 2 secs ) test_pre_run.[trigger] telemetry_unittests
    Run on OS: 'Ubuntu-14.04'
  101. ( 1 secs ) test_pre_run.[trigger] views_perftests
    Run on OS: 'Ubuntu-14.04'
  102. ( 1 secs ) test_pre_run.[trigger] webkit_python_tests
    Run on OS: 'Ubuntu-14.04'
  103. ( 1 secs ) accessibility_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  104. ( 3 mins 10 secs ) angle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:05:19.909440
  105. ( 1 secs ) app_shell_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 34s
  106. ( 1 secs ) aura_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 20s
  107. ( 2 mins 34 secs ) base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:08:04.424300
  108. ( 1 secs ) battor_agent_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  109. ( 1 secs ) blink_common_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  110. ( 1 secs ) blink_fuzzer_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 22s
  111. ( 2 secs ) blink_heap_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 32s
  112. ( 2 secs ) blink_platform_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 55s
  113. ( 1 secs ) boringssl_crypto_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 37s
  114. ( 1 secs ) boringssl_ssl_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  115. ( 27 mins 21 secs ) browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:35:34.293830 (shard #2)
    Min shard duration: 0:25:47.921310 (shard #4)
  116. ( 7 secs ) network_service_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:25:41.021150 (shard #12)
    Min shard duration: 0:19:14.354890 (shard #9)
  117. ( 7 secs ) viz_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:33:17.543480 (shard #2)
    Min shard duration: 0:27:34.461340 (shard #5)
  118. ( 1 secs ) cacheinvalidation_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  119. ( 1 secs ) capture_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 20s
  120. ( 1 secs ) cast_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 20s
  121. ( 2 secs ) cc_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 56s
  122. ( 1 secs ) chrome_app_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 38s
  123. ( 1 secs ) chromedriver_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  124. ( 1 secs ) network_service_components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:31.024020
  125. ( 7 secs ) components_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:12:40.830720
  126. ( 1 secs ) compositor_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 19s
  127. ( 2 mins 17 secs ) content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:40:26.762640
  128. ( 2 secs ) network_service_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:23:51.399500 (shard #1)
    Min shard duration: 0:23:49.877860 (shard #0)
  129. ( 2 secs ) viz_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:21:43.150080 (shard #0)
    Min shard duration: 0:20:28.134610 (shard #1)
  130. ( 3 secs ) content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:06.960600
  131. ( 2 secs ) viz_content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:43.130970
  132. ( 1 secs ) cronet_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  133. ( 1 secs ) cronet_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  134. ( 1 secs ) crypto_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  135. ( 1 secs ) dbus_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  136. ( 1 secs ) device_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 24s
  137. ( 3 secs ) display_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  138. ( 1 secs ) events_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  139. ( 1 secs ) extensions_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:13.481130
  140. ( 1 secs ) network_service_extensions_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:29.281910
  141. ( 1 secs ) extensions_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 57s
  142. ( 1 secs ) filesystem_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  143. ( 1 secs ) gcm_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  144. ( 2 secs ) gfx_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 53s
  145. ( 1 secs ) gin_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  146. ( 1 secs ) google_apis_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  147. ( 3 secs ) gpu_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 49s
  148. ( 1 secs ) headless_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:52.936530
  149. ( 1 secs ) headless_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 34s
  150. ( 1 secs ) interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:17:04.701020 (shard #2)
    Min shard duration: 0:12:31.529260 (shard #1)
  151. ( 1 secs ) network_service_interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:18:09.091670 (shard #0)
    Min shard duration: 0:14:54.200010 (shard #1)
  152. ( 1 secs ) ipc_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  153. ( 1 secs ) jingle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  154. ( 4 secs ) latency_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  155. ( 1 secs ) leveldb_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  156. ( 1 secs ) libjingle_xmpp_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  157. ( 2 secs ) media_blink_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 34s
  158. ( 1 secs ) media_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  159. ( 2 secs ) media_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:23.891900
  160. ( 1 secs ) message_center_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  161. ( 1 secs ) midi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  162. ( 1 secs ) mojo_core_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  163. ( 1 secs ) mojo_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  164. ( 1 secs ) nacl_helper_nonsfi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  165. ( 1 secs ) nacl_loader_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 33s
  166. ( 1 secs ) native_theme_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  167. ( 14 secs ) net_unittests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:13:19.716390 (shard #1)
    Min shard duration: 0:13:04.917300 (shard #0)
  168. ( 1 secs ) pdf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 16s
  169. ( 1 secs ) ppapi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  170. ( 1 secs ) printing_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  171. ( 1 secs ) sandbox_linux_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  172. ( 1 secs ) service_manager_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  173. ( 2 secs ) services_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:03.747610
  174. ( 1 secs ) shell_dialogs_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  175. ( 1 secs ) skia_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  176. ( 1 secs ) snapshot_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 43s
  177. ( 1 secs ) sql_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  178. ( 1 secs ) storage_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 21s
  179. ( 1 secs ) sync_integration_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:12:11.401660
  180. ( 1 secs ) ui_base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  181. ( 1 secs ) ui_touch_selection_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  182. ( 3 secs ) unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:09:27.307710
  183. ( 1 secs ) url_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  184. ( 1 secs ) views_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 30s
  185. ( 1 secs ) viz_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:51.689630
  186. ( 1 secs ) vr_common_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 33s
  187. ( 1 secs ) vr_pixeltests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 31s
  188. ( 6 secs ) webkit_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:05:48.582270
  189. ( 1 secs ) wm_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  190. ( 1 secs ) wtf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  191. ( 1 secs ) devtools_closure_compile
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 30s
    Total tests: n/a
     
  192. ( 1 secs ) devtools_eslint
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 22s
    Total tests: n/a
     
  193. ( 1 secs ) metrics_python_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
    Total tests: 68
    * Passed: 68 (68 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  194. ( 1 secs ) telemetry_gpu_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 21s
    Total tests: 35
    * Passed: 35 (35 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  195. ( 2 secs ) telemetry_unittests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:10:35.983190 (shard #1)
    Min shard duration: 0:08:34.019750 (shard #3)
    Total tests: 1170
    * Passed: 1102 (1102 expected, 0 unexpected)
    * Skipped: 68 (68 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  196. ( 1 secs ) views_perftests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
    Total tests: n/a
     
  197. ( 2 secs ) webkit_python_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
    Total tests: 1545
    * Passed: 1545 (1545 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  198. ( 1 secs ) Tests statistics
     
    Stats
    Total shards: 137
    Total runtime: 21:24:27.098328
     
  199. ( 3 ms ) recipe result

Build Properties:

NameValueSource
$build/goma {"jobs": 500} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm665-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531427489638950, "id": "8941175604584074000", "project": "chromium", "tags": ["builder:Linux Tests (dbg)(1)(32)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/adeaf13d9c8651fcf83c9e5a6a7d1173f1eb27e1", "gitiles_ref:refs/heads/master", "parent_buildername:Linux Builder (dbg)(32)", "parent_buildnumber:84893", "scheduler_invocation_id:9106605666744876784", "scheduler_job_id:chromium/Linux Tests (dbg)(1)(32)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Linux Tests (dbg)(1)(32)" setup_build
buildnumber 51328 setup_build
mastername "chromium.linux" setup_build
parent_buildername "Linux Builder (dbg)(32)" setup_build
parent_got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" setup_build
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" setup_build
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" setup_build
parent_got_revision "adeaf13d9c8651fcf83c9e5a6a7d1173f1eb27e1" setup_build
parent_got_revision_cp "refs/heads/master@{#574689}" setup_build
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" setup_build
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" setup_build
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" setup_build
parent_got_webrtc_revision "798ee75d23651e7631775a113742bd09cc02e212" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#23952}" setup_build
parent_mastername "chromium.linux" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "adeaf13d9c8651fcf83c9e5a6a7d1173f1eb27e1" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "adeaf13d9c8651fcf83c9e5a6a7d1173f1eb27e1" bot_update
got_revision_cp "refs/heads/master@{#574689}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "798ee75d23651e7631775a113742bd09cc02e212" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23952}" bot_update
swarm_hashes {"accessibility_unittests": "06a2db7a21847fe3644e30598d4e6e4347537cc9", "angle_unittests": "33d0fdbad0fc4ce1e8c0f48e95d50b0ccadba9f1", "app_shell_unittests": "5f869ac361c6d24597b93150daf4ecf6fed08716", "aura_unittests": "2a7d99fb134f137cb8d5ebf520a28222afc5b2f4", "base_unittests": "a7700145263955180685fdece71e9224e6354754", "battor_agent_unittests": "b2d4db30098fbcb65ebc8ce546e0e7c41e1b8773", "blink_common_unittests": "845024897d21db4ca60ce7627567e5f2379285cf", "blink_fuzzer_unittests": "520baa2bf30f8e0cfff38dee8211e0a18d160e95", "blink_heap_unittests": "d0c8c2ef82b0b05421799d9fe039d5785c808365", "blink_platform_unittests": "33d80ab9e6daf6501771d20ac5bcc734433c71b0", "boringssl_crypto_tests": "f1b32b2979d8110e9d223e3e43313d187fc0e988", "boringssl_ssl_tests": "a32940c43fb5eb6b0a9b441fa3e908c35a2a2fa6", "browser_tests": "65ad4fe66bccf94a1d5133197e51094b7e4848b3", "cacheinvalidation_unittests": "63f783ecaab5691584c84cc4657cddb6a6ce4551", "capture_unittests": "db643ac35df6864662b6a3ea84408b6708b5e182", "cast_unittests": "072e507f33e214b47acc7b8fe99f9d59731c88be", "cc_unittests": "11a10d4f970ce7e084a484ac332adc8455a073d1", "chrome_app_unittests": "94c7e46781670a1eabf1fe072a33af9f1c9b2652", "chromedriver_unittests": "80fdbb25fc33b5476548b9e4f31355bd18959932", "components_browsertests": "e21e36be8338e470b1e0354b9c5a40b35a3c6774", "components_unittests": "9600ee1e33b6b7ae388056bbc2d9d51245041660", "compositor_unittests": "4daec509b7855d71c30914eeb841e73106c34612", "content_browsertests": "49bbddec928d7d99c2f874ae5d5a629331a01dd9", "content_unittests": "f37a78d9ce02f962a57e62fa7b8106425eeeffdc", "cronet_tests": "1a79f2c3a9ea5b712680cbaf57ee312898c7919a", "cronet_unittests": "5d8a4cd61ecfd7de8158810429ce935c605feec7", "crypto_unittests": "e562bb533401c53ec1546b7f8b5c4d1ff95f6719", "dbus_unittests": "0effbe5dcf5ba5f339348ae64c0d79088abc06fd", "device_unittests": "980db6ab5c6774d733db6b1c23f70e14df4119b6", "devtools_closure_compile": "0959bfbe2c9997dca90cf0dad701c5edaeeade78", "devtools_eslint": "11a09ddbcf0b7d9e1abf0592bfc4c87dba708e13", "display_unittests": "c22bc9423e9134169302db1a71d05e0337e894fe", "events_unittests": "419f82dae448fef9d5a5357b8e6733e88a1138c6", "extensions_browsertests": "658cc3a3308b10a80f016f7e139117c105c441a6", "extensions_unittests": "b7a71d08b64b6a5ab3799e36ba38b9dbe573851b", "filesystem_service_unittests": "ab2814eb940bf199de2e44813c463dc50e13ede8", "gcm_unit_tests": "2d9fcd10c99048a808a5bbeb47ccebc8b533e747", "gfx_unittests": "11fb060bb04fd120e570bece6f8310871c4ff7bd", "gin_unittests": "04818e349c85c62b5502643981482e317cb55e43", "google_apis_unittests": "d8be66ee65d3d0f1dcf29fdfceb0f770c2da5d1f", "gpu_unittests": "49d8c0ba4da8dab53a08943914e443058907ee92", "headless_browsertests": "e2145a1db2e57375520f3d3a7dc0c88d859d559e", "headless_unittests": "96f164254908fa2119b5a6ae0a4248c16dd8c33c", "interactive_ui_tests": "5fbcdec272ad311b0b5622c47d972ae27b2880d9", "ipc_tests": "fe34e99810e928498b62d86a8c55c0138a8121ab", "jingle_unittests": "483f711c45bcd5850d34ac2e86933a9a51a12e90", "latency_unittests": "c3f8d39d13eb7b15b17a69ddf48703f65acaaab1", "leveldb_service_unittests": "cd71e16672de49f442c27259a598e98ab4c562cf", "libjingle_xmpp_unittests": "8a62ceaac1cb97346a874281468fe1a16150c91f", "media_blink_unittests": "82255e7efa0abc224473f2462d6b69a3d1db0e8c", "media_service_unittests": "2ba11708d0e0bc02d3c545d803a4f6b9ab219cd3", "media_unittests": "6b23ce8f865c3387aa43c7b2888cbb53a3bc02be", "message_center_unittests": "6e51ccd1f24ef01204f5e71e3e6f6a8a002866bb", "metrics_python_tests": "b439f1299e83c0d3f70695038135f8d87c8b0851", "midi_unittests": "b5598daaa2b2ed9ab5832453e4304552b6f178cc", "mojo_core_unittests": "a6df81cd9d4154829e7ed81994073854b89d67e5", "mojo_unittests": "ce9dd38c0f7813fe3f72a6c831bcd105221d0172", "nacl_helper_nonsfi_unittests": "a4a2ce10ed67b37ae8fe07ba2281cfe5c6cc8c98", "nacl_loader_unittests": "0b128691066fbec547c0eb8a4bb9c7efb7197937", "native_theme_unittests": "51837a536bf7385afa48afc31dfb40ad42ae99f5", "net_unittests": "ac3a0ad8aef22651f3d21bed1c07e003048b0a7e", "pdf_unittests": "2b88d34ab63a1ecb419a65b36fca12e9caba0b7f", "ppapi_unittests": "d081e8690703ee1b0cfcf406a4409cfe9fa9419b", "printing_unittests": "18136416317fe2aba84208258863002276691151", "sandbox_linux_unittests": "8e4f2e4c257de136d6b76c57cfdb3b800573543d", "service_manager_unittests": "534ec8603f599e28205e6d07f16416fc30461ea7", "services_unittests": "6b8bfa343b1cead3bc3b1da0c528b6ed8ad05179", "shell_dialogs_unittests": "58ad4b7979ded9b380fc00b88633b9b6e37940b0", "skia_unittests": "f30ff4dcc3ab4d76d915dea00851c22d8e0edb8e", "snapshot_unittests": "d61bcce25dab0e709435ff046be15716d5f35228", "sql_unittests": "a74fec7de2e1afee9ac98828ef224985dcd354c1", "storage_unittests": "61a196edb7e9ba30a99ca8489db762060e32ea4b", "sync_integration_tests": "614c535d1cc9868a937a8e0e7be9cef81e1a1e19", "telemetry_gpu_unittests": "8d78e72c6b7bd6e4b05c945d982436bb8c3ab04b", "telemetry_unittests": "14e675414de861b3556bf71ddb8eed94e9158bbe", "ui_base_unittests": "769fcba69a77f4c8f1dd7675ba9b8ae894f5a006", "ui_touch_selection_unittests": "6e6c1b2b85d87a00407864d7edfc109ffa6aaf06", "unit_tests": "7551f100146a1e152d40beff300e2c8f7820ff69", "url_unittests": "c89c2c7770842424d29d7cb793fe8c303330493e", "views_perftests": "89ec9bb4a99387ae7b9d54f521fbb385fdd82b79", "views_unittests": "4ebb4249c1a25d050bf008919f954c41c7f4b4bf", "viz_unittests": "acaf55d904bdfc44a689bb4536827996dbc385f0", "vr_common_unittests": "25307058d2641f3fd46b7e361e456e8f2671f39a", "vr_pixeltests": "15480a40a1a341cc795904a018d4754b8636d47f", "webkit_python_tests": "23ec1f20226a4682e6b1f33c089f9c3921f2943c", "webkit_unit_tests": "962113242f1167b76c7d7eb28eba09ddd2cc12a5", "wm_unittests": "040f891e92d3e9fc787bcaea25490070cd913c14", "wtf_unittests": "543a30f87e22118d01ad28ce18f79592792c8bfa"} find isolated tests

Blamelist:

  1. Nektarios Paisios (nektarohnoyoudont@chromium.org)
  2. Amirhossein Simjour (asimjourohnoyoudont@chromium.org)
  3. Ryan Daum (rdaumohnoyoudont@chromium.org)
  4. Danyao Wang (danyaoohnoyoudont@chromium.org)
  5. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  6. Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
  7. erikchen (erikchenohnoyoudont@chromium.org)
  8. Esmael El-Moslimany (aeeohnoyoudont@chromium.org)
  9. Wez (wezohnoyoudont@chromium.org)
  10. Aldo Culquicondor (acondorohnoyoudont@chromium.org)
  11. Kim Paulhamus (kpaulhamusohnoyoudont@chromium.org)
  12. fuchsia-sdk-chromium-autoroll (fuchsia-sdk-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  13. Ian Clelland (iclellandohnoyoudont@chromium.org)
  14. Fabio Tirelo (ftireloohnoyoudont@chromium.org)
  15. Kenneth Russell (kbrohnoyoudont@chromium.org)
  16. perfetto-chromium-autoroll (perfetto-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  17. Daniel Murphy (dmurphohnoyoudont@chromium.org)
  18. Chromite Chromium Autoroll (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  19. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
  20. Lei Zhang (thestigohnoyoudont@chromium.org)
  21. Lu Chen (cheluohnoyoudont@chromium.org)
  22. Scott Chen (scottchenohnoyoudont@chromium.org)
  23. Kenneth Russell (kbrohnoyoudont@chromium.org)
  24. Kyle Milka (kmilkaohnoyoudont@chromium.org)
  25. skia-chromium-autoroll (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  26. Erik Luo (luoeohnoyoudont@chromium.org)
  27. Nate Fischer (ntfschrohnoyoudont@chromium.org)
  28. Michael Thiessen (mthiesseohnoyoudont@chromium.org)
  29. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
  30. Lei Zhang (thestigohnoyoudont@chromium.org)
  31. Scott Chen (scottchenohnoyoudont@chromium.org)
  32. Pedro Amaral (amaralpohnoyoudont@chromium.org)
  33. Christian Fremerey (chfremerohnoyoudont@chromium.org)
  34. Chris Palmer (palmerohnoyoudont@chromium.org)
  35. Tiger Oakes (tigeroohnoyoudont@google.com)
  36. Xiaocheng Hu (xiaochenghohnoyoudont@chromium.org)
  37. Weidong Guo (weidonggohnoyoudont@chromium.org)
  38. Min Qin (qinminohnoyoudont@chromium.org)
  39. Patrick Noland (pnolandohnoyoudont@google.com)
  40. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
  41. Thomas Tangl (tangltomohnoyoudont@chromium.org)
  42. Manu Cornet (manucornetohnoyoudont@chromium.org)
  43. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
  44. Rayan Kanso (rayankansohnoyoudont@chromium.org)
  45. Tom Anderson (thomasandersonohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 20:31:29 UTC
Start Thursday, 12-Jul-18 20:31:32 UTC
End Thursday, 12-Jul-18 21:30:24 UTC
Pending 2 secs
Execution 58 mins 51 secs

All Changes:

  1. Improved performance of AXPosition::operator less than

    Changed by Nektarios Paisios - nektarohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:01:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision adeaf13d9c8651fcf83c9e5a6a7d1173f1eb27e1

    Comments

    Improved performance of AXPosition::operator less than
    
    Only move up or down the tree using text equivalent positions (by calling CreateParentPosition and AsLeafTextPosition) when we absolutely need to.
    R=dmazzoni@chromium.org
    
    Tested: VoiceOver on Mac by navigating in Gmail and checking how many times you hear "Busy"
    Change-Id: Id9469e52ef87b8b8a0c6c5fac5325abec415382d
    Bug: 861567
    Reviewed-on: https://chromium-review.googlesource.com/1133334
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Nektarios Paisios <nektar@chromium.org>
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574689}

    Changed files

    • ui/accessibility/ax_node_position_unittest.cc
    • ui/accessibility/ax_position.h
  2. VR: fix autofill popup size

    Changed by Amirhossein Simjour - asimjourohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:01:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9d07f06bb5c43657ce38efc57039e36287eac2a6

    Comments

    VR: fix autofill popup size
    
    Break SetAlertDialogSize into to methods. One to set the relative
    size to the main content, another one to set the absolute size.
    Also added comment to hosted_platform_ui to clarify the size of
    the rectangle in the model.
    
    Bug: 863071
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Ie102fcb00865d66052e4bb3c7817831fdcfe5dfa
    Reviewed-on: https://chromium-review.googlesource.com/1132140
    Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
    Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574688}

    Changed files

    • chrome/browser/android/vr/vr_shell_gl.cc
    • chrome/browser/vr/model/hosted_platform_ui.h
    • chrome/browser/vr/ui.cc
    • chrome/browser/vr/ui.h
  3. [chromecast] Support for top-down drag gesture.

    Changed by Ryan Daum - rdaumohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:00:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7281e2b2ea7ce739c6106b6005a2d58a9eedb86a

    Comments

    [chromecast] Support for top-down drag gesture.
    
    Bug: internal b/111304882
    Test: unit test and manual
    Change-Id: Iab32b58098a02eb054faeb94625e312d274cdae1
    Reviewed-on: https://chromium-review.googlesource.com/1135692
    Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
    Commit-Queue: Alex Sakhartchouk <alexst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574687}

    Changed files

    • chromecast/browser/cast_content_window.h
    • chromecast/browser/cast_gesture_dispatcher.cc
    • chromecast/browser/cast_gesture_dispatcher.h
    • chromecast/browser/cast_gesture_dispatcher_test.cc
  4. [Nav Experiment] Parameterize HistoryStateOperationsTest.

    Changed by Danyao Wang - danyaoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:57:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 32bdecc1fac228cf335811bea0f31e2a29153f29

    Comments

    [Nav Experiment] Parameterize HistoryStateOperationsTest.
    
    So both LegacyNavigationManager and WKBasedNavigationManager can be
    tested on trybots.
    
    Fixed test expectation for StateReplacementBackForward to match the
    behavior of WebKit (and Safari on other platforms).
    
    Bug: 862724
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ic01dcabf2e6ef6903d8f8ee348798951007660cc
    Reviewed-on: https://chromium-review.googlesource.com/1134472
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574686}

    Changed files

    • ios/web/navigation/history_state_operations_inttest.mm
  5. Network quality servicification of RTT and downlink estimates

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:56:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 88c8cc52351f93d11e0bfac3b75ded5b420b131b

    Comments

    Network quality servicification of RTT and downlink estimates
    
    Send the RTT and downlink estimates over the mojo channel
    to the browser process. The RTT and downlink estimates are
    sent over an existing mojo message which carrier the current
    effective connection type estimate.
    
    The mojo message is sent only if there is a significant change
    in the values of either the RTT or the downlink estimate.
    
    In the next CL, I will move the network quality consumers
    in the browser process over to NetworkQualityTracker.
    
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I01bbc7af2e7e3cf41f69e7ac19f8edd9ec59de90
    Bug: 819244
    Reviewed-on: https://chromium-review.googlesource.com/1130233
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Helen Li <xunjieli@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574685}

    Changed files

    • chrome/browser/net/network_quality_tracker_browsertest.cc
    • services/network/network_quality_estimator_manager.cc
    • services/network/network_quality_estimator_manager.h
    • services/network/network_quality_estimator_manager_unittest.cc
    • services/network/public/cpp/network_quality_tracker.cc
    • services/network/public/cpp/network_quality_tracker.h
    • services/network/public/cpp/network_quality_tracker_unittest.cc
    • services/network/public/mojom/network_quality_estimator_manager.mojom
  6. [Fuchsia] Remove package detection in base::PathProviderFuchsia()

    Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:48:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4f9d9e774d5d41a5d8073b156348eee4bde25753

    Comments

    [Fuchsia] Remove package detection in base::PathProviderFuchsia()
    
    Previously PathProvider was trying to detect if it's packaged or not.
    That logic is no longer needed because we can assume that all binaries
    produced in chromium are packaged.
    
    Change-Id: I963afac5342d44b8d8188c07ffb927d6b4fac271
    Reviewed-on: https://chromium-review.googlesource.com/1134586
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574684}

    Changed files

    • base/base_paths_fuchsia.cc
  7. Add high water mark in background profiling triggers for memlog.

    Changed by erikchen - erikchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:47:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3483cb3aa6a9343b22e8ec39e81cb2fc864970a3

    Comments

    Add high water mark in background profiling triggers for memlog.
    
    Previously, a memlog report would be uploaded if a fixed threshold was exceeded.
    After that point, the timer frequency would be reduced to prevent too many
    reports from being uploaded.
    
    In this CL, we use a fixed, higher frequency timer to check memory usage. We
    upload an initial report if the fixed thresholds are exceeded, and then upload
    more reports each time the high water mark is exceeded by a significant amount.
    This allows us to catch higher-velocity memory leaks, that might otherwise cause
    the process to be killed before a report would be uploaded with the previous
    mechanism.
    
    Change-Id: I706314810d962c51e4126157363f44ce64868721
    Reviewed-on: https://chromium-review.googlesource.com/1132099
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Reviewed-by: Siddhartha S <ssid@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574683}

    Changed files

    • chrome/browser/profiling_host/background_profiling_triggers.cc
    • chrome/browser/profiling_host/background_profiling_triggers.h
    • chrome/browser/profiling_host/background_profiling_triggers_unittest.cc
  8. WebUI: update text to use primary/secondary colors for style refresh

    Changed by Esmael El-Moslimany - aeeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:47:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0ceaa55ab4070c9fc1bce4a599d62362576b1322

    Comments

    WebUI: update text to use primary/secondary colors for style refresh
    
    Bug: 849857
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ia64cd1565af8f50a4af8b5c08f82d9a13df00acf
    Reviewed-on: https://chromium-review.googlesource.com/1133959
    Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574682}

    Changed files

    • chrome/browser/resources/md_downloads/item.html
    • chrome/browser/resources/md_extensions/detail_view.html
    • chrome/browser/resources/md_extensions/error_page.html
    • chrome/browser/resources/md_extensions/manager.html
    • chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
    • chrome/browser/resources/settings/device_page/storage.html
    • chrome/browser/resources/settings/internet_page/network_summary_item.html
    • chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
    • chrome/browser/resources/settings/people_page/setup_pin_dialog.html
    • chrome/browser/resources/settings/settings_page/settings_subpage_search.html
    • chrome/browser/resources/settings/settings_shared_css.html
    • chrome/browser/resources/settings/site_settings/zoom_levels.html
    • ui/webui/resources/cr_elements/chromeos/network/cr_network_list_item.html
    • ui/webui/resources/cr_elements/paper_tabs_style_css.html
  9. Fix race-condition in SchedulerSingleThreadTaskRunnerManager::Start().

    Changed by Wez - wezohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:42:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 291f0a739f2c952d402f76d3750b9a2340269c18

    Comments

    Fix race-condition in SchedulerSingleThreadTaskRunnerManager::Start().
    
    SchedulerSingleThreadTaskRunnerManager allows SingleThreadTaskRunners to
    be created and tasks posted to them before the worker threads are
    actually started. The call to Start() the required workers was calling
    both Start() and WakeUp() on each of them, the latter being unnecessary
    since if a worker needs to process work then it must already have been
    woken, when the work was PostTask()d into it.
    
    Besides removing an unnecessary wake-up, this resolves a subtle race-
    condition between wake-up and a potential worker clean-up (see bug).
    
    Bug: 862582
    Change-Id: I9c4246cec4b1bda6d728e5e1656bb2c5ca7c0f0a
    Reviewed-on: https://chromium-review.googlesource.com/1133279
    Commit-Queue: Wez <wez@chromium.org>
    Reviewed-by: Robert Liao <robliao@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574681}

    Changed files

    • base/task_scheduler/scheduler_single_thread_task_runner_manager.cc
  10. VR: Update textures only if dirty

    Changed by Aldo Culquicondor - acondorohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:38:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7b520e5b526c4e1ed0a2344a79e42eb6fcf5c298

    Comments

    VR: Update textures only if dirty
    
    This prevents from performing unnecessary context switches.
    
    Bug: 861799
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I5da0e41dda9edb0243c9bbc9c944bdc2cdfaaf39
    Reviewed-on: https://chromium-review.googlesource.com/1133298
    Reviewed-by: Christopher Grant <cjgrant@chromium.org>
    Reviewed-by: Ian Vollick <vollick@chromium.org>
    Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574680}

    Changed files

    • chrome/browser/android/vr/vr_shell_gl.cc
    • chrome/browser/vr/elements/textured_element.cc
    • chrome/browser/vr/elements/textured_element.h
    • chrome/browser/vr/elements/ui_element.cc
    • chrome/browser/vr/elements/ui_element.h
    • chrome/browser/vr/test/ui_test.cc
    • chrome/browser/vr/ui.cc
    • chrome/browser/vr/ui.h
    • chrome/browser/vr/ui_scene.cc
    • chrome/browser/vr/ui_scene.h
  11. Disable flaky SitePerProcessHitTestBrowserTest

    Changed by Kim Paulhamus - kpaulhamusohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:35:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e031a4fd51a2eefc216a0f80f4bb139e1812b6c

    Comments

    Disable flaky SitePerProcessHitTestBrowserTest
    
    [OverlapSurfaceHitTestTest]
    
    TBR=sunxd@chromium.org
    
    Bug: 833380
    Change-Id: I7991db84dd9201e59089f08a536bcab00b23d379
    Reviewed-on: https://chromium-review.googlesource.com/1135648
    Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
    Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574679}

    Changed files

    • content/browser/site_per_process_hit_test_browsertest.cc
  12. Roll Fuchsia SDK from cf3c39f9e29d to 64ef9c9bec71

    Changed by fuchsia-sdk-chromium-autoroll - fuchsia-sdk-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:34:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0708b273b84747404d79725f8be67c90f3047079

    Comments

    Roll Fuchsia SDK from cf3c39f9e29d to 64ef9c9bec71
    
    
    The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
    TBR=cr-fuchsia+bot@chromium.org
    
    Change-Id: I44aa919993e7873807987396622c8fcb0bf2a17f
    Reviewed-on: https://chromium-review.googlesource.com/1135632
    Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574678}

    Changed files

    • build/fuchsia/sdk.sha1
  13. Clean up feature policy flags.

    Changed by Ian Clelland - iclellandohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:32:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 77533434f64cde2813381a26cce2247a62070a21

    Comments

    Clean up feature policy flags.
    
    This fixes the default feature list, ensuring that features only appear
    in it if they are actually enabled with the correct runtime feature
    flags. Even if they are shipped as 'stable', they can still be disabled,
    and should not be parsed in that case, or appear in the output of
    document.policy.allowedFeatures().
    
    Bug: 862601
    Change-Id: I207a17818ed6696e9d029b86adcf42e4b58b6516
    Reviewed-on: https://chromium-review.googlesource.com/1133307
    Reviewed-by: Jeremy Roman <jbroman@chromium.org>
    Commit-Queue: Ian Clelland <iclelland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574677}

    Changed files

    • third_party/blink/renderer/platform/feature_policy/feature_policy.cc
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  14. Reland: [af] Adjust dropdown so it doesn't look so close to the input element

    Changed by Fabio Tirelo - ftireloohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:22:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 03daf4e42f99ef9329ec05fc186c1936ffa718a9

    Comments

    Reland: [af] Adjust dropdown so it doesn't look so close to the input element
    
    This relands commit f1c12e6, which was reverted by commit c71c2c1.
    
    The reason for the revert was a crash introduced by c53515c, and
    reverting that commit was very hard due to merge conflicts.
    
    Bug: 847980
    Change-Id: Ib1b6931d3ac697e78c27a6cbcc7e082f0da4b6ef
    Reviewed-on: https://chromium-review.googlesource.com/1135446
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574676}

    Changed files

    • chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
  15. Complete upgrade of Retina Macs to 10.13.5.

    Changed by Kenneth Russell - kbrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:21:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 43d34bd136540d0ff14ed70bfc2a69019338595d

    Comments

    Complete upgrade of Retina Macs to 10.13.5.
    
    Turn off the multi-dimension trigger script.
    
    Fix the configuration of "Optional Mac Retina Release (AMD)"; a
    mistake was made in the earlier CL beginning the upgrade, and the jobs
    didn't auto-migrate from 10.12.6 to 10.13.5.
    
    Bug: 856799
    Tbr: ynovikov@chromium.org
    Change-Id: Ifcceed16154c47ffaa5b682149780bc53f4a101b
    Reviewed-on: https://chromium-review.googlesource.com/1135651
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574675}

    Changed files

    • testing/buildbot/chromium.gpu.fyi.json
    • testing/buildbot/chromium.gpu.json
    • testing/buildbot/waterfalls.pyl
  16. Roll src/third_party/perfetto f37ffaf9b1a1..2af75f76f0e6 (2 commits)

    Changed by perfetto-chromium-autoroll - perfetto-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:21:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7b6920828c5fa9f72dce1b84c9ae95711ae037e5

    Comments

    Roll src/third_party/perfetto f37ffaf9b1a1..2af75f76f0e6 (2 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/f37ffaf9b1a1..2af75f76f0e6
    
    
    git log f37ffaf9b1a1..2af75f76f0e6 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 michaschwab@google.com Merge "Improve Context Architecture, add "isOnCanvas" method"
    2018-07-12 michaschwab@google.com Improve Context Architecture, add "isOnCanvas" method
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@2af75f76f0e6
    
    The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I4222bc49a1619c3cc2972a496dd5e7e961d03363
    Reviewed-on: https://chromium-review.googlesource.com/1135213
    Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574674}

    Changed files

    • DEPS
  17. [SessionStorage] Always delete Session Storage database on Android

    Changed by Daniel Murphy - dmurphohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:18:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 154ac5551c1e0ff8c877b4cd0e26ad6ea30d4860

    Comments

    [SessionStorage] Always delete Session Storage database on Android
    
    Android doesn't have session restore code run, and this code is what
    cleaned up old session storage namespaces from previous browser runs.
    
    So on Android, the session storage context will delete the database
    on startup.
    
    R=mek@chromium.org
    
    Bug: 860030
    Change-Id: Ia7c349811e4970d05a071a0de9ad50117d771855
    Reviewed-on: https://chromium-review.googlesource.com/1125260
    Commit-Queue: Daniel Murphy <dmurph@chromium.org>
    Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574673}

    Changed files

    • content/browser/dom_storage/dom_storage_context_wrapper.cc
    • content/browser/dom_storage/session_storage_context_mojo.cc
    • content/browser/dom_storage/session_storage_context_mojo.h
    • content/browser/dom_storage/session_storage_context_mojo_unittest.cc
  18. Roll src/third_party/chromite 3973c26575e2..ca73efa2232f (1 commits)

    Changed by Chromite Chromium Autoroll - chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:18:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0113967ab2dcdc45364c7cfa35fd095856d7ede5

    Comments

    Roll src/third_party/chromite 3973c26575e2..ca73efa2232f (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/3973c26575e2..ca73efa2232f
    
    
    git log 3973c26575e2..ca73efa2232f --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 stevenjb@chromium.org deploy_chrome: Always prompt to remove rootfs verification
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@ca73efa2232f
    
    The AutoRoll server is located here: https://chromite-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I910679c20d35bb32e7f9e089bdde8a437a37961c
    Reviewed-on: https://chromium-review.googlesource.com/1135208
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574672}

    Changed files

    • DEPS
  19. [Unity][Android] Update string for payments sync datatype

    Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:17:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab5e146619a4ce43dd36939245a2b6a9a254ef90

    Comments

    [Unity][Android] Update string for payments sync datatype
    
    This CL changes the string used for payments in
    'Sync and Google services' preferences screen.
    
    Bug: 814728
    Change-Id: Ib1932ef94ad6f6b90efa5a59e0ef0500775b9496
    Reviewed-on: https://chromium-review.googlesource.com/1135321
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574671}

    Changed files

    • chrome/android/java/res/xml/sync_customization_preferences.xml
    • chrome/android/java/strings/android_chrome_strings.grd
  20. Move PDFiumEngine doc/form/loading members into PDFiumDocument.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:16:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 94754366872ddaafeb4ec141f971ee47d3350c59

    Comments

    Move PDFiumEngine doc/form/loading members into PDFiumDocument.
    
    Change-Id: I11c1ecff9305a75f66c3de5443fde4d0423163d2
    Reviewed-on: https://chromium-review.googlesource.com/1112498
    Reviewed-by: dsinclair <dsinclair@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574670}

    Changed files

    • pdf/BUILD.gn
    • pdf/pdfium/pdfium_document.cc
    • pdf/pdfium/pdfium_document.h
    • pdf/pdfium/pdfium_engine.cc
    • pdf/pdfium/pdfium_engine.h
  21. Add bad IPC message check at the browser.

    Changed by Lu Chen - cheluohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:15:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f9ecec290e797566bdbbe41459d68a4045e29b5e

    Comments

    Add bad IPC message check at the browser.
    
    Add bad IPC message check to UpdateAnchorElementMetrics. The browser
    will kill the renderer process when it receives a bad message.
    
    Bug: 850624
    Change-Id: I750b6d54e556ddc659cb693844922234b9e845ce
    Reviewed-on: https://chromium-review.googlesource.com/1128259
    Commit-Queue: Lu Chen <chelu@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574669}

    Changed files

    • chrome/browser/navigation_predictor/navigation_predictor.cc
    • chrome/browser/navigation_predictor/navigation_predictor.h
    • chrome/browser/navigation_predictor/navigation_predictor_unittest.cc
    • tools/metrics/histograms/histograms.xml
  22. Settings: fix sync-account-controls banner overflowing border-radius.

    Changed by Scott Chen - scottchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:15:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 66d0e64aa958612d6b9cf38b9b8409925487458b

    Comments

    Settings: fix sync-account-controls banner overflowing border-radius.
    
    Bug: 860265
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ie85c25b7b777463569f4d3b4f01f8a8e524c84f5
    Reviewed-on: https://chromium-review.googlesource.com/1133977
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574668}

    Changed files

    • chrome/browser/resources/settings/people_page/people_page.html
    • chrome/browser/resources/settings/people_page/sync_account_control.html
  23. Update GPU pixel wrangling graphs for macOS 10.13.5 upgrade.

    Changed by Kenneth Russell - kbrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:14:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 32b92d2bc9ae9c12e01f7879de715843ac849ae8

    Comments

    Update GPU pixel wrangling graphs for macOS 10.13.5 upgrade.
    
    Tbr: ynovikov@chromium.org
    Bug: 856799
    Change-Id: I6d7265037477715df7ca7e31290ef88f7ad4f668
    Reviewed-on: https://chromium-review.googlesource.com/1135657
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574667}

    Changed files

    • docs/gpu/pixel_wrangling.md
  24. [NTP] Add Google Photos option for custom backgrounds

    Changed by Kyle Milka - kmilkaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:13:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d87ed83235c1f5505f58b0d51923dfe11db9faae

    Comments

    [NTP] Add Google Photos option for custom backgrounds
    
    Allow users to select one of their photos from Google Photos and set it
    as the NTP background image. Currently only supports users who are
    already signed in to their Google account.
    
    Bug: 848012
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Idef07f3cd107199a8e308fc883c96b9a8da37b1e
    Reviewed-on: https://chromium-review.googlesource.com/1130100
    Commit-Queue: Kyle Milka <kmilka@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574666}

    Changed files

    • chrome/browser/resources/local_ntp/custom_backgrounds.css
    • chrome/browser/resources/local_ntp/custom_backgrounds.js
    • chrome/browser/resources/local_ntp/local_ntp.html
    • chrome/browser/search/background/ntp_background_data.cc
    • chrome/browser/search/background/ntp_background_data.h
    • chrome/browser/search/background/ntp_background_service.cc
    • chrome/browser/search/local_ntp_source.cc
    • chrome/test/data/local_ntp/local_ntp_browsertest.html
  25. Roll src/third_party/skia 56a426a516d0..5551a94b9e0f (15 commits)

    Changed by skia-chromium-autoroll - skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:12:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 521effcf577f74a61bd5d6a35074ed2e3d20abd0

    Comments

    Roll src/third_party/skia 56a426a516d0..5551a94b9e0f (15 commits)
    
    https://skia.googlesource.com/skia.git/+log/56a426a516d0..5551a94b9e0f
    
    
    git log 56a426a516d0..5551a94b9e0f --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 mtklein@chromium.org update color management for color shaders
    2018-07-12 brianosman@google.com Update SRGBReadWritePixelsTest again, to only test opaque colors
    2018-07-12 fmalita@chromium.org PathKit/WASM tweaks
    2018-07-12 mtklein@chromium.org update mode color filter color management
    2018-07-12 mtklein@chromium.org remove unused parts of SkModeColorFilter
    2018-07-12 ziadb@google.com Java-only version of SkAR: drawing on android Canvas
    2018-07-12 brianosman@google.com Remove SK_LEGACY_GPU_PIXEL_OPS tests
    2018-07-12 egdaniel@google.com Generate GrVkInterface when we make the GrVkGpu.
    2018-07-12 reed@google.com remove unneeded scale from procs
    2018-07-12 brianosman@google.com In RGBA444TextureTest, use valid premul colors
    2018-07-12 borenet@google.com Roll Chromium manually to last successful CommandBuffer run
    2018-07-12 mtklein@chromium.org fix color management of CPU drawVertices()
    2018-07-12 caryclark@skia.org remove more references to draw filter
    2018-07-12 bsalomon@google.com remove debug gl interface, grcontextfactory context type, and config.
    2018-07-12 benjaminwagner@google.com Upgrade Skolo Mac bots to 10.13.6.
    
    
    Created with:
      gclient setdep -r src/third_party/skia@5551a94b9e0f
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: I31983fe5eb6e60f68f6b46ed52741dd82999eb78
    Reviewed-on: https://chromium-review.googlesource.com/1135209
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574665}

    Changed files

    • DEPS
  26. DevTools: clicking clear on input should focus

    Changed by Erik Luo - luoeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:11:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cdc1f3d342363df455d02fde8bc04d44f5331e5e

    Comments

    DevTools: clicking clear on input should focus
    
    The act of clicking the 'x' clear button blurs focus. This CL ensures
    the input focuses afterwards.
    
    Bug: 831059
    Change-Id: I848296c0981873cd878f5aaaead9654809811349
    Reviewed-on: https://chromium-review.googlesource.com/1134577
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Commit-Queue: Erik Luo <luoe@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574664}

    Changed files

    • third_party/blink/renderer/devtools/front_end/ui/Toolbar.js
  27. AW: trace events for WindowAndroid verification issues

    Changed by Nate Fischer - ntfschrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:10:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f50fc4d425345286e65488344fd85981bef36c94

    Comments

    AW: trace events for WindowAndroid verification issues
    
    No change to logic.
    
    This adds trace events inside AwContents to track WindowAndroid-related
    class verification errors. Specifically, this should illustrate the
    following verification errors:
    
     * WindowAndroid verification errors should cause activityFromContext to
       take longer than necessary.
     * ActivityWindowAndroid fails verification (because its superclass
       WindowAndroid fails verification), causing its constructor to take
       longer than necessary.
    
    R=torne@chromium.org
    
    Bug: 855796
    Test: tools/perf/run_benchmark system_health.webview_startup --browser android-webview-google
    Change-Id: I6633496fd672300216dfa6425910d19a7ae9e3da
    Reviewed-on: https://chromium-review.googlesource.com/1132479
    Reviewed-by: Richard Coles <torne@chromium.org>
    Commit-Queue: Nate Fischer <ntfschr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574663}

    Changed files

    • android_webview/java/src/org/chromium/android_webview/AwContents.java
  28. Fix VR watchlist

    Changed by Michael Thiessen - mthiesseohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:10:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a7bec5b1769172d3b2722182969d5c1ed618bc42

    Comments

    Fix VR watchlist
    
    Broken in https://chromium-review.googlesource.com/c/chromium/src/+/1134091/9/WATCHLISTS.
    
    Change-Id: Id84c46bb2f52d397975e1c3797a182b2becf9c07
    Reviewed-on: https://chromium-review.googlesource.com/1135115
    Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
    Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574662}

    Changed files

    • WATCHLISTS
  29. Restore some checks in FrameLoader::CommitNavigation

    Changed by Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:06:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cd7f8b8a57712e9a2b2deb2a10282dea99bdb5eb

    Comments

    Restore some checks in FrameLoader::CommitNavigation
    
    These were dropped when separating StartNavigation from
    CommitNavigation. It's reasonable that we cannot be in StopAllLoaders
    or similar unless there is a nested message loop.
    
    See test for an example how print() triggers this stack:
    ...<message loop running here, dispatched CommitNavigation>...
    IPC::SyncChannel::Send()
    content::RenderThreadImpl::Send()
    printing::PrintRenderFrameHelper::RequestPrintPreview()
    content::RenderFrameImpl::ScriptedPrint()
    blink::ChromeClientImpl::PrintDelegate()
    blink::ChromeClient::Print()
    blink::LocalDOMWindow::FinishedLoading()
    blink::FrameLoader::DidFinishNavigation()
    blink::Document::CheckCompleted()
    blink::FrameLoader::DetachProvisionalDocumentLoader()
    blink::DocumentLoader::StopLoading()
    blink::DocumentLoader::DetachFromFrame()
    blink::WebDocumentLoaderImpl::DetachFromFrame()
    blink::FrameLoader::StopAllLoaders()
    blink::LocalFrame::Detach()
    blink::HTMLPlugInElement::DisconnectContentFrame()
    blink::ChildFrameDisconnector::DisconnectCollectedFrameOwners()
    blink::ContainerNode::WillRemoveChild()
    blink::ContainerNode::RemoveChild()
    ...<JavaScript>...
    
    Bug: 860208, 853487, 862088
    Change-Id: Ieb3f0330828f0a031a97d08cdc1ba7de8a3f0edc
    Reviewed-on: https://chromium-review.googlesource.com/1130223
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574661}

    Changed files

    • third_party/WebKit/LayoutTests/fast/loader/detach-while-printing-expected.txt
    • third_party/WebKit/LayoutTests/fast/loader/detach-while-printing.html
    • third_party/blink/renderer/core/loader/frame_loader.cc
  30. Update PDFExtensionTest test expectation.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:06:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision be8ff3e12884ec3188e5fb909b31a62b9412d808

    Comments

    Update PDFExtensionTest test expectation.
    
    After https://pdfium-review.googlesource.com/35432 got rolled into
    Chromium in r570889, a previously failing test case now started passing.
    
    BUG=860757
    
    Change-Id: I998a0ea8a91770bb27d92491a12ac0816f535054
    Reviewed-on: https://chromium-review.googlesource.com/1132633
    Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574660}

    Changed files

    • chrome/browser/pdf/pdf_extension_test.cc
  31. Settings: fix cups printer search field logic.

    Changed by Scott Chen - scottchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:05:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b1fa8446eb300966ba4c7c4e6c02e9f9f86fedc

    Comments

    Settings: fix cups printer search field logic.
    
    An earlier CL (1088163) broke the logic for drop-down search fields in
    CUPS add/edit printer dialog, by setting the searchTerm_ property to the
    wrong value. This CL fixes that issue.
    
    The aforementioned CL also accidentally notifies the parent of the input
    value too often, which is also fixed in this CL.
    
    Tests are added to prevent both regressions in the future.
    
    Bug: 860475
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I3949c01edacc53b5aa0f8b6b25ef57b3acb00577
    Reviewed-on: https://chromium-review.googlesource.com/1132238
    Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574659}

    Changed files

    • chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
    • chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.js
    • chrome/test/data/webui/settings/cups_printer_page_tests.js
  32. Making a menu button component

    Changed by Pedro Amaral - amaralpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:03:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c59b348ffef08cfdca20701f4f54236f9e6e295

    Comments

    Making a menu button component
    
    Pulling the menu button out of the bottom toolbar component into its
    own class.
    
    Bug: 862863
    
    
    Change-Id: Icb2230259d7f1d3ac2f47f3b8ee33e659579ca96
    Reviewed-on: https://chromium-review.googlesource.com/1132423
    Commit-Queue: Pedro Amaral <amaralp@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: Matthew Jones <mdjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574658}

    Changed files

    • chrome/android/java/res/layout/menu_button.xml
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarMediator.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarModel.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/MenuButton.java
    • chrome/android/java_sources.gni
  33. [Video Capture] Abstract out V4L2 API calls to an interface

    Changed by Christian Fremerey - chfremerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:59:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dbf002c655a394a5235cef285a40059f8d32d678

    Comments

    [Video Capture] Abstract out V4L2 API calls to an interface
    
    This CL abstracts V4L2 API calls made from Chromium's video capture
    implementation on Linux out to an interface. This is to enable testability of
    the code that makes such calls without requiring heavy-weight solutions such
    as attaching actual hardware or kernel-level emulators.
    
    This CL is a pure refactoring and has no intended function change.
    
    This CL is part of a series, see Design Doc at
    https://docs.google.com/document/d/1ihGDZloUGdDpZ5XfmiI3AcqsSxOP9kOe5GxXOTqpHW4/edit?usp=sharing
    
    Test: capture_unittests with physical camera attached
    Bug: 768887
    Change-Id: I9208f4a61731c8dc5827c1f5f5ef31d078520270
    Reviewed-on: https://chromium-review.googlesource.com/1120856
    Reviewed-by: Emircan Uysaler <emircan@chromium.org>
    Commit-Queue: Christian Fremerey <chfremer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574657}

    Changed files

    • media/capture/BUILD.gn
    • media/capture/video/linux/v4l2_capture_delegate.cc
    • media/capture/video/linux/v4l2_capture_delegate.h
    • media/capture/video/linux/v4l2_capture_delegate_unittest.cc
    • media/capture/video/linux/v4l2_capture_device.h
    • media/capture/video/linux/v4l2_capture_device_impl.cc
    • media/capture/video/linux/v4l2_capture_device_impl.h
    • media/capture/video/linux/video_capture_device_chromeos.cc
    • media/capture/video/linux/video_capture_device_chromeos.h
    • media/capture/video/linux/video_capture_device_factory_linux.cc
    • media/capture/video/linux/video_capture_device_factory_linux.h
    • media/capture/video/linux/video_capture_device_linux.cc
    • media/capture/video/linux/video_capture_device_linux.h
  34. Change DECHECKs to CHECKs in `base::RingBuffer`.

    Changed by Chris Palmer - palmerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:58:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 940e9a3140b1e0b636f185ff65f20226e997d897

    Comments

    Change DECHECKs to CHECKs in `base::RingBuffer`.
    
    Better safe than sorry!
    
    In the process, do some micro-optimization to make the CHECKs as cheap as
    possible.
    
    Bug: 817982
    Change-Id: I2c45d7e773199a12ce4ae34b4a750ac2b66cb7c2
    Reviewed-on: https://chromium-review.googlesource.com/1134486
    Reviewed-by: danakj <danakj@chromium.org>
    Commit-Queue: Chris Palmer <palmer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574656}

    Changed files

    • base/containers/ring_buffer.h
  35. Groups small symbols at the file level

    Changed by Tiger Oakes - tigeroohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 18:57:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5b84bff2c5ba0511930b78e6d864bfb8ef0bb03

    Comments

    Groups small symbols at the file level
    
    Previously, symbols below min_symbol_size were all placed in an
    "(Other)" file entry at the root of the tree. Now, they are placed
    inside their original file entry but grouped together based on type.
    This ensures byte counts are always accurate, even past the root node.
    This is also the only blocker before we can remove the old UI.
    
    Additionally made some changes to improve first-load performance by
    starting tree building as soon as possible.
    
    Bug: 860303
    Change-Id: I02daee8994d9b7b236837b78585ac8a9c3297125
    Reviewed-on: https://chromium-review.googlesource.com/1135193
    Commit-Queue: Tiger Oakes <tigero@google.com>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Reviewed-by: Peter Wen <wnwen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574655}

    Changed files

    • tools/binary_size/libsupersize/html_report.py
    • tools/binary_size/libsupersize/template_tree_view/index.html
    • tools/binary_size/libsupersize/template_tree_view/start-worker.js
    • tools/binary_size/libsupersize/template_tree_view/state.js
    • tools/binary_size/libsupersize/template_tree_view/tree-ui.js
    • tools/binary_size/libsupersize/template_tree_view/tree-worker.js
  36. Convert two crash layout tests to use testharness

    Changed by Xiaocheng Hu - xiaochenghohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:57:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0279bf752fc5d6e5f0df324190ab72d7bc831010

    Comments

    Convert two crash layout tests to use testharness
    
    The following two layout tests are crash tests and don't need text dump:
    - fast/text/editing-text-crash.html
    - fast/text/text-iterator-crash.html
    
    This patch converts them with testharness for better code health.
    
    Change-Id: I528a681bb6a17e2fb9f6122d6ec42f9722a575df
    Reviewed-on: https://chromium-review.googlesource.com/1134594
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Reviewed-by: Yoichi Osato <yoichio@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574654}

    Changed files

    • third_party/WebKit/LayoutTests/fast/text/editing-text-crash-expected.txt
    • third_party/WebKit/LayoutTests/fast/text/editing-text-crash.html
    • third_party/WebKit/LayoutTests/fast/text/text-iterator-crash-expected.txt
    • third_party/WebKit/LayoutTests/fast/text/text-iterator-crash.html
  37. Introduce GetAppShortcutGlobalQueryItems mojo method

    Changed by Weidong Guo - weidonggohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:56:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f70dc791c0f421c6ac340019a9721df97af0da8d

    Comments

    Introduce GetAppShortcutGlobalQueryItems mojo method
    
    The original solution passing all available app shortcuts metadata to
    Chrome has large latency because getting icons is expensive. This CL
    proposes a new API that passes query and maxResults to Android, and
    searching & results num throttling is done in Android as well.
    Android side change is in ag/4432308.
    
    Bug: 842947
    Test: manual test, latency is controlled in tens milliseconds
    
    Change-Id: I48c168ffd56826c10a4b6d5befb995a087f4a0b2
    Reviewed-on: https://chromium-review.googlesource.com/1117893
    Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Yury Khmel <khmel@chromium.org>
    Reviewed-by: Qiang Xu <warx@google.com>
    Commit-Queue: Weidong Guo <weidongg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574653}

    Changed files

    • chrome/browser/ui/app_list/search/arc/arc_app_shortcuts_search_provider.cc
    • chrome/browser/ui/app_list/search/arc/arc_app_shortcuts_search_provider.h
    • chrome/browser/ui/app_list/search/arc/arc_app_shortcuts_search_provider_unittest.cc
    • chrome/browser/ui/app_list/search/search_controller_factory.cc
    • components/arc/common/app.mojom
    • components/arc/test/fake_app_instance.cc
    • components/arc/test/fake_app_instance.h
  38. Always prompt user if opening a download thru extensions with debugger permission

    Changed by Min Qin - qinminohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:55:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a4a89a53791a508896b388b0d818644834c0d6d

    Comments

    Always prompt user if opening a download thru extensions with debugger permission
    
    The user gesture can be faked, so we shouldn't trust it
    
    BUG=854455
    
    Change-Id: Ib42911a77d3f519554a5b9a4c1464ec50e79f268
    Reviewed-on: https://chromium-review.googlesource.com/1135525
    Reviewed-by: Xing Liu <xingliu@chromium.org>
    Commit-Queue: Min Qin <qinmin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574652}

    Changed files

    • chrome/browser/extensions/api/downloads/downloads_api.cc
  39. Check against null frame_ in GetCanonicalUrlForSharing

    Changed by Patrick Noland - pnolandohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 18:50:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dd341220c263993037559e62938d54d5cf091a2c

    Comments

    Check against null frame_ in GetCanonicalUrlForSharing
    
    Bug: 852350
    Change-Id: Ib6c4cc79572d3dad22f663ec61a20bc54f5d7a8f
    Reviewed-on: https://chromium-review.googlesource.com/1117847
    Commit-Queue: Charlie Reis <creis@chromium.org>
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574651}

    Changed files

    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl_browsertest.cc
  40. FrameLoader: move CancelParsing and CheckCompleted earlier

    Changed by Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:50:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae5ca38f28d3e136c7def1fe7444afed1db7ea9a

    Comments

    FrameLoader: move CancelParsing and CheckCompleted earlier
    
    This way we do it before creating new provisional loader, which
    will help in the future when there would be no provisional loader.
    
    Added Document::Abort method which encapsulates CancelParsing
    and CheckCompleted and also does not issue undesired DidFinishNavigation.
    
    Bug: 831155
    Change-Id: Ica5d968508d7aed7bb07125702ceeaeb6f389497
    Reviewed-on: https://chromium-review.googlesource.com/1119262
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574650}

    Changed files

    • third_party/WebKit/LayoutTests/http/tests/loading/onreadystatechange-detach-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/loading/onreadystatechange-window-stop.html
    • third_party/blink/renderer/core/dom/document.cc
    • third_party/blink/renderer/core/dom/document.h
    • third_party/blink/renderer/core/loader/frame_loader.cc
  41. [unified-consent] Add unified-consent logic to sync confirmation dialog

    Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:49:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ce72c61e3d03607baa3881262eaf5f9d6a06df67

    Comments

    [unified-consent] Add unified-consent logic to sync confirmation dialog
    
    When unified consent is enabled and the user opts into the new unified
    consent sync dialog, unified-consent is given and all services enabled.
    
    Additional changes:
     - Introduce FakeUnifiedConsentServiceClient
     - Add a builder function that creates a UnifiedConsentService for
     testing, using FakeUnifiedConsentServiceClient
    
    Bug: 862202
    Change-Id: I7c70bc45ebbc561916fd618f0b1850525b2cffe0
    Reviewed-on: https://chromium-review.googlesource.com/1131513
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574649}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.cc
    • chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.h
    • chrome/browser/ui/webui/signin/dice_turn_sync_on_helper_unittest.cc
    • chrome/browser/unified_consent/unified_consent_service_factory.cc
    • chrome/browser/unified_consent/unified_consent_test_util.cc
    • chrome/browser/unified_consent/unified_consent_test_util.h
    • components/unified_consent/unified_consent_service.cc
    • components/unified_consent/unified_consent_service.h
    • components/unified_consent/unified_consent_service_unittest.cc
  42. Shelf new UI: center items on the total shelf size

    Changed by Manu Cornet - manucornetohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:46:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e2ccd76952b57016daccdd19fde7a54d1719a7b

    Comments

    Shelf new UI: center items on the total shelf size
    
    Bug: 805612
    Change-Id: I9c6e0c0aab7f39681bec850ee18d890a9410990c
    Reviewed-on: https://chromium-review.googlesource.com/1135298
    Commit-Queue: Manu Cornet <manucornet@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574648}

    Changed files

    • ash/shelf/shelf_view.cc
  43. [Unity][Android] Update personalized sign-in promo descriptions

    Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:43:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1806fde687718fd19118e7a6f09e0d5610239cb5

    Comments

    [Unity][Android] Update personalized sign-in promo descriptions
    
    This CL adds a second set of description strings for personalized
    sign-in promos. This set of strings is shown if UnifiedConsent feature
    is enabled.
    
    Bug: 814728
    Change-Id: I1d90a2ec786397326b6d80011c0de6d31468431b
    Reviewed-on: https://chromium-review.googlesource.com/1131500
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574647}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
    • chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoController.java
    • chrome/android/java/strings/android_chrome_strings.grd
    • chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
  44. [Background Fetch] Fix dispatched event name on failure.

    Changed by Rayan Kanso - rayankansohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:42:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7523f88574031a353b4ce24fa9cb87dfbcc2b11

    Comments

    [Background Fetch] Fix dispatched event name on failure.
    
    TBR=falken@chromium.org
    
    Change-Id: Iba46fbe0eee3a886a847fc259d45e51ecfa81dd1
    Reviewed-on: https://chromium-review.googlesource.com/1135451
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574646}

    Changed files

    • third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc
  45. Fix tabstrip edges not redrawing when entering/leaving single tab mode

    Changed by Tom Anderson - thomasandersonohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:42:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 901634eeb056e61914c0b70b43adff655d156c2b

    Comments

    Fix tabstrip edges not redrawing when entering/leaving single tab mode
    
    BUG=860859
    R=pkasting
    
    Change-Id: I9766d6c175fa6bdd8906c58448bf94ae85a17141
    Reviewed-on: https://chromium-review.googlesource.com/1135512
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574645}

    Changed files

    • chrome/browser/ui/views/frame/opaque_browser_frame_view.cc