Home | Search | chromium - Builders
Login

Builder Linux TSan Tests Build 23673 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision9b78521765f33993e81dfba771127fe9d5eb4add
Got Revision9b78521765f33993e81dfba771127fe9d5eb4add

Execution:

Steps and Logfiles:

Show:
  1. ( 305 ms ) setup_build
    running recipe: "chromium"
  2. ( 493 ms ) remove .cipd
  3. ( 43 secs ) bot_update
    [59GB/295GB used (20%)]
  4. ( 0 ) ensure_goma
  5. ( 573 ms ) swarming.py --version
    0.13
  6. ( 9 secs ) gclient runhooks
  7. ( 775 ms ) read test spec (chromium.memory.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.memory.json
  8. ( 2 secs ) build directory
  9. ( 4 mins 4 secs ) extract build
  10. ( 788 ms ) find isolated tests
  11. ( 0 ) test_pre_run
  12. ( 1 secs ) test_pre_run.[trigger] accessibility_unittests
    Run on OS: 'Ubuntu-14.04'
  13. ( 1 secs ) test_pre_run.[trigger] angle_unittests
    Run on OS: 'Ubuntu-14.04'
  14. ( 1 secs ) test_pre_run.[trigger] app_shell_unittests
    Run on OS: 'Ubuntu-14.04'
  15. ( 1 secs ) test_pre_run.[trigger] aura_unittests
    Run on OS: 'Ubuntu-14.04'
  16. ( 1 secs ) test_pre_run.[trigger] base_unittests
    Run on OS: 'Ubuntu-14.04'
  17. ( 1 secs ) test_pre_run.[trigger] battor_agent_unittests
    Run on OS: 'Ubuntu-14.04'
  18. ( 1 secs ) test_pre_run.[trigger] blink_common_unittests
    Run on OS: 'Ubuntu-14.04'
  19. ( 1 secs ) test_pre_run.[trigger] blink_fuzzer_unittests
    Run on OS: 'Ubuntu-14.04'
  20. ( 1 secs ) test_pre_run.[trigger] blink_platform_unittests
    Run on OS: 'Ubuntu-14.04'
  21. ( 1 secs ) test_pre_run.[trigger] boringssl_crypto_tests
    Run on OS: 'Ubuntu-14.04'
  22. ( 1 secs ) test_pre_run.[trigger] boringssl_ssl_tests
    Run on OS: 'Ubuntu-14.04'
  23. ( 975 ms ) test_pre_run.[trigger] cacheinvalidation_unittests
    Run on OS: 'Ubuntu-14.04'
  24. ( 1 secs ) test_pre_run.[trigger] capture_unittests
    Run on OS: 'Ubuntu-14.04'
  25. ( 1 secs ) test_pre_run.[trigger] cast_unittests
    Run on OS: 'Ubuntu-14.04'
  26. ( 1 secs ) test_pre_run.[trigger] cc_unittests
    Run on OS: 'Ubuntu-14.04'
  27. ( 946 ms ) test_pre_run.[trigger] chrome_app_unittests
    Run on OS: 'Ubuntu-14.04'
  28. ( 1 secs ) test_pre_run.[trigger] chromedriver_unittests
    Run on OS: 'Ubuntu-14.04'
  29. ( 1 secs ) test_pre_run.[trigger] components_browsertests
    Run on OS: 'Ubuntu-14.04'
  30. ( 1 secs ) test_pre_run.[trigger] components_unittests
    Run on OS: 'Ubuntu-14.04'
  31. ( 1 secs ) test_pre_run.[trigger] compositor_unittests
    Run on OS: 'Ubuntu-14.04'
  32. ( 2 secs ) test_pre_run.[trigger] content_browsertests
    Run on OS: 'Ubuntu-14.04'
  33. ( 6 secs ) test_pre_run.[trigger] viz_content_browsertests
    Run on OS: 'Ubuntu-14.04'
  34. ( 1 secs ) test_pre_run.[trigger] content_unittests
    Run on OS: 'Ubuntu-14.04'
  35. ( 1 secs ) test_pre_run.[trigger] viz_content_unittests
    Run on OS: 'Ubuntu-14.04'
  36. ( 1 secs ) test_pre_run.[trigger] cronet_tests
    Run on OS: 'Ubuntu-14.04'
  37. ( 978 ms ) test_pre_run.[trigger] cronet_unittests
    Run on OS: 'Ubuntu-14.04'
  38. ( 1 secs ) test_pre_run.[trigger] crypto_unittests
    Run on OS: 'Ubuntu-14.04'
  39. ( 959 ms ) test_pre_run.[trigger] dbus_unittests
    Run on OS: 'Ubuntu-14.04'
  40. ( 1 secs ) test_pre_run.[trigger] device_unittests
    Run on OS: 'Ubuntu-14.04'
  41. ( 992 ms ) test_pre_run.[trigger] display_unittests
    Run on OS: 'Ubuntu-14.04'
  42. ( 1 secs ) test_pre_run.[trigger] events_unittests
    Run on OS: 'Ubuntu-14.04'
  43. ( 1 secs ) test_pre_run.[trigger] extensions_browsertests
    Run on OS: 'Ubuntu-14.04'
  44. ( 1 secs ) test_pre_run.[trigger] extensions_unittests
    Run on OS: 'Ubuntu-14.04'
  45. ( 1 secs ) test_pre_run.[trigger] filesystem_service_unittests
    Run on OS: 'Ubuntu-14.04'
  46. ( 999 ms ) test_pre_run.[trigger] gcm_unit_tests
    Run on OS: 'Ubuntu-14.04'
  47. ( 1 secs ) test_pre_run.[trigger] gfx_unittests
    Run on OS: 'Ubuntu-14.04'
  48. ( 1 secs ) test_pre_run.[trigger] gin_unittests
    Run on OS: 'Ubuntu-14.04'
  49. ( 1 secs ) test_pre_run.[trigger] gl_unittests
    Run on OS: 'Ubuntu-14.04'
  50. ( 1 secs ) test_pre_run.[trigger] google_apis_unittests
    Run on OS: 'Ubuntu-14.04'
  51. ( 1 secs ) test_pre_run.[trigger] gpu_unittests
    Run on OS: 'Ubuntu-14.04'
  52. ( 1 secs ) test_pre_run.[trigger] headless_unittests
    Run on OS: 'Ubuntu-14.04'
  53. ( 3 secs ) test_pre_run.[trigger] interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
  54. ( 962 ms ) test_pre_run.[trigger] ipc_tests
    Run on OS: 'Ubuntu-14.04'
  55. ( 953 ms ) test_pre_run.[trigger] jingle_unittests
    Run on OS: 'Ubuntu-14.04'
  56. ( 1 secs ) test_pre_run.[trigger] latency_unittests
    Run on OS: 'Ubuntu-14.04'
  57. ( 991 ms ) test_pre_run.[trigger] leveldb_service_unittests
    Run on OS: 'Ubuntu-14.04'
  58. ( 1 secs ) test_pre_run.[trigger] libjingle_xmpp_unittests
    Run on OS: 'Ubuntu-14.04'
  59. ( 1 secs ) test_pre_run.[trigger] media_blink_unittests
    Run on OS: 'Ubuntu-14.04'
  60. ( 948 ms ) test_pre_run.[trigger] media_service_unittests
    Run on OS: 'Ubuntu-14.04'
  61. ( 1 secs ) test_pre_run.[trigger] media_unittests
    Run on OS: 'Ubuntu-14.04'
  62. ( 1 secs ) test_pre_run.[trigger] message_center_unittests
    Run on OS: 'Ubuntu-14.04'
  63. ( 1 secs ) test_pre_run.[trigger] midi_unittests
    Run on OS: 'Ubuntu-14.04'
  64. ( 1 secs ) test_pre_run.[trigger] mojo_core_unittests
    Run on OS: 'Ubuntu-14.04'
  65. ( 1 secs ) test_pre_run.[trigger] mojo_unittests
    Run on OS: 'Ubuntu-14.04'
  66. ( 911 ms ) test_pre_run.[trigger] native_theme_unittests
    Run on OS: 'Ubuntu-14.04'
  67. ( 2 secs ) test_pre_run.[trigger] net_unittests
    Run on OS: 'Ubuntu-14.04'
  68. ( 1 secs ) test_pre_run.[trigger] pdf_unittests
    Run on OS: 'Ubuntu-14.04'
  69. ( 894 ms ) test_pre_run.[trigger] ppapi_unittests
    Run on OS: 'Ubuntu-14.04'
  70. ( 3 secs ) test_pre_run.[trigger] printing_unittests
    Run on OS: 'Ubuntu-14.04'
  71. ( 1 secs ) test_pre_run.[trigger] remoting_unittests
    Run on OS: 'Ubuntu-14.04'
  72. ( 1 secs ) test_pre_run.[trigger] sandbox_linux_unittests
    Run on OS: 'Ubuntu-14.04'
  73. ( 1 secs ) test_pre_run.[trigger] service_manager_unittests
    Run on OS: 'Ubuntu-14.04'
  74. ( 1 secs ) test_pre_run.[trigger] services_unittests
    Run on OS: 'Ubuntu-14.04'
  75. ( 993 ms ) test_pre_run.[trigger] shell_dialogs_unittests
    Run on OS: 'Ubuntu-14.04'
  76. ( 946 ms ) test_pre_run.[trigger] skia_unittests
    Run on OS: 'Ubuntu-14.04'
  77. ( 1 secs ) test_pre_run.[trigger] snapshot_unittests
    Run on OS: 'Ubuntu-14.04'
  78. ( 1 secs ) test_pre_run.[trigger] sql_unittests
    Run on OS: 'Ubuntu-14.04'
  79. ( 1 secs ) test_pre_run.[trigger] storage_unittests
    Run on OS: 'Ubuntu-14.04'
  80. ( 1 secs ) test_pre_run.[trigger] ui_base_unittests
    Run on OS: 'Ubuntu-14.04'
  81. ( 1 secs ) test_pre_run.[trigger] ui_touch_selection_unittests
    Run on OS: 'Ubuntu-14.04'
  82. ( 1 secs ) test_pre_run.[trigger] unit_tests
    Run on OS: 'Ubuntu-14.04'
  83. ( 1 secs ) test_pre_run.[trigger] url_unittests
    Run on OS: 'Ubuntu-14.04'
  84. ( 1 secs ) test_pre_run.[trigger] views_unittests
    Run on OS: 'Ubuntu-14.04'
  85. ( 1 secs ) test_pre_run.[trigger] viz_unittests
    Run on OS: 'Ubuntu-14.04'
  86. ( 1 secs ) test_pre_run.[trigger] vr_common_unittests
    Run on OS: 'Ubuntu-14.04'
  87. ( 1 secs ) test_pre_run.[trigger] vr_pixeltests
    Run on OS: 'Ubuntu-14.04'
  88. ( 980 ms ) test_pre_run.[trigger] webkit_unit_tests
    Run on OS: 'Ubuntu-14.04'
  89. ( 1 secs ) test_pre_run.[trigger] wm_unittests
    Run on OS: 'Ubuntu-14.04'
  90. ( 1 secs ) test_pre_run.[trigger] wtf_unittests
    Run on OS: 'Ubuntu-14.04'
  91. ( 1 secs ) accessibility_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  92. ( 4 mins 10 secs ) angle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:05:56.952220
  93. ( 1 secs ) app_shell_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  94. ( 1 secs ) aura_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 21s
  95. ( 3 secs ) base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:14.395990
  96. ( 1 secs ) battor_agent_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  97. ( 1 secs ) blink_common_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  98. ( 1 secs ) blink_fuzzer_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  99. ( 2 secs ) blink_platform_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 31s
  100. ( 1 secs ) boringssl_crypto_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 47s
  101. ( 1 secs ) boringssl_ssl_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  102. ( 1 secs ) cacheinvalidation_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  103. ( 1 secs ) capture_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  104. ( 1 secs ) cast_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  105. ( 3 secs ) cc_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:33.716190
  106. ( 1 secs ) chrome_app_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  107. ( 1 secs ) chromedriver_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  108. ( 1 secs ) components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:16.350750
  109. ( 2 mins 19 secs ) components_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:09:13.462220
  110. ( 1 secs ) compositor_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 20s
  111. ( 4 mins 4 secs ) content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:13:43.023710 (shard #1)
    Min shard duration: 0:12:22.852970 (shard #4)
  112. ( 3 secs ) viz_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:10:10.438660 (shard #0)
    Min shard duration: 0:08:05.108910 (shard #4)
  113. ( 5 secs ) content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:32.184410
  114. ( 5 secs ) viz_content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:04:06.991690
  115. ( 1 secs ) cronet_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  116. ( 1 secs ) cronet_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  117. ( 1 secs ) crypto_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  118. ( 1 secs ) dbus_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 16s
  119. ( 1 secs ) device_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  120. ( 1 secs ) display_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  121. ( 1 secs ) events_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  122. ( 1 secs ) extensions_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:51.573780
  123. ( 1 secs ) extensions_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:10.869140
  124. ( 1 secs ) filesystem_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 19s
  125. ( 1 secs ) gcm_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  126. ( 3 secs ) gfx_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:07.830340
  127. ( 1 secs ) gin_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  128. ( 1 secs ) gl_tests on NVIDIA GPU on Linux on Ubuntu
    Run on OS: 'Ubuntu'
    Shard duration: 0:01:22.083480
  129. ( 1 secs ) gl_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  130. ( 1 secs ) google_apis_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  131. ( 4 secs ) gpu_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 58s
  132. ( 1 secs ) headless_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  133. ( 2 secs ) interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:10:48.867070 (shard #3)
    Min shard duration: 0:06:15.542190 (shard #0)
  134. ( 1 secs ) ipc_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  135. ( 1 secs ) jingle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  136. ( 1 secs ) latency_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  137. ( 1 secs ) leveldb_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  138. ( 1 secs ) libjingle_xmpp_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 16s
  139. ( 1 secs ) media_blink_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 27s
  140. ( 1 secs ) media_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 19s
  141. ( 4 secs ) media_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:48.935100
  142. ( 1 secs ) message_center_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  143. ( 1 secs ) midi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  144. ( 1 secs ) mojo_core_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  145. ( 1 secs ) mojo_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 24s
  146. ( 1 secs ) native_theme_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  147. ( 19 secs ) net_unittests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:08:56.173020 (shard #0)
    Min shard duration: 0:07:35.927280 (shard #1)
  148. ( 1 secs ) pdf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  149. ( 1 secs ) ppapi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  150. ( 1 secs ) printing_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  151. ( 4 secs ) remoting_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 25s
  152. ( 1 secs ) sandbox_linux_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  153. ( 1 secs ) service_manager_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 25s
  154. ( 3 secs ) services_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:52.763390
  155. ( 1 secs ) shell_dialogs_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  156. ( 1 secs ) skia_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  157. ( 1 secs ) snapshot_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:02.741120
  158. ( 1 secs ) sql_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  159. ( 1 secs ) storage_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  160. ( 1 secs ) traffic_annotation_auditor_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 16s
  161. ( 1 secs ) ui_base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  162. ( 1 secs ) ui_touch_selection_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  163. ( 5 secs ) unit_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:04:22.451780 (shard #1)
    Min shard duration: 0:03:36.463320 (shard #0)
  164. ( 1 secs ) url_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  165. ( 4 secs ) views_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 39s
  166. ( 2 secs ) viz_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:05:24.017040
  167. ( 1 secs ) vr_common_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  168. ( 1 secs ) vr_pixeltests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  169. ( 4 secs ) webkit_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:06:04.272710
  170. ( 1 secs ) wm_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  171. ( 1 secs ) wtf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  172. ( 977 ms ) Tests statistics
     
    Stats
    Total shards: 100
    Total runtime: 4:33:33.410999
     
  173. ( 3 ms ) recipe result

Build Properties:

NameValueSource
$build/goma {"jobs": 500} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm323-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531429069645740, "id": "8941173947826308704", "project": "chromium", "tags": ["builder:Linux TSan Tests", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/9b78521765f33993e81dfba771127fe9d5eb4add", "gitiles_ref:refs/heads/master", "parent_buildername:Linux TSan Builder", "parent_buildnumber:30227", "scheduler_invocation_id:9106604010028139504", "scheduler_job_id:chromium/Linux TSan Tests", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Linux TSan Tests" setup_build
buildnumber 23673 setup_build
mastername "chromium.memory" setup_build
parent_buildername "Linux TSan Builder" setup_build
parent_got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" setup_build
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" setup_build
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" setup_build
parent_got_revision "9b78521765f33993e81dfba771127fe9d5eb4add" setup_build
parent_got_revision_cp "refs/heads/master@{#574700}" setup_build
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" setup_build
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" setup_build
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" setup_build
parent_got_webrtc_revision "895617fa9bc36c240b37d47402cdb341ecadf994" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#23955}" setup_build
parent_mastername "chromium.memory" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "9b78521765f33993e81dfba771127fe9d5eb4add" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "9b78521765f33993e81dfba771127fe9d5eb4add" bot_update
got_revision_cp "refs/heads/master@{#574700}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "895617fa9bc36c240b37d47402cdb341ecadf994" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23955}" bot_update
swarm_hashes {"accessibility_unittests": "5dc765554b461e551d7443ea03c1ad031891a365", "angle_unittests": "ad0fd45af901ea3c7ec75fcdf22a2279087c5156", "app_shell_unittests": "c937096c794a676e6f4ca648301872c3e0af3cf9", "aura_unittests": "a4358a9df86c97e12477974cf42cc3fbbc3307ca", "base_unittests": "9414f519491ce0b7b8a22c31690fc448fab32e0a", "battor_agent_unittests": "061cd80a7d7f7c428ec8690e8227976875a2f8ce", "blink_common_unittests": "ef2e6744522383b5ae60a9135b4029397cb189d7", "blink_fuzzer_unittests": "f360eb695e4fc3058db1d07372e98a79aea0858f", "blink_platform_unittests": "9f36fec30bca1e248ade88e0553498f5b70581c6", "boringssl_crypto_tests": "b11071c558f48d4f1449e96b35e241518cf89422", "boringssl_ssl_tests": "1e199892d5eb918521ef78ab3b9974d0aec9c12e", "cacheinvalidation_unittests": "fbc354f5c4822a0b2b21da8131df65763651e0d9", "capture_unittests": "6e76109301936114b8528a6410ce56ad4c659d78", "cast_unittests": "345fd0d0cc0e554488a3f1c189ac68d3d2ca1790", "cc_unittests": "9ad1068d7cd58f5a0d6914ce3125354c3cbe796e", "chrome_app_unittests": "43c6cf890b630200e7e3a70449b24a3bc6553f27", "chromedriver_unittests": "0fa8a2e080d2b8059548c1b9a884eaa26153fce8", "components_browsertests": "9032577a43efc28d6aa023678008e5d9ba7f1792", "components_unittests": "f11a81191845d813db3d7320e7560f951e6faadf", "compositor_unittests": "1c65be32490d0d72f8197419c64d660d590e95e5", "content_browsertests": "3b574c51588023c1ed2948257866bfc5d422209e", "content_unittests": "af8d1fac1670e10c1610a013efd9c0652c80febe", "cronet_tests": "417d09096d83372436b6cc20e1878dfef6175556", "cronet_unittests": "1579f369e979574faacdfa52532bef3386a7d0db", "crypto_unittests": "c6892779faa7a3638f7fd7b297682d1c8f0e564a", "dbus_unittests": "7b74b948ec309b6c0bf57ca3eedb4a4f1537b622", "device_unittests": "9bf812f3c13019c7f054c58e27ee72bc27942881", "display_unittests": "d4eb4aa0ace2724f4c4fae14c4fd564655b847fb", "events_unittests": "1a900dc34ff60940ac9a072c456b48c1d1e6ac65", "extensions_browsertests": "96ab9fbd9330e8c8f677daecc043c8a408de5eab", "extensions_unittests": "392d8609d7b358f563a94675f112a715b56c251a", "filesystem_service_unittests": "89739dbcab0a385c14b28db331e28fb1d17773b5", "gcm_unit_tests": "3fa62c45b96e82dbf15e67f9951e30e796e9abe4", "gfx_unittests": "8d4b424e9b0ec1f8f7d744d2a698c2d7a22282cf", "gin_unittests": "e64a1a66678ae441d99005c8d2b2663f4f7ff495", "gl_tests": "e8c2a3649b943c17e6374539aa7458c0f371406c", "gl_unittests": "ae43a2e95914a52558f6d6a777d752a872b5835c", "google_apis_unittests": "83c684f14b4aa4e47a283db4882e566f645443f9", "gpu_unittests": "2d102ede0c985b178978080d2055d2fc15d37f32", "headless_unittests": "9ee659c5a25e5ff3792d632825deaf17a7c2dc90", "interactive_ui_tests": "ec5d74f6e0d4089b1718cd0f1aa2dc84fc88f8cd", "ipc_tests": "d4b7580dfb43b96bf8f60da41118ea480bca7ccf", "jingle_unittests": "b4fbf475e26b96dac1e4ad749cc1235f7077f2b8", "latency_unittests": "e91813cb208996e05a74d82fd4560d1ee980fb84", "leveldb_service_unittests": "6b0a5ec6b30f7eee4826f3cb0651ff136da03edf", "libjingle_xmpp_unittests": "4ae0acdb1dcbb803f43350e025ad97d688f70928", "media_blink_unittests": "1f1d24be487de756075d31ea4001c8bce14b8924", "media_service_unittests": "5653170f483a0aaf54b0fa9c33363ecb01c13e16", "media_unittests": "b2566677c1d0afa02e215ed2b600b99e2ba2d29d", "message_center_unittests": "a2294df70aeef44497ac408f5e98099e2869493f", "midi_unittests": "7b241355169a01d81b4ec5b345d8afa665b24ed9", "mojo_core_unittests": "3884aa40137509efcd6e581eb56a14d111160f5e", "mojo_unittests": "0ed09fa51692a4d046081420c1e23389872439ab", "native_theme_unittests": "4c9e70521e79dac1a833343764abdaec12151094", "net_unittests": "1664a259859013dae6e3d4a6031089a66593be96", "pdf_unittests": "8dd934c286d2305320d585d0bae7ef04bfd21578", "ppapi_unittests": "c10a77653f99ec214b8da693794437ad2b6fea12", "printing_unittests": "74d1b9bf8762d43152c6ce7f66aa09058c916e7e", "remoting_unittests": "11ff77c6970ede2b48f089cf7312c130d030d8b4", "sandbox_linux_unittests": "a030aed0445261ac3014d6a041671037a651d73e", "service_manager_unittests": "a36ac7d254b07593d61c281426864b8bf6019331", "services_unittests": "bbd516c410dd6650a4b1ba2cd2768b9cf08a8c55", "shell_dialogs_unittests": "22581fb270507a0a8ee58d90a9b16cff84890227", "skia_unittests": "cf7b347ce0ef186c89cdb135f42fd8c39394f83d", "snapshot_unittests": "f07836f99e39fb1ad4d50ba4aa2d65f2155032e5", "sql_unittests": "de1980274c1db01d33e78cb4c16aa18764d05e7d", "storage_unittests": "cf076292f00de71c8856b087707cd03bb272d939", "traffic_annotation_auditor_unittests": "213002ae8f5641596bd82ab822cbf071ac517411", "ui_base_unittests": "00ff09b26e74815c25d9b42e920c9b3d41c0fc42", "ui_touch_selection_unittests": "c312c7c2148b1b152e7bb8b1b32717d7aae64017", "unit_tests": "7709270b5144b538ee9a41a539b987a743ab2467", "url_unittests": "d8c1286d498bc5b545b04c1d1e1adc9804c60552", "views_unittests": "35bf417ff03fdc972dac2850335420de02f4d5e0", "viz_unittests": "cde6deac0f4111205d537de75cd476a31816edbd", "vr_common_unittests": "5272679bd9a48a63868e8ece76f97dccb6badc43", "vr_pixeltests": "68ce97a53ad40fe7e1bd24c5cbed136be7861623", "webkit_unit_tests": "214425a27b17733d1499d8f72058ea7d72fb31c1", "wm_unittests": "f06efc3ad4691978b0bf3e3f06a348295878ca9c", "wtf_unittests": "79b4fd15c964e5d5b24f88de67758813799fd42d"} find isolated tests

Blamelist:

  1. Robbie McElrath (rmcelrathohnoyoudont@chromium.org)
  2. erikchen (erikchenohnoyoudont@chromium.org)
  3. Moe Ahmadi (mahmadiohnoyoudont@chromium.org)
  4. Martin Kreichgauer (martinkrohnoyoudont@google.com)
  5. webrtc-chromium-autoroll (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  6. Nick Burris (nburrisohnoyoudont@google.com)
  7. Greg Kraynov (kraynovohnoyoudont@chromium.org)
  8. spqchan (spqchanohnoyoudont@chromium.org)
  9. Ben Pastene (bpasteneohnoyoudont@chromium.org)
  10. Andrey Lushnikov (lushnikovohnoyoudont@chromium.org)
  11. Thomas Guilbert (tguilbertohnoyoudont@chromium.org)
  12. Nektarios Paisios (nektarohnoyoudont@chromium.org)
  13. Amirhossein Simjour (asimjourohnoyoudont@chromium.org)
  14. Ryan Daum (rdaumohnoyoudont@chromium.org)
  15. Danyao Wang (danyaoohnoyoudont@chromium.org)
  16. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  17. Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
  18. erikchen (erikchenohnoyoudont@chromium.org)
  19. Esmael El-Moslimany (aeeohnoyoudont@chromium.org)
  20. Wez (wezohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 20:57:49 UTC
Start Thursday, 12-Jul-18 20:57:54 UTC
End Thursday, 12-Jul-18 21:23:43 UTC
Pending 5 secs
Execution 25 mins 48 secs

All Changes:

  1. Migrate PrivetTrafficDetector to use NetworkConnectionTracker.

    Changed by Robbie McElrath - rmcelrathohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:20:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9b78521765f33993e81dfba771127fe9d5eb4add

    Comments

    Migrate PrivetTrafficDetector to use NetworkConnectionTracker.
    
    This migrates PrivetTrafficDetector from using
    net::NetworkChangeNotifier to content::NetworkConnectionTracker, which
    works with the network service enabled.
    
    Bug: 859134
    Change-Id: I06f2ecbe142bbed9a8772f69ab109b0c0dc32581
    Reviewed-on: https://chromium-review.googlesource.com/1123681
    Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
    Reviewed-by: Lei Zhang <thestig@chromium.org>
    Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574700}

    Changed files

    • chrome/browser/printing/cloud_print/privet_traffic_detector.cc
    • chrome/browser/printing/cloud_print/privet_traffic_detector.h
  2. Remove assertion from DetachToOwnWindow on macOS 10.10.

    Changed by erikchen - erikchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:16:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b20bb048913985eae71b480db2a2017173ef73a2

    Comments

    Remove assertion from DetachToOwnWindow on macOS 10.10.
    
    On macOS 10.10, AppKit appears to use the test's generated events to
    asynchronously reactivate the first window. There's no way to tell when this
    asynchronous reactivation will happen, so just avoid checking the assertion in
    the test. This problem appears constrained to how we generate test events, and
    not to the actual behavior of Chrome.
    
    Bug: 862859
    Change-Id: Ibab56946bef3aea9aac3123d3d8aefdb7974d063
    Reviewed-on: https://chromium-review.googlesource.com/1135305
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574699}

    Changed files

    • chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
  3. Revert "[AF][IOS] Scan page for form changes when a field is focused"

    Changed by Moe Ahmadi - mahmadiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:13:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4b937d53836386e51532fbe870938b33ce0455ed

    Comments

    Revert "[AF][IOS] Scan page for form changes when a field is focused"
    
    This reverts commit 77318515062e22c6dbcb5b4ae8c6daa4ef70d5b9.
    
    Reason for revert:
    This change caused a regression (crbug.com/860225). The cause of the regression is that when user focuses a field in order to edit it, Autofill::OnFormsSeen is called which in turn updates the cached form with the new user entered values. Once submitted, form values are discarded as they're thought to be the initial form values on page load. In its current implementation Autofill::OnFormsSeen is only intended to be called on page load.
    
    Original change's description:
    > [AF][IOS] Scan page for form changes when a field is focused
    >
    > This CL fixes a regression caused by crrev.com/c/1012979. Previously,
    > AutofillAgent would scan the whole page on form activities due to the
    > possiblity of Autofill having been enabled after page load.
    > crrev.com/c/1012979 replaced that logic in favor of observing the Pref
    > directly. This has a side effect where previously hidden fields can go
    > unnoticed by AutofillManager. This CL fixes that regression by scanning the
    > page when a field is focused. All fields receive focuse before their value
    > is set by Autofill, therefore, AutofillManager can get notified of
    > previously hidden fields.
    >
    > Bug: 855696
    > Change-Id: I175bf90e12d1ca356b746e6347943a295063c288
    > Reviewed-on: https://chromium-review.googlesource.com/1112493
    > Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
    > Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#570713}
    
    TBR=olivierrobin@chromium.org,mahmadi@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 855696, 860225
    Change-Id: Icc39e67e6d502d75451dbec83d6271255639ee4c
    Reviewed-on: https://chromium-review.googlesource.com/1135671
    Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
    Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574698}

    Changed files

    • components/autofill/ios/browser/autofill_agent.mm
  4. device/fido/mac: integrate with browsing data deletion

    Changed by Martin Kreichgauer - martinkrohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 20:13:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d54b58e5b08b96664080795a01e0bd2373952e6e

    Comments

    device/fido/mac: integrate with browsing data deletion
    
    This updates browsing data deletion for DATA_TYPE_PASSWORDS to call
    device::fido::mac::DeleteWebAuthnCredentials, which deletes credentials
    created by the macOS platform authenticator from the OS keychain.
    
    Also combine the two Touch ID specific configuration methods in
    {Chrome,}AuthenticatorRequestDelegate and introduce a static variant for
    Chrome.
    
    Bug: 678128
    Change-Id: I0034e0815da068fb27c1ea60cad95f958956838e
    Reviewed-on: https://chromium-review.googlesource.com/1125177
    Commit-Queue: Martin Kreichgauer <martinkr@google.com>
    Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Christian Dullweber <dullweber@chromium.org>
    Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574697}

    Changed files

    • chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
    • chrome/browser/webauthn/chrome_authenticator_request_delegate.cc
    • chrome/browser/webauthn/chrome_authenticator_request_delegate.h
    • chrome/browser/webauthn/chrome_authenticator_request_delegate_unittest.cc
    • content/browser/webauth/authenticator_impl.cc
    • content/public/browser/authenticator_request_client_delegate.cc
    • content/public/browser/authenticator_request_client_delegate.h
    • device/fido/mac/authenticator.h
  5. Roll src/third_party/webrtc 798ee75d2365..895617fa9bc3 (3 commits)

    Changed by webrtc-chromium-autoroll - webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 20:12:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 460febcbc6e56f2355493a4f43188b08753c2dc6

    Comments

    Roll src/third_party/webrtc 798ee75d2365..895617fa9bc3 (3 commits)
    
    https://webrtc.googlesource.com/src.git/+log/798ee75d2365..895617fa9bc3
    
    
    git log 798ee75d2365..895617fa9bc3 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 buildbot@webrtc.org Roll chromium_revision efbdada3f7..f7c234b027 (574489:574598)
    2018-07-12 magjed@webrtc.org Android: Add helper functions for comparing H264 codecs
    2018-07-12 saza@webrtc.org Remove useless import of arm.gni
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@895617fa9bc3
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
    
    BUG=chromium:None,chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I07750ee2f3c028532fb0dfbfa0386eeeb119c8f8
    Reviewed-on: https://chromium-review.googlesource.com/1135612
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574696}

    Changed files

    • DEPS
  6. Chrome Cleanup UI: Extract GetLastUsedProfile call from scanner results

    Changed by Nick Burris - nburrisohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 20:11:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision feda02794921ad4eca0b4c5d15c21bc0461e73fa

    Comments

    Chrome Cleanup UI: Extract GetLastUsedProfile call from scanner results
    
    Chrome runs into a fatal error when the cleaner detects unwanted
    software. This is because ChromeCleanerScannerResults is created in the
    IO thread, and ProfileManager::GetLastUsedProfile requires the UI
    thread. The tests passed because they run a test browser process.
    
    - Extract extension name fetching to a separate function.
    - Call this function in tests so they're not affected.
    - Follow-up CL: Call this function once the scanner results are on the
    UI thread, before they're sent to the web UI.
    
    Bug: 853339
    Change-Id: I9cc2425f7b196e923a22b2afd1e8eee7fca61f5b
    Reviewed-on: https://chromium-review.googlesource.com/1135194
    Commit-Queue: Nick Burris <nburris@google.com>
    Reviewed-by: proberge <proberge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574695}

    Changed files

    • chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win_unittest.cc
    • chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win_unittest.cc
    • chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_scanner_results.cc
    • chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_scanner_results.h
  7. Remove components/viz/test dependency from blink platform.

    Changed by Greg Kraynov - kraynovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:07:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8a7df13b2932f8f83559de4c263c972e08f9301b

    Comments

    Remove components/viz/test dependency from blink platform.
    
    cc::OrderedSimpleTestTaskRunner isn't used there anymore.
    
    Bug: 841735
    Change-Id: I88a5bfa2ebaf01a08943396ce20f63c483a19b3a
    Reviewed-on: https://chromium-review.googlesource.com/1133177
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Commit-Queue: Greg Kraynov <kraynov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574694}

    Changed files

    • third_party/blink/renderer/platform/scheduler/BUILD.gn
    • third_party/blink/renderer/platform/scheduler/child/DEPS
    • third_party/blink/renderer/platform/scheduler/common/DEPS
    • third_party/blink/renderer/platform/scheduler/main_thread/DEPS
    • third_party/blink/renderer/platform/scheduler/renderer/DEPS
    • third_party/blink/renderer/platform/scheduler/worker/DEPS
    • third_party/blink/renderer/platform/testing/DEPS
  8. [Mac] Refactor BrowserWindowTouchBarMac

    Changed by spqchan - spqchanohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:05:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e95b7292bae44c8e6fb9af5801f102ae28587d6c

    Comments

    [Mac] Refactor BrowserWindowTouchBarMac
    
    Separate BrowserWindowTouchBarMac into two classes:
    BrowserWindowDefaultTouchBar and
    BrowserWindowTouchBarController.
    
    BrowserWindowTouchBarController determines what
    touch bar should be used for browser window.
    BrowserWindowDefaultTouchBar creates a default
    touch bar for the browser.
    
    These changes are split from a bigger change to
    hook up touch bar support for web textfield in
    MacViews:
    
    https://chromium-review.googlesource.com/c/chromium/src/+/1132597
    
    Bug: 856391
    Change-Id: I9be31c65bd0acc2ec4d39b5e2f6b06fc30e36bf7
    Reviewed-on: https://chromium-review.googlesource.com/1133705
    Commit-Queue: Sarah Chan <spqchan@chromium.org>
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574693}

    Changed files

    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/browser_window_touch_bar_mac.h
    • chrome/browser/ui/cocoa/browser_window_controller.h
    • chrome/browser/ui/cocoa/browser_window_controller.mm
    • chrome/browser/ui/cocoa/framed_browser_window.mm
    • chrome/browser/ui/cocoa/touchbar/browser_window_default_touch_bar.h
    • chrome/browser/ui/cocoa/touchbar/browser_window_default_touch_bar.mm
    • chrome/browser/ui/cocoa/touchbar/browser_window_default_touch_bar_unittest.mm
    • chrome/browser/ui/cocoa/touchbar/browser_window_touch_bar_controller.h
    • chrome/browser/ui/cocoa/touchbar/browser_window_touch_bar_controller.mm
    • chrome/browser/ui/cocoa/touchbar/browser_window_touch_bar_controller_browsertest.mm
    • chrome/browser/ui/views/frame/browser_frame_mac.mm
    • chrome/test/BUILD.gn
  9. milo: Add link to chromiumos tryserver to chromium's console.

    Changed by Ben Pastene - bpasteneohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:03:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6678ca5e07d42a16c0e63b123543672ab94c3c29

    Comments

    milo: Add link to chromiumos tryserver to chromium's console.
    
    And alphabetize the list.
    
    R=hinoka
    
    Change-Id: I28d7c354c153f848fae7098e57b67445345cb850
    Reviewed-on: https://chromium-review.googlesource.com/1135691
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    Commit-Queue: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574692}

    Changed files

    • infra/config/global/luci-milo.cfg
  10. Make content::PermissionManager a delegate of PermissionController

    Changed by Andrey Lushnikov - lushnikovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:02:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ebff0440cc1ada42a20446c0f6d9ddf0619f64df

    Comments

    Make content::PermissionManager a delegate of PermissionController
    
    One-pager describing this refactoring: https://goo.gl/24gkCb
    
    Today, `content/` layer provides `permission_manager.h` interface that
    is supposed to be implemented by embedders and simultaneously used
    as API in `content/` layer. This leaves us with no place in content/ layer
    where we can put DevTools instrumentation.
    
    This patch separates content API from embedder interface. With this
    patch, `content/` layer provides 2 interfaces:
    - content::PermissionController - content-level API to manage permissions
    - content::PermissionManager - interface to be implemented by
    embedders. This is a delegate for content::PermissionController.
    
    This design enables DevTools to handle and override content permissions through
    DevTools protocol. The functionality will be encapsulated in
    PermissionController class.
    
    There's exactly one PermissionController for each BrowserContext.
    If embedder doesn't implement PermissionManager, then
    PermissionController rejects all permission requests.
    
    In a follow-up:
    - rename `content::PermissionManager` into `content::PermissionControllerDelegate`.
    - rename `BrowserContext::GetPermissionManager()` into `BrowserContext::GetPermissionControllerDelegate()`.
    - rename `TestBrowserContext::SetPermissionManager()` into `TestBrowserContext::SetPermissionControllerDelegate()`.
    
    R=dgozman
    TBR=sdefresne, tobiasjs, slan, thakis
    BUG=631464
    
    Change-Id: I5f6f1ea5b28e284c462a5055d9b072f12f30ce19
    Reviewed-on: https://chromium-review.googlesource.com/1111340
    Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574691}

    Changed files

    • android_webview/browser/aw_permission_manager.cc
    • chrome/browser/net/reporting_permissions_checker.cc
    • chrome/browser/notifications/platform_notification_service_impl.cc
    • chrome/browser/permissions/permission_manager.cc
    • chromecast/browser/cast_permission_manager.cc
    • components/domain_reliability/service.cc
    • components/domain_reliability/service_unittest.cc
    • components/payments/content/installable_payment_app_crawler.cc
    • content/browser/BUILD.gn
    • content/browser/background_sync/background_sync_manager.cc
    • content/browser/browser_context.cc
    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/generic_sensor/sensor_provider_proxy_impl.cc
    • content/browser/generic_sensor/sensor_provider_proxy_impl.h
    • content/browser/geolocation/geolocation_service_impl.cc
    • content/browser/geolocation/geolocation_service_impl.h
    • content/browser/geolocation/geolocation_service_impl_unittest.cc
    • content/browser/notifications/blink_notification_service_impl.cc
    • content/browser/payments/payment_app_provider_impl.cc
    • content/browser/permissions/permission_controller_impl.cc
    • content/browser/permissions/permission_controller_impl.h
    • content/browser/permissions/permission_service_context.cc
    • content/browser/permissions/permission_service_impl.cc
    • content/browser/push_messaging/push_messaging_manager.cc
    • content/public/browser/BUILD.gn
    • content/public/browser/browser_context.h
    • content/public/browser/permission_controller.h
    • content/public/browser/permission_manager.h
    • content/public/test/mock_permission_manager.cc
    • content/shell/browser/layout_test/layout_test_permission_manager.cc
    • content/shell/browser/shell_permission_manager.cc
    • headless/lib/browser/headless_permission_manager.cc
  11. Move content::MediaController to media/base

    Changed by Thomas Guilbert - tguilbertohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:02:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2784a2c6630a8de538a7b2bf6d993823d321a489

    Comments

    Move content::MediaController to media/base
    
    The MediaController interface and the upcoming MediaStatusObserver do
    not have to live in content/public/browser. The media/base folder and
    the media namespace is a more generic place for them to live, even if
    most of the code that will use them lives in content.
    
    Bug: 820277
    Change-Id: I2f91cd88c6f5238723aae8aeff1c323c02f738d4
    Reviewed-on: https://chromium-review.googlesource.com/1134090
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574690}

    Changed files

    • chrome/browser/media/android/remote/media_controller_bridge.h
    • chrome/browser/media/android/router/media_router_android.cc
    • chrome/browser/media/android/router/media_router_android.h
    • chrome/browser/media/android/router/media_router_android_bridge.cc
    • chrome/browser/media/android/router/media_router_android_bridge.h
    • chrome/browser/media/router/media_router.h
    • chrome/browser/media/router/media_router_base.cc
    • chrome/browser/media/router/media_router_base.h
    • chrome/browser/media/router/presentation/presentation_service_delegate_impl.cc
    • chrome/browser/media/router/presentation/presentation_service_delegate_impl.h
    • content/browser/media/flinging_renderer.cc
    • content/browser/media/flinging_renderer.h
    • content/browser/media/flinging_renderer_unittest.cc
    • content/browser/presentation/presentation_service_impl_unittest.cc
    • content/public/browser/BUILD.gn
    • content/public/browser/presentation_service_delegate.h
    • media/base/BUILD.gn
    • media/base/media_controller.h
  12. Improved performance of AXPosition::operator less than

    Changed by Nektarios Paisios - nektarohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:01:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision adeaf13d9c8651fcf83c9e5a6a7d1173f1eb27e1

    Comments

    Improved performance of AXPosition::operator less than
    
    Only move up or down the tree using text equivalent positions (by calling CreateParentPosition and AsLeafTextPosition) when we absolutely need to.
    R=dmazzoni@chromium.org
    
    Tested: VoiceOver on Mac by navigating in Gmail and checking how many times you hear "Busy"
    Change-Id: Id9469e52ef87b8b8a0c6c5fac5325abec415382d
    Bug: 861567
    Reviewed-on: https://chromium-review.googlesource.com/1133334
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Nektarios Paisios <nektar@chromium.org>
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574689}

    Changed files

    • ui/accessibility/ax_node_position_unittest.cc
    • ui/accessibility/ax_position.h
  13. VR: fix autofill popup size

    Changed by Amirhossein Simjour - asimjourohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:01:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9d07f06bb5c43657ce38efc57039e36287eac2a6

    Comments

    VR: fix autofill popup size
    
    Break SetAlertDialogSize into to methods. One to set the relative
    size to the main content, another one to set the absolute size.
    Also added comment to hosted_platform_ui to clarify the size of
    the rectangle in the model.
    
    Bug: 863071
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Ie102fcb00865d66052e4bb3c7817831fdcfe5dfa
    Reviewed-on: https://chromium-review.googlesource.com/1132140
    Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
    Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574688}

    Changed files

    • chrome/browser/android/vr/vr_shell_gl.cc
    • chrome/browser/vr/model/hosted_platform_ui.h
    • chrome/browser/vr/ui.cc
    • chrome/browser/vr/ui.h
  14. [chromecast] Support for top-down drag gesture.

    Changed by Ryan Daum - rdaumohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:00:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7281e2b2ea7ce739c6106b6005a2d58a9eedb86a

    Comments

    [chromecast] Support for top-down drag gesture.
    
    Bug: internal b/111304882
    Test: unit test and manual
    Change-Id: Iab32b58098a02eb054faeb94625e312d274cdae1
    Reviewed-on: https://chromium-review.googlesource.com/1135692
    Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
    Commit-Queue: Alex Sakhartchouk <alexst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574687}

    Changed files

    • chromecast/browser/cast_content_window.h
    • chromecast/browser/cast_gesture_dispatcher.cc
    • chromecast/browser/cast_gesture_dispatcher.h
    • chromecast/browser/cast_gesture_dispatcher_test.cc
  15. [Nav Experiment] Parameterize HistoryStateOperationsTest.

    Changed by Danyao Wang - danyaoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:57:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 32bdecc1fac228cf335811bea0f31e2a29153f29

    Comments

    [Nav Experiment] Parameterize HistoryStateOperationsTest.
    
    So both LegacyNavigationManager and WKBasedNavigationManager can be
    tested on trybots.
    
    Fixed test expectation for StateReplacementBackForward to match the
    behavior of WebKit (and Safari on other platforms).
    
    Bug: 862724
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ic01dcabf2e6ef6903d8f8ee348798951007660cc
    Reviewed-on: https://chromium-review.googlesource.com/1134472
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574686}

    Changed files

    • ios/web/navigation/history_state_operations_inttest.mm
  16. Network quality servicification of RTT and downlink estimates

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:56:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 88c8cc52351f93d11e0bfac3b75ded5b420b131b

    Comments

    Network quality servicification of RTT and downlink estimates
    
    Send the RTT and downlink estimates over the mojo channel
    to the browser process. The RTT and downlink estimates are
    sent over an existing mojo message which carrier the current
    effective connection type estimate.
    
    The mojo message is sent only if there is a significant change
    in the values of either the RTT or the downlink estimate.
    
    In the next CL, I will move the network quality consumers
    in the browser process over to NetworkQualityTracker.
    
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I01bbc7af2e7e3cf41f69e7ac19f8edd9ec59de90
    Bug: 819244
    Reviewed-on: https://chromium-review.googlesource.com/1130233
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Helen Li <xunjieli@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574685}

    Changed files

    • chrome/browser/net/network_quality_tracker_browsertest.cc
    • services/network/network_quality_estimator_manager.cc
    • services/network/network_quality_estimator_manager.h
    • services/network/network_quality_estimator_manager_unittest.cc
    • services/network/public/cpp/network_quality_tracker.cc
    • services/network/public/cpp/network_quality_tracker.h
    • services/network/public/cpp/network_quality_tracker_unittest.cc
    • services/network/public/mojom/network_quality_estimator_manager.mojom
  17. [Fuchsia] Remove package detection in base::PathProviderFuchsia()

    Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:48:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4f9d9e774d5d41a5d8073b156348eee4bde25753

    Comments

    [Fuchsia] Remove package detection in base::PathProviderFuchsia()
    
    Previously PathProvider was trying to detect if it's packaged or not.
    That logic is no longer needed because we can assume that all binaries
    produced in chromium are packaged.
    
    Change-Id: I963afac5342d44b8d8188c07ffb927d6b4fac271
    Reviewed-on: https://chromium-review.googlesource.com/1134586
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574684}

    Changed files

    • base/base_paths_fuchsia.cc
  18. Add high water mark in background profiling triggers for memlog.

    Changed by erikchen - erikchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:47:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3483cb3aa6a9343b22e8ec39e81cb2fc864970a3

    Comments

    Add high water mark in background profiling triggers for memlog.
    
    Previously, a memlog report would be uploaded if a fixed threshold was exceeded.
    After that point, the timer frequency would be reduced to prevent too many
    reports from being uploaded.
    
    In this CL, we use a fixed, higher frequency timer to check memory usage. We
    upload an initial report if the fixed thresholds are exceeded, and then upload
    more reports each time the high water mark is exceeded by a significant amount.
    This allows us to catch higher-velocity memory leaks, that might otherwise cause
    the process to be killed before a report would be uploaded with the previous
    mechanism.
    
    Change-Id: I706314810d962c51e4126157363f44ce64868721
    Reviewed-on: https://chromium-review.googlesource.com/1132099
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Reviewed-by: Siddhartha S <ssid@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574683}

    Changed files

    • chrome/browser/profiling_host/background_profiling_triggers.cc
    • chrome/browser/profiling_host/background_profiling_triggers.h
    • chrome/browser/profiling_host/background_profiling_triggers_unittest.cc
  19. WebUI: update text to use primary/secondary colors for style refresh

    Changed by Esmael El-Moslimany - aeeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:47:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0ceaa55ab4070c9fc1bce4a599d62362576b1322

    Comments

    WebUI: update text to use primary/secondary colors for style refresh
    
    Bug: 849857
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ia64cd1565af8f50a4af8b5c08f82d9a13df00acf
    Reviewed-on: https://chromium-review.googlesource.com/1133959
    Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574682}

    Changed files

    • chrome/browser/resources/md_downloads/item.html
    • chrome/browser/resources/md_extensions/detail_view.html
    • chrome/browser/resources/md_extensions/error_page.html
    • chrome/browser/resources/md_extensions/manager.html
    • chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
    • chrome/browser/resources/settings/device_page/storage.html
    • chrome/browser/resources/settings/internet_page/network_summary_item.html
    • chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
    • chrome/browser/resources/settings/people_page/setup_pin_dialog.html
    • chrome/browser/resources/settings/settings_page/settings_subpage_search.html
    • chrome/browser/resources/settings/settings_shared_css.html
    • chrome/browser/resources/settings/site_settings/zoom_levels.html
    • ui/webui/resources/cr_elements/chromeos/network/cr_network_list_item.html
    • ui/webui/resources/cr_elements/paper_tabs_style_css.html
  20. Fix race-condition in SchedulerSingleThreadTaskRunnerManager::Start().

    Changed by Wez - wezohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:42:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 291f0a739f2c952d402f76d3750b9a2340269c18

    Comments

    Fix race-condition in SchedulerSingleThreadTaskRunnerManager::Start().
    
    SchedulerSingleThreadTaskRunnerManager allows SingleThreadTaskRunners to
    be created and tasks posted to them before the worker threads are
    actually started. The call to Start() the required workers was calling
    both Start() and WakeUp() on each of them, the latter being unnecessary
    since if a worker needs to process work then it must already have been
    woken, when the work was PostTask()d into it.
    
    Besides removing an unnecessary wake-up, this resolves a subtle race-
    condition between wake-up and a potential worker clean-up (see bug).
    
    Bug: 862582
    Change-Id: I9c4246cec4b1bda6d728e5e1656bb2c5ca7c0f0a
    Reviewed-on: https://chromium-review.googlesource.com/1133279
    Commit-Queue: Wez <wez@chromium.org>
    Reviewed-by: Robert Liao <robliao@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574681}

    Changed files

    • base/task_scheduler/scheduler_single_thread_task_runner_manager.cc