Home | Search | chromium - Builders
Login

Builder Linux FYI dEQP Release (Intel HD 630) Build 30450 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision9b00f3499c1dc74c8e0419384a69f041ebcd2442
Got Revision9b00f3499c1dc74c8e0419384a69f041ebcd2442

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. Thomas Tangl (tangltomohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 10:06:35 UTC
Start Friday, 12-Oct-18 10:06:40 UTC
End Friday, 12-Oct-18 10:08:41 UTC
Pending 5 secs
Execution 2 mins

All Changes:

  1. Fix radio button bug on sync_page.html

    Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:04:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9b00f3499c1dc74c8e0419384a69f041ebcd2442

    Comments

    Fix radio button bug on sync_page.html
    
    The second radio button in the passphrase section
    was not visibly checked on selection.
    
    To solve this, move the spans containing the conditional
    strings inside one radio-button, instead off having two
    conditional radio buttons.
    
    Additional change:
     - Remove aria-label attribute because the visible text
       is used automatically as radio button title.
    
    Bug: 894385
    Change-Id: Ie339def905ca976444880166552ba580068b9271
    Reviewed-on: https://chromium-review.googlesource.com/c/1276645
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599157}

    Changed files

    • chrome/browser/resources/settings/people_page/sync_page.html